fixes length and thumbnail properties

pytube/__main__.py

@@ -252,7 +252,17 @@ class YouTube(object):
         :rtype: str
 
         """
-        return self.player_config_args["thumbnail_url"]
+        player_response = self.player_config_args.get("player_response", {})
+        thumbnail_details = (
+            player_response.get("videoDetails", {})
+            .get("thumbnail", {})
+            .get("thumbnails")
+        )
+        if thumbnail_details:
+            thumbnail_details = thumbnail_details[-1]  # last item has max size
+            return thumbnail_details["url"]
+
+        return "https://img.youtube.com/vi/" + self.video_id + "/maxresdefault.jpg"
 
     @property
     def title(self) -> str:
@@ -273,10 +283,10 @@ class YouTube(object):
         return self.vid_descr
 
     @property
-    def rating(self):
+    def rating(self) -> float:
         """Get the video average rating.
 
-        :rtype: str
+        :rtype: float
 
         """
         return (
@@ -286,16 +296,18 @@ class YouTube(object):
         )
 
     @property
-    def length(self):
+    def length(self) -> str:
         """Get the video length in seconds.
 
         :rtype: str
 
         """
-        return self.player_config_args["length_seconds"]
+        return self.player_config_args["player_response"]["videoDetails"][
+            "lengthSeconds"
+        ]
 
     @property
-    def views(self):
+    def views(self) -> str:
         """Get the number of the times the video has been viewed.
 
         :rtype: str

pytube/helpers.py

@@ -135,7 +135,7 @@ def safe_filename(s: str, max_length: int = 255) -> str:
     return filename[:max_length].rsplit(" ", 0)[0]
 
 
-def create_logger(level:int = logging.ERROR) -> logging.Logger:
+def create_logger(level: int = logging.ERROR) -> logging.Logger:
     """Create a configured instance of logger.
 
     :param int level:

pytube/query.py

@@ -167,7 +167,7 @@ class StreamQuery:
         return StreamQuery(fmt_streams)
 
     def order_by(self, attribute_name: str) -> "StreamQuery":
-        """Apply a sort order to a resultset. Implicitly Filters out stream the do not have the attribute.
+        """Apply a sort order to a resultset. Filters out stream the do not have the attribute.
 
         :param str attribute_name:
             The name of the attribute to sort by.
@@ -195,10 +195,10 @@ class StreamQuery:
 
         # lookup integer values if we have them
         if integer_attr_repr is not None:
-            return StreamQuery(  # mypy: ignore
+            return StreamQuery(
                 sorted(
                     has_attribute,
-                    key=lambda s: integer_attr_repr[getattr(s, attribute_name)],  # type: ignore
+                    key=lambda s: integer_attr_repr[getattr(s, attribute_name)],  # type: ignore  # noqa: E501
                 )
             )
         else:

pytube/streams.py

@@ -12,7 +12,7 @@ import io
 import logging
 import os
 import pprint
-from typing import Dict, Tuple, Optional
+from typing import Dict, Tuple, Optional, List
 
 from pytube import extract
 from pytube import request
@@ -42,18 +42,21 @@ class Stream(object):
         # (Borg pattern).
         self._monostate = monostate
 
+        self.url = stream["url"]  # signed download url
+        self.itag = int(stream["itag"])  # stream format id (youtube nomenclature)
+        self.type = stream[
+            "type"
+        ]  # the part of the mime before the slash, overwritten later
+
         self.abr = None  # average bitrate (audio streams only)
         self.fps = None  # frames per second (video streams only)
-        self.itag = None  # stream format id (youtube nomenclature)
         self.res = None  # resolution (e.g.: 480p, 720p, 1080p)
-        self.url = None  # signed download url
 
         self._filesize: Optional[int] = None  # filesize in bytes
         self.mime_type = None  # content identifier (e.g.: video/mp4)
-        self.type = None  # the part of the mime before the slash
         self.subtype = None  # the part of the mime after the slash
 
-        self.codecs = []  # audio/video encoders (e.g.: vp8, mp4a)
+        self.codecs: List[str] = []  # audio/video encoders (e.g.: vp8, mp4a)
         self.audio_codec = None  # audio codec of the stream (e.g.: vorbis)
         self.video_codec = None  # video codec of the stream (e.g.: vp8)
 
@@ -63,7 +66,7 @@ class Stream(object):
 
         # Additional information about the stream format, such as resolution,
         # frame rate, and whether the stream is live (HLS) or 3D.
-        self.fmt_profile = get_format_profile(self.itag)
+        self.fmt_profile: Dict = get_format_profile(self.itag)
 
         # Same as above, except for the format profile attributes.
         self.set_attributes_from_dict(self.fmt_profile)

tests/test_cli.py

@@ -10,4 +10,4 @@ def test_download(MockYouTube, mock_sys):
     instance = MockYouTube.return_value
     instance.prefetch_descramble.return_value = None
     instance.streams = mock.Mock()
-    cli.download("asdf", "asdf")
+    cli.download("asdf", 123)