added tests

pytube/helpers.py

@@ -138,7 +138,7 @@ def deprecated(reason: str) -> Callable:
     return decorator
 
 
-def target_directory(output_path: Optional[str]) -> str:
+def target_directory(output_path: Optional[str] = None) -> str:
     """
     Function for determining target directory of a download.
     Returns an absolute path (if relative one given) or the current

pytube/query.py

@@ -284,7 +284,7 @@ class StreamQuery:
         """
         return self.filter(progressive=True).order_by("resolution").asc().last()
 
-    def get_audio_only(self, codec: str = "mp4") -> Optional[Stream]:
+    def get_audio_only(self, subtype: str = "mp4") -> Optional[Stream]:
         """Get highest bitrate audio stream for given codec (defaults to mp4)
 
         :param str codec:
@@ -296,8 +296,8 @@ class StreamQuery:
 
         """
         return (
-            self.filter(only_audio=True, audio_codec=codec)
-            .order_by("resolution")
+            self.filter(only_audio=True, subtype=subtype)
+            .order_by("abr")
             .asc()
             .last()
         )

tests/contrib/test_playlist.py

@@ -95,3 +95,12 @@ def test_videos(youtube, request_get, playlist_html):
     playlist._find_load_more_url = MagicMock(return_value=None)
     request_get.assert_called()
     assert len(list(playlist.videos)) == 12
+
+
+@mock.patch("pytube.contrib.playlist.request.get")
+@mock.patch("pytube.contrib.playlist.install_proxy", return_value=None)
+def test_proxy(install_proxy, request_get):
+    url = "https://www.fakeurl.com/playlist?list=whatever"
+    request_get.return_value = ""
+    Playlist(url, proxies={"http": "things"})
+    install_proxy.assert_called_with({"http": "things"})

tests/test_helpers.py

@@ -1,11 +1,12 @@
 # -*- coding: utf-8 -*-
 from unittest import mock
+from unittest.mock import MagicMock
 
 import pytest
 
 from pytube import helpers
 from pytube.exceptions import RegexMatchError
-from pytube.helpers import deprecated, cache
+from pytube.helpers import deprecated, cache, target_directory
 
 
 def test_regex_search_no_match():
@@ -52,3 +53,25 @@ def test_cache():
     cached_func("bye")
 
     assert call_count == 2
+
+
+@mock.patch("os.path.isabs", return_value=False)
+@mock.patch("os.getcwd", return_value="/cwd")
+@mock.patch("os.makedirs")
+def test_target_directory_with_relative_path(_, __, makedirs):
+    assert target_directory("test") == "/cwd/test"
+    makedirs.assert_called()
+
+
+@mock.patch("os.path.isabs", return_value=True)
+@mock.patch("os.makedirs")
+def test_target_directory_with_absolute_path(_, makedirs):
+    assert target_directory("/test") == "/test"
+    makedirs.assert_called()
+
+
+@mock.patch("os.getcwd", return_value="/cwd")
+@mock.patch("os.makedirs")
+def test_target_directory_with_no_path(_, makedirs):
+    assert target_directory() == "/cwd"
+    makedirs.assert_called()

tests/test_query.py

@@ -154,3 +154,11 @@ def test_filter_is_dash(cipher_signature):
     streams = cipher_signature.streams.filter(is_dash=False).all()
     itags = [s.itag for s in streams]
     assert itags == [18, 398, 397, 396, 395, 394]
+
+
+def test_get_audio_only(cipher_signature):
+    assert cipher_signature.streams.get_audio_only().itag == 140
+
+
+def test_get_audio_only_with_subtype(cipher_signature):
+    assert cipher_signature.streams.get_audio_only(subtype="webm").itag == 251