Fixed lint violations

pytube/__main__.py

@@ -119,17 +119,16 @@ class YouTube(object):
 
             # Fix for KeyError: 'title' issue #434
             if 'title' not in self.player_config_args:
-            	try:
-            		from bs4 import BeautifulSoup
-            		soup = BeautifulSoup(self.watch_html, 'lxml')
-            		title = soup.title.get_text().strip()
-            	except ModuleNotFoundError:
-            		i_start = self.watch_html.lower().index('<title>') + len('<title>')
-            		i_end = self.watch_html.lower().index('</title>')
-            		title = self.watch_html[i_start:i_end].strip()
-            	index = title.lower().rfind(' - youtube')
-            	title = title[:index] if index > 0 else title
-            	self.player_config_args['title'] = title
+                i_start = (
+                    self.watch_html
+                    .lower()
+                    .index('<title>') + len('<title>')
+                )
+                i_end = self.watch_html.lower().index('</title>')
+                title = self.watch_html[i_start:i_end].strip()
+                index = title.lower().rfind(' - youtube')
+                title = title[:index] if index > 0 else title
+                self.player_config_args['title'] = title
 
         self.vid_descr = extract.get_vid_descr(self.watch_html)
         # https://github.com/nficano/pytube/issues/165

pytube/cipher.py

@@ -36,21 +36,20 @@ def get_initial_function_name(js):
     """
     # c&&d.set("signature", EE(c));
 
-    #403 Forbidden fix.
     pattern = [
-        r'\b[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'\b[a-zA-Z0-9]+\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'(?P<sig>[a-zA-Z0-9$]+)\s*=\s*function\(\s*a\s*\)\s*{\s*a\s*=\s*a\.split\(\s*""\s*\)',
+        r'\b[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'\b[a-zA-Z0-9]+\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'(?P<sig>[a-zA-Z0-9$]+)\s*=\s*function\(\s*a\s*\)\s*{\s*a\s*=\s*a\.split\(\s*""\s*\)',  # noqa: E501
         r'(["\'])signature\1\s*,\s*(?P<sig>[a-zA-Z0-9$]+)\(',
         r'\.sig\|\|(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'yt\.akamaized\.net/\)\s*\|\|\s*.*?\s*[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*(?:encodeURIComponent\s*\()?\s*(?P<si$',
-        r'\b[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'\b[a-zA-Z0-9]+\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'\bc\s*&&\s*a\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'\bc\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',
-        r'\bc\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\('
+        r'yt\.akamaized\.net/\)\s*\|\|\s*.*?\s*[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*(?:encodeURIComponent\s*\()?\s*(?P<si$',  # noqa: E501
+        r'\b[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'\b[a-zA-Z0-9]+\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'\bc\s*&&\s*a\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'\bc\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
+        r'\bc\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*\([^)]*\)\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(',  # noqa: E501
     ]
-    
+
     logger.debug('finding initial function name')
     return regex_search(pattern, js, group=1)
 

pytube/contrib/playlist.py

@@ -180,13 +180,13 @@ class Playlist(object):
         try:
             url = self.construct_playlist_url()
             req = request.get(url)
-            open_tag = "<title>"
-            end_tag = "</title>"
-            matchresult = re.compile(open_tag + "(.+?)" + end_tag)
+            open_tag = '<title>'
+            end_tag = '</title>'
+            matchresult = re.compile(open_tag + '(.+?)' + end_tag)
             matchresult = matchresult.search(req).group()
-            matchresult = matchresult.replace(open_tag, "")
-            matchresult = matchresult.replace(end_tag, "")
-            matchresult = matchresult.replace("- YouTube", "")
+            matchresult = matchresult.replace(open_tag, '')
+            matchresult = matchresult.replace(end_tag, '')
+            matchresult = matchresult.replace('- YouTube', '')
             matchresult = matchresult.strip()
 
             return matchresult

pytube/mixins.py

@@ -37,10 +37,14 @@ def apply_signature(config_args, fmt, js):
             url = stream['url']
         elif live_stream:
             raise LiveStreamError('Video is currently being streamed live')
-        #403 Forbidden fix. 
-        if('signature' in url or 
-            ('s' not in stream and 
-            ('&sig=' in url or '&lsig=' in url))):
+        # 403 Forbidden fix.
+        if (
+            'signature' in url or (
+                's' not in stream and (
+                    '&sig=' in url or '&lsig=' in url
+                )
+            )
+        ):
             # For certain videos, YouTube will just provide them pre-signed, in
             # which case there's no real magic to download them and we can skip
             # the whole signature descrambling entirely.
@@ -63,7 +67,7 @@ def apply_signature(config_args, fmt, js):
                 }, indent=2,
             ),
         )
-        #403 forbidden fix
+        # 403 forbidden fix
         stream_manifest[i]['url'] = url + '&sig=' + signature
 
 

pytube/request.py

@@ -1,9 +1,10 @@
 # -*- coding: utf-8 -*-
 """Implements a simple wrapper around urlopen."""
+import urllib.request
+
 from pytube.compat import urlopen
+# 403 forbidden fix
 
-#403 forbidden fix
-import urllib.request
 
 def get(
     url=None, headers=False,
@@ -21,11 +22,10 @@ def get(
         The size in bytes of each chunk.
     """
 
-    #403 forbidden fix
-    req = urllib.request.Request(url, headers = {"User-Agent": "Mozilla/5.0"})
-    #response = urlopen(url)
+    # https://github.com/nficano/pytube/pull/465
+    req = urllib.request.Request(url, headers={'User-Agent': 'Mozilla/5.0'})
     response = urlopen(req)
-    
+
     if streaming:
         return stream_response(response, chunk_size)
     elif headers:

pytube/streams.py

@@ -179,7 +179,8 @@ class Stream(object):
             return player_config_args['title']
 
         details = self.player_config_args.get(
-            'player_response', {}).get('videoDetails', {})
+            'player_response', {},
+        ).get('videoDetails', {})
 
         if 'title' in details:
             return details['title']

setup.cfg

@@ -3,7 +3,7 @@ commit = True
 tag = True
 current_version = 9.5.2
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\-(?P<release>[a-z]+))?
-serialize = 
+serialize =
 	{major}.{minor}.{patch}
 
 [metadata]
@@ -15,9 +15,8 @@ description-file = README.md
 
 [coverage:run]
 source = pytube
-omit = 
+omit =
 	pytube/compat.py
 
 [flake8]
 ignore = W605
-

tests/contrib/test_playlist.py

@@ -1,9 +1,10 @@
+# -*- coding: utf-8 -*-
 from pytube import Playlist
 
 
 def test_title():
-    list_key = "PLsyeobzWxl7poL9JTVyndKe62ieoN-MZ3"
-    url = "https://www.youtube.com/playlist?list=" + list_key
+    list_key = 'PLsyeobzWxl7poL9JTVyndKe62ieoN-MZ3'
+    url = 'https://www.youtube.com/playlist?list=' + list_key
     pl = Playlist(url)
     pl_title = pl.title()
-    assert pl_title == "Python Tutorial for Beginners"
+    assert pl_title == 'Python Tutorial for Beginners'

tests/test_streams.py

@@ -26,7 +26,8 @@ def test_title(cipher_signature):
 
     expected = 'PSY - GANGNAM STYLE(강남스타일)'
     stream.player_config_args = {
-        'player_response': {'videoDetails': {'title': expected}}}
+        'player_response': {'videoDetails': {'title': expected}},
+    }
     assert stream.title == expected
 
     expected = 'Unknown YouTube Video Title'