Update history_manager.py

history_manager.py

@@ -11,22 +11,22 @@ class UserHistoryManager:
         print(f"Initializing UserHistoryManager with file: {os.path.abspath(self.history_file)}")
         self._init_file()
 
-    def _init_file(self):
-        """初始化JSON檔案"""
-        try:
-            if not os.path.exists(self.history_file):
-                print(f"Creating new history file: {self.history_file}")
-                with open(self.history_file, 'w', encoding='utf-8') as f:
-                    json.dump([], f)
-            else:
-                print(f"History file exists: {self.history_file}")
-                # 驗證檔案內容
-                with open(self.history_file, 'r', encoding='utf-8') as f:
-                    data = json.load(f)
-                    print(f"Current history entries: {len(data)}")
-        except Exception as e:
-            print(f"Error in _init_file: {str(e)}")
-            print(traceback.format_exc())
+    # def _init_file(self):
+    #     """初始化JSON檔案"""
+    #     try:
+    #         if not os.path.exists(self.history_file):
+    #             print(f"Creating new history file: {self.history_file}")
+    #             with open(self.history_file, 'w', encoding='utf-8') as f:
+    #                 json.dump([], f)
+    #         else:
+    #             print(f"History file exists: {self.history_file}")
+    #             # 驗證檔案內容
+    #             with open(self.history_file, 'r', encoding='utf-8') as f:
+    #                 data = json.load(f)
+    #                 print(f"Current history entries: {len(data)}")
+    #     except Exception as e:
+    #         print(f"Error in _init_file: {str(e)}")
+    #         print(traceback.format_exc())
             
 
     # def save_history(self, user_preferences: dict = None, results: list = None, search_type: str = "criteria", description: str = None) -> bool:
@@ -77,40 +77,81 @@ class UserHistoryManager:
     #         print(f"Error saving history: {str(e)}")
     #         return False
 
+
+    def _init_file(self):
+        """初始化JSON檔案"""
+        try:
+            if not os.path.exists(self.history_file):
+                print(f"Creating new history file: {self.history_file}")
+                with open(self.history_file, 'w', encoding='utf-8') as f:
+                    json.dump([], f)
+            else:
+                print(f"History file exists: {self.history_file}")
+                with open(self.history_file, 'r', encoding='utf-8') as f:
+                    data = json.load(f)
+                    print(f"Current history entries: {len(data)}")
+        except Exception as e:
+            print(f"Error in _init_file: {str(e)}")
+            print(traceback.format_exc())
+
     def save_history(self, user_preferences: dict = None, results: list = None, search_type: str = "criteria", description: str = None) -> bool:
+        """
+        保存搜尋歷史，確保結果資料被完整保存
+        
+        Args:
+            user_preferences: 使用者的搜尋偏好設定
+            results: 品種推薦結果列表
+            search_type: 搜尋類型
+            description: 搜尋描述
+        
+        Returns:
+            bool: 保存是否成功
+        """
         try:
-            # 確保 results 格式正確
-            if results:
-                for result in results:
-                    if not all(k in result for k in ('breed', 'overall_score')):
-                        print(f"Invalid result entry detected: {result}")
-                        raise ValueError("Each result must include 'breed' and 'overall_score'.")
-    
-            # 原始保存邏輯保持不變
+            # 初始化時區和當前時間
             taipei_tz = pytz.timezone('Asia/Taipei')
             current_time = datetime.now(taipei_tz)
-    
+            
+            # 創建歷史紀錄項目並包含時間戳記
             history_entry = {
                 "timestamp": current_time.strftime("%Y-%m-%d %H:%M:%S"),
-                "search_type": search_type,
-                "results": results
+                "search_type": search_type
             }
+            
+            # 確保結果資料的完整性
+            if results and isinstance(results, list):
+                processed_results = []
+                for result in results:
+                    # 確保每個結果都包含必要的欄位
+                    if isinstance(result, dict):
+                        processed_result = {
+                            'breed': result.get('breed', 'Unknown'),
+                            'overall_score': result.get('overall_score', result.get('final_score', 0)),
+                            'rank': result.get('rank', 0)
+                        }
+                        processed_results.append(processed_result)
+                history_entry["results"] = processed_results
+            
+            # 加入使用者偏好設定（如果有的話）
             if user_preferences:
                 history_entry["preferences"] = user_preferences
-    
+            
+            # 讀��現有歷史
             with open(self.history_file, 'r', encoding='utf-8') as f:
                 history = json.load(f)
-    
+            
+            # 加入新紀錄並保持歷史限制
             history.append(history_entry)
-            if len(history) > 20:  # 保留最近 20 條
+            if len(history) > 20:  # 保留最近 20 筆
                 history = history[-20:]
-    
+            
+            # 儲存更新後的歷史
             with open(self.history_file, 'w', encoding='utf-8') as f:
                 json.dump(history, f, ensure_ascii=False, indent=2)
-    
-            print("History saved successfully:", history_entry)
+            
+            print(f"Successfully saved history entry: {history_entry}")
             return True
-    
+        
         except Exception as e:
             print(f"Error saving history: {str(e)}")
             print(traceback.format_exc())