Improve model preloading in PoetryGenerationService with meaningful return value and enhanced error handling

app/services/poetry_generation.py

@@ -65,9 +65,10 @@ class PoetryGenerationService:
         try:
             _ = ModelManager()  # Ensure ModelManager singleton is initialized
             logger.info("Models preloaded successfully")
+            return True  # Return a meaningful value
         except Exception as e:
             logger.error(f"Error preloading models: {str(e)}")
-            raise
+            raise Exception("Failed to preload models") from e
 
     def generate_poem(
         self,

main.py

@@ -40,17 +40,19 @@ def init_huggingface():
 async def lifespan(app: FastAPI):
     # Initialize Hugging Face authentication first
     init_huggingface()
-    
+
     # Initialize poetry service and preload models
     poetry_service = PoetryGenerationService()
-    
-    # Only await if `preload_models` is asynchronous
-    if callable(getattr(poetry_service, "preload_models", None)):
-        result = poetry_service.preload_models()
-        if asyncio.iscoroutine(result):
-            await result
+
+    try:
+        preload_result = poetry_service.preload_models()
+        if asyncio.iscoroutine(preload_result):
+            await preload_result
         else:
-            result()  # Call directly if synchronous
+            preload_result  # Call directly if synchronous
+    except Exception as e:
+        logger.error(f"Error preloading models: {str(e)}")
+        raise
 
     yield  # Continue to application startup