Update game.js

game.js

@@ -1170,6 +1170,8 @@ class Game {
     if (!this.tank || !this.tank.isLoaded) return;
 
     const crosshair = document.getElementById('crosshair');
+    if (!crosshair) return; // crosshair 요소가 없으면 리턴
+
     const tankPosition = this.tank.getPosition();
     const turretRotation = this.tank.turretRotation;
     
@@ -1184,8 +1186,8 @@ class Game {
     let closestDistance = Infinity;
 
     // 모든 적에 대해 검사
-    this.enemies.forEach(enemy => {
-        if (!enemy.mesh || !enemy.isLoaded) return;
+    for (const enemy of this.enemies) {
+        if (!enemy.mesh || !enemy.isLoaded) continue;
 
         // 적과의 방향 벡터 계산
         const enemyVector = new THREE.Vector3()
@@ -1210,37 +1212,23 @@ class Game {
                 closestDistance = Math.min(closestDistance, distance);
             }
         }
-    });
+    }
 
     // 크로스헤어 상태 업데이트
     if (targetInSight) {
-        if (!crosshair.classList.contains('target-locked')) {
-            // 목표물 조준 시 사운드 효과
-            const targetLockSound = new Audio('sounds/targetlock.ogg');
-            targetLockSound.volume = 0.3;
-            targetLockSound.play();
-            
-            // 크로스헤어 애니메이션 효과
-            crosshair.style.transform = 'scale(1.2)';
-            setTimeout(() => {
-                crosshair.style.transform = 'scale(1)';
-            }, 200);
-        }
-        
         crosshair.classList.add('target-locked');
         
         // 거리에 따른 크로스헤어 크기 조절
-        const baseSize = 32; // 기본 크기
+        const baseSize = 32;
         const size = baseSize * (1 + (100 - closestDistance) / 200);
         crosshair.style.width = `${size}px`;
         crosshair.style.height = `${size}px`;
-        
     } else {
         crosshair.classList.remove('target-locked');
-        // 기본 크기로 복귀
         crosshair.style.width = '32px';
         crosshair.style.height = '32px';
     }
+}
 
     // 레이더 업데이트 메서드 추가
     updateRadar() {
@@ -2059,45 +2047,47 @@ this.enemies.forEach(enemy => {
     }
 
    animate() {
-       if (this.isGameOver) {
-           if (this.animationFrameId) {
-               cancelAnimationFrame(this.animationFrameId);
-           }
-           return;
-       }
-
-       this.animationFrameId = requestAnimationFrame(() => this.animate());
-           // 게임이 시작되지 않았으면 렌더링만 수행
-        if (!this.isStarted) {
-            this.renderer.render(this.scene, this.camera);
-            return;
+    if (this.isGameOver) {
+        if (this.animationFrameId) {
+            cancelAnimationFrame(this.animationFrameId);
         }
+        return;
+    }
 
-       const currentTime = performance.now();
-       const deltaTime = (currentTime - this.lastTime) / 1000;
-       this.lastTime = currentTime;
+    this.animationFrameId = requestAnimationFrame(() => this.animate());
 
-       if (!this.isLoading) {
-           this.handleMovement();
-           this.tank.update(this.mouse.x, this.mouse.y, this.scene);
-           
-           const tankPosition = this.tank.getPosition();
-           this.enemies.forEach(enemy => {
-               enemy.update(tankPosition);
-               
-               if (enemy.isLoaded && enemy.mesh.position.distanceTo(tankPosition) < ENEMY_CONFIG.ATTACK_RANGE) {
-                   enemy.shoot(tankPosition);
-               }
-           });
-            this.updateEnemyLabels(); // 적 라벨 업데이트 추가
-           this.updateParticles();
-           this.checkCollisions();
-           this.updateUI();
-           this.updateRadar(); // 레이더 업데이트 추가
-       }
-       
-       this.renderer.render(this.scene, this.camera);
-   }
+    // 게임이 시작되지 않았으면 렌더링만 수행
+    if (!this.isStarted) {
+        this.renderer.render(this.scene, this.camera);
+        return;
+    }
+
+    const currentTime = performance.now();
+    const deltaTime = (currentTime - this.lastTime) / 1000;
+    this.lastTime = currentTime;
+
+    if (!this.isLoading) {
+        this.handleMovement();
+        this.tank.update(this.mouse.x, this.mouse.y, this.scene);
+        this.checkTargetAlignment(); // 조준 정렬 체크 추가
+
+        const tankPosition = this.tank.getPosition();
+        this.enemies.forEach(enemy => {
+            enemy.update(tankPosition);
+            
+            if (enemy.isLoaded && enemy.mesh.position.distanceTo(tankPosition) < ENEMY_CONFIG.ATTACK_RANGE) {
+                enemy.shoot(tankPosition);
+            }
+        });
+
+        this.updateEnemyLabels();
+        this.updateParticles();
+        this.checkCollisions();
+        this.updateUI();
+        this.updateRadar();
+    }
+    
+    this.renderer.render(this.scene, this.camera);
 }
 
 // Start game