Unit testing & prompt tuning

app.py

@@ -85,7 +85,7 @@ def run_1_game_turn(s_narr_transcript, s_n_turns_elapsed, s_user_transcript, s_u
     elif decider_utils.yesno(QUESTION_IS_USER_ENGAGED_WITH_BANDITS, s_narr_transcript, default=NO) and decider_utils.special_case_is_running_away(s_user_input):
         finally_add2_both_tscripts += "Invalid entry.  You cannot outrun these bandits.\n"
 
-    elif decider_utils.yesno(QUESTION_IS_ACTION_MAGIC, s_user_input, default=NO):
+    elif decider_utils.special_case_is_magic(s_user_input):
         finally_add2_both_tscripts += "Invalid entry.  You are not a spellcaster and have no magic items except your revolver.\n"
 
     else:

decider_questions.py

@@ -3,5 +3,5 @@ QUESTION_DOES_USER_STILL_HAVE_AT_LEAST_30_GOLD = "At the end of the above story,
 QUESTION_IS_USER_ENGAGED_WITH_BANDITS = "At the end of the above story, is the protagonist currently still engaged in a standoff with bandits?"
 QUESTION_IS_ACTION_LIKELY_LETHAL = "Is the action just described likely to result in anyone dying?"
 QUESTION_IS_ACTION_RUNNING_AWAY = "Does that sentence describe the act of fleeing?"
-QUESTION_IS_ACTION_MAGIC = "Is the action just described an example of using supernatural magical spells / potions / etc?"
+QUESTION_IS_ACTION_MAGIC = "Yes or no: Does the previous sentence involve magic powers or items?"
 QUESTION_DID_PROTAGONIST_KILL = "In the story segment above, did the protagonist kill anyone?"

decider_utils.py

@@ -4,10 +4,16 @@ import decider_questions
 YES = True
 NO = False
 
+g_decider_utils_dbg_printing = False
 
 def yesno(question, text, default):
+    global g_decider_utils_dbg_printing
+
     prompt = text + "\n\n" + question
-    print(prompt)
+
+    if g_decider_utils_dbg_printing:
+        print(prompt)
+
     hopefully_word_yes_or_no = openai.Completion.create(
         engine="text-davinci-002",
         prompt=prompt,
@@ -17,7 +23,10 @@ def yesno(question, text, default):
         presence_penalty=0,
         n=1,
     )["choices"][0]["text"]
-    print(hopefully_word_yes_or_no)
+
+    if g_decider_utils_dbg_printing:
+        print(hopefully_word_yes_or_no)
+
     hopefully_word_yes_or_no = hopefully_word_yes_or_no.upper().strip()
 
     result = default
@@ -42,8 +51,22 @@ def special_case_is_running_away(text):
     for keyword in ["run", "away", "hide", "escape", "flee", "sprint", "teleport"]:
         if keyword in text.lower():
             might_really_be_fleeing = True
+            break
 
     if might_really_be_fleeing:
         return yesno(decider_questions.QUESTION_IS_ACTION_RUNNING_AWAY, text, default=NO)
     else:
         return NO
+
+def special_case_is_magic(text):
+    is_magic = False
+    for keyword in ["magic", "spell", "fly", "invisib", "levitat", "teleport", "dragon", "genie", "fairy", "demon", "devil", "angel", "griffin", "wand"]:
+        if keyword in text.lower():
+            is_magic = True
+            break
+
+    if is_magic:
+        return YES
+    else:
+        return yesno(decider_questions.QUESTION_IS_ACTION_MAGIC, text, default=NO)
+

run_unit_tests.py

@@ -1,24 +1,53 @@
 #! /usr/bin/env python3
 
-import os
+import os, sys
 import openai
+import decider_utils
+from decider_utils import YES, NO, yesno
+from decider_questions import *
 
 openai.organization = os.environ.get("OPENAI_ORGANIZATION")
 openai.api_key = os.environ.get("OPENAI_KEY")
 
+decider_utils.g_decider_utils_dbg_printing = True
 
-from decider_utils import YES, NO, yesno, special_case_is_running_away
-from decider_questions import *
+# Begin tests:
+
+assert YES == decider_utils.special_case_is_magic("I fly straight up")
+assert YES == decider_utils.special_case_is_magic("fly up")
+assert YES == decider_utils.special_case_is_magic("turn invisible")
+assert YES == decider_utils.special_case_is_magic("i turn invisible")
+assert YES == decider_utils.special_case_is_magic("i teleport")
+assert YES == decider_utils.special_case_is_magic("I summon a genie")
+assert YES == decider_utils.special_case_is_magic("I summon an angel")
+assert YES == decider_utils.special_case_is_magic("I throw some magic powder")
+assert YES == decider_utils.special_case_is_magic("I start levitating")
+assert YES == decider_utils.special_case_is_magic("I start levitating")
+assert YES == decider_utils.special_case_is_magic("I say wingardium leviosa")
+
+assert NO == decider_utils.special_case_is_magic("I hide behind a rock")
+assert NO == decider_utils.special_case_is_magic("I hide behind a tree")
+assert NO == decider_utils.special_case_is_magic("I hide behind a boulder")
+assert NO == decider_utils.special_case_is_magic("I attempt to bargain")
+assert NO == decider_utils.special_case_is_magic("I start tap dancing")
+assert NO == decider_utils.special_case_is_magic("I say no")
+assert NO == decider_utils.special_case_is_magic("I say ok fine")
+assert NO == decider_utils.special_case_is_magic("I fire my revolver")
+assert NO == decider_utils.special_case_is_magic("I fire my pistol")
+
+
+assert YES == decider_utils.special_case_is_running_away("run away")
+assert YES == decider_utils.special_case_is_running_away("I run away")
+assert YES == decider_utils.special_case_is_running_away("flee")
+assert YES == decider_utils.special_case_is_running_away("I flee.")
 
+assert NO == decider_utils.special_case_is_running_away("A")
+assert NO == decider_utils.special_case_is_running_away("B")
+assert NO == decider_utils.special_case_is_running_away("C")
+assert NO == decider_utils.special_case_is_running_away("ok")
+assert NO == decider_utils.special_case_is_running_away("say ok")
+assert NO == decider_utils.special_case_is_running_away("say okay")
 
-assert YES == special_case_is_running_away("run away")
-assert YES == special_case_is_running_away("I run away")
-assert YES == special_case_is_running_away("flee")
-assert YES == special_case_is_running_away("I flee.")
 
-assert NO == special_case_is_running_away("A")
-assert NO == special_case_is_running_away("B")
-assert NO == special_case_is_running_away("C")
-assert NO == special_case_is_running_away("ok")
-assert NO == special_case_is_running_away("say ok")
-assert NO == special_case_is_running_away("say okay")
+print("All tests passed.")
+sys.exit(0)