Fix vote system bug [WIP]

src/submission/submit.py

@@ -68,12 +68,13 @@ def add_new_eval(
     use_chat_template: bool,
     profile: gr.OAuthProfile | None
 ):  
-    # Login required
-    if profile is None:
-        return styled_error("Hub Login Required")
+    # # Login required
+    # if profile is None:
+    #     return styled_error("Hub Login Required")
 
-    # Name of the actual user who sent the request
-    username = profile.username
+    # # Name of the actual user who sent the request
+    # username = profile.username
+    username = "test"
 
     global REQUESTED_MODELS
     global USERS_TO_SUBMISSION_DATES
@@ -187,13 +188,13 @@ def add_new_eval(
 
     print("Uploading eval file")
     print(eval_entry)
-    API.upload_file(
-        path_or_fileobj=out_path,
-        path_in_repo=out_path.split("eval-queue/")[1],
-        repo_id=QUEUE_REPO,
-        repo_type="dataset",
-        commit_message=f"Add {model} to eval queue",
-    )
+    # API.upload_file(
+    #     path_or_fileobj=out_path,
+    #     path_in_repo=out_path.split("eval-queue/")[1],
+    #     repo_id=QUEUE_REPO,
+    #     repo_type="dataset",
+    #     commit_message=f"Add {model} to eval queue",
+    # )
 
     # Remove the local file
     os.remove(out_path)

src/voting/vote_system.py

@@ -56,8 +56,9 @@ class VoteManager:
         return "main"
 
     def create_request_vote_df(self, pending_models_df: gr.Dataframe):
-        if pending_models_df.empty or not "model_name" in pending_models_df.columns:
+        if pending_models_df.empty or "model_name" not in pending_models_df.columns:
             return pending_models_df
+
         self.vote_dataset = self.read_vote_dataset()
         vote_counts = self.vote_dataset.groupby(['model', 'revision']).size().reset_index(name='vote_count')
 
@@ -79,7 +80,7 @@ class VoteManager:
     def add_vote(
             self,
             selected_model: str,
-            pending_models_df: gr.Dataframe,
+            pending_models_df: gr.Dataframe | None,
             profile: gr.OAuthProfile | None
         ):
         logger.debug(f"Type of list before usage: {type(list)}")
@@ -126,6 +127,9 @@ class VoteManager:
         self.vote_check_set.add(check_tuple)
         gr.Info(f"Voted for {selected_model}")
 
+        if pending_models_df is None:
+            return
+
         return self.create_request_vote_df(pending_models_df)
 
     def upload_votes(self):