Datasets:

bug-localization

/

BeetleBox

like 0

Follow

BLAZE 1

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/subdirectory/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/udf/pages/resource/_source/list.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileChildReUpdate.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileReUpload.vue", "dolphinscheduler-ui/src/js/module/components/nav/nav.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"]

[Improvement][api] resource file content update

used dolphin-scheduler V1.3.1, resource file content update interface only arguments of type "String" are supported, if need update a jar file content, you must delete this file first, then upload again. if a task depends on it, that will get worse. you must delete this task or remove depends, otherwise, you will get an exception.

https://github.com/apache/dolphinscheduler/issues/3327

https://github.com/apache/dolphinscheduler/pull/3394

811fd48f0a27b3112092b4f8b4fbeb5d55cf2da0

78672b035900d5d06f1f66af73f2ee41f87086ca

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"]

[Bug][Master] there exists some problems in checking task dependency

**Describe the bug** There exists some problems in Master-Server executing logic. Some nodes could execute normally though their depenpency is not satisfied. Just like the screenshots below, if you get the same work flow, and you will find the result is wrong. **Screenshots** As you can see, task B shouldn't be executed which is the opposite of the result. When task X has condition-type node after, the tasks that depend on X will be probably executed.  **Which version of Dolphin Scheduler:** -[1.3.2-snapshot] **Probable reason** - it's wrong because of the code below in the red rectangle. 

https://github.com/apache/dolphinscheduler/issues/3324

https://github.com/apache/dolphinscheduler/pull/3473

927985c012342f0c9f1dde397d66b5737571fed2

5756d6b02910d139f00b4b412078f32c5ca14c54

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/ZookeeperNodeManagerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackServiceTest.java", "pom.xml"]

[Question] Why "Failed to load ApplicationContext" when running tests locally

# Why "Failed to load ApplicationContext" when running tests locally The first is the test command I ran: ``` mvn test -pl dolphinscheduler-server -Dtest =TaskPriorityQueueConsumerTest#testSHELLTask ``` It should be noted that the above test is not the only one with this problem. ## The environment in which the problem occurs The problem was originally discovered by running tests in IDEA, but also by testing directly with the 'mvn' command. - Operating system: MacOS - JAVA: 1.8.0_111 - Maven: 3.5.2 - DS version: dev branch To verify that it was a local environment problem, I created a new virtual machine to test, which had the same problem. - Operating system: CentOS 7 - JAVA: 1.8.0_221 - Maven: 3.6.3 - DS version: dev branch ## Action steps I tested it on my virtual machine using the following steps: ``` git clone ... cd incubator-dolphinscheduler-github/ git checkout dev mvn clean install -pl dolphinscheduler-common -am -Dmaven.test.skip=true mvn clean install -pl dolphinscheduler-dao -am -Dmaven.test.skip=true mvn clean install -pl dolphinscheduler-service -am -Dmaven.test.skip=true mvn clean install -pl dolphinscheduler-alert -am -Dmaven.test.skip=true mvn test -pl dolphinscheduler-server -Dtest=TaskPriorityQueueConsumerTest#testSHELLTask ``` ## Error log ``` [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.247 s <<< FAILURE! - in org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumerTest [ERROR] testSHELLTask(org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumerTest) Time elapsed: 0 s <<< ERROR! java.lang.IllegalStateException: Failed to load ApplicationContext Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'nettyExecutorManager': Unsatisfied dependency expressed through field 'zookeeperNodeManager'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperNodeManager': Unsatisfied dependency expressed through field 'registryCenter'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)} Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperNodeManager': Unsatisfied dependency expressed through field 'registryCenter'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)} Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)} Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)} Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)} 01:07:48.958 [SessionTracker] INFO org.apache.zookeeper.server.SessionTrackerImpl - SessionTrackerImpl exited loop! [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TaskPriorityQueueConsumerTest.testSHELLTask » IllegalState Failed to load Appl... [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 48.206 s [INFO] Finished at: 2020-07-27T01:07:49Z [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project dolphinscheduler-server: There are test failures. [ERROR] [ERROR] Please refer to /root/incubator-dolphinscheduler-github/dolphinscheduler-server/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException ``` ## Problem analysis According to my own knowledge, I tried to solve the above problems. Because the reason is that `Autowired` errors, so I according to the prompt in the test code `dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java`, To annotate `@ContextConfiguration` added a class `CuratorZookeeperClient.class`, problem is solved. Just like this: ```java @ContextConfiguration(classes={DependencyConfig.class, SpringApplicationContext.class, SpringZKServer.class, NettyExecutorManager.class, ExecutorDispatcher.class, ZookeeperRegistryCenter.class, TaskPriorityQueueConsumer.class, ZookeeperNodeManager.class, ZookeeperCachedOperator.class, ZookeeperConfig.class, MasterConfig.class, CuratorZookeeperClient.class}) ``` I mentioned this problem with more than one test code, but I'll summarize it now: > if the test code needs to Autowired class A objects, class A needs to Autowired class B objects. Then `A.class` appears in the context configuration, while `B.class` is not, an 'Failed to load ApplicationContext' exception will appear and the test will fail. ## Question Every time the project merges new code, it will be tested automatically. Why is this test enough to pass without these problems?

https://github.com/apache/dolphinscheduler/issues/3314

https://github.com/apache/dolphinscheduler/pull/3304

b555d0a086c88c29b40304802589b3ef77955ab9

3a0d4da27e6f981ecba7d061bad4644079ae122d

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/AlertManager.java"]

[Bug][Alert] when master or worker shutdown, alert cannot notify

This error log: `[ERROR] 2020-07-22 11:00:22.209 org.apache.dolphinscheduler.common.utils.JSONUtils:[145] - parse list exception! com.fasterxml.jackson.databind.JsonMappingException: Unexpected character (''' (code 39)): was expecting double-quote to start field name at [Source: (String)"[{'type':'WORKER','host':'/dolphinscheduler/nodes/worker/hadoop/192.168.0.3:5678','event':'server down','warning level':'serious'}]"; line: 1, column: 2] (through reference chain: java.util.ArrayList[0]) at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:394) at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:365) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:302) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:245) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:27) at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4013) at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3042) at org.apache.dolphinscheduler.common.utils.JSONUtils.toList(JSONUtils.java:143)` I think the reason for this is that Jackson can't parse JSON fields with single quotes.

https://github.com/apache/dolphinscheduler/issues/3299

https://github.com/apache/dolphinscheduler/pull/3552

d30bc7bcf3dda45672845130e04212dfec9f0133

2f0102580268ff045e6042c3a691f1dee4c49962

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java", "dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/utils/ChannelUtils.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryTest.java"]

[Bug][k8s]when recreate or upgrade helm release, the host ip changed

**Describe the bug** When DS was deployed to k8s by helm, if you upgrade the release or recreate the release, the ip of worker server and other server will be changed, so when you try to query the log of history task, you will get empty log. **To Reproduce** Steps to reproduce the behavior, for example: 1. deploy the cluster use helm 2. recreate the deployed release or just upgrade 3. query a task which runned before upgrade/recreate 4. no log will show **Expected behavior** log should be show **Screenshots**  **Which version of Dolphin Scheduler:** -[1.3.1-release] **Additional context** **Requirement or improvement**

https://github.com/apache/dolphinscheduler/issues/3298

https://github.com/apache/dolphinscheduler/pull/4786

23591b71a2859021e9280899b1f1b6ff3b679fbc

8ebddc1f5bb484a2d7d8e1353b2a8f51fae78ec0

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java"]

When I create a scheduler directly through the api, a NullPointerException will appear when the processInstancePriority field is not passed. he is @RequestParam(value = "processInstancePriority", required = false)

 error line  Do you need to modify it to @RequestParam(value = "processInstancePriority", required = true)

https://github.com/apache/dolphinscheduler/issues/3295

https://github.com/apache/dolphinscheduler/pull/3341

5f725aa28b2edbd246480a554ac7822bf07fbbfd

e2a117032de53a206fd0d8a55b665a199efb276a

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/HttpUtilsTest.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClientTest.java", "pom.xml"]

[Bug][dolphinscheduler-common] When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled

When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled eg:  yarn.application.status.address=http://ark1:8088/ws/v1/cluster/apps/%s

https://github.com/apache/dolphinscheduler/issues/3262

https://github.com/apache/dolphinscheduler/pull/3264

232a24441bbb559c18739a74abb69ecdb718e158

5584f0cb4d27e3ae64ec28c65a8669b38c75d188

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["sql/upgrade/1.2.0_schema/mysql/dolphinscheduler_dml.sql", "sql/upgrade/1.3.0_schema/mysql/dolphinscheduler_dml.sql", "sql/upgrade/1.3.0_schema/postgresql/dolphinscheduler_dml.sql"]

admin account modify report error, caused by mobile phone

> > > 我安装1.2.1也不能修改管理员密码，提示request parameter xx is not valid 我这边安装的版本是1.3.1，在进行修改管理原密码的时候，也是提示跟你同样的问题；后面通过F12，查询相应信息，发现这个错误是‘手机’这个信息产生影响的，你必须将该‘手机’参数修改为正确的格式，否则无法正常修改密码，如  _Originally posted by @wjf989 in https://github.com/apache/incubator-dolphinscheduler/issues/219#issuecomment-661597078_ 建议：将“手机”的参数变量，同其他地方的变量信息进行脱钩；

https://github.com/apache/dolphinscheduler/issues/3256

https://github.com/apache/dolphinscheduler/pull/3425

2b990e1f000ba583504585624591e8403958c374

f784ce504f06d8a6b444a98ead01c6aa8b184679

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/UdfFunc.java", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/entity/UdfFuncTest.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/SQLTaskExecutionContext.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/entity/SQLTaskExecutionContextTest.java", "pom.xml"]

[Bug][worker] Cannot find a (Map) Key deserializer for type

When I execute SQL query task, JSON parsing error error info : ```` com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot find a (Map) Key deserializer for type [simple type, class org.apache.dolphinscheduler.dao.entity.UdfFunc] `````  show code : TaskExecutionContext taskExecutionContext = JSONUtils.parseObject(contextJson, TaskExecutionContext.class);  contextJson: ``` { "taskInstanceId":2, "taskName":"SQL-QUERY", "startTime":"2020-07-18 19:18:58", "taskType":"SQL", "host":null, "executePath":"/tmp/dolphinscheduler/exec/process/2/17/2/2", "logPath":null, "taskJson":"{"id":"tasks-5736","name":"SQL-QUERY","desc":null,"type":"SQL","runFlag":"NORMAL","loc":null,"maxRetryTimes":0,"retryInterval":1,"params":{"type":"MYSQL","datasource":3,"sql":"SELECT * FROM person","udfs":"","sqlType":"0","title":"SQL-QUERY","receivers":"zhangboyi_mx@163.com","receiversCc":"","showType":"TABLE","localParams":[],"connParams":"","preStatements":[],"postStatements":[]},"preTasks":[],"extras":null,"depList":[],"dependence":{},"conditionResult":{"successNode":[""],"failedNode":[""]},"taskInstancePriority":"MEDIUM","workerGroup":"default","workerGroupId":null,"timeout":{"strategy":"","interval":null,"enable":false},"conditionsTask":false,"forbidden":false,"taskTimeoutParameter":{"enable":false,"strategy":null,"interval":0}}", "processId":0, "appIds":null, "processInstanceId":2, "scheduleTime":null, "globalParams":null, "executorId":2, "cmdTypeIfComplement":0, "tenantCode":"sysadmin", "queue":"default", "processDefineId":17, "projectId":2, "taskParams":null, "envFile":null, "definedParams":null, "taskAppId":null, "taskTimeoutStrategy":0, "taskTimeout":0, "workerGroup":"default", "resources":{ }, "sqlTaskExecutionContext":{ "warningGroupId":0, "connectionParams":"{"type":null,"address":"jdbc:mysql://127.0.0.1:3306","database":"test","jdbcUrl":"jdbc:mysql://127.0.0.1:3306/test","user":"root","password":"IUAjJCVeJipyb290"}", "udfFuncTenantCodeMap":null }, "dataxTaskExecutionContext":{ "dataSourceId":0, "sourcetype":0, "sourceConnectionParams":null, "dataTargetId":0, "targetType":0, "targetConnectionParams":null }, "dependenceTaskExecutionContext":null, "sqoopTaskExecutionContext":{ "dataSourceId":0, "sourcetype":0, "sourceConnectionParams":null, "dataTargetId":0, "targetType":0, "targetConnectionParams":null }, "procedureTaskExecutionContext":{ "connectionParams":null } } ``` test unit : ``` public class TaskExecuteProcessorTest { @Test public void testJson(){ String contextJson = "{\n" + " \"taskInstanceId\":2,\n" + " \"taskName\":\"SQL-QUERY\",\n" + " \"startTime\":\"2020-07-18 19:18:58\",\n" + " \"taskType\":\"SQL\",\n" + " \"host\":null,\n" + " \"executePath\":\"/tmp/dolphinscheduler/exec/process/2/17/2/2\",\n" + " \"logPath\":null,\n" + " \"taskJson\":\"{\"id\":\"tasks-5736\",\"name\":\"SQL-QUERY\",\"desc\":null,\"type\":\"SQL\",\"runFlag\":\"NORMAL\",\"loc\":null,\"maxRetryTimes\":0,\"retryInterval\":1,\"params\":{\"type\":\"MYSQL\",\"datasource\":3,\"sql\":\"SELECT * FROM person\",\"udfs\":\"\",\"sqlType\":\"0\",\"title\":\"SQL-QUERY\",\"receivers\":\"zhangboyi_mx@163.com\",\"receiversCc\":\"\",\"showType\":\"TABLE\",\"localParams\":[],\"connParams\":\"\",\"preStatements\":[],\"postStatements\":[]},\"preTasks\":[],\"extras\":null,\"depList\":[],\"dependence\":{},\"conditionResult\":{\"successNode\":[\"\"],\"failedNode\":[\"\"]},\"taskInstancePriority\":\"MEDIUM\",\"workerGroup\":\"default\",\"workerGroupId\":null,\"timeout\":{\"strategy\":\"\",\"interval\":null,\"enable\":false},\"conditionsTask\":false,\"forbidden\":false,\"taskTimeoutParameter\":{\"enable\":false,\"strategy\":null,\"interval\":0}}\",\n" + " \"processId\":0,\n" + " \"appIds\":null,\n" + " \"processInstanceId\":2,\n" + " \"scheduleTime\":null,\n" + " \"globalParams\":null,\n" + " \"executorId\":2,\n" + " \"cmdTypeIfComplement\":0,\n" + " \"tenantCode\":\"sysadmin\",\n" + " \"queue\":\"default\",\n" + " \"processDefineId\":17,\n" + " \"projectId\":2,\n" + " \"taskParams\":null,\n" + " \"envFile\":null,\n" + " \"definedParams\":null,\n" + " \"taskAppId\":null,\n" + " \"taskTimeoutStrategy\":0,\n" + " \"taskTimeout\":0,\n" + " \"workerGroup\":\"default\",\n" + " \"resources\":{\n" + "\n" + " },\n" + " \"sqlTaskExecutionContext\":{\n" + " \"warningGroupId\":0,\n" + " \"connectionParams\":\"{\"type\":null,\"address\":\"jdbc:mysql://127.0.0.1:3306\",\"database\":\"test\",\"jdbcUrl\":\"jdbc:mysql://127.0.0.1:3306/test\",\"user\":\"root\",\"password\":\"IUAjJCVeJipyb290\"}\",\n" + " \"udfFuncTenantCodeMap\":null\n" + " },\n" + " \"dataxTaskExecutionContext\":{\n" + " \"dataSourceId\":0,\n" + " \"sourcetype\":0,\n" + " \"sourceConnectionParams\":null,\n" + " \"dataTargetId\":0,\n" + " \"targetType\":0,\n" + " \"targetConnectionParams\":null\n" + " },\n" + " \"dependenceTaskExecutionContext\":null,\n" + " \"sqoopTaskExecutionContext\":{\n" + " \"dataSourceId\":0,\n" + " \"sourcetype\":0,\n" + " \"sourceConnectionParams\":null,\n" + " \"dataTargetId\":0,\n" + " \"targetType\":0,\n" + " \"targetConnectionParams\":null\n" + " },\n" + " \"procedureTaskExecutionContext\":{\n" + " \"connectionParams\":null\n" + " }\n" + "}" ; TaskExecutionContext taskExecutionContext = JSONUtils.parseObject(contextJson, TaskExecutionContext.class); assertTrue(taskExecutionContext != null); } } ``` error info : ``` Connected to the target VM, address: '127.0.0.1:53429', transport: 'socket' 19:43:31.405 [main] ERROR org.apache.dolphinscheduler.common.utils.JSONUtils - parse object exception! com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot find a (Map) Key deserializer for type [simple type, class org.apache.dolphinscheduler.dao.entity.UdfFunc] at [Source: (String)"{ "taskInstanceId":2, "taskName":"SQL-QUERY", "startTime":"2020-07-18 19:18:58", "taskType":"SQL", "host":null, "executePath":"/tmp/dolphinscheduler/exec/process/2/17/2/2", "logPath":null, "taskJson":"{"id":"tasks-5736","name":"SQL-QUERY","desc":null,"type":"SQL","runFlag":"NORMAL","loc":null,"maxRetryTimes":0,"retryInterval":1,"params":{"type":"MYSQL","datasource":3,"sql":"SELECT * FROM person","udfs":"","sqlType":"0","title":"SQL-QUERY","receivers":"zhangboyi_mx"[truncated 1787 chars]; line: 1, column: 1] at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:67) at com.fasterxml.jackson.databind.DeserializationContext.reportBadDefinition(DeserializationContext.java:1452) at com.fasterxml.jackson.databind.deser.DeserializerCache._handleUnknownKeyDeserializer(DeserializerCache.java:599) at com.fasterxml.jackson.databind.deser.DeserializerCache.findKeyDeserializer(DeserializerCache.java:168) at com.fasterxml.jackson.databind.DeserializationContext.findKeyDeserializer(DeserializationContext.java:500) at com.fasterxml.jackson.databind.deser.std.MapDeserializer.createContextual(MapDeserializer.java:248) at com.fasterxml.jackson.databind.DeserializationContext.handlePrimaryContextualization(DeserializationContext.java:651) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.resolve(BeanDeserializerBase.java:484) at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:293) at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:244) at com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142) at com.fasterxml.jackson.databind.DeserializationContext.findNonContextualValueDeserializer(DeserializationContext.java:467) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.resolve(BeanDeserializerBase.java:473) at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:293) at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:244) at com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142) at com.fasterxml.jackson.databind.DeserializationContext.findRootValueDeserializer(DeserializationContext.java:477) at com.fasterxml.jackson.databind.ObjectMapper._findRootDeserializer(ObjectMapper.java:4190) at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4009) at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3004) at org.apache.dolphinscheduler.common.utils.JSONUtils.parseObject(JSONUtils.java:108) at org.apache.dolphinscheduler.server.worker.processor.TaskExecuteProcessorTest.testJson(TaskExecuteProcessorTest.java:71) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) Disconnected from the target VM, address: '127.0.0.1:53429', transport: 'socket' java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.apache.dolphinscheduler.server.worker.processor.TaskExecuteProcessorTest.testJson(TaskExecuteProcessorTest.java:73) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) ```

https://github.com/apache/dolphinscheduler/issues/3240

https://github.com/apache/dolphinscheduler/pull/3245

252abbdaed4a120b0bc5c23da3e956e3d429a7a1

6f2667bf1aab2715cfd734a5a694d2b2fd0adcc9

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["docker/docker-swarm/docker-compose.yml"]

[Bug][Resource Center] Can not create folder in docker with standalone mode

Creating a folder in the Resource Center failed. 1. build docker images by default Dockerfile 2. run docker with args ALL 3. open resource center, and create a folder 4. See error **Which version of Dolphin Scheduler:** -[1.3.1] **Additional context** The error info in logs is : NulPointer Error in createDirecortry(ResourceService.java:484) It seems to be a HDFS error. but in DOC, the local fs is supported. And then，I modify the common config file, change the storage.type from NONE to HDFS, but still failed. i want to evaluate dolphinscheduler quickly, but it's not very easy -_-b Please consider being able to quickly evaluate the software through docker.

https://github.com/apache/dolphinscheduler/issues/3238

https://github.com/apache/dolphinscheduler/pull/3772

973cbf8d86df6a0895a5c19cfc69c38b89853850

b2e78cbf9cea99bbeb5656b071a9db8b025be363

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/pom.xml", "dolphinscheduler-dist/release-docs/LICENSE", "dolphinscheduler-dist/release-docs/licenses/LICENSE-ant-1.6.5.txt", "dolphinscheduler-dist/release-docs/licenses/LICENSE-core-3.1.1.txt", "dolphinscheduler-dist/release-docs/licenses/LICENSE-jsp-api-2.1-6.1.14.txt", "pom.xml", "tools/dependencies/known-dependencies.txt"]

[Bug][api-server] ClassCastException: AppClassLoader cannot be cast to class java.net.URLClassLoader

*For better global communication, please give priority to using English description, thx! * **Which version of Dolphin Scheduler:** 1.3.1 **Describe the bug** Just started the api-server, logs show as follows: ``` [WARN] 2020-07-17 10:17:17.231 org.eclipse.jetty.server.handler.ContextHandler.application:[2355] - unavailable java.lang.ClassCastException: class jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and java.net.URLClassLoader are in module java.base of loader 'bootstrap') at org.apache.jasper.compiler.JspRuntimeContext.<init>(JspRuntimeContext.java:174) at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:150) at org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:672) at org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:429) at org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0(ServletHandler.java:750) at java.base/java.util.stream.SortedOps$SizedRefSortingSink.end(SortedOps.java:357) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:312) at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:735) at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734) at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658) at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:744) at org.springframework.boot.web.embedded.jetty.JettyEmbeddedWebAppContext$JettyEmbeddedServletHandler.deferredInitialize(JettyEmbeddedWebAppContext.java:46) at org.springframework.boot.web.embedded.jetty.JettyEmbeddedWebAppContext.deferredInitialize(JettyEmbeddedWebAppContext.java:36) at org.springframework.boot.web.embedded.jetty.JettyWebServer.handleDeferredInitialize(JettyWebServer.java:221) at org.springframework.boot.web.embedded.jetty.JettyWebServer.start(JettyWebServer.java:142) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.startWebServer(ServletWebServerApplicationContext.java:311) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:164) at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552) at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:142) at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:775) at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397) at org.springframework.boot.SpringApplication.run(SpringApplication.java:316) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1260) at org.springframework.boot.SpringApplication.run(SpringApplication.java:1248) at org.apache.dolphinscheduler.api.ApiApplicationServer.main(ApiApplicationServer.java:36) ``` I found [an explaination on stackoverflow][1]. It shows that JDK 9 has a breaking change here. [1]: https://stackoverflow.com/questions/39739075/hive-shell-not-loading/41637409#41637409 **Requirement or improvement** Please fix this to make DS compatible with modern JDK. Thanks!

https://github.com/apache/dolphinscheduler/issues/3233

https://github.com/apache/dolphinscheduler/pull/4312

9c226435e377e055c64c4c5586a2fcd426ca61af

b8dc4357270ef4610237e2bb498fe604153c2a0f

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java"]

[BUG] Heartbeat thread pool does not shutdown when MasterRegistry unRegistry

*For better global communication, please give priority to using English description, thx! * **Describe the bug** look at the method of MasterRegistry ```java public void unRegistry() { String address = getLocalAddress(); String localNodePath = getMasterPath(); zookeeperRegistryCenter.getZookeeperCachedOperator().remove(localNodePath); logger.info("master node : {} unRegistry to ZK.", address); } ``` The method, which is invoke when close the MasterServer, does not shutdown the Heartbeat thread pool.

https://github.com/apache/dolphinscheduler/issues/3187

https://github.com/apache/dolphinscheduler/pull/3188

98fdba6740abcb8dd30bc08d6ff39793dd9dd598

88f9bed726d479d4be4a46fb599161d5e61f496f

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java"]

[BUG] get http code 400 bad request with AWS S3 as resource storage type

*For better global communication, please give priority to using English description, thx! * **Describe the bug** when you use AWS S3 as the resource storage backend you will get a error like: ``` log Status Code: 400, AWS Service: Amazon S3, AWS Request ID: xxxxxxx, AWS Error Code: null, AWS Error Message: Bad Request ``` **To Reproduce** Steps to reproduce the behavior, for example: just set `resource.storage.type=S3` in common.properties and also keep other configuration correct. **Expected behavior** the resource centre work fine. **Screenshots** when you try to upload a file at resource centre, you will get a error. **Which version of Dolphin Scheduler:** -[1.3.1-release] **Additional context** it is because of the version of AWS S3 encryption method. **Requirement or improvement** I will make a PR for this later.

https://github.com/apache/dolphinscheduler/issues/3181

https://github.com/apache/dolphinscheduler/pull/3182

1e7582e910c23a42bb4e92cd64fde4df7cbf6b34

dcdd7dedd06454ed468eae86881b75177261c9e2

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/startingParam/index.vue", "dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue", "dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/timing.vue"]

[BUG] cache bug

**Describe the bug**  When I go to use it 

https://github.com/apache/dolphinscheduler/issues/3179

https://github.com/apache/dolphinscheduler/pull/3200

a7aa58e6ca258c817ec53d8ae27743e4904189c7

3aa34bc72363eab368ade91b6e5be77b67897b02

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java"]

config resource.storage.type=hdfs throw exception need config resource.storage.type=HDFS

when i config common.properties , resource.storage.type=hdfs will throw exception  because Enumerated type comparisons do not ignore case。

https://github.com/apache/dolphinscheduler/issues/3165

https://github.com/apache/dolphinscheduler/pull/3166

ae902e2308b60f57010918bbce67703def10a02f

a23a3e2d1254acf1d6c194f4996824e3f290cae1

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/NettyRemotingServer.java"]

[BUG] netty server may start multiple times if multiple threads execute the start method

*For better global communication, please give priority to using English description, thx! * **Describe the bug** look at the code of NettyRemotingServer ```java public void start(){ if(this.isStarted.get()){ return; } this.serverBootstrap .group(this.bossGroup, this.workGroup) .channel(NioServerSocketChannel.class) .option(ChannelOption.SO_REUSEADDR, true) .option(ChannelOption.SO_BACKLOG, serverConfig.getSoBacklog()) .childOption(ChannelOption.SO_KEEPALIVE, serverConfig.isSoKeepalive()) .childOption(ChannelOption.TCP_NODELAY, serverConfig.isTcpNoDelay()) .childOption(ChannelOption.SO_SNDBUF, serverConfig.getSendBufferSize()) .childOption(ChannelOption.SO_RCVBUF, serverConfig.getReceiveBufferSize()) .childHandler(new ChannelInitializer<NioSocketChannel>() { @Override protected void initChannel(NioSocketChannel ch) throws Exception { initNettyChannel(ch); } }); ChannelFuture future; try { future = serverBootstrap.bind(serverConfig.getListenPort()).sync(); } catch (Exception e) { logger.error("NettyRemotingServer bind fail {}, exit",e.getMessage(), e); throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort())); } if (future.isSuccess()) { logger.info("NettyRemotingServer bind success at port : {}", serverConfig.getListenPort()); } else if (future.cause() != null) { throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort()), future.cause()); } else { throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort())); } // isStarted.compareAndSet(false, true); } ``` If multiple threads execute the method at a time, it may start the netty server multiple times. **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. **Which version of Dolphin Scheduler:** -[1.1.0-preview] **Additional context** Add any other context about the problem here. **Requirement or improvement - Please describe about your requirements or improvement suggestions.

https://github.com/apache/dolphinscheduler/issues/3157

https://github.com/apache/dolphinscheduler/pull/3158

d4d6aded1184b803557f444c42253d02887995b9

bf3cc0d00ef27eb0523b4542e5905256e369b068

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/ZKServer.java", "dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/zk/ZKServerTest.java"]

[BUG] Embed zookeeper server 'ZKServer' has deadlock problem

*For better global communication, please give priority to using English description, thx! * **Describe the bug** look at the code snippet ```java private static synchronized void startLocalZkServer(final int port, final String dataDirPath,final int tickTime,String maxClientCnxns) { if (zkServer != null) { throw new RuntimeException("Zookeeper server is already started!"); } zkServer = new PublicZooKeeperServerMain(); logger.info("Zookeeper data path : {} ", dataDirPath); dataDir = dataDirPath; final String[] args = new String[]{Integer.toString(port), dataDirPath, Integer.toString(tickTime), maxClientCnxns}; try { logger.info("Zookeeper server started "); isStarted.compareAndSet(false, true); zkServer.initializeAndRun(args); } catch (QuorumPeerConfig.ConfigException e) { logger.warn("Caught exception while starting ZK", e); } catch (IOException e) { logger.warn("Caught exception while starting ZK", e); } } ``` The above start method will acquire the lock of the ZKServer class. But the line "zkServer.initializeAndRun(args);" will block until the application exit. So it will never release the lock. ```java private static synchronized void stopLocalZkServer(final boolean deleteDataDir) { // 省略 } ``` The above stop method try to acquire the lock of the ZKServer class, but it will never succeed. **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. **Which version of Dolphin Scheduler:** -[1.1.0-preview] **Additional context** Add any other context about the problem here. **Requirement or improvement - Please describe about your requirements or improvement suggestions.

https://github.com/apache/dolphinscheduler/issues/3140

https://github.com/apache/dolphinscheduler/pull/3141

6f9970b189d71d043e79200a70a95f2f33ad10f4

753ed58fb9f15f85240918fe6457cf9015ee5101

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/udp/udp.vue"]

[BUG] repeated task name in one flow

first add two different tasks,then rename one and keep both has a some name ,you will find you can save the flow with same name tasks.

https://github.com/apache/dolphinscheduler/issues/3077

https://github.com/apache/dolphinscheduler/pull/3376

26184de905b9e1a83b0e27e8e50e335f12131fdf

555880e6e32ab5235f1947fe036f43cef54e50c4

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/jsPlumbHandle.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/util.js"]

[BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definition

1. process definition  2. task instance order in database  3. task instance order in web ui  4.task instance order in process instance  The task running order in the process instance does not follow the topological order in the process definition, Why?

https://github.com/apache/dolphinscheduler/issues/3058

https://github.com/apache/dolphinscheduler/pull/3464

46f058698170fff573bbd02af74762ded639769c

e2553e33d78f438f8519f6e3dce1f555b002db65

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSource.java", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSourceTest.java", "pom.xml"]

[BUG] Hive JDBC connection parameter ignored

**Describe the bug** The jdbc connection parameter of Hive datasource, should append after the question mark when building jdbc url, like `jdbc:hive2://host:port/default?mapred.job.queue.name=root.users.a`. But actually, it append after the semicolon, so the result is `jdbc:hive2://host:port/default;mapred.job.queue.name=root.users.a`, which make the parameter being ignored  For testing, I set the parameter in this way `{"?mapred.job.queue.name":"root.user.a"}`, and now it can be set correctly **Which version of Dolphin Scheduler:** - [1.2.1-release]

https://github.com/apache/dolphinscheduler/issues/2923

https://github.com/apache/dolphinscheduler/pull/3194

6d43c21d80a3b210a7e01df9fa73d4f076698a58

98fdba6740abcb8dd30bc08d6ff39793dd9dd598

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/LowerWeightHostManager.java", "sql/h2.mv.db"]

[BUG] master server will show exception for some time when master server restart, it's just dispatching task

*For better global communication, please give priority to using English description, thx! * **Describe the bug** [ERROR] 2020-06-06 15:46:22.683 org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer:[152] - dispatch error org.apache.dolphinscheduler.server.master.dispatch.exceptions.ExecuteException: fail to execute : Command [type=TASK_EXECUTE_REQUEST, opaque=1, bodyLen=1619] due to no suitable worker , current task need to default worker group execute at org.apache.dolphinscheduler.server.master.dispatch.ExecutorDispatcher.dispatch(ExecutorDispatcher.java:87) at org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer.dispatch(TaskPriorityQueueConsumer.java:149) at org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer.run(TaskPriorityQueueConsumer.java:118) **To Reproduce** 1、worker server runs normally, click `start workflow` , 2、then restart master server , master server runtime log will show the following exception for some time(about 30 seconds), then master will go works normally **Which version of Dolphin Scheduler:** -[ dev-1.3.0 ]

https://github.com/apache/dolphinscheduler/issues/2910

https://github.com/apache/dolphinscheduler/pull/2913

0de8e589651396925f66549b75e57b9673669291

5c9b080ab85ffc458557ebcbb5e8bf30a7c40ed0

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java"]

[BUG] When editing user information, clear the phone number, the database table t_ds_user.phone is not cleared

  **Which version of Dolphin Scheduler:** -[dev-1.3.0]

https://github.com/apache/dolphinscheduler/issues/2892

https://github.com/apache/dolphinscheduler/pull/2898

4441d91dcf178653e55b94fe564c8c9907e897fa

ae9afcf77a930d10d1d61aa23172b831f1a41cdd

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java"]

[BUG] When a user has a resource directory tree, update the user's tenant to report an error

  **Which version of Dolphin Scheduler:** -[dev_1.3.0] **Additional context** Add any other context about the problem here. **Requirement or improvement - Please describe about your requirements or improvement suggestions.

https://github.com/apache/dolphinscheduler/issues/2860

https://github.com/apache/dolphinscheduler/pull/2876

6723454df9c7d85d3f034d2c13a080db4c130fc1

31dca43cdbaec861b2bfc5dc7407f50424216e3c

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java", "dolphinscheduler-server/src/main/resources/master.properties", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThreadTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/DependencyConfig.java"]

[BUG]the master would be blocked when worker group not exists

**Is your feature request related to a problem? Please describe.** i create a task with a special worker group, master would be blocked when the worker group does not exists, In this case, other tasks would not run anymore. version: [dev-1.3.0]

https://github.com/apache/dolphinscheduler/issues/2762

https://github.com/apache/dolphinscheduler/pull/2764

7d2441f63468fb4c9e340f0be0bd6844923a9743

7a05c007b45ea742e3ed1a7558c1a641515c140c

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java"]

[BUG] SQLTask replace the ${} of the SQL statement to "?" does not work

**Describe the bug** In the SqlTask the function ParameterUtils.replaceScheduleTime(sql, taskExecutionContext.getScheduleTime(), paramsMap) replaces all $ {} to real value, so the function setSqlParamsMap(sql, rgex, sqlParamsMap, paramsMap); does not work **Screenshots**  **Which version of Dolphin Scheduler:** -[dev-1.3.0]

https://github.com/apache/dolphinscheduler/issues/2739

https://github.com/apache/dolphinscheduler/pull/2741

cfd83235a29ec9e19f3c87a27e7d77edf3381c63

6d0375e46d07f386125a3c6e091e605a515df03d

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ResInfo.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/HeartBeatTask.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java", "dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue", "dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"]

[BUG]The IP and process pid of the master and worker in the monitoring center are not displayed  

  **Which version of Dolphin Scheduler:** -[dev_1.3.0]

https://github.com/apache/dolphinscheduler/issues/2735

https://github.com/apache/dolphinscheduler/pull/2770

3d857bba925348f4b92b9ba857c37fbca28549dd

396b1716e4e9b0f55f3686ba8e0283555c65c085

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java"]

Improve the security of datasource management

**Is your feature request related to a problem? Please describe.** Company database account management is relatively strict. We found that when the data source management is updated, the original password is actually brought out. （公司数据库账号管理比较严格，我们发现目前数据源管理更新得时候实际上是把原始密码给带出来了。） **Describe the solution you'd like** The datasources / update-ui interface should not take out the password. The datasources / updateDataSource interface does not update this field without passing the password. You can call the query one more time when the server is updated. （datasources/update-ui 接口不要将密码带出去，datasources/updateDataSource 接口不传 密码就不更新该字段，服务端更新时可以先多调用一次查询。）

https://github.com/apache/dolphinscheduler/issues/2638

https://github.com/apache/dolphinscheduler/pull/2844

fbb8ff438ad0c0db1bfc78d33bbc73b2c7d40683

1c153454423f4b967f3fcd8fb906a4626799872f

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"]

Process shows success,when the task of the process is killed in the terminal

重现步骤： 1、有两个工作流AA和BB，BB依赖AA。 2、AA中有test1和test2任务，test2任务依赖test1。 3、BB中有dependent和test3任务，dependent配置AA的test2，test3依赖dependent。 4、现在手工运行AA，（test1任务可以配置shell，shell中运行一个test1.sh文件，该文件中可以写个sleep 60s），在执行worker的终端kill掉该任务（这种情况是手工kill，实际生产中服务器压力大时很有可能被其他服务kill掉）。 5、此时显示工作流AA运行成功，AA中test1任务kill状态，test2任务没有运行。 6、手工运行BB，可以看到BB中dependent和test3任务都运行成功。 正确的场景是AA中test1被kill后，AA应该是失败状态而不是成功状态，BB因dependent失败而失败 -------------------------------------------------------------------------------------- Reproduction steps: 1. There are two workflows AA and BB, and BB depends on AA. 2. There are test1 and test2 tasks in AA, and test2 tasks depend on test1. 3. There are DEPENDENCT and test3 tasks in BB. DEPENDENCT configures test2 of AA, and test3 depends on the DEPENDENCT. 4. Now run AA manually (test1 task can configure the shell, and a test1.sh file can be run in the shell, and a sleep 60s can be written in the file). Kill the task at the terminal executing the worker (in this case, kill manually. In actual production, when the server is under great pressure, it is likely to be killed by other services). 5. At this time, the workflow AA runs successfully, the test1 task in AA is in kill status, and the test2 task is not running. 6. Run BB manually, and you can see that the DEPENDENCT and test3 tasks in BB run successfully. I think the correct scenario is that after test1 in AA is killed, AA should be in failure state instead of success state. BB fails due to the DEPENDENCT failure

https://github.com/apache/dolphinscheduler/issues/2634

https://github.com/apache/dolphinscheduler/pull/2731

9ffcd82447cd355955d110fe19afb33f465f9d7e

a9da86abb4545b1ac8fdc5cdd05e85bdcdffa9c6

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java"]

[BUG] /dolphinscheduler/projects/create doesn't return project ID when create successfuly

**Describe the bug** V1.2.0, when invoke /dolphinscheduler/projects/create, it doesn't return project ID when create successfuly just return { "code": 0, "msg": "success", "data": null } **Expected behavior** it should return project ID, otherwise, how can I build relationship between dolphin and my system. **Which version of Dolphin Scheduler:** -[1.2.0] **Additional context** Add any other context about the problem here. **Requirement or improvement - Please fix this or tell me how to get project ID for newly created project.

https://github.com/apache/dolphinscheduler/issues/2619

https://github.com/apache/dolphinscheduler/pull/2804

e89f543f04872b2b7d8d3c5cd94e68cd4ddaab7e

fbb8ff438ad0c0db1bfc78d33bbc73b2c7d40683

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java"]

[BUG] code annotation error

incubator-dolphinscheduler-dev/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java Source code： /** * master server startup * * master server not use web service * @param args arguments */ public static void main(String[] args) { Thread.currentThread().setName(Constants.THREAD_NAME_WORKER_SERVER); new SpringApplicationBuilder(WorkerServer.class).web(WebApplicationType.NONE).run(args); } The master in the annotation on lines 74 and 76 should be changed to worker.

https://github.com/apache/dolphinscheduler/issues/2603

https://github.com/apache/dolphinscheduler/pull/2614

8e080ef6085e285480e906ee8dee301e3790bc02

8c8e128d18b2a1e189b05554a8c011749c1408b7

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java"]

[BUG] After renaming the file, downloading the file gives an error

1. create file is test_1.sh 2. The file is renamed to test_1.txt, and the file name displayed on the page is "test_1.txt.sh" 3. Download file, prompt "error downloading resource file" 4. Check the hdfs resource file is "test_1.txt"    **Which version of Dolphin Scheduler:** -[dev]

https://github.com/apache/dolphinscheduler/issues/2598

https://github.com/apache/dolphinscheduler/pull/2732

63ce143be5fd76ea08f9fcf73e7720cb1be99297

60f8eb25fa69fa39cd17404b9eb66376c174b9c3

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["docker/build/README.md", "docker/build/README_zh_CN.md", "docker/build/conf/dolphinscheduler/worker.properties.tpl", "docker/docker-swarm/docker-compose.yml", "docker/docker-swarm/docker-stack.yml", "docker/kubernetes/dolphinscheduler/README.md", "dolphinscheduler-server/src/main/resources/worker.properties"]

[Feature] 建议k8s部署的时候默认数据库是MySQL，降低使用门槛

建议k8s部署的时候默认数据库是MySQL，降低使用门槛。 目前随着Tidb等NewSQL数据库的流行，NewSQL会成为技术中台的首选数据库，而Tidb作为一个非常火的项目是搭建技术中台的首选数据库，Tidb兼容MySQL协议而非pg协议，所以incubator-dolphinscheduler的数据直接建在Tidb上是非常合适的

https://github.com/apache/dolphinscheduler/issues/2584

https://github.com/apache/dolphinscheduler/pull/4875

139211f3ddf9e30fb058c659fd467b18a95d0dbe

bfc5d1e4ba08cc19059bb40293bb0777b3d42377

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"]

[BUG] When the process involves sub-processes, the complement operation will only take the start time, and will repeat the number of days to perform the complement

*For better global communication, please give priority to using English description, thx! * **Describe the bug** When the process involves sub-processes, the complement operation will only take the start time, and will repeat the number of days to perform the complement. **To Reproduce** Steps to reproduce the behavior, for example: 1. Create a simple sub-process, such as a shell 2. Create another main process and associate sub-processes 3. For complement operation, you can also make up only two days The specific operation is as follows： 1. Create subprocess，  2. Save subprocess and setting variables  3. Create the main process and create sub node as in main process   4. Save main process and setting variables  5. As follow.  6. Then complement  7. The result is as follows, the date printed is only the start date    8. The timing of the main process is correct  **Which version of Dolphin Scheduler:** -[1.2.1] - Stand-alone deployment

https://github.com/apache/dolphinscheduler/issues/2581

https://github.com/apache/dolphinscheduler/pull/2656

050dae7ca4a1b6243fbc0dd9c4018d45e1655566

d54aab5cd530b2e135a58fbd6b22564583b5abb8

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/list.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"]

[BUG]wrong description of work flow copy tips

 version: dev i think the tips should be "work flow copy"

https://github.com/apache/dolphinscheduler/issues/2578

https://github.com/apache/dolphinscheduler/pull/2612

6a92bef5e36dd6c7100517cfa516ca9c8603d950

fadfb28187f48648230094e05f946d2b41e8f67a

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java"]

[Feature]Configurable registration ipaddress

**Is your feature request related to a problem? Please describe.** on macos,OSUtils.getHost() returns diffrent ip in running time. Also,the method OSUtils.getHost() didn't perform well in container situation like docker ,some error may happen **Describe the solution you'd like** provide a param like register-ip to specific the ip which will be registried on zk **Describe alternatives you've considered** provide a param like networkinterface to specific the networkinterface which will be registried on zk **Additional context** <img width="1467" alt="8C1E5A5B-CC64-40FE-9049-5FC6154E72FE" src="https://user-images.githubusercontent.com/42403258/80572245-80ab6180-8a30-11ea-9525-73b33f1bf49e.png"> <img width="1481" alt="25DECE0A-2A92-479F-A76F-7DAEB8F691FF" src="https://user-images.githubusercontent.com/42403258/80572256-8608ac00-8a30-11ea-8784-eeb88c0fb7ea.png"> 英文不好,简单的说就是可以指定注册到zk上的ip或可选的网卡配置

https://github.com/apache/dolphinscheduler/issues/2574

https://github.com/apache/dolphinscheduler/pull/3186

6c9ac84f73a20717ab1014fe8c09e98668262baa

6f9970b189d71d043e79200a70a95f2f33ad10f4

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java", "sql/dolphinscheduler_mysql.sql"]

[Feature]unique processdefinition name in the same project

**branch** dev **Is your feature request related to a problem? Please describe.** if the same name in one project ,im hard to recognize any one . And its usually caused by mistake **Describe the solution you'd like** unique processDifinition name in one project **Additional context** name suffix is also good

https://github.com/apache/dolphinscheduler/issues/2559

https://github.com/apache/dolphinscheduler/pull/2617

33658d57fd9149cc8321e53683eeb756076fe7d7

6127f3a4609cda2937f47432e5c2c2ddb75c4452

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue"]

[BUG] The create user is always loading when the queue does not select any value

**The create user is always loading when the queue does not select any value** Prerequisite: queue is not required to fill **Steps to reproduce the issue** 1. Click create user 2. User name, password, tenant, email mobile phone number are filled in correctly 3. Only the queue is empty () 4. submit 5. error: Display "loading" all the time **expected result** Successfully create the user when the queue is empty, so I can use the tenant's queue, because the priority of the user's queue is higher than that of the tenant's queue. **DolphinScheduler1.2.0** **Screenshots** 

https://github.com/apache/dolphinscheduler/issues/2545

https://github.com/apache/dolphinscheduler/pull/2558

632b2b503a7d4fc4d9a24961d5e4139b8373ccbc

697ea0f65625995a07b03ef892cf0f841b8926dd

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"]

[BUG]The task is in progress, the master and worker hang up , start the master and worker again, the process instance and task are not fault-tolerant

1.The task is in progress 2. Worker hangs first, then hangs master 3.start the master and worker again, the process instance and task are not fault-tolerant,Status has been in progress     **Which version of Dolphin Scheduler:** -[dev]

https://github.com/apache/dolphinscheduler/issues/2499

https://github.com/apache/dolphinscheduler/pull/2833

f25069bf839cb76c6dd3bcd58887040f8317d7f6

d67436ffad7afe4985d843bc63cab260667ed7d7

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["script/dolphinscheduler-daemon.sh"]

[BUG] sh stop-all.sh, the master service is not killed  

1. sh stop-all.sh 2. Check the master service，the master service is not killed     **Which version of Dolphin Scheduler:** -[dev]

https://github.com/apache/dolphinscheduler/issues/2492

https://github.com/apache/dolphinscheduler/pull/2497

e837a73fcd823be5f7488d0b36085a044239defe

21c10f886288ee6667f052eff294da7964de8e64

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/resources/config/install_config.conf", "install.sh"]

[BUG] the Mysql needs to configure with“allowMultiQueries = true”,

1.Since MYSQL does not support batch upload, the data source needs to be configured with“allowMultiQueries = true”, otherwise an error will be occurred when deleting resource files。mysql configuration is as follows： spring.datasource.url=jdbc:mysql://192.168.xx.xx:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8&allowMultiQueries=true 2.It is recommended to change the database name to configurable **Which version of Dolphin Scheduler:** -[dev]

https://github.com/apache/dolphinscheduler/issues/2481

https://github.com/apache/dolphinscheduler/pull/2573

b5dbe94f07166d7dfd4dad531c2763bc39951815

632b2b503a7d4fc4d9a24961d5e4139b8373ccbc

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/DependentTaskExecThread.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/DependentExecute.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/DependentTaskTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"]

[BUG] dependent task failed when conditions task exists

 description: 1. work flow A have a conditions task. 2. work flow B have a dependent task that depend work A 3. work flow B would failed always.

https://github.com/apache/dolphinscheduler/issues/2464

https://github.com/apache/dolphinscheduler/pull/2768

7a05c007b45ea742e3ed1a7558c1a641515c140c

184d64e85291b1e8fb82494bf5a8e2ea755a3dc1

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java"]

[BUG] cannot complement data for one day

cannot complement data for one day. 

https://github.com/apache/dolphinscheduler/issues/2450

https://github.com/apache/dolphinscheduler/pull/2493

2f5427ca33b8e929d58412699699141191c640b4

b5fdce4164385f1df2ddb25c9441b50ea28ce681

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java"]

[BUG] update the directory of resource is error

update the directory occasionally appears the resource file does't exist, and the actual update directory is successful    **Which version of Dolphin Scheduler:** -[dev]

https://github.com/apache/dolphinscheduler/issues/2442

https://github.com/apache/dolphinscheduler/pull/2524

c50ad1240c4789403e9518c855c0217fc9030b5b

e6dec8d2a7a6d39280675d225ec818e0cc7012be

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"]

[BUG] master fault tolerance error

1. Start one master1 and two workers 2. Task setting timing, executed once every 1 minute, online timing 3. There are 3 workflow instances running on the master1 service, and the task shell_task_1 of the workflow instance is also in the "running" state. 4. Start the master2 service, the host of the workflow instance changes from master1 to master2, and the task shell_task_1 also starts fault-tolerant processing, as shown in the following figure, and finally shell_task_1 is executed 3 times: =============================================== 1.启动一台master1 ， 2台worker 2.任务设置定时，1分钟执行一次，上线定时 3.有3个工作流实例在master1服务上运行，其中工作流实例的任务shell_task_1也处于“正在运行”状态 4.启动master2服务，工作流实例的host从master1变为master2，任务shell_task_1也开始容错处理，如下图所示，最终shell_task_1被执行3次： ===============================================    **Which version of Dolphin Scheduler:** -[refactor-worker]

https://github.com/apache/dolphinscheduler/issues/2350

https://github.com/apache/dolphinscheduler/pull/2375

c9620ab557ec4c8d0bef1c87c93348b238a7bd8e

785c34bc66b04dbccbd64639850dc44d67957aba

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"]

[BUG]Visit the worker page of the monitoring center, a null pointer occur

  **Which version of Dolphin Scheduler:** -[refactor-worker]

https://github.com/apache/dolphinscheduler/issues/2349

https://github.com/apache/dolphinscheduler/pull/2375

c9620ab557ec4c8d0bef1c87c93348b238a7bd8e

785c34bc66b04dbccbd64639850dc44d67957aba

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-dao/src/main/resources/application.properties", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentExecute.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentTask.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentTaskTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "pom.xml"]

this workflow is bug , I think it's a very serious problem

Is I also found a problem, it is a bug, is I have two workflow of a and b, then a workflow Riga, a1 node b work new b1 task dependent nodes, type selection, the chosen today, relying on a1, my situation is such, a workflow, I have the day before the creation of a1 run through a process, and then I run b process, theory should be run failed, but in fact was a success.I am also drunk, similarly I choose the type of b1 yesterday also can run successfully, but the first three days before the election run failed.That logo is faild

https://github.com/apache/dolphinscheduler/issues/2282

https://github.com/apache/dolphinscheduler/pull/2329

949b8ef17d2b734b239ce31c997d7084868347b7

69e000b54214e8331ede69bdce9710b8418e960e

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java"]

[BUG] SqlTask kerberos authentication process

*For better global communication, please give priority to using English description, thx! * **Describe the bug** When the keytab is expired or deactivated, other tasks that did not require authentication also failed. Obviously there is something wrong with the kerberos authentication process and it should only do it when it is needed. **Which version of Dolphin Scheduler:** -[1.2.1-release] **Requirement or improvement - Change CommonUtils.loadKerberosConf() call scope;

https://github.com/apache/dolphinscheduler/issues/2178

https://github.com/apache/dolphinscheduler/pull/2321

a851168a350e300becb3452e91871220ffa3a5fc

d4735334a1986fedd5b92d185dc6d46be93cb071

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/process/ProcessImplForWin32.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/shell/ShellTaskTest.java"]

[BUG] sun.misc.JavaIOFileDescriptorAccess is not portable

Current implementation relies on `sun.misc.JavaIOFileDescriptorAccess` which is only accessible on oraclejdk8. Basically the demand is getting & setting `field` field of `FileDescriptor`, so we can directly do that with reflection. Though, I suspect the necessity we introduce `ProcessImplForWin32`. Maybe we could have a better way to support worker server to run bat script.

https://github.com/apache/dolphinscheduler/issues/2111

https://github.com/apache/dolphinscheduler/pull/2113

450a1f56fc73f088fce89a343a0b008706f2088c

9224b49b58b756d22c75d8929108f716283282b4

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/conditions/ConditionsParameters.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java"]

[BUG] After renaming the branch name, the name of Branch Flow does not change

更改任务名称后，分支流转的名称还是更改前的任务名称  **Which version of Dolphin Scheduler:** -[1.2.0_release]

https://github.com/apache/dolphinscheduler/issues/2101

https://github.com/apache/dolphinscheduler/pull/4555

cfd9db5555b3d8f9f33f25a9272c8741115a9336

14d49bc584685a33e2952573a0cb6e88377ab9f9

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["install.sh"]

[BUG] install.sh will happen "sh: bin/dolphinscheduler-daemon.sh: No such file or directory" when first deploy

**Describe the bug** when I first deploy the DolphinScheduler, I find that ``` # 3,stop server echo "3,stop server" sh ${workDir}/script/stop-all.sh ... # 5,scp resources echo "5,scp resources" sh ${workDir}/script/scp-hosts.sh if [ $? -eq 0 ] then echo 'scp copy completed' else echo 'scp copy failed to exit' exit -1 fi ``` **Which version of Dolphin Scheduler:** -[1.2.0] **how to solve** the 3 step should change position to the 5 step, becase on the 3 step, the shell scripts not exists in the install path

https://github.com/apache/dolphinscheduler/issues/1996

https://github.com/apache/dolphinscheduler/pull/1998

b4f2e5f4210ce70d6ec50e68fd177ee26841fc03

5ecd3b30b923dc4dfa6ac846b6ac44bfb2f8e11f

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/jsPlumbHandle.js"]

[BUG] The task details window did not close properly.

**Describe the bug** The task details window did not close properly. **To Reproduce** 1. Go to the page of the definition create or definition edit. 2. Drag to create a new task node or edit an exist node. And the task details window will be open. 3. Delete the task node or click the DataSource menu. 4. See error. The task details window still open. **Which version of Dolphin Scheduler:** -[dev] **Requirement or improvement The task details window should be close.

https://github.com/apache/dolphinscheduler/issues/1968

https://github.com/apache/dolphinscheduler/pull/1969

d7d7e95498cd69132660c7287052bb328a76f4ec

afd5c75cd27c9fe1a7efcafbed92bf28fc3996e5

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractTask.java"]

[suggest] The method getcurtaskparamsclass() of class abstracttask is the same as the function of class taskparametersutils Functions can be replaced

*For better global communication, please give priority to using English description, thx! * **Describe the bug** The method getCurTaskParamsClass() of class AbstractTask is the same as the function of class TaskParametersUtils Functions can be replaced **To Reproduce** **Expected behavior** - Delete the method getcurtaskparamsclass() of class abstracttask **Screenshots** If applicable, add screenshots to help explain your problem. **Which version of Dolphin Scheduler:** -[1.2.1-dev] **Additional context** **Requirement or improvement Getcurtaskparamsclass() function of class abstracttask is replaced by taskparametersutils

https://github.com/apache/dolphinscheduler/issues/1682

https://github.com/apache/dolphinscheduler/pull/4262

3bcd3fbcd344983ed35f997bed1fea2c0cf6055d

24864512212a94f53da32eb20dc56673f960547a

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerThread.java"]

[BUG] code comment error

**Describe the bug** in this class: org.apache.dolphinscheduler.server.master.runner.MasterSchedulerThread. the line number 104, zkMasterClient.getMasterLockPath() The lock path obtained may should be /dolphinscheduler/lock/masters, but in the comment, is's /dolphinscheduler/lock/failover/master, I think it's easy to mislead people who read the source code, please check this, if it does, I can open a pr to fix it **To Reproduce** None **Expected behavior** Node **Screenshots** None **Which version of Dolphin Scheduler:** latest version **Additional context** None **Requirement or improvement None

https://github.com/apache/dolphinscheduler/issues/1442

https://github.com/apache/dolphinscheduler/pull/1446

a1ded5ee041a387d56757fcdd27e39efd3a6000a

9a3a6f5a3d5ec613b49ae1a5a947d58c351f1fc7

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java"]

[Feature] add user error when user name contains '.'

**Is your feature request related to a problem? Please describe.** add a user when user name contains '.' i think maybe the username regex string is error.

https://github.com/apache/dolphinscheduler/issues/1441

https://github.com/apache/dolphinscheduler/pull/1445

b276ece5727bdf7cecc07bfc888f27cb75726b65

a1ded5ee041a387d56757fcdd27e39efd3a6000a

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java"]

[BUG] The wrong field order in logger.info

**Describe the bug** The method onlineCreateResource in class ResourcesController，The logger.info has wrong field order with fileName and type. **Screenshots** <img width="1021" alt="" src="https://user-images.githubusercontent.com/3699743/70215243-0f64cc80-1778-11ea-9ec5-f6a38559b051.png"> **Which version of Dolphin Scheduler:** - [dev-db branch]

https://github.com/apache/dolphinscheduler/issues/1399

https://github.com/apache/dolphinscheduler/pull/1400

b3a0e1fd148c876d61bce92fea14528c3fb2cf45

f134453bb838c76f046fc450ef15afccd857074e

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"]

[BUG] [api]Dependent execution fails after task performs serial complement

**To Reproduce** 1. A task depends on B task, the deviation range is the first 3 days 2. The serial complement of 3 days before the B task execution 3. Run workflow, dependent execution fails  **Which version of Dolphin Scheduler:** -[1.2.0]

https://github.com/apache/dolphinscheduler/issues/1336

https://github.com/apache/dolphinscheduler/pull/3331

624f0aeab9621abbbc9584c4a3167cb1bd2dcf00

5f725aa28b2edbd246480a554ac7822bf07fbbfd

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["escheduler-server/src/main/java/cn/escheduler/server/utils/LoggerUtils.java"]

The task instance of MR cannot stop in some cases

The task instance of MR cannot stop in some cases

https://github.com/apache/dolphinscheduler/issues/516

https://github.com/apache/dolphinscheduler/pull/560

f880a76d7a3a95d4b425a16853456025292b8c03

d3e59773085cf287e908a789b58a14285a57da43

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui-next/src/locales/modules/en_US.ts", "dolphinscheduler-ui-next/src/locales/modules/zh_CN.ts", "dolphinscheduler-ui-next/src/views/security/user-manage/components/user-detail-modal.tsx"]

Stand-alone fault tolerance (running, fault tolerance...)（单机容错（正在运行、容错。。。））

https://github.com/apache/dolphinscheduler/issues/319

https://github.com/apache/dolphinscheduler/pull/9683

a51b710b1c8ae43d9e9bcbc386af4d81fb7e6b65

86bdb826dc4df912a60d1cd8bbaffc7ad2b6913f

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-ui/src/views/datasource/list/detail.tsx", "dolphinscheduler-ui/src/views/datasource/list/use-form.ts"]

One-click deployment optimization, use the boot, target 30 minutes to get started （一键部署优化，使用上引导，目标30分钟上手）

One-click deployment optimization, use the boot, target 30 minutes to get started --- 一键部署优化，使用上引导，目标30分钟上手

https://github.com/apache/dolphinscheduler/issues/104

https://github.com/apache/dolphinscheduler/pull/10876

1edbb5e333eb91bc04002d7f15b15c8511fd7eed

56fe11ecf9e50bdd984920a065b8ba0680e741f1

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/K8sNamespaceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/K8SNamespaceServiceTest.java"]

Missing LogParameter and RetStrInfo（缺少LogParameter和RetStrInfo）

LogViewServiceGrpc cannot find LogParameter and RetStrInfo below --- LogViewServiceGrpc 下面找不到LogParameter和RetStrInfo

https://github.com/apache/dolphinscheduler/issues/15

https://github.com/apache/dolphinscheduler/pull/15546

25810a81dc528feedd81e44f8f57469286c0e8c7

2f66a667ba6bed20003cfb17af3f347166e678c1

java

closed

apache/dolphinscheduler

https://github.com/apache/dolphinscheduler

["docs/configs/docsdev.js"]

The link address is missing(链接地址缺少)

https://github.com/apache/dolphinscheduler/issues/1

https://github.com/apache/dolphinscheduler/pull/15660

502b49a1cb845c04c6b754e88748d2de8ef84508

040ab34bafa25c5fd17f4ca172f05f55aa2ab446

java