idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
---|---|---|---|---|---|
7,776,928 | 107,022,856 | 2022-04-22 10:23:20.490 | /builds/gitlab-org/quality/triage-ops/lib/missed_resource_helper.rb:29:in `move_to_current_milest... | Sentry Issue: [TRIAGE-OPS-D8](https://sentry.gitlab.net/gitlab/triage-ops/issues/3269330/?referrer=gitlab_integration)
```
/builds/gitlab-org/quality/triage-ops/lib/missed_resource_helper.rb:29:in `move_to_current_milestone': undefined method `title' for nil:NilClass (NoMethodError)
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/resource/context.rb:28:in `eval'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/resource/context.rb:23:in `instance_eval'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/resource/context.rb:23:in `eval'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/text_content_builder.rb:63:in `eval_interpolation'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/text_content_builder.rb:53:in `format_item'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/base_command_builder.rb:34:in `block in content_string'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/base_command_builder.rb:33:in `map'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/base_command_builder.rb:33:in `content_string'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/command_builders/base_command_builder.rb:14:in `build_command'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action/comment.rb:43:in `build_comment'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action/comment.rb:32:in `block in act'
from /usr/local/lib/ruby/2.7.0/delegate.rb:83:in `each'
from /usr/local/lib/ruby/2.7.0/delegate.rb:83:in `method_missing'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action/comment.rb:31:in `act'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action.rb:28:in `act'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action.rb:16:in `block in process'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action.rb:15:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/action.rb:15:in `process'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:324:in `process_action'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:186:in `block (2 levels) in process_rules'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:308:in `block in resources_for_rule'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/expand_condition.rb:13:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/expand_condition.rb:13:in `perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:278:in `resources_for_rule'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:182:in `block in process_rules'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:181:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:181:in `process_rules'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:76:in `block in perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:67:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/lib/gitlab/triage/engine.rb:67:in `perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/bin/gitlab-triage:18:in `block in <top (required)>'
from /usr/local/lib/ruby/2.7.0/set.rb:328:in `each_key'
from /usr/local/lib/ruby/2.7.0/set.rb:328:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.23.0/bin/gitlab-triage:11:in `<top (required)>'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/bin/gitlab-triage:23:in `load'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/bin/gitlab-triage:23:in `<main>'
```
I believe the problem is in the `Issuable#root_id` method in `gitlab-triage`: https://gitlab.com/gitlab-org/ruby/gems/gitlab-triage/-/blob/870ca5c6964740829351ec039d08928c19621aed/lib/gitlab/triage/resource/shared/issuable.rb#L72 | 2 |
7,776,928 | 107,024,128 | 2022-04-21 23:56:17.670 | Bot message cleanup refactoring | We have a wide implementation of bot automated message and this can be overwhelming and noisy to our team members.
Create this issue to start reducing / redundant or irrelevant messages
1. Bot messages containing code related requirements in documentation MR
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/80756#note_920336781
- Add docs minimal job context?
1. Redundant prompt to apply labels
- https://gitlab.com/gitlab-org/gitlab/-/issues/359166#note_914475256
cc @rymai @kwiebers I created this issue to start refactoring bot messages based on feedback heard.
If you have seen anymore of these please add to them | 2 |
7,776,928 | 106,786,438 | 2022-04-18 17:04:56.014 | Rename event_user to event_actor | So we can finally move away from `event_user` which is sometimes confusing with `resource_user`. The idea is that:
* `event_user` -> `event_actor`
* `resource_user` -> `resource_author` | 1 |
7,776,928 | 106,652,916 | 2022-04-14 16:10:52.148 | Consider enabling the `LabelInference` processor for `gitlab-com/runbooks` | We should consider enabling the `LabelInference` processor for the https://gitlab.com/gitlab-com/runbooks project, e.g. https://gitlab.com/gitlab-com/runbooks/-/merge_requests/4518#note_bb9e07f01265e875fefcd649863efe112f391cb8.
Related to https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/1190#note_846835116. | 2 |
7,776,928 | 106,465,289 | 2022-04-11 18:46:06.848 | Remove conflicting sub-work type if a different scoped type is applied | ## Objective
Reduce misalignment of sub and parent [Work types](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification) on issues and merge requests.
A one-off migration may need to be done to fix any contradicting parent and sub type on open issues and merge requests.
This would be similar to https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/triage/processor/label_inference.rb but to remove child labels when a different type label is added (currently it adds and removes parent labels when a child label is added). | 3 |
7,776,928 | 106,284,538 | 2022-04-07 22:05:59.181 | Add New Category Labels for Group:: Authentication and Authorization | ## Summary
This template is for new or renaming Category labels. This review helps to ensure there will be no impact with triage automation and reports.
### Action items
* [x] Link the merge request to www-gitlab-com for the [category.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/categories.yml) change - https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/101822
* [ ] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]".
/cc @gl-quality/eng-prod | 1 |
7,776,928 | 105,830,413 | 2022-03-31 15:32:45.133 | Move Category:Pages issues to group:editor | ## Summary
This template is for new or renaming Category labels. This review helps to ensure there will be no impact with triage automation and reports.
~"group::editor" is now the group responsible for ~"Category:Pages" so we need to migrate the issue and MR labels accordingly. This should only be done on **open** issues and MRs.
More detail here: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/100227#note_895335961
### Action items
* [ ] Link the merge request to www-gitlab-com for the [category.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/categories.yml) change
* [ ] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]".
/cc @gl-quality/eng-prod | 2 |
7,776,928 | 105,439,409 | 2022-03-24 15:25:47.656 | Add @gitlab-release-tools-bot to Automation Accounts | https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/101092 should not have ~"Community contribution" applied or thanks. | 1 |
7,776,928 | 105,340,361 | 2022-03-23 10:14:50.406 | Gitlab::Error::BadRequest: Server responded with code 400, message: 400 Bad request - Note {:note=>["can't be blank"]} in `AvailabilityPriority` | Sentry Issue: [TRIAGE-OPS-BM](https://sentry.gitlab.net/gitlab/triage-ops/issues/3237312/?referrer=gitlab_integration)
```
Gitlab::Error::BadRequest: Server responded with code 400, message: 400 Bad request - Note {:note=>["can't be blank"]}. Request URI: https://gitlab.com/api/v4/projects/278964/merge_requests/83494/notes
gitlab/request.rb:71:in `validate'
raise error_klass, response if error_klass
gitlab/request.rb:55:in `block (2 levels) in <class:Request>'
validate response
triage/triage/reaction.rb:22:in `post_request'
Triage.api_client.post(path, body: { body: body }) unless Triage.dry_run?
triage/triage/reaction.rb:12:in `add_comment'
Reaction.post_request(path, body)
triage/processor/availability_priority.rb:43:in `ensure_priority'
add_comment("/label ~priority::#{default}")
...
(16 additional frame(s) were not displayed)
``` | 2 |
7,776,928 | 105,339,117 | 2022-03-23 09:56:32.474 | no implicit conversion of nil into String in `RemindMergedMrDeviatingFromGuideline` | Sentry Issue: [TRIAGE-OPS-BN](https://sentry.gitlab.net/gitlab/triage-ops/issues/3237542/?referrer=gitlab_integration)
```
TypeError: no implicit conversion of nil into String
time.rb:372:in `_parse'
d = Date._parse(date, comp)
time.rb:372:in `parse'
d = Date._parse(date, comp)
triage/processor/remind_merged_mr_deviating_from_guidelines.rb:58:in `latest_pipeline_is_recent_enough?'
Time.parse(latest_pipeline_detailed.finished_at) >= (Time.now - 3600 * HOURS_THRESHOLD_FOR_STALE_MR_PIPELINE)
triage/processor/remind_merged_mr_deviating_from_guidelines.rb:40:in `latest_pipeline_valid?'
latest_pipeline_is_recent_enough?
triage/processor/remind_merged_mr_deviating_from_guidelines.rb:20:in `applicable?'
!latest_pipeline_valid?
...
(14 additional frame(s) were not displayed)
``` | 2 |
7,776,928 | 102,961,942 | 2022-02-24 01:08:59.416 | Close issues that have the 'auto closed' label but are not actually closed | Due to a bug fixed at https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/1184, there are a number of issues in `gitlab-org/customers-gitlab-com` and `gitlab-org/license-gitlab-com` that have issues labelled with ~"auto closed" but are not actually closed.
Let's perform a once-off job to close this issues to keep things tidy. | 2 |
7,776,928 | 102,914,116 | 2022-02-23 09:55:42.198 | Consolidate the `Accepting merge requests` and `Seeking community contributions` hygiene policies | Kind of a follow-up to https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/1101 which can result in duplicate notes from the bot:
![Screen_Shot_2022-02-23_at_10.42.28](/uploads/83e74d18bbe73b24a90bf81ee9ff0070/Screen_Shot_2022-02-23_at_10.42.28.png)
I'll consolidate both labels automation in a single file. | 2 |
7,776,928 | 102,498,775 | 2022-02-15 18:30:57.158 | Make AppSec review comments for JiHu contributions in the CNG repository | We recently had [a JiHu contribution](https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/886#note_843817808) that was properly labeled as ~"JiHu contribution" but did not get the AppSec comment. I'm guessing the CNG repository isn't something that triage-ops is monitoring. This may be intentional, so there may be a reason for this that I'm unaware of.
Ideally, AppSec would be getting pings for this repository as well.
If there's a reason why triage-ops doesn't/can't monitor this repository, we can try to figure out another way to get AppSec reviews of those MRs. | 2 |
7,776,928 | 102,491,841 | 2022-02-15 16:17:46.111 | Apply type label from related issue | ## Objective
Increase ~type::* label coverage and accuracy by automatically applying types from issues when 1 type can be inferred from related issues
## Proposal
When a merge request does not have a type::* and has a related issue or issues where 1 type::* label is available, apply the type label from the issue(s) to the merge request | 3 |
7,776,928 | 102,431,293 | 2022-02-14 17:28:59.351 | Look at current labels instead of added labels in PlanUxMrReviewSupport | The following discussion from !1111 should be addressed:
- [ ] @mvanremmerden started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/1111#note_836167763): (+3 comments)
> @rymai @markglenfletcher It seems like the script might not actually pick up items as expected, shouldn't it have been triggered for this MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/80124#note_8195fb85c4f7c66c218e1213f8b96c5dc3c33a89 | 1 |
7,776,928 | 102,424,808 | 2022-02-14 16:04:43.270 | TypeError: no implicit conversion of nil into String | triage/processor/remind_merged_mr_deviating_from_guidelines.rb:44:in `latest_pipeline_is_recent_enough?' | Sentry Issue: [TRIAGE-OPS-9J](https://sentry.gitlab.net/gitlab/triage-ops/issues/3184468/?referrer=gitlab_integration)
```
TypeError: no implicit conversion of nil into String
time.rb:372:in `_parse'
d = Date._parse(date, comp)
time.rb:372:in `parse'
d = Date._parse(date, comp)
triage/processor/remind_merged_mr_deviating_from_guidelines.rb:44:in `latest_pipeline_is_recent_enough?'
Time.parse(latest_pipeline_detailed.finished_at) >= (Time.now - 3600 * HOURS_THRESHOLD_FOR_STALE_MR_PIPELINE)
triage/processor/remind_merged_mr_deviating_from_guidelines.rb:18:in `applicable?'
(!latest_pipeline_is_canonical? || !latest_pipeline_is_recent_enough?)
triage/triage/processor.rb:38:in `triage'
return unless applicable?
...
(20 additional frame(s) were not displayed)
```
I think this happens when the latest pipeline is still running. In that case, we should return `true`. | 1 |
7,776,928 | 102,367,224 | 2022-02-14 01:07:14.793 | Cannot run specs locally | When attempting to run `bundle exec rspec` locally, there are two failures:
```sh
Failures:
1) ThreatInsightsHelper#threat_insights_fe retrieves team members from www-gitlab-com and returns a random threat insights frontend engineer
Failure/Error: json = with_retries { HTTParty.get(json_url, format: :plain) }
WebMock::NetConnectNotAllowedError:
Real HTTP connections are disabled. Unregistered request: GET https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json with headers {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Ruby'}
You can stub this request with the following snippet:
stub_request(:get, "https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json").
with(
headers: {
'Accept'=>'*/*',
'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'User-Agent'=>'Ruby'
}).
to_return(status: 200, body: "", headers: {})
============================================================
# ./lib/www_gitlab_com.rb:43:in `block in fetch_json'
# ./lib/www_gitlab_com.rb:54:in `with_retries'
# ./lib/www_gitlab_com.rb:43:in `fetch_json'
# ./lib/www_gitlab_com.rb:39:in `roulette'
# ./lib/team_member_select_helper.rb:39:in `out_of_office_team_members'
# ./lib/team_member_select_helper.rb:44:in `out_of_office?'
# ./lib/team_member_select_helper.rb:32:in `block in select_team_member_usernames'
# ./lib/team_member_select_helper.rb:31:in `each'
# ./lib/team_member_select_helper.rb:31:in `each_with_object'
# ./lib/team_member_select_helper.rb:31:in `select_team_member_usernames'
# ./lib/team_member_select_helper.rb:16:in `select_team_members_by_department_specialty_role'
# ./lib/team_member_select_helper.rb:8:in `select_random_team_member'
# ./lib/threat_insights_helper.rb:16:in `threat_insights_fe'
# ./spec/lib/threat_insights_helper_spec.rb:43:in `block (3 levels) in <top (required)>'
2) ThreatInsightsHelper#threat_insights_be retrieves team members from www-gitlab-com and returns a random threat insights backend engineer
Failure/Error: json = with_retries { HTTParty.get(json_url, format: :plain) }
WebMock::NetConnectNotAllowedError:
Real HTTP connections are disabled. Unregistered request: GET https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json with headers {'Accept'=>'*/*', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent'=>'Ruby'}
You can stub this request with the following snippet:
stub_request(:get, "https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json").
with(
headers: {
'Accept'=>'*/*',
'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
'User-Agent'=>'Ruby'
}).
to_return(status: 200, body: "", headers: {})
============================================================
# ./lib/www_gitlab_com.rb:43:in `block in fetch_json'
# ./lib/www_gitlab_com.rb:54:in `with_retries'
# ./lib/www_gitlab_com.rb:43:in `fetch_json'
# ./lib/www_gitlab_com.rb:39:in `roulette'
# ./lib/team_member_select_helper.rb:39:in `out_of_office_team_members'
# ./lib/team_member_select_helper.rb:44:in `out_of_office?'
# ./lib/team_member_select_helper.rb:32:in `block in select_team_member_usernames'
# ./lib/team_member_select_helper.rb:31:in `each'
# ./lib/team_member_select_helper.rb:31:in `each_with_object'
# ./lib/team_member_select_helper.rb:31:in `select_team_member_usernames'
# ./lib/team_member_select_helper.rb:16:in `select_team_members_by_department_specialty_role'
# ./lib/team_member_select_helper.rb:8:in `select_random_team_member'
# ./lib/threat_insights_helper.rb:12:in `threat_insights_be'
# ./spec/lib/threat_insights_helper_spec.rb:35:in `block (3 levels) in <top (required)>'
--snip--
Finished in 5.06 seconds (files took 3.42 seconds to load)
1521 examples, 2 failures
Failed examples:
rspec ./spec/lib/threat_insights_helper_spec.rb:40 # ThreatInsightsHelper#threat_insights_fe retrieves team members from www-gitlab-com and returns a random threat insights frontend engineer
rspec ./spec/lib/threat_insights_helper_spec.rb:32 # ThreatInsightsHelper#threat_insights_be retrieves team members from www-gitlab-com and returns a random threat insights backend engineer
``` | 2 |
7,776,928 | 102,027,886 | 2022-02-08 00:24:37.683 | Ping team members in MRs that are waiting for a review | ## Proposal
1. Ping inactive reviewers on community MRs ready for review to either review or reassign to someone else.
* Conditions:
* MR has ~"Community contribution" and ~"workflow::ready for review"
* MR doesn't have ~"automation:reviewers-reminded"
* No activity on the MR in the last 7 days
* MR has reviewer(s) assigned
1. Ping MR coaches on community MRs ready for review.
* Conditions:
* MR has ~"Community contribution" and ~"workflow::ready for review"
* MR doesn't have ~"automation:reviewers-reminded"
* No activity on the MR in the last day (i.e. after 1 day of inactivity, ping an MR coach)
* MR has no reviewers assigned
In both policies, we hint to add ~"workflow::in dev" if some work from the author is actually required.
If the reviewer doesn't take any action, the policy won't fire again, unless ~"automation:reviewers-reminded" is removed.
These policies should ensure that the ball is rolling when a ~"Community contribution" MR is under a GitLab team member responsibility. | 2 |
7,776,928 | 101,997,194 | 2022-02-07 13:17:51.972 | Reactive reminder for merged MRs without a full merged result pipeline | Related to #887 that we should also remind people if the latest pipeline is not a full merged result pipeline (triggered before approved) | 2 |
7,776,928 | 101,825,177 | 2022-02-03 14:55:44.155 | Reactive reminder for merged MRs deviating from guidelines | ## Objective
Provide feedback on merge request guidelines to minimize the opportunity of a ~"master:broken" when a merge request is merged that deviates from the guidelines at https://docs.gitlab.com/ee/development/code_review.html#merging-a-merge-request
### Proposal
When a merge request is merged that deviates from these guidelines a reminder should be posted to the event_user for the merge event.
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75808#note_830752842 | 2 |
7,776,928 | 101,676,530 | 2022-02-01 17:33:38.132 | Add coverage tracking and enforcement | ## Summary
This prevent issues such as https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/883, we should track and enforce a very high coverage for this project. | 3 |
7,776,928 | 101,675,832 | 2022-02-01 17:18:06.329 | NameError: undefined local variable or method `label_names' for #<Triage::DefaultLabelUponClosing:0x00007f70... | # Error Details:
- Sentry event: https://sentry.gitlab.net/gitlab/triage-ops/issues/3178482
- First seen:
2022-02-01T17:12:32+00:00
- Last seen: 2022-02-01T17:12:32+00:00
- Event: 1
- Users: 0 | 1 |
7,776,928 | 101,270,732 | 2022-01-26 09:10:41.352 | Job Failed #2016178858 - Discover | Job [#2016178858](https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/2016178858) failed for a89c849571a693cff8ffbd0bb9d2b7fa9e4f4d07:
### Trace
```
/builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/filters/votes_conditions_filter.rb:46:in `calculate': undefined method `>' for nil:NilClass (NoMethodError)
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:340:in `block in filter_resources'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:331:in `select'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:331:in `filter_resources'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:300:in `block in resources_for_rule'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/expand_condition.rb:13:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/expand_condition.rb:13:in `perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:277:in `resources_for_rule'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:181:in `block in process_rules'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:180:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:180:in `process_rules'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:75:in `block in perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:66:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/lib/gitlab/triage/engine.rb:66:in `perform'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/bin/gitlab-triage:18:in `block in <top (required)>'
from /usr/local/lib/ruby/2.7.0/set.rb:328:in `each_key'
from /usr/local/lib/ruby/2.7.0/set.rb:328:in `each'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/gems/gitlab-triage-1.21.0/bin/gitlab-triage:11:in `<top (required)>'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/bin/gitlab-triage:23:in `load'
from /builds/gitlab-org/quality/triage-ops/vendor/ruby/2.7.0/bin/gitlab-triage:23:in `<main>'
```
It appears the response was incorrect. Following the API request results in
```
{"error":"milestone_id does not have a valid value"}
``` | 1 |
7,776,928 | 100,165,334 | 2022-01-05 19:20:53.131 | Remove Accessibility Categories and Usability Testing Categories from automation | ## Summary
In https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/95994, we have removed two categories: Accessibility testing and Usability Testing.
I have already removed the category in categories.yml, and removed the labels after relabelling the issues with their correct label. I want to confirm that there is no other triage or reports we need to update with these category removals.
### Action items
* [x] Link the merge request to www-gitlab-com for the [category.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/categories.yml) change
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [x] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]". => I actually deleted the label :see_no_evil:
/cc @gl-quality/eng-prod | 1 |
7,776,928 | 100,073,930 | 2022-01-04 11:55:58.692 | Update group label name from monitor to respond | ## Summary
~"group::monitor" will be renaming to `~group::respond` with https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/96249. Label needs to be confirmed with https://about.gitlab.com/groups.json after the MR is merged.
This should be a simple label rename with no migration like https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/845.
### Action items
* [ ] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] Check if label migration will apply labels which have subscribers.
[Communicate with the subscribers](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#communicate-early-and-broadly-about-expected-automation-impact)
before applying the label migration.
* [-] (If applicable) Archive the old label with renaming and adding "DEPRECATED" at the end of the label name.
* [-] (If applicable) Delete the old dashboard views using the deprecated labels.
* [ ] (If applicable) Update the group triage report definition to use the new label.
* [ ] (If applicable) Update the group label's description to refer to the new Stage.
/cc @gl-quality/eng-prod | 2 |
7,776,928 | 99,573,850 | 2021-12-21 16:15:48.701 | Ensure Severity label is applied for UX issues | From Eng Staff Offsite. We want GitLab Bot notifications to make sure we add severity to issues with these labels:
1. "Actionable Insight,"
1. "Low SUS Score,"
1. "UX scorecard-rec,"
1. "cm-scorecard-rec,"
1. "UX debt,"
1. "UI polish,"
1. "UX solution validation,"
1. "accessibility,"
1. "VP-UX Dogfooding,"
1. UX bugs
We will point to the UX severity guidelines in https://about.gitlab.com/handbook/engineering/quality/issue-triage/#severity | 3 |
7,776,928 | 98,941,435 | 2021-12-13 12:31:57.345 | Skip full mr pipeline trigger on approval for qa only changes | Currently, if merge request contains changes only in qa folder, upon first approval a full pipeline will be triggered.
The issue with that is, that first minimal pipeline already triggers e2e tests and triggering full rspec and jest suite do not provide any additional benefits. | 2 |
7,776,928 | 98,911,699 | 2021-12-13 04:30:24.900 | Do not include "Testcases" in the daily triage report | This is an example: https://gitlab.com/gitlab-org/quality/triage-reports/-/issues/5637
The issues mentioned here are actually "testcases" - issue_type field is different.
We might have to figure out a way to differentiate it. | 2 |
7,776,928 | 98,764,201 | 2021-12-09 16:22:26.925 | Follow-up from "Generalize the policy to prompt for slipping check" | The following discussion from !1019 should be addressed:
- [x] @oregand started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/1019#note_756434396): (+2 comments)
> @rymai
>
> Are we able to conditionally act on these type of actions? i.e.
>
> ```
> if group::editor
> mention:
> - ericschurter
> ```
>
> Or can we dynamically pass a name to a policy perhaps? | 1 |
7,776,928 | 98,629,626 | 2021-12-07 22:04:03.969 | Increase default group label application for project/group MRs | ## Objective
Increase the ~group::* label coverage to improve filtered MR searches inside `gitlab-org` and increase discoverability of MRs in team Merge Request reports
## Proposal
See discussion in https://docs.google.com/document/d/1yzHuosvykzb_kaldjGP9I6wxpNpMXdNEvEFBkHyZpXs/edit#bookmark=id.gnno3zgd2hh3
- Review merged MRs for `is_part_of_product` projects (maybe in Sisense?) to identify groups and projects that are good candidates to auto-apply labels | 3 |
7,776,928 | 98,174,237 | 2021-11-30 12:55:50.278 | Web service from this project isn't used, the one from triage-serverless is used instead | I realized that triage-ops deployment isn’t used so any changes that were merged after the merging of triage-serverless into triage-ops haven’t been deployed. I’m trying to figure out what needs to be changed. I’m wondering of maybe we should take the opportunity to deploy a new cluster with a new triage-ops.gitlab.com domain so that once it’s ready we can just add the DNS record and update the webhook URL to use the up-to-date cluster.
We could maybe take the opportunity to resolve https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/766 at the same time.
For reference, the K8s config was introduced by https://gitlab.com/gitlab-org/quality/triage-serverless/-/merge_requests/27/diffs. | 3 |
7,776,928 | 98,154,574 | 2021-11-30 09:01:15.383 | Override "infer group from MR authors" logic for Distribution team members | Distribution team was partitioned to two charters - Build and Deploy. This was reflected in team page data file, where departments now say `Distribution Build BE Team` and `Distribution Deploy BE Team`. Triage-ops, when inferring group labels from MR authors sanitizes these as `group::distribution build` and `group::distribution deploy`. However, those labels do not exist because the team still uses a single group label `group::distribution`.
So, we need an override from `group::distribution build` and `group::distribution deploy` labels to `group::distribution` label. | 1 |
7,776,928 | 97,467,150 | 2021-11-17 08:57:51.948 | Re-enable production deployment of the reactive service | The following discussion from !996 should be addressed:
- [ ] @godfat-gitlab started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/996#note_734985007):
> This seems to be where next we want to change. | 2 |
7,776,928 | 97,474,838 | 2021-11-16 08:26:23.965 | Allow community contributors to request a review | Similar to https://gitlab.com/gitlab-org/quality/triage-serverless/-/issues/173 and https://gitlab.com/gitlab-org/quality/triage-serverless/-/merge_requests/181, we should allow anyone to request a review with `@gitlab-bot request_review`.
The command should probably post to `#mr-coaching` in Slack for now.
We should monitor the number of requests from community contributors. | 3 |
7,776,928 | 97,474,842 | 2021-11-08 11:36:24.218 | New policies to set default type labels upon issue/MR merged/closed event | The idea is to create policies for the `merge_request.merged` event, based on the one-off migrations that were performed by https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/944.
The description of the policies can be found at https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/731.
- Set triage-serverless~2779335 merged and closed issues & MRs without a `type::*` label to `~type::maintenance`
- Set triage-serverless~2278655 merged closed issues & MRs without a `type::*` label to `~type::maintenance` | 2 |
7,776,928 | 96,561,900 | 2021-11-02 08:58:36.205 | Job Failed #1737994920 | Job [#1737994920](https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/1737994920) failed for 398bbf2d1872bb4cd0d6b25e17f5c63986923cd2:
```
1) DevopsLabels DevopsLabels::Context#stage_for_group returns the stage name of the given group
Failure/Error: expect(resource.stage_for_group('distribution')).to eq('enablement')
expected: "enablement"
got: nil
(compared using ==)
# ./spec/lib/devops_labels_spec.rb:694:in `block (4 levels) in <top (required)>'
# ./vendor/ruby/2.7.0/gems/webmock-3.10.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
2) DevopsLabels DevopsLabels::Context#first_group_for_stage returns the first group of the given stage
Failure/Error: expect(resource.first_group_for_stage('enablement')).to eq('distribution')
expected: "distribution"
got: "distribution_build"
(compared using ==)
# ./spec/lib/devops_labels_spec.rb:682:in `block (4 levels) in <top (required)>'
# ./vendor/ruby/2.7.0/gems/webmock-3.10.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
``` | 1 |
7,776,928 | 97,474,866 | 2021-10-01 02:19:06.916 | Use JSON structured log for better parsing in GCP | GKE logging agent automatically parses JSON logs as structured log and they will be available as `jsonPayload`.
https://cloud.google.com/logging/docs/structured-logging
To start with, we could add the following keys to the log:
- `message`
- `severity`
Subsequently, we could add more metadata to the log, for example:
- the relevant processor
- sync (web request) or async (background jobs)
- duration
- etc | 3 |
7,776,928 | 94,432,123 | 2021-09-28 08:58:00.587 | Job Failed #1628339249 | Job [#1628339249](https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/1628339249) failed for 7e33bd5ea2f855b6a8e8eea848e85a974b855829:
```
1) DevopsLabels.teams_per_user username: "lulalala", expected_teams: ["fulfillment_provision", "license"] returns teams of user
Failure/Error: expect(described_class.teams_per_user(username)).to contain_exactly(*expected_teams)
expected collection contained: ["fulfillment_provision", "license"]
actual collection contained: ["license", "license"]
the missing elements were: ["fulfillment_provision"]
the extra elements were: ["license"]
# ./spec/lib/devops_labels_spec.rb:76:in `block (4 levels) in <top (required)>'
# ./vendor/ruby/2.7.0/gems/webmock-3.10.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
Finished in 1.96 seconds (files took 1.17 seconds to load)
653 examples, 1 failure
Failed examples:
rspec './spec/lib/devops_labels_spec.rb[1:6:6:1]' # DevopsLabels.teams_per_user username: "lulalala", expected_teams: ["fulfillment_provision", "license"] returns teams of user
``` | 1 |
7,776,928 | 97,474,870 | 2021-09-22 23:19:02.384 | Resolve edge case in which approval of a "draft" MR triggers a detached pipeline | When a maintainer approves a MR on gitlab, @danger-bot will automatically trigger a new pipeline, stating:
> To ensure full test coverage, a new pipeline has been started.
![CleanShot_2021-09-22_at_18.05.43_2x](/uploads/4cfe22672d42b877eaff27f1d89d9dd6/CleanShot_2021-09-22_at_18.05.43_2x.png)
However, if the MR is still marked as a "Draft", this new `detached` pipeline is [run against the source branch](https://docs.gitlab.com/ee/ci/pipelines/pipelines_for_merged_results.html) rather than against the merged result. I had erroneously presumed that the pipeline triggered upon approval would be against the merged result, and this resulted in gitlab-org/gitlab~3496950 :scream:
When I merged gitlab-org/gitlab!69072, I:
1. clicked "approve"
1. clicked "mark as ready"
1. waited for the new pipeline to become visible
1. clicked "merge when pipeline succeeds"
1. a detached pipeline was run which did not include the latest changes from `master` and missed a test failure which would have occured against a merged result pipeline
1. the pipeline passed and the merged branch ended up breaking master.
Had I instead clicked "mark as ready" _before_ clicking "approve", the full merged result pipeline would have been created instead and this test failure would have been caught before it was automatically merged.
### Recommendation
This behavior _is_ documented, so it is certainly my mistake, but I think if it's possible for @danger-bot to trigger a full merged-result pipeline regardless of the draft state we should configure it to do so (or failing that, it should produce a **warning** saying that the MR is marked as a draft and that a full merged-result pipeline should be triggered.)
-----------
Original discussion from gitlab-org/gitlab!70746:
> > I was not cognizant of any behavior change for pipelines triggered within draft MRs
>
> Yeah, it's a slightly surprising behaviour, but it is [documented](https://docs.gitlab.com/ee/ci/pipelines/pipelines_for_merged_results.html) (emphasis mine):
>
> > When the merge request can’t be merged, the pipeline runs against the source branch only. For example, when:
> >
> > * The target branch has changes that conflict with the changes in the source branch.
> > * The merge request **is a Draft merge request**.
>
> ---
>
> > The pipeline was triggered by `@danger-bot` automatically upon my approval of the MR, so that’s why it doesn’t show me as the triggerer.
> >
> > Do you think there an actionable issue here @markrian?
>
> That does sound like an edge-case bug in our `@danger-bot` tooling, yes (i.e., when the MR is `Draft`). Do you know where we might file an issue or MR for this? | 3 |
7,776,928 | 97,474,872 | 2021-09-16 14:32:54.148 | Consider cleaning up left-overs from the Knative integration | It looks we still have some left-overs from Knative:
- https://gitlab.com/gitlab-org/quality/triage-serverless/-/serverless/functions
- https://gitlab.com/gitlab-org/quality/triage-serverless/-/blob/master/serverless.yml
- https://gitlab.com/gitlab-org/quality/triage-serverless/-/blob/master/config/triage-virtual-service.yaml
- [Screen_Shot_2021-09-16_at_16.30.55](/uploads/5b0065b5fcf4a8f29eefab18354bf965/Screen_Shot_2021-09-16_at_16.30.55.png) | 3 |
7,776,928 | 97,474,874 | 2021-09-15 19:02:38.428 | Delay pinging AppSec team for JiHu contributions after first approval | Following up https://gitlab.com/gitlab-org/quality/triage-serverless/-/issues/125, this is brought up from https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/90253#note_677426770
## Problem
If we ping the AppSec team too early in the life cycle of a merge request, chances are AppSec team can review too early and the review becomes outdated quickly, therefore a complete re-review might be needed later.
## Proposal
Given that it's difficult to shift the ping after the "last" approval, we can at least shift the ping after the "first" approval.
Below was copied and edited from https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/90253#note_677426770
* MR gets submitted
* Bot makes [the unresolved thread](https://gitlab.com/gitlab-org/quality/triage-serverless/-/merge_requests/145/diffs) that acts as a blocker to merging until AppSec can review it (but does not `@-mention` the AppSec team yet)
* Reviewers/maintainers go through the MR, request some changes, eventually approve it
* Once approved by the reviewers/maintainers, automation comments in that unresolved thread and pings the AppSec team for a ~~{-final-}~~{+follow up+} approval
## Implementation
With https://gitlab.com/gitlab-org/quality/triage-serverless/-/merge_requests/153 where it can leave a unique mark in the comment, and a way to detect if the unique mark is already being left, we can extend this so that it can find the original thread and attach new comments in the thread.
* Wrap the first AppSec thread with a unique mark
* When we receive an approval, find the above thread with the unique mark
* Comment and ping AppSec team on the thread
* (Bonus) Make sure the thread cannot be resolved before AppSec team member is pinged!
* (Bonus bonus) Make sure that only team members can resolve the thread!
## Question: Final approval?
If we may find a good way to determine what is the "last" approval, we can as well make AppSec get pinged after that so AppSec team can be the last one to approve. This will be more ideal because we can make sure there's no loophole that AppSec team review can get outdated.
We can as well think about making this process more formal so maintainers can just follow that rule manually.
## Question: triage-ops?
Can we do the same for triage-ops? | 2 |
7,776,928 | 93,102,029 | 2021-09-03 20:52:20.695 | One-off migration for old types to new scoped types | 1. Remove `~type::feature` when `~type::maintenance` exists - based on both labels being present after rename in https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/1003
1. Set ~security open, merged and closed MRs and open issues without a `type::*` label to `~type::maintenance`
1. Set ~documentation open, merged closed MRs and open issues without a `type::*` label to `~type::maintenance`
### Questions
- Where should ~documentation be defaulted to? | 3 |
7,776,928 | 93,099,757 | 2021-09-03 19:58:07.195 | Update triage-ops type label references | As apart of https://gitlab.com/groups/gitlab-org/-/epics/6622
Update the following references:
- [ ] https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/lib/untriaged_helper.rb
- [ ] https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/policies/template/team-summary.yml.erb
- [ ] Probably more | 2 |
7,776,928 | 93,065,038 | 2021-09-03 09:57:03.330 | Handle ~group::not_owned label for "Untriaged community merge requests" policy | ## Problem
In reports like https://gitlab.com/gitlab-org/quality/triage-reports/-/issues/4457 MRs with label ~"group::not_owned" often have missing stage labels.
Those MRs, although properly labelled otherwise, still show up in reports because stage label is missing if MRs changes span multiple stages (hence ~"group::not_owned").
## Proposed solution
Make this specific policy (https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/policies/stages/report/untriaged-community-merge-requests.yml#L18) aware of the following condition:
* Skip MR for the report if the MR has ~"group::not_owned" and stage label is missing | 2 |
7,776,928 | 92,149,112 | 2021-08-17 22:26:14.056 | Update Author Label Inference Docs and Order | In a recent [Engineering Productivity team meeting](https://docs.google.com/document/d/1yzHuosvykzb_kaldjGP9I6wxpNpMXdNEvEFBkHyZpXs/edit#bookmark=id.nni8n0dmw9v6) we discussed how the author label inference can conflict with rules like the Feature Flag rules.
We decided that we should modify the order to have author inference be after Category inference and update these docs:
- https://docs.gitlab.com/ee/development/contributing/issue_workflow.html#group-labels
- https://about.gitlab.com/handbook/engineering/metrics/#stage-and-group-labels | 3 |
7,776,928 | 90,527,365 | 2021-07-19 23:31:34.408 | Remove automatic addition of the Category:Templates label | ## Summary
There appears to be automation that sets label `Category:Templates` for any new issue in `https://gitlab.com/gitlab-org/project-templates`. This automation needs to be removed, as `Category:Templates` no longer exists. Any other automation based on the `Category:Templates` label should also be removed.
### Action items
* [x] Link the merge request to www-gitlab-com for the [category.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/categories.yml) change: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/86626
* [ ] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]".
/cc @gl-quality/eng-prod | 1 |
7,776,928 | 90,525,449 | 2021-07-19 22:05:02.804 | Discrepancy between Issue / issue count between the Quality Heat map and the actual issue list | #### Problem:
The discrepancy was noticed in the most recent Triage issue - https://gitlab.com/gitlab-org/quality/triage-reports/-/issues/3911 (2021-07-19)
Discussion - https://gitlab.com/gitlab-org/quality/triage-reports/-/issues/3911#note_630403592
In the [Heat map for triage failures](https://gitlab.com/gitlab-org/quality/triage-reports/-/issues/3911#heatmap-for-triage-failures), clicking on [157 issues under No severity, No priority](https://gitlab.com/groups/gitlab-org/-/issues?state=opened&label_name%5B%5D=Quality&label_name%5B%5D=QA¬%5Blabel_name%5D%5B%5D=priority%3A%3A1¬%5Blabel_name%5D%5B%5D=priority%3A%3A2¬%5Blabel_name%5D%5B%5D=priority%3A%3A3¬%5Blabel_name%5D%5B%5D=priority%3A%3A4¬%5Blabel_name%5D%5B%5D=severity%3A%3A1¬%5Blabel_name%5D%5B%5D=severity%3A%3A2¬%5Blabel_name%5D%5B%5D=severity%3A%3A3¬%5Blabel_name%5D%5B%5D=severity%3A%3A4) section lists out ~ 1666 Open issues which includes triage reports, test sessions, etc.
![Screen_Shot_2021-07-19_at_6.01.12_PM](/uploads/68882f2c12c2100968cae9a030997cdf/Screen_Shot_2021-07-19_at_6.01.12_PM.png)
#### Expected behaviour:
The issue list should display the same number of Open issues that was shown in the Heat Map.
#### Actual behaviour:
The issue list displayed ~1666 Open issues rather than 157 as shown in the Heat Map.
![Screen_Shot_2021-07-19_at_6.03.18_PM](/uploads/8a936e037b161e4b670da953d87e3ff3/Screen_Shot_2021-07-19_at_6.03.18_PM.png)
#### Potential ROot cause/ Solution:
```
Kyle Wiebers @kwiebers · 1 hour ago
Owner
I think this is due to that table having the .only-gitlab filter applied for the role but the policy is run at the gitlab-org group level so the links in the heatmap go to the group but the counts are for the project.
``` | 3 |
7,776,928 | 88,809,413 | 2021-06-16 12:24:50.673 | Move monthly EM bugs/performance issues triage into this project | A monthly job runs in the Plan project (https://gitlab.com/gitlab-org/plan/) that generates triage issues for EMs in Plan and Create which make it easier to include bugs and performance issues in the release post.
* Job definitions: [.gitlab-ci.yml](https://gitlab.com/gitlab-org/plan/-/blob/master/.gitlab-ci.yml)
* Schedule: [`0 14 13 * *`](https://gitlab.com/gitlab-org/plan/-/pipeline_schedules)
* Policies: https://gitlab.com/gitlab-org/plan/-/tree/master/policies
* Example issues: [Plan bugs for 14.0](https://gitlab.com/gitlab-org/plan/-/issues/342), [Create performance issues for 13.12](https://gitlab.com/gitlab-org/create-stage/-/issues/12853)
A stage-level report is generated that makes it easy for EMs to collaborate by providing a checklist with each item to be triaged, along with a markdown list that can be copied into a commit on the corresponding MR.
This job has a number of downsides that would benefit from its being moved into this project:
- The creation of the issues in pipelines fails because they trigger spam detection, so they have to be manually copied from artifacts into issues;
- Maintenance is within the Plan project and is somewhat opaque to other teams.
The current implementation also has the following drawbacks:
- DRIs are frequently out of date as the SSoT is different from https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/group-definition.yml;
- Code is not DRY, each policy is replicated including issue description text. Expanding to other stages requires duplicating policies in full each time;
- Current milestone isn't usable in title or description.
### Proposal
Move this monthly triage into this project, allowlisting it to Plan and Create only to begin with. Then gradually add stages as they show an interest.
The following steps could be used:
- [x] Align the current policies as closely as possible with this project's
- [x] Remove legacy Ruby script and jobs https://gitlab.com/gitlab-org/plan/-/merge_requests/43
- [x] Copy the `group-definition.yml` file into the project
- [x] Refactor policies to use `group-definition.yml` as the SSoT for EMs and Groups
- [x] Make a single policy for each triage issue type (bugs and performance issues) that consumes the `group-definition.yml`
- [x] Move the triage into this project
- [x] Remove jobs and clean up the Plan project https://gitlab.com/gitlab-org/plan/-/merge_requests/51 | 2 |
7,776,928 | 88,549,667 | 2021-06-11 03:03:04.276 | Update labels to reflect two merged groups | Recently ~"group::dynamic analysis" and ~"group::fuzz testing" merged, and kept the name ~"group::dynamic analysis". This organizational change is reflected in this MR, https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/79866
We need to determine how to handle the ~"group::fuzz testing" label. It is still intermittently being used by customers and team members. It is also has issues associated with it that have been closed.
Whatever updates need to be made should be reflected in the handbook:
https://about.gitlab.com/handbook/product/product-processes/#creating-new-groups | 3 |
7,776,928 | 86,176,415 | 2021-04-29 03:59:00.935 | Category:Experimentation split into four new categories | ## Summary
The existing `Category:Experimentation` can be removed. There are four new categories added, with changes to features.yml and categories.yml
- https://gitlab.com/groups/gitlab-org/-/labels?utf8=%E2%9C%93&subscribed=&search=Category%3AAdoption%20Experiment
- https://gitlab.com/groups/gitlab-org/-/labels?utf8=%E2%9C%93&subscribed=&search=Category%3AActivation%20Experiment
- https://gitlab.com/groups/gitlab-org/-/labels?utf8=%E2%9C%93&subscribed=&search=Category%3AConversion%20Experiment
- https://gitlab.com/groups/gitlab-org/-/labels?utf8=%E2%9C%93&subscribed=&search=Category%3AExpansion%20Experiment
The original `Category:Experimentation` label has not been removed yet, but has been `[DEPRECATED]`
- https://gitlab.com/groups/gitlab-org/-/labels?utf8=%E2%9C%93&subscribed=&search=Category%3AExperimentation
I manually migrated the issues and MRs (there were no Epics with this label).
### Action items
* [x] https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/80937
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [x] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]".
* [ ] Disable the inference for all single-category labels under ~"devops::growth".
#### Background
- issues:
- https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/656
- https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1008
- related MRs:
- https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/75987
- https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/80837
- https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/80937
/cc @gl-quality/eng-prod | 1 |
7,776,928 | 78,420,046 | 2021-02-04 11:06:13.991 | Pre-fill some variables for manual dry-run jobs | Now that we can pre-fill variables in manual jobs (https://docs.gitlab.com/ee/ci/yaml/README.html#prefill-variables-in-manual-pipelines), we should use it in this project. | 2 |
7,776,928 | 77,809,583 | 2021-01-25 16:10:16.351 | Treat non-scoped group label as a group label | Spinning off from https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/631#note_480174901
Instead of treating non-scoped group label a special case, we can just treat them the same. This means whenever there's a non-scoped group label (e.g. ~"group:certify"), we do not need to infer another group label.
This way, when there's ~"group:certify" we can still infer categories for it, and also make it possible to infer that from the categories. This will also require https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/71331 to specify which exact label we need to use for the group label.
With this we can fully resolve https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/631
For now we're just working around it by silencing it when ~"group:certify" is added. | 2 |
7,776,928 | 77,526,286 | 2021-01-20 09:13:54.962 | Consider retiring the "Community contributions merge request report" issue | Now that:
1. We automatically label community contributions with ~"Community contribution" (with `triage-serverless`): https://gitlab.com/gitlab-org/quality/triage-serverless/-/blob/987f8db13d1741b2df08d901fb660fcb137afc6e/triage/processor/thank_community_contribution.rb#L34
1. ~"Community contribution" are triaged so that they have a group label set: https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/policies/stages/report/untriaged-community-merge-requests.yml
1. ~"Community contribution" are surfaced per group in the "Merge requests requiring attention for <group>" report: https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/006cb0be0bac79b0435d9132cfb5ff6e3456d53b/policies/template/merge-requests-needing-attention.yml.erb#L79-107
The "Community contributions merge request report" issue isn't useful (e.g. https://gitlab.com/gitlab-org/gitlab/-/issues/249036) and should probably be retired. It seems to only include MRs opened by former team members (hence which don't have the ~"Community contribution" label set). | 1 |
7,776,928 | 77,060,765 | 2021-01-12 03:21:25.399 | Label `group::provision` doesn't exist | # Error Details:
- Sentry event: https://sentry.gitlab.net/gitlab/triage-ops/issues/2441732
- First seen:
2021-01-12T00:06:27+00:00
- Last seen: 2021-01-12T00:08:10+00:00
- Events: 3
- Users: 0
```
bundler: failed to load command: gitlab-triage (/usr/local/bundle/bin/gitlab-triage)
/usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/command_builders/label_command_builder.rb:20:in `block in ensure_labels_exist!': Label `group::provision` doesn't exist! (Gitlab::Triage::Resource::Label::LabelDoesntExistError)
from /usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/command_builders/label_command_builder.rb:16:in `each'
from /usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/command_builders/label_command_builder.rb:16:in `ensure_labels_exist!'
from /usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/command_builders/label_command_builder.rb:8:in `build_command'
from /usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/action/comment.rb:44:in `build_comment'
from /usr/local/bundle/gems/gitlab-triage-1.14.3/lib/gitlab/triage/action/comment.rb:32:in `block in act'
from /usr/local/lib/ruby/2.6.0/delegate.rb:83:in `each'
``` | 1 |
7,776,928 | 97,474,929 | 2020-12-17 15:13:30.122 | Allow contributors to ping the gitlab-bot for adding a type label | Following triage-serverless#52 and triage-serverless#63, we should allow contributors to add a type label to a MR with a syntax like `@gitlab-bot label ~"type::bug"`.
- Only the author of the issuable will be able to request labelling.
- Only a group or type label can be requested for now.
- Rate limiting is set to 60 label commands per author per hour. | 2 |
7,776,928 | 75,756,531 | 2020-12-08 10:12:36.088 | Consider fetching users from the roulette project to be able to exclude OOO people from triage reports | null | 2 |
7,776,928 | 74,423,476 | 2020-11-16 11:07:34.550 | Job Failed #850788746 | Job [#850788746](https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/850788746) failed for 286fdff9d2e8c5f7e3b01aaa412d4fcbe3c204f7:
```
1) DevopsLabels DevopsLabels::Context#new_stage_and_group_labels_from_intelligent_inference and #comment_for_intelligent_stage_and_group_labels_inference stage: no, group: yes, category: no, team: no => Stage label based on group returns a comment with a /label quick action
Failure/Error: expect(resource.comment_for_intelligent_stage_and_group_labels_inference).to eq %(#{explanation}\n#{label_action})
expected: "Setting label(s) ~\"devops::enablement\" ~\"section::enablement\" based on ~\"group::memory\".\n/label ~\"devops::enablement\" ~\"section::enablement\""
got: "Setting label(s) ~\"Category:Memory\" ~\"devops::enablement\" ~\"section::enablement\" based on ~\"group::memory\".\n/label ~\"Category:Memory\" ~\"devops::enablement\" ~\"section::enablement\""
(compared using ==)
Diff:
@@ -1,3 +1,3 @@
-Setting label(s) ~"devops::enablement" ~"section::enablement" based on ~"group::memory".
-/label ~"devops::enablement" ~"section::enablement"
+Setting label(s) ~"Category:Memory" ~"devops::enablement" ~"section::enablement" based on ~"group::memory".
+/label ~"Category:Memory" ~"devops::enablement" ~"section::enablement"
# ./spec/lib/devops_labels_spec.rb:837:in `block (5 levels) in <top (required)>'
``` | 1 |
7,776,928 | 73,985,416 | 2020-11-06 17:58:12.199 | Deprecate Category:Alert Management label | ## Summary
**We need to deprecate the ~"Category:Alert Management" label. This category is getting removed from categories.yml. All issues with this label can be moved to ~"Category:Incident Management"**
This template is for new or renaming Category labels. This review helps to ensure there will be no impact with triage automation and reports.
### Action items
* [x] Link the merge request to www-gitlab-com for the [category.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/categories.yml) change: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/67449
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] (If applicable) Rename the old label by adding `[DEPRECATED]` at the end of the label name, like ~"CI/CD [DEPRECATED]".
/cc @gl-quality/eng-prod | 2 |
7,776,928 | 73,980,025 | 2020-11-06 01:53:48.716 | Ensure issues for current milestone have a tier label | ## Overview
To specify the tier of a new feature, Product will typically apply a label to issues specifying the license tier of the feature (e.g. `GitLab Premium`). However, we periodically may forget to apply this label consistently, which can also lead to [confusion at times](https://gitlab.com/gitlab-com/Product/-/issues/1669).
I've definitely done this - the problem isn't that I applied the incorrect label, but that I neglected to apply it at all in the midst of creating multiple issues. In order to prevent this, we should make sure that issues with the current milestone (e.g. issues that are being worked on) have a tiering label so we're being intentional about which tier a feature belongs in.
## Proposal
Set up a triage policy:
* If an issue is scheduled for the current milestone AND has a `group::` label AND has a ~direction label AND does not have one of ~"GitLab Core", ~"GitLab Starter", ~"GitLab Premium" , or ~"GitLab Ultimate"
* Then leave a comment in the issue and @ mention the relevant PM to add an appropriate tier label. | 1 |
7,776,928 | 73,719,353 | 2020-11-02 08:26:16.368 | Rename 'value stream management' group to 'optimize' | Handbook update: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/66633/diffs
For every case above, the Engineering Productivity team needs to ensure that:
* The label change is factored into the triage mechanism.
* Engineering Dashboards at https://quality-dashboard.gitlap.com/groups/gitlab-org are updated.
* Old labels are migrated correctly on affected issues and merge requests.
### Action items
* [x] Rename ~"group::value stream management" to ~"group::optimize"
* [x] Rename ~"Category:Value Stream Analytics" to ~"Category:Value Stream Management"
* [x] Update the group triage report definition to use the new label: https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/674
* [x] Update the group label's description to refer to the new Stage.
* [x] Rename ~"group::analytics" to ~"group::optimize" in Periscope: https://gitlab.com/gitlab-data/periscope/-/merge_requests/78 | 2 |
7,776,928 | 73,546,321 | 2020-10-28 23:36:13.781 | Rename group::acquisition to group::activation | ## Summary
Tracking issue: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/230
* Renaming an existing Stage or Group
~"group::acquisition" is becoming ~"group::activation" due to a change in Growth KPIs:
* https://about.gitlab.com/handbook/product/performance-indicators/#new-group-namespace-create-stage-adoption-rate
* https://about.gitlab.com/direction/growth/#growth-kpi
* https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/66124/diffs#ded7bbea02ff2128954ee2b752d088426082101b_176_174 (not a direct line-for-line match)
For every case above, the Engineering Productivity team needs to ensure that:
* The label change is factored into the triage mechanism.
* Engineering Dashboards at <https://quality-dashboard.gitlap.com/groups/gitlab-org> are updated.
* Old labels are migrated correctly on affected issues and merge requests.
### Action items
* [x] Rename ~"group::acquisition" to ~"group::activation"
* [x] Update the group triage report definition to use the new label: https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/668
* [x] Update the group label's description to refer to the new Stage.
* [x] Rename ~"group::acquisition" to ~"group::activation" in Periscope: https://gitlab.com/gitlab-data/periscope/-/merge_requests/77
/cc @gl-quality/eng-prod @jstava | 2 |
7,776,928 | 73,546,233 | 2020-10-28 23:31:49.085 | Rename group::retention to group::adoption | ## Summary
* Renaming an existing Stage or Group
~"group::retention" is becoming ~"group::adoption" due to a change in Growth KPIs:
* https://about.gitlab.com/handbook/product/performance-indicators/#new-group-namespace-create-stage-adoption-rate
* https://about.gitlab.com/direction/growth/#growth-kpi
* https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/66124/diffs#ded7bbea02ff2128954ee2b752d088426082101b_176_173 (not a direct line-for-line match)
**Note** this new group label has been created and is being used.
https://gitlab.com/dashboard/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=group%3A%3Aadoption
For every case above, the Engineering Productivity team needs to ensure that:
* The label change is factored into the triage mechanism.
* Engineering Dashboards at <https://quality-dashboard.gitlap.com/groups/gitlab-org> are updated.
* Old labels are migrated correctly on affected issues and merge requests.
### Action items
* [x] Add ~"group::retention" to all issues/MRs with ~"group::adoption"
* [x] Remove the ~"group::adoption" label
* [x] Rename ~"group::retention" to ~"group::adoption"
* [x] Update the group triage report definition to use the new label: https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/669
* [x] Update the group label's description to refer to the new Stage.
* [x] Rename ~"group::retention" to ~"group::adoption" in Periscope: https://gitlab.com/gitlab-data/periscope/-/merge_requests/79
/cc @gl-quality/eng-prod @mkarampalas | 2 |
7,776,928 | 73,144,511 | 2020-10-22 08:47:42.813 | Rename 'analytics' group to 'value stream management' | ## Summary
Handbook update: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/65811
For every case above, the Engineering Productivity team needs to ensure that:
* The label change is factored into the triage mechanism.
* Engineering Dashboards at <https://quality-dashboard.gitlap.com/groups/gitlab-org> are updated.
* Old labels are migrated correctly on affected issues and merge requests.
### Action items
* [x] Rename ~"group::analytics" to ~"group::value stream management"
* [x] Rename ~"Category:Value Stream Management" to ~"Category:Value Stream Analytics"
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [x] Merge ~"value stream analytics" into ~"Category:Value Stream Analytics": https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/663
* [ ] Check if label migration will apply labels which have subscribers.
[Communicate with the subscribers](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#communicate-early-and-broadly-about-expected-automation-impact)
before applying the label migration.
* [x] Update the group triage report definition to use the new label: https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/662
* [x] Update the group label's description to refer to the new Stage.
* [ ] Rename ~"group::analytics" to ~"group::value stream management" in Periscope: https://gitlab.com/gitlab-data/periscope/-/merge_requests/75 | 3 |
7,776,928 | 71,640,154 | 2020-09-24 15:55:36.941 | Fulfillment Section Rollout | ## Description
Fulfillment is moving to its own section with https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/62755 and I'm unsure of the implications we need to consider
## Tasks
- [x] Create ~"section::fulfillment", ~"devops::fulfillment", ~"group::purchase", ~"group::provision", ~"Category:Purchase", and ~"Category:Provision" `gitlab-org` group labels
- [x] Consider changes to the Embedded Team Dashboard for [UX](https://app.periscopedata.com/app/gitlab/736036/UX-Embedded-Dashboard) and [Quality](https://app.periscopedata.com/app/gitlab/736012/Quality-Embedded-Dashboard)
- [x] Update [`group-definition.yml`](https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/group-definition.yml) and generate corresponding policies and jobs => https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/643
### Migration => https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/639
1. [x] Rename \~"group::fulfillment" to ~"devops::fulfillment"
1. [x] Migrate current ~"devops::fulfillment" + ~frontend issues/MRs to ~"section::fulfillment" + ~"group::purchase" - ~"section::growth" - ~"devops::growth" in `gitlab-org/gitlab`: https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/769726383
- Expected updates: 78 issues, 100 MRs
1. [x] [**To be confirmed**] Migrate current ~"devops::fulfillment" issues/MRs to ~"section::fulfillment" + ~"group::provision" - ~"section::growth" - ~"devops::growth" in `gitlab-org/customers-gitlab-com`: https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/769726383
- Expected updates: 1782 issues, 1775 MRs
1. [x] Migrate current ~"devops::fulfillment" issues/MRs to ~"section::fulfillment" + ~"group::provision" - ~"section::growth" - ~"devops::growth" in `gitlab-org/license-gitlab-com`: https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/769726387
- Expected updates: 110 issues, 76 MRs
### Potential migration
1. [x] Migrate ~"Category:Billing" [794 issues](https://gitlab.com/groups/gitlab-org/-/issues?label_name%5B%5D=Category%3ABilling), [65 MRs](https://gitlab.com/groups/gitlab-org/-/merge_requests?label_name%5B%5D=Category%3ABilling), and [14 epics](https://gitlab.com/groups/gitlab-org/-/epics?label_name%5B%5D=Category%3ABilling) to ~"Category:Purchase" / ~"Category:Provision"? | 3 |
7,776,928 | 70,746,784 | 2020-09-04 17:21:25.412 | Triage issues are polluting issue search in gitlab-org/gitlab | ### Problem to solve
When searching through issues in [gitlab-org/gitlab](https://gitlab.com/gitlab-org/gitlab), it common for the results to contain many triage issues - sometimes an overwhelming number. This is not desirable. Triage issues have little or no value as search results. Generally users (internal and external to GitLab) would prefer to see the underlying issues that these triage issues refer to, but the triage issues are so keyword-rich they are crowding out those higher-value search results.
### Proposal
Triage report issues should be created in [gitlab-org/quality/triage-reports](https://gitlab.com/gitlab-org/quality/triage-reports), not in [gitlab-org/gitlab](https://gitlab.com/gitlab-org/gitlab).
### Related links
- As recently as %12.4, issues for "Automatically rescheduled issues" and "Automatically rescheduled merge_requests" ([example](https://gitlab.com/gitlab-org/gitlab/-/issues?scope=all&utf8=%E2%9C%93&state=closed&search=automatically+rescheduled)) were also crowding search results. Those issues were apparently discontinued or moved elsewhere.
### Screenshots
<details>
<summary>A real search query returning triage issues as 4 of the top 6 results</summary>
![Screen_Shot_2020-09-04_at_12.20.37_PM](/uploads/016d6d981b96dd3b094bfe208081a77f/Screen_Shot_2020-09-04_at_12.20.37_PM.png)
</details>
<details>
<summary>A real search query returning triage issues as 3 of the top 6 results</summary>
![Screen_Shot_2020-09-04_at_11.35.43_AM](/uploads/62e5623ddbf9e290bf6a1faae3852d0a/Screen_Shot_2020-09-04_at_11.35.43_AM.png)
</details> | 1 |
7,776,928 | 70,610,007 | 2020-09-02 04:28:11.420 | unlabelled-issues job failed with undefined `items_per_triagers` | Sentry issue: https://sentry.gitlab.net/gitlab/triage-ops/issues/1802903/?environment=default
This failure seems to stem from https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/592#note_405730964 | 2 |
7,776,928 | 70,565,887 | 2020-09-01 09:16:30.274 | Consider inferring stage/group labels from category labels for MRs as well as issues | As suggested in https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/506#note_405199143, given that we now set stage/group labels based on the author in the `pre-hygiene` stage (https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/.gitlab/ci/pre-hygiene.yml), that means it should be safe to infer stage/group labels based on category labels in the `hygiene` stage. | 2 |
7,776,928 | 70,270,641 | 2020-08-25 13:34:34.584 | Consider labelling community contributions every 30 minutes instead of once a day | In order to improve the discovery of ~"Community contribution" MRs and reduce the cycle time for those (https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/271), one very boring step we can do is to apply the ~"Community contribution" every 30 minutes instead of once a day. | 2 |
7,776,928 | 69,975,015 | 2020-08-18 18:38:40.720 | Investigate why some issues did not get section labels | This was brought up at https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/528#note_398105857
* https://gitlab.com/gitlab-org/gitlab/-/issues/233112
* https://gitlab.com/gitlab-org/gitlab/-/issues/225466
* https://gitlab.com/gitlab-org/gitlab/-/issues/218642 | 1 |
7,776,928 | 68,120,565 | 2020-07-20 14:56:13.986 | Triage Reports are not created for week of 2020-07-20 | Team triage reports are not being created. I suspect the same issues as https://gitlab.com/gitlab-com/gl-security/abuse-team/abuse/-/issues/252
This issue is to investigate the root cause and get triage-reports created.
## Actions
- [x] Announce issues in #product, #development, #eng-managers - https://gitlab.slack.com/archives/C0NFPSFA8/p1595258572124700
- [x] Manually create team triage reports
- [x] `gitlab-org/gitlab`: https://gitlab.com/gitlab-org/quality/triage-ops/-/pipelines/168898689 and https://gitlab.com/gitlab-org/quality/triage-ops/-/pipelines/168900258
- [x] `gitlab-org/gitaly`: https://gitlab.com/gitlab-org/quality/triage-ops/-/pipelines/168899495
- [x] `gitlab-org/gitlab-runner`: https://gitlab.com/gitlab-org/quality/triage-ops/-/pipelines/168899804 | 2 |
7,776,928 | 51,543,407 | 2020-06-29 15:51:09.644 | Remove the rules for removing `group::not_owned` | The following discussions from !537 should be addressed:
- [ ] @godfat started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/537#note_366305619):
> Can remove this after one-off is done.
>
> Or maybe we can keep it for a day, and remove tomorrow after it ran in schedule?
- [ ] @godfat started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/537#note_366305633):
> Can remove this after one-off is done.
>
> Or maybe we can keep it for a day, and remove tomorrow after it ran in schedule? | 1 |
7,776,928 | 51,535,650 | 2020-06-29 15:34:51.604 | Add an explanation to handbook for why sometimes we don't put direct links | The following discussion from !539 should be addressed:
- [ ] @kwiebers started a [discussion](https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/539#note_367659257): (+6 comments)
So we can use this link for longer explanation. | 1 |
7,776,928 | 43,837,480 | 2020-06-15 14:36:47.596 | `gitlab-triage` release process to include bumping version used by `triage-ops`? | `triage-ops` now uses the `gitlab-triage` version from the Gemfile:
- https://gitlab.com/gitlab-org/quality/triage-ops/-/merge_requests/521/diffs
So it's possible that the automated runs will not pull and install the latest version of `gitlab-triage` if we exceed the rule.
Should we make it part of the `gitlab-triage` release process to bump the version here in `triage-ops`? | 1 |
7,776,928 | 41,390,147 | 2020-06-10 18:55:35.393 | Make the idle merge requests report easier to navigate | Following up from https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/486#note_358196219
- Update the description to explain why we don't have direct links
- Use backticks for full URL
- ~~Add a section in the bottom and let people to copy and paste into another comment box, hit preview, here you go, links for you~~
```
- gitlab-org/gitlab!28949
- gitlab-org/gitlab!28949
- gitlab-org/gitlab!28949
``` | 1 |
7,776,928 | 35,468,015 | 2020-06-05 08:23:50.768 | Add more context to Sentry events when scheduled pipeline fails | Identify and add additional context to Sentry to help in debugging failure in scheduled pipelines. | 1 |
7,776,928 | 34,529,294 | 2020-05-13 22:52:03.134 | Reports for Community merge requests requiring attention for Secure analyzers | Within the Secure Sub-Department we get many `~"Community contribution"` MRs. We would like a report similar to what was set up for GitLab EE (example at https://gitlab.com/gitlab-org/gitlab-foss/-/issues/58131)
It looks like a related initiative was created within https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/271 that may have extended to more projects. A challenge regarding reviewer roulette was mentioned.
## Iteration 1
- [ ] Create a report for all of `security-products` groupo MRs + ~"Community contribution" that is similar to the community-merge-requests policy and assigned to @nmccorrison @twoodham @gonzoyumo @sethgitlab: https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/477#note_343589797
## Dynamic Application Security Testing (DAST)
1. https://gitlab.com/gitlab-org/security-products/dast (to be moved into `https://gitlab.com/gitlab-org/security-products/analyzers/dast` - per this [comment](https://gitlab.com/gitlab-org/quality/triage-ops/-/issues/477#note_350220388))
## Static Application Security Testing (SAST)
1. https://gitlab.com/gitlab-org/security-products/analyzers/tslint
1. https://gitlab.com/gitlab-org/security-products/analyzers/secrets
1. https://gitlab.com/gitlab-org/security-products/analyzers/spotbugs
1. https://gitlab.com/gitlab-org/security-products/analyzers/sobelow
1. https://gitlab.com/gitlab-org/security-products/analyzers/pmd-apex
1. https://gitlab.com/gitlab-org/security-products/analyzers/gosec
1. https://gitlab.com/gitlab-org/security-products/analyzers/kubesec
1. https://gitlab.com/gitlab-org/security-products/analyzers/nodejs-scan
1. https://gitlab.com/gitlab-org/security-products/analyzers/security-code-scan
1. https://gitlab.com/gitlab-org/security-products/analyzers/phpcs-security-audit
1. https://gitlab.com/gitlab-org/security-products/analyzers/brakeman
1. https://gitlab.com/gitlab-org/security-products/analyzers/bandit
1. https://gitlab.com/gitlab-org/security-products/analyzers/flawfinder
## Dependency Scanning
1. https://gitlab.com/gitlab-org/security-products/analyzers/gemnasium
1. https://gitlab.com/gitlab-org/security-products/analyzers/gemnasium-maven
1. https://gitlab.com/gitlab-org/security-products/analyzers/gemnasium-python
1. https://gitlab.com/gitlab-org/security-products/analyzers/gemnasium-maven-plugin
1. https://gitlab.com/gitlab-org/security-products/analyzers/bundler-audit
1. https://gitlab.com/gitlab-org/security-products/analyzers/retire.js
## Container Scanning
1. https://gitlab.com/gitlab-org/security-products/analyzers/klar
## Shared
1. https://gitlab.com/gitlab-org/security-products/analyzers/common | 2 |
7,776,928 | 34,517,547 | 2020-05-13 15:55:25.690 | Obsolete group: anomaly detection | ## Summary
* ~"group::anomaly detection" should no longer be used.
### Action items
* [x] (If applicable) Dashboard creation: create or update the stage/group in <https://gitlab.com/gitlab-org/gitlab-insights/blob/master/lib/gitlab_insights.rb>.
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] Check if label migration will apply labels which have subscribers.
[Communicate with the subscribers](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#communicate-early-and-broadly-about-expected-automation-impact)
before applying the label migration.
* [ ] (If applicable) Archive the old label with renaming and adding "DEPRECATED" at the end of the label name.
* [x] (If applicable) Delete the old dashboard views using the deprecated labels.
* [ ] (If applicable) Update the group triage report definition to use the new label.
* [ ] (If applicable) Update the group label's description to refer to the new Stage.
/cc @gl-quality/eng-prod | 2 |
7,776,928 | 34,517,440 | 2020-05-13 15:52:07.795 | Obsolete group: runtime application security | ## Summary
* ~"group::runtime application security" should no longer be used.
### Action items
* [x] (If applicable) Dashboard creation: create or update the stage/group in <https://gitlab.com/gitlab-org/gitlab-insights/blob/master/lib/gitlab_insights.rb>: https://gitlab.com/gitlab-org/gitlab-insights/-/merge_requests/195
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] Check if label migration will apply labels which have subscribers.
[Communicate with the subscribers](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#communicate-early-and-broadly-about-expected-automation-impact)
before applying the label migration.
* [ ] (If applicable) Archive the old label with renaming and adding "DEPRECATED" at the end of the label name.
* [x] (If applicable) Delete the old dashboard views using the deprecated labels.
* [x] (If applicable) Update the group triage report definition to use the new label.
* [x] (If applicable) Update the group label's description to refer to the new Stage.
/cc @gl-quality/eng-prod | 2 |
7,776,928 | 34,517,302 | 2020-05-13 15:49:17.864 | Obsolete group: attack surface | ## Summary
* ~"group::attack surface" should no longer be used.
### Action items
* [x] (If applicable) Dashboard creation: create or update the stage/group in <https://gitlab.com/gitlab-org/gitlab-insights/blob/master/lib/gitlab_insights.rb>: https://gitlab.com/gitlab-org/gitlab-insights/-/merge_requests/195
* [x] (If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests.
* [ ] Check if label migration will apply labels which have subscribers.
[Communicate with the subscribers](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#communicate-early-and-broadly-about-expected-automation-impact)
before applying the label migration.
* [ ] (If applicable) Archive the old label with renaming and adding "DEPRECATED" at the end of the label name.
* [x] (If applicable) Delete the old dashboard views using the deprecated labels.
* [x] (If applicable) Update the group triage report definition to use the new label.
* [x] (If applicable) Update the group label's description to refer to the new Stage.
/cc @gl-quality/eng-prod | 2 |