No description provided.
hac541309 changed pull request status to open

commit diffs look really ugly but in essence they are changing folder names

it's hard to tell from the diffs but basically

03-15 -> CC-MAIN-2015-14
09-16 -> CC-MAIN-2016-40

I hoped that a PR would better illustrate what I meant in #2

OSCAR org

Hey @hac541309 , sorry for the late reply, I'm currently on holidays so sometimes it's difficult to connect and work. Just a question, if I understood correctly, you changed all the folder names to the name of the snapshot, is that correct?

I'm just double checking mostly because the diffs are super difficult to read and I just have a list of a ton of stuff being deleted 😅

Yes that is correct. Using snapshot names is the way many other datasets including falconweb approach this issue.
It might be the best way since it is most identifiable so we can avoid confusion and difficulty.

However, if you do agree that that is the way to go, it might still be better to change the folder names from upstream and reuploading instead of pulling this PR to avoid errors.
I did make sure to change the name correctly, but I have to agree the PR and commit is just filled with deletions and additions so it's hard to check if it is indeed correct.

Ready to merge
This branch is ready to get merged automatically.

Sign up or log in to comment