microsoft

/

Phi-3-mini-4k-instruct

like 804

Thanks for updating new version of phi-3-mini! The improvement of new version is so outstanding！！

When I replace the new version(2024.7) to the old version(2024.4)， there is a new error that "raise ValueError(f"rope_scaling's type field must be one of ['su', 'yarn'], got {rope_scaling_type}")"

detail in the figure

I check the difference from "Phi-3-mini-4k-instruct/configuration_phi3.py" between the new version(2024.7) and the old version(2024.4). The code of https://huggingface.co/microsoft/Phi-3-mini-4k-instruct/blob/c1358f8a35e6d2af81890deffbbfa575b978c62f/configuration_phi3.py#L204 is updated.

I also check the the transformers（4.41.2）https://github.com/huggingface/transformers/blob/f91c16d270e5e3ff32fdb32ccf286d05c03dfa66/src/transformers/models/phi3/configuration_phi3.py#L184. The transformers（4.41.2） is just same to the old version(2024.4).

So, maybe, the transformers should be updated for the new version(2024.7)

Look for your reply!!