type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/infer/pulls/comments/234249462","pull_request_review_id":175853916,"id":234249462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDI0OTQ2Mg==","diff_hunk":"@@ -174,17 +175,18 @@ val mk_command_doc :\n command_exe] records information about a command that is used to create its man page. A lot of\n the concepts are taken from man-pages(7).\n \n- - [command_exe] is the name of the command, preferably an executable that selects the command\n- - [title] will be the title of the manual\n- - [section] will be the section of the manual (the number 7 in man-pages(7))\n- - [version] is the version string of the command\n- - [date] is the date of the last modification of the manual\n- - [short_description] is a one-line description of the command\n- - [options] can be either [`Replace blocks], which populates the OPTIONS section with [blocks],\n+ {ul\n+ {- [command_exe] is the name of the command, preferably an executable that selects the command}\n+ {- [title] will be the title of the manual}\n+ {- [section] will be the section of the manual (the number 7 in man-pages(7))}\n+ {- [version] is the version string of the command}\n+ {- [date] is the date of the last modification of the manual}\n+ {- [short_description] is a one-line description of the command}\n+ {- [options] can be either [`Replace blocks], which populates the OPTIONS section with [blocks],\n or [`Prepend blocks], in which case the options from the command are used, prepended by\n- [blocks]. If unspecified it defaults to [`Prepend []].\n- - All the other [section_name] options correspond to the contents of the section [section_name].\n- Some are mandatory and some are not.\n+ [blocks]. If unspecified it defaults to [`Prepend []].}\n+ {- All the other [section_name] options correspond to the contents of the section [section_name].\n+ Some are mandatory and some are not.}}","path":"infer/src/base/CommandLineOption.mli","position":68,"original_position":68,"commit_id":"932dae853144039392d78ba2655249a3f58ec199","original_commit_id":"932dae853144039392d78ba2655249a3f58ec199","user":{"login":"jberdine","id":1466830,"node_id":"MDQ6VXNlcjE0NjY4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1466830?v=4","gravatar_id":"","url":"https://api.github.com/users/jberdine","html_url":"https://github.com/jberdine","followers_url":"https://api.github.com/users/jberdine/followers","following_url":"https://api.github.com/users/jberdine/following{/other_user}","gists_url":"https://api.github.com/users/jberdine/gists{/gist_id}","starred_url":"https://api.github.com/users/jberdine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberdine/subscriptions","organizations_url":"https://api.github.com/users/jberdine/orgs","repos_url":"https://api.github.com/users/jberdine/repos","events_url":"https://api.github.com/users/jberdine/events{/privacy}","received_events_url":"https://api.github.com/users/jberdine/received_events","type":"User","site_admin":false},"body":"I'm not sure why the heavy syntax is needed here. Is there a different edit that can be used to keep the lighter syntax?","created_at":"2018-11-16T15:41:27Z","updated_at":"2018-11-16T15:45:30Z","html_url":"https://github.com/facebook/infer/pull/1024#discussion_r234249462","pull_request_url":"https://api.github.com/repos/facebook/infer/pulls/1024","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/infer/pulls/comments/234249462"},"html":{"href":"https://github.com/facebook/infer/pull/1024#discussion_r234249462"},"pull_request":{"href":"https://api.github.com/repos/facebook/infer/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/infer/pulls/1024","id":231565916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTY1OTE2","html_url":"https://github.com/facebook/infer/pull/1024","diff_url":"https://github.com/facebook/infer/pull/1024.diff","patch_url":"https://github.com/facebook/infer/pull/1024.patch","issue_url":"https://api.github.com/repos/facebook/infer/issues/1024","number":1024,"state":"open","locked":false,"title":"Fix docstrings","user":{"login":"gpetiot","id":497999,"node_id":"MDQ6VXNlcjQ5Nzk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/497999?v=4","gravatar_id":"","url":"https://api.github.com/users/gpetiot","html_url":"https://github.com/gpetiot","followers_url":"https://api.github.com/users/gpetiot/followers","following_url":"https://api.github.com/users/gpetiot/following{/other_user}","gists_url":"https://api.github.com/users/gpetiot/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetiot/subscriptions","organizations_url":"https://api.github.com/users/gpetiot/orgs","repos_url":"https://api.github.com/users/gpetiot/repos","events_url":"https://api.github.com/users/gpetiot/events{/privacy}","received_events_url":"https://api.github.com/users/gpetiot/received_events","type":"User","site_admin":false},"body":"@jberdine Here are the files to fix so that ocamlformat can be applied to the whole codebase. Don't hesitate to tell me if some changes are too harsh and need ocamlformat to be fixed instead.","created_at":"2018-11-16T15:27:19Z","updated_at":"2018-11-16T15:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f33c51fcb38da6c91ef572a40e897044db079cca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858864,"node_id":"MDU6TGFiZWwxOTY4NTg4NjQ=","url":"https://api.github.com/repos/facebook/infer/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/infer/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/facebook/infer/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/facebook/infer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/infer/issues/1024/comments","statuses_url":"https://api.github.com/repos/facebook/infer/statuses/932dae853144039392d78ba2655249a3f58ec199","head":{"label":"gpetiot:fix-docstrings","ref":"fix-docstrings","sha":"932dae853144039392d78ba2655249a3f58ec199","user":{"login":"gpetiot","id":497999,"node_id":"MDQ6VXNlcjQ5Nzk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/497999?v=4","gravatar_id":"","url":"https://api.github.com/users/gpetiot","html_url":"https://github.com/gpetiot","followers_url":"https://api.github.com/users/gpetiot/followers","following_url":"https://api.github.com/users/gpetiot/following{/other_user}","gists_url":"https://api.github.com/users/gpetiot/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetiot/subscriptions","organizations_url":"https://api.github.com/users/gpetiot/orgs","repos_url":"https://api.github.com/users/gpetiot/repos","events_url":"https://api.github.com/users/gpetiot/events{/privacy}","received_events_url":"https://api.github.com/users/gpetiot/received_events","type":"User","site_admin":false},"repo":{"id":157808174,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4MDgxNzQ=","name":"infer","full_name":"gpetiot/infer","private":false,"owner":{"login":"gpetiot","id":497999,"node_id":"MDQ6VXNlcjQ5Nzk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/497999?v=4","gravatar_id":"","url":"https://api.github.com/users/gpetiot","html_url":"https://github.com/gpetiot","followers_url":"https://api.github.com/users/gpetiot/followers","following_url":"https://api.github.com/users/gpetiot/following{/other_user}","gists_url":"https://api.github.com/users/gpetiot/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetiot/subscriptions","organizations_url":"https://api.github.com/users/gpetiot/orgs","repos_url":"https://api.github.com/users/gpetiot/repos","events_url":"https://api.github.com/users/gpetiot/events{/privacy}","received_events_url":"https://api.github.com/users/gpetiot/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gpetiot/infer","description":"A static analyzer for Java, C, C++, and Objective-C","fork":true,"url":"https://api.github.com/repos/gpetiot/infer","forks_url":"https://api.github.com/repos/gpetiot/infer/forks","keys_url":"https://api.github.com/repos/gpetiot/infer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpetiot/infer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpetiot/infer/teams","hooks_url":"https://api.github.com/repos/gpetiot/infer/hooks","issue_events_url":"https://api.github.com/repos/gpetiot/infer/issues/events{/number}","events_url":"https://api.github.com/repos/gpetiot/infer/events","assignees_url":"https://api.github.com/repos/gpetiot/infer/assignees{/user}","branches_url":"https://api.github.com/repos/gpetiot/infer/branches{/branch}","tags_url":"https://api.github.com/repos/gpetiot/infer/tags","blobs_url":"https://api.github.com/repos/gpetiot/infer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpetiot/infer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpetiot/infer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpetiot/infer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpetiot/infer/statuses/{sha}","languages_url":"https://api.github.com/repos/gpetiot/infer/languages","stargazers_url":"https://api.github.com/repos/gpetiot/infer/stargazers","contributors_url":"https://api.github.com/repos/gpetiot/infer/contributors","subscribers_url":"https://api.github.com/repos/gpetiot/infer/subscribers","subscription_url":"https://api.github.com/repos/gpetiot/infer/subscription","commits_url":"https://api.github.com/repos/gpetiot/infer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpetiot/infer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpetiot/infer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpetiot/infer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpetiot/infer/contents/{+path}","compare_url":"https://api.github.com/repos/gpetiot/infer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpetiot/infer/merges","archive_url":"https://api.github.com/repos/gpetiot/infer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpetiot/infer/downloads","issues_url":"https://api.github.com/repos/gpetiot/infer/issues{/number}","pulls_url":"https://api.github.com/repos/gpetiot/infer/pulls{/number}","milestones_url":"https://api.github.com/repos/gpetiot/infer/milestones{/number}","notifications_url":"https://api.github.com/repos/gpetiot/infer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpetiot/infer/labels{/name}","releases_url":"https://api.github.com/repos/gpetiot/infer/releases{/id}","deployments_url":"https://api.github.com/repos/gpetiot/infer/deployments","created_at":"2018-11-16T03:34:41Z","updated_at":"2018-11-16T03:34:48Z","pushed_at":"2018-11-16T15:22:53Z","git_url":"git://github.com/gpetiot/infer.git","ssh_url":"git@github.com:gpetiot/infer.git","clone_url":"https://github.com/gpetiot/infer.git","svn_url":"https://github.com/gpetiot/infer","homepage":"http://fbinfer.com/","size":94463,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"fac993216876c55a412c3a0d87edc7dbcc866dac","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29857799,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg1Nzc5OQ==","name":"infer","full_name":"facebook/infer","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/infer","description":"A static analyzer for Java, C, C++, and Objective-C","fork":false,"url":"https://api.github.com/repos/facebook/infer","forks_url":"https://api.github.com/repos/facebook/infer/forks","keys_url":"https://api.github.com/repos/facebook/infer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/infer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/infer/teams","hooks_url":"https://api.github.com/repos/facebook/infer/hooks","issue_events_url":"https://api.github.com/repos/facebook/infer/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/infer/events","assignees_url":"https://api.github.com/repos/facebook/infer/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/infer/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/infer/tags","blobs_url":"https://api.github.com/repos/facebook/infer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/infer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/infer/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/infer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/infer/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/infer/languages","stargazers_url":"https://api.github.com/repos/facebook/infer/stargazers","contributors_url":"https://api.github.com/repos/facebook/infer/contributors","subscribers_url":"https://api.github.com/repos/facebook/infer/subscribers","subscription_url":"https://api.github.com/repos/facebook/infer/subscription","commits_url":"https://api.github.com/repos/facebook/infer/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/infer/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/infer/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/infer/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/infer/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/infer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/infer/merges","archive_url":"https://api.github.com/repos/facebook/infer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/infer/downloads","issues_url":"https://api.github.com/repos/facebook/infer/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/infer/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/infer/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/infer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/infer/labels{/name}","releases_url":"https://api.github.com/repos/facebook/infer/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/infer/deployments","created_at":"2015-01-26T11:19:13Z","updated_at":"2018-11-16T12:08:48Z","pushed_at":"2018-11-16T15:27:19Z","git_url":"git://github.com/facebook/infer.git","ssh_url":"git@github.com:facebook/infer.git","clone_url":"https://github.com/facebook/infer.git","svn_url":"https://github.com/facebook/infer","homepage":"http://fbinfer.com/","size":94498,"stargazers_count":9035,"watchers_count":9035,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1223,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1223,"open_issues":158,"watchers":9035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/infer/pulls/1024"},"html":{"href":"https://github.com/facebook/infer/pull/1024"},"issue":{"href":"https://api.github.com/repos/facebook/infer/issues/1024"},"comments":{"href":"https://api.github.com/repos/facebook/infer/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/infer/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/infer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/infer/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/infer/statuses/932dae853144039392d78ba2655249a3f58ec199"}},"author_association":"NONE"}} | {
"id": 29857799,
"name": "facebook/infer",
"url": "https://api.github.com/repos/facebook/infer"
} | {
"id": 1466830,
"login": "jberdine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1466830?",
"url": "https://api.github.com/users/jberdine"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2018-11-16T15:41:27 | 8603035620 | {"actor":{"display_login":"jberdine"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/233138315","pull_request_review_id":174480673,"id":233138315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzEzODMxNQ==","diff_hunk":"@@ -138,6 +138,8 @@ struct BlockBasedTableOptions {\n \n // If non-NULL use the specified cache for compressed blocks.\n // If NULL, rocksdb will not use a compressed block cache.\n+ // Note: though it looks similar too `block_cache`, RocksDB doesn't put the","path":"include/rocksdb/table.h","position":4,"original_position":4,"commit_id":"fbc20a63eee82687892a33dff5fd693d52f8df00","original_commit_id":"fbc20a63eee82687892a33dff5fd693d52f8df00","user":{"login":"maysamyabandeh","id":1167741,"node_id":"MDQ6VXNlcjExNjc3NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"body":"s/too/to/","created_at":"2018-11-13T17:09:07Z","updated_at":"2018-11-13T17:30:20Z","html_url":"https://github.com/facebook/rocksdb/pull/4650#discussion_r233138315","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4650","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/233138315"},"html":{"href":"https://github.com/facebook/rocksdb/pull/4650#discussion_r233138315"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4650"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4650","id":229167798,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTY3Nzk4","html_url":"https://github.com/facebook/rocksdb/pull/4650","diff_url":"https://github.com/facebook/rocksdb/pull/4650.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4650.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4650","number":4650,"state":"open","locked":false,"title":"Remove two variables from BlockContents class and don't use class Block for compressed block","user":{"login":"siying","id":5334567,"node_id":"MDQ6VXNlcjUzMzQ1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5334567?v=4","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"body":"Summary: We carry compression type and \"cachable\" variables for every block in the block cache, while they take well-known values. 8-byte is wasted for each block (2-byte for useful information but it takes 8 bytes because of padding). With this change, these two variables are removed.\r\n\r\nThe cachable information is only useful in the process of reading the block. We use other information to infer from it. For compressed blocks, the compression type is a part of the block content itself so we can get it from there.\r\n\r\nSome code is slightly refactored so that the cachable information can flow better.\r\n\r\nAnother change is to only use class BlockContents for compressed block, and narrow the class Block to only be used for uncompressed blocks, including blocks in compressed block cache. This can make the Block class less confusing. It also saves tens of bytes for each block in compressed block cache.\r\n\r\nTest Plan: Run tests with ASAN","created_at":"2018-11-07T21:04:41Z","updated_at":"2018-11-13T17:30:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab33b65acbc09ab71d54841bca8c749bf1bb6bd9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yiwu-arbug","id":2606959,"node_id":"MDQ6VXNlcjI2MDY5NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2606959?v=4","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4650/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4650/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4650/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/fbc20a63eee82687892a33dff5fd693d52f8df00","head":{"label":"siying:reduce_block_contest3","ref":"reduce_block_contest3","sha":"fbc20a63eee82687892a33dff5fd693d52f8df00","user":{"login":"siying","id":5334567,"node_id":"MDQ6VXNlcjUzMzQ1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5334567?v=4","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"repo":{"id":48715206,"node_id":"MDEwOlJlcG9zaXRvcnk0ODcxNTIwNg==","name":"rocksdb","full_name":"siying/rocksdb","private":false,"owner":{"login":"siying","id":5334567,"node_id":"MDQ6VXNlcjUzMzQ1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5334567?v=4","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"html_url":"https://github.com/siying/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/siying/rocksdb","forks_url":"https://api.github.com/repos/siying/rocksdb/forks","keys_url":"https://api.github.com/repos/siying/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siying/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siying/rocksdb/teams","hooks_url":"https://api.github.com/repos/siying/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/siying/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/siying/rocksdb/events","assignees_url":"https://api.github.com/repos/siying/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/siying/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/siying/rocksdb/tags","blobs_url":"https://api.github.com/repos/siying/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siying/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siying/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/siying/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siying/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/siying/rocksdb/languages","stargazers_url":"https://api.github.com/repos/siying/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/siying/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/siying/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/siying/rocksdb/subscription","commits_url":"https://api.github.com/repos/siying/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/siying/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/siying/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/siying/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/siying/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/siying/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siying/rocksdb/merges","archive_url":"https://api.github.com/repos/siying/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siying/rocksdb/downloads","issues_url":"https://api.github.com/repos/siying/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/siying/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/siying/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/siying/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siying/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/siying/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/siying/rocksdb/deployments","created_at":"2015-12-28T22:25:13Z","updated_at":"2018-11-09T19:43:35Z","pushed_at":"2018-11-13T16:50:48Z","git_url":"git://github.com/siying/rocksdb.git","ssh_url":"git@github.com:siying/rocksdb.git","clone_url":"https://github.com/siying/rocksdb.git","svn_url":"https://github.com/siying/rocksdb","homepage":"http://rocksdb.org","size":107411,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"859dbda6e3cac17416aff48f1760d01707867351","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-11-13T12:13:34Z","pushed_at":"2018-11-13T16:50:51Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":120322,"stargazers_count":12060,"watchers_count":12060,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2657,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2657,"open_issues":246,"watchers":12060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4650"},"html":{"href":"https://github.com/facebook/rocksdb/pull/4650"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4650"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4650/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4650/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4650/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/fbc20a63eee82687892a33dff5fd693d52f8df00"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6934395,
"name": "facebook/rocksdb",
"url": "https://api.github.com/repos/facebook/rocksdb"
} | {
"id": 1167741,
"login": "maysamyabandeh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1167741?",
"url": "https://api.github.com/users/maysamyabandeh"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2018-11-13T17:09:07 | 8582649849 | {"actor":{"display_login":"maysamyabandeh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/168273067","pull_request_review_id":96613788,"id":168273067,"diff_hunk":"@@ -0,0 +1,201 @@\n+/**\n+ * Copyright (c) 2014-present, Facebook, Inc.\n+ *\n+ * This source code is licensed under the MIT license found in the\n+ * LICENSE file in the root directory of this source tree.\n+ *\n+ * @flow\n+ */\n+\n+import React from 'react';\n+import warning from 'fbjs/lib/warning';\n+\n+function noop() {}\n+function identity<T>(t: T): T {\n+ return t;\n+}\n+\n+type Status = 0 | 1 | 2;\n+\n+const Empty = 0;\n+const Resolved = 1;\n+const Rejected = 2;\n+\n+type Record<V> = {|\n+ status: Status,\n+ suspender: Promise<V> | null,\n+ value: V | null,\n+ error: Error | null,\n+|};\n+\n+type RecordCache<K, V> = Map<K, Record<V>>;\n+// TODO: How do you express this type with Flow?\n+type ResourceCache = Map<any, RecordCache<any, any>>;\n+type Cache = {\n+ invalidate(): void,\n+ read<K, V>(resourceType: mixed, key: K, miss: (K) => Promise<V>): V,\n+ preload<K, V>(resourceType: mixed, key: K, miss: (K) => Promise<V>): void,\n+\n+ // DEV-only\n+ $$typeof?: Symbol | number,\n+};\n+\n+let CACHE_TYPE;\n+if (__DEV__) {\n+ CACHE_TYPE = 0xcac4e;\n+}\n+\n+let isCache;\n+if (__DEV__) {\n+ isCache = value =>\n+ value !== null &&\n+ typeof value === 'object' &&\n+ value.$$typeof === CACHE_TYPE;\n+}\n+\n+export function createCache(invalidator: () => mixed): Cache {\n+ const resourceCache: ResourceCache = new Map();\n+\n+ function getRecord<K, V>(resourceType: any, key: K): Record<V> {\n+ if (__DEV__) {\n+ warning(\n+ typeof resourceType !== 'string' && typeof resourceType !== 'number',\n+ 'Invalid resourceType: Expected a symbol, object, or function, but ' +\n+ 'instead received: %s. Strings and numbers are not permitted as ' +\n+ 'resource types.',\n+ resourceType,\n+ );\n+ }\n+\n+ let recordCache = resourceCache.get(resourceType);\n+ if (recordCache !== undefined) {\n+ const record = recordCache.get(key);\n+ if (record !== undefined) {\n+ return record;\n+ }\n+ } else {\n+ recordCache = new Map();\n+ resourceCache.set(resourceType, recordCache);\n+ }\n+\n+ const record = {\n+ status: Empty,\n+ suspender: null,\n+ value: null,\n+ error: null,\n+ };\n+ recordCache.set(key, record);\n+ return record;\n+ }\n+\n+ function load<K, V>(record: Record<V>, key: K, miss: K => Promise<V>) {\n+ const suspender = miss(key);\n+ record.suspender = suspender;\n+ suspender.then(\n+ value => {\n+ // Resource loaded successfully.\n+ record.suspender = null;\n+ record.status = Resolved;\n+ record.value = value;\n+ },\n+ error => {\n+ // Resource failed to load. Stash the error for later so we can throw it\n+ // the next time it's requested.\n+ record.suspender = null;\n+ record.status = Rejected;\n+ record.error = error;\n+ },\n+ );\n+ return suspender;\n+ }\n+\n+ const cache: Cache = {\n+ invalidate() {\n+ invalidator();\n+ },\n+ preload<K, V>(resourceType: any, key: K, miss: K => Promise<V>): void {\n+ const record: Record<V> = getRecord(resourceType, key);\n+ const suspender = record.suspender;\n+ if (suspender !== null) {\n+ // There's already a pending request.\n+ return;\n+ }\n+ switch (record.status) {\n+ case Empty:\n+ // Warm the cache.\n+ load(record, key, miss);\n+ return;\n+ case Resolved:\n+ case Rejected:\n+ // The resource is already in the cache.\n+ return;\n+ }\n+ },\n+ read<K, V>(resourceType: any, key: K, miss: K => Promise<V>): V {\n+ const record: Record<V> = getRecord(resourceType, key);\n+ const suspender = record.suspender;\n+ if (suspender !== null) {\n+ // There's already a pending request.\n+ throw suspender;\n+ }\n+ switch (record.status) {\n+ case Empty:\n+ // Load the requested resource.\n+ throw load(record, key, miss);\n+ case Resolved:\n+ return ((record.value: any): V);\n+ case Rejected:\n+ default:\n+ // The requested resource previously failed loading.\n+ // TODO: When should we try again?\n+ throw record.error;\n+ }\n+ },\n+ };\n+\n+ if (__DEV__) {\n+ cache.$$typeof = CACHE_TYPE;\n+ }\n+ return cache;\n+}\n+\n+type ResourceReader<K, V> = (Cache, K) => V;\n+\n+type Resource<K, V> = ResourceReader<K, V> & {\n+ preload(cache: Cache, key: K): void,\n+};\n+\n+export function createResource<K, V, H>(\n+ loadResource: K => Promise<V>,","path":"packages/simple-cache-provider/src/SimpleCacheProvider.js","position":169,"original_position":169,"commit_id":"c7b45ae1101b1e1ab63c876d1b23ce0c91059a6d","original_commit_id":"c7b45ae1101b1e1ab63c876d1b23ce0c91059a6d","user":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"Could add a DEV warning if this is not `typeof loadResource === 'function'`.","created_at":"2018-02-14T18:49:20Z","updated_at":"2018-02-14T18:53:30Z","html_url":"https://github.com/facebook/react/pull/12224#discussion_r168273067","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/12224","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/168273067"},"html":{"href":"https://github.com/facebook/react/pull/12224#discussion_r168273067"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/12224"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/12224","id":169013086,"html_url":"https://github.com/facebook/react/pull/12224","diff_url":"https://github.com/facebook/react/pull/12224.diff","patch_url":"https://github.com/facebook/react/pull/12224.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/12224","number":12224,"state":"open","locked":false,"title":"[experimental] simple-cache-provider","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"body":"Pushing an early version of this for testing and demonstration purposes.","created_at":"2018-02-14T03:17:59Z","updated_at":"2018-02-14T18:53:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cb7e1e3d77bc216d947a1fb3173379c50048665","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858374,"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/12224/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/12224/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/12224/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/c7b45ae1101b1e1ab63c876d1b23ce0c91059a6d","head":{"label":"acdlite:simple-cache-provider","ref":"simple-cache-provider","sha":"c7b45ae1101b1e1ab63c876d1b23ce0c91059a6d","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"repo":{"id":45281256,"name":"react","full_name":"acdlite/react","owner":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acdlite/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/acdlite/react","forks_url":"https://api.github.com/repos/acdlite/react/forks","keys_url":"https://api.github.com/repos/acdlite/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acdlite/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acdlite/react/teams","hooks_url":"https://api.github.com/repos/acdlite/react/hooks","issue_events_url":"https://api.github.com/repos/acdlite/react/issues/events{/number}","events_url":"https://api.github.com/repos/acdlite/react/events","assignees_url":"https://api.github.com/repos/acdlite/react/assignees{/user}","branches_url":"https://api.github.com/repos/acdlite/react/branches{/branch}","tags_url":"https://api.github.com/repos/acdlite/react/tags","blobs_url":"https://api.github.com/repos/acdlite/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acdlite/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acdlite/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/acdlite/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acdlite/react/statuses/{sha}","languages_url":"https://api.github.com/repos/acdlite/react/languages","stargazers_url":"https://api.github.com/repos/acdlite/react/stargazers","contributors_url":"https://api.github.com/repos/acdlite/react/contributors","subscribers_url":"https://api.github.com/repos/acdlite/react/subscribers","subscription_url":"https://api.github.com/repos/acdlite/react/subscription","commits_url":"https://api.github.com/repos/acdlite/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/acdlite/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/acdlite/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/acdlite/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/acdlite/react/contents/{+path}","compare_url":"https://api.github.com/repos/acdlite/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acdlite/react/merges","archive_url":"https://api.github.com/repos/acdlite/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acdlite/react/downloads","issues_url":"https://api.github.com/repos/acdlite/react/issues{/number}","pulls_url":"https://api.github.com/repos/acdlite/react/pulls{/number}","milestones_url":"https://api.github.com/repos/acdlite/react/milestones{/number}","notifications_url":"https://api.github.com/repos/acdlite/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acdlite/react/labels{/name}","releases_url":"https://api.github.com/repos/acdlite/react/releases{/id}","deployments_url":"https://api.github.com/repos/acdlite/react/deployments","created_at":"2015-10-30T23:18:48Z","updated_at":"2017-10-24T15:02:29Z","pushed_at":"2018-02-14T04:15:52Z","git_url":"git://github.com/acdlite/react.git","ssh_url":"git@github.com:acdlite/react.git","clone_url":"https://github.com/acdlite/react.git","svn_url":"https://github.com/acdlite/react","homepage":"https://facebook.github.io/react/","size":112299,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1fd205ad2d101f441622c9bb7e2ccb480281e0a0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-02-14T18:47:44Z","pushed_at":"2018-02-14T11:47:34Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":134920,"stargazers_count":88371,"watchers_count":88371,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16729,"mirror_url":null,"archived":false,"open_issues_count":374,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":16729,"open_issues":374,"watchers":88371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/12224"},"html":{"href":"https://github.com/facebook/react/pull/12224"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/12224"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/12224/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/12224/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/12224/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/c7b45ae1101b1e1ab63c876d1b23ce0c91059a6d"}},"author_association":"MEMBER"}} | {
"id": 10270250,
"name": "facebook/react",
"url": "https://api.github.com/repos/facebook/react"
} | {
"id": 63648,
"login": "sebmarkbage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/63648?",
"url": "https://api.github.com/users/sebmarkbage"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2018-02-14T18:49:20 | 7245666275 | {"actor":{"display_login":"sebmarkbage"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/square/misk/pulls/comments/238835182","pull_request_review_id":181475306,"id":238835182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODgzNTE4Mg==","diff_hunk":"@@ -0,0 +1,55 @@\n+package misk.redis\n+\n+import java.time.Duration\n+\n+/** A Redis client. */\n+interface Redis {\n+ /**\n+ * Deletes a single key.\n+ *\n+ * @param key the key to delete\n+ * @return 0 if the key was not deleted, 1 if the key was deleted\n+ */\n+ fun del(key: String): Long\n+\n+ /**\n+ * Deletes multiple keys.\n+ *\n+ * @param keys the keys to delete\n+ * @return 0 if none of the keys were deleted, otherwise a positive integer\n+ * representing the number of keys that were deleted\n+ */\n+ fun del(vararg keys: String): Long\n+\n+ /**\n+ * Retrieves a key.\n+ *\n+ * @param key the key to retrieve\n+ * @return a string value if the key was found, null if the key was not found\n+ */\n+ fun get(key: String): String?\n+\n+ /**\n+ * Sets a value for a key.\n+ *\n+ * @param key the key to set\n+ * @param value the value to set\n+ * @return the value that was set\n+ */\n+ fun set(key: String, value: String): String\n+\n+ /**\n+ * Sets a key with an expiration date.\n+ *\n+ * @param key the key to set\n+ * @param expiryDuration the amount of time before the key expires\n+ * @param value the value to set\n+ * @return the value that was set\n+ */\n+ fun setex(key: String, expiryDuration: Duration, value: String): String\n+\n+ /**\n+ * Closes the connection to the redis instance.\n+ */\n+ fun close()","path":"misk-redis/src/main/kotlin/misk/redis/Redis.kt","position":54,"original_position":54,"commit_id":"8d0d3d9b8d6d664e182d2f734837465b1a86aa36","original_commit_id":"8d0d3d9b8d6d664e182d2f734837465b1a86aa36","user":{"login":"mmihic","id":392793,"node_id":"MDQ6VXNlcjM5Mjc5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/392793?v=4","gravatar_id":"","url":"https://api.github.com/users/mmihic","html_url":"https://github.com/mmihic","followers_url":"https://api.github.com/users/mmihic/followers","following_url":"https://api.github.com/users/mmihic/following{/other_user}","gists_url":"https://api.github.com/users/mmihic/gists{/gist_id}","starred_url":"https://api.github.com/users/mmihic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmihic/subscriptions","organizations_url":"https://api.github.com/users/mmihic/orgs","repos_url":"https://api.github.com/users/mmihic/repos","events_url":"https://api.github.com/users/mmihic/events{/privacy}","received_events_url":"https://api.github.com/users/mmihic/received_events","type":"User","site_admin":false},"body":"Does this need to be exposed to application code? I'd think the need to close a is client specific to the `Jedis` implementation and handled for applications automatically by the `RedisService`, in which case this method should just be an `internal` method on `RealRedis`","created_at":"2018-12-04T20:57:05Z","updated_at":"2018-12-04T20:57:06Z","html_url":"https://github.com/square/misk/pull/686#discussion_r238835182","pull_request_url":"https://api.github.com/repos/square/misk/pulls/686","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/comments/238835182"},"html":{"href":"https://github.com/square/misk/pull/686#discussion_r238835182"},"pull_request":{"href":"https://api.github.com/repos/square/misk/pulls/686"}}},"pull_request":{"url":"https://api.github.com/repos/square/misk/pulls/686","id":235615675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjE1Njc1","html_url":"https://github.com/square/misk/pull/686","diff_url":"https://github.com/square/misk/pull/686.diff","patch_url":"https://github.com/square/misk/pull/686.patch","issue_url":"https://api.github.com/repos/square/misk/issues/686","number":686,"state":"open","locked":false,"title":"Add a simple misk-redis module","user":{"login":"hamdanjaveed","id":4147338,"node_id":"MDQ6VXNlcjQxNDczMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4147338?v=4","gravatar_id":"","url":"https://api.github.com/users/hamdanjaveed","html_url":"https://github.com/hamdanjaveed","followers_url":"https://api.github.com/users/hamdanjaveed/followers","following_url":"https://api.github.com/users/hamdanjaveed/following{/other_user}","gists_url":"https://api.github.com/users/hamdanjaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/hamdanjaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamdanjaveed/subscriptions","organizations_url":"https://api.github.com/users/hamdanjaveed/orgs","repos_url":"https://api.github.com/users/hamdanjaveed/repos","events_url":"https://api.github.com/users/hamdanjaveed/events{/privacy}","received_events_url":"https://api.github.com/users/hamdanjaveed/received_events","type":"User","site_admin":false},"body":"* Uses the `Jedis` redis client\r\n* Permits 4 operations, `get`, `set`, `setex` and `del` for strings only","created_at":"2018-12-03T22:32:21Z","updated_at":"2018-12-04T20:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96bb028721ea42347fce780bb7fd829dfbfaf753","assignee":null,"assignees":[],"requested_reviewers":[{"login":"swankjesse","id":133019,"node_id":"MDQ6VXNlcjEzMzAxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/133019?v=4","gravatar_id":"","url":"https://api.github.com/users/swankjesse","html_url":"https://github.com/swankjesse","followers_url":"https://api.github.com/users/swankjesse/followers","following_url":"https://api.github.com/users/swankjesse/following{/other_user}","gists_url":"https://api.github.com/users/swankjesse/gists{/gist_id}","starred_url":"https://api.github.com/users/swankjesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swankjesse/subscriptions","organizations_url":"https://api.github.com/users/swankjesse/orgs","repos_url":"https://api.github.com/users/swankjesse/repos","events_url":"https://api.github.com/users/swankjesse/events{/privacy}","received_events_url":"https://api.github.com/users/swankjesse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/misk/pulls/686/commits","review_comments_url":"https://api.github.com/repos/square/misk/pulls/686/comments","review_comment_url":"https://api.github.com/repos/square/misk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/misk/issues/686/comments","statuses_url":"https://api.github.com/repos/square/misk/statuses/8d0d3d9b8d6d664e182d2f734837465b1a86aa36","head":{"label":"square:hamdan-misk-redis","ref":"hamdan-misk-redis","sha":"8d0d3d9b8d6d664e182d2f734837465b1a86aa36","user":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDcyMTc=","name":"misk","full_name":"square/misk","private":false,"owner":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-12-04T16:35:11Z","pushed_at":"2018-12-04T20:24:20Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":3709,"stargazers_count":124,"watchers_count":124,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":82,"license":null,"forks":18,"open_issues":82,"watchers":124,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"c918d82335ff0a262c9144e4f128c8fd70d37860","user":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDcyMTc=","name":"misk","full_name":"square/misk","private":false,"owner":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-12-04T16:35:11Z","pushed_at":"2018-12-04T20:24:20Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":3709,"stargazers_count":124,"watchers_count":124,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":82,"license":null,"forks":18,"open_issues":82,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/686"},"html":{"href":"https://github.com/square/misk/pull/686"},"issue":{"href":"https://api.github.com/repos/square/misk/issues/686"},"comments":{"href":"https://api.github.com/repos/square/misk/issues/686/comments"},"review_comments":{"href":"https://api.github.com/repos/square/misk/pulls/686/comments"},"review_comment":{"href":"https://api.github.com/repos/square/misk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/misk/pulls/686/commits"},"statuses":{"href":"https://api.github.com/repos/square/misk/statuses/8d0d3d9b8d6d664e182d2f734837465b1a86aa36"}},"author_association":"COLLABORATOR"}} | {
"id": 113107217,
"name": "square/misk",
"url": "https://api.github.com/repos/square/misk"
} | {
"id": 392793,
"login": "mmihic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/392793?",
"url": "https://api.github.com/users/mmihic"
} | {
"id": 82592,
"login": "square",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/82592?",
"url": "https://api.github.com/orgs/square"
} | 2018-12-04T20:57:05 | 8697665634 | {"actor":{"display_login":"mmihic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments/176751205","pull_request_review_id":106511277,"id":176751205,"diff_hunk":"@@ -5,4 +5,14 @@\n thead th {\n padding-top: 0;\n }\n+}\n+\n+/* \n+* This will be removed when we move to version X.X (laura help me here) of the helix-ui code. The version currently used on the site does not have styling for the hxHeading-5 class. ","path":"assets/css/_sass/website/_shame.scss","position":7,"original_position":7,"commit_id":"c41dc264aa5390706c7a0209bb4d92951acd394b","original_commit_id":"c41dc264aa5390706c7a0209bb4d92951acd394b","user":{"login":"nimbinatus","id":1538692,"avatar_url":"https://avatars1.githubusercontent.com/u/1538692?v=4","gravatar_id":"","url":"https://api.github.com/users/nimbinatus","html_url":"https://github.com/nimbinatus","followers_url":"https://api.github.com/users/nimbinatus/followers","following_url":"https://api.github.com/users/nimbinatus/following{/other_user}","gists_url":"https://api.github.com/users/nimbinatus/gists{/gist_id}","starred_url":"https://api.github.com/users/nimbinatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimbinatus/subscriptions","organizations_url":"https://api.github.com/users/nimbinatus/orgs","repos_url":"https://api.github.com/users/nimbinatus/repos","events_url":"https://api.github.com/users/nimbinatus/events{/privacy}","received_events_url":"https://api.github.com/users/nimbinatus/received_events","type":"User","site_admin":false},"body":"h5 appeared in v0.3.0+; we'll be moving to the latest, which is currently v0.4.1","created_at":"2018-03-23T14:26:32Z","updated_at":"2018-03-23T14:26:33Z","html_url":"https://github.com/rackerlabs/design-system/pull/485#discussion_r176751205","pull_request_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/485","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments/176751205"},"html":{"href":"https://github.com/rackerlabs/design-system/pull/485#discussion_r176751205"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/485"}},"in_reply_to_id":176217690},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/design-system/pulls/485","id":176591974,"html_url":"https://github.com/rackerlabs/design-system/pull/485","diff_url":"https://github.com/rackerlabs/design-system/pull/485.diff","patch_url":"https://github.com/rackerlabs/design-system/pull/485.patch","issue_url":"https://api.github.com/repos/rackerlabs/design-system/issues/485","number":485,"state":"open","locked":false,"title":"update(heading): Adjust naming of headers to match Helix-ui","user":{"login":"technabors","id":586682,"avatar_url":"https://avatars3.githubusercontent.com/u/586682?v=4","gravatar_id":"","url":"https://api.github.com/users/technabors","html_url":"https://github.com/technabors","followers_url":"https://api.github.com/users/technabors/followers","following_url":"https://api.github.com/users/technabors/following{/other_user}","gists_url":"https://api.github.com/users/technabors/gists{/gist_id}","starred_url":"https://api.github.com/users/technabors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technabors/subscriptions","organizations_url":"https://api.github.com/users/technabors/orgs","repos_url":"https://api.github.com/users/technabors/repos","events_url":"https://api.github.com/users/technabors/events{/privacy}","received_events_url":"https://api.github.com/users/technabors/received_events","type":"User","site_admin":false},"body":"Headers now match Helix-ui naming specification. Additionally h5 styles\r\nwere written in CSS and added the `_shame.scss` file. These can be\r\nremoved once we update to the newest version of helix-ui; The version\r\nbeing used currently does not include these styles.","created_at":"2018-03-21T19:53:47Z","updated_at":"2018-03-23T14:26:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c9a1bb407128fb9f8f8a3bc9e1158aea035499c","assignee":{"login":"technabors","id":586682,"avatar_url":"https://avatars3.githubusercontent.com/u/586682?v=4","gravatar_id":"","url":"https://api.github.com/users/technabors","html_url":"https://github.com/technabors","followers_url":"https://api.github.com/users/technabors/followers","following_url":"https://api.github.com/users/technabors/following{/other_user}","gists_url":"https://api.github.com/users/technabors/gists{/gist_id}","starred_url":"https://api.github.com/users/technabors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technabors/subscriptions","organizations_url":"https://api.github.com/users/technabors/orgs","repos_url":"https://api.github.com/users/technabors/repos","events_url":"https://api.github.com/users/technabors/events{/privacy}","received_events_url":"https://api.github.com/users/technabors/received_events","type":"User","site_admin":false},"assignees":[{"login":"technabors","id":586682,"avatar_url":"https://avatars3.githubusercontent.com/u/586682?v=4","gravatar_id":"","url":"https://api.github.com/users/technabors","html_url":"https://github.com/technabors","followers_url":"https://api.github.com/users/technabors/followers","following_url":"https://api.github.com/users/technabors/following{/other_user}","gists_url":"https://api.github.com/users/technabors/gists{/gist_id}","starred_url":"https://api.github.com/users/technabors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technabors/subscriptions","organizations_url":"https://api.github.com/users/technabors/orgs","repos_url":"https://api.github.com/users/technabors/repos","events_url":"https://api.github.com/users/technabors/events{/privacy}","received_events_url":"https://api.github.com/users/technabors/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/485/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/485/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/issues/485/comments","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/c41dc264aa5390706c7a0209bb4d92951acd394b","head":{"label":"rackerlabs:surf-721-en","ref":"surf-721-en","sha":"c41dc264aa5390706c7a0209bb4d92951acd394b","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63092460,"name":"design-system","full_name":"rackerlabs/design-system","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/design-system","description":"A prototype of the Design System created by Rackspace Experience Design","fork":false,"url":"https://api.github.com/repos/rackerlabs/design-system","forks_url":"https://api.github.com/repos/rackerlabs/design-system/forks","keys_url":"https://api.github.com/repos/rackerlabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/design-system/teams","hooks_url":"https://api.github.com/repos/rackerlabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/design-system/events","assignees_url":"https://api.github.com/repos/rackerlabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/design-system/tags","blobs_url":"https://api.github.com/repos/rackerlabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/design-system/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/design-system/subscription","commits_url":"https://api.github.com/repos/rackerlabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/design-system/merges","archive_url":"https://api.github.com/repos/rackerlabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/design-system/downloads","issues_url":"https://api.github.com/repos/rackerlabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/design-system/deployments","created_at":"2016-07-11T18:33:13Z","updated_at":"2018-03-23T14:19:48Z","pushed_at":"2018-03-23T14:19:47Z","git_url":"git://github.com/rackerlabs/design-system.git","ssh_url":"git@github.com:rackerlabs/design-system.git","clone_url":"https://github.com/rackerlabs/design-system.git","svn_url":"https://github.com/rackerlabs/design-system","homepage":"","size":259735,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":12,"open_issues":33,"watchers":10,"default_branch":"staging"}},"base":{"label":"rackerlabs:staging","ref":"staging","sha":"56eb298ac6d618685db40fcec7cc96bce3abf424","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63092460,"name":"design-system","full_name":"rackerlabs/design-system","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/design-system","description":"A prototype of the Design System created by Rackspace Experience Design","fork":false,"url":"https://api.github.com/repos/rackerlabs/design-system","forks_url":"https://api.github.com/repos/rackerlabs/design-system/forks","keys_url":"https://api.github.com/repos/rackerlabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/design-system/teams","hooks_url":"https://api.github.com/repos/rackerlabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/design-system/events","assignees_url":"https://api.github.com/repos/rackerlabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/design-system/tags","blobs_url":"https://api.github.com/repos/rackerlabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/design-system/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/design-system/subscription","commits_url":"https://api.github.com/repos/rackerlabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/design-system/merges","archive_url":"https://api.github.com/repos/rackerlabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/design-system/downloads","issues_url":"https://api.github.com/repos/rackerlabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/design-system/deployments","created_at":"2016-07-11T18:33:13Z","updated_at":"2018-03-23T14:19:48Z","pushed_at":"2018-03-23T14:19:47Z","git_url":"git://github.com/rackerlabs/design-system.git","ssh_url":"git@github.com:rackerlabs/design-system.git","clone_url":"https://github.com/rackerlabs/design-system.git","svn_url":"https://github.com/rackerlabs/design-system","homepage":"","size":259735,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":12,"open_issues":33,"watchers":10,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/485"},"html":{"href":"https://github.com/rackerlabs/design-system/pull/485"},"issue":{"href":"https://api.github.com/repos/rackerlabs/design-system/issues/485"},"comments":{"href":"https://api.github.com/repos/rackerlabs/design-system/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/design-system/statuses/c41dc264aa5390706c7a0209bb4d92951acd394b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 63092460,
"name": "rackerlabs/design-system",
"url": "https://api.github.com/repos/rackerlabs/design-system"
} | {
"id": 1538692,
"login": "nimbinatus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1538692?",
"url": "https://api.github.com/users/nimbinatus"
} | {
"id": 84293,
"login": "rackerlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/84293?",
"url": "https://api.github.com/orgs/rackerlabs"
} | 2018-03-23T14:26:32 | 7425693869 | {"actor":{"display_login":"nimbinatus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments/204209019","pull_request_review_id":139256249,"id":204209019,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIwOTAxOQ==","diff_hunk":"@@ -0,0 +1,7 @@\n+<div>\n+ Enable/Disables the TCP_NODELAY flag on the SSH connection.\n+ If set, disable the Nagle algorithm. This means that segments are always sent as soon as possible,","path":"src/main/resources/hudson/plugins/sshslaves/SSHConnector/help-tcpNoDelay.html","position":3,"original_position":3,"commit_id":"afdcc7fc3c78d8a2830880e7b385b88970a2b231","original_commit_id":"afdcc7fc3c78d8a2830880e7b385b88970a2b231","user":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"body":"it come from https://linux.die.net/man/7/tcp","created_at":"2018-07-21T11:46:35Z","updated_at":"2018-07-21T11:46:35Z","html_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90#discussion_r204209019","pull_request_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments/204209019"},"html":{"href":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90#discussion_r204209019"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90","id":202616445,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjE2NDQ1","html_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90","diff_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90.diff","patch_url":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90.patch","issue_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/90","number":90,"state":"open","locked":false,"title":"[JENKINS-52660] Allow to disable TCP_NODELAY","user":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"body":"[JENKINS-52660](https://issues.jenkins-ci.org/browse/JENKINS-52660)\r\n\r\n* Configuration option to disable TCP_NODELAY","created_at":"2018-07-19T16:27:46Z","updated_at":"2018-07-21T11:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3554d7356bb30bd2cf799e0231330fd0fd5b6a29","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":771515247,"node_id":"MDU6TGFiZWw3NzE1MTUyNDc=","url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/labels/work-in-progress","name":"work-in-progress","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/90/comments","statuses_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/afdcc7fc3c78d8a2830880e7b385b88970a2b231","head":{"label":"kuisathaverat:JENKINS-52660","ref":"JENKINS-52660","sha":"afdcc7fc3c78d8a2830880e7b385b88970a2b231","user":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"repo":{"id":124245481,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNDU0ODE=","name":"ssh-slaves-plugin","full_name":"kuisathaverat/ssh-slaves-plugin","owner":{"login":"kuisathaverat","id":5400788,"node_id":"MDQ6VXNlcjU0MDA3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5400788?v=4","gravatar_id":"","url":"https://api.github.com/users/kuisathaverat","html_url":"https://github.com/kuisathaverat","followers_url":"https://api.github.com/users/kuisathaverat/followers","following_url":"https://api.github.com/users/kuisathaverat/following{/other_user}","gists_url":"https://api.github.com/users/kuisathaverat/gists{/gist_id}","starred_url":"https://api.github.com/users/kuisathaverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuisathaverat/subscriptions","organizations_url":"https://api.github.com/users/kuisathaverat/orgs","repos_url":"https://api.github.com/users/kuisathaverat/repos","events_url":"https://api.github.com/users/kuisathaverat/events{/privacy}","received_events_url":"https://api.github.com/users/kuisathaverat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kuisathaverat/ssh-slaves-plugin","description":"Jenkins ssh-slaves plugin","fork":true,"url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin","forks_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/forks","keys_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/teams","hooks_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/hooks","issue_events_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/events","assignees_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/tags","blobs_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/languages","stargazers_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/stargazers","contributors_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/contributors","subscribers_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/subscribers","subscription_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/subscription","commits_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/merges","archive_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/downloads","issues_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/labels{/name}","releases_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/kuisathaverat/ssh-slaves-plugin/deployments","created_at":"2018-03-07T14:10:52Z","updated_at":"2018-03-07T14:10:54Z","pushed_at":"2018-07-21T11:42:28Z","git_url":"git://github.com/kuisathaverat/ssh-slaves-plugin.git","ssh_url":"git@github.com:kuisathaverat/ssh-slaves-plugin.git","clone_url":"https://github.com/kuisathaverat/ssh-slaves-plugin.git","svn_url":"https://github.com/kuisathaverat/ssh-slaves-plugin","homepage":"http://jenkins-ci.org/","size":668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e0e76da32e85e02f5156652d4b3f622ac4fb2b7e","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163791,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYzNzkx","name":"ssh-slaves-plugin","full_name":"jenkinsci/ssh-slaves-plugin","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/ssh-slaves-plugin","description":"Jenkins ssh-slaves plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin","forks_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/deployments","created_at":"2010-12-13T05:56:44Z","updated_at":"2018-07-20T14:28:44Z","pushed_at":"2018-07-21T11:42:30Z","git_url":"git://github.com/jenkinsci/ssh-slaves-plugin.git","ssh_url":"git@github.com:jenkinsci/ssh-slaves-plugin.git","clone_url":"https://github.com/jenkinsci/ssh-slaves-plugin.git","svn_url":"https://github.com/jenkinsci/ssh-slaves-plugin","homepage":"http://jenkins-ci.org/","size":645,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":79,"open_issues":7,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90"},"html":{"href":"https://github.com/jenkinsci/ssh-slaves-plugin/pull/90"},"issue":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/90"},"comments":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/ssh-slaves-plugin/statuses/afdcc7fc3c78d8a2830880e7b385b88970a2b231"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1163791,
"name": "jenkinsci/ssh-slaves-plugin",
"url": "https://api.github.com/repos/jenkinsci/ssh-slaves-plugin"
} | {
"id": 5400788,
"login": "kuisathaverat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5400788?",
"url": "https://api.github.com/users/kuisathaverat"
} | {
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
} | 2018-07-21T11:46:35 | 7998486699 | {"actor":{"display_login":"kuisathaverat"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments/235674679","pull_request_review_id":177592945,"id":235674679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTY3NDY3OQ==","diff_hunk":"@@ -38,24 +37,24 @@\n */\n public interface LogstashIndexerDao {\n @Deprecated\n- static enum IndexerType {\n+ enum IndexerType {\n REDIS,\n RABBIT_MQ,\n ELASTICSEARCH,\n SYSLOG\n }\n \n @Deprecated\n- static enum SyslogFormat {\n+ enum SyslogFormat {\n \tRFC5424,\n \tRFC3164\n }\n \n- static enum SyslogProtocol {\n+ enum SyslogProtocol {\n \tUDP\n }\n \n- public String getDescription();","path":"src/main/java/jenkins/plugins/logstash/persistence/LogstashIndexerDao.java","position":32,"original_position":32,"commit_id":"8cd518f9cd51aa94ce4865eada1b226a1fd20d69","original_commit_id":"8cd518f9cd51aa94ce4865eada1b226a1fd20d69","user":{"login":"jakub-bochenski","id":2794994,"node_id":"MDQ6VXNlcjI3OTQ5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2794994?v=4","gravatar_id":"","url":"https://api.github.com/users/jakub-bochenski","html_url":"https://github.com/jakub-bochenski","followers_url":"https://api.github.com/users/jakub-bochenski/followers","following_url":"https://api.github.com/users/jakub-bochenski/following{/other_user}","gists_url":"https://api.github.com/users/jakub-bochenski/gists{/gist_id}","starred_url":"https://api.github.com/users/jakub-bochenski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakub-bochenski/subscriptions","organizations_url":"https://api.github.com/users/jakub-bochenski/orgs","repos_url":"https://api.github.com/users/jakub-bochenski/repos","events_url":"https://api.github.com/users/jakub-bochenski/events{/privacy}","received_events_url":"https://api.github.com/users/jakub-bochenski/received_events","type":"User","site_admin":false},"body":"you missed the extra semicolon here :)","created_at":"2018-11-22T10:32:35Z","updated_at":"2018-11-22T10:32:35Z","html_url":"https://github.com/jenkinsci/logstash-plugin/pull/82#discussion_r235674679","pull_request_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments/235674679"},"html":{"href":"https://github.com/jenkinsci/logstash-plugin/pull/82#discussion_r235674679"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82","id":229523185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTIzMTg1","html_url":"https://github.com/jenkinsci/logstash-plugin/pull/82","diff_url":"https://github.com/jenkinsci/logstash-plugin/pull/82.diff","patch_url":"https://github.com/jenkinsci/logstash-plugin/pull/82.patch","issue_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/82","number":82,"state":"open","locked":false,"title":"Code Improvements","user":{"login":"darxriggs","id":16874,"node_id":"MDQ6VXNlcjE2ODc0","avatar_url":"https://avatars1.githubusercontent.com/u/16874?v=4","gravatar_id":"","url":"https://api.github.com/users/darxriggs","html_url":"https://github.com/darxriggs","followers_url":"https://api.github.com/users/darxriggs/followers","following_url":"https://api.github.com/users/darxriggs/following{/other_user}","gists_url":"https://api.github.com/users/darxriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/darxriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darxriggs/subscriptions","organizations_url":"https://api.github.com/users/darxriggs/orgs","repos_url":"https://api.github.com/users/darxriggs/repos","events_url":"https://api.github.com/users/darxriggs/events{/privacy}","received_events_url":"https://api.github.com/users/darxriggs/received_events","type":"User","site_admin":false},"body":"After cleaning up the pom.xml I now prepared some commits to improve (just some aspects) the Java code.","created_at":"2018-11-08T22:02:20Z","updated_at":"2018-11-22T10:32:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7715628481fdd5253663ec0ebd65ec0a660b4b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/82/comments","statuses_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/8cd518f9cd51aa94ce4865eada1b226a1fd20d69","head":{"label":"darxriggs:cleanup","ref":"cleanup","sha":"8cd518f9cd51aa94ce4865eada1b226a1fd20d69","user":{"login":"darxriggs","id":16874,"node_id":"MDQ6VXNlcjE2ODc0","avatar_url":"https://avatars1.githubusercontent.com/u/16874?v=4","gravatar_id":"","url":"https://api.github.com/users/darxriggs","html_url":"https://github.com/darxriggs","followers_url":"https://api.github.com/users/darxriggs/followers","following_url":"https://api.github.com/users/darxriggs/following{/other_user}","gists_url":"https://api.github.com/users/darxriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/darxriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darxriggs/subscriptions","organizations_url":"https://api.github.com/users/darxriggs/orgs","repos_url":"https://api.github.com/users/darxriggs/repos","events_url":"https://api.github.com/users/darxriggs/events{/privacy}","received_events_url":"https://api.github.com/users/darxriggs/received_events","type":"User","site_admin":false},"repo":{"id":156621591,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY2MjE1OTE=","name":"logstash-plugin","full_name":"darxriggs/logstash-plugin","private":false,"owner":{"login":"darxriggs","id":16874,"node_id":"MDQ6VXNlcjE2ODc0","avatar_url":"https://avatars1.githubusercontent.com/u/16874?v=4","gravatar_id":"","url":"https://api.github.com/users/darxriggs","html_url":"https://github.com/darxriggs","followers_url":"https://api.github.com/users/darxriggs/followers","following_url":"https://api.github.com/users/darxriggs/following{/other_user}","gists_url":"https://api.github.com/users/darxriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/darxriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darxriggs/subscriptions","organizations_url":"https://api.github.com/users/darxriggs/orgs","repos_url":"https://api.github.com/users/darxriggs/repos","events_url":"https://api.github.com/users/darxriggs/events{/privacy}","received_events_url":"https://api.github.com/users/darxriggs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/darxriggs/logstash-plugin","description":"Jenkins plugin to ship the console log off to Logstash","fork":true,"url":"https://api.github.com/repos/darxriggs/logstash-plugin","forks_url":"https://api.github.com/repos/darxriggs/logstash-plugin/forks","keys_url":"https://api.github.com/repos/darxriggs/logstash-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darxriggs/logstash-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darxriggs/logstash-plugin/teams","hooks_url":"https://api.github.com/repos/darxriggs/logstash-plugin/hooks","issue_events_url":"https://api.github.com/repos/darxriggs/logstash-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/darxriggs/logstash-plugin/events","assignees_url":"https://api.github.com/repos/darxriggs/logstash-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/darxriggs/logstash-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/darxriggs/logstash-plugin/tags","blobs_url":"https://api.github.com/repos/darxriggs/logstash-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darxriggs/logstash-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darxriggs/logstash-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/darxriggs/logstash-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darxriggs/logstash-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/darxriggs/logstash-plugin/languages","stargazers_url":"https://api.github.com/repos/darxriggs/logstash-plugin/stargazers","contributors_url":"https://api.github.com/repos/darxriggs/logstash-plugin/contributors","subscribers_url":"https://api.github.com/repos/darxriggs/logstash-plugin/subscribers","subscription_url":"https://api.github.com/repos/darxriggs/logstash-plugin/subscription","commits_url":"https://api.github.com/repos/darxriggs/logstash-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/darxriggs/logstash-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/darxriggs/logstash-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/darxriggs/logstash-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/darxriggs/logstash-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/darxriggs/logstash-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darxriggs/logstash-plugin/merges","archive_url":"https://api.github.com/repos/darxriggs/logstash-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darxriggs/logstash-plugin/downloads","issues_url":"https://api.github.com/repos/darxriggs/logstash-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/darxriggs/logstash-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/darxriggs/logstash-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/darxriggs/logstash-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darxriggs/logstash-plugin/labels{/name}","releases_url":"https://api.github.com/repos/darxriggs/logstash-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/darxriggs/logstash-plugin/deployments","created_at":"2018-11-07T23:22:57Z","updated_at":"2018-11-08T19:25:58Z","pushed_at":"2018-11-11T20:43:32Z","git_url":"git://github.com/darxriggs/logstash-plugin.git","ssh_url":"git@github.com:darxriggs/logstash-plugin.git","clone_url":"https://github.com/darxriggs/logstash-plugin.git","svn_url":"https://github.com/darxriggs/logstash-plugin","homepage":null,"size":400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8323f19b785992ea117b5341d53bb039e932d8d3","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":7866898,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY2ODk4","name":"logstash-plugin","full_name":"jenkinsci/logstash-plugin","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/logstash-plugin","description":"Jenkins plugin to ship the console log off to Logstash","fork":true,"url":"https://api.github.com/repos/jenkinsci/logstash-plugin","forks_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/logstash-plugin/deployments","created_at":"2013-01-28T09:38:33Z","updated_at":"2018-11-22T10:10:22Z","pushed_at":"2018-11-22T10:10:18Z","git_url":"git://github.com/jenkinsci/logstash-plugin.git","ssh_url":"git@github.com:jenkinsci/logstash-plugin.git","clone_url":"https://github.com/jenkinsci/logstash-plugin.git","svn_url":"https://github.com/jenkinsci/logstash-plugin","homepage":null,"size":467,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":74,"open_issues":10,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82"},"html":{"href":"https://github.com/jenkinsci/logstash-plugin/pull/82"},"issue":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/82"},"comments":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/logstash-plugin/statuses/8cd518f9cd51aa94ce4865eada1b226a1fd20d69"}},"author_association":"NONE"}} | {
"id": 7866898,
"name": "jenkinsci/logstash-plugin",
"url": "https://api.github.com/repos/jenkinsci/logstash-plugin"
} | {
"id": 2794994,
"login": "jakub-bochenski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2794994?",
"url": "https://api.github.com/users/jakub-bochenski"
} | {
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
} | 2018-11-22T10:32:35 | 8632349770 | {"actor":{"display_login":"jakub-bochenski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/204584767","pull_request_review_id":139687828,"id":204584767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU4NDc2Nw==","diff_hunk":"@@ -669,133 +743,175 @@ class JacocoAgent implements CommandLineArgumentProvider {\n test.getJvmArgumentProviders().add(new JacocoAgent(extension))\n ----\n \n-For this to work, `api:org.gradle.testing.jacoco.plugins.JacocoTaskExtension[]` needs to have the correct input and output annotations.\n+For this to work, `link:{groovyDslPath}/org.gradle.testing.jacoco.plugins.JacocoTaskExtension.html[JacocoTaskExtension]` needs to have the correct input and output annotations.\n \n-The approach works for Test JVM arguments, since `api:org.gradle.api.tasks.testing.Test#getJvmArgumentProviders[]` is an `Iterable` annotated with `@api:org.gradle.api.tasks.Nested[]`.\n+The approach works for Test JVM arguments, since `link:{groovyDslPath}/org.gradle.api.tasks.testing.Test.html#org.gradle.api.tasks.testing.Test:jvmArgumentProviders[Test.getJvmArgumentProviders()]` is an `Iterable` annotated with `@link:{javadocPath}/org/gradle/api/tasks/Nested.html[Nested]`.\n \n There are other task types where this kind of nested inputs are available:\n \n-* `api:org.gradle.api.tasks.JavaExec#getArgumentProviders[]` - model e.g. custom tools\n-* `api:org.gradle.api.tasks.JavaExec#getJvmArgumentProviders[]` - used for Jacoco Java agent\n-* `api:org.gradle.api.tasks.compile.CompileOptions#getCompilerArgumentProviders[]` - model e.g annotation processors\n-* `api:org.gradle.api.tasks.Exec#getArgumentProviders[]` - model e.g custom tools\n+* link:{groovyDslPath}/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:argumentProviders[JavaExec.getArgumentProviders()] - model e.g. custom tools\n+* link:{groovyDslPath}/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:jvmArgumentProviders[JavaExec.getJvmArgumentProviders()] - used for Jacoco Java agent\n+* link:{groovyDslPath}/org.gradle.api.tasks.compile.CompileOptions.html#org.gradle.api.tasks.compile.CompileOptions:compilerArgumentProviders[CompileOptions.getCompilerArgumentProviders()] - model e.g annotation processors\n+* link:{groovyDslPath}/org.gradle.api.tasks.Exec.html#org.gradle.api.tasks.Exec:argumentProviders[Exec.getArgumentProviders()] - model e.g custom tools\n \n In the same way, this kind of modelling is available to custom tasks.\n \n [[sec:task_input_output_runtime_api]]\n-===== Runtime API\n+==== Runtime API\n \n Custom task classes are an easy way to bring your own build logic into the arena of incremental build, but you don’t always have that option. That's why Gradle also provides an alternative API that can be used with any tasks, which we look at next.\n \n When you don’t have access to the source for a custom task class, there is no way to add any of the annotations we covered in the previous section. Fortunately, Gradle provides a runtime API for scenarios just like that. It can also be used for ad-hoc tasks, as you'll see next.\n \n \n [[sec:runtime_api_for_adhoc]]\n-====== Using it for ad-hoc tasks\n+===== Using it for ad-hoc tasks\n \n This runtime API is provided through a couple of aptly named properties that are available on every Gradle task:\n \n-* api:org.gradle.api.Task#getInputs()[] of type api:org.gradle.api.tasks.TaskInputs[]\n-* api:org.gradle.api.Task#getOutputs()[] of type api:org.gradle.api.tasks.TaskOutputs[]\n-* api:org.gradle.api.Task#getDestroyables()[] of type api:org.gradle.api.tasks.TaskDestroyables[]\n+* link:{groovyDslPath}/org.gradle.api.Task.html#org.gradle.api.Task:inputs[Task.getInputs()] of type link:{javadocPath}/org/gradle/api/tasks/TaskInputs.html[TaskInputs]\n+* link:{groovyDslPath}/org.gradle.api.Task.html#org.gradle.api.Task:outputs[Task.getOutputs()] of type link:{javadocPath}/org/gradle/api/tasks/TaskOutputs.html[TaskOutputs]\n+* link:{groovyDslPath}/org.gradle.api.Task.html#org.gradle.api.Task:destroyables[Task.getDestroyables()] of type link:{javadocPath}/org/gradle/api/tasks/TaskDestroyables.html[TaskDestroyables]\n \n These objects have methods that allow you to specify files, directories and values which constitute the task’s inputs and outputs. In fact, the runtime API has almost feature parity with the annotations. All it lacks is validation of whether declared files are actually files and declared directories are directories. Nor will it create output directories if they don't exist. But that's it.\n \n Let’s take the template processing example from before and see how it would look as an ad-hoc task that uses the runtime API:\n \n-++++\n-<sample id=\"incrementalAdHocTask\" dir=\"userguide/tasks/incrementalBuild/customTaskClass\" title=\"Ad-hoc task\">\n- <sourcefile file=\"build.gradle\" snippet=\"ad-hoc-task\"/>\n- <output args=\"processTemplatesAdHoc\" ignoreExtraLines=\"true\" ignoreLineOrder=\"true\"/>\n- </sample>\n-++++\n+===== Example: Ad-hoc task\n+\n+[source.multi-language-sample,groovy]\n+.build.gradle\n+----\n+include::{samplesPath}/userguide/tasks/incrementalBuild/customTaskClass/build.gradle[tag=ad-hoc-task]\n+----\n+\n+.Output of **`gradle processTemplatesAdHoc`**\n+----\n+> gradle processTemplatesAdHoc\n+include::{samplesPath}/userguide/tasks/incrementalBuild/customTaskClass/incrementalAdHocTask.out[]\n+----\n \n As before, there’s much to talk about. To begin with, you should really write a custom task class for this as it’s a non-trivial implementation that has several configuration options. In this case, there are no task properties to store the root source folder, the location of the output directory or any of the other settings. That’s deliberate to highlight the fact that the runtime API doesn’t require the task to have any state. In terms of incremental build, the above ad-hoc task will behave the same as the custom task class.\n \n All the input and output definitions are done through the methods on `inputs` and `outputs`, such as `property()`, `files()`, and `dir()`. Gradle performs up-to-date checks on the argument values to determine whether the task needs to run again or not. Each method corresponds to one of the incremental build annotations, for example `inputs.property()` maps to `@Input` and `outputs.dir()` maps to `@OutputDirectory`. The only difference is that the `file()`, `files()`, `dir()` and `dirs()` methods don’t validate the type of file object at the given path (file or directory), unlike the annotations.\n \n The files that a task removes can be specified through `destroyables.register()`.\n \n-++++\n-<sample id=\"destroyableAdHocTask\" dir=\"userguide/tasks/incrementalBuild/customTaskClass\" title=\"Ad-hoc task declaring a destroyable\">\n- <sourcefile file=\"build.gradle\" snippet=\"adhoc-destroyable-task\"/>\n-</sample>\n-++++\n+===== Example: Ad-hoc task declaring a destroyable\n+\n+[source.multi-language-sample,groovy]\n+.build.gradle\n+----\n+include::{samplesPath}/userguide/tasks/incrementalBuild/customTaskClass/build.gradle[tag=adhoc-destroyable-task]\n+----\n \n One notable difference between the runtime API and the annotations is the lack of a method that corresponds directly to `@Nested`. That’s why the example uses two `property()` declarations for the template data, one for each `TemplateData` property. You should utilize the same technique when using the runtime API with nested values. Any given task can either declare destroyables or inputs/outputs, but cannot declare both.\n \n [[sec:runtime_api_for_custom_tasks]]\n-====== Using it for custom task types\n+===== Using it for custom task types\n \n Another type of example involves adding input and output definitions to instances of a custom task class that lacks the requisite annotations. For example, imagine that the `ProcessTemplates` task is provided by a plugin and that it’s missing the incremental build annotations. In order to make up for that deficiency, you can use the runtime API:\n \n-++++\n-<sample id=\"runtimeIncrementalApi\" dir=\"userguide/tasks/incrementalBuild/customTaskClass\" title=\"Using runtime API with custom task type\">\n- <sourcefile file=\"build.gradle\" snippet=\"custom-class-runtime-api\"/>\n- <output args=\"processTemplatesRuntime\" ignoreExtraLines=\"true\" ignoreLineOrder=\"true\"/>\n- <output args=\"processTemplatesRuntime\" ignoreExtraLines=\"true\" ignoreLineOrder=\"true\" outputFile=\"runtimeIncrementalApiUpToDate.out\"/>\n- </sample>\n-++++\n+===== Example: Using runtime API with custom task type\n+\n+[source.multi-language-sample,groovy]\n+.build.gradle\n+----\n+include::{samplesPath}/userguide/tasks/incrementalBuild/customTaskClass/build.gradle[tag=custom-class-runtime-api]\n+----\n+\n+.Output of`gradle processTemplatesRuntime`","path":"subprojects/docs/src/docs/userguide/more_about_tasks.adoc","position":1105,"original_position":1105,"commit_id":"60c6160cd17d98a7640df74160106ca8e02a2f3b","original_commit_id":"60c6160cd17d98a7640df74160106ca8e02a2f3b","user":{"login":"big-guy","id":5387972,"node_id":"MDQ6VXNlcjUzODc5NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5387972?v=4","gravatar_id":"","url":"https://api.github.com/users/big-guy","html_url":"https://github.com/big-guy","followers_url":"https://api.github.com/users/big-guy/followers","following_url":"https://api.github.com/users/big-guy/following{/other_user}","gists_url":"https://api.github.com/users/big-guy/gists{/gist_id}","starred_url":"https://api.github.com/users/big-guy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-guy/subscriptions","organizations_url":"https://api.github.com/users/big-guy/orgs","repos_url":"https://api.github.com/users/big-guy/repos","events_url":"https://api.github.com/users/big-guy/events{/privacy}","received_events_url":"https://api.github.com/users/big-guy/received_events","type":"User","site_admin":false},"body":"missing space after of","created_at":"2018-07-23T23:34:55Z","updated_at":"2018-07-23T23:48:35Z","html_url":"https://github.com/gradle/gradle/pull/6021#discussion_r204584767","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/6021","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/204584767"},"html":{"href":"https://github.com/gradle/gradle/pull/6021#discussion_r204584767"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6021"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/6021","id":202404694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDA0Njk0","html_url":"https://github.com/gradle/gradle/pull/6021","diff_url":"https://github.com/gradle/gradle/pull/6021.diff","patch_url":"https://github.com/gradle/gradle/pull/6021.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/6021","number":6021,"state":"open","locked":false,"title":"Convert user manual to asciidoctor syntax","user":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"body":"### Context\r\nThis is part #5837 split up. This PR converts all user manual chapters to asciidoctor syntax completely. Once this and #6006 are approved, this branch will be merged with the one in #6006 and then merged to master. \r\n\r\nI did the following for all user manual pages:\r\n\r\n - [x] Adjusted links to other manual pages, DSL docs, and Javadocs where necessary. Fixed a couple dozen broken links at least.\r\n - [x] Convert samples XML from docbook to asciidoctor syntax\r\n - [x] Converted wide tables to a more flexible list-based display\r\n\r\nMy compromise here instead of 95 PRs is to have 1 PR with 95 commits: 1 for every chapter, 1 do convert snippets to asciidoctor tag syntax, and 1 to remove 3 user manual chapters that should not exist anymore. \r\n\r\n### Instructions\r\n**You can now just use the _new_ and _nightly_ links below to compare.**\r\n\r\n * You can run `./gradlew :docs:userguide -x userguideSinglePage` to quickly generate HTML under `subprojects/docs/build/docs`. \r\n * Then run `cd subprojects/docs/build/docs && python -m SimpleHTTPServer 8000` or whatever you want to serve the user manual and give it a spin. \r\n * Open http://localhost:8000/userguide/userguide.html and compare with https://docs.gradle.org/nightly/userguide/userguide.html\r\n\r\n#### Splitting up the review work\r\nThe following is a list of all chapters and its corresponding commit(s). To split up the work and make this incremental, please add the rows of chapters you want under your name like Gary has below:\r\n\r\n#### Reviewed by @ghale\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| announce_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/announce_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/announce_plugin.html)) | Y | 8da7e909386adba9279027920d89c6f30003f5bf, f680a5f4c4f |\r\n| ant.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/ant.html) vs [nightly](https://docs.gradle.org/nightly/userguide/ant.html)) | Y | 0656f173373f88c49d5b41fad547ee022cd2210f, a347a0c9431 |\r\n| antlr_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/antlr_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/antlr_plugin.html)) | Y | 013b336173d0635622fc6e2952a4e1f5433a0097, c769bebdf17 |\r\n| checkstyle_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/checkstyle_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/checkstyle_plugin.html)) | Y | 63dda07a50d49436a317030e3a32efedc8454172 |\r\n| codenarc_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/codenarc_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/codenarc_plugin.html)) | Y | 7104d2052d688da8e44db089b44b83504f433474 |\r\n| software_model.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/software_model.html) vs [nightly](https://docs.gradle.org/nightly/userguide/software_model.html)) | C | 13a97776e49e307608d386a64e8a2a44844efb65 |\r\n| software_model_concepts.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/software_model_concepts.html) vs [nightly](https://docs.gradle.org/nightly/userguide/software_model_concepts.html)) | Y | a3e746e1788289df67b8734725406c6a837476f1 |\r\n| software_model_extend.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/software_model_extend.html) vs [nightly](https://docs.gradle.org/nightly/userguide/software_model_extend.html)) | Y | 9063c2956276e7977103db1b573d47d61902502c |\r\n\r\n#### Reviewed by @big-guy\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| application_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/application_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/application_plugin.html)) | Y | af4bbfaa7efffcd20c91af482a9ee37dfca0622d |\r\n| artifact_management.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/artifact_management.html) vs [nightly](https://docs.gradle.org/nightly/userguide/artifact_management.html)) | Y | d786d1492f38e0aa48a6d175a939e54f097fc85b, a694bd0faac |\r\n| authoring_maintainable_build_scripts.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/authoring_maintainable_build_scripts.html) vs [nightly](https://docs.gradle.org/nightly/userguide/authoring_maintainable_build_scripts.html)) | Y | f023a2ef4dcb766d78a1024745f859991ac5fa0c, 03c85b12657 |\r\n| base_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/base_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/base_plugin.html)) | Y | 38d88e71c9f9d98f63270a94e75105d7fb06e3eb, 8a36a902e54 |\r\n| build_announcements_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_announcements_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_announcements_plugin.html)) | Y | 5698323b96497576342ab5fa37ce8a18591a32c8 |\r\n| build_dashboard_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_dashboard_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_dashboard_plugin.html)) | Y | 5e04b0e4d2db7a953e90587aa480fa0dcc744d05 |\r\n| build_environment.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_environment.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_environment.html)) | Y | 2e8662e12ff32dd5aae8f46ae24f7cd25cc2aa15 |\r\n| inspecting_dependencies.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/inspecting_dependencies.html) vs [nightly](https://docs.gradle.org/nightly/userguide/inspecting_dependencies.html)) | Y | 5567cb5f83553a4c3c42d5df04a77af7a04479ca |\r\n| installation.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/installation.html) vs [nightly](https://docs.gradle.org/nightly/userguide/installation.html)) | Y | 01ca12229f7c25e539e3e0350fb272cae667bb7e |\r\n| more_about_tasks.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/more_about_tasks.html) vs [nightly](https://docs.gradle.org/nightly/userguide/more_about_tasks.html)) | C | 9e34e1ebc740fd851a502aa992957f3b52c95430, f6a544dc27a31700d8458220924e3eb4a57bc9bb |\r\n| organizing_gradle_projects.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/organizing_gradle_projects.html) vs [nightly](https://docs.gradle.org/nightly/userguide/organizing_gradle_projects.html)) | Y | 87fcb74ef61d1db0b60509ead33d4225e86a2c93 |\r\n\r\n#### Reviewed by @eskatos\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| custom_plugins.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/custom_plugins.html) vs [nightly](https://docs.gradle.org/nightly/userguide/custom_plugins.html)) | C | a1838ded56c1d359f9462a7738f5c099ac0d5c5d, b02060d75aab6f96fef1f17cbdefb197d56d4bca |\r\n| custom_tasks.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/custom_tasks.html) vs [nightly](https://docs.gradle.org/nightly/userguide/custom_tasks.html)) | Y | 6d7a170a48a396bd0251647ec77f934ada54c948 |\r\n| intro_multi_project_builds.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/intro_multi_project_builds.html) vs [nightly](https://docs.gradle.org/nightly/userguide/intro_multi_project_builds.html)) | C | 38f6b9d4837128dde4104ffa2ba3eacd2f0843bc, dc7b496fb8d4439fb1c3daaf41af9a16fc5249aa |\r\n| multi_project_builds.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/multi_project_builds.html) vs [nightly](https://docs.gradle.org/nightly/userguide/multi_project_builds.html)) | C | a970487406a31ec72169f205ddd8b0517a640493, b42cd6a9b2dbefbdad7976d973dee8549aae1ab2 |\r\n| tutorial_groovy_projects.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/tutorial_groovy_projects.html) vs [nightly](https://docs.gradle.org/nightly/userguide/tutorial_groovy_projects.html)) | N | 6cd667bd26425d95520330dc9ba36acb6fd07e3d |\r\n| tutorial_java_projects.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/tutorial_java_projects.html) vs [nightly](https://docs.gradle.org/nightly/userguide/tutorial_java_projects.html)) | N | 5468e1be249e91e76489af8b5966afde9227096c |\r\n| tutorial_using_tasks.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/tutorial_using_tasks.html) vs [nightly](https://docs.gradle.org/nightly/userguide/tutorial_using_tasks.html)) | N | 16792debb385658930a8a4593e77ed0f7def51fa #|\r\n\r\n#### Reviewed by @marcphilipp\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| dependency_cache.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/dependency_cache.html) vs [nightly](https://docs.gradle.org/nightly/userguide/dependency_cache.html)) | C | 284c105ae4356ed6678af7d3a628a00ddc1e82cf |\r\n| java_gradle_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/java_gradle_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/java_gradle_plugin.html)) | Y | ab73d0157f3f28cfd055d5fb5135949c53a00d37 |\r\n| publishing_ivy.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/publishing_ivy.html) vs [nightly](https://docs.gradle.org/nightly/userguide/publishing_ivy.html)) | Y | e4e29d7cd79438f5863917695126cda12b52e5b9 |\r\n| publishing_maven.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/publishing_maven.html) vs [nightly](https://docs.gradle.org/nightly/userguide/publishing_maven.html)) | C | 0a1c3832f416ef285b12942624d815a51f1388cc |\r\n| publishing_overview.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/publishing_overview.html) vs [nightly](https://docs.gradle.org/nightly/userguide/publishing_overview.html)) | C | ddd42f9d4266da82a5db42548f951e978d08886c |\r\n| signing_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/signing_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/signing_plugin.html)) | Y | abf0d5e2a1754a44e3c8a3acbdc6a1894590d8de |\r\n| introduction_dependency_management.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/introduction_dependency_management.html) vs [nightly](https://docs.gradle.org/nightly/userguide/introduction_dependency_management.html)) | N | f097cee198ceba6b6f2a13e8f95c96c58ec217d9 |\r\n| managing_transitive_dependencies.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/managing_transitive_dependencies.html) vs [nightly](https://docs.gradle.org/nightly/userguide/managing_transitive_dependencies.html)) | N | 98bf4ff8bd4ac9a9d79a7027acaa13916e2d8cf8 |\r\n| maven_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/maven_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/maven_plugin.html)) | N | a5b6bc35245d0b55f93f18aa03106bbe27a16e1f |\r\n\r\n#### Reviewed by @wolfs\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| build_cache.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_cache.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_cache.html)) | C | 734c5dcfe60c50e729420c360df1c08e7446efab, 929571136ec, cfa3a019de46d0732a62e79a155b417ef9c619fb |\r\n| build_init_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_init_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_init_plugin.html)) | C | 66281bd60f46b64bb4ed277536b84d012af2937f |\r\n| build_lifecycle.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/build_lifecycle.html) vs [nightly](https://docs.gradle.org/nightly/userguide/build_lifecycle.html)) | C (see [Crucible](https://code-review.gradle.org/cru/REVIEW-6592#CFR-145241)) | 287e60f09a260071fafe8d6cbfae6b21786bd086, 40f30e70184e4af9edf8b1771e4071e53c401af0 |\r\n| repository_types.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/repository_types.html) vs [nightly](https://docs.gradle.org/nightly/userguide/repository_types.html)) | N | f729ab4376bec0ee837f8123fcad326ebb2cd0d8 |\r\n| scala_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/scala_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/scala_plugin.html)) | N | 34bbdcf894182cb02a9fed9e66ed2c39dd249ffc |\r\n| standard_plugins.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/standard_plugins.html) vs [nightly](https://docs.gradle.org/nightly/userguide/standard_plugins.html)) | N | 3d90151f3a32c284326075b7b6805ee7fb31412c |\r\n\r\n#### Reviewed by Peter Ledbrook:\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| building_java_projects.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/building_java_projects.html) vs [nightly](https://docs.gradle.org/nightly/userguide/building_java_projects.html)) | N | e7a8a4951c1cf11632aff24b5a5f9795d45a658e |\r\n| command_line_interface.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/command_line_interface.html) vs [nightly](https://docs.gradle.org/nightly/userguide/command_line_interface.html)) | N | 5d8a67de3155cdc0eec98091dd60b7f8bcff8f8b |\r\n| working_with_files.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/working_with_files.html) vs [nightly](https://docs.gradle.org/nightly/userguide/working_with_files.html)) | C | f0faeeeb114b162b365e4eb6acd6cd42e956c46b |\r\n\r\n#### Reviewed by Bo:\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| java_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/java_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/java_plugin.html)) | N | 525c901b2481cbd5bfd015d11c5aba2d2f7f45b4 |\r\n| java_testing.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/java_testing.html) vs [nightly](https://docs.gradle.org/nightly/userguide/java_testing.html)) | N | 5bc5ff08a2d931df83a7984298d50f2dd91a5020 |\r\n| writing_build_scripts.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/writing_build_scripts.html) vs [nightly](https://docs.gradle.org/nightly/userguide/writing_build_scripts.html)) | C | a95fa2f099f3bf3ffba75d2d31bab3c411ee8ab4, 6d0cadbc8eee04a6bb1974893563c1d2788dbe1c |\r\n| working_with_files.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/working_with_files.html) vs [nightly](https://docs.gradle.org/nightly/userguide/working_with_files.html)) | C | f0faeeeb114b162b365e4eb6acd6cd42e956c46b |\r\n\r\n#### Reviewed by Daz:\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| composite_builds.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/composite_builds.html) vs [nightly](https://docs.gradle.org/nightly/userguide/composite_builds.html)) | Y | 8cd9d1a53004481206b57cf1381a33986fa24f73 |\r\n| customizing_dependency_resolution_behavior.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/customizing_dependency_resolution_behavior.html) vs [nightly](https://docs.gradle.org/nightly/userguide/customizing_dependency_resolution_behavior.html)) | Y | 19f824b1cbbf41a359abbbed592187760314b93d |\r\n| declaring_dependencies.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/declaring_dependencies.html) vs [nightly](https://docs.gradle.org/nightly/userguide/declaring_dependencies.html)) | Y | 87bffde8ca60ed0ddc0987461bedb1e46b3fa48e |\r\n| declaring_repositories.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/declaring_repositories.html) vs [nightly](https://docs.gradle.org/nightly/userguide/declaring_repositories.html)) | Y | 49791eaf230343516d4f4c7d6e0bf629d96b090d |\r\n| dependency_locking.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/dependency_locking.html) vs [nightly](https://docs.gradle.org/nightly/userguide/dependency_locking.html)) | Y | 6e2237f2b8d0084bb33650a9a77d0471e6a17b06 |\r\n| licenses.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/licenses.html) vs [nightly](https://docs.gradle.org/nightly/userguide/licenses.html)) | Y | 0af5369bbd59acbd01d90e25d0db95536e04af17 |\r\n| jetty_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/jetty_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/jetty_plugin.html)) | Y | 3a7bd3229b6fc48ef4f755cb02ab5a5c0f3b423c |\r\n| working_with_dependencies.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/working_with_dependencies.html) vs [nightly](https://docs.gradle.org/nightly/userguide/working_with_dependencies.html)) | Y | 45c075df1dfe93fc2217e76bdc97892f5ef655e8 |\r\n\r\n#### Reviewed by Donat\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| comparing_builds.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/comparing_builds.html) vs [nightly](https://docs.gradle.org/nightly/userguide/comparing_builds.html)) | N | 8cc5a52aefec495aba08469874e3a3939e3785fc |\r\n| dependency_management_for_java_projects.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/dependency_management_for_java_projects.html) vs [nightly](https://docs.gradle.org/nightly/userguide/dependency_management_for_java_projects.html)) | N | 50450e6ab9fc8dc4366139afe6c2a48f2115a3b7 |\r\n| dependency_management_terminology.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/dependency_management_terminology.html) vs [nightly](https://docs.gradle.org/nightly/userguide/dependency_management_terminology.html)) | N | 9cb47f2df2b3d4378a88355dab7062a011fe6927 |\r\n| dependency_types.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/dependency_types.html) vs [nightly](https://docs.gradle.org/nightly/userguide/dependency_types.html)) | N | 330f058aa208cf0bbb3a58540e346f4e1671e114 |\r\n| distribution_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/distribution_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/distribution_plugin.html)) | N | 8c0295e49d99ab3484ee044d269948f3020f5f38 |\r\n| ear_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/ear_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/ear_plugin.html)) | N | 12060e23e72213edcf508e608b9676d3f2bfaff8 |\r\n| eclipse_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/eclipse_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/eclipse_plugin.html)) | N | e17c67a79fc7e36902ede8d9209ce0a3ddf284f1 |\r\n| idea_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/idea_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/idea_plugin.html)) | N | 67431ebd49c40b2de09e202224d9bbb5bb73050e |\r\n| jdepend_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/jdepend_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/jdepend_plugin.html)) | N | abc1dc1a97930607d10641bead7473cdb9eca049 |\r\n\r\n#### Reviewed by Lorant\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| jacoco_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/jacoco_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/jacoco_plugin.html)) | N | 5c04266b96f03642ecf477d80ed600c72645014a |\r\n| java_library_distribution_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/java_library_distribution_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/java_library_distribution_plugin.html)) | N | 9624d4429b9cd8997678244caab41a6a4e2b55cb |\r\n| java_library_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/java_library_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/java_library_plugin.html)) | N | 141a2f380baaa3e7e3228d73bffb4fe40d3ed71b |\r\n| logging.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/logging.html) vs [nightly](https://docs.gradle.org/nightly/userguide/logging.html)) | N | 9d94e802cab39766889f8d224b1dfee26bc637e5 |\r\n| managing_dependency_configurations.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/managing_dependency_configurations.html) vs [nightly](https://docs.gradle.org/nightly/userguide/managing_dependency_configurations.html)) | N | a135de4cb8f54c75159bf6de22f811b164311199 |\r\n| pmd_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/pmd_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/pmd_plugin.html)) | N | 8970d99f9939220b1479cbef9e7cdb4aeaefebd5 |\r\n| potential_traps.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/potential_traps.html) vs [nightly](https://docs.gradle.org/nightly/userguide/potential_traps.html)) | N | 99dd3b30db1139f69033399bfc6942f2f1bc224a |\r\n| project_report_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/project_report_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/project_report_plugin.html)) | N | df4c7b5d6c79fa9d14c919839c90484c10ae4183 |\r\n\r\n#### Reviewed by Stefan Oehme\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| gradle_daemon.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/gradle_daemon.html) vs [nightly](https://docs.gradle.org/nightly/userguide/gradle_daemon.html)) | N | 2a70666a153467b903878cb46f6fe3a11c0ad755 |\r\n| gradle_wrapper.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/gradle_wrapper.html) vs [nightly](https://docs.gradle.org/nightly/userguide/gradle_wrapper.html)) | N | 26eea6d1fd0bb06e02868160b42e573e651bec85 |\r\n| init_scripts.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/init_scripts.html) vs [nightly](https://docs.gradle.org/nightly/userguide/init_scripts.html)) | N | 88d697e739e36de2ba384bad4af93f81451f372f, 2344c103e6d679186966844d7635d497e4ba1ddf |\r\n| osgi_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/osgi_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/osgi_plugin.html)) | N | b9e50ab17a610c624cace5a75862ee00ad424c9f |\r\n| overview.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/overview.html) vs [nightly](https://docs.gradle.org/nightly/userguide/overview.html)) | N | 2a717fdc581147cd762a7120947b0a6adfa62b53 |\r\n| plugins.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/plugins.html) vs [nightly](https://docs.gradle.org/nightly/userguide/plugins.html)) | N | 6dc03436b15df3a2d86d534349fa68c5f68d8b1e, 9d5d4efedcb1cff06a7c2818d215a3570e70a798 |\r\n\r\n#### Reviewed by Daniel\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| findbugs_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/findbugs_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/findbugs_plugin.html)) | N | 6091cefcd57b2c4374eae8d2d4fbbe27dbd38796 |\r\n| lazy_configuration.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/lazy_configuration.html) vs [nightly](https://docs.gradle.org/nightly/userguide/lazy_configuration.html)) | N | c4c3d0891ebae9c23a087ad6a001a7119a069899 |\r\n| native_software.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/native_software.html) vs [nightly](https://docs.gradle.org/nightly/userguide/native_software.html)) | N | d3ad29093c7902fcc5508e788c933b3243cb52a3 |\r\n| play_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/play_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/play_plugin.html)) | N | f422b27758b8319766532df71ec99bbba73ca03f |\r\n| rule_source.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/rule_source.html) vs [nightly](https://docs.gradle.org/nightly/userguide/rule_source.html)) | N | e9123fd02474c7e96ce2d5d05d799ae8cf0009e0 |\r\n| task_configuration_avoidance.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/task_configuration_avoidance.html) vs [nightly](https://docs.gradle.org/nightly/userguide/task_configuration_avoidance.html)) | N | bb8e79523bfc517cf18398bdfb82b00609e440af |\r\n\r\n#### Reviewed by Adam\r\n\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| embedding.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/embedding.html) vs [nightly](https://docs.gradle.org/nightly/userguide/embedding.html)) | N | f0a6deaa04635b4cba1f4087ec5e3dc18b1eb22d |\r\n| feature_lifecycle.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/feature_lifecycle.html) vs [nightly](https://docs.gradle.org/nightly/userguide/feature_lifecycle.html)) | N | 8f1c09d0af89f9b4b9fe85d847410086281e98a6 |\r\n| test_kit.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/test_kit.html) vs [nightly](https://docs.gradle.org/nightly/userguide/test_kit.html)) | N | a4f9d3926c8ceca4f257aa8fa382a11f12e8eda2 |\r\n| troubleshooting.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/troubleshooting.html) vs [nightly](https://docs.gradle.org/nightly/userguide/troubleshooting.html)) | N | 62fb0f58a69be9f94d0de95668502753125f538a |\r\n| troubleshooting_dependency_resolution.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/troubleshooting_dependency_resolution.html) vs [nightly](https://docs.gradle.org/nightly/userguide/troubleshooting_dependency_resolution.html)) | N | 675294db8c0539e21013d28bdd5a9e45dba570c4 |\r\n\r\n#### Reviewed by Rodrigo\r\n| File | Done | Commit(s) |\r\n| --- | --- | --- |\r\n| getting-started.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/started.html) vs [nightly](https://docs.gradle.org/nightly/userguide/started.html)) | N | 791680c830cde93708e89aa1660dc8f0c418bf62 |\r\n| groovy_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/groovy_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/groovy_plugin.html)) | N | 43cb6fa23b767b1615b9060c0b71b63c4530d65b |\r\n| userguide.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/userguide.html) vs [nightly](https://docs.gradle.org/nightly/userguide/userguide.html)) | N | ec31973af72608ef4527d9d6e2f37d047969ff9b |\r\n| war_plugin.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/war_plugin.html) vs [nightly](https://docs.gradle.org/nightly/userguide/war_plugin.html)) | N | dbeb6510777018b2fb6c5f57c5ced845ffc1cbe2 |\r\n| Removed console.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/console.html) vs [nightly](https://docs.gradle.org/nightly/userguide/console.html)), introduction.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/introduction.html) vs [nightly](https://docs.gradle.org/nightly/userguide/introduction.html)), and web_project_tutorial.adoc ([new](https://builds.gradle.org/repository/download/Gradle_Check_BuildDistributions/14431772:id/distributions/gradle-4.10-all.zip%21/gradle-4.10-20180723200302%2B0200/docs/userguide/web_project_tutorial.html) vs [nightly](https://docs.gradle.org/nightly/userguide/web_project_tutorial.html)) | N | b29c3c20fb80bfed6af799fb7b2d293f593ec85d |\r\n| docs/samples/* | N | cab5bb898e574b32d15542fdc884e3116285c29f |\r\n\r\n","created_at":"2018-07-18T23:11:47Z","updated_at":"2018-07-23T23:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60b14dfa54e1e6ca5fd4efa67c83ac85150be2ab","assignee":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"assignees":[{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":289469033,"node_id":"MDU6TGFiZWwyODk0NjkwMzM=","url":"https://api.github.com/repos/gradle/gradle/labels/from:member","name":"from:member","color":"0052cc","default":false},{"id":290482145,"node_id":"MDU6TGFiZWwyOTA0ODIxNDU=","url":"https://api.github.com/repos/gradle/gradle/labels/in:docs","name":"in:docs","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/73","html_url":"https://github.com/gradle/gradle/milestone/73","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/73/labels","id":3382823,"node_id":"MDk6TWlsZXN0b25lMzM4MjgyMw==","number":73,"title":"4.10 RC1","description":"","creator":{"login":"oehme","id":1191797,"node_id":"MDQ6VXNlcjExOTE3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1191797?v=4","gravatar_id":"","url":"https://api.github.com/users/oehme","html_url":"https://github.com/oehme","followers_url":"https://api.github.com/users/oehme/followers","following_url":"https://api.github.com/users/oehme/following{/other_user}","gists_url":"https://api.github.com/users/oehme/gists{/gist_id}","starred_url":"https://api.github.com/users/oehme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oehme/subscriptions","organizations_url":"https://api.github.com/users/oehme/orgs","repos_url":"https://api.github.com/users/oehme/repos","events_url":"https://api.github.com/users/oehme/events{/privacy}","received_events_url":"https://api.github.com/users/oehme/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":91,"state":"open","created_at":"2018-05-29T07:35:56Z","updated_at":"2018-07-23T21:32:49Z","due_on":"2018-08-06T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/6021/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/6021/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/6021/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/60c6160cd17d98a7640df74160106ca8e02a2f3b","head":{"label":"gradle:eriwen/docs/manual-asciidoc-content","ref":"eriwen/docs/manual-asciidoc-content","sha":"60c6160cd17d98a7640df74160106ca8e02a2f3b","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-07-23T21:33:05Z","pushed_at":"2018-07-23T22:07:00Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":221143,"stargazers_count":7166,"watchers_count":7166,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2238,"mirror_url":null,"archived":false,"open_issues_count":1174,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2238,"open_issues":1174,"watchers":7166,"default_branch":"master"}},"base":{"label":"gradle:eriwen/docs/asciidoc-pdf-and-single-page-manual","ref":"eriwen/docs/asciidoc-pdf-and-single-page-manual","sha":"9b1ecf965946c0f15ca88aa2e6ed28a0b795da2e","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-07-23T21:33:05Z","pushed_at":"2018-07-23T22:07:00Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":221143,"stargazers_count":7166,"watchers_count":7166,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2238,"mirror_url":null,"archived":false,"open_issues_count":1174,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2238,"open_issues":1174,"watchers":7166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6021"},"html":{"href":"https://github.com/gradle/gradle/pull/6021"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/6021"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/6021/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6021/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6021/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/60c6160cd17d98a7640df74160106ca8e02a2f3b"}},"author_association":"MEMBER"}} | {
"id": 302322,
"name": "gradle/gradle",
"url": "https://api.github.com/repos/gradle/gradle"
} | {
"id": 5387972,
"login": "big-guy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5387972?",
"url": "https://api.github.com/users/big-guy"
} | {
"id": 124156,
"login": "gradle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/124156?",
"url": "https://api.github.com/orgs/gradle"
} | 2018-07-23T23:34:55 | 8007020452 | {"actor":{"display_login":"big-guy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/castleproject/Windsor/pulls/comments/193066893","pull_request_review_id":125962865,"id":193066893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA2Njg5Mw==","diff_hunk":"@@ -55,38 +55,38 @@ public void Closed_generic_simple_type()\n \t\t}\n \n \t\t[Test]\n-\t\tpublic void Generic_nested_generic_typeArray_multi_dimentional_pulls_closed_generics_to_innermost_type()\n+\t\tpublic void Generic_nested_generic_typeArray_multi_dimensional()\n \t\t{\n \t\t\tvar name = typeof(GenericHasNested<A2>.NestedGeneric<AProp>[,,]).ToCSharpString();\n-\t\t\tAssert.AreEqual(\"GenericHasNested<�TOuter�>.NestedGeneric<A2, AProp>[,,]\", name);\n+\t\t\tAssert.AreEqual(\"GenericHasNested<A2>.NestedGeneric<AProp>[,,]\", name);\n \t\t}\n \n \t\t[Test]\n-\t\tpublic void Generic_nested_generic_typeArray_pulls_closed_generics_to_innermost_type()\n+\t\tpublic void Generic_nested_generic_typeArray()\n \t\t{\n \t\t\tvar name = typeof(GenericHasNested<A2>.NestedGeneric<AProp>[]).ToCSharpString();\n-\t\t\tAssert.AreEqual(\"GenericHasNested<�TOuter�>.NestedGeneric<A2, AProp>[]\", name);\n+\t\t\tAssert.AreEqual(\"GenericHasNested<A2>.NestedGeneric<AProp>[]\", name);\n \t\t}\n \n \t\t[Test]\n-\t\tpublic void Generic_nested_generic_type_pulls_closed_generics_to_innermost_type()\n+\t\tpublic void Generic_nested_generic_type()\n \t\t{\n \t\t\tvar name = typeof(GenericHasNested<A2>.NestedGeneric<AProp>).ToCSharpString();\n-\t\t\tAssert.AreEqual(\"GenericHasNested<�TOuter�>.NestedGeneric<A2, AProp>\", name);\n+\t\t\tAssert.AreEqual(\"GenericHasNested<A2>.NestedGeneric<AProp>\", name);\n \t\t}\n \n \t\t[Test]\n-\t\tpublic void Generic_nested_type_array_ignores_outer_generic_argument()\n+\t\tpublic void Generic_nested_type_array()\n \t\t{\n \t\t\tvar name = typeof(GenericHasNested<A2>.Nested[]).ToCSharpString();\n-\t\t\tAssert.AreEqual(\"GenericHasNested<�TOuter�>.Nested<A2>[]\", name);\n+\t\t\tAssert.AreEqual(\"GenericHasNested<A2>.Nested[]\", name);\n \t\t}\n \n \t\t[Test]\n-\t\tpublic void Generic_nested_type_ignores_outer_generic_argument()\n+\t\tpublic void Generic_nested_type()\n \t\t{\n \t\t\tvar name = typeof(GenericHasNested<A2>.Nested).ToCSharpString();\n-\t\t\tAssert.AreEqual(\"GenericHasNested<�TOuter�>.Nested<A2>\", name);\n+\t\t\tAssert.AreEqual(\"GenericHasNested<A2>.Nested\", name);","path":"src/Castle.Windsor.Tests/TypeUtilTestCase.cs","position":null,"original_position":45,"commit_id":"e3c4ab767095a7034557db71019c9863220429a5","original_commit_id":"e3c4ab767095a7034557db71019c9863220429a5","user":{"login":"fir3pho3nixx","id":607402,"node_id":"MDQ6VXNlcjYwNzQwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/607402?v=4","gravatar_id":"","url":"https://api.github.com/users/fir3pho3nixx","html_url":"https://github.com/fir3pho3nixx","followers_url":"https://api.github.com/users/fir3pho3nixx/followers","following_url":"https://api.github.com/users/fir3pho3nixx/following{/other_user}","gists_url":"https://api.github.com/users/fir3pho3nixx/gists{/gist_id}","starred_url":"https://api.github.com/users/fir3pho3nixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fir3pho3nixx/subscriptions","organizations_url":"https://api.github.com/users/fir3pho3nixx/orgs","repos_url":"https://api.github.com/users/fir3pho3nixx/repos","events_url":"https://api.github.com/users/fir3pho3nixx/events{/privacy}","received_events_url":"https://api.github.com/users/fir3pho3nixx/received_events","type":"User","site_admin":false},"body":"Should we add a test that nests generic arguments? \r\n\r\n```csharp\r\nvar name = typeof(GenericHasNested<A2>.GenericNested<Tuple<int, bool>>).ToCSharpString();\r\nAssert.AreEqual(\"GenericHasNested<A2>.GenericNested<Tuple<int, bool>>\", name);\r\n```","created_at":"2018-06-05T13:16:26Z","updated_at":"2018-06-05T13:16:27Z","html_url":"https://github.com/castleproject/Windsor/pull/407#discussion_r193066893","pull_request_url":"https://api.github.com/repos/castleproject/Windsor/pulls/407","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/comments/193066893"},"html":{"href":"https://github.com/castleproject/Windsor/pull/407#discussion_r193066893"},"pull_request":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/castleproject/Windsor/pulls/407","id":192640881,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjQwODgx","html_url":"https://github.com/castleproject/Windsor/pull/407","diff_url":"https://github.com/castleproject/Windsor/pull/407.diff","patch_url":"https://github.com/castleproject/Windsor/pull/407.patch","issue_url":"https://api.github.com/repos/castleproject/Windsor/issues/407","number":407,"state":"open","locked":false,"title":"Make Typeutil.ToCSharpString produce more C#-like formatting","user":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"body":"This changes the way how `TypeUtil.ToCSharpString` formats certain types to a representation that looks more like C#:\r\n\r\n* **Generic type parameters.** Those are currently surrounded with a centered dot (`·`) that noone quite seems to know what they're good for. <sup>(†)</sup> (See #406, esp. the recommendation made in https://github.com/castleproject/Windsor/pull/406#issuecomment-394178922.)\r\n\r\n* **Nested generic types.** For example, given `Outer<bool>.Inner<char>`, it outputs `\"Outer<·T·>.Inner<bool, char>\"` which is likely to be confusing rather than helpful. This changes the way how such types get formatted to something more familiar to C# users: `\"Outer<bool>.Inner<char>\"`. (This resolves #404.)\r\n\r\nThese changes are classified in the changelog as an \"enhancement\". Given that there were explicit unit tests about that behavior, it's not really a bugfix, but a change. Classifying as a \"breaking change\" would be accurate, but given that the method's intended use case is for diagnostics, it seems somewhat over-the-top to mark it as \"breaking\".\r\n\r\n<sup>(†)</sup> My personal theory about the centered dots is that they were needed to mark a placeholder, so you'd know how to apply, or \"distribute\", the generic type arguments from the innermost type over the outer types. Now that this distribution is done automatically, the dots aren't really needed anymore.","created_at":"2018-06-05T09:19:11Z","updated_at":"2018-06-05T13:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e116ddd2110fb91643f70f22f8d0b25976e04d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/castleproject/Windsor/pulls/407/commits","review_comments_url":"https://api.github.com/repos/castleproject/Windsor/pulls/407/comments","review_comment_url":"https://api.github.com/repos/castleproject/Windsor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/castleproject/Windsor/issues/407/comments","statuses_url":"https://api.github.com/repos/castleproject/Windsor/statuses/e3c4ab767095a7034557db71019c9863220429a5","head":{"label":"stakx:typeutil-tocsharpstring","ref":"typeutil-tocsharpstring","sha":"e3c4ab767095a7034557db71019c9863220429a5","user":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"repo":{"id":136139275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxMzkyNzU=","name":"Windsor","full_name":"stakx/Windsor","owner":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stakx/Windsor","description":"Castle Windsor is a best of breed, mature Inversion of Control container available for .NET","fork":true,"url":"https://api.github.com/repos/stakx/Windsor","forks_url":"https://api.github.com/repos/stakx/Windsor/forks","keys_url":"https://api.github.com/repos/stakx/Windsor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stakx/Windsor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stakx/Windsor/teams","hooks_url":"https://api.github.com/repos/stakx/Windsor/hooks","issue_events_url":"https://api.github.com/repos/stakx/Windsor/issues/events{/number}","events_url":"https://api.github.com/repos/stakx/Windsor/events","assignees_url":"https://api.github.com/repos/stakx/Windsor/assignees{/user}","branches_url":"https://api.github.com/repos/stakx/Windsor/branches{/branch}","tags_url":"https://api.github.com/repos/stakx/Windsor/tags","blobs_url":"https://api.github.com/repos/stakx/Windsor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stakx/Windsor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stakx/Windsor/git/refs{/sha}","trees_url":"https://api.github.com/repos/stakx/Windsor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stakx/Windsor/statuses/{sha}","languages_url":"https://api.github.com/repos/stakx/Windsor/languages","stargazers_url":"https://api.github.com/repos/stakx/Windsor/stargazers","contributors_url":"https://api.github.com/repos/stakx/Windsor/contributors","subscribers_url":"https://api.github.com/repos/stakx/Windsor/subscribers","subscription_url":"https://api.github.com/repos/stakx/Windsor/subscription","commits_url":"https://api.github.com/repos/stakx/Windsor/commits{/sha}","git_commits_url":"https://api.github.com/repos/stakx/Windsor/git/commits{/sha}","comments_url":"https://api.github.com/repos/stakx/Windsor/comments{/number}","issue_comment_url":"https://api.github.com/repos/stakx/Windsor/issues/comments{/number}","contents_url":"https://api.github.com/repos/stakx/Windsor/contents/{+path}","compare_url":"https://api.github.com/repos/stakx/Windsor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stakx/Windsor/merges","archive_url":"https://api.github.com/repos/stakx/Windsor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stakx/Windsor/downloads","issues_url":"https://api.github.com/repos/stakx/Windsor/issues{/number}","pulls_url":"https://api.github.com/repos/stakx/Windsor/pulls{/number}","milestones_url":"https://api.github.com/repos/stakx/Windsor/milestones{/number}","notifications_url":"https://api.github.com/repos/stakx/Windsor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stakx/Windsor/labels{/name}","releases_url":"https://api.github.com/repos/stakx/Windsor/releases{/id}","deployments_url":"https://api.github.com/repos/stakx/Windsor/deployments","created_at":"2018-06-05T07:42:07Z","updated_at":"2018-06-05T07:42:13Z","pushed_at":"2018-06-05T11:08:35Z","git_url":"git://github.com/stakx/Windsor.git","ssh_url":"git@github.com:stakx/Windsor.git","clone_url":"https://github.com/stakx/Windsor.git","svn_url":"https://github.com/stakx/Windsor","homepage":"http://www.castleproject.org/","size":103524,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"castleproject:master","ref":"master","sha":"a9d6ad8c7ad8d343d2017c97a67d6e1c2fb36c39","user":{"login":"castleproject","id":124839,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDgzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/124839?v=4","gravatar_id":"","url":"https://api.github.com/users/castleproject","html_url":"https://github.com/castleproject","followers_url":"https://api.github.com/users/castleproject/followers","following_url":"https://api.github.com/users/castleproject/following{/other_user}","gists_url":"https://api.github.com/users/castleproject/gists{/gist_id}","starred_url":"https://api.github.com/users/castleproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castleproject/subscriptions","organizations_url":"https://api.github.com/users/castleproject/orgs","repos_url":"https://api.github.com/users/castleproject/repos","events_url":"https://api.github.com/users/castleproject/events{/privacy}","received_events_url":"https://api.github.com/users/castleproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2629717,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NzE3","name":"Windsor","full_name":"castleproject/Windsor","owner":{"login":"castleproject","id":124839,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDgzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/124839?v=4","gravatar_id":"","url":"https://api.github.com/users/castleproject","html_url":"https://github.com/castleproject","followers_url":"https://api.github.com/users/castleproject/followers","following_url":"https://api.github.com/users/castleproject/following{/other_user}","gists_url":"https://api.github.com/users/castleproject/gists{/gist_id}","starred_url":"https://api.github.com/users/castleproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castleproject/subscriptions","organizations_url":"https://api.github.com/users/castleproject/orgs","repos_url":"https://api.github.com/users/castleproject/repos","events_url":"https://api.github.com/users/castleproject/events{/privacy}","received_events_url":"https://api.github.com/users/castleproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/castleproject/Windsor","description":"Castle Windsor is a best of breed, mature Inversion of Control container available for .NET","fork":false,"url":"https://api.github.com/repos/castleproject/Windsor","forks_url":"https://api.github.com/repos/castleproject/Windsor/forks","keys_url":"https://api.github.com/repos/castleproject/Windsor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castleproject/Windsor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castleproject/Windsor/teams","hooks_url":"https://api.github.com/repos/castleproject/Windsor/hooks","issue_events_url":"https://api.github.com/repos/castleproject/Windsor/issues/events{/number}","events_url":"https://api.github.com/repos/castleproject/Windsor/events","assignees_url":"https://api.github.com/repos/castleproject/Windsor/assignees{/user}","branches_url":"https://api.github.com/repos/castleproject/Windsor/branches{/branch}","tags_url":"https://api.github.com/repos/castleproject/Windsor/tags","blobs_url":"https://api.github.com/repos/castleproject/Windsor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castleproject/Windsor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castleproject/Windsor/git/refs{/sha}","trees_url":"https://api.github.com/repos/castleproject/Windsor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castleproject/Windsor/statuses/{sha}","languages_url":"https://api.github.com/repos/castleproject/Windsor/languages","stargazers_url":"https://api.github.com/repos/castleproject/Windsor/stargazers","contributors_url":"https://api.github.com/repos/castleproject/Windsor/contributors","subscribers_url":"https://api.github.com/repos/castleproject/Windsor/subscribers","subscription_url":"https://api.github.com/repos/castleproject/Windsor/subscription","commits_url":"https://api.github.com/repos/castleproject/Windsor/commits{/sha}","git_commits_url":"https://api.github.com/repos/castleproject/Windsor/git/commits{/sha}","comments_url":"https://api.github.com/repos/castleproject/Windsor/comments{/number}","issue_comment_url":"https://api.github.com/repos/castleproject/Windsor/issues/comments{/number}","contents_url":"https://api.github.com/repos/castleproject/Windsor/contents/{+path}","compare_url":"https://api.github.com/repos/castleproject/Windsor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castleproject/Windsor/merges","archive_url":"https://api.github.com/repos/castleproject/Windsor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castleproject/Windsor/downloads","issues_url":"https://api.github.com/repos/castleproject/Windsor/issues{/number}","pulls_url":"https://api.github.com/repos/castleproject/Windsor/pulls{/number}","milestones_url":"https://api.github.com/repos/castleproject/Windsor/milestones{/number}","notifications_url":"https://api.github.com/repos/castleproject/Windsor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castleproject/Windsor/labels{/name}","releases_url":"https://api.github.com/repos/castleproject/Windsor/releases{/id}","deployments_url":"https://api.github.com/repos/castleproject/Windsor/deployments","created_at":"2011-10-23T07:01:06Z","updated_at":"2018-06-05T06:13:27Z","pushed_at":"2018-06-05T11:08:37Z","git_url":"git://github.com/castleproject/Windsor.git","ssh_url":"git@github.com:castleproject/Windsor.git","clone_url":"https://github.com/castleproject/Windsor.git","svn_url":"https://github.com/castleproject/Windsor","homepage":"http://www.castleproject.org/","size":103482,"stargazers_count":882,"watchers_count":882,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":368,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":368,"open_issues":38,"watchers":882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/407"},"html":{"href":"https://github.com/castleproject/Windsor/pull/407"},"issue":{"href":"https://api.github.com/repos/castleproject/Windsor/issues/407"},"comments":{"href":"https://api.github.com/repos/castleproject/Windsor/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/castleproject/Windsor/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/castleproject/Windsor/statuses/e3c4ab767095a7034557db71019c9863220429a5"}},"author_association":"MEMBER"}} | {
"id": 2629717,
"name": "castleproject/Windsor",
"url": "https://api.github.com/repos/castleproject/Windsor"
} | {
"id": 607402,
"login": "fir3pho3nixx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/607402?",
"url": "https://api.github.com/users/fir3pho3nixx"
} | {
"id": 124839,
"login": "castleproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/124839?",
"url": "https://api.github.com/orgs/castleproject"
} | 2018-06-05T13:16:26 | 7778083520 | {"actor":{"display_login":"fir3pho3nixx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/174095419","pull_request_review_id":103388621,"id":174095419,"diff_hunk":"@@ -265,6 +265,49 @@ def self.setup\n @@configured = true\n yield self\n end\n+\n+ # Includes a component to be used by Simple Form. Methods defined in a\n+ # component will be exposed to be used in the wrapper as Simple::Components\n+ #\n+ # Examples\n+ #\n+ # # The application needs to tell where the components will be.\n+ # Dir[Rails.root.join('config/initializers/simple_form_components/**/*.rb')].each { |f| require f }","path":"lib/simple_form.rb","position":11,"original_position":11,"commit_id":"e6f339b5c10d0c310151d9103d0d5fe343f3533f","original_commit_id":"66b26193d5b7785106b15c178a30f3583a930ab2","user":{"login":"feliperenan","id":27698968,"avatar_url":"https://avatars2.githubusercontent.com/u/27698968?v=4","gravatar_id":"","url":"https://api.github.com/users/feliperenan","html_url":"https://github.com/feliperenan","followers_url":"https://api.github.com/users/feliperenan/followers","following_url":"https://api.github.com/users/feliperenan/following{/other_user}","gists_url":"https://api.github.com/users/feliperenan/gists{/gist_id}","starred_url":"https://api.github.com/users/feliperenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feliperenan/subscriptions","organizations_url":"https://api.github.com/users/feliperenan/orgs","repos_url":"https://api.github.com/users/feliperenan/repos","events_url":"https://api.github.com/users/feliperenan/events{/privacy}","received_events_url":"https://api.github.com/users/feliperenan/received_events","type":"User","site_admin":false},"body":"Ahh I got it now. We already recommend adding custom inputs inside `app/inputs` 😅. This way, I think it makes sense. 👍 ","created_at":"2018-03-13T11:27:20Z","updated_at":"2018-03-13T11:27:20Z","html_url":"https://github.com/plataformatec/simple_form/pull/1556#discussion_r174095419","pull_request_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/174095419"},"html":{"href":"https://github.com/plataformatec/simple_form/pull/1556#discussion_r174095419"},"pull_request":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556"}},"in_reply_to_id":173803276},"pull_request":{"url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556","id":173899570,"html_url":"https://github.com/plataformatec/simple_form/pull/1556","diff_url":"https://github.com/plataformatec/simple_form/pull/1556.diff","patch_url":"https://github.com/plataformatec/simple_form/pull/1556.patch","issue_url":"https://api.github.com/repos/plataformatec/simple_form/issues/1556","number":1556,"state":"open","locked":false,"title":"Add API to register custom components","user":{"login":"feliperenan","id":27698968,"avatar_url":"https://avatars2.githubusercontent.com/u/27698968?v=4","gravatar_id":"","url":"https://api.github.com/users/feliperenan","html_url":"https://github.com/feliperenan","followers_url":"https://api.github.com/users/feliperenan/followers","following_url":"https://api.github.com/users/feliperenan/following{/other_user}","gists_url":"https://api.github.com/users/feliperenan/gists{/gist_id}","starred_url":"https://api.github.com/users/feliperenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feliperenan/subscriptions","organizations_url":"https://api.github.com/users/feliperenan/orgs","repos_url":"https://api.github.com/users/feliperenan/repos","events_url":"https://api.github.com/users/feliperenan/events{/privacy}","received_events_url":"https://api.github.com/users/feliperenan/received_events","type":"User","site_admin":false},"body":"Related to https://github.com/plataformatec/simple_form/issues/1176 and more discussion about it in https://github.com/plataformatec/simple_form/pull/1554\r\n\r\nThis is a public API to allow users register custom components without monkey patching Simple Form.\r\n\r\n### Examples\r\n\r\n- Create your custom component.\r\n```ruby\r\n# config/initializers/simple_form_components/input_group.rb\r\nmodule InputGroup\r\n def preprend\r\n ...\r\n end\r\n\r\n def append\r\n ...\r\n end\r\nend\r\n\r\n# Register the component in Simple Form.\r\nSimpleForm.include_component(InputGroup)\r\n```\r\n\r\n- Tells to Simple Form the place that the components will be\r\n```ruby\r\n# app/config/initializers/simple_form.rb\r\nDir[Rails.root.join('config/initializers/simple_form_components/**/*.rb')].each { |f| require f }\r\n```\r\n\r\n- Use the custom component in some wrapper.\r\n```ruby\r\n# app/config/initializers/simple_form.rb\r\nSimpleForm.setup do |config|\r\n # Create a wrapper using the custom component.\r\n config.wrappers :input_group, tag: :div, error_class: :error do |b|\r\n b.use :label\r\n b.optional :prepend\r\n b.use :input\r\n b.use :append\r\n end\r\nend\r\n```\r\n\r\n- Using wrapper with the custom component.\r\n\r\n```ruby\r\n<%= simple_form_for @blog, wrapper: input_group do |f| %>\r\n <%= f.input :title, prepend: true %>\r\n<% end %>\r\n```\r\n\r\n### Notes\r\n\r\nFor while, it is just a idea. I'm open for suggestions 😄 \r\n\r\n### Todo\r\n- [x] Add tests \r\n- [x] Add docs\r\n- [x] Update generator","created_at":"2018-03-09T01:52:48Z","updated_at":"2018-03-13T11:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b40f1d6c4703c88dd22a4f63d6340a6035b5d16e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars3.githubusercontent.com/u/47848?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},{"login":"tegon","id":3727827,"avatar_url":"https://avatars0.githubusercontent.com/u/3727827?v=4","gravatar_id":"","url":"https://api.github.com/users/tegon","html_url":"https://github.com/tegon","followers_url":"https://api.github.com/users/tegon/followers","following_url":"https://api.github.com/users/tegon/following{/other_user}","gists_url":"https://api.github.com/users/tegon/gists{/gist_id}","starred_url":"https://api.github.com/users/tegon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tegon/subscriptions","organizations_url":"https://api.github.com/users/tegon/orgs","repos_url":"https://api.github.com/users/tegon/repos","events_url":"https://api.github.com/users/tegon/events{/privacy}","received_events_url":"https://api.github.com/users/tegon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556/commits","review_comments_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556/comments","review_comment_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/issues/1556/comments","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/e6f339b5c10d0c310151d9103d0d5fe343f3533f","head":{"label":"plataformatec:plataformatec/frg-api-to-register-components","ref":"plataformatec/frg-api-to-register-components","sha":"e6f339b5c10d0c310151d9103d0d5fe343f3533f","user":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars1.githubusercontent.com/u/127679?v=4","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"repo":{"id":451035,"name":"simple_form","full_name":"plataformatec/simple_form","owner":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars1.githubusercontent.com/u/127679?v=4","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plataformatec/simple_form","description":"Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.","fork":false,"url":"https://api.github.com/repos/plataformatec/simple_form","forks_url":"https://api.github.com/repos/plataformatec/simple_form/forks","keys_url":"https://api.github.com/repos/plataformatec/simple_form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plataformatec/simple_form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plataformatec/simple_form/teams","hooks_url":"https://api.github.com/repos/plataformatec/simple_form/hooks","issue_events_url":"https://api.github.com/repos/plataformatec/simple_form/issues/events{/number}","events_url":"https://api.github.com/repos/plataformatec/simple_form/events","assignees_url":"https://api.github.com/repos/plataformatec/simple_form/assignees{/user}","branches_url":"https://api.github.com/repos/plataformatec/simple_form/branches{/branch}","tags_url":"https://api.github.com/repos/plataformatec/simple_form/tags","blobs_url":"https://api.github.com/repos/plataformatec/simple_form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plataformatec/simple_form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plataformatec/simple_form/git/refs{/sha}","trees_url":"https://api.github.com/repos/plataformatec/simple_form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/{sha}","languages_url":"https://api.github.com/repos/plataformatec/simple_form/languages","stargazers_url":"https://api.github.com/repos/plataformatec/simple_form/stargazers","contributors_url":"https://api.github.com/repos/plataformatec/simple_form/contributors","subscribers_url":"https://api.github.com/repos/plataformatec/simple_form/subscribers","subscription_url":"https://api.github.com/repos/plataformatec/simple_form/subscription","commits_url":"https://api.github.com/repos/plataformatec/simple_form/commits{/sha}","git_commits_url":"https://api.github.com/repos/plataformatec/simple_form/git/commits{/sha}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/comments{/number}","issue_comment_url":"https://api.github.com/repos/plataformatec/simple_form/issues/comments{/number}","contents_url":"https://api.github.com/repos/plataformatec/simple_form/contents/{+path}","compare_url":"https://api.github.com/repos/plataformatec/simple_form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plataformatec/simple_form/merges","archive_url":"https://api.github.com/repos/plataformatec/simple_form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plataformatec/simple_form/downloads","issues_url":"https://api.github.com/repos/plataformatec/simple_form/issues{/number}","pulls_url":"https://api.github.com/repos/plataformatec/simple_form/pulls{/number}","milestones_url":"https://api.github.com/repos/plataformatec/simple_form/milestones{/number}","notifications_url":"https://api.github.com/repos/plataformatec/simple_form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plataformatec/simple_form/labels{/name}","releases_url":"https://api.github.com/repos/plataformatec/simple_form/releases{/id}","deployments_url":"https://api.github.com/repos/plataformatec/simple_form/deployments","created_at":"2009-12-28T14:23:48Z","updated_at":"2018-03-12T14:00:54Z","pushed_at":"2018-03-13T10:30:51Z","git_url":"git://github.com/plataformatec/simple_form.git","ssh_url":"git@github.com:plataformatec/simple_form.git","clone_url":"https://github.com/plataformatec/simple_form.git","svn_url":"https://github.com/plataformatec/simple_form","homepage":"http://blog.plataformatec.com.br/tag/simple_form","size":2421,"stargazers_count":6984,"watchers_count":6984,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1164,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1164,"open_issues":43,"watchers":6984,"default_branch":"master"}},"base":{"label":"plataformatec:master","ref":"master","sha":"d32cf5fab7e8d2da7eacd98fa8a00017ca1bf07a","user":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars1.githubusercontent.com/u/127679?v=4","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"repo":{"id":451035,"name":"simple_form","full_name":"plataformatec/simple_form","owner":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars1.githubusercontent.com/u/127679?v=4","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plataformatec/simple_form","description":"Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.","fork":false,"url":"https://api.github.com/repos/plataformatec/simple_form","forks_url":"https://api.github.com/repos/plataformatec/simple_form/forks","keys_url":"https://api.github.com/repos/plataformatec/simple_form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plataformatec/simple_form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plataformatec/simple_form/teams","hooks_url":"https://api.github.com/repos/plataformatec/simple_form/hooks","issue_events_url":"https://api.github.com/repos/plataformatec/simple_form/issues/events{/number}","events_url":"https://api.github.com/repos/plataformatec/simple_form/events","assignees_url":"https://api.github.com/repos/plataformatec/simple_form/assignees{/user}","branches_url":"https://api.github.com/repos/plataformatec/simple_form/branches{/branch}","tags_url":"https://api.github.com/repos/plataformatec/simple_form/tags","blobs_url":"https://api.github.com/repos/plataformatec/simple_form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plataformatec/simple_form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plataformatec/simple_form/git/refs{/sha}","trees_url":"https://api.github.com/repos/plataformatec/simple_form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/{sha}","languages_url":"https://api.github.com/repos/plataformatec/simple_form/languages","stargazers_url":"https://api.github.com/repos/plataformatec/simple_form/stargazers","contributors_url":"https://api.github.com/repos/plataformatec/simple_form/contributors","subscribers_url":"https://api.github.com/repos/plataformatec/simple_form/subscribers","subscription_url":"https://api.github.com/repos/plataformatec/simple_form/subscription","commits_url":"https://api.github.com/repos/plataformatec/simple_form/commits{/sha}","git_commits_url":"https://api.github.com/repos/plataformatec/simple_form/git/commits{/sha}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/comments{/number}","issue_comment_url":"https://api.github.com/repos/plataformatec/simple_form/issues/comments{/number}","contents_url":"https://api.github.com/repos/plataformatec/simple_form/contents/{+path}","compare_url":"https://api.github.com/repos/plataformatec/simple_form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plataformatec/simple_form/merges","archive_url":"https://api.github.com/repos/plataformatec/simple_form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plataformatec/simple_form/downloads","issues_url":"https://api.github.com/repos/plataformatec/simple_form/issues{/number}","pulls_url":"https://api.github.com/repos/plataformatec/simple_form/pulls{/number}","milestones_url":"https://api.github.com/repos/plataformatec/simple_form/milestones{/number}","notifications_url":"https://api.github.com/repos/plataformatec/simple_form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plataformatec/simple_form/labels{/name}","releases_url":"https://api.github.com/repos/plataformatec/simple_form/releases{/id}","deployments_url":"https://api.github.com/repos/plataformatec/simple_form/deployments","created_at":"2009-12-28T14:23:48Z","updated_at":"2018-03-12T14:00:54Z","pushed_at":"2018-03-13T10:30:51Z","git_url":"git://github.com/plataformatec/simple_form.git","ssh_url":"git@github.com:plataformatec/simple_form.git","clone_url":"https://github.com/plataformatec/simple_form.git","svn_url":"https://github.com/plataformatec/simple_form","homepage":"http://blog.plataformatec.com.br/tag/simple_form","size":2421,"stargazers_count":6984,"watchers_count":6984,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1164,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1164,"open_issues":43,"watchers":6984,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556"},"html":{"href":"https://github.com/plataformatec/simple_form/pull/1556"},"issue":{"href":"https://api.github.com/repos/plataformatec/simple_form/issues/1556"},"comments":{"href":"https://api.github.com/repos/plataformatec/simple_form/issues/1556/comments"},"review_comments":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556/comments"},"review_comment":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1556/commits"},"statuses":{"href":"https://api.github.com/repos/plataformatec/simple_form/statuses/e6f339b5c10d0c310151d9103d0d5fe343f3533f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 451035,
"name": "plataformatec/simple_form",
"url": "https://api.github.com/repos/plataformatec/simple_form"
} | {
"id": 27698968,
"login": "feliperenan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27698968?",
"url": "https://api.github.com/users/feliperenan"
} | {
"id": 127679,
"login": "plataformatec",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/127679?",
"url": "https://api.github.com/orgs/plataformatec"
} | 2018-03-13T11:27:20 | 7371352167 | {"actor":{"display_login":"feliperenan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/213968649","pull_request_review_id":150905685,"id":213968649,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk2ODY0OQ==","diff_hunk":"@@ -66,6 +67,7 @@ ul.download-list {\n \n .download-button {\n display: inline-block;\n+ text-align: center;","path":"media/css/pebbles/components/_buttons-download.scss","position":12,"original_position":12,"commit_id":"0437185c1221e7e6d5387a54e6bf33bcbd93ebc3","original_commit_id":"0437185c1221e7e6d5387a54e6bf33bcbd93ebc3","user":{"login":"alexgibson","id":400117,"node_id":"MDQ6VXNlcjQwMDExNw==","avatar_url":"https://avatars0.githubusercontent.com/u/400117?v=4","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"This is going to change all text and messaging within the download button to centered, which looks odd on some pages where text is left or right aligned. Is there a reason to change it?","created_at":"2018-08-30T09:47:06Z","updated_at":"2018-08-30T09:55:27Z","html_url":"https://github.com/mozilla/bedrock/pull/6044#discussion_r213968649","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6044","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/213968649"},"html":{"href":"https://github.com/mozilla/bedrock/pull/6044#discussion_r213968649"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6044"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/6044","id":209448899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDQ4ODk5","html_url":"https://github.com/mozilla/bedrock/pull/6044","diff_url":"https://github.com/mozilla/bedrock/pull/6044.diff","patch_url":"https://github.com/mozilla/bedrock/pull/6044.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/6044","number":6044,"state":"open","locked":false,"title":"Bug 1339226 - Update download buttons for Windows XP/Vista users once Firefox 52 ESR reaches EOL","user":{"login":"kyoshino","id":2929505,"node_id":"MDQ6VXNlcjI5Mjk1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2929505?v=4","gravatar_id":"","url":"https://api.github.com/users/kyoshino","html_url":"https://github.com/kyoshino","followers_url":"https://api.github.com/users/kyoshino/followers","following_url":"https://api.github.com/users/kyoshino/following{/other_user}","gists_url":"https://api.github.com/users/kyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/kyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyoshino/subscriptions","organizations_url":"https://api.github.com/users/kyoshino/orgs","repos_url":"https://api.github.com/users/kyoshino/repos","events_url":"https://api.github.com/users/kyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/kyoshino/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n* Firefox 52 ESR reaches the EOL on September 5. The Firefox download buttons have to be updated to show a warning to Windows XP/Vista users while allowing downloads\r\n* See [my bug comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1339226#c17) for details and screenshots\r\n* I don’t know how Protocol works so didn’t add any warning styling to `media/css/protocol/components/_download-button.scss`\r\n\r\n## Localization\r\n\r\nThere are 2 new short strings. The latter is TBD\r\n\r\n```html\r\n<a href=\"%(url)s\">Mozilla no longer provides security updates for Firefox on Windows XP or Vista</a>, but you can still download the final Windows 32-bit version below.\r\n```\r\n```html\r\nYou’re using an insecure, outdated operating system <a href=\"%(url)s\">no longer supported by Firefox</a>.\r\n```\r\n\r\n## Issue / Bugzilla link\r\n\r\n[Bug 1339226](https://bugzilla.mozilla.org/show_bug.cgi?id=1339226#c17)\r\n\r\n## Testing\r\n\r\nTesting with a physical/virtual XP/Vista machine would be great, but you can still see the warnings by changing the class name on `<html>` to `windows xpvista x86 js loaded`","created_at":"2018-08-20T08:39:07Z","updated_at":"2018-08-30T09:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"162f52f98d792d80d4a0ce5758df77dd6d752c84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":269331505,"node_id":"MDU6TGFiZWwyNjkzMzE1MDU=","url":"https://api.github.com/repos/mozilla/bedrock/labels/L10N%20-%20Localization%20Started","name":"L10N - Localization Started","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6044/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/6044/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/6044/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/0437185c1221e7e6d5387a54e6bf33bcbd93ebc3","head":{"label":"kyoshino:bug-1339226-52-eol-xpvista","ref":"bug-1339226-52-eol-xpvista","sha":"0437185c1221e7e6d5387a54e6bf33bcbd93ebc3","user":{"login":"kyoshino","id":2929505,"node_id":"MDQ6VXNlcjI5Mjk1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2929505?v=4","gravatar_id":"","url":"https://api.github.com/users/kyoshino","html_url":"https://github.com/kyoshino","followers_url":"https://api.github.com/users/kyoshino/followers","following_url":"https://api.github.com/users/kyoshino/following{/other_user}","gists_url":"https://api.github.com/users/kyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/kyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyoshino/subscriptions","organizations_url":"https://api.github.com/users/kyoshino/orgs","repos_url":"https://api.github.com/users/kyoshino/repos","events_url":"https://api.github.com/users/kyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/kyoshino/received_events","type":"User","site_admin":false},"repo":{"id":10098145,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA5ODE0NQ==","name":"bedrock","full_name":"kyoshino/bedrock","owner":{"login":"kyoshino","id":2929505,"node_id":"MDQ6VXNlcjI5Mjk1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2929505?v=4","gravatar_id":"","url":"https://api.github.com/users/kyoshino","html_url":"https://github.com/kyoshino","followers_url":"https://api.github.com/users/kyoshino/followers","following_url":"https://api.github.com/users/kyoshino/following{/other_user}","gists_url":"https://api.github.com/users/kyoshino/gists{/gist_id}","starred_url":"https://api.github.com/users/kyoshino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyoshino/subscriptions","organizations_url":"https://api.github.com/users/kyoshino/orgs","repos_url":"https://api.github.com/users/kyoshino/repos","events_url":"https://api.github.com/users/kyoshino/events{/privacy}","received_events_url":"https://api.github.com/users/kyoshino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyoshino/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":true,"url":"https://api.github.com/repos/kyoshino/bedrock","forks_url":"https://api.github.com/repos/kyoshino/bedrock/forks","keys_url":"https://api.github.com/repos/kyoshino/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyoshino/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyoshino/bedrock/teams","hooks_url":"https://api.github.com/repos/kyoshino/bedrock/hooks","issue_events_url":"https://api.github.com/repos/kyoshino/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/kyoshino/bedrock/events","assignees_url":"https://api.github.com/repos/kyoshino/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/kyoshino/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/kyoshino/bedrock/tags","blobs_url":"https://api.github.com/repos/kyoshino/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyoshino/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyoshino/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyoshino/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyoshino/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/kyoshino/bedrock/languages","stargazers_url":"https://api.github.com/repos/kyoshino/bedrock/stargazers","contributors_url":"https://api.github.com/repos/kyoshino/bedrock/contributors","subscribers_url":"https://api.github.com/repos/kyoshino/bedrock/subscribers","subscription_url":"https://api.github.com/repos/kyoshino/bedrock/subscription","commits_url":"https://api.github.com/repos/kyoshino/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyoshino/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyoshino/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyoshino/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyoshino/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/kyoshino/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyoshino/bedrock/merges","archive_url":"https://api.github.com/repos/kyoshino/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyoshino/bedrock/downloads","issues_url":"https://api.github.com/repos/kyoshino/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/kyoshino/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/kyoshino/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/kyoshino/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyoshino/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/kyoshino/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/kyoshino/bedrock/deployments","created_at":"2013-05-16T09:37:06Z","updated_at":"2018-08-18T05:38:24Z","pushed_at":"2018-08-20T08:22:22Z","git_url":"git://github.com/kyoshino/bedrock.git","ssh_url":"git@github.com:kyoshino/bedrock.git","clone_url":"https://github.com/kyoshino/bedrock.git","svn_url":"https://github.com/kyoshino/bedrock","homepage":"http://mozilla.org","size":462919,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e112ce402db0def407b8b0c8d36334b1d20a6d55","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2NjY1","name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2018-08-30T06:30:27Z","pushed_at":"2018-08-30T00:16:17Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":473106,"stargazers_count":698,"watchers_count":698,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":724,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":724,"open_issues":151,"watchers":698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6044"},"html":{"href":"https://github.com/mozilla/bedrock/pull/6044"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/6044"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/6044/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6044/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/6044/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/0437185c1221e7e6d5387a54e6bf33bcbd93ebc3"}},"author_association":"MEMBER"}} | {
"id": 1616665,
"name": "mozilla/bedrock",
"url": "https://api.github.com/repos/mozilla/bedrock"
} | {
"id": 400117,
"login": "alexgibson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/400117?",
"url": "https://api.github.com/users/alexgibson"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2018-08-30T09:47:06 | 8190224792 | {"actor":{"display_login":"alexgibson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/comments/172719082","pull_request_review_id":101784174,"id":172719082,"diff_hunk":"@@ -0,0 +1,142 @@\n+\n+# Tab Split Metrics\n+\n+Metrics collections and analysis plan for Tab Split as part of the [Firefox Test Pilot program](https://testpilot.firefox.com).\n+\n+## Analysis\n+\n+Data collected in this experiment will be used to answer the following high-level questions:\n+\n+* How often do users load a non-homepage in the sidebar?\n+* Are people who use Tab Split heavy tab users?\n+\n+\n+\n+## Collection\n+Data will be collected with Google Analytics and follow [Test Pilot standards](https://github.com/mozilla/testpilot/blob/master/docs/experiments/ga.md) for reporting.\n+\n+## Custom Metrics\n+*none*\n+\n+### Custom Dimensions\n+\n+* `cd1` - The width of the sidebar in pixels. An integer\n+* `cd2` - The number of open tabs in the current window. An integer","path":"docs/metrics.md","position":24,"original_position":24,"commit_id":"ae2280e4237e5189d88c62a080d8453cafa838af","original_commit_id":"ae2280e4237e5189d88c62a080d8453cafa838af","user":{"login":"clouserw","id":80098,"avatar_url":"https://avatars3.githubusercontent.com/u/80098?v=4","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"body":"Is the list of open tabs per-window or across all windows? @johngruen ","created_at":"2018-03-07T01:45:26Z","updated_at":"2018-03-07T01:45:26Z","html_url":"https://github.com/mozilla/tab-split-2/pull/65#discussion_r172719082","pull_request_url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/comments/172719082"},"html":{"href":"https://github.com/mozilla/tab-split-2/pull/65#discussion_r172719082"},"pull_request":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65","id":173331265,"html_url":"https://github.com/mozilla/tab-split-2/pull/65","diff_url":"https://github.com/mozilla/tab-split-2/pull/65.diff","patch_url":"https://github.com/mozilla/tab-split-2/pull/65.patch","issue_url":"https://api.github.com/repos/mozilla/tab-split-2/issues/65","number":65,"state":"open","locked":false,"title":"Fix #20, add metrics.md","user":{"login":"clouserw","id":80098,"avatar_url":"https://avatars3.githubusercontent.com/u/80098?v=4","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-07T01:44:22Z","updated_at":"2018-03-07T01:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d2e31d63f2983ce2fed95418d9cabba1d8e9928","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65/commits","review_comments_url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65/comments","review_comment_url":"https://api.github.com/repos/mozilla/tab-split-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/tab-split-2/issues/65/comments","statuses_url":"https://api.github.com/repos/mozilla/tab-split-2/statuses/ae2280e4237e5189d88c62a080d8453cafa838af","head":{"label":"clouserw:metrics","ref":"metrics","sha":"ae2280e4237e5189d88c62a080d8453cafa838af","user":{"login":"clouserw","id":80098,"avatar_url":"https://avatars3.githubusercontent.com/u/80098?v=4","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"repo":{"id":124118301,"name":"tab-split-2","full_name":"clouserw/tab-split-2","owner":{"login":"clouserw","id":80098,"avatar_url":"https://avatars3.githubusercontent.com/u/80098?v=4","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clouserw/tab-split-2","description":"An experiment with opening mobile views of pages in the sidebar","fork":true,"url":"https://api.github.com/repos/clouserw/tab-split-2","forks_url":"https://api.github.com/repos/clouserw/tab-split-2/forks","keys_url":"https://api.github.com/repos/clouserw/tab-split-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clouserw/tab-split-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clouserw/tab-split-2/teams","hooks_url":"https://api.github.com/repos/clouserw/tab-split-2/hooks","issue_events_url":"https://api.github.com/repos/clouserw/tab-split-2/issues/events{/number}","events_url":"https://api.github.com/repos/clouserw/tab-split-2/events","assignees_url":"https://api.github.com/repos/clouserw/tab-split-2/assignees{/user}","branches_url":"https://api.github.com/repos/clouserw/tab-split-2/branches{/branch}","tags_url":"https://api.github.com/repos/clouserw/tab-split-2/tags","blobs_url":"https://api.github.com/repos/clouserw/tab-split-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clouserw/tab-split-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clouserw/tab-split-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/clouserw/tab-split-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clouserw/tab-split-2/statuses/{sha}","languages_url":"https://api.github.com/repos/clouserw/tab-split-2/languages","stargazers_url":"https://api.github.com/repos/clouserw/tab-split-2/stargazers","contributors_url":"https://api.github.com/repos/clouserw/tab-split-2/contributors","subscribers_url":"https://api.github.com/repos/clouserw/tab-split-2/subscribers","subscription_url":"https://api.github.com/repos/clouserw/tab-split-2/subscription","commits_url":"https://api.github.com/repos/clouserw/tab-split-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/clouserw/tab-split-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/clouserw/tab-split-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/clouserw/tab-split-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/clouserw/tab-split-2/contents/{+path}","compare_url":"https://api.github.com/repos/clouserw/tab-split-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clouserw/tab-split-2/merges","archive_url":"https://api.github.com/repos/clouserw/tab-split-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clouserw/tab-split-2/downloads","issues_url":"https://api.github.com/repos/clouserw/tab-split-2/issues{/number}","pulls_url":"https://api.github.com/repos/clouserw/tab-split-2/pulls{/number}","milestones_url":"https://api.github.com/repos/clouserw/tab-split-2/milestones{/number}","notifications_url":"https://api.github.com/repos/clouserw/tab-split-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clouserw/tab-split-2/labels{/name}","releases_url":"https://api.github.com/repos/clouserw/tab-split-2/releases{/id}","deployments_url":"https://api.github.com/repos/clouserw/tab-split-2/deployments","created_at":"2018-03-06T18:05:13Z","updated_at":"2018-03-06T18:05:14Z","pushed_at":"2018-03-07T01:44:05Z","git_url":"git://github.com/clouserw/tab-split-2.git","ssh_url":"git@github.com:clouserw/tab-split-2.git","clone_url":"https://github.com/clouserw/tab-split-2.git","svn_url":"https://github.com/clouserw/tab-split-2","homepage":null,"size":260,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"07a4bd7564e6145006553fd6237fbb3584b5a750","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":119596567,"name":"tab-split-2","full_name":"mozilla/tab-split-2","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/tab-split-2","description":"An experiment with opening mobile views of pages in the sidebar","fork":false,"url":"https://api.github.com/repos/mozilla/tab-split-2","forks_url":"https://api.github.com/repos/mozilla/tab-split-2/forks","keys_url":"https://api.github.com/repos/mozilla/tab-split-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/tab-split-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/tab-split-2/teams","hooks_url":"https://api.github.com/repos/mozilla/tab-split-2/hooks","issue_events_url":"https://api.github.com/repos/mozilla/tab-split-2/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/tab-split-2/events","assignees_url":"https://api.github.com/repos/mozilla/tab-split-2/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/tab-split-2/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/tab-split-2/tags","blobs_url":"https://api.github.com/repos/mozilla/tab-split-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/tab-split-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/tab-split-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/tab-split-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/tab-split-2/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/tab-split-2/languages","stargazers_url":"https://api.github.com/repos/mozilla/tab-split-2/stargazers","contributors_url":"https://api.github.com/repos/mozilla/tab-split-2/contributors","subscribers_url":"https://api.github.com/repos/mozilla/tab-split-2/subscribers","subscription_url":"https://api.github.com/repos/mozilla/tab-split-2/subscription","commits_url":"https://api.github.com/repos/mozilla/tab-split-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/tab-split-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/tab-split-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/tab-split-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/tab-split-2/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/tab-split-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/tab-split-2/merges","archive_url":"https://api.github.com/repos/mozilla/tab-split-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/tab-split-2/downloads","issues_url":"https://api.github.com/repos/mozilla/tab-split-2/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/tab-split-2/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/tab-split-2/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/tab-split-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/tab-split-2/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/tab-split-2/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/tab-split-2/deployments","created_at":"2018-01-30T21:27:49Z","updated_at":"2018-02-22T19:25:13Z","pushed_at":"2018-03-07T01:44:23Z","git_url":"git://github.com/mozilla/tab-split-2.git","ssh_url":"git@github.com:mozilla/tab-split-2.git","clone_url":"https://github.com/mozilla/tab-split-2.git","svn_url":"https://github.com/mozilla/tab-split-2","homepage":null,"size":276,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":4,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65"},"html":{"href":"https://github.com/mozilla/tab-split-2/pull/65"},"issue":{"href":"https://api.github.com/repos/mozilla/tab-split-2/issues/65"},"comments":{"href":"https://api.github.com/repos/mozilla/tab-split-2/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/tab-split-2/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/tab-split-2/statuses/ae2280e4237e5189d88c62a080d8453cafa838af"}},"author_association":"OWNER"}} | {
"id": 119596567,
"name": "mozilla/tab-split-2",
"url": "https://api.github.com/repos/mozilla/tab-split-2"
} | {
"id": 80098,
"login": "clouserw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/80098?",
"url": "https://api.github.com/users/clouserw"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2018-03-07T01:45:26 | 7341377663 | {"actor":{"display_login":"clouserw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/comments/191884401","pull_request_review_id":124546154,"id":191884401,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTg4NDQwMQ==","diff_hunk":"@@ -1923,6 +1923,25 @@ def getBlob():\n \n return blob\n \n+ def getReleaseBlobs(self, names, transaction=None):\n+ blobs = {}\n+ uncached = []\n+ for name in names:\n+ cached_blob = cache.get('blob', name)\n+ if cached_blob:\n+ blobs.update({name: cached_blob})\n+ else:\n+ uncached.append(name)\n+\n+ q = self.select(where=[self.name.in_(tuple(uncached))], columns=[self.name, self.data, self.data_version], transaction=transaction)\n+ for row in q:\n+# TODO: investigate what's slowing down cache.put\n+# cache.put('blob', row['name'], row['data'])","path":"auslib/db.py","position":17,"original_position":17,"commit_id":"8885ae3469c13e9500fdb8391503963be5392739","original_commit_id":"8885ae3469c13e9500fdb8391503963be5392739","user":{"login":"mozbhearsum","id":49649,"node_id":"MDQ6VXNlcjQ5NjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49649?v=4","gravatar_id":"","url":"https://api.github.com/users/mozbhearsum","html_url":"https://github.com/mozbhearsum","followers_url":"https://api.github.com/users/mozbhearsum/followers","following_url":"https://api.github.com/users/mozbhearsum/following{/other_user}","gists_url":"https://api.github.com/users/mozbhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/mozbhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozbhearsum/subscriptions","organizations_url":"https://api.github.com/users/mozbhearsum/orgs","repos_url":"https://api.github.com/users/mozbhearsum/repos","events_url":"https://api.github.com/users/mozbhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/mozbhearsum/received_events","type":"User","site_admin":false},"body":"Hm, it looks like this was added as footgun protection against a caller putting something into the cache, and then modifying it. I think this is primarily to make sure we don't end up with bad data in the cache when trying to merge blobs together in https://github.com/mozilla/balrog/blob/dd21686a6dbd5b94698f04e518b8d686ad032d95/auslib/db.py#L2012. We could look at disabling the deepcopy for admin if it's truly causing that much performance degradation. Could you try turning it off and see how much of a difference that makes before we go down this road?\r\n\r\nNice detective work!","created_at":"2018-05-30T18:57:00Z","updated_at":"2018-05-30T18:57:00Z","html_url":"https://github.com/mozilla/balrog/pull/535#discussion_r191884401","pull_request_url":"https://api.github.com/repos/mozilla/balrog/pulls/535","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments/191884401"},"html":{"href":"https://github.com/mozilla/balrog/pull/535#discussion_r191884401"},"pull_request":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/535"}},"in_reply_to_id":187638092},"pull_request":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/535","id":179513895,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc5NTEzODk1","html_url":"https://github.com/mozilla/balrog/pull/535","diff_url":"https://github.com/mozilla/balrog/pull/535.diff","patch_url":"https://github.com/mozilla/balrog/pull/535.patch","issue_url":"https://api.github.com/repos/mozilla/balrog/issues/535","number":535,"state":"open","locked":false,"title":"Bug 1445236 show an indication when a rule points at a blob with wnp data (updateLine object)","user":{"login":"collin5","id":11579108,"node_id":"MDQ6VXNlcjExNTc5MTA4","avatar_url":"https://avatars0.githubusercontent.com/u/11579108?v=4","gravatar_id":"","url":"https://api.github.com/users/collin5","html_url":"https://github.com/collin5","followers_url":"https://api.github.com/users/collin5/followers","following_url":"https://api.github.com/users/collin5/following{/other_user}","gists_url":"https://api.github.com/users/collin5/gists{/gist_id}","starred_url":"https://api.github.com/users/collin5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collin5/subscriptions","organizations_url":"https://api.github.com/users/collin5/orgs","repos_url":"https://api.github.com/users/collin5/repos","events_url":"https://api.github.com/users/collin5/events{/privacy}","received_events_url":"https://api.github.com/users/collin5/received_events","type":"User","site_admin":false},"body":"Adds an indication to respective rules for `mapping` or `fallbackMapping` with WNP.\r\n\r\n<img width=\"403\" alt=\"screen shot 2018-04-29 at 15 13 50\" src=\"https://user-images.githubusercontent.com/11579108/39406488-13869b66-4bc0-11e8-9b3d-4ddebf79538d.png\">\r\n","created_at":"2018-04-04T21:11:45Z","updated_at":"2018-05-30T18:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6980ec7cf4511b48ba9f789abbb844a366afb357","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/balrog/pulls/535/commits","review_comments_url":"https://api.github.com/repos/mozilla/balrog/pulls/535/comments","review_comment_url":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/balrog/issues/535/comments","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/8885ae3469c13e9500fdb8391503963be5392739","head":{"label":"andela:b1445236","ref":"b1445236","sha":"8885ae3469c13e9500fdb8391503963be5392739","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":102361210,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNjEyMTA=","name":"balrog","full_name":"andela/balrog","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/balrog","description":"Next generation update service for Mozilla products","fork":true,"url":"https://api.github.com/repos/andela/balrog","forks_url":"https://api.github.com/repos/andela/balrog/forks","keys_url":"https://api.github.com/repos/andela/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/balrog/teams","hooks_url":"https://api.github.com/repos/andela/balrog/hooks","issue_events_url":"https://api.github.com/repos/andela/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/andela/balrog/events","assignees_url":"https://api.github.com/repos/andela/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/andela/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/andela/balrog/tags","blobs_url":"https://api.github.com/repos/andela/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/balrog/languages","stargazers_url":"https://api.github.com/repos/andela/balrog/stargazers","contributors_url":"https://api.github.com/repos/andela/balrog/contributors","subscribers_url":"https://api.github.com/repos/andela/balrog/subscribers","subscription_url":"https://api.github.com/repos/andela/balrog/subscription","commits_url":"https://api.github.com/repos/andela/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/andela/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/balrog/merges","archive_url":"https://api.github.com/repos/andela/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/balrog/downloads","issues_url":"https://api.github.com/repos/andela/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/andela/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/balrog/labels{/name}","releases_url":"https://api.github.com/repos/andela/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/andela/balrog/deployments","created_at":"2017-09-04T12:53:42Z","updated_at":"2018-05-13T00:33:22Z","pushed_at":"2018-05-30T00:18:13Z","git_url":"git://github.com/andela/balrog.git","ssh_url":"git@github.com:andela/balrog.git","clone_url":"https://github.com/andela/balrog.git","svn_url":"https://github.com/andela/balrog","homepage":"","size":63767,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"a59ec1d0511f10e9176a4ac55661f36caca2c718","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2570444,"node_id":"MDEwOlJlcG9zaXRvcnkyNTcwNDQ0","name":"balrog","full_name":"mozilla/balrog","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/balrog","description":"Next generation update service for Mozilla products","fork":false,"url":"https://api.github.com/repos/mozilla/balrog","forks_url":"https://api.github.com/repos/mozilla/balrog/forks","keys_url":"https://api.github.com/repos/mozilla/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/balrog/teams","hooks_url":"https://api.github.com/repos/mozilla/balrog/hooks","issue_events_url":"https://api.github.com/repos/mozilla/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/balrog/events","assignees_url":"https://api.github.com/repos/mozilla/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/balrog/tags","blobs_url":"https://api.github.com/repos/mozilla/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/balrog/languages","stargazers_url":"https://api.github.com/repos/mozilla/balrog/stargazers","contributors_url":"https://api.github.com/repos/mozilla/balrog/contributors","subscribers_url":"https://api.github.com/repos/mozilla/balrog/subscribers","subscription_url":"https://api.github.com/repos/mozilla/balrog/subscription","commits_url":"https://api.github.com/repos/mozilla/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/balrog/merges","archive_url":"https://api.github.com/repos/mozilla/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/balrog/downloads","issues_url":"https://api.github.com/repos/mozilla/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/balrog/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/balrog/deployments","created_at":"2011-10-13T15:51:47Z","updated_at":"2018-05-29T14:33:52Z","pushed_at":"2018-05-29T14:33:49Z","git_url":"git://github.com/mozilla/balrog.git","ssh_url":"git@github.com:mozilla/balrog.git","clone_url":"https://github.com/mozilla/balrog.git","svn_url":"https://github.com/mozilla/balrog","homepage":"","size":63347,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":119,"open_issues":3,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/535"},"html":{"href":"https://github.com/mozilla/balrog/pull/535"},"issue":{"href":"https://api.github.com/repos/mozilla/balrog/issues/535"},"comments":{"href":"https://api.github.com/repos/mozilla/balrog/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/balrog/statuses/8885ae3469c13e9500fdb8391503963be5392739"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2570444,
"name": "mozilla/balrog",
"url": "https://api.github.com/repos/mozilla/balrog"
} | {
"id": 49649,
"login": "mozbhearsum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49649?",
"url": "https://api.github.com/users/mozbhearsum"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2018-05-30T18:57:00 | 7752028328 | {"actor":{"display_login":"mozbhearsum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/ensemble/pulls/comments/221018206","pull_request_review_id":159566289,"id":221018206,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTAxODIwNg==","diff_hunk":"@@ -24,17 +24,15 @@ class DashboardContainer extends React.Component {\n if (dataFetch.pending) {\n return <Spinner />;\n } else if (dataFetch.rejected) {\n- const extraErrorComponentProps = {};\n-\n if (dataFetch.reason && dataFetch.reason.message) {\n- extraErrorComponentProps.message = dataFetch.reason.message;\n+ // eslint-disable-next-line no-console\n+ console.error(dataFetch.reason.message);","path":"src/components/containers/DashboardContainer.js","position":9,"original_position":9,"commit_id":"3ed0f3aac5674538c042e19103e20a78e0176f65","original_commit_id":"3ed0f3aac5674538c042e19103e20a78e0176f65","user":{"login":"openjck","id":933396,"node_id":"MDQ6VXNlcjkzMzM5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/933396?v=4","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"body":"We don't, unfortunately. It's all static hosting.","created_at":"2018-09-27T17:51:50Z","updated_at":"2018-09-27T17:51:50Z","html_url":"https://github.com/mozilla/ensemble/pull/220#discussion_r221018206","pull_request_url":"https://api.github.com/repos/mozilla/ensemble/pulls/220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/comments/221018206"},"html":{"href":"https://github.com/mozilla/ensemble/pull/220#discussion_r221018206"},"pull_request":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/220"}},"in_reply_to_id":220754069},"pull_request":{"url":"https://api.github.com/repos/mozilla/ensemble/pulls/220","id":218424163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDI0MTYz","html_url":"https://github.com/mozilla/ensemble/pull/220","diff_url":"https://github.com/mozilla/ensemble/pull/220.diff","patch_url":"https://github.com/mozilla/ensemble/pull/220.patch","issue_url":"https://api.github.com/repos/mozilla/ensemble/issues/220","number":220,"state":"open","locked":false,"title":"Fix #141: Simplify missing data error message","user":{"login":"openjck","id":933396,"node_id":"MDQ6VXNlcjkzMzM5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/933396?v=4","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"body":"Do not display a message about JSON.parse() to the user, but do show it\r\nin the console. Unfortunately, because of the way ensemble and\r\nensemble-transposer are hosted, it's not possible to determine if an\r\nerror results from a dataset not existing.","created_at":"2018-09-26T19:11:47Z","updated_at":"2018-09-27T17:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e0d9e7aadfbbef29082b385f2544fa55224d3a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/ensemble/pulls/220/commits","review_comments_url":"https://api.github.com/repos/mozilla/ensemble/pulls/220/comments","review_comment_url":"https://api.github.com/repos/mozilla/ensemble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/ensemble/issues/220/comments","statuses_url":"https://api.github.com/repos/mozilla/ensemble/statuses/3ed0f3aac5674538c042e19103e20a78e0176f65","head":{"label":"openjck:issue-141-error-message","ref":"issue-141-error-message","sha":"3ed0f3aac5674538c042e19103e20a78e0176f65","user":{"login":"openjck","id":933396,"node_id":"MDQ6VXNlcjkzMzM5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/933396?v=4","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"repo":{"id":146505996,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1MDU5OTY=","name":"ensemble","full_name":"openjck/ensemble","private":false,"owner":{"login":"openjck","id":933396,"node_id":"MDQ6VXNlcjkzMzM5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/933396?v=4","gravatar_id":"","url":"https://api.github.com/users/openjck","html_url":"https://github.com/openjck","followers_url":"https://api.github.com/users/openjck/followers","following_url":"https://api.github.com/users/openjck/following{/other_user}","gists_url":"https://api.github.com/users/openjck/gists{/gist_id}","starred_url":"https://api.github.com/users/openjck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openjck/subscriptions","organizations_url":"https://api.github.com/users/openjck/orgs","repos_url":"https://api.github.com/users/openjck/repos","events_url":"https://api.github.com/users/openjck/events{/privacy}","received_events_url":"https://api.github.com/users/openjck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/openjck/ensemble","description":"The platform that powers the Firefox Public Data Report 🎵","fork":true,"url":"https://api.github.com/repos/openjck/ensemble","forks_url":"https://api.github.com/repos/openjck/ensemble/forks","keys_url":"https://api.github.com/repos/openjck/ensemble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openjck/ensemble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openjck/ensemble/teams","hooks_url":"https://api.github.com/repos/openjck/ensemble/hooks","issue_events_url":"https://api.github.com/repos/openjck/ensemble/issues/events{/number}","events_url":"https://api.github.com/repos/openjck/ensemble/events","assignees_url":"https://api.github.com/repos/openjck/ensemble/assignees{/user}","branches_url":"https://api.github.com/repos/openjck/ensemble/branches{/branch}","tags_url":"https://api.github.com/repos/openjck/ensemble/tags","blobs_url":"https://api.github.com/repos/openjck/ensemble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openjck/ensemble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openjck/ensemble/git/refs{/sha}","trees_url":"https://api.github.com/repos/openjck/ensemble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openjck/ensemble/statuses/{sha}","languages_url":"https://api.github.com/repos/openjck/ensemble/languages","stargazers_url":"https://api.github.com/repos/openjck/ensemble/stargazers","contributors_url":"https://api.github.com/repos/openjck/ensemble/contributors","subscribers_url":"https://api.github.com/repos/openjck/ensemble/subscribers","subscription_url":"https://api.github.com/repos/openjck/ensemble/subscription","commits_url":"https://api.github.com/repos/openjck/ensemble/commits{/sha}","git_commits_url":"https://api.github.com/repos/openjck/ensemble/git/commits{/sha}","comments_url":"https://api.github.com/repos/openjck/ensemble/comments{/number}","issue_comment_url":"https://api.github.com/repos/openjck/ensemble/issues/comments{/number}","contents_url":"https://api.github.com/repos/openjck/ensemble/contents/{+path}","compare_url":"https://api.github.com/repos/openjck/ensemble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openjck/ensemble/merges","archive_url":"https://api.github.com/repos/openjck/ensemble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openjck/ensemble/downloads","issues_url":"https://api.github.com/repos/openjck/ensemble/issues{/number}","pulls_url":"https://api.github.com/repos/openjck/ensemble/pulls{/number}","milestones_url":"https://api.github.com/repos/openjck/ensemble/milestones{/number}","notifications_url":"https://api.github.com/repos/openjck/ensemble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openjck/ensemble/labels{/name}","releases_url":"https://api.github.com/repos/openjck/ensemble/releases{/id}","deployments_url":"https://api.github.com/repos/openjck/ensemble/deployments","created_at":"2018-08-28T20:57:43Z","updated_at":"2018-08-31T19:39:57Z","pushed_at":"2018-09-26T19:12:59Z","git_url":"git://github.com/openjck/ensemble.git","ssh_url":"git@github.com:openjck/ensemble.git","clone_url":"https://github.com/openjck/ensemble.git","svn_url":"https://github.com/openjck/ensemble","homepage":"https://data.firefox.com/","size":2730,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"dcaf5410d89160aeb87b928ffb275f1c499c2a9b","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":99034450,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzNDQ1MA==","name":"ensemble","full_name":"mozilla/ensemble","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/ensemble","description":"The platform that powers the Firefox Public Data Report :violin: :trumpet: :musical_keyboard:","fork":false,"url":"https://api.github.com/repos/mozilla/ensemble","forks_url":"https://api.github.com/repos/mozilla/ensemble/forks","keys_url":"https://api.github.com/repos/mozilla/ensemble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/ensemble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/ensemble/teams","hooks_url":"https://api.github.com/repos/mozilla/ensemble/hooks","issue_events_url":"https://api.github.com/repos/mozilla/ensemble/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/ensemble/events","assignees_url":"https://api.github.com/repos/mozilla/ensemble/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/ensemble/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/ensemble/tags","blobs_url":"https://api.github.com/repos/mozilla/ensemble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/ensemble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/ensemble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/ensemble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/ensemble/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/ensemble/languages","stargazers_url":"https://api.github.com/repos/mozilla/ensemble/stargazers","contributors_url":"https://api.github.com/repos/mozilla/ensemble/contributors","subscribers_url":"https://api.github.com/repos/mozilla/ensemble/subscribers","subscription_url":"https://api.github.com/repos/mozilla/ensemble/subscription","commits_url":"https://api.github.com/repos/mozilla/ensemble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/ensemble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/ensemble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/ensemble/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/ensemble/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/ensemble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/ensemble/merges","archive_url":"https://api.github.com/repos/mozilla/ensemble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/ensemble/downloads","issues_url":"https://api.github.com/repos/mozilla/ensemble/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/ensemble/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/ensemble/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/ensemble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/ensemble/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/ensemble/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/ensemble/deployments","created_at":"2017-08-01T19:09:15Z","updated_at":"2018-09-24T20:30:54Z","pushed_at":"2018-09-26T19:13:00Z","git_url":"git://github.com/mozilla/ensemble.git","ssh_url":"git@github.com:mozilla/ensemble.git","clone_url":"https://github.com/mozilla/ensemble.git","svn_url":"https://github.com/mozilla/ensemble","homepage":"https://data.firefox.com/","size":3235,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":4,"open_issues":26,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/220"},"html":{"href":"https://github.com/mozilla/ensemble/pull/220"},"issue":{"href":"https://api.github.com/repos/mozilla/ensemble/issues/220"},"comments":{"href":"https://api.github.com/repos/mozilla/ensemble/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/ensemble/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/ensemble/statuses/3ed0f3aac5674538c042e19103e20a78e0176f65"}},"author_association":"CONTRIBUTOR"}} | {
"id": 99034450,
"name": "mozilla/ensemble",
"url": "https://api.github.com/repos/mozilla/ensemble"
} | {
"id": 933396,
"login": "openjck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/933396?",
"url": "https://api.github.com/users/openjck"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2018-09-27T17:51:50 | 8333394856 | {"actor":{"display_login":"openjck"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/238828774","pull_request_review_id":181467304,"id":238828774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODgyODc3NA==","diff_hunk":"@@ -19,7 +19,7 @@\n \"@schematics/angular\": \"^7.0.4\",\n \"@types/node\": \"6.0.84\",\n \"shelljs\": \"0.8.2\",\n- \"tsickle\": \"0.32.1\"\n+ \"tsickle\": \"0.34.0\"","path":"packages/bazel/package.json","position":5,"original_position":5,"commit_id":"df6485f6799eb8823415983872902d5f53eeefc5","original_commit_id":"df6485f6799eb8823415983872902d5f53eeefc5","user":{"login":"DevVersion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"body":"Ups sorry. I didn't update the PR description to match the commit message. I don't want to make this a peer dependency (yet) because it would be a breaking change","created_at":"2018-12-04T20:37:24Z","updated_at":"2018-12-04T20:37:25Z","html_url":"https://github.com/angular/angular/pull/27402#discussion_r238828774","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/27402","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/238828774"},"html":{"href":"https://github.com/angular/angular/pull/27402#discussion_r238828774"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/27402"}},"in_reply_to_id":238822944},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27402","id":235278042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mjc4MDQy","html_url":"https://github.com/angular/angular/pull/27402","diff_url":"https://github.com/angular/angular/pull/27402.diff","patch_url":"https://github.com/angular/angular/pull/27402.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/27402","number":27402,"state":"open","locked":false,"title":"fix(bazel): tsickle dependency not working with typescript 3.1.x","user":{"login":"DevVersion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"body":"`@angular/bazel` currently requires TypeScript 3.1.x as a peer dependency, but comes with `tsickle` as dependency. The current version of `tsickle` that is specified by `@angular/bazel` does not support TypeScript 3.1.x (which is a peer dependency) and therefore we need to make sure that `tsickle` works with the required TypeScript versions.\r\n\r\nThis change updates `tsickle` to the latest version that comes with angular/tsickle@b10fb6d in order to work with TypeScript 3.1.x.","created_at":"2018-12-02T19:08:41Z","updated_at":"2018-12-04T20:37:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd77f5a223c5f3444a11569218cbd539171929d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":217969169,"node_id":"MDU6TGFiZWwyMTc5NjkxNjk=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":698221504,"node_id":"MDU6TGFiZWw2OTgyMjE1MDQ=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20bazel","name":"comp: bazel","color":"c5def5","default":false},{"id":335954385,"node_id":"MDU6TGFiZWwzMzU5NTQzODU=","url":"https://api.github.com/repos/angular/angular/labels/hotlist:%20material2","name":"hotlist: material2","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"node_id":"MDk6TWlsZXN0b25lMzE0Mzg4MA==","number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"node_id":"MDQ6VXNlcjI2NTM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":275,"closed_issues":974,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-12-04T18:44:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/27402/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/27402/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/27402/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/df6485f6799eb8823415983872902d5f53eeefc5","head":{"label":"DevVersion:fix/bazel-tsickle-peer-dependency-3.1.x","ref":"fix/bazel-tsickle-peer-dependency-3.1.x","sha":"df6485f6799eb8823415983872902d5f53eeefc5","user":{"login":"DevVersion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"repo":{"id":45487607,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ4NzYwNw==","name":"angular","full_name":"DevVersion/angular","private":false,"owner":{"login":"DevVersion","id":4987015,"node_id":"MDQ6VXNlcjQ5ODcwMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DevVersion/angular","description":null,"fork":true,"url":"https://api.github.com/repos/DevVersion/angular","forks_url":"https://api.github.com/repos/DevVersion/angular/forks","keys_url":"https://api.github.com/repos/DevVersion/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevVersion/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevVersion/angular/teams","hooks_url":"https://api.github.com/repos/DevVersion/angular/hooks","issue_events_url":"https://api.github.com/repos/DevVersion/angular/issues/events{/number}","events_url":"https://api.github.com/repos/DevVersion/angular/events","assignees_url":"https://api.github.com/repos/DevVersion/angular/assignees{/user}","branches_url":"https://api.github.com/repos/DevVersion/angular/branches{/branch}","tags_url":"https://api.github.com/repos/DevVersion/angular/tags","blobs_url":"https://api.github.com/repos/DevVersion/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevVersion/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevVersion/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevVersion/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevVersion/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/DevVersion/angular/languages","stargazers_url":"https://api.github.com/repos/DevVersion/angular/stargazers","contributors_url":"https://api.github.com/repos/DevVersion/angular/contributors","subscribers_url":"https://api.github.com/repos/DevVersion/angular/subscribers","subscription_url":"https://api.github.com/repos/DevVersion/angular/subscription","commits_url":"https://api.github.com/repos/DevVersion/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevVersion/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevVersion/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevVersion/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevVersion/angular/contents/{+path}","compare_url":"https://api.github.com/repos/DevVersion/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevVersion/angular/merges","archive_url":"https://api.github.com/repos/DevVersion/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevVersion/angular/downloads","issues_url":"https://api.github.com/repos/DevVersion/angular/issues{/number}","pulls_url":"https://api.github.com/repos/DevVersion/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/DevVersion/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/DevVersion/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevVersion/angular/labels{/name}","releases_url":"https://api.github.com/repos/DevVersion/angular/releases{/id}","deployments_url":"https://api.github.com/repos/DevVersion/angular/deployments","created_at":"2015-11-03T18:39:45Z","updated_at":"2018-10-23T16:16:21Z","pushed_at":"2018-12-04T11:23:56Z","git_url":"git://github.com/DevVersion/angular.git","ssh_url":"git@github.com:DevVersion/angular.git","clone_url":"https://github.com/DevVersion/angular.git","svn_url":"https://github.com/DevVersion/angular","homepage":"https://angular.io","size":91291,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f5f323dae044f364cdf49d48489bdfa30e4c2fd5","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-12-04T20:05:20Z","pushed_at":"2018-12-04T20:33:02Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":95210,"stargazers_count":43227,"watchers_count":43227,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11040,"mirror_url":null,"archived":false,"open_issues_count":2625,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11040,"open_issues":2625,"watchers":43227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/27402"},"html":{"href":"https://github.com/angular/angular/pull/27402"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/27402"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/27402/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/27402/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/27402/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/df6485f6799eb8823415983872902d5f53eeefc5"}},"author_association":"MEMBER"}} | {
"id": 24195339,
"name": "angular/angular",
"url": "https://api.github.com/repos/angular/angular"
} | {
"id": 4987015,
"login": "DevVersion",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4987015?",
"url": "https://api.github.com/users/DevVersion"
} | {
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
} | 2018-12-04T20:37:24 | 8697555152 | {"actor":{"display_login":"DevVersion"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/comments/200362908","pull_request_review_id":134663271,"id":200362908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDM2MjkwOA==","diff_hunk":"@@ -12,20 +12,55 @@ import {\n BuilderConfiguration,\n BuilderContext,\n } from '@angular-devkit/architect';\n-import { getSystemPath, normalize, resolve } from '@angular-devkit/core';\n+import { getSystemPath, normalize, resolve, tags } from '@angular-devkit/core';\n+import * as fs from 'fs';\n import * as ngPackagr from 'ng-packagr';\n-import { Observable } from 'rxjs';\n+import { EMPTY, Observable } from 'rxjs';\n+import { catchError, tap } from 'rxjs/operators';\n+import * as semver from 'semver';\n+\n+const NEW_NG_PACKAGR_VERSION = '4.0.0-rc.3';\n \n // TODO move this function to architect or somewhere else where it can be imported from.\n // Blatantly copy-pasted from 'require-project-module.ts'.\n function requireProjectModule(root: string, moduleName: string) {\n return require(require.resolve(moduleName, { paths: [root] }));\n }\n \n+function resolveProjectModule(root: string, moduleName: string) {\n+ return require.resolve(moduleName, { paths: [root] });\n+}\n \n export interface NgPackagrBuilderOptions {\n project: string;\n tsConfig?: string;\n+ watch?: boolean;\n+}\n+\n+function checkNgPackagrVersion(projectRoot: string): boolean {\n+ let ngPackagrJsonPath;\n+\n+ try {\n+ ngPackagrJsonPath = resolveProjectModule(projectRoot, 'ng-packagr/package.json');\n+ } catch {\n+ // @angular/service-worker is not installed","path":"packages/angular_devkit/build_ng_packagr/src/build/index.ts","position":null,"original_position":37,"commit_id":"3631ebfe1a8ee8ed9143c97f532f9f8bf09df6a1","original_commit_id":"71b3c1173f238325b9e7b744dba461c56caf3225","user":{"login":"alan-agius4","id":17563226,"node_id":"MDQ6VXNlcjE3NTYzMjI2","avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"body":"I will rebase and do it :)","created_at":"2018-07-05T14:01:29Z","updated_at":"2018-07-05T14:01:30Z","html_url":"https://github.com/angular/angular-cli/pull/11358#discussion_r200362908","pull_request_url":"https://api.github.com/repos/angular/angular-cli/pulls/11358","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/comments/200362908"},"html":{"href":"https://github.com/angular/angular-cli/pull/11358#discussion_r200362908"},"pull_request":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/11358"}},"in_reply_to_id":200348181},"pull_request":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/11358","id":196948761,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTQ4NzYx","html_url":"https://github.com/angular/angular-cli/pull/11358","diff_url":"https://github.com/angular/angular-cli/pull/11358.diff","patch_url":"https://github.com/angular/angular-cli/pull/11358.patch","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/11358","number":11358,"state":"open","locked":false,"title":"feat: add support for `watch` when building a library","user":{"login":"alan-agius4","id":17563226,"node_id":"MDQ6VXNlcjE3NTYzMjI2","avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"body":"add support for `watch` when building a library\r\n\r\n`ng-packagr` version `4.0.0-rc.2`, lands the incremental builds feature.\r\n\r\nMore info: https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#400-rc2-2018-06-23\r\n\r\nBREAKING CHANGE:\r\n- `ng-packagr` version `4.0.0-rc.2` or greater is required.\r\n- `enableResourceInlining` needs to be enabled for libraries that contain components\r\n\r\n\r\nPs: most likely this should go in V7, but still felt like doing it, so to be ready.\r\n\r\nCloses: #11100","created_at":"2018-06-24T13:00:09Z","updated_at":"2018-07-05T14:01:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2abe8d36b7a0696e02f09ea557d28ceb4e7ff235","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":393399567,"node_id":"MDU6TGFiZWwzOTMzOTk1Njc=","url":"https://api.github.com/repos/angular/angular-cli/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":671710721,"node_id":"MDU6TGFiZWw2NzE3MTA3MjE=","url":"https://api.github.com/repos/angular/angular-cli/labels/target:%20minor","name":"target: minor","color":"008080","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular-cli/pulls/11358/commits","review_comments_url":"https://api.github.com/repos/angular/angular-cli/pulls/11358/comments","review_comment_url":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/11358/comments","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/3631ebfe1a8ee8ed9143c97f532f9f8bf09df6a1","head":{"label":"alan-agius4:ng-packagr_watch","ref":"ng-packagr_watch","sha":"3631ebfe1a8ee8ed9143c97f532f9f8bf09df6a1","user":{"login":"alan-agius4","id":17563226,"node_id":"MDQ6VXNlcjE3NTYzMjI2","avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"repo":{"id":109288232,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyODgyMzI=","name":"angular-cli","full_name":"alan-agius4/angular-cli","owner":{"login":"alan-agius4","id":17563226,"node_id":"MDQ6VXNlcjE3NTYzMjI2","avatar_url":"https://avatars3.githubusercontent.com/u/17563226?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-agius4","html_url":"https://github.com/alan-agius4","followers_url":"https://api.github.com/users/alan-agius4/followers","following_url":"https://api.github.com/users/alan-agius4/following{/other_user}","gists_url":"https://api.github.com/users/alan-agius4/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-agius4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-agius4/subscriptions","organizations_url":"https://api.github.com/users/alan-agius4/orgs","repos_url":"https://api.github.com/users/alan-agius4/repos","events_url":"https://api.github.com/users/alan-agius4/events{/privacy}","received_events_url":"https://api.github.com/users/alan-agius4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alan-agius4/angular-cli","description":"CLI tool for Angular","fork":true,"url":"https://api.github.com/repos/alan-agius4/angular-cli","forks_url":"https://api.github.com/repos/alan-agius4/angular-cli/forks","keys_url":"https://api.github.com/repos/alan-agius4/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alan-agius4/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alan-agius4/angular-cli/teams","hooks_url":"https://api.github.com/repos/alan-agius4/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/alan-agius4/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/alan-agius4/angular-cli/events","assignees_url":"https://api.github.com/repos/alan-agius4/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/alan-agius4/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/alan-agius4/angular-cli/tags","blobs_url":"https://api.github.com/repos/alan-agius4/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alan-agius4/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alan-agius4/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/alan-agius4/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alan-agius4/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/alan-agius4/angular-cli/languages","stargazers_url":"https://api.github.com/repos/alan-agius4/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/alan-agius4/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/alan-agius4/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/alan-agius4/angular-cli/subscription","commits_url":"https://api.github.com/repos/alan-agius4/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/alan-agius4/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/alan-agius4/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/alan-agius4/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/alan-agius4/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/alan-agius4/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alan-agius4/angular-cli/merges","archive_url":"https://api.github.com/repos/alan-agius4/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alan-agius4/angular-cli/downloads","issues_url":"https://api.github.com/repos/alan-agius4/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/alan-agius4/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/alan-agius4/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/alan-agius4/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alan-agius4/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/alan-agius4/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/alan-agius4/angular-cli/deployments","created_at":"2017-11-02T16:05:57Z","updated_at":"2018-07-04T04:39:28Z","pushed_at":"2018-07-05T14:00:23Z","git_url":"git://github.com/alan-agius4/angular-cli.git","ssh_url":"git@github.com:alan-agius4/angular-cli.git","clone_url":"https://github.com/alan-agius4/angular-cli.git","svn_url":"https://github.com/alan-agius4/angular-cli","homepage":"","size":9750,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"df409e67efb8f1c473080ebaffc98724d8b13100","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":36891867,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg5MTg2Nw==","name":"angular-cli","full_name":"angular/angular-cli","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular-cli","description":"CLI tool for Angular","fork":false,"url":"https://api.github.com/repos/angular/angular-cli","forks_url":"https://api.github.com/repos/angular/angular-cli/forks","keys_url":"https://api.github.com/repos/angular/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular-cli/teams","hooks_url":"https://api.github.com/repos/angular/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/angular/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular-cli/events","assignees_url":"https://api.github.com/repos/angular/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular-cli/tags","blobs_url":"https://api.github.com/repos/angular/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular-cli/languages","stargazers_url":"https://api.github.com/repos/angular/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/angular/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/angular/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/angular/angular-cli/subscription","commits_url":"https://api.github.com/repos/angular/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular-cli/merges","archive_url":"https://api.github.com/repos/angular/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular-cli/downloads","issues_url":"https://api.github.com/repos/angular/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular-cli/deployments","created_at":"2015-06-04T19:49:37Z","updated_at":"2018-07-05T13:56:15Z","pushed_at":"2018-07-05T14:01:07Z","git_url":"git://github.com/angular/angular-cli.git","ssh_url":"git@github.com:angular/angular-cli.git","clone_url":"https://github.com/angular/angular-cli.git","svn_url":"https://github.com/angular/angular-cli","homepage":"","size":13707,"stargazers_count":18517,"watchers_count":18517,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4112,"mirror_url":null,"archived":false,"open_issues_count":1514,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4112,"open_issues":1514,"watchers":18517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/11358"},"html":{"href":"https://github.com/angular/angular-cli/pull/11358"},"issue":{"href":"https://api.github.com/repos/angular/angular-cli/issues/11358"},"comments":{"href":"https://api.github.com/repos/angular/angular-cli/issues/11358/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/11358/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/11358/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular-cli/statuses/3631ebfe1a8ee8ed9143c97f532f9f8bf09df6a1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 36891867,
"name": "angular/angular-cli",
"url": "https://api.github.com/repos/angular/angular-cli"
} | {
"id": 17563226,
"login": "alan-agius4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17563226?",
"url": "https://api.github.com/users/alan-agius4"
} | {
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
} | 2018-07-05T14:01:29 | 7923417982 | {"actor":{"display_login":"alan-agius4"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/236844221","pull_request_review_id":179006683,"id":236844221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjg0NDIyMQ==","diff_hunk":"@@ -406,7 +406,7 @@ export function removeView(\n }\n \n /** Gets the child of the given LViewData */\n-export function getLViewChild(viewData: LViewData): LViewData|LContainer|null {\n+export function getLViewChild(viewData: LView): LView|LContainer|null {","path":"packages/core/src/render3/node_manipulation.ts","position":160,"original_position":149,"commit_id":"81d8bc6523130c391af3222293b841705c9e3359","original_commit_id":"059d6ac110da9c376351896e0eec96ba92de65ff","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-11-27T21:01:18Z","updated_at":"2018-11-27T21:01:19Z","html_url":"https://github.com/angular/angular/pull/27282#discussion_r236844221","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/27282","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/236844221"},"html":{"href":"https://github.com/angular/angular/pull/27282#discussion_r236844221"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/27282"}},"in_reply_to_id":236544346},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/27282","id":233788479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzg4NDc5","html_url":"https://github.com/angular/angular/pull/27282","diff_url":"https://github.com/angular/angular/pull/27282.diff","patch_url":"https://github.com/angular/angular/pull/27282.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/27282","number":27282,"state":"open","locked":false,"title":"Ivy simplify global state","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"- rename `LViewData` to `LView` (to be consistent with `TView`)\r\n- Remove `getRenderer`, `getRendererFactory`, `getTview`, `getCurrentQueries`,\r\n\r\nNOTE: This PR is on top of #27223. Please look at the last SHA label `refactor(ivy): treate LView as the primary global state` only","created_at":"2018-11-27T05:53:18Z","updated_at":"2018-11-27T21:01:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0059afe2868360c34f60a8d1d9fc850002fe88eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/27282/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/27282/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/27282/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/81d8bc6523130c391af3222293b841705c9e3359","head":{"label":"mhevery:ivy_simplify_global_state","ref":"ivy_simplify_global_state","sha":"81d8bc6523130c391af3222293b841705c9e3359","user":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"repo":{"id":24658749,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY1ODc0OQ==","name":"angular","full_name":"mhevery/angular","private":false,"owner":{"login":"mhevery","id":111951,"node_id":"MDQ6VXNlcjExMTk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhevery/angular","description":null,"fork":true,"url":"https://api.github.com/repos/mhevery/angular","forks_url":"https://api.github.com/repos/mhevery/angular/forks","keys_url":"https://api.github.com/repos/mhevery/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhevery/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhevery/angular/teams","hooks_url":"https://api.github.com/repos/mhevery/angular/hooks","issue_events_url":"https://api.github.com/repos/mhevery/angular/issues/events{/number}","events_url":"https://api.github.com/repos/mhevery/angular/events","assignees_url":"https://api.github.com/repos/mhevery/angular/assignees{/user}","branches_url":"https://api.github.com/repos/mhevery/angular/branches{/branch}","tags_url":"https://api.github.com/repos/mhevery/angular/tags","blobs_url":"https://api.github.com/repos/mhevery/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhevery/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhevery/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhevery/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhevery/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/mhevery/angular/languages","stargazers_url":"https://api.github.com/repos/mhevery/angular/stargazers","contributors_url":"https://api.github.com/repos/mhevery/angular/contributors","subscribers_url":"https://api.github.com/repos/mhevery/angular/subscribers","subscription_url":"https://api.github.com/repos/mhevery/angular/subscription","commits_url":"https://api.github.com/repos/mhevery/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhevery/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhevery/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhevery/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhevery/angular/contents/{+path}","compare_url":"https://api.github.com/repos/mhevery/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhevery/angular/merges","archive_url":"https://api.github.com/repos/mhevery/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhevery/angular/downloads","issues_url":"https://api.github.com/repos/mhevery/angular/issues{/number}","pulls_url":"https://api.github.com/repos/mhevery/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/mhevery/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/mhevery/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhevery/angular/labels{/name}","releases_url":"https://api.github.com/repos/mhevery/angular/releases{/id}","deployments_url":"https://api.github.com/repos/mhevery/angular/deployments","created_at":"2014-09-30T22:59:23Z","updated_at":"2018-07-25T17:24:32Z","pushed_at":"2018-11-27T20:54:28Z","git_url":"git://github.com/mhevery/angular.git","ssh_url":"git@github.com:mhevery/angular.git","clone_url":"https://github.com/mhevery/angular.git","svn_url":"https://github.com/mhevery/angular","homepage":null,"size":91270,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"78e3a4c97cd18a242c345f06bde3e2b4d9848deb","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-11-27T20:09:08Z","pushed_at":"2018-11-27T20:54:31Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":94642,"stargazers_count":43009,"watchers_count":43009,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10955,"mirror_url":null,"archived":false,"open_issues_count":2599,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10955,"open_issues":2599,"watchers":43009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/27282"},"html":{"href":"https://github.com/angular/angular/pull/27282"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/27282"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/27282/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/27282/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/27282/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/81d8bc6523130c391af3222293b841705c9e3359"}},"author_association":"MEMBER"}} | {
"id": 24195339,
"name": "angular/angular",
"url": "https://api.github.com/repos/angular/angular"
} | {
"id": 111951,
"login": "mhevery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/111951?",
"url": "https://api.github.com/users/mhevery"
} | {
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
} | 2018-11-27T21:01:18 | 8657335285 | {"actor":{"display_login":"mhevery"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/angular/flex-layout/pulls/comments/172050615","pull_request_review_id":101007362,"id":172050615,"diff_hunk":"@@ -29,12 +55,13 @@ task('aot:clear:mods', [], execTask(\n }\n ));\n \n-task('aot:clear:lock', [], execTask(\n+task('aot:clear:lock', [], existsSync(join(demoAppSource, 'package-lock.json')) ?\n+ execTask(","path":"tools/gulp/tasks/aot.ts","position":56,"original_position":56,"commit_id":"992b3ac6fd337300e988655bd512c2d2eb27c133","original_commit_id":"992b3ac6fd337300e988655bd512c2d2eb27c133","user":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars3.githubusercontent.com/u/210413?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"body":"Let's do this here also:\r\n\r\n```ts\r\n () => existsSync(join(universalAppSource, 'package-lock.json')) ?\r\n```\r\n\r\n> Similar to the fix in Universal.","created_at":"2018-03-04T14:31:10Z","updated_at":"2018-03-04T14:33:35Z","html_url":"https://github.com/angular/flex-layout/pull/639#discussion_r172050615","pull_request_url":"https://api.github.com/repos/angular/flex-layout/pulls/639","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/comments/172050615"},"html":{"href":"https://github.com/angular/flex-layout/pull/639#discussion_r172050615"},"pull_request":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/angular/flex-layout/pulls/639","id":172694614,"html_url":"https://github.com/angular/flex-layout/pull/639","diff_url":"https://github.com/angular/flex-layout/pull/639.diff","patch_url":"https://github.com/angular/flex-layout/pull/639.patch","issue_url":"https://api.github.com/repos/angular/flex-layout/issues/639","number":639,"state":"open","locked":false,"title":"build: reset build to use TypeScript 2.6.x","user":{"login":"CaerusKaru","id":416563,"avatar_url":"https://avatars3.githubusercontent.com/u/416563?v=4","gravatar_id":"","url":"https://api.github.com/users/CaerusKaru","html_url":"https://github.com/CaerusKaru","followers_url":"https://api.github.com/users/CaerusKaru/followers","following_url":"https://api.github.com/users/CaerusKaru/following{/other_user}","gists_url":"https://api.github.com/users/CaerusKaru/gists{/gist_id}","starred_url":"https://api.github.com/users/CaerusKaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaerusKaru/subscriptions","organizations_url":"https://api.github.com/users/CaerusKaru/orgs","repos_url":"https://api.github.com/users/CaerusKaru/repos","events_url":"https://api.github.com/users/CaerusKaru/events{/privacy}","received_events_url":"https://api.github.com/users/CaerusKaru/received_events","type":"User","site_admin":false},"body":"* Lock version of TypeScript to 2.6.x since Angular doesn't support\r\n v2.7 yet\r\n* Re-add MediaQueriesModule as a deprecated alias for CoreModule\r\n* Fix AOT/Universal tasks to check for presence of lock file before\r\n deleting it\r\n\r\nFixes #638 ","created_at":"2018-03-04T00:12:39Z","updated_at":"2018-03-04T14:33:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f55f4e696b554e3b5ae60ae01a087bb6d9a3f18","assignee":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars3.githubusercontent.com/u/210413?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"assignees":[{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars3.githubusercontent.com/u/210413?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":498719570,"url":"https://api.github.com/repos/angular/flex-layout/labels/build","name":"build","color":"c5def5","default":false},{"id":477109935,"url":"https://api.github.com/repos/angular/flex-layout/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":812233501,"url":"https://api.github.com/repos/angular/flex-layout/labels/pr:%20merge%20safe","name":"pr: merge safe","color":"81B68C","default":false},{"id":528334410,"url":"https://api.github.com/repos/angular/flex-layout/labels/pr:%20needs%20review","name":"pr: needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/angular/flex-layout/milestones/14","html_url":"https://github.com/angular/flex-layout/milestone/14","labels_url":"https://api.github.com/repos/angular/flex-layout/milestones/14/labels","id":2753202,"number":14,"title":"v5.0.0-beta.14","description":"Fixes for fxFlex injections of max-width + flex-basis","creator":{"login":"ThomasBurleson","id":210413,"avatar_url":"https://avatars3.githubusercontent.com/u/210413?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasBurleson","html_url":"https://github.com/ThomasBurleson","followers_url":"https://api.github.com/users/ThomasBurleson/followers","following_url":"https://api.github.com/users/ThomasBurleson/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBurleson/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBurleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBurleson/subscriptions","organizations_url":"https://api.github.com/users/ThomasBurleson/orgs","repos_url":"https://api.github.com/users/ThomasBurleson/repos","events_url":"https://api.github.com/users/ThomasBurleson/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBurleson/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":21,"state":"open","created_at":"2017-09-08T15:10:13Z","updated_at":"2018-03-04T07:34:40Z","due_on":"2018-04-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/flex-layout/pulls/639/commits","review_comments_url":"https://api.github.com/repos/angular/flex-layout/pulls/639/comments","review_comment_url":"https://api.github.com/repos/angular/flex-layout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/flex-layout/issues/639/comments","statuses_url":"https://api.github.com/repos/angular/flex-layout/statuses/992b3ac6fd337300e988655bd512c2d2eb27c133","head":{"label":"angular:adam/aot","ref":"adam/aot","sha":"992b3ac6fd337300e988655bd512c2d2eb27c133","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":46386922,"name":"flex-layout","full_name":"angular/flex-layout","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/flex-layout","description":"Provides HTML UI layout for Angular applications; using Flexbox and a Responsive API ","fork":false,"url":"https://api.github.com/repos/angular/flex-layout","forks_url":"https://api.github.com/repos/angular/flex-layout/forks","keys_url":"https://api.github.com/repos/angular/flex-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/flex-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/flex-layout/teams","hooks_url":"https://api.github.com/repos/angular/flex-layout/hooks","issue_events_url":"https://api.github.com/repos/angular/flex-layout/issues/events{/number}","events_url":"https://api.github.com/repos/angular/flex-layout/events","assignees_url":"https://api.github.com/repos/angular/flex-layout/assignees{/user}","branches_url":"https://api.github.com/repos/angular/flex-layout/branches{/branch}","tags_url":"https://api.github.com/repos/angular/flex-layout/tags","blobs_url":"https://api.github.com/repos/angular/flex-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/flex-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/flex-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/flex-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/flex-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/flex-layout/languages","stargazers_url":"https://api.github.com/repos/angular/flex-layout/stargazers","contributors_url":"https://api.github.com/repos/angular/flex-layout/contributors","subscribers_url":"https://api.github.com/repos/angular/flex-layout/subscribers","subscription_url":"https://api.github.com/repos/angular/flex-layout/subscription","commits_url":"https://api.github.com/repos/angular/flex-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/flex-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/flex-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/flex-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/flex-layout/contents/{+path}","compare_url":"https://api.github.com/repos/angular/flex-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/flex-layout/merges","archive_url":"https://api.github.com/repos/angular/flex-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/flex-layout/downloads","issues_url":"https://api.github.com/repos/angular/flex-layout/issues{/number}","pulls_url":"https://api.github.com/repos/angular/flex-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/flex-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/flex-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/flex-layout/labels{/name}","releases_url":"https://api.github.com/repos/angular/flex-layout/releases{/id}","deployments_url":"https://api.github.com/repos/angular/flex-layout/deployments","created_at":"2015-11-18T01:27:14Z","updated_at":"2018-03-04T02:05:51Z","pushed_at":"2018-03-04T08:00:25Z","git_url":"git://github.com/angular/flex-layout.git","ssh_url":"git@github.com:angular/flex-layout.git","clone_url":"https://github.com/angular/flex-layout.git","svn_url":"https://github.com/angular/flex-layout","homepage":"","size":4067,"stargazers_count":2337,"watchers_count":2337,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":279,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":279,"open_issues":62,"watchers":2337,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1c3f99fa52cf34cc25000149c933fe1e55fedd73","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":46386922,"name":"flex-layout","full_name":"angular/flex-layout","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/flex-layout","description":"Provides HTML UI layout for Angular applications; using Flexbox and a Responsive API ","fork":false,"url":"https://api.github.com/repos/angular/flex-layout","forks_url":"https://api.github.com/repos/angular/flex-layout/forks","keys_url":"https://api.github.com/repos/angular/flex-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/flex-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/flex-layout/teams","hooks_url":"https://api.github.com/repos/angular/flex-layout/hooks","issue_events_url":"https://api.github.com/repos/angular/flex-layout/issues/events{/number}","events_url":"https://api.github.com/repos/angular/flex-layout/events","assignees_url":"https://api.github.com/repos/angular/flex-layout/assignees{/user}","branches_url":"https://api.github.com/repos/angular/flex-layout/branches{/branch}","tags_url":"https://api.github.com/repos/angular/flex-layout/tags","blobs_url":"https://api.github.com/repos/angular/flex-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/flex-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/flex-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/flex-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/flex-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/flex-layout/languages","stargazers_url":"https://api.github.com/repos/angular/flex-layout/stargazers","contributors_url":"https://api.github.com/repos/angular/flex-layout/contributors","subscribers_url":"https://api.github.com/repos/angular/flex-layout/subscribers","subscription_url":"https://api.github.com/repos/angular/flex-layout/subscription","commits_url":"https://api.github.com/repos/angular/flex-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/flex-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/flex-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/flex-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/flex-layout/contents/{+path}","compare_url":"https://api.github.com/repos/angular/flex-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/flex-layout/merges","archive_url":"https://api.github.com/repos/angular/flex-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/flex-layout/downloads","issues_url":"https://api.github.com/repos/angular/flex-layout/issues{/number}","pulls_url":"https://api.github.com/repos/angular/flex-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/flex-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/flex-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/flex-layout/labels{/name}","releases_url":"https://api.github.com/repos/angular/flex-layout/releases{/id}","deployments_url":"https://api.github.com/repos/angular/flex-layout/deployments","created_at":"2015-11-18T01:27:14Z","updated_at":"2018-03-04T02:05:51Z","pushed_at":"2018-03-04T08:00:25Z","git_url":"git://github.com/angular/flex-layout.git","ssh_url":"git@github.com:angular/flex-layout.git","clone_url":"https://github.com/angular/flex-layout.git","svn_url":"https://github.com/angular/flex-layout","homepage":"","size":4067,"stargazers_count":2337,"watchers_count":2337,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":279,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":279,"open_issues":62,"watchers":2337,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/639"},"html":{"href":"https://github.com/angular/flex-layout/pull/639"},"issue":{"href":"https://api.github.com/repos/angular/flex-layout/issues/639"},"comments":{"href":"https://api.github.com/repos/angular/flex-layout/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/flex-layout/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/angular/flex-layout/statuses/992b3ac6fd337300e988655bd512c2d2eb27c133"}},"author_association":"MEMBER"}} | {
"id": 46386922,
"name": "angular/flex-layout",
"url": "https://api.github.com/repos/angular/flex-layout"
} | {
"id": 210413,
"login": "ThomasBurleson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/210413?",
"url": "https://api.github.com/users/ThomasBurleson"
} | {
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
} | 2018-03-04T14:31:10 | 7327808897 | {"actor":{"display_login":"ThomasBurleson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/168480011","pull_request_review_id":96852303,"id":168480011,"diff_hunk":"@@ -426,12 +421,24 @@ fixmystreet.assets = {\n return hide_assets;\n })(fixmystreet.maps.display_around);\n \n+ var pins_layer = fixmystreet.map.getLayersByName(\"Pins\")[0];\n for (var i = 0; i < fixmystreet.assets.layers.length; i++) {\n var layer = fixmystreet.assets.layers[i];\n fixmystreet.map.addLayer(layer);\n if (layer.fixmystreet.asset_category) {\n fixmystreet.map.events.register( 'zoomend', layer, check_zoom_message_visibility);\n }\n+\n+ // Don't cover the existing pins layer\n+ if (pins_layer) {\n+ layer.setZIndex(pins_layer.getZIndex()-1);\n+ }\n+\n+ // Make sure the fault markers always appear beneath the linked assets\n+ if (layer.fixmystreet.fault_layer) {\n+ layer.fixmystreet.fault_layer.setZIndex(layer.getZIndex()-1);","path":"web/cobrands/fixmystreet/assets.js","position":73,"original_position":31,"commit_id":"f643fcd3e9d82abcf2fe9b9401f1215d9722bb95","original_commit_id":"6a94a682e1be3da8fc5a1c60ed0cc50d692ecce7","user":{"login":"davea","id":4776,"avatar_url":"https://avatars1.githubusercontent.com/u/4776?v=4","gravatar_id":"","url":"https://api.github.com/users/davea","html_url":"https://github.com/davea","followers_url":"https://api.github.com/users/davea/followers","following_url":"https://api.github.com/users/davea/following{/other_user}","gists_url":"https://api.github.com/users/davea/gists{/gist_id}","starred_url":"https://api.github.com/users/davea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davea/subscriptions","organizations_url":"https://api.github.com/users/davea/orgs","repos_url":"https://api.github.com/users/davea/repos","events_url":"https://api.github.com/users/davea/events{/privacy}","received_events_url":"https://api.github.com/users/davea/received_events","type":"User","site_admin":false},"body":"Yep, you're right. Will rejig this to handle that.","created_at":"2018-02-15T13:51:38Z","updated_at":"2018-02-15T13:51:39Z","html_url":"https://github.com/mysociety/fixmystreet/pull/1999#discussion_r168480011","pull_request_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments/168480011"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/1999#discussion_r168480011"},"pull_request":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999"}},"in_reply_to_id":168471975},"pull_request":{"url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999","id":169366244,"html_url":"https://github.com/mysociety/fixmystreet/pull/1999","diff_url":"https://github.com/mysociety/fixmystreet/pull/1999.diff","patch_url":"https://github.com/mysociety/fixmystreet/pull/1999.patch","issue_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1999","number":1999,"state":"open","locked":false,"title":"More asset/inspector form improvements","user":{"login":"davea","id":4776,"avatar_url":"https://avatars1.githubusercontent.com/u/4776?v=4","gravatar_id":"","url":"https://api.github.com/users/davea","html_url":"https://github.com/davea","followers_url":"https://api.github.com/users/davea/followers","following_url":"https://api.github.com/users/davea/following{/other_user}","gists_url":"https://api.github.com/users/davea/gists{/gist_id}","starred_url":"https://api.github.com/users/davea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davea/subscriptions","organizations_url":"https://api.github.com/users/davea/orgs","repos_url":"https://api.github.com/users/davea/repos","events_url":"https://api.github.com/users/davea/events{/privacy}","received_events_url":"https://api.github.com/users/davea/received_events","type":"User","site_admin":false},"body":" - Display asset layers beneath existing markers on the map\r\n - Fill report `usrn` field from highways asset layer independently of e.g. street lights/grit bins\r\n - Fix bug that would delete values of hidden report extra fields when inspector form saved\r\n - Show hidden report extra fields on inspector form","created_at":"2018-02-15T13:06:29Z","updated_at":"2018-02-15T13:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be3f9f133bf798437ea0c2a86a24978af171573","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999/commits","review_comments_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999/comments","review_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/1999/comments","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/f643fcd3e9d82abcf2fe9b9401f1215d9722bb95","head":{"label":"mysociety:more-asset-improvements","ref":"more-asset-improvements","sha":"f643fcd3e9d82abcf2fe9b9401f1215d9722bb95","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2018-02-12T17:25:25Z","pushed_at":"2018-02-15T13:11:32Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":106025,"stargazers_count":342,"watchers_count":342,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":177,"open_issues":195,"watchers":342,"default_branch":"master"}},"base":{"label":"mysociety:master","ref":"master","sha":"502923dc49ff33d5cf20bfa2355c85969f57f336","user":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"repo":{"id":487492,"name":"fixmystreet","full_name":"mysociety/fixmystreet","owner":{"login":"mysociety","id":141338,"avatar_url":"https://avatars1.githubusercontent.com/u/141338?v=4","gravatar_id":"","url":"https://api.github.com/users/mysociety","html_url":"https://github.com/mysociety","followers_url":"https://api.github.com/users/mysociety/followers","following_url":"https://api.github.com/users/mysociety/following{/other_user}","gists_url":"https://api.github.com/users/mysociety/gists{/gist_id}","starred_url":"https://api.github.com/users/mysociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysociety/subscriptions","organizations_url":"https://api.github.com/users/mysociety/orgs","repos_url":"https://api.github.com/users/mysociety/repos","events_url":"https://api.github.com/users/mysociety/events{/privacy}","received_events_url":"https://api.github.com/users/mysociety/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mysociety/fixmystreet","description":"This is mySociety's popular map-based reporting platform: easy to install in new countries and regions","fork":false,"url":"https://api.github.com/repos/mysociety/fixmystreet","forks_url":"https://api.github.com/repos/mysociety/fixmystreet/forks","keys_url":"https://api.github.com/repos/mysociety/fixmystreet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mysociety/fixmystreet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mysociety/fixmystreet/teams","hooks_url":"https://api.github.com/repos/mysociety/fixmystreet/hooks","issue_events_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/events{/number}","events_url":"https://api.github.com/repos/mysociety/fixmystreet/events","assignees_url":"https://api.github.com/repos/mysociety/fixmystreet/assignees{/user}","branches_url":"https://api.github.com/repos/mysociety/fixmystreet/branches{/branch}","tags_url":"https://api.github.com/repos/mysociety/fixmystreet/tags","blobs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mysociety/fixmystreet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mysociety/fixmystreet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mysociety/fixmystreet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mysociety/fixmystreet/statuses/{sha}","languages_url":"https://api.github.com/repos/mysociety/fixmystreet/languages","stargazers_url":"https://api.github.com/repos/mysociety/fixmystreet/stargazers","contributors_url":"https://api.github.com/repos/mysociety/fixmystreet/contributors","subscribers_url":"https://api.github.com/repos/mysociety/fixmystreet/subscribers","subscription_url":"https://api.github.com/repos/mysociety/fixmystreet/subscription","commits_url":"https://api.github.com/repos/mysociety/fixmystreet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mysociety/fixmystreet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mysociety/fixmystreet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mysociety/fixmystreet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mysociety/fixmystreet/contents/{+path}","compare_url":"https://api.github.com/repos/mysociety/fixmystreet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mysociety/fixmystreet/merges","archive_url":"https://api.github.com/repos/mysociety/fixmystreet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mysociety/fixmystreet/downloads","issues_url":"https://api.github.com/repos/mysociety/fixmystreet/issues{/number}","pulls_url":"https://api.github.com/repos/mysociety/fixmystreet/pulls{/number}","milestones_url":"https://api.github.com/repos/mysociety/fixmystreet/milestones{/number}","notifications_url":"https://api.github.com/repos/mysociety/fixmystreet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mysociety/fixmystreet/labels{/name}","releases_url":"https://api.github.com/repos/mysociety/fixmystreet/releases{/id}","deployments_url":"https://api.github.com/repos/mysociety/fixmystreet/deployments","created_at":"2010-01-25T11:54:20Z","updated_at":"2018-02-12T17:25:25Z","pushed_at":"2018-02-15T13:11:32Z","git_url":"git://github.com/mysociety/fixmystreet.git","ssh_url":"git@github.com:mysociety/fixmystreet.git","clone_url":"https://github.com/mysociety/fixmystreet.git","svn_url":"https://github.com/mysociety/fixmystreet","homepage":"http://fixmystreet.org/","size":106025,"stargazers_count":342,"watchers_count":342,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":177,"open_issues":195,"watchers":342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999"},"html":{"href":"https://github.com/mysociety/fixmystreet/pull/1999"},"issue":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1999"},"comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/issues/1999/comments"},"review_comments":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999/comments"},"review_comment":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mysociety/fixmystreet/pulls/1999/commits"},"statuses":{"href":"https://api.github.com/repos/mysociety/fixmystreet/statuses/f643fcd3e9d82abcf2fe9b9401f1215d9722bb95"}},"author_association":"OWNER"}} | {
"id": 487492,
"name": "mysociety/fixmystreet",
"url": "https://api.github.com/repos/mysociety/fixmystreet"
} | {
"id": 4776,
"login": "davea",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4776?",
"url": "https://api.github.com/users/davea"
} | {
"id": 141338,
"login": "mysociety",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/141338?",
"url": "https://api.github.com/orgs/mysociety"
} | 2018-02-15T13:51:38 | 7249635449 | {"actor":{"display_login":"davea"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/phase2/particle/pulls/comments/217877417","pull_request_review_id":155705091,"id":217877417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg3NzQxNw==","diff_hunk":"@@ -12,10 +12,11 @@ import './_vue-facet-table-vuex.twig';\n import './_vue-facet-table-vue.twig';\n \n // Module styles\n-import './_example-widget.scss';\n+import './_vue-widgets.scss';\n \n-import FacetTableVue from './src/vue-example'; // mount only if dom found\n-import FacetTableVueX from './src/vuex-example'; // mount only if dom found\n+import FacetTableVue from './src/vue-cryptos'; // load only if dom found","path":"source/_patterns/02-molecules/vue-widgets/index.js","position":9,"original_position":9,"commit_id":"8628a96db7a8f4cb52faf4c17f793c52aabf9c2a","original_commit_id":"8628a96db7a8f4cb52faf4c17f793c52aabf9c2a","user":{"login":"illepic","id":295127,"node_id":"MDQ6VXNlcjI5NTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/295127?v=4","gravatar_id":"","url":"https://api.github.com/users/illepic","html_url":"https://github.com/illepic","followers_url":"https://api.github.com/users/illepic/followers","following_url":"https://api.github.com/users/illepic/following{/other_user}","gists_url":"https://api.github.com/users/illepic/gists{/gist_id}","starred_url":"https://api.github.com/users/illepic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illepic/subscriptions","organizations_url":"https://api.github.com/users/illepic/orgs","repos_url":"https://api.github.com/users/illepic/repos","events_url":"https://api.github.com/users/illepic/events{/privacy}","received_events_url":"https://api.github.com/users/illepic/received_events","type":"User","site_admin":false},"body":"No need for the inline comments per line here. If anything, put it in a block above (that would be nice actually)","created_at":"2018-09-15T06:24:25Z","updated_at":"2018-09-15T06:38:05Z","html_url":"https://github.com/phase2/particle/pull/365#discussion_r217877417","pull_request_url":"https://api.github.com/repos/phase2/particle/pulls/365","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/phase2/particle/pulls/comments/217877417"},"html":{"href":"https://github.com/phase2/particle/pull/365#discussion_r217877417"},"pull_request":{"href":"https://api.github.com/repos/phase2/particle/pulls/365"}}},"pull_request":{"url":"https://api.github.com/repos/phase2/particle/pulls/365","id":215396860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Mzk2ODYw","html_url":"https://github.com/phase2/particle/pull/365","diff_url":"https://github.com/phase2/particle/pull/365.diff","patch_url":"https://github.com/phase2/particle/pull/365.patch","issue_url":"https://api.github.com/repos/phase2/particle/issues/365","number":365,"state":"open","locked":false,"title":"Particle vue fe","user":{"login":"FrederickEngelhardt","id":31741411,"node_id":"MDQ6VXNlcjMxNzQxNDEx","avatar_url":"https://avatars1.githubusercontent.com/u/31741411?v=4","gravatar_id":"","url":"https://api.github.com/users/FrederickEngelhardt","html_url":"https://github.com/FrederickEngelhardt","followers_url":"https://api.github.com/users/FrederickEngelhardt/followers","following_url":"https://api.github.com/users/FrederickEngelhardt/following{/other_user}","gists_url":"https://api.github.com/users/FrederickEngelhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/FrederickEngelhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrederickEngelhardt/subscriptions","organizations_url":"https://api.github.com/users/FrederickEngelhardt/orgs","repos_url":"https://api.github.com/users/FrederickEngelhardt/repos","events_url":"https://api.github.com/users/FrederickEngelhardt/events{/privacy}","received_events_url":"https://api.github.com/users/FrederickEngelhardt/received_events","type":"User","site_admin":false},"body":"Added the vue-widget to the example-widget.\r\n\r\nThe vue-widget now has dynamically changing css and demonstrates the Vue feature of enabling and disabling classes dynamically.","created_at":"2018-09-13T19:53:29Z","updated_at":"2018-09-15T06:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edc95bd4bcb0fdd3d14b4017ff001ab3a2cc790e","assignee":{"login":"FrederickEngelhardt","id":31741411,"node_id":"MDQ6VXNlcjMxNzQxNDEx","avatar_url":"https://avatars1.githubusercontent.com/u/31741411?v=4","gravatar_id":"","url":"https://api.github.com/users/FrederickEngelhardt","html_url":"https://github.com/FrederickEngelhardt","followers_url":"https://api.github.com/users/FrederickEngelhardt/followers","following_url":"https://api.github.com/users/FrederickEngelhardt/following{/other_user}","gists_url":"https://api.github.com/users/FrederickEngelhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/FrederickEngelhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrederickEngelhardt/subscriptions","organizations_url":"https://api.github.com/users/FrederickEngelhardt/orgs","repos_url":"https://api.github.com/users/FrederickEngelhardt/repos","events_url":"https://api.github.com/users/FrederickEngelhardt/events{/privacy}","received_events_url":"https://api.github.com/users/FrederickEngelhardt/received_events","type":"User","site_admin":false},"assignees":[{"login":"FrederickEngelhardt","id":31741411,"node_id":"MDQ6VXNlcjMxNzQxNDEx","avatar_url":"https://avatars1.githubusercontent.com/u/31741411?v=4","gravatar_id":"","url":"https://api.github.com/users/FrederickEngelhardt","html_url":"https://github.com/FrederickEngelhardt","followers_url":"https://api.github.com/users/FrederickEngelhardt/followers","following_url":"https://api.github.com/users/FrederickEngelhardt/following{/other_user}","gists_url":"https://api.github.com/users/FrederickEngelhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/FrederickEngelhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrederickEngelhardt/subscriptions","organizations_url":"https://api.github.com/users/FrederickEngelhardt/orgs","repos_url":"https://api.github.com/users/FrederickEngelhardt/repos","events_url":"https://api.github.com/users/FrederickEngelhardt/events{/privacy}","received_events_url":"https://api.github.com/users/FrederickEngelhardt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731046873,"node_id":"MDU6TGFiZWw3MzEwNDY4NzM=","url":"https://api.github.com/repos/phase2/particle/labels/javascript","name":"javascript","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/phase2/particle/milestones/3","html_url":"https://github.com/phase2/particle/milestone/3","labels_url":"https://api.github.com/repos/phase2/particle/milestones/3/labels","id":3621394,"node_id":"MDk6TWlsZXN0b25lMzYyMTM5NA==","number":3,"title":"v10.1.0","description":"Quality of life and real-world feedback on fixes needed to make Particle better after initial gold release.\r\n\r\nBig goals:\r\n\r\n- Saner webpack config for particle and apps\r\n- Vue as UI library of choice\r\n- Better docs","creator":{"login":"illepic","id":295127,"node_id":"MDQ6VXNlcjI5NTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/295127?v=4","gravatar_id":"","url":"https://api.github.com/users/illepic","html_url":"https://github.com/illepic","followers_url":"https://api.github.com/users/illepic/followers","following_url":"https://api.github.com/users/illepic/following{/other_user}","gists_url":"https://api.github.com/users/illepic/gists{/gist_id}","starred_url":"https://api.github.com/users/illepic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illepic/subscriptions","organizations_url":"https://api.github.com/users/illepic/orgs","repos_url":"https://api.github.com/users/illepic/repos","events_url":"https://api.github.com/users/illepic/events{/privacy}","received_events_url":"https://api.github.com/users/illepic/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":19,"state":"open","created_at":"2018-09-04T15:51:26Z","updated_at":"2018-09-14T19:21:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phase2/particle/pulls/365/commits","review_comments_url":"https://api.github.com/repos/phase2/particle/pulls/365/comments","review_comment_url":"https://api.github.com/repos/phase2/particle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phase2/particle/issues/365/comments","statuses_url":"https://api.github.com/repos/phase2/particle/statuses/8628a96db7a8f4cb52faf4c17f793c52aabf9c2a","head":{"label":"phase2:particle-vue-fe","ref":"particle-vue-fe","sha":"8628a96db7a8f4cb52faf4c17f793c52aabf9c2a","user":{"login":"phase2","id":148441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODQ0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/148441?v=4","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"repo":{"id":33627949,"node_id":"MDEwOlJlcG9zaXRvcnkzMzYyNzk0OQ==","name":"particle","full_name":"phase2/particle","owner":{"login":"phase2","id":148441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODQ0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/148441?v=4","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phase2/particle","description":"A starter kit for using the prototyping tool, Pattern Lab, in tandem with a Drupal and Grav theme. Utilizes Webpack for all asset management.","fork":false,"url":"https://api.github.com/repos/phase2/particle","forks_url":"https://api.github.com/repos/phase2/particle/forks","keys_url":"https://api.github.com/repos/phase2/particle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phase2/particle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phase2/particle/teams","hooks_url":"https://api.github.com/repos/phase2/particle/hooks","issue_events_url":"https://api.github.com/repos/phase2/particle/issues/events{/number}","events_url":"https://api.github.com/repos/phase2/particle/events","assignees_url":"https://api.github.com/repos/phase2/particle/assignees{/user}","branches_url":"https://api.github.com/repos/phase2/particle/branches{/branch}","tags_url":"https://api.github.com/repos/phase2/particle/tags","blobs_url":"https://api.github.com/repos/phase2/particle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phase2/particle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phase2/particle/git/refs{/sha}","trees_url":"https://api.github.com/repos/phase2/particle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phase2/particle/statuses/{sha}","languages_url":"https://api.github.com/repos/phase2/particle/languages","stargazers_url":"https://api.github.com/repos/phase2/particle/stargazers","contributors_url":"https://api.github.com/repos/phase2/particle/contributors","subscribers_url":"https://api.github.com/repos/phase2/particle/subscribers","subscription_url":"https://api.github.com/repos/phase2/particle/subscription","commits_url":"https://api.github.com/repos/phase2/particle/commits{/sha}","git_commits_url":"https://api.github.com/repos/phase2/particle/git/commits{/sha}","comments_url":"https://api.github.com/repos/phase2/particle/comments{/number}","issue_comment_url":"https://api.github.com/repos/phase2/particle/issues/comments{/number}","contents_url":"https://api.github.com/repos/phase2/particle/contents/{+path}","compare_url":"https://api.github.com/repos/phase2/particle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phase2/particle/merges","archive_url":"https://api.github.com/repos/phase2/particle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phase2/particle/downloads","issues_url":"https://api.github.com/repos/phase2/particle/issues{/number}","pulls_url":"https://api.github.com/repos/phase2/particle/pulls{/number}","milestones_url":"https://api.github.com/repos/phase2/particle/milestones{/number}","notifications_url":"https://api.github.com/repos/phase2/particle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phase2/particle/labels{/name}","releases_url":"https://api.github.com/repos/phase2/particle/releases{/id}","deployments_url":"https://api.github.com/repos/phase2/particle/deployments","created_at":"2015-04-08T19:34:53Z","updated_at":"2018-09-15T05:43:27Z","pushed_at":"2018-09-15T05:43:25Z","git_url":"git://github.com/phase2/particle.git","ssh_url":"git@github.com:phase2/particle.git","clone_url":"https://github.com/phase2/particle.git","svn_url":"https://github.com/phase2/particle","homepage":"https://phase2.github.io/frontend-docs/","size":10168,"stargazers_count":226,"watchers_count":226,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":82,"open_issues":33,"watchers":226,"default_branch":"master"}},"base":{"label":"phase2:particle-vue","ref":"particle-vue","sha":"b518054e3a17ee55a6a1219e0ded867b4161f1f5","user":{"login":"phase2","id":148441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODQ0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/148441?v=4","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"repo":{"id":33627949,"node_id":"MDEwOlJlcG9zaXRvcnkzMzYyNzk0OQ==","name":"particle","full_name":"phase2/particle","owner":{"login":"phase2","id":148441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODQ0MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/148441?v=4","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phase2/particle","description":"A starter kit for using the prototyping tool, Pattern Lab, in tandem with a Drupal and Grav theme. Utilizes Webpack for all asset management.","fork":false,"url":"https://api.github.com/repos/phase2/particle","forks_url":"https://api.github.com/repos/phase2/particle/forks","keys_url":"https://api.github.com/repos/phase2/particle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phase2/particle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phase2/particle/teams","hooks_url":"https://api.github.com/repos/phase2/particle/hooks","issue_events_url":"https://api.github.com/repos/phase2/particle/issues/events{/number}","events_url":"https://api.github.com/repos/phase2/particle/events","assignees_url":"https://api.github.com/repos/phase2/particle/assignees{/user}","branches_url":"https://api.github.com/repos/phase2/particle/branches{/branch}","tags_url":"https://api.github.com/repos/phase2/particle/tags","blobs_url":"https://api.github.com/repos/phase2/particle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phase2/particle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phase2/particle/git/refs{/sha}","trees_url":"https://api.github.com/repos/phase2/particle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phase2/particle/statuses/{sha}","languages_url":"https://api.github.com/repos/phase2/particle/languages","stargazers_url":"https://api.github.com/repos/phase2/particle/stargazers","contributors_url":"https://api.github.com/repos/phase2/particle/contributors","subscribers_url":"https://api.github.com/repos/phase2/particle/subscribers","subscription_url":"https://api.github.com/repos/phase2/particle/subscription","commits_url":"https://api.github.com/repos/phase2/particle/commits{/sha}","git_commits_url":"https://api.github.com/repos/phase2/particle/git/commits{/sha}","comments_url":"https://api.github.com/repos/phase2/particle/comments{/number}","issue_comment_url":"https://api.github.com/repos/phase2/particle/issues/comments{/number}","contents_url":"https://api.github.com/repos/phase2/particle/contents/{+path}","compare_url":"https://api.github.com/repos/phase2/particle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phase2/particle/merges","archive_url":"https://api.github.com/repos/phase2/particle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phase2/particle/downloads","issues_url":"https://api.github.com/repos/phase2/particle/issues{/number}","pulls_url":"https://api.github.com/repos/phase2/particle/pulls{/number}","milestones_url":"https://api.github.com/repos/phase2/particle/milestones{/number}","notifications_url":"https://api.github.com/repos/phase2/particle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phase2/particle/labels{/name}","releases_url":"https://api.github.com/repos/phase2/particle/releases{/id}","deployments_url":"https://api.github.com/repos/phase2/particle/deployments","created_at":"2015-04-08T19:34:53Z","updated_at":"2018-09-15T05:43:27Z","pushed_at":"2018-09-15T05:43:25Z","git_url":"git://github.com/phase2/particle.git","ssh_url":"git@github.com:phase2/particle.git","clone_url":"https://github.com/phase2/particle.git","svn_url":"https://github.com/phase2/particle","homepage":"https://phase2.github.io/frontend-docs/","size":10168,"stargazers_count":226,"watchers_count":226,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":82,"open_issues":33,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phase2/particle/pulls/365"},"html":{"href":"https://github.com/phase2/particle/pull/365"},"issue":{"href":"https://api.github.com/repos/phase2/particle/issues/365"},"comments":{"href":"https://api.github.com/repos/phase2/particle/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/phase2/particle/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/phase2/particle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phase2/particle/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/phase2/particle/statuses/8628a96db7a8f4cb52faf4c17f793c52aabf9c2a"}},"author_association":"NONE"}} | {
"id": 33627949,
"name": "phase2/particle",
"url": "https://api.github.com/repos/phase2/particle"
} | {
"id": 295127,
"login": "illepic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295127?",
"url": "https://api.github.com/users/illepic"
} | {
"id": 148441,
"login": "phase2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/148441?",
"url": "https://api.github.com/orgs/phase2"
} | 2018-09-15T06:24:25 | 8269488460 | {"actor":{"display_login":"illepic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PRX/Infrastructure/pulls/comments/238330828","pull_request_review_id":180845261,"id":238330828,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODMzMDgyOA==","diff_hunk":"@@ -0,0 +1,121 @@\n+# etc/cms-resource-reporter.yml\n+AWSTemplateFormatVersion: \"2010-09-09\"\n+Description: Handles Resource SNS Events, Sends Report to Slack\n+Parameters:\n+ SlackMessageRelayTopicArn:\n+ Type: String\n+ ResourceSnsTopicArn:\n+ Type: String\n+ DescriptiveAttributeKeys:\n+ Type: CommaDelimitedList\n+ SlackChannel:\n+ Type: String\n+Resources:\n+ LambdaIamRole:\n+ Type: \"AWS::IAM::Role\"\n+ Properties:\n+ AssumeRolePolicyDocument:\n+ Version: \"2012-10-17\"\n+ Statement:\n+ - Effect: \"Allow\"\n+ Principal:\n+ Service:\n+ - \"lambda.amazonaws.com\"\n+ Action:\n+ - \"sts:AssumeRole\"\n+ Path: \"/\"\n+ Policies:\n+ - PolicyName: SnsPolicy\n+ PolicyDocument:\n+ Version: \"2012-10-17\"\n+ Statement:\n+ - Effect: Allow\n+ Action:\n+ - \"sns:Publish\"\n+ Resource:\n+ - !Ref SlackMessageRelayTopicArn\n+ ManagedPolicyArns:\n+ - \"arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole\"\n+ PushSubscription:\n+ Type: \"AWS::SNS::Subscription\"\n+ Properties:\n+ Endpoint: !GetAtt MessageHandlerFunction.Arn\n+ Protocol: \"lambda\"\n+ Region: \"us-east-1\"\n+ TopicArn: !Ref ResourceSnsTopicArn\n+ LambdaResourcePolicy:\n+ Type: \"AWS::Lambda::Permission\"\n+ Properties:\n+ FunctionName: !GetAtt MessageHandlerFunction.Arn\n+ Principal: \"sns.amazonaws.com\"\n+ Action: \"lambda:InvokeFunction\"\n+ SourceArn: !Ref ResourceSnsTopicArn \n+ MessageHandlerFunction:\n+ Type: \"AWS::Lambda::Function\"\n+ Properties:\n+ Code:\n+ ZipFile: >\n+ var AWS = require(\"aws-sdk\");\n+ exports.handler = async (event, context) => {\n+ let message = JSON.parse(event[\"Records\"][0][\"Sns\"][\"Message\"]);\n+ let eventBody = JSON.parse(message[\"body\"]);\n+\n+ let descriptiveAttrKeys = process.env.DESCRIPTIVE_ATTRIBUTE_KEYS.split(',');\n+ let resourceActionDesc = process.env.RESOURCE_SNS_TOPIC_ARN\n+ .split(\":\")\n+ .reverse()[0];\n+\n+ let slackMsg = `${resourceActionDesc}:` + '\\n' +\n+ descriptiveAttrKeys.map((key) => `${key}: ${eventBody[key]}`)\n+ .join('\\n');\n+\n+ let relayParams = {\n+ channel: process.env.SLACK_CHANNEL,\n+ username: 'Resource Activity Reporter',\n+ icon_emoji: ':fleur_de_lis:',\n+ text: slackMsg\n+ };\n+\n+ var sns = new AWS.SNS({region: 'us-east-1'});\n+ var snsWrapper = {\n+ Message: JSON.stringify(relayParams),\n+ Subject: \"Resource Reporter: Resource Action Discovered\",\n+ TopicArn: process.env.SLACK_MESSAGE_RELAY_SNS_TOPIC_ARN\n+ };\n+\n+ await sns.publish(snsWrapper).promise();\n+ return relayParams;\n+ };\n+ Description: Listens for CMS SNS actions, routes them to slack\n+ Environment:\n+ Variables:\n+ SLACK_MESSAGE_RELAY_SNS_TOPIC_ARN: !Ref SlackMessageRelayTopicArn\n+ RESOURCE_SNS_TOPIC_ARN: !Ref ResourceSnsTopicArn\n+ SLACK_CHANNEL: !Ref SlackChannel\n+ DESCRIPTIVE_ATTRIBUTE_KEYS:\n+ !Join\n+ - \",\"\n+ - !Ref DescriptiveAttributeKeys\n+ Handler: index.handler\n+ MemorySize: 128\n+ Role: !GetAtt LambdaIamRole.Arn\n+ Runtime: nodejs8.10\n+ Timeout: 8\n+ LambdaErrorAlarm:\n+ Type: \"AWS::CloudWatch::Alarm\"\n+ Properties:\n+ ActionsEnabled: true\n+ AlarmName: \"[CMSResourceReporter][Lambda][Error] Invocation Error\"","path":"etc/resource-reporter.yml","position":108,"original_position":108,"commit_id":"7a1990b5f369454943dc41d4322c0a84c658429a","original_commit_id":"7a1990b5f369454943dc41d4322c0a84c658429a","user":{"login":"cavis","id":1410587,"node_id":"MDQ6VXNlcjE0MTA1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1410587?v=4","gravatar_id":"","url":"https://api.github.com/users/cavis","html_url":"https://github.com/cavis","followers_url":"https://api.github.com/users/cavis/followers","following_url":"https://api.github.com/users/cavis/following{/other_user}","gists_url":"https://api.github.com/users/cavis/gists{/gist_id}","starred_url":"https://api.github.com/users/cavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavis/subscriptions","organizations_url":"https://api.github.com/users/cavis/orgs","repos_url":"https://api.github.com/users/cavis/repos","events_url":"https://api.github.com/users/cavis/events{/privacy}","received_events_url":"https://api.github.com/users/cavis/received_events","type":"User","site_admin":false},"body":"I think these alarm names have to be unique in the account. So trying to create more than one of these is going to fail. Wondering if some sort of \"human readable\" input parameter could suffice? Like `reportName = \"Series Created\"` or something?","created_at":"2018-12-03T16:07:49Z","updated_at":"2018-12-03T16:08:13Z","html_url":"https://github.com/PRX/Infrastructure/pull/281#discussion_r238330828","pull_request_url":"https://api.github.com/repos/PRX/Infrastructure/pulls/281","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/comments/238330828"},"html":{"href":"https://github.com/PRX/Infrastructure/pull/281#discussion_r238330828"},"pull_request":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/PRX/Infrastructure/pulls/281","id":234365988,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzY1OTg4","html_url":"https://github.com/PRX/Infrastructure/pull/281","diff_url":"https://github.com/PRX/Infrastructure/pull/281.diff","patch_url":"https://github.com/PRX/Infrastructure/pull/281.patch","issue_url":"https://api.github.com/repos/PRX/Infrastructure/issues/281","number":281,"state":"open","locked":false,"title":"notify slack when new series are created","user":{"login":"svevang","id":329012,"node_id":"MDQ6VXNlcjMyOTAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/329012?v=4","gravatar_id":"","url":"https://api.github.com/users/svevang","html_url":"https://github.com/svevang","followers_url":"https://api.github.com/users/svevang/followers","following_url":"https://api.github.com/users/svevang/following{/other_user}","gists_url":"https://api.github.com/users/svevang/gists{/gist_id}","starred_url":"https://api.github.com/users/svevang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svevang/subscriptions","organizations_url":"https://api.github.com/users/svevang/orgs","repos_url":"https://api.github.com/users/svevang/repos","events_url":"https://api.github.com/users/svevang/events{/privacy}","received_events_url":"https://api.github.com/users/svevang/received_events","type":"User","site_admin":false},"body":"This PR sets up a new lambda that monitors the CMS create SNS topic and posts details to slack.","created_at":"2018-11-28T17:37:33Z","updated_at":"2018-12-03T16:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1b1df4d9d527c3a32ea20e2154d86b08a194970","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PRX/Infrastructure/pulls/281/commits","review_comments_url":"https://api.github.com/repos/PRX/Infrastructure/pulls/281/comments","review_comment_url":"https://api.github.com/repos/PRX/Infrastructure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PRX/Infrastructure/issues/281/comments","statuses_url":"https://api.github.com/repos/PRX/Infrastructure/statuses/7a1990b5f369454943dc41d4322c0a84c658429a","head":{"label":"PRX:feat/slack-cms-notifcations","ref":"feat/slack-cms-notifcations","sha":"7a1990b5f369454943dc41d4322c0a84c658429a","user":{"login":"PRX","id":160453,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":76403734,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQwMzczNA==","name":"Infrastructure","full_name":"PRX/Infrastructure","private":false,"owner":{"login":"PRX","id":160453,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PRX/Infrastructure","description":"Templates and assets used to launch and manage many aspects of PRX's applications and services","fork":false,"url":"https://api.github.com/repos/PRX/Infrastructure","forks_url":"https://api.github.com/repos/PRX/Infrastructure/forks","keys_url":"https://api.github.com/repos/PRX/Infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/Infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/Infrastructure/teams","hooks_url":"https://api.github.com/repos/PRX/Infrastructure/hooks","issue_events_url":"https://api.github.com/repos/PRX/Infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/Infrastructure/events","assignees_url":"https://api.github.com/repos/PRX/Infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/Infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/Infrastructure/tags","blobs_url":"https://api.github.com/repos/PRX/Infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/Infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/Infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/Infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/Infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/Infrastructure/languages","stargazers_url":"https://api.github.com/repos/PRX/Infrastructure/stargazers","contributors_url":"https://api.github.com/repos/PRX/Infrastructure/contributors","subscribers_url":"https://api.github.com/repos/PRX/Infrastructure/subscribers","subscription_url":"https://api.github.com/repos/PRX/Infrastructure/subscription","commits_url":"https://api.github.com/repos/PRX/Infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/Infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/Infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/Infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/Infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/Infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/Infrastructure/merges","archive_url":"https://api.github.com/repos/PRX/Infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/Infrastructure/downloads","issues_url":"https://api.github.com/repos/PRX/Infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/Infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/Infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/Infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/Infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/PRX/Infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/Infrastructure/deployments","created_at":"2016-12-13T22:27:16Z","updated_at":"2018-11-28T13:26:36Z","pushed_at":"2018-12-03T15:57:40Z","git_url":"git://github.com/PRX/Infrastructure.git","ssh_url":"git@github.com:PRX/Infrastructure.git","clone_url":"https://github.com/PRX/Infrastructure.git","svn_url":"https://github.com/PRX/Infrastructure","homepage":null,"size":1143,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":35,"watchers":23,"default_branch":"master"}},"base":{"label":"PRX:master","ref":"master","sha":"9f25a09b901573d4e238df939fb9a2531bbed8fe","user":{"login":"PRX","id":160453,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":76403734,"node_id":"MDEwOlJlcG9zaXRvcnk3NjQwMzczNA==","name":"Infrastructure","full_name":"PRX/Infrastructure","private":false,"owner":{"login":"PRX","id":160453,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PRX/Infrastructure","description":"Templates and assets used to launch and manage many aspects of PRX's applications and services","fork":false,"url":"https://api.github.com/repos/PRX/Infrastructure","forks_url":"https://api.github.com/repos/PRX/Infrastructure/forks","keys_url":"https://api.github.com/repos/PRX/Infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/Infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/Infrastructure/teams","hooks_url":"https://api.github.com/repos/PRX/Infrastructure/hooks","issue_events_url":"https://api.github.com/repos/PRX/Infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/Infrastructure/events","assignees_url":"https://api.github.com/repos/PRX/Infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/Infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/Infrastructure/tags","blobs_url":"https://api.github.com/repos/PRX/Infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/Infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/Infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/Infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/Infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/Infrastructure/languages","stargazers_url":"https://api.github.com/repos/PRX/Infrastructure/stargazers","contributors_url":"https://api.github.com/repos/PRX/Infrastructure/contributors","subscribers_url":"https://api.github.com/repos/PRX/Infrastructure/subscribers","subscription_url":"https://api.github.com/repos/PRX/Infrastructure/subscription","commits_url":"https://api.github.com/repos/PRX/Infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/Infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/Infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/Infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/Infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/Infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/Infrastructure/merges","archive_url":"https://api.github.com/repos/PRX/Infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/Infrastructure/downloads","issues_url":"https://api.github.com/repos/PRX/Infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/Infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/Infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/Infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/Infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/PRX/Infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/Infrastructure/deployments","created_at":"2016-12-13T22:27:16Z","updated_at":"2018-11-28T13:26:36Z","pushed_at":"2018-12-03T15:57:40Z","git_url":"git://github.com/PRX/Infrastructure.git","ssh_url":"git@github.com:PRX/Infrastructure.git","clone_url":"https://github.com/PRX/Infrastructure.git","svn_url":"https://github.com/PRX/Infrastructure","homepage":null,"size":1143,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":35,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/281"},"html":{"href":"https://github.com/PRX/Infrastructure/pull/281"},"issue":{"href":"https://api.github.com/repos/PRX/Infrastructure/issues/281"},"comments":{"href":"https://api.github.com/repos/PRX/Infrastructure/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PRX/Infrastructure/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/PRX/Infrastructure/statuses/7a1990b5f369454943dc41d4322c0a84c658429a"}},"author_association":"NONE"}} | {
"id": 76403734,
"name": "PRX/Infrastructure",
"url": "https://api.github.com/repos/PRX/Infrastructure"
} | {
"id": 1410587,
"login": "cavis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1410587?",
"url": "https://api.github.com/users/cavis"
} | {
"id": 160453,
"login": "PRX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160453?",
"url": "https://api.github.com/orgs/PRX"
} | 2018-12-03T16:07:49 | 8688443343 | {"actor":{"display_login":"cavis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/support-frontend/pulls/comments/203004139","pull_request_review_id":137807166,"id":203004139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzAwNDEzOQ==","diff_hunk":"@@ -40,20 +40,14 @@ class CustomActionBuilders(\n // Prevents the identity validation email sending users back to our checkout.\n private val idSkipValidationReturn: (String, String) = \"skipValidationReturn\" -> \"true\"\n \n- private def idWebAppRegisterUrl(path: String, clientId: String, idWebAppRegisterPath: String, campaignCode: Option[String]): String =\n+ private def idWebAppRegisterUrl(path: String, clientId: String, idWebAppRegisterPath: String): String =\n idWebAppUrl / idWebAppRegisterPath ?\n (\"returnUrl\" -> s\"$supportUrl$path\") &\n idSkipConfirmation &\n idSkipValidationReturn &\n- \"clientId\" -> clientId &\n- \"INTCMP\" -> campaignCode\n-\n- def chooseRegister(identityClientId: String): RequestHeader => Result = request => {\n- SeeOther(idWebAppRegisterUrl(request.uri, identityClientId, \"register\", Some(\"recurring-contributions-control\")))\n- }\n-\n+ \"clientId\" -> clientId\n def chooseSignInStart(identityClientId: String): RequestHeader => Result = request => {","path":"app/actions/CustomActionBuilders.scala","position":18,"original_position":18,"commit_id":"c83f30cf000461257b65aa50f61eebd20cc6b77f","original_commit_id":"c83f30cf000461257b65aa50f61eebd20cc6b77f","user":{"login":"Ap0c","id":5131341,"node_id":"MDQ6VXNlcjUxMzEzNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/5131341?v=4","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"body":"Does it make sense to drop the word `choose` from the front of this method name?","created_at":"2018-07-17T12:40:39Z","updated_at":"2018-07-17T12:40:39Z","html_url":"https://github.com/guardian/support-frontend/pull/789#discussion_r203004139","pull_request_url":"https://api.github.com/repos/guardian/support-frontend/pulls/789","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/comments/203004139"},"html":{"href":"https://github.com/guardian/support-frontend/pull/789#discussion_r203004139"},"pull_request":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/789"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/support-frontend/pulls/789","id":201904333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTA0MzMz","html_url":"https://github.com/guardian/support-frontend/pull/789","diff_url":"https://github.com/guardian/support-frontend/pull/789.diff","patch_url":"https://github.com/guardian/support-frontend/pull/789.patch","issue_url":"https://api.github.com/repos/guardian/support-frontend/issues/789","number":789,"state":"open","locked":false,"title":"Default to new 2 step sign in flow","user":{"login":"jranks123","id":2844554,"node_id":"MDQ6VXNlcjI4NDQ1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2844554?v=4","gravatar_id":"","url":"https://api.github.com/users/jranks123","html_url":"https://github.com/jranks123","followers_url":"https://api.github.com/users/jranks123/followers","following_url":"https://api.github.com/users/jranks123/following{/other_user}","gists_url":"https://api.github.com/users/jranks123/gists{/gist_id}","starred_url":"https://api.github.com/users/jranks123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jranks123/subscriptions","organizations_url":"https://api.github.com/users/jranks123/orgs","repos_url":"https://api.github.com/users/jranks123/repos","events_url":"https://api.github.com/users/jranks123/events{/privacy}","received_events_url":"https://api.github.com/users/jranks123/received_events","type":"User","site_admin":false},"body":"## Why are you doing this?\r\nThe results of the [2 step sign in test](https://github.com/guardian/support-frontend/pull/739/files) came back and they were positive, so we are defaulting over to the new sign in url for the support platform. ","created_at":"2018-07-17T11:06:11Z","updated_at":"2018-07-17T12:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32dc88b8dfe3547f1a551ee3e9c2404feb1abe47","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JustinPinner","id":690395,"node_id":"MDQ6VXNlcjY5MDM5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/690395?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinPinner","html_url":"https://github.com/JustinPinner","followers_url":"https://api.github.com/users/JustinPinner/followers","following_url":"https://api.github.com/users/JustinPinner/following{/other_user}","gists_url":"https://api.github.com/users/JustinPinner/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinPinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinPinner/subscriptions","organizations_url":"https://api.github.com/users/JustinPinner/orgs","repos_url":"https://api.github.com/users/JustinPinner/repos","events_url":"https://api.github.com/users/JustinPinner/events{/privacy}","received_events_url":"https://api.github.com/users/JustinPinner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/support-frontend/pulls/789/commits","review_comments_url":"https://api.github.com/repos/guardian/support-frontend/pulls/789/comments","review_comment_url":"https://api.github.com/repos/guardian/support-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/support-frontend/issues/789/comments","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/c83f30cf000461257b65aa50f61eebd20cc6b77f","head":{"label":"guardian:jr-new-flow-yeah!","ref":"jr-new-flow-yeah!","sha":"c83f30cf000461257b65aa50f61eebd20cc6b77f","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":87204582,"node_id":"MDEwOlJlcG9zaXRvcnk4NzIwNDU4Mg==","name":"support-frontend","full_name":"guardian/support-frontend","owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/support-frontend","description":"Frontend for the Supporter platform","fork":false,"url":"https://api.github.com/repos/guardian/support-frontend","forks_url":"https://api.github.com/repos/guardian/support-frontend/forks","keys_url":"https://api.github.com/repos/guardian/support-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/support-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/support-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/support-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/support-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/support-frontend/events","assignees_url":"https://api.github.com/repos/guardian/support-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/support-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/support-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/support-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/support-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/support-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/support-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/support-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/support-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/support-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/support-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/support-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/support-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/support-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/support-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/support-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/support-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/support-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/support-frontend/merges","archive_url":"https://api.github.com/repos/guardian/support-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/support-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/support-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/support-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/support-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/support-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/support-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/support-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/support-frontend/deployments","created_at":"2017-04-04T15:37:12Z","updated_at":"2018-07-13T10:40:37Z","pushed_at":"2018-07-17T12:07:05Z","git_url":"git://github.com/guardian/support-frontend.git","ssh_url":"git@github.com:guardian/support-frontend.git","clone_url":"https://github.com/guardian/support-frontend.git","svn_url":"https://github.com/guardian/support-frontend","homepage":"https://support.theguardian.com/","size":5077,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"b3cd8f9b252aa10b7f02072f794d000f9a320a2e","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":87204582,"node_id":"MDEwOlJlcG9zaXRvcnk4NzIwNDU4Mg==","name":"support-frontend","full_name":"guardian/support-frontend","owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/support-frontend","description":"Frontend for the Supporter platform","fork":false,"url":"https://api.github.com/repos/guardian/support-frontend","forks_url":"https://api.github.com/repos/guardian/support-frontend/forks","keys_url":"https://api.github.com/repos/guardian/support-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/support-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/support-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/support-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/support-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/support-frontend/events","assignees_url":"https://api.github.com/repos/guardian/support-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/support-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/support-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/support-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/support-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/support-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/support-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/support-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/support-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/support-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/support-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/support-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/support-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/support-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/support-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/support-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/support-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/support-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/support-frontend/merges","archive_url":"https://api.github.com/repos/guardian/support-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/support-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/support-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/support-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/support-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/support-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/support-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/support-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/support-frontend/deployments","created_at":"2017-04-04T15:37:12Z","updated_at":"2018-07-13T10:40:37Z","pushed_at":"2018-07-17T12:07:05Z","git_url":"git://github.com/guardian/support-frontend.git","ssh_url":"git@github.com:guardian/support-frontend.git","clone_url":"https://github.com/guardian/support-frontend.git","svn_url":"https://github.com/guardian/support-frontend","homepage":"https://support.theguardian.com/","size":5077,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/789"},"html":{"href":"https://github.com/guardian/support-frontend/pull/789"},"issue":{"href":"https://api.github.com/repos/guardian/support-frontend/issues/789"},"comments":{"href":"https://api.github.com/repos/guardian/support-frontend/issues/789/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/789/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/789/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/support-frontend/statuses/c83f30cf000461257b65aa50f61eebd20cc6b77f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87204582,
"name": "guardian/support-frontend",
"url": "https://api.github.com/repos/guardian/support-frontend"
} | {
"id": 5131341,
"login": "Ap0c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5131341?",
"url": "https://api.github.com/users/Ap0c"
} | {
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
} | 2018-07-17T12:40:39 | 7976428476 | {"actor":{"display_login":"Ap0c"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/facia-tool/pulls/comments/171528811","pull_request_review_id":100394778,"id":171528811,"diff_hunk":"@@ -0,0 +1,5 @@\n+function isPlatformSpecificCollection(platform) {\n+ return platform === 'App' || platform === 'Web';","path":"public/src/js/utils/platform.js","position":2,"original_position":2,"commit_id":"848845de9676d07697a84e87811896fc150a18e7","original_commit_id":"848845de9676d07697a84e87811896fc150a18e7","user":{"login":"Reettaphant","id":3066534,"avatar_url":"https://avatars2.githubusercontent.com/u/3066534?v=4","gravatar_id":"","url":"https://api.github.com/users/Reettaphant","html_url":"https://github.com/Reettaphant","followers_url":"https://api.github.com/users/Reettaphant/followers","following_url":"https://api.github.com/users/Reettaphant/following{/other_user}","gists_url":"https://api.github.com/users/Reettaphant/gists{/gist_id}","starred_url":"https://api.github.com/users/Reettaphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reettaphant/subscriptions","organizations_url":"https://api.github.com/users/Reettaphant/orgs","repos_url":"https://api.github.com/users/Reettaphant/repos","events_url":"https://api.github.com/users/Reettaphant/events{/privacy}","received_events_url":"https://api.github.com/users/Reettaphant/received_events","type":"User","site_admin":false},"body":"These strings seem to be appearing in a few places - they could be defined in `/constants/defaults.js` for clarity","created_at":"2018-03-01T11:19:26Z","updated_at":"2018-03-01T11:24:35Z","html_url":"https://github.com/guardian/facia-tool/pull/273#discussion_r171528811","pull_request_url":"https://api.github.com/repos/guardian/facia-tool/pulls/273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/comments/171528811"},"html":{"href":"https://github.com/guardian/facia-tool/pull/273#discussion_r171528811"},"pull_request":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/facia-tool/pulls/273","id":172190119,"html_url":"https://github.com/guardian/facia-tool/pull/273","diff_url":"https://github.com/guardian/facia-tool/pull/273.diff","patch_url":"https://github.com/guardian/facia-tool/pull/273.patch","issue_url":"https://api.github.com/repos/guardian/facia-tool/issues/273","number":273,"state":"open","locked":false,"title":"Platform-specific collections","user":{"login":"tomrf1","id":1513454,"avatar_url":"https://avatars3.githubusercontent.com/u/1513454?v=4","gravatar_id":"","url":"https://api.github.com/users/tomrf1","html_url":"https://github.com/tomrf1","followers_url":"https://api.github.com/users/tomrf1/followers","following_url":"https://api.github.com/users/tomrf1/following{/other_user}","gists_url":"https://api.github.com/users/tomrf1/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrf1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrf1/subscriptions","organizations_url":"https://api.github.com/users/tomrf1/orgs","repos_url":"https://api.github.com/users/tomrf1/repos","events_url":"https://api.github.com/users/tomrf1/events{/privacy}","received_events_url":"https://api.github.com/users/tomrf1/received_events","type":"User","site_admin":false},"body":"Introduces Any/Web/App collections. A very simple implementation while we test app-only collections.\r\n\r\n1. Collections are Any by default.\r\n2. Does not allow an Any collection to exist with the same name as an App/Web collection. But there may be both an App and Web version of a collection.\r\n3. Does not allow App/Web collections to be dragged into other fronts.\r\n\r\nAn Any collection can be split into Web/App if it only belongs to one front:\r\n<img width=\"316\" alt=\"picture 6\" src=\"https://user-images.githubusercontent.com/1513454/36838293-b423298a-1d36-11e8-93bf-0cfae90d2b37.png\">\r\n\r\n<img width=\"608\" alt=\"picture 5\" src=\"https://user-images.githubusercontent.com/1513454/36838292-b40b15c0-1d36-11e8-96f8-206cd8d5467e.png\">\r\n\r\nA platform-specific collection can be reverted to an Any if it's the only one:\r\n<img width=\"353\" alt=\"picture 7\" src=\"https://user-images.githubusercontent.com/1513454/36838294-b467d4a4-1d36-11e8-8f46-f11a42db33f1.png\">\r\n\r\nWeb/App collections are indicated on the main page:\r\n<img width=\"618\" alt=\"picture 4\" src=\"https://user-images.githubusercontent.com/1513454/36838291-b3f0f136-1d36-11e8-9695-5008c4ea53d9.png\">\r\n","created_at":"2018-03-01T09:59:16Z","updated_at":"2018-03-01T11:24:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2039bff07079b7603c44ca1ee4afd4e0f2f9552","assignee":null,"assignees":[],"requested_reviewers":[{"login":"RichieAHB","id":1652187,"avatar_url":"https://avatars3.githubusercontent.com/u/1652187?v=4","gravatar_id":"","url":"https://api.github.com/users/RichieAHB","html_url":"https://github.com/RichieAHB","followers_url":"https://api.github.com/users/RichieAHB/followers","following_url":"https://api.github.com/users/RichieAHB/following{/other_user}","gists_url":"https://api.github.com/users/RichieAHB/gists{/gist_id}","starred_url":"https://api.github.com/users/RichieAHB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichieAHB/subscriptions","organizations_url":"https://api.github.com/users/RichieAHB/orgs","repos_url":"https://api.github.com/users/RichieAHB/repos","events_url":"https://api.github.com/users/RichieAHB/events{/privacy}","received_events_url":"https://api.github.com/users/RichieAHB/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/facia-tool/pulls/273/commits","review_comments_url":"https://api.github.com/repos/guardian/facia-tool/pulls/273/comments","review_comment_url":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/facia-tool/issues/273/comments","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/848845de9676d07697a84e87811896fc150a18e7","head":{"label":"guardian:platform-collections","ref":"platform-collections","sha":"848845de9676d07697a84e87811896fc150a18e7","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"name":"facia-tool","full_name":"guardian/facia-tool","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-tool/deployments","created_at":"2015-08-07T09:54:57Z","updated_at":"2016-10-26T13:06:10Z","pushed_at":"2018-03-01T09:59:17Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":349465,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"a7f5f1e3aec0166fb6b2fbd175ba575f8568809f","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":40353770,"name":"facia-tool","full_name":"guardian/facia-tool","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-tool","description":"Guardian front pages editor","fork":false,"url":"https://api.github.com/repos/guardian/facia-tool","forks_url":"https://api.github.com/repos/guardian/facia-tool/forks","keys_url":"https://api.github.com/repos/guardian/facia-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-tool/teams","hooks_url":"https://api.github.com/repos/guardian/facia-tool/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-tool/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-tool/events","assignees_url":"https://api.github.com/repos/guardian/facia-tool/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-tool/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-tool/tags","blobs_url":"https://api.github.com/repos/guardian/facia-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-tool/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-tool/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-tool/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-tool/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-tool/subscription","commits_url":"https://api.github.com/repos/guardian/facia-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-tool/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-tool/merges","archive_url":"https://api.github.com/repos/guardian/facia-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-tool/downloads","issues_url":"https://api.github.com/repos/guardian/facia-tool/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-tool/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-tool/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-tool/deployments","created_at":"2015-08-07T09:54:57Z","updated_at":"2016-10-26T13:06:10Z","pushed_at":"2018-03-01T09:59:17Z","git_url":"git://github.com/guardian/facia-tool.git","ssh_url":"git@github.com:guardian/facia-tool.git","clone_url":"https://github.com/guardian/facia-tool.git","svn_url":"https://github.com/guardian/facia-tool","homepage":null,"size":349465,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/273"},"html":{"href":"https://github.com/guardian/facia-tool/pull/273"},"issue":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/273"},"comments":{"href":"https://api.github.com/repos/guardian/facia-tool/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/facia-tool/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/facia-tool/statuses/848845de9676d07697a84e87811896fc150a18e7"}},"author_association":"MEMBER"}} | {
"id": 40353770,
"name": "guardian/facia-tool",
"url": "https://api.github.com/repos/guardian/facia-tool"
} | {
"id": 3066534,
"login": "Reettaphant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3066534?",
"url": "https://api.github.com/users/Reettaphant"
} | {
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
} | 2018-03-01T11:19:26 | 7315535362 | {"actor":{"display_login":"Reettaphant"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/magento/devdocs/pulls/comments/202862724","pull_request_review_id":137575685,"id":202862724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjg2MjcyNA==","diff_hunk":"@@ -60,10 +62,11 @@ The following conventions apply to MFTF tests:\n * All names within the framework are in the CamelCase format.\n * `<test>` name must be alphanumeric.\n * Each action and action group has its own identifier `<stepKey>` for reference purposes.\n-* A test may have any number of [assertions](./test/assertions.html), at any point within the `<test>`.\n-* If `<test>` is included in `<suite>`, it **cannot be generated in isolation** to the rest of the contents of the suite (see [suites](./suite.html) for details).\n+* A test may have any number of [assertions][assertion], at any point within the `<test>`.","path":"guides/v2.2/magento-functional-testing-framework/release-2/test.md","position":50,"original_position":50,"commit_id":"a7f74c116720f9de801d0ae47f78e0fd6af9cb45","original_commit_id":"b0982627a9796c27f9833619a48f53f997862104","user":{"login":"keharper","id":11652541,"node_id":"MDQ6VXNlcjExNjUyNTQx","avatar_url":"https://avatars3.githubusercontent.com/u/11652541?v=4","gravatar_id":"","url":"https://api.github.com/users/keharper","html_url":"https://github.com/keharper","followers_url":"https://api.github.com/users/keharper/followers","following_url":"https://api.github.com/users/keharper/following{/other_user}","gists_url":"https://api.github.com/users/keharper/gists{/gist_id}","starred_url":"https://api.github.com/users/keharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keharper/subscriptions","organizations_url":"https://api.github.com/users/keharper/orgs","repos_url":"https://api.github.com/users/keharper/repos","events_url":"https://api.github.com/users/keharper/events{/privacy}","received_events_url":"https://api.github.com/users/keharper/received_events","type":"User","site_admin":false},"body":"Delete comma","created_at":"2018-07-17T00:13:10Z","updated_at":"2018-07-17T00:30:16Z","html_url":"https://github.com/magento/devdocs/pull/2516#discussion_r202862724","pull_request_url":"https://api.github.com/repos/magento/devdocs/pulls/2516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/magento/devdocs/pulls/comments/202862724"},"html":{"href":"https://github.com/magento/devdocs/pull/2516#discussion_r202862724"},"pull_request":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2516"}}},"pull_request":{"url":"https://api.github.com/repos/magento/devdocs/pulls/2516","id":201694620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjk0NjIw","html_url":"https://github.com/magento/devdocs/pull/2516","diff_url":"https://github.com/magento/devdocs/pull/2516.diff","patch_url":"https://github.com/magento/devdocs/pull/2516.patch","issue_url":"https://api.github.com/repos/magento/devdocs/issues/2516","number":2516,"state":"open","locked":false,"title":"MFTF 2.3.0 documentation updates","user":{"login":"dshevtsov","id":12731225,"node_id":"MDQ6VXNlcjEyNzMxMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/12731225?v=4","gravatar_id":"","url":"https://api.github.com/users/dshevtsov","html_url":"https://github.com/dshevtsov","followers_url":"https://api.github.com/users/dshevtsov/followers","following_url":"https://api.github.com/users/dshevtsov/following{/other_user}","gists_url":"https://api.github.com/users/dshevtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/dshevtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshevtsov/subscriptions","organizations_url":"https://api.github.com/users/dshevtsov/orgs","repos_url":"https://api.github.com/users/dshevtsov/repos","events_url":"https://api.github.com/users/dshevtsov/events{/privacy}","received_events_url":"https://api.github.com/users/dshevtsov/received_events","type":"User","site_admin":false},"body":"<!-- (REQUIRED) What is the nature of this PR? -->\r\n## This PR is a:\r\n- [x] New topic\r\n- [x] Content fix or rewrite\r\n- [ ] Bug fix or improvement\r\n \r\n<!-- (REQUIRED) What does this PR change? -->\r\n## Summary\r\n \r\nWhen this pull request is merged, it will add documentation updates related to the MFTF 2.3.0 release.","created_at":"2018-07-16T16:41:18Z","updated_at":"2018-07-17T00:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b72ec257c89a697144a7c91642f6b84dbb761c1c","assignee":{"login":"dshevtsov","id":12731225,"node_id":"MDQ6VXNlcjEyNzMxMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/12731225?v=4","gravatar_id":"","url":"https://api.github.com/users/dshevtsov","html_url":"https://github.com/dshevtsov","followers_url":"https://api.github.com/users/dshevtsov/followers","following_url":"https://api.github.com/users/dshevtsov/following{/other_user}","gists_url":"https://api.github.com/users/dshevtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/dshevtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshevtsov/subscriptions","organizations_url":"https://api.github.com/users/dshevtsov/orgs","repos_url":"https://api.github.com/users/dshevtsov/repos","events_url":"https://api.github.com/users/dshevtsov/events{/privacy}","received_events_url":"https://api.github.com/users/dshevtsov/received_events","type":"User","site_admin":false},"assignees":[{"login":"dshevtsov","id":12731225,"node_id":"MDQ6VXNlcjEyNzMxMjI1","avatar_url":"https://avatars2.githubusercontent.com/u/12731225?v=4","gravatar_id":"","url":"https://api.github.com/users/dshevtsov","html_url":"https://github.com/dshevtsov","followers_url":"https://api.github.com/users/dshevtsov/followers","following_url":"https://api.github.com/users/dshevtsov/following{/other_user}","gists_url":"https://api.github.com/users/dshevtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/dshevtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshevtsov/subscriptions","organizations_url":"https://api.github.com/users/dshevtsov/orgs","repos_url":"https://api.github.com/users/dshevtsov/repos","events_url":"https://api.github.com/users/dshevtsov/events{/privacy}","received_events_url":"https://api.github.com/users/dshevtsov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":769999399,"node_id":"MDU6TGFiZWw3Njk5OTkzOTk=","url":"https://api.github.com/repos/magento/devdocs/labels/2.2.x","name":"2.2.x","color":"c5def5","default":false},{"id":872662021,"node_id":"MDU6TGFiZWw4NzI2NjIwMjE=","url":"https://api.github.com/repos/magento/devdocs/labels/2.3.x","name":"2.3.x","color":"c5def5","default":false},{"id":661804007,"node_id":"MDU6TGFiZWw2NjE4MDQwMDc=","url":"https://api.github.com/repos/magento/devdocs/labels/Major%20update","name":"Major update","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/devdocs/pulls/2516/commits","review_comments_url":"https://api.github.com/repos/magento/devdocs/pulls/2516/comments","review_comment_url":"https://api.github.com/repos/magento/devdocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/devdocs/issues/2516/comments","statuses_url":"https://api.github.com/repos/magento/devdocs/statuses/a7f74c116720f9de801d0ae47f78e0fd6af9cb45","head":{"label":"magento:pangolin-develop","ref":"pangolin-develop","sha":"a7f74c116720f9de801d0ae47f78e0fd6af9cb45","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":17608126,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwODEyNg==","name":"devdocs","full_name":"magento/devdocs","owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/devdocs","description":"Magento Developer Documentation","fork":false,"url":"https://api.github.com/repos/magento/devdocs","forks_url":"https://api.github.com/repos/magento/devdocs/forks","keys_url":"https://api.github.com/repos/magento/devdocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/devdocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/devdocs/teams","hooks_url":"https://api.github.com/repos/magento/devdocs/hooks","issue_events_url":"https://api.github.com/repos/magento/devdocs/issues/events{/number}","events_url":"https://api.github.com/repos/magento/devdocs/events","assignees_url":"https://api.github.com/repos/magento/devdocs/assignees{/user}","branches_url":"https://api.github.com/repos/magento/devdocs/branches{/branch}","tags_url":"https://api.github.com/repos/magento/devdocs/tags","blobs_url":"https://api.github.com/repos/magento/devdocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/devdocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/devdocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/devdocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/devdocs/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/devdocs/languages","stargazers_url":"https://api.github.com/repos/magento/devdocs/stargazers","contributors_url":"https://api.github.com/repos/magento/devdocs/contributors","subscribers_url":"https://api.github.com/repos/magento/devdocs/subscribers","subscription_url":"https://api.github.com/repos/magento/devdocs/subscription","commits_url":"https://api.github.com/repos/magento/devdocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/devdocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/devdocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/devdocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/devdocs/contents/{+path}","compare_url":"https://api.github.com/repos/magento/devdocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/devdocs/merges","archive_url":"https://api.github.com/repos/magento/devdocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/devdocs/downloads","issues_url":"https://api.github.com/repos/magento/devdocs/issues{/number}","pulls_url":"https://api.github.com/repos/magento/devdocs/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/devdocs/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/devdocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/devdocs/labels{/name}","releases_url":"https://api.github.com/repos/magento/devdocs/releases{/id}","deployments_url":"https://api.github.com/repos/magento/devdocs/deployments","created_at":"2014-03-10T20:54:08Z","updated_at":"2018-07-16T20:00:33Z","pushed_at":"2018-07-16T20:54:44Z","git_url":"git://github.com/magento/devdocs.git","ssh_url":"git@github.com:magento/devdocs.git","clone_url":"https://github.com/magento/devdocs.git","svn_url":"https://github.com/magento/devdocs","homepage":"http://devdocs.magento.com","size":597053,"stargazers_count":333,"watchers_count":333,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":152,"license":null,"forks":893,"open_issues":152,"watchers":333,"default_branch":"master"}},"base":{"label":"magento:master","ref":"master","sha":"06b688b91b3c87ccb2ba3ea048e39a284ffcbd56","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":17608126,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwODEyNg==","name":"devdocs","full_name":"magento/devdocs","owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/devdocs","description":"Magento Developer Documentation","fork":false,"url":"https://api.github.com/repos/magento/devdocs","forks_url":"https://api.github.com/repos/magento/devdocs/forks","keys_url":"https://api.github.com/repos/magento/devdocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/devdocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/devdocs/teams","hooks_url":"https://api.github.com/repos/magento/devdocs/hooks","issue_events_url":"https://api.github.com/repos/magento/devdocs/issues/events{/number}","events_url":"https://api.github.com/repos/magento/devdocs/events","assignees_url":"https://api.github.com/repos/magento/devdocs/assignees{/user}","branches_url":"https://api.github.com/repos/magento/devdocs/branches{/branch}","tags_url":"https://api.github.com/repos/magento/devdocs/tags","blobs_url":"https://api.github.com/repos/magento/devdocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/devdocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/devdocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/devdocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/devdocs/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/devdocs/languages","stargazers_url":"https://api.github.com/repos/magento/devdocs/stargazers","contributors_url":"https://api.github.com/repos/magento/devdocs/contributors","subscribers_url":"https://api.github.com/repos/magento/devdocs/subscribers","subscription_url":"https://api.github.com/repos/magento/devdocs/subscription","commits_url":"https://api.github.com/repos/magento/devdocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/devdocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/devdocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/devdocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/devdocs/contents/{+path}","compare_url":"https://api.github.com/repos/magento/devdocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/devdocs/merges","archive_url":"https://api.github.com/repos/magento/devdocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/devdocs/downloads","issues_url":"https://api.github.com/repos/magento/devdocs/issues{/number}","pulls_url":"https://api.github.com/repos/magento/devdocs/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/devdocs/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/devdocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/devdocs/labels{/name}","releases_url":"https://api.github.com/repos/magento/devdocs/releases{/id}","deployments_url":"https://api.github.com/repos/magento/devdocs/deployments","created_at":"2014-03-10T20:54:08Z","updated_at":"2018-07-16T20:00:33Z","pushed_at":"2018-07-16T20:54:44Z","git_url":"git://github.com/magento/devdocs.git","ssh_url":"git@github.com:magento/devdocs.git","clone_url":"https://github.com/magento/devdocs.git","svn_url":"https://github.com/magento/devdocs","homepage":"http://devdocs.magento.com","size":597053,"stargazers_count":333,"watchers_count":333,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":152,"license":null,"forks":893,"open_issues":152,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2516"},"html":{"href":"https://github.com/magento/devdocs/pull/2516"},"issue":{"href":"https://api.github.com/repos/magento/devdocs/issues/2516"},"comments":{"href":"https://api.github.com/repos/magento/devdocs/issues/2516/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2516/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/devdocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2516/commits"},"statuses":{"href":"https://api.github.com/repos/magento/devdocs/statuses/a7f74c116720f9de801d0ae47f78e0fd6af9cb45"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17608126,
"name": "magento/devdocs",
"url": "https://api.github.com/repos/magento/devdocs"
} | {
"id": 11652541,
"login": "keharper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11652541?",
"url": "https://api.github.com/users/keharper"
} | {
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
} | 2018-07-17T00:13:10 | 7973668001 | {"actor":{"display_login":"keharper"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/comments/173181362","pull_request_review_id":102326538,"id":173181362,"diff_hunk":"@@ -88,6 +91,43 @@ def list_options_specs():\n yield OptionSpec(s, 'destination', default='/dev/log')\n \n \n+class PluginManager(object):\n+ def __init__(self, config=None):\n+ self.config = config\n+ self.plugins = {}\n+\n+ def fetch_plugins(self):\n+ unloaded_names = filter(\n+ lambda name: name not in self.config.plugins,\n+ self.config.temboard.plugins\n+ )\n+ for name in unloaded_names:\n+ logger.debug(\"Looking for plugin %s.\", name)\n+ for ep in iter_entry_points('temboardagent.plugins', name):\n+ logger.info(\"Found plugin %s.\", ep)\n+ yield ep\n+ self.config.plugins.pop(name, None)\n+ break\n+ else:\n+ raise ConfigurationError(\"Missing plugin: %s.\" % (name,))\n+\n+ def load_plugins(self, entrypoints):\n+ for ep in entrypoints:\n+ try:\n+ cls = ep.load()\n+ except Exception:\n+ logger.exception(\"Error while loading %s.\", ep)\n+ raise ConfigurationError(\"Failed to load %s.\" % (ep.name,))\n+ else:\n+ self.plugins[ep.name] = cls()\n+\n+\n+def load_plugins(config):\n+ manager = PluginManager(config)\n+ manager.load_plugins(manager.fetch_plugins())\n+ return manager\n+\n+","path":"temboardagent/scripts/agent.py","position":67,"original_position":67,"commit_id":"b43d3e1cacff67dfaf7de1666ad5d4e82d98731f","original_commit_id":"b43d3e1cacff67dfaf7de1666ad5d4e82d98731f","user":{"login":"julmon","id":920753,"avatar_url":"https://avatars2.githubusercontent.com/u/920753?v=4","gravatar_id":"","url":"https://api.github.com/users/julmon","html_url":"https://github.com/julmon","followers_url":"https://api.github.com/users/julmon/followers","following_url":"https://api.github.com/users/julmon/following{/other_user}","gists_url":"https://api.github.com/users/julmon/gists{/gist_id}","starred_url":"https://api.github.com/users/julmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julmon/subscriptions","organizations_url":"https://api.github.com/users/julmon/orgs","repos_url":"https://api.github.com/users/julmon/repos","events_url":"https://api.github.com/users/julmon/events{/privacy}","received_events_url":"https://api.github.com/users/julmon/received_events","type":"User","site_admin":false},"body":"Is it the right place for this class definition ?","created_at":"2018-03-08T14:54:45Z","updated_at":"2018-03-08T15:01:00Z","html_url":"https://github.com/dalibo/temboard-agent/pull/136#discussion_r173181362","pull_request_url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/comments/173181362"},"html":{"href":"https://github.com/dalibo/temboard-agent/pull/136#discussion_r173181362"},"pull_request":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136","id":173168242,"html_url":"https://github.com/dalibo/temboard-agent/pull/136","diff_url":"https://github.com/dalibo/temboard-agent/pull/136.diff","patch_url":"https://github.com/dalibo/temboard-agent/pull/136.patch","issue_url":"https://api.github.com/repos/dalibo/temboard-agent/issues/136","number":136,"state":"open","locked":false,"title":"New plugin infrastructure","user":{"login":"bersace","id":542613,"avatar_url":"https://avatars1.githubusercontent.com/u/542613?v=4","gravatar_id":"","url":"https://api.github.com/users/bersace","html_url":"https://github.com/bersace","followers_url":"https://api.github.com/users/bersace/followers","following_url":"https://api.github.com/users/bersace/following{/other_user}","gists_url":"https://api.github.com/users/bersace/gists{/gist_id}","starred_url":"https://api.github.com/users/bersace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bersace/subscriptions","organizations_url":"https://api.github.com/users/bersace/orgs","repos_url":"https://api.github.com/users/bersace/repos","events_url":"https://api.github.com/users/bersace/events{/privacy}","received_events_url":"https://api.github.com/users/bersace/received_events","type":"User","site_admin":false},"body":"cf. #131 \r\n\r\nWith this PR :\r\n\r\n- temboardagent loads a plugin either new or legacy\r\n- A missing plugin triggers a fatal error. This may be a typo\r\n- A sample **external** plugin is available to test.\r\n\r\nWhat's not yet here:\r\n\r\n- extending configuration\r\n- hot unload\r\n- compatibility check from plugin","created_at":"2018-03-06T14:09:20Z","updated_at":"2018-03-08T15:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32dbd20387f400a7696d40674ee7a4fd7daece4c","assignee":{"login":"bersace","id":542613,"avatar_url":"https://avatars1.githubusercontent.com/u/542613?v=4","gravatar_id":"","url":"https://api.github.com/users/bersace","html_url":"https://github.com/bersace","followers_url":"https://api.github.com/users/bersace/followers","following_url":"https://api.github.com/users/bersace/following{/other_user}","gists_url":"https://api.github.com/users/bersace/gists{/gist_id}","starred_url":"https://api.github.com/users/bersace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bersace/subscriptions","organizations_url":"https://api.github.com/users/bersace/orgs","repos_url":"https://api.github.com/users/bersace/repos","events_url":"https://api.github.com/users/bersace/events{/privacy}","received_events_url":"https://api.github.com/users/bersace/received_events","type":"User","site_admin":false},"assignees":[{"login":"bersace","id":542613,"avatar_url":"https://avatars1.githubusercontent.com/u/542613?v=4","gravatar_id":"","url":"https://api.github.com/users/bersace","html_url":"https://github.com/bersace","followers_url":"https://api.github.com/users/bersace/followers","following_url":"https://api.github.com/users/bersace/following{/other_user}","gists_url":"https://api.github.com/users/bersace/gists{/gist_id}","starred_url":"https://api.github.com/users/bersace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bersace/subscriptions","organizations_url":"https://api.github.com/users/bersace/orgs","repos_url":"https://api.github.com/users/bersace/repos","events_url":"https://api.github.com/users/bersace/events{/privacy}","received_events_url":"https://api.github.com/users/bersace/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136/commits","review_comments_url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136/comments","review_comment_url":"https://api.github.com/repos/dalibo/temboard-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dalibo/temboard-agent/issues/136/comments","statuses_url":"https://api.github.com/repos/dalibo/temboard-agent/statuses/b43d3e1cacff67dfaf7de1666ad5d4e82d98731f","head":{"label":"bersace:plugins","ref":"plugins","sha":"b43d3e1cacff67dfaf7de1666ad5d4e82d98731f","user":{"login":"bersace","id":542613,"avatar_url":"https://avatars1.githubusercontent.com/u/542613?v=4","gravatar_id":"","url":"https://api.github.com/users/bersace","html_url":"https://github.com/bersace","followers_url":"https://api.github.com/users/bersace/followers","following_url":"https://api.github.com/users/bersace/following{/other_user}","gists_url":"https://api.github.com/users/bersace/gists{/gist_id}","starred_url":"https://api.github.com/users/bersace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bersace/subscriptions","organizations_url":"https://api.github.com/users/bersace/orgs","repos_url":"https://api.github.com/users/bersace/repos","events_url":"https://api.github.com/users/bersace/events{/privacy}","received_events_url":"https://api.github.com/users/bersace/received_events","type":"User","site_admin":false},"repo":{"id":86347461,"name":"temboard-agent","full_name":"bersace/temboard-agent","owner":{"login":"bersace","id":542613,"avatar_url":"https://avatars1.githubusercontent.com/u/542613?v=4","gravatar_id":"","url":"https://api.github.com/users/bersace","html_url":"https://github.com/bersace","followers_url":"https://api.github.com/users/bersace/followers","following_url":"https://api.github.com/users/bersace/following{/other_user}","gists_url":"https://api.github.com/users/bersace/gists{/gist_id}","starred_url":"https://api.github.com/users/bersace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bersace/subscriptions","organizations_url":"https://api.github.com/users/bersace/orgs","repos_url":"https://api.github.com/users/bersace/repos","events_url":"https://api.github.com/users/bersace/events{/privacy}","received_events_url":"https://api.github.com/users/bersace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bersace/temboard-agent","description":"PostgreSQL Remote Control agent","fork":true,"url":"https://api.github.com/repos/bersace/temboard-agent","forks_url":"https://api.github.com/repos/bersace/temboard-agent/forks","keys_url":"https://api.github.com/repos/bersace/temboard-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bersace/temboard-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bersace/temboard-agent/teams","hooks_url":"https://api.github.com/repos/bersace/temboard-agent/hooks","issue_events_url":"https://api.github.com/repos/bersace/temboard-agent/issues/events{/number}","events_url":"https://api.github.com/repos/bersace/temboard-agent/events","assignees_url":"https://api.github.com/repos/bersace/temboard-agent/assignees{/user}","branches_url":"https://api.github.com/repos/bersace/temboard-agent/branches{/branch}","tags_url":"https://api.github.com/repos/bersace/temboard-agent/tags","blobs_url":"https://api.github.com/repos/bersace/temboard-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bersace/temboard-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bersace/temboard-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/bersace/temboard-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bersace/temboard-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/bersace/temboard-agent/languages","stargazers_url":"https://api.github.com/repos/bersace/temboard-agent/stargazers","contributors_url":"https://api.github.com/repos/bersace/temboard-agent/contributors","subscribers_url":"https://api.github.com/repos/bersace/temboard-agent/subscribers","subscription_url":"https://api.github.com/repos/bersace/temboard-agent/subscription","commits_url":"https://api.github.com/repos/bersace/temboard-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/bersace/temboard-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/bersace/temboard-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/bersace/temboard-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/bersace/temboard-agent/contents/{+path}","compare_url":"https://api.github.com/repos/bersace/temboard-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bersace/temboard-agent/merges","archive_url":"https://api.github.com/repos/bersace/temboard-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bersace/temboard-agent/downloads","issues_url":"https://api.github.com/repos/bersace/temboard-agent/issues{/number}","pulls_url":"https://api.github.com/repos/bersace/temboard-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/bersace/temboard-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/bersace/temboard-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bersace/temboard-agent/labels{/name}","releases_url":"https://api.github.com/repos/bersace/temboard-agent/releases{/id}","deployments_url":"https://api.github.com/repos/bersace/temboard-agent/deployments","created_at":"2017-03-27T14:47:05Z","updated_at":"2017-03-27T14:47:08Z","pushed_at":"2018-03-06T16:49:34Z","git_url":"git://github.com/bersace/temboard-agent.git","ssh_url":"git@github.com:bersace/temboard-agent.git","clone_url":"https://github.com/bersace/temboard-agent.git","svn_url":"https://github.com/bersace/temboard-agent","homepage":null,"size":866,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dalibo:master","ref":"master","sha":"ed2514747a6a2430ad1dcbc7e49de980557a338c","user":{"login":"dalibo","id":182275,"avatar_url":"https://avatars1.githubusercontent.com/u/182275?v=4","gravatar_id":"","url":"https://api.github.com/users/dalibo","html_url":"https://github.com/dalibo","followers_url":"https://api.github.com/users/dalibo/followers","following_url":"https://api.github.com/users/dalibo/following{/other_user}","gists_url":"https://api.github.com/users/dalibo/gists{/gist_id}","starred_url":"https://api.github.com/users/dalibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalibo/subscriptions","organizations_url":"https://api.github.com/users/dalibo/orgs","repos_url":"https://api.github.com/users/dalibo/repos","events_url":"https://api.github.com/users/dalibo/events{/privacy}","received_events_url":"https://api.github.com/users/dalibo/received_events","type":"Organization","site_admin":false},"repo":{"id":86312072,"name":"temboard-agent","full_name":"dalibo/temboard-agent","owner":{"login":"dalibo","id":182275,"avatar_url":"https://avatars1.githubusercontent.com/u/182275?v=4","gravatar_id":"","url":"https://api.github.com/users/dalibo","html_url":"https://github.com/dalibo","followers_url":"https://api.github.com/users/dalibo/followers","following_url":"https://api.github.com/users/dalibo/following{/other_user}","gists_url":"https://api.github.com/users/dalibo/gists{/gist_id}","starred_url":"https://api.github.com/users/dalibo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalibo/subscriptions","organizations_url":"https://api.github.com/users/dalibo/orgs","repos_url":"https://api.github.com/users/dalibo/repos","events_url":"https://api.github.com/users/dalibo/events{/privacy}","received_events_url":"https://api.github.com/users/dalibo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dalibo/temboard-agent","description":"PostgreSQL Remote Control agent","fork":false,"url":"https://api.github.com/repos/dalibo/temboard-agent","forks_url":"https://api.github.com/repos/dalibo/temboard-agent/forks","keys_url":"https://api.github.com/repos/dalibo/temboard-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalibo/temboard-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalibo/temboard-agent/teams","hooks_url":"https://api.github.com/repos/dalibo/temboard-agent/hooks","issue_events_url":"https://api.github.com/repos/dalibo/temboard-agent/issues/events{/number}","events_url":"https://api.github.com/repos/dalibo/temboard-agent/events","assignees_url":"https://api.github.com/repos/dalibo/temboard-agent/assignees{/user}","branches_url":"https://api.github.com/repos/dalibo/temboard-agent/branches{/branch}","tags_url":"https://api.github.com/repos/dalibo/temboard-agent/tags","blobs_url":"https://api.github.com/repos/dalibo/temboard-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalibo/temboard-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalibo/temboard-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalibo/temboard-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalibo/temboard-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/dalibo/temboard-agent/languages","stargazers_url":"https://api.github.com/repos/dalibo/temboard-agent/stargazers","contributors_url":"https://api.github.com/repos/dalibo/temboard-agent/contributors","subscribers_url":"https://api.github.com/repos/dalibo/temboard-agent/subscribers","subscription_url":"https://api.github.com/repos/dalibo/temboard-agent/subscription","commits_url":"https://api.github.com/repos/dalibo/temboard-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalibo/temboard-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalibo/temboard-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalibo/temboard-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalibo/temboard-agent/contents/{+path}","compare_url":"https://api.github.com/repos/dalibo/temboard-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalibo/temboard-agent/merges","archive_url":"https://api.github.com/repos/dalibo/temboard-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalibo/temboard-agent/downloads","issues_url":"https://api.github.com/repos/dalibo/temboard-agent/issues{/number}","pulls_url":"https://api.github.com/repos/dalibo/temboard-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/dalibo/temboard-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/dalibo/temboard-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalibo/temboard-agent/labels{/name}","releases_url":"https://api.github.com/repos/dalibo/temboard-agent/releases{/id}","deployments_url":"https://api.github.com/repos/dalibo/temboard-agent/deployments","created_at":"2017-03-27T08:46:24Z","updated_at":"2018-01-05T12:58:41Z","pushed_at":"2018-03-08T14:51:17Z","git_url":"git://github.com/dalibo/temboard-agent.git","ssh_url":"git@github.com:dalibo/temboard-agent.git","clone_url":"https://github.com/dalibo/temboard-agent.git","svn_url":"https://github.com/dalibo/temboard-agent","homepage":null,"size":842,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136"},"html":{"href":"https://github.com/dalibo/temboard-agent/pull/136"},"issue":{"href":"https://api.github.com/repos/dalibo/temboard-agent/issues/136"},"comments":{"href":"https://api.github.com/repos/dalibo/temboard-agent/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dalibo/temboard-agent/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/dalibo/temboard-agent/statuses/b43d3e1cacff67dfaf7de1666ad5d4e82d98731f"}},"author_association":"MEMBER"}} | {
"id": 86312072,
"name": "dalibo/temboard-agent",
"url": "https://api.github.com/repos/dalibo/temboard-agent"
} | {
"id": 920753,
"login": "julmon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/920753?",
"url": "https://api.github.com/users/julmon"
} | {
"id": 182275,
"login": "dalibo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/182275?",
"url": "https://api.github.com/orgs/dalibo"
} | 2018-03-08T14:54:45 | 7350663823 | {"actor":{"display_login":"julmon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/comments/230852907","pull_request_review_id":171685456,"id":230852907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDg1MjkwNw==","diff_hunk":"@@ -16,36 +16,46 @@ Adjust RAM to match your latency requirements and the size and number of simulta\n \n == Minimum Software Requirements\n \n-Mule requires minimum software resources:\n+Mule requires the following minimum software resources:\n \n-* Supported Java versions:\n+* One of the following supported Java versions:\n++\n+** Oracle JDK 1.8.0 (JDK 1.8.0_161 recommended). \n++\n+[NOTE]\n+If you run a Standalone instance of Mule and Anypoint Studio freezes during start up, check to see if the JDK where Studio is installed is 1.8 Update 152 (1.8.0_152). If it is, downgrade to 1.8.0_151 to correct the problem.","path":"modules/ROOT/pages/hardware-and-software-requirements.adoc","position":34,"original_position":28,"commit_id":"e681f6b3124e57ef2bb4afdb49dd0dd56ccbfb58","original_commit_id":"e681f6b3124e57ef2bb4afdb49dd0dd56ccbfb58","user":{"login":"Mulesoft-Mysti","id":39537186,"node_id":"MDQ6VXNlcjM5NTM3MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/39537186?v=4","gravatar_id":"","url":"https://api.github.com/users/Mulesoft-Mysti","html_url":"https://github.com/Mulesoft-Mysti","followers_url":"https://api.github.com/users/Mulesoft-Mysti/followers","following_url":"https://api.github.com/users/Mulesoft-Mysti/following{/other_user}","gists_url":"https://api.github.com/users/Mulesoft-Mysti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mulesoft-Mysti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mulesoft-Mysti/subscriptions","organizations_url":"https://api.github.com/users/Mulesoft-Mysti/orgs","repos_url":"https://api.github.com/users/Mulesoft-Mysti/repos","events_url":"https://api.github.com/users/Mulesoft-Mysti/events{/privacy}","received_events_url":"https://api.github.com/users/Mulesoft-Mysti/received_events","type":"User","site_admin":false},"body":"@dukesphere I don't understand what you're asking me to do in the last two notes.","created_at":"2018-11-05T18:05:31Z","updated_at":"2018-11-05T18:05:32Z","html_url":"https://github.com/mulesoft/docs-mule-runtime/pull/106#discussion_r230852907","pull_request_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/comments/230852907"},"html":{"href":"https://github.com/mulesoft/docs-mule-runtime/pull/106#discussion_r230852907"},"pull_request":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106"}},"in_reply_to_id":229816502},"pull_request":{"url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106","id":227091724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDkxNzI0","html_url":"https://github.com/mulesoft/docs-mule-runtime/pull/106","diff_url":"https://github.com/mulesoft/docs-mule-runtime/pull/106.diff","patch_url":"https://github.com/mulesoft/docs-mule-runtime/pull/106.patch","issue_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/106","number":106,"state":"open","locked":false,"title":"hardware and software updates","user":{"login":"Mulesoft-Mysti","id":39537186,"node_id":"MDQ6VXNlcjM5NTM3MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/39537186?v=4","gravatar_id":"","url":"https://api.github.com/users/Mulesoft-Mysti","html_url":"https://github.com/Mulesoft-Mysti","followers_url":"https://api.github.com/users/Mulesoft-Mysti/followers","following_url":"https://api.github.com/users/Mulesoft-Mysti/following{/other_user}","gists_url":"https://api.github.com/users/Mulesoft-Mysti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mulesoft-Mysti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mulesoft-Mysti/subscriptions","organizations_url":"https://api.github.com/users/Mulesoft-Mysti/orgs","repos_url":"https://api.github.com/users/Mulesoft-Mysti/repos","events_url":"https://api.github.com/users/Mulesoft-Mysti/events{/privacy}","received_events_url":"https://api.github.com/users/Mulesoft-Mysti/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-30T21:43:20Z","updated_at":"2018-11-05T18:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0cba9fa954be5eac7d6330976da5c6cecce79de","assignee":{"login":"Mulesoft-Mysti","id":39537186,"node_id":"MDQ6VXNlcjM5NTM3MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/39537186?v=4","gravatar_id":"","url":"https://api.github.com/users/Mulesoft-Mysti","html_url":"https://github.com/Mulesoft-Mysti","followers_url":"https://api.github.com/users/Mulesoft-Mysti/followers","following_url":"https://api.github.com/users/Mulesoft-Mysti/following{/other_user}","gists_url":"https://api.github.com/users/Mulesoft-Mysti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mulesoft-Mysti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mulesoft-Mysti/subscriptions","organizations_url":"https://api.github.com/users/Mulesoft-Mysti/orgs","repos_url":"https://api.github.com/users/Mulesoft-Mysti/repos","events_url":"https://api.github.com/users/Mulesoft-Mysti/events{/privacy}","received_events_url":"https://api.github.com/users/Mulesoft-Mysti/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mulesoft-Mysti","id":39537186,"node_id":"MDQ6VXNlcjM5NTM3MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/39537186?v=4","gravatar_id":"","url":"https://api.github.com/users/Mulesoft-Mysti","html_url":"https://github.com/Mulesoft-Mysti","followers_url":"https://api.github.com/users/Mulesoft-Mysti/followers","following_url":"https://api.github.com/users/Mulesoft-Mysti/following{/other_user}","gists_url":"https://api.github.com/users/Mulesoft-Mysti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mulesoft-Mysti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mulesoft-Mysti/subscriptions","organizations_url":"https://api.github.com/users/Mulesoft-Mysti/orgs","repos_url":"https://api.github.com/users/Mulesoft-Mysti/repos","events_url":"https://api.github.com/users/Mulesoft-Mysti/events{/privacy}","received_events_url":"https://api.github.com/users/Mulesoft-Mysti/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106/commits","review_comments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106/comments","review_comment_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/106/comments","statuses_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/statuses/e681f6b3124e57ef2bb4afdb49dd0dd56ccbfb58","head":{"label":"mulesoft:DOCS-3000-mb","ref":"DOCS-3000-mb","sha":"e681f6b3124e57ef2bb4afdb49dd0dd56ccbfb58","user":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"repo":{"id":99282259,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI4MjI1OQ==","name":"docs-mule-runtime","full_name":"mulesoft/docs-mule-runtime","private":false,"owner":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mulesoft/docs-mule-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/mulesoft/docs-mule-runtime","forks_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/forks","keys_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/teams","hooks_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/hooks","issue_events_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/events","assignees_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/tags","blobs_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/languages","stargazers_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/stargazers","contributors_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/contributors","subscribers_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/subscribers","subscription_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/subscription","commits_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/merges","archive_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/downloads","issues_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/labels{/name}","releases_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/deployments","created_at":"2017-08-03T23:10:12Z","updated_at":"2018-10-26T14:45:27Z","pushed_at":"2018-11-05T10:35:21Z","git_url":"git://github.com/mulesoft/docs-mule-runtime.git","ssh_url":"git@github.com:mulesoft/docs-mule-runtime.git","clone_url":"https://github.com/mulesoft/docs-mule-runtime.git","svn_url":"https://github.com/mulesoft/docs-mule-runtime","homepage":null,"size":128236,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":17,"open_issues":19,"watchers":0,"default_branch":"latest"}},"base":{"label":"mulesoft:latest","ref":"latest","sha":"3236b26366d9ddce45bee309519cc9eef7add06c","user":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"repo":{"id":99282259,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI4MjI1OQ==","name":"docs-mule-runtime","full_name":"mulesoft/docs-mule-runtime","private":false,"owner":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mulesoft/docs-mule-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/mulesoft/docs-mule-runtime","forks_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/forks","keys_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/teams","hooks_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/hooks","issue_events_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/events","assignees_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/tags","blobs_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/languages","stargazers_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/stargazers","contributors_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/contributors","subscribers_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/subscribers","subscription_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/subscription","commits_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/merges","archive_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/downloads","issues_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/labels{/name}","releases_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/mulesoft/docs-mule-runtime/deployments","created_at":"2017-08-03T23:10:12Z","updated_at":"2018-10-26T14:45:27Z","pushed_at":"2018-11-05T10:35:21Z","git_url":"git://github.com/mulesoft/docs-mule-runtime.git","ssh_url":"git@github.com:mulesoft/docs-mule-runtime.git","clone_url":"https://github.com/mulesoft/docs-mule-runtime.git","svn_url":"https://github.com/mulesoft/docs-mule-runtime","homepage":null,"size":128236,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":17,"open_issues":19,"watchers":0,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106"},"html":{"href":"https://github.com/mulesoft/docs-mule-runtime/pull/106"},"issue":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/106"},"comments":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/mulesoft/docs-mule-runtime/statuses/e681f6b3124e57ef2bb4afdb49dd0dd56ccbfb58"}},"author_association":"NONE"}} | {
"id": 99282259,
"name": "mulesoft/docs-mule-runtime",
"url": "https://api.github.com/repos/mulesoft/docs-mule-runtime"
} | {
"id": 39537186,
"login": "Mulesoft-Mysti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39537186?",
"url": "https://api.github.com/users/Mulesoft-Mysti"
} | {
"id": 185740,
"login": "mulesoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/185740?",
"url": "https://api.github.com/orgs/mulesoft"
} | 2018-11-05T18:05:31 | 8537488107 | {"actor":{"display_login":"Mulesoft-Mysti"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174861094","pull_request_review_id":104296908,"id":174861094,"diff_hunk":"@@ -19,73 +19,153 @@\n */\n package org.neo4j.cypher.internal.compiler.v3_4\n \n+import java.time.{ZoneId, ZoneOffset}\n+\n import org.neo4j.cypher.ExecutionEngineFunSuite\n+import org.neo4j.values.storable._\n import org.scalacheck.Gen\n+import org.scalacheck.Arbitrary.arbitrary\n import org.scalatest.prop.PropertyChecks\n \n+import scala.collection.JavaConversions._\n+\n class SemanticIndexAcceptanceTest extends ExecutionEngineFunSuite with PropertyChecks {\n \n- //the actual test\n- List(\"<\", \"<=\", \"=\", \">\", \">=\").foreach(testOperator)\n+ private val allCRS: Map[Int, Array[CoordinateReferenceSystem]] = CoordinateReferenceSystem.all().toArray.groupBy(_.getDimension)\n+ private val allCRSDimensions = allCRS.keys.toArray\n+ private val oneDay = DurationValue.duration(0, 1, 0, 0)\n+ private val oneSecond = DurationValue.duration(0, 0, 1, 0)\n+ private val timeZones:Seq[ZoneId] = ZoneId.getAvailableZoneIds.toSeq.map(ZoneId.of)\n+\n+ // ----------------\n+ // the actual test\n+ // ----------------\n+\n+ for {\n+ valueGen <- List(\n+ ValueSetup[LongValue](\"longs\", longGen, x => x.minus(1L), x => x.plus(1L)),\n+ ValueSetup[DoubleValue](\"doubles\", doubleGen, x => x.minus(0.1), x => x.plus(0.1)),\n+ ValueSetup[TextValue](\"strings\", textGen, changeLastChar(c => (c - 1).toChar), changeLastChar(c => (c + 1).toChar)),\n+// ValueSetup[PointValue](\"points\", pointGen, modifyPoint(_ - 0.1), modifyPoint(_ + 0.1)), // TODO: here is a bug\n+ ValueSetup[DateValue](\"dates\", dateGen, x => x.sub(oneDay), x => x.add(oneDay)),\n+ ValueSetup[DateTimeValue](\"dateTimes\", dateTimeGen, x => x.sub(oneDay), x => x.add(oneDay)),\n+ ValueSetup[LocalDateTimeValue](\"localDateTimes\", localDateTimeGen, x => x.sub(oneDay), x => x.add(oneDay)),\n+ ValueSetup[TimeValue](\"times\", timeGen, x => x.sub(oneSecond), x => x.add(oneSecond)),\n+ ValueSetup[LocalTimeValue](\"localTimes\", localTimeGen, x => x.sub(oneSecond), x => x.add(oneSecond))\n+ )\n+ bound <- List(\"<\", \"<=\", \"=\", \">\", \">=\")\n+ } {\n+ testOperator(bound, valueGen)\n+ }\n \n override protected def initTest(): Unit = {\n super.initTest()\n for(_ <- 1 to 1000) createLabeledNode(\"Label\")\n }\n \n- private def changeLastChar(f: Char => Char)(in: String) =\n- if (in.isEmpty) \"\"\n- else\n- in.substring(0, in.length - 1) + (in.last - 1).toChar\n+ /**\n+ * Value distribution to test. Allow value generation. Can also provide a slightly smaller\n+ * or larger version of a value, which allows testing around a property bound.\n+ */\n+ case class ValueSetup[T <: Value](name: String, generator:Gen[T], lessThan: T => T, moreThan: T => T)\n \n- private def testOperator(operator: String): Unit = {\n+ // GENERATORS\n \n- val queryNotUsingIndex = s\"match (n:Label) where n.nonIndexed $operator {prop} return n order by id(n)\"\n- val queryUsingIndex = s\"match (n:Label) where n.indexed $operator {prop} return n order by id(n)\"\n+ def longGen: Gen[LongValue] =\n+ for (x <- Gen.chooseNum(Long.MinValue+1, Long.MaxValue-1)) yield Values.longValue(x)\n \n- def testValue(queryNotUsingIndex: String, queryUsingIndex: String, value: Any): Unit = {\n- val indexedResult = execute(queryUsingIndex, \"prop\" -> value)\n- execute(queryNotUsingIndex, \"prop\" -> value).toList should equal(indexedResult.toList)\n- indexedResult.executionPlanDescription().toString should include(\"NodeIndexSeek\")\n- }\n+ def doubleGen: Gen[DoubleValue] =\n+ for (x <- arbitrary[Double]) yield Values.doubleValue(x)\n \n- def tester[T](propertyValue: T, prev: T => T, next: T => T): Unit = {\n- graph.inTx {\n- createLabeledNode(Map(\"nonIndexed\" -> propertyValue, \"indexed\" -> propertyValue), \"Label\")\n+ def textGen: Gen[TextValue] =\n+ for (x <- Gen.alphaStr) yield Values.stringValue(x)\n \n- withClue(\"with TxState\") {\n- testValue(queryNotUsingIndex, queryUsingIndex, propertyValue)\n- testValue(queryNotUsingIndex, queryUsingIndex, prev(propertyValue))\n- testValue(queryNotUsingIndex, queryUsingIndex, next(propertyValue))\n- }\n- }\n- withClue(\"without TxState\") {\n- testValue(queryNotUsingIndex, queryUsingIndex, propertyValue)\n- testValue(queryNotUsingIndex, queryUsingIndex, prev(propertyValue))\n- testValue(queryNotUsingIndex, queryUsingIndex, next(propertyValue))\n- }\n- }\n+ def pointGen: Gen[PointValue] =\n+ for {\n+ dimension <- Gen.oneOf(allCRSDimensions)\n+ coordinates <- Gen.listOfN(dimension, arbitrary[Double])\n+ crs <- Gen.oneOf(allCRS(dimension))\n+ } yield Values.pointValue(crs, coordinates:_*)\n \n- test(s\"testing long with $operator\") {\n- graph.createIndex(\"Label\", \"indexed\")\n- forAll { propertyValue: Long =>\n- tester(propertyValue, (l: Long) => l - 1L, (l: Long) => l + 1)\n- }\n- }\n+ def timeGen: Gen[TimeValue] =\n+ for {\n+ nanosOfDay <- Gen.chooseNum(1000000000, 86399999999999L - 1000000000)","path":"community/cypher/cypher/src/test/scala/org/neo4j/cypher/internal/compiler/v3_4/SemanticIndexAcceptanceTest.scala","position":109,"original_position":109,"commit_id":"14f6510d1627b24f824468f08e563f532f2fca2c","original_commit_id":"14f6510d1627b24f824468f08e563f532f2fca2c","user":{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false},"body":"Where does this range come from? Why are you not checking values closer to 0? Maybe add a comment about it.","created_at":"2018-03-15T17:12:46Z","updated_at":"2018-03-15T17:12:46Z","html_url":"https://github.com/neo4j/neo4j/pull/11221#discussion_r174861094","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174861094"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11221#discussion_r174861094"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221","id":174285019,"html_url":"https://github.com/neo4j/neo4j/pull/11221","diff_url":"https://github.com/neo4j/neo4j/pull/11221.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11221.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11221","number":11221,"state":"open","locked":false,"title":"Temporal acceptance tests","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"body":"This pull request contains mostly acceptance test refactoring and additions, testing both spatial and temporal indexing capabilities. Some minor bugs were detected and fixed, and others cardified. In particular, we ran into a bug with the spatial index which was deemed to hard to solve here, or possibly we are just missing something. \r\n\r\nIn the final commit we decided to completely refactor how `NodeIndexSeekPipe` execute index seeks, because this was to us very hard to understand. All logic around this is now encapsulated in the new trait `NodeIndexSeeker`, which directly creates the kernel API `IndexQuery` that is used to perform the index seeks. This is possible because we are new versioning cypher on the logical plan.\r\n\r\n~~Builds on temporal index IV (#11181), first commit is `split spatial index test classes into separate files`.~~","created_at":"2018-03-12T06:53:48Z","updated_at":"2018-03-15T17:12:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8b912c69ce930605bbd8b7c07e4fe6ae709f365","assignee":{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"Lojjs","id":7222590,"avatar_url":"https://avatars1.githubusercontent.com/u/7222590?v=4","gravatar_id":"","url":"https://api.github.com/users/Lojjs","html_url":"https://github.com/Lojjs","followers_url":"https://api.github.com/users/Lojjs/followers","following_url":"https://api.github.com/users/Lojjs/following{/other_user}","gists_url":"https://api.github.com/users/Lojjs/gists{/gist_id}","starred_url":"https://api.github.com/users/Lojjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lojjs/subscriptions","organizations_url":"https://api.github.com/users/Lojjs/orgs","repos_url":"https://api.github.com/users/Lojjs/repos","events_url":"https://api.github.com/users/Lojjs/events{/privacy}","received_events_url":"https://api.github.com/users/Lojjs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":695463446,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.4","name":"3.4","color":"f9d0c4","default":false},{"id":19073042,"url":"https://api.github.com/repos/neo4j/neo4j/labels/cypher","name":"cypher","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11221/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/14f6510d1627b24f824468f08e563f532f2fca2c","head":{"label":"fickludd:3.4-temporal-acceptance-tests","ref":"3.4-temporal-acceptance-tests","sha":"14f6510d1627b24f824468f08e563f532f2fca2c","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"repo":{"id":60172359,"name":"neo4j","full_name":"fickludd/neo4j","owner":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars1.githubusercontent.com/u/3527193?v=4","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fickludd/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/fickludd/neo4j","forks_url":"https://api.github.com/repos/fickludd/neo4j/forks","keys_url":"https://api.github.com/repos/fickludd/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fickludd/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fickludd/neo4j/teams","hooks_url":"https://api.github.com/repos/fickludd/neo4j/hooks","issue_events_url":"https://api.github.com/repos/fickludd/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/fickludd/neo4j/events","assignees_url":"https://api.github.com/repos/fickludd/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/fickludd/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/fickludd/neo4j/tags","blobs_url":"https://api.github.com/repos/fickludd/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fickludd/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fickludd/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/fickludd/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fickludd/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/fickludd/neo4j/languages","stargazers_url":"https://api.github.com/repos/fickludd/neo4j/stargazers","contributors_url":"https://api.github.com/repos/fickludd/neo4j/contributors","subscribers_url":"https://api.github.com/repos/fickludd/neo4j/subscribers","subscription_url":"https://api.github.com/repos/fickludd/neo4j/subscription","commits_url":"https://api.github.com/repos/fickludd/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/fickludd/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/fickludd/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/fickludd/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/fickludd/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/fickludd/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fickludd/neo4j/merges","archive_url":"https://api.github.com/repos/fickludd/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fickludd/neo4j/downloads","issues_url":"https://api.github.com/repos/fickludd/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/fickludd/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/fickludd/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/fickludd/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fickludd/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/fickludd/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/fickludd/neo4j/deployments","created_at":"2016-06-01T11:49:30Z","updated_at":"2016-07-01T13:40:19Z","pushed_at":"2018-03-15T15:06:01Z","git_url":"git://github.com/fickludd/neo4j.git","ssh_url":"git@github.com:fickludd/neo4j.git","clone_url":"https://github.com/fickludd/neo4j.git","svn_url":"https://github.com/fickludd/neo4j","homepage":"http://neo4j.com","size":394079,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.1"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"88e7c1341e7ea61b0337b2c9f47880da5afd7c33","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-15T15:02:29Z","pushed_at":"2018-03-15T16:35:57Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":394338,"stargazers_count":4824,"watchers_count":4824,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1300,"mirror_url":null,"archived":false,"open_issues_count":342,"license":null,"forks":1300,"open_issues":342,"watchers":4824,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11221"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11221"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11221/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11221/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/14f6510d1627b24f824468f08e563f532f2fca2c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6650539,
"name": "neo4j/neo4j",
"url": "https://api.github.com/repos/neo4j/neo4j"
} | {
"id": 7222590,
"login": "Lojjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7222590?",
"url": "https://api.github.com/users/Lojjs"
} | {
"id": 201120,
"login": "neo4j",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/201120?",
"url": "https://api.github.com/orgs/neo4j"
} | 2018-03-15T17:12:46 | 7386114575 | {"actor":{"display_login":"Lojjs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/comments/187765997","pull_request_review_id":119618806,"id":187765997,"diff_hunk":"@@ -0,0 +1,61 @@\n+---\n+layout: news_post\n+title: \"Вышел Ruby 2.5.1\"\n+author: \"naruse\"\n+translator: \"arbox\"\n+date: 2018-03-28 17:20:00 +0000\n+lang: ru\n+---\n+\n+Вышел Ruby 2.5.1.\n+\n+Этот релиз влючает в себя исправление ошибок и решений проблем в безопасности.\n+\n+* [CVE-2017-17742: HTTP response splitting in WEBrick](/en/news/2018/03/28/http-response-splitting-in-webrick-cve-2017-17742/)","path":"ru/news/_posts/2018-03-28-ruby-2-5-1-released.md","position":14,"original_position":14,"commit_id":"8b0e7e84a138a8aeb7053e94c27653fd35b062c3","original_commit_id":"8b0e7e84a138a8aeb7053e94c27653fd35b062c3","user":{"login":"razum2um","id":122018,"avatar_url":"https://avatars2.githubusercontent.com/u/122018?v=4","gravatar_id":"","url":"https://api.github.com/users/razum2um","html_url":"https://github.com/razum2um","followers_url":"https://api.github.com/users/razum2um/followers","following_url":"https://api.github.com/users/razum2um/following{/other_user}","gists_url":"https://api.github.com/users/razum2um/gists{/gist_id}","starred_url":"https://api.github.com/users/razum2um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razum2um/subscriptions","organizations_url":"https://api.github.com/users/razum2um/orgs","repos_url":"https://api.github.com/users/razum2um/repos","events_url":"https://api.github.com/users/razum2um/events{/privacy}","received_events_url":"https://api.github.com/users/razum2um/received_events","type":"User","site_admin":false},"body":"@arbox let's translate descriptions?","created_at":"2018-05-12T06:30:47Z","updated_at":"2018-05-12T06:30:47Z","html_url":"https://github.com/ruby/www.ruby-lang.org/pull/1792#discussion_r187765997","pull_request_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/comments/187765997"},"html":{"href":"https://github.com/ruby/www.ruby-lang.org/pull/1792#discussion_r187765997"},"pull_request":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792"}}},"pull_request":{"url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792","id":187485842,"html_url":"https://github.com/ruby/www.ruby-lang.org/pull/1792","diff_url":"https://github.com/ruby/www.ruby-lang.org/pull/1792.diff","patch_url":"https://github.com/ruby/www.ruby-lang.org/pull/1792.patch","issue_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/1792","number":1792,"state":"open","locked":false,"title":"Translate 2.5.1 release post (RU)","user":{"login":"arbox","id":357237,"avatar_url":"https://avatars1.githubusercontent.com/u/357237?v=4","gravatar_id":"","url":"https://api.github.com/users/arbox","html_url":"https://github.com/arbox","followers_url":"https://api.github.com/users/arbox/followers","following_url":"https://api.github.com/users/arbox/following{/other_user}","gists_url":"https://api.github.com/users/arbox/gists{/gist_id}","starred_url":"https://api.github.com/users/arbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbox/subscriptions","organizations_url":"https://api.github.com/users/arbox/orgs","repos_url":"https://api.github.com/users/arbox/repos","events_url":"https://api.github.com/users/arbox/events{/privacy}","received_events_url":"https://api.github.com/users/arbox/received_events","type":"User","site_admin":false},"body":"I've translated the Release Notice for Ruby 2.5.1.\r\n\r\nPlease review: @gazay , @razum2um ","created_at":"2018-05-11T14:49:31Z","updated_at":"2018-05-12T06:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3125e2c3a77c4f71b4906298b35243e3e258b00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792/commits","review_comments_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792/comments","review_comment_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/1792/comments","statuses_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/statuses/8b0e7e84a138a8aeb7053e94c27653fd35b062c3","head":{"label":"arbox:fb_translate_251_release","ref":"fb_translate_251_release","sha":"8b0e7e84a138a8aeb7053e94c27653fd35b062c3","user":{"login":"arbox","id":357237,"avatar_url":"https://avatars1.githubusercontent.com/u/357237?v=4","gravatar_id":"","url":"https://api.github.com/users/arbox","html_url":"https://github.com/arbox","followers_url":"https://api.github.com/users/arbox/followers","following_url":"https://api.github.com/users/arbox/following{/other_user}","gists_url":"https://api.github.com/users/arbox/gists{/gist_id}","starred_url":"https://api.github.com/users/arbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbox/subscriptions","organizations_url":"https://api.github.com/users/arbox/orgs","repos_url":"https://api.github.com/users/arbox/repos","events_url":"https://api.github.com/users/arbox/events{/privacy}","received_events_url":"https://api.github.com/users/arbox/received_events","type":"User","site_admin":false},"repo":{"id":31259726,"name":"www.ruby-lang.org","full_name":"arbox/www.ruby-lang.org","owner":{"login":"arbox","id":357237,"avatar_url":"https://avatars1.githubusercontent.com/u/357237?v=4","gravatar_id":"","url":"https://api.github.com/users/arbox","html_url":"https://github.com/arbox","followers_url":"https://api.github.com/users/arbox/followers","following_url":"https://api.github.com/users/arbox/following{/other_user}","gists_url":"https://api.github.com/users/arbox/gists{/gist_id}","starred_url":"https://api.github.com/users/arbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbox/subscriptions","organizations_url":"https://api.github.com/users/arbox/orgs","repos_url":"https://api.github.com/users/arbox/repos","events_url":"https://api.github.com/users/arbox/events{/privacy}","received_events_url":"https://api.github.com/users/arbox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arbox/www.ruby-lang.org","description":"Source of the https://www.ruby-lang.org website.","fork":true,"url":"https://api.github.com/repos/arbox/www.ruby-lang.org","forks_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/forks","keys_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/teams","hooks_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/hooks","issue_events_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/issues/events{/number}","events_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/events","assignees_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/assignees{/user}","branches_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/branches{/branch}","tags_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/tags","blobs_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/statuses/{sha}","languages_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/languages","stargazers_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/stargazers","contributors_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/contributors","subscribers_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/subscribers","subscription_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/subscription","commits_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/contents/{+path}","compare_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/merges","archive_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/downloads","issues_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/issues{/number}","pulls_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/pulls{/number}","milestones_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/milestones{/number}","notifications_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/labels{/name}","releases_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/releases{/id}","deployments_url":"https://api.github.com/repos/arbox/www.ruby-lang.org/deployments","created_at":"2015-02-24T12:49:42Z","updated_at":"2016-02-29T00:05:17Z","pushed_at":"2018-05-11T14:45:21Z","git_url":"git://github.com/arbox/www.ruby-lang.org.git","ssh_url":"git@github.com:arbox/www.ruby-lang.org.git","clone_url":"https://github.com/arbox/www.ruby-lang.org.git","svn_url":"https://github.com/arbox/www.ruby-lang.org","homepage":"","size":42909,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby:master","ref":"master","sha":"2994fa489f8e2b80ddee6ec5c0c09332a02da9c9","user":{"login":"ruby","id":210414,"avatar_url":"https://avatars3.githubusercontent.com/u/210414?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"repo":{"id":2147447,"name":"www.ruby-lang.org","full_name":"ruby/www.ruby-lang.org","owner":{"login":"ruby","id":210414,"avatar_url":"https://avatars3.githubusercontent.com/u/210414?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby/www.ruby-lang.org","description":"Source of the https://www.ruby-lang.org website.","fork":false,"url":"https://api.github.com/repos/ruby/www.ruby-lang.org","forks_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/forks","keys_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/teams","hooks_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/hooks","issue_events_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/events{/number}","events_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/events","assignees_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/assignees{/user}","branches_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/branches{/branch}","tags_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/tags","blobs_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/languages","stargazers_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/stargazers","contributors_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/contributors","subscribers_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/subscribers","subscription_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/subscription","commits_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/contents/{+path}","compare_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/merges","archive_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/downloads","issues_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues{/number}","pulls_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/labels{/name}","releases_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/releases{/id}","deployments_url":"https://api.github.com/repos/ruby/www.ruby-lang.org/deployments","created_at":"2011-08-03T08:29:44Z","updated_at":"2018-05-09T19:42:11Z","pushed_at":"2018-05-11T14:49:32Z","git_url":"git://github.com/ruby/www.ruby-lang.org.git","ssh_url":"git@github.com:ruby/www.ruby-lang.org.git","clone_url":"https://github.com/ruby/www.ruby-lang.org.git","svn_url":"https://github.com/ruby/www.ruby-lang.org","homepage":"","size":42900,"stargazers_count":670,"watchers_count":670,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":457,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":457,"open_issues":61,"watchers":670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792"},"html":{"href":"https://github.com/ruby/www.ruby-lang.org/pull/1792"},"issue":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/1792"},"comments":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/issues/1792/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/pulls/1792/commits"},"statuses":{"href":"https://api.github.com/repos/ruby/www.ruby-lang.org/statuses/8b0e7e84a138a8aeb7053e94c27653fd35b062c3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2147447,
"name": "ruby/www.ruby-lang.org",
"url": "https://api.github.com/repos/ruby/www.ruby-lang.org"
} | {
"id": 122018,
"login": "razum2um",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/122018?",
"url": "https://api.github.com/users/razum2um"
} | {
"id": 210414,
"login": "ruby",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/210414?",
"url": "https://api.github.com/orgs/ruby"
} | 2018-05-12T06:30:47 | 7664368021 | {"actor":{"display_login":"razum2um"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/240911040","pull_request_review_id":184048290,"id":240911040,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDkxMTA0MA==","diff_hunk":"@@ -503,12 +503,31 @@ private void AddInfo(string message, Action<IOperationProgress> onProgress)\n token: TaskCancelToken.Token);\n \n smuggler.Execute();\n- file.Flush(flushToDisk: true);\n+\n+ switch (outputStream)\n+ {\n+ case EncryptingXChaCha20Poly1305Stream encryptedStream:\n+ encryptedStream.Flush(flushToDisk: true);\n+ break;\n+ case FileStream file:\n+ file.Flush(flushToDisk: true);\n+ break;","path":"src/Raven.Server/Documents/PeriodicBackup/BackupTask.cs","position":36,"original_position":36,"commit_id":"a8de37e87b955e021082373af249c1ac3e1c2ea9","original_commit_id":"a8de37e87b955e021082373af249c1ac3e1c2ea9","user":{"login":"arekpalinski","id":376551,"node_id":"MDQ6VXNlcjM3NjU1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/376551?v=4","gravatar_id":"","url":"https://api.github.com/users/arekpalinski","html_url":"https://github.com/arekpalinski","followers_url":"https://api.github.com/users/arekpalinski/followers","following_url":"https://api.github.com/users/arekpalinski/following{/other_user}","gists_url":"https://api.github.com/users/arekpalinski/gists{/gist_id}","starred_url":"https://api.github.com/users/arekpalinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekpalinski/subscriptions","organizations_url":"https://api.github.com/users/arekpalinski/orgs","repos_url":"https://api.github.com/users/arekpalinski/repos","events_url":"https://api.github.com/users/arekpalinski/events{/privacy}","received_events_url":"https://api.github.com/users/arekpalinski/received_events","type":"User","site_admin":false},"body":"Please apply the fix in separate PR","created_at":"2018-12-12T07:59:19Z","updated_at":"2018-12-12T07:59:20Z","html_url":"https://github.com/ravendb/ravendb/pull/8186#discussion_r240911040","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8186","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/240911040"},"html":{"href":"https://github.com/ravendb/ravendb/pull/8186#discussion_r240911040"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8186"}},"in_reply_to_id":240121598},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/8186","id":237120226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTIwMjI2","html_url":"https://github.com/ravendb/ravendb/pull/8186","diff_url":"https://github.com/ravendb/ravendb/pull/8186.diff","patch_url":"https://github.com/ravendb/ravendb/pull/8186.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/8186","number":8186,"state":"open","locked":false,"title":" RavenDB-10683 Backup of encrypted database","user":{"login":"efratshenhar","id":18046191,"node_id":"MDQ6VXNlcjE4MDQ2MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/18046191?v=4","gravatar_id":"","url":"https://api.github.com/users/efratshenhar","html_url":"https://github.com/efratshenhar","followers_url":"https://api.github.com/users/efratshenhar/followers","following_url":"https://api.github.com/users/efratshenhar/following{/other_user}","gists_url":"https://api.github.com/users/efratshenhar/gists{/gist_id}","starred_url":"https://api.github.com/users/efratshenhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efratshenhar/subscriptions","organizations_url":"https://api.github.com/users/efratshenhar/orgs","repos_url":"https://api.github.com/users/efratshenhar/repos","events_url":"https://api.github.com/users/efratshenhar/events{/privacy}","received_events_url":"https://api.github.com/users/efratshenhar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-09T09:55:06Z","updated_at":"2018-12-12T07:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b1376089fd45a185ef0834a2782e11c0fd4d20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1093054486,"node_id":"MDU6TGFiZWwxMDkzMDU0NDg2","url":"https://api.github.com/repos/ravendb/ravendb/labels/v4.2","name":"v4.2","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8186/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8186/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/8186/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/a8de37e87b955e021082373af249c1ac3e1c2ea9","head":{"label":"efratshenhar:RavenDB-10683","ref":"RavenDB-10683","sha":"a8de37e87b955e021082373af249c1ac3e1c2ea9","user":{"login":"efratshenhar","id":18046191,"node_id":"MDQ6VXNlcjE4MDQ2MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/18046191?v=4","gravatar_id":"","url":"https://api.github.com/users/efratshenhar","html_url":"https://github.com/efratshenhar","followers_url":"https://api.github.com/users/efratshenhar/followers","following_url":"https://api.github.com/users/efratshenhar/following{/other_user}","gists_url":"https://api.github.com/users/efratshenhar/gists{/gist_id}","starred_url":"https://api.github.com/users/efratshenhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efratshenhar/subscriptions","organizations_url":"https://api.github.com/users/efratshenhar/orgs","repos_url":"https://api.github.com/users/efratshenhar/repos","events_url":"https://api.github.com/users/efratshenhar/events{/privacy}","received_events_url":"https://api.github.com/users/efratshenhar/received_events","type":"User","site_admin":false},"repo":{"id":54645102,"node_id":"MDEwOlJlcG9zaXRvcnk1NDY0NTEwMg==","name":"ravendb","full_name":"efratshenhar/ravendb","private":false,"owner":{"login":"efratshenhar","id":18046191,"node_id":"MDQ6VXNlcjE4MDQ2MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/18046191?v=4","gravatar_id":"","url":"https://api.github.com/users/efratshenhar","html_url":"https://github.com/efratshenhar","followers_url":"https://api.github.com/users/efratshenhar/followers","following_url":"https://api.github.com/users/efratshenhar/following{/other_user}","gists_url":"https://api.github.com/users/efratshenhar/gists{/gist_id}","starred_url":"https://api.github.com/users/efratshenhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efratshenhar/subscriptions","organizations_url":"https://api.github.com/users/efratshenhar/orgs","repos_url":"https://api.github.com/users/efratshenhar/repos","events_url":"https://api.github.com/users/efratshenhar/events{/privacy}","received_events_url":"https://api.github.com/users/efratshenhar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/efratshenhar/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/efratshenhar/ravendb","forks_url":"https://api.github.com/repos/efratshenhar/ravendb/forks","keys_url":"https://api.github.com/repos/efratshenhar/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efratshenhar/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efratshenhar/ravendb/teams","hooks_url":"https://api.github.com/repos/efratshenhar/ravendb/hooks","issue_events_url":"https://api.github.com/repos/efratshenhar/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/efratshenhar/ravendb/events","assignees_url":"https://api.github.com/repos/efratshenhar/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/efratshenhar/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/efratshenhar/ravendb/tags","blobs_url":"https://api.github.com/repos/efratshenhar/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efratshenhar/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efratshenhar/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/efratshenhar/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efratshenhar/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/efratshenhar/ravendb/languages","stargazers_url":"https://api.github.com/repos/efratshenhar/ravendb/stargazers","contributors_url":"https://api.github.com/repos/efratshenhar/ravendb/contributors","subscribers_url":"https://api.github.com/repos/efratshenhar/ravendb/subscribers","subscription_url":"https://api.github.com/repos/efratshenhar/ravendb/subscription","commits_url":"https://api.github.com/repos/efratshenhar/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/efratshenhar/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/efratshenhar/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/efratshenhar/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/efratshenhar/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/efratshenhar/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efratshenhar/ravendb/merges","archive_url":"https://api.github.com/repos/efratshenhar/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efratshenhar/ravendb/downloads","issues_url":"https://api.github.com/repos/efratshenhar/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/efratshenhar/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/efratshenhar/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/efratshenhar/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efratshenhar/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/efratshenhar/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/efratshenhar/ravendb/deployments","created_at":"2016-03-24T13:46:21Z","updated_at":"2018-10-29T07:42:06Z","pushed_at":"2018-12-10T07:46:43Z","git_url":"git://github.com/efratshenhar/ravendb.git","ssh_url":"git@github.com:efratshenhar/ravendb.git","clone_url":"https://github.com/efratshenhar/ravendb.git","svn_url":"https://github.com/efratshenhar/ravendb","homepage":"http://ayende.com/Blog/","size":453610,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.2","ref":"v4.2","sha":"e7d6642eb6a49eeb94735879644f107b90ffd2d5","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","private":false,"owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2018-12-11T15:38:55Z","pushed_at":"2018-12-12T07:57:08Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":455656,"stargazers_count":2067,"watchers_count":2067,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":706,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":706,"open_issues":14,"watchers":2067,"default_branch":"v4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8186"},"html":{"href":"https://github.com/ravendb/ravendb/pull/8186"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/8186"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/8186/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8186/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8186/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/a8de37e87b955e021082373af249c1ac3e1c2ea9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 542714,
"name": "ravendb/ravendb",
"url": "https://api.github.com/repos/ravendb/ravendb"
} | {
"id": 376551,
"login": "arekpalinski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/376551?",
"url": "https://api.github.com/users/arekpalinski"
} | {
"id": 213792,
"login": "ravendb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/213792?",
"url": "https://api.github.com/orgs/ravendb"
} | 2018-12-12T07:59:19 | 8739383279 | {"actor":{"display_login":"arekpalinski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/229806651","pull_request_review_id":170394998,"id":229806651,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgwNjY1MQ==","diff_hunk":"@@ -380,6 +380,8 @@ def test_constrained_layout23():\n fig.suptitle(\"Suptitle{}\".format(i))\n \n \n+@pytest.mark.timeout(30)\n+@pytest.mark.flaky(reruns=3)","path":"lib/matplotlib/tests/test_constrainedlayout.py","position":5,"original_position":5,"commit_id":"a0c6e245e3582e967e4cb9bf3169c446b3718458","original_commit_id":"a0c6e245e3582e967e4cb9bf3169c446b3718458","user":{"login":"anntzer","id":1322974,"node_id":"MDQ6VXNlcjEzMjI5NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"body":"Can you leave a note explaining the source of randomness?\r\nPerhaps worth investigating whether kiwisolver can be made deterministic too.","created_at":"2018-10-31T18:00:13Z","updated_at":"2018-10-31T18:00:13Z","html_url":"https://github.com/matplotlib/matplotlib/pull/12683#discussion_r229806651","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/229806651"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/12683#discussion_r229806651"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683","id":227379798,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzc5Nzk4","html_url":"https://github.com/matplotlib/matplotlib/pull/12683","diff_url":"https://github.com/matplotlib/matplotlib/pull/12683.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/12683.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12683","number":12683,"state":"open","locked":false,"title":"TST: mark test_constrainedlayout.py::test_colorbar_location as flaky","user":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nCloses #12433\r\n\r\n`test_constrainedlayout.py::test_colorbar_location` is sometimes flaky; i.e. the constraint solver sometimes seems tochoose the wrong constraint. The flakiness is rare, but occasionally causes CI to not pass. \r\n\r\nAlso added a `@pytest.mark.timeout(30)` because I saw one instance where the CI timed out because of this test. I don't see that we do this elsewhere in the CI suite, so please feel free to tell me if this is incorrect. \r\n\r\n## PR Checklist\r\n\r\n- [ ] Has Pytest style unit tests\r\n- [ ] Code is [Flake 8](http://flake8.pycqa.org/en/latest/) compliant\r\n- [ ] New features are documented, with examples if plot related\r\n- [ ] Documentation is sphinx and numpydoc compliant\r\n- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way\r\n\r\n<!--\r\nThank you so much for your PR! To help us review your contribution, please\r\nconsider the following points:\r\n\r\n- A development guide is available at https://matplotlib.org/devdocs/devel/index.html.\r\n\r\n- Help with git and github is available at\r\n https://matplotlib.org/devel/gitwash/development_workflow.html.\r\n\r\n- Do not create the PR out of master, but out of a separate branch.\r\n\r\n- The PR title should summarize the changes, for example \"Raise ValueError on\r\n non-numeric input to set_xlim\". Avoid non-descriptive titles such as\r\n \"Addresses issue #8576\".\r\n\r\n- The summary should provide at least 1-2 sentences describing the pull request\r\n in detail (Why is this change required? What problem does it solve?) and\r\n link to any relevant issues.\r\n\r\n- If you are contributing fixes to docstrings, please pay attention to\r\n http://matplotlib.org/devel/documenting_mpl.html#formatting. In particular,\r\n note the difference between using single backquotes, double backquotes, and\r\n asterisks in the markup.\r\n\r\nWe understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in. Please let us know if the reviews are unclear or\r\nthe recommended next step seems overly demanding, if you would like help in\r\naddressing a reviewer's comments, or if you have been waiting too long to hear\r\nback on your PR.\r\n-->","created_at":"2018-10-31T17:36:11Z","updated_at":"2018-10-31T18:00:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3df4b06360ddd6eb2d08d06e817f99174be44cfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":151683879,"node_id":"MDU6TGFiZWwxNTE2ODM4Nzk=","url":"https://api.github.com/repos/matplotlib/matplotlib/labels/Testing","name":"Testing","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/39","html_url":"https://github.com/matplotlib/matplotlib/milestone/39","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/39/labels","id":3767226,"node_id":"MDk6TWlsZXN0b25lMzc2NzIyNg==","number":39,"title":"v3.0.x","description":"Bug-fix release branch for 3.0 series\r\n\r\non-merge: safe_backport to v3.0.x","creator":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":24,"state":"open","created_at":"2018-10-25T01:59:35Z","updated_at":"2018-10-31T17:36:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12683/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/a0c6e245e3582e967e4cb9bf3169c446b3718458","head":{"label":"jklymak:tst_mark_colorbartest_flaky","ref":"tst_mark_colorbartest_flaky","sha":"a0c6e245e3582e967e4cb9bf3169c446b3718458","user":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"repo":{"id":93901119,"node_id":"MDEwOlJlcG9zaXRvcnk5MzkwMTExOQ==","name":"matplotlib","full_name":"jklymak/matplotlib","private":false,"owner":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jklymak/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/jklymak/matplotlib","forks_url":"https://api.github.com/repos/jklymak/matplotlib/forks","keys_url":"https://api.github.com/repos/jklymak/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklymak/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklymak/matplotlib/teams","hooks_url":"https://api.github.com/repos/jklymak/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/jklymak/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/jklymak/matplotlib/events","assignees_url":"https://api.github.com/repos/jklymak/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/jklymak/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/jklymak/matplotlib/tags","blobs_url":"https://api.github.com/repos/jklymak/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklymak/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklymak/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklymak/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklymak/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/jklymak/matplotlib/languages","stargazers_url":"https://api.github.com/repos/jklymak/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/jklymak/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/jklymak/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/jklymak/matplotlib/subscription","commits_url":"https://api.github.com/repos/jklymak/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklymak/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklymak/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklymak/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklymak/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/jklymak/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklymak/matplotlib/merges","archive_url":"https://api.github.com/repos/jklymak/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklymak/matplotlib/downloads","issues_url":"https://api.github.com/repos/jklymak/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/jklymak/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/jklymak/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/jklymak/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklymak/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/jklymak/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/jklymak/matplotlib/deployments","created_at":"2017-06-09T22:24:38Z","updated_at":"2017-06-10T22:48:17Z","pushed_at":"2018-10-31T17:34:00Z","git_url":"git://github.com/jklymak/matplotlib.git","ssh_url":"git@github.com:jklymak/matplotlib.git","clone_url":"https://github.com/jklymak/matplotlib.git","svn_url":"https://github.com/jklymak/matplotlib","homepage":"http://matplotlib.org/","size":341613,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"matplotlib:master","ref":"master","sha":"9e8be5b0dc0a03f569d7a248f67ef136520adbbb","user":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MTIy","name":"matplotlib","full_name":"matplotlib/matplotlib","private":false,"owner":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-10-31T17:19:38Z","pushed_at":"2018-10-31T17:36:12Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":337602,"stargazers_count":8146,"watchers_count":8146,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3742,"mirror_url":null,"archived":false,"open_issues_count":1438,"license":null,"forks":3742,"open_issues":1438,"watchers":8146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/12683"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/12683"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/12683/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12683/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/a0c6e245e3582e967e4cb9bf3169c446b3718458"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1385122,
"name": "matplotlib/matplotlib",
"url": "https://api.github.com/repos/matplotlib/matplotlib"
} | {
"id": 1322974,
"login": "anntzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1322974?",
"url": "https://api.github.com/users/anntzer"
} | {
"id": 215947,
"login": "matplotlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215947?",
"url": "https://api.github.com/orgs/matplotlib"
} | 2018-10-31T18:00:13 | 8514234001 | {"actor":{"display_login":"anntzer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/191283806","pull_request_review_id":123824012,"id":191283806,"diff_hunk":"@@ -289,27 +290,12 @@ def __init__(self):\n except KeyError:\n self.pkg_config = 'pkg-config'\n \n- self.set_pkgconfig_path()\n self.has_pkgconfig = shutil.which(self.pkg_config) is not None\n if not self.has_pkgconfig:\n print(\"IMPORTANT WARNING:\\n\"\n \" pkg-config is not installed.\\n\"\n \" matplotlib may not be able to find some of its dependencies\")\n \n- def set_pkgconfig_path(self):","path":"setupext.py","position":44,"original_position":44,"commit_id":"9510849e245f4489d955ceecb98ce99abc1edf8d","original_commit_id":"9510849e245f4489d955ceecb98ce99abc1edf8d","user":{"login":"anntzer","id":1322974,"avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"body":"(I don't think that \"trying to keep commit messages minimal\" is a good advice (quite the contrary...). But yes, it's good to also good to duplicate all the info in the thread.)","created_at":"2018-05-29T00:32:01Z","updated_at":"2018-05-29T00:32:02Z","html_url":"https://github.com/matplotlib/matplotlib/pull/11218#discussion_r191283806","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/191283806"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/11218#discussion_r191283806"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218"}},"in_reply_to_id":191278948},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218","id":187122370,"html_url":"https://github.com/matplotlib/matplotlib/pull/11218","diff_url":"https://github.com/matplotlib/matplotlib/pull/11218.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/11218.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11218","number":11218,"state":"open","locked":false,"title":"fix pkg-config handling to make cross-compiling work","user":{"login":"vapier","id":176950,"avatar_url":"https://avatars3.githubusercontent.com/u/176950?v=4","gravatar_id":"","url":"https://api.github.com/users/vapier","html_url":"https://github.com/vapier","followers_url":"https://api.github.com/users/vapier/followers","following_url":"https://api.github.com/users/vapier/following{/other_user}","gists_url":"https://api.github.com/users/vapier/gists{/gist_id}","starred_url":"https://api.github.com/users/vapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapier/subscriptions","organizations_url":"https://api.github.com/users/vapier/orgs","repos_url":"https://api.github.com/users/vapier/repos","events_url":"https://api.github.com/users/vapier/events{/privacy}","received_events_url":"https://api.github.com/users/vapier/received_events","type":"User","site_admin":false},"body":"This series cleans up the pkg-config logic so that cross-compile works properly. There's still some weirdness with the use of freetype-config/libpng-config, but I've ignored that as it only impacts the display and not the actual config/code generation.","created_at":"2018-05-10T07:36:47Z","updated_at":"2018-05-29T00:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73b748d1ce7e0c425bb6eb762a03e38e1b81087f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":129265630,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/build","name":"build","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23","html_url":"https://github.com/matplotlib/matplotlib/milestone/23","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23/labels","id":1542657,"number":23,"title":"v3.0","description":"Big ticket items:\r\n\r\n - drop support for python 2","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":228,"closed_issues":337,"state":"open","created_at":"2016-01-25T21:06:49Z","updated_at":"2018-05-29T00:31:05Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11218/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/9510849e245f4489d955ceecb98ce99abc1edf8d","head":{"label":"vapier:master","ref":"master","sha":"9510849e245f4489d955ceecb98ce99abc1edf8d","user":{"login":"vapier","id":176950,"avatar_url":"https://avatars3.githubusercontent.com/u/176950?v=4","gravatar_id":"","url":"https://api.github.com/users/vapier","html_url":"https://github.com/vapier","followers_url":"https://api.github.com/users/vapier/followers","following_url":"https://api.github.com/users/vapier/following{/other_user}","gists_url":"https://api.github.com/users/vapier/gists{/gist_id}","starred_url":"https://api.github.com/users/vapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapier/subscriptions","organizations_url":"https://api.github.com/users/vapier/orgs","repos_url":"https://api.github.com/users/vapier/repos","events_url":"https://api.github.com/users/vapier/events{/privacy}","received_events_url":"https://api.github.com/users/vapier/received_events","type":"User","site_admin":false},"repo":{"id":35660016,"name":"matplotlib","full_name":"vapier/matplotlib","owner":{"login":"vapier","id":176950,"avatar_url":"https://avatars3.githubusercontent.com/u/176950?v=4","gravatar_id":"","url":"https://api.github.com/users/vapier","html_url":"https://github.com/vapier","followers_url":"https://api.github.com/users/vapier/followers","following_url":"https://api.github.com/users/vapier/following{/other_user}","gists_url":"https://api.github.com/users/vapier/gists{/gist_id}","starred_url":"https://api.github.com/users/vapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vapier/subscriptions","organizations_url":"https://api.github.com/users/vapier/orgs","repos_url":"https://api.github.com/users/vapier/repos","events_url":"https://api.github.com/users/vapier/events{/privacy}","received_events_url":"https://api.github.com/users/vapier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vapier/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/vapier/matplotlib","forks_url":"https://api.github.com/repos/vapier/matplotlib/forks","keys_url":"https://api.github.com/repos/vapier/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vapier/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vapier/matplotlib/teams","hooks_url":"https://api.github.com/repos/vapier/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/vapier/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/vapier/matplotlib/events","assignees_url":"https://api.github.com/repos/vapier/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/vapier/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/vapier/matplotlib/tags","blobs_url":"https://api.github.com/repos/vapier/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vapier/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vapier/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/vapier/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vapier/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/vapier/matplotlib/languages","stargazers_url":"https://api.github.com/repos/vapier/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/vapier/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/vapier/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/vapier/matplotlib/subscription","commits_url":"https://api.github.com/repos/vapier/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/vapier/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/vapier/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/vapier/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/vapier/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/vapier/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vapier/matplotlib/merges","archive_url":"https://api.github.com/repos/vapier/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vapier/matplotlib/downloads","issues_url":"https://api.github.com/repos/vapier/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/vapier/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/vapier/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/vapier/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vapier/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/vapier/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/vapier/matplotlib/deployments","created_at":"2015-05-15T07:24:59Z","updated_at":"2018-05-10T07:35:44Z","pushed_at":"2018-05-10T07:35:41Z","git_url":"git://github.com/vapier/matplotlib.git","ssh_url":"git@github.com:vapier/matplotlib.git","clone_url":"https://github.com/vapier/matplotlib.git","svn_url":"https://github.com/vapier/matplotlib","homepage":"http://matplotlib.org/","size":326984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"4d1ca36d64af1c0a53b6eceb8292144715ebef3e","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-05-29T00:31:48Z","pushed_at":"2018-05-29T00:31:06Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":327700,"stargazers_count":7359,"watchers_count":7359,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3419,"mirror_url":null,"archived":false,"open_issues_count":1337,"license":null,"forks":3419,"open_issues":1337,"watchers":7359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/11218"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11218"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11218/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11218/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/9510849e245f4489d955ceecb98ce99abc1edf8d"}},"author_association":"NONE"}} | {
"id": 1385122,
"name": "matplotlib/matplotlib",
"url": "https://api.github.com/repos/matplotlib/matplotlib"
} | {
"id": 1322974,
"login": "anntzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1322974?",
"url": "https://api.github.com/users/anntzer"
} | {
"id": 215947,
"login": "matplotlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215947?",
"url": "https://api.github.com/orgs/matplotlib"
} | 2018-05-29T00:32:01 | 7740737966 | {"actor":{"display_login":"anntzer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/voyager/pulls/comments/219799629","pull_request_review_id":158057127,"id":219799629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTc5OTYyOQ==","diff_hunk":"@@ -251,107 +253,209 @@ describe(`onStake`, () => {\n })\n \n describe(`submitDelegation`, () => {\n- it(`success`, async () => {\n- const $store = {\n- commit: jest.fn(),\n- dispatch: jest.fn(),\n- getters: getterValues\n- }\n-\n- const {\n- vm: { submitDelegation }\n- } = mount(PageValidator, {\n- mocks: {\n- $route: { params: { validator: `1a2b3c` } },\n- $store\n+ describe(`unit`, () => {\n+ it(`success`, async () => {\n+ const $store = {\n+ commit: jest.fn(),\n+ dispatch: jest.fn(),\n+ getters: getterValues\n }\n- })\n-\n- await submitDelegation({ amount: 10 })\n-\n- expect($store.dispatch.mock.calls).toEqual([\n- [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n- ])\n \n- expect($store.commit.mock.calls).toEqual([\n- [\n- `notify`,\n- {\n- body: `You have successfully staked your atoms.`,\n- title: `Successful Staking!`\n+ const {\n+ vm: { submitDelegation }\n+ } = mount(PageValidator, {\n+ mocks: {\n+ $route: { params: { validator: `1a2b3c` } },\n+ $store\n }\n- ]\n- ])\n- })\n-\n- it(`error`, async () => {\n- const $store = {\n- commit: jest.fn(),\n- dispatch: jest.fn(() => {\n- throw new Error(`message`)\n- }),\n- getters: getterValues\n- }\n+ })\n \n- const {\n- vm: { submitDelegation }\n- } = mount(PageValidator, {\n- mocks: {\n- $route: { params: { validator: `1a2b3c` } },\n- $store\n- }\n+ await submitDelegation({ amount: 10 })\n+\n+ expect($store.dispatch.mock.calls).toEqual([\n+ [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n+ ])\n+\n+ expect($store.commit.mock.calls).toEqual([\n+ [\n+ `notify`,\n+ {\n+ body: `You have successfully staked your atoms.`,\n+ title: `Successful Staking!`\n+ }\n+ ]\n+ ])\n })\n \n- await submitDelegation({ amount: 10 })\n-\n- expect($store.dispatch.mock.calls).toEqual([\n- [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n- ])\n+ it(`error`, async () => {\n+ const $store = {\n+ commit: jest.fn(),\n+ dispatch: jest.fn(() => {\n+ throw new Error(`message`)\n+ }),\n+ getters: getterValues\n+ }\n \n- expect($store.commit.mock.calls).toEqual([\n- [\n- `notifyError`,\n- {\n- body: `message`,\n- title: `Error While Staking atoms`\n+ const {\n+ vm: { submitDelegation }\n+ } = mount(PageValidator, {\n+ mocks: {\n+ $route: { params: { validator: `1a2b3c` } },\n+ $store\n }\n- ]\n- ])\n- })\n+ })\n \n- it(`error with data`, async () => {\n- const $store = {\n- commit: jest.fn(),\n- dispatch: jest.fn(() => {\n- throw new Error(`one\\ntwo\\nthree\\nfour\\nfive\\nsix\"seven`)\n- }),\n- getters: getterValues\n- }\n+ await submitDelegation({ amount: 10 })\n+\n+ expect($store.dispatch.mock.calls).toEqual([\n+ [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n+ ])\n+\n+ expect($store.commit.mock.calls).toEqual([\n+ [\n+ `notifyError`,\n+ {\n+ body: `message`,\n+ title: `Error While Staking atoms`\n+ }\n+ ]\n+ ])\n+ })\n \n- const {\n- vm: { submitDelegation }\n- } = mount(PageValidator, {\n- mocks: {\n- $route: { params: { validator: `1a2b3c` } },\n- $store\n+ it(`error with data`, async () => {\n+ const $store = {\n+ commit: jest.fn(),\n+ dispatch: jest.fn(() => {\n+ throw new Error(`one\\ntwo\\nthree\\nfour\\nfive\\nsix\"seven`)\n+ }),\n+ getters: getterValues\n }\n+\n+ const {\n+ vm: { submitDelegation }\n+ } = mount(PageValidator, {\n+ mocks: {\n+ $route: { params: { validator: `1a2b3c` } },\n+ $store\n+ }\n+ })\n+\n+ await submitDelegation({ amount: 10 })\n+\n+ expect($store.dispatch.mock.calls).toEqual([\n+ [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n+ ])\n+\n+ expect($store.commit.mock.calls).toEqual([\n+ [\n+ `notifyError`,\n+ {\n+ body: `Seven`,\n+ title: `Error While Staking atoms`\n+ }\n+ ]\n+ ])\n })\n+ })\n+\n+ describe(`composition`, () => {\n+ it(`delegation.submitDelegation`, async () => {\n+ const delegation = Delegation({})\n \n- await submitDelegation({ amount: 10 })\n+ const dispatch = jest.fn((type, payload) => {\n+ if (type === `submitDelegation`) {\n+ delegation.actions[type]($store, payload)\n+ }\n+ })\n \n- expect($store.dispatch.mock.calls).toEqual([\n- [`submitDelegation`, [{ atoms: BigNumber(10), delegate }]]\n- ])\n+ const $store = {\n+ commit: jest.fn(),\n+ dispatch,\n+ getters: getterValues,\n+ rootState: getterValues,\n+ state: {\n+ committedDelegates: { \"1a2b3c\": 0 },\n+ unbondingDelegations: {}\n+ }\n+ }\n \n- expect($store.commit.mock.calls).toEqual([\n- [\n- `notifyError`,\n- {\n- body: `Seven`,\n- title: `Error While Staking atoms`\n+ const {\n+ vm: { submitDelegation }\n+ } = mount(PageValidator, {\n+ mocks: {\n+ $route: { params: { validator: `1a2b3c` } },\n+ $store\n }\n- ]\n- ])\n+ })\n+\n+ await submitDelegation({ amount: 10 })\n+\n+ expect($store.dispatch.mock.calls).toEqual([","path":"test/unit/specs/components/staking/PageValidator.spec.js","position":197,"original_position":257,"commit_id":"e3e1271d9812a8d7a67afc0ee8c49319bd34a02c","original_commit_id":"e3e1271d9812a8d7a67afc0ee8c49319bd34a02c","user":{"login":"faboweb","id":5869273,"node_id":"MDQ6VXNlcjU4NjkyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5869273?v=4","gravatar_id":"","url":"https://api.github.com/users/faboweb","html_url":"https://github.com/faboweb","followers_url":"https://api.github.com/users/faboweb/followers","following_url":"https://api.github.com/users/faboweb/following{/other_user}","gists_url":"https://api.github.com/users/faboweb/gists{/gist_id}","starred_url":"https://api.github.com/users/faboweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faboweb/subscriptions","organizations_url":"https://api.github.com/users/faboweb/orgs","repos_url":"https://api.github.com/users/faboweb/repos","events_url":"https://api.github.com/users/faboweb/events{/privacy}","received_events_url":"https://api.github.com/users/faboweb/received_events","type":"User","site_admin":false},"body":"> They're stored in a separate file so you can't see what the test is expecting easily\r\n\r\ntrue.\r\n\r\n> They require an external tool to manipulate (instead of just your code editor)\r\n\r\nfalse.\r\n\r\nI agree with `simpler = better`. But it is a lot more comfortable to update snapshots then go through code on a format change and change all the expected values. Let's discuss it.","created_at":"2018-09-24T11:12:06Z","updated_at":"2018-09-24T11:12:06Z","html_url":"https://github.com/cosmos/voyager/pull/1323#discussion_r219799629","pull_request_url":"https://api.github.com/repos/cosmos/voyager/pulls/1323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/comments/219799629"},"html":{"href":"https://github.com/cosmos/voyager/pull/1323#discussion_r219799629"},"pull_request":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/1323"}},"in_reply_to_id":219110504},"pull_request":{"url":"https://api.github.com/repos/cosmos/voyager/pulls/1323","id":216505376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTA1Mzc2","html_url":"https://github.com/cosmos/voyager/pull/1323","diff_url":"https://github.com/cosmos/voyager/pull/1323.diff","patch_url":"https://github.com/cosmos/voyager/pull/1323.patch","issue_url":"https://api.github.com/repos/cosmos/voyager/issues/1323","number":1323,"state":"open","locked":false,"title":"composition test & close buttons for new delegation implementation","user":{"login":"NodeGuy","id":2148537,"node_id":"MDQ6VXNlcjIxNDg1Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2148537?v=4","gravatar_id":"","url":"https://api.github.com/users/NodeGuy","html_url":"https://github.com/NodeGuy","followers_url":"https://api.github.com/users/NodeGuy/followers","following_url":"https://api.github.com/users/NodeGuy/following{/other_user}","gists_url":"https://api.github.com/users/NodeGuy/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeGuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeGuy/subscriptions","organizations_url":"https://api.github.com/users/NodeGuy/orgs","repos_url":"https://api.github.com/users/NodeGuy/repos","events_url":"https://api.github.com/users/NodeGuy/events{/privacy}","received_events_url":"https://api.github.com/users/NodeGuy/received_events","type":"User","site_admin":false},"body":"Make progress against #1219\r\n\r\nDescription:\r\n\r\nAdds a composition test and close buttons to the new Stake modal.\r\n\r\n\r\n\r\n","created_at":"2018-09-19T03:41:11Z","updated_at":"2018-09-24T11:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bae0b68d4502c3356e7517f2a93212cd23231d68","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nylira","id":172531,"node_id":"MDQ6VXNlcjE3MjUzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/172531?v=4","gravatar_id":"","url":"https://api.github.com/users/nylira","html_url":"https://github.com/nylira","followers_url":"https://api.github.com/users/nylira/followers","following_url":"https://api.github.com/users/nylira/following{/other_user}","gists_url":"https://api.github.com/users/nylira/gists{/gist_id}","starred_url":"https://api.github.com/users/nylira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylira/subscriptions","organizations_url":"https://api.github.com/users/nylira/orgs","repos_url":"https://api.github.com/users/nylira/repos","events_url":"https://api.github.com/users/nylira/events{/privacy}","received_events_url":"https://api.github.com/users/nylira/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/voyager/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/cosmos/voyager/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/cosmos/voyager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/voyager/issues/1323/comments","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/e3e1271d9812a8d7a67afc0ee8c49319bd34a02c","head":{"label":"cosmos:david/1219-composition-tests","ref":"david/1219-composition-tests","sha":"e3e1271d9812a8d7a67afc0ee8c49319bd34a02c","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":99653950,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY1Mzk1MA==","name":"voyager","full_name":"cosmos/voyager","private":false,"owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cosmos/voyager","description":"Cosmos Voyager — the user interface for the Cosmos Network. ✨","fork":false,"url":"https://api.github.com/repos/cosmos/voyager","forks_url":"https://api.github.com/repos/cosmos/voyager/forks","keys_url":"https://api.github.com/repos/cosmos/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/voyager/teams","hooks_url":"https://api.github.com/repos/cosmos/voyager/hooks","issue_events_url":"https://api.github.com/repos/cosmos/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/voyager/events","assignees_url":"https://api.github.com/repos/cosmos/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/voyager/tags","blobs_url":"https://api.github.com/repos/cosmos/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/voyager/languages","stargazers_url":"https://api.github.com/repos/cosmos/voyager/stargazers","contributors_url":"https://api.github.com/repos/cosmos/voyager/contributors","subscribers_url":"https://api.github.com/repos/cosmos/voyager/subscribers","subscription_url":"https://api.github.com/repos/cosmos/voyager/subscription","commits_url":"https://api.github.com/repos/cosmos/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/voyager/merges","archive_url":"https://api.github.com/repos/cosmos/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/voyager/downloads","issues_url":"https://api.github.com/repos/cosmos/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/voyager/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/voyager/deployments","created_at":"2017-08-08T05:34:48Z","updated_at":"2018-09-22T08:07:01Z","pushed_at":"2018-09-22T08:07:06Z","git_url":"git://github.com/cosmos/voyager.git","ssh_url":"git@github.com:cosmos/voyager.git","clone_url":"https://github.com/cosmos/voyager.git","svn_url":"https://github.com/cosmos/voyager","homepage":"https://cosmos.network/voyager","size":47003,"stargazers_count":119,"watchers_count":119,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":157,"watchers":119,"default_branch":"develop"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"70b27f738b152cd40dda08af16e412ae13656c29","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":99653950,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY1Mzk1MA==","name":"voyager","full_name":"cosmos/voyager","private":false,"owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cosmos/voyager","description":"Cosmos Voyager — the user interface for the Cosmos Network. ✨","fork":false,"url":"https://api.github.com/repos/cosmos/voyager","forks_url":"https://api.github.com/repos/cosmos/voyager/forks","keys_url":"https://api.github.com/repos/cosmos/voyager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/voyager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/voyager/teams","hooks_url":"https://api.github.com/repos/cosmos/voyager/hooks","issue_events_url":"https://api.github.com/repos/cosmos/voyager/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/voyager/events","assignees_url":"https://api.github.com/repos/cosmos/voyager/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/voyager/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/voyager/tags","blobs_url":"https://api.github.com/repos/cosmos/voyager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/voyager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/voyager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/voyager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/voyager/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/voyager/languages","stargazers_url":"https://api.github.com/repos/cosmos/voyager/stargazers","contributors_url":"https://api.github.com/repos/cosmos/voyager/contributors","subscribers_url":"https://api.github.com/repos/cosmos/voyager/subscribers","subscription_url":"https://api.github.com/repos/cosmos/voyager/subscription","commits_url":"https://api.github.com/repos/cosmos/voyager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/voyager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/voyager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/voyager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/voyager/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/voyager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/voyager/merges","archive_url":"https://api.github.com/repos/cosmos/voyager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/voyager/downloads","issues_url":"https://api.github.com/repos/cosmos/voyager/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/voyager/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/voyager/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/voyager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/voyager/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/voyager/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/voyager/deployments","created_at":"2017-08-08T05:34:48Z","updated_at":"2018-09-22T08:07:01Z","pushed_at":"2018-09-22T08:07:06Z","git_url":"git://github.com/cosmos/voyager.git","ssh_url":"git@github.com:cosmos/voyager.git","clone_url":"https://github.com/cosmos/voyager.git","svn_url":"https://github.com/cosmos/voyager","homepage":"https://cosmos.network/voyager","size":47003,"stargazers_count":119,"watchers_count":119,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":157,"watchers":119,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/1323"},"html":{"href":"https://github.com/cosmos/voyager/pull/1323"},"issue":{"href":"https://api.github.com/repos/cosmos/voyager/issues/1323"},"comments":{"href":"https://api.github.com/repos/cosmos/voyager/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/voyager/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/voyager/statuses/e3e1271d9812a8d7a67afc0ee8c49319bd34a02c"}},"author_association":"COLLABORATOR"}} | {
"id": 99653950,
"name": "cosmos/voyager",
"url": "https://api.github.com/repos/cosmos/voyager"
} | {
"id": 5869273,
"login": "faboweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5869273?",
"url": "https://api.github.com/users/faboweb"
} | {
"id": 228843,
"login": "cosmos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/228843?",
"url": "https://api.github.com/orgs/cosmos"
} | 2018-09-24T11:12:06 | 8310555126 | {"actor":{"display_login":"faboweb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/210900033","pull_request_review_id":147213430,"id":210900033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDkwMDAzMw==","diff_hunk":"@@ -109,20 +110,46 @@ You can also check your balance at a given block by using the `--block` flag:\n gaiacli account <account_cosmosaccaddr> --block=<block_height>\n ```\n \n-### Delegate\n+### Staking\n+\n+#### Set up a Validator\n+\n+Please refer to the [Validator Setup](https://cosmos.network/docs/validators/validator-setup.html) section for a more complete guide on how to set up a validator-candidate.\n+\n+#### Delegate to a Validator\n \n On the upcoming mainnet, you can delegate `atom` to a validator. These [delegators](/resources/delegators-faq) can receive part of the validator's fee revenue. Read more about the [Cosmos Token Model](https://github.com/cosmos/cosmos/raw/master/Cosmos_Token_Model.pdf).\n \n-### Bond Tokens\n+##### Query Validators\n \n-On the testnet, we delegate `steak` instead of `atom`. Here's how you can bond tokens to a testnet validator:\n+You can query the list of all validators of a specific chain:\n+\n+```bash\n+gaiacli stake validators \\\n+\t--chain-id=gaia-8000\n+```\n+\n+If you want to get the information of a single validator you can check it with:\n+\n+```bash\n+gaiacli stake validator <account_cosmosaccaddr> \\\n+\t--chain-id=gaia-8000\n+```\n+\n+#### Bond Tokens\n+\n+On the testnet, we delegate `steak` instead of `atom`. Here's how you can bond tokens to a testnet validator (*i.e.* delegate):\n \n ```bash\n gaiacli stake delegate \\\n --amount=10steak \\\n --address-validator=$(gaiad tendermint show_validator) \\\n --name=<key_name> \\\n+<<<<<<< HEAD","path":"docs/sdk/clients.md","position":107,"original_position":107,"commit_id":"51cb440ca1a5f76cb4ade657c036b7777a0f4db1","original_commit_id":"51cb440ca1a5f76cb4ade657c036b7777a0f4db1","user":{"login":"cwgoes","id":24760279,"node_id":"MDQ6VXNlcjI0NzYwMjc5","avatar_url":"https://avatars2.githubusercontent.com/u/24760279?v=4","gravatar_id":"","url":"https://api.github.com/users/cwgoes","html_url":"https://github.com/cwgoes","followers_url":"https://api.github.com/users/cwgoes/followers","following_url":"https://api.github.com/users/cwgoes/following{/other_user}","gists_url":"https://api.github.com/users/cwgoes/gists{/gist_id}","starred_url":"https://api.github.com/users/cwgoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwgoes/subscriptions","organizations_url":"https://api.github.com/users/cwgoes/orgs","repos_url":"https://api.github.com/users/cwgoes/repos","events_url":"https://api.github.com/users/cwgoes/events{/privacy}","received_events_url":"https://api.github.com/users/cwgoes/received_events","type":"User","site_admin":false},"body":"Accidental?","created_at":"2018-08-17T12:56:32Z","updated_at":"2018-08-17T12:57:45Z","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2076#discussion_r210900033","pull_request_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/210900033"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2076#discussion_r210900033"},"pull_request":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076"}}},"pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076","id":209138718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTM4NzE4","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2076","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/2076.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/2076.patch","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2076","number":2076,"state":"open","locked":false,"title":"Update cli docs, ","user":{"login":"fedekunze","id":31522760,"node_id":"MDQ6VXNlcjMxNTIyNzYw","avatar_url":"https://avatars0.githubusercontent.com/u/31522760?v=4","gravatar_id":"","url":"https://api.github.com/users/fedekunze","html_url":"https://github.com/fedekunze","followers_url":"https://api.github.com/users/fedekunze/followers","following_url":"https://api.github.com/users/fedekunze/following{/other_user}","gists_url":"https://api.github.com/users/fedekunze/gists{/gist_id}","starred_url":"https://api.github.com/users/fedekunze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedekunze/subscriptions","organizations_url":"https://api.github.com/users/fedekunze/orgs","repos_url":"https://api.github.com/users/fedekunze/repos","events_url":"https://api.github.com/users/fedekunze/events{/privacy}","received_events_url":"https://api.github.com/users/fedekunze/received_events","type":"User","site_admin":false},"body":"<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺\r\nv ✰ Thanks for creating a PR! ✰ \r\nv Before smashing the submit button please review the checkboxes.\r\nv If a checkbox is n/a - please still include it but + a little note why\r\n☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->\r\n\r\nCloses #2026\r\n\r\n---\r\n- [x] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.\r\n- [x] Updated all relevant documentation (`docs/`)\r\n- [x] Updated all relevant code comments\r\n- [ ] Wrote tests\r\n- [ ] Added entries in `PENDING.md` that include links to the relevant issue or PR that most accurately describes the change.\r\n- [ ] Updated `cmd/gaia` and `examples/`\r\n___________________________________\r\nFor Admin Use:\r\n- [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)\r\n- [ ] Reviewers Assigned\r\n- [ ] Squashed all commits, uses message \"Merge pull request #XYZ: [title]\" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))\r\n","created_at":"2018-08-17T12:52:20Z","updated_at":"2018-08-17T12:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a72c47a80430d8d1fb1a06d3b79662a906be599a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jackzampolin","id":7452680,"node_id":"MDQ6VXNlcjc0NTI2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7452680?v=4","gravatar_id":"","url":"https://api.github.com/users/jackzampolin","html_url":"https://github.com/jackzampolin","followers_url":"https://api.github.com/users/jackzampolin/followers","following_url":"https://api.github.com/users/jackzampolin/following{/other_user}","gists_url":"https://api.github.com/users/jackzampolin/gists{/gist_id}","starred_url":"https://api.github.com/users/jackzampolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackzampolin/subscriptions","organizations_url":"https://api.github.com/users/jackzampolin/orgs","repos_url":"https://api.github.com/users/jackzampolin/repos","events_url":"https://api.github.com/users/jackzampolin/events{/privacy}","received_events_url":"https://api.github.com/users/jackzampolin/received_events","type":"User","site_admin":false},{"login":"zramsay","id":8304391,"node_id":"MDQ6VXNlcjgzMDQzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8304391?v=4","gravatar_id":"","url":"https://api.github.com/users/zramsay","html_url":"https://github.com/zramsay","followers_url":"https://api.github.com/users/zramsay/followers","following_url":"https://api.github.com/users/zramsay/following{/other_user}","gists_url":"https://api.github.com/users/zramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/zramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zramsay/subscriptions","organizations_url":"https://api.github.com/users/zramsay/orgs","repos_url":"https://api.github.com/users/zramsay/repos","events_url":"https://api.github.com/users/zramsay/events{/privacy}","received_events_url":"https://api.github.com/users/zramsay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":871015068,"node_id":"MDU6TGFiZWw4NzEwMTUwNjg=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/cli","name":"cli","color":"fafad2","default":false},{"id":529223108,"node_id":"MDU6TGFiZWw1MjkyMjMxMDg=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/docs","name":"docs","color":"d2fafa","default":false},{"id":965477209,"node_id":"MDU6TGFiZWw5NjU0NzcyMDk=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/ready-for-review","name":"ready-for-review","color":"e6fad2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076/commits","review_comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076/comments","review_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2076/comments","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/51cb440ca1a5f76cb4ade657c036b7777a0f4db1","head":{"label":"cosmos:fedekunze/2026-cli-docs","ref":"fedekunze/2026-cli-docs","sha":"51cb440ca1a5f76cb4ade657c036b7777a0f4db1","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/cosmos-sdk","description":"Secure Blockchain Framework","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-08-17T12:00:35Z","pushed_at":"2018-08-17T12:53:01Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":33942,"stargazers_count":523,"watchers_count":523,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":369,"watchers":523,"default_branch":"develop"}},"base":{"label":"cosmos:release/v0.24.0","ref":"release/v0.24.0","sha":"8bb79d12ca0d905f34d734e59479cfba5e6775d1","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/cosmos-sdk","description":"Secure Blockchain Framework","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-08-17T12:00:35Z","pushed_at":"2018-08-17T12:53:01Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":33942,"stargazers_count":523,"watchers_count":523,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":369,"watchers":523,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2076"},"issue":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2076"},"comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2076/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2076/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/51cb440ca1a5f76cb4ade657c036b7777a0f4db1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51193526,
"name": "cosmos/cosmos-sdk",
"url": "https://api.github.com/repos/cosmos/cosmos-sdk"
} | {
"id": 24760279,
"login": "cwgoes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24760279?",
"url": "https://api.github.com/users/cwgoes"
} | {
"id": 228843,
"login": "cosmos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/228843?",
"url": "https://api.github.com/orgs/cosmos"
} | 2018-08-17T12:56:32 | 8128740321 | {"actor":{"display_login":"cwgoes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/racket/racket/pulls/comments/233970403","pull_request_review_id":175508482,"id":233970403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk3MDQwMw==","diff_hunk":"@@ -1,13 +1,17 @@\n #lang racket/base\n (require (for-syntax racket/base)\n \"private/truncate-path.rkt\"\n- \"private/relative-path.rkt\")\n+ \"private/relative-path.rkt\"\n+ (rename-in racket/base [write-byte r:write-byte]))\n \n (provide s-exp->fasl\n fasl->s-exp)\n \n ;; ----------------------------------------\n \n+(define (write-byte byte out)","path":"racket/collects/racket/fasl.rkt","position":13,"original_position":13,"commit_id":"2d01dc0acc584a89eaa356432d62638ac2a36d09","original_commit_id":"2d01dc0acc584a89eaa356432d62638ac2a36d09","user":{"login":"samth","id":244723,"node_id":"MDQ6VXNlcjI0NDcyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/244723?v=4","gravatar_id":"","url":"https://api.github.com/users/samth","html_url":"https://github.com/samth","followers_url":"https://api.github.com/users/samth/followers","following_url":"https://api.github.com/users/samth/following{/other_user}","gists_url":"https://api.github.com/users/samth/gists{/gist_id}","starred_url":"https://api.github.com/users/samth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samth/subscriptions","organizations_url":"https://api.github.com/users/samth/orgs","repos_url":"https://api.github.com/users/samth/repos","events_url":"https://api.github.com/users/samth/events{/privacy}","received_events_url":"https://api.github.com/users/samth/received_events","type":"User","site_admin":false},"body":"I suggested this approach because it makes it harder to misuse, since you'd have to write `r:write-bytes` to do the wrong thing.","created_at":"2018-11-15T19:04:39Z","updated_at":"2018-11-15T19:04:39Z","html_url":"https://github.com/racket/racket/pull/2373#discussion_r233970403","pull_request_url":"https://api.github.com/repos/racket/racket/pulls/2373","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/racket/racket/pulls/comments/233970403"},"html":{"href":"https://github.com/racket/racket/pull/2373#discussion_r233970403"},"pull_request":{"href":"https://api.github.com/repos/racket/racket/pulls/2373"}},"in_reply_to_id":233967183},"pull_request":{"url":"https://api.github.com/repos/racket/racket/pulls/2373","id":231296076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjk2MDc2","html_url":"https://github.com/racket/racket/pull/2373","diff_url":"https://github.com/racket/racket/pull/2373.diff","patch_url":"https://github.com/racket/racket/pull/2373.patch","issue_url":"https://api.github.com/repos/racket/racket/issues/2373","number":2373,"state":"open","locked":false,"title":"fasl: make sure every write-bytes know where to write","user":{"login":"cderici","id":120652,"node_id":"MDQ6VXNlcjEyMDY1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/120652?v=4","gravatar_id":"","url":"https://api.github.com/users/cderici","html_url":"https://github.com/cderici","followers_url":"https://api.github.com/users/cderici/followers","following_url":"https://api.github.com/users/cderici/following{/other_user}","gists_url":"https://api.github.com/users/cderici/gists{/gist_id}","starred_url":"https://api.github.com/users/cderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cderici/subscriptions","organizations_url":"https://api.github.com/users/cderici/orgs","repos_url":"https://api.github.com/users/cderici/repos","events_url":"https://api.github.com/users/cderici/events{/privacy}","received_events_url":"https://api.github.com/users/cderici/received_events","type":"User","site_admin":false},"body":"adding tests that fail without this fix","created_at":"2018-11-15T18:44:08Z","updated_at":"2018-11-15T19:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3879039211cd14cec2537949733e0cbe4b4c48c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/racket/racket/pulls/2373/commits","review_comments_url":"https://api.github.com/repos/racket/racket/pulls/2373/comments","review_comment_url":"https://api.github.com/repos/racket/racket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/racket/racket/issues/2373/comments","statuses_url":"https://api.github.com/repos/racket/racket/statuses/2d01dc0acc584a89eaa356432d62638ac2a36d09","head":{"label":"cderici:fasl-write-fix","ref":"fasl-write-fix","sha":"2d01dc0acc584a89eaa356432d62638ac2a36d09","user":{"login":"cderici","id":120652,"node_id":"MDQ6VXNlcjEyMDY1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/120652?v=4","gravatar_id":"","url":"https://api.github.com/users/cderici","html_url":"https://github.com/cderici","followers_url":"https://api.github.com/users/cderici/followers","following_url":"https://api.github.com/users/cderici/following{/other_user}","gists_url":"https://api.github.com/users/cderici/gists{/gist_id}","starred_url":"https://api.github.com/users/cderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cderici/subscriptions","organizations_url":"https://api.github.com/users/cderici/orgs","repos_url":"https://api.github.com/users/cderici/repos","events_url":"https://api.github.com/users/cderici/events{/privacy}","received_events_url":"https://api.github.com/users/cderici/received_events","type":"User","site_admin":false},"repo":{"id":133993674,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTM2NzQ=","name":"racket","full_name":"cderici/racket","private":false,"owner":{"login":"cderici","id":120652,"node_id":"MDQ6VXNlcjEyMDY1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/120652?v=4","gravatar_id":"","url":"https://api.github.com/users/cderici","html_url":"https://github.com/cderici","followers_url":"https://api.github.com/users/cderici/followers","following_url":"https://api.github.com/users/cderici/following{/other_user}","gists_url":"https://api.github.com/users/cderici/gists{/gist_id}","starred_url":"https://api.github.com/users/cderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cderici/subscriptions","organizations_url":"https://api.github.com/users/cderici/orgs","repos_url":"https://api.github.com/users/cderici/repos","events_url":"https://api.github.com/users/cderici/events{/privacy}","received_events_url":"https://api.github.com/users/cderici/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cderici/racket","description":"The Racket repository","fork":true,"url":"https://api.github.com/repos/cderici/racket","forks_url":"https://api.github.com/repos/cderici/racket/forks","keys_url":"https://api.github.com/repos/cderici/racket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cderici/racket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cderici/racket/teams","hooks_url":"https://api.github.com/repos/cderici/racket/hooks","issue_events_url":"https://api.github.com/repos/cderici/racket/issues/events{/number}","events_url":"https://api.github.com/repos/cderici/racket/events","assignees_url":"https://api.github.com/repos/cderici/racket/assignees{/user}","branches_url":"https://api.github.com/repos/cderici/racket/branches{/branch}","tags_url":"https://api.github.com/repos/cderici/racket/tags","blobs_url":"https://api.github.com/repos/cderici/racket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cderici/racket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cderici/racket/git/refs{/sha}","trees_url":"https://api.github.com/repos/cderici/racket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cderici/racket/statuses/{sha}","languages_url":"https://api.github.com/repos/cderici/racket/languages","stargazers_url":"https://api.github.com/repos/cderici/racket/stargazers","contributors_url":"https://api.github.com/repos/cderici/racket/contributors","subscribers_url":"https://api.github.com/repos/cderici/racket/subscribers","subscription_url":"https://api.github.com/repos/cderici/racket/subscription","commits_url":"https://api.github.com/repos/cderici/racket/commits{/sha}","git_commits_url":"https://api.github.com/repos/cderici/racket/git/commits{/sha}","comments_url":"https://api.github.com/repos/cderici/racket/comments{/number}","issue_comment_url":"https://api.github.com/repos/cderici/racket/issues/comments{/number}","contents_url":"https://api.github.com/repos/cderici/racket/contents/{+path}","compare_url":"https://api.github.com/repos/cderici/racket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cderici/racket/merges","archive_url":"https://api.github.com/repos/cderici/racket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cderici/racket/downloads","issues_url":"https://api.github.com/repos/cderici/racket/issues{/number}","pulls_url":"https://api.github.com/repos/cderici/racket/pulls{/number}","milestones_url":"https://api.github.com/repos/cderici/racket/milestones{/number}","notifications_url":"https://api.github.com/repos/cderici/racket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cderici/racket/labels{/name}","releases_url":"https://api.github.com/repos/cderici/racket/releases{/id}","deployments_url":"https://api.github.com/repos/cderici/racket/deployments","created_at":"2018-05-18T19:02:32Z","updated_at":"2018-11-15T17:47:56Z","pushed_at":"2018-11-15T18:43:00Z","git_url":"git://github.com/cderici/racket.git","ssh_url":"git@github.com:cderici/racket.git","clone_url":"https://github.com/cderici/racket.git","svn_url":"https://github.com/cderici/racket","homepage":"https://racket-lang.org/","size":187808,"stargazers_count":0,"watchers_count":0,"language":"Racket","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"racket:master","ref":"master","sha":"06101ffb8920b6db8f3007113d1fe392e25df4b6","user":{"login":"racket","id":232371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/232371?v=4","gravatar_id":"","url":"https://api.github.com/users/racket","html_url":"https://github.com/racket","followers_url":"https://api.github.com/users/racket/followers","following_url":"https://api.github.com/users/racket/following{/other_user}","gists_url":"https://api.github.com/users/racket/gists{/gist_id}","starred_url":"https://api.github.com/users/racket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racket/subscriptions","organizations_url":"https://api.github.com/users/racket/orgs","repos_url":"https://api.github.com/users/racket/repos","events_url":"https://api.github.com/users/racket/events{/privacy}","received_events_url":"https://api.github.com/users/racket/received_events","type":"Organization","site_admin":false},"repo":{"id":615969,"node_id":"MDEwOlJlcG9zaXRvcnk2MTU5Njk=","name":"racket","full_name":"racket/racket","private":false,"owner":{"login":"racket","id":232371,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/232371?v=4","gravatar_id":"","url":"https://api.github.com/users/racket","html_url":"https://github.com/racket","followers_url":"https://api.github.com/users/racket/followers","following_url":"https://api.github.com/users/racket/following{/other_user}","gists_url":"https://api.github.com/users/racket/gists{/gist_id}","starred_url":"https://api.github.com/users/racket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racket/subscriptions","organizations_url":"https://api.github.com/users/racket/orgs","repos_url":"https://api.github.com/users/racket/repos","events_url":"https://api.github.com/users/racket/events{/privacy}","received_events_url":"https://api.github.com/users/racket/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/racket/racket","description":"The Racket repository","fork":false,"url":"https://api.github.com/repos/racket/racket","forks_url":"https://api.github.com/repos/racket/racket/forks","keys_url":"https://api.github.com/repos/racket/racket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racket/racket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racket/racket/teams","hooks_url":"https://api.github.com/repos/racket/racket/hooks","issue_events_url":"https://api.github.com/repos/racket/racket/issues/events{/number}","events_url":"https://api.github.com/repos/racket/racket/events","assignees_url":"https://api.github.com/repos/racket/racket/assignees{/user}","branches_url":"https://api.github.com/repos/racket/racket/branches{/branch}","tags_url":"https://api.github.com/repos/racket/racket/tags","blobs_url":"https://api.github.com/repos/racket/racket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racket/racket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racket/racket/git/refs{/sha}","trees_url":"https://api.github.com/repos/racket/racket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racket/racket/statuses/{sha}","languages_url":"https://api.github.com/repos/racket/racket/languages","stargazers_url":"https://api.github.com/repos/racket/racket/stargazers","contributors_url":"https://api.github.com/repos/racket/racket/contributors","subscribers_url":"https://api.github.com/repos/racket/racket/subscribers","subscription_url":"https://api.github.com/repos/racket/racket/subscription","commits_url":"https://api.github.com/repos/racket/racket/commits{/sha}","git_commits_url":"https://api.github.com/repos/racket/racket/git/commits{/sha}","comments_url":"https://api.github.com/repos/racket/racket/comments{/number}","issue_comment_url":"https://api.github.com/repos/racket/racket/issues/comments{/number}","contents_url":"https://api.github.com/repos/racket/racket/contents/{+path}","compare_url":"https://api.github.com/repos/racket/racket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racket/racket/merges","archive_url":"https://api.github.com/repos/racket/racket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racket/racket/downloads","issues_url":"https://api.github.com/repos/racket/racket/issues{/number}","pulls_url":"https://api.github.com/repos/racket/racket/pulls{/number}","milestones_url":"https://api.github.com/repos/racket/racket/milestones{/number}","notifications_url":"https://api.github.com/repos/racket/racket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racket/racket/labels{/name}","releases_url":"https://api.github.com/repos/racket/racket/releases{/id}","deployments_url":"https://api.github.com/repos/racket/racket/deployments","created_at":"2010-04-18T06:39:16Z","updated_at":"2018-11-15T17:19:59Z","pushed_at":"2018-11-15T18:44:08Z","git_url":"git://github.com/racket/racket.git","ssh_url":"git@github.com:racket/racket.git","clone_url":"https://github.com/racket/racket.git","svn_url":"https://github.com/racket/racket","homepage":"https://racket-lang.org/","size":187893,"stargazers_count":2662,"watchers_count":2662,"language":"Racket","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"open_issues_count":364,"license":null,"forks":427,"open_issues":364,"watchers":2662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/racket/racket/pulls/2373"},"html":{"href":"https://github.com/racket/racket/pull/2373"},"issue":{"href":"https://api.github.com/repos/racket/racket/issues/2373"},"comments":{"href":"https://api.github.com/repos/racket/racket/issues/2373/comments"},"review_comments":{"href":"https://api.github.com/repos/racket/racket/pulls/2373/comments"},"review_comment":{"href":"https://api.github.com/repos/racket/racket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/racket/racket/pulls/2373/commits"},"statuses":{"href":"https://api.github.com/repos/racket/racket/statuses/2d01dc0acc584a89eaa356432d62638ac2a36d09"}},"author_association":"CONTRIBUTOR"}} | {
"id": 615969,
"name": "racket/racket",
"url": "https://api.github.com/repos/racket/racket"
} | {
"id": 244723,
"login": "samth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/244723?",
"url": "https://api.github.com/users/samth"
} | {
"id": 232371,
"login": "racket",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/232371?",
"url": "https://api.github.com/orgs/racket"
} | 2018-11-15T19:04:39 | 8597566797 | {"actor":{"display_login":"samth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/170166302","pull_request_review_id":98811919,"id":170166302,"diff_hunk":"@@ -97,6 +97,29 @@ def octet_string_to_sid_object(bytes)\n end\n module_function :octet_string_to_sid_object\n \n+ def ads_to_sid_object(ads_object)\n+ if !ads_object || !ads_object.respond_to?(:ole_respond_to?) ||\n+ !ads_object.ole_respond_to?(:objectSID) || !ads_object.ole_respond_to?(:Name)\n+ raise Puppet::Util::Windows::Error.new(\"ads_object must be an IAdsUser or IAdsGroup instance\")\n+ end\n+ octet_string_to_sid_object(ads_object.objectSID)\n+ rescue Puppet::Util::Windows::Error => e\n+ # SID could not be mapped but is a valid SID representation\n+ unresolvable = e.code == ERROR_NONE_MAPPED && valid_sid?(ads_object.Name)\n+\n+ raise if !unresolvable\n+\n+ Principal.new(\n+ ads_object.Name + \" (unresolvable)\", # account","path":"lib/puppet/util/windows/sid.rb","position":17,"original_position":17,"commit_id":"d38f17ecfcf04015d315ee225da40ffae21c8d04","original_commit_id":"d38f17ecfcf04015d315ee225da40ffae21c8d04","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"@puppetlabs/windows / @joshcooper any thoughts on emitting this additional bit in the string for SIDs that can't be translated? IMHO, it's useful in the `puppet resource` output, but I can understand why it also might be considered extraneous.","created_at":"2018-02-23T04:49:03Z","updated_at":"2018-02-23T04:49:04Z","html_url":"https://github.com/puppetlabs/puppet/pull/6647#discussion_r170166302","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/170166302"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6647#discussion_r170166302"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647","id":169714366,"html_url":"https://github.com/puppetlabs/puppet/pull/6647","diff_url":"https://github.com/puppetlabs/puppet/pull/6647.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/6647.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6647","number":6647,"state":"open","locked":false,"title":"(WIP)(PUP-7326) Handle Windows unresolvable SIDs","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-16T20:07:44Z","updated_at":"2018-02-23T04:49:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7ac05ad58bdf7ff82687e9cec41e391a72421a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6647/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/d38f17ecfcf04015d315ee225da40ffae21c8d04","head":{"label":"Iristyle:PUP-7326-handle-unresolvable-SIDs-in-Windows-group","ref":"PUP-7326-handle-unresolvable-SIDs-in-Windows-group","sha":"d38f17ecfcf04015d315ee225da40ffae21c8d04","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"repo":{"id":12253882,"name":"puppet","full_name":"Iristyle/puppet","owner":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Iristyle/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/Iristyle/puppet","forks_url":"https://api.github.com/repos/Iristyle/puppet/forks","keys_url":"https://api.github.com/repos/Iristyle/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Iristyle/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Iristyle/puppet/teams","hooks_url":"https://api.github.com/repos/Iristyle/puppet/hooks","issue_events_url":"https://api.github.com/repos/Iristyle/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/Iristyle/puppet/events","assignees_url":"https://api.github.com/repos/Iristyle/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/Iristyle/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/Iristyle/puppet/tags","blobs_url":"https://api.github.com/repos/Iristyle/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Iristyle/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Iristyle/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Iristyle/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Iristyle/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/Iristyle/puppet/languages","stargazers_url":"https://api.github.com/repos/Iristyle/puppet/stargazers","contributors_url":"https://api.github.com/repos/Iristyle/puppet/contributors","subscribers_url":"https://api.github.com/repos/Iristyle/puppet/subscribers","subscription_url":"https://api.github.com/repos/Iristyle/puppet/subscription","commits_url":"https://api.github.com/repos/Iristyle/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Iristyle/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Iristyle/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Iristyle/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Iristyle/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/Iristyle/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Iristyle/puppet/merges","archive_url":"https://api.github.com/repos/Iristyle/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Iristyle/puppet/downloads","issues_url":"https://api.github.com/repos/Iristyle/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/Iristyle/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/Iristyle/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/Iristyle/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Iristyle/puppet/labels{/name}","releases_url":"https://api.github.com/repos/Iristyle/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/Iristyle/puppet/deployments","created_at":"2013-08-20T20:49:43Z","updated_at":"2015-02-14T00:06:23Z","pushed_at":"2018-02-23T01:41:29Z","git_url":"git://github.com/Iristyle/puppet.git","ssh_url":"git@github.com:Iristyle/puppet.git","clone_url":"https://github.com/Iristyle/puppet.git","svn_url":"https://github.com/Iristyle/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":61268,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:4.10.x","ref":"4.10.x","sha":"aaade42b7897cb9fcddb45b2c41e8753a69d8f0f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2018-02-23T03:34:19Z","pushed_at":"2018-02-23T04:28:22Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":62991,"stargazers_count":4889,"watchers_count":4889,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1983,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1983,"open_issues":41,"watchers":4889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6647"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6647"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6647/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6647/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/d38f17ecfcf04015d315ee225da40ffae21c8d04"}},"author_association":"MEMBER"}} | {
"id": 910744,
"name": "puppetlabs/puppet",
"url": "https://api.github.com/repos/puppetlabs/puppet"
} | {
"id": 394081,
"login": "Iristyle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/394081?",
"url": "https://api.github.com/users/Iristyle"
} | {
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
} | 2018-02-23T04:49:03 | 7285523553 | {"actor":{"display_login":"Iristyle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spotify/reactochart/pulls/comments/192223975","pull_request_review_id":124959850,"id":192223975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjIyMzk3NQ==","diff_hunk":"@@ -849,13 +899,65 @@ export default class SankeyDiagram extends React.Component {\n );\n }\n \n+ function displayStepLabelsIf(\n+ stepLabelText,\n+ stepLabelClassName,\n+ stepLabelStyle,\n+ stepLabelPadding,\n+ nodes\n+ ) {\n+ if (!stepLabelText) {\n+ return null;\n+ }\n+\n+ const depthMapXPos = {};\n+ const depthMapYPos = {};\n+\n+ nodes.forEach(n => {","path":"src/SankeyDiagram.js","position":91,"original_position":91,"commit_id":"f8edb5feebb9626613df30aba072e9581ddf4ccd","original_commit_id":"f8edb5feebb9626613df30aba072e9581ddf4ccd","user":{"login":"krissalvador27","id":5139481,"node_id":"MDQ6VXNlcjUxMzk0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5139481?v=4","gravatar_id":"","url":"https://api.github.com/users/krissalvador27","html_url":"https://github.com/krissalvador27","followers_url":"https://api.github.com/users/krissalvador27/followers","following_url":"https://api.github.com/users/krissalvador27/following{/other_user}","gists_url":"https://api.github.com/users/krissalvador27/gists{/gist_id}","starred_url":"https://api.github.com/users/krissalvador27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krissalvador27/subscriptions","organizations_url":"https://api.github.com/users/krissalvador27/orgs","repos_url":"https://api.github.com/users/krissalvador27/repos","events_url":"https://api.github.com/users/krissalvador27/events{/privacy}","received_events_url":"https://api.github.com/users/krissalvador27/received_events","type":"User","site_admin":false},"body":"these are the nodes returned to us after creating the Sankey graph using d3\r\n\r\nhttps://github.com/d3/d3-sankey#sankey_nodes","created_at":"2018-05-31T20:17:59Z","updated_at":"2018-05-31T20:17:59Z","html_url":"https://github.com/spotify/reactochart/pull/73#discussion_r192223975","pull_request_url":"https://api.github.com/repos/spotify/reactochart/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/comments/192223975"},"html":{"href":"https://github.com/spotify/reactochart/pull/73#discussion_r192223975"},"pull_request":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/73"}},"in_reply_to_id":192126682},"pull_request":{"url":"https://api.github.com/repos/spotify/reactochart/pulls/73","id":191539377,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTM5Mzc3","html_url":"https://github.com/spotify/reactochart/pull/73","diff_url":"https://github.com/spotify/reactochart/pull/73.diff","patch_url":"https://github.com/spotify/reactochart/pull/73.patch","issue_url":"https://api.github.com/repos/spotify/reactochart/issues/73","number":73,"state":"open","locked":false,"title":"Add step labeling to sankey","user":{"login":"krissalvador27","id":5139481,"node_id":"MDQ6VXNlcjUxMzk0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5139481?v=4","gravatar_id":"","url":"https://api.github.com/users/krissalvador27","html_url":"https://github.com/krissalvador27","followers_url":"https://api.github.com/users/krissalvador27/followers","following_url":"https://api.github.com/users/krissalvador27/following{/other_user}","gists_url":"https://api.github.com/users/krissalvador27/gists{/gist_id}","starred_url":"https://api.github.com/users/krissalvador27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krissalvador27/subscriptions","organizations_url":"https://api.github.com/users/krissalvador27/orgs","repos_url":"https://api.github.com/users/krissalvador27/repos","events_url":"https://api.github.com/users/krissalvador27/events{/privacy}","received_events_url":"https://api.github.com/users/krissalvador27/received_events","type":"User","site_admin":false},"body":"Adds step labeling to Sankey. Users must opt in to have labels show up\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-05-30T18:20:41Z","updated_at":"2018-05-31T20:17:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf7996d8d7945bf1784f5e37c93708338d72029","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ariroseonline","id":529109,"node_id":"MDQ6VXNlcjUyOTEwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/529109?v=4","gravatar_id":"","url":"https://api.github.com/users/ariroseonline","html_url":"https://github.com/ariroseonline","followers_url":"https://api.github.com/users/ariroseonline/followers","following_url":"https://api.github.com/users/ariroseonline/following{/other_user}","gists_url":"https://api.github.com/users/ariroseonline/gists{/gist_id}","starred_url":"https://api.github.com/users/ariroseonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariroseonline/subscriptions","organizations_url":"https://api.github.com/users/ariroseonline/orgs","repos_url":"https://api.github.com/users/ariroseonline/repos","events_url":"https://api.github.com/users/ariroseonline/events{/privacy}","received_events_url":"https://api.github.com/users/ariroseonline/received_events","type":"User","site_admin":false},{"login":"dandelany","id":734221,"node_id":"MDQ6VXNlcjczNDIyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734221?v=4","gravatar_id":"","url":"https://api.github.com/users/dandelany","html_url":"https://github.com/dandelany","followers_url":"https://api.github.com/users/dandelany/followers","following_url":"https://api.github.com/users/dandelany/following{/other_user}","gists_url":"https://api.github.com/users/dandelany/gists{/gist_id}","starred_url":"https://api.github.com/users/dandelany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandelany/subscriptions","organizations_url":"https://api.github.com/users/dandelany/orgs","repos_url":"https://api.github.com/users/dandelany/repos","events_url":"https://api.github.com/users/dandelany/events{/privacy}","received_events_url":"https://api.github.com/users/dandelany/received_events","type":"User","site_admin":false},{"login":"mindyyuan","id":16064049,"node_id":"MDQ6VXNlcjE2MDY0MDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/16064049?v=4","gravatar_id":"","url":"https://api.github.com/users/mindyyuan","html_url":"https://github.com/mindyyuan","followers_url":"https://api.github.com/users/mindyyuan/followers","following_url":"https://api.github.com/users/mindyyuan/following{/other_user}","gists_url":"https://api.github.com/users/mindyyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/mindyyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindyyuan/subscriptions","organizations_url":"https://api.github.com/users/mindyyuan/orgs","repos_url":"https://api.github.com/users/mindyyuan/repos","events_url":"https://api.github.com/users/mindyyuan/events{/privacy}","received_events_url":"https://api.github.com/users/mindyyuan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/reactochart/pulls/73/commits","review_comments_url":"https://api.github.com/repos/spotify/reactochart/pulls/73/comments","review_comment_url":"https://api.github.com/repos/spotify/reactochart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/reactochart/issues/73/comments","statuses_url":"https://api.github.com/repos/spotify/reactochart/statuses/f8edb5feebb9626613df30aba072e9581ddf4ccd","head":{"label":"spotify:add-step-labeling-to-sankey","ref":"add-step-labeling-to-sankey","sha":"f8edb5feebb9626613df30aba072e9581ddf4ccd","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":49230386,"node_id":"MDEwOlJlcG9zaXRvcnk0OTIzMDM4Ng==","name":"reactochart","full_name":"spotify/reactochart","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/reactochart","description":":chart_with_upwards_trend: React chart component library (unstable) - http://spotify.github.io/reactochart/docs/","fork":false,"url":"https://api.github.com/repos/spotify/reactochart","forks_url":"https://api.github.com/repos/spotify/reactochart/forks","keys_url":"https://api.github.com/repos/spotify/reactochart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/reactochart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/reactochart/teams","hooks_url":"https://api.github.com/repos/spotify/reactochart/hooks","issue_events_url":"https://api.github.com/repos/spotify/reactochart/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/reactochart/events","assignees_url":"https://api.github.com/repos/spotify/reactochart/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/reactochart/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/reactochart/tags","blobs_url":"https://api.github.com/repos/spotify/reactochart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/reactochart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/reactochart/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/reactochart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/reactochart/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/reactochart/languages","stargazers_url":"https://api.github.com/repos/spotify/reactochart/stargazers","contributors_url":"https://api.github.com/repos/spotify/reactochart/contributors","subscribers_url":"https://api.github.com/repos/spotify/reactochart/subscribers","subscription_url":"https://api.github.com/repos/spotify/reactochart/subscription","commits_url":"https://api.github.com/repos/spotify/reactochart/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/reactochart/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/reactochart/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/reactochart/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/reactochart/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/reactochart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/reactochart/merges","archive_url":"https://api.github.com/repos/spotify/reactochart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/reactochart/downloads","issues_url":"https://api.github.com/repos/spotify/reactochart/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/reactochart/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/reactochart/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/reactochart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/reactochart/labels{/name}","releases_url":"https://api.github.com/repos/spotify/reactochart/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/reactochart/deployments","created_at":"2016-01-07T20:58:18Z","updated_at":"2018-05-27T21:20:57Z","pushed_at":"2018-05-30T18:20:41Z","git_url":"git://github.com/spotify/reactochart.git","ssh_url":"git@github.com:spotify/reactochart.git","clone_url":"https://github.com/spotify/reactochart.git","svn_url":"https://github.com/spotify/reactochart","homepage":"","size":45688,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":6,"watchers":70,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"9e8133b8f6bfd34c2c8692261a493f9c63617d00","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":49230386,"node_id":"MDEwOlJlcG9zaXRvcnk0OTIzMDM4Ng==","name":"reactochart","full_name":"spotify/reactochart","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/reactochart","description":":chart_with_upwards_trend: React chart component library (unstable) - http://spotify.github.io/reactochart/docs/","fork":false,"url":"https://api.github.com/repos/spotify/reactochart","forks_url":"https://api.github.com/repos/spotify/reactochart/forks","keys_url":"https://api.github.com/repos/spotify/reactochart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/reactochart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/reactochart/teams","hooks_url":"https://api.github.com/repos/spotify/reactochart/hooks","issue_events_url":"https://api.github.com/repos/spotify/reactochart/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/reactochart/events","assignees_url":"https://api.github.com/repos/spotify/reactochart/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/reactochart/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/reactochart/tags","blobs_url":"https://api.github.com/repos/spotify/reactochart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/reactochart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/reactochart/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/reactochart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/reactochart/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/reactochart/languages","stargazers_url":"https://api.github.com/repos/spotify/reactochart/stargazers","contributors_url":"https://api.github.com/repos/spotify/reactochart/contributors","subscribers_url":"https://api.github.com/repos/spotify/reactochart/subscribers","subscription_url":"https://api.github.com/repos/spotify/reactochart/subscription","commits_url":"https://api.github.com/repos/spotify/reactochart/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/reactochart/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/reactochart/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/reactochart/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/reactochart/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/reactochart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/reactochart/merges","archive_url":"https://api.github.com/repos/spotify/reactochart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/reactochart/downloads","issues_url":"https://api.github.com/repos/spotify/reactochart/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/reactochart/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/reactochart/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/reactochart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/reactochart/labels{/name}","releases_url":"https://api.github.com/repos/spotify/reactochart/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/reactochart/deployments","created_at":"2016-01-07T20:58:18Z","updated_at":"2018-05-27T21:20:57Z","pushed_at":"2018-05-30T18:20:41Z","git_url":"git://github.com/spotify/reactochart.git","ssh_url":"git@github.com:spotify/reactochart.git","clone_url":"https://github.com/spotify/reactochart.git","svn_url":"https://github.com/spotify/reactochart","homepage":"","size":45688,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":6,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/73"},"html":{"href":"https://github.com/spotify/reactochart/pull/73"},"issue":{"href":"https://api.github.com/repos/spotify/reactochart/issues/73"},"comments":{"href":"https://api.github.com/repos/spotify/reactochart/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/reactochart/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/reactochart/statuses/f8edb5feebb9626613df30aba072e9581ddf4ccd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 49230386,
"name": "spotify/reactochart",
"url": "https://api.github.com/repos/spotify/reactochart"
} | {
"id": 5139481,
"login": "krissalvador27",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5139481?",
"url": "https://api.github.com/users/krissalvador27"
} | {
"id": 251374,
"login": "spotify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/251374?",
"url": "https://api.github.com/orgs/spotify"
} | 2018-05-31T20:17:59 | 7758643605 | {"actor":{"display_login":"krissalvador27"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spotify/scio/pulls/comments/221963497","pull_request_review_id":160736810,"id":221963497,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk2MzQ5Nw==","diff_hunk":"@@ -574,7 +574,13 @@ class ScioContext private[scio] (val options: PipelineOptions, private var artif\n idAttribute: String,\n timestampAttribute: String): SCollection[(T, Map[String, String])] = {\n val io = PubsubIO.withAttributes[T](name, idAttribute, timestampAttribute)\n- this.read(io)(PubsubIO.ReadParam(isSubscription))\n+ val read = this.read(io)(PubsubIO.ReadParam(isSubscription))\n+\n+ if (this.isTest && timestampAttribute != null) {","path":"scio-core/src/main/scala/com/spotify/scio/ScioContext.scala","position":7,"original_position":7,"commit_id":"e09d41cf3556b755801dea86594b99f31ee1ed0b","original_commit_id":"e09d41cf3556b755801dea86594b99f31ee1ed0b","user":{"login":"ClaireMcGinty","id":1360529,"node_id":"MDQ6VXNlcjEzNjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1360529?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaireMcGinty","html_url":"https://github.com/ClaireMcGinty","followers_url":"https://api.github.com/users/ClaireMcGinty/followers","following_url":"https://api.github.com/users/ClaireMcGinty/following{/other_user}","gists_url":"https://api.github.com/users/ClaireMcGinty/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaireMcGinty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaireMcGinty/subscriptions","organizations_url":"https://api.github.com/users/ClaireMcGinty/orgs","repos_url":"https://api.github.com/users/ClaireMcGinty/repos","events_url":"https://api.github.com/users/ClaireMcGinty/events{/privacy}","received_events_url":"https://api.github.com/users/ClaireMcGinty/received_events","type":"User","site_admin":false},"body":"will merge this, then refactor our test IO setup in a different PR.","created_at":"2018-10-02T14:04:10Z","updated_at":"2018-10-02T14:04:10Z","html_url":"https://github.com/spotify/scio/pull/1417#discussion_r221963497","pull_request_url":"https://api.github.com/repos/spotify/scio/pulls/1417","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spotify/scio/pulls/comments/221963497"},"html":{"href":"https://github.com/spotify/scio/pull/1417#discussion_r221963497"},"pull_request":{"href":"https://api.github.com/repos/spotify/scio/pulls/1417"}},"in_reply_to_id":221743024},"pull_request":{"url":"https://api.github.com/repos/spotify/scio/pulls/1417","id":219424395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDI0Mzk1","html_url":"https://github.com/spotify/scio/pull/1417","diff_url":"https://github.com/spotify/scio/pull/1417.diff","patch_url":"https://github.com/spotify/scio/pull/1417.patch","issue_url":"https://api.github.com/repos/spotify/scio/issues/1417","number":1417,"state":"open","locked":false,"title":"Set timestamp attribute in JobTest for PubSubIO (fix #1403)","user":{"login":"ClaireMcGinty","id":1360529,"node_id":"MDQ6VXNlcjEzNjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1360529?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaireMcGinty","html_url":"https://github.com/ClaireMcGinty","followers_url":"https://api.github.com/users/ClaireMcGinty/followers","following_url":"https://api.github.com/users/ClaireMcGinty/following{/other_user}","gists_url":"https://api.github.com/users/ClaireMcGinty/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaireMcGinty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaireMcGinty/subscriptions","organizations_url":"https://api.github.com/users/ClaireMcGinty/orgs","repos_url":"https://api.github.com/users/ClaireMcGinty/repos","events_url":"https://api.github.com/users/ClaireMcGinty/events{/privacy}","received_events_url":"https://api.github.com/users/ClaireMcGinty/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-01T15:45:11Z","updated_at":"2018-10-02T14:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b5e6473510a3b02b39c17a45a4f578cf18f0c66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jto","id":197582,"node_id":"MDQ6VXNlcjE5NzU4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/197582?v=4","gravatar_id":"","url":"https://api.github.com/users/jto","html_url":"https://github.com/jto","followers_url":"https://api.github.com/users/jto/followers","following_url":"https://api.github.com/users/jto/following{/other_user}","gists_url":"https://api.github.com/users/jto/gists{/gist_id}","starred_url":"https://api.github.com/users/jto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jto/subscriptions","organizations_url":"https://api.github.com/users/jto/orgs","repos_url":"https://api.github.com/users/jto/repos","events_url":"https://api.github.com/users/jto/events{/privacy}","received_events_url":"https://api.github.com/users/jto/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/scio/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/spotify/scio/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/spotify/scio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/scio/issues/1417/comments","statuses_url":"https://api.github.com/repos/spotify/scio/statuses/e09d41cf3556b755801dea86594b99f31ee1ed0b","head":{"label":"spotify:claire/pubsub_jobtest_timestamp","ref":"claire/pubsub_jobtest_timestamp","sha":"e09d41cf3556b755801dea86594b99f31ee1ed0b","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":32946662,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk0NjY2Mg==","name":"scio","full_name":"spotify/scio","private":false,"owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotify/scio","description":"A Scala API for Apache Beam and Google Cloud Dataflow.","fork":false,"url":"https://api.github.com/repos/spotify/scio","forks_url":"https://api.github.com/repos/spotify/scio/forks","keys_url":"https://api.github.com/repos/spotify/scio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/scio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/scio/teams","hooks_url":"https://api.github.com/repos/spotify/scio/hooks","issue_events_url":"https://api.github.com/repos/spotify/scio/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/scio/events","assignees_url":"https://api.github.com/repos/spotify/scio/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/scio/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/scio/tags","blobs_url":"https://api.github.com/repos/spotify/scio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/scio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/scio/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/scio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/scio/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/scio/languages","stargazers_url":"https://api.github.com/repos/spotify/scio/stargazers","contributors_url":"https://api.github.com/repos/spotify/scio/contributors","subscribers_url":"https://api.github.com/repos/spotify/scio/subscribers","subscription_url":"https://api.github.com/repos/spotify/scio/subscription","commits_url":"https://api.github.com/repos/spotify/scio/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/scio/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/scio/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/scio/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/scio/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/scio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/scio/merges","archive_url":"https://api.github.com/repos/spotify/scio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/scio/downloads","issues_url":"https://api.github.com/repos/spotify/scio/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/scio/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/scio/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/scio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/scio/labels{/name}","releases_url":"https://api.github.com/repos/spotify/scio/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/scio/deployments","created_at":"2015-03-26T19:07:34Z","updated_at":"2018-10-01T23:17:37Z","pushed_at":"2018-10-02T12:06:20Z","git_url":"git://github.com/spotify/scio.git","ssh_url":"git@github.com:spotify/scio.git","clone_url":"https://github.com/spotify/scio.git","svn_url":"https://github.com/spotify/scio","homepage":"https://spotify.github.io/scio","size":7882,"stargazers_count":1245,"watchers_count":1245,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":201,"open_issues":48,"watchers":1245,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"aa051d14dc6fff224948ba943f957a892d97f926","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":32946662,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk0NjY2Mg==","name":"scio","full_name":"spotify/scio","private":false,"owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotify/scio","description":"A Scala API for Apache Beam and Google Cloud Dataflow.","fork":false,"url":"https://api.github.com/repos/spotify/scio","forks_url":"https://api.github.com/repos/spotify/scio/forks","keys_url":"https://api.github.com/repos/spotify/scio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/scio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/scio/teams","hooks_url":"https://api.github.com/repos/spotify/scio/hooks","issue_events_url":"https://api.github.com/repos/spotify/scio/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/scio/events","assignees_url":"https://api.github.com/repos/spotify/scio/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/scio/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/scio/tags","blobs_url":"https://api.github.com/repos/spotify/scio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/scio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/scio/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/scio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/scio/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/scio/languages","stargazers_url":"https://api.github.com/repos/spotify/scio/stargazers","contributors_url":"https://api.github.com/repos/spotify/scio/contributors","subscribers_url":"https://api.github.com/repos/spotify/scio/subscribers","subscription_url":"https://api.github.com/repos/spotify/scio/subscription","commits_url":"https://api.github.com/repos/spotify/scio/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/scio/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/scio/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/scio/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/scio/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/scio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/scio/merges","archive_url":"https://api.github.com/repos/spotify/scio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/scio/downloads","issues_url":"https://api.github.com/repos/spotify/scio/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/scio/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/scio/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/scio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/scio/labels{/name}","releases_url":"https://api.github.com/repos/spotify/scio/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/scio/deployments","created_at":"2015-03-26T19:07:34Z","updated_at":"2018-10-01T23:17:37Z","pushed_at":"2018-10-02T12:06:20Z","git_url":"git://github.com/spotify/scio.git","ssh_url":"git@github.com:spotify/scio.git","clone_url":"https://github.com/spotify/scio.git","svn_url":"https://github.com/spotify/scio","homepage":"https://spotify.github.io/scio","size":7882,"stargazers_count":1245,"watchers_count":1245,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":201,"open_issues":48,"watchers":1245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/scio/pulls/1417"},"html":{"href":"https://github.com/spotify/scio/pull/1417"},"issue":{"href":"https://api.github.com/repos/spotify/scio/issues/1417"},"comments":{"href":"https://api.github.com/repos/spotify/scio/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/scio/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/scio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/scio/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/scio/statuses/e09d41cf3556b755801dea86594b99f31ee1ed0b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 32946662,
"name": "spotify/scio",
"url": "https://api.github.com/repos/spotify/scio"
} | {
"id": 1360529,
"login": "ClaireMcGinty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1360529?",
"url": "https://api.github.com/users/ClaireMcGinty"
} | {
"id": 251374,
"login": "spotify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/251374?",
"url": "https://api.github.com/orgs/spotify"
} | 2018-10-02T14:04:10 | 8354738397 | {"actor":{"display_login":"ClaireMcGinty"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/224997455","pull_request_review_id":164503551,"id":224997455,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk5NzQ1NQ==","diff_hunk":"@@ -1331,9 +1331,11 @@ def test_singular_values():\n \n \n # CalculusOnlyMatrix tests\n+@XFAIL\n def test_diff():\n x, y = symbols('x y')\n m = CalculusOnlyMatrix(2, 1, [x, y])\n+ # TODO: currently not working as ``_MinimalMatrix`` cannot be sympified:\n assert m.diff(x) == Matrix(2, 1, [1, 0])","path":"sympy/matrices/tests/test_commonmatrix.py","position":null,"original_position":9,"commit_id":"d5fe766fd52a20f78398020c64458250590f2738","original_commit_id":"d5fe766fd52a20f78398020c64458250590f2738","user":{"login":"moorepants","id":276007,"node_id":"MDQ6VXNlcjI3NjAwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/276007?v=4","gravatar_id":"","url":"https://api.github.com/users/moorepants","html_url":"https://github.com/moorepants","followers_url":"https://api.github.com/users/moorepants/followers","following_url":"https://api.github.com/users/moorepants/following{/other_user}","gists_url":"https://api.github.com/users/moorepants/gists{/gist_id}","starred_url":"https://api.github.com/users/moorepants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorepants/subscriptions","organizations_url":"https://api.github.com/users/moorepants/orgs","repos_url":"https://api.github.com/users/moorepants/repos","events_url":"https://api.github.com/users/moorepants/events{/privacy}","received_events_url":"https://api.github.com/users/moorepants/received_events","type":"User","site_admin":false},"body":"This should not be xfailed. It worked before your changes, no?","created_at":"2018-10-14T15:46:14Z","updated_at":"2018-10-14T15:46:14Z","html_url":"https://github.com/sympy/sympy/pull/15390#discussion_r224997455","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/15390","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/224997455"},"html":{"href":"https://github.com/sympy/sympy/pull/15390#discussion_r224997455"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15390"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/15390","id":222695359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjk1MzU5","html_url":"https://github.com/sympy/sympy/pull/15390","diff_url":"https://github.com/sympy/sympy/pull/15390.diff","patch_url":"https://github.com/sympy/sympy/pull/15390.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/15390","number":15390,"state":"open","locked":false,"title":"Partially reverts backwards incompatible changes made in PR 13641","user":{"login":"moorepants","id":276007,"node_id":"MDQ6VXNlcjI3NjAwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/276007?v=4","gravatar_id":"","url":"https://api.github.com/users/moorepants","html_url":"https://github.com/moorepants","followers_url":"https://api.github.com/users/moorepants/followers","following_url":"https://api.github.com/users/moorepants/following{/other_user}","gists_url":"https://api.github.com/users/moorepants/gists{/gist_id}","starred_url":"https://api.github.com/users/moorepants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorepants/subscriptions","organizations_url":"https://api.github.com/users/moorepants/orgs","repos_url":"https://api.github.com/users/moorepants/repos","events_url":"https://api.github.com/users/moorepants/events{/privacy}","received_events_url":"https://api.github.com/users/moorepants/received_events","type":"User","site_admin":false},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\n\r\nPartially reverts #13641 \r\n\r\nFixes #14958 \r\n\r\n#### Brief description of what is fixed or changed\r\n\r\n Reverts backwards incompatible changes to Matrix.diff()\r\n \r\n PR #13641 introduced a new feature: differentiating Matrices by Matrices\r\n and Arrays. To do this, three existing tests were changed, breaking\r\n backwards compatibility. The changes to the code caused\r\n MutableDenseMatrix.diff() to return an ImmutableDenseMatrix. This breaks\r\n user code that relies on the mutability of the matrices. In particular,\r\n it has large effects to the sympy.physics.mechanics code that relies\r\n heavily on matrix differentiation. This PR reverts the three changed\r\n tests, reverts the change to MatrixCalculus.diff() that causes the type\r\n change, and moves all subsequent tests related to differentiating\r\n Matrices with respect to Matrices/Array/etc into an XFAIL test, as they\r\n are now broken.\r\n\r\n\r\n#### Other comments\r\n\r\nThis should be applied as a bugfix patch to SymPy 1.2 and 1.3.\r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. The bot will check your release notes\r\nautomatically to see if they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n\r\n* matrices\r\n * Reverts backwards incompatible change introduced in SymPy 1.2 and 1.3 for matrix differentiation and moves Matrix by Matrix differentiation to expected to fail.\r\n\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2018-10-14T06:05:57Z","updated_at":"2018-10-14T15:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6771d187c49aac4b14f8d7ab5afbf5c3fa199896","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asmeurer","id":71486,"node_id":"MDQ6VXNlcjcxNDg2","avatar_url":"https://avatars3.githubusercontent.com/u/71486?v=4","gravatar_id":"","url":"https://api.github.com/users/asmeurer","html_url":"https://github.com/asmeurer","followers_url":"https://api.github.com/users/asmeurer/followers","following_url":"https://api.github.com/users/asmeurer/following{/other_user}","gists_url":"https://api.github.com/users/asmeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/asmeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmeurer/subscriptions","organizations_url":"https://api.github.com/users/asmeurer/orgs","repos_url":"https://api.github.com/users/asmeurer/repos","events_url":"https://api.github.com/users/asmeurer/events{/privacy}","received_events_url":"https://api.github.com/users/asmeurer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":84627382,"node_id":"MDU6TGFiZWw4NDYyNzM4Mg==","url":"https://api.github.com/repos/sympy/sympy/labels/Critical","name":"Critical","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/15390/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/15390/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/15390/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/d5fe766fd52a20f78398020c64458250590f2738","head":{"label":"moorepants:revert-13641","ref":"revert-13641","sha":"d5fe766fd52a20f78398020c64458250590f2738","user":{"login":"moorepants","id":276007,"node_id":"MDQ6VXNlcjI3NjAwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/276007?v=4","gravatar_id":"","url":"https://api.github.com/users/moorepants","html_url":"https://github.com/moorepants","followers_url":"https://api.github.com/users/moorepants/followers","following_url":"https://api.github.com/users/moorepants/following{/other_user}","gists_url":"https://api.github.com/users/moorepants/gists{/gist_id}","starred_url":"https://api.github.com/users/moorepants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorepants/subscriptions","organizations_url":"https://api.github.com/users/moorepants/orgs","repos_url":"https://api.github.com/users/moorepants/repos","events_url":"https://api.github.com/users/moorepants/events{/privacy}","received_events_url":"https://api.github.com/users/moorepants/received_events","type":"User","site_admin":false},"repo":{"id":1574348,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc0MzQ4","name":"sympy","full_name":"moorepants/sympy","private":false,"owner":{"login":"moorepants","id":276007,"node_id":"MDQ6VXNlcjI3NjAwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/276007?v=4","gravatar_id":"","url":"https://api.github.com/users/moorepants","html_url":"https://github.com/moorepants","followers_url":"https://api.github.com/users/moorepants/followers","following_url":"https://api.github.com/users/moorepants/following{/other_user}","gists_url":"https://api.github.com/users/moorepants/gists{/gist_id}","starred_url":"https://api.github.com/users/moorepants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorepants/subscriptions","organizations_url":"https://api.github.com/users/moorepants/orgs","repos_url":"https://api.github.com/users/moorepants/repos","events_url":"https://api.github.com/users/moorepants/events{/privacy}","received_events_url":"https://api.github.com/users/moorepants/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moorepants/sympy","description":"The main development repo for SymPy","fork":true,"url":"https://api.github.com/repos/moorepants/sympy","forks_url":"https://api.github.com/repos/moorepants/sympy/forks","keys_url":"https://api.github.com/repos/moorepants/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moorepants/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moorepants/sympy/teams","hooks_url":"https://api.github.com/repos/moorepants/sympy/hooks","issue_events_url":"https://api.github.com/repos/moorepants/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/moorepants/sympy/events","assignees_url":"https://api.github.com/repos/moorepants/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/moorepants/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/moorepants/sympy/tags","blobs_url":"https://api.github.com/repos/moorepants/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moorepants/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moorepants/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/moorepants/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moorepants/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/moorepants/sympy/languages","stargazers_url":"https://api.github.com/repos/moorepants/sympy/stargazers","contributors_url":"https://api.github.com/repos/moorepants/sympy/contributors","subscribers_url":"https://api.github.com/repos/moorepants/sympy/subscribers","subscription_url":"https://api.github.com/repos/moorepants/sympy/subscription","commits_url":"https://api.github.com/repos/moorepants/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/moorepants/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/moorepants/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/moorepants/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/moorepants/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/moorepants/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moorepants/sympy/merges","archive_url":"https://api.github.com/repos/moorepants/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moorepants/sympy/downloads","issues_url":"https://api.github.com/repos/moorepants/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/moorepants/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/moorepants/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/moorepants/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moorepants/sympy/labels{/name}","releases_url":"https://api.github.com/repos/moorepants/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/moorepants/sympy/deployments","created_at":"2011-04-05T22:01:14Z","updated_at":"2018-10-03T21:57:31Z","pushed_at":"2018-10-14T14:43:57Z","git_url":"git://github.com/moorepants/sympy.git","ssh_url":"git@github.com:moorepants/sympy.git","clone_url":"https://github.com/moorepants/sympy.git","svn_url":"https://github.com/moorepants/sympy","homepage":"http://sympy.org/","size":97179,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"3e73dbcef8b8cfc875e98016aec467bbb1125d7f","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","private":false,"owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-10-14T14:03:29Z","pushed_at":"2018-10-14T14:44:47Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"https://sympy.org/","size":96021,"stargazers_count":5222,"watchers_count":5222,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2377,"mirror_url":null,"archived":false,"open_issues_count":3463,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2377,"open_issues":3463,"watchers":5222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15390"},"html":{"href":"https://github.com/sympy/sympy/pull/15390"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/15390"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/15390/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15390/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/15390/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/d5fe766fd52a20f78398020c64458250590f2738"}},"author_association":"MEMBER"}} | {
"id": 640534,
"name": "sympy/sympy",
"url": "https://api.github.com/repos/sympy/sympy"
} | {
"id": 276007,
"login": "moorepants",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276007?",
"url": "https://api.github.com/users/moorepants"
} | {
"id": 260832,
"login": "sympy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/260832?",
"url": "https://api.github.com/orgs/sympy"
} | 2018-10-14T15:46:14 | 8417564395 | {"actor":{"display_login":"moorepants"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/222808532","pull_request_review_id":161786382,"id":222808532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjgwODUzMg==","diff_hunk":"@@ -87,7 +89,7 @@ class GalleryEdit extends Component {\n \n \tonSelectImages( images ) {\n \t\tthis.props.setAttributes( {\n-\t\t\timages: images.map( ( image ) => pick( image, [ 'alt', 'caption', 'id', 'link', 'url' ] ) ),\n+\t\t\timages: images.map( ( image ) => pick( image, RELEVANT_MEDIA_FIELDS ) ),","path":"packages/block-library/src/gallery/edit.js","position":14,"original_position":14,"commit_id":"93529d63276101b4626547c74e7203eb7b2b07ba","original_commit_id":"93529d63276101b4626547c74e7203eb7b2b07ba","user":{"login":"gziolo","id":699132,"node_id":"MDQ6VXNlcjY5OTEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"body":"You could export a method out of `( image ) => pick( image, RELEVANT_MEDIA_FIELDS )`:\r\n\r\n```js\r\nexport const piclRelevantMediaFiles = ( image ) => pick( image, RELEVANT_MEDIA_FIELDS );\r\n```\r\n\r\nand also use it inside this file.","created_at":"2018-10-04T20:02:22Z","updated_at":"2018-10-04T20:31:04Z","html_url":"https://github.com/WordPress/gutenberg/pull/9704#discussion_r222808532","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/222808532"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/9704#discussion_r222808532"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704","id":214046935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQ2OTM1","html_url":"https://github.com/WordPress/gutenberg/pull/9704","diff_url":"https://github.com/WordPress/gutenberg/pull/9704.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/9704.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9704","number":9704,"state":"open","locked":false,"title":"utils: mediaUpload: Pass all available properties in the media object","user":{"login":"jorgefilipecosta","id":11271197,"node_id":"MDQ6VXNlcjExMjcxMTk3","avatar_url":"https://avatars1.githubusercontent.com/u/11271197?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgefilipecosta","html_url":"https://github.com/jorgefilipecosta","followers_url":"https://api.github.com/users/jorgefilipecosta/followers","following_url":"https://api.github.com/users/jorgefilipecosta/following{/other_user}","gists_url":"https://api.github.com/users/jorgefilipecosta/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgefilipecosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgefilipecosta/subscriptions","organizations_url":"https://api.github.com/users/jorgefilipecosta/orgs","repos_url":"https://api.github.com/users/jorgefilipecosta/repos","events_url":"https://api.github.com/users/jorgefilipecosta/events{/privacy}","received_events_url":"https://api.github.com/users/jorgefilipecosta/received_events","type":"User","site_admin":false},"body":"## Description\r\nInitially, mediaUpload util only passed to the callback function of the invoker a simple object with the URL of the file, a caption, and an alt. With time needs for other props appeared and the function was changed to add the missing props. The most recent need was mediaDetails.sizes.\r\nNow with the most recent updates in https://github.com/WordPress/gutenberg/pull/9416 I discovered I need yet another property the media type.\r\nI thought a little bit and I think the function should return all the available properties. Omitting props will limit the things blocks can do and will probably force them to use their own media upload if they really need a prop we are omitting.\r\n\r\n\r\n\r\n\r\n## How has this been tested?\r\nI checked that blocks where we upload files (image, gallery, video, audio and file) the uploads still work as before.\r\n\r\n\r\nRequired for: https://github.com/WordPress/gutenberg/pull/9416","created_at":"2018-09-07T21:45:17Z","updated_at":"2018-10-04T20:31:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0b1b1b98fcc8db057f7c9b3fecfcd1a335bf4c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":637003880,"node_id":"MDU6TGFiZWw2MzcwMDM4ODA=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Media","name":"Media","color":"00aa99","default":false},{"id":531680825,"node_id":"MDU6TGFiZWw1MzE2ODA4MjU=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/65","html_url":"https://github.com/WordPress/gutenberg/milestone/65","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/65/labels","id":3648185,"node_id":"MDk6TWlsZXN0b25lMzY0ODE4NQ==","number":65,"title":"4.0","description":"","creator":{"login":"mtias","id":548849,"node_id":"MDQ6VXNlcjU0ODg0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/548849?v=4","gravatar_id":"","url":"https://api.github.com/users/mtias","html_url":"https://github.com/mtias","followers_url":"https://api.github.com/users/mtias/followers","following_url":"https://api.github.com/users/mtias/following{/other_user}","gists_url":"https://api.github.com/users/mtias/gists{/gist_id}","starred_url":"https://api.github.com/users/mtias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtias/subscriptions","organizations_url":"https://api.github.com/users/mtias/orgs","repos_url":"https://api.github.com/users/mtias/repos","events_url":"https://api.github.com/users/mtias/events{/privacy}","received_events_url":"https://api.github.com/users/mtias/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":105,"state":"open","created_at":"2018-09-12T09:58:31Z","updated_at":"2018-10-04T20:29:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9704/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/93529d63276101b4626547c74e7203eb7b2b07ba","head":{"label":"WordPress:update/pass-all-object-properties-in-media-upload","ref":"update/pass-all-object-properties-in-media-upload","sha":"93529d63276101b4626547c74e7203eb7b2b07ba","user":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg2MjU4NA==","name":"gutenberg","full_name":"WordPress/gutenberg","private":false,"owner":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-10-04T20:30:20Z","pushed_at":"2018-10-04T20:29:55Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/","size":24135,"stargazers_count":3480,"watchers_count":3480,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":943,"mirror_url":null,"archived":false,"open_issues_count":1459,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":943,"open_issues":1459,"watchers":3480,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"2fe8cc0b835ee875ed1bb8c4e2134e13ba969ae9","user":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg2MjU4NA==","name":"gutenberg","full_name":"WordPress/gutenberg","private":false,"owner":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-10-04T20:30:20Z","pushed_at":"2018-10-04T20:29:55Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/","size":24135,"stargazers_count":3480,"watchers_count":3480,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":943,"mirror_url":null,"archived":false,"open_issues_count":1459,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":943,"open_issues":1459,"watchers":3480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/9704"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/9704"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/9704/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/9704/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/93529d63276101b4626547c74e7203eb7b2b07ba"}},"author_association":"MEMBER"}} | {
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
} | {
"id": 699132,
"login": "gziolo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/699132?",
"url": "https://api.github.com/users/gziolo"
} | {
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
} | 2018-10-04T20:02:22 | 8370475290 | {"actor":{"display_login":"gziolo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/180988974","pull_request_review_id":111508183,"id":180988974,"diff_hunk":"@@ -1,32 +1,51 @@\n /**\n * WordPress dependencies\n */\n-import { Component, renderToString } from '@wordpress/element';\n+import { Component, renderToString, createRef } from '@wordpress/element';\n+\n+/**\n+ * Internal dependencies\n+ */\n+import FocusableIframe from '../focusable-iframe';\n \n export default class Sandbox extends Component {\n \tconstructor() {\n \t\tsuper( ...arguments );\n \n \t\tthis.trySandbox = this.trySandbox.bind( this );\n \t\tthis.checkMessageForResize = this.checkMessageForResize.bind( this );\n-\t\tthis.checkFocus = this.checkFocus.bind( this );\n+\n+\t\tthis.iframe = createRef();\n \n \t\tthis.state = {\n \t\t\twidth: 0,\n \t\t\theight: 0,\n \t\t};\n \t}\n \n+\tcomponentDidMount() {\n+\t\twindow.addEventListener( 'message', this.checkMessageForResize, false );","path":"components/sandbox/index.js","position":29,"original_position":29,"commit_id":"fa89a1d4ac9d06d7a9914a211d603e35356ee928","original_commit_id":"fa89a1d4ac9d06d7a9914a211d603e35356ee928","user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"body":"withGlobalEvent?","created_at":"2018-04-12T07:37:53Z","updated_at":"2018-04-12T07:37:53Z","html_url":"https://github.com/WordPress/gutenberg/pull/5730#discussion_r180988974","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/180988974"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/5730#discussion_r180988974"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730","id":176525334,"html_url":"https://github.com/WordPress/gutenberg/pull/5730","diff_url":"https://github.com/WordPress/gutenberg/pull/5730.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/5730.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5730","number":5730,"state":"open","locked":false,"title":"Blocks: (Re-)enable selection of embed block by clicking","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":"Closes #5589\r\nRelated: #483\r\n\r\nThis pull request seeks to restore behaviors of embed click-to-select, originally implemented in #4011 and later regressing in #4872. In doing so, it adds a new function property passed to a block to allow a developer to programmatically select or deselect the block. This, in combination with a new `FocusableIframe` component, is leveraged to allow the embed block to be selected when its iframe receives focus.\r\n\r\n- [View `FocusableIframe` Documentation](https://github.com/WordPress/gutenberg/blob/91b0b90ff80bcb65b031402853efff2e4a0621ff/components/focusable-iframe/README.md)\r\n- [View `withGlobalEvents` Documentation](https://github.com/WordPress/gutenberg/blob/91b0b90ff80bcb65b031402853efff2e4a0621ff/components/higher-order/with-global-events/README.md)\r\n\r\n__Testing instructions:__\r\n\r\nRepeat testing instructions from #4011","created_at":"2018-03-21T16:00:17Z","updated_at":"2018-04-12T07:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"978e91a7664f45e573f701c547282144e0ea9213","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":570263070,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Blocks","name":"Blocks","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5730/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/fa89a1d4ac9d06d7a9914a211d603e35356ee928","head":{"label":"WordPress:add/focusable-iframe","ref":"add/focusable-iframe","sha":"fa89a1d4ac9d06d7a9914a211d603e35356ee928","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-04-12T06:24:17Z","pushed_at":"2018-04-12T04:26:28Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":12439,"stargazers_count":2285,"watchers_count":2285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":548,"mirror_url":null,"archived":false,"open_issues_count":834,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":548,"open_issues":834,"watchers":2285,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"004cb8b95a4d7173300bd9142209f2246b7d89e8","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-04-12T06:24:17Z","pushed_at":"2018-04-12T04:26:28Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":12439,"stargazers_count":2285,"watchers_count":2285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":548,"mirror_url":null,"archived":false,"open_issues_count":834,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":548,"open_issues":834,"watchers":2285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/5730"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/5730"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/5730/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/5730/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/fa89a1d4ac9d06d7a9914a211d603e35356ee928"}},"author_association":"MEMBER"}} | {
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
} | {
"id": 272444,
"login": "youknowriad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/272444?",
"url": "https://api.github.com/users/youknowriad"
} | {
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
} | 2018-04-12T07:37:53 | 7518205587 | {"actor":{"display_login":"youknowriad"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/232143200","pull_request_review_id":173275155,"id":232143200,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjE0MzIwMA==","diff_hunk":"@@ -2079,18 +2080,24 @@ array_fromfile(PyObject *NPY_UNUSED(ignored), PyObject *args, PyObject *keywds)\n }\n ret = PyArray_FromFile(fp, type, (npy_intp) nin, sep);\n \n+ /* If an exception is thrown in the call to PyArray_FromFile\n+ * we need to clear it, and restore it later to ensure that\n+ * we can cleanup the duplicated file descriptor properly.\n+ */\n+ PyErr_Fetch(&err_ptype, &err_pvalue, &err_ptraceback);\n if (npy_PyFile_DupClose2(file, fp, orig_pos) < 0) {\n goto fail;\n }\n if (own && npy_PyFile_CloseFile(file) < 0) {\n goto fail;\n }\n+ PyErr_Restore(err_ptype, err_pvalue, err_ptraceback);\n Py_DECREF(file);\n return ret;\n \n fail:\n Py_DECREF(file);\n- Py_DECREF(ret);\n+ if (ret != NULL) Py_DECREF(ret);","path":"numpy/core/src/multiarray/multiarraymodule.c","position":30,"original_position":30,"commit_id":"2ff64c4e6df6c2276666428b9e9458df5ba2e800","original_commit_id":"2ff64c4e6df6c2276666428b9e9458df5ba2e800","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"Simpler as `Py_XDECREF(ret)`","created_at":"2018-11-09T05:02:34Z","updated_at":"2018-11-09T05:02:34Z","html_url":"https://github.com/numpy/numpy/pull/12354#discussion_r232143200","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/12354","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/232143200"},"html":{"href":"https://github.com/numpy/numpy/pull/12354#discussion_r232143200"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12354"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/12354","id":229500427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTAwNDI3","html_url":"https://github.com/numpy/numpy/pull/12354","diff_url":"https://github.com/numpy/numpy/pull/12354.diff","patch_url":"https://github.com/numpy/numpy/pull/12354.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/12354","number":12354,"state":"open","locked":false,"title":"BUG: Fix segfault when an error occurs in np.fromfile","user":{"login":"simongibbons","id":950457,"node_id":"MDQ6VXNlcjk1MDQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/950457?v=4","gravatar_id":"","url":"https://api.github.com/users/simongibbons","html_url":"https://github.com/simongibbons","followers_url":"https://api.github.com/users/simongibbons/followers","following_url":"https://api.github.com/users/simongibbons/following{/other_user}","gists_url":"https://api.github.com/users/simongibbons/gists{/gist_id}","starred_url":"https://api.github.com/users/simongibbons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongibbons/subscriptions","organizations_url":"https://api.github.com/users/simongibbons/orgs","repos_url":"https://api.github.com/users/simongibbons/repos","events_url":"https://api.github.com/users/simongibbons/events{/privacy}","received_events_url":"https://api.github.com/users/simongibbons/received_events","type":"User","site_admin":false},"body":"There is a problem with the way in which we handle\r\nerrors which occur in the call to `PyArray_FromFile`\r\nin `np.fromfile`.\r\n\r\nThe problem here is twofold.\r\n\r\n 1. The return value isn't checked, therefore if we reach\r\n the fail block, we will attempt a DECREF on a NULL and\r\n go down in flames.\r\n\r\n 2. The cleanup code on the filepointers (most notabily the\r\n call to `npy_PyFile_DupClose2`) assumes that there is no\r\n error set to work.\r\n\r\nThis PR addresses these issues\r\n 1. By adding a NULL check to the fail block to ensure we don't\r\n attempt a DECREF on a NULL.\r\n\r\n 2. By saving the error state before attempting the cleanup code\r\n on the file descriptor, and then restoring it after.\r\n\r\nFixes: #12300 ","created_at":"2018-11-08T20:36:33Z","updated_at":"2018-11-09T05:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05df4aac9fb4ef165bd727865b02a36af5c636b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/12354/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/12354/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/12354/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/2ff64c4e6df6c2276666428b9e9458df5ba2e800","head":{"label":"simongibbons:fix-fromfile-error-handling","ref":"fix-fromfile-error-handling","sha":"2ff64c4e6df6c2276666428b9e9458df5ba2e800","user":{"login":"simongibbons","id":950457,"node_id":"MDQ6VXNlcjk1MDQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/950457?v=4","gravatar_id":"","url":"https://api.github.com/users/simongibbons","html_url":"https://github.com/simongibbons","followers_url":"https://api.github.com/users/simongibbons/followers","following_url":"https://api.github.com/users/simongibbons/following{/other_user}","gists_url":"https://api.github.com/users/simongibbons/gists{/gist_id}","starred_url":"https://api.github.com/users/simongibbons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongibbons/subscriptions","organizations_url":"https://api.github.com/users/simongibbons/orgs","repos_url":"https://api.github.com/users/simongibbons/repos","events_url":"https://api.github.com/users/simongibbons/events{/privacy}","received_events_url":"https://api.github.com/users/simongibbons/received_events","type":"User","site_admin":false},"repo":{"id":31131567,"node_id":"MDEwOlJlcG9zaXRvcnkzMTEzMTU2Nw==","name":"numpy","full_name":"simongibbons/numpy","private":false,"owner":{"login":"simongibbons","id":950457,"node_id":"MDQ6VXNlcjk1MDQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/950457?v=4","gravatar_id":"","url":"https://api.github.com/users/simongibbons","html_url":"https://github.com/simongibbons","followers_url":"https://api.github.com/users/simongibbons/followers","following_url":"https://api.github.com/users/simongibbons/following{/other_user}","gists_url":"https://api.github.com/users/simongibbons/gists{/gist_id}","starred_url":"https://api.github.com/users/simongibbons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simongibbons/subscriptions","organizations_url":"https://api.github.com/users/simongibbons/orgs","repos_url":"https://api.github.com/users/simongibbons/repos","events_url":"https://api.github.com/users/simongibbons/events{/privacy}","received_events_url":"https://api.github.com/users/simongibbons/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simongibbons/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/simongibbons/numpy","forks_url":"https://api.github.com/repos/simongibbons/numpy/forks","keys_url":"https://api.github.com/repos/simongibbons/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simongibbons/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simongibbons/numpy/teams","hooks_url":"https://api.github.com/repos/simongibbons/numpy/hooks","issue_events_url":"https://api.github.com/repos/simongibbons/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/simongibbons/numpy/events","assignees_url":"https://api.github.com/repos/simongibbons/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/simongibbons/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/simongibbons/numpy/tags","blobs_url":"https://api.github.com/repos/simongibbons/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simongibbons/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simongibbons/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/simongibbons/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simongibbons/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/simongibbons/numpy/languages","stargazers_url":"https://api.github.com/repos/simongibbons/numpy/stargazers","contributors_url":"https://api.github.com/repos/simongibbons/numpy/contributors","subscribers_url":"https://api.github.com/repos/simongibbons/numpy/subscribers","subscription_url":"https://api.github.com/repos/simongibbons/numpy/subscription","commits_url":"https://api.github.com/repos/simongibbons/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/simongibbons/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/simongibbons/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/simongibbons/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/simongibbons/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/simongibbons/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simongibbons/numpy/merges","archive_url":"https://api.github.com/repos/simongibbons/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simongibbons/numpy/downloads","issues_url":"https://api.github.com/repos/simongibbons/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/simongibbons/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/simongibbons/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/simongibbons/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simongibbons/numpy/labels{/name}","releases_url":"https://api.github.com/repos/simongibbons/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/simongibbons/numpy/deployments","created_at":"2015-02-21T16:27:12Z","updated_at":"2018-11-08T16:46:05Z","pushed_at":"2018-11-08T20:36:02Z","git_url":"git://github.com/simongibbons/numpy.git","ssh_url":"git@github.com:simongibbons/numpy.git","clone_url":"https://github.com/simongibbons/numpy.git","svn_url":"https://github.com/simongibbons/numpy","homepage":"http://www.numpy.org/","size":59024,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"87154002974621a83b4be680b6a74a64ad983730","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2018-11-09T04:57:35Z","pushed_at":"2018-11-09T04:56:42Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":62065,"stargazers_count":8638,"watchers_count":8638,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3111,"mirror_url":null,"archived":false,"open_issues_count":2028,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3111,"open_issues":2028,"watchers":8638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12354"},"html":{"href":"https://github.com/numpy/numpy/pull/12354"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/12354"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/12354/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12354/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/12354/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/2ff64c4e6df6c2276666428b9e9458df5ba2e800"}},"author_association":"CONTRIBUTOR"}} | {
"id": 908607,
"name": "numpy/numpy",
"url": "https://api.github.com/repos/numpy/numpy"
} | {
"id": 425260,
"login": "eric-wieser",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/425260?",
"url": "https://api.github.com/users/eric-wieser"
} | {
"id": 288276,
"login": "numpy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288276?",
"url": "https://api.github.com/orgs/numpy"
} | 2018-11-09T05:02:34 | 8561115595 | {"actor":{"display_login":"eric-wieser"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments/169377452","pull_request_review_id":97894023,"id":169377452,"diff_hunk":"@@ -0,0 +1,23 @@\n+# encoding: UTF-8\n+#\n+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.\n+# This source code is licensed under the BSD-style license found in the\n+# LICENSE file in the root directory of this source tree.\n+\n+require_relative '../base_type'\n+\n+require_relative 'class'\n+\n+module GoodData\n+ module LCM2","path":"lib/gooddata/lcm/types/class/gd_product.rb","position":12,"original_position":12,"commit_id":"995a3b0b1bcbd2cfd34a65a563038ed42fc28193","original_commit_id":"995a3b0b1bcbd2cfd34a65a563038ed42fc28193","user":{"login":"yenkins","id":1506393,"avatar_url":"https://avatars1.githubusercontent.com/u/1506393?v=4","gravatar_id":"","url":"https://api.github.com/users/yenkins","html_url":"https://github.com/yenkins","followers_url":"https://api.github.com/users/yenkins/followers","following_url":"https://api.github.com/users/yenkins/following{/other_user}","gists_url":"https://api.github.com/users/yenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/yenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenkins/subscriptions","organizations_url":"https://api.github.com/users/yenkins/orgs","repos_url":"https://api.github.com/users/yenkins/repos","events_url":"https://api.github.com/users/yenkins/events{/privacy}","received_events_url":"https://api.github.com/users/yenkins/received_events","type":"User","site_admin":false},"body":"Has the name 'lcm2' (UncommunicativeModuleName)","created_at":"2018-02-20T16:29:02Z","updated_at":"2018-02-20T16:29:02Z","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1103#discussion_r169377452","pull_request_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments/169377452"},"html":{"href":"https://github.com/gooddata/gooddata-ruby/pull/1103#discussion_r169377452"},"pull_request":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103"}}},"pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103","id":170241654,"html_url":"https://github.com/gooddata/gooddata-ruby/pull/1103","diff_url":"https://github.com/gooddata/gooddata-ruby/pull/1103.diff","patch_url":"https://github.com/gooddata/gooddata-ruby/pull/1103.patch","issue_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1103","number":1103,"state":"open","locked":false,"title":"TMA 712 add params checking against the specification in all actions","user":{"login":"Hahihula","id":4068385,"avatar_url":"https://avatars2.githubusercontent.com/u/4068385?v=4","gravatar_id":"","url":"https://api.github.com/users/Hahihula","html_url":"https://github.com/Hahihula","followers_url":"https://api.github.com/users/Hahihula/followers","following_url":"https://api.github.com/users/Hahihula/following{/other_user}","gists_url":"https://api.github.com/users/Hahihula/gists{/gist_id}","starred_url":"https://api.github.com/users/Hahihula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hahihula/subscriptions","organizations_url":"https://api.github.com/users/Hahihula/orgs","repos_url":"https://api.github.com/users/Hahihula/repos","events_url":"https://api.github.com/users/Hahihula/events{/privacy}","received_events_url":"https://api.github.com/users/Hahihula/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-20T16:26:19Z","updated_at":"2018-02-20T16:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce4f0022f377470109707ed8f6dbde047ed31635","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103/commits","review_comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103/comments","review_comment_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1103/comments","statuses_url":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/995a3b0b1bcbd2cfd34a65a563038ed42fc28193","head":{"label":"Hahihula:TMA-712","ref":"TMA-712","sha":"995a3b0b1bcbd2cfd34a65a563038ed42fc28193","user":{"login":"Hahihula","id":4068385,"avatar_url":"https://avatars2.githubusercontent.com/u/4068385?v=4","gravatar_id":"","url":"https://api.github.com/users/Hahihula","html_url":"https://github.com/Hahihula","followers_url":"https://api.github.com/users/Hahihula/followers","following_url":"https://api.github.com/users/Hahihula/following{/other_user}","gists_url":"https://api.github.com/users/Hahihula/gists{/gist_id}","starred_url":"https://api.github.com/users/Hahihula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hahihula/subscriptions","organizations_url":"https://api.github.com/users/Hahihula/orgs","repos_url":"https://api.github.com/users/Hahihula/repos","events_url":"https://api.github.com/users/Hahihula/events{/privacy}","received_events_url":"https://api.github.com/users/Hahihula/received_events","type":"User","site_admin":false},"repo":{"id":120332977,"name":"gooddata-ruby","full_name":"Hahihula/gooddata-ruby","owner":{"login":"Hahihula","id":4068385,"avatar_url":"https://avatars2.githubusercontent.com/u/4068385?v=4","gravatar_id":"","url":"https://api.github.com/users/Hahihula","html_url":"https://github.com/Hahihula","followers_url":"https://api.github.com/users/Hahihula/followers","following_url":"https://api.github.com/users/Hahihula/following{/other_user}","gists_url":"https://api.github.com/users/Hahihula/gists{/gist_id}","starred_url":"https://api.github.com/users/Hahihula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hahihula/subscriptions","organizations_url":"https://api.github.com/users/Hahihula/orgs","repos_url":"https://api.github.com/users/Hahihula/repos","events_url":"https://api.github.com/users/Hahihula/events{/privacy}","received_events_url":"https://api.github.com/users/Hahihula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hahihula/gooddata-ruby","description":"GoodData API Ruby Gem","fork":true,"url":"https://api.github.com/repos/Hahihula/gooddata-ruby","forks_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/forks","keys_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/teams","hooks_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/hooks","issue_events_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/events","assignees_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/tags","blobs_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/languages","stargazers_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/stargazers","contributors_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/contributors","subscribers_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/subscribers","subscription_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/subscription","commits_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/merges","archive_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/downloads","issues_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/labels{/name}","releases_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/Hahihula/gooddata-ruby/deployments","created_at":"2018-02-05T16:46:47Z","updated_at":"2018-02-05T16:46:50Z","pushed_at":"2018-02-20T16:25:14Z","git_url":"git://github.com/Hahihula/gooddata-ruby.git","ssh_url":"git@github.com:Hahihula/gooddata-ruby.git","clone_url":"https://github.com/Hahihula/gooddata-ruby.git","svn_url":"https://github.com/Hahihula/gooddata-ruby","homepage":"http://developer.gooddata.com/","size":4664,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gooddata:develop","ref":"develop","sha":"d712ec4da73095f9fbe925c91d230567388640e9","user":{"login":"gooddata","id":291394,"avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"repo":{"id":891109,"name":"gooddata-ruby","full_name":"gooddata/gooddata-ruby","owner":{"login":"gooddata","id":291394,"avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gooddata/gooddata-ruby","description":"GoodData API Ruby Gem","fork":false,"url":"https://api.github.com/repos/gooddata/gooddata-ruby","forks_url":"https://api.github.com/repos/gooddata/gooddata-ruby/forks","keys_url":"https://api.github.com/repos/gooddata/gooddata-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gooddata/gooddata-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gooddata/gooddata-ruby/teams","hooks_url":"https://api.github.com/repos/gooddata/gooddata-ruby/hooks","issue_events_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/gooddata/gooddata-ruby/events","assignees_url":"https://api.github.com/repos/gooddata/gooddata-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/gooddata/gooddata-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/gooddata/gooddata-ruby/tags","blobs_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/gooddata/gooddata-ruby/languages","stargazers_url":"https://api.github.com/repos/gooddata/gooddata-ruby/stargazers","contributors_url":"https://api.github.com/repos/gooddata/gooddata-ruby/contributors","subscribers_url":"https://api.github.com/repos/gooddata/gooddata-ruby/subscribers","subscription_url":"https://api.github.com/repos/gooddata/gooddata-ruby/subscription","commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gooddata/gooddata-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/gooddata/gooddata-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gooddata/gooddata-ruby/merges","archive_url":"https://api.github.com/repos/gooddata/gooddata-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gooddata/gooddata-ruby/downloads","issues_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/gooddata/gooddata-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/gooddata/gooddata-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gooddata/gooddata-ruby/labels{/name}","releases_url":"https://api.github.com/repos/gooddata/gooddata-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/deployments","created_at":"2010-09-06T11:19:17Z","updated_at":"2018-01-31T00:13:46Z","pushed_at":"2018-02-20T16:26:20Z","git_url":"git://github.com/gooddata/gooddata-ruby.git","ssh_url":"git@github.com:gooddata/gooddata-ruby.git","clone_url":"https://github.com/gooddata/gooddata-ruby.git","svn_url":"https://github.com/gooddata/gooddata-ruby","homepage":"http://developer.gooddata.com/","size":4654,"stargazers_count":58,"watchers_count":58,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":89,"open_issues":16,"watchers":58,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103"},"html":{"href":"https://github.com/gooddata/gooddata-ruby/pull/1103"},"issue":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1103"},"comments":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1103/comments"},"review_comments":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103/comments"},"review_comment":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1103/commits"},"statuses":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/995a3b0b1bcbd2cfd34a65a563038ed42fc28193"}},"author_association":"CONTRIBUTOR"}} | {
"id": 891109,
"name": "gooddata/gooddata-ruby",
"url": "https://api.github.com/repos/gooddata/gooddata-ruby"
} | {
"id": 1506393,
"login": "yenkins",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1506393?",
"url": "https://api.github.com/users/yenkins"
} | {
"id": 291394,
"login": "gooddata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/291394?",
"url": "https://api.github.com/orgs/gooddata"
} | 2018-02-20T16:29:02 | 7270436725 | {"actor":{"display_login":"yenkins"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/comments/166894769","pull_request_review_id":95026001,"id":166894769,"diff_hunk":"@@ -14,11 +18,56 @@ class ContentViewContext extends BusinessContext\n {\n /**\n * @Given I start creating a new Landing Page :name\n+ *\n+ * @param string $name\n */\n public function startCreatingNewLandingPage(string $name): void\n {\n $contentStructurePage = PageObjectFactory::createPage($this->utilityContext, ContentStructurePage::PAGE_NAME);\n- $contentStructurePage->createLandingPage($name, 'Test Desc');\n+ $updatePage = $contentStructurePage->startCreatingContent('Landing page');\n+\n+ $updatePage->updateForm->fillFIeldWithValue('Title', $name);\n+ $updatePage->updateForm->fillFIeldWithValue('Description', $name);\n+ }\n+\n+ /**\n+ * @Given I start creating a new Article :name\n+ *\n+ * @param string $name\n+ */\n+ public function startCreatingArticle($name): void\n+ {\n+ $contentStructurePage = PageObjectFactory::createPage($this->utilityContext, ContentStructurePage::PAGE_NAME);\n+ $updatePage = $contentStructurePage->startCreatingContent('Article');\n+\n+ $updatePage->updateForm->fillFIeldWithValue('Title', $name);\n+ $updatePage->updateForm->fillRichtextWithValue('Test desc');\n+ }\n+\n+ /**\n+ * @Given I start editing the content in :language language\n+ */","path":"src/lib/Behat/BusinessContext/ContentViewContext.php","position":44,"original_position":44,"commit_id":"6ee86423e7ee804a6e29db925d34981080a9b3b1","original_commit_id":"6ee86423e7ee804a6e29db925d34981080a9b3b1","user":{"login":"mnocon","id":10993858,"avatar_url":"https://avatars0.githubusercontent.com/u/10993858?v=4","gravatar_id":"","url":"https://api.github.com/users/mnocon","html_url":"https://github.com/mnocon","followers_url":"https://api.github.com/users/mnocon/followers","following_url":"https://api.github.com/users/mnocon/following{/other_user}","gists_url":"https://api.github.com/users/mnocon/gists{/gist_id}","starred_url":"https://api.github.com/users/mnocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnocon/subscriptions","organizations_url":"https://api.github.com/users/mnocon/orgs","repos_url":"https://api.github.com/users/mnocon/repos","events_url":"https://api.github.com/users/mnocon/events{/privacy}","received_events_url":"https://api.github.com/users/mnocon/received_events","type":"User","site_admin":false},"body":"Ok, what's your opinion? I actually feel like they're not needed most of the time (and we should add them only when a description is really needed).","created_at":"2018-02-08T10:41:32Z","updated_at":"2018-02-08T10:41:32Z","html_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338#discussion_r166894769","pull_request_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/comments/166894769"},"html":{"href":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338#discussion_r166894769"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338"}},"in_reply_to_id":166882331},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338","id":167691521,"html_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338","diff_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338.diff","patch_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338.patch","issue_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/338","number":338,"state":"open","locked":false,"title":"EZEE-1836: Fix broken tests","user":{"login":"mnocon","id":10993858,"avatar_url":"https://avatars0.githubusercontent.com/u/10993858?v=4","gravatar_id":"","url":"https://api.github.com/users/mnocon","html_url":"https://github.com/mnocon","followers_url":"https://api.github.com/users/mnocon/followers","following_url":"https://api.github.com/users/mnocon/following{/other_user}","gists_url":"https://api.github.com/users/mnocon/gists{/gist_id}","starred_url":"https://api.github.com/users/mnocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnocon/subscriptions","organizations_url":"https://api.github.com/users/mnocon/orgs","repos_url":"https://api.github.com/users/mnocon/repos","events_url":"https://api.github.com/users/mnocon/events{/privacy}","received_events_url":"https://api.github.com/users/mnocon/received_events","type":"User","site_admin":false},"body":"| Question | Answer\r\n| ------------- | ---\r\n| Tickets | https://jira.ez.no/browse/EZEE-1836\r\n| Bug fix? | no\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Tests pass? | Yes 🐧 \r\n| Doc needed? | no\r\n| License | [GPL-2.0](https://github.com/ezsystems/ezplatform-admin-ui/blob/master/LICENSE)\r\n<!-- Keep in mind: Your contribution has to be compatible with GPL-2.0 as well: https://www.gnu.org/licenses/old-licenses/gpl-2.0-faq.html#GPLModuleLicense -->\r\n\r\n\r\n<!-- Replace this comment with Pull Request description -->\r\n\r\n\r\n#### Checklist:\r\n- [x] Coding standards (`$ composer fix-cs`)\r\n- [x] Ready for Code Review\r\n","created_at":"2018-02-07T13:24:26Z","updated_at":"2018-02-08T10:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66804925e9525c144d04e290e1be33294cf8e11c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"micszo","id":13622502,"avatar_url":"https://avatars1.githubusercontent.com/u/13622502?v=4","gravatar_id":"","url":"https://api.github.com/users/micszo","html_url":"https://github.com/micszo","followers_url":"https://api.github.com/users/micszo/followers","following_url":"https://api.github.com/users/micszo/following{/other_user}","gists_url":"https://api.github.com/users/micszo/gists{/gist_id}","starred_url":"https://api.github.com/users/micszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micszo/subscriptions","organizations_url":"https://api.github.com/users/micszo/orgs","repos_url":"https://api.github.com/users/micszo/repos","events_url":"https://api.github.com/users/micszo/events{/privacy}","received_events_url":"https://api.github.com/users/micszo/received_events","type":"User","site_admin":false},{"login":"barbaragr","id":32538832,"avatar_url":"https://avatars0.githubusercontent.com/u/32538832?v=4","gravatar_id":"","url":"https://api.github.com/users/barbaragr","html_url":"https://github.com/barbaragr","followers_url":"https://api.github.com/users/barbaragr/followers","following_url":"https://api.github.com/users/barbaragr/following{/other_user}","gists_url":"https://api.github.com/users/barbaragr/gists{/gist_id}","starred_url":"https://api.github.com/users/barbaragr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbaragr/subscriptions","organizations_url":"https://api.github.com/users/barbaragr/orgs","repos_url":"https://api.github.com/users/barbaragr/repos","events_url":"https://api.github.com/users/barbaragr/events{/privacy}","received_events_url":"https://api.github.com/users/barbaragr/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/338/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/statuses/6ee86423e7ee804a6e29db925d34981080a9b3b1","head":{"label":"mnocon:ezee-1836-fix-broken-tests","ref":"ezee-1836-fix-broken-tests","sha":"6ee86423e7ee804a6e29db925d34981080a9b3b1","user":{"login":"mnocon","id":10993858,"avatar_url":"https://avatars0.githubusercontent.com/u/10993858?v=4","gravatar_id":"","url":"https://api.github.com/users/mnocon","html_url":"https://github.com/mnocon","followers_url":"https://api.github.com/users/mnocon/followers","following_url":"https://api.github.com/users/mnocon/following{/other_user}","gists_url":"https://api.github.com/users/mnocon/gists{/gist_id}","starred_url":"https://api.github.com/users/mnocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnocon/subscriptions","organizations_url":"https://api.github.com/users/mnocon/orgs","repos_url":"https://api.github.com/users/mnocon/repos","events_url":"https://api.github.com/users/mnocon/events{/privacy}","received_events_url":"https://api.github.com/users/mnocon/received_events","type":"User","site_admin":false},"repo":{"id":108969985,"name":"ezplatform-admin-ui","full_name":"mnocon/ezplatform-admin-ui","owner":{"login":"mnocon","id":10993858,"avatar_url":"https://avatars0.githubusercontent.com/u/10993858?v=4","gravatar_id":"","url":"https://api.github.com/users/mnocon","html_url":"https://github.com/mnocon","followers_url":"https://api.github.com/users/mnocon/followers","following_url":"https://api.github.com/users/mnocon/following{/other_user}","gists_url":"https://api.github.com/users/mnocon/gists{/gist_id}","starred_url":"https://api.github.com/users/mnocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnocon/subscriptions","organizations_url":"https://api.github.com/users/mnocon/orgs","repos_url":"https://api.github.com/users/mnocon/repos","events_url":"https://api.github.com/users/mnocon/events{/privacy}","received_events_url":"https://api.github.com/users/mnocon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnocon/ezplatform-admin-ui","description":"Repository dedicated to the eZ Platform Admin UI Bundle","fork":true,"url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui","forks_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/forks","keys_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/teams","hooks_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/events","assignees_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/tags","blobs_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/languages","stargazers_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/subscription","commits_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/merges","archive_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/downloads","issues_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mnocon/ezplatform-admin-ui/deployments","created_at":"2017-10-31T08:58:02Z","updated_at":"2017-10-31T08:58:05Z","pushed_at":"2018-02-08T08:15:47Z","git_url":"git://github.com/mnocon/ezplatform-admin-ui.git","ssh_url":"git@github.com:mnocon/ezplatform-admin-ui.git","clone_url":"https://github.com/mnocon/ezplatform-admin-ui.git","svn_url":"https://github.com/mnocon/ezplatform-admin-ui","homepage":"","size":2804,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:1.0","ref":"1.0","sha":"86893b34e43c4b2ca2c4edb49fb8aa29997991b5","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":104727697,"name":"ezplatform-admin-ui","full_name":"ezsystems/ezplatform-admin-ui","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezplatform-admin-ui","description":"Repository dedicated to the eZ Platform Admin UI Bundle, Admin UI for eZ Platform v2+","fork":false,"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui","forks_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/forks","keys_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/events","assignees_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/merges","archive_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/deployments","created_at":"2017-09-25T09:09:12Z","updated_at":"2018-02-02T09:03:05Z","pushed_at":"2018-02-08T10:34:52Z","git_url":"git://github.com/ezsystems/ezplatform-admin-ui.git","ssh_url":"git@github.com:ezsystems/ezplatform-admin-ui.git","clone_url":"https://github.com/ezsystems/ezplatform-admin-ui.git","svn_url":"https://github.com/ezsystems/ezplatform-admin-ui","homepage":"https://ezplatform.com/","size":2866,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":19,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338"},"html":{"href":"https://github.com/ezsystems/ezplatform-admin-ui/pull/338"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/338"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/statuses/6ee86423e7ee804a6e29db925d34981080a9b3b1"}},"author_association":"MEMBER"}} | {
"id": 104727697,
"name": "ezsystems/ezplatform-admin-ui",
"url": "https://api.github.com/repos/ezsystems/ezplatform-admin-ui"
} | {
"id": 10993858,
"login": "mnocon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10993858?",
"url": "https://api.github.com/users/mnocon"
} | {
"id": 295311,
"login": "ezsystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295311?",
"url": "https://api.github.com/orgs/ezsystems"
} | 2018-02-08T10:41:32 | 7216144195 | {"actor":{"display_login":"mnocon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/201964353","pull_request_review_id":136565734,"id":201964353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTk2NDM1Mw==","diff_hunk":"@@ -0,0 +1,14 @@\n+<?php\n+\n+namespace Backend\\Modules\\Profiles\\Domain\\Profile;\n+\n+use Doctrine\\ORM\\EntityRepository;\n+\n+class ProfileRepository extends EntityRepository\n+{\n+ public function add(Profile $profile): void\n+ {\n+ // We don't flush here, see http://disq.us/p/okjc6b\n+ $this->getEntityManager()->persist($profile);","path":"src/Backend/Modules/Profiles/Domain/Profile/ProfileRepository.php","position":null,"original_position":12,"commit_id":"635457b4c376d19e3dcc33cc3af4e3b8feb9af27","original_commit_id":"05ead5c944976a62c363d290c7b69f0dd7b4b369","user":{"login":"jonasdekeukelaere","id":4092903,"node_id":"MDQ6VXNlcjQwOTI5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4092903?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasdekeukelaere","html_url":"https://github.com/jonasdekeukelaere","followers_url":"https://api.github.com/users/jonasdekeukelaere/followers","following_url":"https://api.github.com/users/jonasdekeukelaere/following{/other_user}","gists_url":"https://api.github.com/users/jonasdekeukelaere/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasdekeukelaere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasdekeukelaere/subscriptions","organizations_url":"https://api.github.com/users/jonasdekeukelaere/orgs","repos_url":"https://api.github.com/users/jonasdekeukelaere/repos","events_url":"https://api.github.com/users/jonasdekeukelaere/events{/privacy}","received_events_url":"https://api.github.com/users/jonasdekeukelaere/received_events","type":"User","site_admin":false},"body":"Has been changed later","created_at":"2018-07-12T09:15:15Z","updated_at":"2018-07-12T09:15:16Z","html_url":"https://github.com/forkcms/forkcms/pull/2554#discussion_r201964353","pull_request_url":"https://api.github.com/repos/forkcms/forkcms/pulls/2554","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/201964353"},"html":{"href":"https://github.com/forkcms/forkcms/pull/2554#discussion_r201964353"},"pull_request":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2554"}},"in_reply_to_id":193138748},"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/2554","id":191704394,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzA0Mzk0","html_url":"https://github.com/forkcms/forkcms/pull/2554","diff_url":"https://github.com/forkcms/forkcms/pull/2554.diff","patch_url":"https://github.com/forkcms/forkcms/pull/2554.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/2554","number":2554,"state":"open","locked":false,"title":"Profiles entity","user":{"login":"jonasdekeukelaere","id":4092903,"node_id":"MDQ6VXNlcjQwOTI5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4092903?v=4","gravatar_id":"","url":"https://api.github.com/users/jonasdekeukelaere","html_url":"https://github.com/jonasdekeukelaere","followers_url":"https://api.github.com/users/jonasdekeukelaere/followers","following_url":"https://api.github.com/users/jonasdekeukelaere/following{/other_user}","gists_url":"https://api.github.com/users/jonasdekeukelaere/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasdekeukelaere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasdekeukelaere/subscriptions","organizations_url":"https://api.github.com/users/jonasdekeukelaere/orgs","repos_url":"https://api.github.com/users/jonasdekeukelaere/repos","events_url":"https://api.github.com/users/jonasdekeukelaere/events{/privacy}","received_events_url":"https://api.github.com/users/jonasdekeukelaere/received_events","type":"User","site_admin":false},"body":"## Type\r\n- Enhancement\r\n\r\n## Pull request description\r\nUse doctrine to handle profiles module\r\n\r\n","created_at":"2018-05-31T10:03:09Z","updated_at":"2018-07-12T09:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cb1e58d2cb64a2c14f3d6bf451c12ec152ab561","assignee":{"login":"carakas","id":3634654,"node_id":"MDQ6VXNlcjM2MzQ2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3634654?v=4","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false},"assignees":[{"login":"carakas","id":3634654,"node_id":"MDQ6VXNlcjM2MzQ2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3634654?v=4","gravatar_id":"","url":"https://api.github.com/users/carakas","html_url":"https://github.com/carakas","followers_url":"https://api.github.com/users/carakas/followers","following_url":"https://api.github.com/users/carakas/following{/other_user}","gists_url":"https://api.github.com/users/carakas/gists{/gist_id}","starred_url":"https://api.github.com/users/carakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carakas/subscriptions","organizations_url":"https://api.github.com/users/carakas/orgs","repos_url":"https://api.github.com/users/carakas/repos","events_url":"https://api.github.com/users/carakas/events{/privacy}","received_events_url":"https://api.github.com/users/carakas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/2554/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/2554/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/2554/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/635457b4c376d19e3dcc33cc3af4e3b8feb9af27","head":{"label":"forkcms:profiles-entity","ref":"profiles-entity","sha":"635457b4c376d19e3dcc33cc3af4e3b8feb9af27","user":{"login":"forkcms","id":312505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4NTgz","name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2018-07-10T13:42:07Z","pushed_at":"2018-07-12T09:07:10Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":77138,"stargazers_count":1019,"watchers_count":1019,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":273,"open_issues":73,"watchers":1019,"default_branch":"master"}},"base":{"label":"forkcms:6.0.0-dev","ref":"6.0.0-dev","sha":"192359a8894aa5d4824f8b26fbef43dfd9cb3aeb","user":{"login":"forkcms","id":312505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4NTgz","name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/312505?v=4","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an easy to use open source CMS using Symfony Components.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","deployments_url":"https://api.github.com/repos/forkcms/forkcms/deployments","created_at":"2010-12-04T18:06:15Z","updated_at":"2018-07-10T13:42:07Z","pushed_at":"2018-07-12T09:07:10Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":77138,"stargazers_count":1019,"watchers_count":1019,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":273,"open_issues":73,"watchers":1019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2554"},"html":{"href":"https://github.com/forkcms/forkcms/pull/2554"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/2554"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/2554/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2554/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/2554/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/635457b4c376d19e3dcc33cc3af4e3b8feb9af27"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1138583,
"name": "forkcms/forkcms",
"url": "https://api.github.com/repos/forkcms/forkcms"
} | {
"id": 4092903,
"login": "jonasdekeukelaere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4092903?",
"url": "https://api.github.com/users/jonasdekeukelaere"
} | {
"id": 312505,
"login": "forkcms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/312505?",
"url": "https://api.github.com/orgs/forkcms"
} | 2018-07-12T09:15:15 | 7954971948 | {"actor":{"display_login":"jonasdekeukelaere"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/170498546","pull_request_review_id":99189954,"id":170498546,"diff_hunk":"@@ -0,0 +1,283 @@\n+/*\n+ * Copyright (C) 2009-2017 Lightbend Inc. <https://www.lightbend.com>\n+ */\n+package play.filters.csp\n+\n+import play.api.Configuration\n+\n+/**\n+ *\n+ * @see <a href=\"https://www.w3.org/TR/CSP3/\">Content Security Policy Level 3</a>\n+ */\n+object CSPConfig {\n+ def fromConfiguration(conf: Configuration): CSPConfig = {\n+ val config = conf.get[Configuration](\"play.filters.csp\")\n+ fromUnprefixedConfiguration(config)\n+ }\n+\n+ def fromUnprefixedConfiguration(configuration: Configuration): CSPConfig = {\n+ import collection.JavaConverters._\n+\n+ val nonce = configuration.get[Configuration](\"nonce\")\n+ val hashes = configuration.underlying.getConfigList(\"hashes\").asScala\n+ val directives = configuration.get[Configuration](\"directives\")\n+\n+ CSPConfig(\n+ CSPNonceConfig(\n+ enabled = nonce.get[Boolean](\"enabled\"),\n+ pattern = nonce.get[String](\"pattern\"),\n+ header = nonce.get[Boolean](\"header\")\n+ ),\n+ hashes.map { hashConfig =>\n+ CSPHashConfig(\n+ hash = hashConfig.getString(\"hash\"),\n+ pattern = hashConfig.getString(\"pattern\")\n+ )\n+ },\n+ CSPDirectivesConfig(\n+ baseUri = directives.get[Option[String]](\"base-uri\"),\n+ blockAllMixedContent =\n+ directives.getAndValidate[Option[Boolean]](\"block-all-mixed-content\",\n+ Set(None, Some(true))),\n+ childSrc = directives.get[Option[String]](\"child-src\"),\n+ connectSrc = directives.get[Option[String]](\"connect-src\"),\n+ defaultSrc = directives.get[Option[String]](\"default-src\"),\n+ disownOpener =\n+ directives.getAndValidate[Option[Boolean]](\"disown-opener\",\n+ Set(None, Some(true))),\n+ fontSrc = directives.get[Option[String]](\"font-src\"),\n+ formAction = directives.get[Option[String]](\"form-action\"),\n+ frameAncestors = directives.get[Option[String]](\"frame-ancestors\"),\n+ frameSrc = directives.get[Option[String]](\"frame-src\"),\n+ imgSrc = directives.get[Option[String]](\"img-src\"),\n+ manifestSrc = directives.get[Option[String]](\"manifest-src\"),\n+ mediaSrc = directives.get[Option[String]](\"media-src\"),\n+ objectSrc = directives.get[Option[String]](\"object-src\"),\n+ pluginTypes = directives.get[Option[String]](\"plugin-types\"),\n+ reportUri = directives.get[Option[String]](\"report-uri\"),\n+ reportTo = directives.get[Option[String]](\"report-to\"),\n+ requireSriFor = directives.get[Option[String]](\"require-sri-for\"),\n+ sandbox = directives.get[Option[String]](\"sandbox\"),\n+ scriptSrc = directives.get[Option[String]](\"script-src\"),\n+ styleSrc = directives.get[Option[String]](\"style-src\"),\n+ workerSrc = directives.get[Option[String]](\"worker-src\"),\n+ upgradeInsecureRequests = directives.getAndValidate[Option[Boolean]](\n+ \"upgrade-insecure-requests\",\n+ Set(None, Some(true)))\n+ ),\n+ reportOnly = configuration.get[Boolean](\"reportOnly\")\n+ )\n+ }\n+}\n+\n+case class CSPConfig(nonce: CSPNonceConfig = CSPNonceConfig(),\n+ hashes: Seq[CSPHashConfig] = Seq(\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-RpniQm4B6bHP0cNtv7w1p6pVcgpm5B/eu1DNEYyMFXc=\",\n+ pattern = \"$CSP_BADREQUEST_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-UR7HMpJ9Bk/SZpbk4G4Xmx4urXCaAJ04VYs226CvWbI=\",\n+ pattern = \"$CSP_DEVERROR_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-6Ba5NDNhjRXDlqf4OWT1zwWKRGHsa6FuLgWt/ed0JD0=\",\n+ pattern = \"$CSP_DEVNOTFOUND_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-BxhM2vLGwvud/mbb5lHbL9GCvw1oUkIrzbvLaLxLtd8=\",\n+ pattern = \"$CSP_ERROR_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-RpniQm4B6bHP0cNtv7w1p6pVcgpm5B/eu1DNEYyMFXc=\",\n+ pattern = \"$CSP_NOTFOUND_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-TdnckdsryTS8xwO96+DclEwdvg0Cd1JcAQKPhabcYFM=\",\n+ pattern = \"$CSP_TODO_STYLE_HASH$\"),\n+ CSPHashConfig(\n+ hash =\n+ \"sha256-VUk4zRyKowDidapl5g3jDpnX3vljjMnmH02sfDxy/Ik=\",\n+ pattern = \"$CSP_UNAUTHORIZED_STYLE_HASH$\"),\n+ ),\n+ directives: CSPDirectivesConfig = CSPDirectivesConfig(),\n+ reportOnly: Boolean = false) {\n+\n+ /** Java Constructor */\n+ def this() = this(CSPNonceConfig())\n+\n+ def withNonce(nonce: CSPNonceConfig): CSPConfig = {\n+ copy(nonce = nonce)\n+ }\n+\n+ def withHashes(hashes: java.util.List[CSPHashConfig]): CSPConfig = {\n+ import scala.collection.JavaConverters._\n+ copy(hashes = hashes.asScala)\n+ }\n+\n+ def withDirectives(directives: CSPDirectivesConfig): CSPConfig = {\n+ copy(directives = directives)\n+ }\n+\n+}\n+\n+case class CSPNonceConfig(enabled: Boolean = true,\n+ pattern: String = \"$CSP_NONCE_PATTERN$\",\n+ header: Boolean = true) {\n+\n+ /** Java constructor */\n+ def this() = this(true)\n+\n+ def withEnabled(enabled: Boolean): CSPNonceConfig = {\n+ copy(enabled = enabled)\n+ }\n+\n+ def withPattern(pattern: String): CSPNonceConfig = {\n+ copy(pattern = pattern)\n+ }\n+\n+ def withHeader(header: Boolean): CSPNonceConfig = copy(header = header)\n+\n+}\n+\n+case class CSPHashConfig(hash: String, pattern: String)\n+\n+case class CSPDirectivesConfig(\n+ /** https://www.w3.org/TR/CSP3/#directive-base-uri */\n+ baseUri: Option[String] = None,\n+ /** https://www.w3.org/TR/mixed-content/#block-all-mixed-content */\n+ blockAllMixedContent: Option[Boolean] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-child-src */\n+ childSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-connect-src */\n+ connectSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-default-src */\n+ defaultSrc: Option[String] = Some(\"'self' $CSP_NONCE_PATTERN$\"),\n+ /** https://www.w3.org/TR/CSP3/#directive-disown-opener */\n+ disownOpener: Option[Boolean] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-font-src */\n+ fontSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-form-action */\n+ formAction: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-frame-ancestors */\n+ frameAncestors: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-frame-src */\n+ frameSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-img-src */\n+ imgSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-manifest-src */\n+ manifestSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-media-src */\n+ mediaSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-object-src */\n+ objectSrc: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-plugin-types */\n+ pluginTypes: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-report-uri */\n+ reportUri: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-report-to */\n+ reportTo: Option[String] = None,\n+ /** https://w3c.github.io/webappsec-subresource-integrity/#opt-in-require-sri-for */\n+ requireSriFor: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-sandbox */\n+ sandbox: Option[String] = None,\n+ /** https://www.w3.org/TR/CSP3/#directive-script-src */\n+ scriptSrc: Option[String] = Some(\n+ \"$CSP_NONCE_PATTERN$ 'unsafe-inline' 'strict-dynamic' https: http:\"),\n+ /** https://www.w3.org/TR/CSP3/#directive-style-src */\n+ styleSrc: Option[String] = Some(\n+ \"\"\"$CSP_NONCE_PATTERN$\n+ |$CSP_BADREQUEST_STYLE_HASH$\n+ |$CSP_DEVERROR_STYLE_HASH$\n+ |$CSP_DEVNOTFOUND_STYLE_HASH$\n+ |$CSP_ERROR_STYLE_HASH$\n+ |$CSP_NOTFOUND_STYLE_HASH$\n+ |$CSP_TODO_STYLE_HASH$\n+ |$CSP_UNAUTHORIZED_STYLE_HASH$\n+ |'unsafe-inline'\n+ |'strict-dynamic'\n+ | https:\n+ | http:\"\"\".stripMargin.replace(\"\\n\", \"\")),","path":"framework/src/play-filters-helpers/src/main/scala/play/filters/csp/CSPConfig.scala","position":201,"original_position":201,"commit_id":"4c5a7dacd4a125e4f60d500830d64b8f17919890","original_commit_id":"4c5a7dacd4a125e4f60d500830d64b8f17919890","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars2.githubusercontent.com/u/71236?v=4","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"Should be.","created_at":"2018-02-26T05:46:09Z","updated_at":"2018-02-26T05:46:10Z","html_url":"https://github.com/playframework/playframework/pull/8242#discussion_r170498546","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/8242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/170498546"},"html":{"href":"https://github.com/playframework/playframework/pull/8242#discussion_r170498546"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8242"}},"in_reply_to_id":170475165},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/8242","id":170381681,"html_url":"https://github.com/playframework/playframework/pull/8242","diff_url":"https://github.com/playframework/playframework/pull/8242.diff","patch_url":"https://github.com/playframework/playframework/pull/8242.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/8242","number":8242,"state":"open","locked":false,"title":"[WIP] Content Security Policy Filter","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars2.githubusercontent.com/u/71236?v=4","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"WORK IN PROGRESS DO NOT MERGE\r\n\r\nAddressing https://github.com/playframework/playframework/issues/8234 \r\n\r\nExample branch using CSP config here: \r\n\r\nhttps://github.com/wsargent/play-scala-chatroom-example/blob/with-csp-filter/conf/application.conf#L14\r\n\r\nMost things have to have CSPNonce added:\r\n\r\nhttps://github.com/wsargent/play-scala-chatroom-example/blob/with-csp-filter/app/views/index.scala.html#L51\r\n\r\n## Done\r\n\r\n* Breaks out the CSP portion of the SecurityHeadersFilter into its own filter.\r\n* Adds a nonce that carries through the filter via request attribute\r\n* Add configuration that allows for CSP configuration by application.conf\r\n* \"report-only\" feature allows dry-run with report-uri\r\n* Addition of hashes to default error pages (fixes https://github.com/playframework/playframework/issues/7662)\r\n* Test for \"reportOnly\" feature\r\n* Testing on a hapless example project\r\n\r\n## STILL NEEDS\r\n### Code\r\n\r\n* Java API on CSP Config\r\n\r\n### Tests\r\n\r\n* Testing for \"christmas tree\" CSP policy\r\n* Testing on actionbuilder\r\n\r\n### Documentation\r\n\r\n* Documentation page on CSP\r\n* Highlights/Migration Guide from SecurityHeaders\r\n* Scaladoc everywhere\r\n\r\n### Could possibly use, but maybe better as a different PR\r\n\r\n* Integration of allowed hosts into host whitelist\r\n* Integration into assets (assets automagically get hashes added to config etc)","created_at":"2018-02-21T05:43:50Z","updated_at":"2018-02-26T05:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d728cd1c32dd3e6c8c6d5158a6983c9672ec7a24","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marcospereira","id":4576,"avatar_url":"https://avatars0.githubusercontent.com/u/4576?v=4","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/8242/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/8242/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/8242/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/4c5a7dacd4a125e4f60d500830d64b8f17919890","head":{"label":"wsargent:better-content-security-policy-filter","ref":"better-content-security-policy-filter","sha":"4c5a7dacd4a125e4f60d500830d64b8f17919890","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars2.githubusercontent.com/u/71236?v=4","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"repo":{"id":11010009,"name":"playframework","full_name":"wsargent/playframework","owner":{"login":"wsargent","id":71236,"avatar_url":"https://avatars2.githubusercontent.com/u/71236?v=4","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsargent/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/wsargent/playframework","forks_url":"https://api.github.com/repos/wsargent/playframework/forks","keys_url":"https://api.github.com/repos/wsargent/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsargent/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsargent/playframework/teams","hooks_url":"https://api.github.com/repos/wsargent/playframework/hooks","issue_events_url":"https://api.github.com/repos/wsargent/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/wsargent/playframework/events","assignees_url":"https://api.github.com/repos/wsargent/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/wsargent/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/wsargent/playframework/tags","blobs_url":"https://api.github.com/repos/wsargent/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsargent/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsargent/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsargent/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsargent/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/wsargent/playframework/languages","stargazers_url":"https://api.github.com/repos/wsargent/playframework/stargazers","contributors_url":"https://api.github.com/repos/wsargent/playframework/contributors","subscribers_url":"https://api.github.com/repos/wsargent/playframework/subscribers","subscription_url":"https://api.github.com/repos/wsargent/playframework/subscription","commits_url":"https://api.github.com/repos/wsargent/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsargent/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsargent/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsargent/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wsargent/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/wsargent/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsargent/playframework/merges","archive_url":"https://api.github.com/repos/wsargent/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsargent/playframework/downloads","issues_url":"https://api.github.com/repos/wsargent/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/wsargent/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/wsargent/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/wsargent/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsargent/playframework/labels{/name}","releases_url":"https://api.github.com/repos/wsargent/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/wsargent/playframework/deployments","created_at":"2013-06-27T22:58:23Z","updated_at":"2015-04-15T18:06:45Z","pushed_at":"2018-02-25T23:16:43Z","git_url":"git://github.com/wsargent/playframework.git","ssh_url":"git@github.com:wsargent/playframework.git","clone_url":"https://github.com/wsargent/playframework.git","svn_url":"https://github.com/wsargent/playframework","homepage":"http://www.playframework.org/","size":88305,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"a4d9414e13ba46852e11d1cbf046703921d175bf","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2018-02-26T04:56:56Z","pushed_at":"2018-02-25T23:16:49Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":88727,"stargazers_count":10208,"watchers_count":10208,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3483,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3483,"open_issues":367,"watchers":10208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8242"},"html":{"href":"https://github.com/playframework/playframework/pull/8242"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/8242"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/8242/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8242/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8242/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/4c5a7dacd4a125e4f60d500830d64b8f17919890"}},"author_association":"MEMBER"}} | {
"id": 2340549,
"name": "playframework/playframework",
"url": "https://api.github.com/repos/playframework/playframework"
} | {
"id": 71236,
"login": "wsargent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/71236?",
"url": "https://api.github.com/users/wsargent"
} | {
"id": 319107,
"login": "playframework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319107?",
"url": "https://api.github.com/orgs/playframework"
} | 2018-02-26T05:46:09 | 7295258637 | {"actor":{"display_login":"wsargent"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/comments/227567521","pull_request_review_id":167640208,"id":227567521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzU2NzUyMQ==","diff_hunk":"@@ -217,9 +216,6 @@ class VTK_MRML_DISPLAYABLEMANAGER_EXPORT vtkMRMLModelDisplayableManager\n \n vtkMRMLSelectionNode* GetSelectionNode();\n \n- /// Find picked node and cell from mesh and set PickedNodeID and PickedPointID in Internal\n- void FindPickedDisplayNodeFromMesh(vtkPointSet* mesh, double pickedPoint[3]);","path":"Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.h","position":18,"original_position":15,"commit_id":"06629c9dbaeed019a00e55040f97dfa5cf4c6965","original_commit_id":"7a3ca0cd8116b35d387a2a2d71c25de2d5e7950d","user":{"login":"cpinter","id":1325980,"node_id":"MDQ6VXNlcjEzMjU5ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"body":"I added a new section for 5.0 changes and added this as the only item so far","created_at":"2018-10-23T21:15:43Z","updated_at":"2018-10-23T21:15:43Z","html_url":"https://github.com/Slicer/Slicer/pull/1032#discussion_r227567521","pull_request_url":"https://api.github.com/repos/Slicer/Slicer/pulls/1032","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/comments/227567521"},"html":{"href":"https://github.com/Slicer/Slicer/pull/1032#discussion_r227567521"},"pull_request":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/1032"}},"in_reply_to_id":227034721},"pull_request":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/1032","id":224714326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzE0MzI2","html_url":"https://github.com/Slicer/Slicer/pull/1032","diff_url":"https://github.com/Slicer/Slicer/pull/1032.diff","patch_url":"https://github.com/Slicer/Slicer/pull/1032.patch","issue_url":"https://api.github.com/repos/Slicer/Slicer/issues/1032","number":1032,"state":"closed","locked":false,"title":"BUG: Fix 3D picking in displayable managers","user":{"login":"cpinter","id":1325980,"node_id":"MDQ6VXNlcjEzMjU5ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"body":"Model and segmentation displayable managers use vtkCellPicker to pick a node in a certain RAS position. The current implementation uses the GetDataSet method to get the first picked dataset. However, that dataset might be one that is not managed by the caller DM. This is fixed by going through all the picked props and finding the first managed prop.","created_at":"2018-10-22T15:16:13Z","updated_at":"2018-10-23T21:15:43Z","closed_at":"2018-10-23T21:13:01Z","merged_at":null,"merge_commit_sha":"6c4854cedeb5ff42e320d3908c79640cd78d2c62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Slicer/Slicer/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/Slicer/Slicer/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/Slicer/Slicer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Slicer/Slicer/issues/1032/comments","statuses_url":"https://api.github.com/repos/Slicer/Slicer/statuses/06629c9dbaeed019a00e55040f97dfa5cf4c6965","head":{"label":"cpinter:fix-displayable-manager-3dpick","ref":"fix-displayable-manager-3dpick","sha":"06629c9dbaeed019a00e55040f97dfa5cf4c6965","user":{"login":"cpinter","id":1325980,"node_id":"MDQ6VXNlcjEzMjU5ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"repo":{"id":14346962,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0Njk2Mg==","name":"Slicer","full_name":"cpinter/Slicer","private":false,"owner":{"login":"cpinter","id":1325980,"node_id":"MDQ6VXNlcjEzMjU5ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1325980?v=4","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cpinter/Slicer","description":"Multi-platform, free open source software for visualization and image computing.","fork":true,"url":"https://api.github.com/repos/cpinter/Slicer","forks_url":"https://api.github.com/repos/cpinter/Slicer/forks","keys_url":"https://api.github.com/repos/cpinter/Slicer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpinter/Slicer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpinter/Slicer/teams","hooks_url":"https://api.github.com/repos/cpinter/Slicer/hooks","issue_events_url":"https://api.github.com/repos/cpinter/Slicer/issues/events{/number}","events_url":"https://api.github.com/repos/cpinter/Slicer/events","assignees_url":"https://api.github.com/repos/cpinter/Slicer/assignees{/user}","branches_url":"https://api.github.com/repos/cpinter/Slicer/branches{/branch}","tags_url":"https://api.github.com/repos/cpinter/Slicer/tags","blobs_url":"https://api.github.com/repos/cpinter/Slicer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpinter/Slicer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpinter/Slicer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpinter/Slicer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpinter/Slicer/statuses/{sha}","languages_url":"https://api.github.com/repos/cpinter/Slicer/languages","stargazers_url":"https://api.github.com/repos/cpinter/Slicer/stargazers","contributors_url":"https://api.github.com/repos/cpinter/Slicer/contributors","subscribers_url":"https://api.github.com/repos/cpinter/Slicer/subscribers","subscription_url":"https://api.github.com/repos/cpinter/Slicer/subscription","commits_url":"https://api.github.com/repos/cpinter/Slicer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpinter/Slicer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpinter/Slicer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpinter/Slicer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpinter/Slicer/contents/{+path}","compare_url":"https://api.github.com/repos/cpinter/Slicer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpinter/Slicer/merges","archive_url":"https://api.github.com/repos/cpinter/Slicer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpinter/Slicer/downloads","issues_url":"https://api.github.com/repos/cpinter/Slicer/issues{/number}","pulls_url":"https://api.github.com/repos/cpinter/Slicer/pulls{/number}","milestones_url":"https://api.github.com/repos/cpinter/Slicer/milestones{/number}","notifications_url":"https://api.github.com/repos/cpinter/Slicer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpinter/Slicer/labels{/name}","releases_url":"https://api.github.com/repos/cpinter/Slicer/releases{/id}","deployments_url":"https://api.github.com/repos/cpinter/Slicer/deployments","created_at":"2013-11-12T22:24:59Z","updated_at":"2018-10-22T15:12:59Z","pushed_at":"2018-10-23T21:01:28Z","git_url":"git://github.com/cpinter/Slicer.git","ssh_url":"git@github.com:cpinter/Slicer.git","clone_url":"https://github.com/cpinter/Slicer.git","svn_url":"https://github.com/cpinter/Slicer","homepage":"www.slicer.org","size":440197,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Slicer:master","ref":"master","sha":"0f8704d1528fbaf50a91d707ed6565a55c8a7f70","user":{"login":"Slicer","id":324362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/324362?v=4","gravatar_id":"","url":"https://api.github.com/users/Slicer","html_url":"https://github.com/Slicer","followers_url":"https://api.github.com/users/Slicer/followers","following_url":"https://api.github.com/users/Slicer/following{/other_user}","gists_url":"https://api.github.com/users/Slicer/gists{/gist_id}","starred_url":"https://api.github.com/users/Slicer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slicer/subscriptions","organizations_url":"https://api.github.com/users/Slicer/orgs","repos_url":"https://api.github.com/users/Slicer/repos","events_url":"https://api.github.com/users/Slicer/events{/privacy}","received_events_url":"https://api.github.com/users/Slicer/received_events","type":"Organization","site_admin":false},"repo":{"id":2006302,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA2MzAy","name":"Slicer","full_name":"Slicer/Slicer","private":false,"owner":{"login":"Slicer","id":324362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDM2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/324362?v=4","gravatar_id":"","url":"https://api.github.com/users/Slicer","html_url":"https://github.com/Slicer","followers_url":"https://api.github.com/users/Slicer/followers","following_url":"https://api.github.com/users/Slicer/following{/other_user}","gists_url":"https://api.github.com/users/Slicer/gists{/gist_id}","starred_url":"https://api.github.com/users/Slicer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slicer/subscriptions","organizations_url":"https://api.github.com/users/Slicer/orgs","repos_url":"https://api.github.com/users/Slicer/repos","events_url":"https://api.github.com/users/Slicer/events{/privacy}","received_events_url":"https://api.github.com/users/Slicer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Slicer/Slicer","description":"Multi-platform, free open source software for visualization and image computing.","fork":false,"url":"https://api.github.com/repos/Slicer/Slicer","forks_url":"https://api.github.com/repos/Slicer/Slicer/forks","keys_url":"https://api.github.com/repos/Slicer/Slicer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Slicer/Slicer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Slicer/Slicer/teams","hooks_url":"https://api.github.com/repos/Slicer/Slicer/hooks","issue_events_url":"https://api.github.com/repos/Slicer/Slicer/issues/events{/number}","events_url":"https://api.github.com/repos/Slicer/Slicer/events","assignees_url":"https://api.github.com/repos/Slicer/Slicer/assignees{/user}","branches_url":"https://api.github.com/repos/Slicer/Slicer/branches{/branch}","tags_url":"https://api.github.com/repos/Slicer/Slicer/tags","blobs_url":"https://api.github.com/repos/Slicer/Slicer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Slicer/Slicer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Slicer/Slicer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Slicer/Slicer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Slicer/Slicer/statuses/{sha}","languages_url":"https://api.github.com/repos/Slicer/Slicer/languages","stargazers_url":"https://api.github.com/repos/Slicer/Slicer/stargazers","contributors_url":"https://api.github.com/repos/Slicer/Slicer/contributors","subscribers_url":"https://api.github.com/repos/Slicer/Slicer/subscribers","subscription_url":"https://api.github.com/repos/Slicer/Slicer/subscription","commits_url":"https://api.github.com/repos/Slicer/Slicer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Slicer/Slicer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Slicer/Slicer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Slicer/Slicer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Slicer/Slicer/contents/{+path}","compare_url":"https://api.github.com/repos/Slicer/Slicer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Slicer/Slicer/merges","archive_url":"https://api.github.com/repos/Slicer/Slicer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Slicer/Slicer/downloads","issues_url":"https://api.github.com/repos/Slicer/Slicer/issues{/number}","pulls_url":"https://api.github.com/repos/Slicer/Slicer/pulls{/number}","milestones_url":"https://api.github.com/repos/Slicer/Slicer/milestones{/number}","notifications_url":"https://api.github.com/repos/Slicer/Slicer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Slicer/Slicer/labels{/name}","releases_url":"https://api.github.com/repos/Slicer/Slicer/releases{/id}","deployments_url":"https://api.github.com/repos/Slicer/Slicer/deployments","created_at":"2011-07-06T12:27:18Z","updated_at":"2018-10-23T21:12:14Z","pushed_at":"2018-10-23T21:12:08Z","git_url":"git://github.com/Slicer/Slicer.git","ssh_url":"git@github.com:Slicer/Slicer.git","clone_url":"https://github.com/Slicer/Slicer.git","svn_url":"https://github.com/Slicer/Slicer","homepage":"http://www.slicer.org","size":441651,"stargazers_count":579,"watchers_count":579,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":386,"open_issues":29,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/1032"},"html":{"href":"https://github.com/Slicer/Slicer/pull/1032"},"issue":{"href":"https://api.github.com/repos/Slicer/Slicer/issues/1032"},"comments":{"href":"https://api.github.com/repos/Slicer/Slicer/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/Slicer/Slicer/statuses/06629c9dbaeed019a00e55040f97dfa5cf4c6965"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2006302,
"name": "Slicer/Slicer",
"url": "https://api.github.com/repos/Slicer/Slicer"
} | {
"id": 1325980,
"login": "cpinter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1325980?",
"url": "https://api.github.com/users/cpinter"
} | {
"id": 324362,
"login": "Slicer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/324362?",
"url": "https://api.github.com/orgs/Slicer"
} | 2018-10-23T21:15:43 | 8468960625 | {"actor":{"display_login":"cpinter"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mybb/mybb/pulls/comments/186959766","pull_request_review_id":118640516,"id":186959766,"diff_hunk":"@@ -59,33 +59,32 @@ <h3>\n </li>\n </ul>\n <ul>\n- <li>Q: How can I use this font in <a href=\"http://www.aol.com/aim/\">AOL Instant\n- Messenger</a>, <a href=\"http://messenger.msn.com/\">MSN Messenger</a>, <a href=","path":"inc/captcha_fonts/read_me.html","position":23,"original_position":23,"commit_id":"9edd6315e2bf309bd5e2a5e8e6362c358033d88b","original_commit_id":"9edd6315e2bf309bd5e2a5e8e6362c358033d88b","user":{"login":"effone","id":21265591,"avatar_url":"https://avatars3.githubusercontent.com/u/21265591?v=4","gravatar_id":"","url":"https://api.github.com/users/effone","html_url":"https://github.com/effone","followers_url":"https://api.github.com/users/effone/followers","following_url":"https://api.github.com/users/effone/following{/other_user}","gists_url":"https://api.github.com/users/effone/gists{/gist_id}","starred_url":"https://api.github.com/users/effone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effone/subscriptions","organizations_url":"https://api.github.com/users/effone/orgs","repos_url":"https://api.github.com/users/effone/repos","events_url":"https://api.github.com/users/effone/events{/privacy}","received_events_url":"https://api.github.com/users/effone/received_events","type":"User","site_admin":false},"body":"No clue ...\r\nThe quote marks were appearing broken though, so I was bound to touch that file.","created_at":"2018-05-09T07:56:50Z","updated_at":"2018-05-09T07:56:50Z","html_url":"https://github.com/mybb/mybb/pull/3199#discussion_r186959766","pull_request_url":"https://api.github.com/repos/mybb/mybb/pulls/3199","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments/186959766"},"html":{"href":"https://github.com/mybb/mybb/pull/3199#discussion_r186959766"},"pull_request":{"href":"https://api.github.com/repos/mybb/mybb/pulls/3199"}},"in_reply_to_id":186958328},"pull_request":{"url":"https://api.github.com/repos/mybb/mybb/pulls/3199","id":186641659,"html_url":"https://github.com/mybb/mybb/pull/3199","diff_url":"https://github.com/mybb/mybb/pull/3199.diff","patch_url":"https://github.com/mybb/mybb/pull/3199.patch","issue_url":"https://api.github.com/repos/mybb/mybb/issues/3199","number":3199,"state":"open","locked":false,"title":"AIM Removal","user":{"login":"effone","id":21265591,"avatar_url":"https://avatars3.githubusercontent.com/u/21265591?v=4","gravatar_id":"","url":"https://api.github.com/users/effone","html_url":"https://github.com/effone","followers_url":"https://api.github.com/users/effone/followers","following_url":"https://api.github.com/users/effone/following{/other_user}","gists_url":"https://api.github.com/users/effone/gists{/gist_id}","starred_url":"https://api.github.com/users/effone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effone/subscriptions","organizations_url":"https://api.github.com/users/effone/orgs","repos_url":"https://api.github.com/users/effone/repos","events_url":"https://api.github.com/users/effone/events{/privacy}","received_events_url":"https://api.github.com/users/effone/received_events","type":"User","site_admin":false},"body":"As [AIM has been discontinued](https://help.aol.com/articles/aim-discontinued); removed all instances of AIM from MyBB ...\r\n\r\nhttps://github.com/mybb/mybb/pull/3153 recreated.","created_at":"2018-05-08T13:53:12Z","updated_at":"2018-05-09T07:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c8d37b55279345724eb6e576bf309de060e694a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"euantorano","id":748913,"avatar_url":"https://avatars1.githubusercontent.com/u/748913?v=4","gravatar_id":"","url":"https://api.github.com/users/euantorano","html_url":"https://github.com/euantorano","followers_url":"https://api.github.com/users/euantorano/followers","following_url":"https://api.github.com/users/euantorano/following{/other_user}","gists_url":"https://api.github.com/users/euantorano/gists{/gist_id}","starred_url":"https://api.github.com/users/euantorano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euantorano/subscriptions","organizations_url":"https://api.github.com/users/euantorano/orgs","repos_url":"https://api.github.com/users/euantorano/repos","events_url":"https://api.github.com/users/euantorano/events{/privacy}","received_events_url":"https://api.github.com/users/euantorano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":26368972,"url":"https://api.github.com/repos/mybb/mybb/labels/1.8","name":"1.8","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/mybb/mybb/milestones/23","html_url":"https://github.com/mybb/mybb/milestone/23","labels_url":"https://api.github.com/repos/mybb/mybb/milestones/23/labels","id":3193225,"number":23,"title":"1.8.16","description":null,"creator":{"login":"dvz","id":8020837,"avatar_url":"https://avatars1.githubusercontent.com/u/8020837?v=4","gravatar_id":"","url":"https://api.github.com/users/dvz","html_url":"https://github.com/dvz","followers_url":"https://api.github.com/users/dvz/followers","following_url":"https://api.github.com/users/dvz/following{/other_user}","gists_url":"https://api.github.com/users/dvz/gists{/gist_id}","starred_url":"https://api.github.com/users/dvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvz/subscriptions","organizations_url":"https://api.github.com/users/dvz/orgs","repos_url":"https://api.github.com/users/dvz/repos","events_url":"https://api.github.com/users/dvz/events{/privacy}","received_events_url":"https://api.github.com/users/dvz/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":36,"state":"open","created_at":"2018-03-16T12:58:29Z","updated_at":"2018-05-09T03:50:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mybb/mybb/pulls/3199/commits","review_comments_url":"https://api.github.com/repos/mybb/mybb/pulls/3199/comments","review_comment_url":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mybb/mybb/issues/3199/comments","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/9edd6315e2bf309bd5e2a5e8e6362c358033d88b","head":{"label":"effone:effone-aim-drop","ref":"effone-aim-drop","sha":"9edd6315e2bf309bd5e2a5e8e6362c358033d88b","user":{"login":"effone","id":21265591,"avatar_url":"https://avatars3.githubusercontent.com/u/21265591?v=4","gravatar_id":"","url":"https://api.github.com/users/effone","html_url":"https://github.com/effone","followers_url":"https://api.github.com/users/effone/followers","following_url":"https://api.github.com/users/effone/following{/other_user}","gists_url":"https://api.github.com/users/effone/gists{/gist_id}","starred_url":"https://api.github.com/users/effone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effone/subscriptions","organizations_url":"https://api.github.com/users/effone/orgs","repos_url":"https://api.github.com/users/effone/repos","events_url":"https://api.github.com/users/effone/events{/privacy}","received_events_url":"https://api.github.com/users/effone/received_events","type":"User","site_admin":false},"repo":{"id":131077032,"name":"mybb","full_name":"effone/mybb","owner":{"login":"effone","id":21265591,"avatar_url":"https://avatars3.githubusercontent.com/u/21265591?v=4","gravatar_id":"","url":"https://api.github.com/users/effone","html_url":"https://github.com/effone","followers_url":"https://api.github.com/users/effone/followers","following_url":"https://api.github.com/users/effone/following{/other_user}","gists_url":"https://api.github.com/users/effone/gists{/gist_id}","starred_url":"https://api.github.com/users/effone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effone/subscriptions","organizations_url":"https://api.github.com/users/effone/orgs","repos_url":"https://api.github.com/users/effone/repos","events_url":"https://api.github.com/users/effone/events{/privacy}","received_events_url":"https://api.github.com/users/effone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/effone/mybb","description":"MyBB is a free and open source forum software.","fork":true,"url":"https://api.github.com/repos/effone/mybb","forks_url":"https://api.github.com/repos/effone/mybb/forks","keys_url":"https://api.github.com/repos/effone/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/effone/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/effone/mybb/teams","hooks_url":"https://api.github.com/repos/effone/mybb/hooks","issue_events_url":"https://api.github.com/repos/effone/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/effone/mybb/events","assignees_url":"https://api.github.com/repos/effone/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/effone/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/effone/mybb/tags","blobs_url":"https://api.github.com/repos/effone/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/effone/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/effone/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/effone/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/effone/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/effone/mybb/languages","stargazers_url":"https://api.github.com/repos/effone/mybb/stargazers","contributors_url":"https://api.github.com/repos/effone/mybb/contributors","subscribers_url":"https://api.github.com/repos/effone/mybb/subscribers","subscription_url":"https://api.github.com/repos/effone/mybb/subscription","commits_url":"https://api.github.com/repos/effone/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/effone/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/effone/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/effone/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/effone/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/effone/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/effone/mybb/merges","archive_url":"https://api.github.com/repos/effone/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/effone/mybb/downloads","issues_url":"https://api.github.com/repos/effone/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/effone/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/effone/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/effone/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/effone/mybb/labels{/name}","releases_url":"https://api.github.com/repos/effone/mybb/releases{/id}","deployments_url":"https://api.github.com/repos/effone/mybb/deployments","created_at":"2018-04-26T00:06:14Z","updated_at":"2018-04-30T21:33:41Z","pushed_at":"2018-05-09T03:47:40Z","git_url":"git://github.com/effone/mybb.git","ssh_url":"git@github.com:effone/mybb.git","clone_url":"https://github.com/effone/mybb.git","svn_url":"https://github.com/effone/mybb","homepage":"https://mybb.com","size":31562,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature"}},"base":{"label":"mybb:feature","ref":"feature","sha":"bc6b0f54acdd5a5c9f325ec9ea3b1f9ca917c652","user":{"login":"mybb","id":328641,"avatar_url":"https://avatars3.githubusercontent.com/u/328641?v=4","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"repo":{"id":4649599,"name":"mybb","full_name":"mybb/mybb","owner":{"login":"mybb","id":328641,"avatar_url":"https://avatars3.githubusercontent.com/u/328641?v=4","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mybb/mybb","description":"MyBB is a free and open source forum software.","fork":false,"url":"https://api.github.com/repos/mybb/mybb","forks_url":"https://api.github.com/repos/mybb/mybb/forks","keys_url":"https://api.github.com/repos/mybb/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mybb/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mybb/mybb/teams","hooks_url":"https://api.github.com/repos/mybb/mybb/hooks","issue_events_url":"https://api.github.com/repos/mybb/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/mybb/mybb/events","assignees_url":"https://api.github.com/repos/mybb/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/mybb/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/mybb/mybb/tags","blobs_url":"https://api.github.com/repos/mybb/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mybb/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mybb/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mybb/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/mybb/mybb/languages","stargazers_url":"https://api.github.com/repos/mybb/mybb/stargazers","contributors_url":"https://api.github.com/repos/mybb/mybb/contributors","subscribers_url":"https://api.github.com/repos/mybb/mybb/subscribers","subscription_url":"https://api.github.com/repos/mybb/mybb/subscription","commits_url":"https://api.github.com/repos/mybb/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mybb/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mybb/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mybb/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mybb/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/mybb/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mybb/mybb/merges","archive_url":"https://api.github.com/repos/mybb/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mybb/mybb/downloads","issues_url":"https://api.github.com/repos/mybb/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/mybb/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/mybb/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/mybb/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mybb/mybb/labels{/name}","releases_url":"https://api.github.com/repos/mybb/mybb/releases{/id}","deployments_url":"https://api.github.com/repos/mybb/mybb/deployments","created_at":"2012-06-13T10:34:46Z","updated_at":"2018-05-09T02:53:19Z","pushed_at":"2018-05-09T07:28:52Z","git_url":"git://github.com/mybb/mybb.git","ssh_url":"git@github.com:mybb/mybb.git","clone_url":"https://github.com/mybb/mybb.git","svn_url":"https://github.com/mybb/mybb","homepage":"https://mybb.com","size":31532,"stargazers_count":478,"watchers_count":478,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":299,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":299,"open_issues":192,"watchers":478,"default_branch":"feature"}},"_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/3199"},"html":{"href":"https://github.com/mybb/mybb/pull/3199"},"issue":{"href":"https://api.github.com/repos/mybb/mybb/issues/3199"},"comments":{"href":"https://api.github.com/repos/mybb/mybb/issues/3199/comments"},"review_comments":{"href":"https://api.github.com/repos/mybb/mybb/pulls/3199/comments"},"review_comment":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mybb/mybb/pulls/3199/commits"},"statuses":{"href":"https://api.github.com/repos/mybb/mybb/statuses/9edd6315e2bf309bd5e2a5e8e6362c358033d88b"}},"author_association":"MEMBER"}} | {
"id": 4649599,
"name": "mybb/mybb",
"url": "https://api.github.com/repos/mybb/mybb"
} | {
"id": 21265591,
"login": "effone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21265591?",
"url": "https://api.github.com/users/effone"
} | {
"id": 328641,
"login": "mybb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/328641?",
"url": "https://api.github.com/orgs/mybb"
} | 2018-05-09T07:56:50 | 7648172040 | {"actor":{"display_login":"effone"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/226984431","pull_request_review_id":166922382,"id":226984431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk4NDQzMQ==","diff_hunk":"@@ -0,0 +1,60 @@\n+/*\n+ * Hibernate Search, full-text search for your domain model\n+ *\n+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later\n+ * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.\n+ */\n+package org.hibernate.search.backend.elasticsearch.search.query.impl;","path":"backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchProjectionFactoryImpl.java","position":null,"original_position":7,"commit_id":"24890ff9618a9f61e43e9bb6b24f6ed3699c22da","original_commit_id":"ea5690355aa80efc83e9a954f1f519150fc0294a","user":{"login":"yrodiere","id":412878,"node_id":"MDQ6VXNlcjQxMjg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"Just moving the class introduces a cyclic dependency, as mentioned in item 1 above; you now have:\r\n\r\n* `org.hibernate.search.backend.elasticsearch.search.query.impl.ElasticsearchSearchTargetContext`\r\n* depends on `org.hibernate.search.backend.elasticsearch.search.projection.impl.ElasticsearchSearchProjectionFactoryImpl`\r\n* depends on `org.hibernate.search.backend.elasticsearch.search.query.impl.SearchBackendContext` (same package as `ElasticsearchSearchTargetContext`)\r\n\r\nTo remove the cyclic dependency, you would need to do as explained above:\r\n\r\n> declare a SearchProjectionBackendContext interface in the projection package (`org.hibernate.search.backend.elasticsearch.search.projection.impl`), make SearchBackendContext create one such instance in its constructor, and pass the \"backend projection context\" only to the ElasticsearchSearchProjectionFactoryImpl constructor.","created_at":"2018-10-22T13:17:05Z","updated_at":"2018-10-22T13:17:05Z","html_url":"https://github.com/hibernate/hibernate-search/pull/1759#discussion_r226984431","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/226984431"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1759#discussion_r226984431"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759"}},"in_reply_to_id":224088447},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759","id":218646022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjQ2MDIy","html_url":"https://github.com/hibernate/hibernate-search/pull/1759","diff_url":"https://github.com/hibernate/hibernate-search/pull/1759.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1759.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1759","number":1759,"state":"open","locked":false,"title":"HSEARCH-3222 + HSEARCH-3357 + HSEARCH-3190 Provide a DSL to build projections","user":{"login":"gsmet","id":1279749,"node_id":"MDQ6VXNlcjEyNzk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"In passing, get rid of the ProjectionConstants.\r\n\r\nhttps://hibernate.atlassian.net/browse/HSEARCH-3222\r\nhttps://hibernate.atlassian.net/browse/HSEARCH-3357\r\nhttps://hibernate.atlassian.net/browse/HSEARCH-3190","created_at":"2018-09-27T13:08:32Z","updated_at":"2018-10-22T13:17:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df9f16f1f96fefdf0b051b911550b235eff2a5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":120285692,"node_id":"MDU6TGFiZWwxMjAyODU2OTI=","url":"https://api.github.com/repos/hibernate/hibernate-search/labels/Changes%20required","name":"Changes required","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1759/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/24890ff9618a9f61e43e9bb6b24f6ed3699c22da","head":{"label":"gsmet:HSEARCH-3222-1","ref":"HSEARCH-3222-1","sha":"24890ff9618a9f61e43e9bb6b24f6ed3699c22da","user":{"login":"gsmet","id":1279749,"node_id":"MDQ6VXNlcjEyNzk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"repo":{"id":3048410,"node_id":"MDEwOlJlcG9zaXRvcnkzMDQ4NDEw","name":"hibernate-search","full_name":"gsmet/hibernate-search","private":false,"owner":{"login":"gsmet","id":1279749,"node_id":"MDQ6VXNlcjEyNzk3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gsmet/hibernate-search","description":"Hibernate Search · gsmet's work tree","fork":true,"url":"https://api.github.com/repos/gsmet/hibernate-search","forks_url":"https://api.github.com/repos/gsmet/hibernate-search/forks","keys_url":"https://api.github.com/repos/gsmet/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsmet/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsmet/hibernate-search/teams","hooks_url":"https://api.github.com/repos/gsmet/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/gsmet/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/gsmet/hibernate-search/events","assignees_url":"https://api.github.com/repos/gsmet/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/gsmet/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/gsmet/hibernate-search/tags","blobs_url":"https://api.github.com/repos/gsmet/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsmet/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsmet/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsmet/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsmet/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/gsmet/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/gsmet/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/gsmet/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/gsmet/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/gsmet/hibernate-search/subscription","commits_url":"https://api.github.com/repos/gsmet/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsmet/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsmet/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsmet/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsmet/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/gsmet/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsmet/hibernate-search/merges","archive_url":"https://api.github.com/repos/gsmet/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsmet/hibernate-search/downloads","issues_url":"https://api.github.com/repos/gsmet/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/gsmet/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/gsmet/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/gsmet/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsmet/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/gsmet/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/gsmet/hibernate-search/deployments","created_at":"2011-12-25T16:03:56Z","updated_at":"2018-09-10T09:20:05Z","pushed_at":"2018-10-21T16:44:23Z","git_url":"git://github.com/gsmet/hibernate-search.git","ssh_url":"git@github.com:gsmet/hibernate-search.git","clone_url":"https://github.com/gsmet/hibernate-search.git","svn_url":"https://github.com/gsmet/hibernate-search","homepage":"","size":56924,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"c3664efc4dcafa95d702d16db8e7035008e82c92","user":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAyODE=","name":"hibernate-search","full_name":"hibernate/hibernate-search","private":false,"owner":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-search/deployments","created_at":"2010-10-15T15:55:09Z","updated_at":"2018-10-21T15:34:22Z","pushed_at":"2018-10-22T12:01:15Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://hibernate.org/search/","size":58210,"stargazers_count":294,"watchers_count":294,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":195,"open_issues":6,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1759"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1759"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1759/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1759/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/24890ff9618a9f61e43e9bb6b24f6ed3699c22da"}},"author_association":"MEMBER"}} | {
"id": 990281,
"name": "hibernate/hibernate-search",
"url": "https://api.github.com/repos/hibernate/hibernate-search"
} | {
"id": 412878,
"login": "yrodiere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/412878?",
"url": "https://api.github.com/users/yrodiere"
} | {
"id": 348262,
"login": "hibernate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/348262?",
"url": "https://api.github.com/orgs/hibernate"
} | 2018-10-22T13:17:05 | 8458513923 | {"actor":{"display_login":"yrodiere"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/170032164","pull_request_review_id":96897348,"id":170032164,"diff_hunk":"@@ -294,3 +295,12 @@ def _get_pubnote(self):\n return ''\n else:\n return ''\n+\n+\n+def decode_latex(string_with_latex):","path":"inspirehep/utils/latex.py","position":14,"original_position":14,"commit_id":"0e4ef958d795cef6bb8f4de5c9c3618551b0bb12","original_commit_id":"0e4ef958d795cef6bb8f4de5c9c3618551b0bb12","user":{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false},"body":"maybe add a short docstring?","created_at":"2018-02-22T17:22:27Z","updated_at":"2018-02-22T17:22:31Z","html_url":"https://github.com/inspirehep/inspire-next/pull/3194#discussion_r170032164","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/170032164"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3194#discussion_r170032164"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194","id":169385578,"html_url":"https://github.com/inspirehep/inspire-next/pull/3194","diff_url":"https://github.com/inspirehep/inspire-next/pull/3194.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/3194.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3194","number":3194,"state":"open","locked":false,"title":"arxiv: decode latex charachters in authors' full_name","user":{"login":"ammirate","id":8048761,"avatar_url":"https://avatars0.githubusercontent.com/u/8048761?v=4","gravatar_id":"","url":"https://api.github.com/users/ammirate","html_url":"https://github.com/ammirate","followers_url":"https://api.github.com/users/ammirate/followers","following_url":"https://api.github.com/users/ammirate/following{/other_user}","gists_url":"https://api.github.com/users/ammirate/gists{/gist_id}","starred_url":"https://api.github.com/users/ammirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammirate/subscriptions","organizations_url":"https://api.github.com/users/ammirate/orgs","repos_url":"https://api.github.com/users/ammirate/repos","events_url":"https://api.github.com/users/ammirate/events{/privacy}","received_events_url":"https://api.github.com/users/ammirate/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Antonio Cesarano <cesarano2607@gmail.com>\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have all the information that I need (if not, move to `RFC` and look for it).\r\n- [x] I linked the related issue(s) in the corresponding commit logs.\r\n- [x] I wrote [good commit log messages](https://github.com/torvalds/subsurface-for-dirk/blob/5f15ad5a86ada3c5e574041a5f9d85235322dabb/README#L92-L119).\r\n- [x] My code follows the code style of this project.\r\n- [x] I've added any new docs if API/utils methods were added.\r\n- [x] I have updated the existing documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n<!--- After this you can move the PR to `Needs Review` -->\r\n","created_at":"2018-02-15T14:26:57Z","updated_at":"2018-02-22T17:22:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59fdf2c2693252a956ba95ba51c6ca99b77afdcc","assignee":{"login":"ammirate","id":8048761,"avatar_url":"https://avatars0.githubusercontent.com/u/8048761?v=4","gravatar_id":"","url":"https://api.github.com/users/ammirate","html_url":"https://github.com/ammirate","followers_url":"https://api.github.com/users/ammirate/followers","following_url":"https://api.github.com/users/ammirate/following{/other_user}","gists_url":"https://api.github.com/users/ammirate/gists{/gist_id}","starred_url":"https://api.github.com/users/ammirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammirate/subscriptions","organizations_url":"https://api.github.com/users/ammirate/orgs","repos_url":"https://api.github.com/users/ammirate/repos","events_url":"https://api.github.com/users/ammirate/events{/privacy}","received_events_url":"https://api.github.com/users/ammirate/received_events","type":"User","site_admin":false},"assignees":[{"login":"ammirate","id":8048761,"avatar_url":"https://avatars0.githubusercontent.com/u/8048761?v=4","gravatar_id":"","url":"https://api.github.com/users/ammirate","html_url":"https://github.com/ammirate","followers_url":"https://api.github.com/users/ammirate/followers","following_url":"https://api.github.com/users/ammirate/following{/other_user}","gists_url":"https://api.github.com/users/ammirate/gists{/gist_id}","starred_url":"https://api.github.com/users/ammirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammirate/subscriptions","organizations_url":"https://api.github.com/users/ammirate/orgs","repos_url":"https://api.github.com/users/ammirate/repos","events_url":"https://api.github.com/users/ammirate/events{/privacy}","received_events_url":"https://api.github.com/users/ammirate/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"david-caro","id":587148,"avatar_url":"https://avatars1.githubusercontent.com/u/587148?v=4","gravatar_id":"","url":"https://api.github.com/users/david-caro","html_url":"https://github.com/david-caro","followers_url":"https://api.github.com/users/david-caro/followers","following_url":"https://api.github.com/users/david-caro/following{/other_user}","gists_url":"https://api.github.com/users/david-caro/gists{/gist_id}","starred_url":"https://api.github.com/users/david-caro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-caro/subscriptions","organizations_url":"https://api.github.com/users/david-caro/orgs","repos_url":"https://api.github.com/users/david-caro/repos","events_url":"https://api.github.com/users/david-caro/events{/privacy}","received_events_url":"https://api.github.com/users/david-caro/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":828440238,"url":"https://api.github.com/repos/inspirehep/inspire-next/labels/Review:%20Ready%20for%20Review","name":"Review: Ready for Review","color":"75b1b8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3194/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/0e4ef958d795cef6bb8f4de5c9c3618551b0bb12","head":{"label":"ammirate:remove_latex_from_authors","ref":"remove_latex_from_authors","sha":"0e4ef958d795cef6bb8f4de5c9c3618551b0bb12","user":{"login":"ammirate","id":8048761,"avatar_url":"https://avatars0.githubusercontent.com/u/8048761?v=4","gravatar_id":"","url":"https://api.github.com/users/ammirate","html_url":"https://github.com/ammirate","followers_url":"https://api.github.com/users/ammirate/followers","following_url":"https://api.github.com/users/ammirate/following{/other_user}","gists_url":"https://api.github.com/users/ammirate/gists{/gist_id}","starred_url":"https://api.github.com/users/ammirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammirate/subscriptions","organizations_url":"https://api.github.com/users/ammirate/orgs","repos_url":"https://api.github.com/users/ammirate/repos","events_url":"https://api.github.com/users/ammirate/events{/privacy}","received_events_url":"https://api.github.com/users/ammirate/received_events","type":"User","site_admin":false},"repo":{"id":95531052,"name":"inspire-next","full_name":"ammirate/inspire-next","owner":{"login":"ammirate","id":8048761,"avatar_url":"https://avatars0.githubusercontent.com/u/8048761?v=4","gravatar_id":"","url":"https://api.github.com/users/ammirate","html_url":"https://github.com/ammirate","followers_url":"https://api.github.com/users/ammirate/followers","following_url":"https://api.github.com/users/ammirate/following{/other_user}","gists_url":"https://api.github.com/users/ammirate/gists{/gist_id}","starred_url":"https://api.github.com/users/ammirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammirate/subscriptions","organizations_url":"https://api.github.com/users/ammirate/orgs","repos_url":"https://api.github.com/users/ammirate/repos","events_url":"https://api.github.com/users/ammirate/events{/privacy}","received_events_url":"https://api.github.com/users/ammirate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ammirate/inspire-next","description":"The next version of INSPIRE","fork":true,"url":"https://api.github.com/repos/ammirate/inspire-next","forks_url":"https://api.github.com/repos/ammirate/inspire-next/forks","keys_url":"https://api.github.com/repos/ammirate/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ammirate/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ammirate/inspire-next/teams","hooks_url":"https://api.github.com/repos/ammirate/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/ammirate/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/ammirate/inspire-next/events","assignees_url":"https://api.github.com/repos/ammirate/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/ammirate/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/ammirate/inspire-next/tags","blobs_url":"https://api.github.com/repos/ammirate/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ammirate/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ammirate/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/ammirate/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ammirate/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/ammirate/inspire-next/languages","stargazers_url":"https://api.github.com/repos/ammirate/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/ammirate/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/ammirate/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/ammirate/inspire-next/subscription","commits_url":"https://api.github.com/repos/ammirate/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/ammirate/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/ammirate/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/ammirate/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/ammirate/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/ammirate/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ammirate/inspire-next/merges","archive_url":"https://api.github.com/repos/ammirate/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ammirate/inspire-next/downloads","issues_url":"https://api.github.com/repos/ammirate/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/ammirate/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/ammirate/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/ammirate/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ammirate/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/ammirate/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/ammirate/inspire-next/deployments","created_at":"2017-06-27T07:37:30Z","updated_at":"2017-06-27T07:37:34Z","pushed_at":"2018-02-21T11:12:27Z","git_url":"git://github.com/ammirate/inspire-next.git","ssh_url":"git@github.com:ammirate/inspire-next.git","clone_url":"https://github.com/ammirate/inspire-next.git","svn_url":"https://github.com/ammirate/inspire-next","homepage":"https://labs.inspirehep.net","size":71269,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspirehep:master","ref":"master","sha":"9ccc3428171a9f9a4f220a5365403e80d6d0747f","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"The next version of INSPIRE","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/inspirehep/inspire-next/deployments","created_at":"2013-12-16T09:11:58Z","updated_at":"2018-02-19T12:20:36Z","pushed_at":"2018-02-22T16:07:08Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"git@github.com:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":"https://labs.inspirehep.net","size":73915,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":247,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":51,"open_issues":247,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3194"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3194"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3194/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3194/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/0e4ef958d795cef6bb8f4de5c9c3618551b0bb12"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15221515,
"name": "inspirehep/inspire-next",
"url": "https://api.github.com/repos/inspirehep/inspire-next"
} | {
"id": 2895793,
"login": "michamos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2895793?",
"url": "https://api.github.com/users/michamos"
} | {
"id": 356664,
"login": "inspirehep",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/356664?",
"url": "https://api.github.com/orgs/inspirehep"
} | 2018-02-22T17:22:27 | 7282904525 | {"actor":{"display_login":"michamos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/170391198","pull_request_review_id":99079665,"id":170391198,"diff_hunk":"@@ -0,0 +1,300 @@\n+/**\n+ * Copyright (C) 2014-2016 LinkedIn Corp. (pinot-core@linkedin.com)\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.linkedin.pinot.controller.helix.core.rebalance;\n+\n+import com.google.common.collect.Lists;\n+import com.linkedin.pinot.common.config.TableConfig;\n+import com.linkedin.pinot.common.config.TagConfig;\n+import com.linkedin.pinot.common.metadata.stream.KafkaStreamMetadata;\n+import com.linkedin.pinot.common.utils.CommonConstants;\n+import com.linkedin.pinot.common.utils.CommonConstants.Helix.StateModel.RealtimeSegmentOnlineOfflineStateModel;\n+import com.linkedin.pinot.common.utils.LLCSegmentName;\n+import com.linkedin.pinot.common.utils.SegmentName;\n+import com.linkedin.pinot.common.utils.helix.HelixHelper;\n+import com.linkedin.pinot.controller.helix.PartitionAssignment;\n+import com.linkedin.pinot.controller.helix.core.PinotTableIdealStateBuilder;\n+import com.linkedin.pinot.controller.helix.core.realtime.partition.StreamPartitionAssignmentGenerator;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.HashSet;\n+import java.util.Iterator;\n+import java.util.LinkedHashMap;\n+import java.util.LinkedList;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.Set;\n+import org.apache.helix.HelixAdmin;\n+import org.apache.helix.HelixManager;\n+import org.apache.helix.ZNRecord;\n+import org.apache.helix.controller.rebalancer.strategy.AutoRebalanceStrategy;\n+import org.apache.helix.controller.stages.ClusterDataCache;\n+import org.apache.helix.model.IdealState;\n+import org.apache.helix.store.zk.ZkHelixPropertyStore;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+\n+/**\n+ * Basic rebalance segments strategy, which rebalances offline segments using autorebalance strategy,\n+ * and consuming segments using the partition assignment strategy for the table\n+ */\n+public class DefaultRebalanceSegmentStrategy extends BaseRebalanceSegmentStrategy {\n+\n+ private static final Logger LOGGER = LoggerFactory.getLogger(DefaultRebalanceSegmentStrategy.class);\n+\n+ protected static final String DEFAULT_DRY_RUN = \"true\";\n+ protected static final String DEFAULT_INCLUDE_CONSUMING = \"false\";\n+\n+ private HelixManager _helixManager;\n+ private HelixAdmin _helixAdmin;\n+ private String _helixClusterName;\n+ private ZkHelixPropertyStore<ZNRecord> _propertyStore;\n+\n+ public DefaultRebalanceSegmentStrategy(HelixManager helixManager) {\n+ super(helixManager);\n+ _helixManager = helixManager;\n+ _helixAdmin = helixManager.getClusterManagmentTool();\n+ _helixClusterName = helixManager.getClusterName();\n+ _propertyStore = helixManager.getHelixPropertyStore();\n+ }\n+\n+ @Override\n+ public PartitionAssignment rebalancePartitionAssignment(IdealState idealState, TableConfig tableConfig,\n+ RebalanceUserParams rebalanceUserParams) {\n+ PartitionAssignment partitionAssignment = new PartitionAssignment(tableConfig.getTableName());\n+\n+ boolean includeConsuming = Boolean.valueOf(\n+ rebalanceUserParams.getConfig(RebalanceUserParamConstants.INCLUDE_CONSUMING, DEFAULT_INCLUDE_CONSUMING));\n+ if (includeConsuming) {\n+ LOGGER.info(\"Rebalancing partition assignment for table {}\", tableConfig.getTableName());\n+\n+ if (tableConfig.getTableType().equals(CommonConstants.Helix.TableType.REALTIME)) {\n+\n+ StreamPartitionAssignmentGenerator streamPartitionAssignmentGenerator = new StreamPartitionAssignmentGenerator(_propertyStore);\n+ TagConfig tagConfig = new TagConfig(tableConfig, _helixManager);\n+ List<String> consumingInstances = _helixAdmin.getInstancesInClusterWithTag(_helixClusterName, tagConfig.getConsumingServerTag());\n+ String tableNameWithType = tableConfig.getTableName();\n+ // FIXME: where should this come from? from kafka metadata stream or just read from znode how many are existing?\n+ int numPartitions = getKafkaPartitionCount(tableConfig);\n+\n+ Map<String, PartitionAssignment> consumingPartitionAssignment =\n+ streamPartitionAssignmentGenerator.generatePartitionAssignment(tableConfig, numPartitions,\n+ consumingInstances, Lists.newArrayList(tableNameWithType));\n+ partitionAssignment = consumingPartitionAssignment.get(tableNameWithType);\n+\n+ boolean dryRun =\n+ Boolean.valueOf(rebalanceUserParams.getConfig(RebalanceUserParamConstants.DRYRUN, DEFAULT_DRY_RUN));\n+ if (!dryRun) {\n+ LOGGER.info(\"Updating stream partition assignment for table {}\", tableNameWithType);\n+ streamPartitionAssignmentGenerator.writeStreamPartitionAssignment(consumingPartitionAssignment);\n+ } else {\n+ LOGGER.info(\"Dry run. Skip writing stream partition assignment to property store\");\n+ LOGGER.info(\"Partition assignment for table {} is {}\", tableNameWithType, partitionAssignment);\n+ }\n+ }\n+ } else {\n+ LOGGER.info(\"includeConsuming = false. No need to rebalance partition assignment for {}\", tableConfig.getTableType());\n+ }\n+ return partitionAssignment;\n+ }\n+\n+ @Override\n+ public IdealState rebalanceIdealState(IdealState idealState, TableConfig tableConfig,\n+ RebalanceUserParams rebalanceUserParams, PartitionAssignment newPartitionAssignment) {\n+\n+ LOGGER.info(\"Rebalancing ideal state for table {}\", tableConfig.getTableName());\n+ String tableNameWithType = tableConfig.getTableName();\n+ CommonConstants.Helix.TableType tableType = tableConfig.getTableType();\n+\n+ // if realtime, rebalance consuming segments\n+ if (tableType.equals(CommonConstants.Helix.TableType.REALTIME)) {\n+ boolean includeConsuming = Boolean.valueOf(\n+ rebalanceUserParams.getConfig(RebalanceUserParamConstants.INCLUDE_CONSUMING, DEFAULT_INCLUDE_CONSUMING));\n+ if (includeConsuming) {\n+ rebalanceConsumingSegments(idealState, newPartitionAssignment);\n+ }\n+ }\n+ // rebalance serving segments\n+ int targetNumReplicas;\n+ if (tableType.equals(CommonConstants.Helix.TableType.REALTIME)) {\n+ String replicasString = tableConfig.getValidationConfig().getReplicasPerPartition();\n+ try {\n+ targetNumReplicas = Integer.parseInt(replicasString);\n+ } catch (Exception e) {\n+ throw new RuntimeException(\"Invalid value for replicasPerPartition:'\" + replicasString + \"'\", e);\n+ }\n+ } else {\n+ targetNumReplicas = Integer.parseInt(tableConfig.getValidationConfig().getReplication());\n+ }\n+ rebalanceServing(idealState, tableConfig, targetNumReplicas);\n+ boolean dryRun =\n+ Boolean.valueOf(rebalanceUserParams.getConfig(RebalanceUserParamConstants.DRYRUN, DEFAULT_DRY_RUN));\n+ if (!dryRun) {\n+ LOGGER.info(\"Updating ideal state for table {}\", tableNameWithType);\n+ updateIdealState(tableNameWithType, targetNumReplicas,\n+ idealState.getRecord().getMapFields());\n+ } else {\n+ LOGGER.info(\"Dry run. Skip writing ideal state\");\n+ }\n+ return idealState;\n+ }\n+\n+\n+\n+ /**\n+ * Rebalances serving segments based on autorebalance strategy\n+ * @param idealState\n+ * @param tableConfig\n+ * @param targetNumReplicas\n+ * @return\n+ */\n+ protected IdealState rebalanceServing(IdealState idealState, TableConfig tableConfig, int targetNumReplicas) {\n+\n+ LOGGER.info(\"Rebalancing serving segments for table {}\", tableConfig.getTableName());\n+ TagConfig tagConfig = new TagConfig(tableConfig, _helixManager);\n+ List<String> servingInstances =\n+ _helixAdmin.getInstancesInClusterWithTag(_helixClusterName, tagConfig.getCompletedServerTag());\n+ List<String> enabledServingInstances =\n+ HelixHelper.getEnabledInstancesWithTag(_helixAdmin, _helixClusterName, tagConfig.getCompletedServerTag());\n+\n+ int numReplicasInIdealState = Integer.parseInt(idealState.getReplicas());\n+\n+ if (numReplicasInIdealState > targetNumReplicas) { // We need to reduce the number of replicas per helix partition.\n+\n+ for (String segmentId : idealState.getPartitionSet()) {\n+ Map<String, String> instanceStateMap = idealState.getInstanceStateMap(segmentId);\n+ if (instanceStateMap.size() > targetNumReplicas) {\n+ Set<String> keys = instanceStateMap.keySet();\n+ while (instanceStateMap.size() > targetNumReplicas) {\n+ instanceStateMap.remove(keys.iterator().next());\n+ }\n+ } else if (instanceStateMap.size() < targetNumReplicas) {\n+ LOGGER.warn(\"Table {}, segment {} has {} replicas, less than {} (requested number of replicas\",\n+ idealState.getResourceName(), segmentId, instanceStateMap.size(), targetNumReplicas);\n+ }\n+ }\n+ } else { // Number of replicas is either the same or higher, so invoke Helix rebalancer.\n+\n+ final Map<String, Map<String, String>> mapFields = idealState.getRecord().getMapFields();\n+\n+ List<Map.Entry<String, Map<String, String>>> removedEntries = new LinkedList<>();\n+ if (tableConfig.getTableType().equals(CommonConstants.Helix.TableType.REALTIME)) {\n+ // FIXME: what about those in OFFLINE states?\n+ removeSegmentsNotBalanceable(mapFields, removedEntries);\n+ }\n+\n+ if (mapFields.isEmpty()) {// if ideal state had only CONSUMING segments so far, mapFields will be empty\n+ // we do not need to do anything in that case\n+ LOGGER.info(\"No LLC segments in ONLINE state for table {}\", tableConfig.getTableName());\n+ }\n+ else {\n+\n+ String tableNameWithType = tableConfig.getTableName();\n+\n+ LinkedHashMap<String, Integer> states = new LinkedHashMap<>();\n+ List<String> partitions = Lists.newArrayList(idealState.getPartitionSet());\n+ states.put(RealtimeSegmentOnlineOfflineStateModel.OFFLINE, 0);\n+ states.put(RealtimeSegmentOnlineOfflineStateModel.ONLINE, targetNumReplicas);\n+ Set<String> currentHosts = new HashSet<>();\n+ for (String segment : mapFields.keySet()) {\n+ currentHosts.addAll(mapFields.get(segment).keySet());\n+ }\n+ AutoRebalanceStrategy rebalanceStrategy = new AutoRebalanceStrategy(tableNameWithType, partitions, states);\n+\n+ LOGGER.info(\"Current nodes for table {}: {}\", tableNameWithType, currentHosts);\n+ LOGGER.info(\"New nodes for table {}: {}\", tableNameWithType, servingInstances);\n+ LOGGER.info(\"Enabled nodes for table: {} {}\", tableNameWithType, enabledServingInstances);\n+ ZNRecord newZnRecord =\n+ rebalanceStrategy.computePartitionAssignment(servingInstances, enabledServingInstances, mapFields, new ClusterDataCache());\n+ final Map<String, Map<String, String>> newMapping = newZnRecord.getMapFields();\n+ for (Map.Entry<String, Map<String, String>> entry : newMapping.entrySet()) {\n+ idealState.setInstanceStateMap(entry.getKey(), entry.getValue());\n+ }\n+ }\n+ // If we removed any entries, add them back here\n+ for (Map.Entry<String, Map<String, String>> entry : removedEntries) {\n+ idealState.setInstanceStateMap(entry.getKey(), entry.getValue());\n+ }\n+ }\n+ idealState.setReplicas(Integer.toString(targetNumReplicas));\n+ return idealState;\n+ }\n+\n+ /**\n+ * Rebalances consuming segments based on partition assignment of the stream partitions\n+ * @param idealState\n+ * @param newPartitionAssignment\n+ */\n+ private void rebalanceConsumingSegments(IdealState idealState, PartitionAssignment newPartitionAssignment) {\n+ List<String> consumingSegments = new ArrayList<>();\n+ LOGGER.info(\"Rebalancing consuming segments for table {}\", idealState.getResourceName());\n+ Map<String, Map<String, String>> mapFields = idealState.getRecord().getMapFields();\n+ // FIXME: is this sufficient to get all consuming segments? what is someone went into error/offline?\n+ for (Map.Entry<String, Map<String, String>> entry : mapFields.entrySet()) {\n+ Collection<String> instanceStates = entry.getValue().values();\n+ if (instanceStates.contains(RealtimeSegmentOnlineOfflineStateModel.CONSUMING)) {\n+ consumingSegments.add(entry.getKey());\n+ }\n+ }\n+ // TODO: check that targetNumReplicas and replicas in newPartitionAssignment match","path":"pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/rebalance/DefaultRebalanceSegmentStrategy.java","position":254,"original_position":254,"commit_id":"87d9f52e99a36d90d2cbe8899ebe901b59b297f8","original_commit_id":"87d9f52e99a36d90d2cbe8899ebe901b59b297f8","user":{"login":"mcvsubbu","id":2279037,"avatar_url":"https://avatars3.githubusercontent.com/u/2279037?v=4","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"body":"not clear what the todo is?","created_at":"2018-02-23T23:13:31Z","updated_at":"2018-02-23T23:28:41Z","html_url":"https://github.com/linkedin/pinot/pull/2507#discussion_r170391198","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/2507","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/170391198"},"html":{"href":"https://github.com/linkedin/pinot/pull/2507#discussion_r170391198"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2507"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/2507","id":170075891,"html_url":"https://github.com/linkedin/pinot/pull/2507","diff_url":"https://github.com/linkedin/pinot/pull/2507.diff","patch_url":"https://github.com/linkedin/pinot/pull/2507.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/2507","number":2507,"state":"open","locked":false,"title":"Rebalance strategy interface and DefaultRebalanceStrategy implementation","user":{"login":"npawar","id":19693933,"avatar_url":"https://avatars0.githubusercontent.com/u/19693933?v=4","gravatar_id":"","url":"https://api.github.com/users/npawar","html_url":"https://github.com/npawar","followers_url":"https://api.github.com/users/npawar/followers","following_url":"https://api.github.com/users/npawar/following{/other_user}","gists_url":"https://api.github.com/users/npawar/gists{/gist_id}","starred_url":"https://api.github.com/users/npawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npawar/subscriptions","organizations_url":"https://api.github.com/users/npawar/orgs","repos_url":"https://api.github.com/users/npawar/repos","events_url":"https://api.github.com/users/npawar/events{/privacy}","received_events_url":"https://api.github.com/users/npawar/received_events","type":"User","site_admin":false},"body":"Introduce an interface for RebalanceSegmentsStrategy, which has rebalancePartitions and rebalanceSegments\nAdding defaultRebalanceStrategy implementation, which rebalances stream partition assignment for rebalancing consuming segments, and also rebalances completed segments using auto rebalance strategy","created_at":"2018-02-20T00:10:17Z","updated_at":"2018-02-23T23:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21efa8ad59a98c8f0bc958627b78319c5a8ce7fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/2507/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/2507/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/2507/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/87d9f52e99a36d90d2cbe8899ebe901b59b297f8","head":{"label":"linkedin:rebalance_consuming_segments","ref":"rebalance_consuming_segments","sha":"87d9f52e99a36d90d2cbe8899ebe901b59b297f8","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2018-02-23T20:43:31Z","pushed_at":"2018-02-23T23:27:46Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":147851,"stargazers_count":1754,"watchers_count":1754,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":318,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":318,"open_issues":154,"watchers":1754,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"21880cab8a41616fd96681316f1527b8dfcd396a","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2018-02-23T20:43:31Z","pushed_at":"2018-02-23T23:27:46Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":147851,"stargazers_count":1754,"watchers_count":1754,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":318,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":318,"open_issues":154,"watchers":1754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2507"},"html":{"href":"https://github.com/linkedin/pinot/pull/2507"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/2507"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/2507/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2507/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2507/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/87d9f52e99a36d90d2cbe8899ebe901b59b297f8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19961085,
"name": "linkedin/pinot",
"url": "https://api.github.com/repos/linkedin/pinot"
} | {
"id": 2279037,
"login": "mcvsubbu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2279037?",
"url": "https://api.github.com/users/mcvsubbu"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2018-02-23T23:13:31 | 7290096625 | {"actor":{"display_login":"mcvsubbu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/231636884","pull_request_review_id":172647819,"id":231636884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTYzNjg4NA==","diff_hunk":"@@ -213,32 +210,52 @@ public void removeAgedDeletedSegments(int retentionInDays) {\n return;\n }\n \n- AgeFileFilter fileFilter = new AgeFileFilter(DateTime.now().minusDays(retentionInDays).toDate());\n- File[] directories = deletedDir.listFiles((FileFilter) DirectoryFileFilter.DIRECTORY);\n- // Check that the directory for deleted segments is empty\n- if (directories == null) {\n- LOGGER.warn(\"Deleted segment directory {} does not exist or it caused an I/O error.\", deletedDir);\n+ URI dataDirURI = ControllerConf.getUriFromPath(_dataDir);\n+ URI deletedDirURI = ControllerConf.getUriFromPath(StringUtil.join(File.separator, _dataDir, DELETED_SEGMENTS));\n+ PinotFS pinotFS = PinotFSFactory.create(dataDirURI.getScheme());\n+\n+ // Check that the directory for deleted segments exists\n+ if (!pinotFS.isDirectory(deletedDirURI)) {\n+ LOGGER.warn(\"Deleted segment directory {} does not exist or it is not directory.\", deletedDirURI.toString());\n return;\n }\n \n- for (File currentDir : directories) {\n+ try {\n+ String[] tableNameDirs = pinotFS.listFiles(deletedDirURI, false);\n+ if (tableNameDirs == null) {\n+ LOGGER.warn(\"Deleted segment directory {} does not exist.\", deletedDirURI.toString());\n+ return;\n+ }\n+\n+ for (String tableNameDir : tableNameDirs) {\n+ URI tableNameURI = ControllerConf.getUriFromPath(tableNameDir);\n // Get files that are aged\n- Collection<File> targetFiles = FileUtils.listFiles(currentDir, fileFilter, null);\n- // Delete aged files\n- for (File f : targetFiles) {\n- if (!f.delete()) {\n- LOGGER.warn(\"Cannot remove file {} from deleted directory.\", f.getAbsolutePath());\n+ final String[] targetFiles = pinotFS.listFiles(tableNameURI, false);\n+ int numFilesDeleted = 0;\n+ for (String targetFile : targetFiles) {\n+ URI targetURI = ControllerConf.getUriFromPath(targetFile);\n+ Date dateToDelete = DateTime.now().minusDays(retentionInDays).toDate();\n+ if (pinotFS.lastModified(targetURI) < dateToDelete.getTime()) {\n+ if (!pinotFS.delete(targetURI, true)) {\n+ LOGGER.warn(\"Cannot remove file {} from deleted directory.\", targetURI.toString());\n+ } else {\n+ numFilesDeleted ++;\n+ }\n }\n }\n- // Delete directory if it's empty\n- if (currentDir.list() != null && currentDir.list().length == 0) {\n- if (!currentDir.delete()) {\n- LOGGER.warn(\"The directory {} cannot be removed. The directory may not be empty.\", currentDir.getAbsolutePath());\n+\n+ if (numFilesDeleted == targetFiles.length) {\n+ // Delete directory if it's empty\n+ if (!pinotFS.delete(tableNameURI, false)) {\n+ LOGGER.warn(\"The directory {} cannot be removed.\", tableNameDir);\n }\n }\n }\n+ } catch (IOException e){","path":"pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/SegmentDeletionManager.java","position":83,"original_position":83,"commit_id":"af4902b613d4382480897e9b6cc384fb623ade2c","original_commit_id":"af4902b613d4382480897e9b6cc384fb623ade2c","user":{"login":"jackjlli","id":35080149,"node_id":"MDQ6VXNlcjM1MDgwMTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/35080149?v=4","gravatar_id":"","url":"https://api.github.com/users/jackjlli","html_url":"https://github.com/jackjlli","followers_url":"https://api.github.com/users/jackjlli/followers","following_url":"https://api.github.com/users/jackjlli/following{/other_user}","gists_url":"https://api.github.com/users/jackjlli/gists{/gist_id}","starred_url":"https://api.github.com/users/jackjlli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackjlli/subscriptions","organizations_url":"https://api.github.com/users/jackjlli/orgs","repos_url":"https://api.github.com/users/jackjlli/repos","events_url":"https://api.github.com/users/jackjlli/events{/privacy}","received_events_url":"https://api.github.com/users/jackjlli/received_events","type":"User","site_admin":false},"body":"nit: add a space between `){`","created_at":"2018-11-07T19:04:23Z","updated_at":"2018-11-07T19:10:05Z","html_url":"https://github.com/linkedin/pinot/pull/3371#discussion_r231636884","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/3371","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/231636884"},"html":{"href":"https://github.com/linkedin/pinot/pull/3371#discussion_r231636884"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/3371"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/3371","id":225138886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTM4ODg2","html_url":"https://github.com/linkedin/pinot/pull/3371","diff_url":"https://github.com/linkedin/pinot/pull/3371.diff","patch_url":"https://github.com/linkedin/pinot/pull/3371.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/3371","number":3371,"state":"open","locked":false,"title":"Adding RetentionManager Support for Pluggable Storage","user":{"login":"jenniferdai","id":5035129,"node_id":"MDQ6VXNlcjUwMzUxMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/5035129?v=4","gravatar_id":"","url":"https://api.github.com/users/jenniferdai","html_url":"https://github.com/jenniferdai","followers_url":"https://api.github.com/users/jenniferdai/followers","following_url":"https://api.github.com/users/jenniferdai/following{/other_user}","gists_url":"https://api.github.com/users/jenniferdai/gists{/gist_id}","starred_url":"https://api.github.com/users/jenniferdai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenniferdai/subscriptions","organizations_url":"https://api.github.com/users/jenniferdai/orgs","repos_url":"https://api.github.com/users/jenniferdai/repos","events_url":"https://api.github.com/users/jenniferdai/events{/privacy}","received_events_url":"https://api.github.com/users/jenniferdai/received_events","type":"User","site_admin":false},"body":"* This PR will allow us to fully add support for pluggable storage in RetentionManager, which will allow us to age out segments that are deleted.\r\n* Adds lastModified method to PinotFS.\r\n* Changing listFiles to include files and directories and have an option for recursive or not\r\n* Changing isDirectory to not throw an IOException\r\n* Adding test for lastModified\r\n* Fixing AzurePinotFS bug in listFiles\r\n* Test coverage in SegmentDeletionManagerTest","created_at":"2018-10-23T18:20:17Z","updated_at":"2018-11-07T19:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b6f95b03d5263bd28d97140c6a12a7a179089e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/3371/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/3371/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/3371/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/af4902b613d4382480897e9b6cc384fb623ade2c","head":{"label":"linkedin:addAged","ref":"addAged","sha":"af4902b613d4382480897e9b6cc384fb623ade2c","user":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk2MTA4NQ==","name":"pinot","full_name":"linkedin/pinot","private":false,"owner":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2018-11-07T16:39:17Z","pushed_at":"2018-11-07T19:04:54Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":156903,"stargazers_count":2018,"watchers_count":2018,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":365,"open_issues":188,"watchers":2018,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"2e8e20eacacc252565bd6ba0b73b3e7a8dbb60ad","user":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk2MTA4NQ==","name":"pinot","full_name":"linkedin/pinot","private":false,"owner":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2018-11-07T16:39:17Z","pushed_at":"2018-11-07T19:04:54Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":156903,"stargazers_count":2018,"watchers_count":2018,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":365,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":365,"open_issues":188,"watchers":2018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/3371"},"html":{"href":"https://github.com/linkedin/pinot/pull/3371"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/3371"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/3371/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/3371/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/3371/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/af4902b613d4382480897e9b6cc384fb623ade2c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19961085,
"name": "linkedin/pinot",
"url": "https://api.github.com/repos/linkedin/pinot"
} | {
"id": 35080149,
"login": "jackjlli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35080149?",
"url": "https://api.github.com/users/jackjlli"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2018-11-07T19:04:23 | 8551816721 | {"actor":{"display_login":"jackjlli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/175544669","pull_request_review_id":105090999,"id":175544669,"diff_hunk":"@@ -399,27 +404,27 @@ export default Controller.extend({\n }),\n \n /**\n- * Update feedback status on any anomaly\n- * @method updateAnomalyFeedback\n- * @param {Number} anomalyId - the id of the anomaly to update\n- * @param {String} feedbackType - key for feedback type\n- * @return {Ember.RSVP.Promise}\n- */\n- updateAnomalyFeedback(anomalyId, feedbackType) {\n- const url = `/anomalies/updateFeedback/${anomalyId}`;\n- const data = { feedbackType, comment: '' };\n- return fetch(url, postProps(data)).then((res) => checkStatus(res, 'post'));\n- },\n-\n- /**\n- * Fetch a single anomaly record for verification\n- * @method verifyAnomalyFeedback\n- * @param {Number} anomalyId\n+ * Reset all time range options and activate the selected one\n+ * @method newTimeRangeOptions\n+ * @param {String} activeKey - label for currently active time range\n * @return {undefined}\n */\n- verifyAnomalyFeedback(anomalyId) {\n- const anomalyUrl = this.get('anomalyDataUrl') + anomalyId;\n- return fetch(anomalyUrl).then(checkStatus);\n+ newTimeRangeOptions(activeKey) {\n+ const timeRangeOptions = this.get('timeRangeOptions');\n+ const newOptions = timeRangeOptions.map((range) => {","path":"thirdeye/thirdeye-frontend/app/pods/manage/alert/explore/controller.js","position":64,"original_position":42,"commit_id":"eebb4aee8c744e6c33aadc7bf31655cdc10e83ba","original_commit_id":"cab99c75ddfb2dbee43a46030db5f8582ac35e79","user":{"login":"aaronucsd","id":8840761,"avatar_url":"https://avatars1.githubusercontent.com/u/8840761?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronucsd","html_url":"https://github.com/aaronucsd","followers_url":"https://api.github.com/users/aaronucsd/followers","following_url":"https://api.github.com/users/aaronucsd/following{/other_user}","gists_url":"https://api.github.com/users/aaronucsd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronucsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronucsd/subscriptions","organizations_url":"https://api.github.com/users/aaronucsd/orgs","repos_url":"https://api.github.com/users/aaronucsd/repos","events_url":"https://api.github.com/users/aaronucsd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronucsd/received_events","type":"User","site_admin":false},"body":"SKIPPED","created_at":"2018-03-19T18:42:12Z","updated_at":"2018-03-19T18:42:13Z","html_url":"https://github.com/linkedin/pinot/pull/2634#discussion_r175544669","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/2634","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/175544669"},"html":{"href":"https://github.com/linkedin/pinot/pull/2634#discussion_r175544669"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2634"}},"in_reply_to_id":175231956},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/2634","id":175657463,"html_url":"https://github.com/linkedin/pinot/pull/2634","diff_url":"https://github.com/linkedin/pinot/pull/2634.diff","patch_url":"https://github.com/linkedin/pinot/pull/2634.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/2634","number":2634,"state":"open","locked":false,"title":" [TE] frontend - aaronucsd/added new custom component for Resolution","user":{"login":"aaronucsd","id":8840761,"avatar_url":"https://avatars1.githubusercontent.com/u/8840761?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronucsd","html_url":"https://github.com/aaronucsd","followers_url":"https://api.github.com/users/aaronucsd/followers","following_url":"https://api.github.com/users/aaronucsd/following{/other_user}","gists_url":"https://api.github.com/users/aaronucsd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronucsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronucsd/subscriptions","organizations_url":"https://api.github.com/users/aaronucsd/orgs","repos_url":"https://api.github.com/users/aaronucsd/repos","events_url":"https://api.github.com/users/aaronucsd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronucsd/received_events","type":"User","site_admin":false},"body":"\r\n\r\n\r\n1. Added new resolution custom component\r\n2. fixed the icon issue on resolution select for model table\r\n3. Updated styling for the fix in #2\r\n4. Added new method to anomaly util file and moved a few needed anomaly methods from\r\napp/pods/manage/alert/explore/controller.js\r\n5. Moved anomalyResponseObj constant to anomaly util from\r\napp/pods/manage/alert/explore/route.js\r\n6. Updated app/pods/manage/alert/explore/* to use the methods from anomaly util\r\n7. updated anomaly util unit test and ran all tests for sanity","created_at":"2018-03-16T22:11:10Z","updated_at":"2018-03-19T18:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"967771bc2eadf2376d08c60ad999ef51a32c5bac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/2634/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/2634/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/2634/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/eebb4aee8c744e6c33aadc7bf31655cdc10e83ba","head":{"label":"aaronucsd:resolution-template","ref":"resolution-template","sha":"eebb4aee8c744e6c33aadc7bf31655cdc10e83ba","user":{"login":"aaronucsd","id":8840761,"avatar_url":"https://avatars1.githubusercontent.com/u/8840761?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronucsd","html_url":"https://github.com/aaronucsd","followers_url":"https://api.github.com/users/aaronucsd/followers","following_url":"https://api.github.com/users/aaronucsd/following{/other_user}","gists_url":"https://api.github.com/users/aaronucsd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronucsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronucsd/subscriptions","organizations_url":"https://api.github.com/users/aaronucsd/orgs","repos_url":"https://api.github.com/users/aaronucsd/repos","events_url":"https://api.github.com/users/aaronucsd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronucsd/received_events","type":"User","site_admin":false},"repo":{"id":124121729,"name":"pinot","full_name":"aaronucsd/pinot","owner":{"login":"aaronucsd","id":8840761,"avatar_url":"https://avatars1.githubusercontent.com/u/8840761?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronucsd","html_url":"https://github.com/aaronucsd","followers_url":"https://api.github.com/users/aaronucsd/followers","following_url":"https://api.github.com/users/aaronucsd/following{/other_user}","gists_url":"https://api.github.com/users/aaronucsd/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronucsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronucsd/subscriptions","organizations_url":"https://api.github.com/users/aaronucsd/orgs","repos_url":"https://api.github.com/users/aaronucsd/repos","events_url":"https://api.github.com/users/aaronucsd/events{/privacy}","received_events_url":"https://api.github.com/users/aaronucsd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronucsd/pinot","description":"A realtime distributed OLAP datastore","fork":true,"url":"https://api.github.com/repos/aaronucsd/pinot","forks_url":"https://api.github.com/repos/aaronucsd/pinot/forks","keys_url":"https://api.github.com/repos/aaronucsd/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronucsd/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronucsd/pinot/teams","hooks_url":"https://api.github.com/repos/aaronucsd/pinot/hooks","issue_events_url":"https://api.github.com/repos/aaronucsd/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/aaronucsd/pinot/events","assignees_url":"https://api.github.com/repos/aaronucsd/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/aaronucsd/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/aaronucsd/pinot/tags","blobs_url":"https://api.github.com/repos/aaronucsd/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronucsd/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronucsd/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronucsd/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronucsd/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronucsd/pinot/languages","stargazers_url":"https://api.github.com/repos/aaronucsd/pinot/stargazers","contributors_url":"https://api.github.com/repos/aaronucsd/pinot/contributors","subscribers_url":"https://api.github.com/repos/aaronucsd/pinot/subscribers","subscription_url":"https://api.github.com/repos/aaronucsd/pinot/subscription","commits_url":"https://api.github.com/repos/aaronucsd/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronucsd/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronucsd/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronucsd/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronucsd/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/aaronucsd/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronucsd/pinot/merges","archive_url":"https://api.github.com/repos/aaronucsd/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronucsd/pinot/downloads","issues_url":"https://api.github.com/repos/aaronucsd/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/aaronucsd/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronucsd/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronucsd/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronucsd/pinot/labels{/name}","releases_url":"https://api.github.com/repos/aaronucsd/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/aaronucsd/pinot/deployments","created_at":"2018-03-06T18:33:24Z","updated_at":"2018-03-14T17:37:30Z","pushed_at":"2018-03-19T18:39:49Z","git_url":"git://github.com/aaronucsd/pinot.git","ssh_url":"git@github.com:aaronucsd/pinot.git","clone_url":"https://github.com/aaronucsd/pinot.git","svn_url":"https://github.com/aaronucsd/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":148557,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"a8934833c5dff1d3da99363a998291c01b19a8bb","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2018-03-19T16:52:31Z","pushed_at":"2018-03-19T18:39:51Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":148536,"stargazers_count":1773,"watchers_count":1773,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":323,"open_issues":159,"watchers":1773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2634"},"html":{"href":"https://github.com/linkedin/pinot/pull/2634"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/2634"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/2634/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2634/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/2634/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/eebb4aee8c744e6c33aadc7bf31655cdc10e83ba"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19961085,
"name": "linkedin/pinot",
"url": "https://api.github.com/repos/linkedin/pinot"
} | {
"id": 8840761,
"login": "aaronucsd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8840761?",
"url": "https://api.github.com/users/aaronucsd"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2018-03-19T18:42:12 | 7402245375 | {"actor":{"display_login":"aaronucsd"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hashcube/facebook/pulls/comments/219439227","pull_request_review_id":157614872,"id":219439227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQzOTIyNw==","diff_hunk":"@@ -8,7 +8,8 @@ buildscript {\n }\n dependencies {\n classpath 'com.android.tools.build:gradle:3.1.3'\n- ","path":"android/FacebookSDK400/build.gradle","position":4,"original_position":4,"commit_id":"357d083b0ed947785eb7374ad6e3ba3846fcaf6c","original_commit_id":"357d083b0ed947785eb7374ad6e3ba3846fcaf6c","user":{"login":"vivekb91","id":13887851,"node_id":"MDQ6VXNlcjEzODg3ODUx","avatar_url":"https://avatars3.githubusercontent.com/u/13887851?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekb91","html_url":"https://github.com/vivekb91","followers_url":"https://api.github.com/users/vivekb91/followers","following_url":"https://api.github.com/users/vivekb91/following{/other_user}","gists_url":"https://api.github.com/users/vivekb91/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekb91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekb91/subscriptions","organizations_url":"https://api.github.com/users/vivekb91/orgs","repos_url":"https://api.github.com/users/vivekb91/repos","events_url":"https://api.github.com/users/vivekb91/events{/privacy}","received_events_url":"https://api.github.com/users/vivekb91/received_events","type":"User","site_admin":false},"body":"can remove this unwanted change","created_at":"2018-09-21T09:34:41Z","updated_at":"2018-09-21T09:34:41Z","html_url":"https://github.com/hashcube/facebook/pull/27#discussion_r219439227","pull_request_url":"https://api.github.com/repos/hashcube/facebook/pulls/27","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/comments/219439227"},"html":{"href":"https://github.com/hashcube/facebook/pull/27#discussion_r219439227"},"pull_request":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/hashcube/facebook/pulls/27","id":217225109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjI1MTA5","html_url":"https://github.com/hashcube/facebook/pull/27","diff_url":"https://github.com/hashcube/facebook/pull/27.diff","patch_url":"https://github.com/hashcube/facebook/pull/27.patch","issue_url":"https://api.github.com/repos/hashcube/facebook/issues/27","number":27,"state":"open","locked":false,"title":"Add bolts framework as a jar directly","user":{"login":"rampr","id":100719,"node_id":"MDQ6VXNlcjEwMDcxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/100719?v=4","gravatar_id":"","url":"https://api.github.com/users/rampr","html_url":"https://github.com/rampr","followers_url":"https://api.github.com/users/rampr/followers","following_url":"https://api.github.com/users/rampr/following{/other_user}","gists_url":"https://api.github.com/users/rampr/gists{/gist_id}","starred_url":"https://api.github.com/users/rampr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rampr/subscriptions","organizations_url":"https://api.github.com/users/rampr/orgs","repos_url":"https://api.github.com/users/rampr/repos","events_url":"https://api.github.com/users/rampr/events{/privacy}","received_events_url":"https://api.github.com/users/rampr/received_events","type":"User","site_admin":false},"body":"Calls to bolts code wasn't working correctly when done as part of gradle, so temporarily using it as a jar","created_at":"2018-09-21T09:33:01Z","updated_at":"2018-09-21T09:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfa2a79ede793e80340c0c1d5dce262b20c8a172","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashcube/facebook/pulls/27/commits","review_comments_url":"https://api.github.com/repos/hashcube/facebook/pulls/27/comments","review_comment_url":"https://api.github.com/repos/hashcube/facebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashcube/facebook/issues/27/comments","statuses_url":"https://api.github.com/repos/hashcube/facebook/statuses/357d083b0ed947785eb7374ad6e3ba3846fcaf6c","head":{"label":"hashcube:add_bolts_as_jar","ref":"add_bolts_as_jar","sha":"357d083b0ed947785eb7374ad6e3ba3846fcaf6c","user":{"login":"hashcube","id":360533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/360533?v=4","gravatar_id":"","url":"https://api.github.com/users/hashcube","html_url":"https://github.com/hashcube","followers_url":"https://api.github.com/users/hashcube/followers","following_url":"https://api.github.com/users/hashcube/following{/other_user}","gists_url":"https://api.github.com/users/hashcube/gists{/gist_id}","starred_url":"https://api.github.com/users/hashcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashcube/subscriptions","organizations_url":"https://api.github.com/users/hashcube/orgs","repos_url":"https://api.github.com/users/hashcube/repos","events_url":"https://api.github.com/users/hashcube/events{/privacy}","received_events_url":"https://api.github.com/users/hashcube/received_events","type":"Organization","site_admin":false},"repo":{"id":60680962,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY4MDk2Mg==","name":"facebook","full_name":"hashcube/facebook","private":false,"owner":{"login":"hashcube","id":360533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/360533?v=4","gravatar_id":"","url":"https://api.github.com/users/hashcube","html_url":"https://github.com/hashcube","followers_url":"https://api.github.com/users/hashcube/followers","following_url":"https://api.github.com/users/hashcube/following{/other_user}","gists_url":"https://api.github.com/users/hashcube/gists{/gist_id}","starred_url":"https://api.github.com/users/hashcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashcube/subscriptions","organizations_url":"https://api.github.com/users/hashcube/orgs","repos_url":"https://api.github.com/users/hashcube/repos","events_url":"https://api.github.com/users/hashcube/events{/privacy}","received_events_url":"https://api.github.com/users/hashcube/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashcube/facebook","description":"facebook module for GameClosure devkit","fork":false,"url":"https://api.github.com/repos/hashcube/facebook","forks_url":"https://api.github.com/repos/hashcube/facebook/forks","keys_url":"https://api.github.com/repos/hashcube/facebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashcube/facebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashcube/facebook/teams","hooks_url":"https://api.github.com/repos/hashcube/facebook/hooks","issue_events_url":"https://api.github.com/repos/hashcube/facebook/issues/events{/number}","events_url":"https://api.github.com/repos/hashcube/facebook/events","assignees_url":"https://api.github.com/repos/hashcube/facebook/assignees{/user}","branches_url":"https://api.github.com/repos/hashcube/facebook/branches{/branch}","tags_url":"https://api.github.com/repos/hashcube/facebook/tags","blobs_url":"https://api.github.com/repos/hashcube/facebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashcube/facebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashcube/facebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashcube/facebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashcube/facebook/statuses/{sha}","languages_url":"https://api.github.com/repos/hashcube/facebook/languages","stargazers_url":"https://api.github.com/repos/hashcube/facebook/stargazers","contributors_url":"https://api.github.com/repos/hashcube/facebook/contributors","subscribers_url":"https://api.github.com/repos/hashcube/facebook/subscribers","subscription_url":"https://api.github.com/repos/hashcube/facebook/subscription","commits_url":"https://api.github.com/repos/hashcube/facebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashcube/facebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashcube/facebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashcube/facebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashcube/facebook/contents/{+path}","compare_url":"https://api.github.com/repos/hashcube/facebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashcube/facebook/merges","archive_url":"https://api.github.com/repos/hashcube/facebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashcube/facebook/downloads","issues_url":"https://api.github.com/repos/hashcube/facebook/issues{/number}","pulls_url":"https://api.github.com/repos/hashcube/facebook/pulls{/number}","milestones_url":"https://api.github.com/repos/hashcube/facebook/milestones{/number}","notifications_url":"https://api.github.com/repos/hashcube/facebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashcube/facebook/labels{/name}","releases_url":"https://api.github.com/repos/hashcube/facebook/releases{/id}","deployments_url":"https://api.github.com/repos/hashcube/facebook/deployments","created_at":"2016-06-08T08:17:42Z","updated_at":"2018-06-20T07:52:20Z","pushed_at":"2018-09-21T09:33:02Z","git_url":"git://github.com/hashcube/facebook.git","ssh_url":"git@github.com:hashcube/facebook.git","clone_url":"https://github.com/hashcube/facebook.git","svn_url":"https://github.com/hashcube/facebook","homepage":null,"size":68789,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"hashcube:gradle","ref":"gradle","sha":"1efb532c1e9eeaaf7aeb720ea3d0e233cb416dde","user":{"login":"hashcube","id":360533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/360533?v=4","gravatar_id":"","url":"https://api.github.com/users/hashcube","html_url":"https://github.com/hashcube","followers_url":"https://api.github.com/users/hashcube/followers","following_url":"https://api.github.com/users/hashcube/following{/other_user}","gists_url":"https://api.github.com/users/hashcube/gists{/gist_id}","starred_url":"https://api.github.com/users/hashcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashcube/subscriptions","organizations_url":"https://api.github.com/users/hashcube/orgs","repos_url":"https://api.github.com/users/hashcube/repos","events_url":"https://api.github.com/users/hashcube/events{/privacy}","received_events_url":"https://api.github.com/users/hashcube/received_events","type":"Organization","site_admin":false},"repo":{"id":60680962,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY4MDk2Mg==","name":"facebook","full_name":"hashcube/facebook","private":false,"owner":{"login":"hashcube","id":360533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDUzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/360533?v=4","gravatar_id":"","url":"https://api.github.com/users/hashcube","html_url":"https://github.com/hashcube","followers_url":"https://api.github.com/users/hashcube/followers","following_url":"https://api.github.com/users/hashcube/following{/other_user}","gists_url":"https://api.github.com/users/hashcube/gists{/gist_id}","starred_url":"https://api.github.com/users/hashcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashcube/subscriptions","organizations_url":"https://api.github.com/users/hashcube/orgs","repos_url":"https://api.github.com/users/hashcube/repos","events_url":"https://api.github.com/users/hashcube/events{/privacy}","received_events_url":"https://api.github.com/users/hashcube/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashcube/facebook","description":"facebook module for GameClosure devkit","fork":false,"url":"https://api.github.com/repos/hashcube/facebook","forks_url":"https://api.github.com/repos/hashcube/facebook/forks","keys_url":"https://api.github.com/repos/hashcube/facebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashcube/facebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashcube/facebook/teams","hooks_url":"https://api.github.com/repos/hashcube/facebook/hooks","issue_events_url":"https://api.github.com/repos/hashcube/facebook/issues/events{/number}","events_url":"https://api.github.com/repos/hashcube/facebook/events","assignees_url":"https://api.github.com/repos/hashcube/facebook/assignees{/user}","branches_url":"https://api.github.com/repos/hashcube/facebook/branches{/branch}","tags_url":"https://api.github.com/repos/hashcube/facebook/tags","blobs_url":"https://api.github.com/repos/hashcube/facebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashcube/facebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashcube/facebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashcube/facebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashcube/facebook/statuses/{sha}","languages_url":"https://api.github.com/repos/hashcube/facebook/languages","stargazers_url":"https://api.github.com/repos/hashcube/facebook/stargazers","contributors_url":"https://api.github.com/repos/hashcube/facebook/contributors","subscribers_url":"https://api.github.com/repos/hashcube/facebook/subscribers","subscription_url":"https://api.github.com/repos/hashcube/facebook/subscription","commits_url":"https://api.github.com/repos/hashcube/facebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashcube/facebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashcube/facebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashcube/facebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashcube/facebook/contents/{+path}","compare_url":"https://api.github.com/repos/hashcube/facebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashcube/facebook/merges","archive_url":"https://api.github.com/repos/hashcube/facebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashcube/facebook/downloads","issues_url":"https://api.github.com/repos/hashcube/facebook/issues{/number}","pulls_url":"https://api.github.com/repos/hashcube/facebook/pulls{/number}","milestones_url":"https://api.github.com/repos/hashcube/facebook/milestones{/number}","notifications_url":"https://api.github.com/repos/hashcube/facebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashcube/facebook/labels{/name}","releases_url":"https://api.github.com/repos/hashcube/facebook/releases{/id}","deployments_url":"https://api.github.com/repos/hashcube/facebook/deployments","created_at":"2016-06-08T08:17:42Z","updated_at":"2018-06-20T07:52:20Z","pushed_at":"2018-09-21T09:33:02Z","git_url":"git://github.com/hashcube/facebook.git","ssh_url":"git@github.com:hashcube/facebook.git","clone_url":"https://github.com/hashcube/facebook.git","svn_url":"https://github.com/hashcube/facebook","homepage":null,"size":68789,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/27"},"html":{"href":"https://github.com/hashcube/facebook/pull/27"},"issue":{"href":"https://api.github.com/repos/hashcube/facebook/issues/27"},"comments":{"href":"https://api.github.com/repos/hashcube/facebook/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashcube/facebook/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/hashcube/facebook/statuses/357d083b0ed947785eb7374ad6e3ba3846fcaf6c"}},"author_association":"MEMBER"}} | {
"id": 60680962,
"name": "hashcube/facebook",
"url": "https://api.github.com/repos/hashcube/facebook"
} | {
"id": 13887851,
"login": "vivekb91",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13887851?",
"url": "https://api.github.com/users/vivekb91"
} | {
"id": 360533,
"login": "hashcube",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/360533?",
"url": "https://api.github.com/orgs/hashcube"
} | 2018-09-21T09:34:41 | 8300897176 | {"actor":{"display_login":"vivekb91"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/comments/214467657","pull_request_review_id":151534920,"id":214467657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ2NzY1Nw==","diff_hunk":"@@ -172,36 +217,46 @@ function normalizeArgs (args) {\n }\n }\n \n-function createOperationSpan (tracer, config, operation, source) {\n+function createOperationSpan (tracer, config, operation, source, variableValues, startTime) {\n const type = operation.operation\n const name = operation.name && operation.name.value\n-\n const parentScope = tracer.scopeManager().active()\n+ const tags = {\n+ 'service.name': getService(tracer, config),\n+ 'resource.name': [type, name].filter(val => val).join(' '),\n+ 'graphql.document': source\n+ }\n+ if (variableValues && config.filterVariables) {\n+ tags['graphql.variables'] = JSON.stringify(config.filterVariables(variableValues))","path":"src/plugins/graphql.js","position":137,"original_position":137,"commit_id":"5dfd48e365a12b6190a9b6294859c94f10d8b5de","original_commit_id":"5dfd48e365a12b6190a9b6294859c94f10d8b5de","user":{"login":"rochdev","id":1596303,"node_id":"MDQ6VXNlcjE1OTYzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1596303?v=4","gravatar_id":"","url":"https://api.github.com/users/rochdev","html_url":"https://github.com/rochdev","followers_url":"https://api.github.com/users/rochdev/followers","following_url":"https://api.github.com/users/rochdev/following{/other_user}","gists_url":"https://api.github.com/users/rochdev/gists{/gist_id}","starred_url":"https://api.github.com/users/rochdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rochdev/subscriptions","organizations_url":"https://api.github.com/users/rochdev/orgs","repos_url":"https://api.github.com/users/rochdev/repos","events_url":"https://api.github.com/users/rochdev/events{/privacy}","received_events_url":"https://api.github.com/users/rochdev/received_events","type":"User","site_admin":false},"body":"Should this be a single tag or multiple tags? (similar to another PR that you made with the HTTP headers)","created_at":"2018-08-31T20:28:43Z","updated_at":"2018-08-31T20:37:16Z","html_url":"https://github.com/DataDog/dd-trace-js/pull/245#discussion_r214467657","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/comments/214467657"},"html":{"href":"https://github.com/DataDog/dd-trace-js/pull/245#discussion_r214467657"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245","id":209135595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTM1NTk1","html_url":"https://github.com/DataDog/dd-trace-js/pull/245","diff_url":"https://github.com/DataDog/dd-trace-js/pull/245.diff","patch_url":"https://github.com/DataDog/dd-trace-js/pull/245.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-js/issues/245","number":245,"state":"open","locked":false,"title":"[GraphQL] Instrument document parsing & validation and include variables in metadata","user":{"login":"alloy","id":2320,"node_id":"MDQ6VXNlcjIzMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"body":"So the logic in this PR may seem a little unintuitive at first, but my understanding of the existing code is that we really want the operation span to be the parent of all GraphQL related spans and we want to use the operation name as its name.\r\n\r\nThis means we can’t create the parse and validation spans _until_ the operation span has been created (otherwise we don’t have access to the parsed operation name), which is why my changes only record the timing but defer creation of the spans until the operation span is created.\r\n\r\nI also ended up simplifying the tests a little, because they were a bit cumbersome to work with when adding new spans. Rather than assuming spans exist at a certain index, I added a helper function (`findSpan`) to find the spans based on data that the test previously asserted on. Additionally, most tests don’t really seem to need a total span count assertion, so I only left those in 2 places, which would make updating those a lot easier in the future.","created_at":"2018-08-17T12:39:30Z","updated_at":"2018-08-31T20:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e6c38d6750ce87585c501f302f93c5c5d0400c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":810199037,"node_id":"MDU6TGFiZWw4MTAxOTkwMzc=","url":"https://api.github.com/repos/DataDog/dd-trace-js/labels/community","name":"community","color":"0e8a16","default":false},{"id":807931152,"node_id":"MDU6TGFiZWw4MDc5MzExNTI=","url":"https://api.github.com/repos/DataDog/dd-trace-js/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":810199574,"node_id":"MDU6TGFiZWw4MTAxOTk1NzQ=","url":"https://api.github.com/repos/DataDog/dd-trace-js/labels/integrations","name":"integrations","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-js/issues/245/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-js/statuses/5dfd48e365a12b6190a9b6294859c94f10d8b5de","head":{"label":"artsy:graphql-trace-query-parsing-and-validation","ref":"graphql-trace-query-parsing-and-validation","sha":"5dfd48e365a12b6190a9b6294859c94f10d8b5de","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":144856448,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4NTY0NDg=","name":"dd-trace-js","full_name":"artsy/dd-trace-js","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/dd-trace-js","description":"JavaScript APM Tracer (beta)","fork":true,"url":"https://api.github.com/repos/artsy/dd-trace-js","forks_url":"https://api.github.com/repos/artsy/dd-trace-js/forks","keys_url":"https://api.github.com/repos/artsy/dd-trace-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/dd-trace-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/dd-trace-js/teams","hooks_url":"https://api.github.com/repos/artsy/dd-trace-js/hooks","issue_events_url":"https://api.github.com/repos/artsy/dd-trace-js/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/dd-trace-js/events","assignees_url":"https://api.github.com/repos/artsy/dd-trace-js/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/dd-trace-js/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/dd-trace-js/tags","blobs_url":"https://api.github.com/repos/artsy/dd-trace-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/dd-trace-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/dd-trace-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/dd-trace-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/dd-trace-js/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/dd-trace-js/languages","stargazers_url":"https://api.github.com/repos/artsy/dd-trace-js/stargazers","contributors_url":"https://api.github.com/repos/artsy/dd-trace-js/contributors","subscribers_url":"https://api.github.com/repos/artsy/dd-trace-js/subscribers","subscription_url":"https://api.github.com/repos/artsy/dd-trace-js/subscription","commits_url":"https://api.github.com/repos/artsy/dd-trace-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/dd-trace-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/dd-trace-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/dd-trace-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/dd-trace-js/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/dd-trace-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/dd-trace-js/merges","archive_url":"https://api.github.com/repos/artsy/dd-trace-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/dd-trace-js/downloads","issues_url":"https://api.github.com/repos/artsy/dd-trace-js/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/dd-trace-js/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/dd-trace-js/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/dd-trace-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/dd-trace-js/labels{/name}","releases_url":"https://api.github.com/repos/artsy/dd-trace-js/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/dd-trace-js/deployments","created_at":"2018-08-15T13:26:50Z","updated_at":"2018-08-22T12:30:42Z","pushed_at":"2018-08-31T19:51:39Z","git_url":"git://github.com/artsy/dd-trace-js.git","ssh_url":"git@github.com:artsy/dd-trace-js.git","clone_url":"https://github.com/artsy/dd-trace-js.git","svn_url":"https://github.com/artsy/dd-trace-js","homepage":"https://docs.datadoghq.com/tracing/","size":948,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"f6898b9ba1dbd2ba53258c3416fd86b9d5b56d7b","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":117877090,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NzcwOTA=","name":"dd-trace-js","full_name":"DataDog/dd-trace-js","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-js","description":"JavaScript APM Tracer","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-js","forks_url":"https://api.github.com/repos/DataDog/dd-trace-js/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-js/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-js/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-js/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-js/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-js/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-js/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-js/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-js/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-js/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-js/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-js/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-js/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-js/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-js/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-js/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-js/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-js/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-js/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-js/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-js/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-js/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-js/deployments","created_at":"2018-01-17T18:40:03Z","updated_at":"2018-08-28T20:18:52Z","pushed_at":"2018-08-30T21:21:24Z","git_url":"git://github.com/DataDog/dd-trace-js.git","ssh_url":"git@github.com:DataDog/dd-trace-js.git","clone_url":"https://github.com/DataDog/dd-trace-js.git","svn_url":"https://github.com/DataDog/dd-trace-js","homepage":"https://docs.datadoghq.com/tracing/","size":951,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":31,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245"},"html":{"href":"https://github.com/DataDog/dd-trace-js/pull/245"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/issues/245"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-js/statuses/5dfd48e365a12b6190a9b6294859c94f10d8b5de"}},"author_association":"CONTRIBUTOR"}} | {
"id": 117877090,
"name": "DataDog/dd-trace-js",
"url": "https://api.github.com/repos/DataDog/dd-trace-js"
} | {
"id": 1596303,
"login": "rochdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1596303?",
"url": "https://api.github.com/users/rochdev"
} | {
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
} | 2018-08-31T20:28:43 | 8199540758 | {"actor":{"display_login":"rochdev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments/181518114","pull_request_review_id":112169372,"id":181518114,"diff_hunk":"@@ -0,0 +1,60 @@\n+import warnings\n+\n+from functools import wraps\n+\n+\n+class RemovedInDDTrace10Warning(DeprecationWarning):","path":"ddtrace/utils/deprecation.py","position":6,"original_position":6,"commit_id":"f364291e83952dd2c7e4967528a9318cfc997b33","original_commit_id":"f364291e83952dd2c7e4967528a9318cfc997b33","user":{"login":"palazzem","id":1560405,"avatar_url":"https://avatars2.githubusercontent.com/u/1560405?v=4","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"body":"Used to create messages such as:\r\n```\r\nscript.py:10: RemovedInDDTrace10Warning: [...]\r\n```","created_at":"2018-04-13T21:51:23Z","updated_at":"2018-04-13T21:51:23Z","html_url":"https://github.com/DataDog/dd-trace-py/pull/450#discussion_r181518114","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments/181518114"},"html":{"href":"https://github.com/DataDog/dd-trace-py/pull/450#discussion_r181518114"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450","id":181540494,"html_url":"https://github.com/DataDog/dd-trace-py/pull/450","diff_url":"https://github.com/DataDog/dd-trace-py/pull/450.diff","patch_url":"https://github.com/DataDog/dd-trace-py/pull/450.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/450","number":450,"state":"open","locked":false,"title":"[core] add Deprecation system with documentation","user":{"login":"palazzem","id":1560405,"avatar_url":"https://avatars2.githubusercontent.com/u/1560405?v=4","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"body":"### Overview\r\n\r\nThis patch introduces a deprecation system via `warnings` module. It offers a way to add deprecation around our code, when we need to alter/remove a functionality in newer releases. The deprecation log is silent by default, though it could be activated via Python flag / environment variable. This approach should be considered \"safe\" especially because it's used by many web frameworks (i.e. Django) and well documented in the Python official docs.\r\n\r\n* `ddtrace.util` -> `ddtrace.utils.*` (split in many modules)\r\n* `ddtrace.contrib.util` -> `ddtrace.utils.importlib`\r\n\r\n### User impact\r\n\r\nNo impact for the user since the `DeprecationWarning` is silent by default, so unless the production application is run via `-Wall`, nothing will be printed in users' logs.\r\n\r\n### What is missing\r\n\r\nIt's more part of a process, but we should document somewhere (even with a simple list) every time we add a deprecation warning. In that way, users can find easily what's going to be changed in the next major release. A good example is Django: https://docs.djangoproject.com/en/dev/internals/deprecation/","created_at":"2018-04-13T16:44:12Z","updated_at":"2018-04-13T21:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9169a6debcd203e9815e3a7ec0129818ba9d9164","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SeanOC","id":7662,"avatar_url":"https://avatars3.githubusercontent.com/u/7662?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanOC","html_url":"https://github.com/SeanOC","followers_url":"https://api.github.com/users/SeanOC/followers","following_url":"https://api.github.com/users/SeanOC/following{/other_user}","gists_url":"https://api.github.com/users/SeanOC/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanOC/subscriptions","organizations_url":"https://api.github.com/users/SeanOC/orgs","repos_url":"https://api.github.com/users/SeanOC/repos","events_url":"https://api.github.com/users/SeanOC/events{/privacy}","received_events_url":"https://api.github.com/users/SeanOC/received_events","type":"User","site_admin":false},{"login":"LotharSee","id":2720261,"avatar_url":"https://avatars1.githubusercontent.com/u/2720261?v=4","gravatar_id":"","url":"https://api.github.com/users/LotharSee","html_url":"https://github.com/LotharSee","followers_url":"https://api.github.com/users/LotharSee/followers","following_url":"https://api.github.com/users/LotharSee/following{/other_user}","gists_url":"https://api.github.com/users/LotharSee/gists{/gist_id}","starred_url":"https://api.github.com/users/LotharSee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LotharSee/subscriptions","organizations_url":"https://api.github.com/users/LotharSee/orgs","repos_url":"https://api.github.com/users/LotharSee/repos","events_url":"https://api.github.com/users/LotharSee/events{/privacy}","received_events_url":"https://api.github.com/users/LotharSee/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":443002892,"url":"https://api.github.com/repos/DataDog/dd-trace-py/labels/core","name":"core","color":"d93f0b","default":false},{"id":395724892,"url":"https://api.github.com/repos/DataDog/dd-trace-py/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/17","html_url":"https://github.com/DataDog/dd-trace-py/milestone/17","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/17/labels","id":3132894,"number":17,"title":"0.12.0","description":"","creator":{"login":"palazzem","id":1560405,"avatar_url":"https://avatars2.githubusercontent.com/u/1560405?v=4","gravatar_id":"","url":"https://api.github.com/users/palazzem","html_url":"https://github.com/palazzem","followers_url":"https://api.github.com/users/palazzem/followers","following_url":"https://api.github.com/users/palazzem/following{/other_user}","gists_url":"https://api.github.com/users/palazzem/gists{/gist_id}","starred_url":"https://api.github.com/users/palazzem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palazzem/subscriptions","organizations_url":"https://api.github.com/users/palazzem/orgs","repos_url":"https://api.github.com/users/palazzem/repos","events_url":"https://api.github.com/users/palazzem/events{/privacy}","received_events_url":"https://api.github.com/users/palazzem/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":9,"state":"open","created_at":"2018-02-21T12:52:36Z","updated_at":"2018-04-13T16:44:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/450/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/f364291e83952dd2c7e4967528a9318cfc997b33","head":{"label":"DataDog:palazzem/deprecation","ref":"palazzem/deprecation","sha":"f364291e83952dd2c7e4967528a9318cfc997b33","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":61572326,"name":"dd-trace-py","full_name":"DataDog/dd-trace-py","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-py","description":"Datadog Tracing Python Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-py","forks_url":"https://api.github.com/repos/DataDog/dd-trace-py/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-py/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-py/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-py/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-py/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-py/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-py/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-py/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-py/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-py/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-py/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-py/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-py/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-py/deployments","created_at":"2016-06-20T18:52:23Z","updated_at":"2018-03-30T09:07:15Z","pushed_at":"2018-04-13T21:50:30Z","git_url":"git://github.com/DataDog/dd-trace-py.git","ssh_url":"git@github.com:DataDog/dd-trace-py.git","clone_url":"https://github.com/DataDog/dd-trace-py.git","svn_url":"https://github.com/DataDog/dd-trace-py","homepage":"http://pypi.datadoghq.com/trace/docs/","size":1689,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":59,"open_issues":48,"watchers":54,"default_branch":"master"}},"base":{"label":"DataDog:0.12-dev","ref":"0.12-dev","sha":"e439a5286673c098320b7ba11565ecbe2f7a9118","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":61572326,"name":"dd-trace-py","full_name":"DataDog/dd-trace-py","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-py","description":"Datadog Tracing Python Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-py","forks_url":"https://api.github.com/repos/DataDog/dd-trace-py/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-py/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-py/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-py/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-py/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-py/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-py/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-py/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-py/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-py/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-py/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-py/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-py/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-py/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-py/deployments","created_at":"2016-06-20T18:52:23Z","updated_at":"2018-03-30T09:07:15Z","pushed_at":"2018-04-13T21:50:30Z","git_url":"git://github.com/DataDog/dd-trace-py.git","ssh_url":"git@github.com:DataDog/dd-trace-py.git","clone_url":"https://github.com/DataDog/dd-trace-py.git","svn_url":"https://github.com/DataDog/dd-trace-py","homepage":"http://pypi.datadoghq.com/trace/docs/","size":1689,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":59,"open_issues":48,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450"},"html":{"href":"https://github.com/DataDog/dd-trace-py/pull/450"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/issues/450"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-py/statuses/f364291e83952dd2c7e4967528a9318cfc997b33"}},"author_association":"MEMBER"}} | {
"id": 61572326,
"name": "DataDog/dd-trace-py",
"url": "https://api.github.com/repos/DataDog/dd-trace-py"
} | {
"id": 1560405,
"login": "palazzem",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1560405?",
"url": "https://api.github.com/users/palazzem"
} | {
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
} | 2018-04-13T21:51:23 | 7528688177 | {"actor":{"display_login":"palazzem"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/comments/189436228","pull_request_review_id":121620896,"id":189436228,"diff_hunk":"@@ -86,38 +89,68 @@ def self.VERSION\n VERSION\n end\n \n+ ##\n+ # Get the current instance of a StatsD client\n+ #\n+ # @param *args [Array<Object>]\n+ # Any number of arguments passed to the constructor when building a new instance\n+ #\n+ # @return [Datadog::Statsd]\n+ # An instance of the StatsD client or a new one using the provided arguments\n+ def self.current(*args)","path":"lib/datadog/statsd.rb","position":26,"original_position":26,"commit_id":"0b09ae15582ede19b5e2819511549bd30cf58208","original_commit_id":"0b09ae15582ede19b5e2819511549bd30cf58208","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"would return the same instance when called with different args","created_at":"2018-05-19T14:48:03Z","updated_at":"2018-05-19T14:48:04Z","html_url":"https://github.com/DataDog/dogstatsd-ruby/pull/85#discussion_r189436228","pull_request_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/comments/189436228"},"html":{"href":"https://github.com/DataDog/dogstatsd-ruby/pull/85#discussion_r189436228"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85","id":188198142,"html_url":"https://github.com/DataDog/dogstatsd-ruby/pull/85","diff_url":"https://github.com/DataDog/dogstatsd-ruby/pull/85.diff","patch_url":"https://github.com/DataDog/dogstatsd-ruby/pull/85.patch","issue_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/85","number":85,"state":"open","locked":false,"title":"Make it thread-safe and add a current class method","user":{"login":"johvet","id":1147149,"avatar_url":"https://avatars3.githubusercontent.com/u/1147149?v=4","gravatar_id":"","url":"https://api.github.com/users/johvet","html_url":"https://github.com/johvet","followers_url":"https://api.github.com/users/johvet/followers","following_url":"https://api.github.com/users/johvet/following{/other_user}","gists_url":"https://api.github.com/users/johvet/gists{/gist_id}","starred_url":"https://api.github.com/users/johvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johvet/subscriptions","organizations_url":"https://api.github.com/users/johvet/orgs","repos_url":"https://api.github.com/users/johvet/repos","events_url":"https://api.github.com/users/johvet/events{/privacy}","received_events_url":"https://api.github.com/users/johvet/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-15T17:16:28Z","updated_at":"2018-05-19T14:48:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32328340c8bec59ff85d07f856caf6b0febb2a6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85/commits","review_comments_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85/comments","review_comment_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/85/comments","statuses_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/statuses/0b09ae15582ede19b5e2819511549bd30cf58208","head":{"label":"art19:johvet/AROR-1516","ref":"johvet/AROR-1516","sha":"0b09ae15582ede19b5e2819511549bd30cf58208","user":{"login":"art19","id":2906914,"avatar_url":"https://avatars1.githubusercontent.com/u/2906914?v=4","gravatar_id":"","url":"https://api.github.com/users/art19","html_url":"https://github.com/art19","followers_url":"https://api.github.com/users/art19/followers","following_url":"https://api.github.com/users/art19/following{/other_user}","gists_url":"https://api.github.com/users/art19/gists{/gist_id}","starred_url":"https://api.github.com/users/art19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art19/subscriptions","organizations_url":"https://api.github.com/users/art19/orgs","repos_url":"https://api.github.com/users/art19/repos","events_url":"https://api.github.com/users/art19/events{/privacy}","received_events_url":"https://api.github.com/users/art19/received_events","type":"Organization","site_admin":false},"repo":{"id":132057496,"name":"dogstatsd-ruby","full_name":"art19/dogstatsd-ruby","owner":{"login":"art19","id":2906914,"avatar_url":"https://avatars1.githubusercontent.com/u/2906914?v=4","gravatar_id":"","url":"https://api.github.com/users/art19","html_url":"https://github.com/art19","followers_url":"https://api.github.com/users/art19/followers","following_url":"https://api.github.com/users/art19/following{/other_user}","gists_url":"https://api.github.com/users/art19/gists{/gist_id}","starred_url":"https://api.github.com/users/art19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art19/subscriptions","organizations_url":"https://api.github.com/users/art19/orgs","repos_url":"https://api.github.com/users/art19/repos","events_url":"https://api.github.com/users/art19/events{/privacy}","received_events_url":"https://api.github.com/users/art19/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/art19/dogstatsd-ruby","description":"A Ruby client for DogStatsd","fork":true,"url":"https://api.github.com/repos/art19/dogstatsd-ruby","forks_url":"https://api.github.com/repos/art19/dogstatsd-ruby/forks","keys_url":"https://api.github.com/repos/art19/dogstatsd-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/art19/dogstatsd-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/art19/dogstatsd-ruby/teams","hooks_url":"https://api.github.com/repos/art19/dogstatsd-ruby/hooks","issue_events_url":"https://api.github.com/repos/art19/dogstatsd-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/art19/dogstatsd-ruby/events","assignees_url":"https://api.github.com/repos/art19/dogstatsd-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/art19/dogstatsd-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/art19/dogstatsd-ruby/tags","blobs_url":"https://api.github.com/repos/art19/dogstatsd-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/art19/dogstatsd-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/art19/dogstatsd-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/art19/dogstatsd-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/art19/dogstatsd-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/art19/dogstatsd-ruby/languages","stargazers_url":"https://api.github.com/repos/art19/dogstatsd-ruby/stargazers","contributors_url":"https://api.github.com/repos/art19/dogstatsd-ruby/contributors","subscribers_url":"https://api.github.com/repos/art19/dogstatsd-ruby/subscribers","subscription_url":"https://api.github.com/repos/art19/dogstatsd-ruby/subscription","commits_url":"https://api.github.com/repos/art19/dogstatsd-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/art19/dogstatsd-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/art19/dogstatsd-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/art19/dogstatsd-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/art19/dogstatsd-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/art19/dogstatsd-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/art19/dogstatsd-ruby/merges","archive_url":"https://api.github.com/repos/art19/dogstatsd-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/art19/dogstatsd-ruby/downloads","issues_url":"https://api.github.com/repos/art19/dogstatsd-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/art19/dogstatsd-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/art19/dogstatsd-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/art19/dogstatsd-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/art19/dogstatsd-ruby/labels{/name}","releases_url":"https://api.github.com/repos/art19/dogstatsd-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/art19/dogstatsd-ruby/deployments","created_at":"2018-05-03T22:51:17Z","updated_at":"2018-05-03T22:51:19Z","pushed_at":"2018-05-16T00:02:52Z","git_url":"git://github.com/art19/dogstatsd-ruby.git","ssh_url":"git@github.com:art19/dogstatsd-ruby.git","clone_url":"https://github.com/art19/dogstatsd-ruby.git","svn_url":"https://github.com/art19/dogstatsd-ruby","homepage":"https://www.datadoghq.com/","size":276,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"3edece57c90dcfaf1c0f67b2493f0830c977adac","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":4659423,"name":"dogstatsd-ruby","full_name":"DataDog/dogstatsd-ruby","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dogstatsd-ruby","description":"A Ruby client for DogStatsd","fork":true,"url":"https://api.github.com/repos/DataDog/dogstatsd-ruby","forks_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/forks","keys_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/teams","hooks_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/events","assignees_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/tags","blobs_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/languages","stargazers_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/subscription","commits_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/merges","archive_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/downloads","issues_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dogstatsd-ruby/deployments","created_at":"2012-06-14T04:43:39Z","updated_at":"2018-05-19T08:01:42Z","pushed_at":"2018-05-19T13:35:23Z","git_url":"git://github.com/DataDog/dogstatsd-ruby.git","ssh_url":"git@github.com:DataDog/dogstatsd-ruby.git","clone_url":"https://github.com/DataDog/dogstatsd-ruby.git","svn_url":"https://github.com/DataDog/dogstatsd-ruby","homepage":"https://www.datadoghq.com/","size":274,"stargazers_count":75,"watchers_count":75,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":65,"open_issues":17,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85"},"html":{"href":"https://github.com/DataDog/dogstatsd-ruby/pull/85"},"issue":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/85"},"comments":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dogstatsd-ruby/statuses/0b09ae15582ede19b5e2819511549bd30cf58208"}},"author_association":"NONE"}} | {
"id": 4659423,
"name": "DataDog/dogstatsd-ruby",
"url": "https://api.github.com/repos/DataDog/dogstatsd-ruby"
} | {
"id": 11367,
"login": "grosser",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11367?",
"url": "https://api.github.com/users/grosser"
} | {
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
} | 2018-05-19T14:48:03 | 7699621095 | {"actor":{"display_login":"grosser"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/174760119","pull_request_review_id":104173737,"id":174760119,"diff_hunk":"@@ -378,3 +390,554 @@ def transform(self, X):\n X[coordinates] = values\n \n return X\n+\n+\n+class MICEImputer(BaseEstimator, TransformerMixin):\n+ \"\"\"MICE transformer to impute missing values.\n+\n+ Basic implementation of MICE (Multivariate Imputations by Chained\n+ Equations) package from R. This version assumes all of the features are\n+ Gaussian.\n+\n+ Parameters\n+ ----------\n+ missing_values : int or \"NaN\", optional (default=\"NaN\")\n+ The placeholder for the missing values. All occurrences of\n+ ``missing_values`` will be imputed. For missing values encoded as\n+ np.nan, use the string value \"NaN\".\n+\n+ imputation_order : str, optional (default=\"monotone\")\n+ The order in which the features will be imputed. Possible values:\n+\n+ \"monotone\"\n+ From features with fewest missing values to most.\n+ \"revmonotone\"\n+ From features with most missing values to fewest.\n+ \"roman\"\n+ Left to right.\n+ \"arabic\"\n+ Right to left.\n+ \"random\"\n+ A random order for each round.\n+\n+ n_imputations : int, optional (default=100)\n+ Number of MICE rounds to perform, the results of which will be\n+ used in the final average.\n+\n+ n_burn_in : int, optional (default=10)\n+ Number of initial MICE rounds to perform the results of which\n+ will not be returned.\n+\n+ predictor : estimator object, default=BayesianRidge()\n+ The predictor to use at each step of the round-robin imputation.\n+ It must support ``return_std`` in its ``predict`` method.\n+\n+ n_nearest_features : int, optional (default=None)\n+ Number of other features to use to estimate the missing values of\n+ the each feature column. Nearness between features is measured using\n+ the absolute correlation coefficient between each feature pair (after\n+ initial imputation). Can provide significant speed-up when the number\n+ of features is huge. If ``None``, all features will be used.\n+\n+ initial_strategy : str, optional (default=\"mean\")\n+ Which strategy to use to initialize the missing values. Same as the\n+ ``strategy`` parameter in :class:`sklearn.preprocessing.Imputer`\n+ Valid values: {\"mean\", \"median\", or \"most_frequent\"}.\n+\n+ min_value : float, optional (default=None)\n+ Minimum possible imputed value. Default of ``None`` will set minimum\n+ to negative infinity.\n+\n+ max_value : float, optional (default=None)\n+ Maximum possible imputed value. Default of ``None`` will set maximum\n+ to positive infinity.\n+\n+ verbose : int, optional (default=0)\n+ Verbosity flag, controls the debug messages that are issued\n+ as functions are evaluated. The higher, the more verbose. Can be 0, 1,\n+ or 2.\n+\n+ random_state : int, RandomState instance or None, optional (default=None)\n+ The seed of the pseudo random number generator to use when shuffling\n+ the data. If int, random_state is the seed used by the random number\n+ generator; If RandomState instance, random_state is the random number\n+ generator; If None, the random number generator is the RandomState\n+ instance used by ``np.random``.\n+\n+ Attributes\n+ ----------\n+ initial_imputer_ : object of class :class:`sklearn.preprocessing.Imputer`'\n+ The imputer used to initialize the missing values.\n+\n+ imputation_sequence_ : list of tuples\n+ Each tuple has ``(feat_idx, neighbor_feat_idx, predictor)``, where\n+ ``feat_idx`` is the current feature to be imputed,\n+ ``neighbor_feat_idx`` is the array of other features used to impute the\n+ current feature, and ``predictor`` is the trained predictor used for\n+ the imputation.\n+\n+ Notes\n+ -----\n+ The R version of MICE does not have inductive functionality, i.e. first\n+ fitting on ``X_train`` and then transforming any ``X_test`` without\n+ additional fitting. We do this by storing each feature's predictor during\n+ the round-robin ``fit`` phase, and predicting without refitting (in order)\n+ during the ``transform`` phase.\n+\n+ Features which contain all missing values at ``fit`` are discarded upon\n+ ``transform``.\n+\n+ Features with missing values in transform which did not have any missing\n+ values in fit will be imputed with the initial imputation method only.\n+\n+ References\n+ ----------\n+ .. [1] `Stef van Buuren, Karin Groothuis-Oudshoorn (2011). \"mice:\n+ Multivariate Imputation by Chained Equations in R\". Journal of\n+ Statistical Software 45: 1-67.\n+ <https://www.jstatsoft.org/article/view/v045i03>`_\n+ \"\"\"\n+\n+ def __init__(self,\n+ missing_values='NaN',\n+ imputation_order='monotone',\n+ n_imputations=100,\n+ n_burn_in=10,\n+ predictor=None,\n+ n_nearest_features=None,\n+ initial_strategy=\"mean\",\n+ min_value=None,\n+ max_value=None,\n+ verbose=False,\n+ random_state=None):\n+\n+ self.missing_values = missing_values\n+ self.imputation_order = imputation_order\n+ self.n_imputations = n_imputations\n+ self.n_burn_in = n_burn_in\n+ self.predictor = predictor\n+ self.n_nearest_features = n_nearest_features\n+ self.initial_strategy = initial_strategy\n+ self.min_value = min_value\n+ self.max_value = max_value\n+ self.verbose = verbose\n+ self.random_state = random_state\n+\n+ def _impute_one_feature(self,\n+ X_filled,\n+ mask_missing_values,\n+ feat_idx,\n+ neighbor_feat_idx,\n+ predictor=None,\n+ fit_mode=True):\n+ \"\"\"Impute a single feature from the others provided.\n+\n+ This function predicts the missing values of one of the features using\n+ the current estimates of all the other features. The ``predictor`` must\n+ support ``return_std=True`` in its ``predict`` method for this function\n+ to work.\n+\n+ Parameters\n+ ----------\n+ X_filled : ndarray\n+ Input data with the most recent imputations.\n+\n+ mask_missing_values : ndarray\n+ Input data's missing indicator matrix.\n+\n+ feat_idx : int\n+ Index of the feature currently being imputed.\n+\n+ neighbor_feat_idx : ndarray\n+ Indices of the features to be used in imputing ``feat_idx``.\n+\n+ predictor : object\n+ The predictor to use at this step of the round-robin imputation.\n+ It must support ``return_std`` in its ``predict`` method.\n+ If None, it will be cloned from self._predictor.\n+\n+ fit_mode : boolean, default=True\n+ Whether to fit and predict with the predictor or just predict.\n+\n+ Returns\n+ -------\n+ X_filled : ndarray\n+ Input data with ``X_filled[missing_row_mask, feat_idx]`` updated.\n+\n+ predictor : predictor with sklearn API\n+ The fitted predictor used to impute\n+ ``X_filled[missing_row_mask, feat_idx]``.\n+ \"\"\"\n+\n+ # if nothing is missing, just return the default\n+ # (should not happen at fit time because feat_ids would be excluded)\n+ missing_row_mask = mask_missing_values[:, feat_idx]\n+ if not np.any(missing_row_mask):\n+ return X_filled, predictor\n+\n+ if predictor is None and fit_mode is False:\n+ raise ValueError(\"If fit_mode is False, then an already-fitted \"\n+ \"predictor should be passed in.\")\n+\n+ # if no predictor provided, instantiate a new one\n+ if predictor is None:\n+ predictor = clone(self._predictor)\n+\n+ if fit_mode:\n+ X_train = safe_indexing(X_filled[:, neighbor_feat_idx],\n+ ~missing_row_mask)\n+ y_train = safe_indexing(X_filled[:, feat_idx],\n+ ~missing_row_mask)\n+ predictor.fit(X_train, y_train)\n+\n+ # get posterior samples\n+ X_test = safe_indexing(X_filled[:, neighbor_feat_idx],\n+ missing_row_mask)\n+ mus, sigmas = predictor.predict(X_test, return_std=True)\n+ good_sigmas = sigmas > 0\n+ imputed_values = np.zeros(mus.shape, dtype=X_filled.dtype)\n+ imputed_values[~good_sigmas] = mus[~good_sigmas]\n+ imputed_values[good_sigmas] = self.random_state_.normal(\n+ loc=mus[good_sigmas], scale=sigmas[good_sigmas])\n+\n+ # clip the values\n+ imputed_values = np.clip(imputed_values,\n+ self._min_value,\n+ self._max_value)\n+\n+ # update the feature\n+ X_filled[missing_row_mask, feat_idx] = imputed_values\n+ return X_filled, predictor\n+\n+ def _get_neighbor_feat_idx(self,\n+ n_features,\n+ feat_idx,\n+ abs_corr_mat):\n+ \"\"\"Get a list of other features to predict ``feat_idx``.\n+\n+ If self.n_nearest_features is less than or equal to the total\n+ number of features, then use a probability proportional to the absolute\n+ correlation between ``feat_idx`` and each other feature to randomly\n+ choose a subsample of the other features (without replacement).\n+\n+ Parameters\n+ ----------\n+ n_features : int\n+ Number of features in ``X``.\n+\n+ feat_idx : int\n+ Index of the feature currently being imputed.\n+\n+ abs_corr_mat : ndarray, shape (n_features, n_features)\n+ Absolute correlation matrix of ``X``. The diagonal has been zeroed\n+ out and each feature has been normalized to sum to 1. Can be None.\n+\n+ Returns\n+ -------\n+ neighbor_feat_idx : array-like\n+ The features to use to impute ``feat_idx``.\n+ \"\"\"\n+ if (self.n_nearest_features is not None and\n+ self.n_nearest_features < n_features):\n+ p = abs_corr_mat[:, feat_idx]\n+ neighbor_feat_idx = self.random_state_.choice(\n+ np.arange(n_features), self.n_nearest_features, replace=False,\n+ p=p)\n+ else:\n+ inds_left = np.arange(feat_idx)\n+ inds_right = np.arange(feat_idx + 1, n_features)\n+ neighbor_feat_idx = np.concatenate((inds_left, inds_right))\n+ return neighbor_feat_idx\n+\n+ def _get_ordered_idx(self, mask_missing_values):\n+ \"\"\"Decide in what order we will update the features.\n+\n+ As a homage to the MICE R package, we will have 4 main options of\n+ how to order the updates, and use a random order if anything else\n+ is specified.\n+\n+ Also, this function skips features which have no missing values.\n+\n+ Parameters\n+ ----------\n+ mask_missing_values : array-like, shape (n_samples, n_features)\n+ Input data's missing indicator matrix, where \"n_samples\" is the\n+ number of samples and \"n_features\" is the number of features.\n+\n+ Returns\n+ -------\n+ ordered_idx : ndarray, shape (n_features,)\n+ The order in which to impute the features.\n+ \"\"\"\n+ frac_of_missing_values = mask_missing_values.mean(axis=0)\n+ missing_values_idx = np.nonzero(frac_of_missing_values)[0]\n+ if self.imputation_order == 'roman':\n+ ordered_idx = missing_values_idx\n+ elif self.imputation_order == 'arabic':\n+ ordered_idx = missing_values_idx[::-1]\n+ elif self.imputation_order == 'monotone':\n+ n = len(frac_of_missing_values) - len(missing_values_idx)\n+ ordered_idx = np.argsort(frac_of_missing_values,\n+ kind='mergesort')[n:][::-1]\n+ elif self.imputation_order == 'revmonotone':\n+ n = len(frac_of_missing_values) - len(missing_values_idx)\n+ ordered_idx = np.argsort(frac_of_missing_values,\n+ kind='mergesort')[n:]\n+ elif self.imputation_order == 'random':\n+ ordered_idx = missing_values_idx\n+ self.random_state_.shuffle(ordered_idx)\n+ else:\n+ raise ValueError(\"Got an invalid imputation order: '{0}'. It must \"\n+ \"be one of the following: 'roman', 'arabic', \"\n+ \"'monotone', 'revmonotone', or \"\n+ \"'random'.\".format(self.imputation_order))\n+ return ordered_idx\n+\n+ def _get_abs_corr_mat(self, X_filled, tolerance=1e-6):\n+ \"\"\"Get absolute correlation matrix between features.\n+\n+ Parameters\n+ ----------\n+ X_filled : ndarray, shape (n_samples, n_features)\n+ Input data with the most recent imputations.\n+\n+ tolerance : float, optional (default=1e-6)\n+ ``abs_corr_mat`` can have nans, which will be replaced\n+ with ``tolerance``.\n+\n+ Returns\n+ -------\n+ abs_corr_mat : ndarray, shape (n_features, n_features)\n+ Absolute correlation matrix of ``X`` at the beginning of the\n+ current round. The diagonal has been zeroed out and each feature's\n+ absolute correlations with all others have been normalized to sum\n+ to 1.\n+ \"\"\"\n+ n_features = X_filled.shape[1]\n+ if (self.n_nearest_features is None or\n+ self.n_nearest_features >= n_features):\n+ return None\n+ abs_corr_mat = np.abs(np.corrcoef(X_filled.T))\n+ # np.corrcoef is not defined for features with zero std\n+ abs_corr_mat[np.isnan(abs_corr_mat)] = tolerance\n+ # ensures exploration, i.e. at least some probability of sampling\n+ abs_corr_mat[abs_corr_mat < tolerance] = tolerance\n+ # features are not their own neighbors\n+ np.fill_diagonal(abs_corr_mat, 0)\n+ # needs to sum to 1 for np.random.choice sampling\n+ abs_corr_mat = normalize(abs_corr_mat, norm='l1', axis=0, copy=False)\n+ return abs_corr_mat\n+\n+ def _initial_imputation(self, X):\n+ \"\"\"Perform initial imputation for input X.\n+\n+ Parameters\n+ ----------\n+ X : ndarray, shape (n_samples, n_features)\n+ Input data, where \"n_samples\" is the number of samples and\n+ \"n_features\" is the number of features.\n+\n+ Returns\n+ -------\n+ Xt : ndarray, shape (n_samples, n_features)\n+ Input data, where \"n_samples\" is the number of samples and\n+ \"n_features\" is the number of features.\n+\n+ X_filled : ndarray, shape (n_samples, n_features)\n+ Input data with the most recent imputations.\n+\n+ mask_missing_values : ndarray, shape (n_samples, n_features)\n+ Input data's missing indicator matrix, where \"n_samples\" is the\n+ number of samples and \"n_features\" is the number of features.\n+ \"\"\"\n+ X = check_array(X, dtype=FLOAT_DTYPES, order=\"F\",\n+ force_all_finite='allow-nan'\n+ if self.missing_values == 'NaN'\n+ or np.isnan(self.missing_values) else True)\n+\n+ mask_missing_values = _get_mask(X, self.missing_values)\n+ if self.initial_imputer_ is None:\n+ self.initial_imputer_ = SimpleImputer(\n+ missing_values=self.missing_values,\n+ strategy=self.initial_strategy,\n+ axis=0)\n+ X_filled = self.initial_imputer_.fit_transform(X)\n+ else:\n+ X_filled = self.initial_imputer_.transform(X)\n+\n+ # removing empty features","path":"sklearn/impute.py","position":418,"original_position":418,"commit_id":"d0b0d4af9750482ee45ef05bb4dc1bb977802548","original_commit_id":"d0b0d4af9750482ee45ef05bb4dc1bb977802548","user":{"login":"glemaitre","id":7454015,"avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"body":"remove comment","created_at":"2018-03-15T12:06:47Z","updated_at":"2018-03-15T12:13:28Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8478#discussion_r174760119","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/174760119"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8478#discussion_r174760119"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478","id":108430401,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/8478","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/8478.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/8478.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8478","number":8478,"state":"open","locked":false,"title":"[MRG+1] Basic version of MICE Imputation","user":{"login":"sergeyf","id":1874668,"avatar_url":"https://avatars2.githubusercontent.com/u/1874668?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyf","html_url":"https://github.com/sergeyf","followers_url":"https://api.github.com/users/sergeyf/followers","following_url":"https://api.github.com/users/sergeyf/following{/other_user}","gists_url":"https://api.github.com/users/sergeyf/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyf/subscriptions","organizations_url":"https://api.github.com/users/sergeyf/orgs","repos_url":"https://api.github.com/users/sergeyf/repos","events_url":"https://api.github.com/users/sergeyf/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyf/received_events","type":"User","site_admin":false},"body":"Reference Issue\r\n\r\nThis is in reference to #7840, and builds on #7838.\r\n\r\nThis code provides basic MICE imputation functionality. It currently only uses Bayesian linear regression as the prediction model. Once this is merged, I will add predictive mean matching (slower but sometimes better). See here for a reference: https://stat.ethz.ch/education/semesters/ss2012/ams/paper/mice.pdf\r\n","created_at":"2017-02-28T22:55:57Z","updated_at":"2018-03-15T12:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4afe2fa0c77a6dc3a595e34ce494c6502ff4fb31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"raghavrv","id":9487348,"avatar_url":"https://avatars3.githubusercontent.com/u/9487348?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavrv","html_url":"https://github.com/raghavrv","followers_url":"https://api.github.com/users/raghavrv/followers","following_url":"https://api.github.com/users/raghavrv/following{/other_user}","gists_url":"https://api.github.com/users/raghavrv/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavrv/subscriptions","organizations_url":"https://api.github.com/users/raghavrv/orgs","repos_url":"https://api.github.com/users/raghavrv/repos","events_url":"https://api.github.com/users/raghavrv/events{/privacy}","received_events_url":"https://api.github.com/users/raghavrv/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8478/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/d0b0d4af9750482ee45ef05bb4dc1bb977802548","head":{"label":"sergeyf:mice","ref":"mice","sha":"d0b0d4af9750482ee45ef05bb4dc1bb977802548","user":{"login":"sergeyf","id":1874668,"avatar_url":"https://avatars2.githubusercontent.com/u/1874668?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyf","html_url":"https://github.com/sergeyf","followers_url":"https://api.github.com/users/sergeyf/followers","following_url":"https://api.github.com/users/sergeyf/following{/other_user}","gists_url":"https://api.github.com/users/sergeyf/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyf/subscriptions","organizations_url":"https://api.github.com/users/sergeyf/orgs","repos_url":"https://api.github.com/users/sergeyf/repos","events_url":"https://api.github.com/users/sergeyf/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyf/received_events","type":"User","site_admin":false},"repo":{"id":71942271,"name":"scikit-learn","full_name":"sergeyf/scikit-learn","owner":{"login":"sergeyf","id":1874668,"avatar_url":"https://avatars2.githubusercontent.com/u/1874668?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyf","html_url":"https://github.com/sergeyf","followers_url":"https://api.github.com/users/sergeyf/followers","following_url":"https://api.github.com/users/sergeyf/following{/other_user}","gists_url":"https://api.github.com/users/sergeyf/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyf/subscriptions","organizations_url":"https://api.github.com/users/sergeyf/orgs","repos_url":"https://api.github.com/users/sergeyf/repos","events_url":"https://api.github.com/users/sergeyf/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergeyf/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/sergeyf/scikit-learn","forks_url":"https://api.github.com/repos/sergeyf/scikit-learn/forks","keys_url":"https://api.github.com/repos/sergeyf/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergeyf/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergeyf/scikit-learn/teams","hooks_url":"https://api.github.com/repos/sergeyf/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/sergeyf/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/sergeyf/scikit-learn/events","assignees_url":"https://api.github.com/repos/sergeyf/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/sergeyf/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/sergeyf/scikit-learn/tags","blobs_url":"https://api.github.com/repos/sergeyf/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergeyf/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergeyf/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergeyf/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergeyf/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/sergeyf/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/sergeyf/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/sergeyf/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/sergeyf/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/sergeyf/scikit-learn/subscription","commits_url":"https://api.github.com/repos/sergeyf/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergeyf/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergeyf/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergeyf/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergeyf/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/sergeyf/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergeyf/scikit-learn/merges","archive_url":"https://api.github.com/repos/sergeyf/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergeyf/scikit-learn/downloads","issues_url":"https://api.github.com/repos/sergeyf/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/sergeyf/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/sergeyf/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/sergeyf/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergeyf/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/sergeyf/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/sergeyf/scikit-learn/deployments","created_at":"2016-10-25T21:54:22Z","updated_at":"2016-10-25T21:54:31Z","pushed_at":"2018-03-02T23:18:54Z","git_url":"git://github.com/sergeyf/scikit-learn.git","ssh_url":"git@github.com:sergeyf/scikit-learn.git","clone_url":"https://github.com/sergeyf/scikit-learn.git","svn_url":"https://github.com/sergeyf/scikit-learn","homepage":"http://scikit-learn.org","size":87544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"d9c212297ec594a81ae768bec206565055878d99","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-03-15T12:04:36Z","pushed_at":"2018-03-15T10:20:52Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":89583,"stargazers_count":26558,"watchers_count":26558,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13379,"mirror_url":null,"archived":false,"open_issues_count":1579,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13379,"open_issues":1579,"watchers":26558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8478"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8478"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8478/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8478/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/d0b0d4af9750482ee45ef05bb4dc1bb977802548"}},"author_association":"CONTRIBUTOR"}} | {
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
} | {
"id": 7454015,
"login": "glemaitre",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7454015?",
"url": "https://api.github.com/users/glemaitre"
} | {
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
} | 2018-03-15T12:06:47 | 7384250541 | {"actor":{"display_login":"glemaitre"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/223034207","pull_request_review_id":162070555,"id":223034207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzAzNDIwNw==","diff_hunk":"@@ -56,6 +56,15 @@ Support for Python 3.4 and below has been officially dropped.\n order for further speed performances. :issue:`12251` by `Tom Dupre la Tour`_.\n \n \n+:mod:`sklearn.tree`\n+...................\n+- |Feature| ``get_n_leaves()`` and ``get_max_depth()`` have been added to\n+ :class:`tree.BaseDecisionTree` and consequently all estimators based\n+ on it, including :class:`tree.DecisionTreeClassifier`,\n+ :class:`tree.DecisionTreeRegressor`, :class:`tree.ExtraTreeClassifier`,\n+ and :class:`tree.ExtraTreeRegressor`.\n+ :issue:`7613` by :user:`Adrin Jalali <adrinjalali>`.","path":"doc/whats_new/v0.21.rst","position":11,"original_position":11,"commit_id":"cf3a9286a3613392a82b3cc0c7c48b691abb881f","original_commit_id":"cf3a9286a3613392a82b3cc0c7c48b691abb881f","user":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"body":"nah, not really. There seems to be different preferences on this one, and I personally prefer to link to the issues and not the PRs, and if you check v0.20 [whats_new](http://scikit-learn.org/stable/whats_new.html#version-0-20) page, there are 352 cases of links with \"/issue/\" in them, and only 1 \"/pull/\".","created_at":"2018-10-05T14:50:40Z","updated_at":"2018-10-05T14:50:40Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12300#discussion_r223034207","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/223034207"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12300#discussion_r223034207"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300"}},"in_reply_to_id":223032061},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300","id":220692665,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjkyNjY1","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12300","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12300.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12300.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12300","number":12300,"state":"open","locked":false,"title":"Add get_n_leaves() and get_max_depth() to DesicionTrees","user":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"body":"See #7613 (it technically fixes the original issue, but more discussion's going on there)\r\n\r\nTo count the leaves, I'm checking left AND right children of of each node, which should be the case in a general tree. But in most of the tests, only left or right children are checked and not both. I suppose it doesn't happen that only one of the children are set and not the other, but still, it can a potential source of a bug, I think.\r\n\r\nI couldn't really come up with a nice test for the two functions, so I've just replaced the equivalent ones in one of the existing tests. We could replace more of those in tests though.","created_at":"2018-10-05T12:57:17Z","updated_at":"2018-10-05T14:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b2495c3e41d103554cf419aa73cbb637d4256d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12300/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/cf3a9286a3613392a82b3cc0c7c48b691abb881f","head":{"label":"adrinjalali:feature/treefuncs","ref":"feature/treefuncs","sha":"cf3a9286a3613392a82b3cc0c7c48b691abb881f","user":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"repo":{"id":43740145,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc0MDE0NQ==","name":"scikit-learn","full_name":"adrinjalali/scikit-learn","private":false,"owner":{"login":"adrinjalali","id":1663864,"node_id":"MDQ6VXNlcjE2NjM4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1663864?v=4","gravatar_id":"","url":"https://api.github.com/users/adrinjalali","html_url":"https://github.com/adrinjalali","followers_url":"https://api.github.com/users/adrinjalali/followers","following_url":"https://api.github.com/users/adrinjalali/following{/other_user}","gists_url":"https://api.github.com/users/adrinjalali/gists{/gist_id}","starred_url":"https://api.github.com/users/adrinjalali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrinjalali/subscriptions","organizations_url":"https://api.github.com/users/adrinjalali/orgs","repos_url":"https://api.github.com/users/adrinjalali/repos","events_url":"https://api.github.com/users/adrinjalali/events{/privacy}","received_events_url":"https://api.github.com/users/adrinjalali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrinjalali/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/adrinjalali/scikit-learn","forks_url":"https://api.github.com/repos/adrinjalali/scikit-learn/forks","keys_url":"https://api.github.com/repos/adrinjalali/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrinjalali/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrinjalali/scikit-learn/teams","hooks_url":"https://api.github.com/repos/adrinjalali/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/adrinjalali/scikit-learn/events","assignees_url":"https://api.github.com/repos/adrinjalali/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/adrinjalali/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/adrinjalali/scikit-learn/tags","blobs_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrinjalali/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/adrinjalali/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/adrinjalali/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/adrinjalali/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/adrinjalali/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/adrinjalali/scikit-learn/subscription","commits_url":"https://api.github.com/repos/adrinjalali/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrinjalali/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrinjalali/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrinjalali/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/adrinjalali/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrinjalali/scikit-learn/merges","archive_url":"https://api.github.com/repos/adrinjalali/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrinjalali/scikit-learn/downloads","issues_url":"https://api.github.com/repos/adrinjalali/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/adrinjalali/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/adrinjalali/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/adrinjalali/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrinjalali/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/adrinjalali/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/adrinjalali/scikit-learn/deployments","created_at":"2015-10-06T09:03:13Z","updated_at":"2018-10-05T06:27:06Z","pushed_at":"2018-10-05T12:53:59Z","git_url":"git://github.com/adrinjalali/scikit-learn.git","ssh_url":"git@github.com:adrinjalali/scikit-learn.git","clone_url":"https://github.com/adrinjalali/scikit-learn.git","svn_url":"https://github.com/adrinjalali/scikit-learn","homepage":"http://scikit-learn.org","size":93051,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"9e1d48f819b0b7960b8e60edd7b949309f51899e","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-10-05T13:55:26Z","pushed_at":"2018-10-05T14:34:04Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":95302,"stargazers_count":30891,"watchers_count":30891,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15280,"mirror_url":null,"archived":false,"open_issues_count":1754,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15280,"open_issues":1754,"watchers":30891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12300"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12300"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12300/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12300/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/cf3a9286a3613392a82b3cc0c7c48b691abb881f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
} | {
"id": 1663864,
"login": "adrinjalali",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1663864?",
"url": "https://api.github.com/users/adrinjalali"
} | {
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
} | 2018-10-05T14:50:40 | 8374872728 | {"actor":{"display_login":"adrinjalali"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/180917362","pull_request_review_id":111425730,"id":180917362,"diff_hunk":"@@ -0,0 +1,85 @@\n+import pytest\n+\n+from tests.support.asserts import assert_error, assert_success\n+from tests.support.inline import inline\n+\n+def click(session, element):\n+ return session.transport.send(\"POST\", \"session/{session_id}/element/{element_id}/click\"\n+ .format(session_id=session.session_id,\n+ element_id=element.id))\n+\n+\n+# 14.1 Element Click Link Element Tests Step 7\n+\n+def test_click_numbers_link(session):\n+ # 14.1 Step 7\n+ url = \"/webdriver/tests/element_click/support/input.html\"\n+ session.url = inline(\"<a href=%s>123456</a>\" % url)\n+ element = session.find.css(\"a\", all=False)\n+ response = click(session, element)\n+ assert_success(response)\n+\n+ assert session.url == \"http://web-platform.test:8000%s\" % url\n+\n+\n+def test_click_multi_line_link(session):\n+ # 14.1 Step 7\n+ url = \"/webdriver/tests/element_click/support/input.html\"\n+ session.url = inline(\"\"\"\n+ <p style=\"background-color: rgb(255, 255, 0); width: 5em;\">","path":"webdriver/tests/element_click/link.py","position":29,"original_position":29,"commit_id":"6dd0af924044331755c1fc6b189b8b4cf9089ba3","original_commit_id":"6dd0af924044331755c1fc6b189b8b4cf9089ba3","user":{"login":"alchiem","id":30814506,"avatar_url":"https://avatars2.githubusercontent.com/u/30814506?v=4","gravatar_id":"","url":"https://api.github.com/users/alchiem","html_url":"https://github.com/alchiem","followers_url":"https://api.github.com/users/alchiem/followers","following_url":"https://api.github.com/users/alchiem/following{/other_user}","gists_url":"https://api.github.com/users/alchiem/gists{/gist_id}","starred_url":"https://api.github.com/users/alchiem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alchiem/subscriptions","organizations_url":"https://api.github.com/users/alchiem/orgs","repos_url":"https://api.github.com/users/alchiem/repos","events_url":"https://api.github.com/users/alchiem/events{/privacy}","received_events_url":"https://api.github.com/users/alchiem/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-04-11T22:30:59Z","updated_at":"2018-04-11T22:30:59Z","html_url":"https://github.com/w3c/web-platform-tests/pull/8379#discussion_r180917362","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/180917362"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/8379#discussion_r180917362"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379"}},"in_reply_to_id":180402010},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379","id":153720734,"html_url":"https://github.com/w3c/web-platform-tests/pull/8379","diff_url":"https://github.com/w3c/web-platform-tests/pull/8379.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/8379.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/8379","number":8379,"state":"open","locked":false,"title":"Implement element_click test for wpt wdspec","user":{"login":"alchiem","id":30814506,"avatar_url":"https://avatars2.githubusercontent.com/u/30814506?v=4","gravatar_id":"","url":"https://api.github.com/users/alchiem","html_url":"https://github.com/alchiem","followers_url":"https://api.github.com/users/alchiem/followers","following_url":"https://api.github.com/users/alchiem/following{/other_user}","gists_url":"https://api.github.com/users/alchiem/gists{/gist_id}","starred_url":"https://api.github.com/users/alchiem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alchiem/subscriptions","organizations_url":"https://api.github.com/users/alchiem/orgs","repos_url":"https://api.github.com/users/alchiem/repos","events_url":"https://api.github.com/users/alchiem/events{/privacy}","received_events_url":"https://api.github.com/users/alchiem/received_events","type":"User","site_admin":false},"body":"Testing webdriver element click spec.\r\nStep 14.1.5 and 14.1.7 part 2 are incomplete.\r\n\r\nhttps://w3c.github.io/webdriver/webdriver-spec.html#element-click\n\n<!-- Reviewable:start -->\n\n<!-- Reviewable:end -->\n","created_at":"2017-11-20T19:58:53Z","updated_at":"2018-04-11T22:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1766f88d27289f6cf93362af68c9218cdba675a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shs96c","id":28229,"avatar_url":"https://avatars2.githubusercontent.com/u/28229?v=4","gravatar_id":"","url":"https://api.github.com/users/shs96c","html_url":"https://github.com/shs96c","followers_url":"https://api.github.com/users/shs96c/followers","following_url":"https://api.github.com/users/shs96c/following{/other_user}","gists_url":"https://api.github.com/users/shs96c/gists{/gist_id}","starred_url":"https://api.github.com/users/shs96c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shs96c/subscriptions","organizations_url":"https://api.github.com/users/shs96c/orgs","repos_url":"https://api.github.com/users/shs96c/repos","events_url":"https://api.github.com/users/shs96c/events{/privacy}","received_events_url":"https://api.github.com/users/shs96c/received_events","type":"User","site_admin":false},{"login":"lukeis","id":926454,"avatar_url":"https://avatars0.githubusercontent.com/u/926454?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeis","html_url":"https://github.com/lukeis","followers_url":"https://api.github.com/users/lukeis/followers","following_url":"https://api.github.com/users/lukeis/following{/other_user}","gists_url":"https://api.github.com/users/lukeis/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeis/subscriptions","organizations_url":"https://api.github.com/users/lukeis/orgs","repos_url":"https://api.github.com/users/lukeis/repos","events_url":"https://api.github.com/users/lukeis/events{/privacy}","received_events_url":"https://api.github.com/users/lukeis/received_events","type":"User","site_admin":false},{"login":"mjzffr","id":6024326,"avatar_url":"https://avatars2.githubusercontent.com/u/6024326?v=4","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false},{"login":"kereliuk","id":9435736,"avatar_url":"https://avatars1.githubusercontent.com/u/9435736?v=4","gravatar_id":"","url":"https://api.github.com/users/kereliuk","html_url":"https://github.com/kereliuk","followers_url":"https://api.github.com/users/kereliuk/followers","following_url":"https://api.github.com/users/kereliuk/following{/other_user}","gists_url":"https://api.github.com/users/kereliuk/gists{/gist_id}","starred_url":"https://api.github.com/users/kereliuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kereliuk/subscriptions","organizations_url":"https://api.github.com/users/kereliuk/orgs","repos_url":"https://api.github.com/users/kereliuk/repos","events_url":"https://api.github.com/users/kereliuk/events{/privacy}","received_events_url":"https://api.github.com/users/kereliuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45231233,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/webdriver","name":"webdriver","color":"ededed","default":false},{"id":80346691,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/wg-testing_browser","name":"wg-testing_browser","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/8379/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/6dd0af924044331755c1fc6b189b8b4cf9089ba3","head":{"label":"MicrosoftEdge:element_click","ref":"element_click","sha":"6dd0af924044331755c1fc6b189b8b4cf9089ba3","user":{"login":"MicrosoftEdge","id":11354582,"avatar_url":"https://avatars3.githubusercontent.com/u/11354582?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftEdge","html_url":"https://github.com/MicrosoftEdge","followers_url":"https://api.github.com/users/MicrosoftEdge/followers","following_url":"https://api.github.com/users/MicrosoftEdge/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftEdge/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftEdge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftEdge/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftEdge/orgs","repos_url":"https://api.github.com/users/MicrosoftEdge/repos","events_url":"https://api.github.com/users/MicrosoftEdge/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftEdge/received_events","type":"Organization","site_admin":false},"repo":{"id":12577220,"name":"web-platform-tests","full_name":"MicrosoftEdge/web-platform-tests","owner":{"login":"MicrosoftEdge","id":11354582,"avatar_url":"https://avatars3.githubusercontent.com/u/11354582?v=4","gravatar_id":"","url":"https://api.github.com/users/MicrosoftEdge","html_url":"https://github.com/MicrosoftEdge","followers_url":"https://api.github.com/users/MicrosoftEdge/followers","following_url":"https://api.github.com/users/MicrosoftEdge/following{/other_user}","gists_url":"https://api.github.com/users/MicrosoftEdge/gists{/gist_id}","starred_url":"https://api.github.com/users/MicrosoftEdge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicrosoftEdge/subscriptions","organizations_url":"https://api.github.com/users/MicrosoftEdge/orgs","repos_url":"https://api.github.com/users/MicrosoftEdge/repos","events_url":"https://api.github.com/users/MicrosoftEdge/events{/privacy}","received_events_url":"https://api.github.com/users/MicrosoftEdge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MicrosoftEdge/web-platform-tests","description":"Test Suites for Web Platform specifications","fork":true,"url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests","forks_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/forks","keys_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/events","assignees_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/merges","archive_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/MicrosoftEdge/web-platform-tests/deployments","created_at":"2013-09-03T23:21:51Z","updated_at":"2017-12-31T00:44:55Z","pushed_at":"2018-04-08T19:53:33Z","git_url":"git://github.com/MicrosoftEdge/web-platform-tests.git","ssh_url":"git@github.com:MicrosoftEdge/web-platform-tests.git","clone_url":"https://github.com/MicrosoftEdge/web-platform-tests.git","svn_url":"https://github.com/MicrosoftEdge/web-platform-tests","homepage":"","size":266833,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":20,"open_issues":10,"watchers":34,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"46fcb4392f8cc29afead9d407cf182ca70175e16","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-04-11T22:27:46Z","pushed_at":"2018-04-11T22:18:46Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":290409,"stargazers_count":1532,"watchers_count":1532,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1389,"mirror_url":null,"archived":false,"open_issues_count":1167,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1389,"open_issues":1167,"watchers":1532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/8379"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/8379"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/8379/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/8379/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/6dd0af924044331755c1fc6b189b8b4cf9089ba3"}},"author_association":"COLLABORATOR"}} | {
"id": 3618133,
"name": "w3c/web-platform-tests",
"url": "https://api.github.com/repos/w3c/web-platform-tests"
} | {
"id": 30814506,
"login": "alchiem",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30814506?",
"url": "https://api.github.com/users/alchiem"
} | {
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
} | 2018-04-11T22:30:59 | 7516535138 | {"actor":{"display_login":"alchiem"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webauthn/pulls/comments/213511116","pull_request_review_id":150363174,"id":213511116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUxMTExNg==","diff_hunk":"@@ -5401,6 +5405,60 @@ authenticator=] and [=client device=] SHOULD work together to ensure that the ex\n only to the operating system user that created that [=platform credential=].\n \n \n+## Username Enumeration ## {#sctn-username-enumeration}\n+\n+While initiating a [=registration ceremony|registration=] or [=authentication ceremony=], there is a risk that the [=[WRP]=] might leak sensitive\n+information about its registered users. For example, if a [=[RP]=] uses e-mail addresses as usernames and a user attempts to\n+initiate an [=authentication=] [=ceremony=] for \"alex.p.mueller@example.com\" and the [=[RP]=] responds with a failure, but then\n+successfully initiates an [=authentication ceremony=] for \"j.doe@example.com\", then the user can conclude that \"j.doe@example.com\"\n+is registered and \"alex.p.mueller@example.com\" is not. The [=[RP]=] has thus leaked the possibly sensitive information that\n+\"j.doe@example.com\" has an account at this [=[RP]=].\n+\n+The following is a non-normative, non-exhaustive list of measures the [=[RP]=] may implement to mitigate or prevent information\n+leakage due to such an attack:\n+\n+- For [=registration ceremonies=]:\n+\n+ - If the [=[RP]=] uses [=[RP]=]-specific usernames as user identifiers:\n+\n+ - When initiating a [=registration ceremony=], disallow registration of usernames that are syntactically valid e-mail\n+ addresses.\n+\n+ Note: The motivation for this suggestion is that in this case the [=[RP]=] probably has no choice but to fail the\n+ [=registration ceremony=] if the user attempts to register a username that is already registered, and an information\n+ leak might therefore be unavoidable. By disallowing e-mail addresses as usernames, the impact of the leakage can be\n+ mitigated since it will be less likely that a user has the same username at this [=[RP]=] as at other [=[RPS]=].\n+\n+ - If the [=[RP]=] uses e-mail addresses as user identifiers:\n+\n+ - When initiating a [=registration ceremony=], interrupt the user interaction after receiving the e-mail address to\n+ register and send a message to this address, containing an unpredictable one-time code and instructions for how to use\n+ it to proceed with the ceremony. Display the same message to the user in the web interface regardless of the contents\n+ of the sent e-mail and whether or not this e-mail address was already registered.\n+\n+ Note: This suggestion can be similarly adapted for other externally meaningful identifiers — for example,\n+ national ID numbers or credit card numbers — if they provide similar out-of-band contact information — for\n+ example, conventional postal address.\n+\n+- For [=authentication ceremonies=]:\n+\n+ - If, when initiating an [=authentication ceremony=], there is no account matching the provided username, continue the\n+ ceremony by invoking `{{CredentialsContainer/get()|navigator.credentials.get()}}` using a syntactically valid","path":"index.bs","position":55,"original_position":55,"commit_id":"63ccd475ec8e54ac8ccd01fba7094171c4fe5829","original_commit_id":"63ccd475ec8e54ac8ccd01fba7094171c4fe5829","user":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"Ah, good catch. Fixed.\r\n\r\nIn expressions like `<code>|options|.{{CredentialCreationOptions/publicKey}}</code>` the `<code>` tags are necessary to get `|options|` and the periods to render with monospace font. It also does change the font size of `publicKey` slightly.","created_at":"2018-08-29T00:13:38Z","updated_at":"2018-08-29T00:13:38Z","html_url":"https://github.com/w3c/webauthn/pull/1036#discussion_r213511116","pull_request_url":"https://api.github.com/repos/w3c/webauthn/pulls/1036","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/comments/213511116"},"html":{"href":"https://github.com/w3c/webauthn/pull/1036#discussion_r213511116"},"pull_request":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/1036"}},"in_reply_to_id":213058453},"pull_request":{"url":"https://api.github.com/repos/w3c/webauthn/pulls/1036","id":207976293,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTc2Mjkz","html_url":"https://github.com/w3c/webauthn/pull/1036","diff_url":"https://github.com/w3c/webauthn/pull/1036.diff","patch_url":"https://github.com/w3c/webauthn/pull/1036.patch","issue_url":"https://api.github.com/repos/w3c/webauthn/issues/1036","number":1036,"state":"open","locked":false,"title":"Add Username Enumeration section to privacy considerations","user":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"This fixes #1014.\n\n\n<!--\n This comment and the below content is programatically generated.\n You may add a comma-separated list of anchors you'd like a\n direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n Don't remove this comment or modify anything below this line.\n If you don't want a preview generated for this pull request,\n just replace the whole of this comment's content by \"no preview\"\n and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/w3c/webauthn/pull/1036.html\" title=\"Last updated on Aug 27, 2018, 10:44 AM GMT (63ccd47)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/webauthn/1036/d74f56b...63ccd47.html\" title=\"Last updated on Aug 27, 2018, 10:44 AM GMT (63ccd47)\">Diff</a>","created_at":"2018-08-13T13:23:39Z","updated_at":"2018-08-29T00:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"393e7a434c33bb6627bcb6c57ac209d8306f8452","assignee":{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"assignees":[{"login":"emlun","id":1367758,"node_id":"MDQ6VXNlcjEzNjc3NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"selfissued","id":7644414,"node_id":"MDQ6VXNlcjc2NDQ0MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7644414?v=4","gravatar_id":"","url":"https://api.github.com/users/selfissued","html_url":"https://github.com/selfissued","followers_url":"https://api.github.com/users/selfissued/followers","following_url":"https://api.github.com/users/selfissued/following{/other_user}","gists_url":"https://api.github.com/users/selfissued/gists{/gist_id}","starred_url":"https://api.github.com/users/selfissued/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfissued/subscriptions","organizations_url":"https://api.github.com/users/selfissued/orgs","repos_url":"https://api.github.com/users/selfissued/repos","events_url":"https://api.github.com/users/selfissued/events{/privacy}","received_events_url":"https://api.github.com/users/selfissued/received_events","type":"User","site_admin":false},{"login":"samuelweiler","id":24963390,"node_id":"MDQ6VXNlcjI0OTYzMzkw","avatar_url":"https://avatars3.githubusercontent.com/u/24963390?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelweiler","html_url":"https://github.com/samuelweiler","followers_url":"https://api.github.com/users/samuelweiler/followers","following_url":"https://api.github.com/users/samuelweiler/following{/other_user}","gists_url":"https://api.github.com/users/samuelweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelweiler/subscriptions","organizations_url":"https://api.github.com/users/samuelweiler/orgs","repos_url":"https://api.github.com/users/samuelweiler/repos","events_url":"https://api.github.com/users/samuelweiler/events{/privacy}","received_events_url":"https://api.github.com/users/samuelweiler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":446006785,"node_id":"MDU6TGFiZWw0NDYwMDY3ODU=","url":"https://api.github.com/repos/w3c/webauthn/labels/subtype:privacy-cons","name":"subtype:privacy-cons","color":"bfd400","default":false},{"id":340917025,"node_id":"MDU6TGFiZWwzNDA5MTcwMjU=","url":"https://api.github.com/repos/w3c/webauthn/labels/type:editorial","name":"type:editorial","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/w3c/webauthn/milestones/11","html_url":"https://github.com/w3c/webauthn/milestone/11","labels_url":"https://api.github.com/repos/w3c/webauthn/milestones/11/labels","id":2543404,"node_id":"MDk6TWlsZXN0b25lMjU0MzQwNA==","number":11,"title":"PropRec","description":"Issues and pull requests to be resolved before nominating the webatuhn spec to Proposed Recommendation (PR) maturity level. See https://www.w3.org/Consortium/Process/#maturity-levels","creator":{"login":"equalsJeffH","id":226571,"node_id":"MDQ6VXNlcjIyNjU3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/226571?v=4","gravatar_id":"","url":"https://api.github.com/users/equalsJeffH","html_url":"https://github.com/equalsJeffH","followers_url":"https://api.github.com/users/equalsJeffH/followers","following_url":"https://api.github.com/users/equalsJeffH/following{/other_user}","gists_url":"https://api.github.com/users/equalsJeffH/gists{/gist_id}","starred_url":"https://api.github.com/users/equalsJeffH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/equalsJeffH/subscriptions","organizations_url":"https://api.github.com/users/equalsJeffH/orgs","repos_url":"https://api.github.com/users/equalsJeffH/repos","events_url":"https://api.github.com/users/equalsJeffH/events{/privacy}","received_events_url":"https://api.github.com/users/equalsJeffH/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":185,"state":"open","created_at":"2017-05-25T17:33:11Z","updated_at":"2018-08-26T20:56:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/w3c/webauthn/pulls/1036/commits","review_comments_url":"https://api.github.com/repos/w3c/webauthn/pulls/1036/comments","review_comment_url":"https://api.github.com/repos/w3c/webauthn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webauthn/issues/1036/comments","statuses_url":"https://api.github.com/repos/w3c/webauthn/statuses/63ccd475ec8e54ac8ccd01fba7094171c4fe5829","head":{"label":"w3c:issue-1014-username-enumeration","ref":"issue-1014-username-enumeration","sha":"63ccd475ec8e54ac8ccd01fba7094171c4fe5829","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":51303856,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwMzg1Ng==","name":"webauthn","full_name":"w3c/webauthn","owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webauthn","description":"Web Authentication WG: https://www.w3.org/Webauthn Editors' Draft:","fork":false,"url":"https://api.github.com/repos/w3c/webauthn","forks_url":"https://api.github.com/repos/w3c/webauthn/forks","keys_url":"https://api.github.com/repos/w3c/webauthn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webauthn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webauthn/teams","hooks_url":"https://api.github.com/repos/w3c/webauthn/hooks","issue_events_url":"https://api.github.com/repos/w3c/webauthn/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webauthn/events","assignees_url":"https://api.github.com/repos/w3c/webauthn/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webauthn/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webauthn/tags","blobs_url":"https://api.github.com/repos/w3c/webauthn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webauthn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webauthn/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webauthn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webauthn/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webauthn/languages","stargazers_url":"https://api.github.com/repos/w3c/webauthn/stargazers","contributors_url":"https://api.github.com/repos/w3c/webauthn/contributors","subscribers_url":"https://api.github.com/repos/w3c/webauthn/subscribers","subscription_url":"https://api.github.com/repos/w3c/webauthn/subscription","commits_url":"https://api.github.com/repos/w3c/webauthn/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webauthn/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webauthn/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webauthn/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webauthn/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webauthn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webauthn/merges","archive_url":"https://api.github.com/repos/w3c/webauthn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webauthn/downloads","issues_url":"https://api.github.com/repos/w3c/webauthn/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webauthn/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webauthn/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webauthn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webauthn/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webauthn/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webauthn/deployments","created_at":"2016-02-08T14:51:38Z","updated_at":"2018-08-26T20:56:59Z","pushed_at":"2018-08-28T19:57:12Z","git_url":"git://github.com/w3c/webauthn.git","ssh_url":"git@github.com:w3c/webauthn.git","clone_url":"https://github.com/w3c/webauthn.git","svn_url":"https://github.com/w3c/webauthn","homepage":"https://w3c.github.io/webauthn/","size":10702,"stargazers_count":301,"watchers_count":301,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":74,"watchers":301,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"d74f56be8e38abdda425dfc586979f632d894468","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":51303856,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwMzg1Ng==","name":"webauthn","full_name":"w3c/webauthn","owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webauthn","description":"Web Authentication WG: https://www.w3.org/Webauthn Editors' Draft:","fork":false,"url":"https://api.github.com/repos/w3c/webauthn","forks_url":"https://api.github.com/repos/w3c/webauthn/forks","keys_url":"https://api.github.com/repos/w3c/webauthn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webauthn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webauthn/teams","hooks_url":"https://api.github.com/repos/w3c/webauthn/hooks","issue_events_url":"https://api.github.com/repos/w3c/webauthn/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webauthn/events","assignees_url":"https://api.github.com/repos/w3c/webauthn/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webauthn/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webauthn/tags","blobs_url":"https://api.github.com/repos/w3c/webauthn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webauthn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webauthn/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webauthn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webauthn/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webauthn/languages","stargazers_url":"https://api.github.com/repos/w3c/webauthn/stargazers","contributors_url":"https://api.github.com/repos/w3c/webauthn/contributors","subscribers_url":"https://api.github.com/repos/w3c/webauthn/subscribers","subscription_url":"https://api.github.com/repos/w3c/webauthn/subscription","commits_url":"https://api.github.com/repos/w3c/webauthn/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webauthn/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webauthn/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webauthn/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webauthn/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webauthn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webauthn/merges","archive_url":"https://api.github.com/repos/w3c/webauthn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webauthn/downloads","issues_url":"https://api.github.com/repos/w3c/webauthn/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webauthn/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webauthn/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webauthn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webauthn/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webauthn/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/webauthn/deployments","created_at":"2016-02-08T14:51:38Z","updated_at":"2018-08-26T20:56:59Z","pushed_at":"2018-08-28T19:57:12Z","git_url":"git://github.com/w3c/webauthn.git","ssh_url":"git@github.com:w3c/webauthn.git","clone_url":"https://github.com/w3c/webauthn.git","svn_url":"https://github.com/w3c/webauthn","homepage":"https://w3c.github.io/webauthn/","size":10702,"stargazers_count":301,"watchers_count":301,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":74,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/1036"},"html":{"href":"https://github.com/w3c/webauthn/pull/1036"},"issue":{"href":"https://api.github.com/repos/w3c/webauthn/issues/1036"},"comments":{"href":"https://api.github.com/repos/w3c/webauthn/issues/1036/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/1036/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webauthn/pulls/1036/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webauthn/statuses/63ccd475ec8e54ac8ccd01fba7094171c4fe5829"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51303856,
"name": "w3c/webauthn",
"url": "https://api.github.com/repos/w3c/webauthn"
} | {
"id": 1367758,
"login": "emlun",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1367758?",
"url": "https://api.github.com/users/emlun"
} | {
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
} | 2018-08-29T00:13:38 | 8181646582 | {"actor":{"display_login":"emlun"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/comments/195108261","pull_request_review_id":128405390,"id":195108261,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTEwODI2MQ==","diff_hunk":"@@ -3216,6 +3204,41 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe\n \n Note: When an exception is [=throw|thrown=], the implementation does undo (roll back) any changes made to the cache storage during the batch operation job.\n </section>\n+\n+ <section algorithm>\n+ <h3 id=\"resolve-get-client-promise-algorithm\"><dfn>Resolve Get Client Promise</dfn></h3>\n+\n+ : Input\n+ :: |client|, a [=/service worker client=]\n+ :: |promise|, a [=promise=]\n+\n+ : Output\n+ :: none\n+\n+ 1. If |client| is an [=environment settings object=], then:\n+ 1. If |client| is not a [=secure context=], reject |promise| with a \"{{SecurityError}}\" {{DOMException}} and abort these steps.\n+ 1. Else:\n+ 1. If |client|’s [=creation URL=] is not a [=potentially trustworthy URL=], reject |promise| with a \"{{SecurityError}}\" {{DOMException}} and abort these steps.\n+ 1. If |client| is an [=environment settings object=] and is not a [=window client=], then:\n+ 1. Let |clientObject| be the result of running [=Create Client=] algorithm with |client| as the argument.\n+ 1. Resolve |promise| with |clientObject| and abort these steps.\n+ 1. Else:\n+ 1. Let |browsingContext| be null.\n+ 1. Let |visibilityState| be null.\n+ 1. Let |focusState| be false.\n+ 1. Let |ancestorOriginsList| be the empty list.\n+ 1. If |client| is an [=environment settings object=], set |browsingContext| to |client|'s [=environment settings object/global object=]'s [=/browsing context=].\n+ 1. Else, set |browsingContext| to |client|’s [=environment/target browsing context=].\n+ 1. [=Queue a task=] |task| to run the following substeps on |browsingContext|'s [=event loop=] using the [=user interaction task source=]:\n+ 1. Set |visibilityState| to |browsingContext|'s [=active document=]'s {{Document/visibilityState}} attribute value.\n+ 1. Set |focusState| to the result of running the [=has focus steps=] with |browsingContext|'s [=active document=] as the argument.\n+ 1. If |client| is a [=window client=], set |ancestorOriginsList| to |browsingContext|'s [=active document=]'s [=relevant global object=]'s {{Location}} object's [=Location/ancestor origins list=]'s associated list.\n+ 1. Wait for |task| to have executed.\n+ 1. If |client|'s [=discarded flag=] is set, resolve |promise| with undefined and abort these steps.\n+ 1. Let |windowClient| be the result of running [=Create Window Client=] algorithm with |client|, |visibilityState|, |focusState|, and |ancestorOriginsList| as the arguments.\n+ 1. Resolve |promise| with |windowClient|.","path":"docs/index.bs","position":82,"original_position":82,"commit_id":"43e425b9350393be8492e3095bf4a35e69d33045","original_commit_id":"43e425b9350393be8492e3095bf4a35e69d33045","user":{"login":"jakearchibald","id":93594,"node_id":"MDQ6VXNlcjkzNTk0","avatar_url":"https://avatars1.githubusercontent.com/u/93594?v=4","gravatar_id":"","url":"https://api.github.com/users/jakearchibald","html_url":"https://github.com/jakearchibald","followers_url":"https://api.github.com/users/jakearchibald/followers","following_url":"https://api.github.com/users/jakearchibald/following{/other_user}","gists_url":"https://api.github.com/users/jakearchibald/gists{/gist_id}","starred_url":"https://api.github.com/users/jakearchibald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakearchibald/subscriptions","organizations_url":"https://api.github.com/users/jakearchibald/orgs","repos_url":"https://api.github.com/users/jakearchibald/repos","events_url":"https://api.github.com/users/jakearchibald/events{/privacy}","received_events_url":"https://api.github.com/users/jakearchibald/received_events","type":"User","site_admin":false},"body":"This might be a silly question, but is it possible for a client to end up representing another origin, or is the client discarded and a new one created in that case?","created_at":"2018-06-13T14:37:45Z","updated_at":"2018-06-13T14:38:02Z","html_url":"https://github.com/w3c/ServiceWorker/pull/1323#discussion_r195108261","pull_request_url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/comments/195108261"},"html":{"href":"https://github.com/w3c/ServiceWorker/pull/1323#discussion_r195108261"},"pull_request":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323","id":193244256,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjQ0MjU2","html_url":"https://github.com/w3c/ServiceWorker/pull/1323","diff_url":"https://github.com/w3c/ServiceWorker/pull/1323.diff","patch_url":"https://github.com/w3c/ServiceWorker/pull/1323.patch","issue_url":"https://api.github.com/repos/w3c/ServiceWorker/issues/1323","number":1323,"state":"open","locked":false,"title":"Clients.get: block on reserved clients.","user":{"login":"mattto","id":1782098,"node_id":"MDQ6VXNlcjE3ODIwOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1782098?v=4","gravatar_id":"","url":"https://api.github.com/users/mattto","html_url":"https://github.com/mattto","followers_url":"https://api.github.com/users/mattto/followers","following_url":"https://api.github.com/users/mattto/following{/other_user}","gists_url":"https://api.github.com/users/mattto/gists{/gist_id}","starred_url":"https://api.github.com/users/mattto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattto/subscriptions","organizations_url":"https://api.github.com/users/mattto/orgs","repos_url":"https://api.github.com/users/mattto/repos","events_url":"https://api.github.com/users/mattto/events{/privacy}","received_events_url":"https://api.github.com/users/mattto/received_events","type":"User","site_admin":false},"body":"Clients.get: block on reserved clients.\n\nFollow-up to 07e9487 (#1259).\n\n\n<!--\n This comment and the below content is programatically generated.\n You may add a comma-separated list of anchors you'd like a\n direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n Don't remove this comment or modify anything below this line.\n If you don't want a preview generated for this pull request,\n just replace the whole of this comment's content by \"no preview\"\n and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/mattto/ServiceWorker/pull/1323.html\" title=\"Last updated on Jun 13, 2018, 4:56 AM GMT (43e425b)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/ServiceWorker/1323/34a64e6...mattto:43e425b.html\" title=\"Last updated on Jun 13, 2018, 4:56 AM GMT (43e425b)\">Diff</a>","created_at":"2018-06-07T08:41:39Z","updated_at":"2018-06-13T14:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"984e4aa34cb564777d3deb3512f0e9570f53e5b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/w3c/ServiceWorker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/ServiceWorker/issues/1323/comments","statuses_url":"https://api.github.com/repos/w3c/ServiceWorker/statuses/43e425b9350393be8492e3095bf4a35e69d33045","head":{"label":"mattto:clients-get-try2","ref":"clients-get-try2","sha":"43e425b9350393be8492e3095bf4a35e69d33045","user":{"login":"mattto","id":1782098,"node_id":"MDQ6VXNlcjE3ODIwOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1782098?v=4","gravatar_id":"","url":"https://api.github.com/users/mattto","html_url":"https://github.com/mattto","followers_url":"https://api.github.com/users/mattto/followers","following_url":"https://api.github.com/users/mattto/following{/other_user}","gists_url":"https://api.github.com/users/mattto/gists{/gist_id}","starred_url":"https://api.github.com/users/mattto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattto/subscriptions","organizations_url":"https://api.github.com/users/mattto/orgs","repos_url":"https://api.github.com/users/mattto/repos","events_url":"https://api.github.com/users/mattto/events{/privacy}","received_events_url":"https://api.github.com/users/mattto/received_events","type":"User","site_admin":false},"repo":{"id":16687301,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4NzMwMQ==","name":"ServiceWorker","full_name":"mattto/ServiceWorker","owner":{"login":"mattto","id":1782098,"node_id":"MDQ6VXNlcjE3ODIwOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1782098?v=4","gravatar_id":"","url":"https://api.github.com/users/mattto","html_url":"https://github.com/mattto","followers_url":"https://api.github.com/users/mattto/followers","following_url":"https://api.github.com/users/mattto/following{/other_user}","gists_url":"https://api.github.com/users/mattto/gists{/gist_id}","starred_url":"https://api.github.com/users/mattto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattto/subscriptions","organizations_url":"https://api.github.com/users/mattto/orgs","repos_url":"https://api.github.com/users/mattto/repos","events_url":"https://api.github.com/users/mattto/events{/privacy}","received_events_url":"https://api.github.com/users/mattto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattto/ServiceWorker","description":"The Service Worker Specification","fork":true,"url":"https://api.github.com/repos/mattto/ServiceWorker","forks_url":"https://api.github.com/repos/mattto/ServiceWorker/forks","keys_url":"https://api.github.com/repos/mattto/ServiceWorker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattto/ServiceWorker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattto/ServiceWorker/teams","hooks_url":"https://api.github.com/repos/mattto/ServiceWorker/hooks","issue_events_url":"https://api.github.com/repos/mattto/ServiceWorker/issues/events{/number}","events_url":"https://api.github.com/repos/mattto/ServiceWorker/events","assignees_url":"https://api.github.com/repos/mattto/ServiceWorker/assignees{/user}","branches_url":"https://api.github.com/repos/mattto/ServiceWorker/branches{/branch}","tags_url":"https://api.github.com/repos/mattto/ServiceWorker/tags","blobs_url":"https://api.github.com/repos/mattto/ServiceWorker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattto/ServiceWorker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattto/ServiceWorker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattto/ServiceWorker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattto/ServiceWorker/statuses/{sha}","languages_url":"https://api.github.com/repos/mattto/ServiceWorker/languages","stargazers_url":"https://api.github.com/repos/mattto/ServiceWorker/stargazers","contributors_url":"https://api.github.com/repos/mattto/ServiceWorker/contributors","subscribers_url":"https://api.github.com/repos/mattto/ServiceWorker/subscribers","subscription_url":"https://api.github.com/repos/mattto/ServiceWorker/subscription","commits_url":"https://api.github.com/repos/mattto/ServiceWorker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattto/ServiceWorker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattto/ServiceWorker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattto/ServiceWorker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattto/ServiceWorker/contents/{+path}","compare_url":"https://api.github.com/repos/mattto/ServiceWorker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattto/ServiceWorker/merges","archive_url":"https://api.github.com/repos/mattto/ServiceWorker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattto/ServiceWorker/downloads","issues_url":"https://api.github.com/repos/mattto/ServiceWorker/issues{/number}","pulls_url":"https://api.github.com/repos/mattto/ServiceWorker/pulls{/number}","milestones_url":"https://api.github.com/repos/mattto/ServiceWorker/milestones{/number}","notifications_url":"https://api.github.com/repos/mattto/ServiceWorker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattto/ServiceWorker/labels{/name}","releases_url":"https://api.github.com/repos/mattto/ServiceWorker/releases{/id}","deployments_url":"https://api.github.com/repos/mattto/ServiceWorker/deployments","created_at":"2014-02-10T07:06:53Z","updated_at":"2018-06-07T03:37:40Z","pushed_at":"2018-06-13T04:55:54Z","git_url":"git://github.com/mattto/ServiceWorker.git","ssh_url":"git@github.com:mattto/ServiceWorker.git","clone_url":"https://github.com/mattto/ServiceWorker.git","svn_url":"https://github.com/mattto/ServiceWorker","homepage":"","size":9486,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"34a64e666f964bbe12cc571e7a5eb957ca202885","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":8071542,"node_id":"MDEwOlJlcG9zaXRvcnk4MDcxNTQy","name":"ServiceWorker","full_name":"w3c/ServiceWorker","owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/ServiceWorker","description":"The Service Worker Specification https://w3c.github.io/ServiceWorker/","fork":false,"url":"https://api.github.com/repos/w3c/ServiceWorker","forks_url":"https://api.github.com/repos/w3c/ServiceWorker/forks","keys_url":"https://api.github.com/repos/w3c/ServiceWorker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/ServiceWorker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/ServiceWorker/teams","hooks_url":"https://api.github.com/repos/w3c/ServiceWorker/hooks","issue_events_url":"https://api.github.com/repos/w3c/ServiceWorker/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/ServiceWorker/events","assignees_url":"https://api.github.com/repos/w3c/ServiceWorker/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/ServiceWorker/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/ServiceWorker/tags","blobs_url":"https://api.github.com/repos/w3c/ServiceWorker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/ServiceWorker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/ServiceWorker/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/ServiceWorker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/ServiceWorker/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/ServiceWorker/languages","stargazers_url":"https://api.github.com/repos/w3c/ServiceWorker/stargazers","contributors_url":"https://api.github.com/repos/w3c/ServiceWorker/contributors","subscribers_url":"https://api.github.com/repos/w3c/ServiceWorker/subscribers","subscription_url":"https://api.github.com/repos/w3c/ServiceWorker/subscription","commits_url":"https://api.github.com/repos/w3c/ServiceWorker/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/ServiceWorker/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/ServiceWorker/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/ServiceWorker/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/ServiceWorker/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/ServiceWorker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/ServiceWorker/merges","archive_url":"https://api.github.com/repos/w3c/ServiceWorker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/ServiceWorker/downloads","issues_url":"https://api.github.com/repos/w3c/ServiceWorker/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/ServiceWorker/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/ServiceWorker/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/ServiceWorker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/ServiceWorker/labels{/name}","releases_url":"https://api.github.com/repos/w3c/ServiceWorker/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/ServiceWorker/deployments","created_at":"2013-02-07T11:23:04Z","updated_at":"2018-06-13T14:27:20Z","pushed_at":"2018-06-13T14:27:17Z","git_url":"git://github.com/w3c/ServiceWorker.git","ssh_url":"git@github.com:w3c/ServiceWorker.git","clone_url":"https://github.com/w3c/ServiceWorker.git","svn_url":"https://github.com/w3c/ServiceWorker","homepage":"","size":9622,"stargazers_count":2850,"watchers_count":2850,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":258,"open_issues":197,"watchers":2850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323"},"html":{"href":"https://github.com/w3c/ServiceWorker/pull/1323"},"issue":{"href":"https://api.github.com/repos/w3c/ServiceWorker/issues/1323"},"comments":{"href":"https://api.github.com/repos/w3c/ServiceWorker/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/ServiceWorker/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/ServiceWorker/statuses/43e425b9350393be8492e3095bf4a35e69d33045"}},"author_association":"MEMBER"}} | {
"id": 8071542,
"name": "w3c/ServiceWorker",
"url": "https://api.github.com/repos/w3c/ServiceWorker"
} | {
"id": 93594,
"login": "jakearchibald",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/93594?",
"url": "https://api.github.com/users/jakearchibald"
} | {
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
} | 2018-06-13T14:37:45 | 7819277584 | {"actor":{"display_login":"jakearchibald"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/clio/pulls/comments/172937916","pull_request_review_id":102042015,"id":172937916,"diff_hunk":"@@ -72,6 +79,11 @@ object UpsertId {\n */\n private val next6bitIndex = (_: Int) => source.nextInt(Encoding.length)\n \n+ /**\n+ * Clio name for an upsert ID.\n+ */\n+ val UpsertIdFieldName: String = \"upsertId\"","path":"clio-util/src/main/scala/org/broadinstitute/clio/util/model/UpsertId.scala","position":21,"original_position":21,"commit_id":"dd83f621fc225249759bc2706d1ff27ee88f0d40","original_commit_id":"e37fa22fd26bed4e62e19f07410b8b552b7d0eaa","user":{"login":"als364","id":1847690,"avatar_url":"https://avatars0.githubusercontent.com/u/1847690?v=4","gravatar_id":"","url":"https://api.github.com/users/als364","html_url":"https://github.com/als364","followers_url":"https://api.github.com/users/als364/followers","following_url":"https://api.github.com/users/als364/following{/other_user}","gists_url":"https://api.github.com/users/als364/gists{/gist_id}","starred_url":"https://api.github.com/users/als364/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/als364/subscriptions","organizations_url":"https://api.github.com/users/als364/orgs","repos_url":"https://api.github.com/users/als364/repos","events_url":"https://api.github.com/users/als364/events{/privacy}","received_events_url":"https://api.github.com/users/als364/received_events","type":"User","site_admin":false},"body":"Makes sense, I can move this and `EntityId` into ElasticsearchIndex and get rid of the camel case names.","created_at":"2018-03-07T18:24:02Z","updated_at":"2018-03-07T18:24:02Z","html_url":"https://github.com/broadinstitute/clio/pull/220#discussion_r172937916","pull_request_url":"https://api.github.com/repos/broadinstitute/clio/pulls/220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/comments/172937916"},"html":{"href":"https://github.com/broadinstitute/clio/pull/220#discussion_r172937916"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/220"}},"in_reply_to_id":171940573},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/clio/pulls/220","id":172576290,"html_url":"https://github.com/broadinstitute/clio/pull/220","diff_url":"https://github.com/broadinstitute/clio/pull/220.diff","patch_url":"https://github.com/broadinstitute/clio/pull/220.patch","issue_url":"https://api.github.com/repos/broadinstitute/clio/issues/220","number":220,"state":"open","locked":false,"title":"DSDEGP-2069 - Stop expensive json -> case class -> json conversions","user":{"login":"als364","id":1847690,"avatar_url":"https://avatars0.githubusercontent.com/u/1847690?v=4","gravatar_id":"","url":"https://api.github.com/users/als364","html_url":"https://github.com/als364","followers_url":"https://api.github.com/users/als364/followers","following_url":"https://api.github.com/users/als364/following{/other_user}","gists_url":"https://api.github.com/users/als364/gists{/gist_id}","starred_url":"https://api.github.com/users/als364/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/als364/subscriptions","organizations_url":"https://api.github.com/users/als364/orgs","repos_url":"https://api.github.com/users/als364/repos","events_url":"https://api.github.com/users/als364/events{/privacy}","received_events_url":"https://api.github.com/users/als364/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis isn't ready for merging yet, but I'm opening this for comments in the hopes that people who are not @danxmoran can look at it.\r\n\r\nI basically deleted ClioDocument and followed the compiler complaints. I also collapsed `AutoElasticsearchQueryMapper` and `AutoElasticsearchDocumentMapper` into their parent classes, since they were the only subclasses.\r\n\r\n`ElasticsearchIndex` is now parameterized on `TransferIndex` and uses `TransferIndex`'s `KeyType` and `MetadataType` rather than using `TransferKey`s and `MetadataKey`s directly.\r\n\r\nI haven't started looking at the tests, and there's still a `not enough arguments for method implicitly` compile error that I don't understand how to fix.\r\n\r\nIdeally I can get rid of the encoders/decoders in `Elasticsearchindex` eventually and have it just deal with json.\r\n\r\n----\r\n\r\n### Checklist (never delete this)\r\n\r\nNever delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.\r\n\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: Ensure that you have added or updated tests\r\n- [ ] **Submitter**: If you're adding/switching libraries or otherwise changing the design, update the [design documentation](https://broadinstitute.atlassian.net/wiki/pages/viewpage.action?pageId=114531509).\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n * Acceptance criteria exists and is met\r\n * Note any changes to implementation from the description\r\n * Add notes on what you've tested\r\n* Review cycle:\r\n * Team may comment on PR at will\r\n * **Reviewer assigns to submitter** for feedback fixes\r\n * Submitter rebases to develop again if necessary\r\n * Submitter makes further commits. DO NOT SQUASH\r\n * Submitter updates documentation as needed\r\n * Submitter **reassigns to reviewer** for further feedback\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Move the JIRA issue to QA once this checklist is completed\r\n","created_at":"2018-03-02T18:49:15Z","updated_at":"2018-03-07T18:24:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a34a765098bff6f0723f771545c0e27dd2a0f26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":665219589,"url":"https://api.github.com/repos/broadinstitute/clio/labels/do%20not%20merge","name":"do not merge","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/clio/pulls/220/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/clio/pulls/220/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/clio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/clio/issues/220/comments","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/dd83f621fc225249759bc2706d1ff27ee88f0d40","head":{"label":"broadinstitute:as_DSDEGP-2069_stop_expensive_document_conversions","ref":"as_DSDEGP-2069_stop_expensive_document_conversions","sha":"dd83f621fc225249759bc2706d1ff27ee88f0d40","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":88189881,"name":"clio","full_name":"broadinstitute/clio","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/clio","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/clio","forks_url":"https://api.github.com/repos/broadinstitute/clio/forks","keys_url":"https://api.github.com/repos/broadinstitute/clio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/clio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/clio/teams","hooks_url":"https://api.github.com/repos/broadinstitute/clio/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/clio/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/clio/events","assignees_url":"https://api.github.com/repos/broadinstitute/clio/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/clio/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/clio/tags","blobs_url":"https://api.github.com/repos/broadinstitute/clio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/clio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/clio/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/clio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/clio/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/clio/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/clio/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/clio/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/clio/subscription","commits_url":"https://api.github.com/repos/broadinstitute/clio/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/clio/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/clio/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/clio/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/clio/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/clio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/clio/merges","archive_url":"https://api.github.com/repos/broadinstitute/clio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/clio/downloads","issues_url":"https://api.github.com/repos/broadinstitute/clio/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/clio/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/clio/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/clio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/clio/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/clio/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/clio/deployments","created_at":"2017-04-13T17:28:28Z","updated_at":"2017-07-06T22:50:40Z","pushed_at":"2018-03-07T18:04:12Z","git_url":"git://github.com/broadinstitute/clio.git","ssh_url":"git@github.com:broadinstitute/clio.git","clone_url":"https://github.com/broadinstitute/clio.git","svn_url":"https://github.com/broadinstitute/clio","homepage":null,"size":1309,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"a69340fb46a32e06719570055af59d2f4296a230","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":88189881,"name":"clio","full_name":"broadinstitute/clio","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/clio","description":null,"fork":false,"url":"https://api.github.com/repos/broadinstitute/clio","forks_url":"https://api.github.com/repos/broadinstitute/clio/forks","keys_url":"https://api.github.com/repos/broadinstitute/clio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/clio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/clio/teams","hooks_url":"https://api.github.com/repos/broadinstitute/clio/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/clio/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/clio/events","assignees_url":"https://api.github.com/repos/broadinstitute/clio/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/clio/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/clio/tags","blobs_url":"https://api.github.com/repos/broadinstitute/clio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/clio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/clio/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/clio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/clio/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/clio/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/clio/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/clio/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/clio/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/clio/subscription","commits_url":"https://api.github.com/repos/broadinstitute/clio/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/clio/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/clio/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/clio/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/clio/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/clio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/clio/merges","archive_url":"https://api.github.com/repos/broadinstitute/clio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/clio/downloads","issues_url":"https://api.github.com/repos/broadinstitute/clio/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/clio/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/clio/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/clio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/clio/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/clio/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/clio/deployments","created_at":"2017-04-13T17:28:28Z","updated_at":"2017-07-06T22:50:40Z","pushed_at":"2018-03-07T18:04:12Z","git_url":"git://github.com/broadinstitute/clio.git","ssh_url":"git@github.com:broadinstitute/clio.git","clone_url":"https://github.com/broadinstitute/clio.git","svn_url":"https://github.com/broadinstitute/clio","homepage":null,"size":1309,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/220"},"html":{"href":"https://github.com/broadinstitute/clio/pull/220"},"issue":{"href":"https://api.github.com/repos/broadinstitute/clio/issues/220"},"comments":{"href":"https://api.github.com/repos/broadinstitute/clio/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/clio/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/clio/statuses/dd83f621fc225249759bc2706d1ff27ee88f0d40"}},"author_association":"CONTRIBUTOR"}} | {
"id": 88189881,
"name": "broadinstitute/clio",
"url": "https://api.github.com/repos/broadinstitute/clio"
} | {
"id": 1847690,
"login": "als364",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1847690?",
"url": "https://api.github.com/users/als364"
} | {
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
} | 2018-03-07T18:24:02 | 7345745412 | {"actor":{"display_login":"als364"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/comments/237217995","pull_request_review_id":179463410,"id":237217995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIxNzk5NQ==","diff_hunk":"@@ -0,0 +1,81 @@\n+package org.broadinstitute.gdr.encode.explorer.facets\n+\n+import cats.Parallel\n+import cats.effect.Sync\n+import cats.implicits._\n+import org.broadinstitute.gdr.encode.explorer.db.{DbClient, DbTable}\n+import org.broadinstitute.gdr.encode.explorer.fields.{\n+ FieldConfig,\n+ FieldType,\n+ FieldsConfig\n+}\n+\n+import scala.language.higherKinds\n+\n+/**\n+ * Component responsible for handling faceted search requests.\n+ *\n+ * @tparam M wrapper type capable of suspending synchronous effects\n+ * @tparam F wrapper type capable of composing instances of `M` in parallel\n+ * @param fields configuration determining which DB columns should be queried\n+ * and returned on faceted search requests\n+ * @param dbClient client which knows how to query the DB\n+ * @param par proof that `F` can compose instances of `M` in parallel\n+ */\n+class FacetsController[M[_]: Sync, F[_]](\n+ fields: FieldsConfig,\n+ dbClient: DbClient[M]\n+)(implicit par: Parallel[M, F]) {\n+\n+ /** Check that the fields defined in config refer to actual DB columns. */\n+ def validateFields: M[Unit] =\n+ (\n+ validateFields(DbTable.Donors, fields.donorFields),\n+ validateFields(DbTable.Files, fields.fileFields)\n+ ).parMapN((_, _) => ())\n+\n+ private def validateFields(table: DbTable, fields: List[FieldConfig]): M[Unit] =\n+ dbClient.fields(table).flatMap { dbFields =>\n+ fields.traverse_ { f =>\n+ val col = f.column\n+ if (dbFields.contains(col)) {\n+ ().pure[M]\n+ } else {\n+ val err: Throwable = new IllegalStateException(\n+ s\"No such field in table '${table.entryName}': $col\"\n+ )\n+ err.raiseError[M, Unit]\n+ }\n+ }","path":"encode/explorer/src/main/scala/org/broadinstitute/gdr/encode/explorer/facets/FacetsController.scala","position":61,"original_position":49,"commit_id":"3923b9473d3313e7c844891a53e96ddd8ddffe43","original_commit_id":"68ee30577fd22270cb9cc4698acc0c3624f1c6dd","user":{"login":"ahaessly","id":22915781,"node_id":"MDQ6VXNlcjIyOTE1Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/22915781?v=4","gravatar_id":"","url":"https://api.github.com/users/ahaessly","html_url":"https://github.com/ahaessly","followers_url":"https://api.github.com/users/ahaessly/followers","following_url":"https://api.github.com/users/ahaessly/following{/other_user}","gists_url":"https://api.github.com/users/ahaessly/gists{/gist_id}","starred_url":"https://api.github.com/users/ahaessly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahaessly/subscriptions","organizations_url":"https://api.github.com/users/ahaessly/orgs","repos_url":"https://api.github.com/users/ahaessly/repos","events_url":"https://api.github.com/users/ahaessly/events{/privacy}","received_events_url":"https://api.github.com/users/ahaessly/received_events","type":"User","site_admin":false},"body":"probably not important now, but if we are expecting to have a large number of field to validate, you might want to try to validate all fields and then return errors for all the ones that do not pass validation.","created_at":"2018-11-28T18:59:04Z","updated_at":"2018-11-28T18:59:04Z","html_url":"https://github.com/broadinstitute/gdr-ingest/pull/28#discussion_r237217995","pull_request_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/comments/237217995"},"html":{"href":"https://github.com/broadinstitute/gdr-ingest/pull/28#discussion_r237217995"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28","id":233938552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTM4NTUy","html_url":"https://github.com/broadinstitute/gdr-ingest/pull/28","diff_url":"https://github.com/broadinstitute/gdr-ingest/pull/28.diff","patch_url":"https://github.com/broadinstitute/gdr-ingest/pull/28.patch","issue_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/28","number":28,"state":"open","locked":false,"title":"DSPDC-68 Init server for data explorer API","user":{"login":"danxmoran","id":2755881,"node_id":"MDQ6VXNlcjI3NTU4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/2755881?v=4","gravatar_id":"","url":"https://api.github.com/users/danxmoran","html_url":"https://github.com/danxmoran","followers_url":"https://api.github.com/users/danxmoran/followers","following_url":"https://api.github.com/users/danxmoran/following{/other_user}","gists_url":"https://api.github.com/users/danxmoran/gists{/gist_id}","starred_url":"https://api.github.com/users/danxmoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danxmoran/subscriptions","organizations_url":"https://api.github.com/users/danxmoran/orgs","repos_url":"https://api.github.com/users/danxmoran/repos","events_url":"https://api.github.com/users/danxmoran/events{/privacy}","received_events_url":"https://api.github.com/users/danxmoran/received_events","type":"User","site_admin":false},"body":"Result is running in the back-end here: http://broad-gdr-encode.appspot.com/. Be warned it's *painfully* slow, but I wanted to get it merged in.","created_at":"2018-11-27T14:48:19Z","updated_at":"2018-11-28T18:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8692fe2071088f4b1fd6f17114dc6df0c8a06a45","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjamincarlin","id":42980312,"node_id":"MDQ6VXNlcjQyOTgwMzEy","avatar_url":"https://avatars0.githubusercontent.com/u/42980312?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamincarlin","html_url":"https://github.com/benjamincarlin","followers_url":"https://api.github.com/users/benjamincarlin/followers","following_url":"https://api.github.com/users/benjamincarlin/following{/other_user}","gists_url":"https://api.github.com/users/benjamincarlin/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamincarlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamincarlin/subscriptions","organizations_url":"https://api.github.com/users/benjamincarlin/orgs","repos_url":"https://api.github.com/users/benjamincarlin/repos","events_url":"https://api.github.com/users/benjamincarlin/events{/privacy}","received_events_url":"https://api.github.com/users/benjamincarlin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/28/comments","statuses_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/statuses/3923b9473d3313e7c844891a53e96ddd8ddffe43","head":{"label":"broadinstitute:dm-explorer-api-DSPDC-68","ref":"dm-explorer-api-DSPDC-68","sha":"3923b9473d3313e7c844891a53e96ddd8ddffe43","user":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":144730062,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3MzAwNjI=","name":"gdr-ingest","full_name":"broadinstitute/gdr-ingest","private":false,"owner":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/broadinstitute/gdr-ingest","description":"Scripts / pipelines for slurping external datasets into Broad data repositories.","fork":false,"url":"https://api.github.com/repos/broadinstitute/gdr-ingest","forks_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/forks","keys_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/events","assignees_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/merges","archive_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/deployments","created_at":"2018-08-14T14:16:11Z","updated_at":"2018-11-16T18:24:02Z","pushed_at":"2018-11-27T22:49:48Z","git_url":"git://github.com/broadinstitute/gdr-ingest.git","ssh_url":"git@github.com:broadinstitute/gdr-ingest.git","clone_url":"https://github.com/broadinstitute/gdr-ingest.git","svn_url":"https://github.com/broadinstitute/gdr-ingest","homepage":null,"size":199,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"95a3c3b239b657b84b3e5d3045b4a8f7568300e7","user":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":144730062,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3MzAwNjI=","name":"gdr-ingest","full_name":"broadinstitute/gdr-ingest","private":false,"owner":{"login":"broadinstitute","id":393552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/broadinstitute/gdr-ingest","description":"Scripts / pipelines for slurping external datasets into Broad data repositories.","fork":false,"url":"https://api.github.com/repos/broadinstitute/gdr-ingest","forks_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/forks","keys_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/events","assignees_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/merges","archive_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gdr-ingest/deployments","created_at":"2018-08-14T14:16:11Z","updated_at":"2018-11-16T18:24:02Z","pushed_at":"2018-11-27T22:49:48Z","git_url":"git://github.com/broadinstitute/gdr-ingest.git","ssh_url":"git@github.com:broadinstitute/gdr-ingest.git","clone_url":"https://github.com/broadinstitute/gdr-ingest.git","svn_url":"https://github.com/broadinstitute/gdr-ingest","homepage":null,"size":199,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28"},"html":{"href":"https://github.com/broadinstitute/gdr-ingest/pull/28"},"issue":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/28"},"comments":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/gdr-ingest/statuses/3923b9473d3313e7c844891a53e96ddd8ddffe43"}},"author_association":"COLLABORATOR"}} | {
"id": 144730062,
"name": "broadinstitute/gdr-ingest",
"url": "https://api.github.com/repos/broadinstitute/gdr-ingest"
} | {
"id": 22915781,
"login": "ahaessly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22915781?",
"url": "https://api.github.com/users/ahaessly"
} | {
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
} | 2018-11-28T18:59:04 | 8664027706 | {"actor":{"display_login":"ahaessly"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/comments/168915593","pull_request_review_id":97368168,"id":168915593,"diff_hunk":"@@ -0,0 +1,8 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<container xmlns=\"http://symfony.com/schema/dic/services\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd\">\n+ <services>\n+ <service id=\"sonata.doctrine.adapter.doctrine_orm\" class=\"Sonata\\Doctrine\\Adapter\\ORM\\DoctrineORMAdapter\" public=\"false\">","path":"src/Bridge/Symfony/Resources/config/doctrine_orm.xml","position":4,"original_position":4,"commit_id":"3e8b2c24e76941a406620cf288a701277111b9e0","original_commit_id":"3e8b2c24e76941a406620cf288a701277111b9e0","user":{"login":"kunicmarko20","id":13528674,"avatar_url":"https://avatars3.githubusercontent.com/u/13528674?v=4","gravatar_id":"","url":"https://api.github.com/users/kunicmarko20","html_url":"https://github.com/kunicmarko20","followers_url":"https://api.github.com/users/kunicmarko20/followers","following_url":"https://api.github.com/users/kunicmarko20/following{/other_user}","gists_url":"https://api.github.com/users/kunicmarko20/gists{/gist_id}","starred_url":"https://api.github.com/users/kunicmarko20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunicmarko20/subscriptions","organizations_url":"https://api.github.com/users/kunicmarko20/orgs","repos_url":"https://api.github.com/users/kunicmarko20/repos","events_url":"https://api.github.com/users/kunicmarko20/events{/privacy}","received_events_url":"https://api.github.com/users/kunicmarko20/received_events","type":"User","site_admin":false},"body":"Isn't public by default `false`?","created_at":"2018-02-17T07:42:23Z","updated_at":"2018-02-17T07:42:24Z","html_url":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82#discussion_r168915593","pull_request_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/comments/168915593"},"html":{"href":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82#discussion_r168915593"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82","id":166832615,"html_url":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82","diff_url":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82.diff","patch_url":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82.patch","issue_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/82","number":82,"state":"open","locked":false,"title":"Moved stuff from CoreBundle","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n Show us you choose the right branch.\r\n Different branches are used for different things :\r\n - 1.x is for everything backwards compatible, like patches, features and deprecation notices\r\n - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n More details here: https://github.com/sonata-project/sonata-doctrine-extensions/blob/1.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because this is BC.\r\n\r\n<!--\r\n Specify which issues will be fixed/closed.\r\n Remove it if this is not related.\r\n-->\r\n\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n Fill the changelog part inside the code block.\r\n Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Added\r\n- Added all doctrine stuff from `SonataCoreBundle`\r\n```\r\n\r\n## Subject\r\n\r\nThis will move all doctrine stuff from the old `SonataCoreBundle` to this bundle (https://github.com/sonata-project/dev-kit/issues/348).\r\n","created_at":"2018-02-02T15:38:43Z","updated_at":"2018-02-17T07:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53e40ab9fb183a9405110feb007abbe6b3315ceb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":369799218,"url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/labels/minor","name":"minor","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82/commits","review_comments_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82/comments","review_comment_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/82/comments","statuses_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/statuses/3e8b2c24e76941a406620cf288a701277111b9e0","head":{"label":"core23:feature/move-from-core-bundle","ref":"feature/move-from-core-bundle","sha":"3e8b2c24e76941a406620cf288a701277111b9e0","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"repo":{"id":55077423,"name":"sonata-doctrine-extensions","full_name":"core23/sonata-doctrine-extensions","owner":{"login":"core23","id":3440437,"avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/core23/sonata-doctrine-extensions","description":null,"fork":true,"url":"https://api.github.com/repos/core23/sonata-doctrine-extensions","forks_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/forks","keys_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/teams","hooks_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/hooks","issue_events_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/events","assignees_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/tags","blobs_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/languages","stargazers_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/stargazers","contributors_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/contributors","subscribers_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/subscribers","subscription_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/subscription","commits_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/merges","archive_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/downloads","issues_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/labels{/name}","releases_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/core23/sonata-doctrine-extensions/deployments","created_at":"2016-03-30T16:05:17Z","updated_at":"2016-03-30T16:05:18Z","pushed_at":"2018-02-06T16:59:52Z","git_url":"git://github.com/core23/sonata-doctrine-extensions.git","ssh_url":"git@github.com:core23/sonata-doctrine-extensions.git","clone_url":"https://github.com/core23/sonata-doctrine-extensions.git","svn_url":"https://github.com/core23/sonata-doctrine-extensions","homepage":"","size":113,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:1.x","ref":"1.x","sha":"d52db045f47efef166f00f7b970ff73336618464","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":2318793,"name":"sonata-doctrine-extensions","full_name":"sonata-project/sonata-doctrine-extensions","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/sonata-doctrine-extensions","description":null,"fork":false,"url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions","forks_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/forks","keys_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/teams","hooks_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/events","assignees_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/tags","blobs_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/languages","stargazers_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/subscription","commits_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/merges","archive_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/downloads","issues_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/deployments","created_at":"2011-09-03T11:46:40Z","updated_at":"2018-02-15T13:26:06Z","pushed_at":"2018-02-06T16:59:54Z","git_url":"git://github.com/sonata-project/sonata-doctrine-extensions.git","ssh_url":"git@github.com:sonata-project/sonata-doctrine-extensions.git","clone_url":"https://github.com/sonata-project/sonata-doctrine-extensions.git","svn_url":"https://github.com/sonata-project/sonata-doctrine-extensions","homepage":"https://sonata-project.org/","size":120,"stargazers_count":33,"watchers_count":33,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":20,"open_issues":1,"watchers":33,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82"},"html":{"href":"https://github.com/sonata-project/sonata-doctrine-extensions/pull/82"},"issue":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/82"},"comments":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/sonata-doctrine-extensions/statuses/3e8b2c24e76941a406620cf288a701277111b9e0"}},"author_association":"MEMBER"}} | {
"id": 2318793,
"name": "sonata-project/sonata-doctrine-extensions",
"url": "https://api.github.com/repos/sonata-project/sonata-doctrine-extensions"
} | {
"id": 13528674,
"login": "kunicmarko20",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13528674?",
"url": "https://api.github.com/users/kunicmarko20"
} | {
"id": 404157,
"login": "sonata-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/404157?",
"url": "https://api.github.com/orgs/sonata-project"
} | 2018-02-17T07:42:23 | 7258457597 | {"actor":{"display_login":"kunicmarko20"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/comments/240146008","pull_request_review_id":183105357,"id":240146008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE0NjAwOA==","diff_hunk":"@@ -0,0 +1,125 @@\n+=head1 HISTORY","path":"pending/dancer2-plugin-paginator.pod","position":1,"original_position":1,"commit_id":"4b5f8739fb9a1fa9a5cc32280a393d08f72a84b3","original_commit_id":"4b5f8739fb9a1fa9a5cc32280a393d08f72a84b3","user":{"login":"bigpresh","id":54107,"node_id":"MDQ6VXNlcjU0MTA3","avatar_url":"https://avatars3.githubusercontent.com/u/54107?v=4","gravatar_id":"","url":"https://api.github.com/users/bigpresh","html_url":"https://github.com/bigpresh","followers_url":"https://api.github.com/users/bigpresh/followers","following_url":"https://api.github.com/users/bigpresh/following{/other_user}","gists_url":"https://api.github.com/users/bigpresh/gists{/gist_id}","starred_url":"https://api.github.com/users/bigpresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigpresh/subscriptions","organizations_url":"https://api.github.com/users/bigpresh/orgs","repos_url":"https://api.github.com/users/bigpresh/repos","events_url":"https://api.github.com/users/bigpresh/events{/privacy}","received_events_url":"https://api.github.com/users/bigpresh/received_events","type":"User","site_admin":false},"body":"OTTOMH, the `=head1` title should be the one displayed when listing all articles for a year, and `=head2` and below used for sub-sections of the article - so it would be better to start with e.g. `=head1 Dancer2::Plugin::Paginator reborn` or something, and move the `=head1`'s to `=head2`'s.","created_at":"2018-12-10T09:58:26Z","updated_at":"2018-12-10T09:58:26Z","html_url":"https://github.com/PerlDancer/advent-calendar/pull/38#discussion_r240146008","pull_request_url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/comments/240146008"},"html":{"href":"https://github.com/PerlDancer/advent-calendar/pull/38#discussion_r240146008"},"pull_request":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38","id":237105127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTA1MTI3","html_url":"https://github.com/PerlDancer/advent-calendar/pull/38","diff_url":"https://github.com/PerlDancer/advent-calendar/pull/38.diff","patch_url":"https://github.com/PerlDancer/advent-calendar/pull/38.patch","issue_url":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/38","number":38,"state":"open","locked":false,"title":"Dancer2 plugin paginator","user":{"login":"manwar","id":681195,"node_id":"MDQ6VXNlcjY4MTE5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/681195?v=4","gravatar_id":"","url":"https://api.github.com/users/manwar","html_url":"https://github.com/manwar","followers_url":"https://api.github.com/users/manwar/followers","following_url":"https://api.github.com/users/manwar/following{/other_user}","gists_url":"https://api.github.com/users/manwar/gists{/gist_id}","starred_url":"https://api.github.com/users/manwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manwar/subscriptions","organizations_url":"https://api.github.com/users/manwar/orgs","repos_url":"https://api.github.com/users/manwar/repos","events_url":"https://api.github.com/users/manwar/events{/privacy}","received_events_url":"https://api.github.com/users/manwar/received_events","type":"User","site_admin":false},"body":"Hi @cromedome \r\n\r\nPlease review the draft for Advent Calendar 2018 topic Dancer2::Plugin::Paginator.\r\n\r\nMany Thanks.\r\nBest Regards,\r\nMohammad S Anwar","created_at":"2018-12-09T03:05:20Z","updated_at":"2018-12-10T09:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02757f8ad631b557b143dc80d385de6224b6d881","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38/commits","review_comments_url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38/comments","review_comment_url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/38/comments","statuses_url":"https://api.github.com/repos/PerlDancer/advent-calendar/statuses/4b5f8739fb9a1fa9a5cc32280a393d08f72a84b3","head":{"label":"manwar:dancer2-plugin-paginator","ref":"dancer2-plugin-paginator","sha":"4b5f8739fb9a1fa9a5cc32280a393d08f72a84b3","user":{"login":"manwar","id":681195,"node_id":"MDQ6VXNlcjY4MTE5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/681195?v=4","gravatar_id":"","url":"https://api.github.com/users/manwar","html_url":"https://github.com/manwar","followers_url":"https://api.github.com/users/manwar/followers","following_url":"https://api.github.com/users/manwar/following{/other_user}","gists_url":"https://api.github.com/users/manwar/gists{/gist_id}","starred_url":"https://api.github.com/users/manwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manwar/subscriptions","organizations_url":"https://api.github.com/users/manwar/orgs","repos_url":"https://api.github.com/users/manwar/repos","events_url":"https://api.github.com/users/manwar/events{/privacy}","received_events_url":"https://api.github.com/users/manwar/received_events","type":"User","site_admin":false},"repo":{"id":160998581,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5OTg1ODE=","name":"advent-calendar","full_name":"manwar/advent-calendar","private":false,"owner":{"login":"manwar","id":681195,"node_id":"MDQ6VXNlcjY4MTE5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/681195?v=4","gravatar_id":"","url":"https://api.github.com/users/manwar","html_url":"https://github.com/manwar","followers_url":"https://api.github.com/users/manwar/followers","following_url":"https://api.github.com/users/manwar/following{/other_user}","gists_url":"https://api.github.com/users/manwar/gists{/gist_id}","starred_url":"https://api.github.com/users/manwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manwar/subscriptions","organizations_url":"https://api.github.com/users/manwar/orgs","repos_url":"https://api.github.com/users/manwar/repos","events_url":"https://api.github.com/users/manwar/events{/privacy}","received_events_url":"https://api.github.com/users/manwar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manwar/advent-calendar","description":"Articles for the advent calendar","fork":true,"url":"https://api.github.com/repos/manwar/advent-calendar","forks_url":"https://api.github.com/repos/manwar/advent-calendar/forks","keys_url":"https://api.github.com/repos/manwar/advent-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manwar/advent-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manwar/advent-calendar/teams","hooks_url":"https://api.github.com/repos/manwar/advent-calendar/hooks","issue_events_url":"https://api.github.com/repos/manwar/advent-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/manwar/advent-calendar/events","assignees_url":"https://api.github.com/repos/manwar/advent-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/manwar/advent-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/manwar/advent-calendar/tags","blobs_url":"https://api.github.com/repos/manwar/advent-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manwar/advent-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manwar/advent-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/manwar/advent-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manwar/advent-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/manwar/advent-calendar/languages","stargazers_url":"https://api.github.com/repos/manwar/advent-calendar/stargazers","contributors_url":"https://api.github.com/repos/manwar/advent-calendar/contributors","subscribers_url":"https://api.github.com/repos/manwar/advent-calendar/subscribers","subscription_url":"https://api.github.com/repos/manwar/advent-calendar/subscription","commits_url":"https://api.github.com/repos/manwar/advent-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/manwar/advent-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/manwar/advent-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/manwar/advent-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/manwar/advent-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/manwar/advent-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manwar/advent-calendar/merges","archive_url":"https://api.github.com/repos/manwar/advent-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manwar/advent-calendar/downloads","issues_url":"https://api.github.com/repos/manwar/advent-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/manwar/advent-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/manwar/advent-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/manwar/advent-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manwar/advent-calendar/labels{/name}","releases_url":"https://api.github.com/repos/manwar/advent-calendar/releases{/id}","deployments_url":"https://api.github.com/repos/manwar/advent-calendar/deployments","created_at":"2018-12-09T02:55:40Z","updated_at":"2018-12-09T02:55:42Z","pushed_at":"2018-12-10T03:44:11Z","git_url":"git://github.com/manwar/advent-calendar.git","ssh_url":"git@github.com:manwar/advent-calendar.git","clone_url":"https://github.com/manwar/advent-calendar.git","svn_url":"https://github.com/manwar/advent-calendar","homepage":"","size":2914,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PerlDancer:master","ref":"master","sha":"5985fe5f163922a5f925a538f61f48bc76ef0a5f","user":{"login":"PerlDancer","id":409763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/409763?v=4","gravatar_id":"","url":"https://api.github.com/users/PerlDancer","html_url":"https://github.com/PerlDancer","followers_url":"https://api.github.com/users/PerlDancer/followers","following_url":"https://api.github.com/users/PerlDancer/following{/other_user}","gists_url":"https://api.github.com/users/PerlDancer/gists{/gist_id}","starred_url":"https://api.github.com/users/PerlDancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerlDancer/subscriptions","organizations_url":"https://api.github.com/users/PerlDancer/orgs","repos_url":"https://api.github.com/users/PerlDancer/repos","events_url":"https://api.github.com/users/PerlDancer/events{/privacy}","received_events_url":"https://api.github.com/users/PerlDancer/received_events","type":"Organization","site_admin":false},"repo":{"id":978591,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzg1OTE=","name":"advent-calendar","full_name":"PerlDancer/advent-calendar","private":false,"owner":{"login":"PerlDancer","id":409763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTc2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/409763?v=4","gravatar_id":"","url":"https://api.github.com/users/PerlDancer","html_url":"https://github.com/PerlDancer","followers_url":"https://api.github.com/users/PerlDancer/followers","following_url":"https://api.github.com/users/PerlDancer/following{/other_user}","gists_url":"https://api.github.com/users/PerlDancer/gists{/gist_id}","starred_url":"https://api.github.com/users/PerlDancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerlDancer/subscriptions","organizations_url":"https://api.github.com/users/PerlDancer/orgs","repos_url":"https://api.github.com/users/PerlDancer/repos","events_url":"https://api.github.com/users/PerlDancer/events{/privacy}","received_events_url":"https://api.github.com/users/PerlDancer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PerlDancer/advent-calendar","description":"Articles for the advent calendar","fork":false,"url":"https://api.github.com/repos/PerlDancer/advent-calendar","forks_url":"https://api.github.com/repos/PerlDancer/advent-calendar/forks","keys_url":"https://api.github.com/repos/PerlDancer/advent-calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PerlDancer/advent-calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PerlDancer/advent-calendar/teams","hooks_url":"https://api.github.com/repos/PerlDancer/advent-calendar/hooks","issue_events_url":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/events{/number}","events_url":"https://api.github.com/repos/PerlDancer/advent-calendar/events","assignees_url":"https://api.github.com/repos/PerlDancer/advent-calendar/assignees{/user}","branches_url":"https://api.github.com/repos/PerlDancer/advent-calendar/branches{/branch}","tags_url":"https://api.github.com/repos/PerlDancer/advent-calendar/tags","blobs_url":"https://api.github.com/repos/PerlDancer/advent-calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PerlDancer/advent-calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PerlDancer/advent-calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/PerlDancer/advent-calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PerlDancer/advent-calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/PerlDancer/advent-calendar/languages","stargazers_url":"https://api.github.com/repos/PerlDancer/advent-calendar/stargazers","contributors_url":"https://api.github.com/repos/PerlDancer/advent-calendar/contributors","subscribers_url":"https://api.github.com/repos/PerlDancer/advent-calendar/subscribers","subscription_url":"https://api.github.com/repos/PerlDancer/advent-calendar/subscription","commits_url":"https://api.github.com/repos/PerlDancer/advent-calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/PerlDancer/advent-calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/PerlDancer/advent-calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/PerlDancer/advent-calendar/contents/{+path}","compare_url":"https://api.github.com/repos/PerlDancer/advent-calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PerlDancer/advent-calendar/merges","archive_url":"https://api.github.com/repos/PerlDancer/advent-calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PerlDancer/advent-calendar/downloads","issues_url":"https://api.github.com/repos/PerlDancer/advent-calendar/issues{/number}","pulls_url":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/PerlDancer/advent-calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/PerlDancer/advent-calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PerlDancer/advent-calendar/labels{/name}","releases_url":"https://api.github.com/repos/PerlDancer/advent-calendar/releases{/id}","deployments_url":"https://api.github.com/repos/PerlDancer/advent-calendar/deployments","created_at":"2010-10-11T13:50:04Z","updated_at":"2016-11-05T14:07:49Z","pushed_at":"2018-12-10T09:44:52Z","git_url":"git://github.com/PerlDancer/advent-calendar.git","ssh_url":"git@github.com:PerlDancer/advent-calendar.git","clone_url":"https://github.com/PerlDancer/advent-calendar.git","svn_url":"https://github.com/PerlDancer/advent-calendar","homepage":"","size":2916,"stargazers_count":30,"watchers_count":30,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":21,"open_issues":3,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38"},"html":{"href":"https://github.com/PerlDancer/advent-calendar/pull/38"},"issue":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/38"},"comments":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/PerlDancer/advent-calendar/statuses/4b5f8739fb9a1fa9a5cc32280a393d08f72a84b3"}},"author_association":"NONE"}} | {
"id": 978591,
"name": "PerlDancer/advent-calendar",
"url": "https://api.github.com/repos/PerlDancer/advent-calendar"
} | {
"id": 54107,
"login": "bigpresh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54107?",
"url": "https://api.github.com/users/bigpresh"
} | {
"id": 409763,
"login": "PerlDancer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/409763?",
"url": "https://api.github.com/orgs/PerlDancer"
} | 2018-12-10T09:58:26 | 8725637581 | {"actor":{"display_login":"bigpresh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/183542715","pull_request_review_id":114561818,"id":183542715,"diff_hunk":"@@ -40,141 +44,136 @@ def __init__(self, file_name, worker_id=0,\n self._buffer_size = 12000\n self._version_ = \"API-3\"\n self._loaded = False\n- self._open_socket = False\n-\n- try:\n- # Establish communication socket\n- self._socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)\n- self._socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)\n- self._socket.bind((\"localhost\", self.port))\n- self._open_socket = True\n- except socket.error:\n- self._open_socket = True\n- self.close()\n- raise socket.error(\"Couldn't launch new environment because worker number {} is still in use. \"\n- \"You may need to manually close a previously opened environment \"\n- \"or use a different worker number.\".format(str(worker_id)))\n-\n- cwd = os.getcwd()\n- file_name = (file_name.strip()\n- .replace('.app', '').replace('.exe', '').replace('.x86_64', '').replace('.x86', ''))\n- true_filename = os.path.basename(os.path.normpath(file_name))\n- logger.debug('The true file name is {}'.format(true_filename))\n- launch_string = None\n- if platform == \"linux\" or platform == \"linux2\":\n- candidates = glob.glob(os.path.join(cwd, file_name) + '.x86_64')\n- if len(candidates) == 0:\n- candidates = glob.glob(os.path.join(cwd, file_name) + '.x86')\n- if len(candidates) == 0:\n- candidates = glob.glob(file_name + '.x86_64')\n- if len(candidates) == 0:\n- candidates = glob.glob(file_name + '.x86')\n- if len(candidates) > 0:\n- launch_string = candidates[0]\n-\n- elif platform == 'darwin':\n- candidates = glob.glob(os.path.join(cwd, file_name + '.app', 'Contents', 'MacOS', true_filename))\n- if len(candidates) == 0:\n- candidates = glob.glob(os.path.join(file_name + '.app', 'Contents', 'MacOS', true_filename))\n- if len(candidates) == 0:\n- candidates = glob.glob(os.path.join(cwd, file_name + '.app', 'Contents', 'MacOS', '*'))\n- if len(candidates) == 0:\n- candidates = glob.glob(os.path.join(file_name + '.app', 'Contents', 'MacOS', '*'))\n- if len(candidates) > 0:\n- launch_string = candidates[0]\n- elif platform == 'win32':\n- candidates = glob.glob(os.path.join(cwd, file_name + '.exe'))\n- if len(candidates) == 0:\n- candidates = glob.glob(file_name + '.exe')\n- if len(candidates) > 0:\n- launch_string = candidates[0]\n- if launch_string is None:\n- self.close()\n- raise UnityEnvironmentException(\"Couldn't launch the {0} environment. \"\n- \"Provided filename does not match any environments.\"\n- .format(true_filename))\n- else:\n- logger.debug(\"This is the launch string {}\".format(launch_string))\n- # Launch Unity environment\n- if docker_training == False:\n- proc1 = subprocess.Popen(\n- [launch_string,\n- '--port', str(self.port),\n- '--seed', str(seed)])\n+ self.proc1 = None\n+\n+ self.communicator = GrpcCommunicator(worker_id, base_port)\n+ # self.communicator = SocketCommunicator(worker_id, base_port)\n+\n+ if file_name != 'editor':\n+ cwd = os.getcwd()\n+ file_name = (file_name.strip()\n+ .replace('.app', '').replace('.exe', '').replace('.x86_64', '').replace('.x86', ''))\n+ true_filename = os.path.basename(os.path.normpath(file_name))\n+ logger.debug('The true file name is {}'.format(true_filename))\n+ launch_string = None\n+ if platform == \"linux\" or platform == \"linux2\":","path":"python/unityagents/environment.py","position":108,"original_position":108,"commit_id":"344e18a386c1013da70712c88398dc9311cf0313","original_commit_id":"344e18a386c1013da70712c88398dc9311cf0313","user":{"login":"vladimiroster","id":3922999,"avatar_url":"https://avatars1.githubusercontent.com/u/3922999?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimiroster","html_url":"https://github.com/vladimiroster","followers_url":"https://api.github.com/users/vladimiroster/followers","following_url":"https://api.github.com/users/vladimiroster/following{/other_user}","gists_url":"https://api.github.com/users/vladimiroster/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimiroster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimiroster/subscriptions","organizations_url":"https://api.github.com/users/vladimiroster/orgs","repos_url":"https://api.github.com/users/vladimiroster/repos","events_url":"https://api.github.com/users/vladimiroster/events{/privacy}","received_events_url":"https://api.github.com/users/vladimiroster/received_events","type":"User","site_admin":false},"body":"It's a lot nicer to refactor this code into separate functions. This way, you can easily unit test them, and you don't have huge if-else ladders","created_at":"2018-04-23T21:25:18Z","updated_at":"2018-04-23T21:59:03Z","html_url":"https://github.com/Unity-Technologies/ml-agents/pull/638#discussion_r183542715","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/183542715"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/638#discussion_r183542715"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638","id":182010219,"html_url":"https://github.com/Unity-Technologies/ml-agents/pull/638","diff_url":"https://github.com/Unity-Technologies/ml-agents/pull/638.diff","patch_url":"https://github.com/Unity-Technologies/ml-agents/pull/638.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/638","number":638,"state":"open","locked":false,"title":"Develop communicator redesign","user":{"login":"vincentpierre","id":28320361,"avatar_url":"https://avatars3.githubusercontent.com/u/28320361?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentpierre","html_url":"https://github.com/vincentpierre","followers_url":"https://api.github.com/users/vincentpierre/followers","following_url":"https://api.github.com/users/vincentpierre/following{/other_user}","gists_url":"https://api.github.com/users/vincentpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentpierre/subscriptions","organizations_url":"https://api.github.com/users/vincentpierre/orgs","repos_url":"https://api.github.com/users/vincentpierre/repos","events_url":"https://api.github.com/users/vincentpierre/events{/privacy}","received_events_url":"https://api.github.com/users/vincentpierre/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-16T22:58:15Z","updated_at":"2018-04-23T21:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"628d6013d62f70dd4dd957f7c22eb0fb7c2bb753","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mmattar","id":477636,"avatar_url":"https://avatars1.githubusercontent.com/u/477636?v=4","gravatar_id":"","url":"https://api.github.com/users/mmattar","html_url":"https://github.com/mmattar","followers_url":"https://api.github.com/users/mmattar/followers","following_url":"https://api.github.com/users/mmattar/following{/other_user}","gists_url":"https://api.github.com/users/mmattar/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattar/subscriptions","organizations_url":"https://api.github.com/users/mmattar/orgs","repos_url":"https://api.github.com/users/mmattar/repos","events_url":"https://api.github.com/users/mmattar/events{/privacy}","received_events_url":"https://api.github.com/users/mmattar/received_events","type":"User","site_admin":false},{"login":"eshvk","id":807898,"avatar_url":"https://avatars0.githubusercontent.com/u/807898?v=4","gravatar_id":"","url":"https://api.github.com/users/eshvk","html_url":"https://github.com/eshvk","followers_url":"https://api.github.com/users/eshvk/followers","following_url":"https://api.github.com/users/eshvk/following{/other_user}","gists_url":"https://api.github.com/users/eshvk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshvk/subscriptions","organizations_url":"https://api.github.com/users/eshvk/orgs","repos_url":"https://api.github.com/users/eshvk/repos","events_url":"https://api.github.com/users/eshvk/events{/privacy}","received_events_url":"https://api.github.com/users/eshvk/received_events","type":"User","site_admin":false},{"login":"xiaomaogy","id":5985076,"avatar_url":"https://avatars3.githubusercontent.com/u/5985076?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaomaogy","html_url":"https://github.com/xiaomaogy","followers_url":"https://api.github.com/users/xiaomaogy/followers","following_url":"https://api.github.com/users/xiaomaogy/following{/other_user}","gists_url":"https://api.github.com/users/xiaomaogy/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaomaogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaomaogy/subscriptions","organizations_url":"https://api.github.com/users/xiaomaogy/orgs","repos_url":"https://api.github.com/users/xiaomaogy/repos","events_url":"https://api.github.com/users/xiaomaogy/events{/privacy}","received_events_url":"https://api.github.com/users/xiaomaogy/received_events","type":"User","site_admin":false},{"login":"awjuliani","id":9065325,"avatar_url":"https://avatars2.githubusercontent.com/u/9065325?v=4","gravatar_id":"","url":"https://api.github.com/users/awjuliani","html_url":"https://github.com/awjuliani","followers_url":"https://api.github.com/users/awjuliani/followers","following_url":"https://api.github.com/users/awjuliani/following{/other_user}","gists_url":"https://api.github.com/users/awjuliani/gists{/gist_id}","starred_url":"https://api.github.com/users/awjuliani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awjuliani/subscriptions","organizations_url":"https://api.github.com/users/awjuliani/orgs","repos_url":"https://api.github.com/users/awjuliani/repos","events_url":"https://api.github.com/users/awjuliani/events{/privacy}","received_events_url":"https://api.github.com/users/awjuliani/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/638/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/344e18a386c1013da70712c88398dc9311cf0313","head":{"label":"Unity-Technologies:develop-communicator-redesign","ref":"develop-communicator-redesign","sha":"344e18a386c1013da70712c88398dc9311cf0313","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-04-23T21:05:49Z","pushed_at":"2018-04-23T21:51:21Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":190093,"stargazers_count":2789,"watchers_count":2789,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":564,"open_issues":103,"watchers":2789,"default_branch":"master"}},"base":{"label":"Unity-Technologies:develop","ref":"develop","sha":"994659305d446278b046a773a3b6f010c688a642","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-04-23T21:05:49Z","pushed_at":"2018-04-23T21:51:21Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":190093,"stargazers_count":2789,"watchers_count":2789,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":564,"open_issues":103,"watchers":2789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/638"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/638"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/638/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/638/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/344e18a386c1013da70712c88398dc9311cf0313"}},"author_association":"CONTRIBUTOR"}} | {
"id": 102904613,
"name": "Unity-Technologies/ml-agents",
"url": "https://api.github.com/repos/Unity-Technologies/ml-agents"
} | {
"id": 3922999,
"login": "vladimiroster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3922999?",
"url": "https://api.github.com/users/vladimiroster"
} | {
"id": 426196,
"login": "Unity-Technologies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/426196?",
"url": "https://api.github.com/orgs/Unity-Technologies"
} | 2018-04-23T21:25:18 | 7574724069 | {"actor":{"display_login":"vladimiroster"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/166667635","pull_request_review_id":94763963,"id":166667635,"diff_hunk":"@@ -0,0 +1,174 @@\n+package org.infinispan.hibernate.cache.commons.access;\n+\n+import java.util.Collections;\n+import java.util.Map;\n+import java.util.Set;\n+\n+import org.infinispan.container.entries.CacheEntry;\n+import org.infinispan.context.InvocationContext;\n+import org.infinispan.remoting.transport.Address;\n+import org.infinispan.remoting.transport.LocalModeAddress;\n+\n+/**\n+ * This is a copy of {@link org.infinispan.context.SingleKeyNonTxInvocationContext}\n+ * which carries extra info about the session.\n+ */\n+class SessionInvocationContext implements InvocationContext {\n+ private boolean isLocked;\n+ private Object key;\n+ private CacheEntry cacheEntry;\n+ private final Object lockOwner;\n+ private final Object session;\n+\n+ public SessionInvocationContext(Object session, Object lockOwner) {\n+ this.session = session;\n+ this.lockOwner = lockOwner;\n+ }\n+\n+ @Override\n+ public boolean isOriginLocal() {\n+ return true;\n+ }\n+\n+ @Override\n+ public boolean isInTxScope() {\n+ return false;\n+ }\n+\n+ @Override\n+ public Object getLockOwner() {\n+ return lockOwner;\n+ }\n+\n+ @Override\n+ public void setLockOwner(Object lockOwner) {\n+ throw new UnsupportedOperationException();\n+ }\n+\n+ @Override\n+ public InvocationContext clone() {\n+ try {\n+ return (InvocationContext) super.clone();\n+ } catch (CloneNotSupportedException e) {\n+ throw new IllegalStateException(\"Impossible!\", e);\n+ }\n+ }\n+\n+ @Override\n+ public Set<Object> getLockedKeys() {\n+ return isLocked ? Collections.singleton(key) : Collections.emptySet();\n+ }\n+\n+ @Override\n+ public void clearLockedKeys() {\n+ isLocked = false;\n+ }\n+\n+ @Override\n+ public void addLockedKey(final Object key) {\n+ if (this.key == null) {\n+ // Set the key here\n+ this.key = key;\n+ } else if (!isKeyEquals(key)) {\n+ throw illegalStateException();\n+ }\n+\n+ isLocked = true;\n+ }\n+\n+ private IllegalStateException illegalStateException() {\n+ return new IllegalStateException(\"This is a single key invocation context, using multiple keys shouldn't be possible\");\n+ }\n+\n+ @Override\n+ public CacheEntry lookupEntry(final Object key) {\n+ if (this.key != null && isKeyEquals(key))\n+ return cacheEntry;\n+\n+ return null;\n+ }\n+\n+ public boolean isKeyEquals(Object key) {\n+ return this.key == key || this.key.equals(key);\n+ }\n+\n+ @Override\n+ public Map<Object, CacheEntry> getLookedUpEntries() {\n+ return cacheEntry == null ? Collections.emptyMap() : Collections.singletonMap(key, cacheEntry);\n+ }\n+\n+ @Override\n+ public void putLookedUpEntry(final Object key, final CacheEntry e) {\n+ if (this.key == null) {\n+ // Set the key here\n+ this.key = key;\n+ } else if (!isKeyEquals(key)) {\n+ throw illegalStateException();\n+ }\n+\n+ this.cacheEntry = e;\n+ }\n+\n+ @Override\n+ public void removeLookedUpEntry(final Object key) {\n+ if (this.key != null && isKeyEquals(key)) {\n+ this.cacheEntry = null;\n+ }\n+ }\n+\n+ public Object getKey() {\n+ return key;\n+ }\n+\n+ public CacheEntry getCacheEntry() {\n+ return cacheEntry;\n+ }\n+\n+ @Override\n+ public Address getOrigin() {\n+ return LocalModeAddress.INSTANCE;\n+ }\n+\n+ @Override\n+ public ClassLoader getClassLoader() {\n+ return null;\n+ }\n+\n+ @Override\n+ public void setClassLoader(ClassLoader classLoader) {\n+ // No-op\n+ }\n+\n+ @Override\n+ public boolean hasLockedKey(final Object key) {\n+ return isLocked && isKeyEquals(key);\n+ }\n+\n+ @Override\n+ public boolean isEntryRemovedInContext(final Object key) {\n+ CacheEntry ce = lookupEntry(key);\n+ return ce != null && ce.isRemoved() && ce.isChanged();\n+ }\n+\n+ public Object getSession() {\n+ return session;\n+ }\n+\n+ public void resetState() {","path":"hibernate/cache-commons/src/main/java/org/infinispan/hibernate/cache/commons/access/SessionInvocationContext.java","position":157,"original_position":157,"commit_id":"d8e29d646cc95f8731f2ef7548a1e1925eab70ec","original_commit_id":"d8e29d646cc95f8731f2ef7548a1e1925eab70ec","user":{"login":"pruivo","id":1492066,"avatar_url":"https://avatars2.githubusercontent.com/u/1492066?v=4","gravatar_id":"","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User","site_admin":false},"body":"unused","created_at":"2018-02-07T16:11:37Z","updated_at":"2018-02-07T16:13:08Z","html_url":"https://github.com/infinispan/infinispan/pull/5701#discussion_r166667635","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5701","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/166667635"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5701#discussion_r166667635"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5701"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/5701","id":165183465,"html_url":"https://github.com/infinispan/infinispan/pull/5701","diff_url":"https://github.com/infinispan/infinispan/pull/5701.diff","patch_url":"https://github.com/infinispan/infinispan/pull/5701.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/5701","number":5701,"state":"open","locked":false,"title":"ISPN-8336 lockAllAndRecord() method is blocking","user":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars0.githubusercontent.com/u/2167869?v=4","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"body":"Rebased #5515 and hacked hibernate-cache","created_at":"2018-01-25T17:40:33Z","updated_at":"2018-02-07T16:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc84a6c77e5f8ddf43bc8a56b2d4e024c8360c25","assignee":{"login":"danberindei","id":504907,"avatar_url":"https://avatars2.githubusercontent.com/u/504907?v=4","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"assignees":[{"login":"danberindei","id":504907,"avatar_url":"https://avatars2.githubusercontent.com/u/504907?v=4","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"danberindei","id":504907,"avatar_url":"https://avatars2.githubusercontent.com/u/504907?v=4","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5701/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5701/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/5701/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/d8e29d646cc95f8731f2ef7548a1e1925eab70ec","head":{"label":"rvansa:t_8336_blocking_lock","ref":"t_8336_blocking_lock","sha":"d8e29d646cc95f8731f2ef7548a1e1925eab70ec","user":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars0.githubusercontent.com/u/2167869?v=4","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"repo":{"id":8481591,"name":"infinispan","full_name":"rvansa/infinispan","owner":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars0.githubusercontent.com/u/2167869?v=4","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvansa/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/rvansa/infinispan","forks_url":"https://api.github.com/repos/rvansa/infinispan/forks","keys_url":"https://api.github.com/repos/rvansa/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvansa/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvansa/infinispan/teams","hooks_url":"https://api.github.com/repos/rvansa/infinispan/hooks","issue_events_url":"https://api.github.com/repos/rvansa/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/rvansa/infinispan/events","assignees_url":"https://api.github.com/repos/rvansa/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/rvansa/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/rvansa/infinispan/tags","blobs_url":"https://api.github.com/repos/rvansa/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvansa/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvansa/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvansa/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvansa/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/rvansa/infinispan/languages","stargazers_url":"https://api.github.com/repos/rvansa/infinispan/stargazers","contributors_url":"https://api.github.com/repos/rvansa/infinispan/contributors","subscribers_url":"https://api.github.com/repos/rvansa/infinispan/subscribers","subscription_url":"https://api.github.com/repos/rvansa/infinispan/subscription","commits_url":"https://api.github.com/repos/rvansa/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvansa/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvansa/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvansa/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvansa/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/rvansa/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvansa/infinispan/merges","archive_url":"https://api.github.com/repos/rvansa/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvansa/infinispan/downloads","issues_url":"https://api.github.com/repos/rvansa/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/rvansa/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/rvansa/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/rvansa/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvansa/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/rvansa/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/rvansa/infinispan/deployments","created_at":"2013-02-28T15:13:16Z","updated_at":"2015-05-05T17:20:40Z","pushed_at":"2018-02-07T08:37:52Z","git_url":"git://github.com/rvansa/infinispan.git","ssh_url":"git@github.com:rvansa/infinispan.git","clone_url":"https://github.com/rvansa/infinispan.git","svn_url":"https://github.com/rvansa/infinispan","homepage":"http://www.infinispan.org","size":98519,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"07eadcef0c1d481115de30f00e84d705016e89ee","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2018-02-06T06:47:20Z","pushed_at":"2018-02-07T15:56:08Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":105072,"stargazers_count":636,"watchers_count":636,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":425,"open_issues":18,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5701"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5701"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5701"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5701/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5701/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5701/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/d8e29d646cc95f8731f2ef7548a1e1925eab70ec"}},"author_association":"MEMBER"}} | {
"id": 1050944,
"name": "infinispan/infinispan",
"url": "https://api.github.com/repos/infinispan/infinispan"
} | {
"id": 1492066,
"login": "pruivo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1492066?",
"url": "https://api.github.com/users/pruivo"
} | {
"id": 458093,
"login": "infinispan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/458093?",
"url": "https://api.github.com/orgs/infinispan"
} | 2018-02-07T16:11:37 | 7211741413 | {"actor":{"display_login":"pruivo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/js-client/pulls/comments/227350594","pull_request_review_id":167369431,"id":227350594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzM1MDU5NA==","diff_hunk":"@@ -654,7 +654,7 @@\n disconnect: function() {\n logger.debugf('Disconnect transport');\n emitter.removeListener('router', onRouter);\n- return router.disconnect();\n+ return (router ? router.disconnect() : null);","path":"lib/io.js","position":5,"original_position":5,"commit_id":"969a2c192359681089c607f22cda9e6734701184","original_commit_id":"d1e14dfa5da98b8f1a88ccb68ac11d74f78c7b95","user":{"login":"galderz","id":50187,"node_id":"MDQ6VXNlcjUwMTg3","avatar_url":"https://avatars0.githubusercontent.com/u/50187?v=4","gravatar_id":"","url":"https://api.github.com/users/galderz","html_url":"https://github.com/galderz","followers_url":"https://api.github.com/users/galderz/followers","following_url":"https://api.github.com/users/galderz/following{/other_user}","gists_url":"https://api.github.com/users/galderz/gists{/gist_id}","starred_url":"https://api.github.com/users/galderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galderz/subscriptions","organizations_url":"https://api.github.com/users/galderz/orgs","repos_url":"https://api.github.com/users/galderz/repos","events_url":"https://api.github.com/users/galderz/events{/privacy}","received_events_url":"https://api.github.com/users/galderz/received_events","type":"User","site_admin":false},"body":"Oh I see, the SSL errors are client side errors that can happen on startup. In this case, I'd make the `disconnect()` function clearer of what it does. So, I'd check with `f.existy(router)` when `disconnect()` is called and the log accordingly. It can be confusing for the log message to say `Disconnect transport` when you actually don't do any disconnection.","created_at":"2018-10-23T11:41:57Z","updated_at":"2018-10-23T11:41:57Z","html_url":"https://github.com/infinispan/js-client/pull/35#discussion_r227350594","pull_request_url":"https://api.github.com/repos/infinispan/js-client/pulls/35","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/comments/227350594"},"html":{"href":"https://github.com/infinispan/js-client/pull/35#discussion_r227350594"},"pull_request":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/35"}},"in_reply_to_id":224787381},"pull_request":{"url":"https://api.github.com/repos/infinispan/js-client/pulls/35","id":219673114,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjczMTE0","html_url":"https://github.com/infinispan/js-client/pull/35","diff_url":"https://github.com/infinispan/js-client/pull/35.diff","patch_url":"https://github.com/infinispan/js-client/pull/35.patch","issue_url":"https://api.github.com/repos/infinispan/js-client/issues/35","number":35,"state":"open","locked":false,"title":"HRJS-80 - Connection to not-configured cache fails without closing it","user":{"login":"andyuk1986","id":1311306,"node_id":"MDQ6VXNlcjEzMTEzMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1311306?v=4","gravatar_id":"","url":"https://api.github.com/users/andyuk1986","html_url":"https://github.com/andyuk1986","followers_url":"https://api.github.com/users/andyuk1986/followers","following_url":"https://api.github.com/users/andyuk1986/following{/other_user}","gists_url":"https://api.github.com/users/andyuk1986/gists{/gist_id}","starred_url":"https://api.github.com/users/andyuk1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyuk1986/subscriptions","organizations_url":"https://api.github.com/users/andyuk1986/orgs","repos_url":"https://api.github.com/users/andyuk1986/repos","events_url":"https://api.github.com/users/andyuk1986/events{/privacy}","received_events_url":"https://api.github.com/users/andyuk1986/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T11:40:24Z","updated_at":"2018-10-23T11:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1a47af22c6645ffb723515651437d09fab6459a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/js-client/pulls/35/commits","review_comments_url":"https://api.github.com/repos/infinispan/js-client/pulls/35/comments","review_comment_url":"https://api.github.com/repos/infinispan/js-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/js-client/issues/35/comments","statuses_url":"https://api.github.com/repos/infinispan/js-client/statuses/969a2c192359681089c607f22cda9e6734701184","head":{"label":"andyuk1986:HRJS-80","ref":"HRJS-80","sha":"969a2c192359681089c607f22cda9e6734701184","user":{"login":"andyuk1986","id":1311306,"node_id":"MDQ6VXNlcjEzMTEzMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1311306?v=4","gravatar_id":"","url":"https://api.github.com/users/andyuk1986","html_url":"https://github.com/andyuk1986","followers_url":"https://api.github.com/users/andyuk1986/followers","following_url":"https://api.github.com/users/andyuk1986/following{/other_user}","gists_url":"https://api.github.com/users/andyuk1986/gists{/gist_id}","starred_url":"https://api.github.com/users/andyuk1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyuk1986/subscriptions","organizations_url":"https://api.github.com/users/andyuk1986/orgs","repos_url":"https://api.github.com/users/andyuk1986/repos","events_url":"https://api.github.com/users/andyuk1986/events{/privacy}","received_events_url":"https://api.github.com/users/andyuk1986/received_events","type":"User","site_admin":false},"repo":{"id":53681786,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY4MTc4Ng==","name":"js-client","full_name":"andyuk1986/js-client","private":false,"owner":{"login":"andyuk1986","id":1311306,"node_id":"MDQ6VXNlcjEzMTEzMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1311306?v=4","gravatar_id":"","url":"https://api.github.com/users/andyuk1986","html_url":"https://github.com/andyuk1986","followers_url":"https://api.github.com/users/andyuk1986/followers","following_url":"https://api.github.com/users/andyuk1986/following{/other_user}","gists_url":"https://api.github.com/users/andyuk1986/gists{/gist_id}","starred_url":"https://api.github.com/users/andyuk1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyuk1986/subscriptions","organizations_url":"https://api.github.com/users/andyuk1986/orgs","repos_url":"https://api.github.com/users/andyuk1986/repos","events_url":"https://api.github.com/users/andyuk1986/events{/privacy}","received_events_url":"https://api.github.com/users/andyuk1986/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andyuk1986/js-client","description":"Javascript client for Infinispan, over the Hot Rod wire protocol","fork":true,"url":"https://api.github.com/repos/andyuk1986/js-client","forks_url":"https://api.github.com/repos/andyuk1986/js-client/forks","keys_url":"https://api.github.com/repos/andyuk1986/js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyuk1986/js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyuk1986/js-client/teams","hooks_url":"https://api.github.com/repos/andyuk1986/js-client/hooks","issue_events_url":"https://api.github.com/repos/andyuk1986/js-client/issues/events{/number}","events_url":"https://api.github.com/repos/andyuk1986/js-client/events","assignees_url":"https://api.github.com/repos/andyuk1986/js-client/assignees{/user}","branches_url":"https://api.github.com/repos/andyuk1986/js-client/branches{/branch}","tags_url":"https://api.github.com/repos/andyuk1986/js-client/tags","blobs_url":"https://api.github.com/repos/andyuk1986/js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyuk1986/js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyuk1986/js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyuk1986/js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyuk1986/js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/andyuk1986/js-client/languages","stargazers_url":"https://api.github.com/repos/andyuk1986/js-client/stargazers","contributors_url":"https://api.github.com/repos/andyuk1986/js-client/contributors","subscribers_url":"https://api.github.com/repos/andyuk1986/js-client/subscribers","subscription_url":"https://api.github.com/repos/andyuk1986/js-client/subscription","commits_url":"https://api.github.com/repos/andyuk1986/js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyuk1986/js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyuk1986/js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyuk1986/js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyuk1986/js-client/contents/{+path}","compare_url":"https://api.github.com/repos/andyuk1986/js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyuk1986/js-client/merges","archive_url":"https://api.github.com/repos/andyuk1986/js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyuk1986/js-client/downloads","issues_url":"https://api.github.com/repos/andyuk1986/js-client/issues{/number}","pulls_url":"https://api.github.com/repos/andyuk1986/js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/andyuk1986/js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/andyuk1986/js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyuk1986/js-client/labels{/name}","releases_url":"https://api.github.com/repos/andyuk1986/js-client/releases{/id}","deployments_url":"https://api.github.com/repos/andyuk1986/js-client/deployments","created_at":"2016-03-11T16:45:17Z","updated_at":"2018-09-19T11:39:12Z","pushed_at":"2018-10-12T23:50:54Z","git_url":"git://github.com/andyuk1986/js-client.git","ssh_url":"git@github.com:andyuk1986/js-client.git","clone_url":"https://github.com/andyuk1986/js-client.git","svn_url":"https://github.com/andyuk1986/js-client","homepage":null,"size":447,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"e9fe0d803d1cb116eb90953a8025708cc6d09810","user":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":47264708,"node_id":"MDEwOlJlcG9zaXRvcnk0NzI2NDcwOA==","name":"js-client","full_name":"infinispan/js-client","private":false,"owner":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infinispan/js-client","description":"Javascript client for Infinispan, over the Hot Rod wire protocol","fork":false,"url":"https://api.github.com/repos/infinispan/js-client","forks_url":"https://api.github.com/repos/infinispan/js-client/forks","keys_url":"https://api.github.com/repos/infinispan/js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/js-client/teams","hooks_url":"https://api.github.com/repos/infinispan/js-client/hooks","issue_events_url":"https://api.github.com/repos/infinispan/js-client/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/js-client/events","assignees_url":"https://api.github.com/repos/infinispan/js-client/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/js-client/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/js-client/tags","blobs_url":"https://api.github.com/repos/infinispan/js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/js-client/languages","stargazers_url":"https://api.github.com/repos/infinispan/js-client/stargazers","contributors_url":"https://api.github.com/repos/infinispan/js-client/contributors","subscribers_url":"https://api.github.com/repos/infinispan/js-client/subscribers","subscription_url":"https://api.github.com/repos/infinispan/js-client/subscription","commits_url":"https://api.github.com/repos/infinispan/js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/js-client/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/js-client/merges","archive_url":"https://api.github.com/repos/infinispan/js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/js-client/downloads","issues_url":"https://api.github.com/repos/infinispan/js-client/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/js-client/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/js-client/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/js-client/deployments","created_at":"2015-12-02T14:01:23Z","updated_at":"2018-09-18T15:29:47Z","pushed_at":"2018-10-12T23:50:55Z","git_url":"git://github.com/infinispan/js-client.git","ssh_url":"git@github.com:infinispan/js-client.git","clone_url":"https://github.com/infinispan/js-client.git","svn_url":"https://github.com/infinispan/js-client","homepage":null,"size":458,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/35"},"html":{"href":"https://github.com/infinispan/js-client/pull/35"},"issue":{"href":"https://api.github.com/repos/infinispan/js-client/issues/35"},"comments":{"href":"https://api.github.com/repos/infinispan/js-client/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/js-client/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/js-client/statuses/969a2c192359681089c607f22cda9e6734701184"}},"author_association":"CONTRIBUTOR"}} | {
"id": 47264708,
"name": "infinispan/js-client",
"url": "https://api.github.com/repos/infinispan/js-client"
} | {
"id": 50187,
"login": "galderz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50187?",
"url": "https://api.github.com/users/galderz"
} | {
"id": 458093,
"login": "infinispan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/458093?",
"url": "https://api.github.com/orgs/infinispan"
} | 2018-10-23T11:41:57 | 8465205174 | {"actor":{"display_login":"galderz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Talend/daikon/pulls/comments/215952438","pull_request_review_id":153333731,"id":215952438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk1MjQzOA==","diff_hunk":"@@ -144,6 +127,11 @@ private static boolean complies(String value, String pattern) {\n return true;\n }\n \n+ private static boolean wordComplies(String value, String pattern) {","path":"daikon-tql/daikon-tql-bean/src/main/java/org/talend/tql/bean/BeanPredicateVisitor.java","position":30,"original_position":30,"commit_id":"c675e43cf7c607a9882943f7267739aef68af904","original_commit_id":"c675e43cf7c607a9882943f7267739aef68af904","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid unused method parameters such as 'pattern'.](https://app.codacy.com/app/Talend/daikon/pullRequest?prid=2112710)","created_at":"2018-09-07T13:09:34Z","updated_at":"2018-09-07T13:09:34Z","html_url":"https://github.com/Talend/daikon/pull/392#discussion_r215952438","pull_request_url":"https://api.github.com/repos/Talend/daikon/pulls/392","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments/215952438"},"html":{"href":"https://github.com/Talend/daikon/pull/392#discussion_r215952438"},"pull_request":{"href":"https://api.github.com/repos/Talend/daikon/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/daikon/pulls/392","id":211764815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzY0ODE1","html_url":"https://github.com/Talend/daikon/pull/392","diff_url":"https://github.com/Talend/daikon/pull/392.diff","patch_url":"https://github.com/Talend/daikon/pull/392.patch","issue_url":"https://api.github.com/repos/Talend/daikon/issues/392","number":392,"state":"open","locked":false,"title":"feat(TDS-2681): add wordComplies operator to TQL to distinguish patte…","user":{"login":"gmzoughi","id":15381144,"node_id":"MDQ6VXNlcjE1MzgxMTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/15381144?v=4","gravatar_id":"","url":"https://api.github.com/users/gmzoughi","html_url":"https://github.com/gmzoughi","followers_url":"https://api.github.com/users/gmzoughi/followers","following_url":"https://api.github.com/users/gmzoughi/following{/other_user}","gists_url":"https://api.github.com/users/gmzoughi/gists{/gist_id}","starred_url":"https://api.github.com/users/gmzoughi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmzoughi/subscriptions","organizations_url":"https://api.github.com/users/gmzoughi/orgs","repos_url":"https://api.github.com/users/gmzoughi/repos","events_url":"https://api.github.com/users/gmzoughi/events{/privacy}","received_events_url":"https://api.github.com/users/gmzoughi/received_events","type":"User","site_admin":false},"body":"…rn types.\r\n\r\n**What is the problem this Pull Request is trying to solve?**\r\n \r\n**What is the chosen solution to this problem?**\r\n \r\n**Link to the JIRA issue**\r\n<!--e.g. https://jira.talendforge.org/browse/XXX -->\r\n \r\n**Please check if the Pull Request fulfills these requirements**\r\n- [ ] The PR commit message follows our [guidelines](../CONTRIBUTING.md)\r\n- [ ] Tests for the changes have been added (for bug fixes / features, coverage should be over 75% in the new code)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in JIRA), if any, are all linked or available in the Pull Request\r\n\r\n<!-- You can add more checkboxes here -->\r\n \r\n**[ ] This Pull Request introduces a breaking change**\r\n \r\n<!-- **Original Template** -->\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n","created_at":"2018-08-29T14:01:38Z","updated_at":"2018-09-07T13:09:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2548254cd45dea79438f95cf4ba88374a1299a12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":397848096,"node_id":"MDU6TGFiZWwzOTc4NDgwOTY=","url":"https://api.github.com/repos/Talend/daikon/labels/Merged%20build%20passed","name":"Merged build passed","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/daikon/pulls/392/commits","review_comments_url":"https://api.github.com/repos/Talend/daikon/pulls/392/comments","review_comment_url":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/daikon/issues/392/comments","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/c675e43cf7c607a9882943f7267739aef68af904","head":{"label":"Talend:gmzoughi/feat/TDS-2681","ref":"gmzoughi/feat/TDS-2681","sha":"c675e43cf7c607a9882943f7267739aef68af904","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI1NTQ5OQ==","name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2018-09-07T09:33:01Z","pushed_at":"2018-09-07T13:06:45Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":4524,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":31,"open_issues":4,"watchers":7,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"e0b8445bb7bc1744dafb380f3957030f778993ad","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":42255499,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI1NTQ5OQ==","name":"daikon","full_name":"Talend/daikon","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/daikon","description":"Commons back-end java classes shared by dataprep and components services (for now)","fork":false,"url":"https://api.github.com/repos/Talend/daikon","forks_url":"https://api.github.com/repos/Talend/daikon/forks","keys_url":"https://api.github.com/repos/Talend/daikon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/daikon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/daikon/teams","hooks_url":"https://api.github.com/repos/Talend/daikon/hooks","issue_events_url":"https://api.github.com/repos/Talend/daikon/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/daikon/events","assignees_url":"https://api.github.com/repos/Talend/daikon/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/daikon/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/daikon/tags","blobs_url":"https://api.github.com/repos/Talend/daikon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/daikon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/daikon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/daikon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/daikon/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/daikon/languages","stargazers_url":"https://api.github.com/repos/Talend/daikon/stargazers","contributors_url":"https://api.github.com/repos/Talend/daikon/contributors","subscribers_url":"https://api.github.com/repos/Talend/daikon/subscribers","subscription_url":"https://api.github.com/repos/Talend/daikon/subscription","commits_url":"https://api.github.com/repos/Talend/daikon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/daikon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/daikon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/daikon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/daikon/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/daikon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/daikon/merges","archive_url":"https://api.github.com/repos/Talend/daikon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/daikon/downloads","issues_url":"https://api.github.com/repos/Talend/daikon/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/daikon/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/daikon/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/daikon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/daikon/labels{/name}","releases_url":"https://api.github.com/repos/Talend/daikon/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/daikon/deployments","created_at":"2015-09-10T16:08:46Z","updated_at":"2018-09-07T09:33:01Z","pushed_at":"2018-09-07T13:06:45Z","git_url":"git://github.com/Talend/daikon.git","ssh_url":"git@github.com:Talend/daikon.git","clone_url":"https://github.com/Talend/daikon.git","svn_url":"https://github.com/Talend/daikon","homepage":null,"size":4524,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":31,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/daikon/pulls/392"},"html":{"href":"https://github.com/Talend/daikon/pull/392"},"issue":{"href":"https://api.github.com/repos/Talend/daikon/issues/392"},"comments":{"href":"https://api.github.com/repos/Talend/daikon/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/daikon/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/daikon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/daikon/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/daikon/statuses/c675e43cf7c607a9882943f7267739aef68af904"}},"author_association":"COLLABORATOR"}} | {
"id": 42255499,
"name": "Talend/daikon",
"url": "https://api.github.com/repos/Talend/daikon"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 459687,
"login": "Talend",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/459687?",
"url": "https://api.github.com/orgs/Talend"
} | 2018-09-07T13:09:34 | 8230499664 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/226558678","pull_request_review_id":166409917,"id":226558678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU1ODY3OA==","diff_hunk":"@@ -50,6 +55,32 @@ public void processRecord(ComputationContext context, String inputStreamName, Re\n String commandId = in.getCommandId();\n Blob blob = getBlob(in.getDataAsString());\n blob = sort(blob, commandId);\n+\n+ File blobFile = blob.getFile();\n+ try {\n+ BufferedReader br = new BufferedReader(new FileReader(blobFile));\n+ // Add header\n+ String header = in.getHeaderAsString();\n+ StringBuilder result = StringUtils.isNotEmpty(header) ? new StringBuilder(String.format(\"%s%n\", header))\n+ : new StringBuilder();","path":"nuxeo-core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/action/computation/SortBlob.java","position":26,"original_position":26,"commit_id":"eb1a8b0cc6089960f34382070fa944cbb95fd239","original_commit_id":"eb1a8b0cc6089960f34382070fa944cbb95fd239","user":{"login":"bdelbosc","id":589079,"node_id":"MDQ6VXNlcjU4OTA3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/589079?v=4","gravatar_id":"","url":"https://api.github.com/users/bdelbosc","html_url":"https://github.com/bdelbosc","followers_url":"https://api.github.com/users/bdelbosc/followers","following_url":"https://api.github.com/users/bdelbosc/following{/other_user}","gists_url":"https://api.github.com/users/bdelbosc/gists{/gist_id}","starred_url":"https://api.github.com/users/bdelbosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdelbosc/subscriptions","organizations_url":"https://api.github.com/users/bdelbosc/orgs","repos_url":"https://api.github.com/users/bdelbosc/repos","events_url":"https://api.github.com/users/bdelbosc/events{/privacy}","received_events_url":"https://api.github.com/users/bdelbosc/received_events","type":"User","site_admin":false},"body":"just create your stringbuilder and append the header if not empty like for the footer","created_at":"2018-10-19T07:45:51Z","updated_at":"2018-10-19T07:45:51Z","html_url":"https://github.com/nuxeo/nuxeo/pull/2453#discussion_r226558678","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/226558678"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/2453#discussion_r226558678"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453","id":224111422,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTExNDIy","html_url":"https://github.com/nuxeo/nuxeo/pull/2453","diff_url":"https://github.com/nuxeo/nuxeo/pull/2453.diff","patch_url":"https://github.com/nuxeo/nuxeo/pull/2453.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/2453","number":2453,"state":"open","locked":false,"title":"fix-NXP-25980-csv-header","user":{"login":"nuxeojenkins","id":925456,"node_id":"MDQ6VXNlcjkyNTQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/925456?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeojenkins","html_url":"https://github.com/nuxeojenkins","followers_url":"https://api.github.com/users/nuxeojenkins/followers","following_url":"https://api.github.com/users/nuxeojenkins/following{/other_user}","gists_url":"https://api.github.com/users/nuxeojenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeojenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeojenkins/subscriptions","organizations_url":"https://api.github.com/users/nuxeojenkins/orgs","repos_url":"https://api.github.com/users/nuxeojenkins/repos","events_url":"https://api.github.com/users/nuxeojenkins/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeojenkins/received_events","type":"User","site_admin":false},"body":"PR created from https://qa.nuxeo.org/jenkins/job/TestAndPush/job/ondemand-testandpush-fdavid-master/468/","created_at":"2018-10-18T21:54:48Z","updated_at":"2018-10-19T07:45:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f8d19fc0defab9d323dc4d96f31aad593813959","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/2453/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/eb1a8b0cc6089960f34382070fa944cbb95fd239","head":{"label":"nuxeo:fix-NXP-25980-csv-header","ref":"fix-NXP-25980-csv-header","sha":"eb1a8b0cc6089960f34382070fa944cbb95fd239","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MTAx","name":"nuxeo","full_name":"nuxeo/nuxeo","private":false,"owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2018-10-18T16:45:15Z","pushed_at":"2018-10-19T01:15:41Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":235696,"stargazers_count":249,"watchers_count":249,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":163,"open_issues":23,"watchers":249,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"192a297f95494fa9acb39026daf15302f2b0dd9e","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg4MTAx","name":"nuxeo","full_name":"nuxeo/nuxeo","private":false,"owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2018-10-18T16:45:15Z","pushed_at":"2018-10-19T01:15:41Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":235696,"stargazers_count":249,"watchers_count":249,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":163,"open_issues":23,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/2453"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/2453"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/2453/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/2453/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo/statuses/eb1a8b0cc6089960f34382070fa944cbb95fd239"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2988101,
"name": "nuxeo/nuxeo",
"url": "https://api.github.com/repos/nuxeo/nuxeo"
} | {
"id": 589079,
"login": "bdelbosc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/589079?",
"url": "https://api.github.com/users/bdelbosc"
} | {
"id": 460607,
"login": "nuxeo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/460607?",
"url": "https://api.github.com/orgs/nuxeo"
} | 2018-10-19T07:45:51 | 8447354581 | {"actor":{"display_login":"bdelbosc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/237936170","pull_request_review_id":180364482,"id":237936170,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzkzNjE3MA==","diff_hunk":"@@ -0,0 +1,135 @@\n+import { SfdxProject } from '@salesforce/core';\n+import { getWorkspaceOrgType, OrgType } from '../context';\n+import { nls } from '../messages';\n+import { notificationService } from '../notifications';\n+import { sfdxCoreSettings } from '../settings';\n+\n+import * as vscode from 'vscode';\n+\n+interface SfdxProjectJson {\n+ packageDirectories: [PackageDirectory];\n+}\n+\n+interface PackageDirectory {\n+ path: string;\n+ default?: boolean;\n+}\n+\n+enum FileEventType {\n+ Create,\n+ Change,\n+ Delete\n+}\n+\n+const WAIT_TIME_IN_MS = 1000;\n+\n+export async function registerPushOrDeployOnSave() {\n+ if (sfdxCoreSettings.getPushOrDeployOnSaveEnabled()) {\n+ const sourceFileWatcher = await createSourceFileWatcher();\n+ if (sourceFileWatcher) {\n+ setupFileCreateListener(sourceFileWatcher);\n+ setupFileChangeListener(sourceFileWatcher);\n+ setupFileDeleteListener(sourceFileWatcher);\n+ }\n+ }\n+}\n+\n+function setupFileCreateListener(sourceFileWatcher: vscode.FileSystemWatcher) {\n+ const createdFiles: vscode.Uri[] = [];\n+ let createdFilesTimeout: NodeJS.Timer;\n+ sourceFileWatcher.onDidCreate(async uri => {\n+ createdFiles.push(uri);\n+ clearTimeout(createdFilesTimeout);\n+\n+ createdFilesTimeout = setTimeout(async () => {\n+ await pushOrDeploy(FileEventType.Create, createdFiles);\n+ }, WAIT_TIME_IN_MS);\n+ });\n+}\n+\n+function setupFileChangeListener(sourceFileWatcher: vscode.FileSystemWatcher) {\n+ sourceFileWatcher.onDidChange(async uri => {\n+ await pushOrDeploy(FileEventType.Change, [uri]);\n+ });\n+}\n+\n+function setupFileDeleteListener(sourceFileWatcher: vscode.FileSystemWatcher) {\n+ let deletedFilesTimeout: NodeJS.Timer;\n+ sourceFileWatcher.onDidDelete(async uri => {\n+ clearTimeout(deletedFilesTimeout);\n+\n+ deletedFilesTimeout = setTimeout(async () => {\n+ await pushOrDeploy(FileEventType.Delete);\n+ }, WAIT_TIME_IN_MS);\n+ });\n+}\n+\n+async function pushOrDeploy(\n+ fileEventType: FileEventType,\n+ filesToDeploy?: vscode.Uri[]\n+): Promise<void> {\n+ try {\n+ const orgType = await getWorkspaceOrgType();\n+ if (orgType === OrgType.SourceTracked) {\n+ vscode.commands.executeCommand('sfdx.force.source.push');\n+ }\n+\n+ if (orgType === OrgType.NonSourceTracked) {\n+ if (fileEventType === FileEventType.Create) {\n+ vscode.commands.executeCommand(\n+ 'sfdx.force.source.deploy.multiple.paths',\n+ filesToDeploy!.slice(0)\n+ );\n+ } else if (fileEventType === FileEventType.Change) {\n+ vscode.commands.executeCommand(\n+ 'sfdx.force.source.deploy',\n+ filesToDeploy![0]\n+ );\n+ } else if (fileEventType === FileEventType.Delete) {\n+ notificationService.showErrorMessage(\n+ nls.localize('error_change_not_deleted_text')\n+ );\n+ }\n+ }\n+ } catch (e) {\n+ if (e.name === 'NamedOrgNotFound') {\n+ notificationService.showErrorMessage(\n+ nls.localize('error_fetching_auth_info_text')\n+ );\n+ } else if (e.name === 'NoDefaultusernameSet') {\n+ // Do nothing.\n+ } else {\n+ notificationService.showErrorMessage(e);\n+ }\n+ } finally {\n+ if (filesToDeploy) {\n+ emptyCollectedFiles(filesToDeploy);\n+ }\n+ }\n+}\n+\n+function emptyCollectedFiles(uris: vscode.Uri[]) {\n+ uris.length = 0;\n+}\n+\n+async function createSourceFileWatcher(): Promise<vscode.FileSystemWatcher | null> {\n+ if (\n+ vscode.workspace.workspaceFolders &&\n+ vscode.workspace.workspaceFolders.length > 0\n+ ) {\n+ const sfdxProjectPath = vscode.workspace.workspaceFolders[0].uri.fsPath;\n+ const sfdxProject = await SfdxProject.resolve(sfdxProjectPath);\n+ const sfdxProjectJson = (await sfdxProject.resolveProjectConfig()) as SfdxProjectJson;\n+ const packageDirectoryPaths = sfdxProjectJson.packageDirectories.map(","path":"packages/salesforcedx-vscode-core/src/settings/pushOrDeployOnSave.ts","position":123,"original_position":123,"commit_id":"4fef01788d44e4dbbbef8e12235d1f9ff5843669","original_commit_id":"4fef01788d44e4dbbbef8e12235d1f9ff5843669","user":{"login":"allileong","id":1639375,"node_id":"MDQ6VXNlcjE2MzkzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1639375?v=4","gravatar_id":"","url":"https://api.github.com/users/allileong","html_url":"https://github.com/allileong","followers_url":"https://api.github.com/users/allileong/followers","following_url":"https://api.github.com/users/allileong/following{/other_user}","gists_url":"https://api.github.com/users/allileong/gists{/gist_id}","starred_url":"https://api.github.com/users/allileong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allileong/subscriptions","organizations_url":"https://api.github.com/users/allileong/orgs","repos_url":"https://api.github.com/users/allileong/repos","events_url":"https://api.github.com/users/allileong/events{/privacy}","received_events_url":"https://api.github.com/users/allileong/received_events","type":"User","site_admin":false},"body":"I am using the @salesforce/core api to fetch the packageDirectories info from the sfdx-project.json in the workspace. I then create a fileWatcher to detect any creations/changes/deletions made to files inside of the packageDirectories. This approach is not able to differentiate between which files are and aren't source. ","created_at":"2018-11-30T17:15:36Z","updated_at":"2018-11-30T17:15:37Z","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783#discussion_r237936170","pull_request_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/237936170"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783#discussion_r237936170"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783","id":235056870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDU2ODcw","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783","diff_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783.diff","patch_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783.patch","issue_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/783","number":783,"state":"open","locked":false,"title":"[WIP] Easy Deploy on Save","user":{"login":"allileong","id":1639375,"node_id":"MDQ6VXNlcjE2MzkzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1639375?v=4","gravatar_id":"","url":"https://api.github.com/users/allileong","html_url":"https://github.com/allileong","followers_url":"https://api.github.com/users/allileong/followers","following_url":"https://api.github.com/users/allileong/following{/other_user}","gists_url":"https://api.github.com/users/allileong/gists{/gist_id}","starred_url":"https://api.github.com/users/allileong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allileong/subscriptions","organizations_url":"https://api.github.com/users/allileong/orgs","repos_url":"https://api.github.com/users/allileong/repos","events_url":"https://api.github.com/users/allileong/events{/privacy}","received_events_url":"https://api.github.com/users/allileong/received_events","type":"User","site_admin":false},"body":"I'd like to get feedback on my implementation approach for Easy Deploy on Save in case my current approach requires major changes.\r\n\r\n### What does this PR do?\r\n* Adds a workspace configuration called `salesforcedx-vscode-core.push-or-deploy-on-save.enabled` that is set to `false` by default\r\n* Works in both scratch orgs and non-scratch orgs\r\n\r\nStill left to do:\r\n* Update @salesforce/core package to the latest version (in this PR it has been bumped from 0.18.2 to 0.23.1, but the latest version available in npm is 0.24.8)\r\n* Update typescript in all repo packages\r\n* Add testing\r\n* Test on OS's other than Mac\r\n* Test out the alternative way to batch created/deleted files for a single deploy/push; Right now, whenever I detect a create/delete, I extend the wait time by 1 second. When the wait time of 1 second has passed without detecting any additional creates/deletes, then I initiate a single deploy/push\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000005wp9BIAQ/view","created_at":"2018-11-30T17:11:52Z","updated_at":"2018-11-30T17:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b7a7ede95e8de3d9c17606b8f5b3b7f9d46b35","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/783/comments","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/4fef01788d44e4dbbbef8e12235d1f9ff5843669","head":{"label":"forcedotcom:alli/easyDeploy","ref":"alli/easyDeploy","sha":"4fef01788d44e4dbbbef8e12235d1f9ff5843669","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","private":false,"owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-11-30T15:46:20Z","pushed_at":"2018-11-30T17:11:52Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":148559,"stargazers_count":251,"watchers_count":251,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":54,"open_issues":94,"watchers":251,"default_branch":"develop"}},"base":{"label":"forcedotcom:develop","ref":"develop","sha":"44e4858eaabe4ecd7d8a1f749255e7e17e8c3a9f","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","private":false,"owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-11-30T15:46:20Z","pushed_at":"2018-11-30T17:11:52Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":148559,"stargazers_count":251,"watchers_count":251,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":54,"open_issues":94,"watchers":251,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/783"},"issue":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/783"},"comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/4fef01788d44e4dbbbef8e12235d1f9ff5843669"}},"author_association":"CONTRIBUTOR"}} | {
"id": 95021029,
"name": "forcedotcom/salesforcedx-vscode",
"url": "https://api.github.com/repos/forcedotcom/salesforcedx-vscode"
} | {
"id": 1639375,
"login": "allileong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1639375?",
"url": "https://api.github.com/users/allileong"
} | {
"id": 464563,
"login": "forcedotcom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/464563?",
"url": "https://api.github.com/orgs/forcedotcom"
} | 2018-11-30T17:15:36 | 8677606801 | {"actor":{"display_login":"allileong"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/236358385","pull_request_review_id":178417161,"id":236358385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjM1ODM4NQ==","diff_hunk":"@@ -51,7 +51,11 @@\n \"shx rm -rf node_modules && cd out && node ../../../scripts/clean-all-but-jar.js && shx rm -rf coverage && shx rm -rf .nyc_output\",\n \"postinstall\": \"node ./node_modules/vscode/bin/install\",\n \"test\": \"node ../../scripts/run-test-with-top-level-extensions\",\n- \"test:unit\": \"node ../../scripts/run-test-with-top-level-extensions\"\n+ \"test:insiders\":\n+ \"cross-env CODE_VERSION=insiders node ../../scripts/run-test-with-top-level-extensions\",\n+ \"test:unit\": \"node ../../scripts/run-test-with-top-level-extensions\",\n+ \"test:unit-insiders\":","path":"packages/salesforcedx-vscode-apex/package.json","position":8,"original_position":8,"commit_id":"e6a7439ae1fc5fefe7f70e7cd4c0536656dae5c0","original_commit_id":"e6a7439ae1fc5fefe7f70e7cd4c0536656dae5c0","user":{"login":"lcampos","id":1041842,"node_id":"MDQ6VXNlcjEwNDE4NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041842?v=4","gravatar_id":"","url":"https://api.github.com/users/lcampos","html_url":"https://github.com/lcampos","followers_url":"https://api.github.com/users/lcampos/followers","following_url":"https://api.github.com/users/lcampos/following{/other_user}","gists_url":"https://api.github.com/users/lcampos/gists{/gist_id}","starred_url":"https://api.github.com/users/lcampos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcampos/subscriptions","organizations_url":"https://api.github.com/users/lcampos/orgs","repos_url":"https://api.github.com/users/lcampos/repos","events_url":"https://api.github.com/users/lcampos/events{/privacy}","received_events_url":"https://api.github.com/users/lcampos/received_events","type":"User","site_admin":false},"body":"This is missing `cross-env` in the script","created_at":"2018-11-26T17:46:21Z","updated_at":"2018-11-26T17:46:21Z","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770#discussion_r236358385","pull_request_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/236358385"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770#discussion_r236358385"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770","id":232821029,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODIxMDI5","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770","diff_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770.diff","patch_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770.patch","issue_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/770","number":770,"state":"open","locked":false,"title":"Create an autobuild that runs against the insiders' build","user":{"login":"AnanyaJha","id":21326913,"node_id":"MDQ6VXNlcjIxMzI2OTEz","avatar_url":"https://avatars3.githubusercontent.com/u/21326913?v=4","gravatar_id":"","url":"https://api.github.com/users/AnanyaJha","html_url":"https://github.com/AnanyaJha","followers_url":"https://api.github.com/users/AnanyaJha/followers","following_url":"https://api.github.com/users/AnanyaJha/following{/other_user}","gists_url":"https://api.github.com/users/AnanyaJha/gists{/gist_id}","starred_url":"https://api.github.com/users/AnanyaJha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnanyaJha/subscriptions","organizations_url":"https://api.github.com/users/AnanyaJha/orgs","repos_url":"https://api.github.com/users/AnanyaJha/repos","events_url":"https://api.github.com/users/AnanyaJha/events{/privacy}","received_events_url":"https://api.github.com/users/AnanyaJha/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThis pr updates our AppVeyor configuration and `package.json`s to run tests in VSCode and VSCode Insiders concurrently.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n@W-5411499@","created_at":"2018-11-21T23:16:16Z","updated_at":"2018-11-26T17:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34be72f8900c9d01f4e873d6e18afd1f82652ec3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"allileong","id":1639375,"node_id":"MDQ6VXNlcjE2MzkzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1639375?v=4","gravatar_id":"","url":"https://api.github.com/users/allileong","html_url":"https://github.com/allileong","followers_url":"https://api.github.com/users/allileong/followers","following_url":"https://api.github.com/users/allileong/following{/other_user}","gists_url":"https://api.github.com/users/allileong/gists{/gist_id}","starred_url":"https://api.github.com/users/allileong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allileong/subscriptions","organizations_url":"https://api.github.com/users/allileong/orgs","repos_url":"https://api.github.com/users/allileong/repos","events_url":"https://api.github.com/users/allileong/events{/privacy}","received_events_url":"https://api.github.com/users/allileong/received_events","type":"User","site_admin":false},{"login":"praksb","id":10749920,"node_id":"MDQ6VXNlcjEwNzQ5OTIw","avatar_url":"https://avatars1.githubusercontent.com/u/10749920?v=4","gravatar_id":"","url":"https://api.github.com/users/praksb","html_url":"https://github.com/praksb","followers_url":"https://api.github.com/users/praksb/followers","following_url":"https://api.github.com/users/praksb/following{/other_user}","gists_url":"https://api.github.com/users/praksb/gists{/gist_id}","starred_url":"https://api.github.com/users/praksb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praksb/subscriptions","organizations_url":"https://api.github.com/users/praksb/orgs","repos_url":"https://api.github.com/users/praksb/repos","events_url":"https://api.github.com/users/praksb/events{/privacy}","received_events_url":"https://api.github.com/users/praksb/received_events","type":"User","site_admin":false},{"login":"JimSuplizio","id":13556087,"node_id":"MDQ6VXNlcjEzNTU2MDg3","avatar_url":"https://avatars3.githubusercontent.com/u/13556087?v=4","gravatar_id":"","url":"https://api.github.com/users/JimSuplizio","html_url":"https://github.com/JimSuplizio","followers_url":"https://api.github.com/users/JimSuplizio/followers","following_url":"https://api.github.com/users/JimSuplizio/following{/other_user}","gists_url":"https://api.github.com/users/JimSuplizio/gists{/gist_id}","starred_url":"https://api.github.com/users/JimSuplizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimSuplizio/subscriptions","organizations_url":"https://api.github.com/users/JimSuplizio/orgs","repos_url":"https://api.github.com/users/JimSuplizio/repos","events_url":"https://api.github.com/users/JimSuplizio/events{/privacy}","received_events_url":"https://api.github.com/users/JimSuplizio/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/770/comments","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/e6a7439ae1fc5fefe7f70e7cd4c0536656dae5c0","head":{"label":"forcedotcom:ajha/test-with-insiders","ref":"ajha/test-with-insiders","sha":"e6a7439ae1fc5fefe7f70e7cd4c0536656dae5c0","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","private":false,"owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-11-26T16:18:50Z","pushed_at":"2018-11-26T17:32:03Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":148513,"stargazers_count":245,"watchers_count":245,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":50,"open_issues":92,"watchers":245,"default_branch":"develop"}},"base":{"label":"forcedotcom:develop","ref":"develop","sha":"5e6c90f09c8a5187fffae062b40ecb09ebb7f6a6","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","private":false,"owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-11-26T16:18:50Z","pushed_at":"2018-11-26T17:32:03Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":148513,"stargazers_count":245,"watchers_count":245,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":50,"open_issues":92,"watchers":245,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/770"},"issue":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/770"},"comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/770/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/770/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/e6a7439ae1fc5fefe7f70e7cd4c0536656dae5c0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 95021029,
"name": "forcedotcom/salesforcedx-vscode",
"url": "https://api.github.com/repos/forcedotcom/salesforcedx-vscode"
} | {
"id": 1041842,
"login": "lcampos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1041842?",
"url": "https://api.github.com/users/lcampos"
} | {
"id": 464563,
"login": "forcedotcom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/464563?",
"url": "https://api.github.com/orgs/forcedotcom"
} | 2018-11-26T17:46:21 | 8648890537 | {"actor":{"display_login":"lcampos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/191247959","pull_request_review_id":123783396,"id":191247959,"diff_hunk":"@@ -353,6 +353,16 @@ class NDB_Menu_Filter extends NDB_Menu\n if (isset($_REQUEST['keyword'])) {\n // It was included in the request, so save it.\n $key = $_REQUEST['keyword'];\n+ // Check if multiple keyword search\n+ if ($_REQUEST['test_name'] == 'datadict'","path":"php/libraries/NDB_Menu_Filter.class.inc","position":5,"original_position":5,"commit_id":"bfdc5291a7fb99aefadad92ee7f2320d9163d3bf","original_commit_id":"bfdc5291a7fb99aefadad92ee7f2320d9163d3bf","user":{"login":"intralizee","id":16293415,"avatar_url":"https://avatars3.githubusercontent.com/u/16293415?v=4","gravatar_id":"","url":"https://api.github.com/users/intralizee","html_url":"https://github.com/intralizee","followers_url":"https://api.github.com/users/intralizee/followers","following_url":"https://api.github.com/users/intralizee/following{/other_user}","gists_url":"https://api.github.com/users/intralizee/gists{/gist_id}","starred_url":"https://api.github.com/users/intralizee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intralizee/subscriptions","organizations_url":"https://api.github.com/users/intralizee/orgs","repos_url":"https://api.github.com/users/intralizee/repos","events_url":"https://api.github.com/users/intralizee/events{/privacy}","received_events_url":"https://api.github.com/users/intralizee/received_events","type":"User","site_admin":false},"body":"Awesome it makes total sense to do that! Will do.","created_at":"2018-05-28T17:11:58Z","updated_at":"2018-05-28T17:11:58Z","html_url":"https://github.com/aces/Loris/pull/3685#discussion_r191247959","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/3685","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/191247959"},"html":{"href":"https://github.com/aces/Loris/pull/3685#discussion_r191247959"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/3685"}},"in_reply_to_id":191210880},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/3685","id":190023336,"html_url":"https://github.com/aces/Loris/pull/3685","diff_url":"https://github.com/aces/Loris/pull/3685.diff","patch_url":"https://github.com/aces/Loris/pull/3685.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/3685","number":3685,"state":"open","locked":false,"title":"[datadict] Search keyword filter will now return rows for multiple words","user":{"login":"intralizee","id":16293415,"avatar_url":"https://avatars3.githubusercontent.com/u/16293415?v=4","gravatar_id":"","url":"https://api.github.com/users/intralizee","html_url":"https://github.com/intralizee","followers_url":"https://api.github.com/users/intralizee/followers","following_url":"https://api.github.com/users/intralizee/following{/other_user}","gists_url":"https://api.github.com/users/intralizee/gists{/gist_id}","starred_url":"https://api.github.com/users/intralizee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intralizee/subscriptions","organizations_url":"https://api.github.com/users/intralizee/orgs","repos_url":"https://api.github.com/users/intralizee/repos","events_url":"https://api.github.com/users/intralizee/events{/privacy}","received_events_url":"https://api.github.com/users/intralizee/received_events","type":"User","site_admin":false},"body":"This pull request `fixes filtering when searching with multiple words for keywords. Before no results were returned and now results are returned. Also fixes another bug where description column was never searched.`. \r\n\r\nInside NDB_Menu_Filter.class.inc `I added a case for when the keyword variable has multiple words or text and used REGEXP for the mysql query`.\r\n\r\nSee also: `Bug #12910`","created_at":"2018-05-23T15:48:57Z","updated_at":"2018-05-28T17:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a892f4baef8920940e4d3e2551e6f99844409fc","assignee":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"assignees":[{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},{"login":"johnsaigle","id":4022790,"avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152305414,"url":"https://api.github.com/repos/aces/Loris/labels/Bug%20Fix","name":"Bug Fix","color":"f7c6c7","default":false},{"id":708895841,"url":"https://api.github.com/repos/aces/Loris/labels/[branch]%20bugfix","name":"[branch] bugfix","color":"cc9966","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aces/Loris/pulls/3685/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/3685/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/3685/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/bfdc5291a7fb99aefadad92ee7f2320d9163d3bf","head":{"label":"intralizee:datadict_search_keyword_multiple_words","ref":"datadict_search_keyword_multiple_words","sha":"bfdc5291a7fb99aefadad92ee7f2320d9163d3bf","user":{"login":"intralizee","id":16293415,"avatar_url":"https://avatars3.githubusercontent.com/u/16293415?v=4","gravatar_id":"","url":"https://api.github.com/users/intralizee","html_url":"https://github.com/intralizee","followers_url":"https://api.github.com/users/intralizee/followers","following_url":"https://api.github.com/users/intralizee/following{/other_user}","gists_url":"https://api.github.com/users/intralizee/gists{/gist_id}","starred_url":"https://api.github.com/users/intralizee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intralizee/subscriptions","organizations_url":"https://api.github.com/users/intralizee/orgs","repos_url":"https://api.github.com/users/intralizee/repos","events_url":"https://api.github.com/users/intralizee/events{/privacy}","received_events_url":"https://api.github.com/users/intralizee/received_events","type":"User","site_admin":false},"repo":{"id":130723427,"name":"Loris","full_name":"intralizee/Loris","owner":{"login":"intralizee","id":16293415,"avatar_url":"https://avatars3.githubusercontent.com/u/16293415?v=4","gravatar_id":"","url":"https://api.github.com/users/intralizee","html_url":"https://github.com/intralizee","followers_url":"https://api.github.com/users/intralizee/followers","following_url":"https://api.github.com/users/intralizee/following{/other_user}","gists_url":"https://api.github.com/users/intralizee/gists{/gist_id}","starred_url":"https://api.github.com/users/intralizee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intralizee/subscriptions","organizations_url":"https://api.github.com/users/intralizee/orgs","repos_url":"https://api.github.com/users/intralizee/repos","events_url":"https://api.github.com/users/intralizee/events{/privacy}","received_events_url":"https://api.github.com/users/intralizee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/intralizee/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/intralizee/Loris","forks_url":"https://api.github.com/repos/intralizee/Loris/forks","keys_url":"https://api.github.com/repos/intralizee/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intralizee/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intralizee/Loris/teams","hooks_url":"https://api.github.com/repos/intralizee/Loris/hooks","issue_events_url":"https://api.github.com/repos/intralizee/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/intralizee/Loris/events","assignees_url":"https://api.github.com/repos/intralizee/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/intralizee/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/intralizee/Loris/tags","blobs_url":"https://api.github.com/repos/intralizee/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intralizee/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intralizee/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/intralizee/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intralizee/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/intralizee/Loris/languages","stargazers_url":"https://api.github.com/repos/intralizee/Loris/stargazers","contributors_url":"https://api.github.com/repos/intralizee/Loris/contributors","subscribers_url":"https://api.github.com/repos/intralizee/Loris/subscribers","subscription_url":"https://api.github.com/repos/intralizee/Loris/subscription","commits_url":"https://api.github.com/repos/intralizee/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/intralizee/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/intralizee/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/intralizee/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/intralizee/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/intralizee/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intralizee/Loris/merges","archive_url":"https://api.github.com/repos/intralizee/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intralizee/Loris/downloads","issues_url":"https://api.github.com/repos/intralizee/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/intralizee/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/intralizee/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/intralizee/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intralizee/Loris/labels{/name}","releases_url":"https://api.github.com/repos/intralizee/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/intralizee/Loris/deployments","created_at":"2018-04-23T16:08:30Z","updated_at":"2018-04-23T18:35:57Z","pushed_at":"2018-05-28T15:57:44Z","git_url":"git://github.com/intralizee/Loris.git","ssh_url":"git@github.com:intralizee/Loris.git","clone_url":"https://github.com/intralizee/Loris.git","svn_url":"https://github.com/intralizee/Loris","homepage":"","size":75643,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"minor"}},"base":{"label":"aces:bugfix","ref":"bugfix","sha":"7aa5cc2c3c58be9bd469ab1a236e54f12295f9a8","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2018-05-28T14:38:23Z","pushed_at":"2018-05-28T15:57:45Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":75956,"stargazers_count":61,"watchers_count":61,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":91,"open_issues":69,"watchers":61,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/3685"},"html":{"href":"https://github.com/aces/Loris/pull/3685"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/3685"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/3685/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/3685/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/3685/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/bfdc5291a7fb99aefadad92ee7f2320d9163d3bf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1125630,
"name": "aces/Loris",
"url": "https://api.github.com/repos/aces/Loris"
} | {
"id": 16293415,
"login": "intralizee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16293415?",
"url": "https://api.github.com/users/intralizee"
} | {
"id": 472868,
"login": "aces",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/472868?",
"url": "https://api.github.com/orgs/aces"
} | 2018-05-28T17:11:58 | 7739721939 | {"actor":{"display_login":"intralizee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/172601298","pull_request_review_id":101646165,"id":172601298,"diff_hunk":"@@ -0,0 +1,247 @@\n+<?php\n+/**\n+ * This script is written for a one time use only to normalise the consent feature of candidate parameters. \n+ * \n+ * New normalised tables will be populated with existing data from `participant_status` and `consent_info_history`.\n+ * \n+ * A SQL file is exported to path: loris_root/SQL/Cleanup_patches/delete_old_consent_tables.sql\n+ * after running this script. Source this file to delete the now deprecated tables and columns.\n+ * \n+ * affected tables:\n+ * - participant_status\n+ * - consent_info_history\n+ * - consent\n+ * - candidate_consent_rel\n+ * - candidate_consent_history\n+ * \n+ * PHP Version 7\n+ * \n+ * @category Main \n+ * @package Loris\n+ * @author Zaliqa Rosli <zaliqa.rosli@mcin.ca>\n+ * @license Loris license\n+ * @link https://github.com/aces/Loris\n+ */\n+\n+require_once 'generic_includes.php';\n+\n+$config = NDB_Config::singleton();\n+$db =& Database::singleton();\n+\n+// Get consent details from Config.xml\n+$consentConfig = $config->getSettingFromXML('ConsentModule');\n+$useConsent = $consentConfig['useConsent'];\n+$consents = $consentConfig['Consent'];\n+\n+///////////////////////////////////////\n+// VALIDATE EXISTING CONSENT DETAILS //\n+///////////////////////////////////////\n+\n+$errors = [];\n+// Check for when consent columns exist in participant_status but not in Config.xml\n+$columnQuery = 'SELECT Column_name FROM Information_schema.columns WHERE\n+ Column_name LIKE \"%consent%\" AND Table_name LIKE \"participant_status\"';","path":"tools/Normalise_Consent_Data.php","position":43,"original_position":43,"commit_id":"5faf5f02feb3cf34d3cb91caad4df938347dc117","original_commit_id":"5faf5f02feb3cf34d3cb91caad4df938347dc117","user":{"login":"zaliqarosli","id":17415878,"avatar_url":"https://avatars3.githubusercontent.com/u/17415878?v=4","gravatar_id":"","url":"https://api.github.com/users/zaliqarosli","html_url":"https://github.com/zaliqarosli","followers_url":"https://api.github.com/users/zaliqarosli/followers","following_url":"https://api.github.com/users/zaliqarosli/following{/other_user}","gists_url":"https://api.github.com/users/zaliqarosli/gists{/gist_id}","starred_url":"https://api.github.com/users/zaliqarosli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaliqarosli/subscriptions","organizations_url":"https://api.github.com/users/zaliqarosli/orgs","repos_url":"https://api.github.com/users/zaliqarosli/repos","events_url":"https://api.github.com/users/zaliqarosli/events{/privacy}","received_events_url":"https://api.github.com/users/zaliqarosli/received_events","type":"User","site_admin":false},"body":"from what i've seen on CCNA and IBIS, yes. it's the only naming \"standard\" i have found","created_at":"2018-03-06T17:45:01Z","updated_at":"2018-03-06T17:45:01Z","html_url":"https://github.com/aces/Loris/pull/3532#discussion_r172601298","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/3532","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/172601298"},"html":{"href":"https://github.com/aces/Loris/pull/3532#discussion_r172601298"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/3532"}},"in_reply_to_id":172204771},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/3532","id":172631042,"html_url":"https://github.com/aces/Loris/pull/3532","diff_url":"https://github.com/aces/Loris/pull/3532.diff","patch_url":"https://github.com/aces/Loris/pull/3532.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/3532","number":3532,"state":"open","locked":false,"title":"[Candidate_parameters, Core] Normalizing Consent SQL","user":{"login":"zaliqarosli","id":17415878,"avatar_url":"https://avatars3.githubusercontent.com/u/17415878?v=4","gravatar_id":"","url":"https://api.github.com/users/zaliqarosli","html_url":"https://github.com/zaliqarosli","followers_url":"https://api.github.com/users/zaliqarosli/followers","following_url":"https://api.github.com/users/zaliqarosli/following{/other_user}","gists_url":"https://api.github.com/users/zaliqarosli/gists{/gist_id}","starred_url":"https://api.github.com/users/zaliqarosli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaliqarosli/subscriptions","organizations_url":"https://api.github.com/users/zaliqarosli/orgs","repos_url":"https://api.github.com/users/zaliqarosli/repos","events_url":"https://api.github.com/users/zaliqarosli/events{/privacy}","received_events_url":"https://api.github.com/users/zaliqarosli/received_events","type":"User","site_admin":false},"body":"New, smaller PR for SQL changes of https://github.com/aces/Loris/pull/3504\r\n\r\n- [x] new normalized tables\r\n\r\n- [x] add to Config tables\r\n\r\n- [x] data import script\r\n\r\n- [ ] waiting on Rida's PR to add new `/SQL/Cleanup_patches` directory","created_at":"2018-03-02T23:39:45Z","updated_at":"2018-03-06T17:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10aa0c26f78b3273abdc2a599fb01e34b7818e67","assignee":null,"assignees":[],"requested_reviewers":[{"login":"HenriRabalais","id":7550451,"avatar_url":"https://avatars3.githubusercontent.com/u/7550451?v=4","gravatar_id":"","url":"https://api.github.com/users/HenriRabalais","html_url":"https://github.com/HenriRabalais","followers_url":"https://api.github.com/users/HenriRabalais/followers","following_url":"https://api.github.com/users/HenriRabalais/following{/other_user}","gists_url":"https://api.github.com/users/HenriRabalais/gists{/gist_id}","starred_url":"https://api.github.com/users/HenriRabalais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenriRabalais/subscriptions","organizations_url":"https://api.github.com/users/HenriRabalais/orgs","repos_url":"https://api.github.com/users/HenriRabalais/repos","events_url":"https://api.github.com/users/HenriRabalais/events{/privacy}","received_events_url":"https://api.github.com/users/HenriRabalais/received_events","type":"User","site_admin":false},{"login":"ridz1208","id":15268287,"avatar_url":"https://avatars3.githubusercontent.com/u/15268287?v=4","gravatar_id":"","url":"https://api.github.com/users/ridz1208","html_url":"https://github.com/ridz1208","followers_url":"https://api.github.com/users/ridz1208/followers","following_url":"https://api.github.com/users/ridz1208/following{/other_user}","gists_url":"https://api.github.com/users/ridz1208/gists{/gist_id}","starred_url":"https://api.github.com/users/ridz1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridz1208/subscriptions","organizations_url":"https://api.github.com/users/ridz1208/orgs","repos_url":"https://api.github.com/users/ridz1208/repos","events_url":"https://api.github.com/users/ridz1208/events{/privacy}","received_events_url":"https://api.github.com/users/ridz1208/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":530928811,"url":"https://api.github.com/repos/aces/Loris/labels/%22Help!%20I%20don't%20understand%20Travis!%22","name":"\"Help! I don't understand Travis!\"","color":"66ccff","default":false},{"id":152314516,"url":"https://api.github.com/repos/aces/Loris/labels/Cleanup","name":"Cleanup","color":"006b75","default":false},{"id":345188265,"url":"https://api.github.com/repos/aces/Loris/labels/Needs%20Work","name":"Needs Work","color":"eb6420","default":false},{"id":153844577,"url":"https://api.github.com/repos/aces/Loris/labels/SQL","name":"SQL","color":"bfe5bf","default":false},{"id":708896092,"url":"https://api.github.com/repos/aces/Loris/labels/[branch]%20major","name":"[branch] major","color":"4d3319","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aces/Loris/pulls/3532/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/3532/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/3532/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/5faf5f02feb3cf34d3cb91caad4df938347dc117","head":{"label":"zaliqarosli:2018-03-01_normalise_consent_sql","ref":"2018-03-01_normalise_consent_sql","sha":"5faf5f02feb3cf34d3cb91caad4df938347dc117","user":{"login":"zaliqarosli","id":17415878,"avatar_url":"https://avatars3.githubusercontent.com/u/17415878?v=4","gravatar_id":"","url":"https://api.github.com/users/zaliqarosli","html_url":"https://github.com/zaliqarosli","followers_url":"https://api.github.com/users/zaliqarosli/followers","following_url":"https://api.github.com/users/zaliqarosli/following{/other_user}","gists_url":"https://api.github.com/users/zaliqarosli/gists{/gist_id}","starred_url":"https://api.github.com/users/zaliqarosli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaliqarosli/subscriptions","organizations_url":"https://api.github.com/users/zaliqarosli/orgs","repos_url":"https://api.github.com/users/zaliqarosli/repos","events_url":"https://api.github.com/users/zaliqarosli/events{/privacy}","received_events_url":"https://api.github.com/users/zaliqarosli/received_events","type":"User","site_admin":false},"repo":{"id":113231564,"name":"Loris","full_name":"zaliqarosli/Loris","owner":{"login":"zaliqarosli","id":17415878,"avatar_url":"https://avatars3.githubusercontent.com/u/17415878?v=4","gravatar_id":"","url":"https://api.github.com/users/zaliqarosli","html_url":"https://github.com/zaliqarosli","followers_url":"https://api.github.com/users/zaliqarosli/followers","following_url":"https://api.github.com/users/zaliqarosli/following{/other_user}","gists_url":"https://api.github.com/users/zaliqarosli/gists{/gist_id}","starred_url":"https://api.github.com/users/zaliqarosli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaliqarosli/subscriptions","organizations_url":"https://api.github.com/users/zaliqarosli/orgs","repos_url":"https://api.github.com/users/zaliqarosli/repos","events_url":"https://api.github.com/users/zaliqarosli/events{/privacy}","received_events_url":"https://api.github.com/users/zaliqarosli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zaliqarosli/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/zaliqarosli/Loris","forks_url":"https://api.github.com/repos/zaliqarosli/Loris/forks","keys_url":"https://api.github.com/repos/zaliqarosli/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaliqarosli/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaliqarosli/Loris/teams","hooks_url":"https://api.github.com/repos/zaliqarosli/Loris/hooks","issue_events_url":"https://api.github.com/repos/zaliqarosli/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/zaliqarosli/Loris/events","assignees_url":"https://api.github.com/repos/zaliqarosli/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/zaliqarosli/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/zaliqarosli/Loris/tags","blobs_url":"https://api.github.com/repos/zaliqarosli/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaliqarosli/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaliqarosli/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaliqarosli/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaliqarosli/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/zaliqarosli/Loris/languages","stargazers_url":"https://api.github.com/repos/zaliqarosli/Loris/stargazers","contributors_url":"https://api.github.com/repos/zaliqarosli/Loris/contributors","subscribers_url":"https://api.github.com/repos/zaliqarosli/Loris/subscribers","subscription_url":"https://api.github.com/repos/zaliqarosli/Loris/subscription","commits_url":"https://api.github.com/repos/zaliqarosli/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaliqarosli/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaliqarosli/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaliqarosli/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaliqarosli/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/zaliqarosli/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaliqarosli/Loris/merges","archive_url":"https://api.github.com/repos/zaliqarosli/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaliqarosli/Loris/downloads","issues_url":"https://api.github.com/repos/zaliqarosli/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/zaliqarosli/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/zaliqarosli/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/zaliqarosli/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaliqarosli/Loris/labels{/name}","releases_url":"https://api.github.com/repos/zaliqarosli/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/zaliqarosli/Loris/deployments","created_at":"2017-12-05T20:50:03Z","updated_at":"2017-12-05T20:50:07Z","pushed_at":"2018-03-02T23:46:06Z","git_url":"git://github.com/zaliqarosli/Loris.git","ssh_url":"git@github.com:zaliqarosli/Loris.git","clone_url":"https://github.com/zaliqarosli/Loris.git","svn_url":"https://github.com/zaliqarosli/Loris","homepage":"","size":76072,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"minor"}},"base":{"label":"aces:major","ref":"major","sha":"635c282e9a7851e1cb5409e69dd7900c0da1f9a9","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2018-03-02T19:33:39Z","pushed_at":"2018-03-06T17:38:21Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":75903,"stargazers_count":59,"watchers_count":59,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":84,"open_issues":69,"watchers":59,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/3532"},"html":{"href":"https://github.com/aces/Loris/pull/3532"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/3532"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/3532/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/3532/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/3532/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/5faf5f02feb3cf34d3cb91caad4df938347dc117"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1125630,
"name": "aces/Loris",
"url": "https://api.github.com/repos/aces/Loris"
} | {
"id": 17415878,
"login": "zaliqarosli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17415878?",
"url": "https://api.github.com/users/zaliqarosli"
} | {
"id": 472868,
"login": "aces",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/472868?",
"url": "https://api.github.com/orgs/aces"
} | 2018-03-06T17:45:01 | 7339271320 | {"actor":{"display_login":"zaliqarosli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vmware/clarity/pulls/comments/196289208","pull_request_review_id":129811670,"id":196289208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI4OTIwOA==","diff_hunk":"@@ -0,0 +1,131 @@\n+/*\n+ * Copyright (c) 2016-2018 VMware, Inc. All Rights Reserved.\n+ * This software is released under MIT license.\n+ * The full license information can be found in LICENSE in the root directory of this project.\n+ */\n+import {Component} from \"@angular/core\";\n+import {TestBed} from \"@angular/core/testing\";\n+import {By} from \"@angular/platform-browser\";\n+import {NoopAnimationsModule} from \"@angular/platform-browser/animations\";\n+\n+import {DomAdapter} from \"../dom-adapter/dom-adapter\";\n+\n+import {ClrDraggableGhost} from \".\";\n+import {ClrDragAndDropModule} from \"./drag-and-drop.module\";\n+import {ClrDragEventListener} from \"./providers/drag-event-listener\";\n+import {MOCK_DRAG_EVENT_LISTENER_PROVIDER} from \"./providers/drag-event-listener.mock\";\n+import {ClrDraggableStateRegistrar} from \"./providers/draggable-state-registrar\";\n+\n+export default function(): void {\n+ describe(\"ClrDraggableGhost\", function() {\n+ describe(\"Without Wrapping ClrDraggable\", function() {\n+ it(\"should throw an error with a message\", function() {\n+ TestBed.configureTestingModule({\n+ declarations: [WithNoWrappingDraggable, ClrDraggableGhost],\n+ providers: [ClrDraggableStateRegistrar, DomAdapter]","path":"src/clr-angular/utils/drag-and-drop/draggable-ghost.spec.ts","position":null,"original_position":25,"commit_id":"3aa1d4aa3dbdf4458e478edd2707e2f79a5a2b40","original_commit_id":"8c2109215e81b593a32f5f5dd413ebc13b79caa6","user":{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false},"body":"Addressed this issue.","created_at":"2018-06-19T04:05:19Z","updated_at":"2018-06-19T04:05:20Z","html_url":"https://github.com/vmware/clarity/pull/2335#discussion_r196289208","pull_request_url":"https://api.github.com/repos/vmware/clarity/pulls/2335","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments/196289208"},"html":{"href":"https://github.com/vmware/clarity/pull/2335#discussion_r196289208"},"pull_request":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2335"}},"in_reply_to_id":195141669},"pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/2335","id":192532424,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTMyNDI0","html_url":"https://github.com/vmware/clarity/pull/2335","diff_url":"https://github.com/vmware/clarity/pull/2335.diff","patch_url":"https://github.com/vmware/clarity/pull/2335.patch","issue_url":"https://api.github.com/repos/vmware/clarity/issues/2335","number":2335,"state":"open","locked":false,"title":"[NG] clrDraggableGhost component","user":{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shijir Tsogoo <stsogoo@vmware.com>\r\n\r\nDemo: http://dnd-ghost.surge.sh/drag-and-drop\r\n\r\nTested in: Chrome, Firefox, Safari, Edge, IE11","created_at":"2018-06-04T21:23:10Z","updated_at":"2018-06-19T04:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e1e7a7a8adb19230f4a37c2313827689b241608","assignee":{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":473349743,"node_id":"MDU6TGFiZWw0NzMzNDk3NDM=","url":"https://api.github.com/repos/vmware/clarity/labels/ClarityNG","name":"ClarityNG","color":"bfdadc","default":false},{"id":825088764,"node_id":"MDU6TGFiZWw4MjUwODg3NjQ=","url":"https://api.github.com/repos/vmware/clarity/labels/In%20Review","name":"In Review","color":"faf270","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/clarity/pulls/2335/commits","review_comments_url":"https://api.github.com/repos/vmware/clarity/pulls/2335/comments","review_comment_url":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/2335/comments","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/3aa1d4aa3dbdf4458e478edd2707e2f79a5a2b40","head":{"label":"Shijir:draggable-ghost","ref":"draggable-ghost","sha":"3aa1d4aa3dbdf4458e478edd2707e2f79a5a2b40","user":{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false},"repo":{"id":74248388,"node_id":"MDEwOlJlcG9zaXRvcnk3NDI0ODM4OA==","name":"clarity","full_name":"Shijir/clarity","owner":{"login":"Shijir","id":3958008,"node_id":"MDQ6VXNlcjM5NTgwMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3958008?v=4","gravatar_id":"","url":"https://api.github.com/users/Shijir","html_url":"https://github.com/Shijir","followers_url":"https://api.github.com/users/Shijir/followers","following_url":"https://api.github.com/users/Shijir/following{/other_user}","gists_url":"https://api.github.com/users/Shijir/gists{/gist_id}","starred_url":"https://api.github.com/users/Shijir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shijir/subscriptions","organizations_url":"https://api.github.com/users/Shijir/orgs","repos_url":"https://api.github.com/users/Shijir/repos","events_url":"https://api.github.com/users/Shijir/events{/privacy}","received_events_url":"https://api.github.com/users/Shijir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shijir/clarity","description":"Clarity Design System: UX guidelines, HTML/CSS framework, and Angular 2 components working together to craft exceptional experiences","fork":true,"url":"https://api.github.com/repos/Shijir/clarity","forks_url":"https://api.github.com/repos/Shijir/clarity/forks","keys_url":"https://api.github.com/repos/Shijir/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shijir/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shijir/clarity/teams","hooks_url":"https://api.github.com/repos/Shijir/clarity/hooks","issue_events_url":"https://api.github.com/repos/Shijir/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/Shijir/clarity/events","assignees_url":"https://api.github.com/repos/Shijir/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/Shijir/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/Shijir/clarity/tags","blobs_url":"https://api.github.com/repos/Shijir/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shijir/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shijir/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shijir/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shijir/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/Shijir/clarity/languages","stargazers_url":"https://api.github.com/repos/Shijir/clarity/stargazers","contributors_url":"https://api.github.com/repos/Shijir/clarity/contributors","subscribers_url":"https://api.github.com/repos/Shijir/clarity/subscribers","subscription_url":"https://api.github.com/repos/Shijir/clarity/subscription","commits_url":"https://api.github.com/repos/Shijir/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shijir/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shijir/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shijir/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shijir/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/Shijir/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shijir/clarity/merges","archive_url":"https://api.github.com/repos/Shijir/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shijir/clarity/downloads","issues_url":"https://api.github.com/repos/Shijir/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/Shijir/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/Shijir/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/Shijir/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shijir/clarity/labels{/name}","releases_url":"https://api.github.com/repos/Shijir/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/Shijir/clarity/deployments","created_at":"2016-11-20T02:34:12Z","updated_at":"2018-02-13T22:53:29Z","pushed_at":"2018-06-17T04:03:56Z","git_url":"git://github.com/Shijir/clarity.git","ssh_url":"git@github.com:Shijir/clarity.git","clone_url":"https://github.com/Shijir/clarity.git","svn_url":"https://github.com/Shijir/clarity","homepage":"https://vmware.github.io/clarity/","size":154835,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:topic/reusable-drag-and-drop","ref":"topic/reusable-drag-and-drop","sha":"0cfdfc3f8d9e27938b4a5bd748fda0134baf3b59","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":69590701,"node_id":"MDEwOlJlcG9zaXRvcnk2OTU5MDcwMQ==","name":"clarity","full_name":"vmware/clarity","owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/clarity","description":"UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences","fork":false,"url":"https://api.github.com/repos/vmware/clarity","forks_url":"https://api.github.com/repos/vmware/clarity/forks","keys_url":"https://api.github.com/repos/vmware/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/clarity/teams","hooks_url":"https://api.github.com/repos/vmware/clarity/hooks","issue_events_url":"https://api.github.com/repos/vmware/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/clarity/events","assignees_url":"https://api.github.com/repos/vmware/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/clarity/tags","blobs_url":"https://api.github.com/repos/vmware/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/clarity/languages","stargazers_url":"https://api.github.com/repos/vmware/clarity/stargazers","contributors_url":"https://api.github.com/repos/vmware/clarity/contributors","subscribers_url":"https://api.github.com/repos/vmware/clarity/subscribers","subscription_url":"https://api.github.com/repos/vmware/clarity/subscription","commits_url":"https://api.github.com/repos/vmware/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/clarity/merges","archive_url":"https://api.github.com/repos/vmware/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/clarity/downloads","issues_url":"https://api.github.com/repos/vmware/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/clarity/labels{/name}","releases_url":"https://api.github.com/repos/vmware/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/clarity/deployments","created_at":"2016-09-29T17:24:17Z","updated_at":"2018-06-19T03:23:39Z","pushed_at":"2018-06-18T21:12:32Z","git_url":"git://github.com/vmware/clarity.git","ssh_url":"git@github.com:vmware/clarity.git","clone_url":"https://github.com/vmware/clarity.git","svn_url":"https://github.com/vmware/clarity","homepage":"http://clarity.design","size":249893,"stargazers_count":3655,"watchers_count":3655,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":333,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":333,"open_issues":321,"watchers":3655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2335"},"html":{"href":"https://github.com/vmware/clarity/pull/2335"},"issue":{"href":"https://api.github.com/repos/vmware/clarity/issues/2335"},"comments":{"href":"https://api.github.com/repos/vmware/clarity/issues/2335/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2335/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2335/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/clarity/statuses/3aa1d4aa3dbdf4458e478edd2707e2f79a5a2b40"}},"author_association":"CONTRIBUTOR"}} | {
"id": 69590701,
"name": "vmware/clarity",
"url": "https://api.github.com/repos/vmware/clarity"
} | {
"id": 3958008,
"login": "Shijir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3958008?",
"url": "https://api.github.com/users/Shijir"
} | {
"id": 473334,
"login": "vmware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473334?",
"url": "https://api.github.com/orgs/vmware"
} | 2018-06-19T04:05:19 | 7843159054 | {"actor":{"display_login":"Shijir"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic-product/pulls/comments/187730033","pull_request_review_id":119576508,"id":187730033,"diff_hunk":"@@ -0,0 +1,83 @@\n+# Copyright 2016-2017 VMware, Inc. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#\thttp://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License\n+\n+*** Settings ***\n+Documentation Test 5-16 - vMotion VCH Appliance\n+Resource ../../resources/Util.robot\n+Suite Setup Wait Until Keyword Succeeds 10x 10m vMotion Setup\n+Suite Teardown Run Keyword And Ignore Error Nimbus Cleanup ${list}\n+Test Teardown Run Keyword If Test Failed Gather All vSphere Logs\n+\n+*** Keywords ***\n+vMotion Setup\n+ [Timeout] 110 minutes\n+ Run Keyword And Ignore Error Nimbus Cleanup ${list} ${false}\n+ ${name}= Evaluate 'vic-vmotion-' + str(random.randint(1000,9999)) modules=random\n+ Set Suite Variable ${user} %{NIMBUS_USER}\n+ ${out}= Deploy Nimbus Testbed %{NIMBUS_USER} %{NIMBUS_PASSWORD} --plugin testng --vcfvtBuildPath /dbc/pa-dbc1111/mhagen/ --noSupportBundles --vcvaBuild ${VC_VERSION} --esxPxeDir ${ESX_VERSION} --esxBuild ${ESX_VERSION} --testbedName vic-vsan-simple-pxeBoot-vcva --runName ${name}\n+ Should Contain ${out} \"deployment_result\"=>\"PASS\"\n+ Log ${out}\n+\n+ Log To Console Get VC IP ...\n+ Open Connection %{NIMBUS_GW}\n+ Wait Until Keyword Succeeds 10 min 30 sec Login %{NIMBUS_USER} %{NIMBUS_PASSWORD}\n+ ${vc-ip}= Get IP ${name}.vcva-${VC_VERSION}\n+ Close Connection\n+\n+ Set Suite Variable @{list} ${user}-${name}.vcva-${VC_VERSION} ${user}-${name}.esx.0 ${user}-${name}.esx.1 ${user}-${name}.esx.2 ${user}-${name}.esx.3 ${user}-${name}.nfs.0 ${user}-${name}.iscsi.0\n+\n+ Log To Console Set environment variables up for GOVC\n+ Set Environment Variable GOVC_INSECURE 1\n+ Set Environment Variable GOVC_URL ${vc-ip}\n+ Set Environment Variable GOVC_USERNAME Administrator@vsphere.local\n+ Set Environment Variable GOVC_PASSWORD Admin\\!23\n+\n+ Add Host To Distributed Switch /vcqaDC/host/cls\n+\n+ Log To Console Enable DRS and VSAN on the cluster\n+ ${out}= Run govc cluster.change -drs-enabled /vcqaDC/host/cls\n+ Should Be Empty ${out}\n+\n+ Log To Console Deploy VIC to the VC cluster\n+ Set Environment Variable TEST_URL ${vc-ip}\n+ Set Environment Variable TEST_USERNAME Administrator@vsphere.local\n+ Set Environment Variable TEST_PASSWORD Admin\\!23\n+ Set Environment Variable BRIDGE_NETWORK bridge\n+ Set Environment Variable PUBLIC_NETWORK vm-network\n+ Remove Environment Variable TEST_DATACENTER\n+ Set Environment Variable TEST_DATASTORE vsanDatastore\n+ Set Environment Variable TEST_RESOURCE /vcqaDC/host/cls\n+ Set Environment Variable TEST_TIMEOUT 15m\n+\n+ Gather Host IPs\n+ Log To Console Finished Creating vMotion Setup\n+ \n+Gather All vSphere Logs\n+ ${hostList}= Run govc ls -t HostSystem host/cls | xargs\n+ Run govc logs.download ${hostList}\n+\n+*** Test Cases ***\n+Test\n+ Log To Console Deploy VIC to the VC cluster...\n+ Deploy OVA And Install UI Plugin And Run Regression Tests 13-01-vMotion vic-*.ova %{TEST_DATASTORE} %{BRIDGE_NETWORK} %{PUBLIC_NETWORK} %{TEST_USERNAME} %{TEST_PASSWORD}","path":"tests/manual-test-cases/Group5-Interoperability-Tests/5-16-vMotion-VCH-Appliance.robot","position":73,"original_position":73,"commit_id":"95795ab0f8a4ab25630b72e83d0f0f893bb6492e","original_commit_id":"95795ab0f8a4ab25630b72e83d0f0f893bb6492e","user":{"login":"mdharamadas1","id":30418983,"avatar_url":"https://avatars2.githubusercontent.com/u/30418983?v=4","gravatar_id":"","url":"https://api.github.com/users/mdharamadas1","html_url":"https://github.com/mdharamadas1","followers_url":"https://api.github.com/users/mdharamadas1/followers","following_url":"https://api.github.com/users/mdharamadas1/following{/other_user}","gists_url":"https://api.github.com/users/mdharamadas1/gists{/gist_id}","starred_url":"https://api.github.com/users/mdharamadas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdharamadas1/subscriptions","organizations_url":"https://api.github.com/users/mdharamadas1/orgs","repos_url":"https://api.github.com/users/mdharamadas1/repos","events_url":"https://api.github.com/users/mdharamadas1/events{/privacy}","received_events_url":"https://api.github.com/users/mdharamadas1/received_events","type":"User","site_admin":false},"body":"test name needs update","created_at":"2018-05-11T20:52:32Z","updated_at":"2018-05-11T20:52:32Z","html_url":"https://github.com/vmware/vic-product/pull/1735#discussion_r187730033","pull_request_url":"https://api.github.com/repos/vmware/vic-product/pulls/1735","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/comments/187730033"},"html":{"href":"https://github.com/vmware/vic-product/pull/1735#discussion_r187730033"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1735"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic-product/pulls/1735","id":187559574,"html_url":"https://github.com/vmware/vic-product/pull/1735","diff_url":"https://github.com/vmware/vic-product/pull/1735.diff","patch_url":"https://github.com/vmware/vic-product/pull/1735.patch","issue_url":"https://api.github.com/repos/vmware/vic-product/issues/1735","number":1735,"state":"open","locked":false,"title":"Nightly test for vMotion-VCH-Appliance","user":{"login":"singhshwetaQE","id":29071304,"avatar_url":"https://avatars0.githubusercontent.com/u/29071304?v=4","gravatar_id":"","url":"https://api.github.com/users/singhshwetaQE","html_url":"https://github.com/singhshwetaQE","followers_url":"https://api.github.com/users/singhshwetaQE/followers","following_url":"https://api.github.com/users/singhshwetaQE/following{/other_user}","gists_url":"https://api.github.com/users/singhshwetaQE/gists{/gist_id}","starred_url":"https://api.github.com/users/singhshwetaQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhshwetaQE/subscriptions","organizations_url":"https://api.github.com/users/singhshwetaQE/orgs","repos_url":"https://api.github.com/users/singhshwetaQE/repos","events_url":"https://api.github.com/users/singhshwetaQE/events{/privacy}","received_events_url":"https://api.github.com/users/singhshwetaQE/received_events","type":"User","site_admin":false},"body":"\r\nFixes #vmware/vic-ui#419\r\n","created_at":"2018-05-11T20:15:28Z","updated_at":"2018-05-11T20:52:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6494f07cba016dc4d0ba182e2ac804cd80527533","assignee":null,"assignees":[],"requested_reviewers":[{"login":"morris-jason","id":10388115,"avatar_url":"https://avatars0.githubusercontent.com/u/10388115?v=4","gravatar_id":"","url":"https://api.github.com/users/morris-jason","html_url":"https://github.com/morris-jason","followers_url":"https://api.github.com/users/morris-jason/followers","following_url":"https://api.github.com/users/morris-jason/following{/other_user}","gists_url":"https://api.github.com/users/morris-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/morris-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morris-jason/subscriptions","organizations_url":"https://api.github.com/users/morris-jason/orgs","repos_url":"https://api.github.com/users/morris-jason/repos","events_url":"https://api.github.com/users/morris-jason/events{/privacy}","received_events_url":"https://api.github.com/users/morris-jason/received_events","type":"User","site_admin":false},{"login":"rogeliosanchez","id":26554503,"avatar_url":"https://avatars2.githubusercontent.com/u/26554503?v=4","gravatar_id":"","url":"https://api.github.com/users/rogeliosanchez","html_url":"https://github.com/rogeliosanchez","followers_url":"https://api.github.com/users/rogeliosanchez/followers","following_url":"https://api.github.com/users/rogeliosanchez/following{/other_user}","gists_url":"https://api.github.com/users/rogeliosanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/rogeliosanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogeliosanchez/subscriptions","organizations_url":"https://api.github.com/users/rogeliosanchez/orgs","repos_url":"https://api.github.com/users/rogeliosanchez/repos","events_url":"https://api.github.com/users/rogeliosanchez/events{/privacy}","received_events_url":"https://api.github.com/users/rogeliosanchez/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":434930069,"url":"https://api.github.com/repos/vmware/vic-product/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic-product/pulls/1735/commits","review_comments_url":"https://api.github.com/repos/vmware/vic-product/pulls/1735/comments","review_comment_url":"https://api.github.com/repos/vmware/vic-product/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic-product/issues/1735/comments","statuses_url":"https://api.github.com/repos/vmware/vic-product/statuses/95795ab0f8a4ab25630b72e83d0f0f893bb6492e","head":{"label":"vmware:vMotion-nightly","ref":"vMotion-nightly","sha":"95795ab0f8a4ab25630b72e83d0f0f893bb6492e","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":66033051,"name":"vic-product","full_name":"vmware/vic-product","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic-product","description":null,"fork":false,"url":"https://api.github.com/repos/vmware/vic-product","forks_url":"https://api.github.com/repos/vmware/vic-product/forks","keys_url":"https://api.github.com/repos/vmware/vic-product/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic-product/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic-product/teams","hooks_url":"https://api.github.com/repos/vmware/vic-product/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic-product/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic-product/events","assignees_url":"https://api.github.com/repos/vmware/vic-product/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic-product/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic-product/tags","blobs_url":"https://api.github.com/repos/vmware/vic-product/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic-product/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic-product/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic-product/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic-product/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic-product/languages","stargazers_url":"https://api.github.com/repos/vmware/vic-product/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic-product/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic-product/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic-product/subscription","commits_url":"https://api.github.com/repos/vmware/vic-product/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic-product/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic-product/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic-product/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic-product/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic-product/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic-product/merges","archive_url":"https://api.github.com/repos/vmware/vic-product/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic-product/downloads","issues_url":"https://api.github.com/repos/vmware/vic-product/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic-product/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic-product/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic-product/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic-product/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic-product/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic-product/deployments","created_at":"2016-08-18T21:52:44Z","updated_at":"2018-05-11T15:29:31Z","pushed_at":"2018-05-11T20:21:48Z","git_url":"git://github.com/vmware/vic-product.git","ssh_url":"git@github.com:vmware/vic-product.git","clone_url":"https://github.com/vmware/vic-product.git","svn_url":"https://github.com/vmware/vic-product","homepage":null,"size":77446,"stargazers_count":74,"watchers_count":74,"language":"RobotFramework","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":57,"open_issues":215,"watchers":74,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"a5e0b407e6661a49325b74b1fb974fb86db28ab9","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":66033051,"name":"vic-product","full_name":"vmware/vic-product","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic-product","description":null,"fork":false,"url":"https://api.github.com/repos/vmware/vic-product","forks_url":"https://api.github.com/repos/vmware/vic-product/forks","keys_url":"https://api.github.com/repos/vmware/vic-product/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic-product/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic-product/teams","hooks_url":"https://api.github.com/repos/vmware/vic-product/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic-product/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic-product/events","assignees_url":"https://api.github.com/repos/vmware/vic-product/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic-product/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic-product/tags","blobs_url":"https://api.github.com/repos/vmware/vic-product/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic-product/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic-product/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic-product/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic-product/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic-product/languages","stargazers_url":"https://api.github.com/repos/vmware/vic-product/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic-product/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic-product/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic-product/subscription","commits_url":"https://api.github.com/repos/vmware/vic-product/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic-product/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic-product/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic-product/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic-product/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic-product/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic-product/merges","archive_url":"https://api.github.com/repos/vmware/vic-product/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic-product/downloads","issues_url":"https://api.github.com/repos/vmware/vic-product/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic-product/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic-product/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic-product/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic-product/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic-product/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic-product/deployments","created_at":"2016-08-18T21:52:44Z","updated_at":"2018-05-11T15:29:31Z","pushed_at":"2018-05-11T20:21:48Z","git_url":"git://github.com/vmware/vic-product.git","ssh_url":"git@github.com:vmware/vic-product.git","clone_url":"https://github.com/vmware/vic-product.git","svn_url":"https://github.com/vmware/vic-product","homepage":null,"size":77446,"stargazers_count":74,"watchers_count":74,"language":"RobotFramework","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":57,"open_issues":215,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1735"},"html":{"href":"https://github.com/vmware/vic-product/pull/1735"},"issue":{"href":"https://api.github.com/repos/vmware/vic-product/issues/1735"},"comments":{"href":"https://api.github.com/repos/vmware/vic-product/issues/1735/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1735/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic-product/pulls/1735/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic-product/statuses/95795ab0f8a4ab25630b72e83d0f0f893bb6492e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66033051,
"name": "vmware/vic-product",
"url": "https://api.github.com/repos/vmware/vic-product"
} | {
"id": 30418983,
"login": "mdharamadas1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30418983?",
"url": "https://api.github.com/users/mdharamadas1"
} | {
"id": 473334,
"login": "vmware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473334?",
"url": "https://api.github.com/orgs/vmware"
} | 2018-05-11T20:52:32 | 7663328301 | {"actor":{"display_login":"mdharamadas1"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/176350069","pull_request_review_id":106034719,"id":176350069,"diff_hunk":"@@ -127,13 +144,20 @@ protected void removeDecoder(ChannelHandlerContext ctx) throws Exception {\n @Override\n protected Object newInitialMessage(ChannelHandlerContext ctx) throws Exception {\n InetSocketAddress raddr = destinationAddress();\n- final String host = NetUtil.toSocketAddressString(raddr);\n+\n+ String hostString = HttpUtil.formatForHttp(raddr);\n+ int port = raddr.getPort();\n+ String url = hostString + \":\" + port;\n+ String hostHeader = (ignoreDefaultPortsInConnectHostHeader && (port == 80 || port == 443)) ?","path":"handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java","position":72,"original_position":72,"commit_id":"294ae5e978b015a5aa4d5ae2e7162ee3e0359f5a","original_commit_id":"294ae5e978b015a5aa4d5ae2e7162ee3e0359f5a","user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"body":"I'm not convinced it would make sense to test this single line of code.\r\nThen, url and Host header computations are entangled so I can save allocations.\r\nI can't test `HttpProxyHandler#newInitialMessage` because I would need to override `destinationAddress()` which is final.\r\nI'm going to extract CONNECT request creation in a static method.","created_at":"2018-03-22T09:18:09Z","updated_at":"2018-03-22T09:18:09Z","html_url":"https://github.com/netty/netty/pull/7784#discussion_r176350069","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/7784","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/176350069"},"html":{"href":"https://github.com/netty/netty/pull/7784#discussion_r176350069"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/7784"}},"in_reply_to_id":175853931},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/7784","id":175280214,"html_url":"https://github.com/netty/netty/pull/7784","diff_url":"https://github.com/netty/netty/pull/7784.diff","patch_url":"https://github.com/netty/netty/pull/7784.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/7784","number":7784,"state":"open","locked":false,"title":"HttpProxyHandler generates invalid CONNECT url and Host header when address is resolved","user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nHttpProxyHandler uses `NetUtil#toSocketAddressString` to compute\r\nCONNECT url and Host header.\r\n\r\nThe url is correct when the address is unresolved, as\r\n`NetUtil#toSocketAddressString` will then use\r\n`getHoststring`/`getHostname`. If the address is already resolved, the\r\nurl will be based on the IP instead of the hostname.\r\n\r\nThere’s an additional minor issue with the Host header: default port\r\n443 should be omitted.\r\n\r\nModifications:\r\n\r\n* Only use NetUtil.toSocketAddressString when address is unresolved,\r\nuse `getHostname` otherwise\r\n* Don’t append port to Host header when it’s 443\r\n\r\nResult:\r\n\r\nHttpProxyHandler performs properly when connecting to a resolved address","created_at":"2018-03-15T15:05:24Z","updated_at":"2018-03-22T09:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bed0cae4744264f4459e777e247c08fe1556a51f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"trustin","id":173918,"avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/7784/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/7784/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/7784/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/294ae5e978b015a5aa4d5ae2e7162ee3e0359f5a","head":{"label":"slandelle:4.1","ref":"4.1","sha":"294ae5e978b015a5aa4d5ae2e7162ee3e0359f5a","user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"repo":{"id":33929023,"name":"netty","full_name":"slandelle/netty","owner":{"login":"slandelle","id":849197,"avatar_url":"https://avatars0.githubusercontent.com/u/849197?v=4","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slandelle/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/slandelle/netty","forks_url":"https://api.github.com/repos/slandelle/netty/forks","keys_url":"https://api.github.com/repos/slandelle/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slandelle/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slandelle/netty/teams","hooks_url":"https://api.github.com/repos/slandelle/netty/hooks","issue_events_url":"https://api.github.com/repos/slandelle/netty/issues/events{/number}","events_url":"https://api.github.com/repos/slandelle/netty/events","assignees_url":"https://api.github.com/repos/slandelle/netty/assignees{/user}","branches_url":"https://api.github.com/repos/slandelle/netty/branches{/branch}","tags_url":"https://api.github.com/repos/slandelle/netty/tags","blobs_url":"https://api.github.com/repos/slandelle/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slandelle/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slandelle/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/slandelle/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slandelle/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/slandelle/netty/languages","stargazers_url":"https://api.github.com/repos/slandelle/netty/stargazers","contributors_url":"https://api.github.com/repos/slandelle/netty/contributors","subscribers_url":"https://api.github.com/repos/slandelle/netty/subscribers","subscription_url":"https://api.github.com/repos/slandelle/netty/subscription","commits_url":"https://api.github.com/repos/slandelle/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/slandelle/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/slandelle/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/slandelle/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/slandelle/netty/contents/{+path}","compare_url":"https://api.github.com/repos/slandelle/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slandelle/netty/merges","archive_url":"https://api.github.com/repos/slandelle/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slandelle/netty/downloads","issues_url":"https://api.github.com/repos/slandelle/netty/issues{/number}","pulls_url":"https://api.github.com/repos/slandelle/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/slandelle/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/slandelle/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slandelle/netty/labels{/name}","releases_url":"https://api.github.com/repos/slandelle/netty/releases{/id}","deployments_url":"https://api.github.com/repos/slandelle/netty/deployments","created_at":"2015-04-14T11:58:26Z","updated_at":"2016-11-09T11:43:32Z","pushed_at":"2018-03-16T20:46:01Z","git_url":"git://github.com/slandelle/netty.git","ssh_url":"git@github.com:slandelle/netty.git","clone_url":"https://github.com/slandelle/netty.git","svn_url":"https://github.com/slandelle/netty","homepage":"http://netty.io/","size":47353,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"de082bf4c719f177cb068e01511bc1c69bde4cbf","user":{"login":"netty","id":473791,"avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars1.githubusercontent.com/u/473791?v=4","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2018-03-22T09:04:49Z","pushed_at":"2018-03-22T07:30:53Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":50911,"stargazers_count":13215,"watchers_count":13215,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6038,"mirror_url":null,"archived":false,"open_issues_count":398,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6038,"open_issues":398,"watchers":13215,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/7784"},"html":{"href":"https://github.com/netty/netty/pull/7784"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/7784"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/7784/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/7784/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/7784/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/294ae5e978b015a5aa4d5ae2e7162ee3e0359f5a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1064563,
"name": "netty/netty",
"url": "https://api.github.com/repos/netty/netty"
} | {
"id": 849197,
"login": "slandelle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/849197?",
"url": "https://api.github.com/users/slandelle"
} | {
"id": 473791,
"login": "netty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473791?",
"url": "https://api.github.com/orgs/netty"
} | 2018-03-22T09:18:09 | 7417930380 | {"actor":{"display_login":"slandelle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/comments/173502976","pull_request_review_id":102703674,"id":173502976,"diff_hunk":"@@ -40,1372 +40,899 @@\n * https://int80k.com/libuvc/doc/\n */\n \n+#include <functional>\n+#include <iostream>\n+\n+#include <cv_bridge/cv_bridge.h>\n+#include <sensor_msgs/image_encodings.h>\n+\n #include \"uvc_ros_driver.h\"\n \n-namespace uvc\n-{\n+namespace uvc {\n \n-static void callback(uvc_frame *frame, void *arg)\n-{\n-\tuvcROSDriver *obj = (uvcROSDriver *)arg;\n-\tobj->uvc_cb(frame);\n+static void callback(uvc_frame *frame, void *arg) {\n+ uvcROSDriver *obj = (uvcROSDriver *)arg;\n+ obj->uvc_cb(frame);\n }\n \n-static bool myPairMax(std::pair<int, int> p, std::pair<int, int> p1)\n-{\n-\t// gratest value is supposed be on the second index\n-\treturn p.second < p1.second;\n+static bool myPairMax(std::pair<int, int> p, std::pair<int, int> p1) {\n+ // gratest value is supposed be on the second index\n+ return p.second < p1.second;\n }\n \n-uvcROSDriver::~uvcROSDriver()\n-{\n-\tif(serial_port_open_){\n-\t\tsetParam(\"CAMERA_ENABLE\", 0.0f);\n-\t}\n-\tmavlink_message_t message;\n-\tmavlink_param_value_t param;\n-\tmavlink_heartbeat_t heartbeat;\n-\tint count = 0;\n-\tbool wait=1;\n-\tstd::string str = \"CAMERA_ENABLE\";\n-\n-\tif(serial_port_open_){\n-\t\twhile(wait){\n-\t\t\tint res = sp_.read_message(message);\n-\t\t\tif(res == -1){\n-\t\t\t\tserial_port_open_ = false;\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t\tif(res != 0){\n-\t\t\t\tif(message.msgid==22){\n-\t\t\t\t\tmavlink_msg_param_value_decode(&message, ¶m);\n-\t\t\t\t\tif(str.compare(param.param_id)==0 && param.param_value==0){\n-\t\t\t\t\t\twait = 0;\n-\t\t\t\t\t}\n-\t\t\t\t\telse{\n-\t\t\t\t\t\tsetParam(\"CAMERA_ENABLE\", 0.0f);\n-\t\t\t\t\t}\n-\t\t\t\t\t//std::cout << \"received id \" << param.param_id << \" value \" << param.param_value <<\" iteration \" \t\t\t\t<< (float) count << std::endl;\n-\t\t\t\t\tcount++;\n-\t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\n-\tprintf(\"Camera Disabled \\n\");\n-\t// close serial port\n-\tsp_.close_serial();\n-\tusleep(500000);\n-\tuvc_stop_streaming(devh_);\n-\n-\t// close uvc device\n-\tuvc_close(devh_);\n-\tprintf(\"Device closed\");\n-\t// ROS_INFO(\"Device closed\");\n-\tuvc_unref_device(dev_);\n-\tuvc_exit(ctx_);\n-\t}\n+uvcROSDriver::~uvcROSDriver() {\n+ shutdown_ = true;\n+\n+ if (serial_port_open_) {\n+ setParam(\"CAMERA_ENABLE\", 0.0f);\n+ }\n+ mavlink_message_t message;\n+ mavlink_param_value_t param;\n+ bool wait = 1;\n+ std::string str = \"CAMERA_ENABLE\";\n+\n+ if (serial_port_open_) {\n+ while (wait) {\n+ int res = sp_.read_message(message);\n+ if (res == -1) {\n+ serial_port_open_ = false;\n+ break;\n+ }\n+ if (res != 0) {\n+ if (message.msgid == 22) {\n+ mavlink_msg_param_value_decode(&message, ¶m);\n+ if (str.compare(param.param_id) == 0 && param.param_value == 0) {\n+ wait = 0;\n+ } else {\n+ setParam(\"CAMERA_ENABLE\", 0.0f);\n+ }\n+ }\n+ }\n+ }\n+\n+ printf(\"Camera Disabled \\n\");\n+ // close serial port\n+ sp_.close_serial();\n+ usleep(500000);\n+ uvc_stop_streaming(devh_);\n+\n+ // close uvc device\n+ uvc_close(devh_);\n+ printf(\"Device closed\");\n+ uvc_unref_device(dev_);\n+ uvc_exit(ctx_);\n+ }\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-void uvcROSDriver::initDevice()\n-{\n-\t// initialize serial port\n-\t// sp_ = Serial_Port(\"/dev/ttyUSB0\", 115200);\n-\tsp_ = Serial_Port(\"/dev/serial/by-id/usb-Cypress_FX3-if02\", 115200);\n-\n- bool first_fault = true;\n-\tint open = 0;\n- while (true)\n- {\n- \tros::spinOnce();\n-\t\tif(!nh_.ok())\n-\t\t\treturn;\n- \topen = sp_.open_serial();\n-\n- \tif (open != -1){\n-\t\t\tserial_port_open_ = true;\n- \t\tbreak;\n-\t\t}\n- \t\tif (first_fault)\n- \t{\n- \t\tROS_ERROR(\"Couldn't open serialport /dev/serial/by-id/usb-Cypress_FX3-if02. Will retry every second.\");\n- \t\tfirst_fault = false;\n- \t\t }\n- \tsleep(1.0);\n+void uvcROSDriver::initDevice() {\n+ // initialize serial port\n+ // sp_ = Serial_Port(\"/dev/ttyUSB0\", 115200);\n+ sp_ = Serial_Port(\"/dev/serial/by-id/usb-Cypress_FX3-if02\", 115200);\n+\n+ bool first_fault = true;\n+ int open = 0;\n+ while (true) {\n+ ros::spinOnce();\n+ if (!nh_.ok()) return;\n+ open = sp_.open_serial();\n+\n+ if (open != -1) {\n+ serial_port_open_ = true;\n+ break;\n+ }\n+ if (first_fault) {\n+ ROS_ERROR(\n+ \"Couldn't open serialport /dev/serial/by-id/usb-Cypress_FX3-if02. \"\n+ \"Will retry every second.\");\n+ first_fault = false;\n+ }\n+ sleep(1.0);\n+ }\n+\n+ // initialize camera image publisher\n+ constexpr int kCamQueueSize = 5;\n+ constexpr int kIMUQueueSize = 20;\n+ std::string prev_topic;\n+ for (size_t i = 0; i < n_cameras_; ++i) {\n+ const std::string topic = \"cam_\" + std::to_string(i) + \"/\";\n+ cam_raw_pubs_.emplace_back(\n+ it_.advertise(topic + \"image_raw\", kCamQueueSize));\n+ cam_info_pubs_.emplace_back(\n+ nh_.advertise<sensor_msgs::CameraInfo>(topic + \"camera_info\", 1000));\n+\n+ if (i % 2) {\n+ cam_rect_pubs_.emplace_back(\n+ it_.advertise(prev_topic + \"image_rect\", kCamQueueSize));\n+ cam_disp_pubs_.emplace_back(\n+ it_.advertise(prev_topic + \"image_depth\", kCamQueueSize));\n+\n+ imu_pubs_.emplace_back(\n+ nh_.advertise<sensor_msgs::Imu>(prev_topic + \"imu\", kIMUQueueSize));\n+ imu_pubs_.emplace_back(\n+ nh_.advertise<sensor_msgs::Imu>(topic + \"imu\", kIMUQueueSize));\n+ }\n+ prev_topic = topic;\n+ }\n+\n+ info_cams_.resize(n_cameras_);\n+\n+ // time translator\n+ constexpr int kSecondsToNanoSeconds = 1e9;\n+ device_time_translator_.reset(\n+ new cuckoo_time_translator::UnwrappedDeviceTimeTranslator(\n+ cuckoo_time_translator::ClockParameters(kSecondsToNanoSeconds),\n+ nh_.getNamespace(),\n+ cuckoo_time_translator::Defaults().setFilterAlgorithm(\n+ cuckoo_time_translator::FilterAlgorithm::ConvexHull)));\n+\n+ // wait on heartbeat\n+ std::cout << \"Waiting on device.\";\n+ fflush(stdout);\n+ mavlink_message_t message;\n+ if (serial_port_open_ && nh_.ok()) {\n+ int res = sp_.read_message(message);\n+ if (res == -1) {\n+ serial_port_open_ = false;\n+ return;\n+ }\n+\n+ mavlink_heartbeat_t heartbeat;\n+\n+ while (heartbeat.type != 9) { // check for system type 9 heartbeat\n+\n+ if (heartbeat.type != 9) {\n+ printf(\".\");\n+ fflush(stdout);\n+ usleep(50000);\n+ }\n+ if (message.msgid == 0) {\n+ mavlink_msg_heartbeat_decode(&message, &heartbeat);\n+ if (heartbeat.type == 9) {\n+ std::cout << std::endl;\n+ ROS_INFO(\"Got heartbeat from camera\");\n+ }\n+ }\n+ if (serial_port_open_ && nh_.ok()) {\n+ int res = sp_.read_message(message);\n+ if (res == -1) {\n+ serial_port_open_ = false;\n+ return;\n }\n+ }\n+ }\n \n-\t//sp_.open_serial();\n-\n-\t// initialize camera image publisher\n-\tswitch (n_cameras_) {\n-\tcase 10:\n-\t\tcam_9_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_9/image_raw\", 5);\n-\t\tcam_9_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_9/camera_info\", 5);\n-\t\tcam_8c_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_8/image_rect\", 5);\n-\t\tcam_8c_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_8/camera_info\", 5);\n-\t\tcam_8d_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_8/image_depth\", 5);\n-\t\tcam_8d_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_8/camera_info\", 5);\n-\t\t// initialize imu msg publisher\n-\t\timu8_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_8/imu\", 20);\n-\t\timu9_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_9/imu\", 20);\n-\n-\tcase 9:\n-\t\tcam_8_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_8/image_raw\", 5);\n-\t\tcam_8_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_8/camera_info\", 5);\n-\n-\tcase 8:\n-\t\tcam_7_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_7/image_raw\", 5);\n-\t\tcam_7_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_7/camera_info\", 5);\n-\t\tcam_6c_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_6/image_rect\", 5);\n-\t\tcam_6c_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_6/camera_info\", 5);\n-\t\tcam_6d_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_6/image_depth\", 5);\n-\t\tcam_6d_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_6/camera_info\", 5);\n-\t\t// initialize imu msg publisher\n-\t\timu6_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_6/imu\", 20);\n-\t\timu7_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_7/imu\", 20);\n-\n-\tcase 7:\n-\t\tcam_6_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_6/image_raw\", 5);\n-\t\tcam_6_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_6/camera_info\", 5);\n-\n-\tcase 6:\n-\t\tcam_5_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_5/image_raw\", 5);\n-\t\tcam_5_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_5/camera_info\", 5);\n-\t\tcam_4c_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_4/image_rect\", 5);\n-\t\tcam_4c_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_4/camera_info\", 5);\n-\t\tcam_4d_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_4/image_depth\", 5);\n-\t\tcam_4d_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_4/camera_info\", 5);\n-\t\t// initialize imu msg publisher\n-\t\timu4_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_4/imu\", 20);\n-\t\timu5_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_5/imu\", 20);\n-\n-\tcase 5:\n-\t\tcam_4_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_4/image_raw\", 5);\n-\t\tcam_4_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_4/camera_info\", 5);\n-\n-\tcase 4:\n-\t\tcam_3_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_3/image_raw\", 5);\n-\t\tcam_3_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_3/camera_info\", 5);\n-\t\tcam_2c_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_2/image_rect\", 5);\n-\t\tcam_2c_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_2/camera_info\", 5);\n-\t\tcam_2d_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_2/image_depth\", 5);\n-\t\tcam_2d_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_2/camera_info\", 5);\n-\t\t// initialize imu msg publisher\n-\t\timu2_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_2/imu\", 20);\n-\t\timu3_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_3/imu\", 20);\n-\n-\tcase 3:\n-\t\tcam_2_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_2/image_raw\", 5);\n-\t\tcam_2_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_2/camera_info\", 5);\n-\n-\tcase 2:\n-\t\tcam_1_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_1/image_raw\", 5);\n-\t\tcam_1_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_1/camera_info\", 5);\n-\t\tcam_0c_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_0/image_rect\", 5);\n-\t\tcam_0c_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_0/camera_info\", 5);\n-\t\tcam_0d_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_0/image_depth\", 5);\n-\t\tcam_0d_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_0/camera_info\", 5);\n-\t\t// initialize imu msg publisher\n-\t\timu0_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_0/imu\", 20);\n-\t\timu1_publisher_ = nh_.advertise<sensor_msgs::Imu>(\"cam_1/imu\", 20);\n-\n-\tdefault:\n-\t\tcam_0_pub_ = nh_.advertise<sensor_msgs::Image>(\n-\t\t\t\t node_name_ + \"/cam_0/image_raw\", 5);\n-\t\tcam_0_info_pub_ = nh_.advertise<sensor_msgs::CameraInfo>(\n-\t\t\t\t\t node_name_ + \"/cam_0/camera_info\", 5);\n-\t}\n-\n-\n-\t// wait on heart beat\n-\tstd::cout << \"Waiting on device.\";\n-\tfflush(stdout);\n-\tmavlink_message_t message;\n-\tif(serial_port_open_ && nh_.ok()){\n-\t\tint res = sp_.read_message(message);\n-\t\tif(res == -1){\n-\t\t\tserial_port_open_ = false;\n-\t\t\treturn;\n-\t\t}\n-\n-\tmavlink_heartbeat_t heartbeat;\n-\n-\twhile (heartbeat.type !=9){ //check for system type 9 heartbeat\n-\n-\t\tif(heartbeat.type!=9){\n-\t\t\tprintf(\".\");\n-\t\t\tfflush(stdout);\n-\t\t\tusleep(50000);\n-\t\t}\n-\t\tif(message.msgid ==0 ){\n-\t\t\tmavlink_msg_heartbeat_decode(&message, &heartbeat);\n-\t\t\tif(heartbeat.type ==9){\n-\t\t\t\tstd::cout << std::endl;\n-\t\t\t\tROS_INFO(\"Got heartbeat from camera\");\n-\t\t\t}\n-\t\t}\n-\t\tif(serial_port_open_ && nh_.ok()){\n-\t\t\tint res = sp_.read_message(message);\n-\t\t\tif(res == -1){\n-\t\t\t\tserial_port_open_ = false;\n-\t\t\t\treturn;\n-\t\t\t}\n-\t\t}\n-\t}\n-\n-\t//std::cout << \"Device connected\" << std::endl;\n-\t//setCalibration(camera_params_);\n-\t// set flag for completed initializiation\n-\tdevice_initialized_ = true;\n-\t}\n+ // set flag for completed initializiation\n+ device_initialized_ = true;\n+ }\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-void uvcROSDriver::startDevice()\n-{\n-\tif (device_initialized_) {\n-\n-\t\tsetCalibration(camera_params_);\n-\n-\t\t// open uvc stream\n-\t\tuvc_error_t res = initAndOpenUvc();\n-\t\t// start stream\n-\t\tpast_ = ros::Time::now();\n-\t\tres = uvc_start_streaming(devh_, &ctrl_, &callback, this, 0);\n-\t\t\t//mavlink_param_value_t param;\n-\t\t\t//bool wait=1;\n-\t\t\t//std::string str = \"CAMERA_ENABLE\";\n-\t\tsetParam(\"CAMERA_ENABLE\",float(camera_config_));\n-\t\t\t//printf(\"Wait on camera \\n\");\n-\t\t//usleep(200000);\n-\n-\t\t/*while(!uvc_cb_flag_ && ros::ok()){\n-\t\t\t\t/*mavlink_message_t message;\n-\t\t\t\tint res = sp_.read_message(message);\n-\t\t\t\tif(res != 0){\n-\t\t\t\t\tif(message.msgid==22){\n-\t\t\t\t\t\t//printf(\"got message id 22...\\n\");\n-\t\t\t\t\t\tmavlink_msg_param_value_decode(&message, ¶m);\n-\t\t\t\t\t\tif(str.compare(param.param_id)==0 && param.param_value==float(camera_config_)){\n-\t\t\t\t\t\t\twait = 0;\n-\t\t\t\t\t\t\tprintf(\"camera started\\n\");\n-\t\t\t\t\t\t}\n-\t\t\t\t\t\telse{\n-\t\t\t\t\t\t\tsetParam(\"CAMERA_ENABLE\",float(camera_config_));\n-\t\t\t\t\t\t\tstd::cout << \".\" ;\n-\t\t\t\t\t\t}\n-\t\t\t\t\t}\n-\n-\t\t\t\t}*/\n-\t\t\t\t//std::cout << \".\" ;\n-\t\t\t/*setParam(\"CAMERA_ENABLE\",float(camera_config_));\n-\t\t\tusleep(200000);\n-\t\t}*/\n-\n-\t\t\t//printf(\" done\\n\");\n-\t\tprintf(\"Waiting on stream\");\n-\t\twhile (!uvc_cb_flag_ && ros::ok()) {\n-\t\t\tprintf(\".\");\n-\t\t\tfflush(stdout);\n-\t\t\t//uvc_stop_streaming(devh_);\n-\t\t\t//res = uvc_start_streaming(devh_, &ctrl_, &callback, this, 0);\n-\t\t\t\n-\t\t\tif(setParam(\"CAMERA_ENABLE\",float(camera_config_))==-1){\n-\t\t\t\tROS_ERROR(\"Device not initialized!\");\n-\t\t\t\treturn;\n-\t\t\t}\n-\t\t\tusleep(200000);\n-\t\t\t// std::cout << \"res: \" << res << std::endl;\n-\t\t}\n-\n-\t} else {\n-\t\tROS_ERROR(\"Device not initialized!\");\n-\t}\n+void uvcROSDriver::startDevice() {\n+ if (device_initialized_) {\n+ setCalibration(camera_params_);\n+\n+ // open uvc stream\n+ uvc_error_t res = initAndOpenUvc();\n+ if (res < 0) {\n+ uvc_perror(res, \"uvc_init\");\n+ ROS_ERROR(\"Unable to open uvc device\");\n+ return;\n+ }\n+\n+ // start stream\n+ res = uvc_start_streaming(devh_, &ctrl_, &callback, this, 0);\n+\n+ setParam(\"CAMERA_ENABLE\", static_cast<float>(buildCameraConfig()));\n+ setCalibration(camera_params_);\n+\n+ printf(\"Waiting on stream\");\n+ while (!uvc_cb_flag_ && ros::ok()) {\n+ printf(\".\");\n+ fflush(stdout);\n+\n+ if (setParam(\"CAMERA_ENABLE\", static_cast<float>(buildCameraConfig())) == -1) {\n+ ROS_ERROR(\"Device not initialized!\");\n+ return;\n+ }\n+ usleep(200000);\n+ }\n+\n+ ROS_INFO(\"Enabled Dynamic Reconfigure Callback\");\n+ dynamic_reconfigure_.setCallback(\n+ std::bind(&uvcROSDriver::dynamicReconfigureCallback, this,\n+ std::placeholders::_1, std::placeholders::_2));\n+\n+ } else {\n+ ROS_ERROR(\"Device not initialized!\");\n+ }\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-int uvcROSDriver::setParam(const std::string &name, float val)\n-{\n-\tmavlink_message_t msg;\n-\tchar name_buf[16] = {};\n+int uvcROSDriver::setParam(const std::string &name, float val) {\n+ mavlink_message_t msg;\n+ char name_buf[16] = {};\n \n-\tuint8_t local_sys = 1;\n-\tuint8_t local_comp = 1;\n+ uint8_t local_sys = 1;\n+ uint8_t local_comp = 1;\n \n-\tuint8_t target_sys = 99;\n-\tuint8_t target_comp = 55;\n+ uint8_t target_sys = 99;\n+ uint8_t target_comp = 55;\n \n-\t// SETCALIB\n-\tstrncpy(name_buf, name.c_str(), MAVLINK_MSG_PARAM_VALUE_FIELD_PARAM_ID_LEN);\n-\tmavlink_msg_param_set_pack(local_sys, local_comp, &msg, target_sys,\n-\t\t\t\t target_comp, name_buf, val, MAVLINK_TYPE_FLOAT);\n-\tint ret = sp_.write_message(msg);\n+ constexpr size_t kAttempts = 2;\n \n-\tif (ret <= 0) {\n-\t\tprintf(\"ret: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+ // SETCALIB\n+ // multiple attempts, just so we maximize chances things actually go through\n+ for (size_t i = 0; i < kAttempts; ++i) {\n+ strncpy(name_buf, name.c_str(), MAVLINK_MSG_PARAM_VALUE_FIELD_PARAM_ID_LEN);\n+ mavlink_msg_param_set_pack(local_sys, local_comp, &msg, target_sys,\n+ target_comp, name_buf, val, MAVLINK_TYPE_FLOAT);\n+ int ret = sp_.write_message(msg);\n \n-\t// another time, just so we maximize chances things actually go through\n-\tstrncpy(name_buf, name.c_str(), MAVLINK_MSG_PARAM_VALUE_FIELD_PARAM_ID_LEN);\n-\tmavlink_msg_param_set_pack(local_sys, local_comp, &msg, target_sys,\n-\t\t\t\t target_comp, name_buf, val, MAVLINK_TYPE_FLOAT);\n-\tret = sp_.write_message(msg);\n+ if (ret <= 0) {\n+ printf(\"ret: %d\\n\", ret);\n+ return ret;\n+ }\n+ }\n \n-\tif (ret <= 0) {\n-\t\tprintf(\"ret: %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n-\n-\treturn 0;\n+ return 0;\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-void uvcROSDriver::sendCameraParam(const int camera_number, const double fx,\n-\t\t\t\t const double fy, const Eigen::Vector2d &p0,\n-\t\t\t\t const float k1, const float k2,\n-\t\t\t\t const float r1, const float r2,\n-\t\t\t\t const Eigen::Matrix3d &H)\n-{\n-\tstd::string camera_name = \"CAM\" + std::to_string(camera_number);\n-\tsetParam(\"PARAM_CCX_\" + camera_name, p0[0]);\n-\tsetParam(\"PARAM_CCY_\" + camera_name, p0[1]);\n-\tsetParam(\"PARAM_FCX_\" + camera_name, fx);\n-\tsetParam(\"PARAM_FCY_\" + camera_name, fy);\n-\tsetParam(\"PARAM_KC1_\" + camera_name, k1);\n-\tsetParam(\"PARAM_KC2_\" + camera_name, k2);\n-\tsetParam(\"PARAM_P1_\" + camera_name, r1);\n-\tsetParam(\"PARAM_P2_\" + camera_name, r2);\n-\tsetParam(\"PARAM_H11_\" + camera_name, H(0, 0));\n-\tsetParam(\"PARAM_H12_\" + camera_name, H(0, 1));\n-\tsetParam(\"PARAM_H13_\" + camera_name, H(0, 2));\n-\tsetParam(\"PARAM_H21_\" + camera_name, H(1, 0));\n-\tsetParam(\"PARAM_H22_\" + camera_name, H(1, 1));\n-\tsetParam(\"PARAM_H23_\" + camera_name, H(1, 2));\n-\tsetParam(\"PARAM_H31_\" + camera_name, H(2, 0));\n-\tsetParam(\"PARAM_H32_\" + camera_name, H(2, 1));\n-\tsetParam(\"PARAM_H33_\" + camera_name, H(2, 2));\n+void uvcROSDriver::sendCameraParam(\n+ const int camera_number, const uvc_ros_driver::DistortionModelTypes dtype,\n+ const double fx, const double fy, const Eigen::Vector2d &p0, const float k1,\n+ const float k2, const float r1, const float r2, const Eigen::Matrix3d &H) {\n+ std::string camera_name = \"CAM\" + std::to_string(camera_number);\n+\n+ setParam(\"PARAM_DM_\" + camera_name, static_cast<int>(dtype));\n+ setParam(\"PARAM_CCX_\" + camera_name, p0[0]);\n+ setParam(\"PARAM_CCY_\" + camera_name, p0[1]);\n+ setParam(\"PARAM_FCX_\" + camera_name, fx);\n+ setParam(\"PARAM_FCY_\" + camera_name, fy);\n+ setParam(\"PARAM_KC1_\" + camera_name, k1);\n+ setParam(\"PARAM_KC2_\" + camera_name, k2);\n+ setParam(\"PARAM_KC3_\" + camera_name, r1);\n+ setParam(\"PARAM_KC4_\" + camera_name, r2);\n+ setParam(\"PARAM_H11_\" + camera_name, H(0, 0));\n+ setParam(\"PARAM_H12_\" + camera_name, H(0, 1));\n+ setParam(\"PARAM_H13_\" + camera_name, H(0, 2));\n+ setParam(\"PARAM_H21_\" + camera_name, H(1, 0));\n+ setParam(\"PARAM_H22_\" + camera_name, H(1, 1));\n+ setParam(\"PARAM_H23_\" + camera_name, H(1, 2));\n+ setParam(\"PARAM_H31_\" + camera_name, H(2, 0));\n+ setParam(\"PARAM_H32_\" + camera_name, H(2, 1));\n+ setParam(\"PARAM_H33_\" + camera_name, H(2, 2));\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-void uvcROSDriver::setCalibration(CameraParameters camParams)\n-{\n-\t// uvc_ros_driver::FPGACalibration cams[n_cameras_];\n-\tstd::vector<uvc_ros_driver::FPGACalibration> cams;\n-\tint stereo_number = 0;\n-\n-\tif (camParams.isValid) {\n-\t\t// TODO: find better way for this, general case not only stereo between\n-\t\t// cam0->cam1, cam2->cam3\n-\t\tfor (int cam = 0; cam < n_cameras_; cam++) {\n-\t\t\tuvc_ros_driver::FPGACalibration camera;\n-\t\t\tcamera.projection_model_.type_ =\n-\t\t\t\tuvc_ros_driver::ProjectionModelTypes::PINHOLE;\n-\t\t\tcamera.projection_model_.focal_length_u_ = camParams.FocalLength[cam][0];\n-\t\t\tcamera.projection_model_.focal_length_v_ = camParams.FocalLength[cam][1];\n-\t\t\tcamera.projection_model_.principal_point_u_ =\n-\t\t\t\tcamParams.PrincipalPoint[cam][0];\n-\t\t\tcamera.projection_model_.principal_point_v_ =\n-\t\t\t\tcamParams.PrincipalPoint[cam][1];\n-\t\t\tcamera.projection_model_.k1_ = camParams.DistortionCoeffs[cam][0];\n-\t\t\tcamera.projection_model_.k2_ = camParams.DistortionCoeffs[cam][1];\n-\t\t\tcamera.projection_model_.r1_ = camParams.DistortionCoeffs[cam][2];\n-\t\t\tcamera.projection_model_.r2_ = camParams.DistortionCoeffs[cam][3];\n-\n-\t\t\tif (cam % 2 != 0) {\n-\t\t\t\tcamera.projection_model_.R_[0] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][0][0];\n-\t\t\t\tcamera.projection_model_.R_[1] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][0][1];\n-\t\t\t\tcamera.projection_model_.R_[2] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][0][2];\n-\t\t\t\tcamera.projection_model_.R_[3] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][1][0];\n-\t\t\t\tcamera.projection_model_.R_[4] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][1][1];\n-\t\t\t\tcamera.projection_model_.R_[5] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][1][2];\n-\t\t\t\tcamera.projection_model_.R_[6] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][2][0];\n-\t\t\t\tcamera.projection_model_.R_[7] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][2][1];\n-\t\t\t\tcamera.projection_model_.R_[8] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][2][2];\n-\t\t\t\tcamera.projection_model_.t_[0] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][0][3];\n-\t\t\t\tcamera.projection_model_.t_[1] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][1][3];\n-\t\t\t\tcamera.projection_model_.t_[2] =\n-\t\t\t\t\tcamParams.StereoTransformationMatrix[stereo_number][2][3];\n-\t\t\t\tstereo_number++;\n-\n-\t\t\t} else {\n-\t\t\t\tcamera.projection_model_.R_[0] = 1.0f;\n-\t\t\t\tcamera.projection_model_.R_[1] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[2] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[3] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[4] = 1.0f;\n-\t\t\t\tcamera.projection_model_.R_[5] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[6] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[7] = 0.0f;\n-\t\t\t\tcamera.projection_model_.R_[8] = 1.0f;\n-\t\t\t\tcamera.projection_model_.t_[0] = 0.0f;\n-\t\t\t\tcamera.projection_model_.t_[1] = 0.0f;\n-\t\t\t\tcamera.projection_model_.t_[2] = 0.0f;\n-\t\t\t}\n-\n-\t\t\tcams.push_back(camera);\n-\t\t}\n-\n-\t\t// initialize vectors\n-\t\tf_.resize(n_cameras_);\n-\t\tp_.resize(n_cameras_);\n-\t\tH_.resize(n_cameras_);\n-\t\t// pointer at camera info\n-\t\tsensor_msgs::CameraInfo *ci;\n-\t\tsize_t homography_size;\n-\n-\t\t// TODO: reimplment this part for multiple stereo base line based systems\n-\t\tif (set_calibration_) {\n-\t\t\tstd::vector<std::pair<int, int> >::iterator it_homography =\n-\t\t\t\tstd::max_element(homography_mapping_.begin(), homography_mapping_.end(),\n-\t\t\t\t\t\t myPairMax);\n-\t\t\t/*if ((*it_homography).second > n_cameras_) {\n-\t\t\t\thomography_size = std::distance(homography_mapping_.begin(), it_homography);\n-\n-\t\t\t} else {\n-\t\t\t\thomography_size = homography_mapping_.size();\n-\t\t\t}*/\n-\t\t\t//set homography number to number of camera pairs for now\n-\t\t\thomography_size = n_cameras_/2;\n-\n-\t\t\tfor (size_t i = 0; i < homography_size; i++) {\n-\t\t\t\t// temp structures\n-\t\t\t\tEigen::Matrix3d H0;\n-\t\t\t\tEigen::Matrix3d H1;\n-\t\t\t\tdouble f_new;\n-\t\t\t\tEigen::Vector2d p0_new, p1_new;\n-\n-\t\t\t\tstd::pair<int, int> indx = homography_mapping_[i];\n-\n-\t\t\t\tStereoHomography h(cams[indx.first], cams[indx.second]);\n-\t\t\t\th.getHomography(H0, H1, f_new, p0_new, p1_new);\n-\n-\t\t\t\tf_[indx.first] = f_new;\n-\t\t\t\tf_[indx.second] = f_new;\n-\t\t\t\tp_[indx.first] = p0_new;\n-\t\t\t\tp_[indx.second] = p1_new;\n-\t\t\t\t// TODO check if matrix is copied or only pointer!!\n-\t\t\t\tH_[indx.first] = H0;\n-\t\t\t\tH_[indx.second] = H1;\n-\t\t\t}\n-\n-\t\t\t// Set all parameters here\n-\t\t\tfor (int i = 0; i < n_cameras_; i++) {\n-\t\t\t\tsendCameraParam(i, f_[i], f_[i], p_[i], cams[i].projection_model_.k1_,\n-\t\t\t\t\t\tcams[i].projection_model_.k2_,\n-\t\t\t\t\t\tcams[i].projection_model_.r1_,\n-\t\t\t\t\t\tcams[i].projection_model_.r2_, H_[i]);\n-\t\t\t\tselectCameraInfo(i, &ci);\n-\t\t\t\tsetCameraInfoIntrinsics(*ci, f_[i], f_[i], p_[i](0), p_[i](1));\n-\t\t\t\tsetCameraInfoDistortionMdl(\n-\t\t\t\t\t*ci, uvc_ros_driver::ProjectionModelTypes::PINHOLE);\n-\t\t\t\tsetCameraInfoDistortionParams(*ci, 0, 0, 0, 0, 0);\n-\t\t\t}\n-\n-\t\t} else {\n-\t\t\tfor (int i = 0; i < n_cameras_; i++) {\n-\t\t\t\tselectCameraInfo(i, &ci);\n-\t\t\t\tsetCameraInfoIntrinsics(\n-\t\t\t\t\t*ci, camParams.FocalLength[i][0], camParams.FocalLength[i][1],\n-\t\t\t\t\tcamParams.PrincipalPoint[i][0], camParams.PrincipalPoint[i][1]);\n-\t\t\t\tsetCameraInfoDistortionMdl(\n-\t\t\t\t\t*ci, uvc_ros_driver::ProjectionModelTypes::PINHOLE);\n-\t\t\t\tsetCameraInfoDistortionParams(\n-\t\t\t\t\t*ci, cams[i].projection_model_.k1_, cams[i].projection_model_.k2_,\n-\t\t\t\t\tcams[i].projection_model_.r1_, cams[i].projection_model_.r2_, 0);\n-\t\t\t}\n-\t\t}\n-\n-\n-\t\t// TODO: implement with class variables\n-\t\t// SGM stereo penalty values p1: discontinuits, p2:\n-\t\tsetParam(\"STEREO_P1_CAM1\", 10.0f);\n-\t\tsetParam(\"STEREO_P2_CAM1\", 250.0f);\n-\t\t// disparity L->R occlusion in px\n-\t\tsetParam(\"STEREO_LR_CAM1\", 3.0f);\n-\t\t// threshold 0-255 valid disparity\n-\t\tsetParam(\"STEREO_TH_CAM1\", 140.0f);\n-\t\tsetParam(\"STEREO_FP_CAM1\", 0.0f);\n-\t\tsetParam(\"STEREO_CE_CAM1\", 0.0f);\n-\t\tsetParam(\"STEREO_RE_CAM1\", 0.0f);\n-\t\tsetParam(\"STEREO_OF_CAM1\", 0.0f);\n-\n-\t\t//setParam(\"COST_SHIFT\", 2.0f);\n-\n-\t\t//setParam(\"CAMERA_AUTOEXP\",0.0f);\n-\t\t//setParam(\"CAMERA_EXP\",480.0f);\n-\t\t//setParam(\"CAMERA_AUTOG\",0.0f);\n-\t\t//setParam(\"CAMERA_GAIN\",63.0f);\n-\n-\t\tsetParam(\"STEREO_MP_01\", 0.0f);\n-\t\tsetParam(\"STEREO_BAYER_D\", 0.0f);\n-\t\tsetParam(\"IMU_ENABLE\",(float)n_cameras_);\n-\t\tsetParam(\"ADIS_IMU\",0.0f);\n-\n-\t\tsetParam(\"STEREO_P1_CAM3\", 10.0f);\n-\t\tsetParam(\"STEREO_P2_CAM3\", 250.0f);\n-\t\tsetParam(\"STEREO_LR_CAM3\", 3.0f);\n-\t\tsetParam(\"STEREO_TH_CAM3\", 140.0f);\n-\t\tsetParam(\"STEREO_FP_CAM3\", 0.0f);\n-\t\tsetParam(\"STEREO_CE_CAM3\", 0.0f);\n-\t\tsetParam(\"STEREO_RE_CAM3\", 0.0f);\n-\t\tsetParam(\"STEREO_OF_CAM3\", 0.0f);\n-\n-\t\tsetParam(\"STEREO_P1_CAM5\", 16.0f);\n-\t\tsetParam(\"STEREO_P2_CAM5\", 240.0f);\n-\t\tsetParam(\"STEREO_LR_CAM5\", 4.0f);\n-\t\tsetParam(\"STEREO_TH_CAM5\", 120.0f);\n-\t\tsetParam(\"STEREO_FP_CAM5\", 0.0f);\n-\t\tsetParam(\"STEREO_CE_CAM5\", 0.0f);\n-\t\tsetParam(\"STEREO_RE_CAM5\", 0.0f);\n-\t\tsetParam(\"STEREO_OF_CAM5\", 0.0f);\n-\n-\t\tsetParam(\"STEREO_P1_CAM7\", 16.0f);\n-\t\tsetParam(\"STEREO_P2_CAM7\", 240.0f);\n-\t\tsetParam(\"STEREO_LR_CAM7\", 4.0f);\n-\t\tsetParam(\"STEREO_TH_CAM7\", 120.0f);\n-\t\tsetParam(\"STEREO_FP_CAM7\", 0.0f);\n-\t\tsetParam(\"STEREO_CE_CAM7\", 0.0f);\n-\t\tsetParam(\"STEREO_RE_CAM7\", 0.0f);\n-\t\tsetParam(\"STEREO_OF_CAM7\", 0.0f);\n-\n-\t\tsetParam(\"STEREO_P1_CAM9\", 16.0f);\n-\t\tsetParam(\"STEREO_P2_CAM9\", 240.0f);\n-\t\tsetParam(\"STEREO_LR_CAM9\", 4.0f);\n-\t\tsetParam(\"STEREO_TH_CAM9\", 120.0f);\n-\t\tsetParam(\"STEREO_FP_CAM9\", 0.0f);\n-\t\tsetParam(\"STEREO_CE_CAM9\", 0.0f);\n-\t\tsetParam(\"STEREO_RE_CAM9\", 0.0f);\n-\t\tsetParam(\"STEREO_OF_CAM9\", 0.0f);\n-\n-\t\tsetParam(\"CALIB_GAIN\", 4300.0f);\n-\n-\t\tsetParam(\"CAMERA_H_FLIP\", float(flip_));\n-\n-\t\tif(flip_){\n-\t\t\tsetParam(\"IM_H_FLIP_CAM0\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM0\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM2\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM2\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM4\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM4\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM6\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM6\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM8\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM8\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM1\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM1\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM3\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM3\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM5\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM5\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM7\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM7\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM9\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM9\", 1.0f);\n-\t\t}\n-\t\telse{\n-\t\t\tsetParam(\"IM_H_FLIP_CAM0\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM0\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM2\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM2\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM4\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM4\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM6\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM6\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM8\", 1.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM8\", 1.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM1\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM1\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM3\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM3\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM5\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM5\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM7\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM7\", 0.0f);\n-\t\t\tsetParam(\"IM_H_FLIP_CAM9\", 0.0f);\n-\t\t\tsetParam(\"IM_V_FLIP_CAM9\", 0.0f);\n-\t\t}\n-\n-\t}\n-\n-\t/*if (set_calibration_) {\n-\t\tsetParam(\"RESETCALIB\", 0.0f);\n-\n-\t} else {\n-\t\tsetParam(\"RESETCALIB\", 1.0f);\n-\t}*/\n-\n-\n-\tsetParam(\"SETCALIB\", float(set_calibration_));\n-\n-\t// std::cout << \"Configuring cameras...\" << std::endl;\n-\tsetParam(\"RESETMT9V034\", 1.0f);\n-\tsetParam(\"RESETICM20608\",1.0f);\n-\t// sleep(5); // needed, fpga reconfigure cameras and restart time\n-\t// std::cout << \"Configuration completed.\" << std::endl;\n-\t// last 4 bits activate the 4 camera pairs 0x01 = pair 1 only, 0x0F all 4\n-\t// pairs\n-\t//setParam(\"CAMERA_ENABLE\", float(camera_config_));\n+void uvcROSDriver::setCalibration(CameraParameters camParams) {\n+ std::vector<uvc_ros_driver::FPGACalibration> cams;\n+ int stereo_number = 0;\n+\n+ if (camParams.isValid) {\n+ // TODO: find better way for this, general case not only stereo between\n+ // cam0->cam1, cam2->cam3\n+ for (int cam = 0; cam < n_cameras_; cam++) {\n+ uvc_ros_driver::FPGACalibration camera;\n+ camera.projection_model_.projection_type_ =\n+ uvc_ros_driver::ProjectionModelTypes::PINHOLE;\n+ camera.projection_model_.distortion_type_ =\n+ static_cast<uvc_ros_driver::DistortionModelTypes>(\n+ camParams.DistortionModel[cam]);\n+ camera.projection_model_.focal_length_u_ = camParams.FocalLength[cam][0];\n+ camera.projection_model_.focal_length_v_ = camParams.FocalLength[cam][1];\n+ camera.projection_model_.principal_point_u_ =\n+ camParams.PrincipalPoint[cam][0];\n+ camera.projection_model_.principal_point_v_ =\n+ camParams.PrincipalPoint[cam][1];\n+ camera.projection_model_.k1_ = camParams.DistortionCoeffs[cam][0];\n+ camera.projection_model_.k2_ = camParams.DistortionCoeffs[cam][1];\n+ camera.projection_model_.r1_ = camParams.DistortionCoeffs[cam][2];\n+ camera.projection_model_.r2_ = camParams.DistortionCoeffs[cam][3];\n+\n+ if (cam % 2 != 0) {\n+ camera.projection_model_.R_[0] =\n+ camParams.StereoTransformationMatrix[stereo_number][0][0];\n+ camera.projection_model_.R_[1] =\n+ camParams.StereoTransformationMatrix[stereo_number][0][1];\n+ camera.projection_model_.R_[2] =\n+ camParams.StereoTransformationMatrix[stereo_number][0][2];\n+ camera.projection_model_.R_[3] =\n+ camParams.StereoTransformationMatrix[stereo_number][1][0];\n+ camera.projection_model_.R_[4] =\n+ camParams.StereoTransformationMatrix[stereo_number][1][1];\n+ camera.projection_model_.R_[5] =\n+ camParams.StereoTransformationMatrix[stereo_number][1][2];\n+ camera.projection_model_.R_[6] =\n+ camParams.StereoTransformationMatrix[stereo_number][2][0];\n+ camera.projection_model_.R_[7] =\n+ camParams.StereoTransformationMatrix[stereo_number][2][1];\n+ camera.projection_model_.R_[8] =\n+ camParams.StereoTransformationMatrix[stereo_number][2][2];\n+ camera.projection_model_.t_[0] =\n+ camParams.StereoTransformationMatrix[stereo_number][0][3];\n+ camera.projection_model_.t_[1] =\n+ camParams.StereoTransformationMatrix[stereo_number][1][3];\n+ camera.projection_model_.t_[2] =\n+ camParams.StereoTransformationMatrix[stereo_number][2][3];\n+ stereo_number++;\n+\n+ } else {\n+ camera.projection_model_.R_[0] = 1.0f;\n+ camera.projection_model_.R_[1] = 0.0f;\n+ camera.projection_model_.R_[2] = 0.0f;\n+ camera.projection_model_.R_[3] = 0.0f;\n+ camera.projection_model_.R_[4] = 1.0f;\n+ camera.projection_model_.R_[5] = 0.0f;\n+ camera.projection_model_.R_[6] = 0.0f;\n+ camera.projection_model_.R_[7] = 0.0f;\n+ camera.projection_model_.R_[8] = 1.0f;\n+ camera.projection_model_.t_[0] = 0.0f;\n+ camera.projection_model_.t_[1] = 0.0f;\n+ camera.projection_model_.t_[2] = 0.0f;\n+ }\n+\n+ cams.push_back(camera);\n+ }\n+\n+ // initialize vectors\n+ f_.resize(n_cameras_);\n+ p_.resize(n_cameras_);\n+ H_.resize(n_cameras_);\n+ // pointer at camera info\n+ sensor_msgs::CameraInfo *ci;\n+ size_t homography_size;\n+\n+ // TODO: reimplment this part for multiple stereo base line based systems\n+ if (set_calibration_) {\n+ std::vector<std::pair<int, int> >::iterator it_homography =\n+ std::max_element(homography_mapping_.begin(),\n+ homography_mapping_.end(), myPairMax);\n+\n+ // set homography number to number of camera pairs for now\n+ homography_size = n_cameras_ / 2;\n+\n+ for (size_t i = 0; i < homography_size; i++) {\n+ // temp structures\n+ Eigen::Matrix3d H0;\n+ Eigen::Matrix3d H1;\n+ double f_new;\n+ Eigen::Vector2d p0_new, p1_new;\n+\n+ std::pair<int, int> indx = homography_mapping_[i];\n+\n+ StereoHomography h(cams[indx.first], cams[indx.second]);\n+ h.getHomography(H0, H1, f_new, p0_new, p1_new);\n+\n+ f_[indx.first] = f_new;\n+ f_[indx.second] = f_new;\n+ p_[indx.first] = p0_new;\n+ p_[indx.second] = p1_new;\n+ // TODO check if matrix is copied or only pointer!!\n+ H_[indx.first] = H0;\n+ H_[indx.second] = H1;\n+ }\n+\n+ // Set all parameters here\n+ for (int i = 0; i < n_cameras_; i++) {\n+ sendCameraParam(i, cams[i].projection_model_.distortion_type_, f_[i],\n+ f_[i], p_[i], cams[i].projection_model_.k1_,\n+ cams[i].projection_model_.k2_,\n+ cams[i].projection_model_.r1_,\n+ cams[i].projection_model_.r2_, H_[i]);\n+ setCameraInfoIntrinsics(info_cams_[i], f_[i], f_[i], p_[i](0),\n+ p_[i](1));\n+ setCameraInfoDistortionMdl(\n+ info_cams_[i], uvc_ros_driver::ProjectionModelTypes::PINHOLE);\n+ setCameraInfoDistortionParams(info_cams_[i], 0, 0, 0, 0, 0);\n+ }\n+\n+ } else {\n+ for (int i = 0; i < n_cameras_; i++) {\n+ setCameraInfoIntrinsics(info_cams_[i], camParams.FocalLength[i][0],\n+ camParams.FocalLength[i][1],\n+ camParams.PrincipalPoint[i][0],\n+ camParams.PrincipalPoint[i][1]);\n+ setCameraInfoDistortionMdl(\n+ info_cams_[i], uvc_ros_driver::ProjectionModelTypes::PINHOLE);\n+ setCameraInfoDistortionParams(\n+ info_cams_[i], cams[i].projection_model_.k1_,\n+ cams[i].projection_model_.k2_, cams[i].projection_model_.r1_,\n+ cams[i].projection_model_.r2_, 0);\n+ }\n+ }\n+\n+ // TODO: implement with class variables\n+ // SGM stereo penalty values p1: discontinuits, p2:\n+ setParam(\"STEREO_P1_CAM1\", 10.0f);\n+ setParam(\"STEREO_P2_CAM1\", 250.0f);\n+ // disparity L->R occlusion in px\n+ setParam(\"STEREO_LR_CAM1\", 3.0f);\n+ // threshold 0-255 valid disparity\n+ setParam(\"STEREO_TH_CAM1\", 140.0f);\n+ setParam(\"STEREO_FP_CAM1\", 0.0f);\n+ setParam(\"STEREO_CE_CAM1\", 0.0f);\n+ setParam(\"STEREO_RE_CAM1\", 0.0f);\n+ setParam(\"STEREO_OF_CAM1\", 0.0f);\n+\n+ setParam(\"STEREO_MP_01\", 0.0f);\n+ setParam(\"STEREO_BAYER_D\", 0.0f);\n+ setParam(\"IMU_ENABLE\", static_cast<float>(n_cameras_));\n+ setParam(\"ADIS_IMU\", 0.0f);\n+\n+ setParam(\"STEREO_P1_CAM3\", 10.0f);\n+ setParam(\"STEREO_P2_CAM3\", 250.0f);\n+ setParam(\"STEREO_LR_CAM3\", 3.0f);\n+ setParam(\"STEREO_TH_CAM3\", 140.0f);\n+ setParam(\"STEREO_FP_CAM3\", 0.0f);\n+ setParam(\"STEREO_CE_CAM3\", 0.0f);\n+ setParam(\"STEREO_RE_CAM3\", 0.0f);\n+ setParam(\"STEREO_OF_CAM3\", 0.0f);\n+\n+ setParam(\"STEREO_P1_CAM5\", 16.0f);\n+ setParam(\"STEREO_P2_CAM5\", 240.0f);\n+ setParam(\"STEREO_LR_CAM5\", 4.0f);\n+ setParam(\"STEREO_TH_CAM5\", 120.0f);\n+ setParam(\"STEREO_FP_CAM5\", 0.0f);\n+ setParam(\"STEREO_CE_CAM5\", 0.0f);\n+ setParam(\"STEREO_RE_CAM5\", 0.0f);\n+ setParam(\"STEREO_OF_CAM5\", 0.0f);\n+\n+ setParam(\"STEREO_P1_CAM7\", 16.0f);\n+ setParam(\"STEREO_P2_CAM7\", 240.0f);\n+ setParam(\"STEREO_LR_CAM7\", 4.0f);\n+ setParam(\"STEREO_TH_CAM7\", 120.0f);\n+ setParam(\"STEREO_FP_CAM7\", 0.0f);\n+ setParam(\"STEREO_CE_CAM7\", 0.0f);\n+ setParam(\"STEREO_RE_CAM7\", 0.0f);\n+ setParam(\"STEREO_OF_CAM7\", 0.0f);\n+\n+ setParam(\"STEREO_P1_CAM9\", 16.0f);\n+ setParam(\"STEREO_P2_CAM9\", 240.0f);\n+ setParam(\"STEREO_LR_CAM9\", 4.0f);\n+ setParam(\"STEREO_TH_CAM9\", 120.0f);\n+ setParam(\"STEREO_FP_CAM9\", 0.0f);\n+ setParam(\"STEREO_CE_CAM9\", 0.0f);\n+ setParam(\"STEREO_RE_CAM9\", 0.0f);\n+ setParam(\"STEREO_OF_CAM9\", 0.0f);\n+\n+ setParam(\"CALIB_GAIN\", 4300.0f);\n+\n+ setParam(\"CAMERA_H_FLIP\", static_cast<float>(flip_));\n+ setParam(\"P_MODE\", static_cast<float>(primary_camera_mode_));\n+\n+ if (flip_) {\n+ setParam(\"IM_H_FLIP_CAM0\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM0\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM2\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM2\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM4\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM4\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM6\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM6\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM8\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM8\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM1\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM1\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM3\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM3\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM5\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM5\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM7\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM7\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM9\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM9\", 1.0f);\n+ } else {\n+ setParam(\"IM_H_FLIP_CAM0\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM0\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM2\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM2\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM4\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM4\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM6\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM6\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM8\", 1.0f);\n+ setParam(\"IM_V_FLIP_CAM8\", 1.0f);\n+ setParam(\"IM_H_FLIP_CAM1\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM1\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM3\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM3\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM5\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM5\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM7\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM7\", 0.0f);\n+ setParam(\"IM_H_FLIP_CAM9\", 0.0f);\n+ setParam(\"IM_V_FLIP_CAM9\", 0.0f);\n+ }\n+ }\n+\n+ setParam(\"SETCALIB\", float(set_calibration_));\n+\n+ setParam(\"RESETMT9V034\", 1.0f);\n+ setParam(\"RESETICM20608\", 1.0f);\n+}\n \n+void uvcROSDriver::dynamicReconfigureCallback(\n+ uvc_ros_driver::UvcDriverConfig &config, uint32_t level) {\n+ if (!shutdown_) {\n+ setParam(\"CAMERA_AUTOEXP\", static_cast<float>(config.CAMERA_AUTOEXP));\n+ setParam(\"CAMERA_EXP\", static_cast<float>(config.CAMERA_EXP));\n+ setParam(\"CAMERA_MIN_E\", static_cast<float>(config.CAMERA_MIN_E));\n+ setParam(\"CAMERA_MAX_E\", static_cast<float>(config.CAMERA_MAX_E));\n+ setParam(\"CAMERA_AUTOG\", static_cast<float>(config.CAMERA_AUTOG));\n+ setParam(\"CAMERA_GAIN\", static_cast<float>(config.CAMERA_GAIN));\n+ setParam(\"P_MODE\", static_cast<float>(config.PRIMARY_CAM_MODE));\n+\n+ setParam(\"IM_H_FLIP_CAM0\", static_cast<float>(config.CAMERA_0_HFLIP));\n+ setParam(\"IM_V_FLIP_CAM0\", static_cast<float>(config.CAMERA_0_VFLIP));\n+\n+ setParam(\"ADIS_IMU\", static_cast<float>(config.ADIS_IMU));\n+ // update camera parameters in FPGA\n+ setParam(\"UPDATEMT9V034\", 1.0f);\n+\n+ raw_enabled_ = config.RAW_ENABLED;\n+ setParam(\"CAMERA_ENABLE\",static_cast<float>(buildCameraConfig()));\n+\n+ setParam(\"STEREO_RE_CAM1\", static_cast<float>(config.STEREO_RE_CAM1));\n+ setParam(\"STEREO_CE_CAM1\", static_cast<float>(config.STEREO_CE_CAM1));\n+ setParam(\"STEREO_TH_CAM1\", static_cast<float>(config.STEREO_TH_CAM1));\n+ setParam(\"STEREO_LR_CAM1\", static_cast<float>(config.STEREO_LR_CAM1));\n+ setParam(\"STEREO_OF_CAM1\", static_cast<float>(config.STEREO_OF_CAM1));\n+ setParam(\"STEREO_P1_CAM1\", static_cast<float>(config.STEREO_P1_CAM1));\n+ setParam(\"STEREO_P2_CAM1\", static_cast<float>(config.STEREO_P2_CAM1));\n+ setParam(\"STEREO_BAYER_D\", static_cast<float>(config.STEREO_BAYER_D));\n+ // update stereo parameters in FPGA\n+ setParam(\"SETCALIB\", 1.0f);\n+ }\n }\n \n ////////////////////////////////////////////////////////////////////////////////\n // NOTE: return error really necessary?\n-uvc_error_t uvcROSDriver::initAndOpenUvc()\n-{\n-\tuvc_error_t res;\n-\t/* Initialize a UVC service context. Libuvc will set up its own libusb\n-\t* context. Replace NULL with a libusb_context pointer to run libuvc\n-\t* from an existing libusb context. */\n-\tres = uvc_init(&ctx_, NULL);\n-\n-\tif (res < 0) {\n-\t\tuvc_perror(res, \"uvc_init\");\n-\t\tROS_ERROR(\"Unable to initialize uvc service context\");\n-\t\treturn res;\n-\t}\n-\n-\t/* Locates the first attached UVC device, stores in dev */\n-\t/* filter devices: vendor_id, product_id, \"serial_num\" */\n-\tres = uvc_find_device(ctx_, &dev_, 0x04b4, 0, NULL);\n-\n-\tif (res < 0) {\n-\t\tuvc_perror(res, \"uvc_find_device\"); /* no devices found */\n-\t\tROS_ERROR(\"No devices found\");\n-\t\treturn res;\n-\t}\n-\n-\tROS_INFO(\"Device found\");\n-\n-\t/* Try to open the device: requires exclusive access */\n-\tres = uvc_open(dev_, &devh_);\n-\n-\tif (res < 0) {\n-\t\tuvc_perror(res, \"uvc_open\"); /* unable to open device */\n-\t\tROS_ERROR(\"Unable to open the device\");\n-\t\treturn res;\n-\t}\n-\n-\t// ?????????\n-\t// uvc_device_descriptor_t *desc;\n-\t// uvc_get_device_descriptor(dev_, &desc);\n-\t// uvc_free_device_descriptor(desc);\n-\n-\t/* Try to negotiate a 640x480 30 fps YUYV stream profile */\n-\tres = uvc_get_stream_ctrl_format_size(\n-\t\t devh_, &ctrl_, /* result stored in ctrl */\n-\t\t UVC_FRAME_FORMAT_YUYV, /* YUV 422, aka YUV 4:2:2. try _COMPRESSED */\n-\t\t raw_width_, raw_height_, 30 /* width, height, fps */\n-\t );\n-\n-\tif (res < 0) {\n-\t\t/* device doesn't provide a matching stream */\n-\t\tuvc_perror(res, \"get_mode\");\n-\t\tROS_ERROR(\"Device doesn't provide a matching stream\");\n-\t\treturn res;\n-\t}\n-\n-\treturn res;\n+uvc_error_t uvcROSDriver::initAndOpenUvc() {\n+ uvc_error_t res;\n+ /* Initialize a UVC service context. Libuvc will set up its own libusb\n+ * context. Replace NULL with a libusb_context pointer to run libuvc\n+ * from an existing libusb context. */\n+ res = uvc_init(&ctx_, NULL);\n+\n+ if (res < 0) {\n+ uvc_perror(res, \"uvc_init\");\n+ ROS_ERROR(\"Unable to initialize uvc service context\");\n+ return res;\n+ }\n+\n+ /* Locates the first attached UVC device, stores in dev */\n+ /* filter devices: vendor_id, product_id, \"serial_num\" */\n+ res = uvc_find_device(ctx_, &dev_, 0x04b4, 0, NULL);\n+\n+ if (res < 0) {\n+ uvc_perror(res, \"uvc_find_device\"); /* no devices found */\n+ ROS_ERROR(\"No devices found\");\n+ return res;\n+ }\n+\n+ ROS_INFO(\"Device found\");\n+\n+ /* Try to open the device: requires exclusive access */\n+ res = uvc_open(dev_, &devh_);\n+\n+ if (res < 0) {\n+ uvc_perror(res, \"uvc_open\"); /* unable to open device */\n+ ROS_ERROR(\"Unable to open the device\");\n+ return res;\n+ }\n+\n+ /* Try to negotiate a 640x480 30 fps YUYV stream profile */\n+ res = uvc_get_stream_ctrl_format_size(\n+ devh_, &ctrl_, /* result stored in ctrl */\n+ UVC_FRAME_FORMAT_YUYV, /* YUV 422, aka YUV 4:2:2. try _COMPRESSED */\n+ raw_width_, raw_height_, 30 /* width, height, fps */\n+ );\n+\n+ if (res < 0) {\n+ /* device doesn't provide a matching stream */\n+ uvc_perror(res, \"get_mode\");\n+ ROS_ERROR(\"Device doesn't provide a matching stream\");\n+ return res;\n+ }\n+\n+ return res;\n }\n \n-////////////////////////////////////////////////////////////////////////////////\n+uint8_t *uvcROSDriver::rawDataPtr(const uvc_frame_t *frame, const size_t line,\n+ const size_t offset) {\n+ return &(static_cast<uint8_t *>(\n+ frame->data)[2 * ((line + 1) * frame->width - offset)]);\n+}\n \n-int16_t uvcROSDriver::ShortSwap(int16_t s)\n-{\n-\tunsigned char b1, b2;\n-\tb1 = s & 255;\n-\tb2 = (s >> 8) & 255;\n-\treturn (b1 << 8) + b2;\n+uint8_t uvcROSDriver::readUInt8(const uvc_frame_t *frame, const size_t line,\n+ const size_t offset) {\n+ return *rawDataPtr(frame, line, offset);\n }\n \n-////////////////////////////////////////////////////////////////////////////////\n+int16_t uvcROSDriver::readInt16(const uvc_frame_t *frame, const size_t line,\n+ const size_t offset) {\n+ const uint8_t *data = rawDataPtr(frame, line, offset);\n+ uint16_t value = static_cast<uint16_t>((data[1] << 0) | (data[0] << 8));\n+ return *reinterpret_cast<int16_t *>(&value);\n+}\n+\n+uint32_t uvcROSDriver::readUInt32(const uvc_frame_t *frame, const size_t line,\n+ const size_t offset) {\n+ const uint8_t *data = rawDataPtr(frame, line, offset);\n \n-inline void uvcROSDriver::selectCameraInfo(int camera,\n-\t\tsensor_msgs::CameraInfo **ci)\n-{\n-\tswitch (camera) {\n-\tcase 0:\n-\t\t*ci = &info_cam_0_;\n-\t\tbreak;\n-\n-\tcase 1:\n-\t\t*ci = &info_cam_1_;\n-\t\tbreak;\n-\n-\tcase 2:\n-\t\t*ci = &info_cam_2_;\n-\t\tbreak;\n-\n-\tcase 3:\n-\t\t*ci = &info_cam_3_;\n-\t\tbreak;\n-\n-\tcase 4:\n-\t\t*ci = &info_cam_4_;\n-\t\tbreak;\n-\n-\tcase 5:\n-\t\t*ci = &info_cam_5_;\n-\t\tbreak;\n-\n-\tcase 6:\n-\t\t*ci = &info_cam_6_;\n-\t\tbreak;\n-\n-\tcase 7:\n-\t\t*ci = &info_cam_7_;\n-\t\tbreak;\n-\n-\tcase 8:\n-\t\t*ci = &info_cam_8_;\n-\t\tbreak;\n-\n-\tcase 9:\n-\t\t*ci = &info_cam_9_;\n-\t\tbreak;\n-\t}\n+ const uint32_t value =\n+ (data[3] << 0) | (data[2] << 8) | (data[1] << 16) | (data[0] << 24);\n+ return value;\n }\n \n-////////////////////////////////////////////////////////////////////////////////\n+bool uvcROSDriver::extractAndTranslateTimestamp(size_t line,\n+ bool update_translator,\n+ uvc_frame_t *frame,\n+ ros::Time *stamp) {\n+ // read out micro second timestamp\n+ constexpr size_t kTimestampOffset = 10;\n+ const uint32_t fpga_timestamp = readUInt32(frame, line, kTimestampOffset);\n+\n+ if (fpga_timestamp == 0) {\n+ return false;\n+ }\n+\n+ constexpr uint64_t kMicroSecondsToNanoSeconds = 1e3;\n+ const uint64_t fpga_timestamp_64 =\n+ static_cast<uint64_t>(fpga_timestamp) * kMicroSecondsToNanoSeconds;\n+\n+ // only update on image timestamps\n+ if (update_translator) {\n+ device_time_translator_->update(fpga_timestamp_64, ros::Time::now());\n+ }\n+\n+ if (device_time_translator_->isReadyToTranslate()) {\n+ *stamp = device_time_translator_->translate(fpga_timestamp);\n+ } else {\n+ return false;\n+ }\n+\n+ return true;\n+}\n+\n+CamID uvcROSDriver::extractCamId(uvc_frame_t *frame) {\n+ constexpr uint8_t kMaxCams = 10;\n+ constexpr size_t kCamIdOffset = 8;\n+ constexpr size_t kCamIdLine = 0;\n+ constexpr size_t kCamIdShift = 4;\n+ constexpr size_t kImagesPerFrame = 2;\n+ constexpr size_t kRectOffset = 8;\n+\n+ const uint8_t raw_id =\n+ readUInt8(frame, kCamIdLine, kCamIdOffset) >> kCamIdShift;\n+\n+ CamID cam_id;\n+ if (raw_id < kMaxCams / 2) {\n+ cam_id.left_cam_num = kImagesPerFrame * raw_id;\n+ cam_id.right_cam_num = cam_id.left_cam_num + 1;\n+ cam_id.is_raw_images = true;\n+ } else {\n+ cam_id.left_cam_num = kImagesPerFrame * (raw_id - kRectOffset);\n+ cam_id.right_cam_num = cam_id.left_cam_num;\n+ cam_id.is_raw_images = false;\n+ }\n+\n+ return cam_id;\n+}\n+\n+uint8_t uvcROSDriver::extractImuId(uvc_frame_t *frame) {\n+ constexpr size_t kImuIdOffset = 8;\n+ constexpr size_t kImuIdLine = 0;\n+ constexpr uint8_t kImuIdMask = 0x0F;\n+\n+ return readUInt8(frame, kImuIdLine, kImuIdOffset) & kImuIdMask;\n+}\n+\n+uint8_t uvcROSDriver::extractImuCount(size_t line, uvc_frame_t *frame) {\n+ constexpr size_t kImuCountOffset = 9;\n+ return readUInt8(frame, line, kImuCountOffset);\n+}\n+\n+bool uvcROSDriver::extractImuData(size_t line, uvc_frame_t *frame,\n+ sensor_msgs::Imu *msg) {\n+ if (!extractAndTranslateTimestamp(line, false, frame, &msg->header.stamp)) {\n+ return false;\n+ }\n+\n+ msg->linear_acceleration.x =\n+ extractImuElementData(line, ImuElement::AX, frame);\n+ msg->linear_acceleration.y =\n+ extractImuElementData(line, ImuElement::AY, frame);\n+ msg->linear_acceleration.z =\n+ extractImuElementData(line, ImuElement::AZ, frame);\n+\n+ msg->angular_velocity.x = extractImuElementData(line, ImuElement::RX, frame);\n+ msg->angular_velocity.y = extractImuElementData(line, ImuElement::RY, frame);\n+ msg->angular_velocity.z = extractImuElementData(line, ImuElement::RZ, frame);\n+\n+ return true;\n+}\n+\n+double uvcROSDriver::extractImuElementData(size_t line, ImuElement element,\n+ uvc_frame_t *frame) {\n+\n+ constexpr double kDeg2Rad = 2 * M_PI / 360.0;\n+ constexpr double kGravity = 9.807;\n+ \n+ // Standard IMU\n+ //constexpr double kAccScaleFactor = kGravity / 16384.0;\n+ //constexpr double kGyrScaleFactor = kDeg2Rad / 131.0;\n+ \n+ // Scaling factors for ADIS.\n+ constexpr double kAccScaleFactor = kGravity / 4000.0;\n+ constexpr double kGyrScaleFactor = kDeg2Rad / 100.0;","path":"src/uvc_ros_driver.cpp","position":1470,"original_position":1470,"commit_id":"69d071061b8d10a542f234547f8307b1ed7f927e","original_commit_id":"69d071061b8d10a542f234547f8307b1ed7f927e","user":{"login":"marco-tranzatto","id":5328930,"avatar_url":"https://avatars0.githubusercontent.com/u/5328930?v=4","gravatar_id":"","url":"https://api.github.com/users/marco-tranzatto","html_url":"https://github.com/marco-tranzatto","followers_url":"https://api.github.com/users/marco-tranzatto/followers","following_url":"https://api.github.com/users/marco-tranzatto/following{/other_user}","gists_url":"https://api.github.com/users/marco-tranzatto/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-tranzatto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-tranzatto/subscriptions","organizations_url":"https://api.github.com/users/marco-tranzatto/orgs","repos_url":"https://api.github.com/users/marco-tranzatto/repos","events_url":"https://api.github.com/users/marco-tranzatto/events{/privacy}","received_events_url":"https://api.github.com/users/marco-tranzatto/received_events","type":"User","site_admin":false},"body":"same, why in function?","created_at":"2018-03-09T16:43:00Z","updated_at":"2018-03-09T16:59:50Z","html_url":"https://github.com/ethz-asl/uvc_ros_driver/pull/1#discussion_r173502976","pull_request_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/comments/173502976"},"html":{"href":"https://github.com/ethz-asl/uvc_ros_driver/pull/1#discussion_r173502976"},"pull_request":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1","id":173795638,"html_url":"https://github.com/ethz-asl/uvc_ros_driver/pull/1","diff_url":"https://github.com/ethz-asl/uvc_ros_driver/pull/1.diff","patch_url":"https://github.com/ethz-asl/uvc_ros_driver/pull/1.patch","issue_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/1","number":1,"state":"open","locked":false,"title":"Feature/refactor","user":{"login":"ZacharyTaylor","id":730680,"avatar_url":"https://avatars0.githubusercontent.com/u/730680?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacharyTaylor","html_url":"https://github.com/ZacharyTaylor","followers_url":"https://api.github.com/users/ZacharyTaylor/followers","following_url":"https://api.github.com/users/ZacharyTaylor/following{/other_user}","gists_url":"https://api.github.com/users/ZacharyTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacharyTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacharyTaylor/subscriptions","organizations_url":"https://api.github.com/users/ZacharyTaylor/orgs","repos_url":"https://api.github.com/users/ZacharyTaylor/repos","events_url":"https://api.github.com/users/ZacharyTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ZacharyTaylor/received_events","type":"User","site_admin":false},"body":"Large number of changes\r\n\r\nShould have pretty much the same functionality as the current driver but be a bit easier to read. I merged in the dynamic_rqt branch but all my changes are mainly in uvc_ros_driver.cpp\r\n\r\n-Switch to catkin_simple and yaml_cpp_catkin for easier building\r\n-Switch to cuckoo time translator for more robust timestamping\r\n-Switch to image_transport for images\r\n-Replace all switch statements with indexing\r\n-Removed a large amount of code repetition\r\n-Replace implementation specific neon instructions with valarrays\r\n-Made dedicated functions to replace some of the low level byte operations","created_at":"2018-03-08T17:12:15Z","updated_at":"2018-03-09T16:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0376e5cc29bb6f0776ce67f321699c6617db5283","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/1/comments","statuses_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/statuses/69d071061b8d10a542f234547f8307b1ed7f927e","head":{"label":"ethz-asl:feature/refactor","ref":"feature/refactor","sha":"69d071061b8d10a542f234547f8307b1ed7f927e","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":124098241,"name":"uvc_ros_driver","full_name":"ethz-asl/uvc_ros_driver","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/uvc_ros_driver","description":"A ros node to stream images from a multi-camera UVC device","fork":true,"url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver","forks_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/forks","keys_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/teams","hooks_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/events","assignees_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/tags","blobs_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/subscription","commits_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/merges","archive_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/downloads","issues_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/deployments","created_at":"2018-03-06T15:26:59Z","updated_at":"2018-03-08T17:16:22Z","pushed_at":"2018-03-09T13:35:12Z","git_url":"git://github.com/ethz-asl/uvc_ros_driver.git","ssh_url":"git@github.com:ethz-asl/uvc_ros_driver.git","clone_url":"https://github.com/ethz-asl/uvc_ros_driver.git","svn_url":"https://github.com/ethz-asl/uvc_ros_driver","homepage":null,"size":309,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"fac700930f18a9eb498571ec0c51a4fb3655cb63","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":124098241,"name":"uvc_ros_driver","full_name":"ethz-asl/uvc_ros_driver","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars0.githubusercontent.com/u/475362?v=4","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/uvc_ros_driver","description":"A ros node to stream images from a multi-camera UVC device","fork":true,"url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver","forks_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/forks","keys_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/teams","hooks_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/events","assignees_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/tags","blobs_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/subscription","commits_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/merges","archive_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/downloads","issues_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/deployments","created_at":"2018-03-06T15:26:59Z","updated_at":"2018-03-08T17:16:22Z","pushed_at":"2018-03-09T13:35:12Z","git_url":"git://github.com/ethz-asl/uvc_ros_driver.git","ssh_url":"git@github.com:ethz-asl/uvc_ros_driver.git","clone_url":"https://github.com/ethz-asl/uvc_ros_driver.git","svn_url":"https://github.com/ethz-asl/uvc_ros_driver","homepage":null,"size":309,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1"},"html":{"href":"https://github.com/ethz-asl/uvc_ros_driver/pull/1"},"issue":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/1"},"comments":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/uvc_ros_driver/statuses/69d071061b8d10a542f234547f8307b1ed7f927e"}},"author_association":"NONE"}} | {
"id": 124098241,
"name": "ethz-asl/uvc_ros_driver",
"url": "https://api.github.com/repos/ethz-asl/uvc_ros_driver"
} | {
"id": 5328930,
"login": "marco-tranzatto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5328930?",
"url": "https://api.github.com/users/marco-tranzatto"
} | {
"id": 475362,
"login": "ethz-asl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/475362?",
"url": "https://api.github.com/orgs/ethz-asl"
} | 2018-03-09T16:43:00 | 7357120379 | {"actor":{"display_login":"marco-tranzatto"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/adobe/brackets/pulls/comments/184306229","pull_request_review_id":115472540,"id":184306229,"diff_hunk":"@@ -212,26 +215,143 @@ define(function (require, exports, module) {\n }\n \n // Send Analytics data to Server\n- function sendAnalyticsDataToServer(eventParams) {\n+ function sendOrSaveAnalyticsData(eventParams) {\n+ var result = new $.Deferred();\n+ var unsentEventFileLocation = FileSystem.getFileForPath(brackets.app.getApplicationSupportDirectory() + \"/unsentEventFile.txt\");\n+\n+ if(window.navigator.onLine){\n+ internetAvailableSendAllEvents(unsentEventFileLocation, eventParams).done(function() {\n+ result.resolve();\n+ });\n+ }else {\n+ internetUnavailableSaveEventsToDisk(unsentEventFileLocation, eventParams).done(function() {\n+ result.resolve();\n+ }).fail(function () {\n+ result.reject();\n+ });\n+ }\n+ return result.promise();\n+ }\n+\n+ /*\n+ * Called when internet is available. Check whether the local log file has any content\n+ * If it is has, add those to event array while sending to ingest as a single request\n+ */\n+\n+ function internetAvailableSendAllEvents(unsentEventFileLocation, eventParams) {\n+ var result = new $.Deferred();\n+ var analyticsData = [];\n+\n+ unsentEventFileLocation.exists(function (err, exists) {\n+ if (err) {\n+ // logging the error but will still send the current eventParams which needs to be logged\n+ console.error(\"Error while checking if the error log file exits or not\");","path":"src/extensions/default/HealthData/HealthDataManager.js","position":54,"original_position":54,"commit_id":"6a7f263df16c0e934bd330cb05540fc3cb107d8a","original_commit_id":"6a7f263df16c0e934bd330cb05540fc3cb107d8a","user":{"login":"vickramdhawal","id":23508242,"avatar_url":"https://avatars0.githubusercontent.com/u/23508242?v=4","gravatar_id":"","url":"https://api.github.com/users/vickramdhawal","html_url":"https://github.com/vickramdhawal","followers_url":"https://api.github.com/users/vickramdhawal/followers","following_url":"https://api.github.com/users/vickramdhawal/following{/other_user}","gists_url":"https://api.github.com/users/vickramdhawal/gists{/gist_id}","starred_url":"https://api.github.com/users/vickramdhawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vickramdhawal/subscriptions","organizations_url":"https://api.github.com/users/vickramdhawal/orgs","repos_url":"https://api.github.com/users/vickramdhawal/repos","events_url":"https://api.github.com/users/vickramdhawal/events{/privacy}","received_events_url":"https://api.github.com/users/vickramdhawal/received_events","type":"User","site_admin":false},"body":"nit: exists.","created_at":"2018-04-26T08:22:28Z","updated_at":"2018-04-26T08:43:52Z","html_url":"https://github.com/adobe/brackets/pull/14259#discussion_r184306229","pull_request_url":"https://api.github.com/repos/adobe/brackets/pulls/14259","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments/184306229"},"html":{"href":"https://github.com/adobe/brackets/pull/14259#discussion_r184306229"},"pull_request":{"href":"https://api.github.com/repos/adobe/brackets/pulls/14259"}}},"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/14259","id":184140701,"html_url":"https://github.com/adobe/brackets/pull/14259","diff_url":"https://github.com/adobe/brackets/pull/14259.diff","patch_url":"https://github.com/adobe/brackets/pull/14259.patch","issue_url":"https://api.github.com/repos/adobe/brackets/issues/14259","number":14259,"state":"open","locked":false,"title":"<WIP Do not Merge>Handling events not sent to Adobe Analytics because of internet unavailability","user":{"login":"SnchitGrover","id":22751886,"avatar_url":"https://avatars0.githubusercontent.com/u/22751886?v=4","gravatar_id":"","url":"https://api.github.com/users/SnchitGrover","html_url":"https://github.com/SnchitGrover","followers_url":"https://api.github.com/users/SnchitGrover/followers","following_url":"https://api.github.com/users/SnchitGrover/following{/other_user}","gists_url":"https://api.github.com/users/SnchitGrover/gists{/gist_id}","starred_url":"https://api.github.com/users/SnchitGrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnchitGrover/subscriptions","organizations_url":"https://api.github.com/users/SnchitGrover/orgs","repos_url":"https://api.github.com/users/SnchitGrover/repos","events_url":"https://api.github.com/users/SnchitGrover/events{/privacy}","received_events_url":"https://api.github.com/users/SnchitGrover/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-25T19:34:01Z","updated_at":"2018-04-26T08:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"106be6efeba2e23249ca2e19c4784ec920718fd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/brackets/pulls/14259/commits","review_comments_url":"https://api.github.com/repos/adobe/brackets/pulls/14259/comments","review_comment_url":"https://api.github.com/repos/adobe/brackets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/14259/comments","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/6a7f263df16c0e934bd330cb05540fc3cb107d8a","head":{"label":"SnchitGrover:master","ref":"master","sha":"6a7f263df16c0e934bd330cb05540fc3cb107d8a","user":{"login":"SnchitGrover","id":22751886,"avatar_url":"https://avatars0.githubusercontent.com/u/22751886?v=4","gravatar_id":"","url":"https://api.github.com/users/SnchitGrover","html_url":"https://github.com/SnchitGrover","followers_url":"https://api.github.com/users/SnchitGrover/followers","following_url":"https://api.github.com/users/SnchitGrover/following{/other_user}","gists_url":"https://api.github.com/users/SnchitGrover/gists{/gist_id}","starred_url":"https://api.github.com/users/SnchitGrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnchitGrover/subscriptions","organizations_url":"https://api.github.com/users/SnchitGrover/orgs","repos_url":"https://api.github.com/users/SnchitGrover/repos","events_url":"https://api.github.com/users/SnchitGrover/events{/privacy}","received_events_url":"https://api.github.com/users/SnchitGrover/received_events","type":"User","site_admin":false},"repo":{"id":130969859,"name":"brackets","full_name":"SnchitGrover/brackets","owner":{"login":"SnchitGrover","id":22751886,"avatar_url":"https://avatars0.githubusercontent.com/u/22751886?v=4","gravatar_id":"","url":"https://api.github.com/users/SnchitGrover","html_url":"https://github.com/SnchitGrover","followers_url":"https://api.github.com/users/SnchitGrover/followers","following_url":"https://api.github.com/users/SnchitGrover/following{/other_user}","gists_url":"https://api.github.com/users/SnchitGrover/gists{/gist_id}","starred_url":"https://api.github.com/users/SnchitGrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnchitGrover/subscriptions","organizations_url":"https://api.github.com/users/SnchitGrover/orgs","repos_url":"https://api.github.com/users/SnchitGrover/repos","events_url":"https://api.github.com/users/SnchitGrover/events{/privacy}","received_events_url":"https://api.github.com/users/SnchitGrover/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SnchitGrover/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":true,"url":"https://api.github.com/repos/SnchitGrover/brackets","forks_url":"https://api.github.com/repos/SnchitGrover/brackets/forks","keys_url":"https://api.github.com/repos/SnchitGrover/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnchitGrover/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnchitGrover/brackets/teams","hooks_url":"https://api.github.com/repos/SnchitGrover/brackets/hooks","issue_events_url":"https://api.github.com/repos/SnchitGrover/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/SnchitGrover/brackets/events","assignees_url":"https://api.github.com/repos/SnchitGrover/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/SnchitGrover/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/SnchitGrover/brackets/tags","blobs_url":"https://api.github.com/repos/SnchitGrover/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnchitGrover/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnchitGrover/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnchitGrover/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnchitGrover/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/SnchitGrover/brackets/languages","stargazers_url":"https://api.github.com/repos/SnchitGrover/brackets/stargazers","contributors_url":"https://api.github.com/repos/SnchitGrover/brackets/contributors","subscribers_url":"https://api.github.com/repos/SnchitGrover/brackets/subscribers","subscription_url":"https://api.github.com/repos/SnchitGrover/brackets/subscription","commits_url":"https://api.github.com/repos/SnchitGrover/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnchitGrover/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnchitGrover/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnchitGrover/brackets/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnchitGrover/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/SnchitGrover/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnchitGrover/brackets/merges","archive_url":"https://api.github.com/repos/SnchitGrover/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnchitGrover/brackets/downloads","issues_url":"https://api.github.com/repos/SnchitGrover/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/SnchitGrover/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/SnchitGrover/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/SnchitGrover/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnchitGrover/brackets/labels{/name}","releases_url":"https://api.github.com/repos/SnchitGrover/brackets/releases{/id}","deployments_url":"https://api.github.com/repos/SnchitGrover/brackets/deployments","created_at":"2018-04-25T07:48:39Z","updated_at":"2018-04-26T07:55:06Z","pushed_at":"2018-04-26T07:54:55Z","git_url":"git://github.com/SnchitGrover/brackets.git","ssh_url":"git@github.com:SnchitGrover/brackets.git","clone_url":"https://github.com/SnchitGrover/brackets.git","svn_url":"https://github.com/SnchitGrover/brackets","homepage":"http://brackets.io","size":90793,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"efc667f9b1961d87a40ffade0fb285464f7068e7","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":2935735,"name":"brackets","full_name":"adobe/brackets","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/brackets","description":"An open source code editor for the web, written in JavaScript, HTML and CSS.","fork":false,"url":"https://api.github.com/repos/adobe/brackets","forks_url":"https://api.github.com/repos/adobe/brackets/forks","keys_url":"https://api.github.com/repos/adobe/brackets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/brackets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/brackets/teams","hooks_url":"https://api.github.com/repos/adobe/brackets/hooks","issue_events_url":"https://api.github.com/repos/adobe/brackets/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/brackets/events","assignees_url":"https://api.github.com/repos/adobe/brackets/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/brackets/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/brackets/tags","blobs_url":"https://api.github.com/repos/adobe/brackets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/brackets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/brackets/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/brackets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/brackets/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/brackets/languages","stargazers_url":"https://api.github.com/repos/adobe/brackets/stargazers","contributors_url":"https://api.github.com/repos/adobe/brackets/contributors","subscribers_url":"https://api.github.com/repos/adobe/brackets/subscribers","subscription_url":"https://api.github.com/repos/adobe/brackets/subscription","commits_url":"https://api.github.com/repos/adobe/brackets/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/brackets/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/brackets/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/brackets/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/brackets/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/brackets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/brackets/merges","archive_url":"https://api.github.com/repos/adobe/brackets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/brackets/downloads","issues_url":"https://api.github.com/repos/adobe/brackets/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/brackets/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/brackets/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/brackets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/brackets/labels{/name}","releases_url":"https://api.github.com/repos/adobe/brackets/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/brackets/deployments","created_at":"2011-12-07T21:14:40Z","updated_at":"2018-04-26T06:40:56Z","pushed_at":"2018-04-26T08:41:25Z","git_url":"git://github.com/adobe/brackets.git","ssh_url":"git@github.com:adobe/brackets.git","clone_url":"https://github.com/adobe/brackets.git","svn_url":"https://github.com/adobe/brackets","homepage":"http://brackets.io","size":90799,"stargazers_count":28894,"watchers_count":28894,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6268,"mirror_url":null,"archived":false,"open_issues_count":2197,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6268,"open_issues":2197,"watchers":28894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/brackets/pulls/14259"},"html":{"href":"https://github.com/adobe/brackets/pull/14259"},"issue":{"href":"https://api.github.com/repos/adobe/brackets/issues/14259"},"comments":{"href":"https://api.github.com/repos/adobe/brackets/issues/14259/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/brackets/pulls/14259/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/brackets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/brackets/pulls/14259/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/brackets/statuses/6a7f263df16c0e934bd330cb05540fc3cb107d8a"}},"author_association":"NONE"}} | {
"id": 2935735,
"name": "adobe/brackets",
"url": "https://api.github.com/repos/adobe/brackets"
} | {
"id": 23508242,
"login": "vickramdhawal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23508242?",
"url": "https://api.github.com/users/vickramdhawal"
} | {
"id": 476009,
"login": "adobe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/476009?",
"url": "https://api.github.com/orgs/adobe"
} | 2018-04-26T08:22:28 | 7589862270 | {"actor":{"display_login":"vickramdhawal"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/comments/166052509","pull_request_review_id":94079472,"id":166052509,"diff_hunk":"@@ -51,30 +51,54 @@ sed -i \"s/{inst_stack_prefix}/$stackprefix/g\" ./jazz-core/serverless-config-pack\n sed -i \"s/{inst_stack_prefix}/$stackprefix/g\" ./jazz-core/serverless-config-pack/serverless-python.yml\n \n #-------------------------------------------\n-platform_services=(\"cognito-authorizer\" \"logs\" \"usermanagement\" \"services-handler\" \"events\" \"services\" \"logout\" \"login\" \"cloud-logs-streamer\" \"is-service-available\" \"delete-serverless-service\" \"create-serverless-service\" \"email\" )\n+platform_services=(\"cognito-authorizer\" \"platform_logs\" \"platform_usermanagement\" \"platform-services-handler\" \"platform_events\" \"platform_services\" \"platform_logout\" \"platform_login\" \"cloud-logs-streamer\" \"is-service-available\" \"delete-serverless-service\" \"create-serverless-service\" \"platform_email\" )","path":"installscripts/jazz-terraform-unix-noinstances/scripts/modifyCodebase.sh","position":5,"original_position":5,"commit_id":"369d931e58d6843438b79baa4a4f6da155d4fa8f","original_commit_id":"369d931e58d6843438b79baa4a4f6da155d4fa8f","user":{"login":"suryajak","id":9021084,"avatar_url":"https://avatars3.githubusercontent.com/u/9021084?v=4","gravatar_id":"","url":"https://api.github.com/users/suryajak","html_url":"https://github.com/suryajak","followers_url":"https://api.github.com/users/suryajak/followers","following_url":"https://api.github.com/users/suryajak/following{/other_user}","gists_url":"https://api.github.com/users/suryajak/gists{/gist_id}","starred_url":"https://api.github.com/users/suryajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryajak/subscriptions","organizations_url":"https://api.github.com/users/suryajak/orgs","repos_url":"https://api.github.com/users/suryajak/repos","events_url":"https://api.github.com/users/suryajak/events{/privacy}","received_events_url":"https://api.github.com/users/suryajak/received_events","type":"User","site_admin":false},"body":"this is incorrect. The domain is platform and service name is logs.","created_at":"2018-02-05T17:47:18Z","updated_at":"2018-02-05T17:47:48Z","html_url":"https://github.com/tmobile/jazz-installer/pull/82#discussion_r166052509","pull_request_url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/comments/166052509"},"html":{"href":"https://github.com/tmobile/jazz-installer/pull/82#discussion_r166052509"},"pull_request":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82","id":167090358,"html_url":"https://github.com/tmobile/jazz-installer/pull/82","diff_url":"https://github.com/tmobile/jazz-installer/pull/82.diff","patch_url":"https://github.com/tmobile/jazz-installer/pull/82.patch","issue_url":"https://api.github.com/repos/tmobile/jazz-installer/issues/82","number":82,"state":"closed","locked":false,"title":"CAPI-1210 : Follow up PR","user":{"login":"SiniWilson","id":34500278,"avatar_url":"https://avatars2.githubusercontent.com/u/34500278?v=4","gravatar_id":"","url":"https://api.github.com/users/SiniWilson","html_url":"https://github.com/SiniWilson","followers_url":"https://api.github.com/users/SiniWilson/followers","following_url":"https://api.github.com/users/SiniWilson/following{/other_user}","gists_url":"https://api.github.com/users/SiniWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/SiniWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiniWilson/subscriptions","organizations_url":"https://api.github.com/users/SiniWilson/orgs","repos_url":"https://api.github.com/users/SiniWilson/repos","events_url":"https://api.github.com/users/SiniWilson/events{/privacy}","received_events_url":"https://api.github.com/users/SiniWilson/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-05T09:14:49Z","updated_at":"2018-02-05T17:47:48Z","closed_at":"2018-02-05T09:25:31Z","merged_at":"2018-02-05T09:25:31Z","merge_commit_sha":"2a582b3688b073245cd1cd0d35fa671b210543c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82/commits","review_comments_url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82/comments","review_comment_url":"https://api.github.com/repos/tmobile/jazz-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmobile/jazz-installer/issues/82/comments","statuses_url":"https://api.github.com/repos/tmobile/jazz-installer/statuses/369d931e58d6843438b79baa4a4f6da155d4fa8f","head":{"label":"SiniWilson:v1.1.3","ref":"v1.1.3","sha":"369d931e58d6843438b79baa4a4f6da155d4fa8f","user":{"login":"SiniWilson","id":34500278,"avatar_url":"https://avatars2.githubusercontent.com/u/34500278?v=4","gravatar_id":"","url":"https://api.github.com/users/SiniWilson","html_url":"https://github.com/SiniWilson","followers_url":"https://api.github.com/users/SiniWilson/followers","following_url":"https://api.github.com/users/SiniWilson/following{/other_user}","gists_url":"https://api.github.com/users/SiniWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/SiniWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiniWilson/subscriptions","organizations_url":"https://api.github.com/users/SiniWilson/orgs","repos_url":"https://api.github.com/users/SiniWilson/repos","events_url":"https://api.github.com/users/SiniWilson/events{/privacy}","received_events_url":"https://api.github.com/users/SiniWilson/received_events","type":"User","site_admin":false},"repo":{"id":118717966,"name":"jazz-installer","full_name":"SiniWilson/jazz-installer","owner":{"login":"SiniWilson","id":34500278,"avatar_url":"https://avatars2.githubusercontent.com/u/34500278?v=4","gravatar_id":"","url":"https://api.github.com/users/SiniWilson","html_url":"https://github.com/SiniWilson","followers_url":"https://api.github.com/users/SiniWilson/followers","following_url":"https://api.github.com/users/SiniWilson/following{/other_user}","gists_url":"https://api.github.com/users/SiniWilson/gists{/gist_id}","starred_url":"https://api.github.com/users/SiniWilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiniWilson/subscriptions","organizations_url":"https://api.github.com/users/SiniWilson/orgs","repos_url":"https://api.github.com/users/SiniWilson/repos","events_url":"https://api.github.com/users/SiniWilson/events{/privacy}","received_events_url":"https://api.github.com/users/SiniWilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SiniWilson/jazz-installer","description":"Installer for Jazz Serverless Developer Platform!","fork":true,"url":"https://api.github.com/repos/SiniWilson/jazz-installer","forks_url":"https://api.github.com/repos/SiniWilson/jazz-installer/forks","keys_url":"https://api.github.com/repos/SiniWilson/jazz-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SiniWilson/jazz-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SiniWilson/jazz-installer/teams","hooks_url":"https://api.github.com/repos/SiniWilson/jazz-installer/hooks","issue_events_url":"https://api.github.com/repos/SiniWilson/jazz-installer/issues/events{/number}","events_url":"https://api.github.com/repos/SiniWilson/jazz-installer/events","assignees_url":"https://api.github.com/repos/SiniWilson/jazz-installer/assignees{/user}","branches_url":"https://api.github.com/repos/SiniWilson/jazz-installer/branches{/branch}","tags_url":"https://api.github.com/repos/SiniWilson/jazz-installer/tags","blobs_url":"https://api.github.com/repos/SiniWilson/jazz-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SiniWilson/jazz-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SiniWilson/jazz-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/SiniWilson/jazz-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SiniWilson/jazz-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/SiniWilson/jazz-installer/languages","stargazers_url":"https://api.github.com/repos/SiniWilson/jazz-installer/stargazers","contributors_url":"https://api.github.com/repos/SiniWilson/jazz-installer/contributors","subscribers_url":"https://api.github.com/repos/SiniWilson/jazz-installer/subscribers","subscription_url":"https://api.github.com/repos/SiniWilson/jazz-installer/subscription","commits_url":"https://api.github.com/repos/SiniWilson/jazz-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/SiniWilson/jazz-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/SiniWilson/jazz-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/SiniWilson/jazz-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/SiniWilson/jazz-installer/contents/{+path}","compare_url":"https://api.github.com/repos/SiniWilson/jazz-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SiniWilson/jazz-installer/merges","archive_url":"https://api.github.com/repos/SiniWilson/jazz-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SiniWilson/jazz-installer/downloads","issues_url":"https://api.github.com/repos/SiniWilson/jazz-installer/issues{/number}","pulls_url":"https://api.github.com/repos/SiniWilson/jazz-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/SiniWilson/jazz-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/SiniWilson/jazz-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SiniWilson/jazz-installer/labels{/name}","releases_url":"https://api.github.com/repos/SiniWilson/jazz-installer/releases{/id}","deployments_url":"https://api.github.com/repos/SiniWilson/jazz-installer/deployments","created_at":"2018-01-24T05:41:23Z","updated_at":"2018-01-24T05:41:27Z","pushed_at":"2018-02-05T09:11:25Z","git_url":"git://github.com/SiniWilson/jazz-installer.git","ssh_url":"git@github.com:SiniWilson/jazz-installer.git","clone_url":"https://github.com/SiniWilson/jazz-installer.git","svn_url":"https://github.com/SiniWilson/jazz-installer","homepage":"https://github.com/tmobile/jazz","size":283328,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmobile:v1.3.1","ref":"v1.3.1","sha":"cc7bf60e7aec39361a864219b7e186fc62a0f9a2","user":{"login":"tmobile","id":483040,"avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":98331197,"name":"jazz-installer","full_name":"tmobile/jazz-installer","owner":{"login":"tmobile","id":483040,"avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tmobile/jazz-installer","description":"Installer for Jazz Serverless Developer Platform!","fork":false,"url":"https://api.github.com/repos/tmobile/jazz-installer","forks_url":"https://api.github.com/repos/tmobile/jazz-installer/forks","keys_url":"https://api.github.com/repos/tmobile/jazz-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmobile/jazz-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmobile/jazz-installer/teams","hooks_url":"https://api.github.com/repos/tmobile/jazz-installer/hooks","issue_events_url":"https://api.github.com/repos/tmobile/jazz-installer/issues/events{/number}","events_url":"https://api.github.com/repos/tmobile/jazz-installer/events","assignees_url":"https://api.github.com/repos/tmobile/jazz-installer/assignees{/user}","branches_url":"https://api.github.com/repos/tmobile/jazz-installer/branches{/branch}","tags_url":"https://api.github.com/repos/tmobile/jazz-installer/tags","blobs_url":"https://api.github.com/repos/tmobile/jazz-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmobile/jazz-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmobile/jazz-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmobile/jazz-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmobile/jazz-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/tmobile/jazz-installer/languages","stargazers_url":"https://api.github.com/repos/tmobile/jazz-installer/stargazers","contributors_url":"https://api.github.com/repos/tmobile/jazz-installer/contributors","subscribers_url":"https://api.github.com/repos/tmobile/jazz-installer/subscribers","subscription_url":"https://api.github.com/repos/tmobile/jazz-installer/subscription","commits_url":"https://api.github.com/repos/tmobile/jazz-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmobile/jazz-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmobile/jazz-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmobile/jazz-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmobile/jazz-installer/contents/{+path}","compare_url":"https://api.github.com/repos/tmobile/jazz-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmobile/jazz-installer/merges","archive_url":"https://api.github.com/repos/tmobile/jazz-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmobile/jazz-installer/downloads","issues_url":"https://api.github.com/repos/tmobile/jazz-installer/issues{/number}","pulls_url":"https://api.github.com/repos/tmobile/jazz-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/tmobile/jazz-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/tmobile/jazz-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmobile/jazz-installer/labels{/name}","releases_url":"https://api.github.com/repos/tmobile/jazz-installer/releases{/id}","deployments_url":"https://api.github.com/repos/tmobile/jazz-installer/deployments","created_at":"2017-07-25T17:11:24Z","updated_at":"2018-01-25T18:51:21Z","pushed_at":"2018-02-05T17:39:01Z","git_url":"git://github.com/tmobile/jazz-installer.git","ssh_url":"git@github.com:tmobile/jazz-installer.git","clone_url":"https://github.com/tmobile/jazz-installer.git","svn_url":"https://github.com/tmobile/jazz-installer","homepage":"https://github.com/tmobile/jazz","size":283338,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82"},"html":{"href":"https://github.com/tmobile/jazz-installer/pull/82"},"issue":{"href":"https://api.github.com/repos/tmobile/jazz-installer/issues/82"},"comments":{"href":"https://api.github.com/repos/tmobile/jazz-installer/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmobile/jazz-installer/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/tmobile/jazz-installer/statuses/369d931e58d6843438b79baa4a4f6da155d4fa8f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 98331197,
"name": "tmobile/jazz-installer",
"url": "https://api.github.com/repos/tmobile/jazz-installer"
} | {
"id": 9021084,
"login": "suryajak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9021084?",
"url": "https://api.github.com/users/suryajak"
} | {
"id": 483040,
"login": "tmobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/483040?",
"url": "https://api.github.com/orgs/tmobile"
} | 2018-02-05T17:47:18 | 7200062413 | {"actor":{"display_login":"suryajak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tmobile/jazz/pulls/comments/182706539","pull_request_review_id":113555546,"id":182706539,"diff_hunk":"@@ -102,45 +167,71 @@ export class EnvironmentDetailComponent implements OnInit {\n \n if (cachedData) {\n this.onDataFetched(cachedData)\n+ if(this.service.serviceType === \"website\")\n+ {\n+ this.tabData = ['overview','deployments','code quality','assets'];\n+ }\n } else{\n if ( this.subscription ) {\n- this.subscription.unsubscribe();\n- }\n- this.subscription = this.http.get('/jazz/services/'+id).subscribe(\n+ this.subscription.unsubscribe();\n+ }\n+ this.subscription = this.http.get('/jazz/services/'+id).subscribe(\n response => {\n- let service = response.data;\n- this.cache.set(id, service);\n- this.onDataFetched(service);\n+ this.service.accounts=\"tmo-dev-ops, tmo-int\";\n+ this.service.regions=\"us-west-2, us-east\";\n+ // let service = response.data.data;\n+ this.service=response.data.data;\n+ if(environment.envName=='oss')this.service=response.data;\n+\n+ \n+ if(this.service.type === \"website\")\n+ {\n+ this.tabData = ['overview','deployments','code quality','assets'];\n+ }\n+ this.cache.set(id, this.service);\n+ this.onDataFetched(this.service);\n+ \n+ this.envoverview.notify(this.service);\n+ \n },\n err => {\n this.isLoadingService = false;\n let errorMessage = this.messageservice.errorMessage(err,\"serviceDetail\");\n this.toast_pop('error', 'Oops!', errorMessage)\n+ \n }\n )\n }\n \n };\n \n- testApi(type)\n- {\n+ testApi(type){\n switch(type){\n case 'api': \n- this.swaggerUrl=\"http://editor.swagger.io/?url=\"+this.api_doc_name+\"/\"+this.service.domain +\"/\"+ this.service.name +\"/\"+this.envSelected+\"/swagger.json\"\n- window.open(this.swaggerUrl);\n+ window.open('/test-api?service=' + this.service.name + '&domain='+ this.service.domain + '&env=' +this.envSelected);\n+ // this.baseUrl=\"http://jazz-training-api-doc.s3-website-us-east-1.amazonaws.com\"","path":"jazz-ui/src/app/pages/environment-detail/environment-detail.component.ts","position":227,"original_position":227,"commit_id":"4057a5a8ec41a9af65ec180e7ae737034947e62e","original_commit_id":"ec09e00f6ecb41b602ebb36506556cad5a01e6ee","user":{"login":"rjsughosh","id":34435043,"avatar_url":"https://avatars3.githubusercontent.com/u/34435043?v=4","gravatar_id":"","url":"https://api.github.com/users/rjsughosh","html_url":"https://github.com/rjsughosh","followers_url":"https://api.github.com/users/rjsughosh/followers","following_url":"https://api.github.com/users/rjsughosh/following{/other_user}","gists_url":"https://api.github.com/users/rjsughosh/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsughosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsughosh/subscriptions","organizations_url":"https://api.github.com/users/rjsughosh/orgs","repos_url":"https://api.github.com/users/rjsughosh/repos","events_url":"https://api.github.com/users/rjsughosh/events{/privacy}","received_events_url":"https://api.github.com/users/rjsughosh/received_events","type":"User","site_admin":false},"body":"working on removing the dead code","created_at":"2018-04-19T10:50:10Z","updated_at":"2018-04-19T10:50:10Z","html_url":"https://github.com/tmobile/jazz/pull/205#discussion_r182706539","pull_request_url":"https://api.github.com/repos/tmobile/jazz/pulls/205","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/comments/182706539"},"html":{"href":"https://github.com/tmobile/jazz/pull/205#discussion_r182706539"},"pull_request":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/205"}},"in_reply_to_id":181849853},"pull_request":{"url":"https://api.github.com/repos/tmobile/jazz/pulls/205","id":181880952,"html_url":"https://github.com/tmobile/jazz/pull/205","diff_url":"https://github.com/tmobile/jazz/pull/205.diff","patch_url":"https://github.com/tmobile/jazz/pull/205.patch","issue_url":"https://api.github.com/repos/tmobile/jazz/issues/205","number":205,"state":"open","locked":false,"title":"Allow config driven features for UI","user":{"login":"rjsughosh","id":34435043,"avatar_url":"https://avatars3.githubusercontent.com/u/34435043?v=4","gravatar_id":"","url":"https://api.github.com/users/rjsughosh","html_url":"https://github.com/rjsughosh","followers_url":"https://api.github.com/users/rjsughosh/followers","following_url":"https://api.github.com/users/rjsughosh/following{/other_user}","gists_url":"https://api.github.com/users/rjsughosh/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsughosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsughosh/subscriptions","organizations_url":"https://api.github.com/users/rjsughosh/orgs","repos_url":"https://api.github.com/users/rjsughosh/repos","events_url":"https://api.github.com/users/rjsughosh/events{/privacy}","received_events_url":"https://api.github.com/users/rjsughosh/received_events","type":"User","site_admin":false},"body":"### Requirements\r\n\r\n* Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.\r\n* All new code requires tests to ensure against regressions\r\n\r\n### Description of the Change\r\n\r\n<!--\r\n\r\nMerged Internal and OSS codebase\r\n\r\n-->\r\n\r\n### Benefits\r\n\r\nCommon codebase for OSS and Internal. able to generate environment specific builds.\r\nbuild command updated in JenkinsPlatform\r\n\r\n### Possible Drawbacks\r\n\r\n\r\n### Applicable Issues\r\n\r\n<!-- Enter any applicable Issues here -->\r\n","created_at":"2018-04-16T14:33:44Z","updated_at":"2018-04-19T10:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60a46b00591ce135b2c5c12092cdbcc1cde74ad1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/tmobile/jazz/milestones/9","html_url":"https://github.com/tmobile/jazz/milestone/9","labels_url":"https://api.github.com/repos/tmobile/jazz/milestones/9/labels","id":3272197,"number":9,"title":"v1.5","description":"Support for multiple environments","creator":{"login":"suryajak","id":9021084,"avatar_url":"https://avatars3.githubusercontent.com/u/9021084?v=4","gravatar_id":"","url":"https://api.github.com/users/suryajak","html_url":"https://github.com/suryajak","followers_url":"https://api.github.com/users/suryajak/followers","following_url":"https://api.github.com/users/suryajak/following{/other_user}","gists_url":"https://api.github.com/users/suryajak/gists{/gist_id}","starred_url":"https://api.github.com/users/suryajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suryajak/subscriptions","organizations_url":"https://api.github.com/users/suryajak/orgs","repos_url":"https://api.github.com/users/suryajak/repos","events_url":"https://api.github.com/users/suryajak/events{/privacy}","received_events_url":"https://api.github.com/users/suryajak/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2018-04-16T22:38:32Z","updated_at":"2018-04-16T22:41:25Z","due_on":"2018-04-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/tmobile/jazz/pulls/205/commits","review_comments_url":"https://api.github.com/repos/tmobile/jazz/pulls/205/comments","review_comment_url":"https://api.github.com/repos/tmobile/jazz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmobile/jazz/issues/205/comments","statuses_url":"https://api.github.com/repos/tmobile/jazz/statuses/4057a5a8ec41a9af65ec180e7ae737034947e62e","head":{"label":"rjsughosh:v1.4.6","ref":"v1.4.6","sha":"4057a5a8ec41a9af65ec180e7ae737034947e62e","user":{"login":"rjsughosh","id":34435043,"avatar_url":"https://avatars3.githubusercontent.com/u/34435043?v=4","gravatar_id":"","url":"https://api.github.com/users/rjsughosh","html_url":"https://github.com/rjsughosh","followers_url":"https://api.github.com/users/rjsughosh/followers","following_url":"https://api.github.com/users/rjsughosh/following{/other_user}","gists_url":"https://api.github.com/users/rjsughosh/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsughosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsughosh/subscriptions","organizations_url":"https://api.github.com/users/rjsughosh/orgs","repos_url":"https://api.github.com/users/rjsughosh/repos","events_url":"https://api.github.com/users/rjsughosh/events{/privacy}","received_events_url":"https://api.github.com/users/rjsughosh/received_events","type":"User","site_admin":false},"repo":{"id":124220670,"name":"jazz","full_name":"rjsughosh/jazz","owner":{"login":"rjsughosh","id":34435043,"avatar_url":"https://avatars3.githubusercontent.com/u/34435043?v=4","gravatar_id":"","url":"https://api.github.com/users/rjsughosh","html_url":"https://github.com/rjsughosh","followers_url":"https://api.github.com/users/rjsughosh/followers","following_url":"https://api.github.com/users/rjsughosh/following{/other_user}","gists_url":"https://api.github.com/users/rjsughosh/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsughosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsughosh/subscriptions","organizations_url":"https://api.github.com/users/rjsughosh/orgs","repos_url":"https://api.github.com/users/rjsughosh/repos","events_url":"https://api.github.com/users/rjsughosh/events{/privacy}","received_events_url":"https://api.github.com/users/rjsughosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjsughosh/jazz","description":"Jazz Serverless Development Platform","fork":true,"url":"https://api.github.com/repos/rjsughosh/jazz","forks_url":"https://api.github.com/repos/rjsughosh/jazz/forks","keys_url":"https://api.github.com/repos/rjsughosh/jazz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjsughosh/jazz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjsughosh/jazz/teams","hooks_url":"https://api.github.com/repos/rjsughosh/jazz/hooks","issue_events_url":"https://api.github.com/repos/rjsughosh/jazz/issues/events{/number}","events_url":"https://api.github.com/repos/rjsughosh/jazz/events","assignees_url":"https://api.github.com/repos/rjsughosh/jazz/assignees{/user}","branches_url":"https://api.github.com/repos/rjsughosh/jazz/branches{/branch}","tags_url":"https://api.github.com/repos/rjsughosh/jazz/tags","blobs_url":"https://api.github.com/repos/rjsughosh/jazz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjsughosh/jazz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjsughosh/jazz/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjsughosh/jazz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjsughosh/jazz/statuses/{sha}","languages_url":"https://api.github.com/repos/rjsughosh/jazz/languages","stargazers_url":"https://api.github.com/repos/rjsughosh/jazz/stargazers","contributors_url":"https://api.github.com/repos/rjsughosh/jazz/contributors","subscribers_url":"https://api.github.com/repos/rjsughosh/jazz/subscribers","subscription_url":"https://api.github.com/repos/rjsughosh/jazz/subscription","commits_url":"https://api.github.com/repos/rjsughosh/jazz/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjsughosh/jazz/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjsughosh/jazz/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjsughosh/jazz/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjsughosh/jazz/contents/{+path}","compare_url":"https://api.github.com/repos/rjsughosh/jazz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjsughosh/jazz/merges","archive_url":"https://api.github.com/repos/rjsughosh/jazz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjsughosh/jazz/downloads","issues_url":"https://api.github.com/repos/rjsughosh/jazz/issues{/number}","pulls_url":"https://api.github.com/repos/rjsughosh/jazz/pulls{/number}","milestones_url":"https://api.github.com/repos/rjsughosh/jazz/milestones{/number}","notifications_url":"https://api.github.com/repos/rjsughosh/jazz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjsughosh/jazz/labels{/name}","releases_url":"https://api.github.com/repos/rjsughosh/jazz/releases{/id}","deployments_url":"https://api.github.com/repos/rjsughosh/jazz/deployments","created_at":"2018-03-07T10:39:44Z","updated_at":"2018-04-10T11:37:24Z","pushed_at":"2018-04-16T20:41:45Z","git_url":"git://github.com/rjsughosh/jazz.git","ssh_url":"git@github.com:rjsughosh/jazz.git","clone_url":"https://github.com/rjsughosh/jazz.git","svn_url":"https://github.com/rjsughosh/jazz","homepage":"","size":163254,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmobile:v1.4.6","ref":"v1.4.6","sha":"77fc13672074ba3ae871c9fcf8c60c6b704542f4","user":{"login":"tmobile","id":483040,"avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":95246216,"name":"jazz","full_name":"tmobile/jazz","owner":{"login":"tmobile","id":483040,"avatar_url":"https://avatars0.githubusercontent.com/u/483040?v=4","gravatar_id":"","url":"https://api.github.com/users/tmobile","html_url":"https://github.com/tmobile","followers_url":"https://api.github.com/users/tmobile/followers","following_url":"https://api.github.com/users/tmobile/following{/other_user}","gists_url":"https://api.github.com/users/tmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/tmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmobile/subscriptions","organizations_url":"https://api.github.com/users/tmobile/orgs","repos_url":"https://api.github.com/users/tmobile/repos","events_url":"https://api.github.com/users/tmobile/events{/privacy}","received_events_url":"https://api.github.com/users/tmobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tmobile/jazz","description":"Jazz Serverless Development Platform","fork":false,"url":"https://api.github.com/repos/tmobile/jazz","forks_url":"https://api.github.com/repos/tmobile/jazz/forks","keys_url":"https://api.github.com/repos/tmobile/jazz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmobile/jazz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmobile/jazz/teams","hooks_url":"https://api.github.com/repos/tmobile/jazz/hooks","issue_events_url":"https://api.github.com/repos/tmobile/jazz/issues/events{/number}","events_url":"https://api.github.com/repos/tmobile/jazz/events","assignees_url":"https://api.github.com/repos/tmobile/jazz/assignees{/user}","branches_url":"https://api.github.com/repos/tmobile/jazz/branches{/branch}","tags_url":"https://api.github.com/repos/tmobile/jazz/tags","blobs_url":"https://api.github.com/repos/tmobile/jazz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmobile/jazz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmobile/jazz/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmobile/jazz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmobile/jazz/statuses/{sha}","languages_url":"https://api.github.com/repos/tmobile/jazz/languages","stargazers_url":"https://api.github.com/repos/tmobile/jazz/stargazers","contributors_url":"https://api.github.com/repos/tmobile/jazz/contributors","subscribers_url":"https://api.github.com/repos/tmobile/jazz/subscribers","subscription_url":"https://api.github.com/repos/tmobile/jazz/subscription","commits_url":"https://api.github.com/repos/tmobile/jazz/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmobile/jazz/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmobile/jazz/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmobile/jazz/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmobile/jazz/contents/{+path}","compare_url":"https://api.github.com/repos/tmobile/jazz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmobile/jazz/merges","archive_url":"https://api.github.com/repos/tmobile/jazz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmobile/jazz/downloads","issues_url":"https://api.github.com/repos/tmobile/jazz/issues{/number}","pulls_url":"https://api.github.com/repos/tmobile/jazz/pulls{/number}","milestones_url":"https://api.github.com/repos/tmobile/jazz/milestones{/number}","notifications_url":"https://api.github.com/repos/tmobile/jazz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmobile/jazz/labels{/name}","releases_url":"https://api.github.com/repos/tmobile/jazz/releases{/id}","deployments_url":"https://api.github.com/repos/tmobile/jazz/deployments","created_at":"2017-06-23T18:31:26Z","updated_at":"2018-04-13T16:21:51Z","pushed_at":"2018-04-19T10:45:30Z","git_url":"git://github.com/tmobile/jazz.git","ssh_url":"git@github.com:tmobile/jazz.git","clone_url":"https://github.com/tmobile/jazz.git","svn_url":"https://github.com/tmobile/jazz","homepage":"","size":157351,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":35,"open_issues":20,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/205"},"html":{"href":"https://github.com/tmobile/jazz/pull/205"},"issue":{"href":"https://api.github.com/repos/tmobile/jazz/issues/205"},"comments":{"href":"https://api.github.com/repos/tmobile/jazz/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmobile/jazz/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/tmobile/jazz/statuses/4057a5a8ec41a9af65ec180e7ae737034947e62e"}},"author_association":"NONE"}} | {
"id": 95246216,
"name": "tmobile/jazz",
"url": "https://api.github.com/repos/tmobile/jazz"
} | {
"id": 34435043,
"login": "rjsughosh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34435043?",
"url": "https://api.github.com/users/rjsughosh"
} | {
"id": 483040,
"login": "tmobile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/483040?",
"url": "https://api.github.com/orgs/tmobile"
} | 2018-04-19T10:50:10 | 7554754727 | {"actor":{"display_login":"rjsughosh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/175253262","pull_request_review_id":104761738,"id":175253262,"diff_hunk":"@@ -0,0 +1,510 @@\n+{ config, lib, pkgs, ... }:\n+\n+with lib;\n+\n+let\n+\n+ isPath = x: builtins.substring 0 1 x == \"/\";\n+ \n+ mkExcludeFile = cfg:\n+ # Write each exclude pattern to a new line\n+ pkgs.writeText \"excludefile\" (concatStringsSep \"\\n\" cfg.exclude);\n+\n+ mkPathsArgs = cfg:\n+ # Shell-escape each path and put spaces between them\n+ concatMapStringsSep \" \" escapeShellArg cfg.paths;\n+\n+ mkKeepArgs = cfg:\n+ # If cfg.prune.keep e.g. has a yearly attribute,\n+ # its content is passed on as --keep-yearly\n+ concatStringsSep \" \"\n+ (mapAttrsToList (x: y: \"--keep-${x}=${toString y}\") cfg.prune.keep);\n+\n+ mkBackupScript = cfg: ''\n+ on_exit()\n+ {\n+ exit_status=$?\n+ # Reset the EXIT handler, or else we're called again on 'exit' below\n+ trap - EXIT\n+ ${cfg.postHook}\n+ exit $exit_status\n+ }\n+ trap 'on_exit' INT TERM QUIT EXIT\n+\n+ ${cfg.preHook}\n+ '' + optionalString cfg.doInit ''\n+ # Run borg init if the repo doesn't exist yet\n+ if ! borg list; then\n+ borg init \\\n+ --encryption ${cfg.encryption.mode} \\\n+ ${cfg.extraInitArgs}\n+ ${cfg.postInit}\n+ fi\n+ '' + ''\n+ borg create \\\n+ --compression ${cfg.compression} \\\n+ --exclude-from ${mkExcludeFile cfg} \\\n+ ${cfg.extraCreateArgs} \\\n+ \"::$archiveName\" \\\n+ ${mkPathsArgs cfg}\n+ ${cfg.postCreate}\n+ '' + optionalString (cfg.prune.keep != { }) ''\n+ borg prune \\\n+ ${mkKeepArgs cfg} \\\n+ ${cfg.extraPruneArgs}\n+ ${cfg.postPrune}\n+ '';\n+\n+ mkPassEnv = cfg: with cfg.encryption;\n+ if passCommand != null then\n+ { BORG_PASSCOMMAND = passCommand; }\n+ else if passphrase != null then\n+ { BORG_PASSPHRASE = passphrase; }\n+ else { };\n+\n+ mkBackupService = name: cfg: \n+ let\n+ userHome = config.users.users.${cfg.user}.home;\n+ in nameValuePair \"borgbackup-job-${name}\" {\n+ description = \"BorgBackup job ${name}\";\n+ path = with pkgs; [\n+ borgbackup openssh\n+ ];\n+ script = mkBackupScript cfg;\n+ serviceConfig = {\n+ User = cfg.user;\n+ Group = cfg.group;\n+ # Only run when no other process is using CPU or disk\n+ CPUSchedulingPolicy = \"idle\";\n+ IOSchedulingClass = \"idle\";\n+ ProtectSystem = \"strict\";\n+ ReadWritePaths =\n+ [ \"${userHome}/.config/borg\" \"${userHome}/.cache/borg\" ]\n+ # Borg needs write access to repo if it is not remote\n+ ++ optional (isPath cfg.repo) cfg.repo;\n+ PrivateTmp = true;\n+ };\n+ environment = {\n+ BORG_REPO = cfg.repo;\n+ inherit (cfg) archiveName;\n+ } // (mkPassEnv cfg) // cfg.environment;\n+ inherit (cfg) startAt;\n+ };\n+\n+ mkActivationScript = name: cfg:\n+ let\n+ install = \"install -o ${cfg.user} -g ${cfg.group}\";\n+ in\n+ nameValuePair \"borgbackup-job-${name}\" (stringAfter [ \"users\" ] (\n+ ''\n+ cd \"${config.users.users.${cfg.user}.home}\" \n+ ${install} -d .config/borg\n+ ${install} -d .cache/borg\n+ '' + optionalString (isPath cfg.repo) '' \n+ ${install} -d ${escapeShellArg cfg.repo}\n+ ''\n+ ));\n+\n+ # The name arg is needed for mapAttrsToList\n+ mkPassAssertion = name: cfg: {\n+ assertion = with cfg.encryption;\n+ mode != \"none\" -> passCommand != null || passphrase != null;\n+ message =\n+ ''passCommand or passphrase have to be specified ''\n+ + ''because borgbackup.jobs.${name}.encryption != \"none\"'';\n+ };\n+\n+ mkRepoService = name: cfg:\n+ nameValuePair \"borgbackup-repo-${name}\" {\n+ description = \"Create BorgBackup repository ${name} directory\";\n+ script = ''\n+ mkdir -p ${escapeShellArg cfg.path}\n+ chown ${cfg.user}:${cfg.group} ${escapeShellArg cfg.path}\n+ '';\n+ serviceConfig = {\n+ # The service's only task is to ensure that the specified path exists\n+ Type = \"oneshot\";\n+ };\n+ wantedBy = [ \"multi-user.target\" ];\n+ };\n+\n+ mkAuthorizedKey = cfg: appendOnly: key:\n+ let\n+ restrictedArg = \"--restrict-to-repository ${escapeShellArg cfg.path}\";\n+ appendOnlyArg = optionalString appendOnly \"--append-only\";\n+ quotaArg = optionalString (cfg.quota != null) \"--storage-quota ${cfg.quota}\";\n+ command = \"borg serve ${restrictedArg} ${appendOnlyArg} ${quotaArg}\";\n+ in\n+ ''command=\"${command}\",restrict ${key}'';\n+\n+ mkUsersConfig = name: cfg: {\n+ users.${cfg.user} = {\n+ openssh.authorizedKeys.keys =\n+ (map (mkAuthorizedKey cfg false) cfg.authorizedKeys\n+ ++ map (mkAuthorizedKey cfg true) cfg.authorizedKeysAppendOnly);\n+ useDefaultShell = true;\n+ };\n+ groups.${cfg.group} = { };\n+ };\n+\n+ # The name arg is needed for mapAttrsToList\n+ mkKeysAssertion = name: cfg: {\n+ assertion = cfg.authorizedKeys != [ ] || cfg.authorizedKeysAppendOnly != [ ];\n+ message =\n+ \"borgbackup.repos.${name} does not make sense\"\n+ + \" without at least one public key\";\n+ };\n+\n+in {\n+ meta.maintainers = with maintainers; [ dotlambda ];\n+\n+ ###### interface\n+\n+ options.services.borgbackup.jobs = mkOption {\n+ description = \"Deduplicating backups using BorgBackup.\";\n+ default = { };\n+ type = types.attrsOf (types.submodule (\n+ { name, config, ... }: {\n+ options = {\n+\n+ paths = mkOption {\n+ type = with types; either path (nonEmptyListOf path);\n+ description = \"Path(s) to back up.\";\n+ example = \"/home/user\";\n+ apply = x: if isList x then x else [ x ];\n+ };\n+\n+ repo = mkOption {\n+ type = types.str;\n+ description = \"Remote or local repository to back up to.\";\n+ example = \"user@example.com:/path/to/repo\";\n+ };\n+\n+ archiveName = mkOption {\n+ type = types.strMatching \"[^/]+\";\n+ default = \"{hostname}-${name}-{now}\";\n+ example = \"{hostname}-{user}-{utcnow:%Y-%m-%d}\";\n+ description = ''\n+ How to name the created archives.\n+ See <command>borg help placeholders</command>\n+ for a list of placeholders replaced by borg.\n+ '';\n+ };\n+\n+ startAt = mkOption {\n+ type = with types; either str (listOf str);\n+ default = \"daily\";\n+ description = ''\n+ When or how often the backup should run.\n+ Must be in the format described in\n+ <citerefentry><refentrytitle>systemd.time</refentrytitle>\n+ <manvolnum>7</manvolnum></citerefentry>.\n+ If you do not want the backup to start\n+ automatically, use <literal>[ ]</literal>.\n+ '';\n+ };\n+\n+ user = mkOption {\n+ type = types.str;\n+ description = ''\n+ The user <command>borg</command> is run as.\n+ User or group need read permission\n+ for the specified <option>paths</option>.\n+ '';\n+ default = \"root\";\n+ };\n+\n+ group = mkOption {\n+ type = types.str;\n+ description = ''\n+ The group borg is run as. User or group need read permission\n+ for the specified <option>paths</option>.\n+ '';\n+ default = \"root\";\n+ };\n+\n+ encryption.mode = mkOption {\n+ type = types.enum [\n+ \"repokey\" \"keyfile\"\n+ \"repokey-blake2\" \"keyfile-blake2\"\n+ \"authenticated\" \"authenticated-blake2\"\n+ \"none\"\n+ ];\n+ description = ''\n+ Encryption mode to use. Setting a mode\n+ other than <literal>\"none\"</literal> requires\n+ you to specify a <option>passCommand</option>\n+ or a <option>passphrase</option>.\n+ '';\n+ };\n+\n+ encryption.passCommand = mkOption {\n+ type = with types; nullOr str;\n+ description = ''\n+ A command which prints the passphrase to stdout.\n+ Mutually exclusive with <option>passphrase</option>.\n+ '';\n+ default = null;\n+ example = \"cat /path/to/passphrase_file\";\n+ };\n+\n+ encryption.passphrase = mkOption {\n+ type = with types; nullOr str;\n+ description = ''\n+ The passphrase the backups are encrypted with.\n+ Mutually exclusive with <option>passCommand</option>.\n+ If you do not want the passphrase to be stored in the\n+ world-readable Nix store, use <option>passCommand</option>.\n+ '';\n+ default = null;\n+ };\n+\n+ compression = mkOption {\n+ # \"auto\" is optional,\n+ # compression mode must be given,\n+ # compression level is optional\n+ type = types.strMatching \"none|(auto,)?(lz4|zstd|zlib|lzma)(,[[:digit:]]{1,2})?\";\n+ description = ''\n+ Compression method to use. Refer to\n+ <command>borg help compression</command>\n+ for all available options.\n+ '';\n+ default = \"lz4\";\n+ example = \"auto,lzma\";\n+ };\n+\n+ exclude = mkOption {\n+ type = with types; listOf str;\n+ description = ''\n+ Exclude paths matching any of the given patterns. See\n+ <command>borg help patterns</command> for pattern syntax.\n+ '';\n+ default = [ ];\n+ example = [\n+ \"/home/*/.cache\"\n+ \"/nix\"\n+ ];\n+ };\n+\n+ doInit = mkOption {\n+ type = types.bool;\n+ description = ''\n+ Run <command>borg init</command> if the\n+ specified <option>repo</option> does not exist.\n+ You should set this to <literal>false</literal>\n+ if the repository is located on an external drive\n+ that might not always be mounted.\n+ '';\n+ default = true;\n+ };\n+\n+ prune.keep = mkOption {\n+ # Specifying e.g. `prune.keep.yearly = -1`\n+ # means there is no limit of yearly archives to keep\n+ # The regex is for use with e.g. --keep-within 1y\n+ type = with types; attrsOf (either int (strMatching \"[[:digit:]]+[Hdwmy]\"));\n+ description = ''\n+ Prune a repository by deleting all archives\n+ not matching any of the specified retention options.\n+ '';\n+ default = { };\n+ example = literalExample ''\n+ {\n+ within = \"1d\"; # Keep all archives from the last day\n+ daily = 7;\n+ weekly = 4;\n+ monthly = -1; # Keep at least one archive for each month\n+ }\n+ '';\n+ };\n+\n+ environment = mkOption {\n+ type = with types; attrsOf str;\n+ description = ''\n+ Environment variables passed to the backup script.\n+ You can for example specify which SSH key to use.\n+ '';\n+ default = { };\n+ example = { BORG_RSH = \"ssh -i /path/to/key\"; };\n+ };\n+\n+ preHook = mkOption {\n+ type = types.lines;\n+ description = ''\n+ Shell commands to run before the backup.\n+ This can for example be used to mount file systems.\n+ '';\n+ default = \"\";\n+ example = ''\n+ # In case you need to know the exact archive name\n+ archiveName=\"foobar-$(date +%Y%m%dT%H%M%S)\"\n+ '';\n+ };\n+\n+ postInit = mkOption {\n+ type = types.lines;\n+ description = ''\n+ Shell commands to run after\n+ <command>borg init</command>.\n+ '';\n+ default = \"\";\n+ };\n+\n+ postCreate = mkOption {\n+ type = types.lines;\n+ description = ''\n+ Shell commands to run after\n+ <command>borg create</command>.\n+ '';\n+ default = \"\";\n+ example = ''\n+ # In case you want to be able to distinguish failed backups\n+ # (and those during which a warning occurred)\n+ borg rename \"::$archiveName\" \"$archiveName-success\"","path":"nixos/modules/services/backup/borgbackup.nix","position":null,"original_position":363,"commit_id":"6f7f5f3689cf282c15369457402da05e5953db52","original_commit_id":"e6b46f51bda8aa102e2c0939c91e4997e30db282","user":{"login":"bjornfor","id":133602,"avatar_url":"https://avatars1.githubusercontent.com/u/133602?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornfor","html_url":"https://github.com/bjornfor","followers_url":"https://api.github.com/users/bjornfor/followers","following_url":"https://api.github.com/users/bjornfor/following{/other_user}","gists_url":"https://api.github.com/users/bjornfor/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornfor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornfor/subscriptions","organizations_url":"https://api.github.com/users/bjornfor/orgs","repos_url":"https://api.github.com/users/bjornfor/repos","events_url":"https://api.github.com/users/bjornfor/events{/privacy}","received_events_url":"https://api.github.com/users/bjornfor/received_events","type":"User","site_admin":false},"body":"With appendFailedSuffix, I don't think I need to know the exit status in the postHook. If I want to know about overall service, I can use systemd.services.*.onFailure. Thanks!\r\n\r\nBtw, the exit status won't be available in $? for the postHook, because the command that saves the status, \"$exit_status=$?\", sets the status to 0.","created_at":"2018-03-17T09:33:28Z","updated_at":"2018-03-17T09:33:28Z","html_url":"https://github.com/NixOS/nixpkgs/pull/36927#discussion_r175253262","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/175253262"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36927#discussion_r175253262"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927"}},"in_reply_to_id":175017440},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927","id":174767465,"html_url":"https://github.com/NixOS/nixpkgs/pull/36927","diff_url":"https://github.com/NixOS/nixpkgs/pull/36927.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/36927.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36927","number":36927,"state":"open","locked":false,"title":"nixos/borgbackup: init","user":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nI want a secure way to do regular remote backups.\r\nBorg has a nice feature called [append-only mode](http://borgbackup.readthedocs.io/en/stable/usage/notes.html#append-only-mode). To use it, I implemented more or less two modules: a server-side and a client-side one.\r\nTo read more about forcing append-only mode via SSH, look here: http://borgbackup.readthedocs.io/en/stable/usage/serve.html#examples\r\n\r\nI was inspired by @phdoerfler (https://github.com/r-raymond/nixos-mailserver/pull/93) and @bjornfor (https://github.com/bjornfor/nixos-config/blob/a570f4f7e4644520f430b310b4a94bb62decfb40/options/borg-backup.nix).\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [x] NixOS\r\n - [ ] macOS\r\n - [ ] other Linux distributions\r\n- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n/cc @Mic92 who wrote the previous borg test","created_at":"2018-03-13T19:35:16Z","updated_at":"2018-03-17T09:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b57b6dcb2f1b23c3bbf5db8ab41d849503cefcd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36927/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6f7f5f3689cf282c15369457402da05e5953db52","head":{"label":"dotlambda:borg-module","ref":"borg-module","sha":"6f7f5f3689cf282c15369457402da05e5953db52","user":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"repo":{"id":95651842,"name":"nixpkgs","full_name":"dotlambda/nixpkgs","owner":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotlambda/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dotlambda/nixpkgs","forks_url":"https://api.github.com/repos/dotlambda/nixpkgs/forks","keys_url":"https://api.github.com/repos/dotlambda/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotlambda/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotlambda/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dotlambda/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dotlambda/nixpkgs/events","assignees_url":"https://api.github.com/repos/dotlambda/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dotlambda/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotlambda/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotlambda/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dotlambda/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dotlambda/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotlambda/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotlambda/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dotlambda/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotlambda/nixpkgs/merges","archive_url":"https://api.github.com/repos/dotlambda/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotlambda/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dotlambda/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotlambda/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotlambda/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotlambda/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dotlambda/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dotlambda/nixpkgs/deployments","created_at":"2017-06-28T09:21:37Z","updated_at":"2017-06-28T09:22:05Z","pushed_at":"2018-03-17T08:21:04Z","git_url":"git://github.com/dotlambda/nixpkgs.git","ssh_url":"git@github.com:dotlambda/nixpkgs.git","clone_url":"https://github.com/dotlambda/nixpkgs.git","svn_url":"https://github.com/dotlambda/nixpkgs","homepage":null,"size":673114,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"548607d830490a5f48e85b28f57902acbb94a3b1","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-03-17T07:54:00Z","pushed_at":"2018-03-17T09:21:33Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":745996,"stargazers_count":2288,"watchers_count":2288,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2638,"mirror_url":null,"archived":false,"open_issues_count":3226,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2638,"open_issues":3226,"watchers":2288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36927"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36927"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36927/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36927/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6f7f5f3689cf282c15369457402da05e5953db52"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
} | {
"id": 133602,
"login": "bjornfor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/133602?",
"url": "https://api.github.com/users/bjornfor"
} | {
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
} | 2018-03-17T09:33:28 | 7394322073 | {"actor":{"display_login":"bjornfor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/187366467","pull_request_review_id":119132509,"id":187366467,"diff_hunk":"@@ -108,8 +108,9 @@\n > 1 # <lineannotation>(make it a partition number 1)</lineannotation>\n > # <lineannotation>(press enter to accept the default)</lineannotation>\n > # <lineannotation>(press enter to accept the default and use the rest of the remaining space)</lineannotation>\n-> a # <lineannotation>(make the partition bootable)</lineannotation>\n > x # <lineannotation>(enter expert mode)</lineannotation>\n+> A # <lineannotation>(make the partition bootable)</lineannotation>\n+> 1 # <lineannotation>(...partition one, the boot partition)</lineannotation>","path":"nixos/doc/manual/installation/installing.xml","position":21,"original_position":21,"commit_id":"c52745a11ed9ebdaf989a0a5a323c7a8585e1dac","original_commit_id":"c52745a11ed9ebdaf989a0a5a323c7a8585e1dac","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars1.githubusercontent.com/u/855219?v=4","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"body":"good catch, this is probably my typo. I was copying from line 108 above which was the last partition mentioned. Probably should be partition 3.\r\n","created_at":"2018-05-10T15:29:20Z","updated_at":"2018-05-10T15:29:20Z","html_url":"https://github.com/NixOS/nixpkgs/pull/39942#discussion_r187366467","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/187366467"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39942#discussion_r187366467"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942"}},"in_reply_to_id":187324662},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942","id":185808273,"html_url":"https://github.com/NixOS/nixpkgs/pull/39942","diff_url":"https://github.com/NixOS/nixpkgs/pull/39942.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/39942.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39942","number":39942,"state":"open","locked":false,"title":" nixos docs: Update installation partitioner instructions","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars1.githubusercontent.com/u/855219?v=4","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"body":"Updating the instructions to match experience \r\n\r\n- added:\r\n\r\n```\r\n> g # <lineannotation>(create an empty GPT table)</lineannotation>\r\n```\r\n\r\n- Remove this line, because there's only one partition (so you aren't prompted for the partition number)\r\n\r\n```\r\n> 3 # <lineannotation>(... of the boot partition ...)</lineannotation>\r\n```\r\n\r\n- for GPT partitions, the bootable option is under `x` (expert mode). I updated the commands to x-A-1 for bootable.\r\n\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [ ] NixOS\r\n - [ ] macOS\r\n - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-05-03T19:01:17Z","updated_at":"2018-05-10T15:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"811a2f9f6c1027fb4cb18730373d174bef119be9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abbradar","id":1174810,"avatar_url":"https://avatars0.githubusercontent.com/u/1174810?v=4","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},{"login":"globin","id":1447245,"avatar_url":"https://avatars3.githubusercontent.com/u/1447245?v=4","gravatar_id":"","url":"https://api.github.com/users/globin","html_url":"https://github.com/globin","followers_url":"https://api.github.com/users/globin/followers","following_url":"https://api.github.com/users/globin/following{/other_user}","gists_url":"https://api.github.com/users/globin/gists{/gist_id}","starred_url":"https://api.github.com/users/globin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globin/subscriptions","organizations_url":"https://api.github.com/users/globin/orgs","repos_url":"https://api.github.com/users/globin/repos","events_url":"https://api.github.com/users/globin/events{/privacy}","received_events_url":"https://api.github.com/users/globin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122655,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39942/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/c52745a11ed9ebdaf989a0a5a323c7a8585e1dac","head":{"label":"srl295:patch-1","ref":"patch-1","sha":"c52745a11ed9ebdaf989a0a5a323c7a8585e1dac","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars1.githubusercontent.com/u/855219?v=4","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"repo":{"id":132037292,"name":"nixpkgs","full_name":"srl295/nixpkgs","owner":{"login":"srl295","id":855219,"avatar_url":"https://avatars1.githubusercontent.com/u/855219?v=4","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srl295/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/srl295/nixpkgs","forks_url":"https://api.github.com/repos/srl295/nixpkgs/forks","keys_url":"https://api.github.com/repos/srl295/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srl295/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srl295/nixpkgs/teams","hooks_url":"https://api.github.com/repos/srl295/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/srl295/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/srl295/nixpkgs/events","assignees_url":"https://api.github.com/repos/srl295/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/srl295/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/srl295/nixpkgs/tags","blobs_url":"https://api.github.com/repos/srl295/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srl295/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srl295/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/srl295/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srl295/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/srl295/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/srl295/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/srl295/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/srl295/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/srl295/nixpkgs/subscription","commits_url":"https://api.github.com/repos/srl295/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/srl295/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/srl295/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/srl295/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/srl295/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/srl295/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srl295/nixpkgs/merges","archive_url":"https://api.github.com/repos/srl295/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srl295/nixpkgs/downloads","issues_url":"https://api.github.com/repos/srl295/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/srl295/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/srl295/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/srl295/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srl295/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/srl295/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/srl295/nixpkgs/deployments","created_at":"2018-05-03T18:54:00Z","updated_at":"2018-05-03T18:54:33Z","pushed_at":"2018-05-03T18:59:46Z","git_url":"git://github.com/srl295/nixpkgs.git","ssh_url":"git@github.com:srl295/nixpkgs.git","clone_url":"https://github.com/srl295/nixpkgs.git","svn_url":"https://github.com/srl295/nixpkgs","homepage":null,"size":774161,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b45ef79b74d267891a11c1775a473c610ecebe78","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-05-10T14:31:43Z","pushed_at":"2018-05-10T15:11:53Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":787756,"stargazers_count":2420,"watchers_count":2420,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2759,"mirror_url":null,"archived":false,"open_issues_count":3086,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2759,"open_issues":3086,"watchers":2420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39942"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39942"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39942/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39942/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/c52745a11ed9ebdaf989a0a5a323c7a8585e1dac"}},"author_association":"NONE"}} | {
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
} | {
"id": 855219,
"login": "srl295",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/855219?",
"url": "https://api.github.com/users/srl295"
} | {
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
} | 2018-05-10T15:29:20 | 7656179118 | {"actor":{"display_login":"srl295"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206543923","pull_request_review_id":141974108,"id":206543923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjU0MzkyMw==","diff_hunk":"@@ -1,72 +1,73 @@\n-{ stdenv, fetchurl, cmake, libGLU_combined, wxGTK, zlib, libX11, gettext, glew, cairo, curl, openssl, boost, pkgconfig, doxygen }:\n+{ wxGTK, lib, stdenv, fetchurl, cmake, libGLU_combined, zlib\n+, libX11, gettext, glew, glm, cairo, curl, openssl, boost, pkgconfig\n+, doxygen, pcre, libpthreadstubs, libXdmcp\n+, wrapGAppsHook\n+, oceSupport ? true, opencascade\n+, ngspiceSupport ? true, libngspice\n+, swig, python, pythonPackages","path":"pkgs/applications/science/electronics/kicad/default.nix","position":8,"original_position":8,"commit_id":"71b579f9d49e3df0e3e4a6e1478adfc4e52e6aad","original_commit_id":"71b579f9d49e3df0e3e4a6e1478adfc4e52e6aad","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"I removed this parameter `scriptingSupport` for simplicity. If somebody really needs, it can be restored.","created_at":"2018-07-31T14:11:56Z","updated_at":"2018-07-31T14:11:56Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44122#discussion_r206543923","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/206543923"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44122#discussion_r206543923"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122","id":204131342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTMxMzQy","html_url":"https://github.com/NixOS/nixpkgs/pull/44122","diff_url":"https://github.com/NixOS/nixpkgs/pull/44122.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44122.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44122","number":44122,"state":"open","locked":false,"title":"kicad: 4.0.7 -> 5.0.0","user":{"login":"bgamari","id":1010174,"node_id":"MDQ6VXNlcjEwMTAxNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1010174?v=4","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nJust a regular update.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [x] NixOS\r\n - [ ] macOS\r\n - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-07-26T12:49:37Z","updated_at":"2018-07-31T14:11:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f2d717f2e04893b05f121112b8bfa65f6c888f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44122/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/71b579f9d49e3df0e3e4a6e1478adfc4e52e6aad","head":{"label":"bgamari:kicad-0.5","ref":"kicad-0.5","sha":"71b579f9d49e3df0e3e4a6e1478adfc4e52e6aad","user":{"login":"bgamari","id":1010174,"node_id":"MDQ6VXNlcjEwMTAxNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1010174?v=4","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"repo":{"id":72307786,"node_id":"MDEwOlJlcG9zaXRvcnk3MjMwNzc4Ng==","name":"nixpkgs","full_name":"bgamari/nixpkgs","owner":{"login":"bgamari","id":1010174,"node_id":"MDQ6VXNlcjEwMTAxNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1010174?v=4","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgamari/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bgamari/nixpkgs","forks_url":"https://api.github.com/repos/bgamari/nixpkgs/forks","keys_url":"https://api.github.com/repos/bgamari/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgamari/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgamari/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bgamari/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bgamari/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bgamari/nixpkgs/events","assignees_url":"https://api.github.com/repos/bgamari/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bgamari/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bgamari/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bgamari/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgamari/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgamari/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgamari/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgamari/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bgamari/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bgamari/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bgamari/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bgamari/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bgamari/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bgamari/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgamari/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgamari/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgamari/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgamari/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bgamari/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgamari/nixpkgs/merges","archive_url":"https://api.github.com/repos/bgamari/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgamari/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bgamari/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bgamari/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bgamari/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bgamari/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgamari/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bgamari/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bgamari/nixpkgs/deployments","created_at":"2016-10-29T20:30:22Z","updated_at":"2016-10-29T20:30:46Z","pushed_at":"2018-07-31T13:47:00Z","git_url":"git://github.com/bgamari/nixpkgs.git","ssh_url":"git@github.com:bgamari/nixpkgs.git","clone_url":"https://github.com/bgamari/nixpkgs.git","svn_url":"https://github.com/bgamari/nixpkgs","homepage":null,"size":739968,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"886871538c15681575925a990a3f1b68ed9d5477","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-07-31T12:39:07Z","pushed_at":"2018-07-31T14:07:23Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":829225,"stargazers_count":2610,"watchers_count":2610,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2903,"mirror_url":null,"archived":false,"open_issues_count":3063,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2903,"open_issues":3063,"watchers":2610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44122"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44122"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44122/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44122/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/71b579f9d49e3df0e3e4a6e1478adfc4e52e6aad"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
} | {
"id": 96200,
"login": "Mic92",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/96200?",
"url": "https://api.github.com/users/Mic92"
} | {
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
} | 2018-07-31T14:11:56 | 8044352455 | {"actor":{"display_login":"Mic92"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/188515174","pull_request_review_id":120507255,"id":188515174,"diff_hunk":"@@ -96,7 +96,7 @@ let\n \"Description\" \"DHCP\" \"DHCPServer\" \"IPForward\" \"IPMasquerade\" \"IPv4LL\" \"IPv4LLRoute\"\n \"LLMNR\" \"MulticastDNS\" \"Domains\" \"Bridge\" \"Bond\" \"IPv6PrivacyExtensions\"\n ])\n- (assertValueOneOf \"DHCP\" [\"both\" \"none\" \"v4\" \"v6\"])","path":"nixos/modules/system/boot/networkd.nix","position":null,"original_position":4,"commit_id":"69c091096769ca2ce001beb1072ff0a25812be4e","original_commit_id":"125744d8a0eb93cc5f457d89a76ff07fd3a48612","user":{"login":"andir","id":638836,"avatar_url":"https://avatars1.githubusercontent.com/u/638836?v=4","gravatar_id":"","url":"https://api.github.com/users/andir","html_url":"https://github.com/andir","followers_url":"https://api.github.com/users/andir/followers","following_url":"https://api.github.com/users/andir/following{/other_user}","gists_url":"https://api.github.com/users/andir/gists{/gist_id}","starred_url":"https://api.github.com/users/andir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andir/subscriptions","organizations_url":"https://api.github.com/users/andir/orgs","repos_url":"https://api.github.com/users/andir/repos","events_url":"https://api.github.com/users/andir/events{/privacy}","received_events_url":"https://api.github.com/users/andir/received_events","type":"User","site_admin":false},"body":"Nitpick about the commit message: \r\nIt's that those were wrong. They were simply not being documented anymore. As per systemd policy you do not (immediately) remove those old options but instead drop them from the documentation ;-)\r\n\r\nhttps://github.com/systemd/systemd/blob/master/src/network/networkd-network.c#L832-L840","created_at":"2018-05-16T06:34:02Z","updated_at":"2018-05-16T06:42:18Z","html_url":"https://github.com/NixOS/nixpkgs/pull/40573#discussion_r188515174","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/188515174"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40573#discussion_r188515174"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573","id":188264370,"html_url":"https://github.com/NixOS/nixpkgs/pull/40573","diff_url":"https://github.com/NixOS/nixpkgs/pull/40573.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/40573.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40573","number":40573,"state":"open","locked":false,"title":"[WIP] systemd.network: module fixes","user":{"login":"flokli","id":183879,"avatar_url":"https://avatars0.githubusercontent.com/u/183879?v=4","gravatar_id":"","url":"https://api.github.com/users/flokli","html_url":"https://github.com/flokli","followers_url":"https://api.github.com/users/flokli/followers","following_url":"https://api.github.com/users/flokli/following{/other_user}","gists_url":"https://api.github.com/users/flokli/gists{/gist_id}","starred_url":"https://api.github.com/users/flokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flokli/subscriptions","organizations_url":"https://api.github.com/users/flokli/orgs","repos_url":"https://api.github.com/users/flokli/repos","events_url":"https://api.github.com/users/flokli/events{/privacy}","received_events_url":"https://api.github.com/users/flokli/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nThis PR fixes some wrong assertions currently in the `systemd.network` module, adds support for some not-yet-supported options, and moves some other options around to make everything them more consistent with the rest. \r\n\r\nContains the DHCP values fix from #35841, but nothing from the controversial \"disable IPv6 usecase\".\r\n\r\nI'd love to get some feedback from people using networkd, in concert with the nixos module\r\n\r\n/cc @andir @Mic92 @netixx \r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [ ] NixOS\r\n - [ ] macOS\r\n - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-05-15T21:43:21Z","updated_at":"2018-05-16T06:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b23444543c950c0b625f9cd11cc282e1f2e0202c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/40573/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/69c091096769ca2ce001beb1072ff0a25812be4e","head":{"label":"flokli:module-systemd-network-fixes","ref":"module-systemd-network-fixes","sha":"69c091096769ca2ce001beb1072ff0a25812be4e","user":{"login":"flokli","id":183879,"avatar_url":"https://avatars0.githubusercontent.com/u/183879?v=4","gravatar_id":"","url":"https://api.github.com/users/flokli","html_url":"https://github.com/flokli","followers_url":"https://api.github.com/users/flokli/followers","following_url":"https://api.github.com/users/flokli/following{/other_user}","gists_url":"https://api.github.com/users/flokli/gists{/gist_id}","starred_url":"https://api.github.com/users/flokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flokli/subscriptions","organizations_url":"https://api.github.com/users/flokli/orgs","repos_url":"https://api.github.com/users/flokli/repos","events_url":"https://api.github.com/users/flokli/events{/privacy}","received_events_url":"https://api.github.com/users/flokli/received_events","type":"User","site_admin":false},"repo":{"id":106616131,"name":"nixpkgs","full_name":"flokli/nixpkgs","owner":{"login":"flokli","id":183879,"avatar_url":"https://avatars0.githubusercontent.com/u/183879?v=4","gravatar_id":"","url":"https://api.github.com/users/flokli","html_url":"https://github.com/flokli","followers_url":"https://api.github.com/users/flokli/followers","following_url":"https://api.github.com/users/flokli/following{/other_user}","gists_url":"https://api.github.com/users/flokli/gists{/gist_id}","starred_url":"https://api.github.com/users/flokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flokli/subscriptions","organizations_url":"https://api.github.com/users/flokli/orgs","repos_url":"https://api.github.com/users/flokli/repos","events_url":"https://api.github.com/users/flokli/events{/privacy}","received_events_url":"https://api.github.com/users/flokli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flokli/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/flokli/nixpkgs","forks_url":"https://api.github.com/repos/flokli/nixpkgs/forks","keys_url":"https://api.github.com/repos/flokli/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flokli/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flokli/nixpkgs/teams","hooks_url":"https://api.github.com/repos/flokli/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/flokli/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/flokli/nixpkgs/events","assignees_url":"https://api.github.com/repos/flokli/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/flokli/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/flokli/nixpkgs/tags","blobs_url":"https://api.github.com/repos/flokli/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flokli/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flokli/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flokli/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flokli/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/flokli/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/flokli/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/flokli/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/flokli/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/flokli/nixpkgs/subscription","commits_url":"https://api.github.com/repos/flokli/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flokli/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flokli/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flokli/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/flokli/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/flokli/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flokli/nixpkgs/merges","archive_url":"https://api.github.com/repos/flokli/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flokli/nixpkgs/downloads","issues_url":"https://api.github.com/repos/flokli/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/flokli/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/flokli/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/flokli/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flokli/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/flokli/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/flokli/nixpkgs/deployments","created_at":"2017-10-11T22:29:54Z","updated_at":"2017-10-11T22:30:23Z","pushed_at":"2018-05-15T21:34:20Z","git_url":"git://github.com/flokli/nixpkgs.git","ssh_url":"git@github.com:flokli/nixpkgs.git","clone_url":"https://github.com/flokli/nixpkgs.git","svn_url":"https://github.com/flokli/nixpkgs","homepage":null,"size":738658,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"977c207f2295b0b17cb6fbf97c9c6c7656977e11","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-05-16T06:35:29Z","pushed_at":"2018-05-16T06:41:47Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":790789,"stargazers_count":2424,"watchers_count":2424,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2769,"mirror_url":null,"archived":false,"open_issues_count":3074,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2769,"open_issues":3074,"watchers":2424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/40573"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40573"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/40573/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/40573/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/69c091096769ca2ce001beb1072ff0a25812be4e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
} | {
"id": 638836,
"login": "andir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/638836?",
"url": "https://api.github.com/users/andir"
} | {
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
} | 2018-05-16T06:34:02 | 7681268196 | {"actor":{"display_login":"andir"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/233554236","pull_request_review_id":174996524,"id":233554236,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzU1NDIzNg==","diff_hunk":"@@ -209,11 +209,11 @@ def _getCloudAPIVersion(self) -> int:\n # Get the packages version depending on Cura version settings.\n def _getSDKVersion(self) -> Union[int, str]:","path":"plugins/Toolbox/src/Toolbox.py","position":31,"original_position":2,"commit_id":"5f4e3948d392faaed97c782125c8bf3647c4d3d0","original_commit_id":"75f2f405344e16d0bc191d40c488cc3cea3888e8","user":{"login":"ChrisTerBeke","id":1134120,"node_id":"MDQ6VXNlcjExMzQxMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1134120?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisTerBeke","html_url":"https://github.com/ChrisTerBeke","followers_url":"https://api.github.com/users/ChrisTerBeke/followers","following_url":"https://api.github.com/users/ChrisTerBeke/following{/other_user}","gists_url":"https://api.github.com/users/ChrisTerBeke/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisTerBeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisTerBeke/subscriptions","organizations_url":"https://api.github.com/users/ChrisTerBeke/orgs","repos_url":"https://api.github.com/users/ChrisTerBeke/repos","events_url":"https://api.github.com/users/ChrisTerBeke/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisTerBeke/received_events","type":"User","site_admin":false},"body":"That's true, but I don't see why it wouldn't send the full number when not having CuraVersion.py available or correctly configured, it might lead to confusion as the result (package list) is suddenly different.","created_at":"2018-11-14T17:55:20Z","updated_at":"2018-11-14T17:55:20Z","html_url":"https://github.com/Ultimaker/Cura/pull/4705#discussion_r233554236","pull_request_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/233554236"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/4705#discussion_r233554236"},"pull_request":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705"}},"in_reply_to_id":231849741},"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705","id":227630471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjMwNDcx","html_url":"https://github.com/Ultimaker/Cura/pull/4705","diff_url":"https://github.com/Ultimaker/Cura/pull/4705.diff","patch_url":"https://github.com/Ultimaker/Cura/pull/4705.patch","issue_url":"https://api.github.com/repos/Ultimaker/Cura/issues/4705","number":4705,"state":"closed","locked":false,"title":"Fixes required for semantic versioning","user":{"login":"nallath","id":3922611,"node_id":"MDQ6VXNlcjM5MjI2MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3922611?v=4","gravatar_id":"","url":"https://api.github.com/users/nallath","html_url":"https://github.com/nallath","followers_url":"https://api.github.com/users/nallath/followers","following_url":"https://api.github.com/users/nallath/following{/other_user}","gists_url":"https://api.github.com/users/nallath/gists{/gist_id}","starred_url":"https://api.github.com/users/nallath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nallath/subscriptions","organizations_url":"https://api.github.com/users/nallath/orgs","repos_url":"https://api.github.com/users/nallath/repos","events_url":"https://api.github.com/users/nallath/events{/privacy}","received_events_url":"https://api.github.com/users/nallath/received_events","type":"User","site_admin":false},"body":"CURA-5840\r\n\r\nSee also; https://github.com/Ultimaker/Uranium/pull/416","created_at":"2018-11-01T14:07:27Z","updated_at":"2018-11-14T17:55:20Z","closed_at":"2018-11-13T14:34:42Z","merged_at":"2018-11-13T14:34:42Z","merge_commit_sha":"7a577489ae1073a135edfd8f0162e90d1dd88c19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":841603621,"node_id":"MDU6TGFiZWw4NDE2MDM2MjE=","url":"https://api.github.com/repos/Ultimaker/Cura/labels/Status:%20In%20Progress","name":"Status: In Progress","color":"a9e34b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/issues/4705/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/5f4e3948d392faaed97c782125c8bf3647c4d3d0","head":{"label":"Ultimaker:CURA-5840-make-plugin-sdk-use-semantic-versioning","ref":"CURA-5840-make-plugin-sdk-use-semantic-versioning","sha":"5f4e3948d392faaed97c782125c8bf3647c4d3d0","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NDc4Mg==","name":"Cura","full_name":"Ultimaker/Cura","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2018-11-14T12:00:50Z","pushed_at":"2018-11-14T15:57:27Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":161553,"stargazers_count":1080,"watchers_count":1080,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":554,"mirror_url":null,"archived":false,"open_issues_count":536,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":554,"open_issues":536,"watchers":1080,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"2486a5b5da9dec0c07f5e6326f889ab6c05e91dd","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NDc4Mg==","name":"Cura","full_name":"Ultimaker/Cura","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2018-11-14T12:00:50Z","pushed_at":"2018-11-14T15:57:27Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":161553,"stargazers_count":1080,"watchers_count":1080,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":554,"mirror_url":null,"archived":false,"open_issues_count":536,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":554,"open_issues":536,"watchers":1080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/4705"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/4705"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/4705/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4705/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Cura/statuses/5f4e3948d392faaed97c782125c8bf3647c4d3d0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20884782,
"name": "Ultimaker/Cura",
"url": "https://api.github.com/repos/Ultimaker/Cura"
} | {
"id": 1134120,
"login": "ChrisTerBeke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1134120?",
"url": "https://api.github.com/users/ChrisTerBeke"
} | {
"id": 499557,
"login": "Ultimaker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/499557?",
"url": "https://api.github.com/orgs/Ultimaker"
} | 2018-11-14T17:55:20 | 8590020393 | {"actor":{"display_login":"ChrisTerBeke"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/173381174","pull_request_review_id":102562831,"id":173381174,"diff_hunk":"@@ -0,0 +1,55 @@\n+Project Migration Tool\n+======================\n+\n+This project contains a command-line tool for migrating KIE projects from the old project layout (7.4.x and previous) to the new project-oriented structure. This document briefly explains how to build and use the tool.\n+\n+Maven Build\n+-----------\n+\n+To build the project, simply run\n+\n+ mvn clean install\n+\n+This will generate a zip file in the target directory:\n+\n+ kie-wb-common-project-migration-$VERSION-linux.zip\n+\n+The zip file is a standalone artifact that contains all the necessary dependencies to run the CLI tool.\n+\n+(NOTE: The tool requires Java to be installed and available on the path.)\n+\n+Installing the Tool\n+-------------------\n+\n+To install the tool, simply unzip it into the desired location, like so:\n+\n+ unzip -d $INSTALL_DIR kie-wb-common-project-migration-$VERSION-linux.zip\n+\n+This should create a directory (`kie-wb-common-project-migration-$VERSION`) in the `$INSTALL_DIR`.\n+\n+Using the Tool\n+--------------\n+\n+The tool is meant to operate on the `.niogit` directory of a workbench distribution. *IMPORANT*: there should not be a running workbench using this directory when using the tool.\n+\n+For the instructions below, these variables are assumed:\n+\n+* `$NIOGIT` is the path of your `.niogit` directory being migrated.\n+* `$TOOL_DIR` is the path to the directory installed in the previous section (i.e. `$INSTALL_DIR/kie-wb-common-project-migration-$VERSION/`).\n+\n+Simple Usage\n+------------\n+\n+The simplest way to invoke the tool is\n+\n+ $TOOL/bin/migration-tool.sh -t $NIOGIT\n+\n+Batch Mode\n+----------\n+\n+The simple invocation will prompt the user to confirm before migration is attempted. This is done to warn users about making backups, in case an error occurs while migrating project data.\n+\n+If you wish to run the tool without this prompt, you can add the `-b` flag like so:\n+\n+\n+ $TOOL/bin/migration-tool.sh -b -t $NIOGIT","path":"kie-wb-common-cli/kie-wb-common-project-migration/README.md","position":55,"original_position":55,"commit_id":"20865e0bba0e447bb161b7e8cee46cba91d5e555","original_commit_id":"20865e0bba0e447bb161b7e8cee46cba91d5e555","user":{"login":"tomasdavidorg","id":4498639,"avatar_url":"https://avatars0.githubusercontent.com/u/4498639?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasdavidorg","html_url":"https://github.com/tomasdavidorg","followers_url":"https://api.github.com/users/tomasdavidorg/followers","following_url":"https://api.github.com/users/tomasdavidorg/following{/other_user}","gists_url":"https://api.github.com/users/tomasdavidorg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasdavidorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasdavidorg/subscriptions","organizations_url":"https://api.github.com/users/tomasdavidorg/orgs","repos_url":"https://api.github.com/users/tomasdavidorg/repos","events_url":"https://api.github.com/users/tomasdavidorg/events{/privacy}","received_events_url":"https://api.github.com/users/tomasdavidorg/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2018-03-09T07:32:38Z","updated_at":"2018-03-09T07:37:31Z","html_url":"https://github.com/kiegroup/kie-wb-common/pull/1488#discussion_r173381174","pull_request_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/173381174"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/1488#discussion_r173381174"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488","id":173837820,"html_url":"https://github.com/kiegroup/kie-wb-common/pull/1488","diff_url":"https://github.com/kiegroup/kie-wb-common/pull/1488.diff","patch_url":"https://github.com/kiegroup/kie-wb-common/pull/1488.patch","issue_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1488","number":1488,"state":"open","locked":false,"title":"RHBA-499: Add documentation for project migration tool.","user":{"login":"mbarkley","id":4459888,"avatar_url":"https://avatars0.githubusercontent.com/u/4459888?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarkley","html_url":"https://github.com/mbarkley","followers_url":"https://api.github.com/users/mbarkley/followers","following_url":"https://api.github.com/users/mbarkley/following{/other_user}","gists_url":"https://api.github.com/users/mbarkley/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarkley/subscriptions","organizations_url":"https://api.github.com/users/mbarkley/orgs","repos_url":"https://api.github.com/users/mbarkley/repos","events_url":"https://api.github.com/users/mbarkley/events{/privacy}","received_events_url":"https://api.github.com/users/mbarkley/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-08T20:10:48Z","updated_at":"2018-03-09T07:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8339a18cf3a1e48908076429fa9dd7ae8e02e11f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488/commits","review_comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488/comments","review_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1488/comments","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/20865e0bba0e447bb161b7e8cee46cba91d5e555","head":{"label":"mbarkley:RHBA-499","ref":"RHBA-499","sha":"20865e0bba0e447bb161b7e8cee46cba91d5e555","user":{"login":"mbarkley","id":4459888,"avatar_url":"https://avatars0.githubusercontent.com/u/4459888?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarkley","html_url":"https://github.com/mbarkley","followers_url":"https://api.github.com/users/mbarkley/followers","following_url":"https://api.github.com/users/mbarkley/following{/other_user}","gists_url":"https://api.github.com/users/mbarkley/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarkley/subscriptions","organizations_url":"https://api.github.com/users/mbarkley/orgs","repos_url":"https://api.github.com/users/mbarkley/repos","events_url":"https://api.github.com/users/mbarkley/events{/privacy}","received_events_url":"https://api.github.com/users/mbarkley/received_events","type":"User","site_admin":false},"repo":{"id":35953593,"name":"kie-wb-common","full_name":"mbarkley/kie-wb-common","owner":{"login":"mbarkley","id":4459888,"avatar_url":"https://avatars0.githubusercontent.com/u/4459888?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarkley","html_url":"https://github.com/mbarkley","followers_url":"https://api.github.com/users/mbarkley/followers","following_url":"https://api.github.com/users/mbarkley/following{/other_user}","gists_url":"https://api.github.com/users/mbarkley/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarkley/subscriptions","organizations_url":"https://api.github.com/users/mbarkley/orgs","repos_url":"https://api.github.com/users/mbarkley/repos","events_url":"https://api.github.com/users/mbarkley/events{/privacy}","received_events_url":"https://api.github.com/users/mbarkley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbarkley/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":true,"url":"https://api.github.com/repos/mbarkley/kie-wb-common","forks_url":"https://api.github.com/repos/mbarkley/kie-wb-common/forks","keys_url":"https://api.github.com/repos/mbarkley/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbarkley/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbarkley/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/mbarkley/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/mbarkley/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/mbarkley/kie-wb-common/events","assignees_url":"https://api.github.com/repos/mbarkley/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/mbarkley/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/mbarkley/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/mbarkley/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbarkley/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbarkley/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbarkley/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbarkley/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/mbarkley/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/mbarkley/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/mbarkley/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/mbarkley/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/mbarkley/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/mbarkley/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbarkley/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbarkley/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbarkley/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbarkley/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/mbarkley/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbarkley/kie-wb-common/merges","archive_url":"https://api.github.com/repos/mbarkley/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbarkley/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/mbarkley/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/mbarkley/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/mbarkley/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/mbarkley/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbarkley/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/mbarkley/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/mbarkley/kie-wb-common/deployments","created_at":"2015-05-20T14:36:11Z","updated_at":"2015-05-20T14:36:17Z","pushed_at":"2018-03-08T20:03:21Z","git_url":"git://github.com/mbarkley/kie-wb-common.git","ssh_url":"git@github.com:mbarkley/kie-wb-common.git","clone_url":"https://github.com/mbarkley/kie-wb-common.git","svn_url":"https://github.com/mbarkley/kie-wb-common","homepage":"","size":34280,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"aeaf4435d5485dafdc155d9cb2567ee07d044616","user":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":10522120,"name":"kie-wb-common","full_name":"kiegroup/kie-wb-common","owner":{"login":"kiegroup","id":517980,"avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiegroup/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":false,"url":"https://api.github.com/repos/kiegroup/kie-wb-common","forks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/forks","keys_url":"https://api.github.com/repos/kiegroup/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/events","assignees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/kie-wb-common/merges","archive_url":"https://api.github.com/repos/kiegroup/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/deployments","created_at":"2013-06-06T08:32:03Z","updated_at":"2018-02-21T09:51:01Z","pushed_at":"2018-03-08T23:09:14Z","git_url":"git://github.com/kiegroup/kie-wb-common.git","ssh_url":"git@github.com:kiegroup/kie-wb-common.git","clone_url":"https://github.com/kiegroup/kie-wb-common.git","svn_url":"https://github.com/kiegroup/kie-wb-common","homepage":"","size":36974,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":145,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/1488"},"issue":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1488"},"comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/1488/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/1488/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/20865e0bba0e447bb161b7e8cee46cba91d5e555"}},"author_association":"CONTRIBUTOR"}} | {
"id": 10522120,
"name": "kiegroup/kie-wb-common",
"url": "https://api.github.com/repos/kiegroup/kie-wb-common"
} | {
"id": 4498639,
"login": "tomasdavidorg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4498639?",
"url": "https://api.github.com/users/tomasdavidorg"
} | {
"id": 517980,
"login": "kiegroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/517980?",
"url": "https://api.github.com/orgs/kiegroup"
} | 2018-03-09T07:32:38 | 7354578575 | {"actor":{"display_login":"tomasdavidorg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/appformer/pulls/comments/217372088","pull_request_review_id":155066543,"id":217372088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzM3MjA4OA==","diff_hunk":"@@ -0,0 +1,126 @@\n+/*\n+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.guvnor.m2repo.backend.server;\n+\n+import java.io.File;\n+\n+import org.apache.maven.repository.internal.MavenRepositorySystemUtils;\n+import org.appformer.maven.integration.Aether;\n+import org.eclipse.aether.DefaultRepositorySystemSession;\n+import org.eclipse.aether.RepositorySystem;\n+import org.eclipse.aether.RepositorySystemSession;\n+import org.eclipse.aether.artifact.Artifact;\n+import org.eclipse.aether.artifact.DefaultArtifact;\n+import org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory;\n+import org.eclipse.aether.impl.DefaultServiceLocator;\n+import org.eclipse.aether.repository.LocalRepository;\n+import org.eclipse.aether.resolution.ArtifactRequest;\n+import org.eclipse.aether.resolution.ArtifactResolutionException;\n+import org.eclipse.aether.resolution.ArtifactResult;\n+import org.eclipse.aether.spi.connector.RepositoryConnectorFactory;\n+import org.eclipse.aether.spi.connector.transport.TransporterFactory;\n+import org.eclipse.aether.transport.file.FileTransporterFactory;\n+import org.eclipse.aether.transport.http.HttpTransporterFactory;\n+import org.guvnor.common.services.project.model.GAV;\n+import org.guvnor.m2repo.preferences.ArtifactRepositoryPreference;\n+import org.junit.After;\n+import org.junit.Test;\n+\n+import static org.assertj.core.api.Assertions.*;\n+\n+public class M2ServletContextListenerTest {\n+\n+ private static RepositorySystemSession newSession(RepositorySystem system) {\n+ ArtifactRepositoryPreference artifactRepositoryPreference = new ArtifactRepositoryPreference();\n+ artifactRepositoryPreference.defaultValue(artifactRepositoryPreference);\n+ DefaultRepositorySystemSession session = MavenRepositorySystemUtils.newSession();\n+ LocalRepository localRepo = new LocalRepository(artifactRepositoryPreference.getGlobalM2RepoDir());\n+ session.setLocalRepositoryManager(system.newLocalRepositoryManager(session,\n+ localRepo));\n+\n+ return session;\n+ }\n+\n+ private static RepositorySystem newRepositorySystem() {\n+ DefaultServiceLocator locator = MavenRepositorySystemUtils.newServiceLocator();\n+ locator.addService(RepositoryConnectorFactory.class,\n+ BasicRepositoryConnectorFactory.class);\n+ locator.addService(TransporterFactory.class,\n+ FileTransporterFactory.class);\n+ locator.addService(TransporterFactory.class,\n+ HttpTransporterFactory.class);\n+ return locator.getService(RepositorySystem.class);\n+ }\n+\n+ @After\n+ public void tearDown() throws Exception {\n+ deleteArtifactIFPresent();\n+ }\n+\n+ private void deleteArtifactIFPresent() throws ArtifactResolutionException {\n+ ArtifactRequest artifactRequest = new ArtifactRequest();\n+ artifactRequest.setArtifact(getArtifact());\n+ ArtifactResult result = Aether.getAether().getSystem().resolveArtifact(newSession(newRepositorySystem()),\n+ artifactRequest);\n+ if (!result.isMissing()) {\n+ File artifactFile = result.getArtifact().getFile();\n+ assertThat(artifactFile.delete()).isTrue();\n+ }\n+ }\n+\n+ private Artifact getArtifact() {\n+ Artifact jarArtifact = new DefaultArtifact(\"org.uberfire\",\n+ \"uberfire-m2repo-editor-backend\",\n+ \"jar\",\n+ \"100-SNAPSHOT\");\n+ return jarArtifact;\n+ }\n+\n+ @Test\n+ public void deployJarsFrowWar() throws Exception {","path":"uberfire-m2repo-editor/uberfire-m2repo-editor-backend/src/test/java/org/guvnor/m2repo/backend/server/M2ServletContextListenerTest.java","position":93,"original_position":93,"commit_id":"0ffb6e5cad6f0de88c6b7becf3dcf9c62779a5f6","original_commit_id":"0ffb6e5cad6f0de88c6b7becf3dcf9c62779a5f6","user":{"login":"porcelli","id":119395,"node_id":"MDQ6VXNlcjExOTM5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/119395?v=4","gravatar_id":"","url":"https://api.github.com/users/porcelli","html_url":"https://github.com/porcelli","followers_url":"https://api.github.com/users/porcelli/followers","following_url":"https://api.github.com/users/porcelli/following{/other_user}","gists_url":"https://api.github.com/users/porcelli/gists{/gist_id}","starred_url":"https://api.github.com/users/porcelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porcelli/subscriptions","organizations_url":"https://api.github.com/users/porcelli/orgs","repos_url":"https://api.github.com/users/porcelli/repos","events_url":"https://api.github.com/users/porcelli/events{/privacy}","received_events_url":"https://api.github.com/users/porcelli/received_events","type":"User","site_admin":false},"body":"please add check for .pom files as well","created_at":"2018-09-13T12:55:53Z","updated_at":"2018-09-13T12:56:51Z","html_url":"https://github.com/kiegroup/appformer/pull/459#discussion_r217372088","pull_request_url":"https://api.github.com/repos/kiegroup/appformer/pulls/459","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/comments/217372088"},"html":{"href":"https://github.com/kiegroup/appformer/pull/459#discussion_r217372088"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/459"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/appformer/pulls/459","id":215226591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjI2NTkx","html_url":"https://github.com/kiegroup/appformer/pull/459","diff_url":"https://github.com/kiegroup/appformer/pull/459.diff","patch_url":"https://github.com/kiegroup/appformer/pull/459.patch","issue_url":"https://api.github.com/repos/kiegroup/appformer/issues/459","number":459,"state":"open","locked":false,"title":"[AF-1528] 7.11.x Workbench offline ","user":{"login":"desmax74","id":141301,"node_id":"MDQ6VXNlcjE0MTMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/141301?v=4","gravatar_id":"","url":"https://api.github.com/users/desmax74","html_url":"https://github.com/desmax74","followers_url":"https://api.github.com/users/desmax74/followers","following_url":"https://api.github.com/users/desmax74/following{/other_user}","gists_url":"https://api.github.com/users/desmax74/gists{/gist_id}","starred_url":"https://api.github.com/users/desmax74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desmax74/subscriptions","organizations_url":"https://api.github.com/users/desmax74/orgs","repos_url":"https://api.github.com/users/desmax74/repos","events_url":"https://api.github.com/users/desmax74/events{/privacy}","received_events_url":"https://api.github.com/users/desmax74/received_events","type":"User","site_admin":false},"body":"Workbench offline 7.11.x\r\nhttps://github.com/kiegroup/droolsjbpm-build-bootstrap/pull/829\r\nhttps://github.com/kiegroup/kie-soup/pull/57\r\nhttps://github.com/kiegroup/appformer/pull/459\r\nhttps://github.com/kiegroup/kie-wb-common/pull/2117\r\nhttps://github.com/kiegroup/kie-wb-distributions/pull/811\r\n@porcelli @domhanak @jhrcek","created_at":"2018-09-13T09:54:59Z","updated_at":"2018-09-13T12:56:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44a722ef9e68efef9ad6b25fffb7d8354f2da968","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/appformer/pulls/459/commits","review_comments_url":"https://api.github.com/repos/kiegroup/appformer/pulls/459/comments","review_comment_url":"https://api.github.com/repos/kiegroup/appformer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/appformer/issues/459/comments","statuses_url":"https://api.github.com/repos/kiegroup/appformer/statuses/0ffb6e5cad6f0de88c6b7becf3dcf9c62779a5f6","head":{"label":"desmax74:AF-1528-7.11.x","ref":"AF-1528-7.11.x","sha":"0ffb6e5cad6f0de88c6b7becf3dcf9c62779a5f6","user":{"login":"desmax74","id":141301,"node_id":"MDQ6VXNlcjE0MTMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/141301?v=4","gravatar_id":"","url":"https://api.github.com/users/desmax74","html_url":"https://github.com/desmax74","followers_url":"https://api.github.com/users/desmax74/followers","following_url":"https://api.github.com/users/desmax74/following{/other_user}","gists_url":"https://api.github.com/users/desmax74/gists{/gist_id}","starred_url":"https://api.github.com/users/desmax74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desmax74/subscriptions","organizations_url":"https://api.github.com/users/desmax74/orgs","repos_url":"https://api.github.com/users/desmax74/repos","events_url":"https://api.github.com/users/desmax74/events{/privacy}","received_events_url":"https://api.github.com/users/desmax74/received_events","type":"User","site_admin":false},"repo":{"id":93932321,"node_id":"MDEwOlJlcG9zaXRvcnk5MzkzMjMyMQ==","name":"appformer","full_name":"desmax74/appformer","owner":{"login":"desmax74","id":141301,"node_id":"MDQ6VXNlcjE0MTMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/141301?v=4","gravatar_id":"","url":"https://api.github.com/users/desmax74","html_url":"https://github.com/desmax74","followers_url":"https://api.github.com/users/desmax74/followers","following_url":"https://api.github.com/users/desmax74/following{/other_user}","gists_url":"https://api.github.com/users/desmax74/gists{/gist_id}","starred_url":"https://api.github.com/users/desmax74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desmax74/subscriptions","organizations_url":"https://api.github.com/users/desmax74/orgs","repos_url":"https://api.github.com/users/desmax74/repos","events_url":"https://api.github.com/users/desmax74/events{/privacy}","received_events_url":"https://api.github.com/users/desmax74/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/desmax74/appformer","description":"A web platform to rapidly build forms for data management and business automation.","fork":true,"url":"https://api.github.com/repos/desmax74/appformer","forks_url":"https://api.github.com/repos/desmax74/appformer/forks","keys_url":"https://api.github.com/repos/desmax74/appformer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desmax74/appformer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desmax74/appformer/teams","hooks_url":"https://api.github.com/repos/desmax74/appformer/hooks","issue_events_url":"https://api.github.com/repos/desmax74/appformer/issues/events{/number}","events_url":"https://api.github.com/repos/desmax74/appformer/events","assignees_url":"https://api.github.com/repos/desmax74/appformer/assignees{/user}","branches_url":"https://api.github.com/repos/desmax74/appformer/branches{/branch}","tags_url":"https://api.github.com/repos/desmax74/appformer/tags","blobs_url":"https://api.github.com/repos/desmax74/appformer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desmax74/appformer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desmax74/appformer/git/refs{/sha}","trees_url":"https://api.github.com/repos/desmax74/appformer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desmax74/appformer/statuses/{sha}","languages_url":"https://api.github.com/repos/desmax74/appformer/languages","stargazers_url":"https://api.github.com/repos/desmax74/appformer/stargazers","contributors_url":"https://api.github.com/repos/desmax74/appformer/contributors","subscribers_url":"https://api.github.com/repos/desmax74/appformer/subscribers","subscription_url":"https://api.github.com/repos/desmax74/appformer/subscription","commits_url":"https://api.github.com/repos/desmax74/appformer/commits{/sha}","git_commits_url":"https://api.github.com/repos/desmax74/appformer/git/commits{/sha}","comments_url":"https://api.github.com/repos/desmax74/appformer/comments{/number}","issue_comment_url":"https://api.github.com/repos/desmax74/appformer/issues/comments{/number}","contents_url":"https://api.github.com/repos/desmax74/appformer/contents/{+path}","compare_url":"https://api.github.com/repos/desmax74/appformer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desmax74/appformer/merges","archive_url":"https://api.github.com/repos/desmax74/appformer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desmax74/appformer/downloads","issues_url":"https://api.github.com/repos/desmax74/appformer/issues{/number}","pulls_url":"https://api.github.com/repos/desmax74/appformer/pulls{/number}","milestones_url":"https://api.github.com/repos/desmax74/appformer/milestones{/number}","notifications_url":"https://api.github.com/repos/desmax74/appformer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desmax74/appformer/labels{/name}","releases_url":"https://api.github.com/repos/desmax74/appformer/releases{/id}","deployments_url":"https://api.github.com/repos/desmax74/appformer/deployments","created_at":"2017-06-10T10:31:30Z","updated_at":"2017-06-10T10:31:33Z","pushed_at":"2018-09-13T11:55:01Z","git_url":"git://github.com/desmax74/appformer.git","ssh_url":"git@github.com:desmax74/appformer.git","clone_url":"https://github.com/desmax74/appformer.git","svn_url":"https://github.com/desmax74/appformer","homepage":null,"size":46293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:7.11.x","ref":"7.11.x","sha":"254b2389f73616d73cf5eb2f95be74e57990f487","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":35297180,"node_id":"MDEwOlJlcG9zaXRvcnkzNTI5NzE4MA==","name":"appformer","full_name":"kiegroup/appformer","owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiegroup/appformer","description":"A web platform to rapidly build forms for data management and business automation.","fork":false,"url":"https://api.github.com/repos/kiegroup/appformer","forks_url":"https://api.github.com/repos/kiegroup/appformer/forks","keys_url":"https://api.github.com/repos/kiegroup/appformer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/appformer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/appformer/teams","hooks_url":"https://api.github.com/repos/kiegroup/appformer/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/appformer/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/appformer/events","assignees_url":"https://api.github.com/repos/kiegroup/appformer/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/appformer/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/appformer/tags","blobs_url":"https://api.github.com/repos/kiegroup/appformer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/appformer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/appformer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/appformer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/appformer/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/appformer/languages","stargazers_url":"https://api.github.com/repos/kiegroup/appformer/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/appformer/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/appformer/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/appformer/subscription","commits_url":"https://api.github.com/repos/kiegroup/appformer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/appformer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/appformer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/appformer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/appformer/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/appformer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/appformer/merges","archive_url":"https://api.github.com/repos/kiegroup/appformer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/appformer/downloads","issues_url":"https://api.github.com/repos/kiegroup/appformer/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/appformer/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/appformer/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/appformer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/appformer/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/appformer/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/appformer/deployments","created_at":"2015-05-08T19:13:36Z","updated_at":"2018-09-12T04:44:44Z","pushed_at":"2018-09-13T11:55:02Z","git_url":"git://github.com/kiegroup/appformer.git","ssh_url":"git@github.com:kiegroup/appformer.git","clone_url":"https://github.com/kiegroup/appformer.git","svn_url":"https://github.com/kiegroup/appformer","homepage":null,"size":47041,"stargazers_count":54,"watchers_count":54,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":87,"open_issues":10,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/459"},"html":{"href":"https://github.com/kiegroup/appformer/pull/459"},"issue":{"href":"https://api.github.com/repos/kiegroup/appformer/issues/459"},"comments":{"href":"https://api.github.com/repos/kiegroup/appformer/issues/459/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/459/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/appformer/pulls/459/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/appformer/statuses/0ffb6e5cad6f0de88c6b7becf3dcf9c62779a5f6"}},"author_association":"MEMBER"}} | {
"id": 35297180,
"name": "kiegroup/appformer",
"url": "https://api.github.com/repos/kiegroup/appformer"
} | {
"id": 119395,
"login": "porcelli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/119395?",
"url": "https://api.github.com/users/porcelli"
} | {
"id": 517980,
"login": "kiegroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/517980?",
"url": "https://api.github.com/orgs/kiegroup"
} | 2018-09-13T12:55:53 | 8259567338 | {"actor":{"display_login":"porcelli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/231404868","pull_request_review_id":172367209,"id":231404868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQwNDg2OA==","diff_hunk":"@@ -1358,6 +1364,64 @@ public void testStunnerConstellationButtonCausingPoint2DbeingNull() throws IOExc\n assertThat(wpTarget.getY()).isEqualByComparingTo(225d);\n }\n \n+ /**\n+ * DROOLS-2569 [DMN Designer] Marshalling of magnet positions -- Association DMN Edge DMNDI serialization.\n+ * This test re-create by hard-code the graph to simulate the behavior of the Stunner framework programmatically.\n+ */\n+ @SuppressWarnings(\"unchecked\")\n+ @Test\n+ public void testAssociationEdgeDMNDI() throws IOException {\n+ Diagram diagram = applicationFactoryManager.newDiagram(\"testDiagram\",\n+ BindableAdapterUtils.getDefinitionSetId(DMNDefinitionSet.class),\n+ null);\n+ Graph g = diagram.getGraph();\n+ Node diagramRoot = DMNMarshaller.findDMNDiagramRoot(g);\n+ testAugmentWithNSPrefixes(((DMNDiagram) ((View<?>) diagramRoot.getContent()).getDefinition()).getDefinitions());\n+\n+ org.kie.dmn.model.api.InputData dmnInputData = (org.kie.dmn.model.api.InputData) new TInputData();","path":"kie-wb-common-dmn/kie-wb-common-dmn-backend/src/test/java/org/kie/workbench/common/dmn/backend/DMNMarshallerTest.java","position":64,"original_position":64,"commit_id":"56d4fa15feaaa8023670cdad58810d87780a70d0","original_commit_id":"56d4fa15feaaa8023670cdad58810d87780a70d0","user":{"login":"jomarko","id":8044780,"node_id":"MDQ6VXNlcjgwNDQ3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/8044780?v=4","gravatar_id":"","url":"https://api.github.com/users/jomarko","html_url":"https://github.com/jomarko","followers_url":"https://api.github.com/users/jomarko/followers","following_url":"https://api.github.com/users/jomarko/following{/other_user}","gists_url":"https://api.github.com/users/jomarko/gists{/gist_id}","starred_url":"https://api.github.com/users/jomarko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jomarko/subscriptions","organizations_url":"https://api.github.com/users/jomarko/orgs","repos_url":"https://api.github.com/users/jomarko/repos","events_url":"https://api.github.com/users/jomarko/events{/privacy}","received_events_url":"https://api.github.com/users/jomarko/received_events","type":"User","site_admin":false},"body":"Casting is not needed as `TInputData` implements `InputData`.","created_at":"2018-11-07T07:42:03Z","updated_at":"2018-11-07T07:52:00Z","html_url":"https://github.com/kiegroup/kie-wb-common/pull/2245#discussion_r231404868","pull_request_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments/231404868"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/2245#discussion_r231404868"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245","id":228755900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzU1OTAw","html_url":"https://github.com/kiegroup/kie-wb-common/pull/2245","diff_url":"https://github.com/kiegroup/kie-wb-common/pull/2245.diff","patch_url":"https://github.com/kiegroup/kie-wb-common/pull/2245.patch","issue_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/2245","number":2245,"state":"open","locked":false,"title":"DROOLS-2569 [DMN Designer] Marshalling of magnet positions","user":{"login":"tarilabs","id":1699252,"node_id":"MDQ6VXNlcjE2OTkyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1699252?v=4","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"body":"Association DMN Edge DMNDI serialization.\r\n\r\n/cc @manstis @jomarko this PR should address this last issue: https://issues.jboss.org/browse/DROOLS-2569?focusedCommentId=13654081&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13654081","created_at":"2018-11-06T16:34:55Z","updated_at":"2018-11-07T07:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e835b70b17cfbd125e79f6794ddd5b329047a7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245/commits","review_comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245/comments","review_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/2245/comments","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/56d4fa15feaaa8023670cdad58810d87780a70d0","head":{"label":"tarilabs:tarilabs-20181106","ref":"tarilabs-20181106","sha":"56d4fa15feaaa8023670cdad58810d87780a70d0","user":{"login":"tarilabs","id":1699252,"node_id":"MDQ6VXNlcjE2OTkyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1699252?v=4","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"repo":{"id":65296977,"node_id":"MDEwOlJlcG9zaXRvcnk2NTI5Njk3Nw==","name":"kie-wb-common","full_name":"tarilabs/kie-wb-common","private":false,"owner":{"login":"tarilabs","id":1699252,"node_id":"MDQ6VXNlcjE2OTkyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1699252?v=4","gravatar_id":"","url":"https://api.github.com/users/tarilabs","html_url":"https://github.com/tarilabs","followers_url":"https://api.github.com/users/tarilabs/followers","following_url":"https://api.github.com/users/tarilabs/following{/other_user}","gists_url":"https://api.github.com/users/tarilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/tarilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarilabs/subscriptions","organizations_url":"https://api.github.com/users/tarilabs/orgs","repos_url":"https://api.github.com/users/tarilabs/repos","events_url":"https://api.github.com/users/tarilabs/events{/privacy}","received_events_url":"https://api.github.com/users/tarilabs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tarilabs/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":true,"url":"https://api.github.com/repos/tarilabs/kie-wb-common","forks_url":"https://api.github.com/repos/tarilabs/kie-wb-common/forks","keys_url":"https://api.github.com/repos/tarilabs/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarilabs/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarilabs/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/tarilabs/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/tarilabs/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/tarilabs/kie-wb-common/events","assignees_url":"https://api.github.com/repos/tarilabs/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/tarilabs/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/tarilabs/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/tarilabs/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarilabs/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarilabs/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarilabs/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarilabs/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/tarilabs/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/tarilabs/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/tarilabs/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/tarilabs/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/tarilabs/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/tarilabs/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarilabs/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarilabs/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarilabs/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarilabs/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/tarilabs/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarilabs/kie-wb-common/merges","archive_url":"https://api.github.com/repos/tarilabs/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarilabs/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/tarilabs/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/tarilabs/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/tarilabs/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/tarilabs/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarilabs/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/tarilabs/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/tarilabs/kie-wb-common/deployments","created_at":"2016-08-09T13:24:10Z","updated_at":"2018-10-31T13:46:51Z","pushed_at":"2018-11-06T17:10:55Z","git_url":"git://github.com/tarilabs/kie-wb-common.git","ssh_url":"git@github.com:tarilabs/kie-wb-common.git","clone_url":"https://github.com/tarilabs/kie-wb-common.git","svn_url":"https://github.com/tarilabs/kie-wb-common","homepage":"","size":46777,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"e2966c33345f2cb454475286e4843a3091163203","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":10522120,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyMjEyMA==","name":"kie-wb-common","full_name":"kiegroup/kie-wb-common","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":false,"url":"https://api.github.com/repos/kiegroup/kie-wb-common","forks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/forks","keys_url":"https://api.github.com/repos/kiegroup/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/kiegroup/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/kie-wb-common/events","assignees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/kie-wb-common/merges","archive_url":"https://api.github.com/repos/kiegroup/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/kiegroup/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/kie-wb-common/deployments","created_at":"2013-06-06T08:32:03Z","updated_at":"2018-11-07T05:32:24Z","pushed_at":"2018-11-07T05:41:24Z","git_url":"git://github.com/kiegroup/kie-wb-common.git","ssh_url":"git@github.com:kiegroup/kie-wb-common.git","clone_url":"https://github.com/kiegroup/kie-wb-common.git","svn_url":"https://github.com/kiegroup/kie-wb-common","homepage":"","size":51112,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":169,"open_issues":26,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245"},"html":{"href":"https://github.com/kiegroup/kie-wb-common/pull/2245"},"issue":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/2245"},"comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/issues/2245/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/pulls/2245/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/kie-wb-common/statuses/56d4fa15feaaa8023670cdad58810d87780a70d0"}},"author_association":"MEMBER"}} | {
"id": 10522120,
"name": "kiegroup/kie-wb-common",
"url": "https://api.github.com/repos/kiegroup/kie-wb-common"
} | {
"id": 8044780,
"login": "jomarko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8044780?",
"url": "https://api.github.com/users/jomarko"
} | {
"id": 517980,
"login": "kiegroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/517980?",
"url": "https://api.github.com/orgs/kiegroup"
} | 2018-11-07T07:42:03 | 8547885976 | {"actor":{"display_login":"jomarko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments/174124628","pull_request_review_id":103422658,"id":174124628,"diff_hunk":"@@ -0,0 +1,247 @@\n+import QtQuick 2.5\n+import QtQuick.Dialogs 1.2\n+import QtQuick.Controls 1.4\n+import QtQuick.Layouts 1.1\n+import QtQuick.Window 2.0\n+import \"utils.js\" as Utils\n+\n+ColumnLayout {\n+ property var device\n+\n+ readonly property bool acceptableInput: acceptablePin\n+ readonly property bool acceptablePin: !pinInput.enabled\n+ || pinInput.acceptableInput\n+ readonly property bool hasDevice: (device && device.hasDevice\n+ && device.piv) || false\n+ readonly property bool usePinAsKey: tabs.currentIndex == 0\n+ readonly property bool pinIsKeyCurrently: device.piv\n+ && device.piv.has_protected_key\n+ || false\n+ property alias requireTouch: requireTouchCheckbox.checked\n+\n+ property string newManagementKeyInputText\n+\n+ signal canceled\n+ signal changeSuccessful(bool pinAsKey, bool requireTouch)\n+\n+ Layout.minimumHeight: tabs.Layout.minimumHeight\n+ Layout.minimumWidth: tabs.Layout.minimumWidth\n+\n+ TabView {\n+ id: tabs\n+ Layout.fillWidth: true\n+\n+ Layout.minimumHeight: Utils.sum(Utils.pick(contentItem.children,\n+ 'implicitHeight'))\n+ Layout.minimumWidth: Utils.sum(Utils.pick(contentItem.children,\n+ 'implicitWidth'))\n+\n+ Component.onCompleted: {\n+ tabs.currentIndex = 1\n+ tabs.currentIndex = 0\n+ }\n+\n+ Tab {\n+ id: personalTab\n+ title: qsTr(\"Personal\")\n+ anchors.margins: margins\n+\n+ ColumnLayout {\n+ Label {\n+ text: qsTr(\"PIN will be used as management key.\")\n+ }\n+ }\n+ }\n+\n+ Tab {\n+ id: enterpriseTab\n+ title: qsTr(\"Enterprise\")\n+ anchors.margins: margins\n+\n+ ColumnLayout {\n+ id: foo\n+\n+ Label {\n+ text: qsTr(\"A management key separate from the PIN will be created.\")\n+ }\n+\n+ Label {\n+ text: qsTr(\"New management key:\")\n+ }\n+\n+ TextField {\n+ id: newManagementKeyInput\n+ maximumLength: 48\n+ focus: true\n+ Layout.fillWidth: true\n+\n+ onTextChanged: setNewManagementKeyInput(\n+ text) // Root can't reference TabView children directly\n+\n+ validator: RegExpValidator {\n+ regExp: /[0-9a-f]{48}/\n+ }\n+ }\n+\n+ RowLayout {\n+ Button {\n+ text: qsTr(\"Randomize\")\n+ onClicked: {\n+ device.piv_generate_random_mgm_key(function (key) {\n+ newManagementKeyInput.text = key\n+ })\n+ }\n+ }\n+\n+ Button {\n+ text: qsTr(\"Copy to clipboard\")\n+ onClicked: copyToClipboard(newManagementKeyInput.text)\n+ }\n+ }\n+ }\n+ }\n+ }\n+\n+ RowLayout {\n+\n+ Label {\n+ Layout.fillWidth: true\n+ enabled: !pinIsKeyCurrently\n+ text: qsTr(\"Current management key:\")\n+ }\n+\n+ Label {\n+ Layout.alignment: Qt.AlignRight\n+ font.italic: true\n+ text: qsTr(\"PIN is currently used as key.\")\n+ visible: pinIsKeyCurrently\n+ }\n+ }\n+\n+ RowLayout {\n+ TextField {\n+ id: currentManagementKeyInput\n+ enabled: !pinIsKeyCurrently\n+ maximumLength: 48\n+ Layout.fillWidth: true\n+\n+ validator: RegExpValidator {\n+ regExp: /[0-9a-f]{48}/\n+ }\n+ }\n+\n+ Button {","path":"ykman-gui/qml/PivSetManagementKeyForm.qml","position":133,"original_position":133,"commit_id":"8b533ff639596fee4e8aaabc96f3a8c7f03724c9","original_commit_id":"f61f03eff86d6212a0492c850268f73579accdb3","user":{"login":"emlun","id":1367758,"avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"Yeah, good idea. Shall we do that in a separate PR?","created_at":"2018-03-13T13:20:05Z","updated_at":"2018-03-13T13:20:05Z","html_url":"https://github.com/Yubico/yubikey-manager-qt/pull/34#discussion_r174124628","pull_request_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments/174124628"},"html":{"href":"https://github.com/Yubico/yubikey-manager-qt/pull/34#discussion_r174124628"},"pull_request":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34"}},"in_reply_to_id":174122473},"pull_request":{"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34","id":174647804,"html_url":"https://github.com/Yubico/yubikey-manager-qt/pull/34","diff_url":"https://github.com/Yubico/yubikey-manager-qt/pull/34.diff","patch_url":"https://github.com/Yubico/yubikey-manager-qt/pull/34.patch","issue_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/34","number":34,"state":"open","locked":false,"title":"Import PIV manager functionality","user":{"login":"emlun","id":1367758,"avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"body":"Not included:\r\n\r\n- Integrations with Microsoft Windows\r\n- Integrations with Mac operating systems","created_at":"2018-03-13T12:43:10Z","updated_at":"2018-03-13T13:20:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfda2acff7e5279c5abb63bb2752452ed0406810","assignee":{"login":"emlun","id":1367758,"avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false},"assignees":[{"login":"emlun","id":1367758,"avatar_url":"https://avatars3.githubusercontent.com/u/1367758?v=4","gravatar_id":"","url":"https://api.github.com/users/emlun","html_url":"https://github.com/emlun","followers_url":"https://api.github.com/users/emlun/followers","following_url":"https://api.github.com/users/emlun/following{/other_user}","gists_url":"https://api.github.com/users/emlun/gists{/gist_id}","starred_url":"https://api.github.com/users/emlun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlun/subscriptions","organizations_url":"https://api.github.com/users/emlun/orgs","repos_url":"https://api.github.com/users/emlun/repos","events_url":"https://api.github.com/users/emlun/events{/privacy}","received_events_url":"https://api.github.com/users/emlun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34/commits","review_comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34/comments","review_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/34/comments","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/8b533ff639596fee4e8aaabc96f3a8c7f03724c9","head":{"label":"Yubico:piv-manager-split","ref":"piv-manager-split","sha":"8b533ff639596fee4e8aaabc96f3a8c7f03724c9","user":{"login":"Yubico","id":531825,"avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"repo":{"id":71568220,"name":"yubikey-manager-qt","full_name":"Yubico/yubikey-manager-qt","owner":{"login":"Yubico","id":531825,"avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yubico/yubikey-manager-qt","description":"Cross-platform application for configuring any YubiKey over all USB transports.","fork":false,"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt","forks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/forks","keys_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/teams","hooks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/hooks","issue_events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/events","assignees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/tags","blobs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/languages","stargazers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/stargazers","contributors_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contributors","subscribers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscribers","subscription_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscription","commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/merges","archive_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/downloads","issues_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/labels{/name}","releases_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/deployments","created_at":"2016-10-21T13:40:28Z","updated_at":"2018-03-13T12:55:30Z","pushed_at":"2018-03-13T13:18:02Z","git_url":"git://github.com/Yubico/yubikey-manager-qt.git","ssh_url":"git@github.com:Yubico/yubikey-manager-qt.git","clone_url":"https://github.com/Yubico/yubikey-manager-qt.git","svn_url":"https://github.com/Yubico/yubikey-manager-qt","homepage":"https://developers.yubico.com/yubikey-manager-qt/","size":1241,"stargazers_count":44,"watchers_count":44,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":2,"watchers":44,"default_branch":"master"}},"base":{"label":"Yubico:master","ref":"master","sha":"f3cbb0ff8d318421b71ccfd653e02b8e18be57b0","user":{"login":"Yubico","id":531825,"avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"repo":{"id":71568220,"name":"yubikey-manager-qt","full_name":"Yubico/yubikey-manager-qt","owner":{"login":"Yubico","id":531825,"avatar_url":"https://avatars0.githubusercontent.com/u/531825?v=4","gravatar_id":"","url":"https://api.github.com/users/Yubico","html_url":"https://github.com/Yubico","followers_url":"https://api.github.com/users/Yubico/followers","following_url":"https://api.github.com/users/Yubico/following{/other_user}","gists_url":"https://api.github.com/users/Yubico/gists{/gist_id}","starred_url":"https://api.github.com/users/Yubico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yubico/subscriptions","organizations_url":"https://api.github.com/users/Yubico/orgs","repos_url":"https://api.github.com/users/Yubico/repos","events_url":"https://api.github.com/users/Yubico/events{/privacy}","received_events_url":"https://api.github.com/users/Yubico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yubico/yubikey-manager-qt","description":"Cross-platform application for configuring any YubiKey over all USB transports.","fork":false,"url":"https://api.github.com/repos/Yubico/yubikey-manager-qt","forks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/forks","keys_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/teams","hooks_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/hooks","issue_events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/events","assignees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/tags","blobs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/languages","stargazers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/stargazers","contributors_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contributors","subscribers_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscribers","subscription_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/subscription","commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/merges","archive_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/downloads","issues_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/labels{/name}","releases_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Yubico/yubikey-manager-qt/deployments","created_at":"2016-10-21T13:40:28Z","updated_at":"2018-03-13T12:55:30Z","pushed_at":"2018-03-13T13:18:02Z","git_url":"git://github.com/Yubico/yubikey-manager-qt.git","ssh_url":"git@github.com:Yubico/yubikey-manager-qt.git","clone_url":"https://github.com/Yubico/yubikey-manager-qt.git","svn_url":"https://github.com/Yubico/yubikey-manager-qt","homepage":"https://developers.yubico.com/yubikey-manager-qt/","size":1241,"stargazers_count":44,"watchers_count":44,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":2,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34"},"html":{"href":"https://github.com/Yubico/yubikey-manager-qt/pull/34"},"issue":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/34"},"comments":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/Yubico/yubikey-manager-qt/statuses/8b533ff639596fee4e8aaabc96f3a8c7f03724c9"}},"author_association":"MEMBER"}} | {
"id": 71568220,
"name": "Yubico/yubikey-manager-qt",
"url": "https://api.github.com/repos/Yubico/yubikey-manager-qt"
} | {
"id": 1367758,
"login": "emlun",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1367758?",
"url": "https://api.github.com/users/emlun"
} | {
"id": 531825,
"login": "Yubico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/531825?",
"url": "https://api.github.com/orgs/Yubico"
} | 2018-03-13T13:20:05 | 7371901026 | {"actor":{"display_login":"emlun"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/gestalt/pulls/comments/204598156","pull_request_review_id":139705435,"id":204598156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU5ODE1Ng==","diff_hunk":"@@ -144,6 +144,33 @@ class CheckboxExample extends React.Component {\n />\n );\n \n+card(\n+ <Example\n+ name=\"Example: Error state\"\n+ defaultCode={`\n+class CheckboxExample extends React.Component {\n+ render() {\n+ return (\n+ <Box alignItems=\"center\" direction=\"row\" display=\"flex\">\n+ <Checkbox\n+ error","path":"docs/src/Checkbox.doc.js","position":13,"original_position":13,"commit_id":"b87e0f6052cd6b3ea3ef3c2c189b15c224602b2b","original_commit_id":"b87e0f6052cd6b3ea3ef3c2c189b15c224602b2b","user":{"login":"mminute","id":10646092,"node_id":"MDQ6VXNlcjEwNjQ2MDky","avatar_url":"https://avatars3.githubusercontent.com/u/10646092?v=4","gravatar_id":"","url":"https://api.github.com/users/mminute","html_url":"https://github.com/mminute","followers_url":"https://api.github.com/users/mminute/followers","following_url":"https://api.github.com/users/mminute/following{/other_user}","gists_url":"https://api.github.com/users/mminute/gists{/gist_id}","starred_url":"https://api.github.com/users/mminute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminute/subscriptions","organizations_url":"https://api.github.com/users/mminute/orgs","repos_url":"https://api.github.com/users/mminute/repos","events_url":"https://api.github.com/users/mminute/events{/privacy}","received_events_url":"https://api.github.com/users/mminute/received_events","type":"User","site_admin":false},"body":"thanks for catching","created_at":"2018-07-24T01:11:09Z","updated_at":"2018-07-24T01:11:09Z","html_url":"https://github.com/pinterest/gestalt/pull/287#discussion_r204598156","pull_request_url":"https://api.github.com/repos/pinterest/gestalt/pulls/287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/comments/204598156"},"html":{"href":"https://github.com/pinterest/gestalt/pull/287#discussion_r204598156"},"pull_request":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/287"}},"in_reply_to_id":204598070},"pull_request":{"url":"https://api.github.com/repos/pinterest/gestalt/pulls/287","id":203370071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzcwMDcx","html_url":"https://github.com/pinterest/gestalt/pull/287","diff_url":"https://github.com/pinterest/gestalt/pull/287.diff","patch_url":"https://github.com/pinterest/gestalt/pull/287.patch","issue_url":"https://api.github.com/repos/pinterest/gestalt/issues/287","number":287,"state":"open","locked":false,"title":"Checkbox: Add error prop and styling","user":{"login":"mminute","id":10646092,"node_id":"MDQ6VXNlcjEwNjQ2MDky","avatar_url":"https://avatars3.githubusercontent.com/u/10646092?v=4","gravatar_id":"","url":"https://api.github.com/users/mminute","html_url":"https://github.com/mminute","followers_url":"https://api.github.com/users/mminute/followers","following_url":"https://api.github.com/users/mminute/following{/other_user}","gists_url":"https://api.github.com/users/mminute/gists{/gist_id}","starred_url":"https://api.github.com/users/mminute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminute/subscriptions","organizations_url":"https://api.github.com/users/mminute/orgs","repos_url":"https://api.github.com/users/mminute/repos","events_url":"https://api.github.com/users/mminute/events{/privacy}","received_events_url":"https://api.github.com/users/mminute/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-07-23T23:21:33Z","updated_at":"2018-07-24T01:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ab78819b09262ce23bb2b6aacbd308a34a05bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrislloyd","id":718,"node_id":"MDQ6VXNlcjcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/718?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislloyd","html_url":"https://github.com/chrislloyd","followers_url":"https://api.github.com/users/chrislloyd/followers","following_url":"https://api.github.com/users/chrislloyd/following{/other_user}","gists_url":"https://api.github.com/users/chrislloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislloyd/subscriptions","organizations_url":"https://api.github.com/users/chrislloyd/orgs","repos_url":"https://api.github.com/users/chrislloyd/repos","events_url":"https://api.github.com/users/chrislloyd/events{/privacy}","received_events_url":"https://api.github.com/users/chrislloyd/received_events","type":"User","site_admin":false},{"login":"christianvuerings","id":127199,"node_id":"MDQ6VXNlcjEyNzE5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/127199?v=4","gravatar_id":"","url":"https://api.github.com/users/christianvuerings","html_url":"https://github.com/christianvuerings","followers_url":"https://api.github.com/users/christianvuerings/followers","following_url":"https://api.github.com/users/christianvuerings/following{/other_user}","gists_url":"https://api.github.com/users/christianvuerings/gists{/gist_id}","starred_url":"https://api.github.com/users/christianvuerings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianvuerings/subscriptions","organizations_url":"https://api.github.com/users/christianvuerings/orgs","repos_url":"https://api.github.com/users/christianvuerings/repos","events_url":"https://api.github.com/users/christianvuerings/events{/privacy}","received_events_url":"https://api.github.com/users/christianvuerings/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/gestalt/pulls/287/commits","review_comments_url":"https://api.github.com/repos/pinterest/gestalt/pulls/287/comments","review_comment_url":"https://api.github.com/repos/pinterest/gestalt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/gestalt/issues/287/comments","statuses_url":"https://api.github.com/repos/pinterest/gestalt/statuses/b87e0f6052cd6b3ea3ef3c2c189b15c224602b2b","head":{"label":"mminute:checkboxError","ref":"checkboxError","sha":"b87e0f6052cd6b3ea3ef3c2c189b15c224602b2b","user":{"login":"mminute","id":10646092,"node_id":"MDQ6VXNlcjEwNjQ2MDky","avatar_url":"https://avatars3.githubusercontent.com/u/10646092?v=4","gravatar_id":"","url":"https://api.github.com/users/mminute","html_url":"https://github.com/mminute","followers_url":"https://api.github.com/users/mminute/followers","following_url":"https://api.github.com/users/mminute/following{/other_user}","gists_url":"https://api.github.com/users/mminute/gists{/gist_id}","starred_url":"https://api.github.com/users/mminute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminute/subscriptions","organizations_url":"https://api.github.com/users/mminute/orgs","repos_url":"https://api.github.com/users/mminute/repos","events_url":"https://api.github.com/users/mminute/events{/privacy}","received_events_url":"https://api.github.com/users/mminute/received_events","type":"User","site_admin":false},"repo":{"id":122685204,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2ODUyMDQ=","name":"gestalt","full_name":"mminute/gestalt","owner":{"login":"mminute","id":10646092,"node_id":"MDQ6VXNlcjEwNjQ2MDky","avatar_url":"https://avatars3.githubusercontent.com/u/10646092?v=4","gravatar_id":"","url":"https://api.github.com/users/mminute","html_url":"https://github.com/mminute","followers_url":"https://api.github.com/users/mminute/followers","following_url":"https://api.github.com/users/mminute/following{/other_user}","gists_url":"https://api.github.com/users/mminute/gists{/gist_id}","starred_url":"https://api.github.com/users/mminute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminute/subscriptions","organizations_url":"https://api.github.com/users/mminute/orgs","repos_url":"https://api.github.com/users/mminute/repos","events_url":"https://api.github.com/users/mminute/events{/privacy}","received_events_url":"https://api.github.com/users/mminute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mminute/gestalt","description":"A set of React UI components that supports Pinterest’s design language","fork":true,"url":"https://api.github.com/repos/mminute/gestalt","forks_url":"https://api.github.com/repos/mminute/gestalt/forks","keys_url":"https://api.github.com/repos/mminute/gestalt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mminute/gestalt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mminute/gestalt/teams","hooks_url":"https://api.github.com/repos/mminute/gestalt/hooks","issue_events_url":"https://api.github.com/repos/mminute/gestalt/issues/events{/number}","events_url":"https://api.github.com/repos/mminute/gestalt/events","assignees_url":"https://api.github.com/repos/mminute/gestalt/assignees{/user}","branches_url":"https://api.github.com/repos/mminute/gestalt/branches{/branch}","tags_url":"https://api.github.com/repos/mminute/gestalt/tags","blobs_url":"https://api.github.com/repos/mminute/gestalt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mminute/gestalt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mminute/gestalt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mminute/gestalt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mminute/gestalt/statuses/{sha}","languages_url":"https://api.github.com/repos/mminute/gestalt/languages","stargazers_url":"https://api.github.com/repos/mminute/gestalt/stargazers","contributors_url":"https://api.github.com/repos/mminute/gestalt/contributors","subscribers_url":"https://api.github.com/repos/mminute/gestalt/subscribers","subscription_url":"https://api.github.com/repos/mminute/gestalt/subscription","commits_url":"https://api.github.com/repos/mminute/gestalt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mminute/gestalt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mminute/gestalt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mminute/gestalt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mminute/gestalt/contents/{+path}","compare_url":"https://api.github.com/repos/mminute/gestalt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mminute/gestalt/merges","archive_url":"https://api.github.com/repos/mminute/gestalt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mminute/gestalt/downloads","issues_url":"https://api.github.com/repos/mminute/gestalt/issues{/number}","pulls_url":"https://api.github.com/repos/mminute/gestalt/pulls{/number}","milestones_url":"https://api.github.com/repos/mminute/gestalt/milestones{/number}","notifications_url":"https://api.github.com/repos/mminute/gestalt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mminute/gestalt/labels{/name}","releases_url":"https://api.github.com/repos/mminute/gestalt/releases{/id}","deployments_url":"https://api.github.com/repos/mminute/gestalt/deployments","created_at":"2018-02-23T23:57:55Z","updated_at":"2018-02-23T23:57:57Z","pushed_at":"2018-07-24T01:07:40Z","git_url":"git://github.com/mminute/gestalt.git","ssh_url":"git@github.com:mminute/gestalt.git","clone_url":"https://github.com/mminute/gestalt.git","svn_url":"https://github.com/mminute/gestalt","homepage":"https://pinterest.github.io/gestalt","size":3234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:master","ref":"master","sha":"9eaf96cd9f5dc2fd2bcbf5d4f642ddf946eb6973","user":{"login":"pinterest","id":541152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/541152?v=4","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":121806807,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4MDY4MDc=","name":"gestalt","full_name":"pinterest/gestalt","owner":{"login":"pinterest","id":541152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/541152?v=4","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/gestalt","description":"A set of React UI components that supports Pinterest’s design language","fork":false,"url":"https://api.github.com/repos/pinterest/gestalt","forks_url":"https://api.github.com/repos/pinterest/gestalt/forks","keys_url":"https://api.github.com/repos/pinterest/gestalt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/gestalt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/gestalt/teams","hooks_url":"https://api.github.com/repos/pinterest/gestalt/hooks","issue_events_url":"https://api.github.com/repos/pinterest/gestalt/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/gestalt/events","assignees_url":"https://api.github.com/repos/pinterest/gestalt/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/gestalt/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/gestalt/tags","blobs_url":"https://api.github.com/repos/pinterest/gestalt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/gestalt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/gestalt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/gestalt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/gestalt/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/gestalt/languages","stargazers_url":"https://api.github.com/repos/pinterest/gestalt/stargazers","contributors_url":"https://api.github.com/repos/pinterest/gestalt/contributors","subscribers_url":"https://api.github.com/repos/pinterest/gestalt/subscribers","subscription_url":"https://api.github.com/repos/pinterest/gestalt/subscription","commits_url":"https://api.github.com/repos/pinterest/gestalt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/gestalt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/gestalt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/gestalt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/gestalt/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/gestalt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/gestalt/merges","archive_url":"https://api.github.com/repos/pinterest/gestalt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/gestalt/downloads","issues_url":"https://api.github.com/repos/pinterest/gestalt/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/gestalt/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/gestalt/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/gestalt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/gestalt/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/gestalt/releases{/id}","deployments_url":"https://api.github.com/repos/pinterest/gestalt/deployments","created_at":"2018-02-16T22:17:51Z","updated_at":"2018-07-24T01:09:13Z","pushed_at":"2018-07-24T01:07:42Z","git_url":"git://github.com/pinterest/gestalt.git","ssh_url":"git@github.com:pinterest/gestalt.git","clone_url":"https://github.com/pinterest/gestalt.git","svn_url":"https://github.com/pinterest/gestalt","homepage":"https://pinterest.github.io/gestalt","size":5646,"stargazers_count":2317,"watchers_count":2317,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":108,"open_issues":25,"watchers":2317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/287"},"html":{"href":"https://github.com/pinterest/gestalt/pull/287"},"issue":{"href":"https://api.github.com/repos/pinterest/gestalt/issues/287"},"comments":{"href":"https://api.github.com/repos/pinterest/gestalt/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/gestalt/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/gestalt/statuses/b87e0f6052cd6b3ea3ef3c2c189b15c224602b2b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 121806807,
"name": "pinterest/gestalt",
"url": "https://api.github.com/repos/pinterest/gestalt"
} | {
"id": 10646092,
"login": "mminute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10646092?",
"url": "https://api.github.com/users/mminute"
} | {
"id": 541152,
"login": "pinterest",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/541152?",
"url": "https://api.github.com/orgs/pinterest"
} | 2018-07-24T01:11:09 | 8007235187 | {"actor":{"display_login":"mminute"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/comments/230027058","pull_request_review_id":170665270,"id":230027058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDAyNzA1OA==","diff_hunk":"@@ -1,78 +1,76 @@\n ---\n title: Overview\n+navigation_weight: 1\n+description: The SMS API overview.\n ---\n \n-# Overview\n+# SMS API Overview\n \n-Nexmo's SMS API allows you to send and receive text messages to users around the globe through simple RESTful APIs.\n+Nexmo's SMS API enables you to send and receive text messages to and from users worldwide, using simple REST APIs.\n \n-* Programmatically send and receive high volume of SMS anywhere in the world.\n-* Build apps that scale with the web technologies that you are already using.\n+* Programmatically send and receive high volumes of SMS globally.\n * Send SMS with low latency and high delivery rates.\n-* Receive SMS for free using SMS-enabled local numbers in countries around the world.\n-* Only pay for what you use, nothing more.\n+* Receive SMS for free using local numbers.\n+* Scale your applications with familiar web technologies.\n+* Pay only for what you use, nothing more.\n \n ## Contents\n \n-In this document you can learn about:\n+This document contains the following information:\n \n-* [Nexmo SMS API Concepts](#concepts)\n-* [How to Get Started with the SMS API](#getting-started)\n-* [Building Blocks](#building-blocks)\n-* [Guides](#guides)\n-* [Tutorials](#tutorials)\n-* [Reference](#reference)\n+* [Nexmo SMS API Concepts](#concepts) - what you need to know\n+* [**How to Get Started with the SMS API**](#getting-started) - try it out, using your chosen programming language\n+* [Guides](#guides) - learn how to use the SMS API\n+* [Building Blocks](#building-blocks) - code snippets to help with specific tasks\n+* [Tutorials](#tutorials) - detailed tutorials for some common use cases\n+* [Reference](#reference) - complete API documentation\n \n ## Concepts\n \n-To use the Nexmo SMS API, you may need to familiarise yourself with:\n+Before using the Nexmo SMS API, familiarise yourself with the following:\n \n-* **[Number format](/voice/voice-api/guides/numbers)** - All phone numbers in the Nexmo APIs use E.164 format.\n+* **[Number format](/voice/voice-api/guides/numbers)** - The SMS API requires phone numbers in E.164 format.\n \n-* **[Authentication](/concepts/guides/authentication)** - Nexmo SMS API is authenticated with your account API Key and Secret.\n+* **[Authentication](/concepts/guides/authentication)** - The SMS API authenticates using your account API key and secret.\n \n-* **[Webhooks](/concepts/guides/webhooks)** - HTTP requests are made to your application web server so that you can act upon them. For example, the SMS API will send the delivery receipts and inbound SMS.\n+* **[Webhooks](/concepts/guides/webhooks)** - The SMS API makes HTTP requests to your application web server so that you can act upon them. For example: inbound SMS and delivery receipts.\n \n ## Getting Started","path":"_documentation/messaging/sms/overview.md","position":null,"original_position":55,"commit_id":"373a9f1100f5cf5b527dfb3eca92710e0a2d11a4","original_commit_id":"ea81b9110fd2b7d846da432572ba34893e8931ec","user":{"login":"marklewin","id":18176755,"node_id":"MDQ6VXNlcjE4MTc2NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18176755?v=4","gravatar_id":"","url":"https://api.github.com/users/marklewin","html_url":"https://github.com/marklewin","followers_url":"https://api.github.com/users/marklewin/followers","following_url":"https://api.github.com/users/marklewin/following{/other_user}","gists_url":"https://api.github.com/users/marklewin/gists{/gist_id}","starred_url":"https://api.github.com/users/marklewin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklewin/subscriptions","organizations_url":"https://api.github.com/users/marklewin/orgs","repos_url":"https://api.github.com/users/marklewin/repos","events_url":"https://api.github.com/users/marklewin/events{/privacy}","received_events_url":"https://api.github.com/users/marklewin/received_events","type":"User","site_admin":false},"body":"Have moved the Getting Started section, but renaming the page from Overview to SMS API puts it right at the bottom of the navigation menu. Must be hard-coded in NDP?\r\n\r\n\r\n\r\n","created_at":"2018-11-01T12:34:16Z","updated_at":"2018-11-01T12:34:17Z","html_url":"https://github.com/Nexmo/nexmo-developer/pull/1155#discussion_r230027058","pull_request_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/comments/230027058"},"html":{"href":"https://github.com/Nexmo/nexmo-developer/pull/1155#discussion_r230027058"},"pull_request":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155"}},"in_reply_to_id":228586622},"pull_request":{"url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155","id":225018805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDE4ODA1","html_url":"https://github.com/Nexmo/nexmo-developer/pull/1155","diff_url":"https://github.com/Nexmo/nexmo-developer/pull/1155.diff","patch_url":"https://github.com/Nexmo/nexmo-developer/pull/1155.patch","issue_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/1155","number":1155,"state":"open","locked":false,"title":"Initial draft of SMS Overview page","user":{"login":"marklewin","id":18176755,"node_id":"MDQ6VXNlcjE4MTc2NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/18176755?v=4","gravatar_id":"","url":"https://api.github.com/users/marklewin","html_url":"https://github.com/marklewin","followers_url":"https://api.github.com/users/marklewin/followers","following_url":"https://api.github.com/users/marklewin/following{/other_user}","gists_url":"https://api.github.com/users/marklewin/gists{/gist_id}","starred_url":"https://api.github.com/users/marklewin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marklewin/subscriptions","organizations_url":"https://api.github.com/users/marklewin/orgs","repos_url":"https://api.github.com/users/marklewin/repos","events_url":"https://api.github.com/users/marklewin/events{/privacy}","received_events_url":"https://api.github.com/users/marklewin/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAn initial draft, but marking as \"don't merge\" because the building blocks are not in the new format yet. Completed this first because it will likely be translated first.\r\n\r\n## Deploy Notes\r\n\r\nBy all means comment on the verbiage, but the page won't display the code in the \"Getting Started\" section until the building blocks are migrated to the new YAML format.\r\n","created_at":"2018-10-23T12:30:13Z","updated_at":"2018-11-01T12:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c0908d3dd6361c5249fe282d758e6a959b3948e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":913713018,"node_id":"MDU6TGFiZWw5MTM3MTMwMTg=","url":"https://api.github.com/repos/Nexmo/nexmo-developer/labels/don't%20merge","name":"don't merge","color":"d6449e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155/commits","review_comments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155/comments","review_comment_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/1155/comments","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-developer/statuses/373a9f1100f5cf5b527dfb3eca92710e0a2d11a4","head":{"label":"Nexmo:markl-sms-overview","ref":"markl-sms-overview","sha":"373a9f1100f5cf5b527dfb3eca92710e0a2d11a4","user":{"login":"Nexmo","id":551057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTA1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/551057?v=4","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"repo":{"id":81933125,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzMzEyNQ==","name":"nexmo-developer","full_name":"Nexmo/nexmo-developer","private":false,"owner":{"login":"Nexmo","id":551057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTA1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/551057?v=4","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Nexmo/nexmo-developer","description":"Provides resources for developers using Nexmo API platforms","fork":false,"url":"https://api.github.com/repos/Nexmo/nexmo-developer","forks_url":"https://api.github.com/repos/Nexmo/nexmo-developer/forks","keys_url":"https://api.github.com/repos/Nexmo/nexmo-developer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nexmo/nexmo-developer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nexmo/nexmo-developer/teams","hooks_url":"https://api.github.com/repos/Nexmo/nexmo-developer/hooks","issue_events_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/events{/number}","events_url":"https://api.github.com/repos/Nexmo/nexmo-developer/events","assignees_url":"https://api.github.com/repos/Nexmo/nexmo-developer/assignees{/user}","branches_url":"https://api.github.com/repos/Nexmo/nexmo-developer/branches{/branch}","tags_url":"https://api.github.com/repos/Nexmo/nexmo-developer/tags","blobs_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-developer/statuses/{sha}","languages_url":"https://api.github.com/repos/Nexmo/nexmo-developer/languages","stargazers_url":"https://api.github.com/repos/Nexmo/nexmo-developer/stargazers","contributors_url":"https://api.github.com/repos/Nexmo/nexmo-developer/contributors","subscribers_url":"https://api.github.com/repos/Nexmo/nexmo-developer/subscribers","subscription_url":"https://api.github.com/repos/Nexmo/nexmo-developer/subscription","commits_url":"https://api.github.com/repos/Nexmo/nexmo-developer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nexmo/nexmo-developer/contents/{+path}","compare_url":"https://api.github.com/repos/Nexmo/nexmo-developer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nexmo/nexmo-developer/merges","archive_url":"https://api.github.com/repos/Nexmo/nexmo-developer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nexmo/nexmo-developer/downloads","issues_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues{/number}","pulls_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls{/number}","milestones_url":"https://api.github.com/repos/Nexmo/nexmo-developer/milestones{/number}","notifications_url":"https://api.github.com/repos/Nexmo/nexmo-developer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nexmo/nexmo-developer/labels{/name}","releases_url":"https://api.github.com/repos/Nexmo/nexmo-developer/releases{/id}","deployments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/deployments","created_at":"2017-02-14T10:19:36Z","updated_at":"2018-11-01T12:28:44Z","pushed_at":"2018-11-01T12:31:54Z","git_url":"git://github.com/Nexmo/nexmo-developer.git","ssh_url":"git@github.com:Nexmo/nexmo-developer.git","clone_url":"https://github.com/Nexmo/nexmo-developer.git","svn_url":"https://github.com/Nexmo/nexmo-developer","homepage":"https://developer.nexmo.com","size":40746,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":112,"open_issues":35,"watchers":29,"default_branch":"master"}},"base":{"label":"Nexmo:master","ref":"master","sha":"98aedc92b441282b21abfb131e4c88d2279b2bc7","user":{"login":"Nexmo","id":551057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTA1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/551057?v=4","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"repo":{"id":81933125,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzMzEyNQ==","name":"nexmo-developer","full_name":"Nexmo/nexmo-developer","private":false,"owner":{"login":"Nexmo","id":551057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTA1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/551057?v=4","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Nexmo/nexmo-developer","description":"Provides resources for developers using Nexmo API platforms","fork":false,"url":"https://api.github.com/repos/Nexmo/nexmo-developer","forks_url":"https://api.github.com/repos/Nexmo/nexmo-developer/forks","keys_url":"https://api.github.com/repos/Nexmo/nexmo-developer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nexmo/nexmo-developer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nexmo/nexmo-developer/teams","hooks_url":"https://api.github.com/repos/Nexmo/nexmo-developer/hooks","issue_events_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/events{/number}","events_url":"https://api.github.com/repos/Nexmo/nexmo-developer/events","assignees_url":"https://api.github.com/repos/Nexmo/nexmo-developer/assignees{/user}","branches_url":"https://api.github.com/repos/Nexmo/nexmo-developer/branches{/branch}","tags_url":"https://api.github.com/repos/Nexmo/nexmo-developer/tags","blobs_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-developer/statuses/{sha}","languages_url":"https://api.github.com/repos/Nexmo/nexmo-developer/languages","stargazers_url":"https://api.github.com/repos/Nexmo/nexmo-developer/stargazers","contributors_url":"https://api.github.com/repos/Nexmo/nexmo-developer/contributors","subscribers_url":"https://api.github.com/repos/Nexmo/nexmo-developer/subscribers","subscription_url":"https://api.github.com/repos/Nexmo/nexmo-developer/subscription","commits_url":"https://api.github.com/repos/Nexmo/nexmo-developer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nexmo/nexmo-developer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nexmo/nexmo-developer/contents/{+path}","compare_url":"https://api.github.com/repos/Nexmo/nexmo-developer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nexmo/nexmo-developer/merges","archive_url":"https://api.github.com/repos/Nexmo/nexmo-developer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nexmo/nexmo-developer/downloads","issues_url":"https://api.github.com/repos/Nexmo/nexmo-developer/issues{/number}","pulls_url":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls{/number}","milestones_url":"https://api.github.com/repos/Nexmo/nexmo-developer/milestones{/number}","notifications_url":"https://api.github.com/repos/Nexmo/nexmo-developer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nexmo/nexmo-developer/labels{/name}","releases_url":"https://api.github.com/repos/Nexmo/nexmo-developer/releases{/id}","deployments_url":"https://api.github.com/repos/Nexmo/nexmo-developer/deployments","created_at":"2017-02-14T10:19:36Z","updated_at":"2018-11-01T12:28:44Z","pushed_at":"2018-11-01T12:31:54Z","git_url":"git://github.com/Nexmo/nexmo-developer.git","ssh_url":"git@github.com:Nexmo/nexmo-developer.git","clone_url":"https://github.com/Nexmo/nexmo-developer.git","svn_url":"https://github.com/Nexmo/nexmo-developer","homepage":"https://developer.nexmo.com","size":40746,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":112,"open_issues":35,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155"},"html":{"href":"https://github.com/Nexmo/nexmo-developer/pull/1155"},"issue":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/1155"},"comments":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/issues/1155/comments"},"review_comments":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155/comments"},"review_comment":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/pulls/1155/commits"},"statuses":{"href":"https://api.github.com/repos/Nexmo/nexmo-developer/statuses/373a9f1100f5cf5b527dfb3eca92710e0a2d11a4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 81933125,
"name": "Nexmo/nexmo-developer",
"url": "https://api.github.com/repos/Nexmo/nexmo-developer"
} | {
"id": 18176755,
"login": "marklewin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18176755?",
"url": "https://api.github.com/users/marklewin"
} | {
"id": 551057,
"login": "Nexmo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/551057?",
"url": "https://api.github.com/orgs/Nexmo"
} | 2018-11-01T12:34:16 | 8518700336 | {"actor":{"display_login":"marklewin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3-network/pulls/comments/237685646","pull_request_review_id":180046040,"id":237685646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzY4NTY0Ng==","diff_hunk":"@@ -0,0 +1,204 @@\n+import numpy as np\n+\n+from Orange.data import DiscreteVariable, Table, Domain\n+from Orange.widgets import gui\n+from Orange.widgets.settings import ContextSetting, DomainContextHandler\n+from Orange.widgets.utils.itemmodels import DomainModel\n+from Orange.widgets.widget import Input, Output, OWWidget, Msg\n+from orangecontrib.network import Graph\n+\n+\n+class OWNxGroups(OWWidget):\n+ name = \"Network Of Groups\"\n+ description = \"Group instances by feature and connect related groups.\"\n+ icon = \"icons/NetworkGroups.svg\"\n+ priority = 6435\n+\n+ class Inputs:\n+ network = Input(\"Network\", Graph, default=True)\n+ data = Input(\"Data\", Table)\n+\n+ class Outputs:\n+ network = Output(\"Network\", Graph, default=True)\n+ data = Output(\"Data\", Table)\n+\n+ class Warning(OWWidget.Warning):\n+ no_graph_found = Msg(\"Data is given, network is missing.\")\n+ no_discrete_features = Msg(\"Data has no discrete features.\")\n+\n+ class Error(OWWidget.Error):\n+ data_size_mismatch = Msg(\"Length of the data does not \"\n+ \"match the number of nodes.\")\n+\n+ resizing_enabled = False\n+ want_main_area = False\n+\n+ settingsHandler = DomainContextHandler()\n+ feature = ContextSetting(None)\n+\n+ def __init__(self):\n+ super().__init__()\n+ self.network = None\n+ self.data = None\n+ self.effective_data = None\n+ self.output_network = None\n+\n+ info_box = gui.widgetBox(self.controlArea, \"Info\")\n+ self.input_label = gui.widgetLabel(info_box, \"\")\n+ self.__set_input_label_text()\n+\n+ feature_box = gui.widgetBox(self.controlArea, \"Group by\")\n+ self.feature_model = DomainModel(valid_types=DiscreteVariable)\n+ self.feature_combo = gui.comboBox(\n+ feature_box, self, \"feature\", contentsLength=15,\n+ callback=self.__feature_combo_changed, model=self.feature_model\n+ )\n+\n+ def __set_input_label_text(self):\n+ text = \"No data on input.\"\n+ if self.network is not None:\n+ dir_ = \"Directed\" if self.network.is_directed() else \"Undirected\"\n+ text = f\"{dir_} graph\\n{self.network.number_of_nodes()}\" \\\n+ f\" nodes, {self.network.number_of_edges()} edges\"\n+ self.input_label.setText(text)\n+\n+ def __feature_combo_changed(self):\n+ self.commit()\n+\n+ @Inputs.network\n+ def set_network(self, network):\n+ self.network = network\n+ self.__set_input_label_text()\n+\n+ @Inputs.data\n+ def set_data(self, data):\n+ self.data = data\n+\n+ def handleNewSignals(self):\n+ if self.feature_model:\n+ self.closeContext()\n+ self.clear_messages()\n+ self.set_effective_data()\n+ self.set_feature_model()\n+ if self.feature_model:\n+ self.openContext(self.effective_data)\n+ self.commit()\n+\n+ def set_effective_data(self):\n+ self.effective_data = None\n+ if self.network is None and self.data is not None:\n+ self.Warning.no_graph_found()\n+ elif self.network is not None and self.data is not None:\n+ if len(self.data) != self.network.number_of_nodes():\n+ self.Error.data_size_mismatch()\n+ else:\n+ self.effective_data = self.data\n+ elif self.data is None and self.network is not None:\n+ self.effective_data = self.network.items()\n+\n+ if self.effective_data is not None and not \\\n+ self.effective_data.domain.has_discrete_attributes(True, True):\n+ self.Warning.no_discrete_features()\n+\n+ def set_feature_model(self):\n+ data = self.effective_data\n+ self.feature_model.set_domain(data and data.domain)\n+ self.feature = self.feature_model[0] if self.feature_model else None\n+\n+ def commit(self):\n+ if self.feature is None:\n+ self.output_network = None\n+ self.Outputs.network.send(None)\n+ self.Outputs.data.send(None)\n+ return\n+\n+ self._map_network()\n+ self.Outputs.network.send(self.output_network)\n+ self.Outputs.data.send(self.output_network.items())\n+\n+ def _map_network(self):\n+ edges = self.network.edges(data='weight')\n+ row, col, weights = zip(*edges)\n+ col, row = self._map_into_feature_values(np.array(row), np.array(col))\n+ edges = self._construct_edges(row, col, np.array(weights))\n+\n+ network = Graph()\n+ network.add_nodes_from(range(len(self.feature.values)))\n+ network.add_weighted_edges_from(edges)\n+ network.set_items(self._construct_items())\n+ self.output_network = network\n+\n+ def _map_into_feature_values(self, row, col):\n+ n_edges = self.network.number_of_edges()\n+ selected_column = self.effective_data.get_column_view(self.feature)[0]\n+ mapped_row = np.empty(n_edges)\n+ mapped_col = np.empty(n_edges)\n+ for node in range(self.network.number_of_nodes()):\n+ value = selected_column[node]\n+ mapped_row[row == node] = value\n+ mapped_col[col == node] = value\n+ return mapped_row, mapped_col\n+\n+ @staticmethod\n+ def _construct_edges(col, row, weights):\n+ # remove edges that connect to \"unknown\" group\n+ mask = ~np.any(np.isnan(np.vstack((row, col))), axis=0)\n+ # remove edges within a node\n+ mask = np.logical_and((row != col), mask)\n+ row, col, weights = row[mask], col[mask], weights[mask]\n+\n+ # find unique edges\n+ mask = row > col\n+ row[mask], col[mask] = col[mask], row[mask]\n+\n+ array = np.vstack((row, col))\n+ (row, col), inverse = np.unique(array, axis=1, return_inverse=True)\n+\n+ # assign each edge the sum of weights of belonging original edges\n+ weights = np.array(\n+ [np.sum(weights[inverse == i]) for i in range(len(row))])","path":"orangecontrib/network/widgets/OWNxGroups.py","position":159,"original_position":159,"commit_id":"dc6df0a03f60b509955feed60b976175f2139215","original_commit_id":"dc6df0a03f60b509955feed60b976175f2139215","user":{"login":"janezd","id":2387315,"node_id":"MDQ6VXNlcjIzODczMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2387315?v=4","gravatar_id":"","url":"https://api.github.com/users/janezd","html_url":"https://github.com/janezd","followers_url":"https://api.github.com/users/janezd/followers","following_url":"https://api.github.com/users/janezd/following{/other_user}","gists_url":"https://api.github.com/users/janezd/gists{/gist_id}","starred_url":"https://api.github.com/users/janezd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janezd/subscriptions","organizations_url":"https://api.github.com/users/janezd/orgs","repos_url":"https://api.github.com/users/janezd/repos","events_url":"https://api.github.com/users/janezd/events{/privacy}","received_events_url":"https://api.github.com/users/janezd/received_events","type":"User","site_admin":false},"body":"This is cool. And I learned something new about `np.unique`.","created_at":"2018-11-29T22:35:33Z","updated_at":"2018-11-29T22:51:44Z","html_url":"https://github.com/biolab/orange3-network/pull/95#discussion_r237685646","pull_request_url":"https://api.github.com/repos/biolab/orange3-network/pulls/95","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/comments/237685646"},"html":{"href":"https://github.com/biolab/orange3-network/pull/95#discussion_r237685646"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3-network/pulls/95","id":233888576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODg4NTc2","html_url":"https://github.com/biolab/orange3-network/pull/95","diff_url":"https://github.com/biolab/orange3-network/pull/95.diff","patch_url":"https://github.com/biolab/orange3-network/pull/95.patch","issue_url":"https://api.github.com/repos/biolab/orange3-network/issues/95","number":95,"state":"open","locked":false,"title":"[ENH] Network Of Groups: Add a new widget","user":{"login":"VesnaT","id":11465003,"node_id":"MDQ6VXNlcjExNDY1MDAz","avatar_url":"https://avatars3.githubusercontent.com/u/11465003?v=4","gravatar_id":"","url":"https://api.github.com/users/VesnaT","html_url":"https://github.com/VesnaT","followers_url":"https://api.github.com/users/VesnaT/followers","following_url":"https://api.github.com/users/VesnaT/following{/other_user}","gists_url":"https://api.github.com/users/VesnaT/gists{/gist_id}","starred_url":"https://api.github.com/users/VesnaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesnaT/subscriptions","organizations_url":"https://api.github.com/users/VesnaT/orgs","repos_url":"https://api.github.com/users/VesnaT/repos","events_url":"https://api.github.com/users/VesnaT/events{/privacy}","received_events_url":"https://api.github.com/users/VesnaT/received_events","type":"User","site_admin":false},"body":"##### Issue\r\n<!-- E.g. Fixes #1, Implements #2, etc. -->\r\n<!-- Or a short description, if the issue does not exist. -->\r\nReduce by value: Widget to create a network with nodes corresponding to values of some categorical feature (Department), and two values are connected, if there exists a pair of nodes in the original network that are connected and have this values. Its weight is the sum of weights.\r\n\r\n##### Description of changes\r\n\r\n\r\n##### Includes\r\n- [X] Code changes\r\n- [X] Tests\r\n- [ ] Documentation\r\n","created_at":"2018-11-27T12:13:26Z","updated_at":"2018-11-29T22:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54adb5f1cce0f919946bd2e04642c392a8dcb02b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3-network/pulls/95/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3-network/pulls/95/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3-network/issues/95/comments","statuses_url":"https://api.github.com/repos/biolab/orange3-network/statuses/dc6df0a03f60b509955feed60b976175f2139215","head":{"label":"VesnaT:ownxgroups","ref":"ownxgroups","sha":"dc6df0a03f60b509955feed60b976175f2139215","user":{"login":"VesnaT","id":11465003,"node_id":"MDQ6VXNlcjExNDY1MDAz","avatar_url":"https://avatars3.githubusercontent.com/u/11465003?v=4","gravatar_id":"","url":"https://api.github.com/users/VesnaT","html_url":"https://github.com/VesnaT","followers_url":"https://api.github.com/users/VesnaT/followers","following_url":"https://api.github.com/users/VesnaT/following{/other_user}","gists_url":"https://api.github.com/users/VesnaT/gists{/gist_id}","starred_url":"https://api.github.com/users/VesnaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesnaT/subscriptions","organizations_url":"https://api.github.com/users/VesnaT/orgs","repos_url":"https://api.github.com/users/VesnaT/repos","events_url":"https://api.github.com/users/VesnaT/events{/privacy}","received_events_url":"https://api.github.com/users/VesnaT/received_events","type":"User","site_admin":false},"repo":{"id":159329714,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzMjk3MTQ=","name":"orange3-network","full_name":"VesnaT/orange3-network","private":false,"owner":{"login":"VesnaT","id":11465003,"node_id":"MDQ6VXNlcjExNDY1MDAz","avatar_url":"https://avatars3.githubusercontent.com/u/11465003?v=4","gravatar_id":"","url":"https://api.github.com/users/VesnaT","html_url":"https://github.com/VesnaT","followers_url":"https://api.github.com/users/VesnaT/followers","following_url":"https://api.github.com/users/VesnaT/following{/other_user}","gists_url":"https://api.github.com/users/VesnaT/gists{/gist_id}","starred_url":"https://api.github.com/users/VesnaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesnaT/subscriptions","organizations_url":"https://api.github.com/users/VesnaT/orgs","repos_url":"https://api.github.com/users/VesnaT/repos","events_url":"https://api.github.com/users/VesnaT/events{/privacy}","received_events_url":"https://api.github.com/users/VesnaT/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VesnaT/orange3-network","description":"🍊 🕸 Network analysis add-on for Orange data mining suite.","fork":true,"url":"https://api.github.com/repos/VesnaT/orange3-network","forks_url":"https://api.github.com/repos/VesnaT/orange3-network/forks","keys_url":"https://api.github.com/repos/VesnaT/orange3-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VesnaT/orange3-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VesnaT/orange3-network/teams","hooks_url":"https://api.github.com/repos/VesnaT/orange3-network/hooks","issue_events_url":"https://api.github.com/repos/VesnaT/orange3-network/issues/events{/number}","events_url":"https://api.github.com/repos/VesnaT/orange3-network/events","assignees_url":"https://api.github.com/repos/VesnaT/orange3-network/assignees{/user}","branches_url":"https://api.github.com/repos/VesnaT/orange3-network/branches{/branch}","tags_url":"https://api.github.com/repos/VesnaT/orange3-network/tags","blobs_url":"https://api.github.com/repos/VesnaT/orange3-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VesnaT/orange3-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VesnaT/orange3-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/VesnaT/orange3-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VesnaT/orange3-network/statuses/{sha}","languages_url":"https://api.github.com/repos/VesnaT/orange3-network/languages","stargazers_url":"https://api.github.com/repos/VesnaT/orange3-network/stargazers","contributors_url":"https://api.github.com/repos/VesnaT/orange3-network/contributors","subscribers_url":"https://api.github.com/repos/VesnaT/orange3-network/subscribers","subscription_url":"https://api.github.com/repos/VesnaT/orange3-network/subscription","commits_url":"https://api.github.com/repos/VesnaT/orange3-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/VesnaT/orange3-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/VesnaT/orange3-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/VesnaT/orange3-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/VesnaT/orange3-network/contents/{+path}","compare_url":"https://api.github.com/repos/VesnaT/orange3-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VesnaT/orange3-network/merges","archive_url":"https://api.github.com/repos/VesnaT/orange3-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VesnaT/orange3-network/downloads","issues_url":"https://api.github.com/repos/VesnaT/orange3-network/issues{/number}","pulls_url":"https://api.github.com/repos/VesnaT/orange3-network/pulls{/number}","milestones_url":"https://api.github.com/repos/VesnaT/orange3-network/milestones{/number}","notifications_url":"https://api.github.com/repos/VesnaT/orange3-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VesnaT/orange3-network/labels{/name}","releases_url":"https://api.github.com/repos/VesnaT/orange3-network/releases{/id}","deployments_url":"https://api.github.com/repos/VesnaT/orange3-network/deployments","created_at":"2018-11-27T12:09:01Z","updated_at":"2018-11-27T12:09:04Z","pushed_at":"2018-11-27T12:35:54Z","git_url":"git://github.com/VesnaT/orange3-network.git","ssh_url":"git@github.com:VesnaT/orange3-network.git","clone_url":"https://github.com/VesnaT/orange3-network.git","svn_url":"https://github.com/VesnaT/orange3-network","homepage":"","size":3194,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"54276c98970f267211c866b2773ddcb53b404328","user":{"login":"biolab","id":555189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTE4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/555189?v=4","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":40713934,"node_id":"MDEwOlJlcG9zaXRvcnk0MDcxMzkzNA==","name":"orange3-network","full_name":"biolab/orange3-network","private":false,"owner":{"login":"biolab","id":555189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NTE4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/555189?v=4","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/biolab/orange3-network","description":"🍊 🕸 Network analysis add-on for Orange data mining suite.","fork":false,"url":"https://api.github.com/repos/biolab/orange3-network","forks_url":"https://api.github.com/repos/biolab/orange3-network/forks","keys_url":"https://api.github.com/repos/biolab/orange3-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3-network/teams","hooks_url":"https://api.github.com/repos/biolab/orange3-network/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3-network/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3-network/events","assignees_url":"https://api.github.com/repos/biolab/orange3-network/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3-network/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3-network/tags","blobs_url":"https://api.github.com/repos/biolab/orange3-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3-network/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3-network/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3-network/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3-network/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3-network/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3-network/subscription","commits_url":"https://api.github.com/repos/biolab/orange3-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3-network/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3-network/merges","archive_url":"https://api.github.com/repos/biolab/orange3-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3-network/downloads","issues_url":"https://api.github.com/repos/biolab/orange3-network/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3-network/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3-network/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3-network/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3-network/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3-network/deployments","created_at":"2015-08-14T12:29:15Z","updated_at":"2018-11-23T21:10:22Z","pushed_at":"2018-11-27T12:35:55Z","git_url":"git://github.com/biolab/orange3-network.git","ssh_url":"git@github.com:biolab/orange3-network.git","clone_url":"https://github.com/biolab/orange3-network.git","svn_url":"https://github.com/biolab/orange3-network","homepage":"","size":3165,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/95"},"html":{"href":"https://github.com/biolab/orange3-network/pull/95"},"issue":{"href":"https://api.github.com/repos/biolab/orange3-network/issues/95"},"comments":{"href":"https://api.github.com/repos/biolab/orange3-network/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3-network/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3-network/statuses/dc6df0a03f60b509955feed60b976175f2139215"}},"author_association":"NONE"}} | {
"id": 40713934,
"name": "biolab/orange3-network",
"url": "https://api.github.com/repos/biolab/orange3-network"
} | {
"id": 2387315,
"login": "janezd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2387315?",
"url": "https://api.github.com/users/janezd"
} | {
"id": 555189,
"login": "biolab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/555189?",
"url": "https://api.github.com/orgs/biolab"
} | 2018-11-29T22:35:33 | 8672650551 | {"actor":{"display_login":"janezd"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snowdrop/generator/pulls/comments/214273597","pull_request_review_id":151293698,"id":214273597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDI3MzU5Nw==","diff_hunk":"@@ -35,7 +35,32 @@ jobs:\n - run:\n name: Perform build\n command: |\n- go build -o server *.go\n+ go build -o generator *.go\n+\n+ # This job needs to be in machine because it has COPY inside the Dockerfile\n+ # which cannot be handled in the docker type jobs\n+ createImage:\n+ machine: true\n+\n+ steps:\n+ - checkout\n+\n+ - run:\n+ name: Build Docker image\n+ command: |\n+ tagRE='release-(.*)'\n+ if [[ \"${CIRCLE_TAG}\" =~ ${tagRE} ]]; then\n+ VERSION=${BASH_REMATCH[1]}\n+\n+ docker build -t spring-boot-generator:${VERSION} -f docker/Dockerfile_generator .","path":".circleci/config.yml","position":22,"original_position":22,"commit_id":"84aa5fcb15356ae178d5e94f07e50970b1096caa","original_commit_id":"84aa5fcb15356ae178d5e94f07e50970b1096caa","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"body":"@cmoulliard Good point. Actually in the previous iterations of my implementation, I didn't use it. But I still did have to recompile the project (in addition to what release does), because the generic amd64 binary produced by the release process does not work on the busybox image.\r\n\r\nSo I believe that this is the simplest and most clear solution at the moment","created_at":"2018-08-31T08:04:22Z","updated_at":"2018-08-31T08:04:22Z","html_url":"https://github.com/snowdrop/generator/pull/7#discussion_r214273597","pull_request_url":"https://api.github.com/repos/snowdrop/generator/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/comments/214273597"},"html":{"href":"https://github.com/snowdrop/generator/pull/7#discussion_r214273597"},"pull_request":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/7"}},"in_reply_to_id":214133623},"pull_request":{"url":"https://api.github.com/repos/snowdrop/generator/pulls/7","id":212161791,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTYxNzkx","html_url":"https://github.com/snowdrop/generator/pull/7","diff_url":"https://github.com/snowdrop/generator/pull/7.diff","patch_url":"https://github.com/snowdrop/generator/pull/7.patch","issue_url":"https://api.github.com/repos/snowdrop/generator/issues/7","number":7,"state":"open","locked":false,"title":"Create and push a docker image when a release is made","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-30T17:55:58Z","updated_at":"2018-08-31T08:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d69f5048ae1ee4c03587deabd732dd47952f7fe4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snowdrop/generator/pulls/7/commits","review_comments_url":"https://api.github.com/repos/snowdrop/generator/pulls/7/comments","review_comment_url":"https://api.github.com/repos/snowdrop/generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snowdrop/generator/issues/7/comments","statuses_url":"https://api.github.com/repos/snowdrop/generator/statuses/84aa5fcb15356ae178d5e94f07e50970b1096caa","head":{"label":"snowdrop:docker2","ref":"docker2","sha":"84aa5fcb15356ae178d5e94f07e50970b1096caa","user":{"login":"snowdrop","id":558276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/558276?v=4","gravatar_id":"","url":"https://api.github.com/users/snowdrop","html_url":"https://github.com/snowdrop","followers_url":"https://api.github.com/users/snowdrop/followers","following_url":"https://api.github.com/users/snowdrop/following{/other_user}","gists_url":"https://api.github.com/users/snowdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/snowdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowdrop/subscriptions","organizations_url":"https://api.github.com/users/snowdrop/orgs","repos_url":"https://api.github.com/users/snowdrop/repos","events_url":"https://api.github.com/users/snowdrop/events{/privacy}","received_events_url":"https://api.github.com/users/snowdrop/received_events","type":"Organization","site_admin":false},"repo":{"id":146627410,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2Mjc0MTA=","name":"generator","full_name":"snowdrop/generator","owner":{"login":"snowdrop","id":558276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/558276?v=4","gravatar_id":"","url":"https://api.github.com/users/snowdrop","html_url":"https://github.com/snowdrop","followers_url":"https://api.github.com/users/snowdrop/followers","following_url":"https://api.github.com/users/snowdrop/following{/other_user}","gists_url":"https://api.github.com/users/snowdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/snowdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowdrop/subscriptions","organizations_url":"https://api.github.com/users/snowdrop/orgs","repos_url":"https://api.github.com/users/snowdrop/repos","events_url":"https://api.github.com/users/snowdrop/events{/privacy}","received_events_url":"https://api.github.com/users/snowdrop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snowdrop/generator","description":"Simple HTTP Server exposing a Service to handle code scaffolding for Spring Boot project","fork":false,"url":"https://api.github.com/repos/snowdrop/generator","forks_url":"https://api.github.com/repos/snowdrop/generator/forks","keys_url":"https://api.github.com/repos/snowdrop/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowdrop/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowdrop/generator/teams","hooks_url":"https://api.github.com/repos/snowdrop/generator/hooks","issue_events_url":"https://api.github.com/repos/snowdrop/generator/issues/events{/number}","events_url":"https://api.github.com/repos/snowdrop/generator/events","assignees_url":"https://api.github.com/repos/snowdrop/generator/assignees{/user}","branches_url":"https://api.github.com/repos/snowdrop/generator/branches{/branch}","tags_url":"https://api.github.com/repos/snowdrop/generator/tags","blobs_url":"https://api.github.com/repos/snowdrop/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowdrop/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowdrop/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowdrop/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowdrop/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/snowdrop/generator/languages","stargazers_url":"https://api.github.com/repos/snowdrop/generator/stargazers","contributors_url":"https://api.github.com/repos/snowdrop/generator/contributors","subscribers_url":"https://api.github.com/repos/snowdrop/generator/subscribers","subscription_url":"https://api.github.com/repos/snowdrop/generator/subscription","commits_url":"https://api.github.com/repos/snowdrop/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowdrop/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowdrop/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowdrop/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowdrop/generator/contents/{+path}","compare_url":"https://api.github.com/repos/snowdrop/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowdrop/generator/merges","archive_url":"https://api.github.com/repos/snowdrop/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowdrop/generator/downloads","issues_url":"https://api.github.com/repos/snowdrop/generator/issues{/number}","pulls_url":"https://api.github.com/repos/snowdrop/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/snowdrop/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/snowdrop/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowdrop/generator/labels{/name}","releases_url":"https://api.github.com/repos/snowdrop/generator/releases{/id}","deployments_url":"https://api.github.com/repos/snowdrop/generator/deployments","created_at":"2018-08-29T16:22:53Z","updated_at":"2018-08-30T17:26:22Z","pushed_at":"2018-08-30T17:55:58Z","git_url":"git://github.com/snowdrop/generator.git","ssh_url":"git@github.com:snowdrop/generator.git","clone_url":"https://github.com/snowdrop/generator.git","svn_url":"https://github.com/snowdrop/generator","homepage":"","size":2968,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"snowdrop:master","ref":"master","sha":"b1fc4efb95d43a466c39d0385973034aba636e9f","user":{"login":"snowdrop","id":558276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/558276?v=4","gravatar_id":"","url":"https://api.github.com/users/snowdrop","html_url":"https://github.com/snowdrop","followers_url":"https://api.github.com/users/snowdrop/followers","following_url":"https://api.github.com/users/snowdrop/following{/other_user}","gists_url":"https://api.github.com/users/snowdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/snowdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowdrop/subscriptions","organizations_url":"https://api.github.com/users/snowdrop/orgs","repos_url":"https://api.github.com/users/snowdrop/repos","events_url":"https://api.github.com/users/snowdrop/events{/privacy}","received_events_url":"https://api.github.com/users/snowdrop/received_events","type":"Organization","site_admin":false},"repo":{"id":146627410,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2Mjc0MTA=","name":"generator","full_name":"snowdrop/generator","owner":{"login":"snowdrop","id":558276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/558276?v=4","gravatar_id":"","url":"https://api.github.com/users/snowdrop","html_url":"https://github.com/snowdrop","followers_url":"https://api.github.com/users/snowdrop/followers","following_url":"https://api.github.com/users/snowdrop/following{/other_user}","gists_url":"https://api.github.com/users/snowdrop/gists{/gist_id}","starred_url":"https://api.github.com/users/snowdrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowdrop/subscriptions","organizations_url":"https://api.github.com/users/snowdrop/orgs","repos_url":"https://api.github.com/users/snowdrop/repos","events_url":"https://api.github.com/users/snowdrop/events{/privacy}","received_events_url":"https://api.github.com/users/snowdrop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snowdrop/generator","description":"Simple HTTP Server exposing a Service to handle code scaffolding for Spring Boot project","fork":false,"url":"https://api.github.com/repos/snowdrop/generator","forks_url":"https://api.github.com/repos/snowdrop/generator/forks","keys_url":"https://api.github.com/repos/snowdrop/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowdrop/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowdrop/generator/teams","hooks_url":"https://api.github.com/repos/snowdrop/generator/hooks","issue_events_url":"https://api.github.com/repos/snowdrop/generator/issues/events{/number}","events_url":"https://api.github.com/repos/snowdrop/generator/events","assignees_url":"https://api.github.com/repos/snowdrop/generator/assignees{/user}","branches_url":"https://api.github.com/repos/snowdrop/generator/branches{/branch}","tags_url":"https://api.github.com/repos/snowdrop/generator/tags","blobs_url":"https://api.github.com/repos/snowdrop/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowdrop/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowdrop/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowdrop/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowdrop/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/snowdrop/generator/languages","stargazers_url":"https://api.github.com/repos/snowdrop/generator/stargazers","contributors_url":"https://api.github.com/repos/snowdrop/generator/contributors","subscribers_url":"https://api.github.com/repos/snowdrop/generator/subscribers","subscription_url":"https://api.github.com/repos/snowdrop/generator/subscription","commits_url":"https://api.github.com/repos/snowdrop/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowdrop/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowdrop/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowdrop/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowdrop/generator/contents/{+path}","compare_url":"https://api.github.com/repos/snowdrop/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowdrop/generator/merges","archive_url":"https://api.github.com/repos/snowdrop/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowdrop/generator/downloads","issues_url":"https://api.github.com/repos/snowdrop/generator/issues{/number}","pulls_url":"https://api.github.com/repos/snowdrop/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/snowdrop/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/snowdrop/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowdrop/generator/labels{/name}","releases_url":"https://api.github.com/repos/snowdrop/generator/releases{/id}","deployments_url":"https://api.github.com/repos/snowdrop/generator/deployments","created_at":"2018-08-29T16:22:53Z","updated_at":"2018-08-30T17:26:22Z","pushed_at":"2018-08-30T17:55:58Z","git_url":"git://github.com/snowdrop/generator.git","ssh_url":"git@github.com:snowdrop/generator.git","clone_url":"https://github.com/snowdrop/generator.git","svn_url":"https://github.com/snowdrop/generator","homepage":"","size":2968,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/7"},"html":{"href":"https://github.com/snowdrop/generator/pull/7"},"issue":{"href":"https://api.github.com/repos/snowdrop/generator/issues/7"},"comments":{"href":"https://api.github.com/repos/snowdrop/generator/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snowdrop/generator/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/snowdrop/generator/statuses/84aa5fcb15356ae178d5e94f07e50970b1096caa"}},"author_association":"MEMBER"}} | {
"id": 146627410,
"name": "snowdrop/generator",
"url": "https://api.github.com/repos/snowdrop/generator"
} | {
"id": 4374975,
"login": "geoand",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4374975?",
"url": "https://api.github.com/users/geoand"
} | {
"id": 558276,
"login": "snowdrop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/558276?",
"url": "https://api.github.com/orgs/snowdrop"
} | 2018-08-31T08:04:22 | 8195914305 | {"actor":{"display_login":"geoand"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/allegro/hermes/pulls/comments/211237891","pull_request_review_id":147614277,"id":211237891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTIzNzg5MQ==","diff_hunk":"@@ -110,7 +110,7 @@ public KafkaSingleThreadedMessageReceiver(KafkaConsumer<byte[], byte[]> consumer\n } catch (InterruptException ex ) {\n // Despite that Thread.currentThread().interrupt() is called in InterruptException's constructor\n // Thread.currentThread().isInterrupted() somehow returns false so we reset it.\n- logger.info(\"Kafka consumer thread interrupted\", ex);\n+// logger.info(\"Kafka consumer thread interrupted\", ex);","path":"hermes-consumers/src/main/java/pl/allegro/tech/hermes/consumers/consumer/receiver/kafka/KafkaSingleThreadedMessageReceiver.java","position":5,"original_position":5,"commit_id":"60b0b642e01449ffc9ff135d40fe4a1f1f98f066","original_commit_id":"60b0b642e01449ffc9ff135d40fe4a1f1f98f066","user":{"login":"druminski","id":4473056,"node_id":"MDQ6VXNlcjQ0NzMwNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4473056?v=4","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"body":"Why you have commented this log?","created_at":"2018-08-20T12:07:35Z","updated_at":"2018-08-20T12:58:50Z","html_url":"https://github.com/allegro/hermes/pull/893#discussion_r211237891","pull_request_url":"https://api.github.com/repos/allegro/hermes/pulls/893","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments/211237891"},"html":{"href":"https://github.com/allegro/hermes/pull/893#discussion_r211237891"},"pull_request":{"href":"https://api.github.com/repos/allegro/hermes/pulls/893"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/hermes/pulls/893","id":207316757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzE2NzU3","html_url":"https://github.com/allegro/hermes/pull/893","diff_url":"https://github.com/allegro/hermes/pull/893.diff","patch_url":"https://github.com/allegro/hermes/pull/893.patch","issue_url":"https://api.github.com/repos/allegro/hermes/issues/893","number":893,"state":"open","locked":false,"title":"Migrate from ChronicleMap v2 to v3","user":{"login":"cristaloleg","id":366002,"node_id":"MDQ6VXNlcjM2NjAwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/366002?v=4","gravatar_id":"","url":"https://api.github.com/users/cristaloleg","html_url":"https://github.com/cristaloleg","followers_url":"https://api.github.com/users/cristaloleg/followers","following_url":"https://api.github.com/users/cristaloleg/following{/other_user}","gists_url":"https://api.github.com/users/cristaloleg/gists{/gist_id}","starred_url":"https://api.github.com/users/cristaloleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristaloleg/subscriptions","organizations_url":"https://api.github.com/users/cristaloleg/orgs","repos_url":"https://api.github.com/users/cristaloleg/repos","events_url":"https://api.github.com/users/cristaloleg/events{/privacy}","received_events_url":"https://api.github.com/users/cristaloleg/received_events","type":"User","site_admin":false},"body":"Fixes #659 \r\nUpdates #711 \r\nRelated #660 ","created_at":"2018-08-09T13:29:22Z","updated_at":"2018-08-20T12:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d37b5a07aca6d430913fe04d9fda9a1b3ce14a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allegro/hermes/pulls/893/commits","review_comments_url":"https://api.github.com/repos/allegro/hermes/pulls/893/comments","review_comment_url":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/hermes/issues/893/comments","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/60b0b642e01449ffc9ff135d40fe4a1f1f98f066","head":{"label":"cristaloleg:feature/migrate-to-chroniclemap-v3","ref":"feature/migrate-to-chroniclemap-v3","sha":"60b0b642e01449ffc9ff135d40fe4a1f1f98f066","user":{"login":"cristaloleg","id":366002,"node_id":"MDQ6VXNlcjM2NjAwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/366002?v=4","gravatar_id":"","url":"https://api.github.com/users/cristaloleg","html_url":"https://github.com/cristaloleg","followers_url":"https://api.github.com/users/cristaloleg/followers","following_url":"https://api.github.com/users/cristaloleg/following{/other_user}","gists_url":"https://api.github.com/users/cristaloleg/gists{/gist_id}","starred_url":"https://api.github.com/users/cristaloleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristaloleg/subscriptions","organizations_url":"https://api.github.com/users/cristaloleg/orgs","repos_url":"https://api.github.com/users/cristaloleg/repos","events_url":"https://api.github.com/users/cristaloleg/events{/privacy}","received_events_url":"https://api.github.com/users/cristaloleg/received_events","type":"User","site_admin":false},"repo":{"id":135153914,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNTM5MTQ=","name":"hermes","full_name":"cristaloleg/hermes","owner":{"login":"cristaloleg","id":366002,"node_id":"MDQ6VXNlcjM2NjAwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/366002?v=4","gravatar_id":"","url":"https://api.github.com/users/cristaloleg","html_url":"https://github.com/cristaloleg","followers_url":"https://api.github.com/users/cristaloleg/followers","following_url":"https://api.github.com/users/cristaloleg/following{/other_user}","gists_url":"https://api.github.com/users/cristaloleg/gists{/gist_id}","starred_url":"https://api.github.com/users/cristaloleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristaloleg/subscriptions","organizations_url":"https://api.github.com/users/cristaloleg/orgs","repos_url":"https://api.github.com/users/cristaloleg/repos","events_url":"https://api.github.com/users/cristaloleg/events{/privacy}","received_events_url":"https://api.github.com/users/cristaloleg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristaloleg/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":true,"url":"https://api.github.com/repos/cristaloleg/hermes","forks_url":"https://api.github.com/repos/cristaloleg/hermes/forks","keys_url":"https://api.github.com/repos/cristaloleg/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristaloleg/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristaloleg/hermes/teams","hooks_url":"https://api.github.com/repos/cristaloleg/hermes/hooks","issue_events_url":"https://api.github.com/repos/cristaloleg/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/cristaloleg/hermes/events","assignees_url":"https://api.github.com/repos/cristaloleg/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/cristaloleg/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/cristaloleg/hermes/tags","blobs_url":"https://api.github.com/repos/cristaloleg/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristaloleg/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristaloleg/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristaloleg/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristaloleg/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/cristaloleg/hermes/languages","stargazers_url":"https://api.github.com/repos/cristaloleg/hermes/stargazers","contributors_url":"https://api.github.com/repos/cristaloleg/hermes/contributors","subscribers_url":"https://api.github.com/repos/cristaloleg/hermes/subscribers","subscription_url":"https://api.github.com/repos/cristaloleg/hermes/subscription","commits_url":"https://api.github.com/repos/cristaloleg/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristaloleg/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristaloleg/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristaloleg/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristaloleg/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/cristaloleg/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristaloleg/hermes/merges","archive_url":"https://api.github.com/repos/cristaloleg/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristaloleg/hermes/downloads","issues_url":"https://api.github.com/repos/cristaloleg/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/cristaloleg/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/cristaloleg/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/cristaloleg/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristaloleg/hermes/labels{/name}","releases_url":"https://api.github.com/repos/cristaloleg/hermes/releases{/id}","deployments_url":"https://api.github.com/repos/cristaloleg/hermes/deployments","created_at":"2018-05-28T11:49:08Z","updated_at":"2018-05-28T11:49:12Z","pushed_at":"2018-08-20T09:43:57Z","git_url":"git://github.com/cristaloleg/hermes.git","ssh_url":"git@github.com:cristaloleg/hermes.git","clone_url":"https://github.com/cristaloleg/hermes.git","svn_url":"https://github.com/cristaloleg/hermes","homepage":"http://hermes.allegro.tech","size":6084,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allegro:master","ref":"master","sha":"5c286c4e6cb486b2e80691f006cb4fbe6ac56d3f","user":{"login":"allegro","id":562236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjIzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/562236?v=4","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"node_id":"MDEwOlJlcG9zaXRvcnkzNTY2MjA0Mw==","name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjIzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/562236?v=4","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","deployments_url":"https://api.github.com/repos/allegro/hermes/deployments","created_at":"2015-05-15T08:11:16Z","updated_at":"2018-08-20T07:40:24Z","pushed_at":"2018-08-20T09:43:58Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":6219,"stargazers_count":369,"watchers_count":369,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":75,"license":null,"forks":84,"open_issues":75,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/893"},"html":{"href":"https://github.com/allegro/hermes/pull/893"},"issue":{"href":"https://api.github.com/repos/allegro/hermes/issues/893"},"comments":{"href":"https://api.github.com/repos/allegro/hermes/issues/893/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/hermes/pulls/893/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/hermes/pulls/893/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/hermes/statuses/60b0b642e01449ffc9ff135d40fe4a1f1f98f066"}},"author_association":"MEMBER"}} | {
"id": 35662043,
"name": "allegro/hermes",
"url": "https://api.github.com/repos/allegro/hermes"
} | {
"id": 4473056,
"login": "druminski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4473056?",
"url": "https://api.github.com/users/druminski"
} | {
"id": 562236,
"login": "allegro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/562236?",
"url": "https://api.github.com/orgs/allegro"
} | 2018-08-20T12:07:35 | 8137782934 | {"actor":{"display_login":"druminski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/177142909","pull_request_review_id":106964983,"id":177142909,"diff_hunk":"@@ -4465,6 +4514,309 @@ pure @safe unittest\n assertThrown!Exception(same.popFront);\n }\n \n+/+\n+Non-public. Like $(LREF Zip) with `StoppingPolicy.shortest`\n+except it properly implements `back` and `popBack` in the\n+case of uneven ranges or disables those operations when\n+it is not possible to guarantee they are correct.\n++/\n+package template ZipShortest(Ranges...)\n+if (Ranges.length && __traits(compiles,\n+ {\n+ static assert(allSatisfy!(isInputRange, Ranges));\n+ }))\n+{\n+ alias ZipShortest = .ZipShortest!(\n+ Ranges.length == 1 || allSatisfy!(isInfinite, Ranges)\n+ ? Yes.allKnownSameLength\n+ : No.allKnownSameLength,\n+ Ranges);\n+}\n+/+ non-public, ditto +/\n+package struct ZipShortest(Flag!\"allKnownSameLength\" allKnownSameLength, Ranges...)\n+if (Ranges.length && allSatisfy!(isInputRange, Ranges))\n+{\n+ import std.format : format; //for generic mixins\n+ import std.typecons : Tuple;\n+\n+ deprecated(\"Use of an undocumented alias R.\")\n+ alias R = Ranges; // Unused here but defined in case library users rely on it.\n+ private Ranges ranges;\n+ alias ElementType = Tuple!(staticMap!(.ElementType, Ranges));\n+\n+ /+\n+ Builds an object. Usually this is invoked indirectly by using the\n+ $(LREF zip) function.\n+ +/\n+ this(Ranges rs)\n+ {\n+ ranges[] = rs[];\n+ }\n+\n+ /+\n+ Returns `true` if the range is at end.\n+ +/\n+ static if (allKnownSameLength ? anySatisfy!(isInfinite, Ranges)\n+ : allSatisfy!(isInfinite, Ranges))\n+ {\n+ enum bool empty = false;\n+ }\n+ else\n+ {\n+ @property bool empty()\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ return ranges[0].empty;\n+ }\n+ else\n+ {\n+ static foreach (i; 0 .. Ranges.length)\n+ {\n+ if (ranges[i].empty)\n+ return true;\n+ }\n+ return false;\n+ }\n+ }\n+ }\n+\n+ /+\n+ Forward range primitive. Only present if each constituent range is a\n+ forward range.\n+ +/\n+ static if (allSatisfy!(isForwardRange, Ranges))\n+ @property typeof(this) save()\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s].save%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+\n+ /+\n+ Returns the current iterated element.\n+ +/\n+ @property ElementType front()\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s].front%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+\n+ /+\n+ Sets the front of all iterated ranges. Only present if each constituent\n+ range has assignable elements.\n+ +/\n+ static if (allSatisfy!(hasAssignableElements, Ranges))\n+ @property void front()(ElementType v)\n+ {\n+ static foreach (i; 0 .. Ranges.length)\n+ ranges[i].front = v[i];\n+ }\n+\n+ /+\n+ Moves out the front. Present if each constituent range has mobile elements.\n+ +/\n+ static if (allSatisfy!(hasMobileElements, Ranges))\n+ ElementType moveFront()()\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s].moveFront()%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+\n+ private enum bool isBackWellDefined = allSatisfy!(isBidirectionalRange, Ranges)\n+ && (allKnownSameLength\n+ || allSatisfy!(isRandomAccessRange, Ranges)\n+ // Could also add the case where there is one non-infinite bidirectional\n+ // range that defines `length` and all others are infinite random access\n+ // ranges. Adding this would require appropriate branches in\n+ // back/moveBack/popBack.\n+ );\n+\n+ /+\n+ Returns the rightmost element. Present if all constituent ranges are\n+ bidirectional and either there is a compile-time guarantee that all\n+ ranges have the same length (in `allKnownSameLength`) or all ranges\n+ provide random access to elements.\n+ +/\n+ static if (isBackWellDefined)\n+ @property ElementType back()\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s].back()%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+ else\n+ {\n+ const backIndex = length - 1;\n+ return mixin (`typeof(return)(%(ranges[%s][backIndex]%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+ }\n+\n+ /+\n+ Moves out the back. Present if `back` is defined and\n+ each constituent range has mobile elements.\n+ +/\n+ static if (isBackWellDefined && allSatisfy!(hasMobileElements, Ranges))\n+ ElementType moveBack()()\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s].moveBack()%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+ else\n+ {\n+ const backIndex = length - 1;\n+ return mixin (`typeof(return)(%(ranges[%s].moveAt(backIndex)%|, %))`.format(iota(0, Ranges.length)));\n+ }\n+ }\n+\n+ /+\n+ Sets the rightmost element. Only present if `back` is defined and\n+ each constituent range has assignable elements.\n+ +/\n+ static if (isBackWellDefined && allSatisfy!(hasAssignableElements, Ranges))\n+ @property void back()(ElementType v)\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ static foreach (i; 0 .. Ranges.length)\n+ ranges[i].back = v[i];\n+ }\n+ else\n+ {\n+ const backIndex = length - 1;\n+ static foreach (i; 0 .. Ranges.length)\n+ ranges[i][backIndex] = v[i];\n+ }\n+ }\n+\n+ /+\n+ Calls `popFront` on each constituent range.\n+ +/\n+ void popFront()\n+ {\n+ static foreach (i; 0 .. Ranges.length)\n+ ranges[i].popFront();\n+ }\n+\n+ /+\n+ Pops the rightmost element. Present if `back` is defined.\n+ +/\n+ static if (isBackWellDefined)\n+ void popBack()\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ static foreach (i; 0 .. Ranges.length)\n+ ranges[i].popBack;\n+ }\n+ else\n+ {\n+ const len = length;\n+ static foreach (i; 0 .. Ranges.length)\n+ static if (!isInfinite!(Ranges[i]))\n+ if (ranges[i].length == len)\n+ ranges[i].popBack();\n+ }\n+ }\n+\n+ /+\n+ Returns the length of this range. Defined if at least one\n+ constituent range defines `length` and the other ranges all also\n+ define `length` or are infinite, or if at least one constituent\n+ range defines `length` and there is a compile-time guarantee that\n+ all ranges have the same length (in `allKnownSameLength`).\n+ +/\n+ static if (allKnownSameLength\n+ ? anySatisfy!(hasLength, Ranges)\n+ : (anySatisfy!(hasLength, Ranges)\n+ && allSatisfy!(templateOr!(isInfinite, hasLength), Ranges)))\n+ {\n+ @property size_t length()\n+ {\n+ static if (allKnownSameLength)\n+ {\n+ static foreach (i, Range; Ranges)\n+ {\n+ static if (hasLength!Range && !anySatisfy!(hasLength, Ranges[0 .. i]))\n+ return ranges[i].length;\n+ }\n+ }\n+ else\n+ {\n+ static foreach (i, Range; Ranges)\n+ static if (hasLength!Range)\n+ {\n+ static if (!anySatisfy!(hasLength, Ranges[0 .. i]))\n+ size_t minlen = ranges[i].length;\n+ else\n+ {{\n+ const x = ranges[i].length;\n+ if (x < minlen) minlen = x;\n+ }}\n+ }\n+ return minlen;\n+ }\n+ }\n+\n+ alias opDollar = length;\n+ }\n+\n+ /+\n+ Returns a slice of the range. Defined if all constituent ranges\n+ support slicing.\n+ +/\n+ static if (allSatisfy!(hasSlicing, Ranges))\n+ {\n+ // Note: we will know that all elements of the resultant range\n+ // will have the same length but we cannot change `allKnownSameLength`\n+ // because the `hasSlicing` predicate tests that the result returned\n+ // by `opSlice` has the same type as the receiver.\n+ auto opSlice()(size_t from, size_t to)\n+ {\n+ //(ranges[0][from .. to], ranges[1][from .. to], ...)\n+ enum sliceArgs = `(%(ranges[%s][from .. to]%|, %))`.format(iota(0, Ranges.length));\n+ static if (__traits(compiles, mixin(`typeof(this)`~sliceArgs)))\n+ return mixin(`typeof(this)`~sliceArgs);\n+ else\n+ // The type is different anyway so we might as well\n+ // explicitly set allKnownSameLength.\n+ return mixin(`ZipShortest!(Yes.allKnownSameLength, staticMap!(Take, Ranges))`\n+ ~sliceArgs);\n+ }\n+ }\n+\n+ /+\n+ Returns the `n`th element in the composite range. Defined if all\n+ constituent ranges offer random access.\n+ +/\n+ static if (allSatisfy!(isRandomAccessRange, Ranges))\n+ ElementType opIndex()(size_t n)\n+ {\n+ return mixin (`typeof(return)(%(ranges[%s][n]%|, %))`.format(iota(0, Ranges.length)));","path":"std/range/package.d","position":null,"original_position":371,"commit_id":"f998c1fac9336ce4621eaba5da9ad8ae1df8235d","original_commit_id":"cd27a8405ff4d0fc09a4da42f0978e77369e55e5","user":{"login":"n8sh","id":21227491,"avatar_url":"https://avatars2.githubusercontent.com/u/21227491?v=4","gravatar_id":"","url":"https://api.github.com/users/n8sh","html_url":"https://github.com/n8sh","followers_url":"https://api.github.com/users/n8sh/followers","following_url":"https://api.github.com/users/n8sh/following{/other_user}","gists_url":"https://api.github.com/users/n8sh/gists{/gist_id}","starred_url":"https://api.github.com/users/n8sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8sh/subscriptions","organizations_url":"https://api.github.com/users/n8sh/orgs","repos_url":"https://api.github.com/users/n8sh/repos","events_url":"https://api.github.com/users/n8sh/events{/privacy}","received_events_url":"https://api.github.com/users/n8sh/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-03-26T15:53:35Z","updated_at":"2018-03-26T15:53:35Z","html_url":"https://github.com/dlang/phobos/pull/6307#discussion_r177142909","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/6307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/177142909"},"html":{"href":"https://github.com/dlang/phobos/pull/6307#discussion_r177142909"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6307"}},"in_reply_to_id":176962620},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/6307","id":176204648,"html_url":"https://github.com/dlang/phobos/pull/6307","diff_url":"https://github.com/dlang/phobos/pull/6307.diff","patch_url":"https://github.com/dlang/phobos/pull/6307.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/6307","number":6307,"state":"open","locked":false,"title":"Fix Issue 18638 - The main override of std.range.zip could infer @nogc and nothrow","user":{"login":"n8sh","id":21227491,"avatar_url":"https://avatars2.githubusercontent.com/u/21227491?v=4","gravatar_id":"","url":"https://api.github.com/users/n8sh","html_url":"https://github.com/n8sh","followers_url":"https://api.github.com/users/n8sh/followers","following_url":"https://api.github.com/users/n8sh/following{/other_user}","gists_url":"https://api.github.com/users/n8sh/gists{/gist_id}","starred_url":"https://api.github.com/users/n8sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8sh/subscriptions","organizations_url":"https://api.github.com/users/n8sh/orgs","repos_url":"https://api.github.com/users/n8sh/repos","events_url":"https://api.github.com/users/n8sh/events{/privacy}","received_events_url":"https://api.github.com/users/n8sh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-20T14:16:35Z","updated_at":"2018-03-26T15:53:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"835ba2d004ffffe6239acaa90c936ac56f090cae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andralex","id":566679,"avatar_url":"https://avatars1.githubusercontent.com/u/566679?v=4","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},{"login":"ZombineDev","id":3475150,"avatar_url":"https://avatars2.githubusercontent.com/u/3475150?v=4","gravatar_id":"","url":"https://api.github.com/users/ZombineDev","html_url":"https://github.com/ZombineDev","followers_url":"https://api.github.com/users/ZombineDev/followers","following_url":"https://api.github.com/users/ZombineDev/following{/other_user}","gists_url":"https://api.github.com/users/ZombineDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ZombineDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZombineDev/subscriptions","organizations_url":"https://api.github.com/users/ZombineDev/orgs","repos_url":"https://api.github.com/users/ZombineDev/repos","events_url":"https://api.github.com/users/ZombineDev/events{/privacy}","received_events_url":"https://api.github.com/users/ZombineDev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":416188433,"url":"https://api.github.com/repos/dlang/phobos/labels/Enhancement","name":"Enhancement","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/6307/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/6307/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/6307/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/f998c1fac9336ce4621eaba5da9ad8ae1df8235d","head":{"label":"n8sh:zip-shortest","ref":"zip-shortest","sha":"f998c1fac9336ce4621eaba5da9ad8ae1df8235d","user":{"login":"n8sh","id":21227491,"avatar_url":"https://avatars2.githubusercontent.com/u/21227491?v=4","gravatar_id":"","url":"https://api.github.com/users/n8sh","html_url":"https://github.com/n8sh","followers_url":"https://api.github.com/users/n8sh/followers","following_url":"https://api.github.com/users/n8sh/following{/other_user}","gists_url":"https://api.github.com/users/n8sh/gists{/gist_id}","starred_url":"https://api.github.com/users/n8sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8sh/subscriptions","organizations_url":"https://api.github.com/users/n8sh/orgs","repos_url":"https://api.github.com/users/n8sh/repos","events_url":"https://api.github.com/users/n8sh/events{/privacy}","received_events_url":"https://api.github.com/users/n8sh/received_events","type":"User","site_admin":false},"repo":{"id":104249650,"name":"phobos","full_name":"n8sh/phobos","owner":{"login":"n8sh","id":21227491,"avatar_url":"https://avatars2.githubusercontent.com/u/21227491?v=4","gravatar_id":"","url":"https://api.github.com/users/n8sh","html_url":"https://github.com/n8sh","followers_url":"https://api.github.com/users/n8sh/followers","following_url":"https://api.github.com/users/n8sh/following{/other_user}","gists_url":"https://api.github.com/users/n8sh/gists{/gist_id}","starred_url":"https://api.github.com/users/n8sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n8sh/subscriptions","organizations_url":"https://api.github.com/users/n8sh/orgs","repos_url":"https://api.github.com/users/n8sh/repos","events_url":"https://api.github.com/users/n8sh/events{/privacy}","received_events_url":"https://api.github.com/users/n8sh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n8sh/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/n8sh/phobos","forks_url":"https://api.github.com/repos/n8sh/phobos/forks","keys_url":"https://api.github.com/repos/n8sh/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n8sh/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n8sh/phobos/teams","hooks_url":"https://api.github.com/repos/n8sh/phobos/hooks","issue_events_url":"https://api.github.com/repos/n8sh/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/n8sh/phobos/events","assignees_url":"https://api.github.com/repos/n8sh/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/n8sh/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/n8sh/phobos/tags","blobs_url":"https://api.github.com/repos/n8sh/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n8sh/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n8sh/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/n8sh/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n8sh/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/n8sh/phobos/languages","stargazers_url":"https://api.github.com/repos/n8sh/phobos/stargazers","contributors_url":"https://api.github.com/repos/n8sh/phobos/contributors","subscribers_url":"https://api.github.com/repos/n8sh/phobos/subscribers","subscription_url":"https://api.github.com/repos/n8sh/phobos/subscription","commits_url":"https://api.github.com/repos/n8sh/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/n8sh/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/n8sh/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/n8sh/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/n8sh/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/n8sh/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n8sh/phobos/merges","archive_url":"https://api.github.com/repos/n8sh/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n8sh/phobos/downloads","issues_url":"https://api.github.com/repos/n8sh/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/n8sh/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/n8sh/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/n8sh/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n8sh/phobos/labels{/name}","releases_url":"https://api.github.com/repos/n8sh/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/n8sh/phobos/deployments","created_at":"2017-09-20T17:56:10Z","updated_at":"2018-03-26T15:09:36Z","pushed_at":"2018-03-26T15:52:52Z","git_url":"git://github.com/n8sh/phobos.git","ssh_url":"git@github.com:n8sh/phobos.git","clone_url":"https://github.com/n8sh/phobos.git","svn_url":"https://github.com/n8sh/phobos","homepage":"dlang.org/phobos","size":47619,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"2b9583939591a8b1c20afa61a0f81eaf3c99d924","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2018-03-26T14:07:38Z","pushed_at":"2018-03-26T15:52:54Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":47653,"stargazers_count":865,"watchers_count":865,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":595,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":595,"open_issues":122,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6307"},"html":{"href":"https://github.com/dlang/phobos/pull/6307"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/6307"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/6307/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6307/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6307/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/f998c1fac9336ce4621eaba5da9ad8ae1df8235d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1257084,
"name": "dlang/phobos",
"url": "https://api.github.com/repos/dlang/phobos"
} | {
"id": 21227491,
"login": "n8sh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21227491?",
"url": "https://api.github.com/users/n8sh"
} | {
"id": 565913,
"login": "dlang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/565913?",
"url": "https://api.github.com/orgs/dlang"
} | 2018-03-26T15:53:35 | 7436094663 | {"actor":{"display_login":"n8sh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/comments/187284320","pull_request_review_id":119031178,"id":187284320,"diff_hunk":"@@ -38,7 +38,7 @@ def load_metrics\n date_to_s = date.strftime(\"%F\")\n \n conn.execute(load_metrics_query(date_to_s))\n- conn.execute(clean_up_query)\n+ clean_up_query","path":"app/etl/ga/views_processor.rb","position":null,"original_position":5,"commit_id":"730db998f5da9b4db6aaa85efc3c70bc73a5a417","original_commit_id":"c3e3afc31ce0ef421eafc2ee3337a15f1705229c","user":{"login":"KyleMacPherson","id":13124899,"avatar_url":"https://avatars2.githubusercontent.com/u/13124899?v=4","gravatar_id":"","url":"https://api.github.com/users/KyleMacPherson","html_url":"https://github.com/KyleMacPherson","followers_url":"https://api.github.com/users/KyleMacPherson/followers","following_url":"https://api.github.com/users/KyleMacPherson/following{/other_user}","gists_url":"https://api.github.com/users/KyleMacPherson/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleMacPherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleMacPherson/subscriptions","organizations_url":"https://api.github.com/users/KyleMacPherson/orgs","repos_url":"https://api.github.com/users/KyleMacPherson/repos","events_url":"https://api.github.com/users/KyleMacPherson/events{/privacy}","received_events_url":"https://api.github.com/users/KyleMacPherson/received_events","type":"User","site_admin":false},"body":"Good idea, thanks @pmanrubia. Done!","created_at":"2018-05-10T09:37:12Z","updated_at":"2018-05-10T09:37:13Z","html_url":"https://github.com/alphagov/content-performance-manager/pull/696#discussion_r187284320","pull_request_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/comments/187284320"},"html":{"href":"https://github.com/alphagov/content-performance-manager/pull/696#discussion_r187284320"},"pull_request":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696"}},"in_reply_to_id":187274984},"pull_request":{"url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696","id":186968831,"html_url":"https://github.com/alphagov/content-performance-manager/pull/696","diff_url":"https://github.com/alphagov/content-performance-manager/pull/696.diff","patch_url":"https://github.com/alphagov/content-performance-manager/pull/696.patch","issue_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/696","number":696,"state":"open","locked":false,"title":"Delete all events after we import GA metrics","user":{"login":"KyleMacPherson","id":13124899,"avatar_url":"https://avatars2.githubusercontent.com/u/13124899?v=4","gravatar_id":"","url":"https://api.github.com/users/KyleMacPherson","html_url":"https://github.com/KyleMacPherson","followers_url":"https://api.github.com/users/KyleMacPherson/followers","following_url":"https://api.github.com/users/KyleMacPherson/following{/other_user}","gists_url":"https://api.github.com/users/KyleMacPherson/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleMacPherson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleMacPherson/subscriptions","organizations_url":"https://api.github.com/users/KyleMacPherson/orgs","repos_url":"https://api.github.com/users/KyleMacPherson/repos","events_url":"https://api.github.com/users/KyleMacPherson/events{/privacy}","received_events_url":"https://api.github.com/users/KyleMacPherson/received_events","type":"User","site_admin":false},"body":"We have some discrepancies between the data we receive from GA and the data we store in our facts_metrics table, ideally the data in facts_metrics would accurately represent the metrics we receive from GA. We know that the correct data is imported into events_gas table from GA, however we have some discrepancies between facts_metrics and GA due to facts_metrics identifying pages by their base_path and GA using the page_path.\r\n\r\nIn this PR we are deleting all rows from events_gas table after they have been transformed and loaded into the facts_metrics table. We will work on representing the GA data accurately in the facts_metrics table in a later PR.\r\n\r\nNote: We have removed the shared_examples previously used to test the TransformPath module because it was no longer possible to test it in that manner due to us deleting all GA::Events during the ETL process. We have added a unit test, testing the module in isolation, instead.","created_at":"2018-05-09T16:05:55Z","updated_at":"2018-05-10T09:37:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8bf50b0f050ac180011b04ca656d5c25afe7fd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696/commits","review_comments_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696/comments","review_comment_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/696/comments","statuses_url":"https://api.github.com/repos/alphagov/content-performance-manager/statuses/730db998f5da9b4db6aaa85efc3c70bc73a5a417","head":{"label":"alphagov:delete-all-events-after-etl","ref":"delete-all-events-after-etl","sha":"730db998f5da9b4db6aaa85efc3c70bc73a5a417","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":73927580,"name":"content-performance-manager","full_name":"alphagov/content-performance-manager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-performance-manager","description":"Data warehouse that stores content and content metrics to help content owners measure and improve content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/content-performance-manager","forks_url":"https://api.github.com/repos/alphagov/content-performance-manager/forks","keys_url":"https://api.github.com/repos/alphagov/content-performance-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-performance-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-performance-manager/teams","hooks_url":"https://api.github.com/repos/alphagov/content-performance-manager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-performance-manager/events","assignees_url":"https://api.github.com/repos/alphagov/content-performance-manager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-performance-manager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-performance-manager/tags","blobs_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-performance-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-performance-manager/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-performance-manager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-performance-manager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-performance-manager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-performance-manager/subscription","commits_url":"https://api.github.com/repos/alphagov/content-performance-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-performance-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-performance-manager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-performance-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-performance-manager/merges","archive_url":"https://api.github.com/repos/alphagov/content-performance-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-performance-manager/downloads","issues_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-performance-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-performance-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-performance-manager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-performance-manager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-performance-manager/deployments","created_at":"2016-11-16T14:22:38Z","updated_at":"2018-05-09T10:39:42Z","pushed_at":"2018-05-10T09:36:43Z","git_url":"git://github.com/alphagov/content-performance-manager.git","ssh_url":"git@github.com:alphagov/content-performance-manager.git","clone_url":"https://github.com/alphagov/content-performance-manager.git","svn_url":"https://github.com/alphagov/content-performance-manager","homepage":"https://docs.publishing.service.gov.uk/apps/content-performance-manager.html","size":3487,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"c991464a97b4d99b59bbc2b44f2e4508ad1c161c","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":73927580,"name":"content-performance-manager","full_name":"alphagov/content-performance-manager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/content-performance-manager","description":"Data warehouse that stores content and content metrics to help content owners measure and improve content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/content-performance-manager","forks_url":"https://api.github.com/repos/alphagov/content-performance-manager/forks","keys_url":"https://api.github.com/repos/alphagov/content-performance-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/content-performance-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/content-performance-manager/teams","hooks_url":"https://api.github.com/repos/alphagov/content-performance-manager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/content-performance-manager/events","assignees_url":"https://api.github.com/repos/alphagov/content-performance-manager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/content-performance-manager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/content-performance-manager/tags","blobs_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/content-performance-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/content-performance-manager/languages","stargazers_url":"https://api.github.com/repos/alphagov/content-performance-manager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/content-performance-manager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/content-performance-manager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/content-performance-manager/subscription","commits_url":"https://api.github.com/repos/alphagov/content-performance-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/content-performance-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/content-performance-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/content-performance-manager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/content-performance-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/content-performance-manager/merges","archive_url":"https://api.github.com/repos/alphagov/content-performance-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/content-performance-manager/downloads","issues_url":"https://api.github.com/repos/alphagov/content-performance-manager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/content-performance-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/content-performance-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/content-performance-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/content-performance-manager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/content-performance-manager/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/content-performance-manager/deployments","created_at":"2016-11-16T14:22:38Z","updated_at":"2018-05-09T10:39:42Z","pushed_at":"2018-05-10T09:36:43Z","git_url":"git://github.com/alphagov/content-performance-manager.git","ssh_url":"git@github.com:alphagov/content-performance-manager.git","clone_url":"https://github.com/alphagov/content-performance-manager.git","svn_url":"https://github.com/alphagov/content-performance-manager","homepage":"https://docs.publishing.service.gov.uk/apps/content-performance-manager.html","size":3487,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696"},"html":{"href":"https://github.com/alphagov/content-performance-manager/pull/696"},"issue":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/issues/696"},"comments":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/content-performance-manager/statuses/730db998f5da9b4db6aaa85efc3c70bc73a5a417"}},"author_association":"CONTRIBUTOR"}} | {
"id": 73927580,
"name": "alphagov/content-performance-manager",
"url": "https://api.github.com/repos/alphagov/content-performance-manager"
} | {
"id": 13124899,
"login": "KyleMacPherson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13124899?",
"url": "https://api.github.com/users/KyleMacPherson"
} | {
"id": 596977,
"login": "alphagov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596977?",
"url": "https://api.github.com/orgs/alphagov"
} | 2018-05-10T09:37:12 | 7654533954 | {"actor":{"display_login":"KyleMacPherson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/paas-admin/pulls/comments/166910320","pull_request_review_id":95044326,"id":166910320,"diff_hunk":"@@ -0,0 +1,85 @@\n+{\n+ \"name\": \"paas-admin\",\n+ \"version\": \"1.0.0\",\n+ \"description\": \"GOV.UK PaaS CloudFoundry UI\",\n+ \"main\": \"src/main.js\",\n+ \"repository\": \"https://github.com/alphagov/paas-admin\",\n+ \"scripts\": {\n+ \"test\": \"npm run -s test:unit -- --cov && npm run -s lint\",\n+ \"test:unit\": \"npm run -s dev:build && tap --100 --no-coverage --nyc-arg='--instrument=false' --nyc-arg='--all' dist/*.test.js\",\n+ \"test:vulnerabilities\": \"snyk test\",\n+ \"lint\": \"npm run -s lint:js && npm run -s lint:sass\",\n+ \"lint:js\": \"xo\",\n+ \"lint:sass\": \"sass-lint -v\",\n+ \"fix\": \"npm run -s fix:js\",\n+ \"fix:js\": \"xo --fix ./src\",\n+ \"fix:sass\": \"sass-lint --fix ./src\",\n+ \"fix:vulnerabilities\": \"snyk protect\",\n+ \"start\": \"npm run -s dev:start\",\n+ \"dev:build\": \"webpack --config config/webpack.config.js\",\n+ \"dev:start\": \"ENABLE_WATCH=true ENABLE_SERVER=true npm run dev:build | pino\",\n+ \"production:build\": \"DISABLE_TESTS=true NODE_ENV=production webpack --config config/webpack.config.js\",\n+ \"production:start\": \"npm run -s production:build && node dist/main.js\",\n+ \"production:push\": \"npm run -s production:build && cf push\"\n+ },\n+ \"author\": \"Crown\",\n+ \"license\": \"MIT\",\n+ \"devDependencies\": {\n+ \"@govuk-frontend/all\": \"0.0.22-alpha\",\n+ \"apply-loader\": \"2.0.0\",\n+ \"css-loader\": \"0.28.9\",\n+ \"eslint\": \"4.17.0\",\n+ \"express\": \"4.16.2\",\n+ \"express-pino-logger\": \"3.0.1\",\n+ \"extract-loader\": \"1.0.2\",\n+ \"file-loader\": \"1.1.6\",\n+ \"glob\": \"^7.1.2\",\n+ \"govuk_template_jinja\": \"^0.23.0\",\n+ \"helmet\": \"^3.10.0\",\n+ \"html-loader\": \"0.5.5\",\n+ \"istanbul-instrumenter-loader\": \"^3.0.0\",\n+ \"loader-utils\": \"1.1.0\",\n+ \"memory-fs\": \"0.4.1\",\n+ \"node-sass\": \"4.7.2\",\n+ \"nunjucks\": \"3.0.1\",\n+ \"nyc\": \"^11.4.1\",\n+ \"pino\": \"4.10.4\",\n+ \"regexp-replace-loader\": \"^1.0.1\",\n+ \"sass-lint\": \"1.12.1\",\n+ \"sass-loader\": \"6.0.6\",\n+ \"schema-utils\": \"0.4.3\",\n+ \"source-map-support\": \"0.5.3\",\n+ \"start-server-webpack-plugin\": \"2.2.1\",\n+ \"supertest\": \"3.0.0\",\n+ \"tap\": \"^11.1.0\",\n+ \"uglifyjs-webpack-plugin\": \"1.1.8\",\n+ \"webpack\": \"^4.0.0-beta.0\",","path":"package.json","position":56,"original_position":56,"commit_id":"cd408425d6e42c47d9b2b5ddbf638352c1d2d031","original_commit_id":"cd408425d6e42c47d9b2b5ddbf638352c1d2d031","user":{"login":"chrisfarms","id":45921,"avatar_url":"https://avatars2.githubusercontent.com/u/45921?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisfarms","html_url":"https://github.com/chrisfarms","followers_url":"https://api.github.com/users/chrisfarms/followers","following_url":"https://api.github.com/users/chrisfarms/following{/other_user}","gists_url":"https://api.github.com/users/chrisfarms/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisfarms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisfarms/subscriptions","organizations_url":"https://api.github.com/users/chrisfarms/orgs","repos_url":"https://api.github.com/users/chrisfarms/repos","events_url":"https://api.github.com/users/chrisfarms/events{/privacy}","received_events_url":"https://api.github.com/users/chrisfarms/received_events","type":"User","site_admin":false},"body":"Heh it was actually for pragmatic reasons:\r\n\r\n1. source map support is improved and gave correct line numbers in the tests compared with webpack 3\r\n2. webpack 4 actually comes out of beta in like 2 weeks so might as well ","created_at":"2018-02-08T11:47:23Z","updated_at":"2018-02-08T11:47:24Z","html_url":"https://github.com/alphagov/paas-admin/pull/2#discussion_r166910320","pull_request_url":"https://api.github.com/repos/alphagov/paas-admin/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/comments/166910320"},"html":{"href":"https://github.com/alphagov/paas-admin/pull/2#discussion_r166910320"},"pull_request":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/2"}},"in_reply_to_id":166756749},"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-admin/pulls/2","id":167746903,"html_url":"https://github.com/alphagov/paas-admin/pull/2","diff_url":"https://github.com/alphagov/paas-admin/pull/2.diff","patch_url":"https://github.com/alphagov/paas-admin/pull/2.patch","issue_url":"https://api.github.com/repos/alphagov/paas-admin/issues/2","number":2,"state":"open","locked":false,"title":"[#154526390] Node.js Boilerplate","user":{"login":"chrisfarms","id":45921,"avatar_url":"https://avatars2.githubusercontent.com/u/45921?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisfarms","html_url":"https://github.com/chrisfarms","followers_url":"https://api.github.com/users/chrisfarms/followers","following_url":"https://api.github.com/users/chrisfarms/following{/other_user}","gists_url":"https://api.github.com/users/chrisfarms/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisfarms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisfarms/subscriptions","organizations_url":"https://api.github.com/users/chrisfarms/orgs","repos_url":"https://api.github.com/users/chrisfarms/repos","events_url":"https://api.github.com/users/chrisfarms/events{/privacy}","received_events_url":"https://api.github.com/users/chrisfarms/received_events","type":"User","site_admin":false},"body":"# What\r\n\r\nWe have created a starter/boilerplate for building a well tested and well structured node.js application running on paas styled with the new [GOV.UK Design System](https://govuk-design-system-production.cloudapps.digital)\r\n\r\nKey points:\r\n\r\n* Opinionated javascript linting using `xo`.\r\n* Uses webpack to manage the dependencies of the application\r\n* Uses the GOV.UK template from govuk_template_jinja project\r\n* Configured to allow easily importing components from\r\n govuk-fronend project\r\n protection middleware\r\n* Structure is 'feature' focused\r\n* Webserver is an express app, each dir is a logical section ie\r\n 'space' which contains handler code, test code and templates.\r\n* Nunjucks templating to take advantage of the govuk-frontend macros\r\n* 100% test coverage is enforced by istambul/nyc\r\n* tests use node-tap for it's simplicity, good docs, async support and\r\n integration with the other tools\r\n* helpful `npm run *` scripts for linting/testing/fixing\r\n* Ready to deploy to GOV.UK PaaS via `npm run production:push`\r\n* Travis runs tests targetting node 8\r\n* Hot code reloading when using `npm run dev:start`\r\n* Structured logging setup via pino (and prettified during dev mode)\r\n* Content Security Policy enforced by helmet middleware\r\n* .editorconfig to end whitespace wars\r\n\r\n# How to review\r\n\r\n* check out this branch\r\n* read the README ... or just run `npm install` then `npm start` and `npm test`\r\n* have a poke around ... maybe configure your editor to use [xo](https://github.com/sindresorhus/xo) linting\r\n* Imagine you are tasked to \"create a page at `/buttons` with a button on it\" ... and try and do it\r\n\r\n# Who can review\r\n\r\nNot @carolinegreen or @chrisfarms\r\n\r\n@paroxp would be a good candidate or anyone with a bit of nodejs knowledge.\r\n","created_at":"2018-02-07T16:45:47Z","updated_at":"2018-02-08T11:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0e1baa6a8bb4f3a4f20f70f2c8b24f9fd360a75","assignee":{"login":"paroxp","id":2418945,"avatar_url":"https://avatars3.githubusercontent.com/u/2418945?v=4","gravatar_id":"","url":"https://api.github.com/users/paroxp","html_url":"https://github.com/paroxp","followers_url":"https://api.github.com/users/paroxp/followers","following_url":"https://api.github.com/users/paroxp/following{/other_user}","gists_url":"https://api.github.com/users/paroxp/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxp/subscriptions","organizations_url":"https://api.github.com/users/paroxp/orgs","repos_url":"https://api.github.com/users/paroxp/repos","events_url":"https://api.github.com/users/paroxp/events{/privacy}","received_events_url":"https://api.github.com/users/paroxp/received_events","type":"User","site_admin":false},"assignees":[{"login":"paroxp","id":2418945,"avatar_url":"https://avatars3.githubusercontent.com/u/2418945?v=4","gravatar_id":"","url":"https://api.github.com/users/paroxp","html_url":"https://github.com/paroxp","followers_url":"https://api.github.com/users/paroxp/followers","following_url":"https://api.github.com/users/paroxp/following{/other_user}","gists_url":"https://api.github.com/users/paroxp/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxp/subscriptions","organizations_url":"https://api.github.com/users/paroxp/orgs","repos_url":"https://api.github.com/users/paroxp/repos","events_url":"https://api.github.com/users/paroxp/events{/privacy}","received_events_url":"https://api.github.com/users/paroxp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/paas-admin/pulls/2/commits","review_comments_url":"https://api.github.com/repos/alphagov/paas-admin/pulls/2/comments","review_comment_url":"https://api.github.com/repos/alphagov/paas-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/paas-admin/issues/2/comments","statuses_url":"https://api.github.com/repos/alphagov/paas-admin/statuses/cd408425d6e42c47d9b2b5ddbf638352c1d2d031","head":{"label":"alphagov:bootstrap-node-admin-154526390","ref":"bootstrap-node-admin-154526390","sha":"cd408425d6e42c47d9b2b5ddbf638352c1d2d031","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":113037599,"name":"paas-admin","full_name":"alphagov/paas-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-admin","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/paas-admin","forks_url":"https://api.github.com/repos/alphagov/paas-admin/forks","keys_url":"https://api.github.com/repos/alphagov/paas-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-admin/events","assignees_url":"https://api.github.com/repos/alphagov/paas-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-admin/merges","archive_url":"https://api.github.com/repos/alphagov/paas-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-admin/deployments","created_at":"2017-12-04T12:07:40Z","updated_at":"2018-02-07T18:13:33Z","pushed_at":"2018-02-07T18:18:18Z","git_url":"git://github.com/alphagov/paas-admin.git","ssh_url":"git@github.com:alphagov/paas-admin.git","clone_url":"https://github.com/alphagov/paas-admin.git","svn_url":"https://github.com/alphagov/paas-admin","homepage":null,"size":323,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"uaa-auth-153072577"}},"base":{"label":"alphagov:node-master","ref":"node-master","sha":"a1e884b24b3a5c65a456525c4449149519ce8d8d","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":113037599,"name":"paas-admin","full_name":"alphagov/paas-admin","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-admin","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/paas-admin","forks_url":"https://api.github.com/repos/alphagov/paas-admin/forks","keys_url":"https://api.github.com/repos/alphagov/paas-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-admin/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-admin/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-admin/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-admin/events","assignees_url":"https://api.github.com/repos/alphagov/paas-admin/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-admin/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-admin/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-admin/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-admin/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-admin/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-admin/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-admin/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-admin/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-admin/merges","archive_url":"https://api.github.com/repos/alphagov/paas-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-admin/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-admin/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-admin/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-admin/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-admin/deployments","created_at":"2017-12-04T12:07:40Z","updated_at":"2018-02-07T18:13:33Z","pushed_at":"2018-02-07T18:18:18Z","git_url":"git://github.com/alphagov/paas-admin.git","ssh_url":"git@github.com:alphagov/paas-admin.git","clone_url":"https://github.com/alphagov/paas-admin.git","svn_url":"https://github.com/alphagov/paas-admin","homepage":null,"size":323,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"uaa-auth-153072577"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/2"},"html":{"href":"https://github.com/alphagov/paas-admin/pull/2"},"issue":{"href":"https://api.github.com/repos/alphagov/paas-admin/issues/2"},"comments":{"href":"https://api.github.com/repos/alphagov/paas-admin/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/paas-admin/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/paas-admin/statuses/cd408425d6e42c47d9b2b5ddbf638352c1d2d031"}},"author_association":"CONTRIBUTOR"}} | {
"id": 113037599,
"name": "alphagov/paas-admin",
"url": "https://api.github.com/repos/alphagov/paas-admin"
} | {
"id": 45921,
"login": "chrisfarms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45921?",
"url": "https://api.github.com/users/chrisfarms"
} | {
"id": 596977,
"login": "alphagov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596977?",
"url": "https://api.github.com/orgs/alphagov"
} | 2018-02-08T11:47:23 | 7216445108 | {"actor":{"display_login":"chrisfarms"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/187675117","pull_request_review_id":119509314,"id":187675117,"diff_hunk":"@@ -286,9 +284,6 @@ open class RouteController: NSObject {\n private func setupTunnelIntersectionManager() {\n tunnelIntersectionManager = TunnelIntersectionManager()\n tunnelIntersectionManager?.delegate = self\n- tunnelIntersectionManagerCompletionHandler = { enabled, _ in\n- self.tunnelIntersectionManager?.isAnimationEnabled = enabled","path":"MapboxCoreNavigation/RouteController.swift","position":14,"original_position":14,"commit_id":"a5a143e59f78857ddecdb42d52f15f5bfe85ccef","original_commit_id":"1cfa4583aea4d62bd45c0e292ce8f8041c316c95","user":{"login":"1ec5","id":1231218,"avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"body":"> However in the future, if we decide to keep only one location manager alive, we need to inform the developer which location manager is active and whether or not animation is enabled.\r\n\r\nTunnelIntersectionManager already exposes this information via properties, so the delegator can simply access these properties after calling the delegate methods. A completion handler is only necessary if the delegate method needs to return information asynchronously. That pattern is extremely rare in Cocoa Touch frameworks.","created_at":"2018-05-11T17:06:42Z","updated_at":"2018-05-11T17:06:43Z","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414#discussion_r187675117","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/187675117"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414#discussion_r187675117"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414"}},"in_reply_to_id":187447663},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414","id":187295074,"html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414","diff_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1414","number":1414,"state":"open","locked":false,"title":"Remove tunnel intersection manager callback mechanism","user":{"login":"1ec5","id":1231218,"avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"body":"Callback arguments were obscuring the fact that TunnelIntersectionManagerDelegate method implementations and callers were all synchronous. Effectively, properties were getting set to themselves. The callback arguments have been removed and the callbacks inlined into the call sites.\r\n\r\nAlso fixed a tautology and off-by-one error in the code that transitions from tunnel simulation to standard location management.\r\n\r\n/cc ~~@vincentsarago~~ @vincethecoder @bsudekum","created_at":"2018-05-10T20:15:09Z","updated_at":"2018-05-11T17:06:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d12643a4ca9ac37b4dba3bcd093ad54df398c5dc","assignee":{"login":"1ec5","id":1231218,"avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"assignees":[{"login":"1ec5","id":1231218,"avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":482435064,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/-%20bug","name":"- bug","color":"0052cc","default":false},{"id":642998392,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/-%20refactor","name":"- refactor","color":"0052cc","default":false},{"id":650004084,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/topic:%20location","name":"topic: location","color":"bfd4f2","default":false},{"id":583447610,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/%E2%9A%A0%EF%B8%8F%20DO%20NOT%20MERGE","name":"⚠️ DO NOT MERGE","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/18","html_url":"https://github.com/mapbox/mapbox-navigation-ios/milestone/18","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/18/labels","id":3333879,"number":18,"title":"v0.18.0","description":"","creator":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-05-09T17:30:35Z","updated_at":"2018-05-10T20:15:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1414/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/a5a143e59f78857ddecdb42d52f15f5bfe85ccef","head":{"label":"mapbox:1ec5-tunnel-callback","ref":"1ec5-tunnel-callback","sha":"a5a143e59f78857ddecdb42d52f15f5bfe85ccef","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-05-11T17:03:24Z","pushed_at":"2018-05-11T17:04:19Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":53588,"stargazers_count":362,"watchers_count":362,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":70,"open_issues":97,"watchers":362,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f6f54900ab9b92774ec9dba3f9b14f6a6ec78ca8","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-05-11T17:03:24Z","pushed_at":"2018-05-11T17:04:19Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":53588,"stargazers_count":362,"watchers_count":362,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":70,"open_issues":97,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1414"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1414"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1414/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1414/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/a5a143e59f78857ddecdb42d52f15f5bfe85ccef"}},"author_association":"MEMBER"}} | {
"id": 73870932,
"name": "mapbox/mapbox-navigation-ios",
"url": "https://api.github.com/repos/mapbox/mapbox-navigation-ios"
} | {
"id": 1231218,
"login": "1ec5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1231218?",
"url": "https://api.github.com/users/1ec5"
} | {
"id": 600935,
"login": "mapbox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/600935?",
"url": "https://api.github.com/orgs/mapbox"
} | 2018-05-11T17:06:42 | 7662334069 | {"actor":{"display_login":"1ec5"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Mirantis/kqueen/pulls/comments/166929339","pull_request_review_id":95067519,"id":166929339,"diff_hunk":"@@ -2,6 +2,8 @@ version: '2'\n services:\n api:\n image: kqueen/api:v0.16\n+ volumes:","path":"docker-compose.demo.yml","position":4,"original_position":4,"commit_id":"60b6610e3eecaebec64eb7bc121d1f261d44ea32","original_commit_id":"60b6610e3eecaebec64eb7bc121d1f261d44ea32","user":{"login":"naumvd95","id":18596213,"avatar_url":"https://avatars2.githubusercontent.com/u/18596213?v=4","gravatar_id":"","url":"https://api.github.com/users/naumvd95","html_url":"https://github.com/naumvd95","followers_url":"https://api.github.com/users/naumvd95/followers","following_url":"https://api.github.com/users/naumvd95/following{/other_user}","gists_url":"https://api.github.com/users/naumvd95/gists{/gist_id}","starred_url":"https://api.github.com/users/naumvd95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naumvd95/subscriptions","organizations_url":"https://api.github.com/users/naumvd95/orgs","repos_url":"https://api.github.com/users/naumvd95/repos","events_url":"https://api.github.com/users/naumvd95/events{/privacy}","received_events_url":"https://api.github.com/users/naumvd95/received_events","type":"User","site_admin":false},"body":"ok, btw, do we need to map logging into etcd storage?","created_at":"2018-02-08T13:16:37Z","updated_at":"2018-02-08T13:16:37Z","html_url":"https://github.com/Mirantis/kqueen/pull/216#discussion_r166929339","pull_request_url":"https://api.github.com/repos/Mirantis/kqueen/pulls/216","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/comments/166929339"},"html":{"href":"https://github.com/Mirantis/kqueen/pull/216#discussion_r166929339"},"pull_request":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/216"}},"in_reply_to_id":166869539},"pull_request":{"url":"https://api.github.com/repos/Mirantis/kqueen/pulls/216","id":167799432,"html_url":"https://github.com/Mirantis/kqueen/pull/216","diff_url":"https://github.com/Mirantis/kqueen/pull/216.diff","patch_url":"https://github.com/Mirantis/kqueen/pull/216.patch","issue_url":"https://api.github.com/repos/Mirantis/kqueen/issues/216","number":216,"state":"open","locked":false,"title":"file handlers to root logger, dockerfile refactor:","user":{"login":"naumvd95","id":18596213,"avatar_url":"https://avatars2.githubusercontent.com/u/18596213?v=4","gravatar_id":"","url":"https://api.github.com/users/naumvd95","html_url":"https://github.com/naumvd95","followers_url":"https://api.github.com/users/naumvd95/followers","following_url":"https://api.github.com/users/naumvd95/following{/other_user}","gists_url":"https://api.github.com/users/naumvd95/gists{/gist_id}","starred_url":"https://api.github.com/users/naumvd95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naumvd95/subscriptions","organizations_url":"https://api.github.com/users/naumvd95/orgs","repos_url":"https://api.github.com/users/naumvd95/repos","events_url":"https://api.github.com/users/naumvd95/events{/privacy}","received_events_url":"https://api.github.com/users/naumvd95/received_events","type":"User","site_admin":false},"body":"- root logger configuration added to server.py as a 'core' level\r\nto avoid possible reinitializing and handler duplicating.\r\n- filehandler configuration added\r\n- kqueen user, gosu service defined to avoid root-actions, provide good dockerfile practice\r\n- refactoring dockerfile actions to increase visibility and provide good practice","created_at":"2018-02-07T20:24:18Z","updated_at":"2018-02-08T13:16:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"821bd31c393324d08f16faa97e2e0cfd4ee39bee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mirantis/kqueen/pulls/216/commits","review_comments_url":"https://api.github.com/repos/Mirantis/kqueen/pulls/216/comments","review_comment_url":"https://api.github.com/repos/Mirantis/kqueen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mirantis/kqueen/issues/216/comments","statuses_url":"https://api.github.com/repos/Mirantis/kqueen/statuses/60b6610e3eecaebec64eb7bc121d1f261d44ea32","head":{"label":"Mirantis:logging","ref":"logging","sha":"60b6610e3eecaebec64eb7bc121d1f261d44ea32","user":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"repo":{"id":104763063,"name":"kqueen","full_name":"Mirantis/kqueen","owner":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mirantis/kqueen","description":"Kubernetes queen - cluster manager","fork":false,"url":"https://api.github.com/repos/Mirantis/kqueen","forks_url":"https://api.github.com/repos/Mirantis/kqueen/forks","keys_url":"https://api.github.com/repos/Mirantis/kqueen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mirantis/kqueen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mirantis/kqueen/teams","hooks_url":"https://api.github.com/repos/Mirantis/kqueen/hooks","issue_events_url":"https://api.github.com/repos/Mirantis/kqueen/issues/events{/number}","events_url":"https://api.github.com/repos/Mirantis/kqueen/events","assignees_url":"https://api.github.com/repos/Mirantis/kqueen/assignees{/user}","branches_url":"https://api.github.com/repos/Mirantis/kqueen/branches{/branch}","tags_url":"https://api.github.com/repos/Mirantis/kqueen/tags","blobs_url":"https://api.github.com/repos/Mirantis/kqueen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mirantis/kqueen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mirantis/kqueen/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mirantis/kqueen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mirantis/kqueen/statuses/{sha}","languages_url":"https://api.github.com/repos/Mirantis/kqueen/languages","stargazers_url":"https://api.github.com/repos/Mirantis/kqueen/stargazers","contributors_url":"https://api.github.com/repos/Mirantis/kqueen/contributors","subscribers_url":"https://api.github.com/repos/Mirantis/kqueen/subscribers","subscription_url":"https://api.github.com/repos/Mirantis/kqueen/subscription","commits_url":"https://api.github.com/repos/Mirantis/kqueen/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mirantis/kqueen/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mirantis/kqueen/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mirantis/kqueen/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mirantis/kqueen/contents/{+path}","compare_url":"https://api.github.com/repos/Mirantis/kqueen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mirantis/kqueen/merges","archive_url":"https://api.github.com/repos/Mirantis/kqueen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mirantis/kqueen/downloads","issues_url":"https://api.github.com/repos/Mirantis/kqueen/issues{/number}","pulls_url":"https://api.github.com/repos/Mirantis/kqueen/pulls{/number}","milestones_url":"https://api.github.com/repos/Mirantis/kqueen/milestones{/number}","notifications_url":"https://api.github.com/repos/Mirantis/kqueen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mirantis/kqueen/labels{/name}","releases_url":"https://api.github.com/repos/Mirantis/kqueen/releases{/id}","deployments_url":"https://api.github.com/repos/Mirantis/kqueen/deployments","created_at":"2017-09-25T14:47:07Z","updated_at":"2018-02-07T14:19:22Z","pushed_at":"2018-02-08T09:09:30Z","git_url":"git://github.com/Mirantis/kqueen.git","ssh_url":"git@github.com:Mirantis/kqueen.git","clone_url":"https://github.com/Mirantis/kqueen.git","svn_url":"https://github.com/Mirantis/kqueen","homepage":"","size":2936,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":23,"watchers":25,"default_branch":"master"}},"base":{"label":"Mirantis:master","ref":"master","sha":"3c96a76033db55aa4a4846db9547eb9fce366173","user":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"repo":{"id":104763063,"name":"kqueen","full_name":"Mirantis/kqueen","owner":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mirantis/kqueen","description":"Kubernetes queen - cluster manager","fork":false,"url":"https://api.github.com/repos/Mirantis/kqueen","forks_url":"https://api.github.com/repos/Mirantis/kqueen/forks","keys_url":"https://api.github.com/repos/Mirantis/kqueen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mirantis/kqueen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mirantis/kqueen/teams","hooks_url":"https://api.github.com/repos/Mirantis/kqueen/hooks","issue_events_url":"https://api.github.com/repos/Mirantis/kqueen/issues/events{/number}","events_url":"https://api.github.com/repos/Mirantis/kqueen/events","assignees_url":"https://api.github.com/repos/Mirantis/kqueen/assignees{/user}","branches_url":"https://api.github.com/repos/Mirantis/kqueen/branches{/branch}","tags_url":"https://api.github.com/repos/Mirantis/kqueen/tags","blobs_url":"https://api.github.com/repos/Mirantis/kqueen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mirantis/kqueen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mirantis/kqueen/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mirantis/kqueen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mirantis/kqueen/statuses/{sha}","languages_url":"https://api.github.com/repos/Mirantis/kqueen/languages","stargazers_url":"https://api.github.com/repos/Mirantis/kqueen/stargazers","contributors_url":"https://api.github.com/repos/Mirantis/kqueen/contributors","subscribers_url":"https://api.github.com/repos/Mirantis/kqueen/subscribers","subscription_url":"https://api.github.com/repos/Mirantis/kqueen/subscription","commits_url":"https://api.github.com/repos/Mirantis/kqueen/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mirantis/kqueen/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mirantis/kqueen/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mirantis/kqueen/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mirantis/kqueen/contents/{+path}","compare_url":"https://api.github.com/repos/Mirantis/kqueen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mirantis/kqueen/merges","archive_url":"https://api.github.com/repos/Mirantis/kqueen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mirantis/kqueen/downloads","issues_url":"https://api.github.com/repos/Mirantis/kqueen/issues{/number}","pulls_url":"https://api.github.com/repos/Mirantis/kqueen/pulls{/number}","milestones_url":"https://api.github.com/repos/Mirantis/kqueen/milestones{/number}","notifications_url":"https://api.github.com/repos/Mirantis/kqueen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mirantis/kqueen/labels{/name}","releases_url":"https://api.github.com/repos/Mirantis/kqueen/releases{/id}","deployments_url":"https://api.github.com/repos/Mirantis/kqueen/deployments","created_at":"2017-09-25T14:47:07Z","updated_at":"2018-02-07T14:19:22Z","pushed_at":"2018-02-08T09:09:30Z","git_url":"git://github.com/Mirantis/kqueen.git","ssh_url":"git@github.com:Mirantis/kqueen.git","clone_url":"https://github.com/Mirantis/kqueen.git","svn_url":"https://github.com/Mirantis/kqueen","homepage":"","size":2936,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":23,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/216"},"html":{"href":"https://github.com/Mirantis/kqueen/pull/216"},"issue":{"href":"https://api.github.com/repos/Mirantis/kqueen/issues/216"},"comments":{"href":"https://api.github.com/repos/Mirantis/kqueen/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mirantis/kqueen/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/Mirantis/kqueen/statuses/60b6610e3eecaebec64eb7bc121d1f261d44ea32"}},"author_association":"COLLABORATOR"}} | {
"id": 104763063,
"name": "Mirantis/kqueen",
"url": "https://api.github.com/repos/Mirantis/kqueen"
} | {
"id": 18596213,
"login": "naumvd95",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18596213?",
"url": "https://api.github.com/users/naumvd95"
} | {
"id": 609319,
"login": "Mirantis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/609319?",
"url": "https://api.github.com/orgs/Mirantis"
} | 2018-02-08T13:16:37 | 7216843131 | {"actor":{"display_login":"naumvd95"}} |
Subsets and Splits