type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zkoss/zk/pulls/comments/214867403","pull_request_review_id":151992657,"id":214867403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDg2NzQwMw==","diff_hunk":"@@ -94,5 +167,63 @@ zul.wgt.Toolbar = zk.$extends(zul.Widget, {\n \t\tthis.$supers('onChildRemoved_', arguments);\n \t\tif (!this.childReplacing_ && this.inPanelMold())\n \t\t\tthis.rerender();\n+\t},\n+\tonSize: function () {\n+\t\tthis.$supers('onSize', arguments);\n+\t\tif (this.isOverflow())\n+\t\t\tthis._adjustContent();\n+\t},\n+\t_adjustContent: function () {\n+\t\tif (zUtl.isImageLoading() || !this._initialChildrenWidth) {\n+\t\t\tsetTimeout(this.proxy(this._adjustContent), 20);\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tvar toolbar = jq(this.$n()),\n+\t\t\tcontentWidth = toolbar.width() - this._getPaddingWidth(),\n+\t\t\tinitialChildrenWidth = this._initialChildrenWidth,\n+\t\t\tinitialChildrenAmount = initialChildrenWidth.length,\n+\t\t\ttempChildrenWidth = 0,\n+\t\t\tnewPopupChildrenAmount = 0;\n+\n+\t\tfor (var i = 0; i < initialChildrenAmount; i++) {\n+\t\t\ttempChildrenWidth += initialChildrenWidth[i];\n+\t\t\tif (tempChildrenWidth >= contentWidth) {\n+\t\t\t\tnewPopupChildrenAmount = initialChildrenAmount - i;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\n+\t\tvar oldPopupChildren = this._getChildren(this._overflowPopup),\n+\t\t\tpopupChildrenDiff = newPopupChildrenAmount - oldPopupChildren.length;\n+\n+\t\tif (!popupChildrenDiff)\n+\t\t\treturn;\n+\n+\t\tvar popup = this._overflowPopup,\n+\t\t\toverflowOn = this.$s('overflow-on'),\n+\t\t\toverflowOff = this.$s('overflow-off'),\n+\t\t\toldToolbarChildren = this._getChildren(this);\n+\n+\t\tif (newPopupChildrenAmount) {\n+\t\t\ttoolbar.addClass(overflowOn).removeClass(overflowOff);\n+\t\t\tif (popupChildrenDiff > 0) {\n+\t\t\t\tfor (var i = 0; i < popupChildrenDiff; i++)\n+\t\t\t\t\tpopup.insertBefore(oldToolbarChildren.pop(), popup.firstChild);","path":"zul/src/archive/web/js/zul/wgt/Toolbar.js","position":142,"original_position":142,"commit_id":"271ab9750a967795cd7fed7d9be54779cfc9e645","original_commit_id":"271ab9750a967795cd7fed7d9be54779cfc9e645","user":{"login":"wenninghsu","id":14938661,"node_id":"MDQ6VXNlcjE0OTM4NjYx","avatar_url":"https://avatars0.githubusercontent.com/u/14938661?v=4","gravatar_id":"","url":"https://api.github.com/users/wenninghsu","html_url":"https://github.com/wenninghsu","followers_url":"https://api.github.com/users/wenninghsu/followers","following_url":"https://api.github.com/users/wenninghsu/following{/other_user}","gists_url":"https://api.github.com/users/wenninghsu/gists{/gist_id}","starred_url":"https://api.github.com/users/wenninghsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenninghsu/subscriptions","organizations_url":"https://api.github.com/users/wenninghsu/orgs","repos_url":"https://api.github.com/users/wenninghsu/repos","events_url":"https://api.github.com/users/wenninghsu/events{/privacy}","received_events_url":"https://api.github.com/users/wenninghsu/received_events","type":"User","site_admin":false},"body":"why not just manipulate dom?","created_at":"2018-09-04T10:40:25Z","updated_at":"2018-09-04T10:53:41Z","html_url":"https://github.com/zkoss/zk/pull/1275#discussion_r214867403","pull_request_url":"https://api.github.com/repos/zkoss/zk/pulls/1275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zkoss/zk/pulls/comments/214867403"},"html":{"href":"https://github.com/zkoss/zk/pull/1275#discussion_r214867403"},"pull_request":{"href":"https://api.github.com/repos/zkoss/zk/pulls/1275"}}},"pull_request":{"url":"https://api.github.com/repos/zkoss/zk/pulls/1275","id":211946953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTQ2OTUz","html_url":"https://github.com/zkoss/zk/pull/1275","diff_url":"https://github.com/zkoss/zk/pull/1275.diff","patch_url":"https://github.com/zkoss/zk/pull/1275.patch","issue_url":"https://api.github.com/repos/zkoss/zk/issues/1275","number":1275,"state":"open","locked":false,"title":"ZK-3179: Toolbar can have a overflow button that contains those butto…","user":{"login":"charlesqqq","id":34027865,"node_id":"MDQ6VXNlcjM0MDI3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/34027865?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesqqq","html_url":"https://github.com/charlesqqq","followers_url":"https://api.github.com/users/charlesqqq/followers","following_url":"https://api.github.com/users/charlesqqq/following{/other_user}","gists_url":"https://api.github.com/users/charlesqqq/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesqqq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesqqq/subscriptions","organizations_url":"https://api.github.com/users/charlesqqq/orgs","repos_url":"https://api.github.com/users/charlesqqq/repos","events_url":"https://api.github.com/users/charlesqqq/events{/privacy}","received_events_url":"https://api.github.com/users/charlesqqq/received_events","type":"User","site_admin":false},"body":"…ns weren't able to fit in the toolbar","created_at":"2018-08-30T03:42:52Z","updated_at":"2018-09-04T10:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb4d88c3b897a6983e65101e84f3efbd74fad464","assignee":null,"assignees":[],"requested_reviewers":[{"login":"scribetw","id":6398934,"node_id":"MDQ6VXNlcjYzOTg5MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6398934?v=4","gravatar_id":"","url":"https://api.github.com/users/scribetw","html_url":"https://github.com/scribetw","followers_url":"https://api.github.com/users/scribetw/followers","following_url":"https://api.github.com/users/scribetw/following{/other_user}","gists_url":"https://api.github.com/users/scribetw/gists{/gist_id}","starred_url":"https://api.github.com/users/scribetw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scribetw/subscriptions","organizations_url":"https://api.github.com/users/scribetw/orgs","repos_url":"https://api.github.com/users/scribetw/repos","events_url":"https://api.github.com/users/scribetw/events{/privacy}","received_events_url":"https://api.github.com/users/scribetw/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zkoss/zk/pulls/1275/commits","review_comments_url":"https://api.github.com/repos/zkoss/zk/pulls/1275/comments","review_comment_url":"https://api.github.com/repos/zkoss/zk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zkoss/zk/issues/1275/comments","statuses_url":"https://api.github.com/repos/zkoss/zk/statuses/271ab9750a967795cd7fed7d9be54779cfc9e645","head":{"label":"charlesqqq:F86-ZK-3179","ref":"F86-ZK-3179","sha":"271ab9750a967795cd7fed7d9be54779cfc9e645","user":{"login":"charlesqqq","id":34027865,"node_id":"MDQ6VXNlcjM0MDI3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/34027865?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesqqq","html_url":"https://github.com/charlesqqq","followers_url":"https://api.github.com/users/charlesqqq/followers","following_url":"https://api.github.com/users/charlesqqq/following{/other_user}","gists_url":"https://api.github.com/users/charlesqqq/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesqqq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesqqq/subscriptions","organizations_url":"https://api.github.com/users/charlesqqq/orgs","repos_url":"https://api.github.com/users/charlesqqq/repos","events_url":"https://api.github.com/users/charlesqqq/events{/privacy}","received_events_url":"https://api.github.com/users/charlesqqq/received_events","type":"User","site_admin":false},"repo":{"id":124190546,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxOTA1NDY=","name":"zk","full_name":"charlesqqq/zk","owner":{"login":"charlesqqq","id":34027865,"node_id":"MDQ6VXNlcjM0MDI3ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/34027865?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesqqq","html_url":"https://github.com/charlesqqq","followers_url":"https://api.github.com/users/charlesqqq/followers","following_url":"https://api.github.com/users/charlesqqq/following{/other_user}","gists_url":"https://api.github.com/users/charlesqqq/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesqqq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesqqq/subscriptions","organizations_url":"https://api.github.com/users/charlesqqq/orgs","repos_url":"https://api.github.com/users/charlesqqq/repos","events_url":"https://api.github.com/users/charlesqqq/events{/privacy}","received_events_url":"https://api.github.com/users/charlesqqq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlesqqq/zk","description":"ZK is a highly productive Java framework for building amazing enterprise web and mobile applications","fork":true,"url":"https://api.github.com/repos/charlesqqq/zk","forks_url":"https://api.github.com/repos/charlesqqq/zk/forks","keys_url":"https://api.github.com/repos/charlesqqq/zk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlesqqq/zk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlesqqq/zk/teams","hooks_url":"https://api.github.com/repos/charlesqqq/zk/hooks","issue_events_url":"https://api.github.com/repos/charlesqqq/zk/issues/events{/number}","events_url":"https://api.github.com/repos/charlesqqq/zk/events","assignees_url":"https://api.github.com/repos/charlesqqq/zk/assignees{/user}","branches_url":"https://api.github.com/repos/charlesqqq/zk/branches{/branch}","tags_url":"https://api.github.com/repos/charlesqqq/zk/tags","blobs_url":"https://api.github.com/repos/charlesqqq/zk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlesqqq/zk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlesqqq/zk/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlesqqq/zk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlesqqq/zk/statuses/{sha}","languages_url":"https://api.github.com/repos/charlesqqq/zk/languages","stargazers_url":"https://api.github.com/repos/charlesqqq/zk/stargazers","contributors_url":"https://api.github.com/repos/charlesqqq/zk/contributors","subscribers_url":"https://api.github.com/repos/charlesqqq/zk/subscribers","subscription_url":"https://api.github.com/repos/charlesqqq/zk/subscription","commits_url":"https://api.github.com/repos/charlesqqq/zk/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlesqqq/zk/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlesqqq/zk/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlesqqq/zk/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlesqqq/zk/contents/{+path}","compare_url":"https://api.github.com/repos/charlesqqq/zk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlesqqq/zk/merges","archive_url":"https://api.github.com/repos/charlesqqq/zk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlesqqq/zk/downloads","issues_url":"https://api.github.com/repos/charlesqqq/zk/issues{/number}","pulls_url":"https://api.github.com/repos/charlesqqq/zk/pulls{/number}","milestones_url":"https://api.github.com/repos/charlesqqq/zk/milestones{/number}","notifications_url":"https://api.github.com/repos/charlesqqq/zk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlesqqq/zk/labels{/name}","releases_url":"https://api.github.com/repos/charlesqqq/zk/releases{/id}","deployments_url":"https://api.github.com/repos/charlesqqq/zk/deployments","created_at":"2018-03-07T06:34:16Z","updated_at":"2018-03-26T04:24:59Z","pushed_at":"2018-09-04T05:04:18Z","git_url":"git://github.com/charlesqqq/zk.git","ssh_url":"git@github.com:charlesqqq/zk.git","clone_url":"https://github.com/charlesqqq/zk.git","svn_url":"https://github.com/charlesqqq/zk","homepage":"http://www.zkoss.org","size":751847,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zkoss:master","ref":"master","sha":"dfc81724aa10cebcfb1f292090cdc21a097f8b57","user":{"login":"zkoss","id":617150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNzE1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/617150?v=4","gravatar_id":"","url":"https://api.github.com/users/zkoss","html_url":"https://github.com/zkoss","followers_url":"https://api.github.com/users/zkoss/followers","following_url":"https://api.github.com/users/zkoss/following{/other_user}","gists_url":"https://api.github.com/users/zkoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zkoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkoss/subscriptions","organizations_url":"https://api.github.com/users/zkoss/orgs","repos_url":"https://api.github.com/users/zkoss/repos","events_url":"https://api.github.com/users/zkoss/events{/privacy}","received_events_url":"https://api.github.com/users/zkoss/received_events","type":"Organization","site_admin":false},"repo":{"id":1775980,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc1OTgw","name":"zk","full_name":"zkoss/zk","owner":{"login":"zkoss","id":617150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNzE1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/617150?v=4","gravatar_id":"","url":"https://api.github.com/users/zkoss","html_url":"https://github.com/zkoss","followers_url":"https://api.github.com/users/zkoss/followers","following_url":"https://api.github.com/users/zkoss/following{/other_user}","gists_url":"https://api.github.com/users/zkoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zkoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkoss/subscriptions","organizations_url":"https://api.github.com/users/zkoss/orgs","repos_url":"https://api.github.com/users/zkoss/repos","events_url":"https://api.github.com/users/zkoss/events{/privacy}","received_events_url":"https://api.github.com/users/zkoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zkoss/zk","description":"ZK is a highly productive Java framework for building amazing enterprise web and mobile applications","fork":false,"url":"https://api.github.com/repos/zkoss/zk","forks_url":"https://api.github.com/repos/zkoss/zk/forks","keys_url":"https://api.github.com/repos/zkoss/zk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zkoss/zk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zkoss/zk/teams","hooks_url":"https://api.github.com/repos/zkoss/zk/hooks","issue_events_url":"https://api.github.com/repos/zkoss/zk/issues/events{/number}","events_url":"https://api.github.com/repos/zkoss/zk/events","assignees_url":"https://api.github.com/repos/zkoss/zk/assignees{/user}","branches_url":"https://api.github.com/repos/zkoss/zk/branches{/branch}","tags_url":"https://api.github.com/repos/zkoss/zk/tags","blobs_url":"https://api.github.com/repos/zkoss/zk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zkoss/zk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zkoss/zk/git/refs{/sha}","trees_url":"https://api.github.com/repos/zkoss/zk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zkoss/zk/statuses/{sha}","languages_url":"https://api.github.com/repos/zkoss/zk/languages","stargazers_url":"https://api.github.com/repos/zkoss/zk/stargazers","contributors_url":"https://api.github.com/repos/zkoss/zk/contributors","subscribers_url":"https://api.github.com/repos/zkoss/zk/subscribers","subscription_url":"https://api.github.com/repos/zkoss/zk/subscription","commits_url":"https://api.github.com/repos/zkoss/zk/commits{/sha}","git_commits_url":"https://api.github.com/repos/zkoss/zk/git/commits{/sha}","comments_url":"https://api.github.com/repos/zkoss/zk/comments{/number}","issue_comment_url":"https://api.github.com/repos/zkoss/zk/issues/comments{/number}","contents_url":"https://api.github.com/repos/zkoss/zk/contents/{+path}","compare_url":"https://api.github.com/repos/zkoss/zk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zkoss/zk/merges","archive_url":"https://api.github.com/repos/zkoss/zk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zkoss/zk/downloads","issues_url":"https://api.github.com/repos/zkoss/zk/issues{/number}","pulls_url":"https://api.github.com/repos/zkoss/zk/pulls{/number}","milestones_url":"https://api.github.com/repos/zkoss/zk/milestones{/number}","notifications_url":"https://api.github.com/repos/zkoss/zk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zkoss/zk/labels{/name}","releases_url":"https://api.github.com/repos/zkoss/zk/releases{/id}","deployments_url":"https://api.github.com/repos/zkoss/zk/deployments","created_at":"2011-05-20T10:25:18Z","updated_at":"2018-09-04T08:56:15Z","pushed_at":"2018-09-04T08:00:01Z","git_url":"git://github.com/zkoss/zk.git","ssh_url":"git@github.com:zkoss/zk.git","clone_url":"https://github.com/zkoss/zk.git","svn_url":"https://github.com/zkoss/zk","homepage":"http://www.zkoss.org","size":751759,"stargazers_count":259,"watchers_count":259,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":154,"open_issues":34,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zkoss/zk/pulls/1275"},"html":{"href":"https://github.com/zkoss/zk/pull/1275"},"issue":{"href":"https://api.github.com/repos/zkoss/zk/issues/1275"},"comments":{"href":"https://api.github.com/repos/zkoss/zk/issues/1275/comments"},"review_comments":{"href":"https://api.github.com/repos/zkoss/zk/pulls/1275/comments"},"review_comment":{"href":"https://api.github.com/repos/zkoss/zk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zkoss/zk/pulls/1275/commits"},"statuses":{"href":"https://api.github.com/repos/zkoss/zk/statuses/271ab9750a967795cd7fed7d9be54779cfc9e645"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1775980,
"name": "zkoss/zk",
"url": "https://api.github.com/repos/zkoss/zk"
} | {
"id": 14938661,
"login": "wenninghsu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14938661?",
"url": "https://api.github.com/users/wenninghsu"
} | {
"id": 617150,
"login": "zkoss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/617150?",
"url": "https://api.github.com/orgs/zkoss"
} | 2018-09-04T10:40:25 | 8210483801 | {"actor":{"display_login":"wenninghsu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/215761843","pull_request_review_id":153101061,"id":215761843,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTc2MTg0Mw==","diff_hunk":"@@ -157,9 +155,9 @@ It can be activated for printing with\n .. _record_projections_grammar:\n \n .. productionlist:: terms\n- term : term `.` ( qualid )\n- : | term `.` ( qualid arg … arg )\n- : | term `.` ( @`qualid` `term` … `term` )\n+ projection : projection `.` ( `qualid` )\n+ : | projection `.` ( `qualid` `arg` … `arg` )\n+ : | projection `.` ( @`qualid` `term` … `term` )","path":"doc/sphinx/language/gallina-extensions.rst","position":35,"original_position":35,"commit_id":"6023fe82f5b181866b9fc0ccf993e4a89380b03a","original_commit_id":"6023fe82f5b181866b9fc0ccf993e4a89380b03a","user":{"login":"cpitclaudel","id":8181630,"node_id":"MDQ6VXNlcjgxODE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8181630?v=4","gravatar_id":"","url":"https://api.github.com/users/cpitclaudel","html_url":"https://github.com/cpitclaudel","followers_url":"https://api.github.com/users/cpitclaudel/followers","following_url":"https://api.github.com/users/cpitclaudel/following{/other_user}","gists_url":"https://api.github.com/users/cpitclaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/cpitclaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpitclaudel/subscriptions","organizations_url":"https://api.github.com/users/cpitclaudel/orgs","repos_url":"https://api.github.com/users/cpitclaudel/repos","events_url":"https://api.github.com/users/cpitclaudel/events{/privacy}","received_events_url":"https://api.github.com/users/cpitclaudel/received_events","type":"User","site_admin":false},"body":"I added FIXMEs","created_at":"2018-09-06T20:12:42Z","updated_at":"2018-09-06T20:12:42Z","html_url":"https://github.com/coq/coq/pull/8418#discussion_r215761843","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/8418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/215761843"},"html":{"href":"https://github.com/coq/coq/pull/8418#discussion_r215761843"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/8418"}},"in_reply_to_id":215542171},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/8418","id":213434263,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDM0MjYz","html_url":"https://github.com/coq/coq/pull/8418","diff_url":"https://github.com/coq/coq/pull/8418.diff","patch_url":"https://github.com/coq/coq/pull/8418.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/8418","number":8418,"state":"open","locked":false,"title":"Add a PDF version of the manual","user":{"login":"cpitclaudel","id":8181630,"node_id":"MDQ6VXNlcjgxODE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8181630?v=4","gravatar_id":"","url":"https://api.github.com/users/cpitclaudel","html_url":"https://github.com/cpitclaudel","followers_url":"https://api.github.com/users/cpitclaudel/followers","following_url":"https://api.github.com/users/cpitclaudel/following{/other_user}","gists_url":"https://api.github.com/users/cpitclaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/cpitclaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpitclaudel/subscriptions","organizations_url":"https://api.github.com/users/cpitclaudel/orgs","repos_url":"https://api.github.com/users/cpitclaudel/repos","events_url":"https://api.github.com/users/cpitclaudel/events{/privacy}","received_events_url":"https://api.github.com/users/cpitclaudel/received_events","type":"User","site_admin":false},"body":"**Kind:** documentation / infrastructure.\r\n\r\nI've tried to split this into reasonably-sized commits. There were mistakes in some of the LaTeX formulae that the HTML build didn't catch, and in the bib file; I also used this opportunity to document more DOs and DONTs in the documentation's dev guide.\r\n\r\nThere are plenty of further tweaks we could make to make the manual look prettier, but this is enough to build it.\r\n\r\nCloses #7500","created_at":"2018-09-05T21:32:28Z","updated_at":"2018-09-06T20:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a4ab9a1c7957691a92502ff7770bc222554c0e0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":649046438,"node_id":"MDU6TGFiZWw2NDkwNDY0Mzg=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20documentation","name":"kind: documentation","color":"990000","default":false},{"id":649047024,"node_id":"MDU6TGFiZWw2NDkwNDcwMjQ=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20infrastructure","name":"kind: infrastructure","color":"006b75","default":false},{"id":395008245,"node_id":"MDU6TGFiZWwzOTUwMDgyNDU=","url":"https://api.github.com/repos/coq/coq/labels/needs:%20fixing","name":"needs: fixing","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/8418/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/8418/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/8418/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/6023fe82f5b181866b9fc0ccf993e4a89380b03a","head":{"label":"cpitclaudel:cpitclaudel_pdf","ref":"cpitclaudel_pdf","sha":"6023fe82f5b181866b9fc0ccf993e4a89380b03a","user":{"login":"cpitclaudel","id":8181630,"node_id":"MDQ6VXNlcjgxODE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8181630?v=4","gravatar_id":"","url":"https://api.github.com/users/cpitclaudel","html_url":"https://github.com/cpitclaudel","followers_url":"https://api.github.com/users/cpitclaudel/followers","following_url":"https://api.github.com/users/cpitclaudel/following{/other_user}","gists_url":"https://api.github.com/users/cpitclaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/cpitclaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpitclaudel/subscriptions","organizations_url":"https://api.github.com/users/cpitclaudel/orgs","repos_url":"https://api.github.com/users/cpitclaudel/repos","events_url":"https://api.github.com/users/cpitclaudel/events{/privacy}","received_events_url":"https://api.github.com/users/cpitclaudel/received_events","type":"User","site_admin":false},"repo":{"id":30869441,"node_id":"MDEwOlJlcG9zaXRvcnkzMDg2OTQ0MQ==","name":"coq","full_name":"cpitclaudel/coq","owner":{"login":"cpitclaudel","id":8181630,"node_id":"MDQ6VXNlcjgxODE2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8181630?v=4","gravatar_id":"","url":"https://api.github.com/users/cpitclaudel","html_url":"https://github.com/cpitclaudel","followers_url":"https://api.github.com/users/cpitclaudel/followers","following_url":"https://api.github.com/users/cpitclaudel/following{/other_user}","gists_url":"https://api.github.com/users/cpitclaudel/gists{/gist_id}","starred_url":"https://api.github.com/users/cpitclaudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpitclaudel/subscriptions","organizations_url":"https://api.github.com/users/cpitclaudel/orgs","repos_url":"https://api.github.com/users/cpitclaudel/repos","events_url":"https://api.github.com/users/cpitclaudel/events{/privacy}","received_events_url":"https://api.github.com/users/cpitclaudel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpitclaudel/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/cpitclaudel/coq","forks_url":"https://api.github.com/repos/cpitclaudel/coq/forks","keys_url":"https://api.github.com/repos/cpitclaudel/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpitclaudel/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpitclaudel/coq/teams","hooks_url":"https://api.github.com/repos/cpitclaudel/coq/hooks","issue_events_url":"https://api.github.com/repos/cpitclaudel/coq/issues/events{/number}","events_url":"https://api.github.com/repos/cpitclaudel/coq/events","assignees_url":"https://api.github.com/repos/cpitclaudel/coq/assignees{/user}","branches_url":"https://api.github.com/repos/cpitclaudel/coq/branches{/branch}","tags_url":"https://api.github.com/repos/cpitclaudel/coq/tags","blobs_url":"https://api.github.com/repos/cpitclaudel/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpitclaudel/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpitclaudel/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpitclaudel/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpitclaudel/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/cpitclaudel/coq/languages","stargazers_url":"https://api.github.com/repos/cpitclaudel/coq/stargazers","contributors_url":"https://api.github.com/repos/cpitclaudel/coq/contributors","subscribers_url":"https://api.github.com/repos/cpitclaudel/coq/subscribers","subscription_url":"https://api.github.com/repos/cpitclaudel/coq/subscription","commits_url":"https://api.github.com/repos/cpitclaudel/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpitclaudel/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpitclaudel/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpitclaudel/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpitclaudel/coq/contents/{+path}","compare_url":"https://api.github.com/repos/cpitclaudel/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpitclaudel/coq/merges","archive_url":"https://api.github.com/repos/cpitclaudel/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpitclaudel/coq/downloads","issues_url":"https://api.github.com/repos/cpitclaudel/coq/issues{/number}","pulls_url":"https://api.github.com/repos/cpitclaudel/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/cpitclaudel/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/cpitclaudel/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpitclaudel/coq/labels{/name}","releases_url":"https://api.github.com/repos/cpitclaudel/coq/releases{/id}","deployments_url":"https://api.github.com/repos/cpitclaudel/coq/deployments","created_at":"2015-02-16T13:28:07Z","updated_at":"2017-01-14T04:06:03Z","pushed_at":"2018-09-05T21:27:52Z","git_url":"git://github.com/cpitclaudel/coq.git","ssh_url":"git@github.com:cpitclaudel/coq.git","clone_url":"https://github.com/cpitclaudel/coq.git","svn_url":"https://github.com/cpitclaudel/coq","homepage":"http://coq.inria.fr/","size":100884,"stargazers_count":1,"watchers_count":1,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"coq:master","ref":"master","sha":"579f30a53809f9cf73aa3d7c69960b50fc51c7fc","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2018-09-06T20:11:13Z","pushed_at":"2018-09-06T19:34:42Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":114857,"stargazers_count":1434,"watchers_count":1434,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":1825,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":268,"open_issues":1825,"watchers":1434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/8418"},"html":{"href":"https://github.com/coq/coq/pull/8418"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/8418"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/8418/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/8418/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/8418/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/6023fe82f5b181866b9fc0ccf993e4a89380b03a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1377159,
"name": "coq/coq",
"url": "https://api.github.com/repos/coq/coq"
} | {
"id": 8181630,
"login": "cpitclaudel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8181630?",
"url": "https://api.github.com/users/cpitclaudel"
} | {
"id": 621198,
"login": "coq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/621198?",
"url": "https://api.github.com/orgs/coq"
} | 2018-09-06T20:12:42 | 8226684948 | {"actor":{"display_login":"cpitclaudel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/198531868","pull_request_review_id":132477501,"id":198531868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODUzMTg2OA==","diff_hunk":"@@ -0,0 +1,101 @@\n+package quota\n+\n+import (\n+\t\"os\"\n+\t\"path\"\n+\n+\t\"github.com/gluster/glusterd2/glusterd2/daemon\"\n+\t\"github.com/gluster/glusterd2/glusterd2/volume\"\n+\t\"github.com/gluster/glusterd2/glusterd2/xlator\"\n+\t\"github.com/gluster/glusterd2/pkg/errors\"\n+\n+\tlog \"github.com/sirupsen/logrus\"\n+)\n+\n+type quotadActor struct{}\n+\n+const (\n+\tquotaDaemonKey = \"enable\"\n+)\n+\n+// isQuotadAffectedNode returns true if there are local bricks of volume on\n+// which quota is enabled\n+func isQuotadAffectedNode(volumes []*volume.Volinfo) bool {\n+\tfor _, v := range volumes {\n+\t\tif !isQuotaEnabled(v) {\n+\t\t\tcontinue\n+\t\t} else if v.State != volume.VolStarted {\n+\t\t\tcontinue\n+\t\t} else {\n+\t\t\tbricks := v.GetLocalBricks()\n+\t\t\tif len(bricks) > 0 {\n+\t\t\t\treturn true\n+\t\t\t}\n+\t\t}\n+\t}\n+\treturn false\n+}\n+\n+func (actor *quotadActor) Do(v *volume.Volinfo, key, value string, logger log.FieldLogger) error {\n+\tif key != quotaDaemonKey {\n+\t\treturn nil\n+\t}\n+\tquotadDaemon, err := NewQuotad()\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\t// Create pidfile dir if not exists\n+\tif err := os.MkdirAll(path.Dir(quotadDaemon.pidfilepath),\n+\t\tos.ModeDir|os.ModePerm); err != nil {\n+\t\treturn err\n+\t}\n+\n+\t// Create logFiledir dir\n+\tif err := os.MkdirAll(path.Dir(quotadDaemon.logfilepath),\n+\t\tos.ModeDir|os.ModePerm); err != nil {\n+\t\treturn err\n+\t}\n+\n+\tvolumes, err := volume.GetVolumes()\n+\tif err != nil {\n+\t\tlogger.WithError(err).Error(\"failed to get volumes\")\n+\t\treturn err\n+\t}\n+\t// Check for making changes to quotad on this node\n+\t// For both disable and enable we need to do the same (restart).\n+\tif !isQuotadAffectedNode(volumes) {\n+\t\t// This condition is for disable\n+\t\t// If its the last node that is going to stop the daemon,","path":"plugins/quota/actor.go","position":68,"original_position":68,"commit_id":"86e9950eb4b98836bcc6719ac8e8b57ad9a0361b","original_commit_id":"86e9950eb4b98836bcc6719ac8e8b57ad9a0361b","user":{"login":"harigowtham","id":11406648,"node_id":"MDQ6VXNlcjExNDA2NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/11406648?v=4","gravatar_id":"","url":"https://api.github.com/users/harigowtham","html_url":"https://github.com/harigowtham","followers_url":"https://api.github.com/users/harigowtham/followers","following_url":"https://api.github.com/users/harigowtham/following{/other_user}","gists_url":"https://api.github.com/users/harigowtham/gists{/gist_id}","starred_url":"https://api.github.com/users/harigowtham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harigowtham/subscriptions","organizations_url":"https://api.github.com/users/harigowtham/orgs","repos_url":"https://api.github.com/users/harigowtham/repos","events_url":"https://api.github.com/users/harigowtham/events{/privacy}","received_events_url":"https://api.github.com/users/harigowtham/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-27T15:09:03Z","updated_at":"2018-06-27T15:09:03Z","html_url":"https://github.com/gluster/glusterd2/pull/615#discussion_r198531868","pull_request_url":"https://api.github.com/repos/gluster/glusterd2/pulls/615","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments/198531868"},"html":{"href":"https://github.com/gluster/glusterd2/pull/615#discussion_r198531868"},"pull_request":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/615"}},"in_reply_to_id":198366173},"pull_request":{"url":"https://api.github.com/repos/gluster/glusterd2/pulls/615","id":176974076,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc2OTc0MDc2","html_url":"https://github.com/gluster/glusterd2/pull/615","diff_url":"https://github.com/gluster/glusterd2/pull/615.diff","patch_url":"https://github.com/gluster/glusterd2/pull/615.patch","issue_url":"https://api.github.com/repos/gluster/glusterd2/issues/615","number":615,"state":"open","locked":false,"title":"quota: disable quotad","user":{"login":"harigowtham","id":11406648,"node_id":"MDQ6VXNlcjExNDA2NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/11406648?v=4","gravatar_id":"","url":"https://api.github.com/users/harigowtham","html_url":"https://github.com/harigowtham","followers_url":"https://api.github.com/users/harigowtham/followers","following_url":"https://api.github.com/users/harigowtham/following{/other_user}","gists_url":"https://api.github.com/users/harigowtham/gists{/gist_id}","starred_url":"https://api.github.com/users/harigowtham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harigowtham/subscriptions","organizations_url":"https://api.github.com/users/harigowtham/orgs","repos_url":"https://api.github.com/users/harigowtham/repos","events_url":"https://api.github.com/users/harigowtham/events{/privacy}","received_events_url":"https://api.github.com/users/harigowtham/received_events","type":"User","site_admin":false},"body":"disable quota daemon from api.\r\ncli yet to be worked on.\r\n\r\nUpdates: #421\r\nSigned-off-by: Hari Gowtham <hgowtham@redhat.com>","created_at":"2018-03-23T05:00:28Z","updated_at":"2018-06-27T15:09:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285680b8e3c61a0bac4b86b76da2592c6c78700a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kshlm","id":362086,"node_id":"MDQ6VXNlcjM2MjA4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/362086?v=4","gravatar_id":"","url":"https://api.github.com/users/kshlm","html_url":"https://github.com/kshlm","followers_url":"https://api.github.com/users/kshlm/followers","following_url":"https://api.github.com/users/kshlm/following{/other_user}","gists_url":"https://api.github.com/users/kshlm/gists{/gist_id}","starred_url":"https://api.github.com/users/kshlm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshlm/subscriptions","organizations_url":"https://api.github.com/users/kshlm/orgs","repos_url":"https://api.github.com/users/kshlm/repos","events_url":"https://api.github.com/users/kshlm/events{/privacy}","received_events_url":"https://api.github.com/users/kshlm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/glusterd2/pulls/615/commits","review_comments_url":"https://api.github.com/repos/gluster/glusterd2/pulls/615/comments","review_comment_url":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/glusterd2/issues/615/comments","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/86e9950eb4b98836bcc6719ac8e8b57ad9a0361b","head":{"label":"harigowtham:quota_disable","ref":"quota_disable","sha":"86e9950eb4b98836bcc6719ac8e8b57ad9a0361b","user":{"login":"harigowtham","id":11406648,"node_id":"MDQ6VXNlcjExNDA2NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/11406648?v=4","gravatar_id":"","url":"https://api.github.com/users/harigowtham","html_url":"https://github.com/harigowtham","followers_url":"https://api.github.com/users/harigowtham/followers","following_url":"https://api.github.com/users/harigowtham/following{/other_user}","gists_url":"https://api.github.com/users/harigowtham/gists{/gist_id}","starred_url":"https://api.github.com/users/harigowtham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harigowtham/subscriptions","organizations_url":"https://api.github.com/users/harigowtham/orgs","repos_url":"https://api.github.com/users/harigowtham/repos","events_url":"https://api.github.com/users/harigowtham/events{/privacy}","received_events_url":"https://api.github.com/users/harigowtham/received_events","type":"User","site_admin":false},"repo":{"id":102003268,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwMDMyNjg=","name":"glusterd2","full_name":"harigowtham/glusterd2","owner":{"login":"harigowtham","id":11406648,"node_id":"MDQ6VXNlcjExNDA2NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/11406648?v=4","gravatar_id":"","url":"https://api.github.com/users/harigowtham","html_url":"https://github.com/harigowtham","followers_url":"https://api.github.com/users/harigowtham/followers","following_url":"https://api.github.com/users/harigowtham/following{/other_user}","gists_url":"https://api.github.com/users/harigowtham/gists{/gist_id}","starred_url":"https://api.github.com/users/harigowtham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harigowtham/subscriptions","organizations_url":"https://api.github.com/users/harigowtham/orgs","repos_url":"https://api.github.com/users/harigowtham/repos","events_url":"https://api.github.com/users/harigowtham/events{/privacy}","received_events_url":"https://api.github.com/users/harigowtham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harigowtham/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":true,"url":"https://api.github.com/repos/harigowtham/glusterd2","forks_url":"https://api.github.com/repos/harigowtham/glusterd2/forks","keys_url":"https://api.github.com/repos/harigowtham/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harigowtham/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harigowtham/glusterd2/teams","hooks_url":"https://api.github.com/repos/harigowtham/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/harigowtham/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/harigowtham/glusterd2/events","assignees_url":"https://api.github.com/repos/harigowtham/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/harigowtham/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/harigowtham/glusterd2/tags","blobs_url":"https://api.github.com/repos/harigowtham/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harigowtham/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harigowtham/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/harigowtham/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harigowtham/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/harigowtham/glusterd2/languages","stargazers_url":"https://api.github.com/repos/harigowtham/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/harigowtham/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/harigowtham/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/harigowtham/glusterd2/subscription","commits_url":"https://api.github.com/repos/harigowtham/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/harigowtham/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/harigowtham/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/harigowtham/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/harigowtham/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/harigowtham/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harigowtham/glusterd2/merges","archive_url":"https://api.github.com/repos/harigowtham/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harigowtham/glusterd2/downloads","issues_url":"https://api.github.com/repos/harigowtham/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/harigowtham/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/harigowtham/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/harigowtham/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harigowtham/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/harigowtham/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/harigowtham/glusterd2/deployments","created_at":"2017-08-31T13:25:28Z","updated_at":"2017-08-31T13:25:29Z","pushed_at":"2018-06-26T17:09:08Z","git_url":"git://github.com/harigowtham/glusterd2.git","ssh_url":"git@github.com:harigowtham/glusterd2.git","clone_url":"https://github.com/harigowtham/glusterd2.git","svn_url":"https://github.com/harigowtham/glusterd2","homepage":"","size":12591,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"5ecd2b669d51962cc0f8f9fa89140170d64888f9","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24369600,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM2OTYwMA==","name":"glusterd2","full_name":"gluster/glusterd2","owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/glusterd2","description":"GlusterD-2.0 is the distributed management framework to be used for GlusterFS-4.0","fork":false,"url":"https://api.github.com/repos/gluster/glusterd2","forks_url":"https://api.github.com/repos/gluster/glusterd2/forks","keys_url":"https://api.github.com/repos/gluster/glusterd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/glusterd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/glusterd2/teams","hooks_url":"https://api.github.com/repos/gluster/glusterd2/hooks","issue_events_url":"https://api.github.com/repos/gluster/glusterd2/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/glusterd2/events","assignees_url":"https://api.github.com/repos/gluster/glusterd2/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/glusterd2/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/glusterd2/tags","blobs_url":"https://api.github.com/repos/gluster/glusterd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/glusterd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/glusterd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/glusterd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/glusterd2/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/glusterd2/languages","stargazers_url":"https://api.github.com/repos/gluster/glusterd2/stargazers","contributors_url":"https://api.github.com/repos/gluster/glusterd2/contributors","subscribers_url":"https://api.github.com/repos/gluster/glusterd2/subscribers","subscription_url":"https://api.github.com/repos/gluster/glusterd2/subscription","commits_url":"https://api.github.com/repos/gluster/glusterd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/glusterd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/glusterd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/glusterd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/glusterd2/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/glusterd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/glusterd2/merges","archive_url":"https://api.github.com/repos/gluster/glusterd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/glusterd2/downloads","issues_url":"https://api.github.com/repos/gluster/glusterd2/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/glusterd2/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/glusterd2/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/glusterd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/glusterd2/labels{/name}","releases_url":"https://api.github.com/repos/gluster/glusterd2/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/glusterd2/deployments","created_at":"2014-09-23T12:02:13Z","updated_at":"2018-06-27T13:24:26Z","pushed_at":"2018-06-27T12:34:01Z","git_url":"git://github.com/gluster/glusterd2.git","ssh_url":"git@github.com:gluster/glusterd2.git","clone_url":"https://github.com/gluster/glusterd2.git","svn_url":"https://github.com/gluster/glusterd2","homepage":"","size":12619,"stargazers_count":93,"watchers_count":93,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":144,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/615"},"html":{"href":"https://github.com/gluster/glusterd2/pull/615"},"issue":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/615"},"comments":{"href":"https://api.github.com/repos/gluster/glusterd2/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/glusterd2/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/glusterd2/statuses/86e9950eb4b98836bcc6719ac8e8b57ad9a0361b"}},"author_association":"MEMBER"}} | {
"id": 24369600,
"name": "gluster/glusterd2",
"url": "https://api.github.com/repos/gluster/glusterd2"
} | {
"id": 11406648,
"login": "harigowtham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11406648?",
"url": "https://api.github.com/users/harigowtham"
} | {
"id": 622644,
"login": "gluster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/622644?",
"url": "https://api.github.com/orgs/gluster"
} | 2018-06-27T15:09:03 | 7886402181 | {"actor":{"display_login":"harigowtham"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/comments/188103584","pull_request_review_id":120016048,"id":188103584,"diff_hunk":"@@ -0,0 +1,200 @@\n+# Gluster Operator 1.0 Design\n+\n+## Introduction\n+\n+This document specifies the overall design for a Gluster operator. An operator\n+is a Kubernetes [controller](https://github.com/kubernetes/sample-controller)\n+that is focused on managing a specific application with the goal of automating\n+common tasks that an administrator would typically perform.\n+\n+This document is a formalization of many hours of discussion by several people.\n+Credit and thanks to Humble Devassy Chirammal (@humblec),Steve Watt\n+(@wattsteve), and John Strunk (@JohnStrunk) for their early and insightful\n+contributions to the discussions.\n+\n+This document aims to settle on a concrete set of functionality that a Gluster\n+operator should have. It is outside the scope of this document to specify any\n+implementation details of this functionality. The desired functionality should\n+not be strictly limited by the extents of current-day technologies but should\n+not dismiss the costs of waiting for and executing forward development in those\n+technologies.\n+\n+In addition, this document only specifies the desired functionality for\n+declaring a 1.0 release. Further enhancements and feature roadmaps will be\n+captured elsewhere.\n+\n+### Motivation\n+\n+The Gluster operator aims to further streamline the experience of deploying and\n+maintaining Gluster clusters for use in a Kubernetes environment. It will\n+achieve this through the use of common Kubernetes components and paradigms,\n+helping further integrate persistent storage into the Kubernetes experience.\n+\n+## Configurations\n+\n+The Gluster operator will be capable of managing a number of configurations of\n+Gluster clusters. Gluster's flexibility allows it to run in many typs of","path":"docs/design/operator.md","position":36,"original_position":36,"commit_id":"50d7b7c2766691ce959aa6e3ad18357e9a4d7c4d","original_commit_id":"50d7b7c2766691ce959aa6e3ad18357e9a4d7c4d","user":{"login":"phlogistonjohn","id":33039589,"avatar_url":"https://avatars0.githubusercontent.com/u/33039589?v=4","gravatar_id":"","url":"https://api.github.com/users/phlogistonjohn","html_url":"https://github.com/phlogistonjohn","followers_url":"https://api.github.com/users/phlogistonjohn/followers","following_url":"https://api.github.com/users/phlogistonjohn/following{/other_user}","gists_url":"https://api.github.com/users/phlogistonjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/phlogistonjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phlogistonjohn/subscriptions","organizations_url":"https://api.github.com/users/phlogistonjohn/orgs","repos_url":"https://api.github.com/users/phlogistonjohn/repos","events_url":"https://api.github.com/users/phlogistonjohn/events{/privacy}","received_events_url":"https://api.github.com/users/phlogistonjohn/received_events","type":"User","site_admin":false},"body":"Minor typo","created_at":"2018-05-14T21:25:30Z","updated_at":"2018-05-14T21:31:35Z","html_url":"https://github.com/gluster/gluster-kubernetes/pull/476#discussion_r188103584","pull_request_url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/comments/188103584"},"html":{"href":"https://github.com/gluster/gluster-kubernetes/pull/476#discussion_r188103584"},"pull_request":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476"}}},"pull_request":{"url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476","id":187684930,"html_url":"https://github.com/gluster/gluster-kubernetes/pull/476","diff_url":"https://github.com/gluster/gluster-kubernetes/pull/476.diff","patch_url":"https://github.com/gluster/gluster-kubernetes/pull/476.patch","issue_url":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/476","number":476,"state":"open","locked":false,"title":"Gluster Operator Design","user":{"login":"jarrpa","id":1234462,"avatar_url":"https://avatars3.githubusercontent.com/u/1234462?v=4","gravatar_id":"","url":"https://api.github.com/users/jarrpa","html_url":"https://github.com/jarrpa","followers_url":"https://api.github.com/users/jarrpa/followers","following_url":"https://api.github.com/users/jarrpa/following{/other_user}","gists_url":"https://api.github.com/users/jarrpa/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrpa/subscriptions","organizations_url":"https://api.github.com/users/jarrpa/orgs","repos_url":"https://api.github.com/users/jarrpa/repos","events_url":"https://api.github.com/users/jarrpa/events{/privacy}","received_events_url":"https://api.github.com/users/jarrpa/received_events","type":"User","site_admin":false},"body":"A design doc to hopefully get some traction on the development of a Gluster operator. From the introduction:\r\n\r\n```\r\nThis document aims to settle on a concrete set of functionality that a Gluster\r\noperator should have. It is outside the scope of this document to specify any\r\nimplementation details of this functionality. The desired functionality should\r\nnot be strictly limited by the extents of current-day technologies but should\r\nnot dismiss the costs of waiting for and executing forward development in those\r\ntechnologies.\r\n\r\nIn addition, this document only specifies the desired functionality for\r\ndeclaring a 1.0 release. Further enhancements and feature roadmaps will be\r\ncaptured elsewhere.\r\n```\r\n\r\nSigned-off-by: Jose A. Rivera <jarrpa@redhat.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/gluster/gluster-kubernetes/476)\n<!-- Reviewable:end -->\n","created_at":"2018-05-13T19:00:00Z","updated_at":"2018-05-14T21:31:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c940ca3bc6d94e42f80f73e49652d7a1dd4a30f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476/commits","review_comments_url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476/comments","review_comment_url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/476/comments","statuses_url":"https://api.github.com/repos/gluster/gluster-kubernetes/statuses/50d7b7c2766691ce959aa6e3ad18357e9a4d7c4d","head":{"label":"jarrpa:operator-design","ref":"operator-design","sha":"50d7b7c2766691ce959aa6e3ad18357e9a4d7c4d","user":{"login":"jarrpa","id":1234462,"avatar_url":"https://avatars3.githubusercontent.com/u/1234462?v=4","gravatar_id":"","url":"https://api.github.com/users/jarrpa","html_url":"https://github.com/jarrpa","followers_url":"https://api.github.com/users/jarrpa/followers","following_url":"https://api.github.com/users/jarrpa/following{/other_user}","gists_url":"https://api.github.com/users/jarrpa/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrpa/subscriptions","organizations_url":"https://api.github.com/users/jarrpa/orgs","repos_url":"https://api.github.com/users/jarrpa/repos","events_url":"https://api.github.com/users/jarrpa/events{/privacy}","received_events_url":"https://api.github.com/users/jarrpa/received_events","type":"User","site_admin":false},"repo":{"id":73317772,"name":"gluster-kubernetes","full_name":"jarrpa/gluster-kubernetes","owner":{"login":"jarrpa","id":1234462,"avatar_url":"https://avatars3.githubusercontent.com/u/1234462?v=4","gravatar_id":"","url":"https://api.github.com/users/jarrpa","html_url":"https://github.com/jarrpa","followers_url":"https://api.github.com/users/jarrpa/followers","following_url":"https://api.github.com/users/jarrpa/following{/other_user}","gists_url":"https://api.github.com/users/jarrpa/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrpa/subscriptions","organizations_url":"https://api.github.com/users/jarrpa/orgs","repos_url":"https://api.github.com/users/jarrpa/repos","events_url":"https://api.github.com/users/jarrpa/events{/privacy}","received_events_url":"https://api.github.com/users/jarrpa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarrpa/gluster-kubernetes","description":"persistent storage for kubernetes with gluster","fork":true,"url":"https://api.github.com/repos/jarrpa/gluster-kubernetes","forks_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/forks","keys_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/teams","hooks_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/events","assignees_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/tags","blobs_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/languages","stargazers_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/subscription","commits_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/merges","archive_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/downloads","issues_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jarrpa/gluster-kubernetes/deployments","created_at":"2016-11-09T20:14:02Z","updated_at":"2017-09-01T15:01:13Z","pushed_at":"2018-05-13T18:57:28Z","git_url":"git://github.com/jarrpa/gluster-kubernetes.git","ssh_url":"git@github.com:jarrpa/gluster-kubernetes.git","clone_url":"https://github.com/jarrpa/gluster-kubernetes.git","svn_url":"https://github.com/jarrpa/gluster-kubernetes","homepage":"","size":1141,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"2a2a68ce5739524802a38f3871c545e4f57fa20a","user":{"login":"gluster","id":622644,"avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":71491935,"name":"gluster-kubernetes","full_name":"gluster/gluster-kubernetes","owner":{"login":"gluster","id":622644,"avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/gluster-kubernetes","description":"GlusterFS Native Storage Service for Kubernetes","fork":false,"url":"https://api.github.com/repos/gluster/gluster-kubernetes","forks_url":"https://api.github.com/repos/gluster/gluster-kubernetes/forks","keys_url":"https://api.github.com/repos/gluster/gluster-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/gluster-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/gluster-kubernetes/teams","hooks_url":"https://api.github.com/repos/gluster/gluster-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/gluster-kubernetes/events","assignees_url":"https://api.github.com/repos/gluster/gluster-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/gluster-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/gluster-kubernetes/tags","blobs_url":"https://api.github.com/repos/gluster/gluster-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/gluster-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/gluster-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/gluster-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/gluster-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/gluster-kubernetes/languages","stargazers_url":"https://api.github.com/repos/gluster/gluster-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gluster/gluster-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gluster/gluster-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gluster/gluster-kubernetes/subscription","commits_url":"https://api.github.com/repos/gluster/gluster-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/gluster-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/gluster-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/gluster-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/gluster-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/gluster-kubernetes/merges","archive_url":"https://api.github.com/repos/gluster/gluster-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/gluster-kubernetes/downloads","issues_url":"https://api.github.com/repos/gluster/gluster-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/gluster-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/gluster-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/gluster-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gluster/gluster-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/gluster-kubernetes/deployments","created_at":"2016-10-20T18:25:14Z","updated_at":"2018-05-14T07:38:18Z","pushed_at":"2018-05-13T19:00:06Z","git_url":"git://github.com/gluster/gluster-kubernetes.git","ssh_url":"git@github.com:gluster/gluster-kubernetes.git","clone_url":"https://github.com/gluster/gluster-kubernetes.git","svn_url":"https://github.com/gluster/gluster-kubernetes","homepage":"","size":1324,"stargazers_count":338,"watchers_count":338,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":143,"open_issues":64,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476"},"html":{"href":"https://github.com/gluster/gluster-kubernetes/pull/476"},"issue":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/476"},"comments":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/gluster-kubernetes/statuses/50d7b7c2766691ce959aa6e3ad18357e9a4d7c4d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 71491935,
"name": "gluster/gluster-kubernetes",
"url": "https://api.github.com/repos/gluster/gluster-kubernetes"
} | {
"id": 33039589,
"login": "phlogistonjohn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33039589?",
"url": "https://api.github.com/users/phlogistonjohn"
} | {
"id": 622644,
"login": "gluster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/622644?",
"url": "https://api.github.com/orgs/gluster"
} | 2018-05-14T21:25:30 | 7673268732 | {"actor":{"display_login":"phlogistonjohn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments/219889454","pull_request_review_id":158171833,"id":219889454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTg4OTQ1NA==","diff_hunk":"@@ -0,0 +1,458 @@\n+// [WriteFile Name=GenerateOfflineMap, Category=Maps]\n+// [Legal]\n+// Copyright 2017 Esri.\n+\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+// http://www.apache.org/licenses/LICENSE-2.0\n+\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+// [Legal]\n+\n+#include \"GenerateOfflineMap_Overrides.h\"\n+\n+#include \"FeatureLayer.h\"\n+#include \"Map.h\"\n+#include \"MapQuickView.h\"\n+#include \"AuthenticationManager.h\"\n+#include \"Portal.h\"\n+#include \"PortalItem.h\"\n+#include \"OfflineMapTask.h\"\n+#include \"GeometryEngine.h\"\n+#include \"Envelope.h\"\n+#include \"Point.h\"\n+\n+using namespace Esri::ArcGISRuntime;\n+\n+const QString GenerateOfflineMap_Overrides::s_webMapId = QStringLiteral(\"acc027394bc84c2fb04d1ed317aac674\");\n+\n+GenerateOfflineMap_Overrides::GenerateOfflineMap_Overrides(QQuickItem* parent /* = nullptr */):\n+ QQuickItem(parent)\n+{\n+}\n+\n+void GenerateOfflineMap_Overrides::init()\n+{\n+ // Register the map view for QML\n+ qmlRegisterType<MapQuickView>(\"Esri.Samples\", 1, 0, \"MapView\");\n+ qmlRegisterType<GenerateOfflineMap_Overrides>(\"Esri.Samples\", 1, 0, \"GenerateOfflineMap_OverridesSample\");\n+ qmlRegisterUncreatableType<AuthenticationManager>(\"Esri.Samples\", 1, 0, \"AuthenticationManager\", \"AuthenticationManager is uncreateable\");\n+}\n+\n+void GenerateOfflineMap_Overrides::componentComplete()\n+{\n+ QQuickItem::componentComplete();\n+\n+ // find QML MapView component\n+ m_mapView = findChild<MapQuickView*>(\"mapView\");\n+\n+ // Create a Portal Item for use by the Map and OfflineMapTask\n+ bool loginRequired = true;\n+ Portal* portal = new Portal(loginRequired, this);\n+ m_portalItem = new PortalItem(portal, webMapId(), this);\n+\n+ // Create a map from the Portal Item\n+ m_map = new Map(m_portalItem, this);\n+\n+ // Update property once map is done loading\n+ connect(m_map, &Map::doneLoading, this, [this](Error e)\n+ {\n+ if (!e.isEmpty())\n+ return;\n+\n+ m_mapLoaded = true;\n+ emit mapLoadedChanged();\n+ });\n+\n+ // Set map to map view\n+ m_mapView->setMap(m_map);\n+\n+ // Create the OfflineMapTask with the PortalItem\n+ m_offlineMapTask = new OfflineMapTask(m_portalItem, this);\n+\n+ // connect to the error signal\n+ connect(m_offlineMapTask, &OfflineMapTask::errorOccurred, this, [](Error e)\n+ {\n+ if (e.isEmpty())\n+ return;\n+\n+ qDebug() << e.message() << e.additionalMessage();\n+ });","path":"ArcGISRuntimeSDKQt_CppSamples/Maps/GenerateOfflineMap_Overrides/GenerateOfflineMap_Overrides.cpp","position":90,"original_position":85,"commit_id":"c2012a8911f552bbc4daca6ffba91ac8c1078240","original_commit_id":"db80b355cb18589dc9cb17a81de1b2546c7fb90b","user":{"login":"michael-tims","id":5607251,"node_id":"MDQ6VXNlcjU2MDcyNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5607251?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-tims","html_url":"https://github.com/michael-tims","followers_url":"https://api.github.com/users/michael-tims/followers","following_url":"https://api.github.com/users/michael-tims/following{/other_user}","gists_url":"https://api.github.com/users/michael-tims/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-tims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-tims/subscriptions","organizations_url":"https://api.github.com/users/michael-tims/orgs","repos_url":"https://api.github.com/users/michael-tims/repos","events_url":"https://api.github.com/users/michael-tims/events{/privacy}","received_events_url":"https://api.github.com/users/michael-tims/received_events","type":"User","site_admin":false},"body":"Yeah, I was thinking the same thing after I commented on these.\r\n@ldanzinger what do you think? Do we have these print statements for errors connected up in other samples, or are there any guidelines for doing so?\r\n\r\nAlthough we don't necessarily print any of these errors to the UI, it could be handy for a developer who is copying code out of the sample to begin their own app.","created_at":"2018-09-24T15:51:14Z","updated_at":"2018-09-24T15:51:15Z","html_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770#discussion_r219889454","pull_request_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments/219889454"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770#discussion_r219889454"},"pull_request":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770"}},"in_reply_to_id":219864704},"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770","id":217657023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjU3MDIz","html_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770","diff_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770.diff","patch_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/770","number":770,"state":"open","locked":false,"title":"Neil/offlinemap overrides","user":{"login":"anmacdonald","id":42203545,"node_id":"MDQ6VXNlcjQyMjAzNTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/42203545?v=4","gravatar_id":"","url":"https://api.github.com/users/anmacdonald","html_url":"https://github.com/anmacdonald","followers_url":"https://api.github.com/users/anmacdonald/followers","following_url":"https://api.github.com/users/anmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/anmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/anmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmacdonald/subscriptions","organizations_url":"https://api.github.com/users/anmacdonald/orgs","repos_url":"https://api.github.com/users/anmacdonald/repos","events_url":"https://api.github.com/users/anmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/anmacdonald/received_events","type":"User","site_admin":false},"body":"Create a new sample for the GenerateOffllineMapParametersOverrides feature. QML and CPP included.\r\n\r\nThis sample mostly follows the choices / workflow of the current Generate Offline Map sample, but with the addition of an overrides window and an overrides member object that can be manipulated via the overrides window.","created_at":"2018-09-24T13:30:06Z","updated_at":"2018-09-24T15:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad7b224798026d4e6258347cbfc5bb48aabb338d","assignee":{"login":"lsmallwood","id":19823035,"node_id":"MDQ6VXNlcjE5ODIzMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false},"assignees":[{"login":"lsmallwood","id":19823035,"node_id":"MDQ6VXNlcjE5ODIzMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ldanzinger","id":4107363,"node_id":"MDQ6VXNlcjQxMDczNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4107363?v=4","gravatar_id":"","url":"https://api.github.com/users/ldanzinger","html_url":"https://github.com/ldanzinger","followers_url":"https://api.github.com/users/ldanzinger/followers","following_url":"https://api.github.com/users/ldanzinger/following{/other_user}","gists_url":"https://api.github.com/users/ldanzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ldanzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldanzinger/subscriptions","organizations_url":"https://api.github.com/users/ldanzinger/orgs","repos_url":"https://api.github.com/users/ldanzinger/repos","events_url":"https://api.github.com/users/ldanzinger/events{/privacy}","received_events_url":"https://api.github.com/users/ldanzinger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/770/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/c2012a8911f552bbc4daca6ffba91ac8c1078240","head":{"label":"Esri:neil/offlinemap_overrides","ref":"neil/offlinemap_overrides","sha":"c2012a8911f552bbc4daca6ffba91ac8c1078240","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":33001079,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAwMTA3OQ==","name":"arcgis-runtime-samples-qt","full_name":"Esri/arcgis-runtime-samples-qt","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/arcgis-runtime-samples-qt","description":"ArcGIS Runtime SDK for Qt samples for Qt Creator. ","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/deployments","created_at":"2015-03-27T17:55:54Z","updated_at":"2018-09-15T16:12:26Z","pushed_at":"2018-09-24T15:42:29Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-qt","homepage":"","size":146167,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":1,"watchers":37,"default_branch":"master"}},"base":{"label":"Esri:v.next","ref":"v.next","sha":"d8e48b59ef1dd4ec1c3c2d60cc40e634b804fdbf","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":33001079,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAwMTA3OQ==","name":"arcgis-runtime-samples-qt","full_name":"Esri/arcgis-runtime-samples-qt","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/arcgis-runtime-samples-qt","description":"ArcGIS Runtime SDK for Qt samples for Qt Creator. ","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/deployments","created_at":"2015-03-27T17:55:54Z","updated_at":"2018-09-15T16:12:26Z","pushed_at":"2018-09-24T15:42:29Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-qt","homepage":"","size":146167,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":1,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/770"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/770"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/770/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/770/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/c2012a8911f552bbc4daca6ffba91ac8c1078240"}},"author_association":"NONE"}} | {
"id": 33001079,
"name": "Esri/arcgis-runtime-samples-qt",
"url": "https://api.github.com/repos/Esri/arcgis-runtime-samples-qt"
} | {
"id": 5607251,
"login": "michael-tims",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5607251?",
"url": "https://api.github.com/users/michael-tims"
} | {
"id": 628795,
"login": "Esri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/628795?",
"url": "https://api.github.com/orgs/Esri"
} | 2018-09-24T15:51:14 | 8312183231 | {"actor":{"display_login":"michael-tims"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/237821372","pull_request_review_id":180211853,"id":237821372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgyMTM3Mg==","diff_hunk":"@@ -691,7 +864,91 @@ class FitPeaksTest : public CxxTest::TestSuite {\n }\n \n //--------------------------------------------------------------------------------------------------------------\n- /** create basic testing data set containing some Gaussian peaks\n+ /** generate a peak center workspace compatible to the workspace created by\n+ * createTestData(), which will 3 spectra and at most 2 elements for each\n+ * sepctrum\n+ * @brief genPeakCenterWorkspace\n+ * @param peak_index_vec :: a vector of integer as 0 or 1. 0 for peak center\n+ * @param workspace_name\n+ * @return\n+ */\n+ std::string genPeakCenterWorkspace(const std::vector<int> &peak_index_vec,\n+ const std::string &workspace_name) {\n+ // create the empty workspace containing N X values for N peaks (N <=2)\n+ size_t num_peaks = peak_index_vec.size();\n+ int64_t nbins = num_peaks;\n+ // fixed to 2 spectrum\n+ int64_t nhist = 3;\n+ // point data\n+ bool ishist = false;\n+ double xval(0), yval(0), eval(0), dxval(1);\n+ std::set<int64_t> maskedws;\n+ MatrixWorkspace_sptr center_ws =\n+ boost::dynamic_pointer_cast<MatrixWorkspace>(\n+ WorkspaceCreationHelper::create2DWorkspaceWithValuesAndXerror(\n+ nhist, nbins, ishist, xval, yval, eval, dxval, maskedws));\n+\n+ std::cout << \"Center workspace has \" << center_ws->readX(0).size()\n+ << \" bins\"\n+ << \"\\n\";\n+ for (size_t i = 0; i < center_ws->getNumberHistograms(); ++i) {\n+ for (size_t j = 0; j < peak_index_vec.size(); ++j) {\n+ int peak_index = peak_index_vec[j];","path":"Framework/Algorithms/test/FitPeaksTest.h","position":221,"original_position":221,"commit_id":"a1249c885a200aa7947ed97684067b42ba98e8cf","original_commit_id":"a1249c885a200aa7947ed97684067b42ba98e8cf","user":{"login":"soininen","id":19147159,"node_id":"MDQ6VXNlcjE5MTQ3MTU5","avatar_url":"https://avatars3.githubusercontent.com/u/19147159?v=4","gravatar_id":"","url":"https://api.github.com/users/soininen","html_url":"https://github.com/soininen","followers_url":"https://api.github.com/users/soininen/followers","following_url":"https://api.github.com/users/soininen/following{/other_user}","gists_url":"https://api.github.com/users/soininen/gists{/gist_id}","starred_url":"https://api.github.com/users/soininen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soininen/subscriptions","organizations_url":"https://api.github.com/users/soininen/orgs","repos_url":"https://api.github.com/users/soininen/repos","events_url":"https://api.github.com/users/soininen/events{/privacy}","received_events_url":"https://api.github.com/users/soininen/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n const int peak_index = peak_index_vec[j];\r\n```","created_at":"2018-11-30T10:55:38Z","updated_at":"2018-11-30T10:56:40Z","html_url":"https://github.com/mantidproject/mantid/pull/22865#discussion_r237821372","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22865","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/237821372"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22865#discussion_r237821372"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22865"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22865","id":200573269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTczMjY5","html_url":"https://github.com/mantidproject/mantid/pull/22865","diff_url":"https://github.com/mantidproject/mantid/pull/22865.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22865.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22865","number":22865,"state":"open","locked":false,"title":"Allow user to specify max iterations and make partial spectra fitting more flexible.","user":{"login":"wdzhou","id":1129043,"node_id":"MDQ6VXNlcjExMjkwNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1129043?v=4","gravatar_id":"","url":"https://api.github.com/users/wdzhou","html_url":"https://github.com/wdzhou","followers_url":"https://api.github.com/users/wdzhou/followers","following_url":"https://api.github.com/users/wdzhou/following{/other_user}","gists_url":"https://api.github.com/users/wdzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/wdzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdzhou/subscriptions","organizations_url":"https://api.github.com/users/wdzhou/orgs","repos_url":"https://api.github.com/users/wdzhou/repos","events_url":"https://api.github.com/users/wdzhou/events{/privacy}","received_events_url":"https://api.github.com/users/wdzhou/received_events","type":"User","site_admin":false},"body":"**Description of work.**\r\n\r\nThere are two major improvements for FitPeaks.\r\n\r\n1. An optional output TableWorkspace is added for showing fit function parameters' uncertainties.\r\n2. Both output TableWorksapces, for parameters and uncertainties, will have same number of rows as the number the spectra to fit.\r\n\r\n**To test:**\r\n\r\n1. Check new unit tests\r\n2. Run FitPeaks on a multiple spectra workspace to fit peaks in a part of spectra. Check both of the output TableWorkspace for fitted parameter value and uncertainties.\r\n\r\nFixes #22860.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-07-11T02:49:30Z","updated_at":"2018-11-30T10:56:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ae0332f5acffdfa3c88414e3e361430458f9434","assignee":{"login":"wdzhou","id":1129043,"node_id":"MDQ6VXNlcjExMjkwNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1129043?v=4","gravatar_id":"","url":"https://api.github.com/users/wdzhou","html_url":"https://github.com/wdzhou","followers_url":"https://api.github.com/users/wdzhou/followers","following_url":"https://api.github.com/users/wdzhou/following{/other_user}","gists_url":"https://api.github.com/users/wdzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/wdzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdzhou/subscriptions","organizations_url":"https://api.github.com/users/wdzhou/orgs","repos_url":"https://api.github.com/users/wdzhou/repos","events_url":"https://api.github.com/users/wdzhou/events{/privacy}","received_events_url":"https://api.github.com/users/wdzhou/received_events","type":"User","site_admin":false},"assignees":[{"login":"wdzhou","id":1129043,"node_id":"MDQ6VXNlcjExMjkwNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1129043?v=4","gravatar_id":"","url":"https://api.github.com/users/wdzhou","html_url":"https://github.com/wdzhou","followers_url":"https://api.github.com/users/wdzhou/followers","following_url":"https://api.github.com/users/wdzhou/following{/other_user}","gists_url":"https://api.github.com/users/wdzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/wdzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdzhou/subscriptions","organizations_url":"https://api.github.com/users/wdzhou/orgs","repos_url":"https://api.github.com/users/wdzhou/repos","events_url":"https://api.github.com/users/wdzhou/events{/privacy}","received_events_url":"https://api.github.com/users/wdzhou/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":178354911,"node_id":"MDU6TGFiZWwxNzgzNTQ5MTE=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Fitting","name":"Component: Fitting","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/68","html_url":"https://github.com/mantidproject/mantid/milestone/68","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/68/labels","id":3113735,"node_id":"MDk6TWlsZXN0b25lMzExMzczNQ==","number":68,"title":"Release 3.14 (4.0?)","description":"Code freeze: 1st Mar\r\nBeta test: 6th - 19th Mar","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":307,"closed_issues":763,"state":"open","created_at":"2018-02-13T15:42:17Z","updated_at":"2018-11-30T10:20:30Z","due_on":"2019-03-25T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22865/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/22865/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22865/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/a1249c885a200aa7947ed97684067b42ba98e8cf","head":{"label":"mantidproject:fitpeaks_partial_spec_22860","ref":"fitpeaks_partial_spec_22860","sha":"a1249c885a200aa7947ed97684067b42ba98e8cf","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","private":false,"owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-11-30T10:20:49Z","pushed_at":"2018-11-30T10:52:57Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":523246,"stargazers_count":98,"watchers_count":98,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":1897,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":60,"open_issues":1897,"watchers":98,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"104971fa281b7d82f64c95e74094f071e0985087","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","private":false,"owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-11-30T10:20:49Z","pushed_at":"2018-11-30T10:52:57Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":523246,"stargazers_count":98,"watchers_count":98,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":1897,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":60,"open_issues":1897,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22865"},"html":{"href":"https://github.com/mantidproject/mantid/pull/22865"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22865"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/22865/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22865/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/22865/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/a1249c885a200aa7947ed97684067b42ba98e8cf"}},"author_association":"MEMBER"}} | {
"id": 2594116,
"name": "mantidproject/mantid",
"url": "https://api.github.com/repos/mantidproject/mantid"
} | {
"id": 19147159,
"login": "soininen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19147159?",
"url": "https://api.github.com/users/soininen"
} | {
"id": 671496,
"login": "mantidproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/671496?",
"url": "https://api.github.com/orgs/mantidproject"
} | 2018-11-30T10:55:38 | 8675459664 | {"actor":{"display_login":"soininen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/comments/197162435","pull_request_review_id":130852211,"id":197162435,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzE2MjQzNQ==","diff_hunk":"@@ -35,27 +34,31 @@ class FileInfotonTests extends AsyncFunSpec with Matchers with TryValues with He\n Json.parse(res.payload) should be(jsonSuccess)\n }\n }\n- val f1 = f0.flatMap(_ => scheduleFuture(indexingDuration)(Http.get(path))).map { res =>\n- withClue(res) {\n- new String(res.payload, \"UTF-8\") should be(fileStr)\n- res.contentType.takeWhile(_ != ';') should be(\"text/plain\")\n- }\n- }\n+ val f1 = f0.flatMap {_ => spinCheck(100.millis, true)(Http.get(path)){res =>\n+ new String(res.payload, \"UTF-8\").equals(fileStr) && res.contentType.takeWhile(_ != ';').equals(\"text/plain\")}","path":"server/cmwell-it/src/it/scala/cmwell/it/FileInfotonTests.scala","position":26,"original_position":26,"commit_id":"c8651076842b63cc7a776df51c2133f4d50ab983","original_commit_id":"c8651076842b63cc7a776df51c2133f4d50ab983","user":{"login":"e-orz","id":18255673,"node_id":"MDQ6VXNlcjE4MjU1Njcz","avatar_url":"https://avatars2.githubusercontent.com/u/18255673?v=4","gravatar_id":"","url":"https://api.github.com/users/e-orz","html_url":"https://github.com/e-orz","followers_url":"https://api.github.com/users/e-orz/followers","following_url":"https://api.github.com/users/e-orz/following{/other_user}","gists_url":"https://api.github.com/users/e-orz/gists{/gist_id}","starred_url":"https://api.github.com/users/e-orz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-orz/subscriptions","organizations_url":"https://api.github.com/users/e-orz/orgs","repos_url":"https://api.github.com/users/e-orz/repos","events_url":"https://api.github.com/users/e-orz/events{/privacy}","received_events_url":"https://api.github.com/users/e-orz/received_events","type":"User","site_admin":false},"body":"1. use StandardCharsets\r\n2. use `==` instead of equals","created_at":"2018-06-21T14:48:48Z","updated_at":"2018-06-21T14:50:27Z","html_url":"https://github.com/thomsonreuters/CM-Well/pull/756#discussion_r197162435","pull_request_url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/comments/197162435"},"html":{"href":"https://github.com/thomsonreuters/CM-Well/pull/756#discussion_r197162435"},"pull_request":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756"}}},"pull_request":{"url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756","id":195453963,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDUzOTYz","html_url":"https://github.com/thomsonreuters/CM-Well/pull/756","diff_url":"https://github.com/thomsonreuters/CM-Well/pull/756.diff","patch_url":"https://github.com/thomsonreuters/CM-Well/pull/756.patch","issue_url":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/756","number":756,"state":"open","locked":false,"title":"Decrease tests running time | FileInfotonTests","user":{"login":"MoriaYechiel","id":38179268,"node_id":"MDQ6VXNlcjM4MTc5MjY4","avatar_url":"https://avatars0.githubusercontent.com/u/38179268?v=4","gravatar_id":"","url":"https://api.github.com/users/MoriaYechiel","html_url":"https://github.com/MoriaYechiel","followers_url":"https://api.github.com/users/MoriaYechiel/followers","following_url":"https://api.github.com/users/MoriaYechiel/following{/other_user}","gists_url":"https://api.github.com/users/MoriaYechiel/gists{/gist_id}","starred_url":"https://api.github.com/users/MoriaYechiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoriaYechiel/subscriptions","organizations_url":"https://api.github.com/users/MoriaYechiel/orgs","repos_url":"https://api.github.com/users/MoriaYechiel/repos","events_url":"https://api.github.com/users/MoriaYechiel/events{/privacy}","received_events_url":"https://api.github.com/users/MoriaYechiel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T08:33:17Z","updated_at":"2018-06-21T14:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b267e2c555800cf65aa80fc51dc038b088b572","assignee":{"login":"MoriaYechiel","id":38179268,"node_id":"MDQ6VXNlcjM4MTc5MjY4","avatar_url":"https://avatars0.githubusercontent.com/u/38179268?v=4","gravatar_id":"","url":"https://api.github.com/users/MoriaYechiel","html_url":"https://github.com/MoriaYechiel","followers_url":"https://api.github.com/users/MoriaYechiel/followers","following_url":"https://api.github.com/users/MoriaYechiel/following{/other_user}","gists_url":"https://api.github.com/users/MoriaYechiel/gists{/gist_id}","starred_url":"https://api.github.com/users/MoriaYechiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoriaYechiel/subscriptions","organizations_url":"https://api.github.com/users/MoriaYechiel/orgs","repos_url":"https://api.github.com/users/MoriaYechiel/repos","events_url":"https://api.github.com/users/MoriaYechiel/events{/privacy}","received_events_url":"https://api.github.com/users/MoriaYechiel/received_events","type":"User","site_admin":false},"assignees":[{"login":"MoriaYechiel","id":38179268,"node_id":"MDQ6VXNlcjM4MTc5MjY4","avatar_url":"https://avatars0.githubusercontent.com/u/38179268?v=4","gravatar_id":"","url":"https://api.github.com/users/MoriaYechiel","html_url":"https://github.com/MoriaYechiel","followers_url":"https://api.github.com/users/MoriaYechiel/followers","following_url":"https://api.github.com/users/MoriaYechiel/following{/other_user}","gists_url":"https://api.github.com/users/MoriaYechiel/gists{/gist_id}","starred_url":"https://api.github.com/users/MoriaYechiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoriaYechiel/subscriptions","organizations_url":"https://api.github.com/users/MoriaYechiel/orgs","repos_url":"https://api.github.com/users/MoriaYechiel/repos","events_url":"https://api.github.com/users/MoriaYechiel/events{/privacy}","received_events_url":"https://api.github.com/users/MoriaYechiel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756/commits","review_comments_url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756/comments","review_comment_url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/756/comments","statuses_url":"https://api.github.com/repos/thomsonreuters/CM-Well/statuses/c8651076842b63cc7a776df51c2133f4d50ab983","head":{"label":"MoriaYechiel:testTimeFileInfotonTests","ref":"testTimeFileInfotonTests","sha":"c8651076842b63cc7a776df51c2133f4d50ab983","user":{"login":"MoriaYechiel","id":38179268,"node_id":"MDQ6VXNlcjM4MTc5MjY4","avatar_url":"https://avatars0.githubusercontent.com/u/38179268?v=4","gravatar_id":"","url":"https://api.github.com/users/MoriaYechiel","html_url":"https://github.com/MoriaYechiel","followers_url":"https://api.github.com/users/MoriaYechiel/followers","following_url":"https://api.github.com/users/MoriaYechiel/following{/other_user}","gists_url":"https://api.github.com/users/MoriaYechiel/gists{/gist_id}","starred_url":"https://api.github.com/users/MoriaYechiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoriaYechiel/subscriptions","organizations_url":"https://api.github.com/users/MoriaYechiel/orgs","repos_url":"https://api.github.com/users/MoriaYechiel/repos","events_url":"https://api.github.com/users/MoriaYechiel/events{/privacy}","received_events_url":"https://api.github.com/users/MoriaYechiel/received_events","type":"User","site_admin":false},"repo":{"id":130562416,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1NjI0MTY=","name":"CM-Well","full_name":"MoriaYechiel/CM-Well","owner":{"login":"MoriaYechiel","id":38179268,"node_id":"MDQ6VXNlcjM4MTc5MjY4","avatar_url":"https://avatars0.githubusercontent.com/u/38179268?v=4","gravatar_id":"","url":"https://api.github.com/users/MoriaYechiel","html_url":"https://github.com/MoriaYechiel","followers_url":"https://api.github.com/users/MoriaYechiel/followers","following_url":"https://api.github.com/users/MoriaYechiel/following{/other_user}","gists_url":"https://api.github.com/users/MoriaYechiel/gists{/gist_id}","starred_url":"https://api.github.com/users/MoriaYechiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoriaYechiel/subscriptions","organizations_url":"https://api.github.com/users/MoriaYechiel/orgs","repos_url":"https://api.github.com/users/MoriaYechiel/repos","events_url":"https://api.github.com/users/MoriaYechiel/events{/privacy}","received_events_url":"https://api.github.com/users/MoriaYechiel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoriaYechiel/CM-Well","description":"CM-Well - a data warehouse for your knowledge graph","fork":true,"url":"https://api.github.com/repos/MoriaYechiel/CM-Well","forks_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/forks","keys_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/teams","hooks_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/hooks","issue_events_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/issues/events{/number}","events_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/events","assignees_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/assignees{/user}","branches_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/branches{/branch}","tags_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/tags","blobs_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/statuses/{sha}","languages_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/languages","stargazers_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/stargazers","contributors_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/contributors","subscribers_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/subscribers","subscription_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/subscription","commits_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/contents/{+path}","compare_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/merges","archive_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/downloads","issues_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/issues{/number}","pulls_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/pulls{/number}","milestones_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/milestones{/number}","notifications_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/labels{/name}","releases_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/releases{/id}","deployments_url":"https://api.github.com/repos/MoriaYechiel/CM-Well/deployments","created_at":"2018-04-22T11:49:35Z","updated_at":"2018-05-13T14:39:10Z","pushed_at":"2018-06-19T18:56:35Z","git_url":"git://github.com/MoriaYechiel/CM-Well.git","ssh_url":"git@github.com:MoriaYechiel/CM-Well.git","clone_url":"https://github.com/MoriaYechiel/CM-Well.git","svn_url":"https://github.com/MoriaYechiel/CM-Well","homepage":"","size":16319,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thomsonreuters:master","ref":"master","sha":"6d5f21c3d0a8acfd923d1e6e35e80c893a56491f","user":{"login":"thomsonreuters","id":686958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4Njk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/686958?v=4","gravatar_id":"","url":"https://api.github.com/users/thomsonreuters","html_url":"https://github.com/thomsonreuters","followers_url":"https://api.github.com/users/thomsonreuters/followers","following_url":"https://api.github.com/users/thomsonreuters/following{/other_user}","gists_url":"https://api.github.com/users/thomsonreuters/gists{/gist_id}","starred_url":"https://api.github.com/users/thomsonreuters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomsonreuters/subscriptions","organizations_url":"https://api.github.com/users/thomsonreuters/orgs","repos_url":"https://api.github.com/users/thomsonreuters/repos","events_url":"https://api.github.com/users/thomsonreuters/events{/privacy}","received_events_url":"https://api.github.com/users/thomsonreuters/received_events","type":"Organization","site_admin":false},"repo":{"id":90410446,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQxMDQ0Ng==","name":"CM-Well","full_name":"thomsonreuters/CM-Well","owner":{"login":"thomsonreuters","id":686958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4Njk1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/686958?v=4","gravatar_id":"","url":"https://api.github.com/users/thomsonreuters","html_url":"https://github.com/thomsonreuters","followers_url":"https://api.github.com/users/thomsonreuters/followers","following_url":"https://api.github.com/users/thomsonreuters/following{/other_user}","gists_url":"https://api.github.com/users/thomsonreuters/gists{/gist_id}","starred_url":"https://api.github.com/users/thomsonreuters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomsonreuters/subscriptions","organizations_url":"https://api.github.com/users/thomsonreuters/orgs","repos_url":"https://api.github.com/users/thomsonreuters/repos","events_url":"https://api.github.com/users/thomsonreuters/events{/privacy}","received_events_url":"https://api.github.com/users/thomsonreuters/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thomsonreuters/CM-Well","description":"CM-Well - a data warehouse for your knowledge graph","fork":false,"url":"https://api.github.com/repos/thomsonreuters/CM-Well","forks_url":"https://api.github.com/repos/thomsonreuters/CM-Well/forks","keys_url":"https://api.github.com/repos/thomsonreuters/CM-Well/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomsonreuters/CM-Well/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomsonreuters/CM-Well/teams","hooks_url":"https://api.github.com/repos/thomsonreuters/CM-Well/hooks","issue_events_url":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/events{/number}","events_url":"https://api.github.com/repos/thomsonreuters/CM-Well/events","assignees_url":"https://api.github.com/repos/thomsonreuters/CM-Well/assignees{/user}","branches_url":"https://api.github.com/repos/thomsonreuters/CM-Well/branches{/branch}","tags_url":"https://api.github.com/repos/thomsonreuters/CM-Well/tags","blobs_url":"https://api.github.com/repos/thomsonreuters/CM-Well/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomsonreuters/CM-Well/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomsonreuters/CM-Well/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomsonreuters/CM-Well/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomsonreuters/CM-Well/statuses/{sha}","languages_url":"https://api.github.com/repos/thomsonreuters/CM-Well/languages","stargazers_url":"https://api.github.com/repos/thomsonreuters/CM-Well/stargazers","contributors_url":"https://api.github.com/repos/thomsonreuters/CM-Well/contributors","subscribers_url":"https://api.github.com/repos/thomsonreuters/CM-Well/subscribers","subscription_url":"https://api.github.com/repos/thomsonreuters/CM-Well/subscription","commits_url":"https://api.github.com/repos/thomsonreuters/CM-Well/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomsonreuters/CM-Well/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomsonreuters/CM-Well/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomsonreuters/CM-Well/contents/{+path}","compare_url":"https://api.github.com/repos/thomsonreuters/CM-Well/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomsonreuters/CM-Well/merges","archive_url":"https://api.github.com/repos/thomsonreuters/CM-Well/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomsonreuters/CM-Well/downloads","issues_url":"https://api.github.com/repos/thomsonreuters/CM-Well/issues{/number}","pulls_url":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls{/number}","milestones_url":"https://api.github.com/repos/thomsonreuters/CM-Well/milestones{/number}","notifications_url":"https://api.github.com/repos/thomsonreuters/CM-Well/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomsonreuters/CM-Well/labels{/name}","releases_url":"https://api.github.com/repos/thomsonreuters/CM-Well/releases{/id}","deployments_url":"https://api.github.com/repos/thomsonreuters/CM-Well/deployments","created_at":"2017-05-05T19:37:09Z","updated_at":"2018-06-20T11:41:51Z","pushed_at":"2018-06-20T11:41:49Z","git_url":"git://github.com/thomsonreuters/CM-Well.git","ssh_url":"git@github.com:thomsonreuters/CM-Well.git","clone_url":"https://github.com/thomsonreuters/CM-Well.git","svn_url":"https://github.com/thomsonreuters/CM-Well","homepage":"","size":16424,"stargazers_count":99,"watchers_count":99,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":183,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":183,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756"},"html":{"href":"https://github.com/thomsonreuters/CM-Well/pull/756"},"issue":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/756"},"comments":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/issues/756/comments"},"review_comments":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756/comments"},"review_comment":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/pulls/756/commits"},"statuses":{"href":"https://api.github.com/repos/thomsonreuters/CM-Well/statuses/c8651076842b63cc7a776df51c2133f4d50ab983"}},"author_association":"CONTRIBUTOR"}} | {
"id": 90410446,
"name": "thomsonreuters/CM-Well",
"url": "https://api.github.com/repos/thomsonreuters/CM-Well"
} | {
"id": 18255673,
"login": "e-orz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18255673?",
"url": "https://api.github.com/users/e-orz"
} | {
"id": 686958,
"login": "thomsonreuters",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/686958?",
"url": "https://api.github.com/orgs/thomsonreuters"
} | 2018-06-21T14:48:48 | 7858799124 | {"actor":{"display_login":"e-orz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/streamalert/pulls/comments/172708597","pull_request_review_id":101771894,"id":172708597,"diff_hunk":"@@ -26,89 +26,12 @@ resource \"aws_dynamodb_table\" \"threat_intel_ioc\" {\n }\n }\n \n-// IAM Role: Application autoscalling role\n-resource \"aws_iam_role\" \"stream_alert_dynamodb_appautoscaling\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n- name = \"${var.prefix}_streamalert_dynamodb_appautoscaling\"\n- assume_role_policy = \"${data.aws_iam_policy_document.appautoscaling_assume_role_policy.json}\"\n-}\n-\n-// IAM Policy Doc: Generic Application Autoscaling AssumeRole\n-data \"aws_iam_policy_document\" \"appautoscaling_assume_role_policy\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n-\n- statement {\n- effect = \"Allow\"\n- actions = [\"sts:AssumeRole\"]\n-\n- principals {\n- type = \"Service\"\n- identifiers = [\"application-autoscaling.amazonaws.com\"]\n- }\n- }\n-}\n-\n-// IAM Role Policy: Allow appautoscaling IAM role to autoscaling DynamoDB table\n-resource \"aws_iam_role_policy\" \"appautoscaling_update_table\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n- name = \"DynamoDBAppAutoscaleUpdateTablePolicy\"\n- role = \"${aws_iam_role.stream_alert_dynamodb_appautoscaling.id}\"\n- policy = \"${data.aws_iam_policy_document.appautoscaling_update_table.json}\"\n-}\n-\n-// IAM Policy Doc: Allow autoscaling IAM role to send alarm to CloudWatch\n-// and change table settings for autoscaling.\n-// This policy is allow the role to change table settings\n-data \"aws_iam_policy_document\" \"appautoscaling_update_table\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n-\n- statement {\n- effect = \"Allow\"\n-\n- actions = [\n- \"dynamodb:DescribeTable\",\n- \"dynamodb:UpdateTable\",\n- ]\n-\n- resources = [\n- \"${aws_dynamodb_table.threat_intel_ioc.arn}\",\n- ]\n- }\n-}\n-\n-// IAM Role Policy: Allow appautoscaling IAM role to autoscaling DynamoDB table\n-resource \"aws_iam_role_policy\" \"appautoscaling_cloudwatch_alarms\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n- name = \"DynamoDBAppAutoscaleCloudWatchAlarmsPolicy\"\n- role = \"${aws_iam_role.stream_alert_dynamodb_appautoscaling.id}\"\n- policy = \"${data.aws_iam_policy_document.appautoscaling_cloudwatch_alarms.json}\"\n-}\n-\n-// IAM Policy Doc: This policy is allow the role to send alarm to CloudWatch.\n-data \"aws_iam_policy_document\" \"appautoscaling_cloudwatch_alarms\" {\n- count = \"${var.autoscale ? 1 : 0}\"\n-\n- statement {\n- effect = \"Allow\"\n-\n- actions = [\n- \"cloudwatch:PutMetricAlarm\",\n- \"cloudwatch:DescribeAlarms\",\n- \"cloudwatch:GetMetricStatistics\",\n- \"cloudwatch:SetAlarmState\",\n- \"cloudwatch:DeleteAlarms\",\n- ]\n-\n- resources = [\"*\"]\n- }\n-}\n-\n resource \"aws_appautoscaling_target\" \"dynamodb_table_read_target\" {\n count = \"${var.autoscale ? 1 : 0}\"","path":"terraform/modules/tf_threat_intel_downloader/dynamodb.tf","position":82,"original_position":82,"commit_id":"02533c42136326117578d4857a2c6a8659306359","original_commit_id":"02533c42136326117578d4857a2c6a8659306359","user":{"login":"chunyong-lin","id":21151436,"avatar_url":"https://avatars1.githubusercontent.com/u/21151436?v=4","gravatar_id":"","url":"https://api.github.com/users/chunyong-lin","html_url":"https://github.com/chunyong-lin","followers_url":"https://api.github.com/users/chunyong-lin/followers","following_url":"https://api.github.com/users/chunyong-lin/following{/other_user}","gists_url":"https://api.github.com/users/chunyong-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/chunyong-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunyong-lin/subscriptions","organizations_url":"https://api.github.com/users/chunyong-lin/orgs","repos_url":"https://api.github.com/users/chunyong-lin/repos","events_url":"https://api.github.com/users/chunyong-lin/events{/privacy}","received_events_url":"https://api.github.com/users/chunyong-lin/received_events","type":"User","site_admin":false},"body":"There is another line below should be deleted. ","created_at":"2018-03-07T00:41:00Z","updated_at":"2018-03-07T00:44:16Z","html_url":"https://github.com/airbnb/streamalert/pull/623#discussion_r172708597","pull_request_url":"https://api.github.com/repos/airbnb/streamalert/pulls/623","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/comments/172708597"},"html":{"href":"https://github.com/airbnb/streamalert/pull/623#discussion_r172708597"},"pull_request":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/623"}},"in_reply_to_id":172708281},"pull_request":{"url":"https://api.github.com/repos/airbnb/streamalert/pulls/623","id":173317201,"html_url":"https://github.com/airbnb/streamalert/pull/623","diff_url":"https://github.com/airbnb/streamalert/pull/623.diff","patch_url":"https://github.com/airbnb/streamalert/pull/623.patch","issue_url":"https://api.github.com/repos/airbnb/streamalert/issues/623","number":623,"state":"open","locked":false,"title":"A collection of small fixes","user":{"login":"austinbyers","id":3608925,"avatar_url":"https://avatars0.githubusercontent.com/u/3608925?v=4","gravatar_id":"","url":"https://api.github.com/users/austinbyers","html_url":"https://github.com/austinbyers","followers_url":"https://api.github.com/users/austinbyers/followers","following_url":"https://api.github.com/users/austinbyers/following{/other_user}","gists_url":"https://api.github.com/users/austinbyers/gists{/gist_id}","starred_url":"https://api.github.com/users/austinbyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinbyers/subscriptions","organizations_url":"https://api.github.com/users/austinbyers/orgs","repos_url":"https://api.github.com/users/austinbyers/repos","events_url":"https://api.github.com/users/austinbyers/events{/privacy}","received_events_url":"https://api.github.com/users/austinbyers/received_events","type":"User","site_admin":false},"body":"to: @chunyong-lin \r\ncc: @airbnb/streamalert-maintainers \r\nsize: small|medium|large\r\nresolves: #267\r\nresolves: #572 \r\n\r\n## Background\r\n\r\nA collection of small fixes and features that have been bugging me :)\r\n\r\n## Changes\r\n\r\n* #620 added support for SNS and SQS outputs, but did not update the alert tests to mock those outputs. This has been fixed\r\n* Per #572 , Dynamo autoscaling works best with the service role automatically generated by AWS. We use that instead of creating our own IAM role\r\n* Run `terraform fmt` to fix a spacing issue which snuck in\r\n* The `third_party_libraries` config option is only applicable to the rule processor, whereby users can specify additional libraries to install when writing rules. To reduce confusion, this config option has been removed from the other lambda configs\r\n* Adds a BinaryAlert YARA match rule (the log schema was added in #556, but no rules were added)\r\n* One of the unit tests was consuming 5-10% of the test time because it was not properly mocked:\r\n\r\n```\r\n[success] 10.41% tests.unit.stream_alert_athena_partition_refresh.test_main.TestStreamAlertAthenaGlobals.test_handler_no_unique_buckets: 0.9611s\r\n```\r\n\r\n* The ever-annoying RuntimeWarning import error (#267) can be fixed with a magical\r\n\r\n```python\r\nfrom __future__ import absolute_import\r\n```\r\n\r\nI have no idea why it works, but I found this solution to the same problem in the [PyCharm blog](https://youtrack.jetbrains.com/issue/PY-20171#comment=27-1802805)\r\n\r\n## Testing\r\n\r\n* Deployed to a test account - alerts worked end-to-end\r\n* `terraform validate`\r\n* CI\r\n","created_at":"2018-03-07T00:01:12Z","updated_at":"2018-03-07T00:44:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f63fbdadcdf902386158c983890c72b31f331fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/streamalert/pulls/623/commits","review_comments_url":"https://api.github.com/repos/airbnb/streamalert/pulls/623/comments","review_comment_url":"https://api.github.com/repos/airbnb/streamalert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/streamalert/issues/623/comments","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/02533c42136326117578d4857a2c6a8659306359","head":{"label":"airbnb:austin-small-fixes","ref":"austin-small-fixes","sha":"02533c42136326117578d4857a2c6a8659306359","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":79683936,"name":"streamalert","full_name":"airbnb/streamalert","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/streamalert","description":"StreamAlert is a serverless, realtime data analysis framework which empowers you to ingest, analyze, and alert on data from any environment, using datasources and alerting logic you define.","fork":false,"url":"https://api.github.com/repos/airbnb/streamalert","forks_url":"https://api.github.com/repos/airbnb/streamalert/forks","keys_url":"https://api.github.com/repos/airbnb/streamalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/streamalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/streamalert/teams","hooks_url":"https://api.github.com/repos/airbnb/streamalert/hooks","issue_events_url":"https://api.github.com/repos/airbnb/streamalert/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/streamalert/events","assignees_url":"https://api.github.com/repos/airbnb/streamalert/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/streamalert/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/streamalert/tags","blobs_url":"https://api.github.com/repos/airbnb/streamalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/streamalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/streamalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/streamalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/streamalert/languages","stargazers_url":"https://api.github.com/repos/airbnb/streamalert/stargazers","contributors_url":"https://api.github.com/repos/airbnb/streamalert/contributors","subscribers_url":"https://api.github.com/repos/airbnb/streamalert/subscribers","subscription_url":"https://api.github.com/repos/airbnb/streamalert/subscription","commits_url":"https://api.github.com/repos/airbnb/streamalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/streamalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/streamalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/streamalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/streamalert/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/streamalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/streamalert/merges","archive_url":"https://api.github.com/repos/airbnb/streamalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/streamalert/downloads","issues_url":"https://api.github.com/repos/airbnb/streamalert/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/streamalert/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/streamalert/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/streamalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/streamalert/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/streamalert/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/streamalert/deployments","created_at":"2017-01-22T01:10:56Z","updated_at":"2018-03-06T23:59:17Z","pushed_at":"2018-03-07T00:01:13Z","git_url":"git://github.com/airbnb/streamalert.git","ssh_url":"git@github.com:airbnb/streamalert.git","clone_url":"https://github.com/airbnb/streamalert.git","svn_url":"https://github.com/airbnb/streamalert","homepage":"","size":7785,"stargazers_count":1157,"watchers_count":1157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":60,"watchers":1157,"default_branch":"master"}},"base":{"label":"airbnb:release-2.0.0","ref":"release-2.0.0","sha":"9f47ba36469c84e4203ee68c1f333513b5b4c55b","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":79683936,"name":"streamalert","full_name":"airbnb/streamalert","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/streamalert","description":"StreamAlert is a serverless, realtime data analysis framework which empowers you to ingest, analyze, and alert on data from any environment, using datasources and alerting logic you define.","fork":false,"url":"https://api.github.com/repos/airbnb/streamalert","forks_url":"https://api.github.com/repos/airbnb/streamalert/forks","keys_url":"https://api.github.com/repos/airbnb/streamalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/streamalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/streamalert/teams","hooks_url":"https://api.github.com/repos/airbnb/streamalert/hooks","issue_events_url":"https://api.github.com/repos/airbnb/streamalert/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/streamalert/events","assignees_url":"https://api.github.com/repos/airbnb/streamalert/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/streamalert/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/streamalert/tags","blobs_url":"https://api.github.com/repos/airbnb/streamalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/streamalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/streamalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/streamalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/streamalert/languages","stargazers_url":"https://api.github.com/repos/airbnb/streamalert/stargazers","contributors_url":"https://api.github.com/repos/airbnb/streamalert/contributors","subscribers_url":"https://api.github.com/repos/airbnb/streamalert/subscribers","subscription_url":"https://api.github.com/repos/airbnb/streamalert/subscription","commits_url":"https://api.github.com/repos/airbnb/streamalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/streamalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/streamalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/streamalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/streamalert/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/streamalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/streamalert/merges","archive_url":"https://api.github.com/repos/airbnb/streamalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/streamalert/downloads","issues_url":"https://api.github.com/repos/airbnb/streamalert/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/streamalert/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/streamalert/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/streamalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/streamalert/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/streamalert/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/streamalert/deployments","created_at":"2017-01-22T01:10:56Z","updated_at":"2018-03-06T23:59:17Z","pushed_at":"2018-03-07T00:01:13Z","git_url":"git://github.com/airbnb/streamalert.git","ssh_url":"git@github.com:airbnb/streamalert.git","clone_url":"https://github.com/airbnb/streamalert.git","svn_url":"https://github.com/airbnb/streamalert","homepage":"","size":7785,"stargazers_count":1157,"watchers_count":1157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":117,"open_issues":60,"watchers":1157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/623"},"html":{"href":"https://github.com/airbnb/streamalert/pull/623"},"issue":{"href":"https://api.github.com/repos/airbnb/streamalert/issues/623"},"comments":{"href":"https://api.github.com/repos/airbnb/streamalert/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/streamalert/statuses/02533c42136326117578d4857a2c6a8659306359"}},"author_association":"CONTRIBUTOR"}} | {
"id": 79683936,
"name": "airbnb/streamalert",
"url": "https://api.github.com/repos/airbnb/streamalert"
} | {
"id": 21151436,
"login": "chunyong-lin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21151436?",
"url": "https://api.github.com/users/chunyong-lin"
} | {
"id": 698437,
"login": "airbnb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/698437?",
"url": "https://api.github.com/orgs/airbnb"
} | 2018-03-07T00:41:00 | 7341185858 | {"actor":{"display_login":"chunyong-lin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/189706372","pull_request_review_id":121813158,"id":189706372,"diff_hunk":"@@ -122,85 +224,86 @@ protocol CallServiceObserver: class {\n \n // MARK: Ivars\n \n- var peerConnectionClient: PeerConnectionClient? {\n+ fileprivate var callData: SignalCallData? {\n didSet {\n SwiftAssertIsOnMainThread(#function)\n \n- Logger.debug(\"\\(self.logTag) .peerConnectionClient setter: \\(oldValue != nil) -> \\(peerConnectionClient != nil) \\(String(describing: peerConnectionClient))\")\n- }\n- }\n-\n- var call: SignalCall? {\n- didSet {\n- SwiftAssertIsOnMainThread(#function)\n-\n- oldValue?.removeObserver(self)\n- call?.addObserverAndSyncState(observer: self)\n+ oldValue?.call.removeObserver(self)\n+ callData?.call.addObserverAndSyncState(observer: self)\n \n updateIsVideoEnabled()\n \n // Prevent device from sleeping while we have an active call.\n- if oldValue != call {\n+ if oldValue != callData {\n if let oldValue = oldValue {\n DeviceSleepManager.sharedInstance.removeBlock(blockObject: oldValue)\n }\n stopAnyCallTimer()\n- if let call = call {\n- DeviceSleepManager.sharedInstance.addBlock(blockObject: call)\n+ if let callData = callData {\n+ DeviceSleepManager.sharedInstance.addBlock(blockObject: callData)\n self.startCallTimer()\n }\n }\n \n- Logger.debug(\"\\(self.logTag) .call setter: \\(oldValue?.identifiersForLogs as Optional) -> \\(call?.identifiersForLogs as Optional)\")\n+ Logger.debug(\"\\(self.logTag) .callData setter: \\(oldValue?.call.identifiersForLogs as Optional) -> \\(callData?.call.identifiersForLogs as Optional)\")\n \n for observer in observers {\n- observer.value?.didUpdateCall(call: call)\n+ observer.value?.didUpdateCall(call: callData?.call)\n }\n }\n }\n \n- // Used to coordinate promises across delegate methods\n- private var fulfillCallConnectedPromise: (() -> Void)?\n- private var rejectCallConnectedPromise: ((Error) -> Void)?\n-\n- // Used by waitForPeerConnectionClient to make sure any received\n- // ICE messages wait until the peer connection client is set up.\n- private var fulfillPeerConnectionClientPromise: (() -> Void)?\n- private var rejectPeerConnectionClientPromise: ((Error) -> Void)?\n- private var peerConnectionClientPromise: Promise<Void>?\n+ // TODO: Remove?\n+ var call: SignalCall? {\n+ get {\n+ SwiftAssertIsOnMainThread(#function)\n \n- // Used by waituntilReadyToSendIceUpdates to make sure CallOffer was \n- // sent before sending any ICE updates.\n- private var fulfillReadyToSendIceUpdatesPromise: (() -> Void)?\n- private var rejectReadyToSendIceUpdatesPromise: ((Error) -> Void)?\n- private var readyToSendIceUpdatesPromise: Promise<Void>?\n+ guard let callData = callData else {\n+ return nil\n+ }\n+ return callData.call\n+ }\n+ }\n \n- weak var localVideoTrack: RTCVideoTrack? {\n- didSet {\n+ var peerConnectionClient: PeerConnectionClient? {\n+ get {\n SwiftAssertIsOnMainThread(#function)\n \n- Logger.info(\"\\(self.logTag) \\(#function)\")\n-\n- fireDidUpdateVideoTracks()\n+ guard let callData = callData else {\n+ return nil\n+ }\n+ return callData.peerConnectionClient\n }\n }\n \n- weak var remoteVideoTrack: RTCVideoTrack? {\n- didSet {\n+ var localVideoTrack: RTCVideoTrack? {\n+ get {\n SwiftAssertIsOnMainThread(#function)\n \n- Logger.info(\"\\(self.logTag) \\(#function)\")\n-\n- fireDidUpdateVideoTracks()\n+ guard let callData = callData else {\n+ return nil\n+ }\n+ return callData.localVideoTrack\n }\n }\n- var isRemoteVideoEnabled = false {\n- didSet {\n+ weak var remoteVideoTrack: RTCVideoTrack? {","path":"Signal/src/call/CallService.swift","position":217,"original_position":217,"commit_id":"44668d5518b38f76f38f054d38ce8b8152cc7fd4","original_commit_id":"44668d5518b38f76f38f054d38ce8b8152cc7fd4","user":{"login":"michaelkirk-signal","id":36971200,"avatar_url":"https://avatars3.githubusercontent.com/u/36971200?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkirk-signal","html_url":"https://github.com/michaelkirk-signal","followers_url":"https://api.github.com/users/michaelkirk-signal/followers","following_url":"https://api.github.com/users/michaelkirk-signal/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk-signal/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk-signal/orgs","repos_url":"https://api.github.com/users/michaelkirk-signal/repos","events_url":"https://api.github.com/users/michaelkirk-signal/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk-signal/received_events","type":"User","site_admin":false},"body":"I think this `weak` was copied over - now that videoTrack lives on the callData (which I think is a good call!) we don't need it.","created_at":"2018-05-21T20:36:07Z","updated_at":"2018-05-21T20:46:27Z","html_url":"https://github.com/signalapp/Signal-iOS/pull/3454#discussion_r189706372","pull_request_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments/189706372"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3454#discussion_r189706372"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454"}}},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454","id":189124733,"html_url":"https://github.com/signalapp/Signal-iOS/pull/3454","diff_url":"https://github.com/signalapp/Signal-iOS/pull/3454.diff","patch_url":"https://github.com/signalapp/Signal-iOS/pull/3454.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3454","number":3454,"state":"open","locked":false,"title":"Charlesmchen/call lifecycle edge cases","user":{"login":"charlesmchen-signal","id":36971147,"avatar_url":"https://avatars0.githubusercontent.com/u/36971147?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen-signal","html_url":"https://github.com/charlesmchen-signal","followers_url":"https://api.github.com/users/charlesmchen-signal/followers","following_url":"https://api.github.com/users/charlesmchen-signal/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen-signal/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen-signal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen-signal/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen-signal/orgs","repos_url":"https://api.github.com/users/charlesmchen-signal/repos","events_url":"https://api.github.com/users/charlesmchen-signal/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen-signal/received_events","type":"User","site_admin":false},"body":"This fixes at least one reproducible error where ice updates arriving _after_ a call is terminated taint the next call. \r\n\r\nBy gather all per-call state in `SignalCallData`, we can easily reason about it's lifecycle:\r\n\r\n* All per-call state is cleaned up when the call is terminated.\r\n* The futures/promises are all created when the call begins.\r\n* The futures/promises are all rejected if necessary when the call is terminated.\r\n\r\nPTAL @michaelkirk ","created_at":"2018-05-18T20:16:34Z","updated_at":"2018-05-21T20:46:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ee35e77821e66a33f257c3c472f13096e2895e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3454/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/44668d5518b38f76f38f054d38ce8b8152cc7fd4","head":{"label":"signalapp:charlesmchen/callLifecycleEdgeCases","ref":"charlesmchen/callLifecycleEdgeCases","sha":"44668d5518b38f76f38f054d38ce8b8152cc7fd4","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-05-21T05:21:45Z","pushed_at":"2018-05-21T20:00:58Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":472404,"stargazers_count":3468,"watchers_count":3468,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":811,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":811,"open_issues":383,"watchers":3468,"default_branch":"master"}},"base":{"label":"signalapp:master","ref":"master","sha":"2f8b5b8ea23cd1965387cc3cef8cb5bdf6f38d0f","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"signalapp/Signal-iOS","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-iOS","description":"A private messenger for iOS.","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-iOS","forks_url":"https://api.github.com/repos/signalapp/Signal-iOS/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-iOS/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-iOS/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2018-05-21T05:21:45Z","pushed_at":"2018-05-21T20:00:58Z","git_url":"git://github.com/signalapp/Signal-iOS.git","ssh_url":"git@github.com:signalapp/Signal-iOS.git","clone_url":"https://github.com/signalapp/Signal-iOS.git","svn_url":"https://github.com/signalapp/Signal-iOS","homepage":"https://signal.org","size":472404,"stargazers_count":3468,"watchers_count":3468,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":811,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":811,"open_issues":383,"watchers":3468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454"},"html":{"href":"https://github.com/signalapp/Signal-iOS/pull/3454"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3454"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/issues/3454/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/pulls/3454/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-iOS/statuses/44668d5518b38f76f38f054d38ce8b8152cc7fd4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 19429698,
"name": "signalapp/Signal-iOS",
"url": "https://api.github.com/repos/signalapp/Signal-iOS"
} | {
"id": 36971200,
"login": "michaelkirk-signal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36971200?",
"url": "https://api.github.com/users/michaelkirk-signal"
} | {
"id": 702459,
"login": "signalapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/702459?",
"url": "https://api.github.com/orgs/signalapp"
} | 2018-05-21T20:36:07 | 7706961354 | {"actor":{"display_login":"michaelkirk-signal"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/rogue/pulls/comments/228967075","pull_request_review_id":169351377,"id":228967075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk2NzA3NQ==","diff_hunk":"@@ -0,0 +1,118 @@\n+<?php\n+\n+namespace Rogue\\Http\\Controllers;\n+\n+use Rogue\\Models\\Campaign;\n+use Illuminate\\Http\\Request;\n+use Rogue\\Http\\Transformers\\CampaignTransformer;\n+\n+class CampaignsController extends ApiController\n+{\n+ /**\n+ * @var Rogue\\Http\\Transformers\\SignupTransformer;\n+ */\n+ protected $transformer;\n+\n+ /**\n+ * Create a controller instance.\n+ *\n+ */\n+ public function __construct()\n+ {\n+ $this->transformer = new CampaignTransformer;\n+\n+ $this->middleware('auth', ['only' => ['store', 'update', 'destroy']]);\n+ $this->middleware('role:admin,staff', ['only' => ['store', 'update', 'destroy']]);\n+ $this->middleware('scopes:write', ['only' => ['store', 'update', 'destroy']]);\n+ }\n+ /**\n+ * Display a listing of the resource.\n+ *\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function index(Request $request)\n+ {\n+ $query = $this->newQuery(Campaign::class);\n+\n+ return $this->paginatedCollection($query, $request);\n+ }\n+\n+ /**\n+ * Store a newly created resource in storage.\n+ *\n+ * @param \\Illuminate\\Http\\Request $request\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function store(Request $request)\n+ {\n+ $this->validate($request, [\n+ 'internal_title' => 'required|string',\n+ 'start_date' => 'required|date',\n+ 'end_date' => 'required|date',\n+ ]);\n+\n+ // Check to see if the campaign exists before creating one.\n+ $campaign = Campaign::where([\n+ 'internal_title' => $request['internal_title'],\n+ ])->first();\n+\n+ // If there is no campaign with that title, create one.\n+ if (! $campaign) {\n+ $campaign = new Campaign;\n+\n+ $campaign->internal_title = $request['internal_title'];\n+ $campaign->start_date = $request['start_date'];\n+ $campaign->end_date = $request['end_date'];\n+ $campaign->save();\n+\n+ // Log that a campaign was created.\n+ info('campaign_created', ['id' => $campaign->id]);\n+ }\n+\n+ // @TODO: return redirect()->route('campaigns.show', $campaign->id);\n+ }\n+\n+ /**\n+ * Display the specified resource.\n+ *\n+ * @param \\Rogue\\Models\\Campaign $campaign\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function show(Campaign $campaign)\n+ {\n+ return $this->item($campaign, 200, [], $this->transformer);\n+ }\n+\n+ /**\n+ * Update the specified resource in storage.\n+ *\n+ * @param \\Illuminate\\Http\\Request $request\n+ * @param \\Rogue\\Models\\Campaign $campaign\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function update(Request $request, Campaign $campaign)\n+ {\n+ $campaign->update($request->all());","path":"app/Http/Controllers/CampaignsController.php","position":95,"original_position":95,"commit_id":"23248d00bc834f12b423439cde2e5e83d7f78cf7","original_commit_id":"23248d00bc834f12b423439cde2e5e83d7f78cf7","user":{"login":"DFurnes","id":583202,"node_id":"MDQ6VXNlcjU4MzIwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/583202?v=4","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"body":"Let's add some validation above this line, like we do for the `store` method!","created_at":"2018-10-29T15:09:09Z","updated_at":"2018-10-29T15:13:27Z","html_url":"https://github.com/DoSomething/rogue/pull/776#discussion_r228967075","pull_request_url":"https://api.github.com/repos/DoSomething/rogue/pulls/776","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/comments/228967075"},"html":{"href":"https://github.com/DoSomething/rogue/pull/776#discussion_r228967075"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/776"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/rogue/pulls/776","id":225844965,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODQ0OTY1","html_url":"https://github.com/DoSomething/rogue/pull/776","diff_url":"https://github.com/DoSomething/rogue/pull/776.diff","patch_url":"https://github.com/DoSomething/rogue/pull/776.patch","issue_url":"https://api.github.com/repos/DoSomething/rogue/issues/776","number":776,"state":"open","locked":false,"title":"Backend work for Rogue to create campaign IDs","user":{"login":"chloealee","id":9019452,"node_id":"MDQ6VXNlcjkwMTk0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9019452?v=4","gravatar_id":"","url":"https://api.github.com/users/chloealee","html_url":"https://github.com/chloealee","followers_url":"https://api.github.com/users/chloealee/followers","following_url":"https://api.github.com/users/chloealee/following{/other_user}","gists_url":"https://api.github.com/users/chloealee/gists{/gist_id}","starred_url":"https://api.github.com/users/chloealee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chloealee/subscriptions","organizations_url":"https://api.github.com/users/chloealee/orgs","repos_url":"https://api.github.com/users/chloealee/repos","events_url":"https://api.github.com/users/chloealee/events{/privacy}","received_events_url":"https://api.github.com/users/chloealee/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n- Fleshes out backend work for Rogue to create campaign IDs and be the main source of truth for campaigns (once we migrate everything from Ashes to Rogue!). \r\n - Adds new `campaigns` table \r\n - Builds out new Campaign Model and Campaign Controller:\r\n - New Campaign Controller that will be used for all new CRUD activity. \r\n - This includes the following new routes:\r\n - `GET /api/v3/campaigns` index \r\n - `GET /api/v3/campaigns/{campaign}`\r\n - `POST /campaigns`\r\n - `PATCH /campaigns/{campaign}`\r\n - `DELETE /campaigns/{campaign}`\r\n - _Note:_ I decided not to put the last three routes in `api/v3` because they should only be used internally in Rogue admin, for now? \r\n - Adds new Campaign Transformer \r\n - Updates documentation \r\n - Adds tests for each of these new endpoints \r\n- **Notes:**\r\n - Place holders for now to redirect to campaign pages for frontend PR! \r\n - Right now, these endpoints will only reveal/manipulate data that is in the Rogue database, not legacy campaigns. \r\n - Rogue admin is still hooked up to getting campaign data from Ashes. We'll deal with the transition to Rogue as main source for campaign data and to get off Ashes in another PR I assume @ngjo ? \r\n\r\n#### How should this be reviewed?\r\nDoes the structure of the api routes/controller make sense? Anything I missed? \r\n\r\n#### Relevant tickets\r\nFixes [this](https://www.pivotaltracker.com/n/projects/2019429/stories/161257914) Pivotal Card.\r\n\r\n#### How to deploy\r\nhttps://github.com/DoSomething/rogue/blob/master/docs/development/deployments.md\r\n","created_at":"2018-10-25T17:38:35Z","updated_at":"2018-10-29T15:13:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"448145b28321c407c7d1702fc2b00a0c1d3bb7d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/rogue/pulls/776/commits","review_comments_url":"https://api.github.com/repos/DoSomething/rogue/pulls/776/comments","review_comment_url":"https://api.github.com/repos/DoSomething/rogue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/rogue/issues/776/comments","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/23248d00bc834f12b423439cde2e5e83d7f78cf7","head":{"label":"DoSomething:campaign-ids","ref":"campaign-ids","sha":"23248d00bc834f12b423439cde2e5e83d7f78cf7","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":64166359,"node_id":"MDEwOlJlcG9zaXRvcnk2NDE2NjM1OQ==","name":"rogue","full_name":"DoSomething/rogue","private":false,"owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DoSomething/rogue","description":":camera: The DoSomething.org activity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/rogue","forks_url":"https://api.github.com/repos/DoSomething/rogue/forks","keys_url":"https://api.github.com/repos/DoSomething/rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/rogue/teams","hooks_url":"https://api.github.com/repos/DoSomething/rogue/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/rogue/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/rogue/events","assignees_url":"https://api.github.com/repos/DoSomething/rogue/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/rogue/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/rogue/tags","blobs_url":"https://api.github.com/repos/DoSomething/rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/rogue/languages","stargazers_url":"https://api.github.com/repos/DoSomething/rogue/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/rogue/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/rogue/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/rogue/subscription","commits_url":"https://api.github.com/repos/DoSomething/rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/rogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/rogue/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/rogue/merges","archive_url":"https://api.github.com/repos/DoSomething/rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/rogue/downloads","issues_url":"https://api.github.com/repos/DoSomething/rogue/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/rogue/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/rogue/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/rogue/deployments","created_at":"2016-07-25T20:38:30Z","updated_at":"2018-10-19T21:10:19Z","pushed_at":"2018-10-26T20:50:21Z","git_url":"git://github.com/DoSomething/rogue.git","ssh_url":"git@github.com:DoSomething/rogue.git","clone_url":"https://github.com/DoSomething/rogue.git","svn_url":"https://github.com/DoSomething/rogue","homepage":"https://activity.dosomething.org","size":7080,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"c1621059fa5852448f673c881bc92b5ce4962d97","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":64166359,"node_id":"MDEwOlJlcG9zaXRvcnk2NDE2NjM1OQ==","name":"rogue","full_name":"DoSomething/rogue","private":false,"owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DoSomething/rogue","description":":camera: The DoSomething.org activity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/rogue","forks_url":"https://api.github.com/repos/DoSomething/rogue/forks","keys_url":"https://api.github.com/repos/DoSomething/rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/rogue/teams","hooks_url":"https://api.github.com/repos/DoSomething/rogue/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/rogue/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/rogue/events","assignees_url":"https://api.github.com/repos/DoSomething/rogue/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/rogue/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/rogue/tags","blobs_url":"https://api.github.com/repos/DoSomething/rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/rogue/languages","stargazers_url":"https://api.github.com/repos/DoSomething/rogue/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/rogue/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/rogue/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/rogue/subscription","commits_url":"https://api.github.com/repos/DoSomething/rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/rogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/rogue/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/rogue/merges","archive_url":"https://api.github.com/repos/DoSomething/rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/rogue/downloads","issues_url":"https://api.github.com/repos/DoSomething/rogue/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/rogue/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/rogue/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/rogue/deployments","created_at":"2016-07-25T20:38:30Z","updated_at":"2018-10-19T21:10:19Z","pushed_at":"2018-10-26T20:50:21Z","git_url":"git://github.com/DoSomething/rogue.git","ssh_url":"git@github.com:DoSomething/rogue.git","clone_url":"https://github.com/DoSomething/rogue.git","svn_url":"https://github.com/DoSomething/rogue","homepage":"https://activity.dosomething.org","size":7080,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/776"},"html":{"href":"https://github.com/DoSomething/rogue/pull/776"},"issue":{"href":"https://api.github.com/repos/DoSomething/rogue/issues/776"},"comments":{"href":"https://api.github.com/repos/DoSomething/rogue/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/rogue/statuses/23248d00bc834f12b423439cde2e5e83d7f78cf7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64166359,
"name": "DoSomething/rogue",
"url": "https://api.github.com/repos/DoSomething/rogue"
} | {
"id": 583202,
"login": "DFurnes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/583202?",
"url": "https://api.github.com/users/DFurnes"
} | {
"id": 731685,
"login": "DoSomething",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/731685?",
"url": "https://api.github.com/orgs/DoSomething"
} | 2018-10-29T15:09:09 | 8498585858 | {"actor":{"display_login":"DFurnes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/181451348","pull_request_review_id":112087633,"id":181451348,"diff_hunk":"@@ -0,0 +1,39 @@\n+# Security Policies and Procedures\n+\n+This document outlines security procedures and policies for the `Joomla!\n+project`.","path":"SECURITY.md","position":4,"original_position":4,"commit_id":"91c6c71945a3685a06820032787e5253b0181e2c","original_commit_id":"91c6c71945a3685a06820032787e5253b0181e2c","user":{"login":"Quy","id":368084,"avatar_url":"https://avatars2.githubusercontent.com/u/368084?v=4","gravatar_id":"","url":"https://api.github.com/users/Quy","html_url":"https://github.com/Quy","followers_url":"https://api.github.com/users/Quy/followers","following_url":"https://api.github.com/users/Quy/following{/other_user}","gists_url":"https://api.github.com/users/Quy/gists{/gist_id}","starred_url":"https://api.github.com/users/Quy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quy/subscriptions","organizations_url":"https://api.github.com/users/Quy/orgs","repos_url":"https://api.github.com/users/Quy/repos","events_url":"https://api.github.com/users/Quy/events{/privacy}","received_events_url":"https://api.github.com/users/Quy/received_events","type":"User","site_admin":false},"body":"Move to line 3.","created_at":"2018-04-13T17:03:20Z","updated_at":"2018-04-13T17:03:20Z","html_url":"https://github.com/joomla/joomla-cms/pull/20163#discussion_r181451348","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/181451348"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20163#discussion_r181451348"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163","id":181542942,"html_url":"https://github.com/joomla/joomla-cms/pull/20163","diff_url":"https://github.com/joomla/joomla-cms/pull/20163.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20163.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20163","number":20163,"state":"open","locked":false,"title":"Add a security policy","user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"body":"Many projects now add a SECURITY.md document to their repository. Often this is related to using HackerOne but not always.\r\n\r\nThis PR adds a policy to our github repo. It is based on the existing policy on the d.j.o web site\r\n\r\nThe file doesn't need to be distributed so it has been added to the exclude list in the github repo.\r\n","created_at":"2018-04-13T16:55:38Z","updated_at":"2018-04-13T17:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53afa963aee5948729dd8137c7fdb018cd5d34ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20163/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/91c6c71945a3685a06820032787e5253b0181e2c","head":{"label":"brianteeman:security.md","ref":"security.md","sha":"91c6c71945a3685a06820032787e5253b0181e2c","user":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"repo":{"id":76056079,"name":"joomla-cms","full_name":"brianteeman/joomla-cms","owner":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianteeman/joomla-cms","description":"DEV attachments field for Joomla custom fields","fork":true,"url":"https://api.github.com/repos/brianteeman/joomla-cms","forks_url":"https://api.github.com/repos/brianteeman/joomla-cms/forks","keys_url":"https://api.github.com/repos/brianteeman/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianteeman/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianteeman/joomla-cms/teams","hooks_url":"https://api.github.com/repos/brianteeman/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/brianteeman/joomla-cms/events","assignees_url":"https://api.github.com/repos/brianteeman/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/brianteeman/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/brianteeman/joomla-cms/tags","blobs_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianteeman/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/brianteeman/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/brianteeman/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/brianteeman/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/brianteeman/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/brianteeman/joomla-cms/subscription","commits_url":"https://api.github.com/repos/brianteeman/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianteeman/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianteeman/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/brianteeman/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianteeman/joomla-cms/merges","archive_url":"https://api.github.com/repos/brianteeman/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianteeman/joomla-cms/downloads","issues_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/brianteeman/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/brianteeman/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/brianteeman/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianteeman/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/brianteeman/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/brianteeman/joomla-cms/deployments","created_at":"2016-12-09T17:27:35Z","updated_at":"2017-03-27T16:53:19Z","pushed_at":"2018-04-13T16:58:10Z","git_url":"git://github.com/brianteeman/joomla-cms.git","ssh_url":"git@github.com:brianteeman/joomla-cms.git","clone_url":"https://github.com/brianteeman/joomla-cms.git","svn_url":"https://github.com/brianteeman/joomla-cms","homepage":"https://brian.teeman.net","size":228559,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"b5b9d49f98d3b4d95c3b16216504e4ef0c2c5ef1","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-04-13T11:59:22Z","pushed_at":"2018-04-13T16:58:12Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":228306,"stargazers_count":2705,"watchers_count":2705,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2678,"mirror_url":null,"archived":false,"open_issues_count":815,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2678,"open_issues":815,"watchers":2705,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20163"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20163"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20163/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20163/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/91c6c71945a3685a06820032787e5253b0181e2c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2464908,
"name": "joomla/joomla-cms",
"url": "https://api.github.com/repos/joomla/joomla-cms"
} | {
"id": 368084,
"login": "Quy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/368084?",
"url": "https://api.github.com/users/Quy"
} | {
"id": 751633,
"login": "joomla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/751633?",
"url": "https://api.github.com/orgs/joomla"
} | 2018-04-13T17:03:20 | 7527437702 | {"actor":{"display_login":"Quy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/242768960","pull_request_review_id":186359786,"id":242768960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjc2ODk2MA==","diff_hunk":"@@ -165,6 +193,14 @@ class Block {\n return this.merkleRoot.compare(actualMerkleRoot) === 0\n }\n \n+ checkWitnessCommit () {\n+ if (!this.transactions) return false\n+ if (!this.isWitnessBlock()) return false","path":"src/block.js","position":58,"original_position":58,"commit_id":"bc8a0f5b0c1542df9a085c7adee89984816edc4d","original_commit_id":"bc8a0f5b0c1542df9a085c7adee89984816edc4d","user":{"login":"dcousens","id":413395,"node_id":"MDQ6VXNlcjQxMzM5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/413395?v=4","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"``` js\r\n if (!this.transactions) throw new TypeError('Missing transactions')\r\n```\r\n\r\n?","created_at":"2018-12-19T01:51:35Z","updated_at":"2018-12-19T01:51:35Z","html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292#discussion_r242768960","pull_request_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/242768960"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292#discussion_r242768960"},"pull_request":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292"}},"in_reply_to_id":242498720},"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292","id":239446532,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDQ2NTMy","html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292","diff_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292.diff","patch_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292.patch","issue_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/1292","number":1292,"state":"open","locked":false,"title":"Add Witness Commit checking for Block","user":{"login":"junderw","id":11246316,"node_id":"MDQ6VXNlcjExMjQ2MzE2","avatar_url":"https://avatars1.githubusercontent.com/u/11246316?v=4","gravatar_id":"","url":"https://api.github.com/users/junderw","html_url":"https://github.com/junderw","followers_url":"https://api.github.com/users/junderw/followers","following_url":"https://api.github.com/users/junderw/following{/other_user}","gists_url":"https://api.github.com/users/junderw/gists{/gist_id}","starred_url":"https://api.github.com/users/junderw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junderw/subscriptions","organizations_url":"https://api.github.com/users/junderw/orgs","repos_url":"https://api.github.com/users/junderw/repos","events_url":"https://api.github.com/users/junderw/events{/privacy}","received_events_url":"https://api.github.com/users/junderw/received_events","type":"User","site_admin":false},"body":"This PR is based on #1289 and the merge branch is pointed at the ES6 Block branch.\r\n\r\nNeed to be able to verify witness commits for block verification moving forward.","created_at":"2018-12-18T11:01:16Z","updated_at":"2018-12-19T01:51:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa9b9d5856ac5f0da0ac637a541375fd5363b43a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292/commits","review_comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292/comments","review_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/1292/comments","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/bc8a0f5b0c1542df9a085c7adee89984816edc4d","head":{"label":"bitcoinjs:addWitnessBlock","ref":"addWitnessBlock","sha":"bc8a0f5b0c1542df9a085c7adee89984816edc4d","user":{"login":"bitcoinjs","id":756696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/756696?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxOTY4","name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","private":false,"owner":{"login":"bitcoinjs","id":756696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/756696?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"A javascript Bitcoin library for node.js and browsers.","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/deployments","created_at":"2011-05-04T16:03:45Z","updated_at":"2018-12-19T01:30:58Z","pushed_at":"2018-12-19T01:35:30Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"","size":3370,"stargazers_count":3188,"watchers_count":3188,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1148,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1148,"open_issues":36,"watchers":3188,"default_branch":"master"}},"base":{"label":"bitcoinjs:rewriteBlock","ref":"rewriteBlock","sha":"390db57f237194946d11696adfa7e2b7412107b5","user":{"login":"bitcoinjs","id":756696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/756696?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxOTY4","name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","private":false,"owner":{"login":"bitcoinjs","id":756696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjY5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/756696?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"A javascript Bitcoin library for node.js and browsers.","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/deployments","created_at":"2011-05-04T16:03:45Z","updated_at":"2018-12-19T01:30:58Z","pushed_at":"2018-12-19T01:35:30Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"","size":3370,"stargazers_count":3188,"watchers_count":3188,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1148,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1148,"open_issues":36,"watchers":3188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/1292"},"issue":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/1292"},"comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/1292/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/1292/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/bc8a0f5b0c1542df9a085c7adee89984816edc4d"}},"author_association":"MEMBER"}} | {
"id": 1701968,
"name": "bitcoinjs/bitcoinjs-lib",
"url": "https://api.github.com/repos/bitcoinjs/bitcoinjs-lib"
} | {
"id": 413395,
"login": "dcousens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/413395?",
"url": "https://api.github.com/users/dcousens"
} | {
"id": 756696,
"login": "bitcoinjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/756696?",
"url": "https://api.github.com/orgs/bitcoinjs"
} | 2018-12-19T01:51:35 | 8775993221 | {"actor":{"display_login":"dcousens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/comments/196257452","pull_request_review_id":129775809,"id":196257452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI1NzQ1Mg==","diff_hunk":"@@ -85,25 +85,23 @@ The domain name for Terraform Enterprise changed on 02/22 at 9AM from atlas.hash\n \n The fix is to update the OAuth Callback URL in your VCS provider to use app.terraform.io instead of atlas.hashicorp.com.\n \n-## Debugging Certificate Errors on Private Terraform Enterprise\n+## Certificate Errors on Private Terraform Enterprise\n \n-When debugging failures of VCS connections due to certifcate errors, it's sometime helpful to run the OpenSSL command within the TFE container to get more information.\n+When debugging failures of VCS connections due to certifcate errors, running additional diagnostics using the OpenSSL command may provide more information about the failure.\n \n-Attach a bash session to the PTFE container:\n+First, attach a bash session to the application container:\n \n ```\n docker exec -it ptfe_atlas sh -c \"stty rows 50 && stty cols 150 && bash\"\n ```\n \n-Then run the `openssl s_client` command, using the certificate from the container, and you'll be able to see the SSL connection, and any errors that come up.\n-\n-The certificate will be available under `/tmp/cust-ca-certificates.crt` in the container:\n+Then run the `openssl s_client` command, using the certificate at `/tmp/cust-ca-certificates.crt` in the container:\n \n ```\n openssl s_client -showcerts -CAfile /tmp/cust-ca-certificates.crt -connect git-server-hostname:443\n ```\n \n-For example, if my GitLab server was running self-signed certificates, I might get a `verify error:num=18:self signed certificate` log like so:\n+For example, the error `verify error:num=18:self signed certificate` might be returned if a GitLab server was running with a self-signed certificate. This example output is shown below.","path":"content/source/docs/enterprise/vcs/troubleshooting.html.md","position":27,"original_position":27,"commit_id":"5ac3e615703094f021a71eb52b7a922c6e23fc97","original_commit_id":"5ac3e615703094f021a71eb52b7a922c6e23fc97","user":{"login":"nfagerlund","id":484309,"node_id":"MDQ6VXNlcjQ4NDMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/484309?v=4","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"body":"Oh yeah, works for me! ","created_at":"2018-06-18T23:38:31Z","updated_at":"2018-06-18T23:38:31Z","html_url":"https://github.com/hashicorp/terraform-website/pull/326#discussion_r196257452","pull_request_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/comments/196257452"},"html":{"href":"https://github.com/hashicorp/terraform-website/pull/326#discussion_r196257452"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326"}},"in_reply_to_id":196253683},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326","id":195671225,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjcxMjI1","html_url":"https://github.com/hashicorp/terraform-website/pull/326","diff_url":"https://github.com/hashicorp/terraform-website/pull/326.diff","patch_url":"https://github.com/hashicorp/terraform-website/pull/326.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/326","number":326,"state":"open","locked":false,"title":"Small voice/clarity cleanup for the new cert troubleshooting section in VCS","user":{"login":"armchairlinguist","id":1274037,"node_id":"MDQ6VXNlcjEyNzQwMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1274037?v=4","gravatar_id":"","url":"https://api.github.com/users/armchairlinguist","html_url":"https://github.com/armchairlinguist","followers_url":"https://api.github.com/users/armchairlinguist/followers","following_url":"https://api.github.com/users/armchairlinguist/following{/other_user}","gists_url":"https://api.github.com/users/armchairlinguist/gists{/gist_id}","starred_url":"https://api.github.com/users/armchairlinguist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armchairlinguist/subscriptions","organizations_url":"https://api.github.com/users/armchairlinguist/orgs","repos_url":"https://api.github.com/users/armchairlinguist/repos","events_url":"https://api.github.com/users/armchairlinguist/events{/privacy}","received_events_url":"https://api.github.com/users/armchairlinguist/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-18T23:00:08Z","updated_at":"2018-06-18T23:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aa7248b28e0b7f3606f7647c3ed140f6544167e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/326/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform-website/statuses/5ac3e615703094f021a71eb52b7a922c6e23fc97","head":{"label":"hashicorp:vcs-cert-troubleshooting-nits","ref":"vcs-cert-troubleshooting-nits","sha":"5ac3e615703094f021a71eb52b7a922c6e23fc97","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":92349608,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM0OTYwOA==","name":"terraform-website","full_name":"hashicorp/terraform-website","owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform-website","description":"Prototype of Terraform website being assembled from multiple repositories","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform-website","forks_url":"https://api.github.com/repos/hashicorp/terraform-website/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform-website/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform-website/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform-website/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform-website/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform-website/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform-website/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform-website/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform-website/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform-website/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform-website/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform-website/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform-website/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform-website/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform-website/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform-website/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform-website/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform-website/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform-website/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform-website/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform-website/deployments","created_at":"2017-05-25T00:53:44Z","updated_at":"2018-06-18T23:03:08Z","pushed_at":"2018-06-18T23:31:46Z","git_url":"git://github.com/hashicorp/terraform-website.git","ssh_url":"git@github.com:hashicorp/terraform-website.git","clone_url":"https://github.com/hashicorp/terraform-website.git","svn_url":"https://github.com/hashicorp/terraform-website","homepage":null,"size":130484,"stargazers_count":25,"watchers_count":25,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":30,"watchers":25,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"86f3f7c6379bfea3c81893cb6a099a2360ec6ab7","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":92349608,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM0OTYwOA==","name":"terraform-website","full_name":"hashicorp/terraform-website","owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform-website","description":"Prototype of Terraform website being assembled from multiple repositories","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform-website","forks_url":"https://api.github.com/repos/hashicorp/terraform-website/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform-website/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform-website/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform-website/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform-website/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform-website/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform-website/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform-website/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform-website/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform-website/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform-website/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform-website/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform-website/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform-website/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform-website/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform-website/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform-website/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform-website/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform-website/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform-website/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform-website/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform-website/deployments","created_at":"2017-05-25T00:53:44Z","updated_at":"2018-06-18T23:03:08Z","pushed_at":"2018-06-18T23:31:46Z","git_url":"git://github.com/hashicorp/terraform-website.git","ssh_url":"git@github.com:hashicorp/terraform-website.git","clone_url":"https://github.com/hashicorp/terraform-website.git","svn_url":"https://github.com/hashicorp/terraform-website","homepage":null,"size":130484,"stargazers_count":25,"watchers_count":25,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":30,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326"},"html":{"href":"https://github.com/hashicorp/terraform-website/pull/326"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform-website/issues/326"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform-website/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform-website/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform-website/statuses/5ac3e615703094f021a71eb52b7a922c6e23fc97"}},"author_association":"CONTRIBUTOR"}} | {
"id": 92349608,
"name": "hashicorp/terraform-website",
"url": "https://api.github.com/repos/hashicorp/terraform-website"
} | {
"id": 484309,
"login": "nfagerlund",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/484309?",
"url": "https://api.github.com/users/nfagerlund"
} | {
"id": 761456,
"login": "hashicorp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/761456?",
"url": "https://api.github.com/orgs/hashicorp"
} | 2018-06-18T23:38:31 | 7842457598 | {"actor":{"display_login":"nfagerlund"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/187227354","pull_request_review_id":118964100,"id":187227354,"diff_hunk":"@@ -2130,13 +2130,15 @@ func authFromHelper(helperName string) authBackend {\n \t\thelper := dockerAuthHelperPrefix + helperName\n \t\tcmd := exec.Command(helper, \"get\")\n \n-\t\t// Ensure that the HTTPs prefix exists\n-\t\tif !strings.HasPrefix(repo, \"https://\") {\n-\t\t\trepo = fmt.Sprintf(\"https://%s\", repo)\n+\t\trepoInfo, err := parseRepositoryInfo(repo)\n+\t\tif err != nil {\n+\t\t\treturn nil, err\n \t\t}\n \n-\t\tcmd.Stdin = strings.NewReader(repo)\n+\t\t// Ensure that the HTTPs prefix exists\n+\t\trepoAddr := fmt.Sprintf(\"https://%s\", repoInfo.Hostname())","path":"client/driver/docker.go","position":14,"original_position":14,"commit_id":"bbb3d74744441e929a7daa4e530f6300714e6a4f","original_commit_id":"bbb3d74744441e929a7daa4e530f6300714e6a4f","user":{"login":"nickethier","id":766500,"avatar_url":"https://avatars0.githubusercontent.com/u/766500?v=4","gravatar_id":"","url":"https://api.github.com/users/nickethier","html_url":"https://github.com/nickethier","followers_url":"https://api.github.com/users/nickethier/followers","following_url":"https://api.github.com/users/nickethier/following{/other_user}","gists_url":"https://api.github.com/users/nickethier/gists{/gist_id}","starred_url":"https://api.github.com/users/nickethier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickethier/subscriptions","organizations_url":"https://api.github.com/users/nickethier/orgs","repos_url":"https://api.github.com/users/nickethier/repos","events_url":"https://api.github.com/users/nickethier/events{/privacy}","received_events_url":"https://api.github.com/users/nickethier/received_events","type":"User","site_admin":false},"body":"This is whats passed to the helper. The docs only ever show examples with https, but even some of the major cloud registry helpers like AWS ECR and Google GCR strip the https if it exists comming in and do the look up based solely on the domain name. \r\n\r\nhttps://github.com/awslabs/amazon-ecr-credential-helper/blob/master/ecr-login/api/client.go#L41-L43\r\n\r\nhttps://github.com/GoogleCloudPlatform/docker-credential-gcr/blob/master/credhelper/helper.go#L252:16","created_at":"2018-05-10T02:41:08Z","updated_at":"2018-05-10T02:41:08Z","html_url":"https://github.com/hashicorp/nomad/pull/4266#discussion_r187227354","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/187227354"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4266#discussion_r187227354"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4266"}},"in_reply_to_id":186954815},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/4266","id":186727921,"html_url":"https://github.com/hashicorp/nomad/pull/4266","diff_url":"https://github.com/hashicorp/nomad/pull/4266.diff","patch_url":"https://github.com/hashicorp/nomad/pull/4266.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/4266","number":4266,"state":"open","locked":false,"title":"client/driver: use correct repo address when using docker-credential helper","user":{"login":"nickethier","id":766500,"avatar_url":"https://avatars0.githubusercontent.com/u/766500?v=4","gravatar_id":"","url":"https://api.github.com/users/nickethier","html_url":"https://github.com/nickethier","followers_url":"https://api.github.com/users/nickethier/followers","following_url":"https://api.github.com/users/nickethier/following{/other_user}","gists_url":"https://api.github.com/users/nickethier/gists{/gist_id}","starred_url":"https://api.github.com/users/nickethier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickethier/subscriptions","organizations_url":"https://api.github.com/users/nickethier/orgs","repos_url":"https://api.github.com/users/nickethier/repos","events_url":"https://api.github.com/users/nickethier/events{/privacy}","received_events_url":"https://api.github.com/users/nickethier/received_events","type":"User","site_admin":false},"body":"Uses the server address instead of the image repo reference as the input to the docker-credentials helper.\r\n\r\nfixes #3818 \r\nfixes #4221 ","created_at":"2018-05-08T19:09:00Z","updated_at":"2018-05-10T02:41:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0350455bb6bd565f69ff5a12b4ddaa25d54f0f03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4266/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4266/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/4266/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/bbb3d74744441e929a7daa4e530f6300714e6a4f","head":{"label":"hashicorp:b-3818-gce-docker-cred-helper","ref":"b-3818-gce-docker-cred-helper","sha":"bbb3d74744441e929a7daa4e530f6300714e6a4f","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-05-09T23:27:14Z","pushed_at":"2018-05-09T23:27:12Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":100878,"stargazers_count":3489,"watchers_count":3489,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":693,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":693,"open_issues":344,"watchers":3489,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"e809eb560cb1d0232669e220769c5b6f9d000bab","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-05-09T23:27:14Z","pushed_at":"2018-05-09T23:27:12Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":100878,"stargazers_count":3489,"watchers_count":3489,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":693,"mirror_url":null,"archived":false,"open_issues_count":344,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":693,"open_issues":344,"watchers":3489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4266"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4266"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4266"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4266/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4266/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4266/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/bbb3d74744441e929a7daa4e530f6300714e6a4f"}},"author_association":"MEMBER"}} | {
"id": 36653430,
"name": "hashicorp/nomad",
"url": "https://api.github.com/repos/hashicorp/nomad"
} | {
"id": 766500,
"login": "nickethier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/766500?",
"url": "https://api.github.com/users/nickethier"
} | {
"id": 761456,
"login": "hashicorp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/761456?",
"url": "https://api.github.com/orgs/hashicorp"
} | 2018-05-10T02:41:08 | 7653234586 | {"actor":{"display_login":"nickethier"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/238505020","pull_request_review_id":181061875,"id":238505020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODUwNTAyMA==","diff_hunk":"@@ -424,6 +424,9 @@ func TestFingerprintManager_Run_Combination(t *testing.T) {\n \trequire := require.New(t)\n \n \ttestClient, cleanup := TestClient(t, func(c *config.Config) {\n+\t\t// delete nomad.version that may be baked in test node\n+\t\tdelete(c.Node.Attributes, \"nomad.version\")","path":"client/fingerprint_manager_test.go","position":null,"original_position":5,"commit_id":"431ebcb75857361bc87b21d7720ea2e4b44f7d6b","original_commit_id":"d69c408612e92ab346e368b18c88f08a74042637","user":{"login":"notnoop","id":136429,"node_id":"MDQ6VXNlcjEzNjQyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136429?v=4","gravatar_id":"","url":"https://api.github.com/users/notnoop","html_url":"https://github.com/notnoop","followers_url":"https://api.github.com/users/notnoop/followers","following_url":"https://api.github.com/users/notnoop/following{/other_user}","gists_url":"https://api.github.com/users/notnoop/gists{/gist_id}","starred_url":"https://api.github.com/users/notnoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnoop/subscriptions","organizations_url":"https://api.github.com/users/notnoop/orgs","repos_url":"https://api.github.com/users/notnoop/repos","events_url":"https://api.github.com/users/notnoop/events{/privacy}","received_events_url":"https://api.github.com/users/notnoop/received_events","type":"User","site_admin":false},"body":"Great - I agree - took it out of the PR.","created_at":"2018-12-04T01:49:19Z","updated_at":"2018-12-04T01:49:19Z","html_url":"https://github.com/hashicorp/nomad/pull/4948#discussion_r238505020","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4948","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/238505020"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4948#discussion_r238505020"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4948"}},"in_reply_to_id":238361377},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/4948","id":235499181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDk5MTgx","html_url":"https://github.com/hashicorp/nomad/pull/4948","diff_url":"https://github.com/hashicorp/nomad/pull/4948.diff","patch_url":"https://github.com/hashicorp/nomad/pull/4948.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/4948","number":4948,"state":"open","locked":false,"title":"tests: no t.Parallel() in table driven tests","user":{"login":"notnoop","id":136429,"node_id":"MDQ6VXNlcjEzNjQyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/136429?v=4","gravatar_id":"","url":"https://api.github.com/users/notnoop","html_url":"https://github.com/notnoop","followers_url":"https://api.github.com/users/notnoop/followers","following_url":"https://api.github.com/users/notnoop/following{/other_user}","gists_url":"https://api.github.com/users/notnoop/gists{/gist_id}","starred_url":"https://api.github.com/users/notnoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notnoop/subscriptions","organizations_url":"https://api.github.com/users/notnoop/orgs","repos_url":"https://api.github.com/users/notnoop/repos","events_url":"https://api.github.com/users/notnoop/events{/privacy}","received_events_url":"https://api.github.com/users/notnoop/received_events","type":"User","site_admin":false},"body":"When `t.Parallel()` is used inside a `t.Run()` sub-set, the closure\r\ndoesn't behave as expected, and some cases effectively get skipped.\r\nMore details can be found in https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721\r\n\r\nFWIW, the executor tests are currently failing consistently with this change, as libcontainer expects a rootfs with `/bin/{echo|date|date}` to be present but we construct an empty chroot now.\r\n\r\nAlso, a minor change to get `TestFingerprintManager_Run_Combination` test passing.","created_at":"2018-12-03T15:59:14Z","updated_at":"2018-12-04T01:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21a003d9cec816e876b8065d37c01a6f513d827b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4948/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/4948/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/4948/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/431ebcb75857361bc87b21d7720ea2e4b44f7d6b","head":{"label":"hashicorp:b-no-parallel-runs","ref":"b-no-parallel-runs","sha":"431ebcb75857361bc87b21d7720ea2e4b44f7d6b","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY1MzQzMA==","name":"nomad","full_name":"hashicorp/nomad","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-12-03T19:48:27Z","pushed_at":"2018-12-04T01:48:52Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":115179,"stargazers_count":4058,"watchers_count":4058,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":793,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":793,"open_issues":451,"watchers":4058,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"cd8c5c55bd60abc4cd2865e731b903904e421a5f","user":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"node_id":"MDEwOlJlcG9zaXRvcnkzNjY1MzQzMA==","name":"nomad","full_name":"hashicorp/nomad","private":false,"owner":{"login":"hashicorp","id":761456,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MTQ1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashicorp/nomad","description":"Nomad is a flexible, enterprise-grade cluster scheduler designed to easily integrate into existing workflows. Nomad can run a diverse workload of micro-service, batch, containerized and non-containerized applications. Nomad is easy to operate and scale and integrates seamlessly with Consul and Vault.","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2018-12-03T19:48:27Z","pushed_at":"2018-12-04T01:48:52Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":115179,"stargazers_count":4058,"watchers_count":4058,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":793,"mirror_url":null,"archived":false,"open_issues_count":451,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":793,"open_issues":451,"watchers":4058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4948"},"html":{"href":"https://github.com/hashicorp/nomad/pull/4948"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4948"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/4948/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4948/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/4948/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/431ebcb75857361bc87b21d7720ea2e4b44f7d6b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 36653430,
"name": "hashicorp/nomad",
"url": "https://api.github.com/repos/hashicorp/nomad"
} | {
"id": 136429,
"login": "notnoop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/136429?",
"url": "https://api.github.com/users/notnoop"
} | {
"id": 761456,
"login": "hashicorp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/761456?",
"url": "https://api.github.com/orgs/hashicorp"
} | 2018-12-04T01:49:19 | 8691540283 | {"actor":{"display_login":"notnoop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments/222381322","pull_request_review_id":161254587,"id":222381322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM4MTMyMg==","diff_hunk":"@@ -205,7 +211,12 @@ export default class DataStructureGenerator {\n \n let element;\n \n- if (schema.enum) {\n+ if (schema.$ref) {\n+ // element = new RefElement(idForDataStructure(schema.$ref));","path":"src/schema.js","position":35,"original_position":35,"commit_id":"b71d5eb2642ef44983ec01dac6899ec986b27185","original_commit_id":"b71d5eb2642ef44983ec01dac6899ec986b27185","user":{"login":"kylef","id":44164,"node_id":"MDQ6VXNlcjQ0MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/44164?v=4","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"IMO this should be a reference element. However doing so doesn't work with attributes kit 😞.","created_at":"2018-10-03T16:36:18Z","updated_at":"2018-10-03T16:36:18Z","html_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/214#discussion_r222381322","pull_request_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments/222381322"},"html":{"href":"https://github.com/apiaryio/fury-adapter-swagger/pull/214#discussion_r222381322"},"pull_request":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214","id":220101751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTAxNzUx","html_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/214","diff_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/214.diff","patch_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/214.patch","issue_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/214","number":214,"state":"open","locked":false,"title":"Generate dataStructure sections","user":{"login":"kylef","id":44164,"node_id":"MDQ6VXNlcjQ0MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/44164?v=4","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"Adds a dataStructures section to the parse result containing every data structure found within the definitions section of a Swagger document. We now use referencing between data structures found within a request or response data structure which generally makes parse results smaller instead of duplicating the data structure contents.\r\n\r\nEven though we are still using the referenced Swagger document for parsing, where possible I am retrieivng the schema found in the original Swagger document which hasn't been dereferenced, this won't work for every case, however it will work for most until the entire parser can handle the original document containing references.\r\n\r\n#### Dependencies\r\n\r\n- [ ] https://github.com/apiaryio/swagger-zoo/pull/70","created_at":"2018-10-03T16:30:30Z","updated_at":"2018-10-03T16:36:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4d06f1b610476f984e1849636622d9be53442e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214/commits","review_comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214/comments","review_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/214/comments","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/b71d5eb2642ef44983ec01dac6899ec986b27185","head":{"label":"apiaryio:kylef/data-structures","ref":"kylef/data-structures","sha":"b71d5eb2642ef44983ec01dac6899ec986b27185","user":{"login":"apiaryio","id":765943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/765943?v=4","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":42935158,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNTE1OA==","name":"fury-adapter-swagger","full_name":"apiaryio/fury-adapter-swagger","private":false,"owner":{"login":"apiaryio","id":765943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/765943?v=4","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apiaryio/fury-adapter-swagger","description":"Swagger 2.0 parser adapter for Fury.js","fork":false,"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger","forks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/forks","keys_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/teams","hooks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/events","assignees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/tags","blobs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/languages","stargazers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscription","commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/merges","archive_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/downloads","issues_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/deployments","created_at":"2015-09-22T13:24:29Z","updated_at":"2018-09-10T13:09:14Z","pushed_at":"2018-10-03T16:30:30Z","git_url":"git://github.com/apiaryio/fury-adapter-swagger.git","ssh_url":"git@github.com:apiaryio/fury-adapter-swagger.git","clone_url":"https://github.com/apiaryio/fury-adapter-swagger.git","svn_url":"https://github.com/apiaryio/fury-adapter-swagger","homepage":null,"size":658,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":26,"watchers":11,"default_branch":"master"}},"base":{"label":"apiaryio:master","ref":"master","sha":"2bebedd46182db0add240f0b94ac9c416b41437c","user":{"login":"apiaryio","id":765943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/765943?v=4","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":42935158,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNTE1OA==","name":"fury-adapter-swagger","full_name":"apiaryio/fury-adapter-swagger","private":false,"owner":{"login":"apiaryio","id":765943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/765943?v=4","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apiaryio/fury-adapter-swagger","description":"Swagger 2.0 parser adapter for Fury.js","fork":false,"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger","forks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/forks","keys_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/teams","hooks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/events","assignees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/tags","blobs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/languages","stargazers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscription","commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/merges","archive_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/downloads","issues_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/deployments","created_at":"2015-09-22T13:24:29Z","updated_at":"2018-09-10T13:09:14Z","pushed_at":"2018-10-03T16:30:30Z","git_url":"git://github.com/apiaryio/fury-adapter-swagger.git","ssh_url":"git@github.com:apiaryio/fury-adapter-swagger.git","clone_url":"https://github.com/apiaryio/fury-adapter-swagger.git","svn_url":"https://github.com/apiaryio/fury-adapter-swagger","homepage":null,"size":658,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":26,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214"},"html":{"href":"https://github.com/apiaryio/fury-adapter-swagger/pull/214"},"issue":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/214"},"comments":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/b71d5eb2642ef44983ec01dac6899ec986b27185"}},"author_association":"MEMBER"}} | {
"id": 42935158,
"name": "apiaryio/fury-adapter-swagger",
"url": "https://api.github.com/repos/apiaryio/fury-adapter-swagger"
} | {
"id": 44164,
"login": "kylef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44164?",
"url": "https://api.github.com/users/kylef"
} | {
"id": 765943,
"login": "apiaryio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/765943?",
"url": "https://api.github.com/orgs/apiaryio"
} | 2018-10-03T16:36:18 | 8362362028 | {"actor":{"display_login":"kylef"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/165817631","pull_request_review_id":93819725,"id":165817631,"diff_hunk":"@@ -193,6 +193,22 @@ protected override void OnStop()\n \t\t\tOnStateChanged();\n \t\t}\n \n+\t\tbool CanGoBack()\n+\t\t{\n+\t\t\tvar backPressed = BackPressed;","path":"Xamarin.Forms.Platform.Android/FormsApplicationActivity.cs","position":15,"original_position":15,"commit_id":"a9d676f18891e65ce3c58ff61bd4a3ba01f4a6cc","original_commit_id":"a9d676f18891e65ce3c58ff61bd4a3ba01f4a6cc","user":{"login":"rotorgames","id":1790504,"avatar_url":"https://avatars2.githubusercontent.com/u/1790504?v=4","gravatar_id":"","url":"https://api.github.com/users/rotorgames","html_url":"https://github.com/rotorgames","followers_url":"https://api.github.com/users/rotorgames/followers","following_url":"https://api.github.com/users/rotorgames/following{/other_user}","gists_url":"https://api.github.com/users/rotorgames/gists{/gist_id}","starred_url":"https://api.github.com/users/rotorgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotorgames/subscriptions","organizations_url":"https://api.github.com/users/rotorgames/orgs","repos_url":"https://api.github.com/users/rotorgames/repos","events_url":"https://api.github.com/users/rotorgames/events{/privacy}","received_events_url":"https://api.github.com/users/rotorgames/received_events","type":"User","site_admin":false},"body":"I can and if it is needed I will change it.","created_at":"2018-02-03T15:45:37Z","updated_at":"2018-02-03T15:45:37Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1757#discussion_r165817631","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/165817631"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/1757#discussion_r165817631"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757"}},"in_reply_to_id":165817088},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757","id":166213051,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1757","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/1757.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/1757.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1757","number":1757,"state":"open","locked":false,"title":"[Android] BackPressed preventing for an each event","user":{"login":"rotorgames","id":1790504,"avatar_url":"https://avatars2.githubusercontent.com/u/1790504?v=4","gravatar_id":"","url":"https://api.github.com/users/rotorgames","html_url":"https://github.com/rotorgames","followers_url":"https://api.github.com/users/rotorgames/followers","following_url":"https://api.github.com/users/rotorgames/following{/other_user}","gists_url":"https://api.github.com/users/rotorgames/gists{/gist_id}","starred_url":"https://api.github.com/users/rotorgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotorgames/subscriptions","organizations_url":"https://api.github.com/users/rotorgames/orgs","repos_url":"https://api.github.com/users/rotorgames/repos","events_url":"https://api.github.com/users/rotorgames/events{/privacy}","received_events_url":"https://api.github.com/users/rotorgames/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nI have [the library for xamarin forms](https://github.com/rotorgames/Rg.Plugins.Popup) and I should catch a back button event in my library and prevent it if it is needed. I have found the BackPressed events in FormsAppCompatActivity and FormsApplicationActivity and if I return `true` in these events the back button will not work. But it works only for the last delegate in the BackPressed event. I have fixed it. Each delegate will be invoked in the invocation list but if one in them returns true that the back button will not pop any pages.\r\n\r\nI think that a lot of people would like to use this feature in their libraries.\r\n\r\nI have not created any tests because it is simple changes.\r\n\r\nI needed to created two CanGoBack methods in FormsAppCompatActivity and FormsApplicationActivity because there are two delegates for the BackPressed events. Maybe you will have better solution.\r\n\r\n### Bugs Fixed ###\r\n\r\n- \r\n\r\n### API Changes ###\r\n\r\n-\r\n\r\nAdded:\r\n - private bool FormsAppCompatActivity.CanGoBack();\r\n - private bool FormsApplicationActivity.CanGoBack();\r\n\r\nChanged:\r\n - void FormsAppCompatActivity.OnBackPressed();\r\n - void FormsApplicationActivity.OnBackPressed();\r\n\r\n### Behavioral Changes ###\r\n\r\nNo changes\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [ ] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [ ] Consolidate commits as makes sense\r\n","created_at":"2018-01-31T09:59:30Z","updated_at":"2018-02-03T15:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba057000815b540fc34a479c0620c7a057be6a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1757/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/a9d676f18891e65ce3c58ff61bd4a3ba01f4a6cc","head":{"label":"rotorgames:android-back-pressed","ref":"android-back-pressed","sha":"a9d676f18891e65ce3c58ff61bd4a3ba01f4a6cc","user":{"login":"rotorgames","id":1790504,"avatar_url":"https://avatars2.githubusercontent.com/u/1790504?v=4","gravatar_id":"","url":"https://api.github.com/users/rotorgames","html_url":"https://github.com/rotorgames","followers_url":"https://api.github.com/users/rotorgames/followers","following_url":"https://api.github.com/users/rotorgames/following{/other_user}","gists_url":"https://api.github.com/users/rotorgames/gists{/gist_id}","starred_url":"https://api.github.com/users/rotorgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotorgames/subscriptions","organizations_url":"https://api.github.com/users/rotorgames/orgs","repos_url":"https://api.github.com/users/rotorgames/repos","events_url":"https://api.github.com/users/rotorgames/events{/privacy}","received_events_url":"https://api.github.com/users/rotorgames/received_events","type":"User","site_admin":false},"repo":{"id":69179949,"name":"Xamarin.Forms","full_name":"rotorgames/Xamarin.Forms","owner":{"login":"rotorgames","id":1790504,"avatar_url":"https://avatars2.githubusercontent.com/u/1790504?v=4","gravatar_id":"","url":"https://api.github.com/users/rotorgames","html_url":"https://github.com/rotorgames","followers_url":"https://api.github.com/users/rotorgames/followers","following_url":"https://api.github.com/users/rotorgames/following{/other_user}","gists_url":"https://api.github.com/users/rotorgames/gists{/gist_id}","starred_url":"https://api.github.com/users/rotorgames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotorgames/subscriptions","organizations_url":"https://api.github.com/users/rotorgames/orgs","repos_url":"https://api.github.com/users/rotorgames/repos","events_url":"https://api.github.com/users/rotorgames/events{/privacy}","received_events_url":"https://api.github.com/users/rotorgames/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rotorgames/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/rotorgames/Xamarin.Forms","forks_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/rotorgames/Xamarin.Forms/deployments","created_at":"2016-09-25T17:39:38Z","updated_at":"2016-09-25T17:39:43Z","pushed_at":"2018-01-31T09:42:11Z","git_url":"git://github.com/rotorgames/Xamarin.Forms.git","ssh_url":"git@github.com:rotorgames/Xamarin.Forms.git","clone_url":"https://github.com/rotorgames/Xamarin.Forms.git","svn_url":"https://github.com/rotorgames/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":34416,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"ae18666599f3bd243e987abdb0b2971c29577e38","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2018-02-03T06:06:14Z","pushed_at":"2018-02-02T22:02:50Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":38648,"stargazers_count":1891,"watchers_count":1891,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":801,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":801,"open_issues":275,"watchers":1891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/1757"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1757"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1757/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1757/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/a9d676f18891e65ce3c58ff61bd4a3ba01f4a6cc"}},"author_association":"NONE"}} | {
"id": 54213490,
"name": "xamarin/Xamarin.Forms",
"url": "https://api.github.com/repos/xamarin/Xamarin.Forms"
} | {
"id": 1790504,
"login": "rotorgames",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1790504?",
"url": "https://api.github.com/users/rotorgames"
} | {
"id": 790012,
"login": "xamarin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/790012?",
"url": "https://api.github.com/orgs/xamarin"
} | 2018-02-03T15:45:37 | 7193361176 | {"actor":{"display_login":"rotorgames"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/comments/232362962","pull_request_review_id":173552049,"id":232362962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM2Mjk2Mg==","diff_hunk":"@@ -55,6 +55,14 @@ foreach (var type in new [] {\n TH<#=tname#>Storage_free (handle);\n return true;\n }\n+\n+ protected override void Dispose(bool disposing)","path":"TorchSharp/TypeGeneration.tt","position":5,"original_position":5,"commit_id":"d8cdbbfaddad62bb3d1b07f556e6e28beed30a83","original_commit_id":"fda44294dee672b95221845d374be2b68d50b7d4","user":{"login":"interesaaat","id":1534199,"node_id":"MDQ6VXNlcjE1MzQxOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1534199?v=4","gravatar_id":"","url":"https://api.github.com/users/interesaaat","html_url":"https://github.com/interesaaat","followers_url":"https://api.github.com/users/interesaaat/followers","following_url":"https://api.github.com/users/interesaaat/following{/other_user}","gists_url":"https://api.github.com/users/interesaaat/gists{/gist_id}","starred_url":"https://api.github.com/users/interesaaat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interesaaat/subscriptions","organizations_url":"https://api.github.com/users/interesaaat/orgs","repos_url":"https://api.github.com/users/interesaaat/repos","events_url":"https://api.github.com/users/interesaaat/events{/privacy}","received_events_url":"https://api.github.com/users/interesaaat/received_events","type":"User","site_admin":false},"body":"Looking online it seems that without Dispose the handler can be randomly cleaned up when the GC decides so. With Dispose instead the handles will be disposed only at the end (or when Dispose is explicitly called). Apparently without Dispose the GC cleans the handles earlier then it should. ","created_at":"2018-11-09T19:14:39Z","updated_at":"2018-11-09T19:14:40Z","html_url":"https://github.com/xamarin/TorchSharp/pull/60#discussion_r232362962","pull_request_url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/comments/232362962"},"html":{"href":"https://github.com/xamarin/TorchSharp/pull/60#discussion_r232362962"},"pull_request":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60"}},"in_reply_to_id":232321707},"pull_request":{"url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60","id":229549413,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTQ5NDEz","html_url":"https://github.com/xamarin/TorchSharp/pull/60","diff_url":"https://github.com/xamarin/TorchSharp/pull/60.diff","patch_url":"https://github.com/xamarin/TorchSharp/pull/60.patch","issue_url":"https://api.github.com/repos/xamarin/TorchSharp/issues/60","number":60,"state":"open","locked":false,"title":"More file read/write APIs.","user":{"login":"NiklasGustafsson","id":1791495,"node_id":"MDQ6VXNlcjE3OTE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1791495?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasGustafsson","html_url":"https://github.com/NiklasGustafsson","followers_url":"https://api.github.com/users/NiklasGustafsson/followers","following_url":"https://api.github.com/users/NiklasGustafsson/following{/other_user}","gists_url":"https://api.github.com/users/NiklasGustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasGustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasGustafsson/subscriptions","organizations_url":"https://api.github.com/users/NiklasGustafsson/orgs","repos_url":"https://api.github.com/users/NiklasGustafsson/repos","events_url":"https://api.github.com/users/NiklasGustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasGustafsson/received_events","type":"User","site_admin":false},"body":"Adding file read/write API.\r\nFixed a memory allocation bug.\r\nAdded a few tests.\r\n","created_at":"2018-11-09T00:07:48Z","updated_at":"2018-11-09T19:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5c746d0838975374ca571615028cdea9f306b56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60/commits","review_comments_url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60/comments","review_comment_url":"https://api.github.com/repos/xamarin/TorchSharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/TorchSharp/issues/60/comments","statuses_url":"https://api.github.com/repos/xamarin/TorchSharp/statuses/d8cdbbfaddad62bb3d1b07f556e6e28beed30a83","head":{"label":"NiklasGustafsson:morefiles","ref":"morefiles","sha":"d8cdbbfaddad62bb3d1b07f556e6e28beed30a83","user":{"login":"NiklasGustafsson","id":1791495,"node_id":"MDQ6VXNlcjE3OTE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1791495?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasGustafsson","html_url":"https://github.com/NiklasGustafsson","followers_url":"https://api.github.com/users/NiklasGustafsson/followers","following_url":"https://api.github.com/users/NiklasGustafsson/following{/other_user}","gists_url":"https://api.github.com/users/NiklasGustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasGustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasGustafsson/subscriptions","organizations_url":"https://api.github.com/users/NiklasGustafsson/orgs","repos_url":"https://api.github.com/users/NiklasGustafsson/repos","events_url":"https://api.github.com/users/NiklasGustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasGustafsson/received_events","type":"User","site_admin":false},"repo":{"id":155768437,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3Njg0Mzc=","name":"TorchSharp","full_name":"NiklasGustafsson/TorchSharp","private":false,"owner":{"login":"NiklasGustafsson","id":1791495,"node_id":"MDQ6VXNlcjE3OTE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1791495?v=4","gravatar_id":"","url":"https://api.github.com/users/NiklasGustafsson","html_url":"https://github.com/NiklasGustafsson","followers_url":"https://api.github.com/users/NiklasGustafsson/followers","following_url":"https://api.github.com/users/NiklasGustafsson/following{/other_user}","gists_url":"https://api.github.com/users/NiklasGustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/NiklasGustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiklasGustafsson/subscriptions","organizations_url":"https://api.github.com/users/NiklasGustafsson/orgs","repos_url":"https://api.github.com/users/NiklasGustafsson/repos","events_url":"https://api.github.com/users/NiklasGustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/NiklasGustafsson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NiklasGustafsson/TorchSharp","description":".NET bindings for the Pytorch engine","fork":true,"url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp","forks_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/forks","keys_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/teams","hooks_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/hooks","issue_events_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/issues/events{/number}","events_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/events","assignees_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/assignees{/user}","branches_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/branches{/branch}","tags_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/tags","blobs_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/languages","stargazers_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/stargazers","contributors_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/contributors","subscribers_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/subscribers","subscription_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/subscription","commits_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/contents/{+path}","compare_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/merges","archive_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/downloads","issues_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/issues{/number}","pulls_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/labels{/name}","releases_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/releases{/id}","deployments_url":"https://api.github.com/repos/NiklasGustafsson/TorchSharp/deployments","created_at":"2018-11-01T19:56:01Z","updated_at":"2018-11-09T00:28:06Z","pushed_at":"2018-11-09T18:22:20Z","git_url":"git://github.com/NiklasGustafsson/TorchSharp.git","ssh_url":"git@github.com:NiklasGustafsson/TorchSharp.git","clone_url":"https://github.com/NiklasGustafsson/TorchSharp.git","svn_url":"https://github.com/NiklasGustafsson/TorchSharp","homepage":null,"size":1207,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"96ff09c08928603d820c2225a3a5ce3954db267b","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":152770407,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NzA0MDc=","name":"TorchSharp","full_name":"xamarin/TorchSharp","private":false,"owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xamarin/TorchSharp","description":".NET bindings for the Pytorch engine","fork":false,"url":"https://api.github.com/repos/xamarin/TorchSharp","forks_url":"https://api.github.com/repos/xamarin/TorchSharp/forks","keys_url":"https://api.github.com/repos/xamarin/TorchSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/TorchSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/TorchSharp/teams","hooks_url":"https://api.github.com/repos/xamarin/TorchSharp/hooks","issue_events_url":"https://api.github.com/repos/xamarin/TorchSharp/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/TorchSharp/events","assignees_url":"https://api.github.com/repos/xamarin/TorchSharp/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/TorchSharp/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/TorchSharp/tags","blobs_url":"https://api.github.com/repos/xamarin/TorchSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/TorchSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/TorchSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/TorchSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/TorchSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/TorchSharp/languages","stargazers_url":"https://api.github.com/repos/xamarin/TorchSharp/stargazers","contributors_url":"https://api.github.com/repos/xamarin/TorchSharp/contributors","subscribers_url":"https://api.github.com/repos/xamarin/TorchSharp/subscribers","subscription_url":"https://api.github.com/repos/xamarin/TorchSharp/subscription","commits_url":"https://api.github.com/repos/xamarin/TorchSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/TorchSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/TorchSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/TorchSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/TorchSharp/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/TorchSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/TorchSharp/merges","archive_url":"https://api.github.com/repos/xamarin/TorchSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/TorchSharp/downloads","issues_url":"https://api.github.com/repos/xamarin/TorchSharp/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/TorchSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/TorchSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/TorchSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/TorchSharp/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/TorchSharp/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/TorchSharp/deployments","created_at":"2018-10-12T15:20:45Z","updated_at":"2018-11-09T03:04:23Z","pushed_at":"2018-11-09T18:22:21Z","git_url":"git://github.com/xamarin/TorchSharp.git","ssh_url":"git@github.com:xamarin/TorchSharp.git","clone_url":"https://github.com/xamarin/TorchSharp.git","svn_url":"https://github.com/xamarin/TorchSharp","homepage":null,"size":1070,"stargazers_count":35,"watchers_count":35,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":20,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60"},"html":{"href":"https://github.com/xamarin/TorchSharp/pull/60"},"issue":{"href":"https://api.github.com/repos/xamarin/TorchSharp/issues/60"},"comments":{"href":"https://api.github.com/repos/xamarin/TorchSharp/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/TorchSharp/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/TorchSharp/statuses/d8cdbbfaddad62bb3d1b07f556e6e28beed30a83"}},"author_association":"CONTRIBUTOR"}} | {
"id": 152770407,
"name": "xamarin/TorchSharp",
"url": "https://api.github.com/repos/xamarin/TorchSharp"
} | {
"id": 1534199,
"login": "interesaaat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1534199?",
"url": "https://api.github.com/users/interesaaat"
} | {
"id": 790012,
"login": "xamarin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/790012?",
"url": "https://api.github.com/orgs/xamarin"
} | 2018-11-09T19:14:39 | 8565243255 | {"actor":{"display_login":"interesaaat"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/241547001","pull_request_review_id":184849425,"id":241547001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU0NzAwMQ==","diff_hunk":"@@ -0,0 +1,196 @@\n+/* eslint-disable no-undef, no-unused-vars */\n+import * as _ from 'lodash-es';\n+import * as React from 'react';\n+import * as fuzzy from 'fuzzysearch';\n+\n+import { Firehose, LoadingInline, Dropdown, ResourceName, ResourceIcon } from '.';\n+\n+/* Component StorageClassDropdown - creates a dropdown list of storage classes */\n+\n+class StorageClassDropdown_ extends React.Component<StorageClassDropdownProps, StorageClassDropdownState> {\n+ readonly state: StorageClassDropdownState = {\n+ items: {},\n+ name: this.props.name,\n+ selectedKey: null,\n+ title: <LoadingInline />,\n+ defaultClass: null,\n+ };\n+\n+ componentWillMount() {\n+ this.componentWillReceiveProps(this.props);\n+ }\n+\n+ componentWillReceiveProps(nextProps) {\n+ const { loaded, loadError, resources } = nextProps;\n+\n+ if (loadError) {\n+ this.setState({\n+ title: (\n+ <div className=\"cos-error-title\">Error Loading {nextProps.desc}</div>\n+ ),\n+ });\n+ return;\n+ }\n+ if (!loaded) {\n+ return;\n+ }\n+\n+ const state = {\n+ items: {},\n+ title: {},\n+ defaultClass: '',\n+ };\n+ const unorderedItems = {};\n+ const noStorageClass = 'No storage class';\n+ _.each(resources, ({ data }, kindLabel) => {\n+ _.reduce(","path":"frontend/public/components/utils/storage-class-dropdown.tsx","position":46,"original_position":46,"commit_id":"7948a94a7241e858bccddde78082b23f4f034a10","original_commit_id":"7948a94a7241e858bccddde78082b23f4f034a10","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"This seems like it should be a `_.map`","created_at":"2018-12-13T20:15:54Z","updated_at":"2018-12-13T20:20:28Z","html_url":"https://github.com/openshift/console/pull/812#discussion_r241547001","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/812","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/241547001"},"html":{"href":"https://github.com/openshift/console/pull/812#discussion_r241547001"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/812"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/812","id":230944381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTQ0Mzgx","html_url":"https://github.com/openshift/console/pull/812","diff_url":"https://github.com/openshift/console/pull/812.diff","patch_url":"https://github.com/openshift/console/pull/812.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/812","number":812,"state":"open","locked":false,"title":"Update Create PVC form with UXD suggested changes","user":{"login":"zherman0","id":18728857,"node_id":"MDQ6VXNlcjE4NzI4ODU3","avatar_url":"https://avatars0.githubusercontent.com/u/18728857?v=4","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"body":"We have some feedback on how to make the Create PVC form better and this change addresses that:\r\n1) Change name from Create Storage to Create Persistent Volume Claim\r\n2) Add more details about the storage classes in the dropdown selector (this required creating new dropdown component)\r\n\r\n\r\n3) Disable radio buttons if storage class is selected that has accessMode defined\r\n(Note: Hard to see that the radios are disabled in picture below, but they are with the storage class's accessMode selected)\r\n\r\n\r\n4) Added default storage class handling. The default storage class is identified as \"(default)\" in the dropdown. Also, we update the help message. \r\n\r\n\r\n","created_at":"2018-11-14T18:55:31Z","updated_at":"2018-12-13T20:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c585a13ba69325a1e8bc45e7397648953e438c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926924366,"node_id":"MDU6TGFiZWw5MjY5MjQzNjY=","url":"https://api.github.com/repos/openshift/console/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/812/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/812/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/812/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/7948a94a7241e858bccddde78082b23f4f034a10","head":{"label":"zherman0:con1001","ref":"con1001","sha":"7948a94a7241e858bccddde78082b23f4f034a10","user":{"login":"zherman0","id":18728857,"node_id":"MDQ6VXNlcjE4NzI4ODU3","avatar_url":"https://avatars0.githubusercontent.com/u/18728857?v=4","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"repo":{"id":140342837,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzNDI4Mzc=","name":"console","full_name":"zherman0/console","private":false,"owner":{"login":"zherman0","id":18728857,"node_id":"MDQ6VXNlcjE4NzI4ODU3","avatar_url":"https://avatars0.githubusercontent.com/u/18728857?v=4","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zherman0/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/zherman0/console","forks_url":"https://api.github.com/repos/zherman0/console/forks","keys_url":"https://api.github.com/repos/zherman0/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zherman0/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zherman0/console/teams","hooks_url":"https://api.github.com/repos/zherman0/console/hooks","issue_events_url":"https://api.github.com/repos/zherman0/console/issues/events{/number}","events_url":"https://api.github.com/repos/zherman0/console/events","assignees_url":"https://api.github.com/repos/zherman0/console/assignees{/user}","branches_url":"https://api.github.com/repos/zherman0/console/branches{/branch}","tags_url":"https://api.github.com/repos/zherman0/console/tags","blobs_url":"https://api.github.com/repos/zherman0/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zherman0/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zherman0/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/zherman0/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zherman0/console/statuses/{sha}","languages_url":"https://api.github.com/repos/zherman0/console/languages","stargazers_url":"https://api.github.com/repos/zherman0/console/stargazers","contributors_url":"https://api.github.com/repos/zherman0/console/contributors","subscribers_url":"https://api.github.com/repos/zherman0/console/subscribers","subscription_url":"https://api.github.com/repos/zherman0/console/subscription","commits_url":"https://api.github.com/repos/zherman0/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/zherman0/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/zherman0/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/zherman0/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/zherman0/console/contents/{+path}","compare_url":"https://api.github.com/repos/zherman0/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zherman0/console/merges","archive_url":"https://api.github.com/repos/zherman0/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zherman0/console/downloads","issues_url":"https://api.github.com/repos/zherman0/console/issues{/number}","pulls_url":"https://api.github.com/repos/zherman0/console/pulls{/number}","milestones_url":"https://api.github.com/repos/zherman0/console/milestones{/number}","notifications_url":"https://api.github.com/repos/zherman0/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zherman0/console/labels{/name}","releases_url":"https://api.github.com/repos/zherman0/console/releases{/id}","deployments_url":"https://api.github.com/repos/zherman0/console/deployments","created_at":"2018-07-09T21:14:08Z","updated_at":"2018-11-30T18:50:12Z","pushed_at":"2018-12-13T20:02:01Z","git_url":"git://github.com/zherman0/console.git","ssh_url":"git@github.com:zherman0/console.git","clone_url":"https://github.com/zherman0/console.git","svn_url":"https://github.com/zherman0/console","homepage":"https://www.openshift.org","size":89295,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5f9f45c64c8c4c776fa740e32163a8b506d02760","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-12-13T19:51:54Z","pushed_at":"2018-12-13T20:10:00Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":89584,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":42,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/812"},"html":{"href":"https://github.com/openshift/console/pull/812"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/812"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/812/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/812/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/812/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/7948a94a7241e858bccddde78082b23f4f034a10"}},"author_association":"MEMBER"}} | {
"id": 129436456,
"name": "openshift/console",
"url": "https://api.github.com/repos/openshift/console"
} | {
"id": 1167259,
"login": "spadgett",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1167259?",
"url": "https://api.github.com/users/spadgett"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2018-12-13T20:15:54 | 8750814117 | {"actor":{"display_login":"spadgett"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/171934663","pull_request_review_id":100879281,"id":171934663,"diff_hunk":"@@ -0,0 +1,225 @@\n+# Service Bundle Specification\n+\n+A Service Bundle is a container image that the broker can use to manage\n+deployment of a service in a cluster. It adheres to the properties and\n+behaviors described below.\n+\n+## Label\n+\n+Every service bundle container image has a label ‘com.redhat.apb.spec’ that\n+contains a base64 encoded string. This label holds [important\n+metadata](https://github.com/ansibleplaybookbundle/ansible-playbook-bundle/blob/master/docs/developers.md#apb-spec-file)\n+related to the service bundle. Example:\n+\n+```\n+version: 1.0 # The version of the Service Bundle Spec being conformed to\n+name: example-apb # The name of the Service Bundle\n+description: # A short description of the Service Bundle\n+bindable: True # Whether this Service Bundle can be bound to other services\n+async: optional # Does this Service Bundle support asynchronous provision\n+metadata: \n+ documentationUrl: <link to documentation>\n+ imageUrl: <link to URL of image>\n+ dependencies:\n+ - '<registry>/<organization>/<dependency-name-1>' \n+ - '<registry>/<organization>/<dependency-name-2>'\n+ displayName: Example App (APB)\n+ longDescription: A longer description of what this APB does\n+ providerDisplayName: \"Red Hat, Inc.\"\n+plans: # An array of plans supported by this Service Bundle (must have at least 1)\n+ - name: default\n+ description: A short description of what this plan does\n+ free: true\n+ metadata:\n+ displayName: Default\n+ longDescription: A longer description of what this plan deploys\n+ cost: $0.00\n+ Parameters: # Parameters for this plan\n+ - name: parameter_one\n+ required: true\n+ default: foo_string\n+ type: string\n+ title: Parameter One\n+ maxlength: 63\n+ - name: parameter_two\n+ required: true\n+ default: true\n+ title: Parameter Two\n+ type: boolean\n+```\n+\n+## Input\n+\n+The container is run with three arguments.\n+\n+* Action: a single word such as “provision”. The full list is below.\n+* --extra-vars: This is ansible-specific and always has exactly the value\n+ “--extra-vars”. An Ansible Playbook Bundle uses this and the third argument\n+ as-is when calling ansible by appending them to the ansible command.\n+* JSON: a json document of information that is useful to the bundle. Currently\n+ it is expressed in a form that is useful for populating variables in ansible\n+ that can be used by roles.\n+\n+### Actions\n+\n+Possible actions include\n+* provision\n+* deprovision\n+* bind\n+* unbind\n+* update\n+* test\n+\n+### JSON\n+Example of JSON document passed to __provision__:\n+\n+```\n+{\n+ \"cluster\": \"openshift\",\n+ \"_apb_plan_id\": \"default\",\n+ \"_apb_service_class_id\": \"c23ec213bb8dea1577230c5ce005b9c2\",\n+ \"_apb_service_instance_id\": \"54636ad3-0378-49a1-a494-f97d0a0daf8e\",\n+ \"mediawiki_admin_pass\": \"pass\",\n+ \"mediawiki_admin_user\": \"admin\",\n+ \"mediawiki_db_schema\": \"mediawiki\",\n+ \"mediawiki_site_lang\": \"en\",\n+ \"mediawiki_site_name\": \"MediaWiki\",\n+ \"namespace\": \"bazproject\"\n+}\n+```\n+\n+* cluster: the type of cluster on which the service bundle is being run\n+ (currently either ‘openshift’ or ‘kubernetes’).\n+* _apb_plan_id: the name of a “plan”, as defined through the OSB API, that is\n+ available on the service class.\n+* _apb_service_class_id: the “service_id”, as defined through the OSB API, that\n+ is being used for the current action.\n+* _apb_service_instance_id: the “instance_id”, as defined through the OSB API,\n+ that uniquely identifies the service instance being acted upon.\n+* namespace: the target namespace in which resources should be created,\n+ deleted, or acted upon.\n+\n+Other keys represent parameter names from the Plan, the values for which have\n+the type specified in the Plan.\n+\n+Example of JSON document passed to __bind__:\n+\n+```\n+{\n+ \"_apb_plan_id\": \"dev\",\n+ \"_apb_provision_creds\": {\n+ \"DB_ADMIN_PASSWORD\": \"yiX2hXH7RU24RTVRXuye\",\n+ \"DB_HOST\": \"postgresql\",\n+ \"DB_NAME\": \"foo\",\n+ \"DB_PASSWORD\": \"letmein\",\n+ \"DB_PORT\": \"5432\",\n+ \"DB_TYPE\": \"postgres\",\n+ \"DB_USER\": \"bar\"\n+ },\n+ \"_apb_service_class_id\": \"1dda1477cace09730bd8ed7a6505607e\",\n+ \"_apb_service_instance_id\": \"d6ac6b10-fbff-4944-8e6b-3478313e20d1\",\n+ \"cluster\": \"kubernetes\",\n+ \"namespace\": \"default\"\n+}\n+```\n+\n+* _apb_provision_creds: A set of credentials and related data created during a\n+ provision action for this service instance. Details are below in the Output\n+ section.\n+\n+### Environment Variables\n+\n+The following environment variables are set by the broker:\n+\n+* __POD_NAMESPACE__: the namespace in which the service bundle is being run\n+* __POD_NAME__: the name of the pod \n+\n+## Output\n+\n+### stdout / stderr\n+\n+These are ignored.\n+\n+### Exit Code\n+\n+* 0 - success\n+* 1 - error\n+* 8 - action not implemented/supported\n+\n+### Encoded Credentials\n+\n+Binding credentials may be returned during a provision or bind operation by\n+creating a named secret (POD_NAME) in the sandbox namespace (POD_NAMESPACE).\n+The secret should have a single key called “fields” whose value is a\n+base64-encoded JSON document.\n+\n+Ansible Playbook Bundles use the “asb_encode_binding” module to do this.\n+\n+```\n+apiVersion: v1\n+data:\n+ fields: eyJEQl9OQU1FIjogImZvbyIsICJEQl9QQVNTV09SRCI6ICJsZXRtZWluIiwgIkRCX1RZUEUiOiAicG9zdGdyZXMiLCAiREJfUE9SVCI6ICI1NDMyIiwgIkRCX1VTRVIiOiAiYmFyIiwgIkRCX0hPU1QiOiAicG9zdGdyZXNxbCJ9\n+kind: Secret\n+metadata:\n+ creationTimestamp: 2018-02-26T18:34:50Z\n+ name: apb-874ae78d-acfe-4181-b064-124d6e13c592\n+ namespace: dh-postgresql-apb-prov-md5xt\n+ resourceVersion: \"11846\"\n+ selfLink: /api/v1/namespaces/dh-postgresql-apb-prov-md5xt/secrets/apb-874ae78d-acfe-4181-b064-124d6e13c592\n+ uid: ba79e27a-1b23-11e8-aebf-94b96c9ea8ca\n+type: Opaque\n+```\n+\n+The value for “fields” is a base64-encoded JSON document whose keys and values\n+represent any data the APB wants to return to the broker and ultimately to a\n+client that retrieves a binding.\n+\n+__Provision Credentials__ - If a service bundle saves such a secret during the\n+provision operation, the broker saves the passed data as “provision\n+credentials”. That data gets passed into all further actions as part of the\n+JSON document under the key ``_apb_provision_creds``, as a sub-document. As such,\n+it can be useful for making root-level credentials created during provision\n+available to other operations that need to use them. If a request for non-async\n+binding is made and the bundle does not run, any “provision credentials” that\n+were saved will be returned to the client as binding credentials.\n+\n+__Binding Credentials__ - If a service bundle saves such a secret during the bind\n+operation, the broker saves the passed data as “binding credentials”. These\n+credentials get returned to the client that initiated that specific binding\n+operation.\n+\n+## Runtime\n+\n+The container will be run in a pod by itself with ``restartPolicy: Never``. The\n+pod will run in a sandbox namespace created by the broker for that specific\n+operation only. The namespace will be deleted at some point after the pod\n+finishes.\n+\n+APB is run with a service account granted access to the ``POD_NAMESPACE`` and\n+to the “namespace” that the pod is to deploy to. Networks between the two\n+namespaces are tied together so that you can reliably find your services in the\n+target namespace. That only works for\n+[NetworkPolicy](https://kubernetes.io/docs/concepts/services-networking/network-policies/)\n+or for multi tenant openshift-sdn.\n+\n+### Proxy\n+\n+If there are proxy settings for the broker, they will be forwarded to the pod\n+by setting environment variables for ``HTTP_PROXY``, ``HTTPS_PROXY``, and\n+``NO_PROXY``. \n+\n+### Service Account\n+\n+Details of a kubernetes service account are mounted at\n+``/var/run/secrets/kubernetes.io/serviceaccount``\n+\n+Keys contained in the Secret:\n+\n+* ca.crt: a base64-encoded CA certificate that was used to sign the certificate","path":"docs/service-bundle.md","position":218,"original_position":218,"commit_id":"7c8ac77a5efa61e71f1c720770cd69c1b1aff2bb","original_commit_id":"7c8ac77a5efa61e71f1c720770cd69c1b1aff2bb","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars2.githubusercontent.com/u/53091?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"body":"Does the broker mount this information to this location? Or is it something kubernetes is doing automatically for some reason?","created_at":"2018-03-02T19:04:36Z","updated_at":"2018-03-02T19:04:36Z","html_url":"https://github.com/openshift/ansible-service-broker/pull/808#discussion_r171934663","pull_request_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/171934663"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/808#discussion_r171934663"},"pull_request":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808"}},"in_reply_to_id":171664119},"pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808","id":172311334,"html_url":"https://github.com/openshift/ansible-service-broker/pull/808","diff_url":"https://github.com/openshift/ansible-service-broker/pull/808.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/808.patch","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/808","number":808,"state":"open","locked":false,"title":"Adds Service Bundle contract document","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars2.githubusercontent.com/u/53091?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"body":"This document captures a detailed description of the existing contract between a Service Bundle and the Automation Broker.\r\n\r\nPlease review how accurately this represents the current relationship between a Service Bundle and the Automation Broker as implemented today. Please do not (yet) review the technical merits of this design. Once this document is reviewed and accepted as an accurate representation of reality, a next step will be to review the design on technical grounds and look for opportunities to improve it.","created_at":"2018-03-01T18:05:33Z","updated_at":"2018-03-02T19:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b821848d29926f34753beeb25d63b2d63320d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dymurray","id":16140195,"avatar_url":"https://avatars2.githubusercontent.com/u/16140195?v=4","gravatar_id":"","url":"https://api.github.com/users/dymurray","html_url":"https://github.com/dymurray","followers_url":"https://api.github.com/users/dymurray/followers","following_url":"https://api.github.com/users/dymurray/following{/other_user}","gists_url":"https://api.github.com/users/dymurray/gists{/gist_id}","starred_url":"https://api.github.com/users/dymurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymurray/subscriptions","organizations_url":"https://api.github.com/users/dymurray/orgs","repos_url":"https://api.github.com/users/dymurray/repos","events_url":"https://api.github.com/users/dymurray/events{/privacy}","received_events_url":"https://api.github.com/users/dymurray/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596440442,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/docs","name":"docs","color":"c5def5","default":false},{"id":711534248,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808/commits","review_comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808/comments","review_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/808/comments","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/7c8ac77a5efa61e71f1c720770cd69c1b1aff2bb","head":{"label":"mhrivnak:service-bundle-doc","ref":"service-bundle-doc","sha":"7c8ac77a5efa61e71f1c720770cd69c1b1aff2bb","user":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars2.githubusercontent.com/u/53091?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"repo":{"id":113328650,"name":"ansible-service-broker","full_name":"mhrivnak/ansible-service-broker","owner":{"login":"mhrivnak","id":53091,"avatar_url":"https://avatars2.githubusercontent.com/u/53091?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrivnak","html_url":"https://github.com/mhrivnak","followers_url":"https://api.github.com/users/mhrivnak/followers","following_url":"https://api.github.com/users/mhrivnak/following{/other_user}","gists_url":"https://api.github.com/users/mhrivnak/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrivnak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrivnak/subscriptions","organizations_url":"https://api.github.com/users/mhrivnak/orgs","repos_url":"https://api.github.com/users/mhrivnak/repos","events_url":"https://api.github.com/users/mhrivnak/events{/privacy}","received_events_url":"https://api.github.com/users/mhrivnak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhrivnak/ansible-service-broker","description":"Ansible Service Broker","fork":true,"url":"https://api.github.com/repos/mhrivnak/ansible-service-broker","forks_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/mhrivnak/ansible-service-broker/deployments","created_at":"2017-12-06T14:48:13Z","updated_at":"2017-12-06T14:48:15Z","pushed_at":"2018-03-01T17:59:02Z","git_url":"git://github.com/mhrivnak/ansible-service-broker.git","ssh_url":"git@github.com:mhrivnak/ansible-service-broker.git","clone_url":"https://github.com/mhrivnak/ansible-service-broker.git","svn_url":"https://github.com/mhrivnak/ansible-service-broker","homepage":null,"size":77375,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6b5cf4ba67f89698786f6ddc6c16662410d20b9e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":79371528,"name":"ansible-service-broker","full_name":"openshift/ansible-service-broker","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/ansible-service-broker","description":"Ansible Service Broker","fork":false,"url":"https://api.github.com/repos/openshift/ansible-service-broker","forks_url":"https://api.github.com/repos/openshift/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/openshift/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/openshift/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/openshift/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/openshift/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/openshift/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/openshift/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/openshift/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/ansible-service-broker/deployments","created_at":"2017-01-18T18:40:49Z","updated_at":"2018-03-01T20:10:19Z","pushed_at":"2018-03-02T15:47:01Z","git_url":"git://github.com/openshift/ansible-service-broker.git","ssh_url":"git@github.com:openshift/ansible-service-broker.git","clone_url":"https://github.com/openshift/ansible-service-broker.git","svn_url":"https://github.com/openshift/ansible-service-broker","homepage":null,"size":77413,"stargazers_count":91,"watchers_count":91,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":47,"open_issues":38,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/808"},"issue":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/808"},"comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/7c8ac77a5efa61e71f1c720770cd69c1b1aff2bb"}},"author_association":"MEMBER"}} | {
"id": 79371528,
"name": "openshift/ansible-service-broker",
"url": "https://api.github.com/repos/openshift/ansible-service-broker"
} | {
"id": 53091,
"login": "mhrivnak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53091?",
"url": "https://api.github.com/users/mhrivnak"
} | {
"id": 792337,
"login": "openshift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792337?",
"url": "https://api.github.com/orgs/openshift"
} | 2018-03-02T19:04:36 | 7323529881 | {"actor":{"display_login":"mhrivnak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/neontribe/ARCVService/pulls/comments/206810542","pull_request_review_id":142290205,"id":206810542,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjgxMDU0Mg==","diff_hunk":"@@ -0,0 +1,41 @@\n+<?php\n+\n+namespace App\\Http\\Controllers\\Service;","path":"app/Http/Controllers/Store/FamilyController.php","position":3,"original_position":3,"commit_id":"feef105bed96b083cd0c68f54ac84c165116e3ef","original_commit_id":"feef105bed96b083cd0c68f54ac84c165116e3ef","user":{"login":"katjam","id":861172,"node_id":"MDQ6VXNlcjg2MTE3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/861172?v=4","gravatar_id":"","url":"https://api.github.com/users/katjam","html_url":"https://github.com/katjam","followers_url":"https://api.github.com/users/katjam/followers","following_url":"https://api.github.com/users/katjam/following{/other_user}","gists_url":"https://api.github.com/users/katjam/gists{/gist_id}","starred_url":"https://api.github.com/users/katjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katjam/subscriptions","organizations_url":"https://api.github.com/users/katjam/orgs","repos_url":"https://api.github.com/users/katjam/repos","events_url":"https://api.github.com/users/katjam/events{/privacy}","received_events_url":"https://api.github.com/users/katjam/received_events","type":"User","site_admin":false},"body":"Again - store vs service.","created_at":"2018-08-01T09:23:48Z","updated_at":"2018-08-01T09:31:05Z","html_url":"https://github.com/neontribe/ARCVService/pull/131#discussion_r206810542","pull_request_url":"https://api.github.com/repos/neontribe/ARCVService/pulls/131","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/comments/206810542"},"html":{"href":"https://github.com/neontribe/ARCVService/pull/131#discussion_r206810542"},"pull_request":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/neontribe/ARCVService/pulls/131","id":205150597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTUwNTk3","html_url":"https://github.com/neontribe/ARCVService/pull/131","diff_url":"https://github.com/neontribe/ARCVService/pull/131.diff","patch_url":"https://github.com/neontribe/ARCVService/pull/131.patch","issue_url":"https://api.github.com/repos/neontribe/ARCVService/issues/131","number":131,"state":"open","locked":false,"title":"1.2/977 merge controllers in","user":{"login":"charlesstrange2","id":25037036,"node_id":"MDQ6VXNlcjI1MDM3MDM2","avatar_url":"https://avatars3.githubusercontent.com/u/25037036?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesstrange2","html_url":"https://github.com/charlesstrange2","followers_url":"https://api.github.com/users/charlesstrange2/followers","following_url":"https://api.github.com/users/charlesstrange2/following{/other_user}","gists_url":"https://api.github.com/users/charlesstrange2/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesstrange2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesstrange2/subscriptions","organizations_url":"https://api.github.com/users/charlesstrange2/orgs","repos_url":"https://api.github.com/users/charlesstrange2/repos","events_url":"https://api.github.com/users/charlesstrange2/events{/privacy}","received_events_url":"https://api.github.com/users/charlesstrange2/received_events","type":"User","site_admin":false},"body":"this is a bit of a mess, but we're trying to get things into smaller PRs.\r\n","created_at":"2018-07-31T15:22:19Z","updated_at":"2018-08-01T09:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4e6982ec1a0b5319d5ff3494a928a218e1b1f23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neontribe/ARCVService/pulls/131/commits","review_comments_url":"https://api.github.com/repos/neontribe/ARCVService/pulls/131/comments","review_comment_url":"https://api.github.com/repos/neontribe/ARCVService/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neontribe/ARCVService/issues/131/comments","statuses_url":"https://api.github.com/repos/neontribe/ARCVService/statuses/feef105bed96b083cd0c68f54ac84c165116e3ef","head":{"label":"neontribe:1.2/977-merge-controllers-in","ref":"1.2/977-merge-controllers-in","sha":"feef105bed96b083cd0c68f54ac84c165116e3ef","user":{"login":"neontribe","id":814085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/814085?v=4","gravatar_id":"","url":"https://api.github.com/users/neontribe","html_url":"https://github.com/neontribe","followers_url":"https://api.github.com/users/neontribe/followers","following_url":"https://api.github.com/users/neontribe/following{/other_user}","gists_url":"https://api.github.com/users/neontribe/gists{/gist_id}","starred_url":"https://api.github.com/users/neontribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neontribe/subscriptions","organizations_url":"https://api.github.com/users/neontribe/orgs","repos_url":"https://api.github.com/users/neontribe/repos","events_url":"https://api.github.com/users/neontribe/events{/privacy}","received_events_url":"https://api.github.com/users/neontribe/received_events","type":"Organization","site_admin":false},"repo":{"id":88754893,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc1NDg5Mw==","name":"ARCVService","full_name":"neontribe/ARCVService","owner":{"login":"neontribe","id":814085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/814085?v=4","gravatar_id":"","url":"https://api.github.com/users/neontribe","html_url":"https://github.com/neontribe","followers_url":"https://api.github.com/users/neontribe/followers","following_url":"https://api.github.com/users/neontribe/following{/other_user}","gists_url":"https://api.github.com/users/neontribe/gists{/gist_id}","starred_url":"https://api.github.com/users/neontribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neontribe/subscriptions","organizations_url":"https://api.github.com/users/neontribe/orgs","repos_url":"https://api.github.com/users/neontribe/repos","events_url":"https://api.github.com/users/neontribe/events{/privacy}","received_events_url":"https://api.github.com/users/neontribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neontribe/ARCVService","description":"ARC Voucher Service/API","fork":false,"url":"https://api.github.com/repos/neontribe/ARCVService","forks_url":"https://api.github.com/repos/neontribe/ARCVService/forks","keys_url":"https://api.github.com/repos/neontribe/ARCVService/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neontribe/ARCVService/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neontribe/ARCVService/teams","hooks_url":"https://api.github.com/repos/neontribe/ARCVService/hooks","issue_events_url":"https://api.github.com/repos/neontribe/ARCVService/issues/events{/number}","events_url":"https://api.github.com/repos/neontribe/ARCVService/events","assignees_url":"https://api.github.com/repos/neontribe/ARCVService/assignees{/user}","branches_url":"https://api.github.com/repos/neontribe/ARCVService/branches{/branch}","tags_url":"https://api.github.com/repos/neontribe/ARCVService/tags","blobs_url":"https://api.github.com/repos/neontribe/ARCVService/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neontribe/ARCVService/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neontribe/ARCVService/git/refs{/sha}","trees_url":"https://api.github.com/repos/neontribe/ARCVService/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neontribe/ARCVService/statuses/{sha}","languages_url":"https://api.github.com/repos/neontribe/ARCVService/languages","stargazers_url":"https://api.github.com/repos/neontribe/ARCVService/stargazers","contributors_url":"https://api.github.com/repos/neontribe/ARCVService/contributors","subscribers_url":"https://api.github.com/repos/neontribe/ARCVService/subscribers","subscription_url":"https://api.github.com/repos/neontribe/ARCVService/subscription","commits_url":"https://api.github.com/repos/neontribe/ARCVService/commits{/sha}","git_commits_url":"https://api.github.com/repos/neontribe/ARCVService/git/commits{/sha}","comments_url":"https://api.github.com/repos/neontribe/ARCVService/comments{/number}","issue_comment_url":"https://api.github.com/repos/neontribe/ARCVService/issues/comments{/number}","contents_url":"https://api.github.com/repos/neontribe/ARCVService/contents/{+path}","compare_url":"https://api.github.com/repos/neontribe/ARCVService/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neontribe/ARCVService/merges","archive_url":"https://api.github.com/repos/neontribe/ARCVService/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neontribe/ARCVService/downloads","issues_url":"https://api.github.com/repos/neontribe/ARCVService/issues{/number}","pulls_url":"https://api.github.com/repos/neontribe/ARCVService/pulls{/number}","milestones_url":"https://api.github.com/repos/neontribe/ARCVService/milestones{/number}","notifications_url":"https://api.github.com/repos/neontribe/ARCVService/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neontribe/ARCVService/labels{/name}","releases_url":"https://api.github.com/repos/neontribe/ARCVService/releases{/id}","deployments_url":"https://api.github.com/repos/neontribe/ARCVService/deployments","created_at":"2017-04-19T14:31:12Z","updated_at":"2018-07-31T15:21:14Z","pushed_at":"2018-07-31T16:30:41Z","git_url":"git://github.com/neontribe/ARCVService.git","ssh_url":"git@github.com:neontribe/ARCVService.git","clone_url":"https://github.com/neontribe/ARCVService.git","svn_url":"https://github.com/neontribe/ARCVService","homepage":null,"size":3033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"1.2/release"}},"base":{"label":"neontribe:1.2/release","ref":"1.2/release","sha":"b1eeb6061a2ba58b3aaaaf80d9f7a7d684c5cf7b","user":{"login":"neontribe","id":814085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/814085?v=4","gravatar_id":"","url":"https://api.github.com/users/neontribe","html_url":"https://github.com/neontribe","followers_url":"https://api.github.com/users/neontribe/followers","following_url":"https://api.github.com/users/neontribe/following{/other_user}","gists_url":"https://api.github.com/users/neontribe/gists{/gist_id}","starred_url":"https://api.github.com/users/neontribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neontribe/subscriptions","organizations_url":"https://api.github.com/users/neontribe/orgs","repos_url":"https://api.github.com/users/neontribe/repos","events_url":"https://api.github.com/users/neontribe/events{/privacy}","received_events_url":"https://api.github.com/users/neontribe/received_events","type":"Organization","site_admin":false},"repo":{"id":88754893,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc1NDg5Mw==","name":"ARCVService","full_name":"neontribe/ARCVService","owner":{"login":"neontribe","id":814085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDA4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/814085?v=4","gravatar_id":"","url":"https://api.github.com/users/neontribe","html_url":"https://github.com/neontribe","followers_url":"https://api.github.com/users/neontribe/followers","following_url":"https://api.github.com/users/neontribe/following{/other_user}","gists_url":"https://api.github.com/users/neontribe/gists{/gist_id}","starred_url":"https://api.github.com/users/neontribe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neontribe/subscriptions","organizations_url":"https://api.github.com/users/neontribe/orgs","repos_url":"https://api.github.com/users/neontribe/repos","events_url":"https://api.github.com/users/neontribe/events{/privacy}","received_events_url":"https://api.github.com/users/neontribe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neontribe/ARCVService","description":"ARC Voucher Service/API","fork":false,"url":"https://api.github.com/repos/neontribe/ARCVService","forks_url":"https://api.github.com/repos/neontribe/ARCVService/forks","keys_url":"https://api.github.com/repos/neontribe/ARCVService/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neontribe/ARCVService/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neontribe/ARCVService/teams","hooks_url":"https://api.github.com/repos/neontribe/ARCVService/hooks","issue_events_url":"https://api.github.com/repos/neontribe/ARCVService/issues/events{/number}","events_url":"https://api.github.com/repos/neontribe/ARCVService/events","assignees_url":"https://api.github.com/repos/neontribe/ARCVService/assignees{/user}","branches_url":"https://api.github.com/repos/neontribe/ARCVService/branches{/branch}","tags_url":"https://api.github.com/repos/neontribe/ARCVService/tags","blobs_url":"https://api.github.com/repos/neontribe/ARCVService/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neontribe/ARCVService/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neontribe/ARCVService/git/refs{/sha}","trees_url":"https://api.github.com/repos/neontribe/ARCVService/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neontribe/ARCVService/statuses/{sha}","languages_url":"https://api.github.com/repos/neontribe/ARCVService/languages","stargazers_url":"https://api.github.com/repos/neontribe/ARCVService/stargazers","contributors_url":"https://api.github.com/repos/neontribe/ARCVService/contributors","subscribers_url":"https://api.github.com/repos/neontribe/ARCVService/subscribers","subscription_url":"https://api.github.com/repos/neontribe/ARCVService/subscription","commits_url":"https://api.github.com/repos/neontribe/ARCVService/commits{/sha}","git_commits_url":"https://api.github.com/repos/neontribe/ARCVService/git/commits{/sha}","comments_url":"https://api.github.com/repos/neontribe/ARCVService/comments{/number}","issue_comment_url":"https://api.github.com/repos/neontribe/ARCVService/issues/comments{/number}","contents_url":"https://api.github.com/repos/neontribe/ARCVService/contents/{+path}","compare_url":"https://api.github.com/repos/neontribe/ARCVService/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neontribe/ARCVService/merges","archive_url":"https://api.github.com/repos/neontribe/ARCVService/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neontribe/ARCVService/downloads","issues_url":"https://api.github.com/repos/neontribe/ARCVService/issues{/number}","pulls_url":"https://api.github.com/repos/neontribe/ARCVService/pulls{/number}","milestones_url":"https://api.github.com/repos/neontribe/ARCVService/milestones{/number}","notifications_url":"https://api.github.com/repos/neontribe/ARCVService/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neontribe/ARCVService/labels{/name}","releases_url":"https://api.github.com/repos/neontribe/ARCVService/releases{/id}","deployments_url":"https://api.github.com/repos/neontribe/ARCVService/deployments","created_at":"2017-04-19T14:31:12Z","updated_at":"2018-07-31T15:21:14Z","pushed_at":"2018-07-31T16:30:41Z","git_url":"git://github.com/neontribe/ARCVService.git","ssh_url":"git@github.com:neontribe/ARCVService.git","clone_url":"https://github.com/neontribe/ARCVService.git","svn_url":"https://github.com/neontribe/ARCVService","homepage":null,"size":3033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"1.2/release"}},"_links":{"self":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/131"},"html":{"href":"https://github.com/neontribe/ARCVService/pull/131"},"issue":{"href":"https://api.github.com/repos/neontribe/ARCVService/issues/131"},"comments":{"href":"https://api.github.com/repos/neontribe/ARCVService/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neontribe/ARCVService/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/neontribe/ARCVService/statuses/feef105bed96b083cd0c68f54ac84c165116e3ef"}},"author_association":"CONTRIBUTOR"}} | {
"id": 88754893,
"name": "neontribe/ARCVService",
"url": "https://api.github.com/repos/neontribe/ARCVService"
} | {
"id": 861172,
"login": "katjam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/861172?",
"url": "https://api.github.com/users/katjam"
} | {
"id": 814085,
"login": "neontribe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/814085?",
"url": "https://api.github.com/orgs/neontribe"
} | 2018-08-01T09:23:48 | 8049251036 | {"actor":{"display_login":"katjam"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/242985359","pull_request_review_id":186624537,"id":242985359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjk4NTM1OQ==","diff_hunk":"@@ -212,34 +227,45 @@ function tryFixingNonCollapsedRage( range, schema ) {\n \treturn null;\n }\n \n-// Expands selection so it contains whole limit node.\n+// Finds the outer-most ancestor.\n //\n-// @param {module:engine/model/position~Position} position\n+// @param {module:engine/model/node~Node} startingNode\n // @param {module:engine/model/schema~Schema} schema\n // @param {String} expandToDirection Direction of expansion - either 'start' or 'end' of the range.\n-// @returns {module:engine/model/position~Position}\n-function expandSelectionOnIsLimitNode( position, schema, expandToDirection ) {\n-\tlet node = position.parent;\n-\tlet parent = node;\n+// @returns {module:engine/model/node~Node}\n+function findOuterMostIsLimitAncestor( startingNode, schema ) {\n+\tlet isLimitNode = startingNode;\n+\tlet parent = isLimitNode;\n \n \t// Find outer most isLimit block as such blocks might be nested (ie. in tables).\n \twhile ( schema.isLimit( parent ) && parent.parent ) {\n-\t\tnode = parent;\n+\t\tisLimitNode = parent;\n \t\tparent = parent.parent;\n \t}\n \n-\t// Depending on direction of expanding selection return position before or after found node.\n-\treturn expandToDirection === 'start' ? Position._createBefore( node ) : Position._createAfter( node );\n+\treturn isLimitNode;\n }\n \n-// Checks whether both range ends are placed around non-limit elements.\n+// Checks whether one of range ends is placed around non-limit elements.","path":"src/model/utils/selection-post-fixer.js","position":85,"original_position":85,"commit_id":"02ce9189a0f36df53be15a750ec02dd496f72a02","original_commit_id":"02ce9189a0f36df53be15a750ec02dd496f72a02","user":{"login":"scofalik","id":1502228,"node_id":"MDQ6VXNlcjE1MDIyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1502228?v=4","gravatar_id":"","url":"https://api.github.com/users/scofalik","html_url":"https://github.com/scofalik","followers_url":"https://api.github.com/users/scofalik/followers","following_url":"https://api.github.com/users/scofalik/following{/other_user}","gists_url":"https://api.github.com/users/scofalik/gists{/gist_id}","starred_url":"https://api.github.com/users/scofalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scofalik/subscriptions","organizations_url":"https://api.github.com/users/scofalik/orgs","repos_url":"https://api.github.com/users/scofalik/repos","events_url":"https://api.github.com/users/scofalik/events{/privacy}","received_events_url":"https://api.github.com/users/scofalik/received_events","type":"User","site_admin":false},"body":"one => any","created_at":"2018-12-19T16:30:44Z","updated_at":"2018-12-19T16:46:15Z","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1608#discussion_r242985359","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/242985359"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1608#discussion_r242985359"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608"}},"in_reply_to_id":242985180},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608","id":236840042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODQwMDQy","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1608","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1608.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1608.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1608","number":1608,"state":"open","locked":false,"title":"T/ckeditor5 table/99: Selection post-fixer improvements.","user":{"login":"jodator","id":247363,"node_id":"MDQ6VXNlcjI0NzM2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/247363?v=4","gravatar_id":"","url":"https://api.github.com/users/jodator","html_url":"https://github.com/jodator","followers_url":"https://api.github.com/users/jodator/followers","following_url":"https://api.github.com/users/jodator/following{/other_user}","gists_url":"https://api.github.com/users/jodator/gists{/gist_id}","starred_url":"https://api.github.com/users/jodator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodator/subscriptions","organizations_url":"https://api.github.com/users/jodator/orgs","repos_url":"https://api.github.com/users/jodator/repos","events_url":"https://api.github.com/users/jodator/events{/privacy}","received_events_url":"https://api.github.com/users/jodator/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nAdd selection post-fixer improvements. Closes #1593.\r\n\r\n---\r\n\r\n### Additional information\r\n\r\n* Required for table PR: https://github.com/ckeditor/ckeditor5-table/pull/155.\r\n* Required for widget PR: https://github.com/ckeditor/ckeditor5-widget/pull/62.\r\n","created_at":"2018-12-07T11:39:20Z","updated_at":"2018-12-19T16:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c427c628a04dc788f44ff68789bc8fc2498488c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1608/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/02ce9189a0f36df53be15a750ec02dd496f72a02","head":{"label":"ckeditor:t/ckeditor5-table/99","ref":"t/ckeditor5-table/99","sha":"02ce9189a0f36df53be15a750ec02dd496f72a02","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"node_id":"MDEwOlJlcG9zaXRvcnkyODk3Mjg5MA==","name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-12-19T15:30:56Z","pushed_at":"2018-12-19T15:30:51Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":11236,"stargazers_count":64,"watchers_count":64,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":195,"watchers":64,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"fd7734e06e47c7574877d01e1e8effa90984a85c","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"node_id":"MDEwOlJlcG9zaXRvcnkyODk3Mjg5MA==","name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 editing engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2018-12-19T15:30:56Z","pushed_at":"2018-12-19T15:30:51Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"https://ckeditor.com","size":11236,"stargazers_count":64,"watchers_count":64,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":195,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/1608"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1608"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1608/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1608/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/02ce9189a0f36df53be15a750ec02dd496f72a02"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28972890,
"name": "ckeditor/ckeditor5-engine",
"url": "https://api.github.com/repos/ckeditor/ckeditor5-engine"
} | {
"id": 1502228,
"login": "scofalik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1502228?",
"url": "https://api.github.com/users/scofalik"
} | {
"id": 825710,
"login": "ckeditor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/825710?",
"url": "https://api.github.com/orgs/ckeditor"
} | 2018-12-19T16:30:44 | 8780237215 | {"actor":{"display_login":"scofalik"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/234233235","pull_request_review_id":175836856,"id":234233235,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDIzMzIzNQ==","diff_hunk":"@@ -0,0 +1,91 @@\n+{% extends 'base_ds2013.html.twig' %}\n+\n+{% import _self as self %}","path":"templates/clips/list.html.twig","position":3,"original_position":3,"commit_id":"aec3315c498e5a2d61c1c3fc8f4aaf9b4d21072f","original_commit_id":"aec3315c498e5a2d61c1c3fc8f4aaf9b4d21072f","user":{"login":"cisco87","id":169945,"node_id":"MDQ6VXNlcjE2OTk0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/169945?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco87","html_url":"https://github.com/cisco87","followers_url":"https://api.github.com/users/cisco87/followers","following_url":"https://api.github.com/users/cisco87/following{/other_user}","gists_url":"https://api.github.com/users/cisco87/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco87/subscriptions","organizations_url":"https://api.github.com/users/cisco87/orgs","repos_url":"https://api.github.com/users/cisco87/repos","events_url":"https://api.github.com/users/cisco87/events{/privacy}","received_events_url":"https://api.github.com/users/cisco87/received_events","type":"User","site_admin":false},"body":"I am attached to it (joking i will remove it, was part of another approach to rendering a single clip)","created_at":"2018-11-16T14:58:12Z","updated_at":"2018-11-16T14:58:12Z","html_url":"https://github.com/bbc/programmes-frontend/pull/810#discussion_r234233235","pull_request_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/234233235"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/810#discussion_r234233235"},"pull_request":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810"}},"in_reply_to_id":234213599},"pull_request":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810","id":228342533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzQyNTMz","html_url":"https://github.com/bbc/programmes-frontend/pull/810","diff_url":"https://github.com/bbc/programmes-frontend/pull/810.diff","patch_url":"https://github.com/bbc/programmes-frontend/pull/810.patch","issue_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/810","number":810,"state":"open","locked":false,"title":"Programmes 6706 initial clip list page","user":{"login":"cisco87","id":169945,"node_id":"MDQ6VXNlcjE2OTk0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/169945?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco87","html_url":"https://github.com/cisco87","followers_url":"https://api.github.com/users/cisco87/followers","following_url":"https://api.github.com/users/cisco87/following{/other_user}","gists_url":"https://api.github.com/users/cisco87/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco87/subscriptions","organizations_url":"https://api.github.com/users/cisco87/orgs","repos_url":"https://api.github.com/users/cisco87/repos","events_url":"https://api.github.com/users/cisco87/events{/privacy}","received_events_url":"https://api.github.com/users/cisco87/received_events","type":"User","site_admin":false},"body":"https://jira.dev.bbc.co.uk/browse/PROGRAMMES-6707","created_at":"2018-11-05T12:53:45Z","updated_at":"2018-11-16T14:58:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b591f4f268e3219c599c7335426d348bc8ba14e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810/commits","review_comments_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810/comments","review_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/810/comments","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/aec3315c498e5a2d61c1c3fc8f4aaf9b4d21072f","head":{"label":"bbc:PROGRAMMES-6706-initial-clip-list-page","ref":"PROGRAMMES-6706-initial-clip-list-page","sha":"aec3315c498e5a2d61c1c3fc8f4aaf9b4d21072f","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5ODg4OQ==","name":"programmes-frontend","full_name":"bbc/programmes-frontend","private":false,"owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2018-11-16T11:53:17Z","pushed_at":"2018-11-16T14:27:51Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":4187,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":5,"watchers":19,"default_branch":"develop"}},"base":{"label":"bbc:develop","ref":"develop","sha":"2ad5960b0c71ccbe3c4875b282025a66efdf5d0b","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"node_id":"MDEwOlJlcG9zaXRvcnk4NTI5ODg4OQ==","name":"programmes-frontend","full_name":"bbc/programmes-frontend","private":false,"owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2018-11-16T11:53:17Z","pushed_at":"2018-11-16T14:27:51Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":4187,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":5,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/810"},"issue":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/810"},"comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/810/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/810/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/programmes-frontend/statuses/aec3315c498e5a2d61c1c3fc8f4aaf9b4d21072f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 85298889,
"name": "bbc/programmes-frontend",
"url": "https://api.github.com/repos/bbc/programmes-frontend"
} | {
"id": 169945,
"login": "cisco87",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/169945?",
"url": "https://api.github.com/users/cisco87"
} | {
"id": 828722,
"login": "bbc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/828722?",
"url": "https://api.github.com/orgs/bbc"
} | 2018-11-16T14:58:12 | 8602734689 | {"actor":{"display_login":"cisco87"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments/236034767","pull_request_review_id":178042884,"id":236034767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAzNDc2Nw==","diff_hunk":"@@ -23,22 +30,304 @@ implementation are in the accepted\n ``astropy_helpers`` includes a special \"bootstrap\" module called\n ``ah_bootstrap.py`` which is intended to be used by a project's setup.py in\n order to ensure that the ``astropy_helpers`` package is available for\n-build/installation. This is similar to the ``ez_setup.py`` module that is\n-shipped with some projects to bootstrap `setuptools\n-<https://bitbucket.org/pypa/setuptools>`_.\n+build/installation.\n \n-As described in APE4, the version numbers for ``astropy_helpers`` follow the\n-corresponding major/minor version of the `astropy core package\n-<http://www.astropy.org/>`_, but with an independent sequence of micro (bugfix)\n-version numbers. Hence, the initial release is 0.4, in parallel with Astropy\n-v0.4, which will be the first version of Astropy to use ``astropy-helpers``.\n+As described in `APE4 <https://github.com/astropy/astropy-APEs/blob/master/APE4.rst>`_, the version\n+numbers for ``astropy_helpers`` follow the corresponding major/minor version of\n+the `astropy core package <http://www.astropy.org/>`_, but with an independent\n+sequence of micro (bugfix) version numbers. Hence, the initial release is 0.4,\n+in parallel with Astropy v0.4, which will be the first version of Astropy to\n+use ``astropy-helpers``.\n \n For examples of how to implement ``astropy-helpers`` in a project,\n see the ``setup.py`` and ``setup.cfg`` files of the\n `Affiliated package template <https://github.com/astropy/package-template>`_.\n \n-.. image:: https://travis-ci.org/astropy/astropy-helpers.svg\n- :target: https://travis-ci.org/astropy/astropy-helpers\n+Using astropy-helpers\n+---------------------\n+\n+The easiest way to get set up with astropy-helpers in a new package is to use\n+the `package-template <http://docs.astropy.org/projects/package-template>`_\n+that we provide. However, we now go through the steps of adding astropy-helpers\n+as a submodule to a package in case you wish to do so manually. First, add\n+astropy-helpers as a submodule at the root of your repository::\n+\n+ git submodule add git://github.com/astropy/astropy-helpers astropy_helpers\n+\n+Then go inside the submodule and check out a stable version of astropy-helpers.\n+You can see the available versions by running::\n+\n+ $ cd astropy_helpers\n+ $ git tag\n+ ...\n+ v2.0.6\n+ v2.0.7\n+ ...\n+ v3.0.1\n+ v3.0.2\n+\n+If you want to support Python 2, pick the latest v2.0.x version (in the above\n+case ``v2.0.7``) and if you don't need to support Python 2, just pick the latest\n+stable version (in the above case ``v3.0.2``). Check out this version with e.g.::\n+\n+ $ git checkout v3.0.2\n+\n+Then go back up to the root of your repository and copy the ``ah_bootstrap.py``\n+file from the submodule to the root of your repository::\n+\n+ $ cd ..\n+ $ cp astropy_helpers/ah_bootstrap.py .\n+\n+Finally, add::\n+\n+ import ah_bootstrap\n+\n+at the top of your ``setup.py`` file. This will ensure that ``astropy_helpers``\n+is now available to use in your ``setup.py`` file. Finally, add then commit your\n+changes::\n+\n+ git add astropy_helpers ah_bootstrap.py setup.py\n+ git commit ...\n+\n+Updating astropy-helpers\n+------------------------\n+\n+If you would like to automatically get pull requests to update astropy-helpers,\n+then see the instructions `here\n+<https://github.com/astropy/astropy-procedures/tree/master/update-affiliated>`_.\n+\n+To instead update astropy-helpers manually, go inside the submodule and do::\n+\n+ cd astropy_helpers\n+ git fetch origin","path":"README.rst","position":117,"original_position":117,"commit_id":"6e83e891921b22f1298c1376a84d56dda6dbd63e","original_commit_id":"6e83e891921b22f1298c1376a84d56dda6dbd63e","user":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"body":"I've seen the same thing and not fully understood why... but I think it might have to do with the the signing? Or possibly *editing* of tags?","created_at":"2018-11-24T07:31:06Z","updated_at":"2018-11-24T07:48:47Z","html_url":"https://github.com/astropy/astropy-helpers/pull/416#discussion_r236034767","pull_request_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments/236034767"},"html":{"href":"https://github.com/astropy/astropy-helpers/pull/416#discussion_r236034767"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416"}},"in_reply_to_id":236018259},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416","id":231954823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTU0ODIz","html_url":"https://github.com/astropy/astropy-helpers/pull/416","diff_url":"https://github.com/astropy/astropy-helpers/pull/416.diff","patch_url":"https://github.com/astropy/astropy-helpers/pull/416.patch","issue_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/416","number":416,"state":"open","locked":false,"title":"Added initial docs about what the package does","user":{"login":"astrofrog","id":314716,"node_id":"MDQ6VXNlcjMxNDcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"body":"I thought it was about time we documented what astropy-helpers actually does. This is pretty minimal, but I thought it'd be better than nothing.","created_at":"2018-11-19T12:24:06Z","updated_at":"2018-11-24T07:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2131b4def4f48fbdd385eaf792ee944986f4505b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":268333160,"node_id":"MDU6TGFiZWwyNjgzMzMxNjA=","url":"https://api.github.com/repos/astropy/astropy-helpers/labels/Ready-for-final-review","name":"Ready-for-final-review","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy-helpers/milestones/42","html_url":"https://github.com/astropy/astropy-helpers/milestone/42","labels_url":"https://api.github.com/repos/astropy/astropy-helpers/milestones/42/labels","id":3835829,"node_id":"MDk6TWlsZXN0b25lMzgzNTgyOQ==","number":42,"title":"v3.2","description":"","creator":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-11-20T23:27:04Z","updated_at":"2018-11-23T13:03:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/416/comments","statuses_url":"https://api.github.com/repos/astropy/astropy-helpers/statuses/6e83e891921b22f1298c1376a84d56dda6dbd63e","head":{"label":"astrofrog:simple-docs","ref":"simple-docs","sha":"6e83e891921b22f1298c1376a84d56dda6dbd63e","user":{"login":"astrofrog","id":314716,"node_id":"MDQ6VXNlcjMxNDcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"repo":{"id":15879735,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3OTczNQ==","name":"astropy-helpers","full_name":"astrofrog/astropy-helpers","private":false,"owner":{"login":"astrofrog","id":314716,"node_id":"MDQ6VXNlcjMxNDcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/314716?v=4","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"html_url":"https://github.com/astrofrog/astropy-helpers","description":"Helpers for Astropy and Affiliated packages","fork":true,"url":"https://api.github.com/repos/astrofrog/astropy-helpers","forks_url":"https://api.github.com/repos/astrofrog/astropy-helpers/forks","keys_url":"https://api.github.com/repos/astrofrog/astropy-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astrofrog/astropy-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astrofrog/astropy-helpers/teams","hooks_url":"https://api.github.com/repos/astrofrog/astropy-helpers/hooks","issue_events_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/astrofrog/astropy-helpers/events","assignees_url":"https://api.github.com/repos/astrofrog/astropy-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/astrofrog/astropy-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/astrofrog/astropy-helpers/tags","blobs_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astrofrog/astropy-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/astrofrog/astropy-helpers/languages","stargazers_url":"https://api.github.com/repos/astrofrog/astropy-helpers/stargazers","contributors_url":"https://api.github.com/repos/astrofrog/astropy-helpers/contributors","subscribers_url":"https://api.github.com/repos/astrofrog/astropy-helpers/subscribers","subscription_url":"https://api.github.com/repos/astrofrog/astropy-helpers/subscription","commits_url":"https://api.github.com/repos/astrofrog/astropy-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/astrofrog/astropy-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/astrofrog/astropy-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/astrofrog/astropy-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/astrofrog/astropy-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astrofrog/astropy-helpers/merges","archive_url":"https://api.github.com/repos/astrofrog/astropy-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astrofrog/astropy-helpers/downloads","issues_url":"https://api.github.com/repos/astrofrog/astropy-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/astrofrog/astropy-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/astrofrog/astropy-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/astrofrog/astropy-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astrofrog/astropy-helpers/labels{/name}","releases_url":"https://api.github.com/repos/astrofrog/astropy-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/astrofrog/astropy-helpers/deployments","created_at":"2014-01-13T19:51:48Z","updated_at":"2014-06-11T11:29:56Z","pushed_at":"2018-11-23T12:58:55Z","git_url":"git://github.com/astrofrog/astropy-helpers.git","ssh_url":"git@github.com:astrofrog/astropy-helpers.git","clone_url":"https://github.com/astrofrog/astropy-helpers.git","svn_url":"https://github.com/astrofrog/astropy-helpers","homepage":null,"size":1169,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"9f5f3f4235840420302f697be9716bd16e7b2858","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":14448779,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0ODc3OQ==","name":"astropy-helpers","full_name":"astropy/astropy-helpers","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astropy-helpers","description":"Helpers for Astropy and Affiliated packages","fork":false,"url":"https://api.github.com/repos/astropy/astropy-helpers","forks_url":"https://api.github.com/repos/astropy/astropy-helpers/forks","keys_url":"https://api.github.com/repos/astropy/astropy-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy-helpers/teams","hooks_url":"https://api.github.com/repos/astropy/astropy-helpers/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy-helpers/events","assignees_url":"https://api.github.com/repos/astropy/astropy-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy-helpers/tags","blobs_url":"https://api.github.com/repos/astropy/astropy-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy-helpers/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy-helpers/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy-helpers/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy-helpers/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy-helpers/subscription","commits_url":"https://api.github.com/repos/astropy/astropy-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy-helpers/merges","archive_url":"https://api.github.com/repos/astropy/astropy-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy-helpers/downloads","issues_url":"https://api.github.com/repos/astropy/astropy-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy-helpers/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy-helpers/deployments","created_at":"2013-11-16T15:01:42Z","updated_at":"2018-11-19T02:03:31Z","pushed_at":"2018-11-24T07:48:32Z","git_url":"git://github.com/astropy/astropy-helpers.git","ssh_url":"git@github.com:astropy/astropy-helpers.git","clone_url":"https://github.com/astropy/astropy-helpers.git","svn_url":"https://github.com/astropy/astropy-helpers","homepage":null,"size":1278,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":37,"open_issues":45,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416"},"html":{"href":"https://github.com/astropy/astropy-helpers/pull/416"},"issue":{"href":"https://api.github.com/repos/astropy/astropy-helpers/issues/416"},"comments":{"href":"https://api.github.com/repos/astropy/astropy-helpers/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy-helpers/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy-helpers/statuses/6e83e891921b22f1298c1376a84d56dda6dbd63e"}},"author_association":"MEMBER"}} | {
"id": 14448779,
"name": "astropy/astropy-helpers",
"url": "https://api.github.com/repos/astropy/astropy-helpers"
} | {
"id": 346587,
"login": "eteq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/346587?",
"url": "https://api.github.com/users/eteq"
} | {
"id": 847984,
"login": "astropy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/847984?",
"url": "https://api.github.com/orgs/astropy"
} | 2018-11-24T07:31:06 | 8640564667 | {"actor":{"display_login":"eteq"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/184581153","pull_request_review_id":115807510,"id":184581153,"diff_hunk":"@@ -618,10 +618,12 @@ def __call__(self, model, x, y, z=None, weights=None, **kwargs):\n \n Returns\n -------\n- filtered_data : numpy.ma.core.MaskedArray","path":"astropy/modeling/fitting.py","position":4,"original_position":4,"commit_id":"97736e4067c455c64cb75a8b15d9b3eb0bbadec6","original_commit_id":"288b22ee60ccd30e1df200bf6546427c95bbb490","user":{"login":"pllim","id":2090236,"avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"body":"I feel uncomfortable with sudden API change without a deprecation period, but the decision is beyond me. I wonder if astropy/astropy-APEs#20 applies here. :thinking: ","created_at":"2018-04-27T02:52:37Z","updated_at":"2018-04-27T02:52:38Z","html_url":"https://github.com/astropy/astropy/pull/7407#discussion_r184581153","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/7407","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/184581153"},"html":{"href":"https://github.com/astropy/astropy/pull/7407#discussion_r184581153"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7407"}},"in_reply_to_id":184117708},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/7407","id":184085826,"html_url":"https://github.com/astropy/astropy/pull/7407","diff_url":"https://github.com/astropy/astropy/pull/7407.diff","patch_url":"https://github.com/astropy/astropy/pull/7407.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/7407","number":7407,"state":"open","locked":false,"title":"Change order/type of return values in FittingWithOutlierRemoval","user":{"login":"jehturner","id":322026,"avatar_url":"https://avatars0.githubusercontent.com/u/322026?v=4","gravatar_id":"","url":"https://api.github.com/users/jehturner","html_url":"https://github.com/jehturner","followers_url":"https://api.github.com/users/jehturner/followers","following_url":"https://api.github.com/users/jehturner/following{/other_user}","gists_url":"https://api.github.com/users/jehturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jehturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jehturner/subscriptions","organizations_url":"https://api.github.com/users/jehturner/orgs","repos_url":"https://api.github.com/users/jehturner/repos","events_url":"https://api.github.com/users/jehturner/events{/privacy}","received_events_url":"https://api.github.com/users/jehturner/received_events","type":"User","site_admin":false},"body":"I think this should resolve #7350. It also resolves an inconsistency where a plain numpy input array wouldn't get converted to `MaskedArray` in the return value if `niter=0` (a fix I inadvertently left out when we decided to change the return order separately) .\r\n","created_at":"2018-04-25T16:01:50Z","updated_at":"2018-04-27T02:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8d118a3e236e04cb6100f1341bb245b009dad3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nden","id":1110361,"avatar_url":"https://avatars2.githubusercontent.com/u/1110361?v=4","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":316473427,"url":"https://api.github.com/repos/astropy/astropy/labels/Refactoring","name":"Refactoring","color":"fef2c0","default":false},{"id":35800382,"url":"https://api.github.com/repos/astropy/astropy/labels/modeling","name":"modeling","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/52","html_url":"https://github.com/astropy/astropy/milestone/52","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/52/labels","id":2929745,"number":52,"title":"v3.1","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":36,"state":"open","created_at":"2017-11-21T23:24:18Z","updated_at":"2018-04-26T13:08:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/7407/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/7407/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/7407/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/97736e4067c455c64cb75a8b15d9b3eb0bbadec6","head":{"label":"jehturner:issue_7350","ref":"issue_7350","sha":"97736e4067c455c64cb75a8b15d9b3eb0bbadec6","user":{"login":"jehturner","id":322026,"avatar_url":"https://avatars0.githubusercontent.com/u/322026?v=4","gravatar_id":"","url":"https://api.github.com/users/jehturner","html_url":"https://github.com/jehturner","followers_url":"https://api.github.com/users/jehturner/followers","following_url":"https://api.github.com/users/jehturner/following{/other_user}","gists_url":"https://api.github.com/users/jehturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jehturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jehturner/subscriptions","organizations_url":"https://api.github.com/users/jehturner/orgs","repos_url":"https://api.github.com/users/jehturner/repos","events_url":"https://api.github.com/users/jehturner/events{/privacy}","received_events_url":"https://api.github.com/users/jehturner/received_events","type":"User","site_admin":false},"repo":{"id":90890571,"name":"astropy","full_name":"jehturner/astropy","owner":{"login":"jehturner","id":322026,"avatar_url":"https://avatars0.githubusercontent.com/u/322026?v=4","gravatar_id":"","url":"https://api.github.com/users/jehturner","html_url":"https://github.com/jehturner","followers_url":"https://api.github.com/users/jehturner/followers","following_url":"https://api.github.com/users/jehturner/following{/other_user}","gists_url":"https://api.github.com/users/jehturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jehturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jehturner/subscriptions","organizations_url":"https://api.github.com/users/jehturner/orgs","repos_url":"https://api.github.com/users/jehturner/repos","events_url":"https://api.github.com/users/jehturner/events{/privacy}","received_events_url":"https://api.github.com/users/jehturner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jehturner/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/jehturner/astropy","forks_url":"https://api.github.com/repos/jehturner/astropy/forks","keys_url":"https://api.github.com/repos/jehturner/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jehturner/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jehturner/astropy/teams","hooks_url":"https://api.github.com/repos/jehturner/astropy/hooks","issue_events_url":"https://api.github.com/repos/jehturner/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/jehturner/astropy/events","assignees_url":"https://api.github.com/repos/jehturner/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/jehturner/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/jehturner/astropy/tags","blobs_url":"https://api.github.com/repos/jehturner/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jehturner/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jehturner/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jehturner/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jehturner/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/jehturner/astropy/languages","stargazers_url":"https://api.github.com/repos/jehturner/astropy/stargazers","contributors_url":"https://api.github.com/repos/jehturner/astropy/contributors","subscribers_url":"https://api.github.com/repos/jehturner/astropy/subscribers","subscription_url":"https://api.github.com/repos/jehturner/astropy/subscription","commits_url":"https://api.github.com/repos/jehturner/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jehturner/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jehturner/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jehturner/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jehturner/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/jehturner/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jehturner/astropy/merges","archive_url":"https://api.github.com/repos/jehturner/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jehturner/astropy/downloads","issues_url":"https://api.github.com/repos/jehturner/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/jehturner/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/jehturner/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/jehturner/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jehturner/astropy/labels{/name}","releases_url":"https://api.github.com/repos/jehturner/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/jehturner/astropy/deployments","created_at":"2017-05-10T17:25:55Z","updated_at":"2018-04-26T15:17:10Z","pushed_at":"2018-04-26T15:17:21Z","git_url":"git://github.com/jehturner/astropy.git","ssh_url":"git@github.com:jehturner/astropy.git","clone_url":"https://github.com/jehturner/astropy.git","svn_url":"https://github.com/jehturner/astropy","homepage":"www.astropy.org","size":69371,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"9a5e356166abddc3e6889ccbb71c59d3fbdca51c","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2018-04-26T22:06:55Z","pushed_at":"2018-04-26T18:40:11Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":70150,"stargazers_count":1593,"watchers_count":1593,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":858,"mirror_url":null,"archived":false,"open_issues_count":873,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":858,"open_issues":873,"watchers":1593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7407"},"html":{"href":"https://github.com/astropy/astropy/pull/7407"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/7407"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/7407/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7407/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7407/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/97736e4067c455c64cb75a8b15d9b3eb0bbadec6"}},"author_association":"MEMBER"}} | {
"id": 2081289,
"name": "astropy/astropy",
"url": "https://api.github.com/repos/astropy/astropy"
} | {
"id": 2090236,
"login": "pllim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2090236?",
"url": "https://api.github.com/users/pllim"
} | {
"id": 847984,
"login": "astropy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/847984?",
"url": "https://api.github.com/orgs/astropy"
} | 2018-04-27T02:52:37 | 7595053700 | {"actor":{"display_login":"pllim"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/astropy/regions/pulls/comments/181831594","pull_request_review_id":112524460,"id":181831594,"diff_hunk":"@@ -33,6 +33,8 @@ class PixCoord(object):\n \"\"\"\n \n def __init__(self, x, y):\n+ if np.asanyarray(x).shape != np.asanyarray(y).shape:","path":"regions/core/pixcoord.py","position":13,"original_position":13,"commit_id":"1ddfa70080311674c97b35a2f142361cc26c2585","original_commit_id":"1ddfa70080311674c97b35a2f142361cc26c2585","user":{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false},"body":"The first case that you mentioned will be easy to deal with.\r\n\r\nThe second case with the ValueError message can be modified to mention only the dimensions and not the values of x and y.\r\n\r\nIf these two things are only concern , I think it can be resolved in this PR itself.\r\nOr else if you feel there is more to do , we can create a separate issue to deal with this later.","created_at":"2018-04-16T17:55:52Z","updated_at":"2018-04-16T17:55:52Z","html_url":"https://github.com/astropy/regions/pull/172#discussion_r181831594","pull_request_url":"https://api.github.com/repos/astropy/regions/pulls/172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/regions/pulls/comments/181831594"},"html":{"href":"https://github.com/astropy/regions/pull/172#discussion_r181831594"},"pull_request":{"href":"https://api.github.com/repos/astropy/regions/pulls/172"}},"in_reply_to_id":181595068},"pull_request":{"url":"https://api.github.com/repos/astropy/regions/pulls/172","id":178852134,"html_url":"https://github.com/astropy/regions/pull/172","diff_url":"https://github.com/astropy/regions/pull/172.diff","patch_url":"https://github.com/astropy/regions/pull/172.patch","issue_url":"https://api.github.com/repos/astropy/regions/issues/172","number":172,"state":"open","locked":false,"title":"suggestion to store scalar pixels as 0D numpy.ndarray","user":{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false},"body":"Reasons -\r\n1. `from_sky` method returns 0D ndarrays.\r\n2. Avoids confusion.\r\n","created_at":"2018-04-02T14:38:37Z","updated_at":"2018-04-16T17:55:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a457071611d80dd98e0df3541f812de6a1352e19","assignee":{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false},"assignees":[{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":212048370,"url":"https://api.github.com/repos/astropy/regions/labels/question","name":"question","color":"cc317c","default":true}],"milestone":{"url":"https://api.github.com/repos/astropy/regions/milestones/3","html_url":"https://github.com/astropy/regions/milestone/3","labels_url":"https://api.github.com/repos/astropy/regions/milestones/3/labels","id":1848664,"number":3,"title":"astropy-core-pr","description":"When this milestone is met, this is ready to be mored to `astropy.regions` via a pull request to the core repo.","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars3.githubusercontent.com/u/852409?v=4","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2016-06-26T08:51:39Z","updated_at":"2018-04-03T06:57:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/regions/pulls/172/commits","review_comments_url":"https://api.github.com/repos/astropy/regions/pulls/172/comments","review_comment_url":"https://api.github.com/repos/astropy/regions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/regions/issues/172/comments","statuses_url":"https://api.github.com/repos/astropy/regions/statuses/1ddfa70080311674c97b35a2f142361cc26c2585","head":{"label":"sushobhana:pixcoord","ref":"pixcoord","sha":"1ddfa70080311674c97b35a2f142361cc26c2585","user":{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false},"repo":{"id":120472441,"name":"regions","full_name":"sushobhana/regions","owner":{"login":"sushobhana","id":22423652,"avatar_url":"https://avatars0.githubusercontent.com/u/22423652?v=4","gravatar_id":"","url":"https://api.github.com/users/sushobhana","html_url":"https://github.com/sushobhana","followers_url":"https://api.github.com/users/sushobhana/followers","following_url":"https://api.github.com/users/sushobhana/following{/other_user}","gists_url":"https://api.github.com/users/sushobhana/gists{/gist_id}","starred_url":"https://api.github.com/users/sushobhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushobhana/subscriptions","organizations_url":"https://api.github.com/users/sushobhana/orgs","repos_url":"https://api.github.com/users/sushobhana/repos","events_url":"https://api.github.com/users/sushobhana/events{/privacy}","received_events_url":"https://api.github.com/users/sushobhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sushobhana/regions","description":"Astropy affiliated package for region handling","fork":true,"url":"https://api.github.com/repos/sushobhana/regions","forks_url":"https://api.github.com/repos/sushobhana/regions/forks","keys_url":"https://api.github.com/repos/sushobhana/regions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sushobhana/regions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sushobhana/regions/teams","hooks_url":"https://api.github.com/repos/sushobhana/regions/hooks","issue_events_url":"https://api.github.com/repos/sushobhana/regions/issues/events{/number}","events_url":"https://api.github.com/repos/sushobhana/regions/events","assignees_url":"https://api.github.com/repos/sushobhana/regions/assignees{/user}","branches_url":"https://api.github.com/repos/sushobhana/regions/branches{/branch}","tags_url":"https://api.github.com/repos/sushobhana/regions/tags","blobs_url":"https://api.github.com/repos/sushobhana/regions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sushobhana/regions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sushobhana/regions/git/refs{/sha}","trees_url":"https://api.github.com/repos/sushobhana/regions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sushobhana/regions/statuses/{sha}","languages_url":"https://api.github.com/repos/sushobhana/regions/languages","stargazers_url":"https://api.github.com/repos/sushobhana/regions/stargazers","contributors_url":"https://api.github.com/repos/sushobhana/regions/contributors","subscribers_url":"https://api.github.com/repos/sushobhana/regions/subscribers","subscription_url":"https://api.github.com/repos/sushobhana/regions/subscription","commits_url":"https://api.github.com/repos/sushobhana/regions/commits{/sha}","git_commits_url":"https://api.github.com/repos/sushobhana/regions/git/commits{/sha}","comments_url":"https://api.github.com/repos/sushobhana/regions/comments{/number}","issue_comment_url":"https://api.github.com/repos/sushobhana/regions/issues/comments{/number}","contents_url":"https://api.github.com/repos/sushobhana/regions/contents/{+path}","compare_url":"https://api.github.com/repos/sushobhana/regions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sushobhana/regions/merges","archive_url":"https://api.github.com/repos/sushobhana/regions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sushobhana/regions/downloads","issues_url":"https://api.github.com/repos/sushobhana/regions/issues{/number}","pulls_url":"https://api.github.com/repos/sushobhana/regions/pulls{/number}","milestones_url":"https://api.github.com/repos/sushobhana/regions/milestones{/number}","notifications_url":"https://api.github.com/repos/sushobhana/regions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sushobhana/regions/labels{/name}","releases_url":"https://api.github.com/repos/sushobhana/regions/releases{/id}","deployments_url":"https://api.github.com/repos/sushobhana/regions/deployments","created_at":"2018-02-06T14:45:12Z","updated_at":"2018-04-02T12:53:31Z","pushed_at":"2018-04-03T13:56:53Z","git_url":"git://github.com/sushobhana/regions.git","ssh_url":"git@github.com:sushobhana/regions.git","clone_url":"https://github.com/sushobhana/regions.git","svn_url":"https://github.com/sushobhana/regions","homepage":"http://astropy-regions.readthedocs.org/en/latest/","size":650,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"385ac2b36194141724fa59d78cb66cf2945b4455","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":35690635,"name":"regions","full_name":"astropy/regions","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/regions","description":"Astropy affiliated package for region handling","fork":false,"url":"https://api.github.com/repos/astropy/regions","forks_url":"https://api.github.com/repos/astropy/regions/forks","keys_url":"https://api.github.com/repos/astropy/regions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/regions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/regions/teams","hooks_url":"https://api.github.com/repos/astropy/regions/hooks","issue_events_url":"https://api.github.com/repos/astropy/regions/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/regions/events","assignees_url":"https://api.github.com/repos/astropy/regions/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/regions/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/regions/tags","blobs_url":"https://api.github.com/repos/astropy/regions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/regions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/regions/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/regions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/regions/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/regions/languages","stargazers_url":"https://api.github.com/repos/astropy/regions/stargazers","contributors_url":"https://api.github.com/repos/astropy/regions/contributors","subscribers_url":"https://api.github.com/repos/astropy/regions/subscribers","subscription_url":"https://api.github.com/repos/astropy/regions/subscription","commits_url":"https://api.github.com/repos/astropy/regions/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/regions/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/regions/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/regions/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/regions/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/regions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/regions/merges","archive_url":"https://api.github.com/repos/astropy/regions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/regions/downloads","issues_url":"https://api.github.com/repos/astropy/regions/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/regions/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/regions/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/regions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/regions/labels{/name}","releases_url":"https://api.github.com/repos/astropy/regions/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/regions/deployments","created_at":"2015-05-15T18:43:24Z","updated_at":"2018-04-14T04:40:07Z","pushed_at":"2018-04-03T13:56:55Z","git_url":"git://github.com/astropy/regions.git","ssh_url":"git@github.com:astropy/regions.git","clone_url":"https://github.com/astropy/regions.git","svn_url":"https://github.com/astropy/regions","homepage":"http://astropy-regions.readthedocs.org/en/latest/","size":619,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":18,"open_issues":39,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/regions/pulls/172"},"html":{"href":"https://github.com/astropy/regions/pull/172"},"issue":{"href":"https://api.github.com/repos/astropy/regions/issues/172"},"comments":{"href":"https://api.github.com/repos/astropy/regions/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/regions/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/regions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/regions/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/regions/statuses/1ddfa70080311674c97b35a2f142361cc26c2585"}},"author_association":"CONTRIBUTOR"}} | {
"id": 35690635,
"name": "astropy/regions",
"url": "https://api.github.com/repos/astropy/regions"
} | {
"id": 22423652,
"login": "sushobhana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22423652?",
"url": "https://api.github.com/users/sushobhana"
} | {
"id": 847984,
"login": "astropy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/847984?",
"url": "https://api.github.com/orgs/astropy"
} | 2018-04-16T17:55:52 | 7537705866 | {"actor":{"display_login":"sushobhana"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/comments/200459110","pull_request_review_id":134781534,"id":200459110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ1OTExMA==","diff_hunk":"@@ -229,50 +228,110 @@\n \"The index set does not contain the rebalancing collection [%s]\"\n concept-id)))))\n \n+(defn- validate-granule-index-does-not-exist\n+ \"Validates that a granule index does not already exist in the index set for the given collection\n+ concept ID.\"\n+ [index-set collection-concept-id]\n+ (let [existing-index-names (->> (get-in index-set [:index-set :granule :indexes]) (map :name) set)]\n+ (when (contains? existing-index-names collection-concept-id)\n+ (errors/throw-service-error\n+ :bad-request\n+ (format\n+ \"The collection [%s] already has a separate granule index.\"\n+ collection-concept-id)))))\n+\n+(defn- validate-granule-index-exists\n+ \"Validates that a granule index exists in the index set for the given collection concept ID.\"\n+ [index-set collection-concept-id]\n+ (let [existing-index-names (->> (get-in index-set [:index-set :granule :indexes]) (map :name) set)]\n+ (when-not (contains? existing-index-names collection-concept-id)\n+ (errors/throw-service-error\n+ :bad-request\n+ (format\n+ \"The collection [%s] is already in the small collections index.\"\n+ collection-concept-id)))))\n+\n (defn- add-new-granule-index\n \"Adds a new granule index for the given collection. Validates the collection\n does not already have an index.\"\n [index-set collection-concept-id]\n- (let [existing-index-names (->> (get-in index-set [:index-set :granule :indexes]) (map :name) set)\n- _ (when (contains? existing-index-names collection-concept-id)\n- (errors/throw-service-error\n- :bad-request\n- (format\n- \"The collection [%s] already has a separate granule index\"\n- collection-concept-id)))\n- individual-index-settings (get-in index-set [:index-set :granule :individual-index-settings])]\n+ (validate-granule-index-does-not-exist index-set collection-concept-id)\n+ (let [individual-index-settings (get-in index-set [:index-set :granule :individual-index-settings])]\n (update-in index-set [:index-set :granule :indexes]\n conj\n {:name collection-concept-id\n :settings individual-index-settings})))\n \n+(defn- remove-granule-index-from-index-set\n+ \"Removes the separate granule index for the given collection from the index set. Validates the\n+ collection index is listed in the index-set.\"\n+ [index-set collection-concept-id]\n+ (let [existing-index-names (->> (get-in index-set [:index-set :granule :indexes]) (map :name) set)]","path":"index-set-app/src/cmr/index_set/services/index_service.clj","position":72,"original_position":72,"commit_id":"59f44cffcc9a5c28dfb32836b24fe23331cd005f","original_commit_id":"59f44cffcc9a5c28dfb32836b24fe23331cd005f","user":{"login":"chris-durbin","id":4248343,"node_id":"MDQ6VXNlcjQyNDgzNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4248343?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durbin","html_url":"https://github.com/chris-durbin","followers_url":"https://api.github.com/users/chris-durbin/followers","following_url":"https://api.github.com/users/chris-durbin/following{/other_user}","gists_url":"https://api.github.com/users/chris-durbin/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durbin/subscriptions","organizations_url":"https://api.github.com/users/chris-durbin/orgs","repos_url":"https://api.github.com/users/chris-durbin/repos","events_url":"https://api.github.com/users/chris-durbin/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durbin/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-07-05T19:09:08Z","updated_at":"2018-07-05T19:09:09Z","html_url":"https://github.com/nasa/Common-Metadata-Repository/pull/533#discussion_r200459110","pull_request_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/comments/200459110"},"html":{"href":"https://github.com/nasa/Common-Metadata-Repository/pull/533#discussion_r200459110"},"pull_request":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533"}},"in_reply_to_id":200341095},"pull_request":{"url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533","id":199047499,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDQ3NDk5","html_url":"https://github.com/nasa/Common-Metadata-Repository/pull/533","diff_url":"https://github.com/nasa/Common-Metadata-Repository/pull/533.diff","patch_url":"https://github.com/nasa/Common-Metadata-Repository/pull/533.patch","issue_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/533","number":533,"state":"open","locked":false,"title":"CMR-4992: Update rebalancing-collections to support moving from a separate index to a the small collections index.","user":{"login":"chris-durbin","id":4248343,"node_id":"MDQ6VXNlcjQyNDgzNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4248343?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durbin","html_url":"https://github.com/chris-durbin","followers_url":"https://api.github.com/users/chris-durbin/followers","following_url":"https://api.github.com/users/chris-durbin/following{/other_user}","gists_url":"https://api.github.com/users/chris-durbin/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durbin/subscriptions","organizations_url":"https://api.github.com/users/chris-durbin/orgs","repos_url":"https://api.github.com/users/chris-durbin/repos","events_url":"https://api.github.com/users/chris-durbin/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durbin/received_events","type":"User","site_admin":false},"body":"\r\n\r\nThere are almost 70 collections that have 0 or a small number of granules today that currently have their own granule indexes. This happens when a collection that previously had a large (> 300,000) number of granules is deleted, or the majority of the granules within the collection have been deleted.\r\n\r\nThe reason we want to clean this up is that there is overhead with managing the shards in Elasticsearch, and when there are almost empty shards the nodes can become imbalanced. After this PR we'll be able to clean up almost 700 of the 3200 shards in Elasticsearch today.","created_at":"2018-07-03T18:24:38Z","updated_at":"2018-07-05T19:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef9a9fa821a4fde457641f25c567a4e7f6d60228","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533/commits","review_comments_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533/comments","review_comment_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/533/comments","statuses_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/statuses/59f44cffcc9a5c28dfb32836b24fe23331cd005f","head":{"label":"chris-durbin:CMR-4992","ref":"CMR-4992","sha":"59f44cffcc9a5c28dfb32836b24fe23331cd005f","user":{"login":"chris-durbin","id":4248343,"node_id":"MDQ6VXNlcjQyNDgzNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4248343?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durbin","html_url":"https://github.com/chris-durbin","followers_url":"https://api.github.com/users/chris-durbin/followers","following_url":"https://api.github.com/users/chris-durbin/following{/other_user}","gists_url":"https://api.github.com/users/chris-durbin/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durbin/subscriptions","organizations_url":"https://api.github.com/users/chris-durbin/orgs","repos_url":"https://api.github.com/users/chris-durbin/repos","events_url":"https://api.github.com/users/chris-durbin/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durbin/received_events","type":"User","site_admin":false},"repo":{"id":87346027,"node_id":"MDEwOlJlcG9zaXRvcnk4NzM0NjAyNw==","name":"Common-Metadata-Repository","full_name":"chris-durbin/Common-Metadata-Repository","owner":{"login":"chris-durbin","id":4248343,"node_id":"MDQ6VXNlcjQyNDgzNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4248343?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-durbin","html_url":"https://github.com/chris-durbin","followers_url":"https://api.github.com/users/chris-durbin/followers","following_url":"https://api.github.com/users/chris-durbin/following{/other_user}","gists_url":"https://api.github.com/users/chris-durbin/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-durbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-durbin/subscriptions","organizations_url":"https://api.github.com/users/chris-durbin/orgs","repos_url":"https://api.github.com/users/chris-durbin/repos","events_url":"https://api.github.com/users/chris-durbin/events{/privacy}","received_events_url":"https://api.github.com/users/chris-durbin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-durbin/Common-Metadata-Repository","description":null,"fork":true,"url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository","forks_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/forks","keys_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/teams","hooks_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/hooks","issue_events_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/events","assignees_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/tags","blobs_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/languages","stargazers_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/stargazers","contributors_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/contributors","subscribers_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/subscribers","subscription_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/subscription","commits_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/merges","archive_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/downloads","issues_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/labels{/name}","releases_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/chris-durbin/Common-Metadata-Repository/deployments","created_at":"2017-04-05T19:00:04Z","updated_at":"2018-06-12T17:37:27Z","pushed_at":"2018-07-03T18:14:56Z","git_url":"git://github.com/chris-durbin/Common-Metadata-Repository.git","ssh_url":"git@github.com:chris-durbin/Common-Metadata-Repository.git","clone_url":"https://github.com/chris-durbin/Common-Metadata-Repository.git","svn_url":"https://github.com/chris-durbin/Common-Metadata-Repository","homepage":null,"size":21527,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nasa:master","ref":"master","sha":"4a309f8351f2ed0b93d0c21497eeab9222c29ca1","user":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":75120133,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyMDEzMw==","name":"Common-Metadata-Repository","full_name":"nasa/Common-Metadata-Repository","owner":{"login":"nasa","id":848102,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0ODEwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/848102?v=4","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/Common-Metadata-Repository","description":null,"fork":false,"url":"https://api.github.com/repos/nasa/Common-Metadata-Repository","forks_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/forks","keys_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/teams","hooks_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/hooks","issue_events_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/events","assignees_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/tags","blobs_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/languages","stargazers_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/stargazers","contributors_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/contributors","subscribers_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/subscribers","subscription_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/subscription","commits_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/merges","archive_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/downloads","issues_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/labels{/name}","releases_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/nasa/Common-Metadata-Repository/deployments","created_at":"2016-11-29T20:41:30Z","updated_at":"2018-06-29T19:45:06Z","pushed_at":"2018-07-05T15:06:54Z","git_url":"git://github.com/nasa/Common-Metadata-Repository.git","ssh_url":"git@github.com:nasa/Common-Metadata-Repository.git","clone_url":"https://github.com/nasa/Common-Metadata-Repository.git","svn_url":"https://github.com/nasa/Common-Metadata-Repository","homepage":null,"size":21561,"stargazers_count":75,"watchers_count":75,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":6,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533"},"html":{"href":"https://github.com/nasa/Common-Metadata-Repository/pull/533"},"issue":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/533"},"comments":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/nasa/Common-Metadata-Repository/statuses/59f44cffcc9a5c28dfb32836b24fe23331cd005f"}},"author_association":"COLLABORATOR"}} | {
"id": 75120133,
"name": "nasa/Common-Metadata-Repository",
"url": "https://api.github.com/repos/nasa/Common-Metadata-Repository"
} | {
"id": 4248343,
"login": "chris-durbin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4248343?",
"url": "https://api.github.com/users/chris-durbin"
} | {
"id": 848102,
"login": "nasa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/848102?",
"url": "https://api.github.com/orgs/nasa"
} | 2018-07-05T19:09:08 | 7925045734 | {"actor":{"display_login":"chris-durbin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/171744631","pull_request_review_id":100653360,"id":171744631,"diff_hunk":"@@ -0,0 +1,183 @@\n+/**\n+ * This Source Code Form is subject to the terms of the Mozilla Public License,\n+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can\n+ * obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under\n+ * the terms of the Healthcare Disclaimer located at http://openmrs.org/license.\n+ *\n+ * Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS\n+ * graphic logo is a trademark of OpenMRS Inc.\n+ */\n+package org.openmrs.api.impl;\n+\n+import org.junit.Assert;\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.rules.ExpectedException;\n+import org.openmrs.CodedOrFreeText;\n+import org.openmrs.Condition;\n+import org.openmrs.ConditionClinicalStatus;\n+import org.openmrs.ConditionVerificationStatus;\n+import org.openmrs.api.ConditionService;\n+import org.openmrs.api.PatientService;\n+import org.openmrs.api.context.Context;\n+import org.openmrs.test.BaseContextSensitiveTest;\n+import java.util.Date;\n+import java.util.List;\n+\n+/**\n+ * Unit tests for methods that are specific to the {@link ConditionServiceImpl}. General tests that\n+ * would span implementations should go on the {@link ConditionService}.\n+ */\n+public class ConditionServiceImplTest extends BaseContextSensitiveTest {\n+\t\n+\tprotected static final String CONDITION_XML = \"org/openmrs/api/include/ConditionServiceImplTest-SetupCondition.xml\";\n+\t\n+\tprivate ConditionService conditionService;\n+\t\n+\tprivate PatientService patientService;\n+\t\n+\t@Rule\n+\tpublic ExpectedException expectedException = ExpectedException.none();\n+\t\n+\t@Before\n+\tpublic void setup (){\n+\t\tif(conditionService == null){\n+\t\t\tconditionService = Context.getConditionService();\n+\t\t}\n+\t\tif(patientService == null){\n+\t\t\tpatientService = Context.getPatientService();\n+\t\t}\n+\t\texecuteDataSet(CONDITION_XML);\n+\t}\n+\n+\t/**\n+\t * @see ConditionService#saveCondition(Condition) \n+\t */\n+\t@Test\n+\tpublic void saveCondition_shouldSaveNewCondition(){\n+\t\tInteger patientId = 2;\n+\t\tDate date = new Date();\n+\t\tString uuid = \"08002000-4469-12q3-551f-0339000c9a76\";\n+\t\tString additionalDetail = \"saving a condition\";\n+\t\tCodedOrFreeText codedOrFreeText = new CodedOrFreeText();\n+\t\tCondition condition = new Condition();\n+\t\tcondition.setCondition(codedOrFreeText);\n+\t\tcondition.setClinicalStatus(ConditionClinicalStatus.ACTIVE);\n+\t\tcondition.setAdditionalDetail(additionalDetail);\n+\t\tcondition.setVerificationStatus(ConditionVerificationStatus.CONFIRMED);\n+\t\tcondition.setOnsetDate(date);\n+\t\tcondition.setUuid(uuid);\n+\t\tcondition.setPatient(patientService.getPatient(patientId));\n+\t\t\n+\t\tconditionService.saveCondition(condition);\n+\t\tCondition savedCondition = conditionService.getConditionByUuid(uuid);\n+\t\t\n+\t\tAssert.assertEquals(additionalDetail, savedCondition.getAdditionalDetail());\n+\t\tAssert.assertEquals(ConditionVerificationStatus.CONFIRMED, savedCondition.getVerificationStatus());\n+\t\tAssert.assertEquals(ConditionClinicalStatus.ACTIVE, savedCondition.getClinicalStatus());\n+\t\tAssert.assertEquals(uuid, savedCondition.getUuid());\n+\t\tAssert.assertEquals(patientId, savedCondition.getPatient().getPatientId());\n+\t\tAssert.assertEquals(codedOrFreeText, savedCondition.getCondition());\n+\t}\n+\n+\t/**\n+\t * @see ConditionService#getConditionByUuid(String)\n+\t */\n+\t@Test\n+\tpublic void getConditionByUuid_shouldFindConditionGivenValidUuid() {\n+\t\tString uuid=\"2cc6880e-2c46-15e4-9038-a6c5e4d22fb7\";\n+\t\tString clinical_status = \"INACTIVE\";\n+\t\tString verification_status = \"PROVISIONAL\";\n+\t\tCondition condition = conditionService.getConditionByUuid(uuid);\n+\t\tAssert.assertEquals(clinical_status, condition.getClinicalStatus().toString());\n+\t\tAssert.assertEquals(verification_status, condition.getVerificationStatus().toString());\n+\t}\n+\n+\t/**\n+\t * @see ConditionService#getConditionByUuid(String)\n+\t */\n+\t@Test\n+\tpublic void getConditionByUuid_shouldReturnNullIfNoObjectFoundWithGivenUuid() {\n+\t\tAssert.assertNull(conditionService.getConditionByUuid(\"invalid uuid\"));\n+\t}\n+\n+\t/**\n+\t * @see ConditionService#getCondition(Integer) \n+\t */\n+\t@Test\n+\tpublic void getConditionById_shouldFindConditionGivenValidId() {","path":"api/src/test/java/org/openmrs/api/impl/ConditionServiceImplTest.java","position":109,"original_position":109,"commit_id":"c713e0a9bd76c677522022fbd98b24c07841b266","original_commit_id":"c713e0a9bd76c677522022fbd98b24c07841b266","user":{"login":"wluyima","id":1395907,"avatar_url":"https://avatars0.githubusercontent.com/u/1395907?v=4","gravatar_id":"","url":"https://api.github.com/users/wluyima","html_url":"https://github.com/wluyima","followers_url":"https://api.github.com/users/wluyima/followers","following_url":"https://api.github.com/users/wluyima/following{/other_user}","gists_url":"https://api.github.com/users/wluyima/gists{/gist_id}","starred_url":"https://api.github.com/users/wluyima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wluyima/subscriptions","organizations_url":"https://api.github.com/users/wluyima/orgs","repos_url":"https://api.github.com/users/wluyima/repos","events_url":"https://api.github.com/users/wluyima/events{/privacy}","received_events_url":"https://api.github.com/users/wluyima/received_events","type":"User","site_admin":false},"body":"Should this test be named `getConditionBy_shouldFindConditionGivenValidId(`)?","created_at":"2018-03-02T01:26:27Z","updated_at":"2018-03-02T01:26:27Z","html_url":"https://github.com/openmrs/openmrs-core/pull/2600#discussion_r171744631","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/171744631"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2600#discussion_r171744631"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600","id":171327891,"html_url":"https://github.com/openmrs/openmrs-core/pull/2600","diff_url":"https://github.com/openmrs/openmrs-core/pull/2600.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2600.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2600","number":2600,"state":"open","locked":false,"title":"TRUNK-5354: Add implementation of condition service interface","user":{"login":"paradisekelechi","id":14928334,"avatar_url":"https://avatars3.githubusercontent.com/u/14928334?v=4","gravatar_id":"","url":"https://api.github.com/users/paradisekelechi","html_url":"https://github.com/paradisekelechi","followers_url":"https://api.github.com/users/paradisekelechi/followers","following_url":"https://api.github.com/users/paradisekelechi/following{/other_user}","gists_url":"https://api.github.com/users/paradisekelechi/gists{/gist_id}","starred_url":"https://api.github.com/users/paradisekelechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradisekelechi/subscriptions","organizations_url":"https://api.github.com/users/paradisekelechi/orgs","repos_url":"https://api.github.com/users/paradisekelechi/repos","events_url":"https://api.github.com/users/paradisekelechi/events{/privacy}","received_events_url":"https://api.github.com/users/paradisekelechi/received_events","type":"User","site_admin":false},"body":"<!--- Add a pull request title above in this format -->\r\n<!--- real example: 'TRUNK-5111 Replace use of deprecated isVoided' -->\r\n<!--- 'TRUNK-JiraIssueNumber JiraIssueTitle' -->\r\n## Description of what I changed\r\n<!--- Describe your changes in detail -->\r\n<!--- It can simply be your commit message, which you must have -->\r\nImplemented the Condition Service Interface\r\nThe following files were modified\r\n- api/src/main/java/org/openmrs/api/context/Context.java\r\n- api/src/main/java/org/openmrs/api/context/ServiceContext.java\r\n- api/src/main/resources/applicationContext-service.xml\r\n- api/src/main/java/org/openmrs/validator/ConditionValidator.java\r\n- api/src/test/java/org/openmrs/validator/ConditionValidatorTest.java\r\nThe following files were added\r\n- api/src/main/java/org/openmrs/api/impl/ConditionServiceImpl.java\r\n- api/src/test/java/org/openmrs/api/impl/ConditionServiceImplTest.java\r\n- api/src/test/resources/org/openmrs/api/include/ConditionServiceImplTest-SetupCondition.xml\r\n\r\n## Issue I worked on\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- Want a new feature or change? Discuss it in an issue first -->\r\n<!--- Found a bug? Point us to the issue/or create one so we can reproduce it -->\r\n<!--- Just add the issue number at the end: -->\r\nsee https://issues.openmrs.org/browse/TRUNK-5354\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n<!--- Put an `x` in the box if you did the task -->\r\n<!--- If you forgot a task please follow the instructions below -->\r\n- [x] My pull request only contains **ONE single commit**\r\n(the number above, next to the 'Commits' tab is 1).\r\n\r\n No? -> [read here](https://wiki.openmrs.org/display/docs/Pull+Request+Tips) on how to squash multiple commits into one\r\n\r\n- [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.\r\n\r\n No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend`\r\n\r\n- [x] I have **added tests** to cover my changes. (If you refactored\r\n existing code that was well tested you do not have to add tests)\r\n\r\n No? -> write tests and add them to this commit `git add . && git commit --amend`\r\n\r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n added all formatting changes to my commit.\r\n\r\n No? -> execute above command\r\n\r\n- [x] All new and existing **tests passed**.\r\n\r\n No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.\r\n\r\n- [x] My pull request is **based on the latest changes** of the master branch.\r\n\r\n No? Unsure? -> execute command `git pull --rebase upstream master`\r\n\r\n","created_at":"2018-02-26T10:00:13Z","updated_at":"2018-03-02T01:26:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8eb485503a851cdb0830dc0f988c788e4cfe918","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2600/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/c713e0a9bd76c677522022fbd98b24c07841b266","head":{"label":"paradisekelechi:TRUNK-5354","ref":"TRUNK-5354","sha":"c713e0a9bd76c677522022fbd98b24c07841b266","user":{"login":"paradisekelechi","id":14928334,"avatar_url":"https://avatars3.githubusercontent.com/u/14928334?v=4","gravatar_id":"","url":"https://api.github.com/users/paradisekelechi","html_url":"https://github.com/paradisekelechi","followers_url":"https://api.github.com/users/paradisekelechi/followers","following_url":"https://api.github.com/users/paradisekelechi/following{/other_user}","gists_url":"https://api.github.com/users/paradisekelechi/gists{/gist_id}","starred_url":"https://api.github.com/users/paradisekelechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradisekelechi/subscriptions","organizations_url":"https://api.github.com/users/paradisekelechi/orgs","repos_url":"https://api.github.com/users/paradisekelechi/repos","events_url":"https://api.github.com/users/paradisekelechi/events{/privacy}","received_events_url":"https://api.github.com/users/paradisekelechi/received_events","type":"User","site_admin":false},"repo":{"id":121345652,"name":"openmrs-core","full_name":"paradisekelechi/openmrs-core","owner":{"login":"paradisekelechi","id":14928334,"avatar_url":"https://avatars3.githubusercontent.com/u/14928334?v=4","gravatar_id":"","url":"https://api.github.com/users/paradisekelechi","html_url":"https://github.com/paradisekelechi","followers_url":"https://api.github.com/users/paradisekelechi/followers","following_url":"https://api.github.com/users/paradisekelechi/following{/other_user}","gists_url":"https://api.github.com/users/paradisekelechi/gists{/gist_id}","starred_url":"https://api.github.com/users/paradisekelechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradisekelechi/subscriptions","organizations_url":"https://api.github.com/users/paradisekelechi/orgs","repos_url":"https://api.github.com/users/paradisekelechi/repos","events_url":"https://api.github.com/users/paradisekelechi/events{/privacy}","received_events_url":"https://api.github.com/users/paradisekelechi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paradisekelechi/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/paradisekelechi/openmrs-core","forks_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/forks","keys_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/teams","hooks_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/events","assignees_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/tags","blobs_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/subscription","commits_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/merges","archive_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/downloads","issues_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/paradisekelechi/openmrs-core/deployments","created_at":"2018-02-13T06:08:53Z","updated_at":"2018-02-13T06:09:01Z","pushed_at":"2018-03-01T21:13:25Z","git_url":"git://github.com/paradisekelechi/openmrs-core.git","ssh_url":"git@github.com:paradisekelechi/openmrs-core.git","clone_url":"https://github.com/paradisekelechi/openmrs-core.git","svn_url":"https://github.com/paradisekelechi/openmrs-core","homepage":"http://openmrs.org","size":227396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"bb754ce3d4ba8f378125d41a3feaf98966851796","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2018-03-01T16:45:09Z","pushed_at":"2018-03-01T21:13:29Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":227395,"stargazers_count":622,"watchers_count":622,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2053,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2053,"open_issues":22,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2600"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2600"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2600/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2600/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/c713e0a9bd76c677522022fbd98b24c07841b266"}},"author_association":"CONTRIBUTOR"}} | {
"id": 5187976,
"name": "openmrs/openmrs-core",
"url": "https://api.github.com/repos/openmrs/openmrs-core"
} | {
"id": 1395907,
"login": "wluyima",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1395907?",
"url": "https://api.github.com/users/wluyima"
} | {
"id": 860776,
"login": "openmrs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/860776?",
"url": "https://api.github.com/orgs/openmrs"
} | 2018-03-02T01:26:27 | 7319547102 | {"actor":{"display_login":"wluyima"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/186747000","pull_request_review_id":118386311,"id":186747000,"diff_hunk":"@@ -13,13 +13,14 @@ class LinearSystemComp(ImplicitComponent):\n \"\"\"\n Component that solves a linear system, Ax=b.\n \n- Designed to handle small and dense linear systems that can be\n- efficiently solved with lu-decomposition\n+ Designed to handle small, dense linear systems that can be efficiently solved with\n+ lu-decomposition. It can be vectorized to either solve for multiple right hand sides,\n+ or to solve multiple linear systems.","path":"openmdao/components/linear_system_comp.py","position":null,"original_position":8,"commit_id":"6515a14b9aa3c9f9f55229dbe1f9adc5deed3bee","original_commit_id":"621d82d702362c3aa453dadea55e989da77607d6","user":{"login":"Kenneth-T-Moore","id":867917,"avatar_url":"https://avatars2.githubusercontent.com/u/867917?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenneth-T-Moore","html_url":"https://github.com/Kenneth-T-Moore","followers_url":"https://api.github.com/users/Kenneth-T-Moore/followers","following_url":"https://api.github.com/users/Kenneth-T-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Kenneth-T-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenneth-T-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenneth-T-Moore/subscriptions","organizations_url":"https://api.github.com/users/Kenneth-T-Moore/orgs","repos_url":"https://api.github.com/users/Kenneth-T-Moore/repos","events_url":"https://api.github.com/users/Kenneth-T-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Kenneth-T-Moore/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-05-08T14:27:35Z","updated_at":"2018-05-08T14:27:35Z","html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/607#discussion_r186747000","pull_request_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/186747000"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/607#discussion_r186747000"},"pull_request":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607"}},"in_reply_to_id":186745061},"pull_request":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607","id":186403750,"html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/607","diff_url":"https://github.com/OpenMDAO/OpenMDAO/pull/607.diff","patch_url":"https://github.com/OpenMDAO/OpenMDAO/pull/607.patch","issue_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/607","number":607,"state":"open","locked":false,"title":"Vectorize the LinearSystemComp","user":{"login":"Kenneth-T-Moore","id":867917,"avatar_url":"https://avatars2.githubusercontent.com/u/867917?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenneth-T-Moore","html_url":"https://github.com/Kenneth-T-Moore","followers_url":"https://api.github.com/users/Kenneth-T-Moore/followers","following_url":"https://api.github.com/users/Kenneth-T-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Kenneth-T-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenneth-T-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenneth-T-Moore/subscriptions","organizations_url":"https://api.github.com/users/Kenneth-T-Moore/orgs","repos_url":"https://api.github.com/users/Kenneth-T-Moore/repos","events_url":"https://api.github.com/users/Kenneth-T-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Kenneth-T-Moore/received_events","type":"User","site_admin":false},"body":"1. Added vectorization options (both for multiple RHS and multiple linear systems)\r\n2 Added a feature doc for this component.\r\n3. Removed the partial_type option since it really isn't needed.\r\n4. Upped coverage of this comp to 100%.","created_at":"2018-05-07T16:48:07Z","updated_at":"2018-05-08T14:27:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb7fe96f8c864e4cb3cddcb26dd5e325b4877a63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607/commits","review_comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607/comments","review_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/607/comments","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/6515a14b9aa3c9f9f55229dbe1f9adc5deed3bee","head":{"label":"Kenneth-T-Moore:ken1","ref":"ken1","sha":"6515a14b9aa3c9f9f55229dbe1f9adc5deed3bee","user":{"login":"Kenneth-T-Moore","id":867917,"avatar_url":"https://avatars2.githubusercontent.com/u/867917?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenneth-T-Moore","html_url":"https://github.com/Kenneth-T-Moore","followers_url":"https://api.github.com/users/Kenneth-T-Moore/followers","following_url":"https://api.github.com/users/Kenneth-T-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Kenneth-T-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenneth-T-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenneth-T-Moore/subscriptions","organizations_url":"https://api.github.com/users/Kenneth-T-Moore/orgs","repos_url":"https://api.github.com/users/Kenneth-T-Moore/repos","events_url":"https://api.github.com/users/Kenneth-T-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Kenneth-T-Moore/received_events","type":"User","site_admin":false},"repo":{"id":96469346,"name":"blue","full_name":"Kenneth-T-Moore/blue","owner":{"login":"Kenneth-T-Moore","id":867917,"avatar_url":"https://avatars2.githubusercontent.com/u/867917?v=4","gravatar_id":"","url":"https://api.github.com/users/Kenneth-T-Moore","html_url":"https://github.com/Kenneth-T-Moore","followers_url":"https://api.github.com/users/Kenneth-T-Moore/followers","following_url":"https://api.github.com/users/Kenneth-T-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Kenneth-T-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Kenneth-T-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kenneth-T-Moore/subscriptions","organizations_url":"https://api.github.com/users/Kenneth-T-Moore/orgs","repos_url":"https://api.github.com/users/Kenneth-T-Moore/repos","events_url":"https://api.github.com/users/Kenneth-T-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Kenneth-T-Moore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kenneth-T-Moore/blue","description":null,"fork":true,"url":"https://api.github.com/repos/Kenneth-T-Moore/blue","forks_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/forks","keys_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/teams","hooks_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/hooks","issue_events_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/issues/events{/number}","events_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/events","assignees_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/assignees{/user}","branches_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/branches{/branch}","tags_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/tags","blobs_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/statuses/{sha}","languages_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/languages","stargazers_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/stargazers","contributors_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/contributors","subscribers_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/subscribers","subscription_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/subscription","commits_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/contents/{+path}","compare_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/merges","archive_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/downloads","issues_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/issues{/number}","pulls_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/pulls{/number}","milestones_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/milestones{/number}","notifications_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/labels{/name}","releases_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/releases{/id}","deployments_url":"https://api.github.com/repos/Kenneth-T-Moore/blue/deployments","created_at":"2017-07-06T20:28:07Z","updated_at":"2017-07-06T20:28:09Z","pushed_at":"2018-05-08T14:27:19Z","git_url":"git://github.com/Kenneth-T-Moore/blue.git","ssh_url":"git@github.com:Kenneth-T-Moore/blue.git","clone_url":"https://github.com/Kenneth-T-Moore/blue.git","svn_url":"https://github.com/Kenneth-T-Moore/blue","homepage":null,"size":11994,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMDAO:master","ref":"master","sha":"41981fd24d1d97e988caa8496128f16c5294cf86","user":{"login":"OpenMDAO","id":861615,"avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"repo":{"id":66572302,"name":"OpenMDAO","full_name":"OpenMDAO/OpenMDAO","owner":{"login":"OpenMDAO","id":861615,"avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMDAO/OpenMDAO","description":"OpenMDAO 2.0 repository. ","fork":false,"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO","forks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/forks","keys_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/teams","hooks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/hooks","issue_events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/events","assignees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/tags","blobs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/languages","stargazers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/stargazers","contributors_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contributors","subscribers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscribers","subscription_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscription","commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/merges","archive_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/downloads","issues_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/labels{/name}","releases_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/deployments","created_at":"2016-08-25T15:53:25Z","updated_at":"2018-05-07T14:35:26Z","pushed_at":"2018-05-08T14:27:21Z","git_url":"git://github.com/OpenMDAO/OpenMDAO.git","ssh_url":"git@github.com:OpenMDAO/OpenMDAO.git","clone_url":"https://github.com/OpenMDAO/OpenMDAO.git","svn_url":"https://github.com/OpenMDAO/OpenMDAO","homepage":"http://openmdao.org","size":11825,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":30,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/607"},"issue":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/607"},"comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/6515a14b9aa3c9f9f55229dbe1f9adc5deed3bee"}},"author_association":"OWNER"}} | {
"id": 66572302,
"name": "OpenMDAO/OpenMDAO",
"url": "https://api.github.com/repos/OpenMDAO/OpenMDAO"
} | {
"id": 867917,
"login": "Kenneth-T-Moore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/867917?",
"url": "https://api.github.com/users/Kenneth-T-Moore"
} | {
"id": 861615,
"login": "OpenMDAO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/861615?",
"url": "https://api.github.com/orgs/OpenMDAO"
} | 2018-05-08T14:27:35 | 7644048358 | {"actor":{"display_login":"Kenneth-T-Moore"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/comments/196511213","pull_request_review_id":130078142,"id":196511213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUxMTIxMw==","diff_hunk":"@@ -0,0 +1,49 @@\n+/*\n+ * Autopsy Forensic Browser\n+ *\n+ * Copyright 2011 Basis Technology Corp.\n+ * Contact: carrier <at> sleuthkit <dot> org\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.sleuthkit.autopsy.commonfilesearch;\n+\n+import java.util.List;\n+import org.sleuthkit.datamodel.AbstractFile;\n+import org.openide.nodes.Children;\n+import org.openide.nodes.Node;\n+\n+/**\n+ *\n+ * @author bsweeney\n+ */\n+class CommonFilesChildren extends Children.Keys<AbstractFile>{\n+\n+ CommonFilesChildren(boolean lazy, List<AbstractFile> fileList){\n+ super(lazy);\n+ this.setKeys(fileList);\n+ }\n+ \n+ @Override\n+ protected Node[] createNodes(AbstractFile t) {\n+ \n+ if(t.isDir()){\n+ //TODO log an error ???\n+ \n+ } else {\n+ \n+ }\n+ throw new UnsupportedOperationException(\"Not supported yet.\"); //To change body of generated methods, choose Tools | Templates.\n+ }","path":"Core/src/org/sleuthkit/autopsy/commonfilesearch/CommonFilesChildren.java","position":47,"original_position":47,"commit_id":"a51a2da70af156cda2187ba075256b262e3e5ce1","original_commit_id":"a51a2da70af156cda2187ba075256b262e3e5ce1","user":{"login":"aziehl","id":5732585,"node_id":"MDQ6VXNlcjU3MzI1ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/5732585?v=4","gravatar_id":"","url":"https://api.github.com/users/aziehl","html_url":"https://github.com/aziehl","followers_url":"https://api.github.com/users/aziehl/followers","following_url":"https://api.github.com/users/aziehl/following{/other_user}","gists_url":"https://api.github.com/users/aziehl/gists{/gist_id}","starred_url":"https://api.github.com/users/aziehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aziehl/subscriptions","organizations_url":"https://api.github.com/users/aziehl/orgs","repos_url":"https://api.github.com/users/aziehl/repos","events_url":"https://api.github.com/users/aziehl/events{/privacy}","received_events_url":"https://api.github.com/users/aziehl/received_events","type":"User","site_admin":false},"body":"Removed, this was an unmerged fragment","created_at":"2018-06-19T17:22:30Z","updated_at":"2018-06-19T17:22:30Z","html_url":"https://github.com/sleuthkit/autopsy/pull/3856#discussion_r196511213","pull_request_url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/comments/196511213"},"html":{"href":"https://github.com/sleuthkit/autopsy/pull/3856#discussion_r196511213"},"pull_request":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856"}},"in_reply_to_id":196431187},"pull_request":{"url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856","id":194998767,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTk4NzY3","html_url":"https://github.com/sleuthkit/autopsy/pull/3856","diff_url":"https://github.com/sleuthkit/autopsy/pull/3856.diff","patch_url":"https://github.com/sleuthkit/autopsy/pull/3856.patch","issue_url":"https://api.github.com/repos/sleuthkit/autopsy/issues/3856","number":3856,"state":"open","locked":false,"title":"3870 progress bar callable","user":{"login":"aziehl","id":5732585,"node_id":"MDQ6VXNlcjU3MzI1ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/5732585?v=4","gravatar_id":"","url":"https://api.github.com/users/aziehl","html_url":"https://github.com/aziehl","followers_url":"https://api.github.com/users/aziehl/followers","following_url":"https://api.github.com/users/aziehl/following{/other_user}","gists_url":"https://api.github.com/users/aziehl/gists{/gist_id}","starred_url":"https://api.github.com/users/aziehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aziehl/subscriptions","organizations_url":"https://api.github.com/users/aziehl/orgs","repos_url":"https://api.github.com/users/aziehl/repos","events_url":"https://api.github.com/users/aziehl/events{/privacy}","received_events_url":"https://api.github.com/users/aziehl/received_events","type":"User","site_admin":false},"body":"upstream develop with just the progress bar and callable wrapper changes for 3870.","created_at":"2018-06-14T19:47:26Z","updated_at":"2018-06-19T17:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc7c25f37f66943a07d0b3c99fcf9ead3e88c704","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856/commits","review_comments_url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856/comments","review_comment_url":"https://api.github.com/repos/sleuthkit/autopsy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sleuthkit/autopsy/issues/3856/comments","statuses_url":"https://api.github.com/repos/sleuthkit/autopsy/statuses/a51a2da70af156cda2187ba075256b262e3e5ce1","head":{"label":"briangsweeney:3870-progress-bar-callable","ref":"3870-progress-bar-callable","sha":"a51a2da70af156cda2187ba075256b262e3e5ce1","user":{"login":"briangsweeney","id":10343515,"node_id":"MDQ6VXNlcjEwMzQzNTE1","avatar_url":"https://avatars1.githubusercontent.com/u/10343515?v=4","gravatar_id":"","url":"https://api.github.com/users/briangsweeney","html_url":"https://github.com/briangsweeney","followers_url":"https://api.github.com/users/briangsweeney/followers","following_url":"https://api.github.com/users/briangsweeney/following{/other_user}","gists_url":"https://api.github.com/users/briangsweeney/gists{/gist_id}","starred_url":"https://api.github.com/users/briangsweeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briangsweeney/subscriptions","organizations_url":"https://api.github.com/users/briangsweeney/orgs","repos_url":"https://api.github.com/users/briangsweeney/repos","events_url":"https://api.github.com/users/briangsweeney/events{/privacy}","received_events_url":"https://api.github.com/users/briangsweeney/received_events","type":"User","site_admin":false},"repo":{"id":124417085,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MTcwODU=","name":"autopsy","full_name":"briangsweeney/autopsy","owner":{"login":"briangsweeney","id":10343515,"node_id":"MDQ6VXNlcjEwMzQzNTE1","avatar_url":"https://avatars1.githubusercontent.com/u/10343515?v=4","gravatar_id":"","url":"https://api.github.com/users/briangsweeney","html_url":"https://github.com/briangsweeney","followers_url":"https://api.github.com/users/briangsweeney/followers","following_url":"https://api.github.com/users/briangsweeney/following{/other_user}","gists_url":"https://api.github.com/users/briangsweeney/gists{/gist_id}","starred_url":"https://api.github.com/users/briangsweeney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briangsweeney/subscriptions","organizations_url":"https://api.github.com/users/briangsweeney/orgs","repos_url":"https://api.github.com/users/briangsweeney/repos","events_url":"https://api.github.com/users/briangsweeney/events{/privacy}","received_events_url":"https://api.github.com/users/briangsweeney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briangsweeney/autopsy","description":"Autopsy® is a digital forensics platform and graphical interface to The Sleuth Kit® and other digital forensics tools. It can be used by law enforcement, military, and corporate examiners to investigate what happened on a computer. You can even use it to recover photos from your camera's memory card. ","fork":true,"url":"https://api.github.com/repos/briangsweeney/autopsy","forks_url":"https://api.github.com/repos/briangsweeney/autopsy/forks","keys_url":"https://api.github.com/repos/briangsweeney/autopsy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briangsweeney/autopsy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briangsweeney/autopsy/teams","hooks_url":"https://api.github.com/repos/briangsweeney/autopsy/hooks","issue_events_url":"https://api.github.com/repos/briangsweeney/autopsy/issues/events{/number}","events_url":"https://api.github.com/repos/briangsweeney/autopsy/events","assignees_url":"https://api.github.com/repos/briangsweeney/autopsy/assignees{/user}","branches_url":"https://api.github.com/repos/briangsweeney/autopsy/branches{/branch}","tags_url":"https://api.github.com/repos/briangsweeney/autopsy/tags","blobs_url":"https://api.github.com/repos/briangsweeney/autopsy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briangsweeney/autopsy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briangsweeney/autopsy/git/refs{/sha}","trees_url":"https://api.github.com/repos/briangsweeney/autopsy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briangsweeney/autopsy/statuses/{sha}","languages_url":"https://api.github.com/repos/briangsweeney/autopsy/languages","stargazers_url":"https://api.github.com/repos/briangsweeney/autopsy/stargazers","contributors_url":"https://api.github.com/repos/briangsweeney/autopsy/contributors","subscribers_url":"https://api.github.com/repos/briangsweeney/autopsy/subscribers","subscription_url":"https://api.github.com/repos/briangsweeney/autopsy/subscription","commits_url":"https://api.github.com/repos/briangsweeney/autopsy/commits{/sha}","git_commits_url":"https://api.github.com/repos/briangsweeney/autopsy/git/commits{/sha}","comments_url":"https://api.github.com/repos/briangsweeney/autopsy/comments{/number}","issue_comment_url":"https://api.github.com/repos/briangsweeney/autopsy/issues/comments{/number}","contents_url":"https://api.github.com/repos/briangsweeney/autopsy/contents/{+path}","compare_url":"https://api.github.com/repos/briangsweeney/autopsy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briangsweeney/autopsy/merges","archive_url":"https://api.github.com/repos/briangsweeney/autopsy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briangsweeney/autopsy/downloads","issues_url":"https://api.github.com/repos/briangsweeney/autopsy/issues{/number}","pulls_url":"https://api.github.com/repos/briangsweeney/autopsy/pulls{/number}","milestones_url":"https://api.github.com/repos/briangsweeney/autopsy/milestones{/number}","notifications_url":"https://api.github.com/repos/briangsweeney/autopsy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briangsweeney/autopsy/labels{/name}","releases_url":"https://api.github.com/repos/briangsweeney/autopsy/releases{/id}","deployments_url":"https://api.github.com/repos/briangsweeney/autopsy/deployments","created_at":"2018-03-08T16:18:10Z","updated_at":"2018-06-14T19:25:13Z","pushed_at":"2018-06-19T16:41:38Z","git_url":"git://github.com/briangsweeney/autopsy.git","ssh_url":"git@github.com:briangsweeney/autopsy.git","clone_url":"https://github.com/briangsweeney/autopsy.git","svn_url":"https://github.com/briangsweeney/autopsy","homepage":"http://www.sleuthkit.org/autopsy/","size":612566,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sleuthkit:develop","ref":"develop","sha":"9e236be97377a3d135831342f4235272229898a2","user":{"login":"sleuthkit","id":866922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NjkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/866922?v=4","gravatar_id":"","url":"https://api.github.com/users/sleuthkit","html_url":"https://github.com/sleuthkit","followers_url":"https://api.github.com/users/sleuthkit/followers","following_url":"https://api.github.com/users/sleuthkit/following{/other_user}","gists_url":"https://api.github.com/users/sleuthkit/gists{/gist_id}","starred_url":"https://api.github.com/users/sleuthkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleuthkit/subscriptions","organizations_url":"https://api.github.com/users/sleuthkit/orgs","repos_url":"https://api.github.com/users/sleuthkit/repos","events_url":"https://api.github.com/users/sleuthkit/events{/privacy}","received_events_url":"https://api.github.com/users/sleuthkit/received_events","type":"Organization","site_admin":false},"repo":{"id":2516243,"node_id":"MDEwOlJlcG9zaXRvcnkyNTE2MjQz","name":"autopsy","full_name":"sleuthkit/autopsy","owner":{"login":"sleuthkit","id":866922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NjkyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/866922?v=4","gravatar_id":"","url":"https://api.github.com/users/sleuthkit","html_url":"https://github.com/sleuthkit","followers_url":"https://api.github.com/users/sleuthkit/followers","following_url":"https://api.github.com/users/sleuthkit/following{/other_user}","gists_url":"https://api.github.com/users/sleuthkit/gists{/gist_id}","starred_url":"https://api.github.com/users/sleuthkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleuthkit/subscriptions","organizations_url":"https://api.github.com/users/sleuthkit/orgs","repos_url":"https://api.github.com/users/sleuthkit/repos","events_url":"https://api.github.com/users/sleuthkit/events{/privacy}","received_events_url":"https://api.github.com/users/sleuthkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sleuthkit/autopsy","description":"Autopsy® is a digital forensics platform and graphical interface to The Sleuth Kit® and other digital forensics tools. It can be used by law enforcement, military, and corporate examiners to investigate what happened on a computer. You can even use it to recover photos from your camera's memory card. ","fork":false,"url":"https://api.github.com/repos/sleuthkit/autopsy","forks_url":"https://api.github.com/repos/sleuthkit/autopsy/forks","keys_url":"https://api.github.com/repos/sleuthkit/autopsy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sleuthkit/autopsy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sleuthkit/autopsy/teams","hooks_url":"https://api.github.com/repos/sleuthkit/autopsy/hooks","issue_events_url":"https://api.github.com/repos/sleuthkit/autopsy/issues/events{/number}","events_url":"https://api.github.com/repos/sleuthkit/autopsy/events","assignees_url":"https://api.github.com/repos/sleuthkit/autopsy/assignees{/user}","branches_url":"https://api.github.com/repos/sleuthkit/autopsy/branches{/branch}","tags_url":"https://api.github.com/repos/sleuthkit/autopsy/tags","blobs_url":"https://api.github.com/repos/sleuthkit/autopsy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sleuthkit/autopsy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sleuthkit/autopsy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sleuthkit/autopsy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sleuthkit/autopsy/statuses/{sha}","languages_url":"https://api.github.com/repos/sleuthkit/autopsy/languages","stargazers_url":"https://api.github.com/repos/sleuthkit/autopsy/stargazers","contributors_url":"https://api.github.com/repos/sleuthkit/autopsy/contributors","subscribers_url":"https://api.github.com/repos/sleuthkit/autopsy/subscribers","subscription_url":"https://api.github.com/repos/sleuthkit/autopsy/subscription","commits_url":"https://api.github.com/repos/sleuthkit/autopsy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sleuthkit/autopsy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sleuthkit/autopsy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sleuthkit/autopsy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sleuthkit/autopsy/contents/{+path}","compare_url":"https://api.github.com/repos/sleuthkit/autopsy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sleuthkit/autopsy/merges","archive_url":"https://api.github.com/repos/sleuthkit/autopsy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sleuthkit/autopsy/downloads","issues_url":"https://api.github.com/repos/sleuthkit/autopsy/issues{/number}","pulls_url":"https://api.github.com/repos/sleuthkit/autopsy/pulls{/number}","milestones_url":"https://api.github.com/repos/sleuthkit/autopsy/milestones{/number}","notifications_url":"https://api.github.com/repos/sleuthkit/autopsy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sleuthkit/autopsy/labels{/name}","releases_url":"https://api.github.com/repos/sleuthkit/autopsy/releases{/id}","deployments_url":"https://api.github.com/repos/sleuthkit/autopsy/deployments","created_at":"2011-10-05T02:11:11Z","updated_at":"2018-06-19T14:05:22Z","pushed_at":"2018-06-19T16:51:44Z","git_url":"git://github.com/sleuthkit/autopsy.git","ssh_url":"git@github.com:sleuthkit/autopsy.git","clone_url":"https://github.com/sleuthkit/autopsy.git","svn_url":"https://github.com/sleuthkit/autopsy","homepage":"http://www.sleuthkit.org/autopsy/","size":649905,"stargazers_count":568,"watchers_count":568,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":251,"open_issues":203,"watchers":568,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856"},"html":{"href":"https://github.com/sleuthkit/autopsy/pull/3856"},"issue":{"href":"https://api.github.com/repos/sleuthkit/autopsy/issues/3856"},"comments":{"href":"https://api.github.com/repos/sleuthkit/autopsy/issues/3856/comments"},"review_comments":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856/comments"},"review_comment":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sleuthkit/autopsy/pulls/3856/commits"},"statuses":{"href":"https://api.github.com/repos/sleuthkit/autopsy/statuses/a51a2da70af156cda2187ba075256b262e3e5ce1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2516243,
"name": "sleuthkit/autopsy",
"url": "https://api.github.com/repos/sleuthkit/autopsy"
} | {
"id": 5732585,
"login": "aziehl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5732585?",
"url": "https://api.github.com/users/aziehl"
} | {
"id": 866922,
"login": "sleuthkit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/866922?",
"url": "https://api.github.com/orgs/sleuthkit"
} | 2018-06-19T17:22:30 | 7847097909 | {"actor":{"display_login":"aziehl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/190712686","pull_request_review_id":123149642,"id":190712686,"diff_hunk":"@@ -366,13 +366,20 @@ object KSerializerDescriptorResolver {\n \n val args = mutableListOf<ValueParameterDescriptor>()\n var i = 0\n+\n+ val targ = TypeParameterDescriptorImpl.createWithDefaultBound(f, Annotations.EMPTY, false, Variance.INVARIANT, Name.identifier(\"T\"), 0)\n+ val typeArguments = listOf(TypeProjectionImpl(targ.defaultType))\n+\n+ val koutputClass = KotlinTypeFactory.simpleNotNullType(Annotations.EMPTY,","path":"plugins/kotlin-serialization/kotlin-serialization-compiler/src/org/jetbrains/kotlinx/serialization/compiler/resolve/KSerializerDescriptorResolver.kt","position":8,"original_position":8,"commit_id":"ca118a97446f0ddc1a6f53a61476e6c44b541369","original_commit_id":"ca118a97446f0ddc1a6f53a61476e6c44b541369","user":{"login":"pdvrieze","id":15138068,"avatar_url":"https://avatars3.githubusercontent.com/u/15138068?v=4","gravatar_id":"","url":"https://api.github.com/users/pdvrieze","html_url":"https://github.com/pdvrieze","followers_url":"https://api.github.com/users/pdvrieze/followers","following_url":"https://api.github.com/users/pdvrieze/following{/other_user}","gists_url":"https://api.github.com/users/pdvrieze/gists{/gist_id}","starred_url":"https://api.github.com/users/pdvrieze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdvrieze/subscriptions","organizations_url":"https://api.github.com/users/pdvrieze/orgs","repos_url":"https://api.github.com/users/pdvrieze/repos","events_url":"https://api.github.com/users/pdvrieze/events{/privacy}","received_events_url":"https://api.github.com/users/pdvrieze/received_events","type":"User","site_admin":false},"body":"Probably by accident. I didn't look carefully at koutput","created_at":"2018-05-24T20:00:08Z","updated_at":"2018-05-24T20:00:08Z","html_url":"https://github.com/JetBrains/kotlin/pull/1684#discussion_r190712686","pull_request_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/190712686"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1684#discussion_r190712686"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684"}},"in_reply_to_id":190547080},"pull_request":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684","id":189686055,"html_url":"https://github.com/JetBrains/kotlin/pull/1684","diff_url":"https://github.com/JetBrains/kotlin/pull/1684.diff","patch_url":"https://github.com/JetBrains/kotlin/pull/1684.patch","issue_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1684","number":1684,"state":"open","locked":false,"title":"Fix for Kotlin/kotlinx.serialization/136","user":{"login":"pdvrieze","id":15138068,"avatar_url":"https://avatars3.githubusercontent.com/u/15138068?v=4","gravatar_id":"","url":"https://api.github.com/users/pdvrieze","html_url":"https://github.com/pdvrieze","followers_url":"https://api.github.com/users/pdvrieze/followers","following_url":"https://api.github.com/users/pdvrieze/following{/other_user}","gists_url":"https://api.github.com/users/pdvrieze/gists{/gist_id}","starred_url":"https://api.github.com/users/pdvrieze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdvrieze/subscriptions","organizations_url":"https://api.github.com/users/pdvrieze/orgs","repos_url":"https://api.github.com/users/pdvrieze/repos","events_url":"https://api.github.com/users/pdvrieze/events{/privacy}","received_events_url":"https://api.github.com/users/pdvrieze/received_events","type":"User","site_admin":false},"body":"Create a version that actually passes a type parameter in write$Self","created_at":"2018-05-22T14:37:44Z","updated_at":"2018-05-24T20:00:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69e7f770cb44e689d66143a658195d72cc0c9e73","assignee":{"login":"sandwwraith","id":11777575,"avatar_url":"https://avatars1.githubusercontent.com/u/11777575?v=4","gravatar_id":"","url":"https://api.github.com/users/sandwwraith","html_url":"https://github.com/sandwwraith","followers_url":"https://api.github.com/users/sandwwraith/followers","following_url":"https://api.github.com/users/sandwwraith/following{/other_user}","gists_url":"https://api.github.com/users/sandwwraith/gists{/gist_id}","starred_url":"https://api.github.com/users/sandwwraith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandwwraith/subscriptions","organizations_url":"https://api.github.com/users/sandwwraith/orgs","repos_url":"https://api.github.com/users/sandwwraith/repos","events_url":"https://api.github.com/users/sandwwraith/events{/privacy}","received_events_url":"https://api.github.com/users/sandwwraith/received_events","type":"User","site_admin":false},"assignees":[{"login":"sandwwraith","id":11777575,"avatar_url":"https://avatars1.githubusercontent.com/u/11777575?v=4","gravatar_id":"","url":"https://api.github.com/users/sandwwraith","html_url":"https://github.com/sandwwraith","followers_url":"https://api.github.com/users/sandwwraith/followers","following_url":"https://api.github.com/users/sandwwraith/following{/other_user}","gists_url":"https://api.github.com/users/sandwwraith/gists{/gist_id}","starred_url":"https://api.github.com/users/sandwwraith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandwwraith/subscriptions","organizations_url":"https://api.github.com/users/sandwwraith/orgs","repos_url":"https://api.github.com/users/sandwwraith/repos","events_url":"https://api.github.com/users/sandwwraith/events{/privacy}","received_events_url":"https://api.github.com/users/sandwwraith/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684/commits","review_comments_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684/comments","review_comment_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1684/comments","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/ca118a97446f0ddc1a6f53a61476e6c44b541369","head":{"label":"pdvrieze:fix_missing_type_arg","ref":"fix_missing_type_arg","sha":"ca118a97446f0ddc1a6f53a61476e6c44b541369","user":{"login":"pdvrieze","id":15138068,"avatar_url":"https://avatars3.githubusercontent.com/u/15138068?v=4","gravatar_id":"","url":"https://api.github.com/users/pdvrieze","html_url":"https://github.com/pdvrieze","followers_url":"https://api.github.com/users/pdvrieze/followers","following_url":"https://api.github.com/users/pdvrieze/following{/other_user}","gists_url":"https://api.github.com/users/pdvrieze/gists{/gist_id}","starred_url":"https://api.github.com/users/pdvrieze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdvrieze/subscriptions","organizations_url":"https://api.github.com/users/pdvrieze/orgs","repos_url":"https://api.github.com/users/pdvrieze/repos","events_url":"https://api.github.com/users/pdvrieze/events{/privacy}","received_events_url":"https://api.github.com/users/pdvrieze/received_events","type":"User","site_admin":false},"repo":{"id":134410443,"name":"kotlin","full_name":"pdvrieze/kotlin","owner":{"login":"pdvrieze","id":15138068,"avatar_url":"https://avatars3.githubusercontent.com/u/15138068?v=4","gravatar_id":"","url":"https://api.github.com/users/pdvrieze","html_url":"https://github.com/pdvrieze","followers_url":"https://api.github.com/users/pdvrieze/followers","following_url":"https://api.github.com/users/pdvrieze/following{/other_user}","gists_url":"https://api.github.com/users/pdvrieze/gists{/gist_id}","starred_url":"https://api.github.com/users/pdvrieze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdvrieze/subscriptions","organizations_url":"https://api.github.com/users/pdvrieze/orgs","repos_url":"https://api.github.com/users/pdvrieze/repos","events_url":"https://api.github.com/users/pdvrieze/events{/privacy}","received_events_url":"https://api.github.com/users/pdvrieze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdvrieze/kotlin","description":"The Kotlin Programming Language","fork":true,"url":"https://api.github.com/repos/pdvrieze/kotlin","forks_url":"https://api.github.com/repos/pdvrieze/kotlin/forks","keys_url":"https://api.github.com/repos/pdvrieze/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdvrieze/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdvrieze/kotlin/teams","hooks_url":"https://api.github.com/repos/pdvrieze/kotlin/hooks","issue_events_url":"https://api.github.com/repos/pdvrieze/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/pdvrieze/kotlin/events","assignees_url":"https://api.github.com/repos/pdvrieze/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/pdvrieze/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/pdvrieze/kotlin/tags","blobs_url":"https://api.github.com/repos/pdvrieze/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdvrieze/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdvrieze/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdvrieze/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdvrieze/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/pdvrieze/kotlin/languages","stargazers_url":"https://api.github.com/repos/pdvrieze/kotlin/stargazers","contributors_url":"https://api.github.com/repos/pdvrieze/kotlin/contributors","subscribers_url":"https://api.github.com/repos/pdvrieze/kotlin/subscribers","subscription_url":"https://api.github.com/repos/pdvrieze/kotlin/subscription","commits_url":"https://api.github.com/repos/pdvrieze/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdvrieze/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdvrieze/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdvrieze/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdvrieze/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/pdvrieze/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdvrieze/kotlin/merges","archive_url":"https://api.github.com/repos/pdvrieze/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdvrieze/kotlin/downloads","issues_url":"https://api.github.com/repos/pdvrieze/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/pdvrieze/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/pdvrieze/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/pdvrieze/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdvrieze/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/pdvrieze/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/pdvrieze/kotlin/deployments","created_at":"2018-05-22T12:15:57Z","updated_at":"2018-05-22T12:17:12Z","pushed_at":"2018-05-22T14:34:44Z","git_url":"git://github.com/pdvrieze/kotlin.git","ssh_url":"git@github.com:pdvrieze/kotlin.git","clone_url":"https://github.com/pdvrieze/kotlin.git","svn_url":"https://github.com/pdvrieze/kotlin","homepage":"http://kotlinlang.org/","size":457528,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JetBrains:rr/kotlinx.serialization","ref":"rr/kotlinx.serialization","sha":"a36d0b5f7e0029f558466a194c1fdac21af11152","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"name":"kotlin","full_name":"JetBrains/kotlin","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2018-05-24T19:27:37Z","pushed_at":"2018-05-24T19:54:35Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"http://kotlinlang.org/","size":458805,"stargazers_count":22545,"watchers_count":22545,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2526,"mirror_url":null,"archived":false,"open_issues_count":93,"license":null,"forks":2526,"open_issues":93,"watchers":22545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1684"},"issue":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1684"},"comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1684/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1684/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/kotlin/statuses/ca118a97446f0ddc1a6f53a61476e6c44b541369"}},"author_association":"NONE"}} | {
"id": 3432266,
"name": "JetBrains/kotlin",
"url": "https://api.github.com/repos/JetBrains/kotlin"
} | {
"id": 15138068,
"login": "pdvrieze",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15138068?",
"url": "https://api.github.com/users/pdvrieze"
} | {
"id": 878437,
"login": "JetBrains",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/878437?",
"url": "https://api.github.com/orgs/JetBrains"
} | 2018-05-24T20:00:08 | 7726063562 | {"actor":{"display_login":"pdvrieze"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/230171166","pull_request_review_id":170849227,"id":230171166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDE3MTE2Ng==","diff_hunk":"@@ -1,12 +1,13 @@\n package org.jetbrains.idl2k\n \n-import org.antlr.v4.runtime.ANTLRFileStream\n-import kotlin.collections.HashSet\n+import org.antlr.v4.runtime.CharStreams\n import java.io.File\n import java.io.IOException\n import java.net.URL\n+import java.nio.charset.StandardCharsets\n import java.util.ArrayList\n import java.util.LinkedHashMap\n+import kotlin.collections.HashSet","path":"libraries/tools/idl2k/src/main/kotlin/build.kt","position":12,"original_position":12,"commit_id":"c4a43da359db0335f64ba941a20b45760b99eab5","original_commit_id":"c4a43da359db0335f64ba941a20b45760b99eab5","user":{"login":"ilya-g","id":4257577,"node_id":"MDQ6VXNlcjQyNTc1Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/4257577?v=4","gravatar_id":"","url":"https://api.github.com/users/ilya-g","html_url":"https://github.com/ilya-g","followers_url":"https://api.github.com/users/ilya-g/followers","following_url":"https://api.github.com/users/ilya-g/following{/other_user}","gists_url":"https://api.github.com/users/ilya-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-g/subscriptions","organizations_url":"https://api.github.com/users/ilya-g/orgs","repos_url":"https://api.github.com/users/ilya-g/repos","events_url":"https://api.github.com/users/ilya-g/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-g/received_events","type":"User","site_admin":false},"body":"import looks redundant","created_at":"2018-11-01T19:39:22Z","updated_at":"2018-11-01T19:40:15Z","html_url":"https://github.com/JetBrains/kotlin/pull/1950#discussion_r230171166","pull_request_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/230171166"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1950#discussion_r230171166"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950","id":227732434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzMyNDM0","html_url":"https://github.com/JetBrains/kotlin/pull/1950","diff_url":"https://github.com/JetBrains/kotlin/pull/1950.diff","patch_url":"https://github.com/JetBrains/kotlin/pull/1950.patch","issue_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1950","number":1950,"state":"open","locked":false,"title":"Add mininal test suite to idl2k, remove deprecated ANTLRFileStream","user":{"login":"Schahen","id":25667761,"node_id":"MDQ6VXNlcjI1NjY3NzYx","avatar_url":"https://avatars2.githubusercontent.com/u/25667761?v=4","gravatar_id":"","url":"https://api.github.com/users/Schahen","html_url":"https://github.com/Schahen","followers_url":"https://api.github.com/users/Schahen/followers","following_url":"https://api.github.com/users/Schahen/following{/other_user}","gists_url":"https://api.github.com/users/Schahen/gists{/gist_id}","starred_url":"https://api.github.com/users/Schahen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schahen/subscriptions","organizations_url":"https://api.github.com/users/Schahen/orgs","repos_url":"https://api.github.com/users/Schahen/repos","events_url":"https://api.github.com/users/Schahen/events{/privacy}","received_events_url":"https://api.github.com/users/Schahen/received_events","type":"User","site_admin":false},"body":"- There's only one test so far that covers the very basic functionality.\r\n- For this particular PR the goal was not to change the code tested at all, that's the reason there's that two new lines in the generated code.\r\n- parameter .. is never used warning fixed\r\n- ANTLRFileStream is deprecated and removed","created_at":"2018-11-01T19:29:02Z","updated_at":"2018-11-01T19:40:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a090f5c48bb5e961778c2b0de027333677dee405","assignee":{"login":"bashor","id":485321,"node_id":"MDQ6VXNlcjQ4NTMyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/485321?v=4","gravatar_id":"","url":"https://api.github.com/users/bashor","html_url":"https://github.com/bashor","followers_url":"https://api.github.com/users/bashor/followers","following_url":"https://api.github.com/users/bashor/following{/other_user}","gists_url":"https://api.github.com/users/bashor/gists{/gist_id}","starred_url":"https://api.github.com/users/bashor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashor/subscriptions","organizations_url":"https://api.github.com/users/bashor/orgs","repos_url":"https://api.github.com/users/bashor/repos","events_url":"https://api.github.com/users/bashor/events{/privacy}","received_events_url":"https://api.github.com/users/bashor/received_events","type":"User","site_admin":false},"assignees":[{"login":"bashor","id":485321,"node_id":"MDQ6VXNlcjQ4NTMyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/485321?v=4","gravatar_id":"","url":"https://api.github.com/users/bashor","html_url":"https://github.com/bashor","followers_url":"https://api.github.com/users/bashor/followers","following_url":"https://api.github.com/users/bashor/following{/other_user}","gists_url":"https://api.github.com/users/bashor/gists{/gist_id}","starred_url":"https://api.github.com/users/bashor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashor/subscriptions","organizations_url":"https://api.github.com/users/bashor/orgs","repos_url":"https://api.github.com/users/bashor/repos","events_url":"https://api.github.com/users/bashor/events{/privacy}","received_events_url":"https://api.github.com/users/bashor/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bashor","id":485321,"node_id":"MDQ6VXNlcjQ4NTMyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/485321?v=4","gravatar_id":"","url":"https://api.github.com/users/bashor","html_url":"https://github.com/bashor","followers_url":"https://api.github.com/users/bashor/followers","following_url":"https://api.github.com/users/bashor/following{/other_user}","gists_url":"https://api.github.com/users/bashor/gists{/gist_id}","starred_url":"https://api.github.com/users/bashor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashor/subscriptions","organizations_url":"https://api.github.com/users/bashor/orgs","repos_url":"https://api.github.com/users/bashor/repos","events_url":"https://api.github.com/users/bashor/events{/privacy}","received_events_url":"https://api.github.com/users/bashor/received_events","type":"User","site_admin":false},{"login":"alexander-gorshenev","id":23235396,"node_id":"MDQ6VXNlcjIzMjM1Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/23235396?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-gorshenev","html_url":"https://github.com/alexander-gorshenev","followers_url":"https://api.github.com/users/alexander-gorshenev/followers","following_url":"https://api.github.com/users/alexander-gorshenev/following{/other_user}","gists_url":"https://api.github.com/users/alexander-gorshenev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-gorshenev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-gorshenev/subscriptions","organizations_url":"https://api.github.com/users/alexander-gorshenev/orgs","repos_url":"https://api.github.com/users/alexander-gorshenev/repos","events_url":"https://api.github.com/users/alexander-gorshenev/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-gorshenev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950/commits","review_comments_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950/comments","review_comment_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/issues/1950/comments","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/c4a43da359db0335f64ba941a20b45760b99eab5","head":{"label":"JetBrains:shagen/idl2k_tests_pr","ref":"shagen/idl2k_tests_pr","sha":"c4a43da359db0335f64ba941a20b45760b99eab5","user":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"node_id":"MDEwOlJlcG9zaXRvcnkzNDMyMjY2","name":"kotlin","full_name":"JetBrains/kotlin","private":false,"owner":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2018-11-01T19:39:19Z","pushed_at":"2018-11-01T19:29:03Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"http://kotlinlang.org/","size":508741,"stargazers_count":25005,"watchers_count":25005,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2883,"mirror_url":null,"archived":false,"open_issues_count":106,"license":null,"forks":2883,"open_issues":106,"watchers":25005,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"e9c0dea70e47f5c31fc8047ad49050b8d0e986b6","user":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"node_id":"MDEwOlJlcG9zaXRvcnkzNDMyMjY2","name":"kotlin","full_name":"JetBrains/kotlin","private":false,"owner":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2018-11-01T19:39:19Z","pushed_at":"2018-11-01T19:29:03Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"http://kotlinlang.org/","size":508741,"stargazers_count":25005,"watchers_count":25005,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2883,"mirror_url":null,"archived":false,"open_issues_count":106,"license":null,"forks":2883,"open_issues":106,"watchers":25005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/1950"},"issue":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1950"},"comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/1950/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/1950/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/kotlin/statuses/c4a43da359db0335f64ba941a20b45760b99eab5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3432266,
"name": "JetBrains/kotlin",
"url": "https://api.github.com/repos/JetBrains/kotlin"
} | {
"id": 4257577,
"login": "ilya-g",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4257577?",
"url": "https://api.github.com/users/ilya-g"
} | {
"id": 878437,
"login": "JetBrains",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/878437?",
"url": "https://api.github.com/orgs/JetBrains"
} | 2018-11-01T19:39:22 | 8521266445 | {"actor":{"display_login":"ilya-g"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/187291334","pull_request_review_id":119039655,"id":187291334,"diff_hunk":"@@ -63,18 +92,14 @@ public static TDestDelegate MapExpressionAsInclude<TDestDelegate>(this IMapper m\n if (expression == null)\r\n return null;\r\n \r\n- var typeSourceFunc = expression.GetType().GetGenericArguments()[0];\r\n- var typeDestFunc = typeof(TDestDelegate).GetGenericArguments()[0];\r\n-\r\n- var typeMappings = new Dictionary<Type, Type>()\r\n- .AddTypeMappingsFromDelegates(typeSourceFunc, typeDestFunc);\r\n-\r\n- XpressionMapperVisitor visitor = new MapIncludesVisitor(mapper == null ? Mapper.Configuration : mapper.ConfigurationProvider, typeMappings);\r\n- var remappedBody = visitor.Visit(expression.Body);\r\n- if (remappedBody == null)\r\n- throw new InvalidOperationException(Resource.cantRemapExpression);\r\n-\r\n- return (TDestDelegate)Lambda(typeDestFunc, remappedBody, expression.GetDestinationParameterExpressions(visitor.InfoDictionary, typeMappings));\r\n+ return mapper.MapExpression<TDestDelegate>\n+ (\n+ mapper == null ? Mapper.Configuration : mapper.ConfigurationProvider,\n+ expression,\n+ expression.GetType().GetGenericArguments()[0],\n+ typeof(TDestDelegate).GetGenericArguments()[0],","path":"src/AutoMapper/XpressionMapper/Extensions/MapperExtensions.cs","position":28,"original_position":89,"commit_id":"da59765c15c9807716500cf5af1b0c7589396abe","original_commit_id":"da59765c15c9807716500cf5af1b0c7589396abe","user":{"login":"lbargaoanu","id":4517428,"avatar_url":"https://avatars2.githubusercontent.com/u/4517428?v=4","gravatar_id":"","url":"https://api.github.com/users/lbargaoanu","html_url":"https://github.com/lbargaoanu","followers_url":"https://api.github.com/users/lbargaoanu/followers","following_url":"https://api.github.com/users/lbargaoanu/following{/other_user}","gists_url":"https://api.github.com/users/lbargaoanu/gists{/gist_id}","starred_url":"https://api.github.com/users/lbargaoanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbargaoanu/subscriptions","organizations_url":"https://api.github.com/users/lbargaoanu/orgs","repos_url":"https://api.github.com/users/lbargaoanu/repos","events_url":"https://api.github.com/users/lbargaoanu/events{/privacy}","received_events_url":"https://api.github.com/users/lbargaoanu/received_events","type":"User","site_admin":false},"body":"There is still some duplication here.","created_at":"2018-05-10T10:12:04Z","updated_at":"2018-05-10T10:12:05Z","html_url":"https://github.com/AutoMapper/AutoMapper/pull/2622#discussion_r187291334","pull_request_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/187291334"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/2622#discussion_r187291334"},"pull_request":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622"}}},"pull_request":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622","id":187024459,"html_url":"https://github.com/AutoMapper/AutoMapper/pull/2622","diff_url":"https://github.com/AutoMapper/AutoMapper/pull/2622.diff","patch_url":"https://github.com/AutoMapper/AutoMapper/pull/2622.patch","issue_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2622","number":2622,"state":"open","locked":false,"title":"Fix for #2543 (plus improved mapping of constants)","user":{"login":"BlaiseD","id":7595209,"avatar_url":"https://avatars3.githubusercontent.com/u/7595209?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaiseD","html_url":"https://github.com/BlaiseD","followers_url":"https://api.github.com/users/BlaiseD/followers","following_url":"https://api.github.com/users/BlaiseD/following{/other_user}","gists_url":"https://api.github.com/users/BlaiseD/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaiseD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaiseD/subscriptions","organizations_url":"https://api.github.com/users/BlaiseD/orgs","repos_url":"https://api.github.com/users/BlaiseD/repos","events_url":"https://api.github.com/users/BlaiseD/events{/privacy}","received_events_url":"https://api.github.com/users/BlaiseD/received_events","type":"User","site_admin":false},"body":"1. Improves mapping of constants in expressions.\r\n2. Maps expressions where the type changes for instance methods.\r\n3. Fixes #2543 (XpressionMapper does not convert the delegate return type).","created_at":"2018-05-09T19:59:54Z","updated_at":"2018-05-10T10:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e0fda9f5d27246d14fd5abba719d8eb71902055","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622/commits","review_comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622/comments","review_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2622/comments","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/da59765c15c9807716500cf5af1b0c7589396abe","head":{"label":"BlaiseD:master","ref":"master","sha":"da59765c15c9807716500cf5af1b0c7589396abe","user":{"login":"BlaiseD","id":7595209,"avatar_url":"https://avatars3.githubusercontent.com/u/7595209?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaiseD","html_url":"https://github.com/BlaiseD","followers_url":"https://api.github.com/users/BlaiseD/followers","following_url":"https://api.github.com/users/BlaiseD/following{/other_user}","gists_url":"https://api.github.com/users/BlaiseD/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaiseD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaiseD/subscriptions","organizations_url":"https://api.github.com/users/BlaiseD/orgs","repos_url":"https://api.github.com/users/BlaiseD/repos","events_url":"https://api.github.com/users/BlaiseD/events{/privacy}","received_events_url":"https://api.github.com/users/BlaiseD/received_events","type":"User","site_admin":false},"repo":{"id":132745885,"name":"AutoMapper","full_name":"BlaiseD/AutoMapper","owner":{"login":"BlaiseD","id":7595209,"avatar_url":"https://avatars3.githubusercontent.com/u/7595209?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaiseD","html_url":"https://github.com/BlaiseD","followers_url":"https://api.github.com/users/BlaiseD/followers","following_url":"https://api.github.com/users/BlaiseD/following{/other_user}","gists_url":"https://api.github.com/users/BlaiseD/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaiseD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaiseD/subscriptions","organizations_url":"https://api.github.com/users/BlaiseD/orgs","repos_url":"https://api.github.com/users/BlaiseD/repos","events_url":"https://api.github.com/users/BlaiseD/events{/privacy}","received_events_url":"https://api.github.com/users/BlaiseD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BlaiseD/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":true,"url":"https://api.github.com/repos/BlaiseD/AutoMapper","forks_url":"https://api.github.com/repos/BlaiseD/AutoMapper/forks","keys_url":"https://api.github.com/repos/BlaiseD/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlaiseD/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlaiseD/AutoMapper/teams","hooks_url":"https://api.github.com/repos/BlaiseD/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/BlaiseD/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/BlaiseD/AutoMapper/events","assignees_url":"https://api.github.com/repos/BlaiseD/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/BlaiseD/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/BlaiseD/AutoMapper/tags","blobs_url":"https://api.github.com/repos/BlaiseD/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlaiseD/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlaiseD/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlaiseD/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlaiseD/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/BlaiseD/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/BlaiseD/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/BlaiseD/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/BlaiseD/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/BlaiseD/AutoMapper/subscription","commits_url":"https://api.github.com/repos/BlaiseD/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlaiseD/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlaiseD/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlaiseD/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlaiseD/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/BlaiseD/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlaiseD/AutoMapper/merges","archive_url":"https://api.github.com/repos/BlaiseD/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlaiseD/AutoMapper/downloads","issues_url":"https://api.github.com/repos/BlaiseD/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/BlaiseD/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/BlaiseD/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/BlaiseD/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlaiseD/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/BlaiseD/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/BlaiseD/AutoMapper/deployments","created_at":"2018-05-09T11:19:23Z","updated_at":"2018-05-09T19:51:43Z","pushed_at":"2018-05-09T19:51:38Z","git_url":"git://github.com/BlaiseD/AutoMapper.git","ssh_url":"git@github.com:BlaiseD/AutoMapper.git","clone_url":"https://github.com/BlaiseD/AutoMapper.git","svn_url":"https://github.com/BlaiseD/AutoMapper","homepage":"http://automapper.org","size":71502,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AutoMapper:master","ref":"master","sha":"c4a091badf28b5851f340998e00f9aa84ad3d322","user":{"login":"AutoMapper","id":890883,"avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"repo":{"id":505380,"name":"AutoMapper","full_name":"AutoMapper/AutoMapper","owner":{"login":"AutoMapper","id":890883,"avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutoMapper/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":false,"url":"https://api.github.com/repos/AutoMapper/AutoMapper","forks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/forks","keys_url":"https://api.github.com/repos/AutoMapper/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoMapper/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoMapper/AutoMapper/teams","hooks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/events","assignees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/AutoMapper/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/tags","blobs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoMapper/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscription","commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/AutoMapper/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoMapper/AutoMapper/merges","archive_url":"https://api.github.com/repos/AutoMapper/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoMapper/AutoMapper/downloads","issues_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoMapper/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoMapper/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/AutoMapper/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/deployments","created_at":"2010-02-06T15:17:58Z","updated_at":"2018-05-10T07:12:42Z","pushed_at":"2018-05-09T19:59:55Z","git_url":"git://github.com/AutoMapper/AutoMapper.git","ssh_url":"git@github.com:AutoMapper/AutoMapper.git","clone_url":"https://github.com/AutoMapper/AutoMapper.git","svn_url":"https://github.com/AutoMapper/AutoMapper","homepage":"http://automapper.org","size":71492,"stargazers_count":5432,"watchers_count":5432,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1287,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1287,"open_issues":12,"watchers":5432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/2622"},"issue":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2622"},"comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2622/comments"},"review_comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622/comments"},"review_comment":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2622/commits"},"statuses":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/da59765c15c9807716500cf5af1b0c7589396abe"}},"author_association":"CONTRIBUTOR"}} | {
"id": 505380,
"name": "AutoMapper/AutoMapper",
"url": "https://api.github.com/repos/AutoMapper/AutoMapper"
} | {
"id": 4517428,
"login": "lbargaoanu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4517428?",
"url": "https://api.github.com/users/lbargaoanu"
} | {
"id": 890883,
"login": "AutoMapper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/890883?",
"url": "https://api.github.com/orgs/AutoMapper"
} | 2018-05-10T10:12:04 | 7654684820 | {"actor":{"display_login":"lbargaoanu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/234398991","pull_request_review_id":176043716,"id":234398991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDM5ODk5MQ==","diff_hunk":"@@ -0,0 +1,46 @@\n+using System.Collections.Generic;\n+using System.Collections.ObjectModel;\n+using System.Linq;\n+using System.Linq.Expressions;\n+using AutoMapper.Configuration;\n+using AutoMapper.Internal;\n+using AutoMapper.Mappers.Internal;\n+\n+namespace AutoMapper.Mappers\n+{\n+ using static Expression;\n+ using static ExpressionFactory;\n+ using static CollectionMapperExpressionFactory;\n+\n+ public class ReadOnlyDictionaryMapper : IObjectMapper\n+ {\n+ public bool IsMatch(TypePair context)\n+ {\n+ if (!(context.SourceType.IsEnumerableType() && context.DestinationType.IsGenericType()))","path":"src/AutoMapper/Mappers/ReadOnlyDictionaryMapper.cs","position":19,"original_position":19,"commit_id":"5a1721abfb40dd83b4e2efc6d2fe058f30040da1","original_commit_id":"5a1721abfb40dd83b4e2efc6d2fe058f30040da1","user":{"login":"jbogard","id":104498,"node_id":"MDQ6VXNlcjEwNDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/104498?v=4","gravatar_id":"","url":"https://api.github.com/users/jbogard","html_url":"https://github.com/jbogard","followers_url":"https://api.github.com/users/jbogard/followers","following_url":"https://api.github.com/users/jbogard/following{/other_user}","gists_url":"https://api.github.com/users/jbogard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbogard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbogard/subscriptions","organizations_url":"https://api.github.com/users/jbogard/orgs","repos_url":"https://api.github.com/users/jbogard/repos","events_url":"https://api.github.com/users/jbogard/events{/privacy}","received_events_url":"https://api.github.com/users/jbogard/received_events","type":"User","site_admin":false},"body":"Added one but it's slightly different than this one, as it checks for just the interface","created_at":"2018-11-17T06:46:57Z","updated_at":"2018-11-17T06:46:57Z","html_url":"https://github.com/AutoMapper/AutoMapper/pull/2873#discussion_r234398991","pull_request_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments/234398991"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/2873#discussion_r234398991"},"pull_request":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873"}},"in_reply_to_id":234273845},"pull_request":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873","id":231525705,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTI1NzA1","html_url":"https://github.com/AutoMapper/AutoMapper/pull/2873","diff_url":"https://github.com/AutoMapper/AutoMapper/pull/2873.diff","patch_url":"https://github.com/AutoMapper/AutoMapper/pull/2873.patch","issue_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2873","number":2873,"state":"open","locked":false,"title":"Read only dictionaries support","user":{"login":"jbogard","id":104498,"node_id":"MDQ6VXNlcjEwNDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/104498?v=4","gravatar_id":"","url":"https://api.github.com/users/jbogard","html_url":"https://github.com/jbogard","followers_url":"https://api.github.com/users/jbogard/followers","following_url":"https://api.github.com/users/jbogard/following{/other_user}","gists_url":"https://api.github.com/users/jbogard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbogard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbogard/subscriptions","organizations_url":"https://api.github.com/users/jbogard/orgs","repos_url":"https://api.github.com/users/jbogard/repos","events_url":"https://api.github.com/users/jbogard/events{/privacy}","received_events_url":"https://api.github.com/users/jbogard/received_events","type":"User","site_admin":false},"body":"Fixes #2794 ","created_at":"2018-11-16T13:11:29Z","updated_at":"2018-11-17T06:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8a3dace4b56baf145da1d610191aba1f4386d55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":92629422,"node_id":"MDU6TGFiZWw5MjYyOTQyMg==","url":"https://api.github.com/repos/AutoMapper/AutoMapper/labels/Feature","name":"Feature","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones/33","html_url":"https://github.com/AutoMapper/AutoMapper/milestone/33","labels_url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones/33/labels","id":3449537,"node_id":"MDk6TWlsZXN0b25lMzQ0OTUzNw==","number":33,"title":"8.0.0","description":"","creator":{"login":"jbogard","id":104498,"node_id":"MDQ6VXNlcjEwNDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/104498?v=4","gravatar_id":"","url":"https://api.github.com/users/jbogard","html_url":"https://github.com/jbogard","followers_url":"https://api.github.com/users/jbogard/followers","following_url":"https://api.github.com/users/jbogard/following{/other_user}","gists_url":"https://api.github.com/users/jbogard/gists{/gist_id}","starred_url":"https://api.github.com/users/jbogard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbogard/subscriptions","organizations_url":"https://api.github.com/users/jbogard/orgs","repos_url":"https://api.github.com/users/jbogard/repos","events_url":"https://api.github.com/users/jbogard/events{/privacy}","received_events_url":"https://api.github.com/users/jbogard/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":41,"state":"open","created_at":"2018-06-25T12:56:03Z","updated_at":"2018-11-16T14:59:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873/commits","review_comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873/comments","review_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2873/comments","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/5a1721abfb40dd83b4e2efc6d2fe058f30040da1","head":{"label":"AutoMapper:read-only-dictionaries","ref":"read-only-dictionaries","sha":"5a1721abfb40dd83b4e2efc6d2fe058f30040da1","user":{"login":"AutoMapper","id":890883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDg4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"repo":{"id":505380,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUzODA=","name":"AutoMapper","full_name":"AutoMapper/AutoMapper","private":false,"owner":{"login":"AutoMapper","id":890883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDg4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AutoMapper/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":false,"url":"https://api.github.com/repos/AutoMapper/AutoMapper","forks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/forks","keys_url":"https://api.github.com/repos/AutoMapper/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoMapper/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoMapper/AutoMapper/teams","hooks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/events","assignees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/AutoMapper/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/tags","blobs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoMapper/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscription","commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/AutoMapper/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoMapper/AutoMapper/merges","archive_url":"https://api.github.com/repos/AutoMapper/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoMapper/AutoMapper/downloads","issues_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoMapper/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoMapper/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/AutoMapper/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/deployments","created_at":"2010-02-06T15:17:58Z","updated_at":"2018-11-16T22:03:23Z","pushed_at":"2018-11-16T14:59:46Z","git_url":"git://github.com/AutoMapper/AutoMapper.git","ssh_url":"git@github.com:AutoMapper/AutoMapper.git","clone_url":"https://github.com/AutoMapper/AutoMapper.git","svn_url":"https://github.com/AutoMapper/AutoMapper","homepage":"http://automapper.org","size":71994,"stargazers_count":5901,"watchers_count":5901,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1358,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1358,"open_issues":7,"watchers":5901,"default_branch":"master"}},"base":{"label":"AutoMapper:master","ref":"master","sha":"7ac7f0351e5b30cac21085477fca063acc2214e8","user":{"login":"AutoMapper","id":890883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDg4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"repo":{"id":505380,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUzODA=","name":"AutoMapper","full_name":"AutoMapper/AutoMapper","private":false,"owner":{"login":"AutoMapper","id":890883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDg4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/890883?v=4","gravatar_id":"","url":"https://api.github.com/users/AutoMapper","html_url":"https://github.com/AutoMapper","followers_url":"https://api.github.com/users/AutoMapper/followers","following_url":"https://api.github.com/users/AutoMapper/following{/other_user}","gists_url":"https://api.github.com/users/AutoMapper/gists{/gist_id}","starred_url":"https://api.github.com/users/AutoMapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutoMapper/subscriptions","organizations_url":"https://api.github.com/users/AutoMapper/orgs","repos_url":"https://api.github.com/users/AutoMapper/repos","events_url":"https://api.github.com/users/AutoMapper/events{/privacy}","received_events_url":"https://api.github.com/users/AutoMapper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AutoMapper/AutoMapper","description":"A convention-based object-object mapper in .NET. ","fork":false,"url":"https://api.github.com/repos/AutoMapper/AutoMapper","forks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/forks","keys_url":"https://api.github.com/repos/AutoMapper/AutoMapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutoMapper/AutoMapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutoMapper/AutoMapper/teams","hooks_url":"https://api.github.com/repos/AutoMapper/AutoMapper/hooks","issue_events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/events{/number}","events_url":"https://api.github.com/repos/AutoMapper/AutoMapper/events","assignees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/assignees{/user}","branches_url":"https://api.github.com/repos/AutoMapper/AutoMapper/branches{/branch}","tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/tags","blobs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/{sha}","languages_url":"https://api.github.com/repos/AutoMapper/AutoMapper/languages","stargazers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/stargazers","contributors_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contributors","subscribers_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscribers","subscription_url":"https://api.github.com/repos/AutoMapper/AutoMapper/subscription","commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutoMapper/AutoMapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutoMapper/AutoMapper/contents/{+path}","compare_url":"https://api.github.com/repos/AutoMapper/AutoMapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutoMapper/AutoMapper/merges","archive_url":"https://api.github.com/repos/AutoMapper/AutoMapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutoMapper/AutoMapper/downloads","issues_url":"https://api.github.com/repos/AutoMapper/AutoMapper/issues{/number}","pulls_url":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls{/number}","milestones_url":"https://api.github.com/repos/AutoMapper/AutoMapper/milestones{/number}","notifications_url":"https://api.github.com/repos/AutoMapper/AutoMapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutoMapper/AutoMapper/labels{/name}","releases_url":"https://api.github.com/repos/AutoMapper/AutoMapper/releases{/id}","deployments_url":"https://api.github.com/repos/AutoMapper/AutoMapper/deployments","created_at":"2010-02-06T15:17:58Z","updated_at":"2018-11-16T22:03:23Z","pushed_at":"2018-11-16T14:59:46Z","git_url":"git://github.com/AutoMapper/AutoMapper.git","ssh_url":"git@github.com:AutoMapper/AutoMapper.git","clone_url":"https://github.com/AutoMapper/AutoMapper.git","svn_url":"https://github.com/AutoMapper/AutoMapper","homepage":"http://automapper.org","size":71994,"stargazers_count":5901,"watchers_count":5901,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1358,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1358,"open_issues":7,"watchers":5901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873"},"html":{"href":"https://github.com/AutoMapper/AutoMapper/pull/2873"},"issue":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2873"},"comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/issues/2873/comments"},"review_comments":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873/comments"},"review_comment":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/pulls/2873/commits"},"statuses":{"href":"https://api.github.com/repos/AutoMapper/AutoMapper/statuses/5a1721abfb40dd83b4e2efc6d2fe058f30040da1"}},"author_association":"MEMBER"}} | {
"id": 505380,
"name": "AutoMapper/AutoMapper",
"url": "https://api.github.com/repos/AutoMapper/AutoMapper"
} | {
"id": 104498,
"login": "jbogard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/104498?",
"url": "https://api.github.com/users/jbogard"
} | {
"id": 890883,
"login": "AutoMapper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/890883?",
"url": "https://api.github.com/orgs/AutoMapper"
} | 2018-11-17T06:46:57 | 8606010864 | {"actor":{"display_login":"jbogard"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zotero/translators/pulls/comments/230063383","pull_request_review_id":170712406,"id":230063383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDA2MzM4Mw==","diff_hunk":"@@ -0,0 +1,303 @@\n+{\n+\t\"translatorID\": \"d2c0d2f4-42c0-41e0-8021-3b87b52b27d2\",\n+\t\"label\": \"Landesbibliographie Baden-Württemberg\",\n+\t\"creator\": \"Philipp Zumstein\",\n+\t\"target\": \"^https?://(www\\\\.)?statistik\\\\.baden-wuerttemberg\\\\.de/LABI\",\n+\t\"minVersion\": \"3.0\",\n+\t\"maxVersion\": \"\",\n+\t\"priority\": 100,\n+\t\"inRepository\": true,\n+\t\"translatorType\": 4,\n+\t\"browserSupport\": \"gcsibv\",\n+\t\"lastUpdated\": \"2018-11-01 11:35:17\"\n+}\n+\n+/*\n+\t***** BEGIN LICENSE BLOCK *****\n+\n+\tCopyright © 2018 Philipp Zumstein\n+\t\n+\tThis file is part of Zotero.\n+\n+\tZotero is free software: you can redistribute it and/or modify\n+\tit under the terms of the GNU Affero General Public License as published by\n+\tthe Free Software Foundation, either version 3 of the License, or\n+\t(at your option) any later version.\n+\n+\tZotero is distributed in the hope that it will be useful,\n+\tbut WITHOUT ANY WARRANTY; without even the implied warranty of\n+\tMERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+\tGNU Affero General Public License for more details.\n+\n+\tYou should have received a copy of the GNU Affero General Public License\n+\talong with Zotero. If not, see <http://www.gnu.org/licenses/>.\n+\n+\t***** END LICENSE BLOCK *****\n+*/\n+\n+\n+// attr()/text() v2\n+function attr(docOrElem,selector,attr,index){var elem=index?docOrElem.querySelectorAll(selector).item(index):docOrElem.querySelector(selector);return elem?elem.getAttribute(attr):null;}function text(docOrElem,selector,index){var elem=index?docOrElem.querySelectorAll(selector).item(index):docOrElem.querySelector(selector);return elem?elem.textContent:null;}\n+\n+\n+function detectWeb(doc, url) {\n+\tif (url.includes('/LABI.asp?')) {\n+\t\tif (getSearchResults(doc, true)) {\n+\t\t\treturn \"multiple\";\n+\t\t} else {\n+\t\t\tvar labels = doc.querySelectorAll('td>b');\n+\t\t\tfor (let label of labels) {\n+\t\t\t\tif (label.textContent == 'ISBN:') {\n+\t\t\t\t\treturn \"book\";\n+\t\t\t\t}\n+\t\t\t\tif (label.textContent.includes('Enthalten')) {\n+\t\t\t\t\treturn \"journalArticle\";\n+\t\t\t\t}\n+\t\t\t}\n+\t\t\treturn \"report\";\n+\t\t}\n+\t}\n+}\n+\n+\n+function getSearchResults(doc, checkOnly) {\n+\tvar items = {};\n+\tvar found = false;\n+\tvar rows = doc.querySelectorAll('td.right + td>a');\n+\tfor (let i=0; i<rows.length; i++) {\n+\t\tlet href = rows[i].href;\n+\t\tlet title = ZU.trimInternal(rows[i].textContent);\n+\t\tif (!href || !title) continue;\n+\t\tif (checkOnly) return true;\n+\t\tfound = true;\n+\t\titems[href] = title;\n+\t}\n+\treturn found ? items : false;\n+}\n+\n+\n+function doWeb(doc, url) {\n+\tif (detectWeb(doc, url) == \"multiple\") {\n+\t\tZotero.selectItems(getSearchResults(doc, false), function (items) {\n+\t\t\tif (!items) {\n+\t\t\t\treturn true;\n+\t\t\t}\n+\t\t\tvar articles = [];\n+\t\t\tfor (var i in items) {\n+\t\t\t\tarticles.push(i);\n+\t\t\t}\n+\t\t\tZU.processDocuments(articles, scrape);\n+\t\t});\n+\t} else {\n+\t\tscrape(doc, url);\n+\t}\n+}\n+\n+\n+function scrape(doc, url) {\n+\tvar type = detectWeb(doc, url);\n+\tvar risURL = attr(doc, 'a.export', 'href');\n+\tZU.doGet(risURL, function(text) {\n+\t\t// Z.debug(text)\n+\t\tvar translator = Zotero.loadTranslator(\"import\");\n+\t\ttranslator.setTranslator(\"32d59d2d-b65a-4da4-b0a3-bdd3cfb979e7\");\n+\t\ttranslator.setString(text);\n+\t\ttranslator.setHandler(\"itemDone\", function(obj, item) {\n+\t\t\titem.itemType = type;\n+\t\t\t// fixes the added author information in the title,\n+\t\t\t// which might be fixed by them in the future\n+\t\t\titem.title = item.title.replace(/\\/[^\\/]*$/, '');\n+\t\t\t\n+\t\t\tif (type == \"book\" && item.pages) {\n+\t\t\t\tvar m = item.pages.match(/(\\d+) Seiten/);\n+\t\t\t\tif (m) {\n+\t\t\t\t\titem.numPages = m[1];\n+\t\t\t\t\tdelete item.pages;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t\titem.attachments.push({\n+\t\t\t\ttitle: \"Titel in der Landesbibliographie Baden-Württemberg\",\n+\t\t\t\turl: url,\n+\t\t\t\tsnapshot: false\n+\t\t\t});\n+\t\t\titem.complete();\n+\t\t});\n+\n+\t\ttranslator.translate();\n+\t});\n+}\n+\n+/** BEGIN TEST CASES **/\n+var testCases = [\n+\t{\n+\t\t\"type\": \"web\",\n+\t\t\"url\": \"http://www.statistik.baden-wuerttemberg.de/LABI/LABI.asp?HC=63amFSWsgYL&K1=10&T1=mannheim&TA=5\",\n+\t\t\"items\": [\n+\t\t\t{\n+\t\t\t\t\"itemType\": \"journalArticle\",\n+\t\t\t\t\"title\": \"Überfordert : Mozart: Don Giovanni : Mannheim, Nationaltheater\",\n+\t\t\t\t\"creators\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"lastName\": \"Schweikert\",\n+\t\t\t\t\t\t\"firstName\": \"Uwe\",\n+\t\t\t\t\t\t\"creatorType\": \"author\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"date\": \"2018\",\n+\t\t\t\t\"issue\": \"9/10\",\n+\t\t\t\t\"libraryCatalog\": \"Landesbibliographie Baden-Württemberg\",\n+\t\t\t\t\"pages\": \"56-57\",\n+\t\t\t\t\"publicationTitle\": \"Opernwelt\",\n+\t\t\t\t\"shortTitle\": \"Überfordert\",\n+\t\t\t\t\"volume\": \"59\",\n+\t\t\t\t\"attachments\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"title\": \"Titel in der Landesbibliographie Baden-Württemberg\",\n+\t\t\t\t\t\t\"snapshot\": false\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"tags\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Mannheim\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Musik\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Nationaltheater Mannheim\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Oper\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Schauspiel, Oper, Operette und Ballett\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"notes\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"note\": \"<p>\\\"Premiere am 14. Juli 2018\\\" (Textende)</p>\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"seeAlso\": []\n+\t\t\t}\n+\t\t]\n+\t},\n+\t{\n+\t\t\"type\": \"web\",\n+\t\t\"url\": \"http://www.statistik.baden-wuerttemberg.de/LABI/LABI.asp?HC=53amwU0Dwj6&K1=10&T1=mannheim&TA=12\",\n+\t\t\"items\": [\n+\t\t\t{\n+\t\t\t\t\"itemType\": \"book\",\n+\t\t\t\t\"title\": \"Hafen Mannheim 2018 : 150 Jahre Mannheimer Akte\",\n+\t\t\t\t\"creators\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"lastName\": \"Mardo\",\n+\t\t\t\t\t\t\"firstName\": \"Thommy\",\n+\t\t\t\t\t\t\"creatorType\": \"author\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"date\": \"2018\",\n+\t\t\t\t\"ISBN\": \"9783864760938\",\n+\t\t\t\t\"libraryCatalog\": \"Landesbibliographie Baden-Württemberg\",\n+\t\t\t\t\"numPages\": \"208\",\n+\t\t\t\t\"place\": \"Mannheim\",\n+\t\t\t\t\"publisher\": \"Verlag Waldkirch\",\n+\t\t\t\t\"shortTitle\": \"Hafen Mannheim 2018\",\n+\t\t\t\t\"attachments\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"title\": \"Titel in der Landesbibliographie Baden-Württemberg\",\n+\t\t\t\t\t\t\"snapshot\": false\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"tags\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Bildband\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Hafen\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Mannheim\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Mannheimer Rheinschiffahrtsakte\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Oberrheingebiet\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Rhein-Neckar-Hafen Mannheim\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Rheinschifffahrt\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Schifffahrt\"\n+\t\t\t\t\t},\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"tag\": \"Wasserstraßen\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"notes\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"note\": \"<p>Text in deutsch, englisch und französisch</p>\"\n+\t\t\t\t\t}\n+\t\t\t\t],\n+\t\t\t\t\"seeAlso\": []\n+\t\t\t}\n+\t\t]\n+\t},\n+\t{\n+\t\t\"type\": \"web\",\n+\t\t\"url\": \"http://www.statistik.baden-wuerttemberg.de/LABI/LABI.asp?HC=53anjtk4Avy&K1=10&T1=mannheim&EF=Z&TA=87\",\n+\t\t\"items\": [\n+\t\t\t{\n+\t\t\t\t\"itemType\": \"report\",\n+\t\t\t\t\"title\": \"Rechenschaftsbericht ... des Rektors\",\n+\t\t\t\t\"creators\": [\n+\t\t\t\t\t{\n+\t\t\t\t\t\t\"lastName\": \"Universität \",","path":"Landesbibliographie Baden-Wurttemberg.js","position":259,"original_position":259,"commit_id":"1beb03dcaab841b8aea9e021f4dec8d1d5508dbf","original_commit_id":"1beb03dcaab841b8aea9e021f4dec8d1d5508dbf","user":{"login":"zuphilip","id":5199995,"node_id":"MDQ6VXNlcjUxOTk5OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5199995?v=4","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"body":"This comes from\r\n```\r\nAU - Universität <Mannheim>\r\n```\r\nwhich is catalogued as a \"Körperschaft\" in the original. Maybe we could move it to a `contributor` but I don't know how to identifies these cases. Thoughts?","created_at":"2018-11-01T14:36:45Z","updated_at":"2018-11-01T14:36:46Z","html_url":"https://github.com/zotero/translators/pull/1774#discussion_r230063383","pull_request_url":"https://api.github.com/repos/zotero/translators/pulls/1774","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments/230063383"},"html":{"href":"https://github.com/zotero/translators/pull/1774#discussion_r230063383"},"pull_request":{"href":"https://api.github.com/repos/zotero/translators/pulls/1774"}},"in_reply_to_id":230025156},"pull_request":{"url":"https://api.github.com/repos/zotero/translators/pulls/1774","id":227591391,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTkxMzkx","html_url":"https://github.com/zotero/translators/pull/1774","diff_url":"https://github.com/zotero/translators/pull/1774.diff","patch_url":"https://github.com/zotero/translators/pull/1774.patch","issue_url":"https://api.github.com/repos/zotero/translators/issues/1774","number":1774,"state":"open","locked":false,"title":"Add translator Landesbibliographie Baden-Wurttemberg.js","user":{"login":"zuphilip","id":5199995,"node_id":"MDQ6VXNlcjUxOTk5OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5199995?v=4","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-01T11:37:57Z","updated_at":"2018-11-01T14:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21661fd24796fe86e071a0fb10803faf3c68710e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zotero/translators/pulls/1774/commits","review_comments_url":"https://api.github.com/repos/zotero/translators/pulls/1774/comments","review_comment_url":"https://api.github.com/repos/zotero/translators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zotero/translators/issues/1774/comments","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/1beb03dcaab841b8aea9e021f4dec8d1d5508dbf","head":{"label":"zuphilip:labi-bw","ref":"labi-bw","sha":"1beb03dcaab841b8aea9e021f4dec8d1d5508dbf","user":{"login":"zuphilip","id":5199995,"node_id":"MDQ6VXNlcjUxOTk5OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5199995?v=4","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"repo":{"id":23522231,"node_id":"MDEwOlJlcG9zaXRvcnkyMzUyMjIzMQ==","name":"translators","full_name":"zuphilip/translators","private":false,"owner":{"login":"zuphilip","id":5199995,"node_id":"MDQ6VXNlcjUxOTk5OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5199995?v=4","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zuphilip/translators","description":"Zotero Translators","fork":true,"url":"https://api.github.com/repos/zuphilip/translators","forks_url":"https://api.github.com/repos/zuphilip/translators/forks","keys_url":"https://api.github.com/repos/zuphilip/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zuphilip/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zuphilip/translators/teams","hooks_url":"https://api.github.com/repos/zuphilip/translators/hooks","issue_events_url":"https://api.github.com/repos/zuphilip/translators/issues/events{/number}","events_url":"https://api.github.com/repos/zuphilip/translators/events","assignees_url":"https://api.github.com/repos/zuphilip/translators/assignees{/user}","branches_url":"https://api.github.com/repos/zuphilip/translators/branches{/branch}","tags_url":"https://api.github.com/repos/zuphilip/translators/tags","blobs_url":"https://api.github.com/repos/zuphilip/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zuphilip/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zuphilip/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/zuphilip/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zuphilip/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/zuphilip/translators/languages","stargazers_url":"https://api.github.com/repos/zuphilip/translators/stargazers","contributors_url":"https://api.github.com/repos/zuphilip/translators/contributors","subscribers_url":"https://api.github.com/repos/zuphilip/translators/subscribers","subscription_url":"https://api.github.com/repos/zuphilip/translators/subscription","commits_url":"https://api.github.com/repos/zuphilip/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/zuphilip/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/zuphilip/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/zuphilip/translators/issues/comments{/number}","contents_url":"https://api.github.com/repos/zuphilip/translators/contents/{+path}","compare_url":"https://api.github.com/repos/zuphilip/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zuphilip/translators/merges","archive_url":"https://api.github.com/repos/zuphilip/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zuphilip/translators/downloads","issues_url":"https://api.github.com/repos/zuphilip/translators/issues{/number}","pulls_url":"https://api.github.com/repos/zuphilip/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/zuphilip/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/zuphilip/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zuphilip/translators/labels{/name}","releases_url":"https://api.github.com/repos/zuphilip/translators/releases{/id}","deployments_url":"https://api.github.com/repos/zuphilip/translators/deployments","created_at":"2014-08-31T20:18:19Z","updated_at":"2018-03-27T05:37:04Z","pushed_at":"2018-11-01T12:21:05Z","git_url":"git://github.com/zuphilip/translators.git","ssh_url":"git@github.com:zuphilip/translators.git","clone_url":"https://github.com/zuphilip/translators.git","svn_url":"https://github.com/zuphilip/translators","homepage":"http://www.zotero.org/support/dev/translators","size":13457,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"zotero:master","ref":"master","sha":"fbb118b09b461e79ad01b77d5f86f627c7d28559","user":{"login":"zotero","id":891917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/891917?v=4","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":1991863,"node_id":"MDEwOlJlcG9zaXRvcnkxOTkxODYz","name":"translators","full_name":"zotero/translators","private":false,"owner":{"login":"zotero","id":891917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/891917?v=4","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zotero/translators","description":"Zotero Translators","fork":false,"url":"https://api.github.com/repos/zotero/translators","forks_url":"https://api.github.com/repos/zotero/translators/forks","keys_url":"https://api.github.com/repos/zotero/translators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/translators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/translators/teams","hooks_url":"https://api.github.com/repos/zotero/translators/hooks","issue_events_url":"https://api.github.com/repos/zotero/translators/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/translators/events","assignees_url":"https://api.github.com/repos/zotero/translators/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/translators/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/translators/tags","blobs_url":"https://api.github.com/repos/zotero/translators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/translators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/translators/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/translators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/translators/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/translators/languages","stargazers_url":"https://api.github.com/repos/zotero/translators/stargazers","contributors_url":"https://api.github.com/repos/zotero/translators/contributors","subscribers_url":"https://api.github.com/repos/zotero/translators/subscribers","subscription_url":"https://api.github.com/repos/zotero/translators/subscription","commits_url":"https://api.github.com/repos/zotero/translators/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/translators/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/translators/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/translators/issues/comments{/number}","contents_url":"https://api.github.com/repos/zotero/translators/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/translators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/translators/merges","archive_url":"https://api.github.com/repos/zotero/translators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/translators/downloads","issues_url":"https://api.github.com/repos/zotero/translators/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/translators/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/translators/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/translators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/translators/labels{/name}","releases_url":"https://api.github.com/repos/zotero/translators/releases{/id}","deployments_url":"https://api.github.com/repos/zotero/translators/deployments","created_at":"2011-07-03T17:40:38Z","updated_at":"2018-10-24T04:53:09Z","pushed_at":"2018-11-01T12:21:05Z","git_url":"git://github.com/zotero/translators.git","ssh_url":"git@github.com:zotero/translators.git","clone_url":"https://github.com/zotero/translators.git","svn_url":"https://github.com/zotero/translators","homepage":"http://www.zotero.org/support/dev/translators","size":13107,"stargazers_count":319,"watchers_count":319,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":273,"license":null,"forks":277,"open_issues":273,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/translators/pulls/1774"},"html":{"href":"https://github.com/zotero/translators/pull/1774"},"issue":{"href":"https://api.github.com/repos/zotero/translators/issues/1774"},"comments":{"href":"https://api.github.com/repos/zotero/translators/issues/1774/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/translators/pulls/1774/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/translators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zotero/translators/pulls/1774/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/translators/statuses/1beb03dcaab841b8aea9e021f4dec8d1d5508dbf"}},"author_association":"COLLABORATOR"}} | {
"id": 1991863,
"name": "zotero/translators",
"url": "https://api.github.com/repos/zotero/translators"
} | {
"id": 5199995,
"login": "zuphilip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5199995?",
"url": "https://api.github.com/users/zuphilip"
} | {
"id": 891917,
"login": "zotero",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/891917?",
"url": "https://api.github.com/orgs/zotero"
} | 2018-11-01T14:36:45 | 8519395432 | {"actor":{"display_login":"zuphilip"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mercadopago/px-android/pulls/comments/183094141","pull_request_review_id":114025014,"id":183094141,"diff_hunk":"@@ -0,0 +1,50 @@\n+package com.mercadopago;\n+\n+import android.support.test.filters.LargeTest;\n+import android.support.test.rule.ActivityTestRule;\n+import android.support.test.runner.AndroidJUnit4;\n+\n+import com.mercadopago.core.MercadoPagoCheckout;\n+import com.mercadopago.preferences.CheckoutPreference;\n+import com.mercadopago.testcheckout.CheckoutResource;\n+import com.mercadopago.testcheckout.flows.CheckoutTestFlow;\n+import com.mercadopago.testcheckout.input.Card;\n+import com.mercadopago.testcheckout.input.FakeCard;\n+import com.mercadopago.testcheckout.pages.CongratsPage;\n+import com.mercadopago.testlib.HttpResource;\n+\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+import static junit.framework.Assert.assertNotNull;\n+\n+@RunWith(AndroidJUnit4.class)\n+@LargeTest\n+public class Ete6Test {\n+ @Rule\n+ public HttpResource httpResource = new CheckoutResource();\n+\n+ @Rule\n+ public ActivityTestRule<CheckoutExampleActivity> activityRule =\n+ new ActivityTestRule<>(CheckoutExampleActivity.class);\n+\n+ private CheckoutTestFlow checkoutTestFlow;\n+\n+ @Before\n+ public void setUp() {\n+ MercadoPagoCheckout.Builder builder = new MercadoPagoCheckout.Builder();\n+ builder.setCheckoutPreference(new CheckoutPreference(\"243966003-bb8f7422-39c1-4337-81dd-60a88eb787df\"));\n+ builder.setPublicKey(\"APP_USR-0d933ff3-b803-4999-a211-8b3c7d5c7c03\");\n+ builder.setActivity(activityRule.getActivity());\n+ checkoutTestFlow = CheckoutTestFlow.createFlowWithCheckout(builder);\n+ }\n+\n+ @Test\n+ public void withOnlyOnePaymentMethodCardAvailablePaymentFlowWorksOk() {\n+ Card card = new FakeCard(FakeCard.CardState.APRO, \"5323793735506106\");\n+ CongratsPage congratsPage = checkoutTestFlow.runCreditCardOnlyPaymentAvailable(card);","path":"example/src/androidTest/java/com/mercadopago/Ete6Test.java","position":47,"original_position":47,"commit_id":"4f1a829be174f67a902fae81ea2fd909dae1e292","original_commit_id":"4f1a829be174f67a902fae81ea2fd909dae1e292","user":{"login":"valeserber","id":5674142,"avatar_url":"https://avatars3.githubusercontent.com/u/5674142?v=4","gravatar_id":"","url":"https://api.github.com/users/valeserber","html_url":"https://github.com/valeserber","followers_url":"https://api.github.com/users/valeserber/followers","following_url":"https://api.github.com/users/valeserber/following{/other_user}","gists_url":"https://api.github.com/users/valeserber/gists{/gist_id}","starred_url":"https://api.github.com/users/valeserber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valeserber/subscriptions","organizations_url":"https://api.github.com/users/valeserber/orgs","repos_url":"https://api.github.com/users/valeserber/repos","events_url":"https://api.github.com/users/valeserber/events{/privacy}","received_events_url":"https://api.github.com/users/valeserber/received_events","type":"User","site_admin":false},"body":"El método `runCreditCardOnlyPaymentAvailable` no debería empezar con un `PaymentMethodPage` igual que todos los casos? Donde ahí instantáneamente se pasa a un `CreditCardPage` porque es el único tipo de medio disponible, sino siento que no se está testeando lo que debería testearse. De alguna manera hay que ver que no se muestre grupos, pero sin forzarlo a que vaya directo a la pantalla de tarjeta de crédito. ","created_at":"2018-04-20T15:49:49Z","updated_at":"2018-04-20T15:51:05Z","html_url":"https://github.com/mercadopago/px-android/pull/957#discussion_r183094141","pull_request_url":"https://api.github.com/repos/mercadopago/px-android/pulls/957","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/comments/183094141"},"html":{"href":"https://github.com/mercadopago/px-android/pull/957#discussion_r183094141"},"pull_request":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/957"}}},"pull_request":{"url":"https://api.github.com/repos/mercadopago/px-android/pulls/957","id":182562093,"html_url":"https://github.com/mercadopago/px-android/pull/957","diff_url":"https://github.com/mercadopago/px-android/pull/957.diff","patch_url":"https://github.com/mercadopago/px-android/pull/957.patch","issue_url":"https://api.github.com/repos/mercadopago/px-android/issues/957","number":957,"state":"open","locked":false,"title":"[enhancement] etes 1, 3, 5 y 6 como page objects","user":{"login":"zehemz","id":7827612,"avatar_url":"https://avatars0.githubusercontent.com/u/7827612?v=4","gravatar_id":"","url":"https://api.github.com/users/zehemz","html_url":"https://github.com/zehemz","followers_url":"https://api.github.com/users/zehemz/followers","following_url":"https://api.github.com/users/zehemz/following{/other_user}","gists_url":"https://api.github.com/users/zehemz/gists{/gist_id}","starred_url":"https://api.github.com/users/zehemz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zehemz/subscriptions","organizations_url":"https://api.github.com/users/zehemz/orgs","repos_url":"https://api.github.com/users/zehemz/repos","events_url":"https://api.github.com/users/zehemz/events{/privacy}","received_events_url":"https://api.github.com/users/zehemz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-18T18:17:31Z","updated_at":"2018-04-20T15:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24af87e6b6dc236687949a70da814a5bfe742d72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mercadopago/px-android/pulls/957/commits","review_comments_url":"https://api.github.com/repos/mercadopago/px-android/pulls/957/comments","review_comment_url":"https://api.github.com/repos/mercadopago/px-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mercadopago/px-android/issues/957/comments","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/4f1a829be174f67a902fae81ea2fd909dae1e292","head":{"label":"mercadopago:enhancement/etes","ref":"enhancement/etes","sha":"4f1a829be174f67a902fae81ea2fd909dae1e292","user":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529486,"name":"px-android","full_name":"mercadopago/px-android","owner":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-android","description":"MercadoPago SDK Android","fork":false,"url":"https://api.github.com/repos/mercadopago/px-android","forks_url":"https://api.github.com/repos/mercadopago/px-android/forks","keys_url":"https://api.github.com/repos/mercadopago/px-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-android/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-android/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-android/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-android/events","assignees_url":"https://api.github.com/repos/mercadopago/px-android/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-android/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-android/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-android/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-android/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-android/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-android/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-android/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-android/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-android/merges","archive_url":"https://api.github.com/repos/mercadopago/px-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-android/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-android/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-android/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-android/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-android/deployments","created_at":"2016-01-12T21:18:39Z","updated_at":"2018-04-02T18:21:38Z","pushed_at":"2018-04-20T15:24:36Z","git_url":"git://github.com/mercadopago/px-android.git","ssh_url":"git@github.com:mercadopago/px-android.git","clone_url":"https://github.com/mercadopago/px-android.git","svn_url":"https://github.com/mercadopago/px-android","homepage":"http://mercadopago.github.io/px-android","size":77656,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":25,"watchers":23,"default_branch":"master"}},"base":{"label":"mercadopago:develop","ref":"develop","sha":"2021d1e38860a9fed11822063085ad4d7bd3b33a","user":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529486,"name":"px-android","full_name":"mercadopago/px-android","owner":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-android","description":"MercadoPago SDK Android","fork":false,"url":"https://api.github.com/repos/mercadopago/px-android","forks_url":"https://api.github.com/repos/mercadopago/px-android/forks","keys_url":"https://api.github.com/repos/mercadopago/px-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-android/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-android/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-android/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-android/events","assignees_url":"https://api.github.com/repos/mercadopago/px-android/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-android/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-android/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-android/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-android/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-android/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-android/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-android/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-android/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-android/merges","archive_url":"https://api.github.com/repos/mercadopago/px-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-android/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-android/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-android/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-android/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-android/deployments","created_at":"2016-01-12T21:18:39Z","updated_at":"2018-04-02T18:21:38Z","pushed_at":"2018-04-20T15:24:36Z","git_url":"git://github.com/mercadopago/px-android.git","ssh_url":"git@github.com:mercadopago/px-android.git","clone_url":"https://github.com/mercadopago/px-android.git","svn_url":"https://github.com/mercadopago/px-android","homepage":"http://mercadopago.github.io/px-android","size":77656,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":25,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/957"},"html":{"href":"https://github.com/mercadopago/px-android/pull/957"},"issue":{"href":"https://api.github.com/repos/mercadopago/px-android/issues/957"},"comments":{"href":"https://api.github.com/repos/mercadopago/px-android/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/mercadopago/px-android/statuses/4f1a829be174f67a902fae81ea2fd909dae1e292"}},"author_association":"NONE"}} | {
"id": 49529486,
"name": "mercadopago/px-android",
"url": "https://api.github.com/repos/mercadopago/px-android"
} | {
"id": 5674142,
"login": "valeserber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5674142?",
"url": "https://api.github.com/users/valeserber"
} | {
"id": 900583,
"login": "mercadopago",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/900583?",
"url": "https://api.github.com/orgs/mercadopago"
} | 2018-04-20T15:49:49 | 7562655594 | {"actor":{"display_login":"valeserber"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/189633430","pull_request_review_id":121850857,"id":189633430,"diff_hunk":"@@ -205,6 +216,7 @@ ESPresponse [exceptions_inline] GetESDLBindingResponse\n string ConfigXML;\n [min_ver(\"1.1\")] ESPStruct ESDLBindingContents ESDLBinding;\n ESPstruct BaseESDLStatus status;\n+ [min_ver(\"1.4\")] ESPStruct PublishHistory History;","path":"esp/scm/ws_esdlconfig.ecm","position":43,"original_position":35,"commit_id":"1b3b8bcaa630e2761f284e75e0a2d2f637c992fb","original_commit_id":"a39ba033a25e7fb6d0524cb080ac5485548c9f9d","user":{"login":"mayx","id":907992,"avatar_url":"https://avatars3.githubusercontent.com/u/907992?v=4","gravatar_id":"","url":"https://api.github.com/users/mayx","html_url":"https://github.com/mayx","followers_url":"https://api.github.com/users/mayx/followers","following_url":"https://api.github.com/users/mayx/following{/other_user}","gists_url":"https://api.github.com/users/mayx/gists{/gist_id}","starred_url":"https://api.github.com/users/mayx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayx/subscriptions","organizations_url":"https://api.github.com/users/mayx/orgs","repos_url":"https://api.github.com/users/mayx/repos","events_url":"https://api.github.com/users/mayx/events{/privacy}","received_events_url":"https://api.github.com/users/mayx/received_events","type":"User","site_admin":false},"body":"@rpastrana having another layer is fine in my opinion.","created_at":"2018-05-21T15:58:50Z","updated_at":"2018-05-21T15:58:50Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162#discussion_r189633430","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/189633430"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162#discussion_r189633430"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162"}},"in_reply_to_id":188593396},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162","id":188004944,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11162","number":11162,"state":"open","locked":false,"title":"HPCC-19679 Report ESDL Binding and Definition History","user":{"login":"rpastrana","id":915949,"avatar_url":"https://avatars2.githubusercontent.com/u/915949?v=4","gravatar_id":"","url":"https://api.github.com/users/rpastrana","html_url":"https://github.com/rpastrana","followers_url":"https://api.github.com/users/rpastrana/followers","following_url":"https://api.github.com/users/rpastrana/following{/other_user}","gists_url":"https://api.github.com/users/rpastrana/gists{/gist_id}","starred_url":"https://api.github.com/users/rpastrana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpastrana/subscriptions","organizations_url":"https://api.github.com/users/rpastrana/orgs","repos_url":"https://api.github.com/users/rpastrana/repos","events_url":"https://api.github.com/users/rpastrana/events{/privacy}","received_events_url":"https://api.github.com/users/rpastrana/received_events","type":"User","site_admin":false},"body":"- Declares new PublishHistory ECM structure\r\n- Provide history onListDefs and onlistBindings\r\n\r\nSigned-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexis.com>\r\n\r\n<!-- Thank you for submitting a pull request to the HPCC project\r\n\r\n PLEASE READ the following before proceeding.\r\n\r\n This project only accepts pull requests related to open JIRA issues.\r\n If suggesting a new feature or change, please discuss it in a JIRA issue first.\r\n If fixing a bug, there should be an issue describing it with steps to reproduce.\r\n The title line of the pull request (and of each commit within it) should refer to the\r\n associated issue using the format:\r\n\r\n HPCC-nnnnn Short description of issue\r\n\r\n This will allow the Jira ticket to be automatically updated to refer to this pull request,\r\n and will ensure that the automatically-generated changelog is properly formatted.\r\n Where a pull request contains a single commit the pull request title will be set automatically,\r\n assuming that the commit has followed the proper guidelines.\r\n\r\n Please go over all the following points, and put an `x` in all the boxes that apply. You may find\r\n it easier to press the 'Create' button first then click on the checkboxes to edit the comment.\r\n-->\r\n\r\n## Type of change:\r\n- [x] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [ ] This change is a new feature (non-breaking change which adds functionality).\r\n- [ ] This change improves the code (refactor or other change that does not change the functionality)\r\n- [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n - [ ] My code does not create any new warnings from compiler, build system, or lint.\r\n- [x] The commit message is properly formatted and free of typos.\r\n - [ ] The commit message title makes sense in a changelog, by itself.\r\n - [ ] The commit is signed.\r\n- [ ] My change requires a change to the documentation.\r\n - [ ] I have updated the documentation accordingly, or...\r\n - [ ] I have created a JIRA ticket to update the documentation.\r\n - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [x] I have read the CONTRIBUTORS document.\r\n- [x] The change has been fully tested:\r\n - [ ] I have added tests to cover my changes.\r\n - [ ] All new and existing tests passed.\r\n - [ ] I have checked that this change does not introduce memory leaks.\r\n - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [x] I have given due consideration to all of the following potential concerns:\r\n - [ ] Scalability\r\n - [ ] Performance\r\n - [ ] Security\r\n - [ ] Thread-safety\r\n - [ ] Premature optimization\r\n - [ ] Existing deployed queries will not be broken\r\n - [ ] This change fixes the problem, not just the symptom\r\n - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [x] There are no similar instances of the same problem that should be addressed\r\n - [ ] I have addressed them here\r\n - [ ] I have raised JIRA issues to address them separately\r\n- [ ] This is a user interface / front-end modification\r\n - [ ] I have tested my changes in multiple modern browsers\r\n - [ ] The component(s) render as expected\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\n\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n","created_at":"2018-05-15T03:30:17Z","updated_at":"2018-05-21T15:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9488cc10c4d460b209954e0dcf85cd514f5e5d11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11162/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/1b3b8bcaa630e2761f284e75e0a2d2f637c992fb","head":{"label":"rpastrana:HPCC-HPCC-19679-ReportHistory","ref":"HPCC-HPCC-19679-ReportHistory","sha":"1b3b8bcaa630e2761f284e75e0a2d2f637c992fb","user":{"login":"rpastrana","id":915949,"avatar_url":"https://avatars2.githubusercontent.com/u/915949?v=4","gravatar_id":"","url":"https://api.github.com/users/rpastrana","html_url":"https://github.com/rpastrana","followers_url":"https://api.github.com/users/rpastrana/followers","following_url":"https://api.github.com/users/rpastrana/following{/other_user}","gists_url":"https://api.github.com/users/rpastrana/gists{/gist_id}","starred_url":"https://api.github.com/users/rpastrana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpastrana/subscriptions","organizations_url":"https://api.github.com/users/rpastrana/orgs","repos_url":"https://api.github.com/users/rpastrana/repos","events_url":"https://api.github.com/users/rpastrana/events{/privacy}","received_events_url":"https://api.github.com/users/rpastrana/received_events","type":"User","site_admin":false},"repo":{"id":2055368,"name":"HPCC-Platform","full_name":"rpastrana/HPCC-Platform","owner":{"login":"rpastrana","id":915949,"avatar_url":"https://avatars2.githubusercontent.com/u/915949?v=4","gravatar_id":"","url":"https://api.github.com/users/rpastrana","html_url":"https://github.com/rpastrana","followers_url":"https://api.github.com/users/rpastrana/followers","following_url":"https://api.github.com/users/rpastrana/following{/other_user}","gists_url":"https://api.github.com/users/rpastrana/gists{/gist_id}","starred_url":"https://api.github.com/users/rpastrana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpastrana/subscriptions","organizations_url":"https://api.github.com/users/rpastrana/orgs","repos_url":"https://api.github.com/users/rpastrana/repos","events_url":"https://api.github.com/users/rpastrana/events{/privacy}","received_events_url":"https://api.github.com/users/rpastrana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpastrana/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/rpastrana/HPCC-Platform","forks_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/rpastrana/HPCC-Platform/deployments","created_at":"2011-07-15T20:12:56Z","updated_at":"2017-04-25T21:19:39Z","pushed_at":"2018-05-18T13:00:35Z","git_url":"git://github.com/rpastrana/HPCC-Platform.git","ssh_url":"git@github.com:rpastrana/HPCC-Platform.git","clone_url":"https://github.com/rpastrana/HPCC-Platform.git","svn_url":"https://github.com/rpastrana/HPCC-Platform","homepage":"www.hpccsystems.com","size":189126,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"f0664fcdca7786809e11c4ccb49f77242c9651a7","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2018-05-21T15:02:08Z","pushed_at":"2018-05-21T15:58:23Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":188711,"stargazers_count":339,"watchers_count":339,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":437,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":196,"open_issues":437,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/11162"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11162"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11162/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11162/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/1b3b8bcaa630e2761f284e75e0a2d2f637c992fb"}},"author_association":"MEMBER"}} | {
"id": 2030681,
"name": "hpcc-systems/HPCC-Platform",
"url": "https://api.github.com/repos/hpcc-systems/HPCC-Platform"
} | {
"id": 907992,
"login": "mayx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/907992?",
"url": "https://api.github.com/users/mayx"
} | {
"id": 900867,
"login": "hpcc-systems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/900867?",
"url": "https://api.github.com/orgs/hpcc-systems"
} | 2018-05-21T15:58:50 | 7705598717 | {"actor":{"display_login":"mayx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/munin-monitoring/munin/pulls/comments/219468373","pull_request_review_id":157652957,"id":219468373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ2ODM3Mw==","diff_hunk":"@@ -22,13 +22,39 @@ here. However, all new code should be made to comply.\n \n =head1 GETTING STARTED\n \n-In the B<dev_scripts> directory you will find scripts that are meant to be\n-useful for developing. Most of them are tools for creating and using\n-Munin in a sandbox.\n+\n+=head2 GITHUB\n+\n+The main development of Munin is happening on L<https://github.com>. With a\n+free account you can report feature requests and issues\n+(L<https://github.com/munin-monitoring/munin/issues/new/choose>) and create\n+pull requests (L<https://github.com/munin-monitoring/munin/pulls>).\n+\n+There are two interesting branches:\n+\n+=over\n+\n+=item I<stable-2.0>\n+\n+As the name suggests this is the stable branch for versions 2.0.x.\n+Please base your plugin and bug-fix patches on this branch.","path":"HACKING.pod","position":37,"original_position":22,"commit_id":"41e196c8805138b2902071bec121b34597d323db","original_commit_id":"433ceba1ff370ab62222bb7929da1680925a2c18","user":{"login":"sumpfralle","id":1474141,"node_id":"MDQ6VXNlcjE0NzQxNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1474141?v=4","gravatar_id":"","url":"https://api.github.com/users/sumpfralle","html_url":"https://github.com/sumpfralle","followers_url":"https://api.github.com/users/sumpfralle/followers","following_url":"https://api.github.com/users/sumpfralle/following{/other_user}","gists_url":"https://api.github.com/users/sumpfralle/gists{/gist_id}","starred_url":"https://api.github.com/users/sumpfralle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumpfralle/subscriptions","organizations_url":"https://api.github.com/users/sumpfralle/orgs","repos_url":"https://api.github.com/users/sumpfralle/repos","events_url":"https://api.github.com/users/sumpfralle/events{/privacy}","received_events_url":"https://api.github.com/users/sumpfralle/received_events","type":"User","site_admin":false},"body":"Update of our discussion: during the [IRC meeting on the 5th of September](http://meetbot.debian.net/munin/2018/munin.2018-09-05-18.29.log.html) we agreed on only applying fixes (both for core and for plugins) to `stable-2.0` from now own. These changes will be merged into `master` from time to time. All other changes go directly to `master`. ","created_at":"2018-09-21T11:39:56Z","updated_at":"2018-09-21T11:39:56Z","html_url":"https://github.com/munin-monitoring/munin/pull/1064#discussion_r219468373","pull_request_url":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/comments/219468373"},"html":{"href":"https://github.com/munin-monitoring/munin/pull/1064#discussion_r219468373"},"pull_request":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064"}},"in_reply_to_id":213342587},"pull_request":{"url":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064","id":211244258,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjQ0MjU4","html_url":"https://github.com/munin-monitoring/munin/pull/1064","diff_url":"https://github.com/munin-monitoring/munin/pull/1064.diff","patch_url":"https://github.com/munin-monitoring/munin/pull/1064.patch","issue_url":"https://api.github.com/repos/munin-monitoring/munin/issues/1064","number":1064,"state":"open","locked":false,"title":"update HACKING.pod","user":{"login":"cgzones","id":6131885,"node_id":"MDQ6VXNlcjYxMzE4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6131885?v=4","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"body":"This is just a first draft. Please discuss.\r\nRelated: #1014, #1051, #1060, #1061","created_at":"2018-08-27T22:01:42Z","updated_at":"2018-09-21T11:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"693a895b764ec276de9f8b5d41332b3dc4370c7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/munin-monitoring/munin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/munin-monitoring/munin/issues/1064/comments","statuses_url":"https://api.github.com/repos/munin-monitoring/munin/statuses/41e196c8805138b2902071bec121b34597d323db","head":{"label":"cgzones:hacking","ref":"hacking","sha":"41e196c8805138b2902071bec121b34597d323db","user":{"login":"cgzones","id":6131885,"node_id":"MDQ6VXNlcjYxMzE4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6131885?v=4","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"repo":{"id":93246647,"node_id":"MDEwOlJlcG9zaXRvcnk5MzI0NjY0Nw==","name":"munin","full_name":"cgzones/munin","private":false,"owner":{"login":"cgzones","id":6131885,"node_id":"MDQ6VXNlcjYxMzE4ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6131885?v=4","gravatar_id":"","url":"https://api.github.com/users/cgzones","html_url":"https://github.com/cgzones","followers_url":"https://api.github.com/users/cgzones/followers","following_url":"https://api.github.com/users/cgzones/following{/other_user}","gists_url":"https://api.github.com/users/cgzones/gists{/gist_id}","starred_url":"https://api.github.com/users/cgzones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgzones/subscriptions","organizations_url":"https://api.github.com/users/cgzones/orgs","repos_url":"https://api.github.com/users/cgzones/repos","events_url":"https://api.github.com/users/cgzones/events{/privacy}","received_events_url":"https://api.github.com/users/cgzones/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cgzones/munin","description":"Main repository for munin master / node / plugins","fork":true,"url":"https://api.github.com/repos/cgzones/munin","forks_url":"https://api.github.com/repos/cgzones/munin/forks","keys_url":"https://api.github.com/repos/cgzones/munin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgzones/munin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgzones/munin/teams","hooks_url":"https://api.github.com/repos/cgzones/munin/hooks","issue_events_url":"https://api.github.com/repos/cgzones/munin/issues/events{/number}","events_url":"https://api.github.com/repos/cgzones/munin/events","assignees_url":"https://api.github.com/repos/cgzones/munin/assignees{/user}","branches_url":"https://api.github.com/repos/cgzones/munin/branches{/branch}","tags_url":"https://api.github.com/repos/cgzones/munin/tags","blobs_url":"https://api.github.com/repos/cgzones/munin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgzones/munin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgzones/munin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgzones/munin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgzones/munin/statuses/{sha}","languages_url":"https://api.github.com/repos/cgzones/munin/languages","stargazers_url":"https://api.github.com/repos/cgzones/munin/stargazers","contributors_url":"https://api.github.com/repos/cgzones/munin/contributors","subscribers_url":"https://api.github.com/repos/cgzones/munin/subscribers","subscription_url":"https://api.github.com/repos/cgzones/munin/subscription","commits_url":"https://api.github.com/repos/cgzones/munin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgzones/munin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgzones/munin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgzones/munin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgzones/munin/contents/{+path}","compare_url":"https://api.github.com/repos/cgzones/munin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgzones/munin/merges","archive_url":"https://api.github.com/repos/cgzones/munin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgzones/munin/downloads","issues_url":"https://api.github.com/repos/cgzones/munin/issues{/number}","pulls_url":"https://api.github.com/repos/cgzones/munin/pulls{/number}","milestones_url":"https://api.github.com/repos/cgzones/munin/milestones{/number}","notifications_url":"https://api.github.com/repos/cgzones/munin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgzones/munin/labels{/name}","releases_url":"https://api.github.com/repos/cgzones/munin/releases{/id}","deployments_url":"https://api.github.com/repos/cgzones/munin/deployments","created_at":"2017-06-03T12:27:28Z","updated_at":"2018-08-29T11:03:57Z","pushed_at":"2018-09-04T14:04:13Z","git_url":"git://github.com/cgzones/munin.git","ssh_url":"git@github.com:cgzones/munin.git","clone_url":"https://github.com/cgzones/munin.git","svn_url":"https://github.com/cgzones/munin","homepage":"http://munin-monitoring.org","size":16383,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"munin-monitoring:master","ref":"master","sha":"a2dec6c8afffbfa576c21c8d47036ba6ec22f5b5","user":{"login":"munin-monitoring","id":909917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/909917?v=4","gravatar_id":"","url":"https://api.github.com/users/munin-monitoring","html_url":"https://github.com/munin-monitoring","followers_url":"https://api.github.com/users/munin-monitoring/followers","following_url":"https://api.github.com/users/munin-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/munin-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/munin-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munin-monitoring/subscriptions","organizations_url":"https://api.github.com/users/munin-monitoring/orgs","repos_url":"https://api.github.com/users/munin-monitoring/repos","events_url":"https://api.github.com/users/munin-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/munin-monitoring/received_events","type":"Organization","site_admin":false},"repo":{"id":4511595,"node_id":"MDEwOlJlcG9zaXRvcnk0NTExNTk1","name":"munin","full_name":"munin-monitoring/munin","private":false,"owner":{"login":"munin-monitoring","id":909917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/909917?v=4","gravatar_id":"","url":"https://api.github.com/users/munin-monitoring","html_url":"https://github.com/munin-monitoring","followers_url":"https://api.github.com/users/munin-monitoring/followers","following_url":"https://api.github.com/users/munin-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/munin-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/munin-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munin-monitoring/subscriptions","organizations_url":"https://api.github.com/users/munin-monitoring/orgs","repos_url":"https://api.github.com/users/munin-monitoring/repos","events_url":"https://api.github.com/users/munin-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/munin-monitoring/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/munin-monitoring/munin","description":"Main repository for munin master / node / plugins","fork":false,"url":"https://api.github.com/repos/munin-monitoring/munin","forks_url":"https://api.github.com/repos/munin-monitoring/munin/forks","keys_url":"https://api.github.com/repos/munin-monitoring/munin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munin-monitoring/munin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munin-monitoring/munin/teams","hooks_url":"https://api.github.com/repos/munin-monitoring/munin/hooks","issue_events_url":"https://api.github.com/repos/munin-monitoring/munin/issues/events{/number}","events_url":"https://api.github.com/repos/munin-monitoring/munin/events","assignees_url":"https://api.github.com/repos/munin-monitoring/munin/assignees{/user}","branches_url":"https://api.github.com/repos/munin-monitoring/munin/branches{/branch}","tags_url":"https://api.github.com/repos/munin-monitoring/munin/tags","blobs_url":"https://api.github.com/repos/munin-monitoring/munin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munin-monitoring/munin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munin-monitoring/munin/git/refs{/sha}","trees_url":"https://api.github.com/repos/munin-monitoring/munin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munin-monitoring/munin/statuses/{sha}","languages_url":"https://api.github.com/repos/munin-monitoring/munin/languages","stargazers_url":"https://api.github.com/repos/munin-monitoring/munin/stargazers","contributors_url":"https://api.github.com/repos/munin-monitoring/munin/contributors","subscribers_url":"https://api.github.com/repos/munin-monitoring/munin/subscribers","subscription_url":"https://api.github.com/repos/munin-monitoring/munin/subscription","commits_url":"https://api.github.com/repos/munin-monitoring/munin/commits{/sha}","git_commits_url":"https://api.github.com/repos/munin-monitoring/munin/git/commits{/sha}","comments_url":"https://api.github.com/repos/munin-monitoring/munin/comments{/number}","issue_comment_url":"https://api.github.com/repos/munin-monitoring/munin/issues/comments{/number}","contents_url":"https://api.github.com/repos/munin-monitoring/munin/contents/{+path}","compare_url":"https://api.github.com/repos/munin-monitoring/munin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munin-monitoring/munin/merges","archive_url":"https://api.github.com/repos/munin-monitoring/munin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munin-monitoring/munin/downloads","issues_url":"https://api.github.com/repos/munin-monitoring/munin/issues{/number}","pulls_url":"https://api.github.com/repos/munin-monitoring/munin/pulls{/number}","milestones_url":"https://api.github.com/repos/munin-monitoring/munin/milestones{/number}","notifications_url":"https://api.github.com/repos/munin-monitoring/munin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munin-monitoring/munin/labels{/name}","releases_url":"https://api.github.com/repos/munin-monitoring/munin/releases{/id}","deployments_url":"https://api.github.com/repos/munin-monitoring/munin/deployments","created_at":"2012-05-31T18:51:44Z","updated_at":"2018-09-21T07:05:54Z","pushed_at":"2018-09-21T11:32:24Z","git_url":"git://github.com/munin-monitoring/munin.git","ssh_url":"git@github.com:munin-monitoring/munin.git","clone_url":"https://github.com/munin-monitoring/munin.git","svn_url":"https://github.com/munin-monitoring/munin","homepage":"http://munin-monitoring.org","size":16777,"stargazers_count":1217,"watchers_count":1217,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":355,"open_issues":139,"watchers":1217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064"},"html":{"href":"https://github.com/munin-monitoring/munin/pull/1064"},"issue":{"href":"https://api.github.com/repos/munin-monitoring/munin/issues/1064"},"comments":{"href":"https://api.github.com/repos/munin-monitoring/munin/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/munin-monitoring/munin/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/munin-monitoring/munin/statuses/41e196c8805138b2902071bec121b34597d323db"}},"author_association":"CONTRIBUTOR"}} | {
"id": 4511595,
"name": "munin-monitoring/munin",
"url": "https://api.github.com/repos/munin-monitoring/munin"
} | {
"id": 1474141,
"login": "sumpfralle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1474141?",
"url": "https://api.github.com/users/sumpfralle"
} | {
"id": 909917,
"login": "munin-monitoring",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/909917?",
"url": "https://api.github.com/orgs/munin-monitoring"
} | 2018-09-21T11:39:56 | 8301496742 | {"actor":{"display_login":"sumpfralle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LIS/LISAv2/pulls/comments/217108409","pull_request_review_id":154412667,"id":217108409,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzEwODQwOQ==","diff_hunk":"@@ -0,0 +1,122 @@\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the Apache License.\n+\n+\n+<#\n+.Synopsis\n+ Mount a floppy vfd file in the VMs floppy drive.\n+\n+.Description\n+ Mount a floppy in the VMs floppy drive\n+ The .vfd file that will be mounted in the floppy drive\n+ is named <vmName>.vfd. If the virtual floppy does not\n+ exist, it will be created.\n+\n+#>\n+\n+param([String] $TestParams)\n+\n+function Main {\n+ param (\n+ $VMName,\n+ $HvServer,\n+ $Ipv4,\n+ $VMPort,\n+ $VMUserName,\n+ $VMPassword,\n+ $RootDir,\n+ $TestParams\n+ )\n+\n+ $vfdPath = \"$null\"\n+ $remoteScript = \"LIS-Mount-FloppyDisk.sh\"\n+ #############################################################\n+ #\n+ # Main script body\n+ #\n+ #############################################################\n+ # Change the working directory to where we need to be\n+ if (-not (Test-Path $RootDir)) {\n+ LogErr \"Error: The directory `\"${RootDir}`\" does not exist!\"\n+ return \"FAIL\"\n+ }\n+ Set-Location $RootDir\n+ # Collect Hyper-v settings info\n+ $hostInfo = Get-VMHost -ComputerName $HvServer\n+ if (-not $hostInfo) {\n+ LogErr \"Unable to collect Hyper-V settings for ${HvServer}\"\n+ return \"FAIL\"\n+ }\n+\n+ # Check for floppy support. If it's not present, test will be skipped\n+\n+ $sts = RunLinuxCmd -username \"root\" -password $VMPassword -ip $Ipv4 -port $VMPort -command \"cat /boot/config-`$(uname -r) | grep -e CONFIG_BLK_DEV_FD=y -e CONFIG_BLK_DEV_FD=m\"","path":"Testscripts/Windows/LIS-Mount-FloppyDisk.ps1","position":53,"original_position":53,"commit_id":"6031f453719011cbf768eea244ef9f1ff0c9a532","original_commit_id":"6031f453719011cbf768eea244ef9f1ff0c9a532","user":{"login":"juhlee-microsoft","id":23069399,"node_id":"MDQ6VXNlcjIzMDY5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/23069399?v=4","gravatar_id":"","url":"https://api.github.com/users/juhlee-microsoft","html_url":"https://github.com/juhlee-microsoft","followers_url":"https://api.github.com/users/juhlee-microsoft/followers","following_url":"https://api.github.com/users/juhlee-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/juhlee-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/juhlee-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhlee-microsoft/subscriptions","organizations_url":"https://api.github.com/users/juhlee-microsoft/orgs","repos_url":"https://api.github.com/users/juhlee-microsoft/repos","events_url":"https://api.github.com/users/juhlee-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/juhlee-microsoft/received_events","type":"User","site_admin":false},"body":"Use 'root' directly? ","created_at":"2018-09-12T16:47:14Z","updated_at":"2018-09-12T16:48:08Z","html_url":"https://github.com/LIS/LISAv2/pull/199#discussion_r217108409","pull_request_url":"https://api.github.com/repos/LIS/LISAv2/pulls/199","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/comments/217108409"},"html":{"href":"https://github.com/LIS/LISAv2/pull/199#discussion_r217108409"},"pull_request":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/LIS/LISAv2/pulls/199","id":214641071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjQxMDcx","html_url":"https://github.com/LIS/LISAv2/pull/199","diff_url":"https://github.com/LIS/LISAv2/pull/199.diff","patch_url":"https://github.com/LIS/LISAv2/pull/199.patch","issue_url":"https://api.github.com/repos/LIS/LISAv2/issues/199","number":199,"state":"open","locked":false,"title":"HyperV: LIS core tests backport","user":{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false},"body":"**Test results:** \r\nVHD under test **Centos_7.5_x64.vhd**\r\n ARM Image under test : : : \r\n Total Executed TestCases 4 ( 4 Pass, 0 Fail, 0 Abort)\r\n Total Execution Time(dd:hh:mm) 0:0:7\r\n XML file: TestConfiguration\r\n \r\n LIS-Check-HypervDaemons-Files-Status Execution Time: 2.86 minutes\r\n \tLIS-Check-HypervDaemons-Files-Status : PASS \r\n LIS-Mount-FloppyDisk Execution Time: 0.67 minutes\r\n \tLIS-Mount-FloppyDisk : PASS \r\n LIS-Mount-CD Execution Time: 2.45 minutes\r\n \tLIS-Mount-CD : PASS \r\n LIS-Mount-CD-HotAdd Execution Time: 1.37 minutes\r\n \tLIS-Mount-CD-HotAdd : PASS \r\n**These tests are available only on RHEL/CENTOS with LIS built-in**\r\n\r\n VHD under test **ubuntu_18.04.vhd**\r\n ARM Image under test : : : \r\n Total Executed TestCases 4 ( 3 Pass, 1 Fail, 0 Abort)\r\n Total Execution Time(dd:hh:mm) 0:0:11\r\n XML file: TestConfiguration\r\n \r\n LIS-Check-HypervDaemons-Files-Status Execution Time: 3.99 minutes\r\n \tLIS-Check-HypervDaemons-Files-Status : FAIL \r\n LIS-Mount-FloppyDisk Execution Time: 1.37 minutes\r\n \tLIS-Mount-FloppyDisk : PASS \r\n LIS-Mount-CD Execution Time: 2.26 minutes\r\n \tLIS-Mount-CD : PASS \r\n LIS-Mount-CD-HotAdd Execution Time: 3.39 minutes\r\n \tLIS-Mount-CD-HotAdd : PASS ","created_at":"2018-09-11T13:53:58Z","updated_at":"2018-09-12T16:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccb0c23b13dfde0441f42e97f15bc1430bbf1362","assignee":{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false},"assignees":[{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ader1990","id":1412442,"node_id":"MDQ6VXNlcjE0MTI0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1412442?v=4","gravatar_id":"","url":"https://api.github.com/users/ader1990","html_url":"https://github.com/ader1990","followers_url":"https://api.github.com/users/ader1990/followers","following_url":"https://api.github.com/users/ader1990/following{/other_user}","gists_url":"https://api.github.com/users/ader1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ader1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ader1990/subscriptions","organizations_url":"https://api.github.com/users/ader1990/orgs","repos_url":"https://api.github.com/users/ader1990/repos","events_url":"https://api.github.com/users/ader1990/events{/privacy}","received_events_url":"https://api.github.com/users/ader1990/received_events","type":"User","site_admin":false},{"login":"lizzha","id":7566196,"node_id":"MDQ6VXNlcjc1NjYxOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7566196?v=4","gravatar_id":"","url":"https://api.github.com/users/lizzha","html_url":"https://github.com/lizzha","followers_url":"https://api.github.com/users/lizzha/followers","following_url":"https://api.github.com/users/lizzha/following{/other_user}","gists_url":"https://api.github.com/users/lizzha/gists{/gist_id}","starred_url":"https://api.github.com/users/lizzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizzha/subscriptions","organizations_url":"https://api.github.com/users/lizzha/orgs","repos_url":"https://api.github.com/users/lizzha/repos","events_url":"https://api.github.com/users/lizzha/events{/privacy}","received_events_url":"https://api.github.com/users/lizzha/received_events","type":"User","site_admin":false},{"login":"iamshital","id":7985635,"node_id":"MDQ6VXNlcjc5ODU2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/7985635?v=4","gravatar_id":"","url":"https://api.github.com/users/iamshital","html_url":"https://github.com/iamshital","followers_url":"https://api.github.com/users/iamshital/followers","following_url":"https://api.github.com/users/iamshital/following{/other_user}","gists_url":"https://api.github.com/users/iamshital/gists{/gist_id}","starred_url":"https://api.github.com/users/iamshital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamshital/subscriptions","organizations_url":"https://api.github.com/users/iamshital/orgs","repos_url":"https://api.github.com/users/iamshital/repos","events_url":"https://api.github.com/users/iamshital/events{/privacy}","received_events_url":"https://api.github.com/users/iamshital/received_events","type":"User","site_admin":false},{"login":"mbivolan","id":30174925,"node_id":"MDQ6VXNlcjMwMTc0OTI1","avatar_url":"https://avatars1.githubusercontent.com/u/30174925?v=4","gravatar_id":"","url":"https://api.github.com/users/mbivolan","html_url":"https://github.com/mbivolan","followers_url":"https://api.github.com/users/mbivolan/followers","following_url":"https://api.github.com/users/mbivolan/following{/other_user}","gists_url":"https://api.github.com/users/mbivolan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbivolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbivolan/subscriptions","organizations_url":"https://api.github.com/users/mbivolan/orgs","repos_url":"https://api.github.com/users/mbivolan/repos","events_url":"https://api.github.com/users/mbivolan/events{/privacy}","received_events_url":"https://api.github.com/users/mbivolan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937845978,"node_id":"MDU6TGFiZWw5Mzc4NDU5Nzg=","url":"https://api.github.com/repos/LIS/LISAv2/labels/New%20Testcase","name":"New Testcase","color":"00d6dd","default":false}],"milestone":{"url":"https://api.github.com/repos/LIS/LISAv2/milestones/6","html_url":"https://github.com/LIS/LISAv2/milestone/6","labels_url":"https://api.github.com/repos/LIS/LISAv2/milestones/6/labels","id":3451076,"node_id":"MDk6TWlsZXN0b25lMzQ1MTA3Ng==","number":6,"title":"September - 2018","description":"","creator":{"login":"juhlee-microsoft","id":23069399,"node_id":"MDQ6VXNlcjIzMDY5Mzk5","avatar_url":"https://avatars3.githubusercontent.com/u/23069399?v=4","gravatar_id":"","url":"https://api.github.com/users/juhlee-microsoft","html_url":"https://github.com/juhlee-microsoft","followers_url":"https://api.github.com/users/juhlee-microsoft/followers","following_url":"https://api.github.com/users/juhlee-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/juhlee-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/juhlee-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhlee-microsoft/subscriptions","organizations_url":"https://api.github.com/users/juhlee-microsoft/orgs","repos_url":"https://api.github.com/users/juhlee-microsoft/repos","events_url":"https://api.github.com/users/juhlee-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/juhlee-microsoft/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":11,"state":"open","created_at":"2018-06-25T20:54:30Z","updated_at":"2018-09-12T15:59:43Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/LIS/LISAv2/pulls/199/commits","review_comments_url":"https://api.github.com/repos/LIS/LISAv2/pulls/199/comments","review_comment_url":"https://api.github.com/repos/LIS/LISAv2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LIS/LISAv2/issues/199/comments","statuses_url":"https://api.github.com/repos/LIS/LISAv2/statuses/6031f453719011cbf768eea244ef9f1ff0c9a532","head":{"label":"asofron:core-tests","ref":"core-tests","sha":"6031f453719011cbf768eea244ef9f1ff0c9a532","user":{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false},"repo":{"id":144140822,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQxNDA4MjI=","name":"LISAv2","full_name":"asofron/LISAv2","owner":{"login":"asofron","id":40065256,"node_id":"MDQ6VXNlcjQwMDY1MjU2","avatar_url":"https://avatars3.githubusercontent.com/u/40065256?v=4","gravatar_id":"","url":"https://api.github.com/users/asofron","html_url":"https://github.com/asofron","followers_url":"https://api.github.com/users/asofron/followers","following_url":"https://api.github.com/users/asofron/following{/other_user}","gists_url":"https://api.github.com/users/asofron/gists{/gist_id}","starred_url":"https://api.github.com/users/asofron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asofron/subscriptions","organizations_url":"https://api.github.com/users/asofron/orgs","repos_url":"https://api.github.com/users/asofron/repos","events_url":"https://api.github.com/users/asofron/events{/privacy}","received_events_url":"https://api.github.com/users/asofron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asofron/LISAv2","description":null,"fork":true,"url":"https://api.github.com/repos/asofron/LISAv2","forks_url":"https://api.github.com/repos/asofron/LISAv2/forks","keys_url":"https://api.github.com/repos/asofron/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asofron/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asofron/LISAv2/teams","hooks_url":"https://api.github.com/repos/asofron/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/asofron/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/asofron/LISAv2/events","assignees_url":"https://api.github.com/repos/asofron/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/asofron/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/asofron/LISAv2/tags","blobs_url":"https://api.github.com/repos/asofron/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asofron/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asofron/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/asofron/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asofron/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/asofron/LISAv2/languages","stargazers_url":"https://api.github.com/repos/asofron/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/asofron/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/asofron/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/asofron/LISAv2/subscription","commits_url":"https://api.github.com/repos/asofron/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/asofron/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/asofron/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/asofron/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/asofron/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/asofron/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asofron/LISAv2/merges","archive_url":"https://api.github.com/repos/asofron/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asofron/LISAv2/downloads","issues_url":"https://api.github.com/repos/asofron/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/asofron/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/asofron/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/asofron/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asofron/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/asofron/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/asofron/LISAv2/deployments","created_at":"2018-08-09T11:02:14Z","updated_at":"2018-09-06T16:40:45Z","pushed_at":"2018-09-11T14:04:40Z","git_url":"git://github.com/asofron/LISAv2.git","ssh_url":"git@github.com:asofron/LISAv2.git","clone_url":"https://github.com/asofron/LISAv2.git","svn_url":"https://github.com/asofron/LISAv2","homepage":null,"size":5870,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LIS:master","ref":"master","sha":"473995aa34bcbfe245b61db96a90eaf9ab1846f6","user":{"login":"LIS","id":930970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMDk3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/930970?v=4","gravatar_id":"","url":"https://api.github.com/users/LIS","html_url":"https://github.com/LIS","followers_url":"https://api.github.com/users/LIS/followers","following_url":"https://api.github.com/users/LIS/following{/other_user}","gists_url":"https://api.github.com/users/LIS/gists{/gist_id}","starred_url":"https://api.github.com/users/LIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LIS/subscriptions","organizations_url":"https://api.github.com/users/LIS/orgs","repos_url":"https://api.github.com/users/LIS/repos","events_url":"https://api.github.com/users/LIS/events{/privacy}","received_events_url":"https://api.github.com/users/LIS/received_events","type":"Organization","site_admin":false},"repo":{"id":133582416,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1ODI0MTY=","name":"LISAv2","full_name":"LIS/LISAv2","owner":{"login":"LIS","id":930970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMDk3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/930970?v=4","gravatar_id":"","url":"https://api.github.com/users/LIS","html_url":"https://github.com/LIS","followers_url":"https://api.github.com/users/LIS/followers","following_url":"https://api.github.com/users/LIS/following{/other_user}","gists_url":"https://api.github.com/users/LIS/gists{/gist_id}","starred_url":"https://api.github.com/users/LIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LIS/subscriptions","organizations_url":"https://api.github.com/users/LIS/orgs","repos_url":"https://api.github.com/users/LIS/repos","events_url":"https://api.github.com/users/LIS/events{/privacy}","received_events_url":"https://api.github.com/users/LIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LIS/LISAv2","description":null,"fork":false,"url":"https://api.github.com/repos/LIS/LISAv2","forks_url":"https://api.github.com/repos/LIS/LISAv2/forks","keys_url":"https://api.github.com/repos/LIS/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LIS/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LIS/LISAv2/teams","hooks_url":"https://api.github.com/repos/LIS/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/LIS/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/LIS/LISAv2/events","assignees_url":"https://api.github.com/repos/LIS/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/LIS/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/LIS/LISAv2/tags","blobs_url":"https://api.github.com/repos/LIS/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LIS/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LIS/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/LIS/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LIS/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/LIS/LISAv2/languages","stargazers_url":"https://api.github.com/repos/LIS/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/LIS/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/LIS/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/LIS/LISAv2/subscription","commits_url":"https://api.github.com/repos/LIS/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/LIS/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/LIS/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/LIS/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/LIS/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/LIS/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LIS/LISAv2/merges","archive_url":"https://api.github.com/repos/LIS/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LIS/LISAv2/downloads","issues_url":"https://api.github.com/repos/LIS/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/LIS/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/LIS/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/LIS/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LIS/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/LIS/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/LIS/LISAv2/deployments","created_at":"2018-05-15T23:04:25Z","updated_at":"2018-09-12T15:59:47Z","pushed_at":"2018-09-12T15:59:43Z","git_url":"git://github.com/LIS/LISAv2.git","ssh_url":"git@github.com:LIS/LISAv2.git","clone_url":"https://github.com/LIS/LISAv2.git","svn_url":"https://github.com/LIS/LISAv2","homepage":null,"size":5850,"stargazers_count":6,"watchers_count":6,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":48,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/199"},"html":{"href":"https://github.com/LIS/LISAv2/pull/199"},"issue":{"href":"https://api.github.com/repos/LIS/LISAv2/issues/199"},"comments":{"href":"https://api.github.com/repos/LIS/LISAv2/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LIS/LISAv2/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/LIS/LISAv2/statuses/6031f453719011cbf768eea244ef9f1ff0c9a532"}},"author_association":"COLLABORATOR"}} | {
"id": 133582416,
"name": "LIS/LISAv2",
"url": "https://api.github.com/repos/LIS/LISAv2"
} | {
"id": 23069399,
"login": "juhlee-microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23069399?",
"url": "https://api.github.com/users/juhlee-microsoft"
} | {
"id": 930970,
"login": "LIS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/930970?",
"url": "https://api.github.com/orgs/LIS"
} | 2018-09-12T16:47:14 | 8254619051 | {"actor":{"display_login":"juhlee-microsoft"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NYPL/staff-picks/pulls/comments/182298618","pull_request_review_id":113065741,"id":182298618,"diff_hunk":"@@ -54,14 +99,35 @@ function selectClientMonthData(req, res) {\n console.error(`Status Code: ${error.statusCode}, Error Message: ${error.code}`);\n \n res.json({\n- statusCode: error.statusCode,\n+ statusCode: error.statusCode || 500,\n errorMessage: error.code,\n });\n });\n }\n \n+/**\n+ * selectClientMonthDataPost(req, res, next)\n+ * Handles the requests from the form submit button (when no JS).\n+ * It redirects to the route to execute the function for server side requesting.\n+ */\n+function selectClientMonthDataPost(req, res) {\n+ const season = (req.body.season) ? `${req.body.season}-01` : '';","path":"src/server/routes/monthData.js","position":116,"original_position":116,"commit_id":"2526cb6a9abf1a028fec273d4d954d0ff6a9676a","original_commit_id":"457e4c1ab7e057b69d9c55134a4a16f27f20d609","user":{"login":"EdwinGuzman","id":1280564,"avatar_url":"https://avatars0.githubusercontent.com/u/1280564?v=4","gravatar_id":"","url":"https://api.github.com/users/EdwinGuzman","html_url":"https://github.com/EdwinGuzman","followers_url":"https://api.github.com/users/EdwinGuzman/followers","following_url":"https://api.github.com/users/EdwinGuzman/following{/other_user}","gists_url":"https://api.github.com/users/EdwinGuzman/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwinGuzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwinGuzman/subscriptions","organizations_url":"https://api.github.com/users/EdwinGuzman/orgs","repos_url":"https://api.github.com/users/EdwinGuzman/repos","events_url":"https://api.github.com/users/EdwinGuzman/events{/privacy}","received_events_url":"https://api.github.com/users/EdwinGuzman/received_events","type":"User","site_admin":false},"body":"I'm not sure if @gkallenberg finished working on the API yet but the previous API endpoints had `[year]-[month]-01` as the convention. If we move away from that convention, then yes it is redundant and we don't need it. But also remember that users will have URLs that are in the form of `[year]-[month]-01`.","created_at":"2018-04-18T03:16:10Z","updated_at":"2018-04-18T03:16:10Z","html_url":"https://github.com/NYPL/staff-picks/pull/162#discussion_r182298618","pull_request_url":"https://api.github.com/repos/NYPL/staff-picks/pulls/162","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/comments/182298618"},"html":{"href":"https://github.com/NYPL/staff-picks/pull/162#discussion_r182298618"},"pull_request":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/162"}},"in_reply_to_id":182174365},"pull_request":{"url":"https://api.github.com/repos/NYPL/staff-picks/pulls/162","id":182022591,"html_url":"https://github.com/NYPL/staff-picks/pull/162","diff_url":"https://github.com/NYPL/staff-picks/pull/162.diff","patch_url":"https://github.com/NYPL/staff-picks/pull/162.patch","issue_url":"https://api.github.com/repos/NYPL/staff-picks/issues/162","number":162,"state":"open","locked":false,"title":"Kp/www 76 get and update url for server side request api request","user":{"login":"ktp242","id":3506922,"avatar_url":"https://avatars1.githubusercontent.com/u/3506922?v=4","gravatar_id":"","url":"https://api.github.com/users/ktp242","html_url":"https://github.com/ktp242","followers_url":"https://api.github.com/users/ktp242/followers","following_url":"https://api.github.com/users/ktp242/following{/other_user}","gists_url":"https://api.github.com/users/ktp242/gists{/gist_id}","starred_url":"https://api.github.com/users/ktp242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktp242/subscriptions","organizations_url":"https://api.github.com/users/ktp242/orgs","repos_url":"https://api.github.com/users/ktp242/repos","events_url":"https://api.github.com/users/ktp242/events{/privacy}","received_events_url":"https://api.github.com/users/ktp242/received_events","type":"User","site_admin":false},"body":"This PR makes server side requests to `/book-lists` endpoints, so now the application can handling direct URL inputs and no JS form submissions.\r\n\r\nIt also now be able to push history for client side requests. ","created_at":"2018-04-17T00:32:44Z","updated_at":"2018-04-18T03:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2864f66b008373903ee6433e95e87e83aa9942f0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gkallenberg","id":1726809,"avatar_url":"https://avatars1.githubusercontent.com/u/1726809?v=4","gravatar_id":"","url":"https://api.github.com/users/gkallenberg","html_url":"https://github.com/gkallenberg","followers_url":"https://api.github.com/users/gkallenberg/followers","following_url":"https://api.github.com/users/gkallenberg/following{/other_user}","gists_url":"https://api.github.com/users/gkallenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/gkallenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkallenberg/subscriptions","organizations_url":"https://api.github.com/users/gkallenberg/orgs","repos_url":"https://api.github.com/users/gkallenberg/repos","events_url":"https://api.github.com/users/gkallenberg/events{/privacy}","received_events_url":"https://api.github.com/users/gkallenberg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL/staff-picks/pulls/162/commits","review_comments_url":"https://api.github.com/repos/NYPL/staff-picks/pulls/162/comments","review_comment_url":"https://api.github.com/repos/NYPL/staff-picks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL/staff-picks/issues/162/comments","statuses_url":"https://api.github.com/repos/NYPL/staff-picks/statuses/2526cb6a9abf1a028fec273d4d954d0ff6a9676a","head":{"label":"NYPL:kp/www-76-get-and-update-url-for-server-side-request-api-request","ref":"kp/www-76-get-and-update-url-for-server-side-request-api-request","sha":"2526cb6a9abf1a028fec273d4d954d0ff6a9676a","user":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"repo":{"id":106718966,"name":"staff-picks","full_name":"NYPL/staff-picks","owner":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL/staff-picks","description":null,"fork":false,"url":"https://api.github.com/repos/NYPL/staff-picks","forks_url":"https://api.github.com/repos/NYPL/staff-picks/forks","keys_url":"https://api.github.com/repos/NYPL/staff-picks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL/staff-picks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL/staff-picks/teams","hooks_url":"https://api.github.com/repos/NYPL/staff-picks/hooks","issue_events_url":"https://api.github.com/repos/NYPL/staff-picks/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL/staff-picks/events","assignees_url":"https://api.github.com/repos/NYPL/staff-picks/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL/staff-picks/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL/staff-picks/tags","blobs_url":"https://api.github.com/repos/NYPL/staff-picks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL/staff-picks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL/staff-picks/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL/staff-picks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL/staff-picks/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL/staff-picks/languages","stargazers_url":"https://api.github.com/repos/NYPL/staff-picks/stargazers","contributors_url":"https://api.github.com/repos/NYPL/staff-picks/contributors","subscribers_url":"https://api.github.com/repos/NYPL/staff-picks/subscribers","subscription_url":"https://api.github.com/repos/NYPL/staff-picks/subscription","commits_url":"https://api.github.com/repos/NYPL/staff-picks/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL/staff-picks/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL/staff-picks/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL/staff-picks/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL/staff-picks/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL/staff-picks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL/staff-picks/merges","archive_url":"https://api.github.com/repos/NYPL/staff-picks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL/staff-picks/downloads","issues_url":"https://api.github.com/repos/NYPL/staff-picks/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL/staff-picks/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL/staff-picks/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL/staff-picks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL/staff-picks/labels{/name}","releases_url":"https://api.github.com/repos/NYPL/staff-picks/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL/staff-picks/deployments","created_at":"2017-10-12T16:37:11Z","updated_at":"2018-04-06T17:46:28Z","pushed_at":"2018-04-18T00:39:56Z","git_url":"git://github.com/NYPL/staff-picks.git","ssh_url":"git@github.com:NYPL/staff-picks.git","clone_url":"https://github.com/NYPL/staff-picks.git","svn_url":"https://github.com/NYPL/staff-picks","homepage":null,"size":4121,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"NYPL:development","ref":"development","sha":"c4a39eb42e460dbb49511d245a072696355fba31","user":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"repo":{"id":106718966,"name":"staff-picks","full_name":"NYPL/staff-picks","owner":{"login":"NYPL","id":944604,"avatar_url":"https://avatars1.githubusercontent.com/u/944604?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL","html_url":"https://github.com/NYPL","followers_url":"https://api.github.com/users/NYPL/followers","following_url":"https://api.github.com/users/NYPL/following{/other_user}","gists_url":"https://api.github.com/users/NYPL/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL/subscriptions","organizations_url":"https://api.github.com/users/NYPL/orgs","repos_url":"https://api.github.com/users/NYPL/repos","events_url":"https://api.github.com/users/NYPL/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL/staff-picks","description":null,"fork":false,"url":"https://api.github.com/repos/NYPL/staff-picks","forks_url":"https://api.github.com/repos/NYPL/staff-picks/forks","keys_url":"https://api.github.com/repos/NYPL/staff-picks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL/staff-picks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL/staff-picks/teams","hooks_url":"https://api.github.com/repos/NYPL/staff-picks/hooks","issue_events_url":"https://api.github.com/repos/NYPL/staff-picks/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL/staff-picks/events","assignees_url":"https://api.github.com/repos/NYPL/staff-picks/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL/staff-picks/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL/staff-picks/tags","blobs_url":"https://api.github.com/repos/NYPL/staff-picks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL/staff-picks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL/staff-picks/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL/staff-picks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL/staff-picks/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL/staff-picks/languages","stargazers_url":"https://api.github.com/repos/NYPL/staff-picks/stargazers","contributors_url":"https://api.github.com/repos/NYPL/staff-picks/contributors","subscribers_url":"https://api.github.com/repos/NYPL/staff-picks/subscribers","subscription_url":"https://api.github.com/repos/NYPL/staff-picks/subscription","commits_url":"https://api.github.com/repos/NYPL/staff-picks/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL/staff-picks/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL/staff-picks/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL/staff-picks/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL/staff-picks/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL/staff-picks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL/staff-picks/merges","archive_url":"https://api.github.com/repos/NYPL/staff-picks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL/staff-picks/downloads","issues_url":"https://api.github.com/repos/NYPL/staff-picks/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL/staff-picks/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL/staff-picks/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL/staff-picks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL/staff-picks/labels{/name}","releases_url":"https://api.github.com/repos/NYPL/staff-picks/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL/staff-picks/deployments","created_at":"2017-10-12T16:37:11Z","updated_at":"2018-04-06T17:46:28Z","pushed_at":"2018-04-18T00:39:56Z","git_url":"git://github.com/NYPL/staff-picks.git","ssh_url":"git@github.com:NYPL/staff-picks.git","clone_url":"https://github.com/NYPL/staff-picks.git","svn_url":"https://github.com/NYPL/staff-picks","homepage":null,"size":4121,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/162"},"html":{"href":"https://github.com/NYPL/staff-picks/pull/162"},"issue":{"href":"https://api.github.com/repos/NYPL/staff-picks/issues/162"},"comments":{"href":"https://api.github.com/repos/NYPL/staff-picks/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL/staff-picks/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL/staff-picks/statuses/2526cb6a9abf1a028fec273d4d954d0ff6a9676a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 106718966,
"name": "NYPL/staff-picks",
"url": "https://api.github.com/repos/NYPL/staff-picks"
} | {
"id": 1280564,
"login": "EdwinGuzman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1280564?",
"url": "https://api.github.com/users/EdwinGuzman"
} | {
"id": 944604,
"login": "NYPL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/944604?",
"url": "https://api.github.com/orgs/NYPL"
} | 2018-04-18T03:16:10 | 7546499043 | {"actor":{"display_login":"EdwinGuzman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/203460458","pull_request_review_id":138354279,"id":203460458,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ2MDQ1OA==","diff_hunk":"@@ -30,21 +31,20 @@ public SettingsCredentialProvider(Configuration.IPackageSourceProvider packageSo\n \n public ICredentials GetCredentials(Uri uri, IWebProxy proxy, CoreV2.NuGet.CredentialType credentialType, bool retrying)\n {\n- NetworkCredential credentials;\n // If we are retrying, the stored credentials must be invalid.\n- if (!retrying && (credentialType == CoreV2.NuGet.CredentialType.RequestCredentials) && TryGetCredentials(uri, out credentials))\n+ if (!retrying && (credentialType == CoreV2.NuGet.CredentialType.RequestCredentials) && TryGetCredentials(uri, out var credentials, out var username))","path":"src/NuGet.Clients/NuGet.CommandLine/SettingsCredentialProvider.cs","position":19,"original_position":19,"commit_id":"f1bfa71e58840f2172a874f352779e00bf80aeb4","original_commit_id":"f1bfa71e58840f2172a874f352779e00bf80aeb4","user":{"login":"nkolev92","id":2878341,"node_id":"MDQ6VXNlcjI4NzgzNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2878341?v=4","gravatar_id":"","url":"https://api.github.com/users/nkolev92","html_url":"https://github.com/nkolev92","followers_url":"https://api.github.com/users/nkolev92/followers","following_url":"https://api.github.com/users/nkolev92/following{/other_user}","gists_url":"https://api.github.com/users/nkolev92/gists{/gist_id}","starred_url":"https://api.github.com/users/nkolev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkolev92/subscriptions","organizations_url":"https://api.github.com/users/nkolev92/orgs","repos_url":"https://api.github.com/users/nkolev92/repos","events_url":"https://api.github.com/users/nkolev92/events{/privacy}","received_events_url":"https://api.github.com/users/nkolev92/received_events","type":"User","site_admin":false},"body":"ah, missed the fact that you're changing it to ICredentials. ","created_at":"2018-07-18T17:15:00Z","updated_at":"2018-07-18T17:15:01Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/2297#discussion_r203460458","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/203460458"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/2297#discussion_r203460458"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297"}},"in_reply_to_id":203147337},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297","id":194719091,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzE5MDkx","html_url":"https://github.com/NuGet/NuGet.Client/pull/2297","diff_url":"https://github.com/NuGet/NuGet.Client/pull/2297.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/2297.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2297","number":2297,"state":"open","locked":false,"title":"Add config option to filter authn types for credentials","user":{"login":"jmyersmsft","id":11822817,"node_id":"MDQ6VXNlcjExODIyODE3","avatar_url":"https://avatars2.githubusercontent.com/u/11822817?v=4","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"body":"## Bug\r\nWorks around NuGet/Home#5651 and NuGet/Home#5286\r\n\r\nCurrently, it is very difficult to interact with servers that support Negotiate authentication if default credentials are not the right credentials. With dotnet on Linux, it is currently impossible. On Windows, Negotiate itself can work, but if the logged-in Windows user isn't the right user, results can be counterintuitive, and if you actually do need to present a credential specifically via the Basic mechanism (because, for instance, the identity is a special identity defined by the server rather than a real Windows domain user), you're out of luck unless you can write a credential provider (and that option isn't even available with .net core nuget in current released versions)\r\n\r\nWith .net core on Linux, .net never falls back to Basic if it has a credential for Negotiate, even though it also doesn't try to actually perform Negotiate auth, whether or not an explicit credential is given. I think this is a bug in the .net framework\r\n\r\n## Fix\r\nDetails: \r\nThis change extends the mechanism used to filter auth types for credential providers to work with configured credentials as well. The user will specify NUGET_AUTHENTICATION_TYPES=basic. This will cause NuGet to respond \"don't have any\" when asked for credentials for Negotiate, NTLM, etc, forcing .net to fall back to Basic.\r\n\r\n## Testing/Validation\r\nTests Added: Yes, a couple of unit tests.\r\nValidation done: Manual test as follows\r\n* NuGet server: On-Premises TFS Package Management, with a feed upstreamed to nuget.org\r\n* Same trivial project used for both environments: `dotnet new console; dotnet add package Newtonsoft.Json`\r\n* Credentials (an arbitrary username and a TFS Personal Access Token) in clear text in nuget.config in project directory\r\n* Tested in Linux Docker container from image microsoft/aspnetcore-build@sha256:1e4043c2484157e029d6b09a3149ebd01c5122f6b62f0a1b6c6f54b90500ea4b.\r\n * Replaced the NuGet dlls in the dotnet sdk folder\r\n * With `NUGET_AUTHENTICATION_TYPES=basic`: Successfully authenticates with basic credentials\r\n * With the variable unset: fails as before\r\n* Tested on Windows with nuget.exe:\r\n * With `NUGET_AUTHENTICATION_TYPES=basic`: Successfully authenticates with basic credentials\r\n * With the variable unset: Attempts to use credentials for Negotiate auth, doesn't fall back to Basic when that doesn't work.\r\n","created_at":"2018-06-13T21:22:29Z","updated_at":"2018-07-18T17:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b551e468be2dd125fdce04b5dd38860028273a87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rohit21agrawal","id":1857490,"node_id":"MDQ6VXNlcjE4NTc0OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1857490?v=4","gravatar_id":"","url":"https://api.github.com/users/rohit21agrawal","html_url":"https://github.com/rohit21agrawal","followers_url":"https://api.github.com/users/rohit21agrawal/followers","following_url":"https://api.github.com/users/rohit21agrawal/following{/other_user}","gists_url":"https://api.github.com/users/rohit21agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/rohit21agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohit21agrawal/subscriptions","organizations_url":"https://api.github.com/users/rohit21agrawal/orgs","repos_url":"https://api.github.com/users/rohit21agrawal/repos","events_url":"https://api.github.com/users/rohit21agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/rohit21agrawal/received_events","type":"User","site_admin":false},{"login":"PatoBeltran","id":2132567,"node_id":"MDQ6VXNlcjIxMzI1Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/2132567?v=4","gravatar_id":"","url":"https://api.github.com/users/PatoBeltran","html_url":"https://github.com/PatoBeltran","followers_url":"https://api.github.com/users/PatoBeltran/followers","following_url":"https://api.github.com/users/PatoBeltran/following{/other_user}","gists_url":"https://api.github.com/users/PatoBeltran/gists{/gist_id}","starred_url":"https://api.github.com/users/PatoBeltran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatoBeltran/subscriptions","organizations_url":"https://api.github.com/users/PatoBeltran/orgs","repos_url":"https://api.github.com/users/PatoBeltran/repos","events_url":"https://api.github.com/users/PatoBeltran/events{/privacy}","received_events_url":"https://api.github.com/users/PatoBeltran/received_events","type":"User","site_admin":false},{"login":"zhili1208","id":7131513,"node_id":"MDQ6VXNlcjcxMzE1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7131513?v=4","gravatar_id":"","url":"https://api.github.com/users/zhili1208","html_url":"https://github.com/zhili1208","followers_url":"https://api.github.com/users/zhili1208/followers","following_url":"https://api.github.com/users/zhili1208/following{/other_user}","gists_url":"https://api.github.com/users/zhili1208/gists{/gist_id}","starred_url":"https://api.github.com/users/zhili1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhili1208/subscriptions","organizations_url":"https://api.github.com/users/zhili1208/orgs","repos_url":"https://api.github.com/users/zhili1208/repos","events_url":"https://api.github.com/users/zhili1208/events{/privacy}","received_events_url":"https://api.github.com/users/zhili1208/received_events","type":"User","site_admin":false},{"login":"mishra14","id":10507120,"node_id":"MDQ6VXNlcjEwNTA3MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/10507120?v=4","gravatar_id":"","url":"https://api.github.com/users/mishra14","html_url":"https://github.com/mishra14","followers_url":"https://api.github.com/users/mishra14/followers","following_url":"https://api.github.com/users/mishra14/following{/other_user}","gists_url":"https://api.github.com/users/mishra14/gists{/gist_id}","starred_url":"https://api.github.com/users/mishra14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishra14/subscriptions","organizations_url":"https://api.github.com/users/mishra14/orgs","repos_url":"https://api.github.com/users/mishra14/repos","events_url":"https://api.github.com/users/mishra14/events{/privacy}","received_events_url":"https://api.github.com/users/mishra14/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":788888526,"node_id":"MDU6TGFiZWw3ODg4ODg1MjY=","url":"https://api.github.com/repos/NuGet/NuGet.Client/labels/Approved%20for%20CI","name":"Approved for CI","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2297/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/f1bfa71e58840f2172a874f352779e00bf80aeb4","head":{"label":"jmyersmsft:basicCredsOnly2","ref":"basicCredsOnly2","sha":"f1bfa71e58840f2172a874f352779e00bf80aeb4","user":{"login":"jmyersmsft","id":11822817,"node_id":"MDQ6VXNlcjExODIyODE3","avatar_url":"https://avatars2.githubusercontent.com/u/11822817?v=4","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"repo":{"id":62089818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjA4OTgxOA==","name":"NuGet.Client","full_name":"jmyersmsft/NuGet.Client","owner":{"login":"jmyersmsft","id":11822817,"node_id":"MDQ6VXNlcjExODIyODE3","avatar_url":"https://avatars2.githubusercontent.com/u/11822817?v=4","gravatar_id":"","url":"https://api.github.com/users/jmyersmsft","html_url":"https://github.com/jmyersmsft","followers_url":"https://api.github.com/users/jmyersmsft/followers","following_url":"https://api.github.com/users/jmyersmsft/following{/other_user}","gists_url":"https://api.github.com/users/jmyersmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jmyersmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmyersmsft/subscriptions","organizations_url":"https://api.github.com/users/jmyersmsft/orgs","repos_url":"https://api.github.com/users/jmyersmsft/repos","events_url":"https://api.github.com/users/jmyersmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jmyersmsft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmyersmsft/NuGet.Client","description":"Core client libraries for NuGet Services","fork":true,"url":"https://api.github.com/repos/jmyersmsft/NuGet.Client","forks_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/forks","keys_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/events","assignees_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/merges","archive_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/jmyersmsft/NuGet.Client/deployments","created_at":"2016-06-27T21:33:05Z","updated_at":"2016-06-27T21:33:17Z","pushed_at":"2018-07-11T15:32:01Z","git_url":"git://github.com/jmyersmsft/NuGet.Client.git","ssh_url":"git@github.com:jmyersmsft/NuGet.Client.git","clone_url":"https://github.com/jmyersmsft/NuGet.Client.git","svn_url":"https://github.com/jmyersmsft/NuGet.Client","homepage":null,"size":35043,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"82dec5d7ef12975184891a7e0cfe6447bcc40c5e","user":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMzMDczNg==","name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2018-07-18T01:59:30Z","pushed_at":"2018-07-18T05:41:15Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":34568,"stargazers_count":267,"watchers_count":267,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":315,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":315,"open_issues":27,"watchers":267,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/2297"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2297"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2297/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2297/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/f1bfa71e58840f2172a874f352779e00bf80aeb4"}},"author_association":"NONE"}} | {
"id": 19330736,
"name": "NuGet/NuGet.Client",
"url": "https://api.github.com/repos/NuGet/NuGet.Client"
} | {
"id": 2878341,
"login": "nkolev92",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2878341?",
"url": "https://api.github.com/users/nkolev92"
} | {
"id": 968310,
"login": "NuGet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/968310?",
"url": "https://api.github.com/orgs/NuGet"
} | 2018-07-18T17:15:00 | 7984328663 | {"actor":{"display_login":"nkolev92"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/222898012","pull_request_review_id":161896993,"id":222898012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjg5ODAxMg==","diff_hunk":"@@ -886,7 +944,16 @@ log_threaded_dest_driver_init_method(LogPipe *s)\n if (!self->seq_num)\n init_sequence_number(&self->seq_num);\n \n- return _start_worker_thread(self);\n+ /* free previous workers array if set to cope with num_workers change */\n+ g_free(self->workers);\n+ self->workers = g_new0(LogThreadedDestWorker *, self->num_workers);\n+\n+ gboolean startup_success = TRUE;\n+ for (gint i = 0; startup_success && i < self->num_workers; i++)\n+ {\n+ startup_success &= _start_worker_thread(self);","path":"lib/logthrdestdrv.c","position":853,"original_position":174,"commit_id":"ca7bc4d855d79c6f0840e8f8b700996a00f125a9","original_commit_id":"5f32ecc6f83cccbfd45ceb5da1f56678fe6adb3b","user":{"login":"furiel","id":11007226,"node_id":"MDQ6VXNlcjExMDA3MjI2","avatar_url":"https://avatars0.githubusercontent.com/u/11007226?v=4","gravatar_id":"","url":"https://api.github.com/users/furiel","html_url":"https://github.com/furiel","followers_url":"https://api.github.com/users/furiel/followers","following_url":"https://api.github.com/users/furiel/following{/other_user}","gists_url":"https://api.github.com/users/furiel/gists{/gist_id}","starred_url":"https://api.github.com/users/furiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furiel/subscriptions","organizations_url":"https://api.github.com/users/furiel/orgs","repos_url":"https://api.github.com/users/furiel/repos","events_url":"https://api.github.com/users/furiel/events{/privacy}","received_events_url":"https://api.github.com/users/furiel/received_events","type":"User","site_admin":false},"body":"I was thinking that the individual workers also have init deinit mechanism, but that's not the case as only the \"master\" has init-deinit, hence was my confusion. I agree. Marking as resolved.","created_at":"2018-10-05T05:56:20Z","updated_at":"2018-10-05T05:56:21Z","html_url":"https://github.com/balabit/syslog-ng/pull/2291#discussion_r222898012","pull_request_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments/222898012"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2291#discussion_r222898012"},"pull_request":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291"}},"in_reply_to_id":221421294},"pull_request":{"url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291","id":216309301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzA5MzAx","html_url":"https://github.com/balabit/syslog-ng/pull/2291","diff_url":"https://github.com/balabit/syslog-ng/pull/2291.diff","patch_url":"https://github.com/balabit/syslog-ng/pull/2291.patch","issue_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2291","number":2291,"state":"open","locked":false,"title":"Http multi threading","user":{"login":"bazsi","id":714102,"node_id":"MDQ6VXNlcjcxNDEwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/714102?v=4","gravatar_id":"","url":"https://api.github.com/users/bazsi","html_url":"https://github.com/bazsi","followers_url":"https://api.github.com/users/bazsi/followers","following_url":"https://api.github.com/users/bazsi/following{/other_user}","gists_url":"https://api.github.com/users/bazsi/gists{/gist_id}","starred_url":"https://api.github.com/users/bazsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazsi/subscriptions","organizations_url":"https://api.github.com/users/bazsi/orgs","repos_url":"https://api.github.com/users/bazsi/repos","events_url":"https://api.github.com/users/bazsi/events{/privacy}","received_events_url":"https://api.github.com/users/bazsi/received_events","type":"User","site_admin":false},"body":"This branch implements multithreaded http destination, that uses the specified number of worker threads to send messages to an upstream HTTP server.\r\n\r\nThis should drastically improve performance of HTTP based transports, especially if combined with #2289, #2287, #2286 ","created_at":"2018-09-18T13:32:48Z","updated_at":"2018-10-05T05:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68e59919668250916ea470a4ed96993e4b8bf67f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gaborznagy","id":25612261,"node_id":"MDQ6VXNlcjI1NjEyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/25612261?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborznagy","html_url":"https://github.com/gaborznagy","followers_url":"https://api.github.com/users/gaborznagy/followers","following_url":"https://api.github.com/users/gaborznagy/following{/other_user}","gists_url":"https://api.github.com/users/gaborznagy/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborznagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborznagy/subscriptions","organizations_url":"https://api.github.com/users/gaborznagy/orgs","repos_url":"https://api.github.com/users/gaborznagy/repos","events_url":"https://api.github.com/users/gaborznagy/events{/privacy}","received_events_url":"https://api.github.com/users/gaborznagy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291/commits","review_comments_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291/comments","review_comment_url":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/issues/2291/comments","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/ca7bc4d855d79c6f0840e8f8b700996a00f125a9","head":{"label":"balabit:http-multi-threading","ref":"http-multi-threading","sha":"ca7bc4d855d79c6f0840e8f8b700996a00f125a9","user":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Njc1Nw==","name":"syslog-ng","full_name":"balabit/syslog-ng","private":false,"owner":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2018-10-04T14:10:05Z","pushed_at":"2018-10-05T05:53:04Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":24811,"stargazers_count":886,"watchers_count":886,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":181,"watchers":886,"default_branch":"master"}},"base":{"label":"balabit:master","ref":"master","sha":"d7c70cfcc3fde0393d127a4b3f3fa1033fad0c40","user":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"repo":{"id":14146757,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0Njc1Nw==","name":"syslog-ng","full_name":"balabit/syslog-ng","private":false,"owner":{"login":"balabit","id":986981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4Njk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/986981?v=4","gravatar_id":"","url":"https://api.github.com/users/balabit","html_url":"https://github.com/balabit","followers_url":"https://api.github.com/users/balabit/followers","following_url":"https://api.github.com/users/balabit/following{/other_user}","gists_url":"https://api.github.com/users/balabit/gists{/gist_id}","starred_url":"https://api.github.com/users/balabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balabit/subscriptions","organizations_url":"https://api.github.com/users/balabit/orgs","repos_url":"https://api.github.com/users/balabit/repos","events_url":"https://api.github.com/users/balabit/events{/privacy}","received_events_url":"https://api.github.com/users/balabit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/balabit/syslog-ng","description":"syslog-ng is an enhanced log daemon, supporting a wide range of input and output methods: syslog, unstructured text, queueing, SQL & NoSQL.","fork":false,"url":"https://api.github.com/repos/balabit/syslog-ng","forks_url":"https://api.github.com/repos/balabit/syslog-ng/forks","keys_url":"https://api.github.com/repos/balabit/syslog-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balabit/syslog-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balabit/syslog-ng/teams","hooks_url":"https://api.github.com/repos/balabit/syslog-ng/hooks","issue_events_url":"https://api.github.com/repos/balabit/syslog-ng/issues/events{/number}","events_url":"https://api.github.com/repos/balabit/syslog-ng/events","assignees_url":"https://api.github.com/repos/balabit/syslog-ng/assignees{/user}","branches_url":"https://api.github.com/repos/balabit/syslog-ng/branches{/branch}","tags_url":"https://api.github.com/repos/balabit/syslog-ng/tags","blobs_url":"https://api.github.com/repos/balabit/syslog-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balabit/syslog-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balabit/syslog-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/balabit/syslog-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balabit/syslog-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/balabit/syslog-ng/languages","stargazers_url":"https://api.github.com/repos/balabit/syslog-ng/stargazers","contributors_url":"https://api.github.com/repos/balabit/syslog-ng/contributors","subscribers_url":"https://api.github.com/repos/balabit/syslog-ng/subscribers","subscription_url":"https://api.github.com/repos/balabit/syslog-ng/subscription","commits_url":"https://api.github.com/repos/balabit/syslog-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/balabit/syslog-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/balabit/syslog-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/balabit/syslog-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/balabit/syslog-ng/contents/{+path}","compare_url":"https://api.github.com/repos/balabit/syslog-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balabit/syslog-ng/merges","archive_url":"https://api.github.com/repos/balabit/syslog-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balabit/syslog-ng/downloads","issues_url":"https://api.github.com/repos/balabit/syslog-ng/issues{/number}","pulls_url":"https://api.github.com/repos/balabit/syslog-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/balabit/syslog-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/balabit/syslog-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balabit/syslog-ng/labels{/name}","releases_url":"https://api.github.com/repos/balabit/syslog-ng/releases{/id}","deployments_url":"https://api.github.com/repos/balabit/syslog-ng/deployments","created_at":"2013-11-05T16:22:02Z","updated_at":"2018-10-04T14:10:05Z","pushed_at":"2018-10-05T05:53:04Z","git_url":"git://github.com/balabit/syslog-ng.git","ssh_url":"git@github.com:balabit/syslog-ng.git","clone_url":"https://github.com/balabit/syslog-ng.git","svn_url":"https://github.com/balabit/syslog-ng","homepage":"http://www.syslog-ng.org/","size":24811,"stargazers_count":886,"watchers_count":886,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":181,"watchers":886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291"},"html":{"href":"https://github.com/balabit/syslog-ng/pull/2291"},"issue":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2291"},"comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/issues/2291/comments"},"review_comments":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291/comments"},"review_comment":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balabit/syslog-ng/pulls/2291/commits"},"statuses":{"href":"https://api.github.com/repos/balabit/syslog-ng/statuses/ca7bc4d855d79c6f0840e8f8b700996a00f125a9"}},"author_association":"MEMBER"}} | {
"id": 14146757,
"name": "balabit/syslog-ng",
"url": "https://api.github.com/repos/balabit/syslog-ng"
} | {
"id": 11007226,
"login": "furiel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11007226?",
"url": "https://api.github.com/users/furiel"
} | {
"id": 986981,
"login": "balabit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/986981?",
"url": "https://api.github.com/orgs/balabit"
} | 2018-10-05T05:56:20 | 8372245049 | {"actor":{"display_login":"furiel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/176697604","pull_request_review_id":106447024,"id":176697604,"diff_hunk":"@@ -0,0 +1,103 @@\n+Yii and Docker\n+==============\n+\n+For development and deployments Yii applications can be run as Docker containers. A container is like a lightweight isolated virtual machine that maps its services to host's ports, i.e. a webserver in a container on port 80 is available on port 8888 on your (local)host. \n+\n+Containers can solve many issues such as having identical software versions at developer's computer and the server, fast deployments or simulating mutli-server architecture while developing.\n+\n+You can read more about Docker containers on [docker.com](https://www.docker.com/what-docker).\n+\n+## Requirements\n+\n+- `docker`\n+- `docker-compose`\n+\n+Visit the [download page](https://www.docker.com/community-edition) to get the Docker tooling.\n+\n+## Installation\n+\n+After installation, you should be able to run `docker ps` and see an output similar to\n+\n+```\n+CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS\n+```\n+\n+This means your Docker daemon is up and running.\n+\n+Additionally run `docker-compose version`, your output should look like this\n+\n+```\n+docker-compose version 1.20.0, build unknown\n+docker-py version: 3.1.3\n+CPython version: 3.6.4\n+OpenSSL version: OpenSSL 1.1.0g 2 Nov 2017\n+```\n+\n+With Compose you can configure manage all services required for your application, such as databases and caching.\n+\n+## Resources\n+\n+- PHP-base images for Yii can be found at [yii2-docker](https://github.com/yiisoft/yii2-docker)\n+- Docker support for [yii2-app-basic](https://github.com/yiisoft/yii2-app-basic#install-with-docker)\n+- Docker support for [yii2-app-advanced](https://github.com/yiisoft/yii2-app-advanced/pull/347) is in development\n+\n+## Usage\n+\n+Basic commands for Docker are\n+\n+ docker-compose up -d\n+ \n+to start all services in your stack, in the background\n+\n+ docker-compose ps\n+ \n+to list running services\n+\n+ docker-compose logs -f\n+ \n+to view logs for all services, continuously\n+\n+ docker-compose stop\n+ \n+to stop all services in your stack, gracefully\n+\n+ docker-copmose kill\n+ \n+to stop all services in your stack, immediately\n+\n+ docker-copmose down -v\n+ \n+to stop and remove all services, **be aware of data loss when not using host-volumes**\n+\n+To run commands in a container\n+\n+ docker-composer run --rm php composer install","path":"docs/guide/tutorial-docker.md","position":null,"original_position":74,"commit_id":"2797268f4cd3013055d5889f6f81968c5083bfc1","original_commit_id":"eee39632df860c1180a934285e21928884b1a355","user":{"login":"schmunk42","id":649031,"avatar_url":"https://avatars1.githubusercontent.com/u/649031?v=4","gravatar_id":"","url":"https://api.github.com/users/schmunk42","html_url":"https://github.com/schmunk42","followers_url":"https://api.github.com/users/schmunk42/followers","following_url":"https://api.github.com/users/schmunk42/following{/other_user}","gists_url":"https://api.github.com/users/schmunk42/gists{/gist_id}","starred_url":"https://api.github.com/users/schmunk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmunk42/subscriptions","organizations_url":"https://api.github.com/users/schmunk42/orgs","repos_url":"https://api.github.com/users/schmunk42/repos","events_url":"https://api.github.com/users/schmunk42/events{/privacy}","received_events_url":"https://api.github.com/users/schmunk42/received_events","type":"User","site_admin":false},"body":"LOL, thanks for spotting :+1: ","created_at":"2018-03-23T10:45:20Z","updated_at":"2018-03-23T10:45:20Z","html_url":"https://github.com/yiisoft/yii2/pull/15938#discussion_r176697604","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15938","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/176697604"},"html":{"href":"https://github.com/yiisoft/yii2/pull/15938#discussion_r176697604"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15938"}},"in_reply_to_id":176621565},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/15938","id":176475361,"html_url":"https://github.com/yiisoft/yii2/pull/15938","diff_url":"https://github.com/yiisoft/yii2/pull/15938.diff","patch_url":"https://github.com/yiisoft/yii2/pull/15938.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/15938","number":15938,"state":"open","locked":false,"title":"added docs about Docker","user":{"login":"schmunk42","id":649031,"avatar_url":"https://avatars1.githubusercontent.com/u/649031?v=4","gravatar_id":"","url":"https://api.github.com/users/schmunk42","html_url":"https://github.com/schmunk42","followers_url":"https://api.github.com/users/schmunk42/followers","following_url":"https://api.github.com/users/schmunk42/following{/other_user}","gists_url":"https://api.github.com/users/schmunk42/gists{/gist_id}","starred_url":"https://api.github.com/users/schmunk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmunk42/subscriptions","organizations_url":"https://api.github.com/users/schmunk42/orgs","repos_url":"https://api.github.com/users/schmunk42/repos","events_url":"https://api.github.com/users/schmunk42/events{/privacy}","received_events_url":"https://api.github.com/users/schmunk42/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| ------------- | ---\r\n| Is bugfix? | no\r\n| New feature? | yes (documentation)\r\n| Breaks BC? | no\r\n| Tests pass? | n/a\r\n| Fixed issues | https://github.com/yiisoft/yii2-docker/issues/19\r\n\r\nRelated:\r\n- https://github.com/yiisoft/yii2-app-advanced/pull/347\r\n- https://github.com/yiisoft/yii2-docker/pull/29#issuecomment-374174837\r\n\r\nFor sure we could write a ton more about Docker, but at least this is a starting point.","created_at":"2018-03-21T13:28:32Z","updated_at":"2018-03-23T10:45:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c993c35e64ec3c3d1afc57a3cfbe19daa6791fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":33208865,"url":"https://api.github.com/repos/yiisoft/yii2/labels/type:docs","name":"type:docs","color":"207de5","default":false}],"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/22","html_url":"https://github.com/yiisoft/yii2/milestone/22","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/22/labels","id":1962396,"number":22,"title":"2.1.0","description":"","creator":{"login":"samdark","id":47294,"avatar_url":"https://avatars2.githubusercontent.com/u/47294?v=4","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"open_issues":239,"closed_issues":116,"state":"open","created_at":"2016-08-25T07:42:19Z","updated_at":"2018-03-22T15:52:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15938/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15938/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/15938/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/2797268f4cd3013055d5889f6f81968c5083bfc1","head":{"label":"schmunk42:feature/docs-docker","ref":"feature/docs-docker","sha":"2797268f4cd3013055d5889f6f81968c5083bfc1","user":{"login":"schmunk42","id":649031,"avatar_url":"https://avatars1.githubusercontent.com/u/649031?v=4","gravatar_id":"","url":"https://api.github.com/users/schmunk42","html_url":"https://github.com/schmunk42","followers_url":"https://api.github.com/users/schmunk42/followers","following_url":"https://api.github.com/users/schmunk42/following{/other_user}","gists_url":"https://api.github.com/users/schmunk42/gists{/gist_id}","starred_url":"https://api.github.com/users/schmunk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmunk42/subscriptions","organizations_url":"https://api.github.com/users/schmunk42/orgs","repos_url":"https://api.github.com/users/schmunk42/repos","events_url":"https://api.github.com/users/schmunk42/events{/privacy}","received_events_url":"https://api.github.com/users/schmunk42/received_events","type":"User","site_admin":false},"repo":{"id":31380895,"name":"yii2","full_name":"schmunk42/yii2","owner":{"login":"schmunk42","id":649031,"avatar_url":"https://avatars1.githubusercontent.com/u/649031?v=4","gravatar_id":"","url":"https://api.github.com/users/schmunk42","html_url":"https://github.com/schmunk42","followers_url":"https://api.github.com/users/schmunk42/followers","following_url":"https://api.github.com/users/schmunk42/following{/other_user}","gists_url":"https://api.github.com/users/schmunk42/gists{/gist_id}","starred_url":"https://api.github.com/users/schmunk42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmunk42/subscriptions","organizations_url":"https://api.github.com/users/schmunk42/orgs","repos_url":"https://api.github.com/users/schmunk42/repos","events_url":"https://api.github.com/users/schmunk42/events{/privacy}","received_events_url":"https://api.github.com/users/schmunk42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmunk42/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/schmunk42/yii2","forks_url":"https://api.github.com/repos/schmunk42/yii2/forks","keys_url":"https://api.github.com/repos/schmunk42/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmunk42/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmunk42/yii2/teams","hooks_url":"https://api.github.com/repos/schmunk42/yii2/hooks","issue_events_url":"https://api.github.com/repos/schmunk42/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/schmunk42/yii2/events","assignees_url":"https://api.github.com/repos/schmunk42/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/schmunk42/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/schmunk42/yii2/tags","blobs_url":"https://api.github.com/repos/schmunk42/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmunk42/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmunk42/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmunk42/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmunk42/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/schmunk42/yii2/languages","stargazers_url":"https://api.github.com/repos/schmunk42/yii2/stargazers","contributors_url":"https://api.github.com/repos/schmunk42/yii2/contributors","subscribers_url":"https://api.github.com/repos/schmunk42/yii2/subscribers","subscription_url":"https://api.github.com/repos/schmunk42/yii2/subscription","commits_url":"https://api.github.com/repos/schmunk42/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmunk42/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmunk42/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmunk42/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmunk42/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/schmunk42/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmunk42/yii2/merges","archive_url":"https://api.github.com/repos/schmunk42/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmunk42/yii2/downloads","issues_url":"https://api.github.com/repos/schmunk42/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/schmunk42/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/schmunk42/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/schmunk42/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmunk42/yii2/labels{/name}","releases_url":"https://api.github.com/repos/schmunk42/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/schmunk42/yii2/deployments","created_at":"2015-02-26T18:05:43Z","updated_at":"2015-02-26T18:08:01Z","pushed_at":"2018-03-23T10:44:34Z","git_url":"git://github.com/schmunk42/yii2.git","ssh_url":"git@github.com:schmunk42/yii2.git","clone_url":"https://github.com/schmunk42/yii2.git","svn_url":"https://github.com/schmunk42/yii2","homepage":"http://www.yiiframework.com","size":78393,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"143d429975265e1ebbac557a30ef5bdaf348c890","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2018-03-23T09:40:44Z","pushed_at":"2018-03-23T10:44:40Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":78560,"stargazers_count":11748,"watchers_count":11748,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6349,"mirror_url":null,"archived":false,"open_issues_count":911,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6349,"open_issues":911,"watchers":11748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15938"},"html":{"href":"https://github.com/yiisoft/yii2/pull/15938"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/15938"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/15938/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15938/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15938/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/2797268f4cd3013055d5889f6f81968c5083bfc1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3431193,
"name": "yiisoft/yii2",
"url": "https://api.github.com/repos/yiisoft/yii2"
} | {
"id": 649031,
"login": "schmunk42",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/649031?",
"url": "https://api.github.com/users/schmunk42"
} | {
"id": 993323,
"login": "yiisoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/993323?",
"url": "https://api.github.com/orgs/yiisoft"
} | 2018-03-23T10:45:20 | 7424617273 | {"actor":{"display_login":"schmunk42"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab-android/pulls/comments/244546625","pull_request_review_id":188452038,"id":244546625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU0NjYyNQ==","diff_hunk":"@@ -254,4 +255,22 @@ public static void applySwipeLayoutColors(SwipeRefreshLayout swipeLayout,\n }\n swipeLayout.setColorSchemeColors(colors);\n }\n+\n+ public static long[] getVibrationPattern(Context context) {","path":"mobile/src/main/java/org/openhab/habdroid/util/Util.java","position":13,"original_position":13,"commit_id":"baa76904618472cf89b5995bd45790918f1c251d","original_commit_id":"baa76904618472cf89b5995bd45790918f1c251d","user":{"login":"stickler-ci[bot]","id":41810448,"node_id":"MDM6Qm90NDE4MTA0NDg=","avatar_url":"https://avatars3.githubusercontent.com/in/15299?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci%5Bbot%5D","html_url":"https://github.com/apps/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/followers","following_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/repos","events_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Missing a Javadoc comment.","created_at":"2018-12-30T22:19:23Z","updated_at":"2018-12-30T22:19:23Z","html_url":"https://github.com/openhab/openhab-android/pull/1137#discussion_r244546625","pull_request_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/comments/244546625"},"html":{"href":"https://github.com/openhab/openhab-android/pull/1137#discussion_r244546625"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137","id":238175697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTc1Njk3","html_url":"https://github.com/openhab/openhab-android/pull/1137","diff_url":"https://github.com/openhab/openhab-android/pull/1137.diff","patch_url":"https://github.com/openhab/openhab-android/pull/1137.patch","issue_url":"https://api.github.com/repos/openhab/openhab-android/issues/1137","number":1137,"state":"open","locked":false,"title":"Send alarm clock to openHAB","user":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"body":"and also add a framework for adding more background tasks like this in\r\nthe future.\r\n\r\nThanks to @ekahlenberger for this idea.\r\n\r\nSigned-off-by: mueller-ma <mueller-ma@users.noreply.github.com>\r\n\r\nTODO:\r\n\r\n- [x] Add feature with example to Readme/Docs","created_at":"2018-12-12T20:42:26Z","updated_at":"2018-12-30T22:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42613f2f751132aabc3000e83ca3d7410995919d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":91955062,"node_id":"MDU6TGFiZWw5MTk1NTA2Mg==","url":"https://api.github.com/repos/openhab/openhab-android/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-android/issues/1137/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-android/statuses/baa76904618472cf89b5995bd45790918f1c251d","head":{"label":"mueller-ma:alarm-clock","ref":"alarm-clock","sha":"baa76904618472cf89b5995bd45790918f1c251d","user":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"repo":{"id":86972940,"node_id":"MDEwOlJlcG9zaXRvcnk4Njk3Mjk0MA==","name":"openhab.android","full_name":"mueller-ma/openhab.android","private":false,"owner":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mueller-ma/openhab.android","description":"openHAB Android app","fork":true,"url":"https://api.github.com/repos/mueller-ma/openhab.android","forks_url":"https://api.github.com/repos/mueller-ma/openhab.android/forks","keys_url":"https://api.github.com/repos/mueller-ma/openhab.android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mueller-ma/openhab.android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mueller-ma/openhab.android/teams","hooks_url":"https://api.github.com/repos/mueller-ma/openhab.android/hooks","issue_events_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues/events{/number}","events_url":"https://api.github.com/repos/mueller-ma/openhab.android/events","assignees_url":"https://api.github.com/repos/mueller-ma/openhab.android/assignees{/user}","branches_url":"https://api.github.com/repos/mueller-ma/openhab.android/branches{/branch}","tags_url":"https://api.github.com/repos/mueller-ma/openhab.android/tags","blobs_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mueller-ma/openhab.android/statuses/{sha}","languages_url":"https://api.github.com/repos/mueller-ma/openhab.android/languages","stargazers_url":"https://api.github.com/repos/mueller-ma/openhab.android/stargazers","contributors_url":"https://api.github.com/repos/mueller-ma/openhab.android/contributors","subscribers_url":"https://api.github.com/repos/mueller-ma/openhab.android/subscribers","subscription_url":"https://api.github.com/repos/mueller-ma/openhab.android/subscription","commits_url":"https://api.github.com/repos/mueller-ma/openhab.android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mueller-ma/openhab.android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mueller-ma/openhab.android/contents/{+path}","compare_url":"https://api.github.com/repos/mueller-ma/openhab.android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mueller-ma/openhab.android/merges","archive_url":"https://api.github.com/repos/mueller-ma/openhab.android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mueller-ma/openhab.android/downloads","issues_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues{/number}","pulls_url":"https://api.github.com/repos/mueller-ma/openhab.android/pulls{/number}","milestones_url":"https://api.github.com/repos/mueller-ma/openhab.android/milestones{/number}","notifications_url":"https://api.github.com/repos/mueller-ma/openhab.android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mueller-ma/openhab.android/labels{/name}","releases_url":"https://api.github.com/repos/mueller-ma/openhab.android/releases{/id}","deployments_url":"https://api.github.com/repos/mueller-ma/openhab.android/deployments","created_at":"2017-04-02T08:23:49Z","updated_at":"2017-09-30T23:51:32Z","pushed_at":"2018-12-30T22:19:07Z","git_url":"git://github.com/mueller-ma/openhab.android.git","ssh_url":"git@github.com:mueller-ma/openhab.android.git","clone_url":"https://github.com/mueller-ma/openhab.android.git","svn_url":"https://github.com/mueller-ma/openhab.android","homepage":null,"size":27459,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"de486ea55b6001affbe5045089d1d2993d71d6b9","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":18703240,"node_id":"MDEwOlJlcG9zaXRvcnkxODcwMzI0MA==","name":"openhab-android","full_name":"openhab/openhab-android","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab-android","description":"openHAB client for Android","fork":false,"url":"https://api.github.com/repos/openhab/openhab-android","forks_url":"https://api.github.com/repos/openhab/openhab-android/forks","keys_url":"https://api.github.com/repos/openhab/openhab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-android/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-android/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-android/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-android/events","assignees_url":"https://api.github.com/repos/openhab/openhab-android/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-android/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-android/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-android/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-android/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-android/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-android/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-android/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-android/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-android/merges","archive_url":"https://api.github.com/repos/openhab/openhab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-android/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-android/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-android/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-android/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-android/deployments","created_at":"2014-04-12T12:09:03Z","updated_at":"2018-12-30T21:52:00Z","pushed_at":"2018-12-30T22:19:09Z","git_url":"git://github.com/openhab/openhab-android.git","ssh_url":"git@github.com:openhab/openhab-android.git","clone_url":"https://github.com/openhab/openhab-android.git","svn_url":"https://github.com/openhab/openhab-android","homepage":"https://play.google.com/store/apps/details?id=org.openhab.habdroid","size":27149,"stargazers_count":263,"watchers_count":263,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":221,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":221,"open_issues":117,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137"},"html":{"href":"https://github.com/openhab/openhab-android/pull/1137"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-android/issues/1137"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-android/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-android/statuses/baa76904618472cf89b5995bd45790918f1c251d"}},"author_association":"MEMBER"}} | {
"id": 18703240,
"name": "openhab/openhab-android",
"url": "https://api.github.com/repos/openhab/openhab-android"
} | {
"id": 41810448,
"login": "stickler-ci[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41810448?",
"url": "https://api.github.com/users/stickler-ci[bot]"
} | {
"id": 1007353,
"login": "openhab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1007353?",
"url": "https://api.github.com/orgs/openhab"
} | 2018-12-30T22:19:23 | 8817320045 | {"actor":{"display_login":"stickler-ci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/227380149","pull_request_review_id":167405796,"id":227380149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzM4MDE0OQ==","diff_hunk":"@@ -8598,9 +8598,8 @@ bool OSDMonitor::prepare_command_impl(MonOpRequestRef op,\n CrushWrapper newcrush;\n _get_pending_crush(newcrush);\n if (!newcrush.class_exists(device_class)) {\n- err = -ENOENT;\n- ss << \"class '\" << device_class << \"' does not exist\";\n- goto reply;\n+ err = 0; // make command idempotent\n+ goto wait;","path":"src/mon/OSDMonitor.cc","position":8,"original_position":8,"commit_id":"1e5eb78765e8d0553dedd19f2c0836e070179744","original_commit_id":"1e5eb78765e8d0553dedd19f2c0836e070179744","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"@liewegas Do you mean:\r\n\r\n```\r\nif (!crush.class_exists(device_class)) {\r\n err = 0;\r\n ss << \"class '\" << device_class << \"' does not exist\";\r\n goto reply;\r\n }\r\n```\r\n?\r\n","created_at":"2018-10-23T13:06:32Z","updated_at":"2018-10-23T13:06:32Z","html_url":"https://github.com/ceph/ceph/pull/24657#discussion_r227380149","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/24657","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/227380149"},"html":{"href":"https://github.com/ceph/ceph/pull/24657#discussion_r227380149"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24657"}},"in_reply_to_id":227367898},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24657","id":223876334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODc2MzM0","html_url":"https://github.com/ceph/ceph/pull/24657","diff_url":"https://github.com/ceph/ceph/pull/24657.diff","patch_url":"https://github.com/ceph/ceph/pull/24657.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24657","number":24657,"state":"open","locked":false,"title":"mon/OSDMonitor: two \"ceph osd crush class rm\" fixes","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for opening a pull request! Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin. For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview. More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [ ] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-10-18T09:01:14Z","updated_at":"2018-10-23T13:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14cb068bdfbab073fe2e6bd79e328a5fb9080177","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/24657/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/24657/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24657/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/1e5eb78765e8d0553dedd19f2c0836e070179744","head":{"label":"xiexingguo:wip-rm-device-class-fix","ref":"wip-rm-device-class-fix","sha":"1e5eb78765e8d0553dedd19f2c0836e070179744","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"repo":{"id":45168396,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE2ODM5Ng==","name":"ceph","full_name":"xiexingguo/ceph","private":false,"owner":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xiexingguo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/xiexingguo/ceph","forks_url":"https://api.github.com/repos/xiexingguo/ceph/forks","keys_url":"https://api.github.com/repos/xiexingguo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiexingguo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiexingguo/ceph/teams","hooks_url":"https://api.github.com/repos/xiexingguo/ceph/hooks","issue_events_url":"https://api.github.com/repos/xiexingguo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/xiexingguo/ceph/events","assignees_url":"https://api.github.com/repos/xiexingguo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/xiexingguo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/xiexingguo/ceph/tags","blobs_url":"https://api.github.com/repos/xiexingguo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiexingguo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiexingguo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiexingguo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiexingguo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/xiexingguo/ceph/languages","stargazers_url":"https://api.github.com/repos/xiexingguo/ceph/stargazers","contributors_url":"https://api.github.com/repos/xiexingguo/ceph/contributors","subscribers_url":"https://api.github.com/repos/xiexingguo/ceph/subscribers","subscription_url":"https://api.github.com/repos/xiexingguo/ceph/subscription","commits_url":"https://api.github.com/repos/xiexingguo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiexingguo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiexingguo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiexingguo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiexingguo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/xiexingguo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiexingguo/ceph/merges","archive_url":"https://api.github.com/repos/xiexingguo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiexingguo/ceph/downloads","issues_url":"https://api.github.com/repos/xiexingguo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/xiexingguo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/xiexingguo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/xiexingguo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiexingguo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/xiexingguo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/xiexingguo/ceph/deployments","created_at":"2015-10-29T07:51:41Z","updated_at":"2018-10-15T01:15:32Z","pushed_at":"2018-10-23T07:23:34Z","git_url":"git://github.com/xiexingguo/ceph.git","ssh_url":"git@github.com:xiexingguo/ceph.git","clone_url":"https://github.com/xiexingguo/ceph.git","svn_url":"https://github.com/xiexingguo/ceph","homepage":"http://ceph.com","size":306108,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"ba3252544c8b4e8815a57c2292d19818b73aa43a","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-10-23T11:28:54Z","pushed_at":"2018-10-23T12:35:33Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":329032,"stargazers_count":5186,"watchers_count":5186,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2721,"mirror_url":null,"archived":false,"open_issues_count":641,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2721,"open_issues":641,"watchers":5186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24657"},"html":{"href":"https://github.com/ceph/ceph/pull/24657"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/24657"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/24657/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24657/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24657/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/1e5eb78765e8d0553dedd19f2c0836e070179744"}},"author_association":"MEMBER"}} | {
"id": 2310495,
"name": "ceph/ceph",
"url": "https://api.github.com/repos/ceph/ceph"
} | {
"id": 14193361,
"login": "xiexingguo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14193361?",
"url": "https://api.github.com/users/xiexingguo"
} | {
"id": 1015767,
"login": "ceph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1015767?",
"url": "https://api.github.com/orgs/ceph"
} | 2018-10-23T13:06:32 | 8465734845 | {"actor":{"display_login":"xiexingguo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/207733495","pull_request_review_id":143408231,"id":207733495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzczMzQ5NQ==","diff_hunk":"@@ -0,0 +1,169 @@\n+/*\n+ * PROJECT: ReactOS User-mode DMI/SMBIOS Helper Functions\n+ * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+)\n+ * PURPOSE: SMBIOS table parsing functions\n+ * COPYRIGHT: Copyright 2018 Stanislav Motylkov\n+ */\n+\n+#include \"precomp.h\"\n+\n+static UINT (WINAPI * pGetSystemFirmwareTable)(DWORD, DWORD, PVOID, DWORD);\n+\n+/* Load SMBIOS Data */\n+PVOID\n+LoadSMBiosData(\n+ _Inout_updates_(ID_STRINGS_MAX) PCHAR * Strings)\n+{\n+ HANDLE hKernel;\n+ PVOID pBuffer = NULL;\n+ HKEY hKey;\n+ DWORD dwType, dwCheck, dwBytes = 0;\n+\n+ hKernel = GetModuleHandleW(L\"kernel32.dll\");\n+ if (!hKernel)\n+ return NULL;\n+\n+ // try use GetSystemFirmwareTable (works on NT 5.2 and higher)\n+ pGetSystemFirmwareTable = (void *)GetProcAddress(hKernel, \"GetSystemFirmwareTable\");\n+ if (pGetSystemFirmwareTable)\n+ {\n+ dwBytes = pGetSystemFirmwareTable('RSMB', 0, NULL, 0);\n+ if (dwBytes > 0)\n+ {\n+ pBuffer = malloc(dwBytes);\n+ if (!pBuffer)\n+ {\n+ return NULL;\n+ }\n+ dwCheck = pGetSystemFirmwareTable('RSMB', 0, pBuffer, dwBytes);\n+ if (dwCheck != dwBytes)\n+ {\n+ free(pBuffer);\n+ return NULL;\n+ }\n+ }\n+ }\n+ if (dwBytes == 0)\n+ {\n+ // try use registry (works on NT 5.1)\n+ if (RegOpenKeyW(HKEY_LOCAL_MACHINE,\n+ L\"SYSTEM\\\\CurrentControlSet\\\\Services\\\\mssmbios\\\\Data\",\n+ &hKey) != ERROR_SUCCESS)\n+ {\n+ return NULL;\n+ }\n+\n+ if (RegQueryValueExW(hKey,\n+ L\"SMBiosData\",\n+ NULL,\n+ &dwType,\n+ NULL,\n+ &dwBytes) != ERROR_SUCCESS || dwType != REG_BINARY)\n+ {\n+ RegCloseKey(hKey);\n+ return NULL;\n+ }\n+\n+ pBuffer = malloc(dwBytes);\n+ if (!pBuffer)\n+ {\n+ RegCloseKey(hKey);\n+ return NULL;\n+ }\n+\n+ if (RegQueryValueExW(hKey,\n+ L\"SMBiosData\",\n+ NULL,\n+ &dwType,\n+ pBuffer,\n+ &dwBytes) != ERROR_SUCCESS || dwType != REG_BINARY)\n+ {\n+ free(pBuffer);\n+ RegCloseKey(hKey);\n+ return NULL;\n+ }\n+\n+ RegCloseKey(hKey);\n+ }\n+ ParseSMBiosTables(pBuffer, dwBytes, Strings);\n+ return pBuffer;\n+}\n+\n+/* Trim converted DMI string */\n+VOID\n+TrimDmiStringW(\n+ _Inout_ LPWSTR lpStr)\n+{\n+ unsigned Length;\n+ int i = 0;\n+\n+ if (!lpStr)\n+ return;\n+\n+ Length = wcslen(lpStr);\n+ if (Length == 0)\n+ return;\n+\n+ /* Trim leading spaces */\n+ while (i < Length && lpStr[i] <= 32)\n+ {\n+ i++;\n+ }\n+ if (i < Length)\n+ {\n+ if (i > 0)\n+ {\n+ Length -= i;\n+ memmove(lpStr, lpStr + i, (Length + 1) * sizeof(WCHAR));\n+ }\n+\n+ /* Trim trailing spaces */\n+ while (Length && lpStr[Length-1] <= 32)\n+ {\n+ lpStr[Length-1] = L'\\0';\n+ --Length;\n+ }\n+ }\n+ else\n+ {\n+ *lpStr = 0;\n+ }\n+}\n+\n+/* Convert string from SMBIOS */\n+unsigned","path":"sdk/lib/udmihelp/udmihelp.c","position":134,"original_position":134,"commit_id":"8bbed2c0bac6bfe09b72a10d99ba347483c9b313","original_commit_id":"8bbed2c0bac6bfe09b72a10d99ba347483c9b313","user":{"login":"ThFabba","id":18138474,"node_id":"MDQ6VXNlcjE4MTM4NDc0","avatar_url":"https://avatars3.githubusercontent.com/u/18138474?v=4","gravatar_id":"","url":"https://api.github.com/users/ThFabba","html_url":"https://github.com/ThFabba","followers_url":"https://api.github.com/users/ThFabba/followers","following_url":"https://api.github.com/users/ThFabba/following{/other_user}","gists_url":"https://api.github.com/users/ThFabba/gists{/gist_id}","starred_url":"https://api.github.com/users/ThFabba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThFabba/subscriptions","organizations_url":"https://api.github.com/users/ThFabba/orgs","repos_url":"https://api.github.com/users/ThFabba/repos","events_url":"https://api.github.com/users/ThFabba/events{/privacy}","received_events_url":"https://api.github.com/users/ThFabba/received_events","type":"User","site_admin":false},"body":"What's an un-real type?","created_at":"2018-08-05T11:44:48Z","updated_at":"2018-08-05T11:44:48Z","html_url":"https://github.com/reactos/reactos/pull/727#discussion_r207733495","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/727","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/207733495"},"html":{"href":"https://github.com/reactos/reactos/pull/727#discussion_r207733495"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/727"}},"in_reply_to_id":207733101},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/727","id":205847943,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODQ3OTQz","html_url":"https://github.com/reactos/reactos/pull/727","diff_url":"https://github.com/reactos/reactos/pull/727.diff","patch_url":"https://github.com/reactos/reactos/pull/727.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/727","number":727,"state":"open","locked":false,"title":"[DXDIAG] Fix blank system and BIOS values","user":{"login":"binarymaster","id":578406,"node_id":"MDQ6VXNlcjU3ODQwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/578406?v=4","gravatar_id":"","url":"https://api.github.com/users/binarymaster","html_url":"https://github.com/binarymaster","followers_url":"https://api.github.com/users/binarymaster/followers","following_url":"https://api.github.com/users/binarymaster/following{/other_user}","gists_url":"https://api.github.com/users/binarymaster/gists{/gist_id}","starred_url":"https://api.github.com/users/binarymaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarymaster/subscriptions","organizations_url":"https://api.github.com/users/binarymaster/orgs","repos_url":"https://api.github.com/users/binarymaster/repos","events_url":"https://api.github.com/users/binarymaster/events{/privacy}","received_events_url":"https://api.github.com/users/binarymaster/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nFix blank system and BIOS values in ReactX Diagnostic Tool.\r\n\r\nJIRA issue: [CORE-5961](https://jira.reactos.org/browse/CORE-5961)\r\n\r\n## Proposed changes\r\n\r\n- Add user-mode DMI/SMBIOS helper library that will also be used in `systeminfo` and `sysdm.cpl`\r\n- Fix bugs in the `dxdiag` and use `udmihelp` library\r\n- Screenshot after fix:\r\n\r\n","created_at":"2018-08-02T20:12:48Z","updated_at":"2018-08-05T11:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f19fdca1d0c65ec35c9447c214ab2ed5c8a5304f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/727/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/727/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/727/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/8bbed2c0bac6bfe09b72a10d99ba347483c9b313","head":{"label":"binarymaster:dxdiag-fixes","ref":"dxdiag-fixes","sha":"8bbed2c0bac6bfe09b72a10d99ba347483c9b313","user":{"login":"binarymaster","id":578406,"node_id":"MDQ6VXNlcjU3ODQwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/578406?v=4","gravatar_id":"","url":"https://api.github.com/users/binarymaster","html_url":"https://github.com/binarymaster","followers_url":"https://api.github.com/users/binarymaster/followers","following_url":"https://api.github.com/users/binarymaster/following{/other_user}","gists_url":"https://api.github.com/users/binarymaster/gists{/gist_id}","starred_url":"https://api.github.com/users/binarymaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarymaster/subscriptions","organizations_url":"https://api.github.com/users/binarymaster/orgs","repos_url":"https://api.github.com/users/binarymaster/repos","events_url":"https://api.github.com/users/binarymaster/events{/privacy}","received_events_url":"https://api.github.com/users/binarymaster/received_events","type":"User","site_admin":false},"repo":{"id":105761687,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3NjE2ODc=","name":"reactos","full_name":"binarymaster/reactos","owner":{"login":"binarymaster","id":578406,"node_id":"MDQ6VXNlcjU3ODQwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/578406?v=4","gravatar_id":"","url":"https://api.github.com/users/binarymaster","html_url":"https://github.com/binarymaster","followers_url":"https://api.github.com/users/binarymaster/followers","following_url":"https://api.github.com/users/binarymaster/following{/other_user}","gists_url":"https://api.github.com/users/binarymaster/gists{/gist_id}","starred_url":"https://api.github.com/users/binarymaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binarymaster/subscriptions","organizations_url":"https://api.github.com/users/binarymaster/orgs","repos_url":"https://api.github.com/users/binarymaster/repos","events_url":"https://api.github.com/users/binarymaster/events{/privacy}","received_events_url":"https://api.github.com/users/binarymaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binarymaster/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/binarymaster/reactos","forks_url":"https://api.github.com/repos/binarymaster/reactos/forks","keys_url":"https://api.github.com/repos/binarymaster/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binarymaster/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binarymaster/reactos/teams","hooks_url":"https://api.github.com/repos/binarymaster/reactos/hooks","issue_events_url":"https://api.github.com/repos/binarymaster/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/binarymaster/reactos/events","assignees_url":"https://api.github.com/repos/binarymaster/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/binarymaster/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/binarymaster/reactos/tags","blobs_url":"https://api.github.com/repos/binarymaster/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binarymaster/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binarymaster/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/binarymaster/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binarymaster/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/binarymaster/reactos/languages","stargazers_url":"https://api.github.com/repos/binarymaster/reactos/stargazers","contributors_url":"https://api.github.com/repos/binarymaster/reactos/contributors","subscribers_url":"https://api.github.com/repos/binarymaster/reactos/subscribers","subscription_url":"https://api.github.com/repos/binarymaster/reactos/subscription","commits_url":"https://api.github.com/repos/binarymaster/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/binarymaster/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/binarymaster/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/binarymaster/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/binarymaster/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/binarymaster/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binarymaster/reactos/merges","archive_url":"https://api.github.com/repos/binarymaster/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binarymaster/reactos/downloads","issues_url":"https://api.github.com/repos/binarymaster/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/binarymaster/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/binarymaster/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/binarymaster/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binarymaster/reactos/labels{/name}","releases_url":"https://api.github.com/repos/binarymaster/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/binarymaster/reactos/deployments","created_at":"2017-10-04T11:42:59Z","updated_at":"2018-08-05T08:19:37Z","pushed_at":"2018-08-05T08:19:34Z","git_url":"git://github.com/binarymaster/reactos.git","ssh_url":"git@github.com:binarymaster/reactos.git","clone_url":"https://github.com/binarymaster/reactos.git","svn_url":"https://github.com/binarymaster/reactos","homepage":null,"size":376848,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"d7559e23546e74b9ba099f254957d402f7becf56","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-08-05T11:39:30Z","pushed_at":"2018-08-05T11:39:18Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":458009,"stargazers_count":4914,"watchers_count":4914,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":388,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":388,"open_issues":79,"watchers":4914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/727"},"html":{"href":"https://github.com/reactos/reactos/pull/727"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/727"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/727/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/727/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/727/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/8bbed2c0bac6bfe09b72a10d99ba347483c9b313"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105627846,
"name": "reactos/reactos",
"url": "https://api.github.com/repos/reactos/reactos"
} | {
"id": 18138474,
"login": "ThFabba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18138474?",
"url": "https://api.github.com/users/ThFabba"
} | {
"id": 1056157,
"login": "reactos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1056157?",
"url": "https://api.github.com/orgs/reactos"
} | 2018-08-05T11:44:48 | 8067722605 | {"actor":{"display_login":"ThFabba"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/165940900","pull_request_review_id":93946281,"id":165940900,"diff_hunk":"@@ -966,6 +975,28 @@ FUNC KiZwSystemService\n \n ENDFUNC\n \n+PUBLIC KiConvertToGuiThread\n+FUNC KiConvertToGuiThread\n+\n+ push rbp","path":"ntoskrnl/ke/amd64/trap.S","position":41,"original_position":41,"commit_id":"9335f8f0bc58a007e3686daed457504593922fab","original_commit_id":"9335f8f0bc58a007e3686daed457504593922fab","user":{"login":"HBelusca","id":1969829,"avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"body":"> x64 functions must not begin with a single-byte instruction [...]\r\n\r\nAnd what's the technical/philosophical reason behind this?","created_at":"2018-02-05T11:06:47Z","updated_at":"2018-02-05T11:11:44Z","html_url":"https://github.com/reactos/reactos/pull/361#discussion_r165940900","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/361","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/165940900"},"html":{"href":"https://github.com/reactos/reactos/pull/361#discussion_r165940900"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/361"}},"in_reply_to_id":165924365},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/361","id":167045120,"html_url":"https://github.com/reactos/reactos/pull/361","diff_url":"https://github.com/reactos/reactos/pull/361.diff","patch_url":"https://github.com/reactos/reactos/pull/361.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/361","number":361,"state":"open","locked":false,"title":"[WIP] The ultimate ros amd64 bringup","user":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"body":"## Make ReactOS boot to user mode on x64\r\n\r\nThis fixes a large number of issues and implements missing stuff.\r\n\r\n## TODO\r\n- Fix resource conflict issues properly\r\n- Implement user mode callback code\r\n","created_at":"2018-02-05T02:17:55Z","updated_at":"2018-02-05T11:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b894613b5dbcc4fdcfacd38b72a6e67bbf86796","assignee":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zefklop","id":1056020,"avatar_url":"https://avatars0.githubusercontent.com/u/1056020?v=4","gravatar_id":"","url":"https://api.github.com/users/zefklop","html_url":"https://github.com/zefklop","followers_url":"https://api.github.com/users/zefklop/followers","following_url":"https://api.github.com/users/zefklop/following{/other_user}","gists_url":"https://api.github.com/users/zefklop/gists{/gist_id}","starred_url":"https://api.github.com/users/zefklop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zefklop/subscriptions","organizations_url":"https://api.github.com/users/zefklop/orgs","repos_url":"https://api.github.com/users/zefklop/repos","events_url":"https://api.github.com/users/zefklop/events{/privacy}","received_events_url":"https://api.github.com/users/zefklop/received_events","type":"User","site_admin":false},{"login":"HeisSpiter","id":1531741,"avatar_url":"https://avatars0.githubusercontent.com/u/1531741?v=4","gravatar_id":"","url":"https://api.github.com/users/HeisSpiter","html_url":"https://github.com/HeisSpiter","followers_url":"https://api.github.com/users/HeisSpiter/followers","following_url":"https://api.github.com/users/HeisSpiter/following{/other_user}","gists_url":"https://api.github.com/users/HeisSpiter/gists{/gist_id}","starred_url":"https://api.github.com/users/HeisSpiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeisSpiter/subscriptions","organizations_url":"https://api.github.com/users/HeisSpiter/orgs","repos_url":"https://api.github.com/users/HeisSpiter/repos","events_url":"https://api.github.com/users/HeisSpiter/events{/privacy}","received_events_url":"https://api.github.com/users/HeisSpiter/received_events","type":"User","site_admin":false},{"login":"ionescu007","id":6047864,"avatar_url":"https://avatars3.githubusercontent.com/u/6047864?v=4","gravatar_id":"","url":"https://api.github.com/users/ionescu007","html_url":"https://github.com/ionescu007","followers_url":"https://api.github.com/users/ionescu007/followers","following_url":"https://api.github.com/users/ionescu007/following{/other_user}","gists_url":"https://api.github.com/users/ionescu007/gists{/gist_id}","starred_url":"https://api.github.com/users/ionescu007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionescu007/subscriptions","organizations_url":"https://api.github.com/users/ionescu007/orgs","repos_url":"https://api.github.com/users/ionescu007/repos","events_url":"https://api.github.com/users/ionescu007/events{/privacy}","received_events_url":"https://api.github.com/users/ionescu007/received_events","type":"User","site_admin":false},{"login":"yagoulas","id":7785499,"avatar_url":"https://avatars3.githubusercontent.com/u/7785499?v=4","gravatar_id":"","url":"https://api.github.com/users/yagoulas","html_url":"https://github.com/yagoulas","followers_url":"https://api.github.com/users/yagoulas/followers","following_url":"https://api.github.com/users/yagoulas/following{/other_user}","gists_url":"https://api.github.com/users/yagoulas/gists{/gist_id}","starred_url":"https://api.github.com/users/yagoulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yagoulas/subscriptions","organizations_url":"https://api.github.com/users/yagoulas/orgs","repos_url":"https://api.github.com/users/yagoulas/repos","events_url":"https://api.github.com/users/yagoulas/events{/privacy}","received_events_url":"https://api.github.com/users/yagoulas/received_events","type":"User","site_admin":false},{"login":"EricKohl","id":32571919,"avatar_url":"https://avatars1.githubusercontent.com/u/32571919?v=4","gravatar_id":"","url":"https://api.github.com/users/EricKohl","html_url":"https://github.com/EricKohl","followers_url":"https://api.github.com/users/EricKohl/followers","following_url":"https://api.github.com/users/EricKohl/following{/other_user}","gists_url":"https://api.github.com/users/EricKohl/gists{/gist_id}","starred_url":"https://api.github.com/users/EricKohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricKohl/subscriptions","organizations_url":"https://api.github.com/users/EricKohl/orgs","repos_url":"https://api.github.com/users/EricKohl/repos","events_url":"https://api.github.com/users/EricKohl/events{/privacy}","received_events_url":"https://api.github.com/users/EricKohl/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/361/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/361/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/361/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/9335f8f0bc58a007e3686daed457504593922fab","head":{"label":"reactos:tkreuzer/The_ultimate_ros_amd64_bringup","ref":"tkreuzer/The_ultimate_ros_amd64_bringup","sha":"9335f8f0bc58a007e3686daed457504593922fab","user":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-02-05T10:24:08Z","pushed_at":"2018-02-05T10:50:25Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":462904,"stargazers_count":3185,"watchers_count":3185,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":43,"license":null,"forks":198,"open_issues":43,"watchers":3185,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"dae88fb828426f692a5ad3fd946f888311409e49","user":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-02-05T10:24:08Z","pushed_at":"2018-02-05T10:50:25Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":462904,"stargazers_count":3185,"watchers_count":3185,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":43,"license":null,"forks":198,"open_issues":43,"watchers":3185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/361"},"html":{"href":"https://github.com/reactos/reactos/pull/361"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/361"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/9335f8f0bc58a007e3686daed457504593922fab"}},"author_association":"CONTRIBUTOR"}} | {
"id": 105627846,
"name": "reactos/reactos",
"url": "https://api.github.com/repos/reactos/reactos"
} | {
"id": 1969829,
"login": "HBelusca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1969829?",
"url": "https://api.github.com/users/HBelusca"
} | {
"id": 1056157,
"login": "reactos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1056157?",
"url": "https://api.github.com/orgs/reactos"
} | 2018-02-05T11:06:47 | 7198020503 | {"actor":{"display_login":"HBelusca"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/comments/176684350","pull_request_review_id":106431861,"id":176684350,"diff_hunk":"@@ -1,3 +1,3 @@\n #!/usr/bin/env bash\n \n-mv ~/.m2/repository/com/bugsnag/bugsnag-android-gradle-plugin ~/.Trash/\n+mv ~/.m2/repository/com/bugsnag/bugsnag-android-gradle-plugin ~/.Trash/ || true","path":"features/scripts/clear_local_maven_repo.sh","position":4,"original_position":4,"commit_id":"acaed8689070661fb2fe8b52e75e32ffab32c69b","original_commit_id":"acaed8689070661fb2fe8b52e75e32ffab32c69b","user":{"login":"fractalwrench","id":11800640,"avatar_url":"https://avatars3.githubusercontent.com/u/11800640?v=4","gravatar_id":"","url":"https://api.github.com/users/fractalwrench","html_url":"https://github.com/fractalwrench","followers_url":"https://api.github.com/users/fractalwrench/followers","following_url":"https://api.github.com/users/fractalwrench/following{/other_user}","gists_url":"https://api.github.com/users/fractalwrench/gists{/gist_id}","starred_url":"https://api.github.com/users/fractalwrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractalwrench/subscriptions","organizations_url":"https://api.github.com/users/fractalwrench/orgs","repos_url":"https://api.github.com/users/fractalwrench/repos","events_url":"https://api.github.com/users/fractalwrench/events{/privacy}","received_events_url":"https://api.github.com/users/fractalwrench/received_events","type":"User","site_admin":false},"body":"I thought it would be better having this action be reversible in case something went horrendously wrong with the script/maze-runner and it deleted files it wasn't supposed to. If you're happy I can change it to `rm -rf`","created_at":"2018-03-23T09:54:08Z","updated_at":"2018-03-23T09:54:09Z","html_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92#discussion_r176684350","pull_request_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/comments/176684350"},"html":{"href":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92#discussion_r176684350"},"pull_request":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92"}},"in_reply_to_id":176683599},"pull_request":{"url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92","id":176436226,"html_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92","diff_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92.diff","patch_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92.patch","issue_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/92","number":92,"state":"open","locked":false,"title":"Install mazerunner artefact locally","user":{"login":"fractalwrench","id":11800640,"avatar_url":"https://avatars3.githubusercontent.com/u/11800640?v=4","gravatar_id":"","url":"https://api.github.com/users/fractalwrench","html_url":"https://github.com/fractalwrench","followers_url":"https://api.github.com/users/fractalwrench/followers","following_url":"https://api.github.com/users/fractalwrench/following{/other_user}","gists_url":"https://api.github.com/users/fractalwrench/gists{/gist_id}","starred_url":"https://api.github.com/users/fractalwrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractalwrench/subscriptions","organizations_url":"https://api.github.com/users/fractalwrench/orgs","repos_url":"https://api.github.com/users/fractalwrench/repos","events_url":"https://api.github.com/users/fractalwrench/events{/privacy}","received_events_url":"https://api.github.com/users/fractalwrench/received_events","type":"User","site_admin":false},"body":"Installs the plugin as a maven artefact locally, with a high version number to avoid the potential for it to be accidentally picked up from JCenter instead. The local maven repo is also cleared on each run, so the scenarios should fail if the plugin cannot build for any reason.","created_at":"2018-03-21T10:43:21Z","updated_at":"2018-03-23T09:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fec642a5aecabe5ac3fb0d96671b56dd857cfeb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92/commits","review_comments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92/comments","review_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/92/comments","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/statuses/acaed8689070661fb2fe8b52e75e32ffab32c69b","head":{"label":"bugsnag:install-local-artefact","ref":"install-local-artefact","sha":"acaed8689070661fb2fe8b52e75e32ffab32c69b","user":{"login":"bugsnag","id":1058895,"avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"repo":{"id":28617951,"name":"bugsnag-android-gradle-plugin","full_name":"bugsnag/bugsnag-android-gradle-plugin","owner":{"login":"bugsnag","id":1058895,"avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin","description":"Gradle plugin for Bugsnag to automatically upload ProGuard mapping files","fork":false,"url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin","forks_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/forks","keys_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/events","assignees_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/merges","archive_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/deployments","created_at":"2014-12-30T04:44:44Z","updated_at":"2018-03-04T14:29:21Z","pushed_at":"2018-03-23T09:52:04Z","git_url":"git://github.com/bugsnag/bugsnag-android-gradle-plugin.git","ssh_url":"git@github.com:bugsnag/bugsnag-android-gradle-plugin.git","clone_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin.git","svn_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin","homepage":"https://bugsnag.com","size":655,"stargazers_count":20,"watchers_count":20,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":8,"watchers":20,"default_branch":"master"}},"base":{"label":"bugsnag:add-maze-harness","ref":"add-maze-harness","sha":"1effa94fb52304b565cac5146c50a8032845bd08","user":{"login":"bugsnag","id":1058895,"avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"repo":{"id":28617951,"name":"bugsnag-android-gradle-plugin","full_name":"bugsnag/bugsnag-android-gradle-plugin","owner":{"login":"bugsnag","id":1058895,"avatar_url":"https://avatars2.githubusercontent.com/u/1058895?v=4","gravatar_id":"","url":"https://api.github.com/users/bugsnag","html_url":"https://github.com/bugsnag","followers_url":"https://api.github.com/users/bugsnag/followers","following_url":"https://api.github.com/users/bugsnag/following{/other_user}","gists_url":"https://api.github.com/users/bugsnag/gists{/gist_id}","starred_url":"https://api.github.com/users/bugsnag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugsnag/subscriptions","organizations_url":"https://api.github.com/users/bugsnag/orgs","repos_url":"https://api.github.com/users/bugsnag/repos","events_url":"https://api.github.com/users/bugsnag/events{/privacy}","received_events_url":"https://api.github.com/users/bugsnag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin","description":"Gradle plugin for Bugsnag to automatically upload ProGuard mapping files","fork":false,"url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin","forks_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/forks","keys_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/events","assignees_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/merges","archive_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/deployments","created_at":"2014-12-30T04:44:44Z","updated_at":"2018-03-04T14:29:21Z","pushed_at":"2018-03-23T09:52:04Z","git_url":"git://github.com/bugsnag/bugsnag-android-gradle-plugin.git","ssh_url":"git@github.com:bugsnag/bugsnag-android-gradle-plugin.git","clone_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin.git","svn_url":"https://github.com/bugsnag/bugsnag-android-gradle-plugin","homepage":"https://bugsnag.com","size":655,"stargazers_count":20,"watchers_count":20,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":8,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92"},"html":{"href":"https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/92"},"issue":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/92"},"comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin/statuses/acaed8689070661fb2fe8b52e75e32ffab32c69b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28617951,
"name": "bugsnag/bugsnag-android-gradle-plugin",
"url": "https://api.github.com/repos/bugsnag/bugsnag-android-gradle-plugin"
} | {
"id": 11800640,
"login": "fractalwrench",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11800640?",
"url": "https://api.github.com/users/fractalwrench"
} | {
"id": 1058895,
"login": "bugsnag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1058895?",
"url": "https://api.github.com/orgs/bugsnag"
} | 2018-03-23T09:54:08 | 7424367271 | {"actor":{"display_login":"fractalwrench"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/Portus/pulls/comments/168201314","pull_request_review_id":96529055,"id":168201314,"diff_hunk":"@@ -1,5 +1,11 @@\n # See http://www.robotstxt.org/robotstxt.html for documentation on how to use the robots.txt file\n #\n # To ban all spiders from the entire site uncomment the next two lines:\n-# User-agent: *\n-# Disallow: /\n+User-agent: *\n+Disallow: /","path":"public/robots.txt","position":7,"original_position":7,"commit_id":"ca98426c7a3ed38e45069cbe2fac3365999e6e87","original_commit_id":"ca98426c7a3ed38e45069cbe2fac3365999e6e87","user":{"login":"mssola","id":767943,"avatar_url":"https://avatars0.githubusercontent.com/u/767943?v=4","gravatar_id":"","url":"https://api.github.com/users/mssola","html_url":"https://github.com/mssola","followers_url":"https://api.github.com/users/mssola/followers","following_url":"https://api.github.com/users/mssola/following{/other_user}","gists_url":"https://api.github.com/users/mssola/gists{/gist_id}","starred_url":"https://api.github.com/users/mssola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mssola/subscriptions","organizations_url":"https://api.github.com/users/mssola/orgs","repos_url":"https://api.github.com/users/mssola/repos","events_url":"https://api.github.com/users/mssola/events{/privacy}","received_events_url":"https://api.github.com/users/mssola/received_events","type":"User","site_admin":false},"body":"You shouldn't be doing this I fear. It's disallowing *all* paths (so the following lines would be irrelevant then 😉)","created_at":"2018-02-14T15:04:38Z","updated_at":"2018-02-14T15:17:01Z","html_url":"https://github.com/SUSE/Portus/pull/1682#discussion_r168201314","pull_request_url":"https://api.github.com/repos/SUSE/Portus/pulls/1682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/comments/168201314"},"html":{"href":"https://github.com/SUSE/Portus/pull/1682#discussion_r168201314"},"pull_request":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/1682"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/Portus/pulls/1682","id":169109378,"html_url":"https://github.com/SUSE/Portus/pull/1682","diff_url":"https://github.com/SUSE/Portus/pull/1682.diff","patch_url":"https://github.com/SUSE/Portus/pull/1682.patch","issue_url":"https://api.github.com/repos/SUSE/Portus/issues/1682","number":1682,"state":"open","locked":false,"title":"Change the default robots.txt so that Portus cannot be crawled by search engines","user":{"login":"lightlace","id":23658248,"avatar_url":"https://avatars1.githubusercontent.com/u/23658248?v=4","gravatar_id":"","url":"https://api.github.com/users/lightlace","html_url":"https://github.com/lightlace","followers_url":"https://api.github.com/users/lightlace/followers","following_url":"https://api.github.com/users/lightlace/following{/other_user}","gists_url":"https://api.github.com/users/lightlace/gists{/gist_id}","starred_url":"https://api.github.com/users/lightlace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightlace/subscriptions","organizations_url":"https://api.github.com/users/lightlace/orgs","repos_url":"https://api.github.com/users/lightlace/repos","events_url":"https://api.github.com/users/lightlace/events{/privacy}","received_events_url":"https://api.github.com/users/lightlace/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-14T13:27:40Z","updated_at":"2018-02-14T15:17:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e40acf0f18e15e3a9310f9a9da41f8eb2c7cddc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/Portus/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/SUSE/Portus/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/SUSE/Portus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/Portus/issues/1682/comments","statuses_url":"https://api.github.com/repos/SUSE/Portus/statuses/ca98426c7a3ed38e45069cbe2fac3365999e6e87","head":{"label":"lightlace:robots","ref":"robots","sha":"ca98426c7a3ed38e45069cbe2fac3365999e6e87","user":{"login":"lightlace","id":23658248,"avatar_url":"https://avatars1.githubusercontent.com/u/23658248?v=4","gravatar_id":"","url":"https://api.github.com/users/lightlace","html_url":"https://github.com/lightlace","followers_url":"https://api.github.com/users/lightlace/followers","following_url":"https://api.github.com/users/lightlace/following{/other_user}","gists_url":"https://api.github.com/users/lightlace/gists{/gist_id}","starred_url":"https://api.github.com/users/lightlace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightlace/subscriptions","organizations_url":"https://api.github.com/users/lightlace/orgs","repos_url":"https://api.github.com/users/lightlace/repos","events_url":"https://api.github.com/users/lightlace/events{/privacy}","received_events_url":"https://api.github.com/users/lightlace/received_events","type":"User","site_admin":false},"repo":{"id":116011964,"name":"Portus","full_name":"lightlace/Portus","owner":{"login":"lightlace","id":23658248,"avatar_url":"https://avatars1.githubusercontent.com/u/23658248?v=4","gravatar_id":"","url":"https://api.github.com/users/lightlace","html_url":"https://github.com/lightlace","followers_url":"https://api.github.com/users/lightlace/followers","following_url":"https://api.github.com/users/lightlace/following{/other_user}","gists_url":"https://api.github.com/users/lightlace/gists{/gist_id}","starred_url":"https://api.github.com/users/lightlace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightlace/subscriptions","organizations_url":"https://api.github.com/users/lightlace/orgs","repos_url":"https://api.github.com/users/lightlace/repos","events_url":"https://api.github.com/users/lightlace/events{/privacy}","received_events_url":"https://api.github.com/users/lightlace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lightlace/Portus","description":"Authorization service and frontend for Docker registry (v2)","fork":true,"url":"https://api.github.com/repos/lightlace/Portus","forks_url":"https://api.github.com/repos/lightlace/Portus/forks","keys_url":"https://api.github.com/repos/lightlace/Portus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightlace/Portus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightlace/Portus/teams","hooks_url":"https://api.github.com/repos/lightlace/Portus/hooks","issue_events_url":"https://api.github.com/repos/lightlace/Portus/issues/events{/number}","events_url":"https://api.github.com/repos/lightlace/Portus/events","assignees_url":"https://api.github.com/repos/lightlace/Portus/assignees{/user}","branches_url":"https://api.github.com/repos/lightlace/Portus/branches{/branch}","tags_url":"https://api.github.com/repos/lightlace/Portus/tags","blobs_url":"https://api.github.com/repos/lightlace/Portus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightlace/Portus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightlace/Portus/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightlace/Portus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightlace/Portus/statuses/{sha}","languages_url":"https://api.github.com/repos/lightlace/Portus/languages","stargazers_url":"https://api.github.com/repos/lightlace/Portus/stargazers","contributors_url":"https://api.github.com/repos/lightlace/Portus/contributors","subscribers_url":"https://api.github.com/repos/lightlace/Portus/subscribers","subscription_url":"https://api.github.com/repos/lightlace/Portus/subscription","commits_url":"https://api.github.com/repos/lightlace/Portus/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightlace/Portus/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightlace/Portus/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightlace/Portus/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightlace/Portus/contents/{+path}","compare_url":"https://api.github.com/repos/lightlace/Portus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightlace/Portus/merges","archive_url":"https://api.github.com/repos/lightlace/Portus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightlace/Portus/downloads","issues_url":"https://api.github.com/repos/lightlace/Portus/issues{/number}","pulls_url":"https://api.github.com/repos/lightlace/Portus/pulls{/number}","milestones_url":"https://api.github.com/repos/lightlace/Portus/milestones{/number}","notifications_url":"https://api.github.com/repos/lightlace/Portus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightlace/Portus/labels{/name}","releases_url":"https://api.github.com/repos/lightlace/Portus/releases{/id}","deployments_url":"https://api.github.com/repos/lightlace/Portus/deployments","created_at":"2018-01-02T12:15:55Z","updated_at":"2018-01-02T12:15:57Z","pushed_at":"2018-02-14T13:27:14Z","git_url":"git://github.com/lightlace/Portus.git","ssh_url":"git@github.com:lightlace/Portus.git","clone_url":"https://github.com/lightlace/Portus.git","svn_url":"https://github.com/lightlace/Portus","homepage":"http://port.us.org/","size":24254,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"c5b24fa642ff1994c0dd99e95b8e30b8c359b804","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":33866783,"name":"Portus","full_name":"SUSE/Portus","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/Portus","description":"Authorization service and frontend for Docker registry (v2)","fork":false,"url":"https://api.github.com/repos/SUSE/Portus","forks_url":"https://api.github.com/repos/SUSE/Portus/forks","keys_url":"https://api.github.com/repos/SUSE/Portus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/Portus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/Portus/teams","hooks_url":"https://api.github.com/repos/SUSE/Portus/hooks","issue_events_url":"https://api.github.com/repos/SUSE/Portus/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/Portus/events","assignees_url":"https://api.github.com/repos/SUSE/Portus/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/Portus/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/Portus/tags","blobs_url":"https://api.github.com/repos/SUSE/Portus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/Portus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/Portus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/Portus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/Portus/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/Portus/languages","stargazers_url":"https://api.github.com/repos/SUSE/Portus/stargazers","contributors_url":"https://api.github.com/repos/SUSE/Portus/contributors","subscribers_url":"https://api.github.com/repos/SUSE/Portus/subscribers","subscription_url":"https://api.github.com/repos/SUSE/Portus/subscription","commits_url":"https://api.github.com/repos/SUSE/Portus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/Portus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/Portus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/Portus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/Portus/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/Portus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/Portus/merges","archive_url":"https://api.github.com/repos/SUSE/Portus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/Portus/downloads","issues_url":"https://api.github.com/repos/SUSE/Portus/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/Portus/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/Portus/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/Portus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/Portus/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/Portus/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/Portus/deployments","created_at":"2015-04-13T12:18:20Z","updated_at":"2018-02-14T08:29:54Z","pushed_at":"2018-02-14T14:49:26Z","git_url":"git://github.com/SUSE/Portus.git","ssh_url":"git@github.com:SUSE/Portus.git","clone_url":"https://github.com/SUSE/Portus.git","svn_url":"https://github.com/SUSE/Portus","homepage":"http://port.us.org/","size":35657,"stargazers_count":1708,"watchers_count":1708,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":344,"open_issues":158,"watchers":1708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/1682"},"html":{"href":"https://github.com/SUSE/Portus/pull/1682"},"issue":{"href":"https://api.github.com/repos/SUSE/Portus/issues/1682"},"comments":{"href":"https://api.github.com/repos/SUSE/Portus/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/Portus/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/Portus/statuses/ca98426c7a3ed38e45069cbe2fac3365999e6e87"}},"author_association":"CONTRIBUTOR"}} | {
"id": 33866783,
"name": "SUSE/Portus",
"url": "https://api.github.com/repos/SUSE/Portus"
} | {
"id": 767943,
"login": "mssola",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/767943?",
"url": "https://api.github.com/users/mssola"
} | {
"id": 1067733,
"login": "SUSE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1067733?",
"url": "https://api.github.com/orgs/SUSE"
} | 2018-02-14T15:04:38 | 7244486876 | {"actor":{"display_login":"mssola"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/184228950","pull_request_review_id":115382305,"id":184228950,"diff_hunk":"@@ -167,7 +167,7 @@ enum modem_type cellmodem_probe(const char *dev, sbp_zmq_pubsub_ctx_t *pubsub_ct\n return MODEM_TYPE_INVALID;\n }\n piksi_log(LOG_INFO, \"Modem %s: %s\", c->display, r);","path":"package/piksi_system_daemon/piksi_system_daemon/src/cellmodem_probe.c","position":56,"original_position":56,"commit_id":"ef4550a51c97bae588b4ea46084467a540791c56","original_commit_id":"ef4550a51c97bae588b4ea46084467a540791c56","user":{"login":"benjaminaltieri","id":5225320,"avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"body":"Cool yea I saw that, is that in 1.5 too?","created_at":"2018-04-25T22:54:15Z","updated_at":"2018-04-25T22:54:15Z","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/596#discussion_r184228950","pull_request_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/184228950"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/596#discussion_r184228950"},"pull_request":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596"}},"in_reply_to_id":184227528},"pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596","id":184177749,"html_url":"https://github.com/swift-nav/piksi_buildroot/pull/596","diff_url":"https://github.com/swift-nav/piksi_buildroot/pull/596.diff","patch_url":"https://github.com/swift-nav/piksi_buildroot/pull/596.patch","issue_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/596","number":596,"state":"open","locked":false,"title":"[DEVC-590] Add retry loop for initial AT command probe to candidate modem ttys","user":{"login":"benjaminaltieri","id":5225320,"avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"body":"Retries added to initial modem probe attempt in `cellmodem_probe.c`\r\n\r\nAlso removed manual sbp log routine which has been superseded by `sbp_log` from `libpiksi`","created_at":"2018-04-25T22:11:52Z","updated_at":"2018-04-25T22:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f501bc1605312fec197d081bbefee9e37986b02f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596/commits","review_comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596/comments","review_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/596/comments","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/ef4550a51c97bae588b4ea46084467a540791c56","head":{"label":"swift-nav:benaltieri/cellmodem_probe_at_retries","ref":"benaltieri/cellmodem_probe_at_retries","sha":"ef4550a51c97bae588b4ea46084467a540791c56","user":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","owner":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-02-13T14:52:27Z","pushed_at":"2018-04-25T22:27:35Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":5331,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":22,"open_issues":29,"watchers":3,"default_branch":"v1.4.0-release"}},"base":{"label":"swift-nav:v1.5.0-release","ref":"v1.5.0-release","sha":"31966a38180d123cba5a68c5bdce3a78cf989233","user":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","owner":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-02-13T14:52:27Z","pushed_at":"2018-04-25T22:27:35Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":5331,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":22,"open_issues":29,"watchers":3,"default_branch":"v1.4.0-release"}},"_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/596"},"issue":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/596"},"comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/ef4550a51c97bae588b4ea46084467a540791c56"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62339278,
"name": "swift-nav/piksi_buildroot",
"url": "https://api.github.com/repos/swift-nav/piksi_buildroot"
} | {
"id": 5225320,
"login": "benjaminaltieri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5225320?",
"url": "https://api.github.com/users/benjaminaltieri"
} | {
"id": 1069835,
"login": "swift-nav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1069835?",
"url": "https://api.github.com/orgs/swift-nav"
} | 2018-04-25T22:54:15 | 7587973855 | {"actor":{"display_login":"benjaminaltieri"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/242980671","pull_request_review_id":186180869,"id":242980671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjk4MDY3MQ==","diff_hunk":"@@ -0,0 +1,211 @@\n+# Wagtail pages\n+\n+[Wagtail pages](http://docs.wagtail.io/en/v1.13.4/topics/pages.html) are \n+[Django models](https://docs.djangoproject.com/en/1.11/topics/db/models/) \n+that are constructed of \n+[fields](#fields), [StreamFields](#streamfields), and [panels](#panels) \n+that are rendered in a standard way. \n+All CFPB Wagtail pages should inherit from the \n+[`v1.models.base.CFGOVPage` class](https://github.com/cfpb/cfgov-refresh/blob/master/cfgov/v1/models/base.py).\n+\n+!!! note\n+ Before creating a new Wagtail page type \n+ please consider whether one of our existing page types can meet your needs, \n+ whether this is a different type of content than we have anywhere else in the site, \n+ and whether there is maintenance efficiency gained from a new page type.\n+\n+There are types of information defined on a new Wagtail page model: \n+basic [database fields](#fields) (like any Django model), \n+specialized database fields called [StreamFields](#streamfields) that allow for freeform page content, \n+and [editor panels](#panels) that present these fields to content editors. \n+\n+## Fields\n+\n+Database fields in Wagtail pages work exactly the same as in \n+[Django models](https://docs.djangoproject.com/en/1.11/topics/db/models/#fields), \n+and Wagtail pages can use any [Django model field](https://docs.djangoproject.com/en/1.11/ref/models/fields/). \n+\n+For example, our `BrowsePage` \n+[includes a standard Django `BooleanField`](https://github.com/cfpb/cfgov-refresh/blob/master/cfgov/v1/models/browse_page.py) \n+that allows content editors to toggle secondary navigation sibling pages:\n+\n+```python\n+from django.db import models\n+\n+from v1.models.base import CFGOVPage\n+\n+\n+class BrowsePage(CFGOVPage):\n+ secondary_nav_exclude_sibling_pages = models.BooleanField(default=False)\n+```\n+\n+## StreamFields\n+\n+StreamFields are special Django model fields provided by Wagtail for \n+[freeform page content](https://docs.wagtail.io/en/v1.13.4/topics/streamfield.html). \n+They allow a content editor to pick any number number of optional components\n+and place them in any order within their StreamField. \n+In practice this provides the flexibilty of a large \n+[rich text box with the structure of individual components](https://torchbox.com/blog/rich-text-fields-and-faster-horses/).\n+\n+For example, our `LandingPage` page model \n+[includes a `header` StreamField](https://github.com/cfpb/cfgov-refresh/blob/master/cfgov/v1/models/landing_page.py) \n+that can have a hero and/or a text introduction:\n+\n+```python\n+from wagtail.wagtailcore.fields import StreamField\n+\n+from v1.atomic_elements import molecules\n+from v1.models import CFGOVPage\n+\n+\n+class LandingPage(CFGOVPage):\n+\n+ header = StreamField([\n+ ('hero', molecules.Hero()),\n+ ('text_introduction', molecules.TextIntroduction()),\n+ ], blank=True)\n+```\n+\n+The specifics of StreamField block components can be found in \n+[Creating and Editing Wagtail Components](https://cfpb.github.io/cfgov-refresh/editing-components/).\n+\n+## Panels\n+\n+Editor panels define how the page's [fields](#fields) and [StreamFields](#streamfields) will be organized for content editors ","path":"docs/wagtail-pages.md","position":75,"original_position":75,"commit_id":"3443a19eb45e440539271c4e784c52638c3daf61","original_commit_id":"3443a19eb45e440539271c4e784c52638c3daf61","user":{"login":"Scotchester","id":1044670,"node_id":"MDQ6VXNlcjEwNDQ2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1044670?v=4","gravatar_id":"","url":"https://api.github.com/users/Scotchester","html_url":"https://github.com/Scotchester","followers_url":"https://api.github.com/users/Scotchester/followers","following_url":"https://api.github.com/users/Scotchester/following{/other_user}","gists_url":"https://api.github.com/users/Scotchester/gists{/gist_id}","starred_url":"https://api.github.com/users/Scotchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scotchester/subscriptions","organizations_url":"https://api.github.com/users/Scotchester/orgs","repos_url":"https://api.github.com/users/Scotchester/repos","events_url":"https://api.github.com/users/Scotchester/events{/privacy}","received_events_url":"https://api.github.com/users/Scotchester/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nEditor panels define how the page's [fields](#fields) and [StreamFields](#streamfields) will be organized for content editors;\r\n```","created_at":"2018-12-19T16:19:35Z","updated_at":"2018-12-19T16:53:44Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/4707#discussion_r242980671","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/242980671"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/4707#discussion_r242980671"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707","id":239194544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTk0NTQ0","html_url":"https://github.com/cfpb/cfgov-refresh/pull/4707","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/4707.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/4707.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4707","number":4707,"state":"open","locked":false,"title":"Add documentation about Wagtail page models","user":{"login":"willbarton","id":10562538,"node_id":"MDQ6VXNlcjEwNTYyNTM4","avatar_url":"https://avatars0.githubusercontent.com/u/10562538?v=4","gravatar_id":"","url":"https://api.github.com/users/willbarton","html_url":"https://github.com/willbarton","followers_url":"https://api.github.com/users/willbarton/followers","following_url":"https://api.github.com/users/willbarton/following{/other_user}","gists_url":"https://api.github.com/users/willbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/willbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willbarton/subscriptions","organizations_url":"https://api.github.com/users/willbarton/orgs","repos_url":"https://api.github.com/users/willbarton/repos","events_url":"https://api.github.com/users/willbarton/events{/privacy}","received_events_url":"https://api.github.com/users/willbarton/received_events","type":"User","site_admin":false},"body":"This PR adds a document that describes the process of creating a new Wagtail page type via an explanation of the different aspects of a page model: Django model fields, StreamFields, editor panels, parent/child relationships, and templates. It's meant to be an referable overview, with plenty of links to more information. \r\n\r\nMissing from this document are:\r\n\r\n- *When* to create a new page type. This document, because it's an overview of the different pieces of a page, side-steps that issue. Because that's a larger decision for a team to make and not just on the developer who might be creating the page model.\r\n- Links to the the new StreamField docs in ~~#4678~~ and #4706. These will be added.\r\n\r\nThis replaces the old, useless \"Wagtail pages vs Django models\" document, which gave potentially bad, but mostly useless advice to anyone trying to create anything.\r\n\r\nRendered via GitHub: https://github.com/cfpb/cfgov-refresh/blob/wagtail-page-doc/docs/wagtail-pages.md\r\n\r\n## Checklist\r\n\r\n- [x] PR has an informative and human-readable title\r\n- [x] Changes are limited to a single goal (no scope creep)\r\n- [x] Code can be automatically merged (no conflicts)\r\n- [ ] Code follows the standards laid out in the [development playbook](https://github.com/cfpb/development)\r\n- [ ] Passes all existing automated tests\r\n- [ ] Any _change_ in functionality is tested\r\n- [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n- [ ] Placeholder code is flagged / future todos are captured in comments\r\n- [ ] Visually tested in supported browsers and devices (see checklist below :point_down:)\r\n- [x] Project documentation has been updated\r\n- [x] Reviewers requested with the [Reviewers tool](https://help.github.com/articles/requesting-a-pull-request-review/) :arrow_right:\r\n","created_at":"2018-12-17T15:56:44Z","updated_at":"2018-12-19T16:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb867f87cedc79ec94748f6d05629ac6b0a47ee7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cfarm","id":702526,"node_id":"MDQ6VXNlcjcwMjUyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/702526?v=4","gravatar_id":"","url":"https://api.github.com/users/cfarm","html_url":"https://github.com/cfarm","followers_url":"https://api.github.com/users/cfarm/followers","following_url":"https://api.github.com/users/cfarm/following{/other_user}","gists_url":"https://api.github.com/users/cfarm/gists{/gist_id}","starred_url":"https://api.github.com/users/cfarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfarm/subscriptions","organizations_url":"https://api.github.com/users/cfarm/orgs","repos_url":"https://api.github.com/users/cfarm/repos","events_url":"https://api.github.com/users/cfarm/events{/privacy}","received_events_url":"https://api.github.com/users/cfarm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4707/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/3443a19eb45e440539271c4e784c52638c3daf61","head":{"label":"cfpb:wagtail-page-doc","ref":"wagtail-page-doc","sha":"3443a19eb45e440539271c4e784c52638c3daf61","user":{"login":"cfpb","id":1071563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1071563?v=4","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"node_id":"MDEwOlJlcG9zaXRvcnkxODg1MjU2Ng==","name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","private":false,"owner":{"login":"cfpb","id":1071563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1071563?v=4","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project protecting American consumers","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2018-12-19T16:29:10Z","pushed_at":"2018-12-19T16:49:15Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"https://www.consumerfinance.gov/","size":252299,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":65,"watchers":105,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"d33a52cac94b39cf98af4b357247b93b9b0d8559","user":{"login":"cfpb","id":1071563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1071563?v=4","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"node_id":"MDEwOlJlcG9zaXRvcnkxODg1MjU2Ng==","name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","private":false,"owner":{"login":"cfpb","id":1071563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzE1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1071563?v=4","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cfpb/cfgov-refresh","description":"Django project protecting American consumers","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/deployments","created_at":"2014-04-16T19:22:03Z","updated_at":"2018-12-19T16:29:10Z","pushed_at":"2018-12-19T16:49:15Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"https://www.consumerfinance.gov/","size":252299,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":65,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/4707"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4707"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/4707/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/4707/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/3443a19eb45e440539271c4e784c52638c3daf61"}},"author_association":"MEMBER"}} | {
"id": 18852566,
"name": "cfpb/cfgov-refresh",
"url": "https://api.github.com/repos/cfpb/cfgov-refresh"
} | {
"id": 1044670,
"login": "Scotchester",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1044670?",
"url": "https://api.github.com/users/Scotchester"
} | {
"id": 1071563,
"login": "cfpb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1071563?",
"url": "https://api.github.com/orgs/cfpb"
} | 2018-12-19T16:19:35 | 8780286024 | {"actor":{"display_login":"Scotchester"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/comments/242709999","pull_request_review_id":186286320,"id":242709999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjcwOTk5OQ==","diff_hunk":"@@ -0,0 +1,169 @@\n+import {\n+ client,\n+ categoriesService,\n+ ordersService,\n+ stateService,\n+ customersService,\n+ shippingMethodService,\n+ zonesService,\n+ productsService\n+} from './services'\n+\n+const deleteCategories = () => {\n+ client.execute({","path":"lib/clear.js","position":13,"original_position":13,"commit_id":"783939fcf0f42d8726f9f0e982349d84b4453423","original_commit_id":"783939fcf0f42d8726f9f0e982349d84b4453423","user":{"login":"nkuehn","id":4006139,"node_id":"MDQ6VXNlcjQwMDYxMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4006139?v=4","gravatar_id":"","url":"https://api.github.com/users/nkuehn","html_url":"https://github.com/nkuehn","followers_url":"https://api.github.com/users/nkuehn/followers","following_url":"https://api.github.com/users/nkuehn/following{/other_user}","gists_url":"https://api.github.com/users/nkuehn/gists{/gist_id}","starred_url":"https://api.github.com/users/nkuehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkuehn/subscriptions","organizations_url":"https://api.github.com/users/nkuehn/orgs","repos_url":"https://api.github.com/users/nkuehn/repos","events_url":"https://api.github.com/users/nkuehn/events{/privacy}","received_events_url":"https://api.github.com/users/nkuehn/received_events","type":"User","site_admin":false},"body":"client.process(...) is your friend for iterating through everything https://commercetools.github.io/nodejs/sdk/api/sdkClient.html#processrequest-processfn-options \r\n\r\nThe default is 20 items returned, that does not even suffice here. \r\n\r\nAn alternative when deleting is to use GraphQL to fetch _only_ the ids and versions to be able to brute-force delete. You don't really need anything else from the API payload and that way you can safely fetch 500 or 1000 in one call. \r\n","created_at":"2018-12-18T21:21:49Z","updated_at":"2018-12-18T21:34:31Z","html_url":"https://github.com/commercetools/commercetools-sunrise-data/pull/115#discussion_r242709999","pull_request_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/comments/242709999"},"html":{"href":"https://github.com/commercetools/commercetools-sunrise-data/pull/115#discussion_r242709999"},"pull_request":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115","id":239473586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDczNTg2","html_url":"https://github.com/commercetools/commercetools-sunrise-data/pull/115","diff_url":"https://github.com/commercetools/commercetools-sunrise-data/pull/115.diff","patch_url":"https://github.com/commercetools/commercetools-sunrise-data/pull/115.patch","issue_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/115","number":115,"state":"open","locked":false,"title":"Clear","user":{"login":"plaskevich","id":45790929,"node_id":"MDQ6VXNlcjQ1NzkwOTI5","avatar_url":"https://avatars2.githubusercontent.com/u/45790929?v=4","gravatar_id":"","url":"https://api.github.com/users/plaskevich","html_url":"https://github.com/plaskevich","followers_url":"https://api.github.com/users/plaskevich/followers","following_url":"https://api.github.com/users/plaskevich/following{/other_user}","gists_url":"https://api.github.com/users/plaskevich/gists{/gist_id}","starred_url":"https://api.github.com/users/plaskevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaskevich/subscriptions","organizations_url":"https://api.github.com/users/plaskevich/orgs","repos_url":"https://api.github.com/users/plaskevich/repos","events_url":"https://api.github.com/users/plaskevich/events{/privacy}","received_events_url":"https://api.github.com/users/plaskevich/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-18T12:35:41Z","updated_at":"2018-12-18T21:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"764966fe61fcf851caca272461267cc754ec8e34","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sshibani","id":1684498,"node_id":"MDQ6VXNlcjE2ODQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1684498?v=4","gravatar_id":"","url":"https://api.github.com/users/sshibani","html_url":"https://github.com/sshibani","followers_url":"https://api.github.com/users/sshibani/followers","following_url":"https://api.github.com/users/sshibani/following{/other_user}","gists_url":"https://api.github.com/users/sshibani/gists{/gist_id}","starred_url":"https://api.github.com/users/sshibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshibani/subscriptions","organizations_url":"https://api.github.com/users/sshibani/orgs","repos_url":"https://api.github.com/users/sshibani/repos","events_url":"https://api.github.com/users/sshibani/events{/privacy}","received_events_url":"https://api.github.com/users/sshibani/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115/commits","review_comments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115/comments","review_comment_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/115/comments","statuses_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/statuses/783939fcf0f42d8726f9f0e982349d84b4453423","head":{"label":"commercetools:clear","ref":"clear","sha":"783939fcf0f42d8726f9f0e982349d84b4453423","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":41093366,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5MzM2Ng==","name":"commercetools-sunrise-data","full_name":"commercetools/commercetools-sunrise-data","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/commercetools-sunrise-data","description":"The data (product types, categories, products) for Sunrise","fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data","forks_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/deployments","created_at":"2015-08-20T12:02:17Z","updated_at":"2018-11-19T14:44:01Z","pushed_at":"2018-12-18T12:35:42Z","git_url":"git://github.com/commercetools/commercetools-sunrise-data.git","ssh_url":"git@github.com:commercetools/commercetools-sunrise-data.git","clone_url":"https://github.com/commercetools/commercetools-sunrise-data.git","svn_url":"https://github.com/commercetools/commercetools-sunrise-data","homepage":null,"size":12242,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":24,"watchers":6,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"2a488591377ca1cf0de82a7ef708a0d9fd510537","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":41093366,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5MzM2Ng==","name":"commercetools-sunrise-data","full_name":"commercetools/commercetools-sunrise-data","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/commercetools-sunrise-data","description":"The data (product types, categories, products) for Sunrise","fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data","forks_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/deployments","created_at":"2015-08-20T12:02:17Z","updated_at":"2018-11-19T14:44:01Z","pushed_at":"2018-12-18T12:35:42Z","git_url":"git://github.com/commercetools/commercetools-sunrise-data.git","ssh_url":"git@github.com:commercetools/commercetools-sunrise-data.git","clone_url":"https://github.com/commercetools/commercetools-sunrise-data.git","svn_url":"https://github.com/commercetools/commercetools-sunrise-data","homepage":null,"size":12242,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":24,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115"},"html":{"href":"https://github.com/commercetools/commercetools-sunrise-data/pull/115"},"issue":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/115"},"comments":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/commercetools-sunrise-data/statuses/783939fcf0f42d8726f9f0e982349d84b4453423"}},"author_association":"NONE"}} | {
"id": 41093366,
"name": "commercetools/commercetools-sunrise-data",
"url": "https://api.github.com/repos/commercetools/commercetools-sunrise-data"
} | {
"id": 4006139,
"login": "nkuehn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4006139?",
"url": "https://api.github.com/users/nkuehn"
} | {
"id": 1084585,
"login": "commercetools",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1084585?",
"url": "https://api.github.com/orgs/commercetools"
} | 2018-12-18T21:21:49 | 8774991831 | {"actor":{"display_login":"nkuehn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom-languageclient/pulls/comments/168670973","pull_request_review_id":97078260,"id":168670973,"diff_hunk":"@@ -31,7 +31,7 @@ export default (async function downloadFile(\n throw Error('No response body');\n }\n \n- const finalLength = length || parseInt(response.headers.get('Content-Length' || '0'), 10);\n+ const finalLength = length || parseInt(response.headers.get('Content-Length') || '0', 10);","path":"lib/download-file.ts","position":5,"original_position":5,"commit_id":"f42e380940cf878f477f3167fd90bcf995c920c8","original_commit_id":"efd506a5bceae7881b1106d6b331632b2a51072b","user":{"login":"damieng","id":118951,"avatar_url":"https://avatars3.githubusercontent.com/u/118951?v=4","gravatar_id":"","url":"https://api.github.com/users/damieng","html_url":"https://github.com/damieng","followers_url":"https://api.github.com/users/damieng/followers","following_url":"https://api.github.com/users/damieng/following{/other_user}","gists_url":"https://api.github.com/users/damieng/gists{/gist_id}","starred_url":"https://api.github.com/users/damieng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damieng/subscriptions","organizations_url":"https://api.github.com/users/damieng/orgs","repos_url":"https://api.github.com/users/damieng/repos","events_url":"https://api.github.com/users/damieng/events{/privacy}","received_events_url":"https://api.github.com/users/damieng/received_events","type":"User","site_admin":true},"body":"Ha, looks like it. Nice catch.","created_at":"2018-02-16T03:54:09Z","updated_at":"2018-02-16T03:54:09Z","html_url":"https://github.com/atom/atom-languageclient/pull/179#discussion_r168670973","pull_request_url":"https://api.github.com/repos/atom/atom-languageclient/pulls/179","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/comments/168670973"},"html":{"href":"https://github.com/atom/atom-languageclient/pull/179#discussion_r168670973"},"pull_request":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/179"}},"in_reply_to_id":168363310},"pull_request":{"url":"https://api.github.com/repos/atom/atom-languageclient/pulls/179","id":169265495,"html_url":"https://github.com/atom/atom-languageclient/pull/179","diff_url":"https://github.com/atom/atom-languageclient/pull/179.diff","patch_url":"https://github.com/atom/atom-languageclient/pull/179.patch","issue_url":"https://api.github.com/repos/atom/atom-languageclient/issues/179","number":179,"state":"open","locked":false,"title":"Enable strictNullChecks in tsconfig.json","user":{"login":"daviwil","id":79405,"avatar_url":"https://avatars3.githubusercontent.com/u/79405?v=4","gravatar_id":"","url":"https://api.github.com/users/daviwil","html_url":"https://github.com/daviwil","followers_url":"https://api.github.com/users/daviwil/followers","following_url":"https://api.github.com/users/daviwil/following{/other_user}","gists_url":"https://api.github.com/users/daviwil/gists{/gist_id}","starred_url":"https://api.github.com/users/daviwil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviwil/subscriptions","organizations_url":"https://api.github.com/users/daviwil/orgs","repos_url":"https://api.github.com/users/daviwil/repos","events_url":"https://api.github.com/users/daviwil/events{/privacy}","received_events_url":"https://api.github.com/users/daviwil/received_events","type":"User","site_admin":true},"body":"Please let me know if there are any places where these changes are incorrect!\r\n\r\n/cc @laughedelic ","created_at":"2018-02-15T01:21:10Z","updated_at":"2018-02-16T03:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"991fd5aaf3187823d82e65a42cae836a4e49513b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"damieng","id":118951,"avatar_url":"https://avatars3.githubusercontent.com/u/118951?v=4","gravatar_id":"","url":"https://api.github.com/users/damieng","html_url":"https://github.com/damieng","followers_url":"https://api.github.com/users/damieng/followers","following_url":"https://api.github.com/users/damieng/following{/other_user}","gists_url":"https://api.github.com/users/damieng/gists{/gist_id}","starred_url":"https://api.github.com/users/damieng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damieng/subscriptions","organizations_url":"https://api.github.com/users/damieng/orgs","repos_url":"https://api.github.com/users/damieng/repos","events_url":"https://api.github.com/users/damieng/events{/privacy}","received_events_url":"https://api.github.com/users/damieng/received_events","type":"User","site_admin":true}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom-languageclient/pulls/179/commits","review_comments_url":"https://api.github.com/repos/atom/atom-languageclient/pulls/179/comments","review_comment_url":"https://api.github.com/repos/atom/atom-languageclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom-languageclient/issues/179/comments","statuses_url":"https://api.github.com/repos/atom/atom-languageclient/statuses/f42e380940cf878f477f3167fd90bcf995c920c8","head":{"label":"atom:dw-strict-null-checks","ref":"dw-strict-null-checks","sha":"f42e380940cf878f477f3167fd90bcf995c920c8","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":83468354,"name":"atom-languageclient","full_name":"atom/atom-languageclient","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-languageclient","description":"Language Server Protocol support for Atom (the basis of Atom-IDE)","fork":false,"url":"https://api.github.com/repos/atom/atom-languageclient","forks_url":"https://api.github.com/repos/atom/atom-languageclient/forks","keys_url":"https://api.github.com/repos/atom/atom-languageclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-languageclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-languageclient/teams","hooks_url":"https://api.github.com/repos/atom/atom-languageclient/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-languageclient/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-languageclient/events","assignees_url":"https://api.github.com/repos/atom/atom-languageclient/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-languageclient/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-languageclient/tags","blobs_url":"https://api.github.com/repos/atom/atom-languageclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-languageclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-languageclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-languageclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-languageclient/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-languageclient/languages","stargazers_url":"https://api.github.com/repos/atom/atom-languageclient/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-languageclient/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-languageclient/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-languageclient/subscription","commits_url":"https://api.github.com/repos/atom/atom-languageclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-languageclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-languageclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-languageclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom-languageclient/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-languageclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-languageclient/merges","archive_url":"https://api.github.com/repos/atom/atom-languageclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-languageclient/downloads","issues_url":"https://api.github.com/repos/atom/atom-languageclient/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-languageclient/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-languageclient/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-languageclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-languageclient/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-languageclient/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom-languageclient/deployments","created_at":"2017-02-28T18:58:38Z","updated_at":"2018-02-14T22:08:50Z","pushed_at":"2018-02-15T19:08:54Z","git_url":"git://github.com/atom/atom-languageclient.git","ssh_url":"git@github.com:atom/atom-languageclient.git","clone_url":"https://github.com/atom/atom-languageclient.git","svn_url":"https://github.com/atom/atom-languageclient","homepage":"https://ide.atom.io/","size":1093,"stargazers_count":230,"watchers_count":230,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":44,"open_issues":14,"watchers":230,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"d8be6eb1e4161865445c5a9f985cf6aaa1332151","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":83468354,"name":"atom-languageclient","full_name":"atom/atom-languageclient","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-languageclient","description":"Language Server Protocol support for Atom (the basis of Atom-IDE)","fork":false,"url":"https://api.github.com/repos/atom/atom-languageclient","forks_url":"https://api.github.com/repos/atom/atom-languageclient/forks","keys_url":"https://api.github.com/repos/atom/atom-languageclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-languageclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-languageclient/teams","hooks_url":"https://api.github.com/repos/atom/atom-languageclient/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-languageclient/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-languageclient/events","assignees_url":"https://api.github.com/repos/atom/atom-languageclient/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-languageclient/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-languageclient/tags","blobs_url":"https://api.github.com/repos/atom/atom-languageclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-languageclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-languageclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-languageclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-languageclient/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-languageclient/languages","stargazers_url":"https://api.github.com/repos/atom/atom-languageclient/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-languageclient/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-languageclient/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-languageclient/subscription","commits_url":"https://api.github.com/repos/atom/atom-languageclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-languageclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-languageclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-languageclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom-languageclient/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-languageclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-languageclient/merges","archive_url":"https://api.github.com/repos/atom/atom-languageclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-languageclient/downloads","issues_url":"https://api.github.com/repos/atom/atom-languageclient/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-languageclient/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-languageclient/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-languageclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-languageclient/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-languageclient/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom-languageclient/deployments","created_at":"2017-02-28T18:58:38Z","updated_at":"2018-02-14T22:08:50Z","pushed_at":"2018-02-15T19:08:54Z","git_url":"git://github.com/atom/atom-languageclient.git","ssh_url":"git@github.com:atom/atom-languageclient.git","clone_url":"https://github.com/atom/atom-languageclient.git","svn_url":"https://github.com/atom/atom-languageclient","homepage":"https://ide.atom.io/","size":1093,"stargazers_count":230,"watchers_count":230,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":44,"open_issues":14,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/179"},"html":{"href":"https://github.com/atom/atom-languageclient/pull/179"},"issue":{"href":"https://api.github.com/repos/atom/atom-languageclient/issues/179"},"comments":{"href":"https://api.github.com/repos/atom/atom-languageclient/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom-languageclient/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom-languageclient/statuses/f42e380940cf878f477f3167fd90bcf995c920c8"}},"author_association":"OWNER"}} | {
"id": 83468354,
"name": "atom/atom-languageclient",
"url": "https://api.github.com/repos/atom/atom-languageclient"
} | {
"id": 118951,
"login": "damieng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/118951?",
"url": "https://api.github.com/users/damieng"
} | {
"id": 1089146,
"login": "atom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1089146?",
"url": "https://api.github.com/orgs/atom"
} | 2018-02-16T03:54:09 | 7253241571 | {"actor":{"display_login":"damieng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/comments/198332731","pull_request_review_id":132246226,"id":198332731,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMzMjczMQ==","diff_hunk":"@@ -0,0 +1,56 @@\n+<!-- productType attribute defines type of product to load -->\n+<product-page productType=\"finite-fault\">\n+\n+ <!-- container with header attribute is added before attribution -->\n+ <ng-container header>\n+ <h2>\n+ <abbr title=\"Finite Fault\">\n+ Finite Fault\n+ </abbr>\n+ </h2>\n+ </ng-container>\n+\n+ <div *ngIf=\"eventService.product$ | async as product\">\n+\n+ <h2>Result</h2>","path":"src/app/finite-fault/finite-fault/finite-fault.component.html","position":15,"original_position":15,"commit_id":"6ae36ea2a90e452fb1b5186722b4002cb1a02e9d","original_commit_id":"6ae36ea2a90e452fb1b5186722b4002cb1a02e9d","user":{"login":"ehunter-usgs","id":1932750,"node_id":"MDQ6VXNlcjE5MzI3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1932750?v=4","gravatar_id":"","url":"https://api.github.com/users/ehunter-usgs","html_url":"https://github.com/ehunter-usgs","followers_url":"https://api.github.com/users/ehunter-usgs/followers","following_url":"https://api.github.com/users/ehunter-usgs/following{/other_user}","gists_url":"https://api.github.com/users/ehunter-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ehunter-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehunter-usgs/subscriptions","organizations_url":"https://api.github.com/users/ehunter-usgs/orgs","repos_url":"https://api.github.com/users/ehunter-usgs/repos","events_url":"https://api.github.com/users/ehunter-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/ehunter-usgs/received_events","type":"User","site_admin":false},"body":"We have the `shared-text-product` that allows you to read in text-like products. You can use this component to display the finite-fault html. The html is referenced using the `product.properties.eventsourcecode + '.html'` and is found in `product.contents` (you don't need to know that last part, but if you want to see the path to the html file that's where you find it).\r\n\r\nfinite-fault.component.html should look something like this...\r\n```\r\n <div *ngIf=\"eventService.product$ | async as product\">\r\n <shared-text-product\r\n [contentPath]=\"product?.properties?.eventsourcecode + '.html'\"\r\n [product]='product'>\r\n </shared-text-product>\r\n </div>\r\n```","created_at":"2018-06-27T00:04:52Z","updated_at":"2018-06-27T00:04:57Z","html_url":"https://github.com/usgs/earthquake-eventpages/pull/1052#discussion_r198332731","pull_request_url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/comments/198332731"},"html":{"href":"https://github.com/usgs/earthquake-eventpages/pull/1052#discussion_r198332731"},"pull_request":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052"}}},"pull_request":{"url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052","id":197434476,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDM0NDc2","html_url":"https://github.com/usgs/earthquake-eventpages/pull/1052","diff_url":"https://github.com/usgs/earthquake-eventpages/pull/1052.diff","patch_url":"https://github.com/usgs/earthquake-eventpages/pull/1052.patch","issue_url":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/1052","number":1052,"state":"open","locked":false,"title":"created finite-fault module skeleton and implemented sharedProductCon…","user":{"login":"cswilson-usgs","id":40367133,"node_id":"MDQ6VXNlcjQwMzY3MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/40367133?v=4","gravatar_id":"","url":"https://api.github.com/users/cswilson-usgs","html_url":"https://github.com/cswilson-usgs","followers_url":"https://api.github.com/users/cswilson-usgs/followers","following_url":"https://api.github.com/users/cswilson-usgs/following{/other_user}","gists_url":"https://api.github.com/users/cswilson-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/cswilson-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cswilson-usgs/subscriptions","organizations_url":"https://api.github.com/users/cswilson-usgs/orgs","repos_url":"https://api.github.com/users/cswilson-usgs/repos","events_url":"https://api.github.com/users/cswilson-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/cswilson-usgs/received_events","type":"User","site_admin":false},"body":"Fixes #1039 ","created_at":"2018-06-26T14:03:23Z","updated_at":"2018-06-27T00:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"882fb11ee51956272ff2522ff69895aec1fe7273","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":339528014,"node_id":"MDU6TGFiZWwzMzk1MjgwMTQ=","url":"https://api.github.com/repos/usgs/earthquake-eventpages/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052/commits","review_comments_url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052/comments","review_comment_url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/1052/comments","statuses_url":"https://api.github.com/repos/usgs/earthquake-eventpages/statuses/6ae36ea2a90e452fb1b5186722b4002cb1a02e9d","head":{"label":"cswilson-usgs:issue-1039","ref":"issue-1039","sha":"6ae36ea2a90e452fb1b5186722b4002cb1a02e9d","user":{"login":"cswilson-usgs","id":40367133,"node_id":"MDQ6VXNlcjQwMzY3MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/40367133?v=4","gravatar_id":"","url":"https://api.github.com/users/cswilson-usgs","html_url":"https://github.com/cswilson-usgs","followers_url":"https://api.github.com/users/cswilson-usgs/followers","following_url":"https://api.github.com/users/cswilson-usgs/following{/other_user}","gists_url":"https://api.github.com/users/cswilson-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/cswilson-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cswilson-usgs/subscriptions","organizations_url":"https://api.github.com/users/cswilson-usgs/orgs","repos_url":"https://api.github.com/users/cswilson-usgs/repos","events_url":"https://api.github.com/users/cswilson-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/cswilson-usgs/received_events","type":"User","site_admin":false},"repo":{"id":137803386,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4MDMzODY=","name":"earthquake-eventpages","full_name":"cswilson-usgs/earthquake-eventpages","owner":{"login":"cswilson-usgs","id":40367133,"node_id":"MDQ6VXNlcjQwMzY3MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/40367133?v=4","gravatar_id":"","url":"https://api.github.com/users/cswilson-usgs","html_url":"https://github.com/cswilson-usgs","followers_url":"https://api.github.com/users/cswilson-usgs/followers","following_url":"https://api.github.com/users/cswilson-usgs/following{/other_user}","gists_url":"https://api.github.com/users/cswilson-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/cswilson-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cswilson-usgs/subscriptions","organizations_url":"https://api.github.com/users/cswilson-usgs/orgs","repos_url":"https://api.github.com/users/cswilson-usgs/repos","events_url":"https://api.github.com/users/cswilson-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/cswilson-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cswilson-usgs/earthquake-eventpages","description":"Web application for displaying earthquake event pages.","fork":true,"url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages","forks_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/forks","keys_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/teams","hooks_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/hooks","issue_events_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/issues/events{/number}","events_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/events","assignees_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/assignees{/user}","branches_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/branches{/branch}","tags_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/tags","blobs_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/git/refs{/sha}","trees_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/statuses/{sha}","languages_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/languages","stargazers_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/stargazers","contributors_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/contributors","subscribers_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/subscribers","subscription_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/subscription","commits_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/commits{/sha}","git_commits_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/git/commits{/sha}","comments_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/comments{/number}","issue_comment_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/issues/comments{/number}","contents_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/contents/{+path}","compare_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/merges","archive_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/downloads","issues_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/issues{/number}","pulls_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/pulls{/number}","milestones_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/milestones{/number}","notifications_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/labels{/name}","releases_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/releases{/id}","deployments_url":"https://api.github.com/repos/cswilson-usgs/earthquake-eventpages/deployments","created_at":"2018-06-18T20:32:30Z","updated_at":"2018-06-26T22:21:30Z","pushed_at":"2018-06-26T22:21:28Z","git_url":"git://github.com/cswilson-usgs/earthquake-eventpages.git","ssh_url":"git@github.com:cswilson-usgs/earthquake-eventpages.git","clone_url":"https://github.com/cswilson-usgs/earthquake-eventpages.git","svn_url":"https://github.com/cswilson-usgs/earthquake-eventpages","homepage":null,"size":18797,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usgs:master","ref":"master","sha":"0b2f6fc0ae34b3fa313caa55d293e2dbdc517760","user":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"repo":{"id":13967335,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2NzMzNQ==","name":"earthquake-eventpages","full_name":"usgs/earthquake-eventpages","owner":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usgs/earthquake-eventpages","description":"Web application for displaying earthquake event pages.","fork":false,"url":"https://api.github.com/repos/usgs/earthquake-eventpages","forks_url":"https://api.github.com/repos/usgs/earthquake-eventpages/forks","keys_url":"https://api.github.com/repos/usgs/earthquake-eventpages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usgs/earthquake-eventpages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usgs/earthquake-eventpages/teams","hooks_url":"https://api.github.com/repos/usgs/earthquake-eventpages/hooks","issue_events_url":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/events{/number}","events_url":"https://api.github.com/repos/usgs/earthquake-eventpages/events","assignees_url":"https://api.github.com/repos/usgs/earthquake-eventpages/assignees{/user}","branches_url":"https://api.github.com/repos/usgs/earthquake-eventpages/branches{/branch}","tags_url":"https://api.github.com/repos/usgs/earthquake-eventpages/tags","blobs_url":"https://api.github.com/repos/usgs/earthquake-eventpages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usgs/earthquake-eventpages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usgs/earthquake-eventpages/git/refs{/sha}","trees_url":"https://api.github.com/repos/usgs/earthquake-eventpages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usgs/earthquake-eventpages/statuses/{sha}","languages_url":"https://api.github.com/repos/usgs/earthquake-eventpages/languages","stargazers_url":"https://api.github.com/repos/usgs/earthquake-eventpages/stargazers","contributors_url":"https://api.github.com/repos/usgs/earthquake-eventpages/contributors","subscribers_url":"https://api.github.com/repos/usgs/earthquake-eventpages/subscribers","subscription_url":"https://api.github.com/repos/usgs/earthquake-eventpages/subscription","commits_url":"https://api.github.com/repos/usgs/earthquake-eventpages/commits{/sha}","git_commits_url":"https://api.github.com/repos/usgs/earthquake-eventpages/git/commits{/sha}","comments_url":"https://api.github.com/repos/usgs/earthquake-eventpages/comments{/number}","issue_comment_url":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/comments{/number}","contents_url":"https://api.github.com/repos/usgs/earthquake-eventpages/contents/{+path}","compare_url":"https://api.github.com/repos/usgs/earthquake-eventpages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usgs/earthquake-eventpages/merges","archive_url":"https://api.github.com/repos/usgs/earthquake-eventpages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usgs/earthquake-eventpages/downloads","issues_url":"https://api.github.com/repos/usgs/earthquake-eventpages/issues{/number}","pulls_url":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls{/number}","milestones_url":"https://api.github.com/repos/usgs/earthquake-eventpages/milestones{/number}","notifications_url":"https://api.github.com/repos/usgs/earthquake-eventpages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usgs/earthquake-eventpages/labels{/name}","releases_url":"https://api.github.com/repos/usgs/earthquake-eventpages/releases{/id}","deployments_url":"https://api.github.com/repos/usgs/earthquake-eventpages/deployments","created_at":"2013-10-29T20:12:22Z","updated_at":"2018-06-26T21:36:27Z","pushed_at":"2018-06-26T22:18:58Z","git_url":"git://github.com/usgs/earthquake-eventpages.git","ssh_url":"git@github.com:usgs/earthquake-eventpages.git","clone_url":"https://github.com/usgs/earthquake-eventpages.git","svn_url":"https://github.com/usgs/earthquake-eventpages","homepage":null,"size":18783,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":41,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052"},"html":{"href":"https://github.com/usgs/earthquake-eventpages/pull/1052"},"issue":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/1052"},"comments":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/issues/1052/comments"},"review_comments":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052/comments"},"review_comment":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/pulls/1052/commits"},"statuses":{"href":"https://api.github.com/repos/usgs/earthquake-eventpages/statuses/6ae36ea2a90e452fb1b5186722b4002cb1a02e9d"}},"author_association":"NONE"}} | {
"id": 13967335,
"name": "usgs/earthquake-eventpages",
"url": "https://api.github.com/repos/usgs/earthquake-eventpages"
} | {
"id": 1932750,
"login": "ehunter-usgs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1932750?",
"url": "https://api.github.com/users/ehunter-usgs"
} | {
"id": 1091434,
"login": "usgs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1091434?",
"url": "https://api.github.com/orgs/usgs"
} | 2018-06-27T00:04:52 | 7882678483 | {"actor":{"display_login":"ehunter-usgs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/conformal/spectrwm/pulls/comments/226652221","pull_request_review_id":166530078,"id":226652221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjY1MjIyMQ==","diff_hunk":"@@ -5504,7 +5504,7 @@ stack_master(struct workspace *ws, struct swm_geometry *g, int rot, bool flip)\n \t\t/* Window coordinates exclude frame. */\n \n \t\tif (winno > 1 || !disable_border ||\n-\t\t (bar_enabled && ws->bar_enabled)) {\n+\t\t (bar_enabled && ws->bar_enabled && winno > 1)) {","path":"spectrwm.c","position":5,"original_position":5,"commit_id":"f2cd18c89e3df584aa9c765bef8401da1d2cdfc1","original_commit_id":"f2cd18c89e3df584aa9c765bef8401da1d2cdfc1","user":{"login":"bket","id":1864835,"node_id":"MDQ6VXNlcjE4NjQ4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1864835?v=4","gravatar_id":"","url":"https://api.github.com/users/bket","html_url":"https://github.com/bket","followers_url":"https://api.github.com/users/bket/followers","following_url":"https://api.github.com/users/bket/following{/other_user}","gists_url":"https://api.github.com/users/bket/gists{/gist_id}","starred_url":"https://api.github.com/users/bket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bket/subscriptions","organizations_url":"https://api.github.com/users/bket/orgs","repos_url":"https://api.github.com/users/bket/repos","events_url":"https://api.github.com/users/bket/events{/privacy}","received_events_url":"https://api.github.com/users/bket/received_events","type":"User","site_admin":false},"body":"Yes, that is even better. Thank you. You can find the updated proposal at bket@479445a.","created_at":"2018-10-19T13:45:59Z","updated_at":"2018-10-19T13:45:59Z","html_url":"https://github.com/conformal/spectrwm/pull/221#discussion_r226652221","pull_request_url":"https://api.github.com/repos/conformal/spectrwm/pulls/221","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/comments/226652221"},"html":{"href":"https://github.com/conformal/spectrwm/pull/221#discussion_r226652221"},"pull_request":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/221"}},"in_reply_to_id":226558541},"pull_request":{"url":"https://api.github.com/repos/conformal/spectrwm/pulls/221","id":224003924,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDAzOTI0","html_url":"https://github.com/conformal/spectrwm/pull/221","diff_url":"https://github.com/conformal/spectrwm/pull/221.diff","patch_url":"https://github.com/conformal/spectrwm/pull/221.patch","issue_url":"https://api.github.com/repos/conformal/spectrwm/issues/221","number":221,"state":"closed","locked":false,"title":"Remove window border when there is only one window in workspace.","user":{"login":"bket","id":1864835,"node_id":"MDQ6VXNlcjE4NjQ4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1864835?v=4","gravatar_id":"","url":"https://api.github.com/users/bket","html_url":"https://github.com/bket","followers_url":"https://api.github.com/users/bket/followers","following_url":"https://api.github.com/users/bket/following{/other_user}","gists_url":"https://api.github.com/users/bket/gists{/gist_id}","starred_url":"https://api.github.com/users/bket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bket/subscriptions","organizations_url":"https://api.github.com/users/bket/orgs","repos_url":"https://api.github.com/users/bket/repos","events_url":"https://api.github.com/users/bket/events{/privacy}","received_events_url":"https://api.github.com/users/bket/received_events","type":"User","site_admin":false},"body":"I would expect that no border is shown if there is only window in a workspace. This is the case when disable_border is set, and the bar is disabled.\r\nReading the manpage closely I concluded that my expectation is wrong:\r\n\r\n```\r\ndisable_border\r\n Remove border when bar is disabled and there is only one window on the region.\"\r\n```\r\n\r\nI was wondering if it makes sense to change behaviour of `disable_border` to:\r\n\r\n```\r\nRemove border when bar is disabled OR there is only one window on the region.\r\n```","created_at":"2018-10-18T15:36:13Z","updated_at":"2018-10-19T13:45:59Z","closed_at":"2018-10-18T17:24:07Z","merged_at":null,"merge_commit_sha":"429b8d21e4190fd2bf00d615bb37bef89f94649b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conformal/spectrwm/pulls/221/commits","review_comments_url":"https://api.github.com/repos/conformal/spectrwm/pulls/221/comments","review_comment_url":"https://api.github.com/repos/conformal/spectrwm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conformal/spectrwm/issues/221/comments","statuses_url":"https://api.github.com/repos/conformal/spectrwm/statuses/f2cd18c89e3df584aa9c765bef8401da1d2cdfc1","head":{"label":"bket:no_border","ref":"no_border","sha":"f2cd18c89e3df584aa9c765bef8401da1d2cdfc1","user":{"login":"bket","id":1864835,"node_id":"MDQ6VXNlcjE4NjQ4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1864835?v=4","gravatar_id":"","url":"https://api.github.com/users/bket","html_url":"https://github.com/bket","followers_url":"https://api.github.com/users/bket/followers","following_url":"https://api.github.com/users/bket/following{/other_user}","gists_url":"https://api.github.com/users/bket/gists{/gist_id}","starred_url":"https://api.github.com/users/bket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bket/subscriptions","organizations_url":"https://api.github.com/users/bket/orgs","repos_url":"https://api.github.com/users/bket/repos","events_url":"https://api.github.com/users/bket/events{/privacy}","received_events_url":"https://api.github.com/users/bket/received_events","type":"User","site_admin":false},"repo":{"id":152393062,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIzOTMwNjI=","name":"spectrwm","full_name":"bket/spectrwm","private":false,"owner":{"login":"bket","id":1864835,"node_id":"MDQ6VXNlcjE4NjQ4MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1864835?v=4","gravatar_id":"","url":"https://api.github.com/users/bket","html_url":"https://github.com/bket","followers_url":"https://api.github.com/users/bket/followers","following_url":"https://api.github.com/users/bket/following{/other_user}","gists_url":"https://api.github.com/users/bket/gists{/gist_id}","starred_url":"https://api.github.com/users/bket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bket/subscriptions","organizations_url":"https://api.github.com/users/bket/orgs","repos_url":"https://api.github.com/users/bket/repos","events_url":"https://api.github.com/users/bket/events{/privacy}","received_events_url":"https://api.github.com/users/bket/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bket/spectrwm","description":"A small dynamic tiling window manager for X11.","fork":true,"url":"https://api.github.com/repos/bket/spectrwm","forks_url":"https://api.github.com/repos/bket/spectrwm/forks","keys_url":"https://api.github.com/repos/bket/spectrwm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bket/spectrwm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bket/spectrwm/teams","hooks_url":"https://api.github.com/repos/bket/spectrwm/hooks","issue_events_url":"https://api.github.com/repos/bket/spectrwm/issues/events{/number}","events_url":"https://api.github.com/repos/bket/spectrwm/events","assignees_url":"https://api.github.com/repos/bket/spectrwm/assignees{/user}","branches_url":"https://api.github.com/repos/bket/spectrwm/branches{/branch}","tags_url":"https://api.github.com/repos/bket/spectrwm/tags","blobs_url":"https://api.github.com/repos/bket/spectrwm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bket/spectrwm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bket/spectrwm/git/refs{/sha}","trees_url":"https://api.github.com/repos/bket/spectrwm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bket/spectrwm/statuses/{sha}","languages_url":"https://api.github.com/repos/bket/spectrwm/languages","stargazers_url":"https://api.github.com/repos/bket/spectrwm/stargazers","contributors_url":"https://api.github.com/repos/bket/spectrwm/contributors","subscribers_url":"https://api.github.com/repos/bket/spectrwm/subscribers","subscription_url":"https://api.github.com/repos/bket/spectrwm/subscription","commits_url":"https://api.github.com/repos/bket/spectrwm/commits{/sha}","git_commits_url":"https://api.github.com/repos/bket/spectrwm/git/commits{/sha}","comments_url":"https://api.github.com/repos/bket/spectrwm/comments{/number}","issue_comment_url":"https://api.github.com/repos/bket/spectrwm/issues/comments{/number}","contents_url":"https://api.github.com/repos/bket/spectrwm/contents/{+path}","compare_url":"https://api.github.com/repos/bket/spectrwm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bket/spectrwm/merges","archive_url":"https://api.github.com/repos/bket/spectrwm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bket/spectrwm/downloads","issues_url":"https://api.github.com/repos/bket/spectrwm/issues{/number}","pulls_url":"https://api.github.com/repos/bket/spectrwm/pulls{/number}","milestones_url":"https://api.github.com/repos/bket/spectrwm/milestones{/number}","notifications_url":"https://api.github.com/repos/bket/spectrwm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bket/spectrwm/labels{/name}","releases_url":"https://api.github.com/repos/bket/spectrwm/releases{/id}","deployments_url":"https://api.github.com/repos/bket/spectrwm/deployments","created_at":"2018-10-10T08:56:00Z","updated_at":"2018-10-10T08:56:03Z","pushed_at":"2018-10-19T13:34:25Z","git_url":"git://github.com/bket/spectrwm.git","ssh_url":"git@github.com:bket/spectrwm.git","clone_url":"https://github.com/bket/spectrwm.git","svn_url":"https://github.com/bket/spectrwm","homepage":null,"size":5617,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conformal:master","ref":"master","sha":"b365987d3871d587663ad9204880df0504b31f72","user":{"login":"conformal","id":1123608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjM2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1123608?v=4","gravatar_id":"","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"repo":{"id":10093477,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA5MzQ3Nw==","name":"spectrwm","full_name":"conformal/spectrwm","private":false,"owner":{"login":"conformal","id":1123608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjM2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1123608?v=4","gravatar_id":"","url":"https://api.github.com/users/conformal","html_url":"https://github.com/conformal","followers_url":"https://api.github.com/users/conformal/followers","following_url":"https://api.github.com/users/conformal/following{/other_user}","gists_url":"https://api.github.com/users/conformal/gists{/gist_id}","starred_url":"https://api.github.com/users/conformal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conformal/subscriptions","organizations_url":"https://api.github.com/users/conformal/orgs","repos_url":"https://api.github.com/users/conformal/repos","events_url":"https://api.github.com/users/conformal/events{/privacy}","received_events_url":"https://api.github.com/users/conformal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conformal/spectrwm","description":"A small dynamic tiling window manager for X11.","fork":false,"url":"https://api.github.com/repos/conformal/spectrwm","forks_url":"https://api.github.com/repos/conformal/spectrwm/forks","keys_url":"https://api.github.com/repos/conformal/spectrwm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conformal/spectrwm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conformal/spectrwm/teams","hooks_url":"https://api.github.com/repos/conformal/spectrwm/hooks","issue_events_url":"https://api.github.com/repos/conformal/spectrwm/issues/events{/number}","events_url":"https://api.github.com/repos/conformal/spectrwm/events","assignees_url":"https://api.github.com/repos/conformal/spectrwm/assignees{/user}","branches_url":"https://api.github.com/repos/conformal/spectrwm/branches{/branch}","tags_url":"https://api.github.com/repos/conformal/spectrwm/tags","blobs_url":"https://api.github.com/repos/conformal/spectrwm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conformal/spectrwm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conformal/spectrwm/git/refs{/sha}","trees_url":"https://api.github.com/repos/conformal/spectrwm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conformal/spectrwm/statuses/{sha}","languages_url":"https://api.github.com/repos/conformal/spectrwm/languages","stargazers_url":"https://api.github.com/repos/conformal/spectrwm/stargazers","contributors_url":"https://api.github.com/repos/conformal/spectrwm/contributors","subscribers_url":"https://api.github.com/repos/conformal/spectrwm/subscribers","subscription_url":"https://api.github.com/repos/conformal/spectrwm/subscription","commits_url":"https://api.github.com/repos/conformal/spectrwm/commits{/sha}","git_commits_url":"https://api.github.com/repos/conformal/spectrwm/git/commits{/sha}","comments_url":"https://api.github.com/repos/conformal/spectrwm/comments{/number}","issue_comment_url":"https://api.github.com/repos/conformal/spectrwm/issues/comments{/number}","contents_url":"https://api.github.com/repos/conformal/spectrwm/contents/{+path}","compare_url":"https://api.github.com/repos/conformal/spectrwm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conformal/spectrwm/merges","archive_url":"https://api.github.com/repos/conformal/spectrwm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conformal/spectrwm/downloads","issues_url":"https://api.github.com/repos/conformal/spectrwm/issues{/number}","pulls_url":"https://api.github.com/repos/conformal/spectrwm/pulls{/number}","milestones_url":"https://api.github.com/repos/conformal/spectrwm/milestones{/number}","notifications_url":"https://api.github.com/repos/conformal/spectrwm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conformal/spectrwm/labels{/name}","releases_url":"https://api.github.com/repos/conformal/spectrwm/releases{/id}","deployments_url":"https://api.github.com/repos/conformal/spectrwm/deployments","created_at":"2013-05-16T04:09:16Z","updated_at":"2018-10-06T17:37:04Z","pushed_at":"2018-10-18T15:36:14Z","git_url":"git://github.com/conformal/spectrwm.git","ssh_url":"git@github.com:conformal/spectrwm.git","clone_url":"https://github.com/conformal/spectrwm.git","svn_url":"https://github.com/conformal/spectrwm","homepage":null,"size":5662,"stargazers_count":395,"watchers_count":395,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":51,"open_issues":46,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/221"},"html":{"href":"https://github.com/conformal/spectrwm/pull/221"},"issue":{"href":"https://api.github.com/repos/conformal/spectrwm/issues/221"},"comments":{"href":"https://api.github.com/repos/conformal/spectrwm/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conformal/spectrwm/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/conformal/spectrwm/statuses/f2cd18c89e3df584aa9c765bef8401da1d2cdfc1"}},"author_association":"NONE"}} | {
"id": 10093477,
"name": "conformal/spectrwm",
"url": "https://api.github.com/repos/conformal/spectrwm"
} | {
"id": 1864835,
"login": "bket",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1864835?",
"url": "https://api.github.com/users/bket"
} | {
"id": 1123608,
"login": "conformal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1123608?",
"url": "https://api.github.com/orgs/conformal"
} | 2018-10-19T13:45:59 | 8449178949 | {"actor":{"display_login":"bket"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments/169707388","pull_request_review_id":98277861,"id":169707388,"diff_hunk":"@@ -144,4 +144,17 @@ describe('DialogDataService test', () => {\n const expectedSortedResult = [[5, 'C'], [0, 'B'], [2, 'A']];\n expect(testSortedDescription).toEqual(expectedSortedResult);\n });\n+ it('should allow a numeric Description field to be sorted in a dropdown', () => {\n+ const testDropDownDescription = {\n+ values: [\n+ [0, '0'],","path":"src/dialog-user/services/dialogData.spec.ts","position":7,"original_position":7,"commit_id":"09b0cc28ba5379215116722abb0f09b2a86ddf01","original_commit_id":"09b0cc28ba5379215116722abb0f09b2a86ddf01","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"Also, can you change the keys and values to something different?\r\n\r\nIt is impossible to tell if this really works or if it sorts by value instead :).","created_at":"2018-02-21T17:01:52Z","updated_at":"2018-02-21T17:01:52Z","html_url":"https://github.com/ManageIQ/ui-components/pull/265#discussion_r169707388","pull_request_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments/169707388"},"html":{"href":"https://github.com/ManageIQ/ui-components/pull/265#discussion_r169707388"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265","id":170270900,"html_url":"https://github.com/ManageIQ/ui-components/pull/265","diff_url":"https://github.com/ManageIQ/ui-components/pull/265.diff","patch_url":"https://github.com/ManageIQ/ui-components/pull/265.patch","issue_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/265","number":265,"state":"open","locked":false,"title":"Updated support for sorting of drop downs","user":{"login":"chalettu","id":230549,"avatar_url":"https://avatars3.githubusercontent.com/u/230549?v=4","gravatar_id":"","url":"https://api.github.com/users/chalettu","html_url":"https://github.com/chalettu","followers_url":"https://api.github.com/users/chalettu/followers","following_url":"https://api.github.com/users/chalettu/following{/other_user}","gists_url":"https://api.github.com/users/chalettu/gists{/gist_id}","starred_url":"https://api.github.com/users/chalettu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalettu/subscriptions","organizations_url":"https://api.github.com/users/chalettu/orgs","repos_url":"https://api.github.com/users/chalettu/repos","events_url":"https://api.github.com/users/chalettu/events{/privacy}","received_events_url":"https://api.github.com/users/chalettu/received_events","type":"User","site_admin":false},"body":"@miq-bot add_label bug\r\n@miq-bot add_label gaprindashvili/yes \r\nThis PR also addresses an issue where \"None\" option should default to staying at the top of a dropdown list of options.\r\nFix for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1531677","created_at":"2018-02-20T18:21:22Z","updated_at":"2018-02-21T17:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc2f8fa85f7cd36291995460f104023622e522fa","assignee":{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"assignees":[{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":809179204,"url":"https://api.github.com/repos/ManageIQ/ui-components/labels/blocker","name":"blocker","color":"000000","default":false},{"id":416230452,"url":"https://api.github.com/repos/ManageIQ/ui-components/labels/bug","name":"bug","color":"ee0701","default":true},{"id":739710644,"url":"https://api.github.com/repos/ManageIQ/ui-components/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/265/comments","statuses_url":"https://api.github.com/repos/ManageIQ/ui-components/statuses/09b0cc28ba5379215116722abb0f09b2a86ddf01","head":{"label":"chalettu:dialog-sorting-dropdowns","ref":"dialog-sorting-dropdowns","sha":"09b0cc28ba5379215116722abb0f09b2a86ddf01","user":{"login":"chalettu","id":230549,"avatar_url":"https://avatars3.githubusercontent.com/u/230549?v=4","gravatar_id":"","url":"https://api.github.com/users/chalettu","html_url":"https://github.com/chalettu","followers_url":"https://api.github.com/users/chalettu/followers","following_url":"https://api.github.com/users/chalettu/following{/other_user}","gists_url":"https://api.github.com/users/chalettu/gists{/gist_id}","starred_url":"https://api.github.com/users/chalettu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalettu/subscriptions","organizations_url":"https://api.github.com/users/chalettu/orgs","repos_url":"https://api.github.com/users/chalettu/repos","events_url":"https://api.github.com/users/chalettu/events{/privacy}","received_events_url":"https://api.github.com/users/chalettu/received_events","type":"User","site_admin":false},"repo":{"id":94911001,"name":"ui-components","full_name":"chalettu/ui-components","owner":{"login":"chalettu","id":230549,"avatar_url":"https://avatars3.githubusercontent.com/u/230549?v=4","gravatar_id":"","url":"https://api.github.com/users/chalettu","html_url":"https://github.com/chalettu","followers_url":"https://api.github.com/users/chalettu/followers","following_url":"https://api.github.com/users/chalettu/following{/other_user}","gists_url":"https://api.github.com/users/chalettu/gists{/gist_id}","starred_url":"https://api.github.com/users/chalettu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalettu/subscriptions","organizations_url":"https://api.github.com/users/chalettu/orgs","repos_url":"https://api.github.com/users/chalettu/repos","events_url":"https://api.github.com/users/chalettu/events{/privacy}","received_events_url":"https://api.github.com/users/chalettu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalettu/ui-components","description":"Angular UI Components for ManageIQ","fork":true,"url":"https://api.github.com/repos/chalettu/ui-components","forks_url":"https://api.github.com/repos/chalettu/ui-components/forks","keys_url":"https://api.github.com/repos/chalettu/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalettu/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalettu/ui-components/teams","hooks_url":"https://api.github.com/repos/chalettu/ui-components/hooks","issue_events_url":"https://api.github.com/repos/chalettu/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/chalettu/ui-components/events","assignees_url":"https://api.github.com/repos/chalettu/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/chalettu/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/chalettu/ui-components/tags","blobs_url":"https://api.github.com/repos/chalettu/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalettu/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalettu/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalettu/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalettu/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/chalettu/ui-components/languages","stargazers_url":"https://api.github.com/repos/chalettu/ui-components/stargazers","contributors_url":"https://api.github.com/repos/chalettu/ui-components/contributors","subscribers_url":"https://api.github.com/repos/chalettu/ui-components/subscribers","subscription_url":"https://api.github.com/repos/chalettu/ui-components/subscription","commits_url":"https://api.github.com/repos/chalettu/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalettu/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalettu/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalettu/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalettu/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/chalettu/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalettu/ui-components/merges","archive_url":"https://api.github.com/repos/chalettu/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalettu/ui-components/downloads","issues_url":"https://api.github.com/repos/chalettu/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/chalettu/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/chalettu/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/chalettu/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalettu/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/chalettu/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/chalettu/ui-components/deployments","created_at":"2017-06-20T16:12:17Z","updated_at":"2017-06-20T16:12:19Z","pushed_at":"2018-02-21T16:54:10Z","git_url":"git://github.com/chalettu/ui-components.git","ssh_url":"git@github.com:chalettu/ui-components.git","clone_url":"https://github.com/chalettu/ui-components.git","svn_url":"https://github.com/chalettu/ui-components","homepage":"","size":1878,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"062ee1fc486b2893cea4f4d2e18d13cd616b30de","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":64480586,"name":"ui-components","full_name":"ManageIQ/ui-components","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/ui-components","description":"Angular UI Components for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/ui-components","forks_url":"https://api.github.com/repos/ManageIQ/ui-components/forks","keys_url":"https://api.github.com/repos/ManageIQ/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/ui-components/teams","hooks_url":"https://api.github.com/repos/ManageIQ/ui-components/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/ui-components/events","assignees_url":"https://api.github.com/repos/ManageIQ/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/ui-components/tags","blobs_url":"https://api.github.com/repos/ManageIQ/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/ui-components/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/ui-components/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/ui-components/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/ui-components/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/ui-components/subscription","commits_url":"https://api.github.com/repos/ManageIQ/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/ui-components/merges","archive_url":"https://api.github.com/repos/ManageIQ/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/ui-components/downloads","issues_url":"https://api.github.com/repos/ManageIQ/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/ui-components/deployments","created_at":"2016-07-29T12:58:19Z","updated_at":"2018-02-19T13:42:16Z","pushed_at":"2018-02-21T16:54:12Z","git_url":"git://github.com/ManageIQ/ui-components.git","ssh_url":"git@github.com:ManageIQ/ui-components.git","clone_url":"https://github.com/ManageIQ/ui-components.git","svn_url":"https://github.com/ManageIQ/ui-components","homepage":"","size":3880,"stargazers_count":11,"watchers_count":11,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":28,"open_issues":20,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265"},"html":{"href":"https://github.com/ManageIQ/ui-components/pull/265"},"issue":{"href":"https://api.github.com/repos/ManageIQ/ui-components/issues/265"},"comments":{"href":"https://api.github.com/repos/ManageIQ/ui-components/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/ui-components/statuses/09b0cc28ba5379215116722abb0f09b2a86ddf01"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64480586,
"name": "ManageIQ/ui-components",
"url": "https://api.github.com/repos/ManageIQ/ui-components"
} | {
"id": 289743,
"login": "himdel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/289743?",
"url": "https://api.github.com/users/himdel"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2018-02-21T17:01:52 | 7276676330 | {"actor":{"display_login":"himdel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/comments/206259384","pull_request_review_id":141639871,"id":206259384,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjI1OTM4NA==","diff_hunk":"@@ -36,5 +36,10 @@ def self.parse(source, dictionary)\n end\n result\n end\n+\n+ def self.get_location_led_info(leds)","path":"app/models/manageiq/providers/lenovo/physical_infra_manager/parser/component_parser.rb","position":5,"original_position":5,"commit_id":"35ac39bac876554464022d7553e0eabe5874b033","original_commit_id":"35ac39bac876554464022d7553e0eabe5874b033","user":{"login":"CharlleDaniel","id":12627705,"node_id":"MDQ6VXNlcjEyNjI3NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/12627705?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlleDaniel","html_url":"https://github.com/CharlleDaniel","followers_url":"https://api.github.com/users/CharlleDaniel/followers","following_url":"https://api.github.com/users/CharlleDaniel/following{/other_user}","gists_url":"https://api.github.com/users/CharlleDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlleDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlleDaniel/subscriptions","organizations_url":"https://api.github.com/users/CharlleDaniel/orgs","repos_url":"https://api.github.com/users/CharlleDaniel/repos","events_url":"https://api.github.com/users/CharlleDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/CharlleDaniel/received_events","type":"User","site_admin":false},"body":"So, leds never will be nil or empty?","created_at":"2018-07-30T17:36:56Z","updated_at":"2018-07-30T17:37:03Z","html_url":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207#discussion_r206259384","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/comments/206259384"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207#discussion_r206259384"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207","id":199755566,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzU1NTY2","html_url":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207","diff_url":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/207","number":207,"state":"open","locked":false,"title":"Parsing Location LED name","user":{"login":"douglasgabriel","id":8550928,"node_id":"MDQ6VXNlcjg1NTA5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8550928?v=4","gravatar_id":"","url":"https://api.github.com/users/douglasgabriel","html_url":"https://github.com/douglasgabriel","followers_url":"https://api.github.com/users/douglasgabriel/followers","following_url":"https://api.github.com/users/douglasgabriel/following{/other_user}","gists_url":"https://api.github.com/users/douglasgabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/douglasgabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglasgabriel/subscriptions","organizations_url":"https://api.github.com/users/douglasgabriel/orgs","repos_url":"https://api.github.com/users/douglasgabriel/repos","events_url":"https://api.github.com/users/douglasgabriel/events{/privacy}","received_events_url":"https://api.github.com/users/douglasgabriel/received_events","type":"User","site_admin":false},"body":"__This PR is able to__\r\n- Parse the Location LED name to `physical_servers` and `physical_chassis`\r\n\r\n__Depends on__\r\n- ~https://github.com/ManageIQ/manageiq-schema/pull/231~ - Merged","created_at":"2018-07-06T13:57:42Z","updated_at":"2018-07-30T17:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8735bddf6d49a8fee91468d96b3c8d1c7719cf9","assignee":{"login":"CharlleDaniel","id":12627705,"node_id":"MDQ6VXNlcjEyNjI3NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/12627705?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlleDaniel","html_url":"https://github.com/CharlleDaniel","followers_url":"https://api.github.com/users/CharlleDaniel/followers","following_url":"https://api.github.com/users/CharlleDaniel/following{/other_user}","gists_url":"https://api.github.com/users/CharlleDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlleDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlleDaniel/subscriptions","organizations_url":"https://api.github.com/users/CharlleDaniel/orgs","repos_url":"https://api.github.com/users/CharlleDaniel/repos","events_url":"https://api.github.com/users/CharlleDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/CharlleDaniel/received_events","type":"User","site_admin":false},"assignees":[{"login":"CharlleDaniel","id":12627705,"node_id":"MDQ6VXNlcjEyNjI3NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/12627705?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlleDaniel","html_url":"https://github.com/CharlleDaniel","followers_url":"https://api.github.com/users/CharlleDaniel/followers","following_url":"https://api.github.com/users/CharlleDaniel/following{/other_user}","gists_url":"https://api.github.com/users/CharlleDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlleDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlleDaniel/subscriptions","organizations_url":"https://api.github.com/users/CharlleDaniel/orgs","repos_url":"https://api.github.com/users/CharlleDaniel/repos","events_url":"https://api.github.com/users/CharlleDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/CharlleDaniel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/207/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/statuses/35ac39bac876554464022d7553e0eabe5874b033","head":{"label":"douglasgabriel:parse_led_name","ref":"parse_led_name","sha":"35ac39bac876554464022d7553e0eabe5874b033","user":{"login":"douglasgabriel","id":8550928,"node_id":"MDQ6VXNlcjg1NTA5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8550928?v=4","gravatar_id":"","url":"https://api.github.com/users/douglasgabriel","html_url":"https://github.com/douglasgabriel","followers_url":"https://api.github.com/users/douglasgabriel/followers","following_url":"https://api.github.com/users/douglasgabriel/following{/other_user}","gists_url":"https://api.github.com/users/douglasgabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/douglasgabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglasgabriel/subscriptions","organizations_url":"https://api.github.com/users/douglasgabriel/orgs","repos_url":"https://api.github.com/users/douglasgabriel/repos","events_url":"https://api.github.com/users/douglasgabriel/events{/privacy}","received_events_url":"https://api.github.com/users/douglasgabriel/received_events","type":"User","site_admin":false},"repo":{"id":105152363,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxNTIzNjM=","name":"manageiq-providers-lenovo","full_name":"douglasgabriel/manageiq-providers-lenovo","owner":{"login":"douglasgabriel","id":8550928,"node_id":"MDQ6VXNlcjg1NTA5Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/8550928?v=4","gravatar_id":"","url":"https://api.github.com/users/douglasgabriel","html_url":"https://github.com/douglasgabriel","followers_url":"https://api.github.com/users/douglasgabriel/followers","following_url":"https://api.github.com/users/douglasgabriel/following{/other_user}","gists_url":"https://api.github.com/users/douglasgabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/douglasgabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglasgabriel/subscriptions","organizations_url":"https://api.github.com/users/douglasgabriel/orgs","repos_url":"https://api.github.com/users/douglasgabriel/repos","events_url":"https://api.github.com/users/douglasgabriel/events{/privacy}","received_events_url":"https://api.github.com/users/douglasgabriel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/douglasgabriel/manageiq-providers-lenovo","description":"ManageIQ plugin for the Lenovo XClarity provider.","fork":true,"url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo","forks_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/forks","keys_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/teams","hooks_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/hooks","issue_events_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/issues/events{/number}","events_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/events","assignees_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/assignees{/user}","branches_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/branches{/branch}","tags_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/tags","blobs_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/git/refs{/sha}","trees_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/statuses/{sha}","languages_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/languages","stargazers_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/stargazers","contributors_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/contributors","subscribers_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/subscribers","subscription_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/subscription","commits_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/commits{/sha}","git_commits_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/git/commits{/sha}","comments_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/comments{/number}","issue_comment_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/issues/comments{/number}","contents_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/contents/{+path}","compare_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/merges","archive_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/downloads","issues_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/issues{/number}","pulls_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/pulls{/number}","milestones_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/milestones{/number}","notifications_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/labels{/name}","releases_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/releases{/id}","deployments_url":"https://api.github.com/repos/douglasgabriel/manageiq-providers-lenovo/deployments","created_at":"2017-09-28T13:32:24Z","updated_at":"2017-09-28T13:32:26Z","pushed_at":"2018-07-27T11:24:49Z","git_url":"git://github.com/douglasgabriel/manageiq-providers-lenovo.git","ssh_url":"git@github.com:douglasgabriel/manageiq-providers-lenovo.git","clone_url":"https://github.com/douglasgabriel/manageiq-providers-lenovo.git","svn_url":"https://github.com/douglasgabriel/manageiq-providers-lenovo","homepage":"http://manageiq.org","size":1013,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"1dd5282f534de8c9517d9f3be61256fbb13b2ffd","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":65032062,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAzMjA2Mg==","name":"manageiq-providers-lenovo","full_name":"ManageIQ/manageiq-providers-lenovo","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-lenovo","description":"ManageIQ plugin for the Lenovo XClarity provider.","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/deployments","created_at":"2016-08-05T16:10:11Z","updated_at":"2018-07-25T16:31:29Z","pushed_at":"2018-07-27T11:24:51Z","git_url":"git://github.com/ManageIQ/manageiq-providers-lenovo.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-lenovo.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-lenovo.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-lenovo","homepage":"http://manageiq.org","size":1013,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":16,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-lenovo/pull/207"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/207"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo/statuses/35ac39bac876554464022d7553e0eabe5874b033"}},"author_association":"MEMBER"}} | {
"id": 65032062,
"name": "ManageIQ/manageiq-providers-lenovo",
"url": "https://api.github.com/repos/ManageIQ/manageiq-providers-lenovo"
} | {
"id": 12627705,
"login": "CharlleDaniel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12627705?",
"url": "https://api.github.com/users/CharlleDaniel"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2018-07-30T17:36:56 | 8039195225 | {"actor":{"display_login":"CharlleDaniel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lsst/qserv/pulls/comments/222771333","pull_request_review_id":161739319,"id":222771333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjc3MTMzMw==","diff_hunk":"@@ -122,210 +125,214 @@ bool test() {\n \n try {\n \n- ////////////////////////////////////////////////////////////////////////////\n- // Start the controller in its own thread pool before injecting any requests\n+ ///////////////////////////////////////////////////////////////////////////\n+ // Start the provider in its own thread pool before initiating any requests\n+ // or jobs.\n+ //\n // Note that onFinish callbacks which are activated upon the completion of\n- // the requsets will be run in one of the threads of the Controller's pool.\n+ // the requests or jobs will be run by a thread from the pool.\n \n replica::ServiceProvider::Ptr const provider = replica::ServiceProvider::create(configUrl);\n replica::Controller::Ptr const controller = replica::Controller::create(provider);\n \n- controller->run();\n+ provider->run();\n \n util::BlockPost blockPost(1000,2000);\n \n- ///////////////////////////////////////////////////////////////////\n- // Start two parallel jobs, the firts one getting the latest state\n- // of replicas accross the Replication cluster, and the second one\n- // getting a list of replicas known to Qserv workers.\n-\n- std::atomic<bool> replicaJobFinished{false};\n- auto findAllJob = replica::FindAllJob::create(\n- databaseFamily,\n- saveReplicaInfo,\n- controller,\n- std::string(),\n- [&replicaJobFinished] (replica::FindAllJob::Ptr const& job) {\n- replicaJobFinished = true;\n- }\n- );\n- findAllJob->start();\n-\n- replica::QservGetReplicasJob::Ptr qservGetReplicasJob;\n- if (pullQservReplicas) {\n- std::atomic<bool> qservJobFinished{false};\n- bool const inUseOnly = false;\n- qservGetReplicasJob = replica::QservGetReplicasJob::create(\n+ for (unsigned int i = 0; i < numIter; ++i) {\n+\n+ ///////////////////////////////////////////////////////////////////\n+ // Start two parallel jobs, the firts one getting the latest state","path":"core/modules/replica/tools/qserv-replica-job-chunks.cc","position":70,"original_position":70,"commit_id":"aa39c43c9f323276396852ccce7f8fcfa6f48312","original_commit_id":"c349500082c65be3da26e73cb312cad14a99dca4","user":{"login":"iagaponenko","id":14188390,"node_id":"MDQ6VXNlcjE0MTg4Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14188390?v=4","gravatar_id":"","url":"https://api.github.com/users/iagaponenko","html_url":"https://github.com/iagaponenko","followers_url":"https://api.github.com/users/iagaponenko/followers","following_url":"https://api.github.com/users/iagaponenko/following{/other_user}","gists_url":"https://api.github.com/users/iagaponenko/gists{/gist_id}","starred_url":"https://api.github.com/users/iagaponenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iagaponenko/subscriptions","organizations_url":"https://api.github.com/users/iagaponenko/orgs","repos_url":"https://api.github.com/users/iagaponenko/repos","events_url":"https://api.github.com/users/iagaponenko/events{/privacy}","received_events_url":"https://api.github.com/users/iagaponenko/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-10-04T18:01:43Z","updated_at":"2018-10-04T18:01:43Z","html_url":"https://github.com/lsst/qserv/pull/418#discussion_r222771333","pull_request_url":"https://api.github.com/repos/lsst/qserv/pulls/418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/qserv/pulls/comments/222771333"},"html":{"href":"https://github.com/lsst/qserv/pull/418#discussion_r222771333"},"pull_request":{"href":"https://api.github.com/repos/lsst/qserv/pulls/418"}},"in_reply_to_id":221781158},"pull_request":{"url":"https://api.github.com/repos/lsst/qserv/pulls/418","id":219114056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTE0MDU2","html_url":"https://github.com/lsst/qserv/pull/418","diff_url":"https://github.com/lsst/qserv/pull/418.diff","patch_url":"https://github.com/lsst/qserv/pull/418.patch","issue_url":"https://api.github.com/repos/lsst/qserv/issues/418","number":418,"state":"open","locked":false,"title":"Tickets/dm 14292","user":{"login":"iagaponenko","id":14188390,"node_id":"MDQ6VXNlcjE0MTg4Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14188390?v=4","gravatar_id":"","url":"https://api.github.com/users/iagaponenko","html_url":"https://github.com/iagaponenko","followers_url":"https://api.github.com/users/iagaponenko/followers","following_url":"https://api.github.com/users/iagaponenko/following{/other_user}","gists_url":"https://api.github.com/users/iagaponenko/gists{/gist_id}","starred_url":"https://api.github.com/users/iagaponenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iagaponenko/subscriptions","organizations_url":"https://api.github.com/users/iagaponenko/orgs","repos_url":"https://api.github.com/users/iagaponenko/repos","events_url":"https://api.github.com/users/iagaponenko/events{/privacy}","received_events_url":"https://api.github.com/users/iagaponenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-29T00:42:07Z","updated_at":"2018-10-04T18:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5df4d5f5c5fca30dbb660d5c97649488ff7b7dad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/qserv/pulls/418/commits","review_comments_url":"https://api.github.com/repos/lsst/qserv/pulls/418/comments","review_comment_url":"https://api.github.com/repos/lsst/qserv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/qserv/issues/418/comments","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/aa39c43c9f323276396852ccce7f8fcfa6f48312","head":{"label":"lsst:tickets/DM-14292","ref":"tickets/DM-14292","sha":"aa39c43c9f323276396852ccce7f8fcfa6f48312","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzQ2MA==","name":"qserv","full_name":"lsst/qserv","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/qserv","description":"LSST Query Services","fork":false,"url":"https://api.github.com/repos/lsst/qserv","forks_url":"https://api.github.com/repos/lsst/qserv/forks","keys_url":"https://api.github.com/repos/lsst/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/qserv/teams","hooks_url":"https://api.github.com/repos/lsst/qserv/hooks","issue_events_url":"https://api.github.com/repos/lsst/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/qserv/events","assignees_url":"https://api.github.com/repos/lsst/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/qserv/tags","blobs_url":"https://api.github.com/repos/lsst/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/qserv/languages","stargazers_url":"https://api.github.com/repos/lsst/qserv/stargazers","contributors_url":"https://api.github.com/repos/lsst/qserv/contributors","subscribers_url":"https://api.github.com/repos/lsst/qserv/subscribers","subscription_url":"https://api.github.com/repos/lsst/qserv/subscription","commits_url":"https://api.github.com/repos/lsst/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/qserv/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/qserv/merges","archive_url":"https://api.github.com/repos/lsst/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/qserv/downloads","issues_url":"https://api.github.com/repos/lsst/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/qserv/labels{/name}","releases_url":"https://api.github.com/repos/lsst/qserv/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/qserv/deployments","created_at":"2014-08-16T07:50:36Z","updated_at":"2018-10-04T17:15:38Z","pushed_at":"2018-10-04T17:15:44Z","git_url":"git://github.com/lsst/qserv.git","ssh_url":"git@github.com:lsst/qserv.git","clone_url":"https://github.com/lsst/qserv.git","svn_url":"https://github.com/lsst/qserv","homepage":"http://dm.lsst.org/","size":20207,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":14,"open_issues":3,"watchers":18,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"a956f306aeff7b1ac8bcf1d2d998ee509c911613","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzQ2MA==","name":"qserv","full_name":"lsst/qserv","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/qserv","description":"LSST Query Services","fork":false,"url":"https://api.github.com/repos/lsst/qserv","forks_url":"https://api.github.com/repos/lsst/qserv/forks","keys_url":"https://api.github.com/repos/lsst/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/qserv/teams","hooks_url":"https://api.github.com/repos/lsst/qserv/hooks","issue_events_url":"https://api.github.com/repos/lsst/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/qserv/events","assignees_url":"https://api.github.com/repos/lsst/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/qserv/tags","blobs_url":"https://api.github.com/repos/lsst/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/qserv/languages","stargazers_url":"https://api.github.com/repos/lsst/qserv/stargazers","contributors_url":"https://api.github.com/repos/lsst/qserv/contributors","subscribers_url":"https://api.github.com/repos/lsst/qserv/subscribers","subscription_url":"https://api.github.com/repos/lsst/qserv/subscription","commits_url":"https://api.github.com/repos/lsst/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/qserv/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/qserv/merges","archive_url":"https://api.github.com/repos/lsst/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/qserv/downloads","issues_url":"https://api.github.com/repos/lsst/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/qserv/labels{/name}","releases_url":"https://api.github.com/repos/lsst/qserv/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/qserv/deployments","created_at":"2014-08-16T07:50:36Z","updated_at":"2018-10-04T17:15:38Z","pushed_at":"2018-10-04T17:15:44Z","git_url":"git://github.com/lsst/qserv.git","ssh_url":"git@github.com:lsst/qserv.git","clone_url":"https://github.com/lsst/qserv.git","svn_url":"https://github.com/lsst/qserv","homepage":"http://dm.lsst.org/","size":20207,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":14,"open_issues":3,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/qserv/pulls/418"},"html":{"href":"https://github.com/lsst/qserv/pull/418"},"issue":{"href":"https://api.github.com/repos/lsst/qserv/issues/418"},"comments":{"href":"https://api.github.com/repos/lsst/qserv/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/qserv/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/qserv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/qserv/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/qserv/statuses/aa39c43c9f323276396852ccce7f8fcfa6f48312"}},"author_association":"CONTRIBUTOR"}} | {
"id": 23013460,
"name": "lsst/qserv",
"url": "https://api.github.com/repos/lsst/qserv"
} | {
"id": 14188390,
"login": "iagaponenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14188390?",
"url": "https://api.github.com/users/iagaponenko"
} | {
"id": 1134504,
"login": "lsst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1134504?",
"url": "https://api.github.com/orgs/lsst"
} | 2018-10-04T18:01:43 | 8369669709 | {"actor":{"display_login":"iagaponenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/204006495","pull_request_review_id":139010678,"id":204006495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDAwNjQ5NQ==","diff_hunk":"@@ -1148,6 +1148,40 @@ Returns:\n }'\n }\n \n+\n+.. jinja_ref:: traverse\n+\n+``traverse``\n+--------------\n+\n+.. versionadded:: 2018.3.3","path":"doc/topics/jinja/index.rst","position":10,"original_position":10,"commit_id":"37a41226d5b1486ad915fc67f54ee702bf1d4520","original_commit_id":"37a41226d5b1486ad915fc67f54ee702bf1d4520","user":{"login":"mirceaulinic","id":16694679,"node_id":"MDQ6VXNlcjE2Njk0Njc5","avatar_url":"https://avatars1.githubusercontent.com/u/16694679?v=4","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"body":"`.. versionadded:: Fluorine`","created_at":"2018-07-20T10:48:11Z","updated_at":"2018-07-20T10:51:39Z","html_url":"https://github.com/saltstack/salt/pull/48670#discussion_r204006495","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/48670","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/204006495"},"html":{"href":"https://github.com/saltstack/salt/pull/48670#discussion_r204006495"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48670"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/48670","id":202610208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjEwMjA4","html_url":"https://github.com/saltstack/salt/pull/48670","diff_url":"https://github.com/saltstack/salt/pull/48670.diff","patch_url":"https://github.com/saltstack/salt/pull/48670.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/48670","number":48670,"state":"open","locked":false,"title":"Add the \"traverse\" jinja filter","user":{"login":"bbinet","id":76281,"node_id":"MDQ6VXNlcjc2Mjgx","avatar_url":"https://avatars0.githubusercontent.com/u/76281?v=4","gravatar_id":"","url":"https://api.github.com/users/bbinet","html_url":"https://github.com/bbinet","followers_url":"https://api.github.com/users/bbinet/followers","following_url":"https://api.github.com/users/bbinet/following{/other_user}","gists_url":"https://api.github.com/users/bbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbinet/subscriptions","organizations_url":"https://api.github.com/users/bbinet/orgs","repos_url":"https://api.github.com/users/bbinet/repos","events_url":"https://api.github.com/users/bbinet/events{/privacy}","received_events_url":"https://api.github.com/users/bbinet/received_events","type":"User","site_admin":false},"body":"This filter can be really useful in states to select some leaf pillar data or fallback with a default value.\r\n\r\nThe code is trivial as it is just a matter of exposing the existing `traverse_dict_and_list` function as a jinja filter through the `@jinja_filter('traverse')` decorator.\r\nThat is the reason why it seems safe to merge it in the 2018.3 branch instead of the develop branch.\r\n","created_at":"2018-07-19T16:05:14Z","updated_at":"2018-07-20T10:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26c248f6dcc0be673caea8cc44974f0dc14c59b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/48670/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/48670/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/48670/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/37a41226d5b1486ad915fc67f54ee702bf1d4520","head":{"label":"bbinet:traverse","ref":"traverse","sha":"37a41226d5b1486ad915fc67f54ee702bf1d4520","user":{"login":"bbinet","id":76281,"node_id":"MDQ6VXNlcjc2Mjgx","avatar_url":"https://avatars0.githubusercontent.com/u/76281?v=4","gravatar_id":"","url":"https://api.github.com/users/bbinet","html_url":"https://github.com/bbinet","followers_url":"https://api.github.com/users/bbinet/followers","following_url":"https://api.github.com/users/bbinet/following{/other_user}","gists_url":"https://api.github.com/users/bbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbinet/subscriptions","organizations_url":"https://api.github.com/users/bbinet/orgs","repos_url":"https://api.github.com/users/bbinet/repos","events_url":"https://api.github.com/users/bbinet/events{/privacy}","received_events_url":"https://api.github.com/users/bbinet/received_events","type":"User","site_admin":false},"repo":{"id":15610472,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxMDQ3Mg==","name":"salt","full_name":"bbinet/salt","owner":{"login":"bbinet","id":76281,"node_id":"MDQ6VXNlcjc2Mjgx","avatar_url":"https://avatars0.githubusercontent.com/u/76281?v=4","gravatar_id":"","url":"https://api.github.com/users/bbinet","html_url":"https://github.com/bbinet","followers_url":"https://api.github.com/users/bbinet/followers","following_url":"https://api.github.com/users/bbinet/following{/other_user}","gists_url":"https://api.github.com/users/bbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/bbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbinet/subscriptions","organizations_url":"https://api.github.com/users/bbinet/orgs","repos_url":"https://api.github.com/users/bbinet/repos","events_url":"https://api.github.com/users/bbinet/events{/privacy}","received_events_url":"https://api.github.com/users/bbinet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbinet/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/bbinet/salt","forks_url":"https://api.github.com/repos/bbinet/salt/forks","keys_url":"https://api.github.com/repos/bbinet/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbinet/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbinet/salt/teams","hooks_url":"https://api.github.com/repos/bbinet/salt/hooks","issue_events_url":"https://api.github.com/repos/bbinet/salt/issues/events{/number}","events_url":"https://api.github.com/repos/bbinet/salt/events","assignees_url":"https://api.github.com/repos/bbinet/salt/assignees{/user}","branches_url":"https://api.github.com/repos/bbinet/salt/branches{/branch}","tags_url":"https://api.github.com/repos/bbinet/salt/tags","blobs_url":"https://api.github.com/repos/bbinet/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbinet/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbinet/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbinet/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbinet/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/bbinet/salt/languages","stargazers_url":"https://api.github.com/repos/bbinet/salt/stargazers","contributors_url":"https://api.github.com/repos/bbinet/salt/contributors","subscribers_url":"https://api.github.com/repos/bbinet/salt/subscribers","subscription_url":"https://api.github.com/repos/bbinet/salt/subscription","commits_url":"https://api.github.com/repos/bbinet/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbinet/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbinet/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbinet/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbinet/salt/contents/{+path}","compare_url":"https://api.github.com/repos/bbinet/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbinet/salt/merges","archive_url":"https://api.github.com/repos/bbinet/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbinet/salt/downloads","issues_url":"https://api.github.com/repos/bbinet/salt/issues{/number}","pulls_url":"https://api.github.com/repos/bbinet/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/bbinet/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/bbinet/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbinet/salt/labels{/name}","releases_url":"https://api.github.com/repos/bbinet/salt/releases{/id}","deployments_url":"https://api.github.com/repos/bbinet/salt/deployments","created_at":"2014-01-03T13:50:35Z","updated_at":"2014-06-13T16:07:02Z","pushed_at":"2018-07-20T10:11:51Z","git_url":"git://github.com/bbinet/salt.git","ssh_url":"git@github.com:bbinet/salt.git","clone_url":"https://github.com/bbinet/salt.git","svn_url":"https://github.com/bbinet/salt","homepage":"saltstack.org","size":381969,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack:2018.3","ref":"2018.3","sha":"e82816711433ee5826fddf0458666a6aefa0200c","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-07-20T09:26:17Z","pushed_at":"2018-07-20T10:19:38Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":410279,"stargazers_count":9051,"watchers_count":9051,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4218,"mirror_url":null,"archived":false,"open_issues_count":3025,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4218,"open_issues":3025,"watchers":9051,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48670"},"html":{"href":"https://github.com/saltstack/salt/pull/48670"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/48670"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/48670/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48670/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/48670/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/37a41226d5b1486ad915fc67f54ee702bf1d4520"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1390248,
"name": "saltstack/salt",
"url": "https://api.github.com/repos/saltstack/salt"
} | {
"id": 16694679,
"login": "mirceaulinic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16694679?",
"url": "https://api.github.com/users/mirceaulinic"
} | {
"id": 1147473,
"login": "saltstack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1147473?",
"url": "https://api.github.com/orgs/saltstack"
} | 2018-07-20T10:48:11 | 7994323150 | {"actor":{"display_login":"mirceaulinic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/165780733","pull_request_review_id":93780568,"id":165780733,"diff_hunk":"@@ -232,20 +234,21 @@ def testBasic(self):\n os.path.join('main', 'raet', 'main_master')))\n self.assertTrue(main.ha, (\"0.0.0.0\", raeting.RAET_PORT))\n self.assertIs(main.keep.auto, raeting.AutoMode.never.value)\n- self.assertDictEqual(main.keep.loadLocalData(), {'name': mainData['name'],\n- 'uid': 1,\n- 'ha': ['127.0.0.1', 7530],\n- 'iha': None,\n- 'natted': None,\n- 'fqdn': '1.0.0.127.in-addr.arpa',\n- 'dyned': None,\n- 'sid': 0,\n- 'puid': 1,\n- 'aha': ['0.0.0.0', 7530],\n- 'role': mainData['role'],\n- 'sighex': mainData['sighex'],\n- 'prihex': mainData['prihex'],\n- })\n+ self.assertDictEqual(main.keep.loadLocalData(),\n+ {'name': mainData['name'],\n+ 'uid': 1,\n+ 'ha': ['127.0.0.1', 7530],\n+ 'iha': None,\n+ 'natted': None,\n+ 'fqdn': socket.getfqdn('127.0.0.1'),\n+ 'dyned': None,\n+ 'sid': 0,\n+ 'puid': 1,\n+ 'aha': ['0.0.0.0', 7530],\n+ 'role': mainData['role'],\n+ 'sighex': salt.utils.stringutils.to_str(mainData['sighex']),\n+ 'prihex': salt.utils.stringutils.to_str(mainData['prihex']),","path":"salt/daemons/test/test_saltkeep.py","position":53,"original_position":53,"commit_id":"0b7fb33b0395cf03fe208368b84456fa155ae3b0","original_commit_id":"0b7fb33b0395cf03fe208368b84456fa155ae3b0","user":{"login":"terminalmage","id":328598,"avatar_url":"https://avatars1.githubusercontent.com/u/328598?v=4","gravatar_id":"","url":"https://api.github.com/users/terminalmage","html_url":"https://github.com/terminalmage","followers_url":"https://api.github.com/users/terminalmage/followers","following_url":"https://api.github.com/users/terminalmage/following{/other_user}","gists_url":"https://api.github.com/users/terminalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/terminalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terminalmage/subscriptions","organizations_url":"https://api.github.com/users/terminalmage/orgs","repos_url":"https://api.github.com/users/terminalmage/repos","events_url":"https://api.github.com/users/terminalmage/events{/privacy}","received_events_url":"https://api.github.com/users/terminalmage/received_events","type":"User","site_admin":false},"body":"OK, thanks for the explanation, this is good to merge then. I just wanted to make sure this value wasn't intended to be a bytes type, because this would break it on Python 3 if that were the case.","created_at":"2018-02-02T22:48:51Z","updated_at":"2018-02-02T22:48:51Z","html_url":"https://github.com/saltstack/salt/pull/45800#discussion_r165780733","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/45800","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/165780733"},"html":{"href":"https://github.com/saltstack/salt/pull/45800#discussion_r165780733"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/45800"}},"in_reply_to_id":165561801},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/45800","id":166279289,"html_url":"https://github.com/saltstack/salt/pull/45800","diff_url":"https://github.com/saltstack/salt/pull/45800.diff","patch_url":"https://github.com/saltstack/salt/pull/45800.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/45800","number":45800,"state":"open","locked":false,"title":"RAET transport Py3 support and shutdown fixes","user":{"login":"DmitryKuzmenko","id":4807387,"avatar_url":"https://avatars0.githubusercontent.com/u/4807387?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKuzmenko","html_url":"https://github.com/DmitryKuzmenko","followers_url":"https://api.github.com/users/DmitryKuzmenko/followers","following_url":"https://api.github.com/users/DmitryKuzmenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKuzmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKuzmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKuzmenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryKuzmenko/orgs","repos_url":"https://api.github.com/users/DmitryKuzmenko/repos","events_url":"https://api.github.com/users/DmitryKuzmenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKuzmenko/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nFixes RAET transport:\r\n* Fixed specific tests for raet\r\n* Python 3 support\r\n* No tracebacks on shutdown Py2/Py3\r\n* Tested Py2-Py3 network level compatibility\r\n\r\n### What issues does this PR fix or reference?\r\nThis is the final part of RAET deprecation work.\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Commits signed with GPG?\r\nYes","created_at":"2018-01-31T14:46:49Z","updated_at":"2018-02-02T22:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45f2de020e85c39dc4af9fb44b39de90ca811fd5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"terminalmage","id":328598,"avatar_url":"https://avatars1.githubusercontent.com/u/328598?v=4","gravatar_id":"","url":"https://api.github.com/users/terminalmage","html_url":"https://github.com/terminalmage","followers_url":"https://api.github.com/users/terminalmage/followers","following_url":"https://api.github.com/users/terminalmage/following{/other_user}","gists_url":"https://api.github.com/users/terminalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/terminalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terminalmage/subscriptions","organizations_url":"https://api.github.com/users/terminalmage/orgs","repos_url":"https://api.github.com/users/terminalmage/repos","events_url":"https://api.github.com/users/terminalmage/events{/privacy}","received_events_url":"https://api.github.com/users/terminalmage/received_events","type":"User","site_admin":false},{"login":"thatch45","id":507599,"avatar_url":"https://avatars0.githubusercontent.com/u/507599?v=4","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/45800/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/45800/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/45800/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/0b7fb33b0395cf03fe208368b84456fa155ae3b0","head":{"label":"DSRCorporation:bugs/raet_deprecation","ref":"bugs/raet_deprecation","sha":"0b7fb33b0395cf03fe208368b84456fa155ae3b0","user":{"login":"DSRCorporation","id":5587153,"avatar_url":"https://avatars3.githubusercontent.com/u/5587153?v=4","gravatar_id":"","url":"https://api.github.com/users/DSRCorporation","html_url":"https://github.com/DSRCorporation","followers_url":"https://api.github.com/users/DSRCorporation/followers","following_url":"https://api.github.com/users/DSRCorporation/following{/other_user}","gists_url":"https://api.github.com/users/DSRCorporation/gists{/gist_id}","starred_url":"https://api.github.com/users/DSRCorporation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSRCorporation/subscriptions","organizations_url":"https://api.github.com/users/DSRCorporation/orgs","repos_url":"https://api.github.com/users/DSRCorporation/repos","events_url":"https://api.github.com/users/DSRCorporation/events{/privacy}","received_events_url":"https://api.github.com/users/DSRCorporation/received_events","type":"Organization","site_admin":false},"repo":{"id":23872510,"name":"salt","full_name":"DSRCorporation/salt","owner":{"login":"DSRCorporation","id":5587153,"avatar_url":"https://avatars3.githubusercontent.com/u/5587153?v=4","gravatar_id":"","url":"https://api.github.com/users/DSRCorporation","html_url":"https://github.com/DSRCorporation","followers_url":"https://api.github.com/users/DSRCorporation/followers","following_url":"https://api.github.com/users/DSRCorporation/following{/other_user}","gists_url":"https://api.github.com/users/DSRCorporation/gists{/gist_id}","starred_url":"https://api.github.com/users/DSRCorporation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSRCorporation/subscriptions","organizations_url":"https://api.github.com/users/DSRCorporation/orgs","repos_url":"https://api.github.com/users/DSRCorporation/repos","events_url":"https://api.github.com/users/DSRCorporation/events{/privacy}","received_events_url":"https://api.github.com/users/DSRCorporation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DSRCorporation/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/DSRCorporation/salt","forks_url":"https://api.github.com/repos/DSRCorporation/salt/forks","keys_url":"https://api.github.com/repos/DSRCorporation/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSRCorporation/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSRCorporation/salt/teams","hooks_url":"https://api.github.com/repos/DSRCorporation/salt/hooks","issue_events_url":"https://api.github.com/repos/DSRCorporation/salt/issues/events{/number}","events_url":"https://api.github.com/repos/DSRCorporation/salt/events","assignees_url":"https://api.github.com/repos/DSRCorporation/salt/assignees{/user}","branches_url":"https://api.github.com/repos/DSRCorporation/salt/branches{/branch}","tags_url":"https://api.github.com/repos/DSRCorporation/salt/tags","blobs_url":"https://api.github.com/repos/DSRCorporation/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSRCorporation/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSRCorporation/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSRCorporation/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSRCorporation/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/DSRCorporation/salt/languages","stargazers_url":"https://api.github.com/repos/DSRCorporation/salt/stargazers","contributors_url":"https://api.github.com/repos/DSRCorporation/salt/contributors","subscribers_url":"https://api.github.com/repos/DSRCorporation/salt/subscribers","subscription_url":"https://api.github.com/repos/DSRCorporation/salt/subscription","commits_url":"https://api.github.com/repos/DSRCorporation/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSRCorporation/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSRCorporation/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSRCorporation/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSRCorporation/salt/contents/{+path}","compare_url":"https://api.github.com/repos/DSRCorporation/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSRCorporation/salt/merges","archive_url":"https://api.github.com/repos/DSRCorporation/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSRCorporation/salt/downloads","issues_url":"https://api.github.com/repos/DSRCorporation/salt/issues{/number}","pulls_url":"https://api.github.com/repos/DSRCorporation/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/DSRCorporation/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/DSRCorporation/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSRCorporation/salt/labels{/name}","releases_url":"https://api.github.com/repos/DSRCorporation/salt/releases{/id}","deployments_url":"https://api.github.com/repos/DSRCorporation/salt/deployments","created_at":"2014-09-10T11:48:31Z","updated_at":"2017-02-01T15:31:59Z","pushed_at":"2018-02-02T20:31:33Z","git_url":"git://github.com/DSRCorporation/salt.git","ssh_url":"git@github.com:DSRCorporation/salt.git","clone_url":"https://github.com/DSRCorporation/salt.git","svn_url":"https://github.com/DSRCorporation/salt","homepage":"saltstack.com","size":199518,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:oxygen.rc1","ref":"oxygen.rc1","sha":"5c3ede4022ef6002ea256ad42736a947cd0be23f","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-02-02T15:47:03Z","pushed_at":"2018-02-02T21:36:25Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":203353,"stargazers_count":8527,"watchers_count":8527,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3974,"mirror_url":null,"archived":false,"open_issues_count":3810,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3974,"open_issues":3810,"watchers":8527,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/45800"},"html":{"href":"https://github.com/saltstack/salt/pull/45800"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/45800"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/45800/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/45800/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/45800/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/0b7fb33b0395cf03fe208368b84456fa155ae3b0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1390248,
"name": "saltstack/salt",
"url": "https://api.github.com/repos/saltstack/salt"
} | {
"id": 328598,
"login": "terminalmage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/328598?",
"url": "https://api.github.com/users/terminalmage"
} | {
"id": 1147473,
"login": "saltstack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1147473?",
"url": "https://api.github.com/orgs/saltstack"
} | 2018-02-02T22:48:51 | 7191849392 | {"actor":{"display_login":"terminalmage"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/224081486","pull_request_review_id":163362182,"id":224081486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDA4MTQ4Ng==","diff_hunk":"@@ -810,24 +742,9 @@ def set_dhcp_linklocal_all(interface):\n else:\n _restart(interface)\n return True\n- service = _interface_to_service(interface)\n- if not service:\n- if interface in map(lambda x: x.name, pyiface.getIfaces()):\n- return _enable_dhcp(interface)\n- raise salt.exceptions.CommandExecutionError('Invalid interface name: {0}'.format(interface))\n- service = pyconnman.ConnService(os.path.join(SERVICE_PATH, service))\n- ipv4 = service.get_property('IPv4.Configuration')\n- ipv4['Method'] = dbus.String('dhcp', variant_level=1)\n- ipv4['Address'] = dbus.String('', variant_level=1)\n- ipv4['Netmask'] = dbus.String('', variant_level=1)\n- ipv4['Gateway'] = dbus.String('', variant_level=1)\n- try:\n- service.set_property('IPv4.Configuration', ipv4)\n- service.set_property('Nameservers.Configuration', ['']) # reset nameservers list\n- except Exception as exc:\n- exc_msg = 'Couldn\\'t set dhcp linklocal for service: {0}\\nError: {1}\\n'.format(service, exc)\n- raise salt.exceptions.CommandExecutionError(exc_msg)\n- return True\n+ if interface in [x.name for x in pyiface.getIfaces()]:\n+ return _change_dhcp_config(interface)","path":"salt/modules/nilrt_ip.py","position":176,"original_position":176,"commit_id":"6d280e2b7c6bb6d501d74e7393c11dd04fe6c6cb","original_commit_id":"6d280e2b7c6bb6d501d74e7393c11dd04fe6c6cb","user":{"login":"rares-pop","id":29376719,"node_id":"MDQ6VXNlcjI5Mzc2NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/29376719?v=4","gravatar_id":"","url":"https://api.github.com/users/rares-pop","html_url":"https://github.com/rares-pop","followers_url":"https://api.github.com/users/rares-pop/followers","following_url":"https://api.github.com/users/rares-pop/following{/other_user}","gists_url":"https://api.github.com/users/rares-pop/gists{/gist_id}","starred_url":"https://api.github.com/users/rares-pop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rares-pop/subscriptions","organizations_url":"https://api.github.com/users/rares-pop/orgs","repos_url":"https://api.github.com/users/rares-pop/repos","events_url":"https://api.github.com/users/rares-pop/events{/privacy}","received_events_url":"https://api.github.com/users/rares-pop/received_events","type":"User","site_admin":false},"body":"is this setting the interface to dhcp-only? or dhcp-linklocal too?","created_at":"2018-10-10T13:44:37Z","updated_at":"2018-10-10T13:44:37Z","html_url":"https://github.com/saltstack/salt/pull/49926#discussion_r224081486","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/49926","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/224081486"},"html":{"href":"https://github.com/saltstack/salt/pull/49926#discussion_r224081486"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/49926"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/49926","id":221016814,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDE2ODE0","html_url":"https://github.com/saltstack/salt/pull/49926","diff_url":"https://github.com/saltstack/salt/pull/49926.diff","patch_url":"https://github.com/saltstack/salt/pull/49926.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/49926","number":49926,"state":"open","locked":false,"title":"Configure network interfaces without cable & add tests","user":{"login":"alexvasiu","id":13847052,"node_id":"MDQ6VXNlcjEzODQ3MDUy","avatar_url":"https://avatars0.githubusercontent.com/u/13847052?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvasiu","html_url":"https://github.com/alexvasiu","followers_url":"https://api.github.com/users/alexvasiu/followers","following_url":"https://api.github.com/users/alexvasiu/following{/other_user}","gists_url":"https://api.github.com/users/alexvasiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvasiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvasiu/subscriptions","organizations_url":"https://api.github.com/users/alexvasiu/orgs","repos_url":"https://api.github.com/users/alexvasiu/repos","events_url":"https://api.github.com/users/alexvasiu/events{/privacy}","received_events_url":"https://api.github.com/users/alexvasiu/received_events","type":"User","site_admin":false},"body":"* modules/nilrt_ip.py: Configure network interfaces without cable\r\nOn NG we use connman as a network manager which consider a service,\r\n an interface connected with a cable. The only way to set-up an interface\r\n without a cable is through config files. This works also for services\r\n because before we start the connamn daemon, we create a config file,\r\n /var/lib/connman/interfaces.config with DHCP settings for each interface.\r\n\r\n The supported request modes on NG are:\r\n - dhcp_linklocal_all\r\n - disabled\r\n - static\r\n* integration/modules/test_nilrt_ip.py: Add more tests & fixes\r\nThe following tests should run just on CG:\r\n - test_ethernet\r\n - test_set_dhcp_only_all\r\n - test_set_linklocal_only_all\r\n - test_supported_adapter_modes\r\n\r\n The following tests should run just on NG:\r\n - test_dhcp_disable (new)\r\n - test_dhcp_static (new)\r\n - test_static_disable (new)\r\n\r\n The following tests should run on CG & NG:\r\n - test_down\r\n - test_set_dhcp_linklocal_all\r\n - test_static_all\r\n - test_up","created_at":"2018-10-08T06:49:34Z","updated_at":"2018-10-10T13:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7541cf34451e4deaa6be56ed8e977faf31fa2342","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/49926/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/49926/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/49926/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/6d280e2b7c6bb6d501d74e7393c11dd04fe6c6cb","head":{"label":"alexvasiu:dev/avasiu/fix_connman_master_config_upstream","ref":"dev/avasiu/fix_connman_master_config_upstream","sha":"6d280e2b7c6bb6d501d74e7393c11dd04fe6c6cb","user":{"login":"alexvasiu","id":13847052,"node_id":"MDQ6VXNlcjEzODQ3MDUy","avatar_url":"https://avatars0.githubusercontent.com/u/13847052?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvasiu","html_url":"https://github.com/alexvasiu","followers_url":"https://api.github.com/users/alexvasiu/followers","following_url":"https://api.github.com/users/alexvasiu/following{/other_user}","gists_url":"https://api.github.com/users/alexvasiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvasiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvasiu/subscriptions","organizations_url":"https://api.github.com/users/alexvasiu/orgs","repos_url":"https://api.github.com/users/alexvasiu/repos","events_url":"https://api.github.com/users/alexvasiu/events{/privacy}","received_events_url":"https://api.github.com/users/alexvasiu/received_events","type":"User","site_admin":false},"repo":{"id":114689417,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2ODk0MTc=","name":"salt","full_name":"alexvasiu/salt","private":false,"owner":{"login":"alexvasiu","id":13847052,"node_id":"MDQ6VXNlcjEzODQ3MDUy","avatar_url":"https://avatars0.githubusercontent.com/u/13847052?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvasiu","html_url":"https://github.com/alexvasiu","followers_url":"https://api.github.com/users/alexvasiu/followers","following_url":"https://api.github.com/users/alexvasiu/following{/other_user}","gists_url":"https://api.github.com/users/alexvasiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvasiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvasiu/subscriptions","organizations_url":"https://api.github.com/users/alexvasiu/orgs","repos_url":"https://api.github.com/users/alexvasiu/repos","events_url":"https://api.github.com/users/alexvasiu/events{/privacy}","received_events_url":"https://api.github.com/users/alexvasiu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexvasiu/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/alexvasiu/salt","forks_url":"https://api.github.com/repos/alexvasiu/salt/forks","keys_url":"https://api.github.com/repos/alexvasiu/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexvasiu/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexvasiu/salt/teams","hooks_url":"https://api.github.com/repos/alexvasiu/salt/hooks","issue_events_url":"https://api.github.com/repos/alexvasiu/salt/issues/events{/number}","events_url":"https://api.github.com/repos/alexvasiu/salt/events","assignees_url":"https://api.github.com/repos/alexvasiu/salt/assignees{/user}","branches_url":"https://api.github.com/repos/alexvasiu/salt/branches{/branch}","tags_url":"https://api.github.com/repos/alexvasiu/salt/tags","blobs_url":"https://api.github.com/repos/alexvasiu/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexvasiu/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexvasiu/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexvasiu/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexvasiu/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/alexvasiu/salt/languages","stargazers_url":"https://api.github.com/repos/alexvasiu/salt/stargazers","contributors_url":"https://api.github.com/repos/alexvasiu/salt/contributors","subscribers_url":"https://api.github.com/repos/alexvasiu/salt/subscribers","subscription_url":"https://api.github.com/repos/alexvasiu/salt/subscription","commits_url":"https://api.github.com/repos/alexvasiu/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexvasiu/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexvasiu/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexvasiu/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexvasiu/salt/contents/{+path}","compare_url":"https://api.github.com/repos/alexvasiu/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexvasiu/salt/merges","archive_url":"https://api.github.com/repos/alexvasiu/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexvasiu/salt/downloads","issues_url":"https://api.github.com/repos/alexvasiu/salt/issues{/number}","pulls_url":"https://api.github.com/repos/alexvasiu/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/alexvasiu/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/alexvasiu/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexvasiu/salt/labels{/name}","releases_url":"https://api.github.com/repos/alexvasiu/salt/releases{/id}","deployments_url":"https://api.github.com/repos/alexvasiu/salt/deployments","created_at":"2017-12-18T21:27:11Z","updated_at":"2018-03-23T10:56:22Z","pushed_at":"2018-10-10T13:33:27Z","git_url":"git://github.com/alexvasiu/salt.git","ssh_url":"git@github.com:alexvasiu/salt.git","clone_url":"https://github.com/alexvasiu/salt.git","svn_url":"https://github.com/alexvasiu/salt","homepage":"https://repo.saltstack.com/","size":415734,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"51662d56a78a9d84ae1cbce47ccee6c9a66c193d","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","private":false,"owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-10-10T13:35:10Z","pushed_at":"2018-10-10T13:44:30Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":417430,"stargazers_count":9280,"watchers_count":9280,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4329,"mirror_url":null,"archived":false,"open_issues_count":2527,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4329,"open_issues":2527,"watchers":9280,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/49926"},"html":{"href":"https://github.com/saltstack/salt/pull/49926"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/49926"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/49926/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/49926/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/49926/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/6d280e2b7c6bb6d501d74e7393c11dd04fe6c6cb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1390248,
"name": "saltstack/salt",
"url": "https://api.github.com/repos/saltstack/salt"
} | {
"id": 29376719,
"login": "rares-pop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29376719?",
"url": "https://api.github.com/users/rares-pop"
} | {
"id": 1147473,
"login": "saltstack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1147473?",
"url": "https://api.github.com/orgs/saltstack"
} | 2018-10-10T13:44:37 | 8397828267 | {"actor":{"display_login":"rares-pop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GannettDigital/simulato/pulls/comments/219933061","pull_request_review_id":158222260,"id":219933061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTkzMzA2MQ==","diff_hunk":"@@ -0,0 +1,798 @@\n+'use strict';\n+\n+const mockery = require('mockery');\n+const sinon = require('sinon');\n+const expect = require('chai').expect;\n+\n+describe('lib/runner/test-runner/action-json-writer.js', function() {\n+ describe('write', function() {\n+ let actionJsonWriter;\n+ let configHandler;\n+ let path;\n+ let fs;\n+ let report;\n+ let passingReport;\n+\n+ beforeEach(function() {\n+ configHandler = {\n+ get: sinon.stub(),\n+ };\n+ path = {\n+ resolve: sinon.stub(),\n+ };\n+ fs = {\n+ writeFileSync: sinon.stub(),\n+ readFileSync: sinon.stub(),\n+ };\n+ report = {\n+ testReports: [\n+ {\n+ status: 'fail',\n+ testRuns: [\n+ {\n+ report: {\n+ testName: 'testOne',\n+ actions: [\n+ {\n+ component: 'navigate',\n+ action: 'navigate',\n+ status: 'pass',\n+ time: [\n+ 1,\n+ 201697760,\n+ ],\n+ steps: {\n+ precondition: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ perform: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ effects: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ },\n+ },\n+ {\n+ component: 'article1',\n+ action: 'click',\n+ status: 'fail',\n+ time: [\n+ 1,\n+ 201697760,\n+ ],\n+ steps: {\n+ perform: {\n+ status: 'fail',\n+ error: 'perform failed',\n+ },\n+ },\n+ },\n+ ],\n+ },\n+ },\n+ ],\n+ },\n+ ],\n+ };\n+\n+ passingReport = {\n+ testReports: [\n+ {\n+ status: 'fail',\n+ testRuns: [\n+ {\n+ report: {\n+ testName: 'testOne',\n+ actions: [\n+ {\n+ component: 'navigate',\n+ action: 'navigate',\n+ status: 'pass',\n+ time: [\n+ 1,\n+ 201697760,\n+ ],\n+ steps: {\n+ precondition: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ perform: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ effects: {\n+ status: 'pass',\n+ error: null,\n+ },\n+ },\n+ },\n+ ],\n+ },\n+ },\n+ ],\n+ },\n+ ],\n+ };\n+\n+ mockery.enable({useCleanCache: true});\n+ mockery.registerAllowable('../../../../../lib/runner/writers/action-json-writer.js');\n+ mockery.registerMock('fs', fs);\n+ mockery.registerMock('path', path);\n+ mockery.registerMock('../../util/config-handler.js', configHandler);\n+\n+ actionJsonWriter = require('../../../../../lib/runner/writers/action-json-writer.js');\n+ actionJsonWriter._getActionTestData = sinon.stub();\n+ actionJsonWriter._writeReports = sinon.stub();\n+ actionJsonWriter._checkActionForError = sinon.stub();\n+ });\n+\n+ afterEach(function() {\n+ mockery.resetCache();\n+ mockery.deregisterAll();\n+ mockery.disable();\n+ });\n+\n+ it('should call configHandler.get with \\'testPath\\'', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ });\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(configHandler.get.args).to.deep.equal([['testPath']]);\n+ });\n+\n+ it('should call path.resolve with testPath', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ });\n+ configHandler.get.returns('./testPath');\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(path.resolve.args).to.deep.equal([['./testPath']]);\n+ });\n+\n+ it('should call fs.readFileSync with the path to the test and \\'utf8\\'', function() {\n+ path.resolve.returns('./testpath');\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ });\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(fs.readFileSync.args).to.deep.equal([\n+ [\n+ './testpath/testOne',\n+ 'utf8',\n+ ],\n+ ]);\n+ });\n+\n+ it('should call actionJsonWriter._getActionTestData with action name passed in', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ });\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(actionJsonWriter._getActionTestData.args).to.deep.equal([['navigate.navigate'], ['article1.click']]);\n+ });\n+\n+ it('should call actionJsonWriter._checkActionForError with action and testData passed in', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ });\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(actionJsonWriter._checkActionForError.args).to.deep.equal([\n+ [\n+ {\n+ 'action': 'navigate',\n+ 'component': 'navigate',\n+ 'status': 'pass',\n+ 'steps': {\n+ 'effects': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ 'perform': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ 'precondition': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ },\n+ 'time': [\n+ 1,\n+ 201697760,\n+ ],\n+ },\n+ {\n+ 'averageTime': NaN,\n+ 'count': 2,\n+ },\n+ ],\n+ [\n+ {\n+ 'action': 'click',\n+ 'component': 'article1',\n+ 'status': 'fail',\n+ 'steps': {\n+ 'perform': {\n+ 'error': 'perform failed',\n+ 'status': 'fail',\n+ },\n+ },\n+ 'time': [\n+ 1,\n+ 201697760,\n+ ],\n+ },\n+ {\n+ 'averageTime': NaN,\n+ 'count': 2,\n+ },\n+ ],\n+ ]);\n+ });\n+\n+ describe('if there is an error in test data', function() {\n+ it('should push the error to to testData.failures', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ failures: [],\n+ });\n+\n+ actionJsonWriter._checkActionForError.returns({error: 'error'});\n+\n+ actionJsonWriter.write(report);\n+\n+ expect(actionJsonWriter._checkActionForError.args).to.deep.equal([\n+ [\n+ {\n+ 'action': 'navigate',\n+ 'component': 'navigate',\n+ 'status': 'pass',\n+ 'steps': {\n+ 'effects': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ 'perform': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ 'precondition': {\n+ 'error': null,\n+ 'status': 'pass',\n+ },\n+ },\n+ 'time': [\n+ 1,\n+ 201697760,\n+ ],\n+ },\n+ {\n+ 'averageTime': NaN,\n+ 'count': 2,\n+ 'failures': [\n+ {\n+ 'error': {\n+ 'error': 'error',\n+ },\n+ 'test': undefined,\n+ },\n+ {\n+ 'error': {\n+ 'error': 'error',\n+ },\n+ 'test': undefined,\n+ },\n+ ],\n+ },\n+ ],\n+ [\n+ {\n+ 'action': 'click',\n+ 'component': 'article1',\n+ 'status': 'fail',\n+ 'steps': {\n+ 'perform': {\n+ 'error': 'perform failed',\n+ 'status': 'fail',\n+ },\n+ },\n+ 'time': [\n+ 1,\n+ 201697760,\n+ ],\n+ },\n+ {\n+ 'averageTime': NaN,\n+ 'count': 2,\n+ 'failures': [\n+ {\n+ 'error': {\n+ 'error': 'error',\n+ },\n+ 'test': undefined,\n+ },\n+ {\n+ 'error': {\n+ 'error': 'error',\n+ },\n+ 'test': undefined,\n+ },\n+ ],\n+ },\n+ ],\n+ ]);\n+ });\n+\n+ it('should push the error to to testData.failures', function() {\n+ actionJsonWriter._getActionTestData.returns({\n+ count: 0,\n+ failures: [],\n+ });\n+ actionJsonWriter.write(passingReport);\n+\n+ expect(actionJsonWriter._checkActionForError.args).to.deep.equal([","path":"test/unit/lib/runner/writers/action-json-writer-tests.js","position":348,"original_position":348,"commit_id":"6151f5812bae151740e38e9d0555b53e292519a4","original_commit_id":"6151f5812bae151740e38e9d0555b53e292519a4","user":{"login":"tomrdale","id":32067409,"node_id":"MDQ6VXNlcjMyMDY3NDA5","avatar_url":"https://avatars0.githubusercontent.com/u/32067409?v=4","gravatar_id":"","url":"https://api.github.com/users/tomrdale","html_url":"https://github.com/tomrdale","followers_url":"https://api.github.com/users/tomrdale/followers","following_url":"https://api.github.com/users/tomrdale/following{/other_user}","gists_url":"https://api.github.com/users/tomrdale/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrdale/subscriptions","organizations_url":"https://api.github.com/users/tomrdale/orgs","repos_url":"https://api.github.com/users/tomrdale/repos","events_url":"https://api.github.com/users/tomrdale/events{/privacy}","received_events_url":"https://api.github.com/users/tomrdale/received_events","type":"User","site_admin":false},"body":"this looks like the same test as above","created_at":"2018-09-24T18:02:47Z","updated_at":"2018-09-24T18:07:14Z","html_url":"https://github.com/GannettDigital/simulato/pull/156#discussion_r219933061","pull_request_url":"https://api.github.com/repos/GannettDigital/simulato/pulls/156","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/comments/219933061"},"html":{"href":"https://github.com/GannettDigital/simulato/pull/156#discussion_r219933061"},"pull_request":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/GannettDigital/simulato/pulls/156","id":215327851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzI3ODUx","html_url":"https://github.com/GannettDigital/simulato/pull/156","diff_url":"https://github.com/GannettDigital/simulato/pull/156.diff","patch_url":"https://github.com/GannettDigital/simulato/pull/156.patch","issue_url":"https://api.github.com/repos/GannettDigital/simulato/issues/156","number":156,"state":"open","locked":false,"title":"Issue 155: Add a custom writer that generates report for QASymphony","user":{"login":"subarna55","id":35924576,"node_id":"MDQ6VXNlcjM1OTI0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/35924576?v=4","gravatar_id":"","url":"https://api.github.com/users/subarna55","html_url":"https://github.com/subarna55","followers_url":"https://api.github.com/users/subarna55/followers","following_url":"https://api.github.com/users/subarna55/following{/other_user}","gists_url":"https://api.github.com/users/subarna55/gists{/gist_id}","starred_url":"https://api.github.com/users/subarna55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subarna55/subscriptions","organizations_url":"https://api.github.com/users/subarna55/orgs","repos_url":"https://api.github.com/users/subarna55/repos","events_url":"https://api.github.com/users/subarna55/events{/privacy}","received_events_url":"https://api.github.com/users/subarna55/received_events","type":"User","site_admin":false},"body":"Resolves issue: #155 \r\n\r\nChanges proposed in this pull request:\r\n- Added a custom writer that can generate action reports for QASymphony\r\n-Added unit tests for action-jason-writer\r\n\r\n@GannettDigital/simulato-core-contributors","created_at":"2018-09-13T15:42:10Z","updated_at":"2018-09-24T18:07:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e6ec9a4345c04ae6f01af3a6c766f67c3ba674","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GannettDigital/simulato/pulls/156/commits","review_comments_url":"https://api.github.com/repos/GannettDigital/simulato/pulls/156/comments","review_comment_url":"https://api.github.com/repos/GannettDigital/simulato/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GannettDigital/simulato/issues/156/comments","statuses_url":"https://api.github.com/repos/GannettDigital/simulato/statuses/6151f5812bae151740e38e9d0555b53e292519a4","head":{"label":"subarna55:issue-155","ref":"issue-155","sha":"6151f5812bae151740e38e9d0555b53e292519a4","user":{"login":"subarna55","id":35924576,"node_id":"MDQ6VXNlcjM1OTI0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/35924576?v=4","gravatar_id":"","url":"https://api.github.com/users/subarna55","html_url":"https://github.com/subarna55","followers_url":"https://api.github.com/users/subarna55/followers","following_url":"https://api.github.com/users/subarna55/following{/other_user}","gists_url":"https://api.github.com/users/subarna55/gists{/gist_id}","starred_url":"https://api.github.com/users/subarna55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subarna55/subscriptions","organizations_url":"https://api.github.com/users/subarna55/orgs","repos_url":"https://api.github.com/users/subarna55/repos","events_url":"https://api.github.com/users/subarna55/events{/privacy}","received_events_url":"https://api.github.com/users/subarna55/received_events","type":"User","site_admin":false},"repo":{"id":147725276,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MjUyNzY=","name":"simulato","full_name":"subarna55/simulato","private":false,"owner":{"login":"subarna55","id":35924576,"node_id":"MDQ6VXNlcjM1OTI0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/35924576?v=4","gravatar_id":"","url":"https://api.github.com/users/subarna55","html_url":"https://github.com/subarna55","followers_url":"https://api.github.com/users/subarna55/followers","following_url":"https://api.github.com/users/subarna55/following{/other_user}","gists_url":"https://api.github.com/users/subarna55/gists{/gist_id}","starred_url":"https://api.github.com/users/subarna55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subarna55/subscriptions","organizations_url":"https://api.github.com/users/subarna55/orgs","repos_url":"https://api.github.com/users/subarna55/repos","events_url":"https://api.github.com/users/subarna55/events{/privacy}","received_events_url":"https://api.github.com/users/subarna55/received_events","type":"User","site_admin":false},"html_url":"https://github.com/subarna55/simulato","description":"A model based testing tool","fork":true,"url":"https://api.github.com/repos/subarna55/simulato","forks_url":"https://api.github.com/repos/subarna55/simulato/forks","keys_url":"https://api.github.com/repos/subarna55/simulato/keys{/key_id}","collaborators_url":"https://api.github.com/repos/subarna55/simulato/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/subarna55/simulato/teams","hooks_url":"https://api.github.com/repos/subarna55/simulato/hooks","issue_events_url":"https://api.github.com/repos/subarna55/simulato/issues/events{/number}","events_url":"https://api.github.com/repos/subarna55/simulato/events","assignees_url":"https://api.github.com/repos/subarna55/simulato/assignees{/user}","branches_url":"https://api.github.com/repos/subarna55/simulato/branches{/branch}","tags_url":"https://api.github.com/repos/subarna55/simulato/tags","blobs_url":"https://api.github.com/repos/subarna55/simulato/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/subarna55/simulato/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/subarna55/simulato/git/refs{/sha}","trees_url":"https://api.github.com/repos/subarna55/simulato/git/trees{/sha}","statuses_url":"https://api.github.com/repos/subarna55/simulato/statuses/{sha}","languages_url":"https://api.github.com/repos/subarna55/simulato/languages","stargazers_url":"https://api.github.com/repos/subarna55/simulato/stargazers","contributors_url":"https://api.github.com/repos/subarna55/simulato/contributors","subscribers_url":"https://api.github.com/repos/subarna55/simulato/subscribers","subscription_url":"https://api.github.com/repos/subarna55/simulato/subscription","commits_url":"https://api.github.com/repos/subarna55/simulato/commits{/sha}","git_commits_url":"https://api.github.com/repos/subarna55/simulato/git/commits{/sha}","comments_url":"https://api.github.com/repos/subarna55/simulato/comments{/number}","issue_comment_url":"https://api.github.com/repos/subarna55/simulato/issues/comments{/number}","contents_url":"https://api.github.com/repos/subarna55/simulato/contents/{+path}","compare_url":"https://api.github.com/repos/subarna55/simulato/compare/{base}...{head}","merges_url":"https://api.github.com/repos/subarna55/simulato/merges","archive_url":"https://api.github.com/repos/subarna55/simulato/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/subarna55/simulato/downloads","issues_url":"https://api.github.com/repos/subarna55/simulato/issues{/number}","pulls_url":"https://api.github.com/repos/subarna55/simulato/pulls{/number}","milestones_url":"https://api.github.com/repos/subarna55/simulato/milestones{/number}","notifications_url":"https://api.github.com/repos/subarna55/simulato/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/subarna55/simulato/labels{/name}","releases_url":"https://api.github.com/repos/subarna55/simulato/releases{/id}","deployments_url":"https://api.github.com/repos/subarna55/simulato/deployments","created_at":"2018-09-06T19:46:35Z","updated_at":"2018-09-06T19:46:38Z","pushed_at":"2018-09-24T17:50:12Z","git_url":"git://github.com/subarna55/simulato.git","ssh_url":"git@github.com:subarna55/simulato.git","clone_url":"https://github.com/subarna55/simulato.git","svn_url":"https://github.com/subarna55/simulato","homepage":"https://gannettdigital.github.io/simulato/","size":3282,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GannettDigital:master","ref":"master","sha":"445f0cd85779ae6ac705bbfd011651e536adfb9e","user":{"login":"GannettDigital","id":1149177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDkxNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1149177?v=4","gravatar_id":"","url":"https://api.github.com/users/GannettDigital","html_url":"https://github.com/GannettDigital","followers_url":"https://api.github.com/users/GannettDigital/followers","following_url":"https://api.github.com/users/GannettDigital/following{/other_user}","gists_url":"https://api.github.com/users/GannettDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GannettDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GannettDigital/subscriptions","organizations_url":"https://api.github.com/users/GannettDigital/orgs","repos_url":"https://api.github.com/users/GannettDigital/repos","events_url":"https://api.github.com/users/GannettDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GannettDigital/received_events","type":"Organization","site_admin":false},"repo":{"id":123987920,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5ODc5MjA=","name":"simulato","full_name":"GannettDigital/simulato","private":false,"owner":{"login":"GannettDigital","id":1149177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDkxNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1149177?v=4","gravatar_id":"","url":"https://api.github.com/users/GannettDigital","html_url":"https://github.com/GannettDigital","followers_url":"https://api.github.com/users/GannettDigital/followers","following_url":"https://api.github.com/users/GannettDigital/following{/other_user}","gists_url":"https://api.github.com/users/GannettDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GannettDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GannettDigital/subscriptions","organizations_url":"https://api.github.com/users/GannettDigital/orgs","repos_url":"https://api.github.com/users/GannettDigital/repos","events_url":"https://api.github.com/users/GannettDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GannettDigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GannettDigital/simulato","description":"A model based testing tool","fork":false,"url":"https://api.github.com/repos/GannettDigital/simulato","forks_url":"https://api.github.com/repos/GannettDigital/simulato/forks","keys_url":"https://api.github.com/repos/GannettDigital/simulato/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GannettDigital/simulato/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GannettDigital/simulato/teams","hooks_url":"https://api.github.com/repos/GannettDigital/simulato/hooks","issue_events_url":"https://api.github.com/repos/GannettDigital/simulato/issues/events{/number}","events_url":"https://api.github.com/repos/GannettDigital/simulato/events","assignees_url":"https://api.github.com/repos/GannettDigital/simulato/assignees{/user}","branches_url":"https://api.github.com/repos/GannettDigital/simulato/branches{/branch}","tags_url":"https://api.github.com/repos/GannettDigital/simulato/tags","blobs_url":"https://api.github.com/repos/GannettDigital/simulato/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GannettDigital/simulato/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GannettDigital/simulato/git/refs{/sha}","trees_url":"https://api.github.com/repos/GannettDigital/simulato/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GannettDigital/simulato/statuses/{sha}","languages_url":"https://api.github.com/repos/GannettDigital/simulato/languages","stargazers_url":"https://api.github.com/repos/GannettDigital/simulato/stargazers","contributors_url":"https://api.github.com/repos/GannettDigital/simulato/contributors","subscribers_url":"https://api.github.com/repos/GannettDigital/simulato/subscribers","subscription_url":"https://api.github.com/repos/GannettDigital/simulato/subscription","commits_url":"https://api.github.com/repos/GannettDigital/simulato/commits{/sha}","git_commits_url":"https://api.github.com/repos/GannettDigital/simulato/git/commits{/sha}","comments_url":"https://api.github.com/repos/GannettDigital/simulato/comments{/number}","issue_comment_url":"https://api.github.com/repos/GannettDigital/simulato/issues/comments{/number}","contents_url":"https://api.github.com/repos/GannettDigital/simulato/contents/{+path}","compare_url":"https://api.github.com/repos/GannettDigital/simulato/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GannettDigital/simulato/merges","archive_url":"https://api.github.com/repos/GannettDigital/simulato/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GannettDigital/simulato/downloads","issues_url":"https://api.github.com/repos/GannettDigital/simulato/issues{/number}","pulls_url":"https://api.github.com/repos/GannettDigital/simulato/pulls{/number}","milestones_url":"https://api.github.com/repos/GannettDigital/simulato/milestones{/number}","notifications_url":"https://api.github.com/repos/GannettDigital/simulato/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GannettDigital/simulato/labels{/name}","releases_url":"https://api.github.com/repos/GannettDigital/simulato/releases{/id}","deployments_url":"https://api.github.com/repos/GannettDigital/simulato/deployments","created_at":"2018-03-05T22:36:44Z","updated_at":"2018-09-17T20:18:15Z","pushed_at":"2018-09-24T17:50:13Z","git_url":"git://github.com/GannettDigital/simulato.git","ssh_url":"git@github.com:GannettDigital/simulato.git","clone_url":"https://github.com/GannettDigital/simulato.git","svn_url":"https://github.com/GannettDigital/simulato","homepage":"https://gannettdigital.github.io/simulato/","size":3677,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/156"},"html":{"href":"https://github.com/GannettDigital/simulato/pull/156"},"issue":{"href":"https://api.github.com/repos/GannettDigital/simulato/issues/156"},"comments":{"href":"https://api.github.com/repos/GannettDigital/simulato/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GannettDigital/simulato/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/GannettDigital/simulato/statuses/6151f5812bae151740e38e9d0555b53e292519a4"}},"author_association":"NONE"}} | {
"id": 123987920,
"name": "GannettDigital/simulato",
"url": "https://api.github.com/repos/GannettDigital/simulato"
} | {
"id": 32067409,
"login": "tomrdale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32067409?",
"url": "https://api.github.com/users/tomrdale"
} | {
"id": 1149177,
"login": "GannettDigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1149177?",
"url": "https://api.github.com/orgs/GannettDigital"
} | 2018-09-24T18:02:47 | 8312956128 | {"actor":{"display_login":"tomrdale"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/comments/176040078","pull_request_review_id":105670272,"id":176040078,"diff_hunk":"@@ -0,0 +1,16 @@\n+# -*- coding: utf-8 -*-","path":"invenio_pidstore/config.py","position":1,"original_position":1,"commit_id":"905aeb7f14905f71f54762f8aa1af9144105fbc5","original_commit_id":"905aeb7f14905f71f54762f8aa1af9144105fbc5","user":{"login":"lnielsen","id":1698163,"avatar_url":"https://avatars3.githubusercontent.com/u/1698163?v=4","gravatar_id":"","url":"https://api.github.com/users/lnielsen","html_url":"https://github.com/lnielsen","followers_url":"https://api.github.com/users/lnielsen/followers","following_url":"https://api.github.com/users/lnielsen/following{/other_user}","gists_url":"https://api.github.com/users/lnielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lnielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnielsen/subscriptions","organizations_url":"https://api.github.com/users/lnielsen/orgs","repos_url":"https://api.github.com/users/lnielsen/repos","events_url":"https://api.github.com/users/lnielsen/events{/privacy}","received_events_url":"https://api.github.com/users/lnielsen/received_events","type":"User","site_admin":false},"body":"I think you likely need to add this to the documentation as well similar to:\r\n\r\nhttps://github.com/inveniosoftware/invenio-rest/blob/master/docs/configuration.rst\r\nhttps://github.com/inveniosoftware/invenio-rest/blob/master/docs/index.rst\r\n","created_at":"2018-03-21T10:46:21Z","updated_at":"2018-03-21T10:46:21Z","html_url":"https://github.com/inveniosoftware/invenio-pidstore/pull/115#discussion_r176040078","pull_request_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/comments/176040078"},"html":{"href":"https://github.com/inveniosoftware/invenio-pidstore/pull/115#discussion_r176040078"},"pull_request":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115","id":176430870,"html_url":"https://github.com/inveniosoftware/invenio-pidstore/pull/115","diff_url":"https://github.com/inveniosoftware/invenio-pidstore/pull/115.diff","patch_url":"https://github.com/inveniosoftware/invenio-pidstore/pull/115.patch","issue_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/115","number":115,"state":"open","locked":false,"title":"config: add record id pid field name","user":{"login":"egabancho","id":582735,"avatar_url":"https://avatars2.githubusercontent.com/u/582735?v=4","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"body":"* Adds new config variable to set the name of the field of the record\r\n identifier field. By default, and for compatibility reasons, the name\r\n of the field is `control_number`","created_at":"2018-03-21T10:20:58Z","updated_at":"2018-03-21T10:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"632d85722b1112739932ebf26625cdc54a1d9e00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115/commits","review_comments_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115/comments","review_comment_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/115/comments","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/statuses/905aeb7f14905f71f54762f8aa1af9144105fbc5","head":{"label":"egabancho:pid-recid-field-config","ref":"pid-recid-field-config","sha":"905aeb7f14905f71f54762f8aa1af9144105fbc5","user":{"login":"egabancho","id":582735,"avatar_url":"https://avatars2.githubusercontent.com/u/582735?v=4","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"repo":{"id":43114275,"name":"invenio-pidstore","full_name":"egabancho/invenio-pidstore","owner":{"login":"egabancho","id":582735,"avatar_url":"https://avatars2.githubusercontent.com/u/582735?v=4","gravatar_id":"","url":"https://api.github.com/users/egabancho","html_url":"https://github.com/egabancho","followers_url":"https://api.github.com/users/egabancho/followers","following_url":"https://api.github.com/users/egabancho/following{/other_user}","gists_url":"https://api.github.com/users/egabancho/gists{/gist_id}","starred_url":"https://api.github.com/users/egabancho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egabancho/subscriptions","organizations_url":"https://api.github.com/users/egabancho/orgs","repos_url":"https://api.github.com/users/egabancho/repos","events_url":"https://api.github.com/users/egabancho/events{/privacy}","received_events_url":"https://api.github.com/users/egabancho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egabancho/invenio-pidstore","description":"Invenio module that stores and registers persistent identifiers.","fork":true,"url":"https://api.github.com/repos/egabancho/invenio-pidstore","forks_url":"https://api.github.com/repos/egabancho/invenio-pidstore/forks","keys_url":"https://api.github.com/repos/egabancho/invenio-pidstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egabancho/invenio-pidstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egabancho/invenio-pidstore/teams","hooks_url":"https://api.github.com/repos/egabancho/invenio-pidstore/hooks","issue_events_url":"https://api.github.com/repos/egabancho/invenio-pidstore/issues/events{/number}","events_url":"https://api.github.com/repos/egabancho/invenio-pidstore/events","assignees_url":"https://api.github.com/repos/egabancho/invenio-pidstore/assignees{/user}","branches_url":"https://api.github.com/repos/egabancho/invenio-pidstore/branches{/branch}","tags_url":"https://api.github.com/repos/egabancho/invenio-pidstore/tags","blobs_url":"https://api.github.com/repos/egabancho/invenio-pidstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egabancho/invenio-pidstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egabancho/invenio-pidstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/egabancho/invenio-pidstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egabancho/invenio-pidstore/statuses/{sha}","languages_url":"https://api.github.com/repos/egabancho/invenio-pidstore/languages","stargazers_url":"https://api.github.com/repos/egabancho/invenio-pidstore/stargazers","contributors_url":"https://api.github.com/repos/egabancho/invenio-pidstore/contributors","subscribers_url":"https://api.github.com/repos/egabancho/invenio-pidstore/subscribers","subscription_url":"https://api.github.com/repos/egabancho/invenio-pidstore/subscription","commits_url":"https://api.github.com/repos/egabancho/invenio-pidstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/egabancho/invenio-pidstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/egabancho/invenio-pidstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/egabancho/invenio-pidstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/egabancho/invenio-pidstore/contents/{+path}","compare_url":"https://api.github.com/repos/egabancho/invenio-pidstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egabancho/invenio-pidstore/merges","archive_url":"https://api.github.com/repos/egabancho/invenio-pidstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egabancho/invenio-pidstore/downloads","issues_url":"https://api.github.com/repos/egabancho/invenio-pidstore/issues{/number}","pulls_url":"https://api.github.com/repos/egabancho/invenio-pidstore/pulls{/number}","milestones_url":"https://api.github.com/repos/egabancho/invenio-pidstore/milestones{/number}","notifications_url":"https://api.github.com/repos/egabancho/invenio-pidstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egabancho/invenio-pidstore/labels{/name}","releases_url":"https://api.github.com/repos/egabancho/invenio-pidstore/releases{/id}","deployments_url":"https://api.github.com/repos/egabancho/invenio-pidstore/deployments","created_at":"2015-09-25T06:46:09Z","updated_at":"2015-09-25T06:46:10Z","pushed_at":"2018-03-21T10:19:47Z","git_url":"git://github.com/egabancho/invenio-pidstore.git","ssh_url":"git@github.com:egabancho/invenio-pidstore.git","clone_url":"https://github.com/egabancho/invenio-pidstore.git","svn_url":"https://github.com/egabancho/invenio-pidstore","homepage":"","size":184,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inveniosoftware:master","ref":"master","sha":"2d04cd11778bd9b9710722c327affe57d9122a01","user":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars1.githubusercontent.com/u/1157480?v=4","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":39133678,"name":"invenio-pidstore","full_name":"inveniosoftware/invenio-pidstore","owner":{"login":"inveniosoftware","id":1157480,"avatar_url":"https://avatars1.githubusercontent.com/u/1157480?v=4","gravatar_id":"","url":"https://api.github.com/users/inveniosoftware","html_url":"https://github.com/inveniosoftware","followers_url":"https://api.github.com/users/inveniosoftware/followers","following_url":"https://api.github.com/users/inveniosoftware/following{/other_user}","gists_url":"https://api.github.com/users/inveniosoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/inveniosoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inveniosoftware/subscriptions","organizations_url":"https://api.github.com/users/inveniosoftware/orgs","repos_url":"https://api.github.com/users/inveniosoftware/repos","events_url":"https://api.github.com/users/inveniosoftware/events{/privacy}","received_events_url":"https://api.github.com/users/inveniosoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inveniosoftware/invenio-pidstore","description":"Invenio module that stores and registers persistent identifiers.","fork":false,"url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore","forks_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/forks","keys_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/teams","hooks_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/hooks","issue_events_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/events{/number}","events_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/events","assignees_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/assignees{/user}","branches_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/branches{/branch}","tags_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/tags","blobs_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/statuses/{sha}","languages_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/languages","stargazers_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/stargazers","contributors_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/contributors","subscribers_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/subscribers","subscription_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/subscription","commits_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/contents/{+path}","compare_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/merges","archive_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/downloads","issues_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues{/number}","pulls_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls{/number}","milestones_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/milestones{/number}","notifications_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/labels{/name}","releases_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/releases{/id}","deployments_url":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/deployments","created_at":"2015-07-15T11:40:54Z","updated_at":"2018-03-18T13:46:39Z","pushed_at":"2018-03-21T10:20:58Z","git_url":"git://github.com/inveniosoftware/invenio-pidstore.git","ssh_url":"git@github.com:inveniosoftware/invenio-pidstore.git","clone_url":"https://github.com/inveniosoftware/invenio-pidstore.git","svn_url":"https://github.com/inveniosoftware/invenio-pidstore","homepage":"https://invenio-pidstore.readthedocs.io","size":291,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":19,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115"},"html":{"href":"https://github.com/inveniosoftware/invenio-pidstore/pull/115"},"issue":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/115"},"comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/inveniosoftware/invenio-pidstore/statuses/905aeb7f14905f71f54762f8aa1af9144105fbc5"}},"author_association":"MEMBER"}} | {
"id": 39133678,
"name": "inveniosoftware/invenio-pidstore",
"url": "https://api.github.com/repos/inveniosoftware/invenio-pidstore"
} | {
"id": 1698163,
"login": "lnielsen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1698163?",
"url": "https://api.github.com/users/lnielsen"
} | {
"id": 1157480,
"login": "inveniosoftware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1157480?",
"url": "https://api.github.com/orgs/inveniosoftware"
} | 2018-03-21T10:46:21 | 7412040667 | {"actor":{"display_login":"lnielsen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ninenines/ranch/pulls/comments/188656424","pull_request_review_id":120678511,"id":188656424,"diff_hunk":"@@ -272,6 +274,63 @@ procs1(Ref, Sup) ->\n \t\t[]\n \tend.\n \n+-spec wait_for_connections(ref(), '>' | '>=' | '==' | '=<', non_neg_integer()) -> ok;\n+\t(ref(), '<', pos_integer()) -> ok.\n+wait_for_connections(Ref, Op, NumConns) ->\n+\twait_for_connections(Ref, Op, NumConns, 1000).\n+\n+-spec wait_for_connections(ref(), '>' | '>=' | '==' | '=<', non_neg_integer(),\n+\tnon_neg_integer()) -> ok;\n+\t(ref(), '<', pos_integer(), non_neg_integer()) -> ok.\n+wait_for_connections(Ref, Op, NumConns, Interval) ->\n+\tif\n+\t\tis_integer(Interval) andalso Interval>=0 ->\n+\t\t\tok;\n+\t\ttrue ->\n+\t\t\terror(badarg)\n+\tend,\n+\tif\n+\t\tis_integer(NumConns) andalso NumConns>=0 ->\n+\t\t\tok;\n+\t\ttrue ->\n+\t\t\terror(badarg)\n+\tend,\n+\tcase Op of\n+\t\t'>' ->\n+\t\t\tok;\n+\t\t'>=' ->\n+\t\t\tok;\n+\t\t'==' ->\n+\t\t\tok;\n+\t\t'=<' ->\n+\t\t\tok;\n+\t\t'<' when NumConns>=1 ->\n+\t\t\tok;\n+\t\t_ ->\n+\t\t\terror(badarg)\n+\tend,","path":"src/ranch.erl","position":47,"original_position":47,"commit_id":"9c75fa2ee5a66529bea6f767b43657e49324ca72","original_commit_id":"9c75fa2ee5a66529bea6f767b43657e49324ca72","user":{"login":"essen","id":141739,"avatar_url":"https://avatars2.githubusercontent.com/u/141739?v=4","gravatar_id":"","url":"https://api.github.com/users/essen","html_url":"https://github.com/essen","followers_url":"https://api.github.com/users/essen/followers","following_url":"https://api.github.com/users/essen/following{/other_user}","gists_url":"https://api.github.com/users/essen/gists{/gist_id}","starred_url":"https://api.github.com/users/essen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essen/subscriptions","organizations_url":"https://api.github.com/users/essen/orgs","repos_url":"https://api.github.com/users/essen/repos","events_url":"https://api.github.com/users/essen/events{/privacy}","received_events_url":"https://api.github.com/users/essen/received_events","type":"User","site_admin":false},"body":"Not quite as expected lol. I'll merge and make it more to what I was thinking.","created_at":"2018-05-16T14:53:37Z","updated_at":"2018-05-16T14:53:37Z","html_url":"https://github.com/ninenines/ranch/pull/191#discussion_r188656424","pull_request_url":"https://api.github.com/repos/ninenines/ranch/pulls/191","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/comments/188656424"},"html":{"href":"https://github.com/ninenines/ranch/pull/191#discussion_r188656424"},"pull_request":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/ninenines/ranch/pulls/191","id":187168224,"html_url":"https://github.com/ninenines/ranch/pull/191","diff_url":"https://github.com/ninenines/ranch/pull/191.diff","patch_url":"https://github.com/ninenines/ranch/pull/191.patch","issue_url":"https://api.github.com/repos/ninenines/ranch/issues/191","number":191,"state":"open","locked":false,"title":"Wait for connections","user":{"login":"juhlig","id":23236642,"avatar_url":"https://avatars1.githubusercontent.com/u/23236642?v=4","gravatar_id":"","url":"https://api.github.com/users/juhlig","html_url":"https://github.com/juhlig","followers_url":"https://api.github.com/users/juhlig/followers","following_url":"https://api.github.com/users/juhlig/following{/other_user}","gists_url":"https://api.github.com/users/juhlig/gists{/gist_id}","starred_url":"https://api.github.com/users/juhlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhlig/subscriptions","organizations_url":"https://api.github.com/users/juhlig/orgs","repos_url":"https://api.github.com/users/juhlig/repos","events_url":"https://api.github.com/users/juhlig/events{/privacy}","received_events_url":"https://api.github.com/users/juhlig/received_events","type":"User","site_admin":false},"body":"`wait_for_connections` functions as discussed in issue #175.\r\n\r\nThere are currently no checks for validity of the `Operator` and `NumConnections` args in place. Providing invalid arguments (undefined operator, negative number of connections, operator `'<'` and number of connections `0`, etc) is thus possible but causes the wait to never finish. If you want checks in place, just tell me.\r\n\r\nThe documentation commit also contains an addition for the `info/1` function that was introduced with PR #184 but undocumented, and fix for a typo from the same PR.","created_at":"2018-05-10T11:28:26Z","updated_at":"2018-05-16T14:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a1595c17596f71944959cdfc1866191d8774589","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ninenines/ranch/pulls/191/commits","review_comments_url":"https://api.github.com/repos/ninenines/ranch/pulls/191/comments","review_comment_url":"https://api.github.com/repos/ninenines/ranch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninenines/ranch/issues/191/comments","statuses_url":"https://api.github.com/repos/ninenines/ranch/statuses/9c75fa2ee5a66529bea6f767b43657e49324ca72","head":{"label":"juhlig2:wait_for_connections","ref":"wait_for_connections","sha":"9c75fa2ee5a66529bea6f767b43657e49324ca72","user":{"login":"juhlig2","id":37176822,"avatar_url":"https://avatars3.githubusercontent.com/u/37176822?v=4","gravatar_id":"","url":"https://api.github.com/users/juhlig2","html_url":"https://github.com/juhlig2","followers_url":"https://api.github.com/users/juhlig2/followers","following_url":"https://api.github.com/users/juhlig2/following{/other_user}","gists_url":"https://api.github.com/users/juhlig2/gists{/gist_id}","starred_url":"https://api.github.com/users/juhlig2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhlig2/subscriptions","organizations_url":"https://api.github.com/users/juhlig2/orgs","repos_url":"https://api.github.com/users/juhlig2/repos","events_url":"https://api.github.com/users/juhlig2/events{/privacy}","received_events_url":"https://api.github.com/users/juhlig2/received_events","type":"Organization","site_admin":false},"repo":{"id":131971977,"name":"ranch","full_name":"juhlig2/ranch","owner":{"login":"juhlig2","id":37176822,"avatar_url":"https://avatars3.githubusercontent.com/u/37176822?v=4","gravatar_id":"","url":"https://api.github.com/users/juhlig2","html_url":"https://github.com/juhlig2","followers_url":"https://api.github.com/users/juhlig2/followers","following_url":"https://api.github.com/users/juhlig2/following{/other_user}","gists_url":"https://api.github.com/users/juhlig2/gists{/gist_id}","starred_url":"https://api.github.com/users/juhlig2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhlig2/subscriptions","organizations_url":"https://api.github.com/users/juhlig2/orgs","repos_url":"https://api.github.com/users/juhlig2/repos","events_url":"https://api.github.com/users/juhlig2/events{/privacy}","received_events_url":"https://api.github.com/users/juhlig2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juhlig2/ranch","description":"Socket acceptor pool for TCP protocols.","fork":true,"url":"https://api.github.com/repos/juhlig2/ranch","forks_url":"https://api.github.com/repos/juhlig2/ranch/forks","keys_url":"https://api.github.com/repos/juhlig2/ranch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juhlig2/ranch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juhlig2/ranch/teams","hooks_url":"https://api.github.com/repos/juhlig2/ranch/hooks","issue_events_url":"https://api.github.com/repos/juhlig2/ranch/issues/events{/number}","events_url":"https://api.github.com/repos/juhlig2/ranch/events","assignees_url":"https://api.github.com/repos/juhlig2/ranch/assignees{/user}","branches_url":"https://api.github.com/repos/juhlig2/ranch/branches{/branch}","tags_url":"https://api.github.com/repos/juhlig2/ranch/tags","blobs_url":"https://api.github.com/repos/juhlig2/ranch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juhlig2/ranch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juhlig2/ranch/git/refs{/sha}","trees_url":"https://api.github.com/repos/juhlig2/ranch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juhlig2/ranch/statuses/{sha}","languages_url":"https://api.github.com/repos/juhlig2/ranch/languages","stargazers_url":"https://api.github.com/repos/juhlig2/ranch/stargazers","contributors_url":"https://api.github.com/repos/juhlig2/ranch/contributors","subscribers_url":"https://api.github.com/repos/juhlig2/ranch/subscribers","subscription_url":"https://api.github.com/repos/juhlig2/ranch/subscription","commits_url":"https://api.github.com/repos/juhlig2/ranch/commits{/sha}","git_commits_url":"https://api.github.com/repos/juhlig2/ranch/git/commits{/sha}","comments_url":"https://api.github.com/repos/juhlig2/ranch/comments{/number}","issue_comment_url":"https://api.github.com/repos/juhlig2/ranch/issues/comments{/number}","contents_url":"https://api.github.com/repos/juhlig2/ranch/contents/{+path}","compare_url":"https://api.github.com/repos/juhlig2/ranch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juhlig2/ranch/merges","archive_url":"https://api.github.com/repos/juhlig2/ranch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juhlig2/ranch/downloads","issues_url":"https://api.github.com/repos/juhlig2/ranch/issues{/number}","pulls_url":"https://api.github.com/repos/juhlig2/ranch/pulls{/number}","milestones_url":"https://api.github.com/repos/juhlig2/ranch/milestones{/number}","notifications_url":"https://api.github.com/repos/juhlig2/ranch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juhlig2/ranch/labels{/name}","releases_url":"https://api.github.com/repos/juhlig2/ranch/releases{/id}","deployments_url":"https://api.github.com/repos/juhlig2/ranch/deployments","created_at":"2018-05-03T09:24:13Z","updated_at":"2018-05-07T14:07:34Z","pushed_at":"2018-05-14T12:05:21Z","git_url":"git://github.com/juhlig2/ranch.git","ssh_url":"git@github.com:juhlig2/ranch.git","clone_url":"https://github.com/juhlig2/ranch.git","svn_url":"https://github.com/juhlig2/ranch","homepage":"","size":658,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninenines:master","ref":"master","sha":"301f582b97f82e7f7dc2d41bb575671bcc30215e","user":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars0.githubusercontent.com/u/1166740?v=4","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"repo":{"id":3944995,"name":"ranch","full_name":"ninenines/ranch","owner":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars0.githubusercontent.com/u/1166740?v=4","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninenines/ranch","description":"Socket acceptor pool for TCP protocols.","fork":false,"url":"https://api.github.com/repos/ninenines/ranch","forks_url":"https://api.github.com/repos/ninenines/ranch/forks","keys_url":"https://api.github.com/repos/ninenines/ranch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninenines/ranch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninenines/ranch/teams","hooks_url":"https://api.github.com/repos/ninenines/ranch/hooks","issue_events_url":"https://api.github.com/repos/ninenines/ranch/issues/events{/number}","events_url":"https://api.github.com/repos/ninenines/ranch/events","assignees_url":"https://api.github.com/repos/ninenines/ranch/assignees{/user}","branches_url":"https://api.github.com/repos/ninenines/ranch/branches{/branch}","tags_url":"https://api.github.com/repos/ninenines/ranch/tags","blobs_url":"https://api.github.com/repos/ninenines/ranch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninenines/ranch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninenines/ranch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninenines/ranch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninenines/ranch/statuses/{sha}","languages_url":"https://api.github.com/repos/ninenines/ranch/languages","stargazers_url":"https://api.github.com/repos/ninenines/ranch/stargazers","contributors_url":"https://api.github.com/repos/ninenines/ranch/contributors","subscribers_url":"https://api.github.com/repos/ninenines/ranch/subscribers","subscription_url":"https://api.github.com/repos/ninenines/ranch/subscription","commits_url":"https://api.github.com/repos/ninenines/ranch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninenines/ranch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninenines/ranch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninenines/ranch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninenines/ranch/contents/{+path}","compare_url":"https://api.github.com/repos/ninenines/ranch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninenines/ranch/merges","archive_url":"https://api.github.com/repos/ninenines/ranch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninenines/ranch/downloads","issues_url":"https://api.github.com/repos/ninenines/ranch/issues{/number}","pulls_url":"https://api.github.com/repos/ninenines/ranch/pulls{/number}","milestones_url":"https://api.github.com/repos/ninenines/ranch/milestones{/number}","notifications_url":"https://api.github.com/repos/ninenines/ranch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninenines/ranch/labels{/name}","releases_url":"https://api.github.com/repos/ninenines/ranch/releases{/id}","deployments_url":"https://api.github.com/repos/ninenines/ranch/deployments","created_at":"2012-04-05T23:06:16Z","updated_at":"2018-05-15T15:08:19Z","pushed_at":"2018-05-14T12:05:22Z","git_url":"git://github.com/ninenines/ranch.git","ssh_url":"git@github.com:ninenines/ranch.git","clone_url":"https://github.com/ninenines/ranch.git","svn_url":"https://github.com/ninenines/ranch","homepage":"","size":601,"stargazers_count":795,"watchers_count":795,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":252,"open_issues":16,"watchers":795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/191"},"html":{"href":"https://github.com/ninenines/ranch/pull/191"},"issue":{"href":"https://api.github.com/repos/ninenines/ranch/issues/191"},"comments":{"href":"https://api.github.com/repos/ninenines/ranch/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninenines/ranch/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/ninenines/ranch/statuses/9c75fa2ee5a66529bea6f767b43657e49324ca72"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3944995,
"name": "ninenines/ranch",
"url": "https://api.github.com/repos/ninenines/ranch"
} | {
"id": 141739,
"login": "essen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/141739?",
"url": "https://api.github.com/users/essen"
} | {
"id": 1166740,
"login": "ninenines",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1166740?",
"url": "https://api.github.com/orgs/ninenines"
} | 2018-05-16T14:53:37 | 7683885619 | {"actor":{"display_login":"essen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/165803483","pull_request_review_id":93805560,"id":165803483,"diff_hunk":"@@ -0,0 +1,20 @@\n+LIB = $(top_builddir)/lib\n+\n+AM_CFLAGS = \\\n+ -I$(srcdir) \\\n+ -I$(top_srcdir)/example \\\n+ -I$(top_srcdir)/platform/@with_platform@/include \\\n+ -I$(top_srcdir)/include/ \\\n+ -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@ \\\n+ -I$(top_srcdir)/helper/include \\\n+ -I$(top_builddir)/platform/@with_platform@/include \\\n+ -I$(top_srcdir)/platform/@with_platform@/arch/@ARCH_DIR@ \\\n+ -I$(top_builddir)/include \\\n+ -I$(PAPI_PATH)/include","path":"example/instrum/Makefile.am","position":13,"original_position":13,"commit_id":"5abc93432479fa968cc1932c8c802aae2d187997","original_commit_id":"1425e02cbb2c8e34c776f1bab6ff280c88bde37f","user":{"login":"lumag","id":20323,"avatar_url":"https://avatars2.githubusercontent.com/u/20323?v=4","gravatar_id":"","url":"https://api.github.com/users/lumag","html_url":"https://github.com/lumag","followers_url":"https://api.github.com/users/lumag/followers","following_url":"https://api.github.com/users/lumag/following{/other_user}","gists_url":"https://api.github.com/users/lumag/gists{/gist_id}","starred_url":"https://api.github.com/users/lumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumag/subscriptions","organizations_url":"https://api.github.com/users/lumag/orgs","repos_url":"https://api.github.com/users/lumag/repos","events_url":"https://api.github.com/users/lumag/events{/privacy}","received_events_url":"https://api.github.com/users/lumag/received_events","type":"User","site_admin":false},"body":"Please restructure include flags:\r\n - Use `$(ODP_INCLUDES)` to get all ODP includes\r\n - Use `$(PAPI_CFLAGS)` here.","created_at":"2018-02-03T03:27:29Z","updated_at":"2018-02-03T03:36:49Z","html_url":"https://github.com/Linaro/odp/pull/443#discussion_r165803483","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/443","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/165803483"},"html":{"href":"https://github.com/Linaro/odp/pull/443#discussion_r165803483"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/443","id":166540861,"html_url":"https://github.com/Linaro/odp/pull/443","diff_url":"https://github.com/Linaro/odp/pull/443.diff","patch_url":"https://github.com/Linaro/odp/pull/443.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/443","number":443,"state":"open","locked":false,"title":"[PATCH v1] Code instrumentation with PAPI library","user":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"body":"ODP API instrumentation with PAPI (Performance API) library (http://icl.cs.utk.edu/papi)\r\n\r\n\"instrum\" example is using library preload, symbols overloading and PAPI to obtain performance counters (like data cache miss or conditional branch count) for execution of ODP API calls. Performance counters are saved in CSV file format and can be presented in a graphical form (with Excel or similar).\r\n\r\nBuild:\r\n./bootstrap\r\n./configure --with-papi-path=< path to papi install> --with-code-instrum-profile=<ddf|scheduler|all>\r\nmake clean\r\nmake\r\n\r\nConfigure path to papi install:\r\n--with-papi-path= < path to papi install>\r\n\r\nConfigure instrumented ODP API:\r\n--with-code-instrum-profile=<ddf|scheduler|all>\r\nDefault: all\r\n\r\nStorage directory:\r\nexport ODP_INSTRUM_STORE_DIR= < folder to store csv files >\r\nDefault directory: /tmp\r\ne.g.\r\nexport ODP_INSTRUM_STORE_DIR=/home/bopi/Work/linaro/store\r\n\r\nConfigure PAPI events set:\r\nexport ODP_INSTRUM_PAPI_EVENTS=\r\nDefault: PAPI_BR_CN,PAPI_L2_DCM\r\ne.g:\r\nexport ODP_INSTRUM_PAPI_EVENTS=PAPI_BR_CN,PAPI_L2_DCM,PAPI_BR_UCN\r\n\r\nSet load library path:\r\nexport LD_LIBRARY_PATH=$LD_LIBRARY_PATH::\r\ne.g.\r\nexport LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/bopi/Work/linaro/odp/lib/.libs:/home/bopi/Work/linaro/papi_inst/lib\r\n\r\nRun:\r\nLD_PRELOAD=libinstrum.so.0.0.0 ./example/generator/.libs/odp_generator -I eth1 -m r -c 0x8","created_at":"2018-02-01T13:45:43Z","updated_at":"2018-02-03T03:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7eb054a87f5e31ccdca856470dd8e2ce0dcdd1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/443/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/443/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/443/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/5abc93432479fa968cc1932c8c802aae2d187997","head":{"label":"bogdanPricope:master_benchmark_pr","ref":"master_benchmark_pr","sha":"5abc93432479fa968cc1932c8c802aae2d187997","user":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"repo":{"id":94429694,"name":"odp","full_name":"bogdanPricope/odp","owner":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdanPricope/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/bogdanPricope/odp","forks_url":"https://api.github.com/repos/bogdanPricope/odp/forks","keys_url":"https://api.github.com/repos/bogdanPricope/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdanPricope/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdanPricope/odp/teams","hooks_url":"https://api.github.com/repos/bogdanPricope/odp/hooks","issue_events_url":"https://api.github.com/repos/bogdanPricope/odp/issues/events{/number}","events_url":"https://api.github.com/repos/bogdanPricope/odp/events","assignees_url":"https://api.github.com/repos/bogdanPricope/odp/assignees{/user}","branches_url":"https://api.github.com/repos/bogdanPricope/odp/branches{/branch}","tags_url":"https://api.github.com/repos/bogdanPricope/odp/tags","blobs_url":"https://api.github.com/repos/bogdanPricope/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdanPricope/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdanPricope/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdanPricope/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdanPricope/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdanPricope/odp/languages","stargazers_url":"https://api.github.com/repos/bogdanPricope/odp/stargazers","contributors_url":"https://api.github.com/repos/bogdanPricope/odp/contributors","subscribers_url":"https://api.github.com/repos/bogdanPricope/odp/subscribers","subscription_url":"https://api.github.com/repos/bogdanPricope/odp/subscription","commits_url":"https://api.github.com/repos/bogdanPricope/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdanPricope/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdanPricope/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdanPricope/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdanPricope/odp/contents/{+path}","compare_url":"https://api.github.com/repos/bogdanPricope/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdanPricope/odp/merges","archive_url":"https://api.github.com/repos/bogdanPricope/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdanPricope/odp/downloads","issues_url":"https://api.github.com/repos/bogdanPricope/odp/issues{/number}","pulls_url":"https://api.github.com/repos/bogdanPricope/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdanPricope/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdanPricope/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdanPricope/odp/labels{/name}","releases_url":"https://api.github.com/repos/bogdanPricope/odp/releases{/id}","deployments_url":"https://api.github.com/repos/bogdanPricope/odp/deployments","created_at":"2017-06-15T10:42:06Z","updated_at":"2017-06-15T10:42:09Z","pushed_at":"2018-02-01T11:53:13Z","git_url":"git://github.com/bogdanPricope/odp.git","ssh_url":"git@github.com:bogdanPricope/odp.git","clone_url":"https://github.com/bogdanPricope/odp.git","svn_url":"https://github.com/bogdanPricope/odp","homepage":"http://www.opendataplane.org/","size":9686,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:master","ref":"master","sha":"b95ccd3db6eeb7358a877541747e06354429acdd","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2018-02-01T11:11:45Z","pushed_at":"2018-02-03T03:23:28Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":10657,"stargazers_count":37,"watchers_count":37,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":47,"open_issues":26,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/443"},"html":{"href":"https://github.com/Linaro/odp/pull/443"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/443"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/5abc93432479fa968cc1932c8c802aae2d187997"}},"author_association":"CONTRIBUTOR"}} | {
"id": 79130215,
"name": "Linaro/odp",
"url": "https://api.github.com/repos/Linaro/odp"
} | {
"id": 20323,
"login": "lumag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20323?",
"url": "https://api.github.com/users/lumag"
} | {
"id": 1180626,
"login": "Linaro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1180626?",
"url": "https://api.github.com/orgs/Linaro"
} | 2018-02-03T03:27:29 | 7192442941 | {"actor":{"display_login":"lumag"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/comments/184981786","pull_request_review_id":116280818,"id":184981786,"diff_hunk":"@@ -62,5 +62,5 @@\n --q-link-color: var(--q-color-primary-5);\n \n /* layout */\n- --q-space-base: 16px;\n+ --q-space-base: 8px;","path":"client/src/styles/config.css","position":5,"original_position":5,"commit_id":"8d5b07ea9f33f5726fdc84542efbd20f94ae710c","original_commit_id":"8d5b07ea9f33f5726fdc84542efbd20f94ae710c","user":{"login":"benib","id":821875,"avatar_url":"https://avatars0.githubusercontent.com/u/821875?v=4","gravatar_id":"","url":"https://api.github.com/users/benib","html_url":"https://github.com/benib","followers_url":"https://api.github.com/users/benib/followers","following_url":"https://api.github.com/users/benib/following{/other_user}","gists_url":"https://api.github.com/users/benib/gists{/gist_id}","starred_url":"https://api.github.com/users/benib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benib/subscriptions","organizations_url":"https://api.github.com/users/benib/orgs","repos_url":"https://api.github.com/users/benib/repos","events_url":"https://api.github.com/users/benib/events{/privacy}","received_events_url":"https://api.github.com/users/benib/received_events","type":"User","site_admin":false},"body":"This should be either kept at 16px or the calculation needs to be adjusted everywhere where this is used.","created_at":"2018-04-30T13:10:49Z","updated_at":"2018-04-30T13:12:58Z","html_url":"https://github.com/nzzdev/Q-editor/pull/116#discussion_r184981786","pull_request_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/comments/184981786"},"html":{"href":"https://github.com/nzzdev/Q-editor/pull/116#discussion_r184981786"},"pull_request":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116","id":184606784,"html_url":"https://github.com/nzzdev/Q-editor/pull/116","diff_url":"https://github.com/nzzdev/Q-editor/pull/116.diff","patch_url":"https://github.com/nzzdev/Q-editor/pull/116.patch","issue_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/116","number":116,"state":"open","locked":false,"title":"Move q-bar to top (header redesign)","user":{"login":"manuelroth","id":1810384,"avatar_url":"https://avatars0.githubusercontent.com/u/1810384?v=4","gravatar_id":"","url":"https://api.github.com/users/manuelroth","html_url":"https://github.com/manuelroth","followers_url":"https://api.github.com/users/manuelroth/followers","following_url":"https://api.github.com/users/manuelroth/following{/other_user}","gists_url":"https://api.github.com/users/manuelroth/gists{/gist_id}","starred_url":"https://api.github.com/users/manuelroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuelroth/subscriptions","organizations_url":"https://api.github.com/users/manuelroth/orgs","repos_url":"https://api.github.com/users/manuelroth/repos","events_url":"https://api.github.com/users/manuelroth/events{/privacy}","received_events_url":"https://api.github.com/users/manuelroth/received_events","type":"User","site_admin":false},"body":"- This PR moves the q-bar to the top and integrates the status-bar into q-bar\r\n- The q-bar is now part of each page. It is customized for each page using the custom element slot feature. For example the index page doesn't have the back button and feed/item-detail/editor pages don't have the logo but show the back button\r\n- This branch is deployed on staging and q-beta for testing -> https://q.st-staging.nzz.ch/index","created_at":"2018-04-27T12:21:50Z","updated_at":"2018-04-30T13:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42176eafb2ec4756ca914041015ffb57d55c62a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116/commits","review_comments_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116/comments","review_comment_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/116/comments","statuses_url":"https://api.github.com/repos/nzzdev/Q-editor/statuses/8d5b07ea9f33f5726fdc84542efbd20f94ae710c","head":{"label":"nzzdev:feat-redesign-header","ref":"feat-redesign-header","sha":"8d5b07ea9f33f5726fdc84542efbd20f94ae710c","user":{"login":"nzzdev","id":1212529,"avatar_url":"https://avatars1.githubusercontent.com/u/1212529?v=4","gravatar_id":"","url":"https://api.github.com/users/nzzdev","html_url":"https://github.com/nzzdev","followers_url":"https://api.github.com/users/nzzdev/followers","following_url":"https://api.github.com/users/nzzdev/following{/other_user}","gists_url":"https://api.github.com/users/nzzdev/gists{/gist_id}","starred_url":"https://api.github.com/users/nzzdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzzdev/subscriptions","organizations_url":"https://api.github.com/users/nzzdev/orgs","repos_url":"https://api.github.com/users/nzzdev/repos","events_url":"https://api.github.com/users/nzzdev/events{/privacy}","received_events_url":"https://api.github.com/users/nzzdev/received_events","type":"Organization","site_admin":false},"repo":{"id":81865109,"name":"Q-editor","full_name":"nzzdev/Q-editor","owner":{"login":"nzzdev","id":1212529,"avatar_url":"https://avatars1.githubusercontent.com/u/1212529?v=4","gravatar_id":"","url":"https://api.github.com/users/nzzdev","html_url":"https://github.com/nzzdev","followers_url":"https://api.github.com/users/nzzdev/followers","following_url":"https://api.github.com/users/nzzdev/following{/other_user}","gists_url":"https://api.github.com/users/nzzdev/gists{/gist_id}","starred_url":"https://api.github.com/users/nzzdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzzdev/subscriptions","organizations_url":"https://api.github.com/users/nzzdev/orgs","repos_url":"https://api.github.com/users/nzzdev/repos","events_url":"https://api.github.com/users/nzzdev/events{/privacy}","received_events_url":"https://api.github.com/users/nzzdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nzzdev/Q-editor","description":"This is the editor for the Q Toolbox.","fork":false,"url":"https://api.github.com/repos/nzzdev/Q-editor","forks_url":"https://api.github.com/repos/nzzdev/Q-editor/forks","keys_url":"https://api.github.com/repos/nzzdev/Q-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nzzdev/Q-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nzzdev/Q-editor/teams","hooks_url":"https://api.github.com/repos/nzzdev/Q-editor/hooks","issue_events_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/events{/number}","events_url":"https://api.github.com/repos/nzzdev/Q-editor/events","assignees_url":"https://api.github.com/repos/nzzdev/Q-editor/assignees{/user}","branches_url":"https://api.github.com/repos/nzzdev/Q-editor/branches{/branch}","tags_url":"https://api.github.com/repos/nzzdev/Q-editor/tags","blobs_url":"https://api.github.com/repos/nzzdev/Q-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nzzdev/Q-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nzzdev/Q-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/nzzdev/Q-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nzzdev/Q-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/nzzdev/Q-editor/languages","stargazers_url":"https://api.github.com/repos/nzzdev/Q-editor/stargazers","contributors_url":"https://api.github.com/repos/nzzdev/Q-editor/contributors","subscribers_url":"https://api.github.com/repos/nzzdev/Q-editor/subscribers","subscription_url":"https://api.github.com/repos/nzzdev/Q-editor/subscription","commits_url":"https://api.github.com/repos/nzzdev/Q-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/nzzdev/Q-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/nzzdev/Q-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/nzzdev/Q-editor/contents/{+path}","compare_url":"https://api.github.com/repos/nzzdev/Q-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nzzdev/Q-editor/merges","archive_url":"https://api.github.com/repos/nzzdev/Q-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nzzdev/Q-editor/downloads","issues_url":"https://api.github.com/repos/nzzdev/Q-editor/issues{/number}","pulls_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/nzzdev/Q-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/nzzdev/Q-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nzzdev/Q-editor/labels{/name}","releases_url":"https://api.github.com/repos/nzzdev/Q-editor/releases{/id}","deployments_url":"https://api.github.com/repos/nzzdev/Q-editor/deployments","created_at":"2017-02-13T19:56:44Z","updated_at":"2018-04-24T09:12:22Z","pushed_at":"2018-04-28T14:04:03Z","git_url":"git://github.com/nzzdev/Q-editor.git","ssh_url":"git@github.com:nzzdev/Q-editor.git","clone_url":"https://github.com/nzzdev/Q-editor.git","svn_url":"https://github.com/nzzdev/Q-editor","homepage":"","size":635,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":14,"watchers":21,"default_branch":"dev"}},"base":{"label":"nzzdev:dev","ref":"dev","sha":"c75c165d5134b19ebf345c37ffc3d518a689ad0d","user":{"login":"nzzdev","id":1212529,"avatar_url":"https://avatars1.githubusercontent.com/u/1212529?v=4","gravatar_id":"","url":"https://api.github.com/users/nzzdev","html_url":"https://github.com/nzzdev","followers_url":"https://api.github.com/users/nzzdev/followers","following_url":"https://api.github.com/users/nzzdev/following{/other_user}","gists_url":"https://api.github.com/users/nzzdev/gists{/gist_id}","starred_url":"https://api.github.com/users/nzzdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzzdev/subscriptions","organizations_url":"https://api.github.com/users/nzzdev/orgs","repos_url":"https://api.github.com/users/nzzdev/repos","events_url":"https://api.github.com/users/nzzdev/events{/privacy}","received_events_url":"https://api.github.com/users/nzzdev/received_events","type":"Organization","site_admin":false},"repo":{"id":81865109,"name":"Q-editor","full_name":"nzzdev/Q-editor","owner":{"login":"nzzdev","id":1212529,"avatar_url":"https://avatars1.githubusercontent.com/u/1212529?v=4","gravatar_id":"","url":"https://api.github.com/users/nzzdev","html_url":"https://github.com/nzzdev","followers_url":"https://api.github.com/users/nzzdev/followers","following_url":"https://api.github.com/users/nzzdev/following{/other_user}","gists_url":"https://api.github.com/users/nzzdev/gists{/gist_id}","starred_url":"https://api.github.com/users/nzzdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzzdev/subscriptions","organizations_url":"https://api.github.com/users/nzzdev/orgs","repos_url":"https://api.github.com/users/nzzdev/repos","events_url":"https://api.github.com/users/nzzdev/events{/privacy}","received_events_url":"https://api.github.com/users/nzzdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nzzdev/Q-editor","description":"This is the editor for the Q Toolbox.","fork":false,"url":"https://api.github.com/repos/nzzdev/Q-editor","forks_url":"https://api.github.com/repos/nzzdev/Q-editor/forks","keys_url":"https://api.github.com/repos/nzzdev/Q-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nzzdev/Q-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nzzdev/Q-editor/teams","hooks_url":"https://api.github.com/repos/nzzdev/Q-editor/hooks","issue_events_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/events{/number}","events_url":"https://api.github.com/repos/nzzdev/Q-editor/events","assignees_url":"https://api.github.com/repos/nzzdev/Q-editor/assignees{/user}","branches_url":"https://api.github.com/repos/nzzdev/Q-editor/branches{/branch}","tags_url":"https://api.github.com/repos/nzzdev/Q-editor/tags","blobs_url":"https://api.github.com/repos/nzzdev/Q-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nzzdev/Q-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nzzdev/Q-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/nzzdev/Q-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nzzdev/Q-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/nzzdev/Q-editor/languages","stargazers_url":"https://api.github.com/repos/nzzdev/Q-editor/stargazers","contributors_url":"https://api.github.com/repos/nzzdev/Q-editor/contributors","subscribers_url":"https://api.github.com/repos/nzzdev/Q-editor/subscribers","subscription_url":"https://api.github.com/repos/nzzdev/Q-editor/subscription","commits_url":"https://api.github.com/repos/nzzdev/Q-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/nzzdev/Q-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/nzzdev/Q-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/nzzdev/Q-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/nzzdev/Q-editor/contents/{+path}","compare_url":"https://api.github.com/repos/nzzdev/Q-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nzzdev/Q-editor/merges","archive_url":"https://api.github.com/repos/nzzdev/Q-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nzzdev/Q-editor/downloads","issues_url":"https://api.github.com/repos/nzzdev/Q-editor/issues{/number}","pulls_url":"https://api.github.com/repos/nzzdev/Q-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/nzzdev/Q-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/nzzdev/Q-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nzzdev/Q-editor/labels{/name}","releases_url":"https://api.github.com/repos/nzzdev/Q-editor/releases{/id}","deployments_url":"https://api.github.com/repos/nzzdev/Q-editor/deployments","created_at":"2017-02-13T19:56:44Z","updated_at":"2018-04-24T09:12:22Z","pushed_at":"2018-04-28T14:04:03Z","git_url":"git://github.com/nzzdev/Q-editor.git","ssh_url":"git@github.com:nzzdev/Q-editor.git","clone_url":"https://github.com/nzzdev/Q-editor.git","svn_url":"https://github.com/nzzdev/Q-editor","homepage":"","size":635,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":14,"watchers":21,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116"},"html":{"href":"https://github.com/nzzdev/Q-editor/pull/116"},"issue":{"href":"https://api.github.com/repos/nzzdev/Q-editor/issues/116"},"comments":{"href":"https://api.github.com/repos/nzzdev/Q-editor/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nzzdev/Q-editor/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/nzzdev/Q-editor/statuses/8d5b07ea9f33f5726fdc84542efbd20f94ae710c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 81865109,
"name": "nzzdev/Q-editor",
"url": "https://api.github.com/repos/nzzdev/Q-editor"
} | {
"id": 821875,
"login": "benib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/821875?",
"url": "https://api.github.com/users/benib"
} | {
"id": 1212529,
"login": "nzzdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1212529?",
"url": "https://api.github.com/orgs/nzzdev"
} | 2018-04-30T13:10:49 | 7606390347 | {"actor":{"display_login":"benib"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments/182867932","pull_request_review_id":113756322,"id":182867932,"diff_hunk":"@@ -628,7 +629,323 @@ public OptimizelyManager build(Context context) {\n try {\n logger = LoggerFactory.getLogger(OptimizelyManager.class);\n } catch (Exception e) {\n- logger = LoggerFactory.getLogger(\"com.optimizely.ab.android.sdk.OptimizelyManager\");\n+ try {\n+ logger = LoggerFactory.getLogger(\"com.optimizely.ab.android.sdk.OptimizelyManager\");\n+ }\n+ catch (Exception e1) {\n+ logger = new Logger() {","path":"android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java","position":17,"original_position":17,"commit_id":"04b0ccea3255b0f429278a51b510260594ffa548","original_commit_id":"04b0ccea3255b0f429278a51b510260594ffa548","user":{"login":"mikeng13","id":1365958,"avatar_url":"https://avatars3.githubusercontent.com/u/1365958?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},"body":"This is crazy haha. Can we create a class that encapsulates this and pull it in here?","created_at":"2018-04-19T20:01:52Z","updated_at":"2018-04-19T20:01:53Z","html_url":"https://github.com/optimizely/android-sdk/pull/195#discussion_r182867932","pull_request_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/195","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments/182867932"},"html":{"href":"https://github.com/optimizely/android-sdk/pull/195#discussion_r182867932"},"pull_request":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/optimizely/android-sdk/pulls/195","id":182858143,"html_url":"https://github.com/optimizely/android-sdk/pull/195","diff_url":"https://github.com/optimizely/android-sdk/pull/195.diff","patch_url":"https://github.com/optimizely/android-sdk/pull/195.patch","issue_url":"https://api.github.com/repos/optimizely/android-sdk/issues/195","number":195,"state":"open","locked":false,"title":"fix for blue apron by providing default logger if none is supplied.","user":{"login":"thomaszurkan-optimizely","id":28317449,"avatar_url":"https://avatars3.githubusercontent.com/u/28317449?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaszurkan-optimizely","html_url":"https://github.com/thomaszurkan-optimizely","followers_url":"https://api.github.com/users/thomaszurkan-optimizely/followers","following_url":"https://api.github.com/users/thomaszurkan-optimizely/following{/other_user}","gists_url":"https://api.github.com/users/thomaszurkan-optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaszurkan-optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaszurkan-optimizely/subscriptions","organizations_url":"https://api.github.com/users/thomaszurkan-optimizely/orgs","repos_url":"https://api.github.com/users/thomaszurkan-optimizely/repos","events_url":"https://api.github.com/users/thomaszurkan-optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/thomaszurkan-optimizely/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-19T18:18:31Z","updated_at":"2018-04-19T20:01:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36d2ba77ed6b1f706c30750231fa4e1e95422003","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/195/commits","review_comments_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/195/comments","review_comment_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/issues/195/comments","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/04b0ccea3255b0f429278a51b510260594ffa548","head":{"label":"optimizely:blueApron/fix","ref":"blueApron/fix","sha":"04b0ccea3255b0f429278a51b510260594ffa548","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":64177091,"name":"android-sdk","full_name":"optimizely/android-sdk","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/android-sdk","description":"Optimizely X Android SDK","fork":false,"url":"https://api.github.com/repos/optimizely/android-sdk","forks_url":"https://api.github.com/repos/optimizely/android-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/android-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/android-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/android-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/android-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/android-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/android-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/android-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/android-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/android-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/android-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/android-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/android-sdk/deployments","created_at":"2016-07-26T00:32:26Z","updated_at":"2018-04-13T22:37:14Z","pushed_at":"2018-04-19T18:18:33Z","git_url":"git://github.com/optimizely/android-sdk.git","ssh_url":"git@github.com:optimizely/android-sdk.git","clone_url":"https://github.com/optimizely/android-sdk.git","svn_url":"https://github.com/optimizely/android-sdk","homepage":"https://developers.optimizely.com/x/solutions/sdks/introduction/index.html?language=android&platform=mobile","size":1676,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":7,"watchers":11,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"ad9d888c1abb9a2ab1c47d9222583d17c846d10b","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":64177091,"name":"android-sdk","full_name":"optimizely/android-sdk","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars3.githubusercontent.com/u/1274132?v=4","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/android-sdk","description":"Optimizely X Android SDK","fork":false,"url":"https://api.github.com/repos/optimizely/android-sdk","forks_url":"https://api.github.com/repos/optimizely/android-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/android-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/android-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/android-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/android-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/android-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/android-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/android-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/android-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/android-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/android-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/android-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/android-sdk/deployments","created_at":"2016-07-26T00:32:26Z","updated_at":"2018-04-13T22:37:14Z","pushed_at":"2018-04-19T18:18:33Z","git_url":"git://github.com/optimizely/android-sdk.git","ssh_url":"git@github.com:optimizely/android-sdk.git","clone_url":"https://github.com/optimizely/android-sdk.git","svn_url":"https://github.com/optimizely/android-sdk","homepage":"https://developers.optimizely.com/x/solutions/sdks/introduction/index.html?language=android&platform=mobile","size":1676,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/195"},"html":{"href":"https://github.com/optimizely/android-sdk/pull/195"},"issue":{"href":"https://api.github.com/repos/optimizely/android-sdk/issues/195"},"comments":{"href":"https://api.github.com/repos/optimizely/android-sdk/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/android-sdk/statuses/04b0ccea3255b0f429278a51b510260594ffa548"}},"author_association":"CONTRIBUTOR"}} | {
"id": 64177091,
"name": "optimizely/android-sdk",
"url": "https://api.github.com/repos/optimizely/android-sdk"
} | {
"id": 1365958,
"login": "mikeng13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1365958?",
"url": "https://api.github.com/users/mikeng13"
} | {
"id": 1274132,
"login": "optimizely",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1274132?",
"url": "https://api.github.com/orgs/optimizely"
} | 2018-04-19T20:01:52 | 7557822355 | {"actor":{"display_login":"mikeng13"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pydata/xarray/pulls/comments/205994099","pull_request_review_id":141367580,"id":205994099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk5NDA5OQ==","diff_hunk":"@@ -181,9 +181,9 @@ def get_clean_interp_index(arr, dim, method, use_coordinate=True, **kwargs):\n # The division can change the nearest-neighbour\n # when compared to pandas (which does not divide).\n # Let's keep that compatitibility\n- index = (index - index.min())\n+ index = (index - index.mean())\n if len(index) > 1:\n- index /= index.std()\n+ index /= np.max(np.abs(index))","path":"xarray/core/missing.py","position":null,"original_position":8,"commit_id":"21c8c473ccee890705a5a0bdba9fbfd103a054c4","original_commit_id":"21c8c473ccee890705a5a0bdba9fbfd103a054c4","user":{"login":"shoyer","id":1217238,"node_id":"MDQ6VXNlcjEyMTcyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1217238?v=4","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"body":"This still needs a fix to account for possibly dividing by zero.\r\n\r\nAlso, I don't think you need abs() here because subtracting by mean() already centers the data.","created_at":"2018-07-30T00:43:00Z","updated_at":"2018-07-30T00:43:52Z","html_url":"https://github.com/pydata/xarray/pull/2328#discussion_r205994099","pull_request_url":"https://api.github.com/repos/pydata/xarray/pulls/2328","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments/205994099"},"html":{"href":"https://github.com/pydata/xarray/pull/2328#discussion_r205994099"},"pull_request":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2328"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/xarray/pulls/2328","id":204619664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjE5NjY0","html_url":"https://github.com/pydata/xarray/pull/2328","diff_url":"https://github.com/pydata/xarray/pull/2328.diff","patch_url":"https://github.com/pydata/xarray/pull/2328.patch","issue_url":"https://api.github.com/repos/pydata/xarray/issues/2328","number":2328,"state":"open","locked":false,"title":"Silence some warnings.","user":{"login":"dcherian","id":2448579,"node_id":"MDQ6VXNlcjI0NDg1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2448579?v=4","gravatar_id":"","url":"https://api.github.com/users/dcherian","html_url":"https://github.com/dcherian","followers_url":"https://api.github.com/users/dcherian/followers","following_url":"https://api.github.com/users/dcherian/following{/other_user}","gists_url":"https://api.github.com/users/dcherian/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherian/subscriptions","organizations_url":"https://api.github.com/users/dcherian/orgs","repos_url":"https://api.github.com/users/dcherian/repos","events_url":"https://api.github.com/users/dcherian/events{/privacy}","received_events_url":"https://api.github.com/users/dcherian/received_events","type":"User","site_admin":false},"body":" - [x] Tests passed (for all non-documentation changes)\r\n\r\nRemove some warnings.","created_at":"2018-07-29T01:46:27Z","updated_at":"2018-07-30T00:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28fb1bde61200839b170f40add4b58292c2b0946","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/xarray/pulls/2328/commits","review_comments_url":"https://api.github.com/repos/pydata/xarray/pulls/2328/comments","review_comment_url":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/xarray/issues/2328/comments","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/21c8c473ccee890705a5a0bdba9fbfd103a054c4","head":{"label":"dcherian:fix-some-warnings","ref":"fix-some-warnings","sha":"21c8c473ccee890705a5a0bdba9fbfd103a054c4","user":{"login":"dcherian","id":2448579,"node_id":"MDQ6VXNlcjI0NDg1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2448579?v=4","gravatar_id":"","url":"https://api.github.com/users/dcherian","html_url":"https://github.com/dcherian","followers_url":"https://api.github.com/users/dcherian/followers","following_url":"https://api.github.com/users/dcherian/following{/other_user}","gists_url":"https://api.github.com/users/dcherian/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherian/subscriptions","organizations_url":"https://api.github.com/users/dcherian/orgs","repos_url":"https://api.github.com/users/dcherian/repos","events_url":"https://api.github.com/users/dcherian/events{/privacy}","received_events_url":"https://api.github.com/users/dcherian/received_events","type":"User","site_admin":false},"repo":{"id":111721718,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3MjE3MTg=","name":"xarray","full_name":"dcherian/xarray","owner":{"login":"dcherian","id":2448579,"node_id":"MDQ6VXNlcjI0NDg1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2448579?v=4","gravatar_id":"","url":"https://api.github.com/users/dcherian","html_url":"https://github.com/dcherian","followers_url":"https://api.github.com/users/dcherian/followers","following_url":"https://api.github.com/users/dcherian/following{/other_user}","gists_url":"https://api.github.com/users/dcherian/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherian/subscriptions","organizations_url":"https://api.github.com/users/dcherian/orgs","repos_url":"https://api.github.com/users/dcherian/repos","events_url":"https://api.github.com/users/dcherian/events{/privacy}","received_events_url":"https://api.github.com/users/dcherian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcherian/xarray","description":"N-D labeled arrays and datasets in Python","fork":true,"url":"https://api.github.com/repos/dcherian/xarray","forks_url":"https://api.github.com/repos/dcherian/xarray/forks","keys_url":"https://api.github.com/repos/dcherian/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcherian/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcherian/xarray/teams","hooks_url":"https://api.github.com/repos/dcherian/xarray/hooks","issue_events_url":"https://api.github.com/repos/dcherian/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/dcherian/xarray/events","assignees_url":"https://api.github.com/repos/dcherian/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/dcherian/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/dcherian/xarray/tags","blobs_url":"https://api.github.com/repos/dcherian/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcherian/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcherian/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcherian/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcherian/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/dcherian/xarray/languages","stargazers_url":"https://api.github.com/repos/dcherian/xarray/stargazers","contributors_url":"https://api.github.com/repos/dcherian/xarray/contributors","subscribers_url":"https://api.github.com/repos/dcherian/xarray/subscribers","subscription_url":"https://api.github.com/repos/dcherian/xarray/subscription","commits_url":"https://api.github.com/repos/dcherian/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcherian/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcherian/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcherian/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcherian/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/dcherian/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcherian/xarray/merges","archive_url":"https://api.github.com/repos/dcherian/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcherian/xarray/downloads","issues_url":"https://api.github.com/repos/dcherian/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/dcherian/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/dcherian/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/dcherian/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcherian/xarray/labels{/name}","releases_url":"https://api.github.com/repos/dcherian/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/dcherian/xarray/deployments","created_at":"2017-11-22T18:58:27Z","updated_at":"2018-07-29T01:39:39Z","pushed_at":"2018-07-30T00:33:13Z","git_url":"git://github.com/dcherian/xarray.git","ssh_url":"git@github.com:dcherian/xarray.git","clone_url":"https://github.com/dcherian/xarray.git","svn_url":"https://github.com/dcherian/xarray","homepage":"http://xarray.pydata.org","size":13272,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"f281945fcacbfc1dbaa48fb15546fae5317bdda8","user":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":13221727,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIyMTcyNw==","name":"xarray","full_name":"pydata/xarray","owner":{"login":"pydata","id":1284191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQxOTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1284191?v=4","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/xarray","description":"N-D labeled arrays and datasets in Python","fork":false,"url":"https://api.github.com/repos/pydata/xarray","forks_url":"https://api.github.com/repos/pydata/xarray/forks","keys_url":"https://api.github.com/repos/pydata/xarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/xarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/xarray/teams","hooks_url":"https://api.github.com/repos/pydata/xarray/hooks","issue_events_url":"https://api.github.com/repos/pydata/xarray/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/xarray/events","assignees_url":"https://api.github.com/repos/pydata/xarray/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/xarray/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/xarray/tags","blobs_url":"https://api.github.com/repos/pydata/xarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/xarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/xarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/xarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/xarray/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/xarray/languages","stargazers_url":"https://api.github.com/repos/pydata/xarray/stargazers","contributors_url":"https://api.github.com/repos/pydata/xarray/contributors","subscribers_url":"https://api.github.com/repos/pydata/xarray/subscribers","subscription_url":"https://api.github.com/repos/pydata/xarray/subscription","commits_url":"https://api.github.com/repos/pydata/xarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/xarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/xarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/xarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/xarray/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/xarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/xarray/merges","archive_url":"https://api.github.com/repos/pydata/xarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/xarray/downloads","issues_url":"https://api.github.com/repos/pydata/xarray/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/xarray/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/xarray/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/xarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/xarray/labels{/name}","releases_url":"https://api.github.com/repos/pydata/xarray/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/xarray/deployments","created_at":"2013-09-30T17:21:10Z","updated_at":"2018-07-29T22:00:27Z","pushed_at":"2018-07-30T00:28:46Z","git_url":"git://github.com/pydata/xarray.git","ssh_url":"git@github.com:pydata/xarray.git","clone_url":"https://github.com/pydata/xarray.git","svn_url":"https://github.com/pydata/xarray","homepage":"http://xarray.pydata.org","size":13039,"stargazers_count":904,"watchers_count":904,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":516,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":273,"open_issues":516,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2328"},"html":{"href":"https://github.com/pydata/xarray/pull/2328"},"issue":{"href":"https://api.github.com/repos/pydata/xarray/issues/2328"},"comments":{"href":"https://api.github.com/repos/pydata/xarray/issues/2328/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2328/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/xarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/xarray/pulls/2328/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/xarray/statuses/21c8c473ccee890705a5a0bdba9fbfd103a054c4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 13221727,
"name": "pydata/xarray",
"url": "https://api.github.com/repos/pydata/xarray"
} | {
"id": 1217238,
"login": "shoyer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1217238?",
"url": "https://api.github.com/users/shoyer"
} | {
"id": 1284191,
"login": "pydata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1284191?",
"url": "https://api.github.com/orgs/pydata"
} | 2018-07-30T00:43:00 | 8034934322 | {"actor":{"display_login":"shoyer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments/187287808","pull_request_review_id":119035373,"id":187287808,"diff_hunk":"@@ -587,6 +587,118 @@ struct configuration_update_app_env_response\n 2:string hint_message;\n }\n \n+/////////////////// duplication-related structs ////////////////////\n+\n+// - INIT -> START\n+// - START -> PAUSE\n+// - START -> REMOVED\n+// - PAUSE -> START\n+// - PAUSE -> REMOVED\n+enum duplication_status\n+{\n+ DS_INIT = 0,\n+ DS_START,\n+ DS_PAUSE,\n+ DS_REMOVED,\n+}\n+\n+// This request is sent from client to meta.\n+struct duplication_add_request\n+{\n+ 1:string app_name;\n+ 2:string remote_cluster_address;\n+}\n+\n+struct duplication_add_response\n+{\n+ // Possible errors:\n+ // - ERR_INVALID_PARAMETERS:\n+ // the address of remote cluster is not well configured in meta sever.\n+ 1:dsn.error_code err;\n+ 2:i32 appid;\n+ 3:i32 dupid;\n+}\n+\n+// This request is sent from client to meta.\n+struct duplication_status_change_request\n+{\n+ 1:string app_name;\n+ 2:i32 dupid;\n+ 3:duplication_status status;\n+}\n+\n+struct duplication_status_change_response\n+{\n+ // Possible errors:\n+ // - ERR_APP_NOT_EXIST: app is not found\n+ // - ERR_OBJECT_NOT_FOUND: duplication is not found\n+ // - ERR_BUSY: busy for updating state\n+ // - ERR_INVALID_PARAMETERS: illegal request\n+ 1:dsn.error_code err;\n+ 2:i32 appid;\n+}\n+\n+struct duplication_entry\n+{\n+ 1:i32 dupid;\n+ 2:duplication_status status;\n+ 3:string remote_address;\n+ 4:i64 create_ts;\n+\n+ // partition_index => confirmed decree\n+ 5:map<i32, i64> progress;","path":"src/dist/replication/replication.thrift","position":63,"original_position":63,"commit_id":"4929a00784d0e8df86e4f89aa6a544152eae67a4","original_commit_id":"4929a00784d0e8df86e4f89aa6a544152eae67a4","user":{"login":"neverchanje","id":6970676,"avatar_url":"https://avatars1.githubusercontent.com/u/6970676?v=4","gravatar_id":"","url":"https://api.github.com/users/neverchanje","html_url":"https://github.com/neverchanje","followers_url":"https://api.github.com/users/neverchanje/followers","following_url":"https://api.github.com/users/neverchanje/following{/other_user}","gists_url":"https://api.github.com/users/neverchanje/gists{/gist_id}","starred_url":"https://api.github.com/users/neverchanje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverchanje/subscriptions","organizations_url":"https://api.github.com/users/neverchanje/orgs","repos_url":"https://api.github.com/users/neverchanje/repos","events_url":"https://api.github.com/users/neverchanje/events{/privacy}","received_events_url":"https://api.github.com/users/neverchanje/received_events","type":"User","site_admin":false},"body":"一台机器上的 partition 不会太多，所以 sync 的时候没关系，不过写 zk 的时候是要注意这个，但是不在这个 commit 里。","created_at":"2018-05-10T09:54:57Z","updated_at":"2018-05-10T09:54:58Z","html_url":"https://github.com/XiaoMi/rdsn/pull/47#discussion_r187287808","pull_request_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments/187287808"},"html":{"href":"https://github.com/XiaoMi/rdsn/pull/47#discussion_r187287808"},"pull_request":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47"}},"in_reply_to_id":187271572},"pull_request":{"url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47","id":186508895,"html_url":"https://github.com/XiaoMi/rdsn/pull/47","diff_url":"https://github.com/XiaoMi/rdsn/pull/47.diff","patch_url":"https://github.com/XiaoMi/rdsn/pull/47.patch","issue_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/47","number":47,"state":"open","locked":false,"title":"duplication: define thrift structs and add some utilities for rpc message","user":{"login":"neverchanje","id":6970676,"avatar_url":"https://avatars1.githubusercontent.com/u/6970676?v=4","gravatar_id":"","url":"https://api.github.com/users/neverchanje","html_url":"https://github.com/neverchanje","followers_url":"https://api.github.com/users/neverchanje/followers","following_url":"https://api.github.com/users/neverchanje/following{/other_user}","gists_url":"https://api.github.com/users/neverchanje/gists{/gist_id}","starred_url":"https://api.github.com/users/neverchanje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverchanje/subscriptions","organizations_url":"https://api.github.com/users/neverchanje/orgs","repos_url":"https://api.github.com/users/neverchanje/repos","events_url":"https://api.github.com/users/neverchanje/events{/privacy}","received_events_url":"https://api.github.com/users/neverchanje/received_events","type":"User","site_admin":false},"body":"This PR includes:\r\n\r\n- Definition of duplication-related structs, which are described in `src/dist/replication/replication.thrift`. Duplication implementation in replica and meta will be in another PR.\r\n- Convenience utilities for rpc messages. \r\n- Utilities for exposing `replica` and `replica_stub` to application level. They will be used in unit test of pegasus server.","created_at":"2018-05-08T02:05:59Z","updated_at":"2018-05-10T09:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b47f5dfc518f22e2eafaa0610a4697f2ec77d65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars1.githubusercontent.com/u/528445?v=4","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},{"login":"LoveHeat","id":12112111,"avatar_url":"https://avatars3.githubusercontent.com/u/12112111?v=4","gravatar_id":"","url":"https://api.github.com/users/LoveHeat","html_url":"https://github.com/LoveHeat","followers_url":"https://api.github.com/users/LoveHeat/followers","following_url":"https://api.github.com/users/LoveHeat/following{/other_user}","gists_url":"https://api.github.com/users/LoveHeat/gists{/gist_id}","starred_url":"https://api.github.com/users/LoveHeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoveHeat/subscriptions","organizations_url":"https://api.github.com/users/LoveHeat/orgs","repos_url":"https://api.github.com/users/LoveHeat/repos","events_url":"https://api.github.com/users/LoveHeat/events{/privacy}","received_events_url":"https://api.github.com/users/LoveHeat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47/commits","review_comments_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47/comments","review_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/47/comments","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/4929a00784d0e8df86e4f89aa6a544152eae67a4","head":{"label":"neverchanje:master","ref":"master","sha":"4929a00784d0e8df86e4f89aa6a544152eae67a4","user":{"login":"neverchanje","id":6970676,"avatar_url":"https://avatars1.githubusercontent.com/u/6970676?v=4","gravatar_id":"","url":"https://api.github.com/users/neverchanje","html_url":"https://github.com/neverchanje","followers_url":"https://api.github.com/users/neverchanje/followers","following_url":"https://api.github.com/users/neverchanje/following{/other_user}","gists_url":"https://api.github.com/users/neverchanje/gists{/gist_id}","starred_url":"https://api.github.com/users/neverchanje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverchanje/subscriptions","organizations_url":"https://api.github.com/users/neverchanje/orgs","repos_url":"https://api.github.com/users/neverchanje/repos","events_url":"https://api.github.com/users/neverchanje/events{/privacy}","received_events_url":"https://api.github.com/users/neverchanje/received_events","type":"User","site_admin":false},"repo":{"id":128627697,"name":"rdsn","full_name":"neverchanje/rdsn","owner":{"login":"neverchanje","id":6970676,"avatar_url":"https://avatars1.githubusercontent.com/u/6970676?v=4","gravatar_id":"","url":"https://api.github.com/users/neverchanje","html_url":"https://github.com/neverchanje","followers_url":"https://api.github.com/users/neverchanje/followers","following_url":"https://api.github.com/users/neverchanje/following{/other_user}","gists_url":"https://api.github.com/users/neverchanje/gists{/gist_id}","starred_url":"https://api.github.com/users/neverchanje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neverchanje/subscriptions","organizations_url":"https://api.github.com/users/neverchanje/orgs","repos_url":"https://api.github.com/users/neverchanje/repos","events_url":"https://api.github.com/users/neverchanje/events{/privacy}","received_events_url":"https://api.github.com/users/neverchanje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neverchanje/rdsn","description":null,"fork":true,"url":"https://api.github.com/repos/neverchanje/rdsn","forks_url":"https://api.github.com/repos/neverchanje/rdsn/forks","keys_url":"https://api.github.com/repos/neverchanje/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neverchanje/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neverchanje/rdsn/teams","hooks_url":"https://api.github.com/repos/neverchanje/rdsn/hooks","issue_events_url":"https://api.github.com/repos/neverchanje/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/neverchanje/rdsn/events","assignees_url":"https://api.github.com/repos/neverchanje/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/neverchanje/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/neverchanje/rdsn/tags","blobs_url":"https://api.github.com/repos/neverchanje/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neverchanje/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neverchanje/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/neverchanje/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neverchanje/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/neverchanje/rdsn/languages","stargazers_url":"https://api.github.com/repos/neverchanje/rdsn/stargazers","contributors_url":"https://api.github.com/repos/neverchanje/rdsn/contributors","subscribers_url":"https://api.github.com/repos/neverchanje/rdsn/subscribers","subscription_url":"https://api.github.com/repos/neverchanje/rdsn/subscription","commits_url":"https://api.github.com/repos/neverchanje/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/neverchanje/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/neverchanje/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/neverchanje/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/neverchanje/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/neverchanje/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neverchanje/rdsn/merges","archive_url":"https://api.github.com/repos/neverchanje/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neverchanje/rdsn/downloads","issues_url":"https://api.github.com/repos/neverchanje/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/neverchanje/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/neverchanje/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/neverchanje/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neverchanje/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/neverchanje/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/neverchanje/rdsn/deployments","created_at":"2018-04-08T10:07:13Z","updated_at":"2018-05-08T08:58:21Z","pushed_at":"2018-05-08T08:58:19Z","git_url":"git://github.com/neverchanje/rdsn.git","ssh_url":"git@github.com:neverchanje/rdsn.git","clone_url":"https://github.com/neverchanje/rdsn.git","svn_url":"https://github.com/neverchanje/rdsn","homepage":null,"size":78924,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"XiaoMi:master","ref":"master","sha":"67feae37045ccde81956f835ef7d3ffbdcbe2c59","user":{"login":"XiaoMi","id":1309360,"avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"repo":{"id":104966876,"name":"rdsn","full_name":"XiaoMi/rdsn","owner":{"login":"XiaoMi","id":1309360,"avatar_url":"https://avatars3.githubusercontent.com/u/1309360?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoMi","html_url":"https://github.com/XiaoMi","followers_url":"https://api.github.com/users/XiaoMi/followers","following_url":"https://api.github.com/users/XiaoMi/following{/other_user}","gists_url":"https://api.github.com/users/XiaoMi/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoMi/subscriptions","organizations_url":"https://api.github.com/users/XiaoMi/orgs","repos_url":"https://api.github.com/users/XiaoMi/repos","events_url":"https://api.github.com/users/XiaoMi/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoMi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XiaoMi/rdsn","description":null,"fork":false,"url":"https://api.github.com/repos/XiaoMi/rdsn","forks_url":"https://api.github.com/repos/XiaoMi/rdsn/forks","keys_url":"https://api.github.com/repos/XiaoMi/rdsn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XiaoMi/rdsn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XiaoMi/rdsn/teams","hooks_url":"https://api.github.com/repos/XiaoMi/rdsn/hooks","issue_events_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/events{/number}","events_url":"https://api.github.com/repos/XiaoMi/rdsn/events","assignees_url":"https://api.github.com/repos/XiaoMi/rdsn/assignees{/user}","branches_url":"https://api.github.com/repos/XiaoMi/rdsn/branches{/branch}","tags_url":"https://api.github.com/repos/XiaoMi/rdsn/tags","blobs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XiaoMi/rdsn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XiaoMi/rdsn/git/refs{/sha}","trees_url":"https://api.github.com/repos/XiaoMi/rdsn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XiaoMi/rdsn/statuses/{sha}","languages_url":"https://api.github.com/repos/XiaoMi/rdsn/languages","stargazers_url":"https://api.github.com/repos/XiaoMi/rdsn/stargazers","contributors_url":"https://api.github.com/repos/XiaoMi/rdsn/contributors","subscribers_url":"https://api.github.com/repos/XiaoMi/rdsn/subscribers","subscription_url":"https://api.github.com/repos/XiaoMi/rdsn/subscription","commits_url":"https://api.github.com/repos/XiaoMi/rdsn/commits{/sha}","git_commits_url":"https://api.github.com/repos/XiaoMi/rdsn/git/commits{/sha}","comments_url":"https://api.github.com/repos/XiaoMi/rdsn/comments{/number}","issue_comment_url":"https://api.github.com/repos/XiaoMi/rdsn/issues/comments{/number}","contents_url":"https://api.github.com/repos/XiaoMi/rdsn/contents/{+path}","compare_url":"https://api.github.com/repos/XiaoMi/rdsn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XiaoMi/rdsn/merges","archive_url":"https://api.github.com/repos/XiaoMi/rdsn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XiaoMi/rdsn/downloads","issues_url":"https://api.github.com/repos/XiaoMi/rdsn/issues{/number}","pulls_url":"https://api.github.com/repos/XiaoMi/rdsn/pulls{/number}","milestones_url":"https://api.github.com/repos/XiaoMi/rdsn/milestones{/number}","notifications_url":"https://api.github.com/repos/XiaoMi/rdsn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XiaoMi/rdsn/labels{/name}","releases_url":"https://api.github.com/repos/XiaoMi/rdsn/releases{/id}","deployments_url":"https://api.github.com/repos/XiaoMi/rdsn/deployments","created_at":"2017-09-27T03:19:21Z","updated_at":"2018-05-08T02:57:58Z","pushed_at":"2018-05-09T14:25:09Z","git_url":"git://github.com/XiaoMi/rdsn.git","ssh_url":"git@github.com:XiaoMi/rdsn.git","clone_url":"https://github.com/XiaoMi/rdsn.git","svn_url":"https://github.com/XiaoMi/rdsn","homepage":null,"size":78685,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":9,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47"},"html":{"href":"https://github.com/XiaoMi/rdsn/pull/47"},"issue":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/47"},"comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XiaoMi/rdsn/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/XiaoMi/rdsn/statuses/4929a00784d0e8df86e4f89aa6a544152eae67a4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 104966876,
"name": "XiaoMi/rdsn",
"url": "https://api.github.com/repos/XiaoMi/rdsn"
} | {
"id": 6970676,
"login": "neverchanje",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6970676?",
"url": "https://api.github.com/users/neverchanje"
} | {
"id": 1309360,
"login": "XiaoMi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1309360?",
"url": "https://api.github.com/orgs/XiaoMi"
} | 2018-05-10T09:54:57 | 7654610025 | {"actor":{"display_login":"neverchanje"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/comments/186334221","pull_request_review_id":117890223,"id":186334221,"diff_hunk":"@@ -29,5 +29,60 @@ NOTE: If geo-replication is setup on the gluster volumes, the geo-replication ne\n * Replace bricks from the host to be removed using the `Replace Brick` option\n * Once all bricks are replaces, the host can be moved to maintenance and removed.\n \n+## Graceful shutdown and startup\n+Currently there is no scirpt or single command available to shutdown a whole cluster. However, the following steps can be executed to manually shutdown and start a cluster again.\n+\n+### Shutdown\n+1. Shutdown all VMs\n+2. Enable global maintenance mode:\n+ * In the Administration Portal, right-click the engine virtual machine, and select **Enable Global HA Maintenance**.\n+ * You can also set the maintenance mode from the command line:\n+ \n+ # hosted-engine --set-maintenance --mode=global\n+\n+3. Wait for all VMs to be down\n+4. If the cluster is running a hosted engine:\n+ 1. Logon to the node running hosted-engine\n+ 2. Shutdown hosted-engine\n+ \n+ # hosted-engine --vm-shutdown\n+ \n+ 3. Wait for stopped hosted engine using\n+ \n+ # hosted-engine --vm-status\n+\n+5. Shutdown all nodes\n+\n+### Startup\n+1. Switch on all nodes\n+2. Start glusterd on all nodes since it does not start by default\n+\n+ # systemctl start glusterd\n+\n+3. Check peer and volume status on one of the nodes\n+\n+ # gluster peer status\n+ # gluster volume status all\n+ \n+4. Wait for ovrt-ha-agent until \n+\n+ # hosted-engine --vm-status\n+ \n+ does not fail anymore printing `The hosted engine configuration has not been retrieved from shared storage. Please ensure that ovirt-ha-agent is running and the storage server is reachable.`\n+5. Start hosted engine on one of the nodes\n+","path":"source/documentation/gluster-hyperconverged/chap-Maintenance_and_Upgrading_Resources.html.md","position":45,"original_position":45,"commit_id":"4f0f8e9226f0ba414cd8f062c7e7b90ee04f659b","original_commit_id":"4f0f8e9226f0ba414cd8f062c7e7b90ee04f659b","user":{"login":"sabose","id":6857979,"avatar_url":"https://avatars0.githubusercontent.com/u/6857979?v=4","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"body":"The HE VM will be started automatically - I think in Step 4. waiting for the HE health to be reported healthy would be sufficient. ","created_at":"2018-05-07T06:15:39Z","updated_at":"2018-05-07T06:15:44Z","html_url":"https://github.com/oVirt/ovirt-site/pull/1473#discussion_r186334221","pull_request_url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/comments/186334221"},"html":{"href":"https://github.com/oVirt/ovirt-site/pull/1473#discussion_r186334221"},"pull_request":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473"}}},"pull_request":{"url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473","id":161147662,"html_url":"https://github.com/oVirt/ovirt-site/pull/1473","diff_url":"https://github.com/oVirt/ovirt-site/pull/1473.diff","patch_url":"https://github.com/oVirt/ovirt-site/pull/1473.patch","issue_url":"https://api.github.com/repos/oVirt/ovirt-site/issues/1473","number":1473,"state":"open","locked":false,"title":"Added graceful shutdown and startup steps for gluster hyperconvergence","user":{"login":"sinuswave","id":16309753,"avatar_url":"https://avatars1.githubusercontent.com/u/16309753?v=4","gravatar_id":"","url":"https://api.github.com/users/sinuswave","html_url":"https://github.com/sinuswave","followers_url":"https://api.github.com/users/sinuswave/followers","following_url":"https://api.github.com/users/sinuswave/following{/other_user}","gists_url":"https://api.github.com/users/sinuswave/gists{/gist_id}","starred_url":"https://api.github.com/users/sinuswave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinuswave/subscriptions","organizations_url":"https://api.github.com/users/sinuswave/orgs","repos_url":"https://api.github.com/users/sinuswave/repos","events_url":"https://api.github.com/users/sinuswave/events{/privacy}","received_events_url":"https://api.github.com/users/sinuswave/received_events","type":"User","site_admin":false},"body":"Helpful documentation based on https://lists.ovirt.org/pipermail/users/2018-January/086065.html\r\n\r\nI confirm that this pull request was submitted according to the [contribution guidelines](https://github.com/oVirt/ovirt-site/blob/master/CONTRIBUTING.md): @sinuswave","created_at":"2018-01-04T15:23:11Z","updated_at":"2018-05-07T06:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa9b6c2badfeb5cdaa6eb60a5ce96cc4618b443f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473/commits","review_comments_url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473/comments","review_comment_url":"https://api.github.com/repos/oVirt/ovirt-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oVirt/ovirt-site/issues/1473/comments","statuses_url":"https://api.github.com/repos/oVirt/ovirt-site/statuses/4f0f8e9226f0ba414cd8f062c7e7b90ee04f659b","head":{"label":"sinuswave:gluster-hyperconvergence-graceful-shutdown-startup","ref":"gluster-hyperconvergence-graceful-shutdown-startup","sha":"4f0f8e9226f0ba414cd8f062c7e7b90ee04f659b","user":{"login":"sinuswave","id":16309753,"avatar_url":"https://avatars1.githubusercontent.com/u/16309753?v=4","gravatar_id":"","url":"https://api.github.com/users/sinuswave","html_url":"https://github.com/sinuswave","followers_url":"https://api.github.com/users/sinuswave/followers","following_url":"https://api.github.com/users/sinuswave/following{/other_user}","gists_url":"https://api.github.com/users/sinuswave/gists{/gist_id}","starred_url":"https://api.github.com/users/sinuswave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinuswave/subscriptions","organizations_url":"https://api.github.com/users/sinuswave/orgs","repos_url":"https://api.github.com/users/sinuswave/repos","events_url":"https://api.github.com/users/sinuswave/events{/privacy}","received_events_url":"https://api.github.com/users/sinuswave/received_events","type":"User","site_admin":false},"repo":{"id":116271307,"name":"ovirt-site","full_name":"sinuswave/ovirt-site","owner":{"login":"sinuswave","id":16309753,"avatar_url":"https://avatars1.githubusercontent.com/u/16309753?v=4","gravatar_id":"","url":"https://api.github.com/users/sinuswave","html_url":"https://github.com/sinuswave","followers_url":"https://api.github.com/users/sinuswave/followers","following_url":"https://api.github.com/users/sinuswave/following{/other_user}","gists_url":"https://api.github.com/users/sinuswave/gists{/gist_id}","starred_url":"https://api.github.com/users/sinuswave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinuswave/subscriptions","organizations_url":"https://api.github.com/users/sinuswave/orgs","repos_url":"https://api.github.com/users/sinuswave/repos","events_url":"https://api.github.com/users/sinuswave/events{/privacy}","received_events_url":"https://api.github.com/users/sinuswave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinuswave/ovirt-site","description":"oVirt website","fork":true,"url":"https://api.github.com/repos/sinuswave/ovirt-site","forks_url":"https://api.github.com/repos/sinuswave/ovirt-site/forks","keys_url":"https://api.github.com/repos/sinuswave/ovirt-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinuswave/ovirt-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinuswave/ovirt-site/teams","hooks_url":"https://api.github.com/repos/sinuswave/ovirt-site/hooks","issue_events_url":"https://api.github.com/repos/sinuswave/ovirt-site/issues/events{/number}","events_url":"https://api.github.com/repos/sinuswave/ovirt-site/events","assignees_url":"https://api.github.com/repos/sinuswave/ovirt-site/assignees{/user}","branches_url":"https://api.github.com/repos/sinuswave/ovirt-site/branches{/branch}","tags_url":"https://api.github.com/repos/sinuswave/ovirt-site/tags","blobs_url":"https://api.github.com/repos/sinuswave/ovirt-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinuswave/ovirt-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinuswave/ovirt-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinuswave/ovirt-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinuswave/ovirt-site/statuses/{sha}","languages_url":"https://api.github.com/repos/sinuswave/ovirt-site/languages","stargazers_url":"https://api.github.com/repos/sinuswave/ovirt-site/stargazers","contributors_url":"https://api.github.com/repos/sinuswave/ovirt-site/contributors","subscribers_url":"https://api.github.com/repos/sinuswave/ovirt-site/subscribers","subscription_url":"https://api.github.com/repos/sinuswave/ovirt-site/subscription","commits_url":"https://api.github.com/repos/sinuswave/ovirt-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinuswave/ovirt-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinuswave/ovirt-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinuswave/ovirt-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinuswave/ovirt-site/contents/{+path}","compare_url":"https://api.github.com/repos/sinuswave/ovirt-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinuswave/ovirt-site/merges","archive_url":"https://api.github.com/repos/sinuswave/ovirt-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinuswave/ovirt-site/downloads","issues_url":"https://api.github.com/repos/sinuswave/ovirt-site/issues{/number}","pulls_url":"https://api.github.com/repos/sinuswave/ovirt-site/pulls{/number}","milestones_url":"https://api.github.com/repos/sinuswave/ovirt-site/milestones{/number}","notifications_url":"https://api.github.com/repos/sinuswave/ovirt-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinuswave/ovirt-site/labels{/name}","releases_url":"https://api.github.com/repos/sinuswave/ovirt-site/releases{/id}","deployments_url":"https://api.github.com/repos/sinuswave/ovirt-site/deployments","created_at":"2018-01-04T14:46:22Z","updated_at":"2018-01-04T14:46:28Z","pushed_at":"2018-01-10T13:43:15Z","git_url":"git://github.com/sinuswave/ovirt-site.git","ssh_url":"git@github.com:sinuswave/ovirt-site.git","clone_url":"https://github.com/sinuswave/ovirt-site.git","svn_url":"https://github.com/sinuswave/ovirt-site","homepage":"http://www.ovirt.org/","size":183324,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oVirt:master","ref":"master","sha":"9b4e750dae0a4c592fc2c54d5fd35dc7b49d8eda","user":{"login":"oVirt","id":1318634,"avatar_url":"https://avatars2.githubusercontent.com/u/1318634?v=4","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"repo":{"id":47401658,"name":"ovirt-site","full_name":"oVirt/ovirt-site","owner":{"login":"oVirt","id":1318634,"avatar_url":"https://avatars2.githubusercontent.com/u/1318634?v=4","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oVirt/ovirt-site","description":"oVirt website","fork":false,"url":"https://api.github.com/repos/oVirt/ovirt-site","forks_url":"https://api.github.com/repos/oVirt/ovirt-site/forks","keys_url":"https://api.github.com/repos/oVirt/ovirt-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oVirt/ovirt-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oVirt/ovirt-site/teams","hooks_url":"https://api.github.com/repos/oVirt/ovirt-site/hooks","issue_events_url":"https://api.github.com/repos/oVirt/ovirt-site/issues/events{/number}","events_url":"https://api.github.com/repos/oVirt/ovirt-site/events","assignees_url":"https://api.github.com/repos/oVirt/ovirt-site/assignees{/user}","branches_url":"https://api.github.com/repos/oVirt/ovirt-site/branches{/branch}","tags_url":"https://api.github.com/repos/oVirt/ovirt-site/tags","blobs_url":"https://api.github.com/repos/oVirt/ovirt-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oVirt/ovirt-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oVirt/ovirt-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/oVirt/ovirt-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oVirt/ovirt-site/statuses/{sha}","languages_url":"https://api.github.com/repos/oVirt/ovirt-site/languages","stargazers_url":"https://api.github.com/repos/oVirt/ovirt-site/stargazers","contributors_url":"https://api.github.com/repos/oVirt/ovirt-site/contributors","subscribers_url":"https://api.github.com/repos/oVirt/ovirt-site/subscribers","subscription_url":"https://api.github.com/repos/oVirt/ovirt-site/subscription","commits_url":"https://api.github.com/repos/oVirt/ovirt-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/oVirt/ovirt-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/oVirt/ovirt-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/oVirt/ovirt-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/oVirt/ovirt-site/contents/{+path}","compare_url":"https://api.github.com/repos/oVirt/ovirt-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oVirt/ovirt-site/merges","archive_url":"https://api.github.com/repos/oVirt/ovirt-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oVirt/ovirt-site/downloads","issues_url":"https://api.github.com/repos/oVirt/ovirt-site/issues{/number}","pulls_url":"https://api.github.com/repos/oVirt/ovirt-site/pulls{/number}","milestones_url":"https://api.github.com/repos/oVirt/ovirt-site/milestones{/number}","notifications_url":"https://api.github.com/repos/oVirt/ovirt-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oVirt/ovirt-site/labels{/name}","releases_url":"https://api.github.com/repos/oVirt/ovirt-site/releases{/id}","deployments_url":"https://api.github.com/repos/oVirt/ovirt-site/deployments","created_at":"2015-12-04T12:05:58Z","updated_at":"2018-05-06T06:26:37Z","pushed_at":"2018-05-06T06:26:29Z","git_url":"git://github.com/oVirt/ovirt-site.git","ssh_url":"git@github.com:oVirt/ovirt-site.git","clone_url":"https://github.com/oVirt/ovirt-site.git","svn_url":"https://github.com/oVirt/ovirt-site","homepage":"http://www.ovirt.org/","size":185580,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":196,"open_issues":98,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473"},"html":{"href":"https://github.com/oVirt/ovirt-site/pull/1473"},"issue":{"href":"https://api.github.com/repos/oVirt/ovirt-site/issues/1473"},"comments":{"href":"https://api.github.com/repos/oVirt/ovirt-site/issues/1473/comments"},"review_comments":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473/comments"},"review_comment":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oVirt/ovirt-site/pulls/1473/commits"},"statuses":{"href":"https://api.github.com/repos/oVirt/ovirt-site/statuses/4f0f8e9226f0ba414cd8f062c7e7b90ee04f659b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 47401658,
"name": "oVirt/ovirt-site",
"url": "https://api.github.com/repos/oVirt/ovirt-site"
} | {
"id": 6857979,
"login": "sabose",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6857979?",
"url": "https://api.github.com/users/sabose"
} | {
"id": 1318634,
"login": "oVirt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1318634?",
"url": "https://api.github.com/orgs/oVirt"
} | 2018-05-07T06:15:39 | 7635803347 | {"actor":{"display_login":"sabose"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/brotli/pulls/comments/217712905","pull_request_review_id":155495169,"id":217712905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcxMjkwNQ==","diff_hunk":"@@ -33,11 +33,60 @@ static const uint16_t kMaxHuffmanTableSize[] = {\n \n #define BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH 5\n \n+#if !defined(BROTLI_HUFFMAN_CODE_FAST_LOAD)\n typedef struct {\n uint8_t bits; /* number of bits used for this symbol */\n uint16_t value; /* symbol value or table offset */\n } HuffmanCode;\n \n+/* To allow optimization of HuffmanCode accesses in hot paths,\n+ * please use the following macros to:\n+ *\n+ * - prepare a HuffmanCode pointer for access\n+ * ( BROTLI_HC_PREPARE_TO_ACCESS(HuffmanCode*) )\n+ * - update the pointer each time it is changed\n+ * ( BROTLI_HC_UPDATE(HuffmanCode*) )\n+ * - get the bits or value fields\n+ * ( BROTLI_HC_GET_BITS/VALUE(HuffmanCode*) )\n+ *\n+ * For example, assuming |table| contains a HuffmanCode pointer:\n+ *\n+ * BROTLI_HC_PREPARE_TO_ACCESS(table);\n+ * BROTLI_HC_UPDATE(table);\n+ * *bits = BROTLI_HC_GET_BITS(table);\n+ * *value = BROTLI_HC_GET_VALUE(table);\n+ * table += offset;\n+ * BROTLI_HC_UPDATE(table);\n+ * *bits2 = BROTLI_HC_GET_BITS(table);\n+ * *value2 = BROTLI_HC_GET_VALUE(table);\n+ *\n+ */\n+\n+#define BROTLI_HC_PREPARE_TO_ACCESS(H)\n+#define BROTLI_HC_UPDATE(H)\n+\n+/* Getters must be given a pointer to a HuffmanCode. */\n+#define BROTLI_HC_GET_BITS(H) (H->bits)\n+#define BROTLI_HC_GET_VALUE(H) (H->value)\n+\n+/* Setters must be given a HuffmanCode. */\n+#define BROTLI_HC_SET_BITS(H, B) H.bits = B\n+#define BROTLI_HC_SET_VALUE(H, V) H.value = V\n+#else\n+typedef BROTLI_ALIGNED(4) uint32_t HuffmanCode;\n+\n+#define BROTLI_HC_PREPARE_TO_ACCESS(H) uint32_t __fastload_##H","path":"c/dec/huffman.h","position":46,"original_position":46,"commit_id":"abd8d1f44bce42021881742e8da4cf3f96562806","original_commit_id":"abd8d1f44bce42021881742e8da4cf3f96562806","user":{"login":"stephenkyle-ARM","id":18005244,"node_id":"MDQ6VXNlcjE4MDA1MjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18005244?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkyle-ARM","html_url":"https://github.com/stephenkyle-ARM","followers_url":"https://api.github.com/users/stephenkyle-ARM/followers","following_url":"https://api.github.com/users/stephenkyle-ARM/following{/other_user}","gists_url":"https://api.github.com/users/stephenkyle-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkyle-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkyle-ARM/subscriptions","organizations_url":"https://api.github.com/users/stephenkyle-ARM/orgs","repos_url":"https://api.github.com/users/stephenkyle-ARM/repos","events_url":"https://api.github.com/users/stephenkyle-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkyle-ARM/received_events","type":"User","site_admin":false},"body":"Hi @eustas, thanks for the feedback.\r\n\r\nSo just to check, you're suggesting we make both the setters and getters access HuffmanCode (not a pointer):\r\n\r\n```\r\n/* Getters and setters must be given a HuffmanCode. */ \r\n#define BROTLI_HC_GET_BITS(H) (H.bits) \r\n#define BROTLI_HC_GET_VALUE(H) (H.value)\r\n```\r\n\r\n(and with FAST_LOAD:)\r\n\r\n```\r\n/* Getters and setters must be given a HuffmanCode. */ \r\n#define BROTLI_HC_GET_BITS(H) (H & 0xFFu) \r\n#define BROTLI_HC_GET_VALUE(H) (H >> 16)\r\n```\r\n\r\nAnd then we drop the PREPARE_TO_ACCESS and UPDATE macros, and just do things like:\r\n\r\n```\r\nstatic BROTLI_INLINE uint32_t DecodeSymbol(uint32_t bits, \r\n const HuffmanCode* table, \r\n BrotliBitReader* br) { \r\n HuffmanCode huffman_code; \r\n table += bits & HUFFMAN_TABLE_MASK; \r\n huffman_code = *table; \r\n if (BROTLI_HC_GET_BITS(huffman_code) > HUFFMAN_TABLE_BITS) { \r\n uint32_t nbits = BROTLI_HC_GET_BITS(huffman_code) - HUFFMAN_TABLE_BITS;\r\n BrotliDropBits(br, HUFFMAN_TABLE_BITS); \r\n table += BROTLI_HC_GET_VALUE(huffman_code); \r\n table += (bits >> HUFFMAN_TABLE_BITS) & BitMask(nbits); \r\n huffman_code = *table; \r\n } \r\n BrotliDropBits(br, BROTLI_HC_GET_BITS(huffman_code)); \r\n return BROTLI_HC_GET_VALUE(huffman_code); \r\n}\r\n```\r\n\r\n(Which name would you prefer for the local variable? `huffman_code`, `prefix_code`, `_table`, etc?","created_at":"2018-09-14T13:30:32Z","updated_at":"2018-09-14T13:30:32Z","html_url":"https://github.com/google/brotli/pull/703#discussion_r217712905","pull_request_url":"https://api.github.com/repos/google/brotli/pulls/703","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/brotli/pulls/comments/217712905"},"html":{"href":"https://github.com/google/brotli/pull/703#discussion_r217712905"},"pull_request":{"href":"https://api.github.com/repos/google/brotli/pulls/703"}},"in_reply_to_id":217474907},"pull_request":{"url":"https://api.github.com/repos/google/brotli/pulls/703","id":208552742,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTUyNzQy","html_url":"https://github.com/google/brotli/pull/703","diff_url":"https://github.com/google/brotli/pull/703.diff","patch_url":"https://github.com/google/brotli/pull/703.patch","issue_url":"https://api.github.com/repos/google/brotli/issues/703","number":703,"state":"open","locked":false,"title":"decode: faster huffman code loading on 32-bit Arm","user":{"login":"stephenkyle-ARM","id":18005244,"node_id":"MDQ6VXNlcjE4MDA1MjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18005244?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkyle-ARM","html_url":"https://github.com/stephenkyle-ARM","followers_url":"https://api.github.com/users/stephenkyle-ARM/followers","following_url":"https://api.github.com/users/stephenkyle-ARM/following{/other_user}","gists_url":"https://api.github.com/users/stephenkyle-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkyle-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkyle-ARM/subscriptions","organizations_url":"https://api.github.com/users/stephenkyle-ARM/orgs","repos_url":"https://api.github.com/users/stephenkyle-ARM/repos","events_url":"https://api.github.com/users/stephenkyle-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkyle-ARM/received_events","type":"User","site_admin":false},"body":"In both symbol preloading and decoding, force the compiler to generate a\r\nsingle load instead of two when loading the bits and value fields of the\r\nHuffmanCode struct.","created_at":"2018-08-15T12:46:21Z","updated_at":"2018-09-14T13:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"156100ef8809a87dd9b763c92e1e29f377aa7648","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/brotli/pulls/703/commits","review_comments_url":"https://api.github.com/repos/google/brotli/pulls/703/comments","review_comment_url":"https://api.github.com/repos/google/brotli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/brotli/issues/703/comments","statuses_url":"https://api.github.com/repos/google/brotli/statuses/abd8d1f44bce42021881742e8da4cf3f96562806","head":{"label":"stephenkyle-ARM:perf/faster-symbol-load-arm","ref":"perf/faster-symbol-load-arm","sha":"abd8d1f44bce42021881742e8da4cf3f96562806","user":{"login":"stephenkyle-ARM","id":18005244,"node_id":"MDQ6VXNlcjE4MDA1MjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18005244?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkyle-ARM","html_url":"https://github.com/stephenkyle-ARM","followers_url":"https://api.github.com/users/stephenkyle-ARM/followers","following_url":"https://api.github.com/users/stephenkyle-ARM/following{/other_user}","gists_url":"https://api.github.com/users/stephenkyle-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkyle-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkyle-ARM/subscriptions","organizations_url":"https://api.github.com/users/stephenkyle-ARM/orgs","repos_url":"https://api.github.com/users/stephenkyle-ARM/repos","events_url":"https://api.github.com/users/stephenkyle-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkyle-ARM/received_events","type":"User","site_admin":false},"repo":{"id":140866756,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NjY3NTY=","name":"brotli","full_name":"stephenkyle-ARM/brotli","owner":{"login":"stephenkyle-ARM","id":18005244,"node_id":"MDQ6VXNlcjE4MDA1MjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18005244?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenkyle-ARM","html_url":"https://github.com/stephenkyle-ARM","followers_url":"https://api.github.com/users/stephenkyle-ARM/followers","following_url":"https://api.github.com/users/stephenkyle-ARM/following{/other_user}","gists_url":"https://api.github.com/users/stephenkyle-ARM/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenkyle-ARM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenkyle-ARM/subscriptions","organizations_url":"https://api.github.com/users/stephenkyle-ARM/orgs","repos_url":"https://api.github.com/users/stephenkyle-ARM/repos","events_url":"https://api.github.com/users/stephenkyle-ARM/events{/privacy}","received_events_url":"https://api.github.com/users/stephenkyle-ARM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenkyle-ARM/brotli","description":"Brotli compression format","fork":true,"url":"https://api.github.com/repos/stephenkyle-ARM/brotli","forks_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/forks","keys_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/teams","hooks_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/hooks","issue_events_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/events","assignees_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/tags","blobs_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/languages","stargazers_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/stargazers","contributors_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/contributors","subscribers_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/subscribers","subscription_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/subscription","commits_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/merges","archive_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/downloads","issues_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/labels{/name}","releases_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/releases{/id}","deployments_url":"https://api.github.com/repos/stephenkyle-ARM/brotli/deployments","created_at":"2018-07-13T15:56:43Z","updated_at":"2018-07-25T09:48:54Z","pushed_at":"2018-08-22T16:11:07Z","git_url":"git://github.com/stephenkyle-ARM/brotli.git","ssh_url":"git@github.com:stephenkyle-ARM/brotli.git","clone_url":"https://github.com/stephenkyle-ARM/brotli.git","svn_url":"https://github.com/stephenkyle-ARM/brotli","homepage":"","size":31104,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d4cd6cdf1cd52b75f871b6d75b1c8941454371db","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":24993138,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk5MzEzOA==","name":"brotli","full_name":"google/brotli","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/brotli","description":"Brotli compression format","fork":false,"url":"https://api.github.com/repos/google/brotli","forks_url":"https://api.github.com/repos/google/brotli/forks","keys_url":"https://api.github.com/repos/google/brotli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/brotli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/brotli/teams","hooks_url":"https://api.github.com/repos/google/brotli/hooks","issue_events_url":"https://api.github.com/repos/google/brotli/issues/events{/number}","events_url":"https://api.github.com/repos/google/brotli/events","assignees_url":"https://api.github.com/repos/google/brotli/assignees{/user}","branches_url":"https://api.github.com/repos/google/brotli/branches{/branch}","tags_url":"https://api.github.com/repos/google/brotli/tags","blobs_url":"https://api.github.com/repos/google/brotli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/brotli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/brotli/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/brotli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/brotli/statuses/{sha}","languages_url":"https://api.github.com/repos/google/brotli/languages","stargazers_url":"https://api.github.com/repos/google/brotli/stargazers","contributors_url":"https://api.github.com/repos/google/brotli/contributors","subscribers_url":"https://api.github.com/repos/google/brotli/subscribers","subscription_url":"https://api.github.com/repos/google/brotli/subscription","commits_url":"https://api.github.com/repos/google/brotli/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/brotli/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/brotli/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/brotli/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/brotli/contents/{+path}","compare_url":"https://api.github.com/repos/google/brotli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/brotli/merges","archive_url":"https://api.github.com/repos/google/brotli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/brotli/downloads","issues_url":"https://api.github.com/repos/google/brotli/issues{/number}","pulls_url":"https://api.github.com/repos/google/brotli/pulls{/number}","milestones_url":"https://api.github.com/repos/google/brotli/milestones{/number}","notifications_url":"https://api.github.com/repos/google/brotli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/brotli/labels{/name}","releases_url":"https://api.github.com/repos/google/brotli/releases{/id}","deployments_url":"https://api.github.com/repos/google/brotli/deployments","created_at":"2014-10-09T14:35:14Z","updated_at":"2018-09-14T11:39:23Z","pushed_at":"2018-09-14T12:56:41Z","git_url":"git://github.com/google/brotli.git","ssh_url":"git@github.com:google/brotli.git","clone_url":"https://github.com/google/brotli.git","svn_url":"https://github.com/google/brotli","homepage":"","size":31133,"stargazers_count":6358,"watchers_count":6358,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":635,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":635,"open_issues":31,"watchers":6358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/brotli/pulls/703"},"html":{"href":"https://github.com/google/brotli/pull/703"},"issue":{"href":"https://api.github.com/repos/google/brotli/issues/703"},"comments":{"href":"https://api.github.com/repos/google/brotli/issues/703/comments"},"review_comments":{"href":"https://api.github.com/repos/google/brotli/pulls/703/comments"},"review_comment":{"href":"https://api.github.com/repos/google/brotli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/brotli/pulls/703/commits"},"statuses":{"href":"https://api.github.com/repos/google/brotli/statuses/abd8d1f44bce42021881742e8da4cf3f96562806"}},"author_association":"CONTRIBUTOR"}} | {
"id": 24993138,
"name": "google/brotli",
"url": "https://api.github.com/repos/google/brotli"
} | {
"id": 18005244,
"login": "stephenkyle-ARM",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18005244?",
"url": "https://api.github.com/users/stephenkyle-ARM"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2018-09-14T13:30:32 | 8266119888 | {"actor":{"display_login":"stephenkyle-ARM"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/232395740","pull_request_review_id":173577985,"id":232395740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM5NTc0MA==","diff_hunk":"@@ -0,0 +1,201 @@\n+// Copyright 2018 The Go Cloud Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// https://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+package pubsub_test\n+\n+import (\n+\t\"context\"\n+\t\"sync\"\n+\t\"testing\"\n+\t\"time\"\n+\n+\t\"github.com/google/go-cloud/pubsub\"\n+\t\"github.com/google/go-cloud/pubsub/driver\"\n+)\n+\n+type driverTopic struct {\n+\tsubs []*driverSub\n+}\n+\n+func (t *driverTopic) SendBatch(ctx context.Context, ms []*driver.Message) error {\n+\tfor _, s := range t.subs {\n+\t\tselect {\n+\t\tcase <-s.sem:\n+\t\t\ts.q = append(s.q, ms...)\n+\t\t\ts.sem <- struct{}{}\n+\t\tcase <-ctx.Done():\n+\t\t\treturn ctx.Err()\n+\t\t}\n+\t}\n+\treturn nil\n+}\n+\n+func (t *driverTopic) Close() error {\n+\treturn nil\n+}\n+\n+type driverSub struct {\n+\tsem chan struct{}\n+\t// Normally this queue would live on a separate server in the cloud.\n+\tq []*driver.Message\n+}\n+\n+func NewDriverSub() *driverSub {\n+\tds := &driverSub{\n+\t\tsem: make(chan struct{}, 1),\n+\t}\n+\tds.sem <- struct{}{}\n+\treturn ds\n+}\n+\n+func (s *driverSub) ReceiveBatch(ctx context.Context) ([]*driver.Message, error) {\n+\tfor {\n+\t\tselect {\n+\t\tcase <-s.sem:\n+\t\t\tms := s.grabQueue()\n+\t\t\tif len(ms) != 0 {\n+\t\t\t\treturn ms, nil\n+\t\t\t}\n+\t\tcase <-ctx.Done():\n+\t\t\treturn nil, ctx.Err()\n+\t\tdefault:\n+\t\t}\n+\t\ttime.Sleep(time.Microsecond)","path":"pubsub/pubsub_test.go","position":73,"original_position":73,"commit_id":"6742f57ca8318ebdc5eb99711f680a1d17c18697","original_commit_id":"6742f57ca8318ebdc5eb99711f680a1d17c18697","user":{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},"body":"Don't use sleep in tests. Receive on a channel instead.","created_at":"2018-11-09T21:14:51Z","updated_at":"2018-11-09T21:18:49Z","html_url":"https://github.com/google/go-cloud/pull/642#discussion_r232395740","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/642","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/232395740"},"html":{"href":"https://github.com/google/go-cloud/pull/642#discussion_r232395740"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/642","id":228875768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODc1NzY4","html_url":"https://github.com/google/go-cloud/pull/642","diff_url":"https://github.com/google/go-cloud/pull/642.diff","patch_url":"https://github.com/google/go-cloud/pull/642.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/642","number":642,"state":"open","locked":false,"title":"pubsub: add concrete API implementation","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"body":"Fixes #607 ","created_at":"2018-11-07T00:00:56Z","updated_at":"2018-11-09T21:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"619774694f986e2a26d8d0a3b0863354eccee57e","assignee":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"assignees":[{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/642/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/642/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/642/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/6742f57ca8318ebdc5eb99711f680a1d17c18697","head":{"label":"ijt:pubsub20181101","ref":"pubsub20181101","sha":"6742f57ca8318ebdc5eb99711f680a1d17c18697","user":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"repo":{"id":142936626,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MzY2MjY=","name":"go-cloud","full_name":"ijt/go-cloud","private":false,"owner":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ijt/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/ijt/go-cloud","forks_url":"https://api.github.com/repos/ijt/go-cloud/forks","keys_url":"https://api.github.com/repos/ijt/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijt/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijt/go-cloud/teams","hooks_url":"https://api.github.com/repos/ijt/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/ijt/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/ijt/go-cloud/events","assignees_url":"https://api.github.com/repos/ijt/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/ijt/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/ijt/go-cloud/tags","blobs_url":"https://api.github.com/repos/ijt/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijt/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijt/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijt/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijt/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/ijt/go-cloud/languages","stargazers_url":"https://api.github.com/repos/ijt/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/ijt/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/ijt/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/ijt/go-cloud/subscription","commits_url":"https://api.github.com/repos/ijt/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijt/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijt/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijt/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijt/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/ijt/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijt/go-cloud/merges","archive_url":"https://api.github.com/repos/ijt/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijt/go-cloud/downloads","issues_url":"https://api.github.com/repos/ijt/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/ijt/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/ijt/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/ijt/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijt/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/ijt/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/ijt/go-cloud/deployments","created_at":"2018-07-30T23:02:52Z","updated_at":"2018-07-31T00:27:06Z","pushed_at":"2018-11-09T20:50:49Z","git_url":"git://github.com/ijt/go-cloud.git","ssh_url":"git@github.com:ijt/go-cloud.git","clone_url":"https://github.com/ijt/go-cloud.git","svn_url":"https://github.com/ijt/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18772,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"08ec72e01c429d8ec2cc47e10bb4810ff0354bd7","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2018-11-09T20:37:14Z","pushed_at":"2018-11-09T21:15:31Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18526,"stargazers_count":4942,"watchers_count":4942,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":268,"open_issues":92,"watchers":4942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642"},"html":{"href":"https://github.com/google/go-cloud/pull/642"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/642"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/642/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/642/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/6742f57ca8318ebdc5eb99711f680a1d17c18697"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126250425,
"name": "google/go-cloud",
"url": "https://api.github.com/repos/google/go-cloud"
} | {
"id": 181535,
"login": "zombiezen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181535?",
"url": "https://api.github.com/users/zombiezen"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2018-11-09T21:14:51 | 8565836229 | {"actor":{"display_login":"zombiezen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/173856659","pull_request_review_id":103104865,"id":173856659,"diff_hunk":"@@ -0,0 +1,562 @@\n+//MAP CONVERTED BY dmm2tgm.py THIS HEADER COMMENT PREVENTS RECONVERSION, DO NOT REMOVE\n+\"a\" = (\n+/turf/template_noop,\n+/area/template_noop)\n+\"b\" = (\n+/turf/closed/wall/r_wall,\n+/area/greytopia)\n+\"c\" = (\n+/obj/item/banner/greytide{\n+\tpixel_y = -4\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/greytopia)\n+\"d\" = (\n+/obj/item/cardboard_cutout/adaptive{\n+\tname = \"Nameless Hero\";\n+\ticon_state = \"cutout_viva\";\n+\tpixel_y = -5\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/greytopia)\n+\"e\" = (\n+/obj/structure/statue/sandstone/assistant{\n+\tpixel_y = -5\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/greytopia)\n+\"f\" = (\n+/obj/structure/weightlifter,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"g\" = (\n+/obj/structure/bed,\n+/obj/item/bedsheet/grey,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"h\" = (\n+/obj/structure/punching_bag,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"i\" = (\n+/mob/living/simple_animal/bot/medbot/mysterious{\n+\tstationary_mode = 1\n+\t},\n+/turf/open/floor/plating,\n+/area/greytopia)\n+\"j\" = (\n+/obj/structure/bonfire/dense,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"k\" = (\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"l\" = (\n+/obj/item/target,\n+/obj/item/gun/energy/laser/chameleon{\n+\tpixel_y = -8\n+\t},\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"m\" = (\n+/obj/structure/bed,\n+/obj/item/bedsheet/grey,\n+/turf/open/floor/plating{\n+\ticon_state = \"panelscorched\"\n+\t},\n+/area/greytopia)\n+\"n\" = (\n+/turf/open/floor/plating{\n+\ticon_state = \"platingdmg1\"\n+\t},\n+/area/greytopia)\n+\"o\" = (\n+/obj/structure/chair,\n+/obj/item/device/radio/headset/headset_com{\n+\tflags_1 = 80;\n+\tflags_2 = 66;\n+\tname = \"\\proper the head of assistants's bowman headset\"\n+\t},\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"p\" = (\n+/obj/structure/mirror{\n+\tpixel_x = 5\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/greytopia)\n+\"q\" = (\n+/obj/structure/sink{\n+\tdir = 8;\n+\tpixel_x = -12\n+\t},\n+/turf/open/floor/plating,\n+/area/greytopia)\n+\"r\" = (\n+/obj/effect/decal/cleanable/blood/gibs/torso,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"s\" = (\n+/obj/structure/chair{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"t\" = (\n+/obj/structure/table,\n+/obj/item/reagent_containers/food/snacks/salad/validsalad{\n+\tpixel_x = -9;\n+\tpixel_y = 2\n+\t},\n+/obj/item/reagent_containers/food/snacks/salad/validsalad{\n+\tpixel_x = 7;\n+\tpixel_y = 1\n+\t},\n+/obj/item/candle/infinite{\n+\tpixel_y = 9\n+\t},\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"u\" = (\n+/obj/item/chair,\n+/obj/item/banhammer,\n+/obj/effect/decal/cleanable/blood/old,\n+/turf/open/floor/plating{\n+\tluminosity = 2\n+\t},\n+/area/greytopia)\n+\"v\" = (\n+/obj/machinery/computer/security/wooden_tv,\n+/turf/open/floor/plating{\n+\tluminosity = 2","path":"_maps/RandomRooms/greytopia.dmm","position":151,"original_position":151,"commit_id":"fae3ac3e0306933130f485e763fb1e778eeb278c","original_commit_id":"fae3ac3e0306933130f485e763fb1e778eeb278c","user":{"login":"ShizCalev","id":6209658,"avatar_url":"https://avatars2.githubusercontent.com/u/6209658?v=4","gravatar_id":"","url":"https://api.github.com/users/ShizCalev","html_url":"https://github.com/ShizCalev","followers_url":"https://api.github.com/users/ShizCalev/followers","following_url":"https://api.github.com/users/ShizCalev/following{/other_user}","gists_url":"https://api.github.com/users/ShizCalev/gists{/gist_id}","starred_url":"https://api.github.com/users/ShizCalev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShizCalev/subscriptions","organizations_url":"https://api.github.com/users/ShizCalev/orgs","repos_url":"https://api.github.com/users/ShizCalev/repos","events_url":"https://api.github.com/users/ShizCalev/events{/privacy}","received_events_url":"https://api.github.com/users/ShizCalev/received_events","type":"User","site_admin":false},"body":"dv","created_at":"2018-03-12T16:18:44Z","updated_at":"2018-03-12T16:26:51Z","html_url":"https://github.com/tgstation/tgstation/pull/35922#discussion_r173856659","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/35922","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/173856659"},"html":{"href":"https://github.com/tgstation/tgstation/pull/35922#discussion_r173856659"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/35922"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/35922","id":170949239,"html_url":"https://github.com/tgstation/tgstation/pull/35922","diff_url":"https://github.com/tgstation/tgstation/pull/35922.diff","patch_url":"https://github.com/tgstation/tgstation/pull/35922.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/35922","number":35922,"state":"open","locked":false,"title":"Box Map Update that also adds a persistent art system, semi-randomized maint generation, a rage cage construction system, and new map spawners","user":{"login":"Robustin","id":6372371,"avatar_url":"https://avatars2.githubusercontent.com/u/6372371?v=4","gravatar_id":"","url":"https://api.github.com/users/Robustin","html_url":"https://github.com/Robustin","followers_url":"https://api.github.com/users/Robustin/followers","following_url":"https://api.github.com/users/Robustin/following{/other_user}","gists_url":"https://api.github.com/users/Robustin/gists{/gist_id}","starred_url":"https://api.github.com/users/Robustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robustin/subscriptions","organizations_url":"https://api.github.com/users/Robustin/orgs","repos_url":"https://api.github.com/users/Robustin/repos","events_url":"https://api.github.com/users/Robustin/events{/privacy}","received_events_url":"https://api.github.com/users/Robustin/received_events","type":"User","site_admin":false},"body":":cl: Robustin\r\nadd: Box got an update! The update focuses on maintenance with several new rooms and surprises. Every department has a new \"themed\" room in their respective maintenance. Get exploring!\r\nadd: Persistent Art and the Box art gallery! There is now an art gallery tucked away above the chapel featuring new \"durable\" picture frames that will save photos and paintings for viewing in later rounds.\r\nadd: Picture frames can now hold canvases.\r\nadd: Directional map loading! Currently limited to box's \"random rooms\", the map loader now supports loading in maps in South/East/West directions.\r\nadd: Box now possesses the ultimate rage cage - including a construction drone with an arsenal of special hazards. Ice arena with disposal chutes to launch into your opponents? Yes. Lava arena with emitters? Absolutely. Audience safety guaranteed? No. \r\nadd: Steam vents. These non-Ratvarian steam vents have a unique icon and steam effect. They can be controlled manually or en-masse with a control lever. Box sec and science maint now feature these vents.\r\nadd: New map spawners and visual effects to diversify the stuff you might see in maint.\r\nadd: Random rooms. There are now 5 rooms in maint that will select from a list of 14 new templates. Abandoned surgery might now pop up in scimaint, an electronics depot might end up where abandoned surgery was... you'll never know!\r\nadd: Maint blockage. At designated \"forks\" in maint there is now a chance that one of the paths will be blocked (and only accessible via the alternative route). \r\n/:cl:\r\n\r\nBox needs some love and this PR delivers. ","created_at":"2018-02-23T07:29:02Z","updated_at":"2018-03-12T16:26:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e15b3338c832ac11640b0fdee54ea2b167ca47e3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ninjanomnom","id":1234602,"avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},{"login":"WJohn","id":5988156,"avatar_url":"https://avatars1.githubusercontent.com/u/5988156?v=4","gravatar_id":"","url":"https://api.github.com/users/WJohn","html_url":"https://github.com/WJohn","followers_url":"https://api.github.com/users/WJohn/followers","following_url":"https://api.github.com/users/WJohn/following{/other_user}","gists_url":"https://api.github.com/users/WJohn/gists{/gist_id}","starred_url":"https://api.github.com/users/WJohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WJohn/subscriptions","organizations_url":"https://api.github.com/users/WJohn/orgs","repos_url":"https://api.github.com/users/WJohn/repos","events_url":"https://api.github.com/users/WJohn/events{/privacy}","received_events_url":"https://api.github.com/users/WJohn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":149581322,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":136257509,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Map%20Edit","name":"Map Edit","color":"eb6420","default":false},{"id":31457996,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Sprites","name":"Sprites","color":"5ECCD1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/35922/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/35922/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/35922/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/fae3ac3e0306933130f485e763fb1e778eeb278c","head":{"label":"Robustin:biggestbox","ref":"biggestbox","sha":"fae3ac3e0306933130f485e763fb1e778eeb278c","user":{"login":"Robustin","id":6372371,"avatar_url":"https://avatars2.githubusercontent.com/u/6372371?v=4","gravatar_id":"","url":"https://api.github.com/users/Robustin","html_url":"https://github.com/Robustin","followers_url":"https://api.github.com/users/Robustin/followers","following_url":"https://api.github.com/users/Robustin/following{/other_user}","gists_url":"https://api.github.com/users/Robustin/gists{/gist_id}","starred_url":"https://api.github.com/users/Robustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robustin/subscriptions","organizations_url":"https://api.github.com/users/Robustin/orgs","repos_url":"https://api.github.com/users/Robustin/repos","events_url":"https://api.github.com/users/Robustin/events{/privacy}","received_events_url":"https://api.github.com/users/Robustin/received_events","type":"User","site_admin":false},"repo":{"id":85407743,"name":"tgstation","full_name":"Robustin/tgstation","owner":{"login":"Robustin","id":6372371,"avatar_url":"https://avatars2.githubusercontent.com/u/6372371?v=4","gravatar_id":"","url":"https://api.github.com/users/Robustin","html_url":"https://github.com/Robustin","followers_url":"https://api.github.com/users/Robustin/followers","following_url":"https://api.github.com/users/Robustin/following{/other_user}","gists_url":"https://api.github.com/users/Robustin/gists{/gist_id}","starred_url":"https://api.github.com/users/Robustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robustin/subscriptions","organizations_url":"https://api.github.com/users/Robustin/orgs","repos_url":"https://api.github.com/users/Robustin/repos","events_url":"https://api.github.com/users/Robustin/events{/privacy}","received_events_url":"https://api.github.com/users/Robustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Robustin/tgstation","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/Robustin/tgstation","forks_url":"https://api.github.com/repos/Robustin/tgstation/forks","keys_url":"https://api.github.com/repos/Robustin/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robustin/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robustin/tgstation/teams","hooks_url":"https://api.github.com/repos/Robustin/tgstation/hooks","issue_events_url":"https://api.github.com/repos/Robustin/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/Robustin/tgstation/events","assignees_url":"https://api.github.com/repos/Robustin/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/Robustin/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/Robustin/tgstation/tags","blobs_url":"https://api.github.com/repos/Robustin/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robustin/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robustin/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robustin/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robustin/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/Robustin/tgstation/languages","stargazers_url":"https://api.github.com/repos/Robustin/tgstation/stargazers","contributors_url":"https://api.github.com/repos/Robustin/tgstation/contributors","subscribers_url":"https://api.github.com/repos/Robustin/tgstation/subscribers","subscription_url":"https://api.github.com/repos/Robustin/tgstation/subscription","commits_url":"https://api.github.com/repos/Robustin/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robustin/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robustin/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robustin/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robustin/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/Robustin/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robustin/tgstation/merges","archive_url":"https://api.github.com/repos/Robustin/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robustin/tgstation/downloads","issues_url":"https://api.github.com/repos/Robustin/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/Robustin/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/Robustin/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/Robustin/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robustin/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/Robustin/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/Robustin/tgstation/deployments","created_at":"2017-03-18T14:33:38Z","updated_at":"2017-03-18T14:33:50Z","pushed_at":"2018-03-10T22:47:10Z","git_url":"git://github.com/Robustin/tgstation.git","ssh_url":"git@github.com:Robustin/tgstation.git","clone_url":"https://github.com/Robustin/tgstation.git","svn_url":"https://github.com/Robustin/tgstation","homepage":"http://www.tgstation13.org/","size":1109185,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"b3b67b5812ede4e7bfd23bc30fcb6d0ff3eac0cb","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2018-03-12T14:13:38Z","pushed_at":"2018-03-12T15:49:39Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"https://www.tgstation13.org/","size":1092326,"stargazers_count":477,"watchers_count":477,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":1154,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1722,"open_issues":1154,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/35922"},"html":{"href":"https://github.com/tgstation/tgstation/pull/35922"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/35922"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/35922/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/35922/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/35922/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/fae3ac3e0306933130f485e763fb1e778eeb278c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
} | {
"id": 6209658,
"login": "ShizCalev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6209658?",
"url": "https://api.github.com/users/ShizCalev"
} | {
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
} | 2018-03-12T16:18:44 | 7366785573 | {"actor":{"display_login":"ShizCalev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/175249718","pull_request_review_id":104758115,"id":175249718,"diff_hunk":"@@ -31739,273 +31173,1727 @@\n \t},\n /turf/open/floor/plating,\n /area/maintenance/starboard/aft)\n-\"fWz\" = (\n-/obj/machinery/door/airlock/external{\n-\tname = \"External Docking Port\";\n-\treq_access_txt = \"63\"\n+\"dgV\" = (\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n \t},\n /obj/effect/turf_decal/stripes/line{\n-\tdir = 8\n-\t},\n-/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n-\tdir = 8\n+\tdir = 4\n \t},\n /turf/open/floor/plasteel,\n-/area/hallway/secondary/exit)\n-\"kKd\" = (\n+/area/engine/atmos)\n+\"diG\" = (\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"doD\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n /obj/machinery/door/firedoor,\n-/obj/machinery/door/airlock/external{\n-\tname = \"Mining Dock Airlock\";\n-\treq_access_txt = \"48\"\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n \t},\n /obj/effect/turf_decal/stripes/line{\n-\tdir = 8\n+\tdir = 2\n \t},\n /obj/effect/turf_decal/stripes/line{\n-\tdir = 4\n-\t},\n-/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n-\tdir = 8\n+\tdir = 1\n \t},\n /turf/open/floor/plasteel,\n-/area/quartermaster/miningdock)\n-\"lCg\" = (\n-/obj/machinery/door/airlock/external{\n-\tname = \"Supply Dock Airlock\";\n-\treq_access_txt = \"31\"\n-\t},\n-/obj/effect/turf_decal/stripes/line{\n-\tdir = 8\n-\t},\n-/obj/effect/turf_decal/stripes/line{\n-\tdir = 4\n-\t},\n-/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n+/area/hallway/primary/starboard)\n+\"dEa\" = (\n+/obj/machinery/computer/arcade,\n+/turf/open/floor/plasteel/vault{\n \tdir = 8\n \t},\n-/turf/open/floor/plasteel,\n-/area/quartermaster/storage)\n-\"nKi\" = (\n-/obj/machinery/door/airlock/maintenance_hatch{\n-\tname = \"Maintenance Hatch\";\n-\treq_access_txt = \"12\"\n-\t},\n-/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+/area/maintenance/port)\n+\"dFV\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n \tdir = 4\n \t},\n-/obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 1;\n+\tname = \"Oxygen to Airmix\";\n+\ton = 1\n \t},\n-/obj/effect/turf_decal/stripes/line{\n-\tdir = 8\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n \t},\n-/obj/effect/turf_decal/stripes/line{\n+/area/engine/atmos)\n+\"dMl\" = (\n+/obj/structure/sign/warning/fire,\n+/obj/machinery/atmospherics/pipe/simple/orange/visible{\n \tdir = 4\n \t},\n-/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n-\tdir = 4\n+/turf/closed/wall/r_wall,\n+/area/maintenance/disposal/incinerator)\n+\"dWc\" = (\n+/turf/closed/mineral/random/labormineral,\n+/area/space)\n+\"dYC\" = (\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden{\n+\tdir = 1\n \t},\n-/turf/open/floor/plating,\n-/area/maintenance/starboard/aft)\n-\"sws\" = (\n-/obj/docking_port/stationary{\n-\tdheight = 1;\n-\tdir = 8;\n-\tdwidth = 12;\n-\theight = 17;\n-\tid = \"syndicate_sw\";\n-\tname = \"southwest of station\";\n-\tturf_type = /turf/open/space;\n-\twidth = 23\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 1\n \t},\n-/turf/open/space,\n-/area/space/nearstation)\n-\"swv\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/bridge)\n-\"swx\" = (\n-/obj/structure/cable/white{\n+/area/hallway/primary/fore)\n+\"eaf\" = (\n+/obj/machinery/atmospherics/pipe/simple/yellow/visible,\n+/obj/structure/cable{\n \ticon_state = \"4-8\"\n \t},\n-/obj/structure/cable/white{\n-\ticon_state = \"1-8\"\n+/obj/effect/turf_decal/stripes/line,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"eew\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n \t},\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"eva\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n \tdir = 4\n \t},\n-/turf/open/floor/plasteel/vault/side{\n-\tdir = 9\n-\t},\n-/area/bridge)\n-\"swy\" = (\n-/turf/open/floor/plasteel/vault/side{\n-\tdir = 8\n+/obj/machinery/computer/atmos_control/tank{\n+\tdir = 1;\n+\tinput_tag = \"airmix_in\";\n+\tname = \"Airmix Supply Control\";\n+\toutput_tag = \"airmix_out\";\n+\tsensors = list(\"airmix_sensor\" = \"Tank\")\n \t},\n-/area/bridge)\n-\"swz\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/crew_quarters/heads/hop)\n-\"swA\" = (\n-/turf/closed/wall/rust,\n-/area/maintenance/starboard/fore)\n-\"swC\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/crew_quarters/heads/captain/private)\n-\"swD\" = (\n-/obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n \t},\n-/turf/open/floor/plasteel/vault/side{\n+/area/engine/atmos)\n+\"ewT\" = (\n+/obj/machinery/atmospherics/components/unary/vent_pump/on{\n \tdir = 8\n \t},\n-/area/bridge)\n-\"swF\" = (\n-/obj/structure/sign/warning/securearea,\n-/turf/closed/wall/rust,\n-/area/asteroid/nearstation)\n-\"swG\" = (\n-/turf/closed/wall/rust,\n-/area/security/detectives_office)\n-\"swJ\" = (\n-/obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n+/turf/open/floor/plasteel/greenblue/side{\n+\tdir = 1\n \t},\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n-\tdir = 4\n+/area/hydroponics)\n+\"exb\" = (\n+/obj/machinery/door/window/brigdoor{\n+\tdir = 8;\n+\tname = \"Creature Pen\";\n+\treq_access_txt = \"47\"\n \t},\n-/turf/open/floor/plasteel/vault/side{\n-\tdir = 4\n+/obj/machinery/door/poddoor/preopen{\n+\tid = \"xeno3\";\n+\tname = \"Creature Cell #3\"\n \t},\n-/area/bridge)\n-\"swK\" = (\n /obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n+\ticon_state = \"1-4\"\n \t},\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n-\tdir = 4\n+/obj/structure/cable/white{\n+\ticon_state = \"2-4\"\n \t},\n-/turf/open/floor/plasteel/vault/side{\n+/turf/open/floor/plasteel/vault{\n \tdir = 8\n \t},\n-/area/bridge)\n-\"swL\" = (\n-/turf/closed/wall/rust,\n-/area/quartermaster/storage)\n-\"swM\" = (\n-/obj/machinery/status_display{\n-\tname = \"cargo display\";\n-\tsupply_display = 1\n-\t},\n-/turf/closed/wall/rust,\n-/area/quartermaster/storage)\n-\"swN\" = (\n-/turf/closed/wall/rust,\n-/area/asteroid/nearstation)\n-\"swZ\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/security/brig)\n-\"sxc\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/asteroid/nearstation)\n-\"sxC\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/ai_monitored/turret_protected/ai)\n-\"syC\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/teleporter)\n-\"syD\" = (\n-/turf/closed/wall/rust,\n-/area/quartermaster/miningdock)\n-\"syS\" = (\n-/turf/closed/wall/rust,\n-/area/hallway/primary/central)\n-\"syT\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/ai_monitored/storage/eva)\n-\"sAc\" = (\n-/turf/closed/wall/rust,\n-/area/storage/primary)\n-\"sAx\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/engine/atmos)\n-\"sAy\" = (\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n-\tdir = 4\n+/area/science/xenobiology)\n+\"eyu\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 8\n \t},\n-/turf/closed/wall/r_wall/rust,\n+/obj/machinery/light/small,\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n+/turf/open/floor/engine,\n+/area/maintenance/disposal/incinerator)\n+\"ezP\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible,\n+/obj/effect/spawner/structure/window/reinforced,\n+/turf/open/floor/plating,\n /area/engine/atmos)\n-\"sAz\" = (\n-/turf/closed/wall/r_wall/rust,\n-/area/storage/primary)\n-\"sAA\" = (\n-/turf/closed/wall/rust,\n-/area/crew_quarters/bar/atrium)\n-\"sAX\" = (\n-/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\"eCg\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n \tdir = 4\n \t},\n-/obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n+/obj/machinery/atmospherics/pipe/simple/yellow/visible,\n+/obj/machinery/computer/atmos_control/tank{\n+\tdir = 1;\n+\tinput_tag = \"n2_in\";\n+\tname = \"Nitrogen Supply Control\";\n+\toutput_tag = \"n2_out\";\n+\tsensors = list(\"n2_sensor\" = \"Tank\")\n \t},\n-/turf/open/floor/plating{\n-\ticon_state = \"platingdmg1\"\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n \t},\n-/area/maintenance/starboard/central)\n-\"sAY\" = (\n-/turf/open/floor/plating{\n-\ticon_state = \"panelscorched\"\n+/area/engine/atmos)\n+\"eFp\" = (\n+/obj/effect/turf_decal/stripes/end{\n+\tdir = 8\n \t},\n-/area/maintenance/starboard)\n-\"sBu\" = (\n /obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n-/turf/closed/wall/r_wall/rust,\n-/area/security/brig)\n-\"sBv\" = (\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n-\tdir = 4\n+/obj/machinery/camera{\n+\tc_tag = \"Xenobiology North\";\n+\tdir = 4;\n+\tpixel_y = -5\n \t},\n-/turf/closed/wall/rust,\n-/area/crew_quarters/theatre)\n-\"sBw\" = (\n-/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+/turf/open/floor/plasteel,\n+/area/science/xenobiology)\n+\"eOs\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n \tdir = 4\n \t},\n-/turf/closed/wall/rust,\n-/area/crew_quarters/bar/atrium)\n-\"sBx\" = (\n-/obj/effect/landmark/xeno_spawn,\n-/obj/machinery/atmospherics/components/unary/vent_pump/on{\n-\tdir = 8\n-\t},\n-/obj/structure/cable/white{\n-\ticon_state = \"4-8\"\n-\t},\n-/turf/open/floor/plating,\n-/area/maintenance/starboard)\n-\"sBy\" = (\n-/obj/machinery/door/airlock/external{\n-\tname = \"External Airlock\";\n-\treq_access_txt = \"13\"\n-\t},\n+/obj/structure/table/reinforced,\n+/obj/item/storage/belt/utility,\n+/obj/item/storage/belt/utility,\n+/obj/item/clothing/glasses/meson/engine/tray,\n+/obj/item/clothing/glasses/meson/engine/tray,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"eUz\" = (\n+/obj/machinery/door/firedoor,\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n /obj/effect/turf_decal/stripes/line{\n-\tdir = 8\n+\tdir = 2\n \t},\n /obj/effect/turf_decal/stripes/line{\n-\tdir = 4\n+\tdir = 1\n \t},\n-/obj/structure/cable/white{\n+/turf/open/floor/plasteel,\n+/area/hallway/primary/aft)\n+\"eYe\" = (\n+/obj/effect/mapping_helpers/airlock/locked,\n+/obj/machinery/door/airlock/public/glass{\n+\tautoclose = 0;\n+\tfrequency = 1449;\n+\theat_proof = 1;\n+\tid_tag = \"incinerator_airlock_exterior\";\n+\tname = \"Incinerator Exterior Airlock\";\n+\treq_access_txt = \"12\"\n+\t},\n+/obj/structure/cable{\n \ticon_state = \"4-8\"\n \t},\n+/obj/effect/decal/cleanable/dirt,\n /obj/effect/mapping_helpers/airlock/cyclelink_helper{\n-\tdir = 8\n+\tdir = 4\n+\t},\n+/turf/open/floor/engine,\n+/area/maintenance/disposal/incinerator)\n+\"eZd\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible,\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 10\n \t},\n /turf/open/floor/plasteel,\n-/area/maintenance/starboard)\n-\"sBW\" = (\n-/obj/structure/sign/warning/vacuum,\n-/turf/closed/wall/rust,\n-/area/maintenance/starboard)\n-\"sCr\" = (\n+/area/engine/atmos)\n+\"fbH\" = (\n+/obj/machinery/atmospherics/pipe/simple/orange/visible,\n+/obj/effect/decal/cleanable/dirt,\n+/obj/structure/fireaxecabinet{\n+\tpixel_x = -30\n+\t},\n+/turf/open/floor/plasteel/caution{\n+\tdir = 8\n+\t},\n+/area/engine/atmos)\n+\"fgG\" = (\n+/obj/machinery/ai_status_display,\n+/turf/closed/wall,\n+/area/crew_quarters/lounge)\n+\"fjs\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/obj/machinery/camera{\n+\tc_tag = \"Atmospherics Central\";\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"fnp\" = (\n+/obj/machinery/air_sensor{\n+\tfrequency = 1441;\n+\tid_tag = \"n2o_sensor\"\n+\t},\n+/turf/open/floor/engine/n2o,\n+/area/engine/atmos)\n+\"fom\" = (\n+/obj/structure/lattice/catwalk,\n+/obj/item/wrench,\n+/turf/open/space,\n+/area/space/nearstation)\n+\"fsJ\" = (\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/obj/machinery/atmospherics/components/binary/dp_vent_pump/high_volume{\n+\tdir = 2;\n+\tfrequency = 1449;\n+\tid = \"incinerator_airlock_pump\"\n+\t},\n+/turf/open/floor/engine,\n+/area/maintenance/disposal/incinerator)\n+\"fvd\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"fEt\" = (\n+/obj/machinery/atmospherics/pipe/manifold/general/visible,\n+/obj/machinery/meter,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"fEM\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/hidden{\n+\ticon_state = \"intact\";\n+\tdir = 6\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"fFw\" = (\n+/obj/machinery/atmospherics/components/unary/portables_connector/visible,\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/obj/machinery/portable_atmospherics/canister,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"fIN\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 10\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"fLr\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 9\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"fMT\" = (\n+/obj/machinery/door/firedoor,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/hallway/primary/starboard)\n+\"fSE\" = (\n+/turf/closed/wall/r_wall,\n+/area/space)\n+\"fWz\" = (\n+/obj/machinery/door/airlock/external{\n+\tname = \"External Docking Port\";\n+\treq_access_txt = \"63\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel,\n+/area/hallway/secondary/exit)\n+\"fYx\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/obj/machinery/light,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"gap\" = (\n+/obj/machinery/portable_atmospherics/canister/nitrous_oxide,\n+/turf/open/floor/engine/n2o,\n+/area/engine/atmos)\n+\"gdA\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 6\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/maintenance/disposal/incinerator)\n+\"geZ\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n+/turf/open/floor/plasteel/neutral/corner,\n+/area/hallway/primary/port)\n+\"gii\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/turf/open/floor/plasteel/neutral,\n+/area/hallway/primary/aft)\n+\"glC\" = (\n+/turf/closed/wall/r_wall,\n+/area/maintenance/starboard/aft)\n+\"guM\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/structure/cable{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"gyV\" = (\n+/obj/machinery/atmospherics/pipe/manifold/supply/hidden{\n+\tdir = 1\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 4\n+\t},\n+/area/hallway/primary/starboard)\n+\"gNH\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plating/asteroid/airless,\n+/area/asteroid/nearstation)\n+\"gSv\" = (\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/orange/visible,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 8\n+\t},\n+/area/engine/atmos)\n+\"gVX\" = (\n+/obj/machinery/atmospherics/components/trinary/filter/flipped{\n+\tdir = 8;\n+\tfilter_type = \"co2\";\n+\ton = 1\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"heQ\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/machinery/navbeacon{\n+\tcodes_txt = \"patrol;next_patrol=8.3-AftSW\";\n+\tlocation = \"8.2-AftSE\"\n+\t},\n+/turf/open/floor/plasteel/neutral/corner,\n+/area/hallway/primary/aft)\n+\"hpr\" = (\n+/obj/machinery/navbeacon{\n+\tcodes_txt = \"patrol;next_patrol=3.2-AtriumSW\";\n+\tlocation = \"3.1-AtriumNW\"\n+\t},\n+/turf/open/floor/plasteel/redyellow,\n+/area/crew_quarters/bar/atrium)\n+\"hqX\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"hsV\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/turf/closed/wall/r_wall/rust,\n+/area/engine/atmos)\n+\"hDi\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/obj/machinery/navbeacon{\n+\tcodes_txt = \"patrol;next_patrol=3.4-AtriumNE\";\n+\tlocation = \"3.3-AtriumSE\"\n+\t},\n+/turf/open/floor/plasteel/redyellow,\n+/area/crew_quarters/bar/atrium)\n+\"hNO\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/hidden{\n+\ticon_state = \"intact\";\n+\tdir = 5\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"hOh\" = (\n+/obj/machinery/portable_atmospherics/canister/carbon_dioxide,\n+/turf/open/floor/engine/co2,\n+/area/engine/atmos)\n+\"hUG\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"hUL\" = (\n+/obj/effect/landmark/start/atmospheric_technician,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"hXn\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/pipedispenser,\n+/obj/effect/turf_decal/bot,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iaa\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n+/obj/machinery/navbeacon{\n+\tcodes_txt = \"patrol;next_patrol=2.1-Teleporter\";\n+\tlocation = \"1.2-BrigNorth\"\n+\t},\n+/turf/open/floor/plasteel/red/corner{\n+\tdir = 1\n+\t},\n+/area/hallway/primary/port/fore)\n+\"ibv\" = (\n+/turf/closed/wall,\n+/area/science/xenobiology)\n+\"idD\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/light,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"iqC\" = (\n+/obj/machinery/air_sensor{\n+\tfrequency = 1441;\n+\tid_tag = \"co2_sensor\"\n+\t},\n+/turf/open/floor/engine/co2,\n+/area/engine/atmos)\n+\"ixk\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iye\" = (\n+/obj/machinery/atmospherics/components/unary/vent_pump/siphon/on{\n+\tdir = 4\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"iIj\" = (\n+/obj/machinery/atmospherics/components/trinary/mixer/flipped{\n+\tdir = 4;\n+\tnode1_concentration = 0.8;\n+\tnode2_concentration = 0.2;\n+\ton = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iJY\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/turf_decal/stripes/line,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iKp\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 5\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iML\" = (\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel/neutral,\n+/area/hallway/primary/aft)\n+\"iVw\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/turf/open/floor/plasteel/whitepurple/side{\n+\tdir = 4\n+\t},\n+/area/science/xenobiology)\n+\"iVy\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 5\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/visible,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"iZQ\" = (\n+/obj/machinery/atmospherics/components/unary/outlet_injector/on{\n+\tdir = 2;\n+\tfrequency = 1441;\n+\tid = \"co2_in\";\n+\tname = \"co2 injector\";\n+\tpixel_y = 1\n+\t},\n+/turf/open/floor/engine/co2,\n+/area/engine/atmos)\n+\"jbQ\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 5\n+\t},\n+/obj/structure/lattice,\n+/turf/open/space/basic,\n+/area/space/nearstation)\n+\"jcn\" = (\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/obj/machinery/navbeacon{\n+\tcodes_txt = \"patrol;next_patrol=3.1-AtriumNW\";\n+\tlocation = \"2.2-BridgeWest\"\n+\t},\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 8;\n+\theat_capacity = 1e+006\n+\t},\n+/area/hallway/primary/fore)\n+\"jdD\" = (\n+/obj/structure/table/reinforced,\n+/obj/machinery/button/door{\n+\tid = \"xeno3\";\n+\tname = \"Containment Control\";\n+\treq_access_txt = \"55\"\n+\t},\n+/obj/effect/turf_decal/bot,\n+/turf/open/floor/plasteel,\n+/area/science/xenobiology)\n+\"jkl\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"jpv\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/machinery/light{\n+\tdir = 1\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/obj/structure/sign/poster/random{\n+\tpixel_y = 32\n+\t},\n+/turf/open/floor/plasteel/caution{\n+\tdir = 1\n+\t},\n+/area/engine/atmos)\n+\"jqM\" = (\n+/obj/effect/turf_decal/bot,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel/vault/side{\n+\tdir = 8\n+\t},\n+/area/hallway/primary/starboard)\n+\"jtZ\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"juT\" = (\n+/obj/machinery/atmospherics/pipe/simple/yellow/visible,\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"jwi\" = (\n+/obj/structure/sign/directions/engineering{\n+\tdir = 8;\n+\tpixel_y = 8\n+\t},\n+/obj/structure/sign/directions/security{\n+\tdir = 8\n+\t},\n+/obj/structure/sign/directions/medical{\n+\tpixel_y = -8\n+\t},\n+/turf/closed/wall,\n+/area/hallway/primary/fore)\n+\"jxc\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"jBG\" = (\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"1-4\"\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"1-8\"\n+\t},\n+/obj/machinery/atmospherics/pipe/manifold/supply/hidden{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel/whitepurple/side{\n+\tdir = 4\n+\t},\n+/area/science/xenobiology)\n+\"jCi\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/light,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"jDd\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/hidden{\n+\ticon_state = \"intact\";\n+\tdir = 8\n+\t},\n+/turf/closed/wall/r_wall/rust,\n+/area/engine/atmos)\n+\"kaA\" = (\n+/obj/machinery/atmospherics/components/unary/portables_connector/visible{\n+\tdir = 1\n+\t},\n+/obj/machinery/portable_atmospherics/scrubber,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/escape{\n+\tdir = 10\n+\t},\n+/area/engine/atmos)\n+\"kit\" = (\n+/obj/machinery/portable_atmospherics/canister/toxins,\n+/turf/open/floor/engine/plasma,\n+/area/engine/atmos)\n+\"kiw\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible,\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"kwF\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 1;\n+\tname = \"Nitrogen to Airmix\";\n+\ton = 1\n+\t},\n+/obj/machinery/light,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"kCU\" = (\n+/obj/machinery/atmospherics/pipe/simple/orange/visible{\n+\tdir = 4\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"kHA\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/computer/atmos_control/tank{\n+\tdir = 2;\n+\tinput_tag = \"co2_in\";\n+\tname = \"Carbox Dioxide Supply Control\";\n+\toutput_tag = \"co2_out\";\n+\tsensors = list(\"co2_sensor\" = \"Tank\")\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"kKd\" = (\n+/obj/machinery/door/firedoor,\n+/obj/machinery/door/airlock/external{\n+\tname = \"Mining Dock Airlock\";\n+\treq_access_txt = \"48\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel,\n+/area/quartermaster/miningdock)\n+\"kTz\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible,\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"lrg\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/structure/lattice,\n+/turf/open/space/basic,\n+/area/space/nearstation)\n+\"lvw\" = (\n+/obj/machinery/atmospherics/pipe/simple/orange/visible,\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/caution{\n+\tdir = 8\n+\t},\n+/area/engine/atmos)\n+\"lxq\" = (\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 4\n+\t},\n+/area/hallway/primary/port)\n+\"lyp\" = (\n+/obj/machinery/atmospherics/components/unary/vent_scrubber/on,\n+/turf/open/floor/plasteel/greenblue/side,\n+/area/hydroponics)\n+\"lAs\" = (\n+/obj/effect/decal/cleanable/dirt,\n+/obj/item/device/radio/intercom{\n+\tname = \"Station Intercom\";\n+\tpixel_y = 24\n+\t},\n+/obj/machinery/camera{\n+\tc_tag = \"Atmospherics North West\";\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel/caution{\n+\tdir = 9\n+\t},\n+/area/engine/atmos)\n+\"lCg\" = (\n+/obj/machinery/door/airlock/external{\n+\tname = \"Supply Dock Airlock\";\n+\treq_access_txt = \"31\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n+\tdir = 8\n+\t},\n+/turf/open/floor/plasteel,\n+/area/quartermaster/storage)\n+\"lEr\" = (\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel/neutral/corner,\n+/area/hallway/primary/aft)\n+\"lFi\" = (\n+/obj/effect/spawner/structure/window/reinforced,\n+/turf/open/floor/plating,\n+/area/hallway/primary/starboard)\n+\"lFw\" = (\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/visible,\n+/turf/open/floor/plating/asteroid/airless,\n+/area/asteroid/nearstation)\n+\"lIM\" = (\n+/turf/closed/wall/rust,\n+/area/crew_quarters/lounge)\n+\"lQs\" = (\n+/obj/machinery/door/firedoor,\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/hallway/primary/starboard)\n+\"lUu\" = (\n+/obj/machinery/portable_atmospherics/canister/air,\n+/turf/open/floor/engine/air,\n+/area/engine/atmos)\n+\"lXk\" = (\n+/obj/structure/closet/firecloset,\n+/obj/effect/turf_decal/delivery,\n+/turf/open/floor/plasteel/vault/side{\n+\tdir = 8\n+\t},\n+/area/hallway/primary/aft)\n+\"lZR\" = (\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 8;\n+\theat_capacity = 1e+006\n+\t},\n+/area/hallway/primary/fore)\n+\"mae\" = (\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mgs\" = (\n+/obj/machinery/atmospherics/components/unary/outlet_injector/on{\n+\tdir = 1;\n+\tfrequency = 1441;\n+\tid = \"airmix_in\";\n+\tname = \"airmix injector\"\n+\t},\n+/turf/open/floor/engine/air,\n+/area/engine/atmos)\n+\"mkF\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/structure/table/reinforced,\n+/obj/item/clothing/head/welding,\n+/obj/item/clothing/head/welding{\n+\tpixel_y = 5\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mnD\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/pipedispenser/disposal,\n+/obj/effect/turf_decal/bot,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mqF\" = (\n+/obj/machinery/door/poddoor{\n+\tid = \"turbinevent\";\n+\tname = \"Turbine Vent\"\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"msJ\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/machinery/atmospherics/pipe/simple/orange/visible{\n+\tdir = 4\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mJP\" = (\n+/obj/machinery/igniter{\n+\ticon_state = \"igniter0\";\n+\tid = \"Incinerator\";\n+\tluminosity = 2;\n+\ton = 0\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"mJQ\" = (\n+/obj/structure/table/glass,\n+/obj/effect/turf_decal/delivery,\n+/obj/item/book/manual/hydroponics_pod_people,\n+/obj/item/paper/guides/jobs/hydroponics,\n+/turf/open/floor/plasteel/neutral,\n+/area/hydroponics)\n+\"mQi\" = (\n+/turf/closed/wall/rust,\n+/area/maintenance/starboard/central)\n+\"mTv\" = (\n+/obj/machinery/atmospherics/pipe/manifold/cyan/visible{\n+\tdir = 1\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"2-4\"\n+\t},\n+/obj/effect/turf_decal/stripes/line,\n+/obj/machinery/meter,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mTM\" = (\n+/turf/open/floor/engine/co2,\n+/area/engine/atmos)\n+\"mTT\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 8;\n+\tname = \"Port to Fuel Pipe\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"mXV\" = (\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 4\n+\t},\n+/area/hallway/primary/starboard)\n+\"ndg\" = (\n+/turf/open/floor/plasteel/neutral/corner,\n+/area/hallway/primary/fore)\n+\"nhU\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/maintenance/disposal/incinerator)\n+\"nwY\" = (\n+/obj/effect/spawner/structure/window/reinforced,\n+/turf/open/floor/plating,\n+/area/hallway/primary/starboard/fore)\n+\"nxA\" = (\n+/turf/closed/wall,\n+/area/hallway/primary/port/aft)\n+\"nFG\" = (\n+/obj/machinery/atmospherics/pipe/manifold/yellow/visible{\n+\tdir = 8\n+\t},\n+/obj/machinery/meter,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"nKi\" = (\n+/obj/machinery/door/airlock/maintenance_hatch{\n+\tname = \"Maintenance Hatch\";\n+\treq_access_txt = \"12\"\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/obj/effect/mapping_helpers/airlock/cyclelink_helper{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plating,\n+/area/maintenance/starboard/aft)\n+\"nTi\" = (\n+/obj/structure/sign/warning/biohazard,\n+/turf/closed/wall,\n+/area/science/xenobiology)\n+\"nUk\" = (\n+/obj/effect/decal/cleanable/dirt,\n+/obj/machinery/atmospherics/pipe/simple/general/visible,\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 10\n+\t},\n+/turf/open/floor/plasteel/caution,\n+/area/engine/atmos)\n+\"oaV\" = (\n+/obj/structure/grille,\n+/obj/machinery/meter,\n+/obj/machinery/atmospherics/pipe/simple/yellow/visible,\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"oiL\" = (\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/caution{\n+\tdir = 1\n+\t},\n+/area/engine/atmos)\n+\"oql\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"orI\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/structure/cable{\n+\ticon_state = \"1-8\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"otn\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 6\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"oxn\" = (\n+/obj/machinery/power/compressor{\n+\ticon_state = \"compressor\";\n+\tdir = 4;\n+\tluminosity = 2;\n+\tcomp_id = \"incineratorturbine\"\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"0-4\"\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"0-8\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"oyD\" = (\n+/turf/closed/wall,\n+/area/crew_quarters/toilet/restrooms)\n+\"oCy\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/obj/structure/cable{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"oGc\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible{\n+\tdir = 6\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"oIG\" = (\n+/obj/structure/sign/warning/fire,\n+/turf/closed/wall/r_wall,\n+/area/maintenance/disposal/incinerator)\n+\"oJp\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/machinery/atmospherics/components/unary/vent_pump/on,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"oOk\" = (\n+/turf/open/floor/engine/plasma,\n+/area/engine/atmos)\n+\"oQL\" = (\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden{\n+\tdir = 1\n+\t},\n+/obj/machinery/atmospherics/components/unary/vent_pump/on{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel/neutral/corner,\n+/area/hallway/primary/starboard)\n+\"pbT\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 10\n+\t},\n+/turf/open/floor/plasteel/vault,\n+/area/engine/gravity_generator)\n+\"pcl\" = (\n+/obj/machinery/atmospherics/components/unary/vent_pump/siphon/on{\n+\tdir = 2;\n+\tfrequency = 1441;\n+\tid_tag = \"mix_out\";\n+\tname = \"distro vent\"\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/engine/atmos)\n+\"pjU\" = (\n+/obj/structure/grille,\n+/obj/machinery/atmospherics/pipe/simple/yellow/hidden{\n+\ticon_state = \"intact\";\n+\tdir = 6\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"plz\" = (\n+/obj/effect/turf_decal/stripes/end{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/machinery/button/door{\n+\tid = \"xeno5\";\n+\tname = \"Containment Control\";\n+\tpixel_x = 26;\n+\tpixel_y = -6;\n+\treq_access_txt = \"55\"\n+\t},\n+/obj/machinery/button/door{\n+\tid = \"xeno4\";\n+\tname = \"Containment Control\";\n+\tpixel_x = 26;\n+\tpixel_y = 6;\n+\treq_access_txt = \"55\"\n+\t},\n+/turf/open/floor/plasteel,\n+/area/science/xenobiology)\n+\"pqs\" = (\n+/obj/machinery/power/turbine{\n+\ticon_state = \"turbine\";\n+\tdir = 8;\n+\tluminosity = 2\n+\t},\n+/obj/structure/sign/warning/vacuum{\n+\tpixel_y = -32\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"0-4\"\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"psq\" = (\n+/obj/structure/sign/poster/random{\n+\tpixel_y = 32\n+\t},\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/science/xenobiology)\n+\"pvX\" = (\n+/obj/effect/decal/cleanable/dirt,\n+/obj/machinery/atmospherics/pipe/simple/orange/visible,\n+/obj/machinery/atmospherics/pipe/simple/general/visible{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel/caution{\n+\tdir = 10\n+\t},\n+/area/engine/atmos)\n+\"pEH\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/open/floor/plating,\n+/area/asteroid/nearstation)\n+\"pLb\" = (\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/machinery/atmospherics/pipe/manifold/scrubbers/hidden{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel/whitepurple/side{\n+\tdir = 8\n+\t},\n+/area/science/xenobiology)\n+\"pNE\" = (\n+/obj/structure/grille,\n+/obj/machinery/atmospherics/pipe/simple/cyan/hidden{\n+\ticon_state = \"intact\";\n+\tdir = 8\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"qdt\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 5\n+\t},\n+/obj/structure/reagent_dispensers/watertank/high,\n+/turf/open/floor/plasteel/greenblue/side{\n+\tdir = 9\n+\t},\n+/area/hydroponics)\n+\"qdD\" = (\n+/obj/machinery/holopad,\n+/obj/effect/turf_decal/bot,\n+/turf/open/floor/plasteel,\n+/area/hallway/primary/fore)\n+\"qgC\" = (\n+/obj/machinery/atmospherics/components/unary/outlet_injector/on{\n+\tdir = 4;\n+\tfrequency = 1441;\n+\tid = \"mix_in\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/engine/vacuum,\n+/area/maintenance/disposal/incinerator)\n+\"qoT\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 1;\n+\tname = \"Nitrogen to Pure\"\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qpG\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/turf/closed/wall/r_wall/rust,\n+/area/engine/gravity_generator)\n+\"qsc\" = (\n+/obj/machinery/air_sensor{\n+\tfrequency = 1441;\n+\tid_tag = \"airmix_sensor\"\n+\t},\n+/turf/open/floor/engine/air,\n+/area/engine/atmos)\n+\"qui\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tname = \"Distro to Waste\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qEl\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/pipedispenser/disposal/transit_tube,\n+/obj/effect/turf_decal/bot,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qFw\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 1;\n+\tname = \"Pure to Mix\"\n+\t},\n+/obj/machinery/light{\n+\tdir = 1\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"qIp\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/obj/machinery/atmospherics/components/unary/vent_scrubber/on{\n+\tdir = 4\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qMr\" = (\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 8\n+\t},\n+/obj/machinery/atmospherics/pipe/manifold/general/visible{\n+\tdir = 1\n+\t},\n+/obj/machinery/meter,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qTa\" = (\n+/obj/machinery/atmospherics/pipe/simple/orange/visible{\n+\tdir = 4\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 9\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"qUW\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 5\n+\t},\n+/turf/closed/wall/r_wall,\n+/area/engine/atmos)\n+\"rae\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 1;\n+\tname = \"Airmix to Pure\"\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"rjQ\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"rjV\" = (\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tdir = 4\n+\t},\n+/obj/machinery/light/small{\n+\tdir = 1\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/machinery/airlock_sensor{\n+\tid_tag = \"incinerator_airlock_sensor\";\n+\tmaster_tag = \"incinerator_airlock_control\";\n+\tpixel_y = 24\n+\t},\n+/turf/open/floor/engine,\n+/area/maintenance/disposal/incinerator)\n+\"rlq\" = (\n+/obj/machinery/door/firedoor,\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden,\n+/obj/structure/cable/white{\n+\ticon_state = \"1-2\"\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 2\n+\t},\n+/obj/effect/turf_decal/stripes/line{\n+\tdir = 1\n+\t},\n+/turf/open/floor/plasteel,\n+/area/hallway/primary/aft)\n+\"rzn\" = (\n+/obj/machinery/status_display,\n+/turf/closed/wall,\n+/area/hallway/primary/starboard)\n+\"rzq\" = (\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/visible{\n+\tdir = 6\n+\t},\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"rCw\" = (\n+/obj/machinery/door/window/brigdoor{\n+\tdir = 4;\n+\tname = \"Creature Pen\";\n+\treq_access_txt = \"47\"\n+\t},\n+/obj/machinery/door/poddoor/preopen{\n+\tid = \"xeno4\";\n+\tname = \"Creature Cell #4\"\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"1-8\"\n+\t},\n+/obj/structure/cable/white{\n+\ticon_state = \"2-8\"\n+\t},\n+/obj/effect/turf_decal/delivery,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 8\n+\t},\n+/area/science/xenobiology)\n+\"rEx\" = (\n+/obj/machinery/atmospherics/pipe/simple/cyan/visible{\n+\tdir = 4\n+\t},\n+/obj/structure/cable{\n+\ticon_state = \"4-8\"\n+\t},\n+/obj/effect/turf_decal/stripes/line,\n+/turf/open/floor/plasteel,\n+/area/engine/atmos)\n+\"rVj\" = (\n+/obj/machinery/atmospherics/components/unary/vent_pump/siphon/on{\n+\tdir = 1;\n+\tfrequency = 1441;\n+\tid_tag = \"airmix_out\";\n+\tname = \"airmix vent\"\n+\t},\n+/turf/open/floor/engine/air,\n+/area/engine/atmos)\n+\"rVs\" = (\n+/obj/machinery/atmospherics/components/unary/outlet_injector/on{\n+\tdir = 2;\n+\tfrequency = 1441;\n+\tid = \"mix_in\";\n+\tname = \"gas mix injector\";\n+\tpixel_y = 1\n+\t},\n+/turf/open/floor/engine/vacuum,\n+/area/engine/atmos)\n+\"sak\" = (\n+/obj/effect/landmark/event_spawn,\n+/turf/open/floor/plasteel/greenblue/side{\n+\tdir = 1\n+\t},\n+/area/hydroponics)\n+\"sdL\" = (\n+/obj/effect/turf_decal/delivery,\n+/obj/machinery/hydroponics/soil,\n+/turf/open/floor/plasteel/vault/side,\n+/area/maintenance/starboard/aft)\n+\"soC\" = (\n+/obj/machinery/atmospherics/pipe/simple/supply/hidden{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/pipe/simple/scrubbers/hidden,\n+/obj/structure/cable/white{\n+\ticon_state = \"4-8\"\n+\t},\n+/turf/open/floor/plasteel/neutral/corner{\n+\tdir = 4\n+\t},\n+/area/hallway/primary/starboard)\n+\"sqz\" = (\n+/turf/closed/wall,\n+/area/hallway/primary/starboard)\n+\"srh\" = (\n+/obj/machinery/atmospherics/pipe/simple/green/visible{\n+\tdir = 4\n+\t},\n+/obj/machinery/atmospherics/components/binary/pump{\n+\tname = \"CO2 to Pure\"\n+\t},\n+/obj/effect/decal/cleanable/dirt,\n+/turf/open/floor/plasteel/vault{\n+\tdir = 5\n+\t},\n+/area/engine/atmos)\n+\"srR\" = (\n+/obj/machinery/atmospherics/components/unary/outlet_injector/on{\n+\tdir = 2;\n+\tfrequency = 1441;\n+\tid = \"n2o_in\";\n+\tname = \"n2o injector\";\n+\tpixel_y = 1","path":"_maps/map_files/OmegaStation/OmegaStation.dmm","position":7969,"original_position":7969,"commit_id":"2790073810d96560d616f9f762887a1a01440760","original_commit_id":"2790073810d96560d616f9f762887a1a01440760","user":{"login":"ShizCalev","id":6209658,"avatar_url":"https://avatars2.githubusercontent.com/u/6209658?v=4","gravatar_id":"","url":"https://api.github.com/users/ShizCalev","html_url":"https://github.com/ShizCalev","followers_url":"https://api.github.com/users/ShizCalev/followers","following_url":"https://api.github.com/users/ShizCalev/following{/other_user}","gists_url":"https://api.github.com/users/ShizCalev/gists{/gist_id}","starred_url":"https://api.github.com/users/ShizCalev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShizCalev/subscriptions","organizations_url":"https://api.github.com/users/ShizCalev/orgs","repos_url":"https://api.github.com/users/ShizCalev/repos","events_url":"https://api.github.com/users/ShizCalev/events{/privacy}","received_events_url":"https://api.github.com/users/ShizCalev/received_events","type":"User","site_admin":false},"body":"dv?","created_at":"2018-03-17T06:29:35Z","updated_at":"2018-03-17T06:33:38Z","html_url":"https://github.com/tgstation/tgstation/pull/36468#discussion_r175249718","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/36468","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/175249718"},"html":{"href":"https://github.com/tgstation/tgstation/pull/36468#discussion_r175249718"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/36468"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/36468","id":175655951,"html_url":"https://github.com/tgstation/tgstation/pull/36468","diff_url":"https://github.com/tgstation/tgstation/pull/36468.diff","patch_url":"https://github.com/tgstation/tgstation/pull/36468.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/36468","number":36468,"state":"open","locked":false,"title":"Omegastation: The spring cleaning DLC","user":{"login":"81Denton","id":32391752,"avatar_url":"https://avatars2.githubusercontent.com/u/32391752?v=4","gravatar_id":"","url":"https://api.github.com/users/81Denton","html_url":"https://github.com/81Denton","followers_url":"https://api.github.com/users/81Denton/followers","following_url":"https://api.github.com/users/81Denton/following{/other_user}","gists_url":"https://api.github.com/users/81Denton/gists{/gist_id}","starred_url":"https://api.github.com/users/81Denton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/81Denton/subscriptions","organizations_url":"https://api.github.com/users/81Denton/orgs","repos_url":"https://api.github.com/users/81Denton/repos","events_url":"https://api.github.com/users/81Denton/events{/privacy}","received_events_url":"https://api.github.com/users/81Denton/received_events","type":"User","site_admin":false},"body":":cl: Denton\r\nadd: It's suicide HoPline prevention week at Omegastation! \r\nadd: Navigation beacons and a brand-new Officer Beepsky unit have been installed. This means that crewmembers can now use medibots, janibots and other bots as well.\r\nadd: The atmospherics department has been outfitted with all missing gases as well as an incinerator and a hardsuit.\r\nadd: The size of the botany and xenobiology departments have been increased in order to increase productivity.\r\nadd: RnD now has circuitry tools; medbay has stethoscopes and primary tool storage has multitools. Enginers no longer have to share a single pair of insulated gloves either.\r\nadd: Engineers now have access to an Engi-Vend vending machine as well as missing tools like inducers. Circuitry storage has a smoke machine board and a solars crate in case the engine blows up.\r\ntweak: Blueprints have been moved from the vault safe to secure storage in order to speed up construction projects.\r\nfix: AI sat turret control can now be accessed from the outside. The first two turrets now use the proper type of gun. The telecomms air alarm will no longer report false alarms.\r\nfix: The main hallway's firelocks now no longer all close at once.\r\n/:cl:\r\n\r\n[why]: While Omega has a decent size for lowpop, some areas are just too small and too sparsely equipped to allow proper gameplay (6 trays for 2 botanists? no gas mixing or incinerator for atmos techs? come on). This often leads to mass spacing or HoPline suicides at roundstart. I hope I can fix that at least a little bit.\r\n\r\n[Botany before/after](https://i.imgur.com/IfV7l3M.jpg)\r\n[Xenobiology before/after](https://i.imgur.com/IAbwjqa.jpg)\r\n[Atmospherics before/after](https://i.imgur.com/netIA4q.jpg)\r\n\r\n<details><summary>Structural:</summary>\r\n<p>\r\n- Added nav beacons with patrol paths as well as Officer Beepsky (the base model with 25 health).<br>\r\n- Made botanics larger by cutting into the anti-breach storage next to it.<br>\r\n- Increased xenobio's size, adding two slime pens.<br>\r\n- Added missing gases (CO2, Plasma, N2O) as well as an incinerator and a hardsuit to atmospherics.<br>\r\n- Split the \"central primary hallway\" area into multiple areas. This way, a single fire alarm doesn't shut down half the station.\r\n</p>\r\n</details>\r\n\r\n<details><summary>Additions:</summary>\r\n<p>\r\n- Circuitry storage: Smoke machine circuit board and a solars crate, since Omega doesn't come with solars by default.<br>\r\n- Engineering: Insulated gloves (before, all engineers had to share a single pair). An engi-vend machine and a locker with electrical supplies.<br>\r\n- Misc: Stethoscopes for medbay, multitools for tool storage and arcade machines.\r\n</p>\r\n</details>\r\n\r\n<details><summary>Tweaks:</summary>\r\n<p>\r\n- Blueprints have been moved from the vault safe to Engineering secure storage. I've had lots of complaints that construction projects were neigh impossible because A) they were inside the vault safe and B) Omega had no stethoscopes either.<br>\r\n- Replaced meson goggles in engineering with the scanner model.<br>\r\n- Reduced the AI sat SMES starting charge by 80%. The Omega minisat draws so little power that the SMES was at ~90% after a three hour round.\r\n</p>\r\n</details>\r\n\r\n<details><summary>Fixes:</summary>\r\n<p>\r\n- The telecomms air alarm now uses the correct \"airalarm\\server\" subtype and should no longer report false alarms.<br>\r\n- Fixed the position of the first AI sat turret control panel. Before, you had to stand inside the open door to access it.<br>\r\n- Fixed the gun subtype of the first two turrets (it used to be e_gun instead of e_gun/turret).\r\n</p>\r\n</details>","created_at":"2018-03-16T22:01:21Z","updated_at":"2018-03-17T06:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732c972f85610aece3d05a87f3fe0f9a07eaeaf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":149581322,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":157846355,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Fix","name":"Fix","color":"00bbdd","default":false},{"id":136257509,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Map%20Edit","name":"Map Edit","color":"eb6420","default":false},{"id":373745412,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Tweak","name":"Tweak","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/36468/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/36468/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/36468/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/2790073810d96560d616f9f762887a1a01440760","head":{"label":"81Denton:omeganna-drive-me-crazy","ref":"omeganna-drive-me-crazy","sha":"2790073810d96560d616f9f762887a1a01440760","user":{"login":"81Denton","id":32391752,"avatar_url":"https://avatars2.githubusercontent.com/u/32391752?v=4","gravatar_id":"","url":"https://api.github.com/users/81Denton","html_url":"https://github.com/81Denton","followers_url":"https://api.github.com/users/81Denton/followers","following_url":"https://api.github.com/users/81Denton/following{/other_user}","gists_url":"https://api.github.com/users/81Denton/gists{/gist_id}","starred_url":"https://api.github.com/users/81Denton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/81Denton/subscriptions","organizations_url":"https://api.github.com/users/81Denton/orgs","repos_url":"https://api.github.com/users/81Denton/repos","events_url":"https://api.github.com/users/81Denton/events{/privacy}","received_events_url":"https://api.github.com/users/81Denton/received_events","type":"User","site_admin":false},"repo":{"id":119250400,"name":"tgstation","full_name":"81Denton/tgstation","owner":{"login":"81Denton","id":32391752,"avatar_url":"https://avatars2.githubusercontent.com/u/32391752?v=4","gravatar_id":"","url":"https://api.github.com/users/81Denton","html_url":"https://github.com/81Denton","followers_url":"https://api.github.com/users/81Denton/followers","following_url":"https://api.github.com/users/81Denton/following{/other_user}","gists_url":"https://api.github.com/users/81Denton/gists{/gist_id}","starred_url":"https://api.github.com/users/81Denton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/81Denton/subscriptions","organizations_url":"https://api.github.com/users/81Denton/orgs","repos_url":"https://api.github.com/users/81Denton/repos","events_url":"https://api.github.com/users/81Denton/events{/privacy}","received_events_url":"https://api.github.com/users/81Denton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/81Denton/tgstation","description":"the smoothbrained branch of SS13","fork":true,"url":"https://api.github.com/repos/81Denton/tgstation","forks_url":"https://api.github.com/repos/81Denton/tgstation/forks","keys_url":"https://api.github.com/repos/81Denton/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/81Denton/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/81Denton/tgstation/teams","hooks_url":"https://api.github.com/repos/81Denton/tgstation/hooks","issue_events_url":"https://api.github.com/repos/81Denton/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/81Denton/tgstation/events","assignees_url":"https://api.github.com/repos/81Denton/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/81Denton/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/81Denton/tgstation/tags","blobs_url":"https://api.github.com/repos/81Denton/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/81Denton/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/81Denton/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/81Denton/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/81Denton/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/81Denton/tgstation/languages","stargazers_url":"https://api.github.com/repos/81Denton/tgstation/stargazers","contributors_url":"https://api.github.com/repos/81Denton/tgstation/contributors","subscribers_url":"https://api.github.com/repos/81Denton/tgstation/subscribers","subscription_url":"https://api.github.com/repos/81Denton/tgstation/subscription","commits_url":"https://api.github.com/repos/81Denton/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/81Denton/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/81Denton/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/81Denton/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/81Denton/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/81Denton/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/81Denton/tgstation/merges","archive_url":"https://api.github.com/repos/81Denton/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/81Denton/tgstation/downloads","issues_url":"https://api.github.com/repos/81Denton/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/81Denton/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/81Denton/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/81Denton/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/81Denton/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/81Denton/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/81Denton/tgstation/deployments","created_at":"2018-01-28T10:59:54Z","updated_at":"2018-03-16T21:03:41Z","pushed_at":"2018-03-16T22:10:21Z","git_url":"git://github.com/81Denton/tgstation.git","ssh_url":"git@github.com:81Denton/tgstation.git","clone_url":"https://github.com/81Denton/tgstation.git","svn_url":"https://github.com/81Denton/tgstation","homepage":"http://www.tgstation13.org/","size":1095280,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"denton-master"}},"base":{"label":"tgstation:master","ref":"master","sha":"7d84dd9f3ca51b5c4c3e29b396efd734243bd3d0","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars2.githubusercontent.com/u/1363778?v=4","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2018-03-17T06:11:14Z","pushed_at":"2018-03-17T06:10:56Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"https://www.tgstation13.org/","size":1095094,"stargazers_count":481,"watchers_count":481,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1724,"mirror_url":null,"archived":false,"open_issues_count":1195,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1724,"open_issues":1195,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/36468"},"html":{"href":"https://github.com/tgstation/tgstation/pull/36468"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/36468"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/36468/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/36468/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/36468/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/2790073810d96560d616f9f762887a1a01440760"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3234987,
"name": "tgstation/tgstation",
"url": "https://api.github.com/repos/tgstation/tgstation"
} | {
"id": 6209658,
"login": "ShizCalev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6209658?",
"url": "https://api.github.com/users/ShizCalev"
} | {
"id": 1363778,
"login": "tgstation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1363778?",
"url": "https://api.github.com/orgs/tgstation"
} | 2018-03-17T06:29:35 | 7394117862 | {"actor":{"display_login":"ShizCalev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/comments/207022050","pull_request_review_id":142551576,"id":207022050,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAyMjA1MA==","diff_hunk":"@@ -0,0 +1,493 @@\n+From 9a1c544d542fcc7d3986b9eaf59bc27aeeb314df Mon Sep 17 00:00:00 2001\n+From: Justin <jrd2558@gmail.com>\n+Date: Wed, 1 Aug 2018 00:25:20 -0700\n+Subject: [PATCH] Add try with resource support\n+\n+\n+diff --git a/src/org/jetbrains/java/decompiler/main/rels/MethodProcessorRunnable.java b/src/org/jetbrains/java/decompiler/main/rels/MethodProcessorRunnable.java\n+index 8ac1d92..7212a0a 100644\n+--- a/src/org/jetbrains/java/decompiler/main/rels/MethodProcessorRunnable.java\n++++ b/src/org/jetbrains/java/decompiler/main/rels/MethodProcessorRunnable.java\n+@@ -169,6 +169,10 @@ public class MethodProcessorRunnable implements Runnable {\n+ \n+ LabelHelper.identifyLabels(root);\n+ \n++ if (TryHelper.enhanceTryStats(root)) {\n++ continue;\n++ }\n++\n+ if (InlineSingleBlockHelper.inlineSingleBlocks(root)) {\n+ continue;\n+ }\n+diff --git a/src/org/jetbrains/java/decompiler/modules/decompiler/TryHelper.java b/src/org/jetbrains/java/decompiler/modules/decompiler/TryHelper.java\n+new file mode 100644\n+index 0000000..76ae1aa\n+--- /dev/null\n++++ b/src/org/jetbrains/java/decompiler/modules/decompiler/TryHelper.java\n+@@ -0,0 +1,264 @@\n++package org.jetbrains.java.decompiler.modules.decompiler;\n++\n++import org.jetbrains.java.decompiler.main.DecompilerContext;\n++import org.jetbrains.java.decompiler.modules.decompiler.exps.AssignmentExprent;\n++import org.jetbrains.java.decompiler.modules.decompiler.exps.ExitExprent;\n++import org.jetbrains.java.decompiler.modules.decompiler.exps.Exprent;\n++import org.jetbrains.java.decompiler.modules.decompiler.exps.InvocationExprent;\n++import org.jetbrains.java.decompiler.modules.decompiler.exps.VarExprent;\n++import org.jetbrains.java.decompiler.modules.decompiler.stats.BasicBlockStatement;\n++import org.jetbrains.java.decompiler.modules.decompiler.stats.CatchAllStatement;\n++import org.jetbrains.java.decompiler.modules.decompiler.stats.CatchStatement;\n++import org.jetbrains.java.decompiler.modules.decompiler.stats.RootStatement;\n++import org.jetbrains.java.decompiler.modules.decompiler.stats.Statement;\n++import org.jetbrains.java.decompiler.struct.gen.VarType;\n++import java.util.ArrayList;\n++import java.util.List;\n++\n++public class TryHelper\n++{\n++ private static final String[] CLOSABLES = {","path":"FernFlower-Patches/0024-Add-try-with-resource-support.patch","position":47,"original_position":47,"commit_id":"a81a2166e8ca43c64d97b4bdca62a351324b2f57","original_commit_id":"a81a2166e8ca43c64d97b4bdca62a351324b2f57","user":{"login":"bs2609","id":1447117,"node_id":"MDQ6VXNlcjE0NDcxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"body":"Does this need a list or can it work like #4 and check for `AutoCloseable` instances?","created_at":"2018-08-01T20:33:56Z","updated_at":"2018-08-01T20:33:57Z","html_url":"https://github.com/MinecraftForge/ForgeFlower/pull/21#discussion_r207022050","pull_request_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/comments/207022050"},"html":{"href":"https://github.com/MinecraftForge/ForgeFlower/pull/21#discussion_r207022050"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21"}},"in_reply_to_id":207011675},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21","id":205335322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzM1MzIy","html_url":"https://github.com/MinecraftForge/ForgeFlower/pull/21","diff_url":"https://github.com/MinecraftForge/ForgeFlower/pull/21.diff","patch_url":"https://github.com/MinecraftForge/ForgeFlower/pull/21.patch","issue_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/21","number":21,"state":"open","locked":false,"title":"Add try with resource support","user":{"login":"JDLogic","id":6103327,"node_id":"MDQ6VXNlcjYxMDMzMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6103327?v=4","gravatar_id":"","url":"https://api.github.com/users/JDLogic","html_url":"https://github.com/JDLogic","followers_url":"https://api.github.com/users/JDLogic/followers","following_url":"https://api.github.com/users/JDLogic/following{/other_user}","gists_url":"https://api.github.com/users/JDLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/JDLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDLogic/subscriptions","organizations_url":"https://api.github.com/users/JDLogic/orgs","repos_url":"https://api.github.com/users/JDLogic/repos","events_url":"https://api.github.com/users/JDLogic/events{/privacy}","received_events_url":"https://api.github.com/users/JDLogic/received_events","type":"User","site_admin":false},"body":"Attempt at resolving #17. This should not introduce any errors as far I can tell.\r\n[Resulting MC Diff](https://gist.github.com/JDLogic/0ef03494be8fb30d96242c08271356bc)","created_at":"2018-08-01T07:41:42Z","updated_at":"2018-08-01T20:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"015e34a83078ad06ea3550e9c2cac44a394cece2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/21/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/statuses/a81a2166e8ca43c64d97b4bdca62a351324b2f57","head":{"label":"JDLogic:add-twr","ref":"add-twr","sha":"a81a2166e8ca43c64d97b4bdca62a351324b2f57","user":{"login":"JDLogic","id":6103327,"node_id":"MDQ6VXNlcjYxMDMzMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6103327?v=4","gravatar_id":"","url":"https://api.github.com/users/JDLogic","html_url":"https://github.com/JDLogic","followers_url":"https://api.github.com/users/JDLogic/followers","following_url":"https://api.github.com/users/JDLogic/following{/other_user}","gists_url":"https://api.github.com/users/JDLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/JDLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDLogic/subscriptions","organizations_url":"https://api.github.com/users/JDLogic/orgs","repos_url":"https://api.github.com/users/JDLogic/repos","events_url":"https://api.github.com/users/JDLogic/events{/privacy}","received_events_url":"https://api.github.com/users/JDLogic/received_events","type":"User","site_admin":false},"repo":{"id":142386065,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzODYwNjU=","name":"ForgeFlower","full_name":"JDLogic/ForgeFlower","owner":{"login":"JDLogic","id":6103327,"node_id":"MDQ6VXNlcjYxMDMzMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6103327?v=4","gravatar_id":"","url":"https://api.github.com/users/JDLogic","html_url":"https://github.com/JDLogic","followers_url":"https://api.github.com/users/JDLogic/followers","following_url":"https://api.github.com/users/JDLogic/following{/other_user}","gists_url":"https://api.github.com/users/JDLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/JDLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDLogic/subscriptions","organizations_url":"https://api.github.com/users/JDLogic/orgs","repos_url":"https://api.github.com/users/JDLogic/repos","events_url":"https://api.github.com/users/JDLogic/events{/privacy}","received_events_url":"https://api.github.com/users/JDLogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JDLogic/ForgeFlower","description":"Forge's modifications to FernFlower. Fixing various bugs/inconsistencies. Main Repo: https://github.com/MinecraftForge/FernFlower","fork":true,"url":"https://api.github.com/repos/JDLogic/ForgeFlower","forks_url":"https://api.github.com/repos/JDLogic/ForgeFlower/forks","keys_url":"https://api.github.com/repos/JDLogic/ForgeFlower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDLogic/ForgeFlower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDLogic/ForgeFlower/teams","hooks_url":"https://api.github.com/repos/JDLogic/ForgeFlower/hooks","issue_events_url":"https://api.github.com/repos/JDLogic/ForgeFlower/issues/events{/number}","events_url":"https://api.github.com/repos/JDLogic/ForgeFlower/events","assignees_url":"https://api.github.com/repos/JDLogic/ForgeFlower/assignees{/user}","branches_url":"https://api.github.com/repos/JDLogic/ForgeFlower/branches{/branch}","tags_url":"https://api.github.com/repos/JDLogic/ForgeFlower/tags","blobs_url":"https://api.github.com/repos/JDLogic/ForgeFlower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDLogic/ForgeFlower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDLogic/ForgeFlower/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDLogic/ForgeFlower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDLogic/ForgeFlower/statuses/{sha}","languages_url":"https://api.github.com/repos/JDLogic/ForgeFlower/languages","stargazers_url":"https://api.github.com/repos/JDLogic/ForgeFlower/stargazers","contributors_url":"https://api.github.com/repos/JDLogic/ForgeFlower/contributors","subscribers_url":"https://api.github.com/repos/JDLogic/ForgeFlower/subscribers","subscription_url":"https://api.github.com/repos/JDLogic/ForgeFlower/subscription","commits_url":"https://api.github.com/repos/JDLogic/ForgeFlower/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDLogic/ForgeFlower/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDLogic/ForgeFlower/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDLogic/ForgeFlower/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDLogic/ForgeFlower/contents/{+path}","compare_url":"https://api.github.com/repos/JDLogic/ForgeFlower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDLogic/ForgeFlower/merges","archive_url":"https://api.github.com/repos/JDLogic/ForgeFlower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDLogic/ForgeFlower/downloads","issues_url":"https://api.github.com/repos/JDLogic/ForgeFlower/issues{/number}","pulls_url":"https://api.github.com/repos/JDLogic/ForgeFlower/pulls{/number}","milestones_url":"https://api.github.com/repos/JDLogic/ForgeFlower/milestones{/number}","notifications_url":"https://api.github.com/repos/JDLogic/ForgeFlower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDLogic/ForgeFlower/labels{/name}","releases_url":"https://api.github.com/repos/JDLogic/ForgeFlower/releases{/id}","deployments_url":"https://api.github.com/repos/JDLogic/ForgeFlower/deployments","created_at":"2018-07-26T03:53:21Z","updated_at":"2018-07-26T03:53:23Z","pushed_at":"2018-08-01T07:31:04Z","git_url":"git://github.com/JDLogic/ForgeFlower.git","ssh_url":"git@github.com:JDLogic/ForgeFlower.git","clone_url":"https://github.com/JDLogic/ForgeFlower.git","svn_url":"https://github.com/JDLogic/ForgeFlower","homepage":null,"size":434,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"e6d1cc3746737dc7922497fa3f018923f1c70a3e","user":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":87991423,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzk5MTQyMw==","name":"ForgeFlower","full_name":"MinecraftForge/ForgeFlower","owner":{"login":"MinecraftForge","id":1390178,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTAxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/ForgeFlower","description":"Forge's modifications to FernFlower. Fixing various bugs/inconsistencies. Main Repo: https://github.com/MinecraftForge/FernFlower","fork":false,"url":"https://api.github.com/repos/MinecraftForge/ForgeFlower","forks_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/forks","keys_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/events","assignees_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/merges","archive_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/ForgeFlower/deployments","created_at":"2017-04-12T00:25:49Z","updated_at":"2018-07-30T07:29:29Z","pushed_at":"2018-08-01T07:41:43Z","git_url":"git://github.com/MinecraftForge/ForgeFlower.git","ssh_url":"git@github.com:MinecraftForge/ForgeFlower.git","clone_url":"https://github.com/MinecraftForge/ForgeFlower.git","svn_url":"https://github.com/MinecraftForge/ForgeFlower","homepage":null,"size":432,"stargazers_count":21,"watchers_count":21,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":8,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21"},"html":{"href":"https://github.com/MinecraftForge/ForgeFlower/pull/21"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/21"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/ForgeFlower/statuses/a81a2166e8ca43c64d97b4bdca62a351324b2f57"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87991423,
"name": "MinecraftForge/ForgeFlower",
"url": "https://api.github.com/repos/MinecraftForge/ForgeFlower"
} | {
"id": 1447117,
"login": "bs2609",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1447117?",
"url": "https://api.github.com/users/bs2609"
} | {
"id": 1390178,
"login": "MinecraftForge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1390178?",
"url": "https://api.github.com/orgs/MinecraftForge"
} | 2018-08-01T20:33:56 | 8052813899 | {"actor":{"display_login":"bs2609"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/datatable/pulls/comments/222452012","pull_request_review_id":161341959,"id":222452012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ1MjAxMg==","diff_hunk":"@@ -0,0 +1,569 @@\n+//------------------------------------------------------------------------------\n+// Copyright 2018 H2O.ai\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+//------------------------------------------------------------------------------\n+#include \"frame/py_frame.h\"\n+#include <type_traits>\n+#include <unordered_set>\n+#include \"python/dict.h\"\n+#include \"python/list.h\"\n+#include \"utils/assert.h\"\n+#include \"utils/progress.h\"\n+\n+namespace py {\n+\n+\n+PKArgs Frame::Type::args_replace(\n+ 2, 0, 0, false, false,\n+ {\"to_replace\", \"replace_with\"},\n+ \"replace\",\n+R\"(replace(self, replace_what, replace_with)\n+--\n+\n+Replace given value(s) `replace_what` with `replace_with` in the entire Frame.\n+\n+For each replace value, this method operates only on columns of types\n+appropriate for that value. For example, if `replace_what` is a list\n+`[-1, math.inf, None, \"??\"]`, then the value `-1` will be replaced in integer\n+columns only, `math.inf` only in real columns, `None` in columns of all types,\n+and finally `\"??\"` only in string columns.","path":"c/frame/replace.cc","position":40,"original_position":40,"commit_id":"25c11e6bb0393bbbbb669de912a6a61cb02ee603","original_commit_id":"25c11e6bb0393bbbbb669de912a6a61cb02ee603","user":{"login":"oleksiyskononenko","id":35204136,"node_id":"MDQ6VXNlcjM1MjA0MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/35204136?v=4","gravatar_id":"","url":"https://api.github.com/users/oleksiyskononenko","html_url":"https://github.com/oleksiyskononenko","followers_url":"https://api.github.com/users/oleksiyskononenko/followers","following_url":"https://api.github.com/users/oleksiyskononenko/following{/other_user}","gists_url":"https://api.github.com/users/oleksiyskononenko/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksiyskononenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksiyskononenko/subscriptions","organizations_url":"https://api.github.com/users/oleksiyskononenko/orgs","repos_url":"https://api.github.com/users/oleksiyskononenko/repos","events_url":"https://api.github.com/users/oleksiyskononenko/events{/privacy}","received_events_url":"https://api.github.com/users/oleksiyskononenko/received_events","type":"User","site_admin":false},"body":"I agree, also don't like an idea to change the column type during replacement as this seems to be completely separate functionality. ","created_at":"2018-10-03T20:14:58Z","updated_at":"2018-10-03T20:14:58Z","html_url":"https://github.com/h2oai/datatable/pull/1319#discussion_r222452012","pull_request_url":"https://api.github.com/repos/h2oai/datatable/pulls/1319","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/comments/222452012"},"html":{"href":"https://github.com/h2oai/datatable/pull/1319#discussion_r222452012"},"pull_request":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1319"}},"in_reply_to_id":222153609},"pull_request":{"url":"https://api.github.com/repos/h2oai/datatable/pulls/1319","id":219237319,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjM3MzE5","html_url":"https://github.com/h2oai/datatable/pull/1319","diff_url":"https://github.com/h2oai/datatable/pull/1319.diff","patch_url":"https://github.com/h2oai/datatable/pull/1319.patch","issue_url":"https://api.github.com/repos/h2oai/datatable/issues/1319","number":1319,"state":"closed","locked":false,"title":"Frame.replace() method","user":{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false},"body":"Implement `.replace()` method for a Frame. This currently works with int or float columns only; handling of bool and str columns will be done later (this PR is already too big).\r\n\r\nAdditional changes:\r\n* `Args` object now knows both the function name and its doc-string from the moment of construction (this allows to declare a method's signature much easier);\r\n* Error messages now say `\"Frame() constructor\"` instead of `\"Frame.__init__()\"`;\r\n* Start working on \"progress\" functionality -- a more unified way to run code in parallel. The reason to have this unified is to be able to eventually add the progress-bar functionality for all long-running tasks;\r\n\r\nCloses #1302 ","created_at":"2018-10-01T00:26:16Z","updated_at":"2018-10-03T20:14:58Z","closed_at":"2018-10-01T01:07:27Z","merged_at":"2018-10-01T01:07:27Z","merge_commit_sha":"db9e2277c95dba020799cd6ed8414f4e62a8df1b","assignee":{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false},"assignees":[{"login":"st-pasha","id":4231472,"node_id":"MDQ6VXNlcjQyMzE0NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4231472?v=4","gravatar_id":"","url":"https://api.github.com/users/st-pasha","html_url":"https://github.com/st-pasha","followers_url":"https://api.github.com/users/st-pasha/followers","following_url":"https://api.github.com/users/st-pasha/following{/other_user}","gists_url":"https://api.github.com/users/st-pasha/gists{/gist_id}","starred_url":"https://api.github.com/users/st-pasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-pasha/subscriptions","organizations_url":"https://api.github.com/users/st-pasha/orgs","repos_url":"https://api.github.com/users/st-pasha/repos","events_url":"https://api.github.com/users/st-pasha/events{/privacy}","received_events_url":"https://api.github.com/users/st-pasha/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pseudotensor","id":2249614,"node_id":"MDQ6VXNlcjIyNDk2MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2249614?v=4","gravatar_id":"","url":"https://api.github.com/users/pseudotensor","html_url":"https://github.com/pseudotensor","followers_url":"https://api.github.com/users/pseudotensor/followers","following_url":"https://api.github.com/users/pseudotensor/following{/other_user}","gists_url":"https://api.github.com/users/pseudotensor/gists{/gist_id}","starred_url":"https://api.github.com/users/pseudotensor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pseudotensor/subscriptions","organizations_url":"https://api.github.com/users/pseudotensor/orgs","repos_url":"https://api.github.com/users/pseudotensor/repos","events_url":"https://api.github.com/users/pseudotensor/events{/privacy}","received_events_url":"https://api.github.com/users/pseudotensor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/datatable/pulls/1319/commits","review_comments_url":"https://api.github.com/repos/h2oai/datatable/pulls/1319/comments","review_comment_url":"https://api.github.com/repos/h2oai/datatable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/datatable/issues/1319/comments","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/25c11e6bb0393bbbbb669de912a6a61cb02ee603","head":{"label":"h2oai:replace","ref":"replace","sha":"25c11e6bb0393bbbbb669de912a6a61cb02ee603","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":83748372,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzc0ODM3Mg==","name":"datatable","full_name":"h2oai/datatable","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/datatable","description":"data.table for Python","fork":false,"url":"https://api.github.com/repos/h2oai/datatable","forks_url":"https://api.github.com/repos/h2oai/datatable/forks","keys_url":"https://api.github.com/repos/h2oai/datatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/datatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/datatable/teams","hooks_url":"https://api.github.com/repos/h2oai/datatable/hooks","issue_events_url":"https://api.github.com/repos/h2oai/datatable/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/datatable/events","assignees_url":"https://api.github.com/repos/h2oai/datatable/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/datatable/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/datatable/tags","blobs_url":"https://api.github.com/repos/h2oai/datatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/datatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/datatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/datatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/datatable/languages","stargazers_url":"https://api.github.com/repos/h2oai/datatable/stargazers","contributors_url":"https://api.github.com/repos/h2oai/datatable/contributors","subscribers_url":"https://api.github.com/repos/h2oai/datatable/subscribers","subscription_url":"https://api.github.com/repos/h2oai/datatable/subscription","commits_url":"https://api.github.com/repos/h2oai/datatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/datatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/datatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/datatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/datatable/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/datatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/datatable/merges","archive_url":"https://api.github.com/repos/h2oai/datatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/datatable/downloads","issues_url":"https://api.github.com/repos/h2oai/datatable/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/datatable/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/datatable/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/datatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/datatable/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/datatable/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/datatable/deployments","created_at":"2017-03-03T02:32:59Z","updated_at":"2018-10-02T22:30:24Z","pushed_at":"2018-10-02T23:06:51Z","git_url":"git://github.com/h2oai/datatable.git","ssh_url":"git@github.com:h2oai/datatable.git","clone_url":"https://github.com/h2oai/datatable.git","svn_url":"https://github.com/h2oai/datatable","homepage":null,"size":4297,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":12,"open_issues":67,"watchers":187,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"3b77876e11c11aaff3aca8739cc815dc294ebba4","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":83748372,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzc0ODM3Mg==","name":"datatable","full_name":"h2oai/datatable","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/datatable","description":"data.table for Python","fork":false,"url":"https://api.github.com/repos/h2oai/datatable","forks_url":"https://api.github.com/repos/h2oai/datatable/forks","keys_url":"https://api.github.com/repos/h2oai/datatable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/datatable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/datatable/teams","hooks_url":"https://api.github.com/repos/h2oai/datatable/hooks","issue_events_url":"https://api.github.com/repos/h2oai/datatable/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/datatable/events","assignees_url":"https://api.github.com/repos/h2oai/datatable/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/datatable/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/datatable/tags","blobs_url":"https://api.github.com/repos/h2oai/datatable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/datatable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/datatable/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/datatable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/datatable/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/datatable/languages","stargazers_url":"https://api.github.com/repos/h2oai/datatable/stargazers","contributors_url":"https://api.github.com/repos/h2oai/datatable/contributors","subscribers_url":"https://api.github.com/repos/h2oai/datatable/subscribers","subscription_url":"https://api.github.com/repos/h2oai/datatable/subscription","commits_url":"https://api.github.com/repos/h2oai/datatable/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/datatable/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/datatable/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/datatable/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/datatable/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/datatable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/datatable/merges","archive_url":"https://api.github.com/repos/h2oai/datatable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/datatable/downloads","issues_url":"https://api.github.com/repos/h2oai/datatable/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/datatable/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/datatable/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/datatable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/datatable/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/datatable/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/datatable/deployments","created_at":"2017-03-03T02:32:59Z","updated_at":"2018-10-02T22:30:24Z","pushed_at":"2018-10-02T23:06:51Z","git_url":"git://github.com/h2oai/datatable.git","ssh_url":"git@github.com:h2oai/datatable.git","clone_url":"https://github.com/h2oai/datatable.git","svn_url":"https://github.com/h2oai/datatable","homepage":null,"size":4297,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":12,"open_issues":67,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1319"},"html":{"href":"https://github.com/h2oai/datatable/pull/1319"},"issue":{"href":"https://api.github.com/repos/h2oai/datatable/issues/1319"},"comments":{"href":"https://api.github.com/repos/h2oai/datatable/issues/1319/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1319/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/datatable/pulls/1319/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/datatable/statuses/25c11e6bb0393bbbbb669de912a6a61cb02ee603"}},"author_association":"MEMBER"}} | {
"id": 83748372,
"name": "h2oai/datatable",
"url": "https://api.github.com/repos/h2oai/datatable"
} | {
"id": 35204136,
"login": "oleksiyskononenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35204136?",
"url": "https://api.github.com/users/oleksiyskononenko"
} | {
"id": 1402695,
"login": "h2oai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1402695?",
"url": "https://api.github.com/orgs/h2oai"
} | 2018-10-03T20:14:58 | 8363613732 | {"actor":{"display_login":"oleksiyskononenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/comments/241844161","pull_request_review_id":185225974,"id":241844161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTg0NDE2MQ==","diff_hunk":"@@ -121,13 +121,15 @@ export default class AccordionItem extends Component {\n {...other}>\n <Expando\n type=\"button\"\n+ aria-expanded={this.state.open}\n className={`${prefix}--accordion__heading`}\n- role=\"tab\"\n onClick={this.handleHeadingClick}>\n <Icon\n className={`${prefix}--accordion__arrow`}\n icon={iconChevronRight}\n description={iconDescription}\n+ role={null} // eslint-disable-line jsx-a11y/aria-role","path":"src/components/AccordionItem/AccordionItem.js","position":12,"original_position":12,"commit_id":"52b5adbfa20d81aa9e290e70efa920e18e88fc73","original_commit_id":"52b5adbfa20d81aa9e290e70efa920e18e88fc73","user":{"login":"emyarod","id":8265238,"node_id":"MDQ6VXNlcjgyNjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/8265238?v=4","gravatar_id":"","url":"https://api.github.com/users/emyarod","html_url":"https://github.com/emyarod","followers_url":"https://api.github.com/users/emyarod/followers","following_url":"https://api.github.com/users/emyarod/following{/other_user}","gists_url":"https://api.github.com/users/emyarod/gists{/gist_id}","starred_url":"https://api.github.com/users/emyarod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyarod/subscriptions","organizations_url":"https://api.github.com/users/emyarod/orgs","repos_url":"https://api.github.com/users/emyarod/repos","events_url":"https://api.github.com/users/emyarod/events{/privacy}","received_events_url":"https://api.github.com/users/emyarod/received_events","type":"User","site_admin":false},"body":"yup it's because we don't need `role` that it is being set to `null` here, since `Icon` will assign it a default value","created_at":"2018-12-14T18:15:55Z","updated_at":"2018-12-14T18:15:55Z","html_url":"https://github.com/IBM/carbon-components-react/pull/1657#discussion_r241844161","pull_request_url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/comments/241844161"},"html":{"href":"https://github.com/IBM/carbon-components-react/pull/1657#discussion_r241844161"},"pull_request":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657"}},"in_reply_to_id":241840166},"pull_request":{"url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657","id":238537842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTM3ODQy","html_url":"https://github.com/IBM/carbon-components-react/pull/1657","diff_url":"https://github.com/IBM/carbon-components-react/pull/1657.diff","patch_url":"https://github.com/IBM/carbon-components-react/pull/1657.patch","issue_url":"https://api.github.com/repos/IBM/carbon-components-react/issues/1657","number":1657,"state":"open","locked":false,"title":"fix(AccordionItem): add aria-expanded and use tab role","user":{"login":"emyarod","id":8265238,"node_id":"MDQ6VXNlcjgyNjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/8265238?v=4","gravatar_id":"","url":"https://api.github.com/users/emyarod","html_url":"https://github.com/emyarod","followers_url":"https://api.github.com/users/emyarod/followers","following_url":"https://api.github.com/users/emyarod/following{/other_user}","gists_url":"https://api.github.com/users/emyarod/gists{/gist_id}","starred_url":"https://api.github.com/users/emyarod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyarod/subscriptions","organizations_url":"https://api.github.com/users/emyarod/orgs","repos_url":"https://api.github.com/users/emyarod/repos","events_url":"https://api.github.com/users/emyarod/events{/privacy}","received_events_url":"https://api.github.com/users/emyarod/received_events","type":"User","site_admin":false},"body":"Closes IBM/carbon-components-react#1650\r\n\r\nThis PR uses a more appropriate `role` for `<AccordionItem>`s with respect to our current markup and includes the `aria-expanded` on the component. This change is meant to support screen readers but exposes a potential larger issue with the elements used to construct our `<Accordion>`s\r\n\r\n#### Changelog\r\n\r\n**Changed**\r\n\r\n- use `tab` role for `<AccordionItem>` to correspond with the `role` on `<Accordion>`\r\n- tie `aria-expanded` state to component open/closed state","created_at":"2018-12-13T21:27:37Z","updated_at":"2018-12-14T18:15:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c05f3f3e60dbbae0702583b8ed0c9d147d8a4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dakahn","id":40970507,"node_id":"MDQ6VXNlcjQwOTcwNTA3","avatar_url":"https://avatars3.githubusercontent.com/u/40970507?v=4","gravatar_id":"","url":"https://api.github.com/users/dakahn","html_url":"https://github.com/dakahn","followers_url":"https://api.github.com/users/dakahn/followers","following_url":"https://api.github.com/users/dakahn/following{/other_user}","gists_url":"https://api.github.com/users/dakahn/gists{/gist_id}","starred_url":"https://api.github.com/users/dakahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakahn/subscriptions","organizations_url":"https://api.github.com/users/dakahn/orgs","repos_url":"https://api.github.com/users/dakahn/repos","events_url":"https://api.github.com/users/dakahn/events{/privacy}","received_events_url":"https://api.github.com/users/dakahn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":625018029,"node_id":"MDU6TGFiZWw2MjUwMTgwMjk=","url":"https://api.github.com/repos/IBM/carbon-components-react/labels/status:%20one%20more%20review%20:eyes:","name":"status: one more review :eyes:","color":"0052cc","default":false},{"id":625018770,"node_id":"MDU6TGFiZWw2MjUwMTg3NzA=","url":"https://api.github.com/repos/IBM/carbon-components-react/labels/status:%20ready%20for%20review%20%20:eyes:","name":"status: ready for review :eyes:","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/IBM/carbon-components-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBM/carbon-components-react/issues/1657/comments","statuses_url":"https://api.github.com/repos/IBM/carbon-components-react/statuses/52b5adbfa20d81aa9e290e70efa920e18e88fc73","head":{"label":"emyarod:1650-aria-expanded-missing-from-accordion","ref":"1650-aria-expanded-missing-from-accordion","sha":"52b5adbfa20d81aa9e290e70efa920e18e88fc73","user":{"login":"emyarod","id":8265238,"node_id":"MDQ6VXNlcjgyNjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/8265238?v=4","gravatar_id":"","url":"https://api.github.com/users/emyarod","html_url":"https://github.com/emyarod","followers_url":"https://api.github.com/users/emyarod/followers","following_url":"https://api.github.com/users/emyarod/following{/other_user}","gists_url":"https://api.github.com/users/emyarod/gists{/gist_id}","starred_url":"https://api.github.com/users/emyarod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyarod/subscriptions","organizations_url":"https://api.github.com/users/emyarod/orgs","repos_url":"https://api.github.com/users/emyarod/repos","events_url":"https://api.github.com/users/emyarod/events{/privacy}","received_events_url":"https://api.github.com/users/emyarod/received_events","type":"User","site_admin":false},"repo":{"id":136348348,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNDgzNDg=","name":"carbon-components-react","full_name":"emyarod/carbon-components-react","private":false,"owner":{"login":"emyarod","id":8265238,"node_id":"MDQ6VXNlcjgyNjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/8265238?v=4","gravatar_id":"","url":"https://api.github.com/users/emyarod","html_url":"https://github.com/emyarod","followers_url":"https://api.github.com/users/emyarod/followers","following_url":"https://api.github.com/users/emyarod/following{/other_user}","gists_url":"https://api.github.com/users/emyarod/gists{/gist_id}","starred_url":"https://api.github.com/users/emyarod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyarod/subscriptions","organizations_url":"https://api.github.com/users/emyarod/orgs","repos_url":"https://api.github.com/users/emyarod/repos","events_url":"https://api.github.com/users/emyarod/events{/privacy}","received_events_url":"https://api.github.com/users/emyarod/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emyarod/carbon-components-react","description":"Carbon Components - in React!","fork":true,"url":"https://api.github.com/repos/emyarod/carbon-components-react","forks_url":"https://api.github.com/repos/emyarod/carbon-components-react/forks","keys_url":"https://api.github.com/repos/emyarod/carbon-components-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emyarod/carbon-components-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emyarod/carbon-components-react/teams","hooks_url":"https://api.github.com/repos/emyarod/carbon-components-react/hooks","issue_events_url":"https://api.github.com/repos/emyarod/carbon-components-react/issues/events{/number}","events_url":"https://api.github.com/repos/emyarod/carbon-components-react/events","assignees_url":"https://api.github.com/repos/emyarod/carbon-components-react/assignees{/user}","branches_url":"https://api.github.com/repos/emyarod/carbon-components-react/branches{/branch}","tags_url":"https://api.github.com/repos/emyarod/carbon-components-react/tags","blobs_url":"https://api.github.com/repos/emyarod/carbon-components-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emyarod/carbon-components-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emyarod/carbon-components-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/emyarod/carbon-components-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emyarod/carbon-components-react/statuses/{sha}","languages_url":"https://api.github.com/repos/emyarod/carbon-components-react/languages","stargazers_url":"https://api.github.com/repos/emyarod/carbon-components-react/stargazers","contributors_url":"https://api.github.com/repos/emyarod/carbon-components-react/contributors","subscribers_url":"https://api.github.com/repos/emyarod/carbon-components-react/subscribers","subscription_url":"https://api.github.com/repos/emyarod/carbon-components-react/subscription","commits_url":"https://api.github.com/repos/emyarod/carbon-components-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/emyarod/carbon-components-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/emyarod/carbon-components-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/emyarod/carbon-components-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/emyarod/carbon-components-react/contents/{+path}","compare_url":"https://api.github.com/repos/emyarod/carbon-components-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emyarod/carbon-components-react/merges","archive_url":"https://api.github.com/repos/emyarod/carbon-components-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emyarod/carbon-components-react/downloads","issues_url":"https://api.github.com/repos/emyarod/carbon-components-react/issues{/number}","pulls_url":"https://api.github.com/repos/emyarod/carbon-components-react/pulls{/number}","milestones_url":"https://api.github.com/repos/emyarod/carbon-components-react/milestones{/number}","notifications_url":"https://api.github.com/repos/emyarod/carbon-components-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emyarod/carbon-components-react/labels{/name}","releases_url":"https://api.github.com/repos/emyarod/carbon-components-react/releases{/id}","deployments_url":"https://api.github.com/repos/emyarod/carbon-components-react/deployments","created_at":"2018-06-06T15:25:56Z","updated_at":"2018-12-13T16:53:36Z","pushed_at":"2018-12-14T16:53:03Z","git_url":"git://github.com/emyarod/carbon-components-react.git","ssh_url":"git@github.com:emyarod/carbon-components-react.git","clone_url":"https://github.com/emyarod/carbon-components-react.git","svn_url":"https://github.com/emyarod/carbon-components-react","homepage":"http://react.carbondesignsystem.com","size":122867,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IBM:master","ref":"master","sha":"9ef4bdb35395601ff21adae8c89659c4dfa8a7db","user":{"login":"IBM","id":1459110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1459110?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM","html_url":"https://github.com/IBM","followers_url":"https://api.github.com/users/IBM/followers","following_url":"https://api.github.com/users/IBM/following{/other_user}","gists_url":"https://api.github.com/users/IBM/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM/subscriptions","organizations_url":"https://api.github.com/users/IBM/orgs","repos_url":"https://api.github.com/users/IBM/repos","events_url":"https://api.github.com/users/IBM/events{/privacy}","received_events_url":"https://api.github.com/users/IBM/received_events","type":"Organization","site_admin":false},"repo":{"id":92527058,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUyNzA1OA==","name":"carbon-components-react","full_name":"IBM/carbon-components-react","private":false,"owner":{"login":"IBM","id":1459110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTkxMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1459110?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM","html_url":"https://github.com/IBM","followers_url":"https://api.github.com/users/IBM/followers","following_url":"https://api.github.com/users/IBM/following{/other_user}","gists_url":"https://api.github.com/users/IBM/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM/subscriptions","organizations_url":"https://api.github.com/users/IBM/orgs","repos_url":"https://api.github.com/users/IBM/repos","events_url":"https://api.github.com/users/IBM/events{/privacy}","received_events_url":"https://api.github.com/users/IBM/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IBM/carbon-components-react","description":"React components for the Carbon Design System","fork":false,"url":"https://api.github.com/repos/IBM/carbon-components-react","forks_url":"https://api.github.com/repos/IBM/carbon-components-react/forks","keys_url":"https://api.github.com/repos/IBM/carbon-components-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM/carbon-components-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM/carbon-components-react/teams","hooks_url":"https://api.github.com/repos/IBM/carbon-components-react/hooks","issue_events_url":"https://api.github.com/repos/IBM/carbon-components-react/issues/events{/number}","events_url":"https://api.github.com/repos/IBM/carbon-components-react/events","assignees_url":"https://api.github.com/repos/IBM/carbon-components-react/assignees{/user}","branches_url":"https://api.github.com/repos/IBM/carbon-components-react/branches{/branch}","tags_url":"https://api.github.com/repos/IBM/carbon-components-react/tags","blobs_url":"https://api.github.com/repos/IBM/carbon-components-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM/carbon-components-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM/carbon-components-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM/carbon-components-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM/carbon-components-react/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM/carbon-components-react/languages","stargazers_url":"https://api.github.com/repos/IBM/carbon-components-react/stargazers","contributors_url":"https://api.github.com/repos/IBM/carbon-components-react/contributors","subscribers_url":"https://api.github.com/repos/IBM/carbon-components-react/subscribers","subscription_url":"https://api.github.com/repos/IBM/carbon-components-react/subscription","commits_url":"https://api.github.com/repos/IBM/carbon-components-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM/carbon-components-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM/carbon-components-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM/carbon-components-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM/carbon-components-react/contents/{+path}","compare_url":"https://api.github.com/repos/IBM/carbon-components-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM/carbon-components-react/merges","archive_url":"https://api.github.com/repos/IBM/carbon-components-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM/carbon-components-react/downloads","issues_url":"https://api.github.com/repos/IBM/carbon-components-react/issues{/number}","pulls_url":"https://api.github.com/repos/IBM/carbon-components-react/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM/carbon-components-react/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM/carbon-components-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM/carbon-components-react/labels{/name}","releases_url":"https://api.github.com/repos/IBM/carbon-components-react/releases{/id}","deployments_url":"https://api.github.com/repos/IBM/carbon-components-react/deployments","created_at":"2017-05-26T16:01:37Z","updated_at":"2018-12-14T17:10:42Z","pushed_at":"2018-12-14T17:50:17Z","git_url":"git://github.com/IBM/carbon-components-react.git","ssh_url":"git@github.com:IBM/carbon-components-react.git","clone_url":"https://github.com/IBM/carbon-components-react.git","svn_url":"https://github.com/IBM/carbon-components-react","homepage":"http://react.carbondesignsystem.com","size":122550,"stargazers_count":611,"watchers_count":611,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":284,"open_issues":168,"watchers":611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657"},"html":{"href":"https://github.com/IBM/carbon-components-react/pull/1657"},"issue":{"href":"https://api.github.com/repos/IBM/carbon-components-react/issues/1657"},"comments":{"href":"https://api.github.com/repos/IBM/carbon-components-react/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBM/carbon-components-react/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/IBM/carbon-components-react/statuses/52b5adbfa20d81aa9e290e70efa920e18e88fc73"}},"author_association":"MEMBER"}} | {
"id": 92527058,
"name": "IBM/carbon-components-react",
"url": "https://api.github.com/repos/IBM/carbon-components-react"
} | {
"id": 8265238,
"login": "emyarod",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8265238?",
"url": "https://api.github.com/users/emyarod"
} | {
"id": 1459110,
"login": "IBM",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1459110?",
"url": "https://api.github.com/orgs/IBM"
} | 2018-12-14T18:15:55 | 8756592980 | {"actor":{"display_login":"emyarod"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snowplow/snowplow/pulls/comments/240222141","pull_request_review_id":183198407,"id":240222141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDIyMjE0MQ==","diff_hunk":"@@ -157,6 +157,14 @@ def initialize(debug, staging, enrich, staging_stream_enrich, shred, es, archive\n csbe = config[:aws][:s3][:buckets][:enriched]\n csbs = config[:aws][:s3][:buckets][:shredded]\n \n+ # Clear HDFS if persistent jobflow has been found\n+ if found_persistent_jobflow\n+ submit_jobflow_step(get_rmr_step(ENRICH_STEP_INPUT, standard_assets_bucket, \"Empty Raw HDFS\"), use_persistent_jobflow)\n+ submit_jobflow_step(get_rmr_step(ENRICH_STEP_OUTPUT, standard_assets_bucket, \"Empty Enriched HDFS\"), use_persistent_jobflow)\n+ submit_jobflow_step(get_rmr_step(SHRED_STEP_OUTPUT, standard_assets_bucket, \"Empty Shredded HDFS\"), use_persistent_jobflow)","path":"3-enrich/emr-etl-runner/lib/snowplow-emr-etl-runner/emr_job.rb","position":63,"original_position":8,"commit_id":"d2bab7ce2f7fe2020a9b0d04f6cd82c3d0cd2e1e","original_commit_id":"d2bab7ce2f7fe2020a9b0d04f6cd82c3d0cd2e1e","user":{"login":"BenFradet","id":1737211,"node_id":"MDQ6VXNlcjE3MzcyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1737211?v=4","gravatar_id":"","url":"https://api.github.com/users/BenFradet","html_url":"https://github.com/BenFradet","followers_url":"https://api.github.com/users/BenFradet/followers","following_url":"https://api.github.com/users/BenFradet/following{/other_user}","gists_url":"https://api.github.com/users/BenFradet/gists{/gist_id}","starred_url":"https://api.github.com/users/BenFradet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenFradet/subscriptions","organizations_url":"https://api.github.com/users/BenFradet/orgs","repos_url":"https://api.github.com/users/BenFradet/repos","events_url":"https://api.github.com/users/BenFradet/events{/privacy}","received_events_url":"https://api.github.com/users/BenFradet/received_events","type":"User","site_admin":false},"body":"could we combine those as one step?","created_at":"2018-12-10T14:08:30Z","updated_at":"2018-12-10T14:08:45Z","html_url":"https://github.com/snowplow/snowplow/pull/3933#discussion_r240222141","pull_request_url":"https://api.github.com/repos/snowplow/snowplow/pulls/3933","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/comments/240222141"},"html":{"href":"https://github.com/snowplow/snowplow/pull/3933#discussion_r240222141"},"pull_request":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/3933"}}},"pull_request":{"url":"https://api.github.com/repos/snowplow/snowplow/pulls/3933","id":233787201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzg3MjAx","html_url":"https://github.com/snowplow/snowplow/pull/3933","diff_url":"https://github.com/snowplow/snowplow/pull/3933.diff","patch_url":"https://github.com/snowplow/snowplow/pull/3933.patch","issue_url":"https://api.github.com/repos/snowplow/snowplow/issues/3933","number":3933,"state":"open","locked":false,"title":"Add persistent EMR Cluster for EER runs","user":{"login":"jbeemster","id":7984544,"node_id":"MDQ6VXNlcjc5ODQ1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7984544?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeemster","html_url":"https://github.com/jbeemster","followers_url":"https://api.github.com/users/jbeemster/followers","following_url":"https://api.github.com/users/jbeemster/following{/other_user}","gists_url":"https://api.github.com/users/jbeemster/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeemster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeemster/subscriptions","organizations_url":"https://api.github.com/users/jbeemster/orgs","repos_url":"https://api.github.com/users/jbeemster/repos","events_url":"https://api.github.com/users/jbeemster/events{/privacy}","received_events_url":"https://api.github.com/users/jbeemster/received_events","type":"User","site_admin":false},"body":"Hey @BenFradet so this branch can now successfully push steps to a persistent cluster. The logic is as follows:\r\n\r\n1. If the `--use-persistent-jobflow` argument is passed to `run` then it will attempt to discover a jobflow with the name specified in the config and return the jobflow_id to attach to\r\n - If no jobflow exists with this name that is in a RUNNING or WAITING state then it simply creates a new cluster\r\n - If a jobflow is found but it is in RUNNING state it fails as it is currently processing\r\n - If more than one jobflow is found in RUNNING or WAITING state it fails as the jobflow must be unique\r\n - If a unique jobflow is found in WAITING then the id is returned and we attach to it\r\n2. If a jobflow is found then all `application`, `configuration` and `bootstrap` actions are ignored as they cannot be applied to a running cluster\r\n3. If a persistent cluster should be used then all steps have their failure action changed to `cancel_and_wait`\r\n\r\nFor parsing the job steps I am filtering based on the run_tstamp so we only look at the job steps from this run rather than all job steps. From my experimentation the list_steps function in Elasticity returns the most recent 50 steps so we should not need to do any pagination for this.\r\n\r\nFor managing the cluster I am planning on adding a \"down\" function to be able to terminate it but equally can also just leave that manual management out...","created_at":"2018-11-27T05:44:53Z","updated_at":"2018-12-10T14:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3c51289e6bf6ae8fd09baf3a6ac3e53d61c18ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snowplow/snowplow/pulls/3933/commits","review_comments_url":"https://api.github.com/repos/snowplow/snowplow/pulls/3933/comments","review_comment_url":"https://api.github.com/repos/snowplow/snowplow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snowplow/snowplow/issues/3933/comments","statuses_url":"https://api.github.com/repos/snowplow/snowplow/statuses/d2bab7ce2f7fe2020a9b0d04f6cd82c3d0cd2e1e","head":{"label":"snowplow:feat/persistent-emr","ref":"feat/persistent-emr","sha":"d2bab7ce2f7fe2020a9b0d04f6cd82c3d0cd2e1e","user":{"login":"snowplow","id":1476001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzYwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"repo":{"id":3591964,"node_id":"MDEwOlJlcG9zaXRvcnkzNTkxOTY0","name":"snowplow","full_name":"snowplow/snowplow","private":false,"owner":{"login":"snowplow","id":1476001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzYwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snowplow/snowplow","description":"Cloud-native web, mobile and event analytics, running on AWS and GCP","fork":false,"url":"https://api.github.com/repos/snowplow/snowplow","forks_url":"https://api.github.com/repos/snowplow/snowplow/forks","keys_url":"https://api.github.com/repos/snowplow/snowplow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowplow/snowplow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowplow/snowplow/teams","hooks_url":"https://api.github.com/repos/snowplow/snowplow/hooks","issue_events_url":"https://api.github.com/repos/snowplow/snowplow/issues/events{/number}","events_url":"https://api.github.com/repos/snowplow/snowplow/events","assignees_url":"https://api.github.com/repos/snowplow/snowplow/assignees{/user}","branches_url":"https://api.github.com/repos/snowplow/snowplow/branches{/branch}","tags_url":"https://api.github.com/repos/snowplow/snowplow/tags","blobs_url":"https://api.github.com/repos/snowplow/snowplow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowplow/snowplow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowplow/snowplow/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowplow/snowplow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowplow/snowplow/statuses/{sha}","languages_url":"https://api.github.com/repos/snowplow/snowplow/languages","stargazers_url":"https://api.github.com/repos/snowplow/snowplow/stargazers","contributors_url":"https://api.github.com/repos/snowplow/snowplow/contributors","subscribers_url":"https://api.github.com/repos/snowplow/snowplow/subscribers","subscription_url":"https://api.github.com/repos/snowplow/snowplow/subscription","commits_url":"https://api.github.com/repos/snowplow/snowplow/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowplow/snowplow/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowplow/snowplow/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowplow/snowplow/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowplow/snowplow/contents/{+path}","compare_url":"https://api.github.com/repos/snowplow/snowplow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowplow/snowplow/merges","archive_url":"https://api.github.com/repos/snowplow/snowplow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowplow/snowplow/downloads","issues_url":"https://api.github.com/repos/snowplow/snowplow/issues{/number}","pulls_url":"https://api.github.com/repos/snowplow/snowplow/pulls{/number}","milestones_url":"https://api.github.com/repos/snowplow/snowplow/milestones{/number}","notifications_url":"https://api.github.com/repos/snowplow/snowplow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowplow/snowplow/labels{/name}","releases_url":"https://api.github.com/repos/snowplow/snowplow/releases{/id}","deployments_url":"https://api.github.com/repos/snowplow/snowplow/deployments","created_at":"2012-03-01T13:02:21Z","updated_at":"2018-12-10T09:58:56Z","pushed_at":"2018-12-10T06:41:39Z","git_url":"git://github.com/snowplow/snowplow.git","ssh_url":"git@github.com:snowplow/snowplow.git","clone_url":"https://github.com/snowplow/snowplow.git","svn_url":"https://github.com/snowplow/snowplow","homepage":"http://snowplowanalytics.com","size":23102,"stargazers_count":4445,"watchers_count":4445,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":947,"mirror_url":null,"archived":false,"open_issues_count":602,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":947,"open_issues":602,"watchers":4445,"default_branch":"master"}},"base":{"label":"snowplow:master","ref":"master","sha":"08d2f51b44148169427e5f423f7ea4dd489af9e5","user":{"login":"snowplow","id":1476001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzYwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"repo":{"id":3591964,"node_id":"MDEwOlJlcG9zaXRvcnkzNTkxOTY0","name":"snowplow","full_name":"snowplow/snowplow","private":false,"owner":{"login":"snowplow","id":1476001,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzYwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1476001?v=4","gravatar_id":"","url":"https://api.github.com/users/snowplow","html_url":"https://github.com/snowplow","followers_url":"https://api.github.com/users/snowplow/followers","following_url":"https://api.github.com/users/snowplow/following{/other_user}","gists_url":"https://api.github.com/users/snowplow/gists{/gist_id}","starred_url":"https://api.github.com/users/snowplow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowplow/subscriptions","organizations_url":"https://api.github.com/users/snowplow/orgs","repos_url":"https://api.github.com/users/snowplow/repos","events_url":"https://api.github.com/users/snowplow/events{/privacy}","received_events_url":"https://api.github.com/users/snowplow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snowplow/snowplow","description":"Cloud-native web, mobile and event analytics, running on AWS and GCP","fork":false,"url":"https://api.github.com/repos/snowplow/snowplow","forks_url":"https://api.github.com/repos/snowplow/snowplow/forks","keys_url":"https://api.github.com/repos/snowplow/snowplow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowplow/snowplow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowplow/snowplow/teams","hooks_url":"https://api.github.com/repos/snowplow/snowplow/hooks","issue_events_url":"https://api.github.com/repos/snowplow/snowplow/issues/events{/number}","events_url":"https://api.github.com/repos/snowplow/snowplow/events","assignees_url":"https://api.github.com/repos/snowplow/snowplow/assignees{/user}","branches_url":"https://api.github.com/repos/snowplow/snowplow/branches{/branch}","tags_url":"https://api.github.com/repos/snowplow/snowplow/tags","blobs_url":"https://api.github.com/repos/snowplow/snowplow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowplow/snowplow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowplow/snowplow/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowplow/snowplow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowplow/snowplow/statuses/{sha}","languages_url":"https://api.github.com/repos/snowplow/snowplow/languages","stargazers_url":"https://api.github.com/repos/snowplow/snowplow/stargazers","contributors_url":"https://api.github.com/repos/snowplow/snowplow/contributors","subscribers_url":"https://api.github.com/repos/snowplow/snowplow/subscribers","subscription_url":"https://api.github.com/repos/snowplow/snowplow/subscription","commits_url":"https://api.github.com/repos/snowplow/snowplow/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowplow/snowplow/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowplow/snowplow/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowplow/snowplow/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowplow/snowplow/contents/{+path}","compare_url":"https://api.github.com/repos/snowplow/snowplow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowplow/snowplow/merges","archive_url":"https://api.github.com/repos/snowplow/snowplow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowplow/snowplow/downloads","issues_url":"https://api.github.com/repos/snowplow/snowplow/issues{/number}","pulls_url":"https://api.github.com/repos/snowplow/snowplow/pulls{/number}","milestones_url":"https://api.github.com/repos/snowplow/snowplow/milestones{/number}","notifications_url":"https://api.github.com/repos/snowplow/snowplow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowplow/snowplow/labels{/name}","releases_url":"https://api.github.com/repos/snowplow/snowplow/releases{/id}","deployments_url":"https://api.github.com/repos/snowplow/snowplow/deployments","created_at":"2012-03-01T13:02:21Z","updated_at":"2018-12-10T09:58:56Z","pushed_at":"2018-12-10T06:41:39Z","git_url":"git://github.com/snowplow/snowplow.git","ssh_url":"git@github.com:snowplow/snowplow.git","clone_url":"https://github.com/snowplow/snowplow.git","svn_url":"https://github.com/snowplow/snowplow","homepage":"http://snowplowanalytics.com","size":23102,"stargazers_count":4445,"watchers_count":4445,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":947,"mirror_url":null,"archived":false,"open_issues_count":602,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":947,"open_issues":602,"watchers":4445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/3933"},"html":{"href":"https://github.com/snowplow/snowplow/pull/3933"},"issue":{"href":"https://api.github.com/repos/snowplow/snowplow/issues/3933"},"comments":{"href":"https://api.github.com/repos/snowplow/snowplow/issues/3933/comments"},"review_comments":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/3933/comments"},"review_comment":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snowplow/snowplow/pulls/3933/commits"},"statuses":{"href":"https://api.github.com/repos/snowplow/snowplow/statuses/d2bab7ce2f7fe2020a9b0d04f6cd82c3d0cd2e1e"}},"author_association":"MEMBER"}} | {
"id": 3591964,
"name": "snowplow/snowplow",
"url": "https://api.github.com/repos/snowplow/snowplow"
} | {
"id": 1737211,
"login": "BenFradet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1737211?",
"url": "https://api.github.com/users/BenFradet"
} | {
"id": 1476001,
"login": "snowplow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1476001?",
"url": "https://api.github.com/orgs/snowplow"
} | 2018-12-10T14:08:30 | 8727071211 | {"actor":{"display_login":"BenFradet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/comments/166849210","pull_request_review_id":94971642,"id":166849210,"diff_hunk":"@@ -1,30 +1,30 @@\n /*\n-Copyright (c) 2016, Blue Brain Project\n-All rights reserved.\n+ Copyright (c) 2016, Blue Brain Project\n+ All rights reserved.\n \n-Redistribution and use in source and binary forms, with or without modification,\n-are permitted provided that the following conditions are met:\n-1. Redistributions of source code must retain the above copyright notice,\n+ Redistribution and use in source and binary forms, with or without modification,\n+ are permitted provided that the following conditions are met:\n+ 1. Redistributions of source code must retain the above copyright notice,\n this list of conditions and the following disclaimer.\n-2. Redistributions in binary form must reproduce the above copyright notice,\n+ 2. Redistributions in binary form must reproduce the above copyright notice,\n this list of conditions and the following disclaimer in the documentation\n and/or other materials provided with the distribution.\n-3. Neither the name of the copyright holder nor the names of its contributors\n+ 3. Neither the name of the copyright holder nor the names of its contributors\n may be used to endorse or promote products derived from this software\n without specific prior written permission.\n \n-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n-ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n-LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF\n-THE POSSIBILITY OF SUCH DAMAGE.\n-*/\n+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE","path":"coreneuron/utils/reports/nrnreport.h","position":36,"original_position":36,"commit_id":"a7ce1158ca1ed7e0fbc192cb1c7d5638f741d440","original_commit_id":"a7ce1158ca1ed7e0fbc192cb1c7d5638f741d440","user":{"login":"pramodk","id":666852,"avatar_url":"https://avatars1.githubusercontent.com/u/666852?v=4","gravatar_id":"","url":"https://api.github.com/users/pramodk","html_url":"https://github.com/pramodk","followers_url":"https://api.github.com/users/pramodk/followers","following_url":"https://api.github.com/users/pramodk/following{/other_user}","gists_url":"https://api.github.com/users/pramodk/gists{/gist_id}","starred_url":"https://api.github.com/users/pramodk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pramodk/subscriptions","organizations_url":"https://api.github.com/users/pramodk/orgs","repos_url":"https://api.github.com/users/pramodk/repos","events_url":"https://api.github.com/users/pramodk/events{/privacy}","received_events_url":"https://api.github.com/users/pramodk/received_events","type":"User","site_admin":false},"body":"extra spacing in copyright?","created_at":"2018-02-08T07:27:20Z","updated_at":"2018-02-08T07:32:10Z","html_url":"https://github.com/BlueBrain/CoreNeuron/pull/74#discussion_r166849210","pull_request_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/comments/166849210"},"html":{"href":"https://github.com/BlueBrain/CoreNeuron/pull/74#discussion_r166849210"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74","id":167759652,"html_url":"https://github.com/BlueBrain/CoreNeuron/pull/74","diff_url":"https://github.com/BlueBrain/CoreNeuron/pull/74.diff","patch_url":"https://github.com/BlueBrain/CoreNeuron/pull/74.patch","issue_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/74","number":74,"state":"open","locked":false,"title":"Report generation refactoring","user":{"login":"fouriaux","id":28300081,"avatar_url":"https://avatars0.githubusercontent.com/u/28300081?v=4","gravatar_id":"","url":"https://api.github.com/users/fouriaux","html_url":"https://github.com/fouriaux","followers_url":"https://api.github.com/users/fouriaux/followers","following_url":"https://api.github.com/users/fouriaux/following{/other_user}","gists_url":"https://api.github.com/users/fouriaux/gists{/gist_id}","starred_url":"https://api.github.com/users/fouriaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fouriaux/subscriptions","organizations_url":"https://api.github.com/users/fouriaux/orgs","repos_url":"https://api.github.com/users/fouriaux/repos","events_url":"https://api.github.com/users/fouriaux/events{/privacy}","received_events_url":"https://api.github.com/users/fouriaux/received_events","type":"User","site_admin":false},"body":"* Multiple reports\r\n* Synapse Report\r\n* filtering using new report.conf format\r\n","created_at":"2018-02-07T17:32:51Z","updated_at":"2018-02-08T07:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75c21d581842a97b105f35a786f80c2597be9b1a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pramodskumbhar","id":27898197,"avatar_url":"https://avatars2.githubusercontent.com/u/27898197?v=4","gravatar_id":"","url":"https://api.github.com/users/pramodskumbhar","html_url":"https://github.com/pramodskumbhar","followers_url":"https://api.github.com/users/pramodskumbhar/followers","following_url":"https://api.github.com/users/pramodskumbhar/following{/other_user}","gists_url":"https://api.github.com/users/pramodskumbhar/gists{/gist_id}","starred_url":"https://api.github.com/users/pramodskumbhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pramodskumbhar/subscriptions","organizations_url":"https://api.github.com/users/pramodskumbhar/orgs","repos_url":"https://api.github.com/users/pramodskumbhar/repos","events_url":"https://api.github.com/users/pramodskumbhar/events{/privacy}","received_events_url":"https://api.github.com/users/pramodskumbhar/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/74/comments","statuses_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/statuses/a7ce1158ca1ed7e0fbc192cb1c7d5638f741d440","head":{"label":"BlueBrain:report_refactoring","ref":"report_refactoring","sha":"a7ce1158ca1ed7e0fbc192cb1c7d5638f741d440","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":53666842,"name":"CoreNeuron","full_name":"BlueBrain/CoreNeuron","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/CoreNeuron","description":"Simulator optimized for large scale neural network simulations. ","fork":false,"url":"https://api.github.com/repos/BlueBrain/CoreNeuron","forks_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/forks","keys_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/teams","hooks_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/events","assignees_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/tags","blobs_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/subscription","commits_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/merges","archive_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/downloads","issues_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/deployments","created_at":"2016-03-11T12:51:50Z","updated_at":"2017-12-12T18:23:25Z","pushed_at":"2018-02-07T17:32:52Z","git_url":"git://github.com/BlueBrain/CoreNeuron.git","ssh_url":"git@github.com:BlueBrain/CoreNeuron.git","clone_url":"https://github.com/BlueBrain/CoreNeuron.git","svn_url":"https://github.com/BlueBrain/CoreNeuron","homepage":null,"size":35107,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":9,"watchers":16,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"1b55b2fe6b9a17681882cf44cffa206603c683b6","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":53666842,"name":"CoreNeuron","full_name":"BlueBrain/CoreNeuron","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/CoreNeuron","description":"Simulator optimized for large scale neural network simulations. ","fork":false,"url":"https://api.github.com/repos/BlueBrain/CoreNeuron","forks_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/forks","keys_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/teams","hooks_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/events","assignees_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/tags","blobs_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/subscription","commits_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/merges","archive_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/downloads","issues_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/CoreNeuron/deployments","created_at":"2016-03-11T12:51:50Z","updated_at":"2017-12-12T18:23:25Z","pushed_at":"2018-02-07T17:32:52Z","git_url":"git://github.com/BlueBrain/CoreNeuron.git","ssh_url":"git@github.com:BlueBrain/CoreNeuron.git","clone_url":"https://github.com/BlueBrain/CoreNeuron.git","svn_url":"https://github.com/BlueBrain/CoreNeuron","homepage":null,"size":35107,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74"},"html":{"href":"https://github.com/BlueBrain/CoreNeuron/pull/74"},"issue":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/74"},"comments":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/CoreNeuron/statuses/a7ce1158ca1ed7e0fbc192cb1c7d5638f741d440"}},"author_association":"COLLABORATOR"}} | {
"id": 53666842,
"name": "BlueBrain/CoreNeuron",
"url": "https://api.github.com/repos/BlueBrain/CoreNeuron"
} | {
"id": 666852,
"login": "pramodk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/666852?",
"url": "https://api.github.com/users/pramodk"
} | {
"id": 1479142,
"login": "BlueBrain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1479142?",
"url": "https://api.github.com/orgs/BlueBrain"
} | 2018-02-08T07:27:20 | 7215304771 | {"actor":{"display_login":"pramodk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-management/pulls/comments/175260447","pull_request_review_id":104768637,"id":175260447,"diff_hunk":"@@ -0,0 +1,113 @@\n+/*\n+ * Copyright (C) 2017 Lightbend Inc. <http://www.lightbend.com>\n+ */\n+package akka.discovery.awsapi.ecs\n+\n+import java.net.{ InetAddress, NetworkInterface }\n+import java.util.concurrent.TimeoutException\n+\n+import akka.actor.ActorSystem\n+import akka.discovery.SimpleServiceDiscovery\n+import akka.discovery.SimpleServiceDiscovery.{ Resolved, ResolvedTarget }\n+import akka.discovery.awsapi.ecs.EcsSimpleServiceDiscovery._\n+import akka.pattern.after\n+import com.amazonaws.services.ecs.model.{ DescribeTasksRequest, DesiredStatus, ListTasksRequest, Task }\n+import com.amazonaws.services.ecs.{ AmazonECS, AmazonECSClientBuilder }\n+\n+import scala.annotation.tailrec\n+import scala.collection.JavaConverters._\n+import scala.collection.immutable.Seq\n+import scala.concurrent.Future\n+import scala.concurrent.duration._\n+\n+class EcsSimpleServiceDiscovery(system: ActorSystem) extends SimpleServiceDiscovery {\n+\n+ override def lookup(name: String, resolveTimeout: FiniteDuration): Future[Resolved] = {\n+ val ecsClient = AmazonECSClientBuilder.defaultClient()\n+ import system.dispatcher\n+ Future.firstCompletedOf(\n+ Seq(\n+ after(resolveTimeout, using = system.scheduler)(\n+ Future.failed(new TimeoutException(\"Future timed out!\"))\n+ ),\n+ Future {\n+ Resolved(\n+ serviceName = name,\n+ addresses = for {\n+ task <- resolveTasks(ecsClient, name)\n+ container <- task.getContainers.asScala\n+ networkInterface <- container.getNetworkInterfaces.asScala\n+ } yield\n+ ResolvedTarget(\n+ host = networkInterface.getPrivateIpv4Address,\n+ port = None\n+ )\n+ )\n+ }\n+ )\n+ )\n+ }\n+}\n+\n+object EcsSimpleServiceDiscovery {\n+\n+ // InetAddress.getLocalHost.getHostAddress throws an exception when running\n+ // in awsvpc mode because the container name cannot be resolved.\n+ // ECS provides a metadata file\n+ // (https://docs.aws.amazon.com/AmazonECS/latest/developerguide/container-metadata.html)\n+ // that we ought to be able to use instead to find our IP address, but the\n+ // metadata file does not get set when running on Fargate. So this is our\n+ // only option for determining what the canonical Akka and akka-management\n+ // hostname values should be set to.\n+ def getContainerAddress: Either[String, InetAddress] =\n+ NetworkInterface.getNetworkInterfaces.asScala\n+ .flatMap(_.getInetAddresses.asScala)\n+ .filterNot(_.isLoopbackAddress)\n+ .filter(_.isSiteLocalAddress)\n+ .to[Seq] match {\n+ case Seq(value) =>\n+ Right(value)\n+\n+ case other =>\n+ Left(s\"Exactly one private address must be configured (found: $other).\")\n+ }\n+\n+ private def resolveTasks(ecsClient: AmazonECS, serviceName: String): Seq[Task] =\n+ describeTasks(ecsClient, listTaskArns(ecsClient, serviceName))\n+\n+ @tailrec private[this] def listTaskArns(ecsClient: AmazonECS,\n+ serviceName: String,\n+ pageTaken: Option[String] = None,\n+ accumulator: Seq[String] = Seq.empty): Seq[String] = {\n+ val listTasksResult = ecsClient.listTasks(\n+ new ListTasksRequest()\n+ .withServiceName(serviceName)\n+ .withNextToken(pageTaken.orNull)\n+ .withDesiredStatus(DesiredStatus.RUNNING)\n+ )\n+ val accumulatedTasksArns = accumulator ++ listTasksResult.getTaskArns.asScala\n+ listTasksResult.getNextToken match {\n+ case null =>\n+ accumulatedTasksArns\n+\n+ case nextPageToken =>","path":"discovery-aws-api/src/main/scala/akka/discovery/awsapi/ecs/EcsSimpleServiceDiscovery.scala","position":93,"original_position":93,"commit_id":"28d6e119116a752c12b8c907b8bb29855acd98e7","original_commit_id":"28d6e119116a752c12b8c907b8bb29855acd98e7","user":{"login":"dhpiggott","id":6965859,"avatar_url":"https://avatars1.githubusercontent.com/u/6965859?v=4","gravatar_id":"","url":"https://api.github.com/users/dhpiggott","html_url":"https://github.com/dhpiggott","followers_url":"https://api.github.com/users/dhpiggott/followers","following_url":"https://api.github.com/users/dhpiggott/following{/other_user}","gists_url":"https://api.github.com/users/dhpiggott/gists{/gist_id}","starred_url":"https://api.github.com/users/dhpiggott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhpiggott/subscriptions","organizations_url":"https://api.github.com/users/dhpiggott/orgs","repos_url":"https://api.github.com/users/dhpiggott/repos","events_url":"https://api.github.com/users/dhpiggott/events{/privacy}","received_events_url":"https://api.github.com/users/dhpiggott/received_events","type":"User","site_admin":false},"body":"And here by (temporarily) adding `.withMaxResults(1)` to the request.","created_at":"2018-03-17T15:00:18Z","updated_at":"2018-03-17T15:00:19Z","html_url":"https://github.com/akka/akka-management/pull/140#discussion_r175260447","pull_request_url":"https://api.github.com/repos/akka/akka-management/pulls/140","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-management/pulls/comments/175260447"},"html":{"href":"https://github.com/akka/akka-management/pull/140#discussion_r175260447"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-management/pulls/140"}},"in_reply_to_id":174301838},"pull_request":{"url":"https://api.github.com/repos/akka/akka-management/pulls/140","id":174803564,"html_url":"https://github.com/akka/akka-management/pull/140","diff_url":"https://github.com/akka/akka-management/pull/140.diff","patch_url":"https://github.com/akka/akka-management/pull/140.patch","issue_url":"https://api.github.com/repos/akka/akka-management/issues/140","number":140,"state":"open","locked":false,"title":"(WIP) Issue #82: Implement AWS Discovery via ECS Service API","user":{"login":"dhpiggott","id":6965859,"avatar_url":"https://avatars1.githubusercontent.com/u/6965859?v=4","gravatar_id":"","url":"https://api.github.com/users/dhpiggott","html_url":"https://github.com/dhpiggott","followers_url":"https://api.github.com/users/dhpiggott/followers","following_url":"https://api.github.com/users/dhpiggott/following{/other_user}","gists_url":"https://api.github.com/users/dhpiggott/gists{/gist_id}","starred_url":"https://api.github.com/users/dhpiggott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhpiggott/subscriptions","organizations_url":"https://api.github.com/users/dhpiggott/orgs","repos_url":"https://api.github.com/users/dhpiggott/repos","events_url":"https://api.github.com/users/dhpiggott/events{/privacy}","received_events_url":"https://api.github.com/users/dhpiggott/received_events","type":"User","site_admin":false},"body":"The initial implementation was done downstream in Liquidity\r\n(https://github.com/dhpcs/liquidity).\r\n\r\nThe first approach was to use the conventions established by the\r\nEc2TagBasedSimpleServiceDiscovery implementation as a starting point.\r\nThe downstream commit on which that part of this contribution is based:\r\nhttps://github.com/dhpcs/liquidity/commit/0513aacb154ae94b67e2f6ee54a2f2906d75c2c6.\r\n\r\nThat approach works, but by limiting ourselves to the old/stable AWS SDK\r\nwe are forced to accept blocking IO between our nodes and the AWS APIs.\r\nTo overcome this, I enhanced the initial implementation to use the\r\npreview non-blocking AWS SDK.\r\n\r\nThe downstream commit on which that part of this contribution is based:\r\nhttps://github.com/dhpcs/liquidity/commit/9dfbb701fba4e613b2efe4181494284f70a21bea.\r\n\r\nIn the downstream project the non-blocking version was developed\r\nimmediately after the blocking version - so the blocking version has not\r\nactually been tested in anger. However, as can be seen in the downstream\r\ncommit, a main method was created and used to validate it works as a\r\nunit (by doing runMain locally with an appropriate AWS config pointing\r\nit to a real ECS service).\r\n\r\nThe non-blocking version was subject to the same test, but is also now\r\nin use running Liquidity (albeit as a one-node-cluster most of the\r\ntime...).\r\n\r\nThe downstream commit in which the relevant configuration changes were\r\nmade:\r\nhttps://github.com/dhpcs/liquidity/commit/1e376d25f02c4f8c0a17c2e3978660e0d2d87dec.\r\n\r\nFor me the non-blocking version is preferable (I'm happy using the\r\npreview non-blocking AWS SDK), but I recognise it might not be desirable\r\nto provide that as the only option in this contribution. Hence\r\nincluding both, with appropriate namespace separations, so that other\r\ndownstream users can choose which they are most comfortable with.\r\n\r\nIn this commit I'm providing the implementation (which is the easy part,\r\nbecause it was already done) in order to get a PR open sooner rather\r\nthan later. There's a TODO for documentation - that's the bit which\r\ncould take longer - hopefully within the next week or two though.\r\n\r\nNote that the ECS service this was built for and is tested against is\r\nusing awsvpc mode networking*\r\n(https://aws.amazon.com/about-aws/whats-new/2017/11/amazon-ecs-introduces-awsvpc-networking-mode-for-containers-to-support-full-networking-capabilities/).\r\nawsvpc mode networking makes things a lot simpler by eliminating the\r\nneed for discovering ports too (as would be necessary with bridge mode),\r\nwhile not also limiting containers to one per container instance (unlike\r\nhost mode). In other words, this solution is _not_ intended for use with\r\nolder ECS networking approaches; it's only for awsvpc mode.\r\n\r\n*it's also using Fargate, but that shouldn't make a difference one way\r\nor the other here.","created_at":"2018-03-13T22:07:17Z","updated_at":"2018-03-17T15:00:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b79e2bee268a97c9bc3d68b3f5858c1ce95da44c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-management/pulls/140/commits","review_comments_url":"https://api.github.com/repos/akka/akka-management/pulls/140/comments","review_comment_url":"https://api.github.com/repos/akka/akka-management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-management/issues/140/comments","statuses_url":"https://api.github.com/repos/akka/akka-management/statuses/28d6e119116a752c12b8c907b8bb29855acd98e7","head":{"label":"dhpiggott:ecs-service-discovery","ref":"ecs-service-discovery","sha":"28d6e119116a752c12b8c907b8bb29855acd98e7","user":{"login":"dhpiggott","id":6965859,"avatar_url":"https://avatars1.githubusercontent.com/u/6965859?v=4","gravatar_id":"","url":"https://api.github.com/users/dhpiggott","html_url":"https://github.com/dhpiggott","followers_url":"https://api.github.com/users/dhpiggott/followers","following_url":"https://api.github.com/users/dhpiggott/following{/other_user}","gists_url":"https://api.github.com/users/dhpiggott/gists{/gist_id}","starred_url":"https://api.github.com/users/dhpiggott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhpiggott/subscriptions","organizations_url":"https://api.github.com/users/dhpiggott/orgs","repos_url":"https://api.github.com/users/dhpiggott/repos","events_url":"https://api.github.com/users/dhpiggott/events{/privacy}","received_events_url":"https://api.github.com/users/dhpiggott/received_events","type":"User","site_admin":false},"repo":{"id":125115023,"name":"akka-management","full_name":"dhpiggott/akka-management","owner":{"login":"dhpiggott","id":6965859,"avatar_url":"https://avatars1.githubusercontent.com/u/6965859?v=4","gravatar_id":"","url":"https://api.github.com/users/dhpiggott","html_url":"https://github.com/dhpiggott","followers_url":"https://api.github.com/users/dhpiggott/followers","following_url":"https://api.github.com/users/dhpiggott/following{/other_user}","gists_url":"https://api.github.com/users/dhpiggott/gists{/gist_id}","starred_url":"https://api.github.com/users/dhpiggott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhpiggott/subscriptions","organizations_url":"https://api.github.com/users/dhpiggott/orgs","repos_url":"https://api.github.com/users/dhpiggott/repos","events_url":"https://api.github.com/users/dhpiggott/events{/privacy}","received_events_url":"https://api.github.com/users/dhpiggott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhpiggott/akka-management","description":null,"fork":true,"url":"https://api.github.com/repos/dhpiggott/akka-management","forks_url":"https://api.github.com/repos/dhpiggott/akka-management/forks","keys_url":"https://api.github.com/repos/dhpiggott/akka-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhpiggott/akka-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhpiggott/akka-management/teams","hooks_url":"https://api.github.com/repos/dhpiggott/akka-management/hooks","issue_events_url":"https://api.github.com/repos/dhpiggott/akka-management/issues/events{/number}","events_url":"https://api.github.com/repos/dhpiggott/akka-management/events","assignees_url":"https://api.github.com/repos/dhpiggott/akka-management/assignees{/user}","branches_url":"https://api.github.com/repos/dhpiggott/akka-management/branches{/branch}","tags_url":"https://api.github.com/repos/dhpiggott/akka-management/tags","blobs_url":"https://api.github.com/repos/dhpiggott/akka-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhpiggott/akka-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhpiggott/akka-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhpiggott/akka-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhpiggott/akka-management/statuses/{sha}","languages_url":"https://api.github.com/repos/dhpiggott/akka-management/languages","stargazers_url":"https://api.github.com/repos/dhpiggott/akka-management/stargazers","contributors_url":"https://api.github.com/repos/dhpiggott/akka-management/contributors","subscribers_url":"https://api.github.com/repos/dhpiggott/akka-management/subscribers","subscription_url":"https://api.github.com/repos/dhpiggott/akka-management/subscription","commits_url":"https://api.github.com/repos/dhpiggott/akka-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhpiggott/akka-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhpiggott/akka-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhpiggott/akka-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhpiggott/akka-management/contents/{+path}","compare_url":"https://api.github.com/repos/dhpiggott/akka-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhpiggott/akka-management/merges","archive_url":"https://api.github.com/repos/dhpiggott/akka-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhpiggott/akka-management/downloads","issues_url":"https://api.github.com/repos/dhpiggott/akka-management/issues{/number}","pulls_url":"https://api.github.com/repos/dhpiggott/akka-management/pulls{/number}","milestones_url":"https://api.github.com/repos/dhpiggott/akka-management/milestones{/number}","notifications_url":"https://api.github.com/repos/dhpiggott/akka-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhpiggott/akka-management/labels{/name}","releases_url":"https://api.github.com/repos/dhpiggott/akka-management/releases{/id}","deployments_url":"https://api.github.com/repos/dhpiggott/akka-management/deployments","created_at":"2018-03-13T21:09:37Z","updated_at":"2018-03-13T21:09:40Z","pushed_at":"2018-03-13T22:05:00Z","git_url":"git://github.com/dhpiggott/akka-management.git","ssh_url":"git@github.com:dhpiggott/akka-management.git","clone_url":"https://github.com/dhpiggott/akka-management.git","svn_url":"https://github.com/dhpiggott/akka-management","homepage":"http://developer.lightbend.com/docs/akka-management/current/","size":13107,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"f3a54393ddc6fb83a78bcc4a49e043d9904785ca","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":73269683,"name":"akka-management","full_name":"akka/akka-management","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-management","description":null,"fork":false,"url":"https://api.github.com/repos/akka/akka-management","forks_url":"https://api.github.com/repos/akka/akka-management/forks","keys_url":"https://api.github.com/repos/akka/akka-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-management/teams","hooks_url":"https://api.github.com/repos/akka/akka-management/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-management/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-management/events","assignees_url":"https://api.github.com/repos/akka/akka-management/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-management/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-management/tags","blobs_url":"https://api.github.com/repos/akka/akka-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-management/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-management/languages","stargazers_url":"https://api.github.com/repos/akka/akka-management/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-management/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-management/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-management/subscription","commits_url":"https://api.github.com/repos/akka/akka-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-management/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-management/merges","archive_url":"https://api.github.com/repos/akka/akka-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-management/downloads","issues_url":"https://api.github.com/repos/akka/akka-management/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-management/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-management/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-management/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-management/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-management/deployments","created_at":"2016-11-09T09:33:12Z","updated_at":"2018-03-13T15:51:57Z","pushed_at":"2018-03-13T22:07:17Z","git_url":"git://github.com/akka/akka-management.git","ssh_url":"git@github.com:akka/akka-management.git","clone_url":"https://github.com/akka/akka-management.git","svn_url":"https://github.com/akka/akka-management","homepage":"http://developer.lightbend.com/docs/akka-management/current/","size":13100,"stargazers_count":66,"watchers_count":66,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":34,"open_issues":19,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-management/pulls/140"},"html":{"href":"https://github.com/akka/akka-management/pull/140"},"issue":{"href":"https://api.github.com/repos/akka/akka-management/issues/140"},"comments":{"href":"https://api.github.com/repos/akka/akka-management/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-management/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-management/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-management/statuses/28d6e119116a752c12b8c907b8bb29855acd98e7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 73269683,
"name": "akka/akka-management",
"url": "https://api.github.com/repos/akka/akka-management"
} | {
"id": 6965859,
"login": "dhpiggott",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6965859?",
"url": "https://api.github.com/users/dhpiggott"
} | {
"id": 1496237,
"login": "akka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1496237?",
"url": "https://api.github.com/orgs/akka"
} | 2018-03-17T15:00:18 | 7394772393 | {"actor":{"display_login":"dhpiggott"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akka/reactive-kafka/pulls/comments/179599687","pull_request_review_id":109876213,"id":179599687,"diff_hunk":"@@ -28,6 +28,15 @@ object ConsumerMessage {\n committableOffset: CommittableOffset\n )\n \n+ /**\n+ * Output element of `transactionalSource`.\n+ * The offset is automatically committed as by the Producer\n+ */\n+ final case class TransactionalMessage[K, V](\n+ record: ConsumerRecord[K, V],\n+ partitionOffset: PartitionOffset\n+ )","path":"core/src/main/scala/akka/kafka/ConsumerMessage.scala","position":11,"original_position":11,"commit_id":"afb50287f5287e4bc7f477fe087727f9f0bd8aa7","original_commit_id":"afb50287f5287e4bc7f477fe087727f9f0bd8aa7","user":{"login":"fchaillou","id":515348,"avatar_url":"https://avatars2.githubusercontent.com/u/515348?v=4","gravatar_id":"","url":"https://api.github.com/users/fchaillou","html_url":"https://github.com/fchaillou","followers_url":"https://api.github.com/users/fchaillou/followers","following_url":"https://api.github.com/users/fchaillou/following{/other_user}","gists_url":"https://api.github.com/users/fchaillou/gists{/gist_id}","starred_url":"https://api.github.com/users/fchaillou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fchaillou/subscriptions","organizations_url":"https://api.github.com/users/fchaillou/orgs","repos_url":"https://api.github.com/users/fchaillou/repos","events_url":"https://api.github.com/users/fchaillou/events{/privacy}","received_events_url":"https://api.github.com/users/fchaillou/received_events","type":"User","site_admin":false},"body":"Did you forget to make this class implement `PartitionOffsetMessage` ?","created_at":"2018-04-05T21:01:38Z","updated_at":"2018-04-05T21:40:27Z","html_url":"https://github.com/akka/reactive-kafka/pull/420#discussion_r179599687","pull_request_url":"https://api.github.com/repos/akka/reactive-kafka/pulls/420","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/comments/179599687"},"html":{"href":"https://github.com/akka/reactive-kafka/pull/420#discussion_r179599687"},"pull_request":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/akka/reactive-kafka/pulls/420","id":177510644,"html_url":"https://github.com/akka/reactive-kafka/pull/420","diff_url":"https://github.com/akka/reactive-kafka/pull/420.diff","patch_url":"https://github.com/akka/reactive-kafka/pull/420.patch","issue_url":"https://api.github.com/repos/akka/reactive-kafka/issues/420","number":420,"state":"open","locked":false,"title":"Kafka Transactions","user":{"login":"seglo","id":1148412,"avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"body":"This PR is my first draft of Kafka transactional support to allow for \"exactly once\" message _processing_ semantics. I originally proposed this feature in #369 . I've been tinkering for some time now and I'm eager for feedback from the maintainers and users of this project. This implementation is inspired by the `exactly_once` setting for the `processing.guarantee` configuration found in Kafka Streams ([KIP-129](https://cwiki.apache.org/confluence/display/KAFKA/KIP-129%3A+Streams+Exactly-Once+Semantics), [design document](https://docs.google.com/document/d/1pGZ8xtOOyGwDYgH5vA6h19zOMMaduFK1DAB8_gBYA2c/edit#heading=h.vkrkjfth3p8p)). I've included [documentation](https://github.com/seglo/reactive-kafka/blob/transactions/docs/src/main/paradox/transactions.md) which describes the implementation and usage in detail. Some excerpts are copied into the PR description below for convenience.\r\n\r\n> # Transactions \r\n> Kafka Transactions provide guarantees that messages processed in a consume->transform->produce workflow (consumed from a source topic, transformed, and produced to a destination topic) are processed exactly once or not at all. This is achieved through coordination between the Kafka consumer group coordinator, transaction coordinator, and the consumer and producer clients used in the user application. The Kafka producer marks messages that are consumed from the source topic as \"committed\" only once the transformed messages are successfully produced to the sink. \r\n> \r\n\r\n...\r\n\r\n> ## Consume Transform Produce Workflow\r\n> Kafka transactions are handled transparently to the user. The `Consumer.transactionalSource` will enforce that a consumer group id is specified and the `Producer.transactionalFlow` or `Producer.transactionalSink` will enforce that a transactional id is specified. All other Kafka consumer and producer properties required to enable transactions are overridden.\r\n> \r\n> Transactions are committed on an interval which can be controlled with the producer config `akka.kafka.producer.eos-commit-interval-ms`, similar to how exactly once works with Kafka Streams. The default value is `100ms`. The larger commit interval is the more records will need to be reprocessed in the event of failure and the transaction is aborted.\r\n> \r\n> When the stream is materialized the producer will initialize the transaction for the provided `transactionalId` and a transaction will begin. Every commit interval (`eos-commit-interval-ms`) we check if there are any offsets available to commit. If offsets exist then we suspend backpressured demand while we drain all outstanding messages that have not yet been successfully acknowledged (if any) and then commit the transaction. After the commit succeeds a new transaction is begun and we re-initialize demand for upstream messages.\r\n> \r\n> To gracefully shutdown the stream and commit the current transaction you must call `shutdown()` on the `Control` materialized value to await all produced message acknowledgements and commit the final transaction. \r\n\r\nAn oversimplified example using `RestartableSource` to recover from transient errors encountered in a stream. For a more detailed example see the [`\"successful consume transform produce transaction with transient failure causing an abort with restartable source\"` test in `IntegrationSpec`](https://github.com/seglo/reactive-kafka/blob/transactions/core/src/test/scala/akka/kafka/scaladsl/IntegrationSpec.scala#L465).\r\n\r\n```\r\n var innerControl = null.asInstanceOf[Control]\r\n\r\n val stream = RestartSource.onFailuresWithBackoff(\r\n minBackoff = 1.seconds,\r\n maxBackoff = 30.seconds,\r\n randomFactor = 0.2\r\n ) { () =>\r\n Consumer.transactionalSource(consumerSettings, Subscriptions.topics(\"source-topic\"))\r\n .via(business)\r\n .map { msg =>\r\n ProducerMessage.Message(\r\n new ProducerRecord[Array[Byte], String](\"sink-topic\", msg.record.value), msg.partitionOffset)\r\n }\r\n // side effect out the `Control` materialized value because it can't be propagated through the `RestartSource`\r\n .mapMaterializedValue(innerControl = _)\r\n .via(Producer.transactionalFlow(producerSettings, \"transactional-id\"))\r\n }\r\n\r\n stream.runWith(Sink.ignore)\r\n\r\n // Add shutdown hook to respond to SIGTERM and gracefully shutdown stream\r\n Runtime.getRuntime.addShutdownHook(new Thread { Await.result(innerControl.shutdown(), 10.seconds) })\r\n```","created_at":"2018-03-26T17:10:29Z","updated_at":"2018-04-05T21:40:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a5eb4d61efa902f83578f11caf9287265f99e10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/reactive-kafka/pulls/420/commits","review_comments_url":"https://api.github.com/repos/akka/reactive-kafka/pulls/420/comments","review_comment_url":"https://api.github.com/repos/akka/reactive-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/reactive-kafka/issues/420/comments","statuses_url":"https://api.github.com/repos/akka/reactive-kafka/statuses/afb50287f5287e4bc7f477fe087727f9f0bd8aa7","head":{"label":"seglo:transactions","ref":"transactions","sha":"afb50287f5287e4bc7f477fe087727f9f0bd8aa7","user":{"login":"seglo","id":1148412,"avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"repo":{"id":112093533,"name":"reactive-kafka","full_name":"seglo/reactive-kafka","owner":{"login":"seglo","id":1148412,"avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seglo/reactive-kafka","description":"Reactive Streams API for Apache Kafka","fork":true,"url":"https://api.github.com/repos/seglo/reactive-kafka","forks_url":"https://api.github.com/repos/seglo/reactive-kafka/forks","keys_url":"https://api.github.com/repos/seglo/reactive-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seglo/reactive-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seglo/reactive-kafka/teams","hooks_url":"https://api.github.com/repos/seglo/reactive-kafka/hooks","issue_events_url":"https://api.github.com/repos/seglo/reactive-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/seglo/reactive-kafka/events","assignees_url":"https://api.github.com/repos/seglo/reactive-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/seglo/reactive-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/seglo/reactive-kafka/tags","blobs_url":"https://api.github.com/repos/seglo/reactive-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seglo/reactive-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seglo/reactive-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/seglo/reactive-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seglo/reactive-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/seglo/reactive-kafka/languages","stargazers_url":"https://api.github.com/repos/seglo/reactive-kafka/stargazers","contributors_url":"https://api.github.com/repos/seglo/reactive-kafka/contributors","subscribers_url":"https://api.github.com/repos/seglo/reactive-kafka/subscribers","subscription_url":"https://api.github.com/repos/seglo/reactive-kafka/subscription","commits_url":"https://api.github.com/repos/seglo/reactive-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/seglo/reactive-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/seglo/reactive-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/seglo/reactive-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/seglo/reactive-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/seglo/reactive-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seglo/reactive-kafka/merges","archive_url":"https://api.github.com/repos/seglo/reactive-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seglo/reactive-kafka/downloads","issues_url":"https://api.github.com/repos/seglo/reactive-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/seglo/reactive-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/seglo/reactive-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/seglo/reactive-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seglo/reactive-kafka/labels{/name}","releases_url":"https://api.github.com/repos/seglo/reactive-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/seglo/reactive-kafka/deployments","created_at":"2017-11-26T15:22:04Z","updated_at":"2018-04-04T21:49:38Z","pushed_at":"2018-04-04T22:00:34Z","git_url":"git://github.com/seglo/reactive-kafka.git","ssh_url":"git@github.com:seglo/reactive-kafka.git","clone_url":"https://github.com/seglo/reactive-kafka.git","svn_url":"https://github.com/seglo/reactive-kafka","homepage":"http://doc.akka.io/docs/akka-stream-kafka/current/home.html","size":1153,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"b5096f0ef79b3c8e25bcdc831a78ea36b20a0208","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":28635588,"name":"reactive-kafka","full_name":"akka/reactive-kafka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/reactive-kafka","description":"Reactive Streams API for Apache Kafka","fork":false,"url":"https://api.github.com/repos/akka/reactive-kafka","forks_url":"https://api.github.com/repos/akka/reactive-kafka/forks","keys_url":"https://api.github.com/repos/akka/reactive-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/reactive-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/reactive-kafka/teams","hooks_url":"https://api.github.com/repos/akka/reactive-kafka/hooks","issue_events_url":"https://api.github.com/repos/akka/reactive-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/reactive-kafka/events","assignees_url":"https://api.github.com/repos/akka/reactive-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/reactive-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/reactive-kafka/tags","blobs_url":"https://api.github.com/repos/akka/reactive-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/reactive-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/reactive-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/reactive-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/reactive-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/reactive-kafka/languages","stargazers_url":"https://api.github.com/repos/akka/reactive-kafka/stargazers","contributors_url":"https://api.github.com/repos/akka/reactive-kafka/contributors","subscribers_url":"https://api.github.com/repos/akka/reactive-kafka/subscribers","subscription_url":"https://api.github.com/repos/akka/reactive-kafka/subscription","commits_url":"https://api.github.com/repos/akka/reactive-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/reactive-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/reactive-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/reactive-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/reactive-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/reactive-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/reactive-kafka/merges","archive_url":"https://api.github.com/repos/akka/reactive-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/reactive-kafka/downloads","issues_url":"https://api.github.com/repos/akka/reactive-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/reactive-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/reactive-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/reactive-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/reactive-kafka/labels{/name}","releases_url":"https://api.github.com/repos/akka/reactive-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/reactive-kafka/deployments","created_at":"2014-12-30T15:30:02Z","updated_at":"2018-04-05T15:26:30Z","pushed_at":"2018-04-05T15:26:25Z","git_url":"git://github.com/akka/reactive-kafka.git","ssh_url":"git@github.com:akka/reactive-kafka.git","clone_url":"https://github.com/akka/reactive-kafka.git","svn_url":"https://github.com/akka/reactive-kafka","homepage":"http://doc.akka.io/docs/akka-stream-kafka/current/home.html","size":1152,"stargazers_count":974,"watchers_count":974,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":270,"open_issues":71,"watchers":974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/420"},"html":{"href":"https://github.com/akka/reactive-kafka/pull/420"},"issue":{"href":"https://api.github.com/repos/akka/reactive-kafka/issues/420"},"comments":{"href":"https://api.github.com/repos/akka/reactive-kafka/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/reactive-kafka/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/akka/reactive-kafka/statuses/afb50287f5287e4bc7f477fe087727f9f0bd8aa7"}},"author_association":"NONE"}} | {
"id": 28635588,
"name": "akka/reactive-kafka",
"url": "https://api.github.com/repos/akka/reactive-kafka"
} | {
"id": 515348,
"login": "fchaillou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/515348?",
"url": "https://api.github.com/users/fchaillou"
} | {
"id": 1496237,
"login": "akka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1496237?",
"url": "https://api.github.com/orgs/akka"
} | 2018-04-05T21:01:38 | 7487776871 | {"actor":{"display_login":"fchaillou"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/236054020","pull_request_review_id":178062585,"id":236054020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA1NDAyMA==","diff_hunk":"@@ -97,6 +98,19 @@ import akka.util.JavaDurationConverters._\n }(responseTimeout, ClassTag[Res](resClass))\n }\n \n+ // Scala API impl\n+ def pipeToSelf[Value](future: Future[Value])(mapResult: Try[Value] ⇒ T): Unit = {\n+ future.onComplete(value ⇒ self.upcast ! AdaptMessage(value, mapResult))\n+ }\n+\n+ // Java API impl\n+ def pipeToSelf[Value](future: CompletionStage[Value], applyToResult: BiFunction[Value, Throwable, T]): Unit = {\n+ future whenComplete ((value: Value, ex: Throwable) ⇒ {\n+ if (value != null) self ! applyToResult.apply(value, null)\n+ if (ex != null) self ! applyToResult.apply(null.asInstanceOf[Value], ex)\n+ })","path":"akka-actor-typed/src/main/scala/akka/actor/typed/internal/ActorContextImpl.scala","position":36,"original_position":36,"commit_id":"45b32b3e079a5783c0de4d90554e9eafb70afebe","original_commit_id":"45b32b3e079a5783c0de4d90554e9eafb70afebe","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":"I've deferred that to #25972, so they can all be done.","created_at":"2018-11-24T21:20:31Z","updated_at":"2018-11-24T21:20:31Z","html_url":"https://github.com/akka/akka/pull/25966#discussion_r236054020","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/25966","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/236054020"},"html":{"href":"https://github.com/akka/akka/pull/25966#discussion_r236054020"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/25966"}},"in_reply_to_id":236051482},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/25966","id":233093748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDkzNzQ4","html_url":"https://github.com/akka/akka/pull/25966","diff_url":"https://github.com/akka/akka/pull/25966.diff","patch_url":"https://github.com/akka/akka/pull/25966.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/25966","number":25966,"state":"open","locked":false,"title":"Add pipeToSelf to typed ActorContext","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":"* Implemented in terms of AdaptMessage, which makes sure to map the\r\n values on the actor's thread, in Scala.\r\n* Defined with 2 parameter groups, to help type inferrence, in Scala\r\n* Test inspired by ActorContextAskSpec & PipeToSpec.\r\n\r\nAlso: Remove AskResponse by reusing AdaptMessage more","created_at":"2018-11-23T01:59:31Z","updated_at":"2018-11-24T21:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87709d91d8796d5d63b4528af4f006637c800c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/25966/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/25966/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/25966/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/45b32b3e079a5783c0de4d90554e9eafb70afebe","head":{"label":"dwijnand:pipeToSelf","ref":"pipeToSelf","sha":"45b32b3e079a5783c0de4d90554e9eafb70afebe","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"repo":{"id":92174429,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE3NDQyOQ==","name":"akka","full_name":"dwijnand/akka","private":false,"owner":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwijnand/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":true,"url":"https://api.github.com/repos/dwijnand/akka","forks_url":"https://api.github.com/repos/dwijnand/akka/forks","keys_url":"https://api.github.com/repos/dwijnand/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwijnand/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwijnand/akka/teams","hooks_url":"https://api.github.com/repos/dwijnand/akka/hooks","issue_events_url":"https://api.github.com/repos/dwijnand/akka/issues/events{/number}","events_url":"https://api.github.com/repos/dwijnand/akka/events","assignees_url":"https://api.github.com/repos/dwijnand/akka/assignees{/user}","branches_url":"https://api.github.com/repos/dwijnand/akka/branches{/branch}","tags_url":"https://api.github.com/repos/dwijnand/akka/tags","blobs_url":"https://api.github.com/repos/dwijnand/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwijnand/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwijnand/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwijnand/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwijnand/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/dwijnand/akka/languages","stargazers_url":"https://api.github.com/repos/dwijnand/akka/stargazers","contributors_url":"https://api.github.com/repos/dwijnand/akka/contributors","subscribers_url":"https://api.github.com/repos/dwijnand/akka/subscribers","subscription_url":"https://api.github.com/repos/dwijnand/akka/subscription","commits_url":"https://api.github.com/repos/dwijnand/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwijnand/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwijnand/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwijnand/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwijnand/akka/contents/{+path}","compare_url":"https://api.github.com/repos/dwijnand/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwijnand/akka/merges","archive_url":"https://api.github.com/repos/dwijnand/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwijnand/akka/downloads","issues_url":"https://api.github.com/repos/dwijnand/akka/issues{/number}","pulls_url":"https://api.github.com/repos/dwijnand/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/dwijnand/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/dwijnand/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwijnand/akka/labels{/name}","releases_url":"https://api.github.com/repos/dwijnand/akka/releases{/id}","deployments_url":"https://api.github.com/repos/dwijnand/akka/deployments","created_at":"2017-05-23T13:11:56Z","updated_at":"2018-11-04T01:56:33Z","pushed_at":"2018-11-23T21:23:12Z","git_url":"git://github.com/dwijnand/akka.git","ssh_url":"git@github.com:dwijnand/akka.git","clone_url":"https://github.com/dwijnand/akka.git","svn_url":"https://github.com/dwijnand/akka","homepage":"http://akka.io","size":212367,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"039bb26d2c552ba22b62efed7ed4fff468f5d4c2","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","private":false,"owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-11-24T19:31:58Z","pushed_at":"2018-11-23T21:23:15Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":215498,"stargazers_count":9259,"watchers_count":9259,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2910,"mirror_url":null,"archived":false,"open_issues_count":839,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2910,"open_issues":839,"watchers":9259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/25966"},"html":{"href":"https://github.com/akka/akka/pull/25966"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/25966"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/25966/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/25966/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/25966/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/45b32b3e079a5783c0de4d90554e9eafb70afebe"}},"author_association":"MEMBER"}} | {
"id": 130013,
"name": "akka/akka",
"url": "https://api.github.com/repos/akka/akka"
} | {
"id": 344610,
"login": "dwijnand",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/344610?",
"url": "https://api.github.com/users/dwijnand"
} | {
"id": 1496237,
"login": "akka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1496237?",
"url": "https://api.github.com/orgs/akka"
} | 2018-11-24T21:20:31 | 8641760298 | {"actor":{"display_login":"dwijnand"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/192667221","pull_request_review_id":125483269,"id":192667221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjY2NzIyMQ==","diff_hunk":"@@ -35,12 +38,12 @@ public State emptyState() {\n \n @Override\n public CommandHandler<Command, Event, State> commandHandler() {\n- return (ctx, state, command) -> Effect().none();\n+ return (ctx, state, command) -> someEffectFromCommand;\n }\n \n @Override\n public EventHandler<Event, State> eventHandler() {\n- return (state, event) -> state;\n+ return (state, event) -> newStateAfterEvent;\n }","path":"akka-persistence-typed/src/test/java/jdocs/akka/persistence/typed/BasicPersistentBehaviorsTest.java","position":22,"original_position":22,"commit_id":"052b1ab21866f806bef2371bb84822597429a722","original_commit_id":"052b1ab21866f806bef2371bb84822597429a722","user":{"login":"viktorklang","id":10871,"node_id":"MDQ6VXNlcjEwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/10871?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"I'd be fine with TODOs, so in that case I think we need to return `null` in those cases for Java, and ??? for Scala because I wouldn't want it to silently do the wrong thing—i.e. it needs to be implemented. Wdyt?\r\n","created_at":"2018-06-04T08:49:40Z","updated_at":"2018-06-04T08:49:40Z","html_url":"https://github.com/akka/akka/pull/25194#discussion_r192667221","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/25194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/192667221"},"html":{"href":"https://github.com/akka/akka/pull/25194#discussion_r192667221"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/25194"}},"in_reply_to_id":192657431},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/25194","id":192324458,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzI0NDU4","html_url":"https://github.com/akka/akka/pull/25194","diff_url":"https://github.com/akka/akka/pull/25194.diff","patch_url":"https://github.com/akka/akka/pull/25194.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/25194","number":25194,"state":"open","locked":false,"title":"Proposed documentation updates for Akka Persistence Typed","user":{"login":"viktorklang","id":10871,"node_id":"MDQ6VXNlcjEwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/10871?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"These are some elaborations I asked myself as I read the documentation.\r\nI hope any of it is found to be helpful!","created_at":"2018-06-04T07:52:47Z","updated_at":"2018-06-04T08:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e01e14e0664945ebf2fc2a5b6ecc592b26a84c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":92622675,"node_id":"MDU6TGFiZWw5MjYyMjY3NQ==","url":"https://api.github.com/repos/akka/akka/labels/t:docs","name":"t:docs","color":"CCCCCC","default":false},{"id":92611711,"node_id":"MDU6TGFiZWw5MjYxMTcxMQ==","url":"https://api.github.com/repos/akka/akka/labels/t:persistence","name":"t:persistence","color":"CCCCCC","default":false},{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/25194/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/25194/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/25194/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/052b1ab21866f806bef2371bb84822597429a722","head":{"label":"akka:wip-persistence-typed-doc-updates-√","ref":"wip-persistence-typed-doc-updates-√","sha":"052b1ab21866f806bef2371bb84822597429a722","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-06-04T08:02:35Z","pushed_at":"2018-06-04T08:41:59Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":211536,"stargazers_count":8611,"watchers_count":8611,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2739,"mirror_url":null,"archived":false,"open_issues_count":716,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2739,"open_issues":716,"watchers":8611,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"85c37f4aeb1a7a4a761e15aa8d26abb432aeb438","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-06-04T08:02:35Z","pushed_at":"2018-06-04T08:41:59Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":211536,"stargazers_count":8611,"watchers_count":8611,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2739,"mirror_url":null,"archived":false,"open_issues_count":716,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2739,"open_issues":716,"watchers":8611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/25194"},"html":{"href":"https://github.com/akka/akka/pull/25194"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/25194"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/25194/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/25194/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/25194/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/052b1ab21866f806bef2371bb84822597429a722"}},"author_association":"MEMBER"}} | {
"id": 130013,
"name": "akka/akka",
"url": "https://api.github.com/repos/akka/akka"
} | {
"id": 10871,
"login": "viktorklang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10871?",
"url": "https://api.github.com/users/viktorklang"
} | {
"id": 1496237,
"login": "akka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1496237?",
"url": "https://api.github.com/orgs/akka"
} | 2018-06-04T08:49:40 | 7770438797 | {"actor":{"display_login":"viktorklang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/176987270","pull_request_review_id":106780661,"id":176987270,"diff_hunk":"@@ -0,0 +1,35 @@\n+class ClozureCl < Formula\n+ desc \"Common Lisp implementation with a long history\"\n+ homepage \"https://ccl.clozure.com\"\n+ url \"https://github.com/Clozure/ccl/releases/download/v1.11.5/ccl-1.11.5-darwinx86.tar.gz\"\n+ sha256 \"5adbea3d8b4a2e29af30d141f781c6613844f468c0ccfa11bae908c3e9641939\"\n+ head \"https://github.com/Clozure/ccl.git\"\n+\n+ depends_on :xcode => :build\n+\n+ def install\n+ cd \"lisp-kernel/darwinx8664\" do\n+ system \"make\", \"clean\"\n+ system \"make\"\n+ end\n+\n+ ENV[\"CCL_DEFAULT_DIRECTORY\"] = buildpath\n+ system \"scripts/ccl64\", \"-n\",\n+ \"-e\", \"(ccl:rebuild-ccl :full t)\",\n+ \"-e\", \"(quit)\"\n+\n+ prefix.install \"doc/README\"\n+ doc.install Dir[\"doc/*\"]\n+\n+ libexec.install Dir[\"*\"]","path":"Formula/clozure-cl.rb","position":24,"original_position":24,"commit_id":"51a5b8fb44f0e17533ef94b6b987c8f64c85f982","original_commit_id":"51a5b8fb44f0e17533ef94b6b987c8f64c85f982","user":{"login":"ylluminarious","id":4912973,"avatar_url":"https://avatars2.githubusercontent.com/u/4912973?v=4","gravatar_id":"","url":"https://api.github.com/users/ylluminarious","html_url":"https://github.com/ylluminarious","followers_url":"https://api.github.com/users/ylluminarious/followers","following_url":"https://api.github.com/users/ylluminarious/following{/other_user}","gists_url":"https://api.github.com/users/ylluminarious/gists{/gist_id}","starred_url":"https://api.github.com/users/ylluminarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylluminarious/subscriptions","organizations_url":"https://api.github.com/users/ylluminarious/orgs","repos_url":"https://api.github.com/users/ylluminarious/repos","events_url":"https://api.github.com/users/ylluminarious/events{/privacy}","received_events_url":"https://api.github.com/users/ylluminarious/received_events","type":"User","site_admin":false},"body":"@ilovezfs It seems that there is [an expectation](https://github.com/Clozure/ccl/issues/84) from the developers that one has a preexisting heap image in order to compile properly. Even their documentation points to this fact, the docs which you said are \"poor.\" So I need to consult with their developers a bit and see if a fully bootstrapped build is possible.\r\n\r\nThis is an unfortunate situation for package managers which like to build everything from source, but this *is* the way programs are traditionally built in the Lisp world. The practice dates back to Lisp's inception way back in the 50's. So it's not just some crazy half-baked program which doesn't know how to build itself properly.\r\n\r\nIn the meantime, please do not close this PR. This is a useful program and it actually is used by a number of Mac users so it would be really nice to have this in homebrew again.","created_at":"2018-03-26T06:05:08Z","updated_at":"2018-03-26T06:05:08Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/25768#discussion_r176987270","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/176987270"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/25768#discussion_r176987270"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768"}},"in_reply_to_id":176983405},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768","id":177342802,"html_url":"https://github.com/Homebrew/homebrew-core/pull/25768","diff_url":"https://github.com/Homebrew/homebrew-core/pull/25768.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/25768.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25768","number":25768,"state":"open","locked":false,"title":"clozure-cl 1.11.5 (restoration of a deleted formula)","user":{"login":"ylluminarious","id":4912973,"avatar_url":"https://avatars2.githubusercontent.com/u/4912973?v=4","gravatar_id":"","url":"https://api.github.com/users/ylluminarious","html_url":"https://github.com/ylluminarious","followers_url":"https://api.github.com/users/ylluminarious/followers","following_url":"https://api.github.com/users/ylluminarious/following{/other_user}","gists_url":"https://api.github.com/users/ylluminarious/gists{/gist_id}","starred_url":"https://api.github.com/users/ylluminarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylluminarious/subscriptions","organizations_url":"https://api.github.com/users/ylluminarious/orgs","repos_url":"https://api.github.com/users/ylluminarious/repos","events_url":"https://api.github.com/users/ylluminarious/events{/privacy}","received_events_url":"https://api.github.com/users/ylluminarious/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nThis formula was deleted in https://github.com/Homebrew/homebrew-core/pull/23970. Its problem was apparently that it did not build from sources, according to @ilovezfs. I have tried to address this issue while keeping most of the same code from the original formula. As far as I can tell from running some `find` incantations, there are no binary files in the source directory. So running the same commands as in the original formula seem to do the trick just fine and (I think) are building from source.\r\n\r\nPing @paulvaneecke and @vinay who also expressed interest in this formula's revival.","created_at":"2018-03-26T05:00:33Z","updated_at":"2018-03-26T06:05:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a180a9cd6acd58b71331c6677abfeb4dee07093e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":351930923,"url":"https://api.github.com/repos/Homebrew/homebrew-core/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25768/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/51a5b8fb44f0e17533ef94b6b987c8f64c85f982","head":{"label":"ylluminarious:clozure-cl","ref":"clozure-cl","sha":"51a5b8fb44f0e17533ef94b6b987c8f64c85f982","user":{"login":"ylluminarious","id":4912973,"avatar_url":"https://avatars2.githubusercontent.com/u/4912973?v=4","gravatar_id":"","url":"https://api.github.com/users/ylluminarious","html_url":"https://github.com/ylluminarious","followers_url":"https://api.github.com/users/ylluminarious/followers","following_url":"https://api.github.com/users/ylluminarious/following{/other_user}","gists_url":"https://api.github.com/users/ylluminarious/gists{/gist_id}","starred_url":"https://api.github.com/users/ylluminarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylluminarious/subscriptions","organizations_url":"https://api.github.com/users/ylluminarious/orgs","repos_url":"https://api.github.com/users/ylluminarious/repos","events_url":"https://api.github.com/users/ylluminarious/events{/privacy}","received_events_url":"https://api.github.com/users/ylluminarious/received_events","type":"User","site_admin":false},"repo":{"id":106515451,"name":"homebrew-core","full_name":"ylluminarious/homebrew-core","owner":{"login":"ylluminarious","id":4912973,"avatar_url":"https://avatars2.githubusercontent.com/u/4912973?v=4","gravatar_id":"","url":"https://api.github.com/users/ylluminarious","html_url":"https://github.com/ylluminarious","followers_url":"https://api.github.com/users/ylluminarious/followers","following_url":"https://api.github.com/users/ylluminarious/following{/other_user}","gists_url":"https://api.github.com/users/ylluminarious/gists{/gist_id}","starred_url":"https://api.github.com/users/ylluminarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylluminarious/subscriptions","organizations_url":"https://api.github.com/users/ylluminarious/orgs","repos_url":"https://api.github.com/users/ylluminarious/repos","events_url":"https://api.github.com/users/ylluminarious/events{/privacy}","received_events_url":"https://api.github.com/users/ylluminarious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylluminarious/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/ylluminarious/homebrew-core","forks_url":"https://api.github.com/repos/ylluminarious/homebrew-core/forks","keys_url":"https://api.github.com/repos/ylluminarious/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylluminarious/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylluminarious/homebrew-core/teams","hooks_url":"https://api.github.com/repos/ylluminarious/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/ylluminarious/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/ylluminarious/homebrew-core/events","assignees_url":"https://api.github.com/repos/ylluminarious/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/ylluminarious/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/ylluminarious/homebrew-core/tags","blobs_url":"https://api.github.com/repos/ylluminarious/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylluminarious/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylluminarious/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylluminarious/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylluminarious/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ylluminarious/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/ylluminarious/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/ylluminarious/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/ylluminarious/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/ylluminarious/homebrew-core/subscription","commits_url":"https://api.github.com/repos/ylluminarious/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylluminarious/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylluminarious/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylluminarious/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylluminarious/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/ylluminarious/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylluminarious/homebrew-core/merges","archive_url":"https://api.github.com/repos/ylluminarious/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylluminarious/homebrew-core/downloads","issues_url":"https://api.github.com/repos/ylluminarious/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/ylluminarious/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ylluminarious/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ylluminarious/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylluminarious/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/ylluminarious/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/ylluminarious/homebrew-core/deployments","created_at":"2017-10-11T06:40:51Z","updated_at":"2018-03-17T07:59:51Z","pushed_at":"2018-03-26T04:59:10Z","git_url":"git://github.com/ylluminarious/homebrew-core.git","ssh_url":"git@github.com:ylluminarious/homebrew-core.git","clone_url":"https://github.com/ylluminarious/homebrew-core.git","svn_url":"https://github.com/ylluminarious/homebrew-core","homepage":"https://brew.sh","size":173722,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"1841e28ea9760ddf50bd2f67e911fa79e481dbf0","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2018-03-26T05:56:41Z","pushed_at":"2018-03-26T05:56:42Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":173681,"stargazers_count":3318,"watchers_count":3318,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4116,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":4116,"open_issues":68,"watchers":3318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/25768"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25768"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25768/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25768/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/51a5b8fb44f0e17533ef94b6b987c8f64c85f982"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52855516,
"name": "Homebrew/homebrew-core",
"url": "https://api.github.com/repos/Homebrew/homebrew-core"
} | {
"id": 4912973,
"login": "ylluminarious",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4912973?",
"url": "https://api.github.com/users/ylluminarious"
} | {
"id": 1503512,
"login": "Homebrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1503512?",
"url": "https://api.github.com/orgs/Homebrew"
} | 2018-03-26T06:05:08 | 7433140634 | {"actor":{"display_login":"ylluminarious"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/204657710","pull_request_review_id":139772638,"id":204657710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDY1NzcxMA==","diff_hunk":"@@ -151,10 +153,11 @@ def each_line_from(sources)\n end\n \n def result\n- Result.new(command,\n- processed_output[:stdout],\n- processed_output[:stderr],\n- processed_status.exitstatus)\n+ output = @merged_output.each_with_object(stdout: \"\", stderr: \"\") do |(type, line), h|\n+ h[type] << line","path":"Library/Homebrew/system_command.rb","position":74,"original_position":74,"commit_id":"ac1fc193329033930a5d617cee8e59da62712bbd","original_commit_id":"ac1fc193329033930a5d617cee8e59da62712bbd","user":{"login":"MikeMcQuaid","id":125011,"node_id":"MDQ6VXNlcjEyNTAxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"`hash` would be a preferable variable (assuming that's what it is)","created_at":"2018-07-24T07:57:51Z","updated_at":"2018-07-24T07:57:51Z","html_url":"https://github.com/Homebrew/brew/pull/4541#discussion_r204657710","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/4541","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/204657710"},"html":{"href":"https://github.com/Homebrew/brew/pull/4541#discussion_r204657710"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4541"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/4541","id":203343609,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzQzNjA5","html_url":"https://github.com/Homebrew/brew/pull/4541","diff_url":"https://github.com/Homebrew/brew/pull/4541.diff","patch_url":"https://github.com/Homebrew/brew/pull/4541.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/4541","number":4541,"state":"open","locked":false,"title":"Merge `Hbc::Container` classes into `UnpackStrategy`.","user":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/brew/blob/master/Library/Homebrew/test/PATH_spec.rb).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n","created_at":"2018-07-23T21:05:54Z","updated_at":"2018-07-24T07:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c097b7527429f23152b13ebc07b2d26a922a854","assignee":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"assignees":[{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JCount","id":18537310,"node_id":"MDQ6VXNlcjE4NTM3MzEw","avatar_url":"https://avatars2.githubusercontent.com/u/18537310?v=4","gravatar_id":"","url":"https://api.github.com/users/JCount","html_url":"https://github.com/JCount","followers_url":"https://api.github.com/users/JCount/followers","following_url":"https://api.github.com/users/JCount/following{/other_user}","gists_url":"https://api.github.com/users/JCount/gists{/gist_id}","starred_url":"https://api.github.com/users/JCount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCount/subscriptions","organizations_url":"https://api.github.com/users/JCount/orgs","repos_url":"https://api.github.com/users/JCount/repos","events_url":"https://api.github.com/users/JCount/events{/privacy}","received_events_url":"https://api.github.com/users/JCount/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":351931983,"node_id":"MDU6TGFiZWwzNTE5MzE5ODM=","url":"https://api.github.com/repos/Homebrew/brew/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/4541/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/4541/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/4541/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/ac1fc193329033930a5d617cee8e59da62712bbd","head":{"label":"reitermarkus:unpack-strategies","ref":"unpack-strategies","sha":"ac1fc193329033930a5d617cee8e59da62712bbd","user":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"repo":{"id":63458821,"node_id":"MDEwOlJlcG9zaXRvcnk2MzQ1ODgyMQ==","name":"brew","full_name":"reitermarkus/brew","owner":{"login":"reitermarkus","id":1309829,"node_id":"MDQ6VXNlcjEzMDk4Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1309829?v=4","gravatar_id":"","url":"https://api.github.com/users/reitermarkus","html_url":"https://github.com/reitermarkus","followers_url":"https://api.github.com/users/reitermarkus/followers","following_url":"https://api.github.com/users/reitermarkus/following{/other_user}","gists_url":"https://api.github.com/users/reitermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/reitermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitermarkus/subscriptions","organizations_url":"https://api.github.com/users/reitermarkus/orgs","repos_url":"https://api.github.com/users/reitermarkus/repos","events_url":"https://api.github.com/users/reitermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/reitermarkus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reitermarkus/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/reitermarkus/brew","forks_url":"https://api.github.com/repos/reitermarkus/brew/forks","keys_url":"https://api.github.com/repos/reitermarkus/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reitermarkus/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reitermarkus/brew/teams","hooks_url":"https://api.github.com/repos/reitermarkus/brew/hooks","issue_events_url":"https://api.github.com/repos/reitermarkus/brew/issues/events{/number}","events_url":"https://api.github.com/repos/reitermarkus/brew/events","assignees_url":"https://api.github.com/repos/reitermarkus/brew/assignees{/user}","branches_url":"https://api.github.com/repos/reitermarkus/brew/branches{/branch}","tags_url":"https://api.github.com/repos/reitermarkus/brew/tags","blobs_url":"https://api.github.com/repos/reitermarkus/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reitermarkus/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reitermarkus/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/reitermarkus/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reitermarkus/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/reitermarkus/brew/languages","stargazers_url":"https://api.github.com/repos/reitermarkus/brew/stargazers","contributors_url":"https://api.github.com/repos/reitermarkus/brew/contributors","subscribers_url":"https://api.github.com/repos/reitermarkus/brew/subscribers","subscription_url":"https://api.github.com/repos/reitermarkus/brew/subscription","commits_url":"https://api.github.com/repos/reitermarkus/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/reitermarkus/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/reitermarkus/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/reitermarkus/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/reitermarkus/brew/contents/{+path}","compare_url":"https://api.github.com/repos/reitermarkus/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reitermarkus/brew/merges","archive_url":"https://api.github.com/repos/reitermarkus/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reitermarkus/brew/downloads","issues_url":"https://api.github.com/repos/reitermarkus/brew/issues{/number}","pulls_url":"https://api.github.com/repos/reitermarkus/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/reitermarkus/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/reitermarkus/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reitermarkus/brew/labels{/name}","releases_url":"https://api.github.com/repos/reitermarkus/brew/releases{/id}","deployments_url":"https://api.github.com/repos/reitermarkus/brew/deployments","created_at":"2016-07-16T00:59:33Z","updated_at":"2018-04-15T22:56:47Z","pushed_at":"2018-07-24T05:13:16Z","git_url":"git://github.com/reitermarkus/brew.git","ssh_url":"git@github.com:reitermarkus/brew.git","clone_url":"https://github.com/reitermarkus/brew.git","svn_url":"https://github.com/reitermarkus/brew","homepage":"http://brew.sh","size":24877,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"8223df081ce645e748ec724fe777580949b6f3aa","user":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"node_id":"MDEwOlJlcG9zaXRvcnk1MzIzODgxMw==","name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":"🍺 The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2018-07-24T06:10:42Z","pushed_at":"2018-07-24T05:13:18Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"https://brew.sh","size":24677,"stargazers_count":13077,"watchers_count":13077,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3017,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":3017,"open_issues":33,"watchers":13077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4541"},"html":{"href":"https://github.com/Homebrew/brew/pull/4541"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/4541"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/4541/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4541/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/4541/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/ac1fc193329033930a5d617cee8e59da62712bbd"}},"author_association":"MEMBER"}} | {
"id": 53238813,
"name": "Homebrew/brew",
"url": "https://api.github.com/repos/Homebrew/brew"
} | {
"id": 125011,
"login": "MikeMcQuaid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/125011?",
"url": "https://api.github.com/users/MikeMcQuaid"
} | {
"id": 1503512,
"login": "Homebrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1503512?",
"url": "https://api.github.com/orgs/Homebrew"
} | 2018-07-24T07:57:51 | 8008464465 | {"actor":{"display_login":"MikeMcQuaid"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/236168795","pull_request_review_id":178185063,"id":236168795,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjE2ODc5NQ==","diff_hunk":"@@ -0,0 +1,58 @@\n+class Aom < Formula\n+ desc \"Codec library for encoding and decoding AV1 video streams\"\n+ homepage \"https://aomedia.googlesource.com/aom\"\n+ url \"https://aomedia.googlesource.com/aom\", :using => :git, :tag => \"v1.0.0\", :revision => \"cb108fb20fec79291588f4925499ac4cb3e64bfd\"","path":"Formula/aom.rb","position":4,"original_position":4,"commit_id":"c36833006f082a06580ade24952c7716687f67b9","original_commit_id":"c36833006f082a06580ade24952c7716687f67b9","user":{"login":"fxcoudert","id":1980544,"node_id":"MDQ6VXNlcjE5ODA1NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1980544?v=4","gravatar_id":"","url":"https://api.github.com/users/fxcoudert","html_url":"https://github.com/fxcoudert","followers_url":"https://api.github.com/users/fxcoudert/followers","following_url":"https://api.github.com/users/fxcoudert/following{/other_user}","gists_url":"https://api.github.com/users/fxcoudert/gists{/gist_id}","starred_url":"https://api.github.com/users/fxcoudert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxcoudert/subscriptions","organizations_url":"https://api.github.com/users/fxcoudert/orgs","repos_url":"https://api.github.com/users/fxcoudert/repos","events_url":"https://api.github.com/users/fxcoudert/events{/privacy}","received_events_url":"https://api.github.com/users/fxcoudert/received_events","type":"User","site_admin":false},"body":"```\r\n==> Checking out tag v1.0.0\r\nHEAD is now at d14c5bb4f... [NORMATIVE]Allow non-identical sequence headers\r\nError: v1.0.0 tag should be cb108fb20fec79291588f4925499ac4cb3e64bfd\r\nbut is actually d14c5bb4f336ef1842046089849dee4a301fbbf0\r\n```","created_at":"2018-11-26T09:07:38Z","updated_at":"2018-11-26T09:07:42Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/34463#discussion_r236168795","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/236168795"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/34463#discussion_r236168795"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463","id":233454022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDU0MDIy","html_url":"https://github.com/Homebrew/homebrew-core/pull/34463","diff_url":"https://github.com/Homebrew/homebrew-core/pull/34463.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/34463.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/34463","number":34463,"state":"open","locked":false,"title":"aom 1.0.0 (new formula)","user":{"login":"maki-chan","id":6783670,"node_id":"MDQ6VXNlcjY3ODM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6783670?v=4","gravatar_id":"","url":"https://api.github.com/users/maki-chan","html_url":"https://github.com/maki-chan","followers_url":"https://api.github.com/users/maki-chan/followers","following_url":"https://api.github.com/users/maki-chan/following{/other_user}","gists_url":"https://api.github.com/users/maki-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/maki-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maki-chan/subscriptions","organizations_url":"https://api.github.com/users/maki-chan/orgs","repos_url":"https://api.github.com/users/maki-chan/repos","events_url":"https://api.github.com/users/maki-chan/events{/privacy}","received_events_url":"https://api.github.com/users/maki-chan/received_events","type":"User","site_admin":false},"body":"- [X] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [X] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [X] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [X] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n","created_at":"2018-11-26T06:48:53Z","updated_at":"2018-11-26T09:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"522dfb3f14347bccdedf61281a358cb6f0abb328","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/34463/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/c36833006f082a06580ade24952c7716687f67b9","head":{"label":"maki-chan:aom","ref":"aom","sha":"c36833006f082a06580ade24952c7716687f67b9","user":{"login":"maki-chan","id":6783670,"node_id":"MDQ6VXNlcjY3ODM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6783670?v=4","gravatar_id":"","url":"https://api.github.com/users/maki-chan","html_url":"https://github.com/maki-chan","followers_url":"https://api.github.com/users/maki-chan/followers","following_url":"https://api.github.com/users/maki-chan/following{/other_user}","gists_url":"https://api.github.com/users/maki-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/maki-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maki-chan/subscriptions","organizations_url":"https://api.github.com/users/maki-chan/orgs","repos_url":"https://api.github.com/users/maki-chan/repos","events_url":"https://api.github.com/users/maki-chan/events{/privacy}","received_events_url":"https://api.github.com/users/maki-chan/received_events","type":"User","site_admin":false},"repo":{"id":159109900,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxMDk5MDA=","name":"homebrew-core","full_name":"maki-chan/homebrew-core","private":false,"owner":{"login":"maki-chan","id":6783670,"node_id":"MDQ6VXNlcjY3ODM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6783670?v=4","gravatar_id":"","url":"https://api.github.com/users/maki-chan","html_url":"https://github.com/maki-chan","followers_url":"https://api.github.com/users/maki-chan/followers","following_url":"https://api.github.com/users/maki-chan/following{/other_user}","gists_url":"https://api.github.com/users/maki-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/maki-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maki-chan/subscriptions","organizations_url":"https://api.github.com/users/maki-chan/orgs","repos_url":"https://api.github.com/users/maki-chan/repos","events_url":"https://api.github.com/users/maki-chan/events{/privacy}","received_events_url":"https://api.github.com/users/maki-chan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maki-chan/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/maki-chan/homebrew-core","forks_url":"https://api.github.com/repos/maki-chan/homebrew-core/forks","keys_url":"https://api.github.com/repos/maki-chan/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maki-chan/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maki-chan/homebrew-core/teams","hooks_url":"https://api.github.com/repos/maki-chan/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/maki-chan/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/maki-chan/homebrew-core/events","assignees_url":"https://api.github.com/repos/maki-chan/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/maki-chan/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/maki-chan/homebrew-core/tags","blobs_url":"https://api.github.com/repos/maki-chan/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maki-chan/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maki-chan/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/maki-chan/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maki-chan/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/maki-chan/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/maki-chan/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/maki-chan/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/maki-chan/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/maki-chan/homebrew-core/subscription","commits_url":"https://api.github.com/repos/maki-chan/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/maki-chan/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/maki-chan/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/maki-chan/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/maki-chan/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/maki-chan/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maki-chan/homebrew-core/merges","archive_url":"https://api.github.com/repos/maki-chan/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maki-chan/homebrew-core/downloads","issues_url":"https://api.github.com/repos/maki-chan/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/maki-chan/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/maki-chan/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/maki-chan/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maki-chan/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/maki-chan/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/maki-chan/homebrew-core/deployments","created_at":"2018-11-26T04:18:45Z","updated_at":"2018-11-26T04:19:26Z","pushed_at":"2018-11-26T06:47:27Z","git_url":"git://github.com/maki-chan/homebrew-core.git","ssh_url":"git@github.com:maki-chan/homebrew-core.git","clone_url":"https://github.com/maki-chan/homebrew-core.git","svn_url":"https://github.com/maki-chan/homebrew-core","homepage":"https://brew.sh","size":217437,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"a94389162abdf0efed6700718e7466ae56ddbfa3","user":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg1NTUxNg==","name":"homebrew-core","full_name":"Homebrew/homebrew-core","private":false,"owner":{"login":"Homebrew","id":1503512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDM1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2018-11-26T09:02:17Z","pushed_at":"2018-11-26T09:01:41Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":217435,"stargazers_count":4747,"watchers_count":4747,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5331,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":5331,"open_issues":168,"watchers":4747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/34463"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/34463"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/34463/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/34463/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/c36833006f082a06580ade24952c7716687f67b9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52855516,
"name": "Homebrew/homebrew-core",
"url": "https://api.github.com/repos/Homebrew/homebrew-core"
} | {
"id": 1980544,
"login": "fxcoudert",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1980544?",
"url": "https://api.github.com/users/fxcoudert"
} | {
"id": 1503512,
"login": "Homebrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1503512?",
"url": "https://api.github.com/orgs/Homebrew"
} | 2018-11-26T09:07:38 | 8645684807 | {"actor":{"display_login":"fxcoudert"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ocf/ocfweb/pulls/comments/165624295","pull_request_review_id":93595653,"id":165624295,"diff_hunk":"@@ -12,7 +12,7 @@\n from ocfweb.component.lab_status import get_lab_status\n \n \n-@periodic(60, ttl=86400)\n+@periodic(60)","path":"ocfweb/main/home.py","position":5,"original_position":5,"commit_id":"bd1d7896e966e8e9fab594c4a657dd61ccdde7c7","original_commit_id":"bd1d7896e966e8e9fab594c4a657dd61ccdde7c7","user":{"login":"abizer","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/abizer","html_url":"https://github.com/abizer","followers_url":"https://api.github.com/users/abizer/followers","following_url":"https://api.github.com/users/abizer/following{/other_user}","gists_url":"https://api.github.com/users/abizer/gists{/gist_id}","starred_url":"https://api.github.com/users/abizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abizer/subscriptions","organizations_url":"https://api.github.com/users/abizer/orgs","repos_url":"https://api.github.com/users/abizer/repos","events_url":"https://api.github.com/users/abizer/events{/privacy}","received_events_url":"https://api.github.com/users/abizer/received_events","type":"User","site_admin":false},"body":"you'll want to keep the ttl","created_at":"2018-02-02T11:41:47Z","updated_at":"2018-02-02T11:49:09Z","html_url":"https://github.com/ocf/ocfweb/pull/364#discussion_r165624295","pull_request_url":"https://api.github.com/repos/ocf/ocfweb/pulls/364","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/comments/165624295"},"html":{"href":"https://github.com/ocf/ocfweb/pull/364#discussion_r165624295"},"pull_request":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/ocf/ocfweb/pulls/364","id":160010688,"html_url":"https://github.com/ocf/ocfweb/pull/364","diff_url":"https://github.com/ocf/ocfweb/pull/364.diff","patch_url":"https://github.com/ocf/ocfweb/pull/364.patch","issue_url":"https://api.github.com/repos/ocf/ocfweb/issues/364","number":364,"state":"open","locked":false,"title":"changes staff hours and adds git hub issue 349","user":{"login":"vaibhavjayaraman","id":26752388,"avatar_url":"https://avatars2.githubusercontent.com/u/26752388?v=4","gravatar_id":"","url":"https://api.github.com/users/vaibhavjayaraman","html_url":"https://github.com/vaibhavjayaraman","followers_url":"https://api.github.com/users/vaibhavjayaraman/followers","following_url":"https://api.github.com/users/vaibhavjayaraman/following{/other_user}","gists_url":"https://api.github.com/users/vaibhavjayaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/vaibhavjayaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaibhavjayaraman/subscriptions","organizations_url":"https://api.github.com/users/vaibhavjayaraman/orgs","repos_url":"https://api.github.com/users/vaibhavjayaraman/repos","events_url":"https://api.github.com/users/vaibhavjayaraman/events{/privacy}","received_events_url":"https://api.github.com/users/vaibhavjayaraman/received_events","type":"User","site_admin":false},"body":"splits up staff hours into groups based off days first and then splits by hours. \r\nAdds the reason for why staff hours are cancelled if because of holidays. ","created_at":"2017-12-24T21:07:00Z","updated_at":"2018-02-02T11:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f21e3d5176d02b16c077c1f1d3c675ee3d8c8a56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocf/ocfweb/pulls/364/commits","review_comments_url":"https://api.github.com/repos/ocf/ocfweb/pulls/364/comments","review_comment_url":"https://api.github.com/repos/ocf/ocfweb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocf/ocfweb/issues/364/comments","statuses_url":"https://api.github.com/repos/ocf/ocfweb/statuses/bd1d7896e966e8e9fab594c4a657dd61ccdde7c7","head":{"label":"vaibhavjayaraman:master","ref":"master","sha":"bd1d7896e966e8e9fab594c4a657dd61ccdde7c7","user":{"login":"vaibhavjayaraman","id":26752388,"avatar_url":"https://avatars2.githubusercontent.com/u/26752388?v=4","gravatar_id":"","url":"https://api.github.com/users/vaibhavjayaraman","html_url":"https://github.com/vaibhavjayaraman","followers_url":"https://api.github.com/users/vaibhavjayaraman/followers","following_url":"https://api.github.com/users/vaibhavjayaraman/following{/other_user}","gists_url":"https://api.github.com/users/vaibhavjayaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/vaibhavjayaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaibhavjayaraman/subscriptions","organizations_url":"https://api.github.com/users/vaibhavjayaraman/orgs","repos_url":"https://api.github.com/users/vaibhavjayaraman/repos","events_url":"https://api.github.com/users/vaibhavjayaraman/events{/privacy}","received_events_url":"https://api.github.com/users/vaibhavjayaraman/received_events","type":"User","site_admin":false},"repo":{"id":105482459,"name":"ocfweb","full_name":"vaibhavjayaraman/ocfweb","owner":{"login":"vaibhavjayaraman","id":26752388,"avatar_url":"https://avatars2.githubusercontent.com/u/26752388?v=4","gravatar_id":"","url":"https://api.github.com/users/vaibhavjayaraman","html_url":"https://github.com/vaibhavjayaraman","followers_url":"https://api.github.com/users/vaibhavjayaraman/followers","following_url":"https://api.github.com/users/vaibhavjayaraman/following{/other_user}","gists_url":"https://api.github.com/users/vaibhavjayaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/vaibhavjayaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaibhavjayaraman/subscriptions","organizations_url":"https://api.github.com/users/vaibhavjayaraman/orgs","repos_url":"https://api.github.com/users/vaibhavjayaraman/repos","events_url":"https://api.github.com/users/vaibhavjayaraman/events{/privacy}","received_events_url":"https://api.github.com/users/vaibhavjayaraman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vaibhavjayaraman/ocfweb","description":"The main ocf website","fork":true,"url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb","forks_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/forks","keys_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/teams","hooks_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/hooks","issue_events_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/issues/events{/number}","events_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/events","assignees_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/assignees{/user}","branches_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/branches{/branch}","tags_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/tags","blobs_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/statuses/{sha}","languages_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/languages","stargazers_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/stargazers","contributors_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/contributors","subscribers_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/subscribers","subscription_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/subscription","commits_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/contents/{+path}","compare_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/merges","archive_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/downloads","issues_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/issues{/number}","pulls_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/pulls{/number}","milestones_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/milestones{/number}","notifications_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/labels{/name}","releases_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/releases{/id}","deployments_url":"https://api.github.com/repos/vaibhavjayaraman/ocfweb/deployments","created_at":"2017-10-01T23:37:37Z","updated_at":"2017-10-01T23:37:39Z","pushed_at":"2018-02-01T22:39:17Z","git_url":"git://github.com/vaibhavjayaraman/ocfweb.git","ssh_url":"git@github.com:vaibhavjayaraman/ocfweb.git","clone_url":"https://github.com/vaibhavjayaraman/ocfweb.git","svn_url":"https://github.com/vaibhavjayaraman/ocfweb","homepage":"https://www.ocf.berkeley.edu","size":3144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocf:master","ref":"master","sha":"8dbdd374bfd14e2a5346ba1975789c1154a42687","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":41186799,"name":"ocfweb","full_name":"ocf/ocfweb","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/ocfweb","description":"The main ocf website","fork":false,"url":"https://api.github.com/repos/ocf/ocfweb","forks_url":"https://api.github.com/repos/ocf/ocfweb/forks","keys_url":"https://api.github.com/repos/ocf/ocfweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/ocfweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/ocfweb/teams","hooks_url":"https://api.github.com/repos/ocf/ocfweb/hooks","issue_events_url":"https://api.github.com/repos/ocf/ocfweb/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/ocfweb/events","assignees_url":"https://api.github.com/repos/ocf/ocfweb/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/ocfweb/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/ocfweb/tags","blobs_url":"https://api.github.com/repos/ocf/ocfweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/ocfweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/ocfweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/ocfweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/ocfweb/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/ocfweb/languages","stargazers_url":"https://api.github.com/repos/ocf/ocfweb/stargazers","contributors_url":"https://api.github.com/repos/ocf/ocfweb/contributors","subscribers_url":"https://api.github.com/repos/ocf/ocfweb/subscribers","subscription_url":"https://api.github.com/repos/ocf/ocfweb/subscription","commits_url":"https://api.github.com/repos/ocf/ocfweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/ocfweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/ocfweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/ocfweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/ocfweb/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/ocfweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/ocfweb/merges","archive_url":"https://api.github.com/repos/ocf/ocfweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/ocfweb/downloads","issues_url":"https://api.github.com/repos/ocf/ocfweb/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/ocfweb/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/ocfweb/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/ocfweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/ocfweb/labels{/name}","releases_url":"https://api.github.com/repos/ocf/ocfweb/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/ocfweb/deployments","created_at":"2015-08-22T02:43:14Z","updated_at":"2018-01-30T23:54:55Z","pushed_at":"2018-02-02T03:27:46Z","git_url":"git://github.com/ocf/ocfweb.git","ssh_url":"git@github.com:ocf/ocfweb.git","clone_url":"https://github.com/ocf/ocfweb.git","svn_url":"https://github.com/ocf/ocfweb","homepage":"https://www.ocf.berkeley.edu","size":3373,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":32,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/364"},"html":{"href":"https://github.com/ocf/ocfweb/pull/364"},"issue":{"href":"https://api.github.com/repos/ocf/ocfweb/issues/364"},"comments":{"href":"https://api.github.com/repos/ocf/ocfweb/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/ocf/ocfweb/statuses/bd1d7896e966e8e9fab594c4a657dd61ccdde7c7"}},"author_association":"NONE"}} | {
"id": 41186799,
"name": "ocf/ocfweb",
"url": "https://api.github.com/repos/ocf/ocfweb"
} | {
"id": 1916822,
"login": "abizer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1916822?",
"url": "https://api.github.com/users/abizer"
} | {
"id": 1504667,
"login": "ocf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1504667?",
"url": "https://api.github.com/orgs/ocf"
} | 2018-02-02T11:41:47 | 7188875972 | {"actor":{"display_login":"abizer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/170709407","pull_request_review_id":99436824,"id":170709407,"diff_hunk":"@@ -367,7 +367,7 @@ def get_hosts(self, pattern=\"all\", ignore_limits=False, ignore_restrictions=Fals\n from random import shuffle\n shuffle(hosts)\n elif order not in [None, 'inventory']:\n- AnsibleOptionsError(\"Invalid 'order' specified for inventory hosts: %s\" % order)\n+ raise AnsibleError(\"Invalid 'order' specified for inventory hosts: %s\" % order)","path":"lib/ansible/inventory/manager.py","position":null,"original_position":14,"commit_id":"560fa094c42e66ee25b834a0fdf4f9a1e386892a","original_commit_id":"7fc34160a22bcf7f582656a1b732aad4e6546b09","user":{"login":"bcoca","id":836171,"avatar_url":"https://avatars1.githubusercontent.com/u/836171?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"body":"I might have been using 'options' to mean more than CLI options .. this might be better classified as a ParserError? or do we need a KeywordError?","created_at":"2018-02-26T19:34:46Z","updated_at":"2018-02-26T19:34:46Z","html_url":"https://github.com/ansible/ansible/pull/36650#discussion_r170709407","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/36650","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/170709407"},"html":{"href":"https://github.com/ansible/ansible/pull/36650#discussion_r170709407"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36650"}},"in_reply_to_id":170354326},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36650","id":171085684,"html_url":"https://github.com/ansible/ansible/pull/36650","diff_url":"https://github.com/ansible/ansible/pull/36650.diff","patch_url":"https://github.com/ansible/ansible/pull/36650.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36650","number":36650,"state":"open","locked":false,"title":"[WIP] raise error if an invalid hosts order is provided - fixes #36582","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars2.githubusercontent.com/u/19572925?v=4","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nAn exception was there but wasn't being raised if an invalid host order was provided. ~Since AnsibleOptionsError doesn't output anything mentioning order, raised an AnsibleError instead.~ Raising AnsibleOptionsError but adding the permitted values to the message since there is no CLI flag. Fixes #36582\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/inventory/manager.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.6.0\r\n```","created_at":"2018-02-23T18:35:40Z","updated_at":"2018-02-26T19:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1ffddec0fa1ce79e2c6ff5e513772194d5cd4b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":529643857,"url":"https://api.github.com/repos/ansible/ansible/labels/WIP","name":"WIP","color":"fef2c0","default":false},{"id":48276098,"url":"https://api.github.com/repos/ansible/ansible/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270","default":false},{"id":612318497,"url":"https://api.github.com/repos/ansible/ansible/labels/inventory","name":"inventory","color":"1d76db","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/36650/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/36650/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36650/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/560fa094c42e66ee25b834a0fdf4f9a1e386892a","head":{"label":"s-hertel:raise_exception_for_bad_order","ref":"raise_exception_for_bad_order","sha":"560fa094c42e66ee25b834a0fdf4f9a1e386892a","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars2.githubusercontent.com/u/19572925?v=4","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"repo":{"id":60099782,"name":"ansible","full_name":"s-hertel/ansible","owner":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars2.githubusercontent.com/u/19572925?v=4","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-hertel/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/s-hertel/ansible","forks_url":"https://api.github.com/repos/s-hertel/ansible/forks","keys_url":"https://api.github.com/repos/s-hertel/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-hertel/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-hertel/ansible/teams","hooks_url":"https://api.github.com/repos/s-hertel/ansible/hooks","issue_events_url":"https://api.github.com/repos/s-hertel/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/s-hertel/ansible/events","assignees_url":"https://api.github.com/repos/s-hertel/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/s-hertel/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/s-hertel/ansible/tags","blobs_url":"https://api.github.com/repos/s-hertel/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-hertel/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-hertel/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-hertel/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-hertel/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/s-hertel/ansible/languages","stargazers_url":"https://api.github.com/repos/s-hertel/ansible/stargazers","contributors_url":"https://api.github.com/repos/s-hertel/ansible/contributors","subscribers_url":"https://api.github.com/repos/s-hertel/ansible/subscribers","subscription_url":"https://api.github.com/repos/s-hertel/ansible/subscription","commits_url":"https://api.github.com/repos/s-hertel/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-hertel/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-hertel/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-hertel/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-hertel/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/s-hertel/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-hertel/ansible/merges","archive_url":"https://api.github.com/repos/s-hertel/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-hertel/ansible/downloads","issues_url":"https://api.github.com/repos/s-hertel/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/s-hertel/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/s-hertel/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/s-hertel/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-hertel/ansible/labels{/name}","releases_url":"https://api.github.com/repos/s-hertel/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/s-hertel/ansible/deployments","created_at":"2016-05-31T15:07:40Z","updated_at":"2017-04-21T13:44:13Z","pushed_at":"2018-02-26T19:18:46Z","git_url":"git://github.com/s-hertel/ansible.git","ssh_url":"git@github.com:s-hertel/ansible.git","clone_url":"https://github.com/s-hertel/ansible.git","svn_url":"https://github.com/s-hertel/ansible","homepage":"http://ansible.com/","size":110527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"ff0f6286d73f72bc4e284fa21269bb72ac16611b","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-02-26T15:15:47Z","pushed_at":"2018-02-26T19:32:22Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":119978,"stargazers_count":28644,"watchers_count":28644,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10339,"mirror_url":null,"archived":false,"open_issues_count":4801,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10339,"open_issues":4801,"watchers":28644,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36650"},"html":{"href":"https://github.com/ansible/ansible/pull/36650"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/36650"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/36650/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36650/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36650/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/560fa094c42e66ee25b834a0fdf4f9a1e386892a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3638964,
"name": "ansible/ansible",
"url": "https://api.github.com/repos/ansible/ansible"
} | {
"id": 836171,
"login": "bcoca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/836171?",
"url": "https://api.github.com/users/bcoca"
} | {
"id": 1507452,
"login": "ansible",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1507452?",
"url": "https://api.github.com/orgs/ansible"
} | 2018-02-26T19:34:46 | 7299268140 | {"actor":{"display_login":"bcoca"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/236511661","pull_request_review_id":178601050,"id":236511661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUxMTY2MQ==","diff_hunk":"@@ -24,67 +24,68 @@\n options:\n state:\n description:\n- - Create or destroy the ELB\n+ - Create or destroy the ELB.\n choices: [\"present\", \"absent\"]\n required: true\n name:\n description:\n- - The name of the ELB\n+ - The name of the ELB.\n required: true\n listeners:\n description:\n- - List of ports/protocols for this ELB to listen on (see example)\n+ - List of ports/protocols for this ELB to listen on (see example).\n required: false\n purge_listeners:\n description:\n- - Purge existing listeners on ELB that are not found in listeners\n+ - Purge existing listeners on ELB that are not found in listeners.\n type: bool\n default: 'yes'\n instance_ids:\n description:\n- - List of instance ids to attach to this ELB\n+ - List of instance ids to attach to this ELB.\n type: bool\n default: 'no'","path":"lib/ansible/modules/cloud/amazon/ec2_elb_lb.py","position":null,"original_position":29,"commit_id":"e90d732968310175d493caa8c096e76046a5e75d","original_commit_id":"c14c9c65392ef8264cf361d2592af3845888ad5f","user":{"login":"Akasurde","id":633765,"node_id":"MDQ6VXNlcjYzMzc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"Type `bool` handles both Booleans and String booleans.","created_at":"2018-11-27T03:49:43Z","updated_at":"2018-11-27T03:49:43Z","html_url":"https://github.com/ansible/ansible/pull/49136#discussion_r236511661","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/49136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/236511661"},"html":{"href":"https://github.com/ansible/ansible/pull/49136#discussion_r236511661"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49136"}},"in_reply_to_id":236467004},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49136","id":233624471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjI0NDcx","html_url":"https://github.com/ansible/ansible/pull/49136","diff_url":"https://github.com/ansible/ansible/pull/49136.diff","patch_url":"https://github.com/ansible/ansible/pull/49136.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49136","number":49136,"state":"open","locked":false,"title":"E325 removal - Part I","user":{"login":"Akasurde","id":633765,"node_id":"MDQ6VXNlcjYzMzc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nRemove E325 from Amazon modules\r\n\r\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>\r\n\r\n##### ISSUE TYPE\r\n- Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\nA bunch of them ...","created_at":"2018-11-26T16:44:08Z","updated_at":"2018-11-27T03:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52e88e30c2908364f18738a62a886a275c0eeb71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":379680333,"node_id":"MDU6TGFiZWwzNzk2ODAzMzM=","url":"https://api.github.com/repos/ansible/ansible/labels/aws","name":"aws","color":"c5def5","default":false},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":849212023,"node_id":"MDU6TGFiZWw4NDkyMTIwMjM=","url":"https://api.github.com/repos/ansible/ansible/labels/docs","name":"docs","color":"0052cc","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":468273802,"node_id":"MDU6TGFiZWw0NjgyNzM4MDI=","url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/49136/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/49136/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49136/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/e90d732968310175d493caa8c096e76046a5e75d","head":{"label":"Akasurde:e325_fix","ref":"e325_fix","sha":"e90d732968310175d493caa8c096e76046a5e75d","user":{"login":"Akasurde","id":633765,"node_id":"MDQ6VXNlcjYzMzc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"repo":{"id":87410645,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQxMDY0NQ==","name":"ansible","full_name":"Akasurde/ansible","private":false,"owner":{"login":"Akasurde","id":633765,"node_id":"MDQ6VXNlcjYzMzc2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Akasurde/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/Akasurde/ansible","forks_url":"https://api.github.com/repos/Akasurde/ansible/forks","keys_url":"https://api.github.com/repos/Akasurde/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akasurde/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akasurde/ansible/teams","hooks_url":"https://api.github.com/repos/Akasurde/ansible/hooks","issue_events_url":"https://api.github.com/repos/Akasurde/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/Akasurde/ansible/events","assignees_url":"https://api.github.com/repos/Akasurde/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/Akasurde/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/Akasurde/ansible/tags","blobs_url":"https://api.github.com/repos/Akasurde/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akasurde/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akasurde/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akasurde/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akasurde/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/Akasurde/ansible/languages","stargazers_url":"https://api.github.com/repos/Akasurde/ansible/stargazers","contributors_url":"https://api.github.com/repos/Akasurde/ansible/contributors","subscribers_url":"https://api.github.com/repos/Akasurde/ansible/subscribers","subscription_url":"https://api.github.com/repos/Akasurde/ansible/subscription","commits_url":"https://api.github.com/repos/Akasurde/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akasurde/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akasurde/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akasurde/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akasurde/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/Akasurde/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akasurde/ansible/merges","archive_url":"https://api.github.com/repos/Akasurde/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akasurde/ansible/downloads","issues_url":"https://api.github.com/repos/Akasurde/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/Akasurde/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/Akasurde/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/Akasurde/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akasurde/ansible/labels{/name}","releases_url":"https://api.github.com/repos/Akasurde/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/Akasurde/ansible/deployments","created_at":"2017-04-06T09:20:07Z","updated_at":"2018-11-26T09:12:59Z","pushed_at":"2018-11-27T03:48:37Z","git_url":"git://github.com/Akasurde/ansible.git","ssh_url":"git@github.com:Akasurde/ansible.git","clone_url":"https://github.com/Akasurde/ansible.git","svn_url":"https://github.com/Akasurde/ansible","homepage":"http://ansible.com/","size":142377,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":2,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"6f29eafef4d8fc49645d2382c444e9416f8ab38d","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-11-27T02:49:00Z","pushed_at":"2018-11-27T03:49:13Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":145934,"stargazers_count":33946,"watchers_count":33946,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13583,"mirror_url":null,"archived":false,"open_issues_count":5623,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13583,"open_issues":5623,"watchers":33946,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49136"},"html":{"href":"https://github.com/ansible/ansible/pull/49136"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/49136"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/49136/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49136/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/49136/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/e90d732968310175d493caa8c096e76046a5e75d"}},"author_association":"MEMBER"}} | {
"id": 3638964,
"name": "ansible/ansible",
"url": "https://api.github.com/repos/ansible/ansible"
} | {
"id": 633765,
"login": "Akasurde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/633765?",
"url": "https://api.github.com/users/Akasurde"
} | {
"id": 1507452,
"login": "ansible",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1507452?",
"url": "https://api.github.com/orgs/ansible"
} | 2018-11-27T03:49:43 | 8651570620 | {"actor":{"display_login":"Akasurde"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/latera/activiti-ext/pulls/comments/188195486","pull_request_review_id":120121558,"id":188195486,"diff_hunk":"@@ -1,50 +1,42 @@\n package org.activiti.latera.bss.eventListeners\n+import org.activiti.engine.delegate.DelegateExecution\n \n import org.activiti.latera.bss.eventListeners.AbstractListener\n import org.activiti.engine.delegate.event.*\n import org.activiti.engine.delegate.event.impl.*\n \n+import org.slf4j.LoggerFactory\n+\n public class EventLogging extends AbstractListener {\n- def protected execute() {\n+ def protected execute(DelegateExecution execution, ActivitiEvent event) {\n+\n def logStr = \"Occured ${event.getType()} event\"\n \n- def detailedLogStr = getDetailedLog()\n+ def detailedLogStr = getDetailedLog(event)\n if (detailedLogStr) {\n logStr = \"${logStr}: ${detailedLogStr}\"\n }\n \n- log logStr\n+ log(logStr, 'debug', execution)\n }\n \n- def private getDetailedLog() {\n+ def private getDetailedLog(ActivitiEvent event) {\n def detailedLog = null\n \n switch (event) {\n case ActivitiActivityEventImpl:\n- detailedLog = getActivityLog()\n+ detailedLog = \"${event.getActivityId()} (${event.getActivityType()} - ${event.getActivityName()})\"","path":"src/bss/eventListeners/event_logging.groovy","position":33,"original_position":33,"commit_id":"1fa23d024e2d29be2edd9f1fde8950af643aefec","original_commit_id":"1fa23d024e2d29be2edd9f1fde8950af643aefec","user":{"login":"eugenweissbart","id":2291757,"avatar_url":"https://avatars3.githubusercontent.com/u/2291757?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenweissbart","html_url":"https://github.com/eugenweissbart","followers_url":"https://api.github.com/users/eugenweissbart/followers","following_url":"https://api.github.com/users/eugenweissbart/following{/other_user}","gists_url":"https://api.github.com/users/eugenweissbart/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenweissbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenweissbart/subscriptions","organizations_url":"https://api.github.com/users/eugenweissbart/orgs","repos_url":"https://api.github.com/users/eugenweissbart/repos","events_url":"https://api.github.com/users/eugenweissbart/events{/privacy}","received_events_url":"https://api.github.com/users/eugenweissbart/received_events","type":"User","site_admin":false},"body":"I don't find them much necessary as they just return a single string","created_at":"2018-05-15T07:59:26Z","updated_at":"2018-05-15T07:59:26Z","html_url":"https://github.com/latera/activiti-ext/pull/2#discussion_r188195486","pull_request_url":"https://api.github.com/repos/latera/activiti-ext/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/comments/188195486"},"html":{"href":"https://github.com/latera/activiti-ext/pull/2#discussion_r188195486"},"pull_request":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/2"}},"in_reply_to_id":187972288},"pull_request":{"url":"https://api.github.com/repos/latera/activiti-ext/pulls/2","id":187819169,"html_url":"https://github.com/latera/activiti-ext/pull/2","diff_url":"https://github.com/latera/activiti-ext/pull/2.diff","patch_url":"https://github.com/latera/activiti-ext/pull/2.patch","issue_url":"https://api.github.com/repos/latera/activiti-ext/issues/2","number":2,"state":"open","locked":false,"title":"[CONSULT-1524] changed execution from member to method parameter","user":{"login":"eugenweissbart","id":2291757,"avatar_url":"https://avatars3.githubusercontent.com/u/2291757?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenweissbart","html_url":"https://github.com/eugenweissbart","followers_url":"https://api.github.com/users/eugenweissbart/followers","following_url":"https://api.github.com/users/eugenweissbart/following{/other_user}","gists_url":"https://api.github.com/users/eugenweissbart/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenweissbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenweissbart/subscriptions","organizations_url":"https://api.github.com/users/eugenweissbart/orgs","repos_url":"https://api.github.com/users/eugenweissbart/repos","events_url":"https://api.github.com/users/eugenweissbart/events{/privacy}","received_events_url":"https://api.github.com/users/eugenweissbart/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-14T13:00:26Z","updated_at":"2018-05-15T07:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d28ffb3bfc803fbd672e3e653c3196c88a68d610","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/latera/activiti-ext/pulls/2/commits","review_comments_url":"https://api.github.com/repos/latera/activiti-ext/pulls/2/comments","review_comment_url":"https://api.github.com/repos/latera/activiti-ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/latera/activiti-ext/issues/2/comments","statuses_url":"https://api.github.com/repos/latera/activiti-ext/statuses/1fa23d024e2d29be2edd9f1fde8950af643aefec","head":{"label":"eugenweissbart:no_member_variables","ref":"no_member_variables","sha":"1fa23d024e2d29be2edd9f1fde8950af643aefec","user":{"login":"eugenweissbart","id":2291757,"avatar_url":"https://avatars3.githubusercontent.com/u/2291757?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenweissbart","html_url":"https://github.com/eugenweissbart","followers_url":"https://api.github.com/users/eugenweissbart/followers","following_url":"https://api.github.com/users/eugenweissbart/following{/other_user}","gists_url":"https://api.github.com/users/eugenweissbart/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenweissbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenweissbart/subscriptions","organizations_url":"https://api.github.com/users/eugenweissbart/orgs","repos_url":"https://api.github.com/users/eugenweissbart/repos","events_url":"https://api.github.com/users/eugenweissbart/events{/privacy}","received_events_url":"https://api.github.com/users/eugenweissbart/received_events","type":"User","site_admin":false},"repo":{"id":115400747,"name":"activiti-ext","full_name":"eugenweissbart/activiti-ext","owner":{"login":"eugenweissbart","id":2291757,"avatar_url":"https://avatars3.githubusercontent.com/u/2291757?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenweissbart","html_url":"https://github.com/eugenweissbart","followers_url":"https://api.github.com/users/eugenweissbart/followers","following_url":"https://api.github.com/users/eugenweissbart/following{/other_user}","gists_url":"https://api.github.com/users/eugenweissbart/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenweissbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenweissbart/subscriptions","organizations_url":"https://api.github.com/users/eugenweissbart/orgs","repos_url":"https://api.github.com/users/eugenweissbart/repos","events_url":"https://api.github.com/users/eugenweissbart/events{/privacy}","received_events_url":"https://api.github.com/users/eugenweissbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eugenweissbart/activiti-ext","description":"Latera Activiti extension","fork":true,"url":"https://api.github.com/repos/eugenweissbart/activiti-ext","forks_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/forks","keys_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/teams","hooks_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/hooks","issue_events_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/issues/events{/number}","events_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/events","assignees_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/assignees{/user}","branches_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/branches{/branch}","tags_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/tags","blobs_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/languages","stargazers_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/stargazers","contributors_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/contributors","subscribers_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/subscribers","subscription_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/subscription","commits_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/contents/{+path}","compare_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/merges","archive_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/downloads","issues_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/issues{/number}","pulls_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/labels{/name}","releases_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/releases{/id}","deployments_url":"https://api.github.com/repos/eugenweissbart/activiti-ext/deployments","created_at":"2017-12-26T08:06:01Z","updated_at":"2017-12-26T08:06:03Z","pushed_at":"2018-05-14T12:57:41Z","git_url":"git://github.com/eugenweissbart/activiti-ext.git","ssh_url":"git@github.com:eugenweissbart/activiti-ext.git","clone_url":"https://github.com/eugenweissbart/activiti-ext.git","svn_url":"https://github.com/eugenweissbart/activiti-ext","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"latera:master","ref":"master","sha":"7ad3a716214e99ccff8b67eceb8ad55166200a2c","user":{"login":"latera","id":1512462,"avatar_url":"https://avatars3.githubusercontent.com/u/1512462?v=4","gravatar_id":"","url":"https://api.github.com/users/latera","html_url":"https://github.com/latera","followers_url":"https://api.github.com/users/latera/followers","following_url":"https://api.github.com/users/latera/following{/other_user}","gists_url":"https://api.github.com/users/latera/gists{/gist_id}","starred_url":"https://api.github.com/users/latera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latera/subscriptions","organizations_url":"https://api.github.com/users/latera/orgs","repos_url":"https://api.github.com/users/latera/repos","events_url":"https://api.github.com/users/latera/events{/privacy}","received_events_url":"https://api.github.com/users/latera/received_events","type":"Organization","site_admin":false},"repo":{"id":57125387,"name":"activiti-ext","full_name":"latera/activiti-ext","owner":{"login":"latera","id":1512462,"avatar_url":"https://avatars3.githubusercontent.com/u/1512462?v=4","gravatar_id":"","url":"https://api.github.com/users/latera","html_url":"https://github.com/latera","followers_url":"https://api.github.com/users/latera/followers","following_url":"https://api.github.com/users/latera/following{/other_user}","gists_url":"https://api.github.com/users/latera/gists{/gist_id}","starred_url":"https://api.github.com/users/latera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latera/subscriptions","organizations_url":"https://api.github.com/users/latera/orgs","repos_url":"https://api.github.com/users/latera/repos","events_url":"https://api.github.com/users/latera/events{/privacy}","received_events_url":"https://api.github.com/users/latera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/latera/activiti-ext","description":"Latera Activiti extension","fork":false,"url":"https://api.github.com/repos/latera/activiti-ext","forks_url":"https://api.github.com/repos/latera/activiti-ext/forks","keys_url":"https://api.github.com/repos/latera/activiti-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latera/activiti-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latera/activiti-ext/teams","hooks_url":"https://api.github.com/repos/latera/activiti-ext/hooks","issue_events_url":"https://api.github.com/repos/latera/activiti-ext/issues/events{/number}","events_url":"https://api.github.com/repos/latera/activiti-ext/events","assignees_url":"https://api.github.com/repos/latera/activiti-ext/assignees{/user}","branches_url":"https://api.github.com/repos/latera/activiti-ext/branches{/branch}","tags_url":"https://api.github.com/repos/latera/activiti-ext/tags","blobs_url":"https://api.github.com/repos/latera/activiti-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latera/activiti-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latera/activiti-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/latera/activiti-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latera/activiti-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/latera/activiti-ext/languages","stargazers_url":"https://api.github.com/repos/latera/activiti-ext/stargazers","contributors_url":"https://api.github.com/repos/latera/activiti-ext/contributors","subscribers_url":"https://api.github.com/repos/latera/activiti-ext/subscribers","subscription_url":"https://api.github.com/repos/latera/activiti-ext/subscription","commits_url":"https://api.github.com/repos/latera/activiti-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/latera/activiti-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/latera/activiti-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/latera/activiti-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/latera/activiti-ext/contents/{+path}","compare_url":"https://api.github.com/repos/latera/activiti-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latera/activiti-ext/merges","archive_url":"https://api.github.com/repos/latera/activiti-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latera/activiti-ext/downloads","issues_url":"https://api.github.com/repos/latera/activiti-ext/issues{/number}","pulls_url":"https://api.github.com/repos/latera/activiti-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/latera/activiti-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/latera/activiti-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latera/activiti-ext/labels{/name}","releases_url":"https://api.github.com/repos/latera/activiti-ext/releases{/id}","deployments_url":"https://api.github.com/repos/latera/activiti-ext/deployments","created_at":"2016-04-26T12:12:39Z","updated_at":"2016-04-27T14:13:59Z","pushed_at":"2018-05-14T13:00:27Z","git_url":"git://github.com/latera/activiti-ext.git","ssh_url":"git@github.com:latera/activiti-ext.git","clone_url":"https://github.com/latera/activiti-ext.git","svn_url":"https://github.com/latera/activiti-ext","homepage":null,"size":10,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/2"},"html":{"href":"https://github.com/latera/activiti-ext/pull/2"},"issue":{"href":"https://api.github.com/repos/latera/activiti-ext/issues/2"},"comments":{"href":"https://api.github.com/repos/latera/activiti-ext/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/latera/activiti-ext/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/latera/activiti-ext/statuses/1fa23d024e2d29be2edd9f1fde8950af643aefec"}},"author_association":"NONE"}} | {
"id": 57125387,
"name": "latera/activiti-ext",
"url": "https://api.github.com/repos/latera/activiti-ext"
} | {
"id": 2291757,
"login": "eugenweissbart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2291757?",
"url": "https://api.github.com/users/eugenweissbart"
} | {
"id": 1512462,
"login": "latera",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1512462?",
"url": "https://api.github.com/orgs/latera"
} | 2018-05-15T07:59:26 | 7675224648 | {"actor":{"display_login":"eugenweissbart"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments/173731930","pull_request_review_id":102967097,"id":173731930,"diff_hunk":"@@ -3110,3 +3110,4 @@ libwayland-egl++.so.0.2 libwaylandpp-2.2.0_1\n libwayland-client++.so.0.2 libwaylandpp-2.2.0_1\n libwayland-cursor++.so.0.2 libwaylandpp-2.2.0_1\n libwayland-client-extra++.so.0.2 libwaylandpp-2.2.0_1\n+libdeviceclient.so.0 pragha-1.3.3_1","path":"common/shlibs","position":4,"original_position":4,"commit_id":"d895f61e6ff31ae5f7c005f65f079f257e85cf00","original_commit_id":"d895f61e6ff31ae5f7c005f65f079f257e85cf00","user":{"login":"VargMon","id":7844568,"avatar_url":"https://avatars1.githubusercontent.com/u/7844568?v=4","gravatar_id":"","url":"https://api.github.com/users/VargMon","html_url":"https://github.com/VargMon","followers_url":"https://api.github.com/users/VargMon/followers","following_url":"https://api.github.com/users/VargMon/following{/other_user}","gists_url":"https://api.github.com/users/VargMon/gists{/gist_id}","starred_url":"https://api.github.com/users/VargMon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VargMon/subscriptions","organizations_url":"https://api.github.com/users/VargMon/orgs","repos_url":"https://api.github.com/users/VargMon/repos","events_url":"https://api.github.com/users/VargMon/events{/privacy}","received_events_url":"https://api.github.com/users/VargMon/received_events","type":"User","site_admin":false},"body":"I was unable to cross compile to i686 without adding to `shlibs` I'm supposing that this _could_ be related to the autotools bug. Please, if I may ask, for a possible solution to properly fix this, or some suggestions (should I add a devel subpackage??)","created_at":"2018-03-12T09:24:35Z","updated_at":"2018-03-12T09:24:35Z","html_url":"https://github.com/voidlinux/void-packages/pull/12418#discussion_r173731930","pull_request_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments/173731930"},"html":{"href":"https://github.com/voidlinux/void-packages/pull/12418#discussion_r173731930"},"pull_request":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418"}},"in_reply_to_id":173716822},"pull_request":{"url":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418","id":174289606,"html_url":"https://github.com/voidlinux/void-packages/pull/12418","diff_url":"https://github.com/voidlinux/void-packages/pull/12418.diff","patch_url":"https://github.com/voidlinux/void-packages/pull/12418.patch","issue_url":"https://api.github.com/repos/voidlinux/void-packages/issues/12418","number":12418,"state":"open","locked":false,"title":"New package: pragha-1.3.3","user":{"login":"VargMon","id":7844568,"avatar_url":"https://avatars1.githubusercontent.com/u/7844568?v=4","gravatar_id":"","url":"https://api.github.com/users/VargMon","html_url":"https://github.com/VargMon","followers_url":"https://api.github.com/users/VargMon/followers","following_url":"https://api.github.com/users/VargMon/following{/other_user}","gists_url":"https://api.github.com/users/VargMon/gists{/gist_id}","starred_url":"https://api.github.com/users/VargMon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VargMon/subscriptions","organizations_url":"https://api.github.com/users/VargMon/orgs","repos_url":"https://api.github.com/users/VargMon/repos","events_url":"https://api.github.com/users/VargMon/events{/privacy}","received_events_url":"https://api.github.com/users/VargMon/received_events","type":"User","site_admin":false},"body":"Tested on `x86_64`. Cross compiling to `i686` works. This is to fulfill package request: #12310 Please let me know if there's any improvements I make to the template. I didn't have to use(or apply) any patches to get this to compile properly. However, I ran into one a ./configure script bug, and did have to export one environment variable. :-)","created_at":"2018-03-12T07:26:35Z","updated_at":"2018-03-12T09:24:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbaf9f2b57d67ff2757492359d3353b5e85d7dd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418/commits","review_comments_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418/comments","review_comment_url":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voidlinux/void-packages/issues/12418/comments","statuses_url":"https://api.github.com/repos/voidlinux/void-packages/statuses/d895f61e6ff31ae5f7c005f65f079f257e85cf00","head":{"label":"VargMon:pragha-1.3.3","ref":"pragha-1.3.3","sha":"d895f61e6ff31ae5f7c005f65f079f257e85cf00","user":{"login":"VargMon","id":7844568,"avatar_url":"https://avatars1.githubusercontent.com/u/7844568?v=4","gravatar_id":"","url":"https://api.github.com/users/VargMon","html_url":"https://github.com/VargMon","followers_url":"https://api.github.com/users/VargMon/followers","following_url":"https://api.github.com/users/VargMon/following{/other_user}","gists_url":"https://api.github.com/users/VargMon/gists{/gist_id}","starred_url":"https://api.github.com/users/VargMon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VargMon/subscriptions","organizations_url":"https://api.github.com/users/VargMon/orgs","repos_url":"https://api.github.com/users/VargMon/repos","events_url":"https://api.github.com/users/VargMon/events{/privacy}","received_events_url":"https://api.github.com/users/VargMon/received_events","type":"User","site_admin":false},"repo":{"id":123547135,"name":"void-packages","full_name":"VargMon/void-packages","owner":{"login":"VargMon","id":7844568,"avatar_url":"https://avatars1.githubusercontent.com/u/7844568?v=4","gravatar_id":"","url":"https://api.github.com/users/VargMon","html_url":"https://github.com/VargMon","followers_url":"https://api.github.com/users/VargMon/followers","following_url":"https://api.github.com/users/VargMon/following{/other_user}","gists_url":"https://api.github.com/users/VargMon/gists{/gist_id}","starred_url":"https://api.github.com/users/VargMon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VargMon/subscriptions","organizations_url":"https://api.github.com/users/VargMon/orgs","repos_url":"https://api.github.com/users/VargMon/repos","events_url":"https://api.github.com/users/VargMon/events{/privacy}","received_events_url":"https://api.github.com/users/VargMon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VargMon/void-packages","description":"The XBPS source packages collection","fork":true,"url":"https://api.github.com/repos/VargMon/void-packages","forks_url":"https://api.github.com/repos/VargMon/void-packages/forks","keys_url":"https://api.github.com/repos/VargMon/void-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VargMon/void-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VargMon/void-packages/teams","hooks_url":"https://api.github.com/repos/VargMon/void-packages/hooks","issue_events_url":"https://api.github.com/repos/VargMon/void-packages/issues/events{/number}","events_url":"https://api.github.com/repos/VargMon/void-packages/events","assignees_url":"https://api.github.com/repos/VargMon/void-packages/assignees{/user}","branches_url":"https://api.github.com/repos/VargMon/void-packages/branches{/branch}","tags_url":"https://api.github.com/repos/VargMon/void-packages/tags","blobs_url":"https://api.github.com/repos/VargMon/void-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VargMon/void-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VargMon/void-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/VargMon/void-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VargMon/void-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/VargMon/void-packages/languages","stargazers_url":"https://api.github.com/repos/VargMon/void-packages/stargazers","contributors_url":"https://api.github.com/repos/VargMon/void-packages/contributors","subscribers_url":"https://api.github.com/repos/VargMon/void-packages/subscribers","subscription_url":"https://api.github.com/repos/VargMon/void-packages/subscription","commits_url":"https://api.github.com/repos/VargMon/void-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/VargMon/void-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/VargMon/void-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/VargMon/void-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/VargMon/void-packages/contents/{+path}","compare_url":"https://api.github.com/repos/VargMon/void-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VargMon/void-packages/merges","archive_url":"https://api.github.com/repos/VargMon/void-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VargMon/void-packages/downloads","issues_url":"https://api.github.com/repos/VargMon/void-packages/issues{/number}","pulls_url":"https://api.github.com/repos/VargMon/void-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/VargMon/void-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/VargMon/void-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VargMon/void-packages/labels{/name}","releases_url":"https://api.github.com/repos/VargMon/void-packages/releases{/id}","deployments_url":"https://api.github.com/repos/VargMon/void-packages/deployments","created_at":"2018-03-02T07:42:27Z","updated_at":"2018-03-04T04:01:43Z","pushed_at":"2018-03-12T07:20:22Z","git_url":"git://github.com/VargMon/void-packages.git","ssh_url":"git@github.com:VargMon/void-packages.git","clone_url":"https://github.com/VargMon/void-packages.git","svn_url":"https://github.com/VargMon/void-packages","homepage":"http://www.voidlinux.eu","size":193690,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voidlinux:master","ref":"master","sha":"3cabad0f435ef154e21ea0680189c88f68958d7c","user":{"login":"voidlinux","id":1512782,"avatar_url":"https://avatars2.githubusercontent.com/u/1512782?v=4","gravatar_id":"","url":"https://api.github.com/users/voidlinux","html_url":"https://github.com/voidlinux","followers_url":"https://api.github.com/users/voidlinux/followers","following_url":"https://api.github.com/users/voidlinux/following{/other_user}","gists_url":"https://api.github.com/users/voidlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/voidlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidlinux/subscriptions","organizations_url":"https://api.github.com/users/voidlinux/orgs","repos_url":"https://api.github.com/users/voidlinux/repos","events_url":"https://api.github.com/users/voidlinux/events{/privacy}","received_events_url":"https://api.github.com/users/voidlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":2060910,"name":"void-packages","full_name":"voidlinux/void-packages","owner":{"login":"voidlinux","id":1512782,"avatar_url":"https://avatars2.githubusercontent.com/u/1512782?v=4","gravatar_id":"","url":"https://api.github.com/users/voidlinux","html_url":"https://github.com/voidlinux","followers_url":"https://api.github.com/users/voidlinux/followers","following_url":"https://api.github.com/users/voidlinux/following{/other_user}","gists_url":"https://api.github.com/users/voidlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/voidlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidlinux/subscriptions","organizations_url":"https://api.github.com/users/voidlinux/orgs","repos_url":"https://api.github.com/users/voidlinux/repos","events_url":"https://api.github.com/users/voidlinux/events{/privacy}","received_events_url":"https://api.github.com/users/voidlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voidlinux/void-packages","description":"The XBPS source packages collection","fork":false,"url":"https://api.github.com/repos/voidlinux/void-packages","forks_url":"https://api.github.com/repos/voidlinux/void-packages/forks","keys_url":"https://api.github.com/repos/voidlinux/void-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voidlinux/void-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voidlinux/void-packages/teams","hooks_url":"https://api.github.com/repos/voidlinux/void-packages/hooks","issue_events_url":"https://api.github.com/repos/voidlinux/void-packages/issues/events{/number}","events_url":"https://api.github.com/repos/voidlinux/void-packages/events","assignees_url":"https://api.github.com/repos/voidlinux/void-packages/assignees{/user}","branches_url":"https://api.github.com/repos/voidlinux/void-packages/branches{/branch}","tags_url":"https://api.github.com/repos/voidlinux/void-packages/tags","blobs_url":"https://api.github.com/repos/voidlinux/void-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voidlinux/void-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voidlinux/void-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/voidlinux/void-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voidlinux/void-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/voidlinux/void-packages/languages","stargazers_url":"https://api.github.com/repos/voidlinux/void-packages/stargazers","contributors_url":"https://api.github.com/repos/voidlinux/void-packages/contributors","subscribers_url":"https://api.github.com/repos/voidlinux/void-packages/subscribers","subscription_url":"https://api.github.com/repos/voidlinux/void-packages/subscription","commits_url":"https://api.github.com/repos/voidlinux/void-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/voidlinux/void-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/voidlinux/void-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/voidlinux/void-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/voidlinux/void-packages/contents/{+path}","compare_url":"https://api.github.com/repos/voidlinux/void-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voidlinux/void-packages/merges","archive_url":"https://api.github.com/repos/voidlinux/void-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voidlinux/void-packages/downloads","issues_url":"https://api.github.com/repos/voidlinux/void-packages/issues{/number}","pulls_url":"https://api.github.com/repos/voidlinux/void-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/voidlinux/void-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/voidlinux/void-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voidlinux/void-packages/labels{/name}","releases_url":"https://api.github.com/repos/voidlinux/void-packages/releases{/id}","deployments_url":"https://api.github.com/repos/voidlinux/void-packages/deployments","created_at":"2011-07-17T07:26:35Z","updated_at":"2018-03-11T12:49:28Z","pushed_at":"2018-03-12T09:00:10Z","git_url":"git://github.com/voidlinux/void-packages.git","ssh_url":"git@github.com:voidlinux/void-packages.git","clone_url":"https://github.com/voidlinux/void-packages.git","svn_url":"https://github.com/voidlinux/void-packages","homepage":"http://www.voidlinux.eu","size":194342,"stargazers_count":449,"watchers_count":449,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":651,"mirror_url":null,"archived":false,"open_issues_count":860,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":651,"open_issues":860,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418"},"html":{"href":"https://github.com/voidlinux/void-packages/pull/12418"},"issue":{"href":"https://api.github.com/repos/voidlinux/void-packages/issues/12418"},"comments":{"href":"https://api.github.com/repos/voidlinux/void-packages/issues/12418/comments"},"review_comments":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418/comments"},"review_comment":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voidlinux/void-packages/pulls/12418/commits"},"statuses":{"href":"https://api.github.com/repos/voidlinux/void-packages/statuses/d895f61e6ff31ae5f7c005f65f079f257e85cf00"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2060910,
"name": "voidlinux/void-packages",
"url": "https://api.github.com/repos/voidlinux/void-packages"
} | {
"id": 7844568,
"login": "VargMon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7844568?",
"url": "https://api.github.com/users/VargMon"
} | {
"id": 1512782,
"login": "voidlinux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1512782?",
"url": "https://api.github.com/orgs/voidlinux"
} | 2018-03-12T09:24:35 | 7364447966 | {"actor":{"display_login":"VargMon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/python/mypy/pulls/comments/179885347","pull_request_review_id":110220189,"id":179885347,"diff_hunk":"@@ -0,0 +1,115 @@\n+from contextlib import contextmanager\n+import os\n+import shutil\n+import sys\n+from typing import Generator, List\n+from unittest import TestCase, main\n+\n+import mypy.api\n+from mypy.build import FindModuleCache, _get_site_packages_dirs\n+from mypy.test.config import package_path\n+from mypy.test.helpers import run_command\n+from mypy.util import try_find_python2_interpreter\n+\n+SIMPLE_PROGRAM = \"\"\"\n+from typedpkg.sample import ex\n+a = ex([''])\n+reveal_type(a)\n+\"\"\"\n+\n+\n+class TestPEP561(TestCase):\n+ @contextmanager\n+ def install_package(self, pkg: str,\n+ python_executable: str = sys.executable) -> Generator[None, None, None]:\n+ \"\"\"Context manager to temporarily install a package from test-data/packages/pkg/\"\"\"\n+ working_dir = os.path.join(package_path, pkg)\n+ install_cmd = [python_executable, '-m', 'pip', 'install', '.']\n+ # if we aren't in a virtualenv, install in the\n+ # user package directory so we don't need sudo\n+ if not hasattr(sys, 'real_prefix') or python_executable != sys.executable:\n+ install_cmd.append('--user')\n+ returncode, lines = run_command(install_cmd, cwd=working_dir)\n+ if returncode != 0:\n+ self.fail('\\n'.join(lines))\n+ try:\n+ yield\n+ finally:\n+ run_command([python_executable, '-m', 'pip', 'uninstall', '-y', pkg], cwd=package_path)\n+\n+ def test_get_pkg_dirs(self) -> None:\n+ \"\"\"Check that get_package_dirs works.\"\"\"\n+ dirs = _get_site_packages_dirs(sys.executable)\n+ assert dirs\n+\n+ @staticmethod\n+ def check_mypy_run(cmd_line: List[str],\n+ expected_out: str,\n+ expected_err: str = '',\n+ expected_returncode: int = 1) -> None:\n+ \"\"\"Helper to run mypy and check the output.\"\"\"\n+ out, err, returncode = mypy.api.run(cmd_line)\n+ assert out == expected_out, err","path":"mypy/test/testpep561.py","position":52,"original_position":52,"commit_id":"6916b0907a53627cf18b730ae8ac12a99d2474d8","original_commit_id":"6916b0907a53627cf18b730ae8ac12a99d2474d8","user":{"login":"ethanhs","id":9504279,"avatar_url":"https://avatars0.githubusercontent.com/u/9504279?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanhs","html_url":"https://github.com/ethanhs","followers_url":"https://api.github.com/users/ethanhs/followers","following_url":"https://api.github.com/users/ethanhs/following{/other_user}","gists_url":"https://api.github.com/users/ethanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanhs/subscriptions","organizations_url":"https://api.github.com/users/ethanhs/orgs","repos_url":"https://api.github.com/users/ethanhs/repos","events_url":"https://api.github.com/users/ethanhs/events{/privacy}","received_events_url":"https://api.github.com/users/ethanhs/received_events","type":"User","site_admin":false},"body":"Yes, this is so the test output will show both if the assert fails. For example if something breaks, mypy would print `mypy can't find module blah` to stderr, with an empty stdout.","created_at":"2018-04-06T21:56:57Z","updated_at":"2018-04-06T21:56:57Z","html_url":"https://github.com/python/mypy/pull/4693#discussion_r179885347","pull_request_url":"https://api.github.com/repos/python/mypy/pulls/4693","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/comments/179885347"},"html":{"href":"https://github.com/python/mypy/pull/4693#discussion_r179885347"},"pull_request":{"href":"https://api.github.com/repos/python/mypy/pulls/4693"}},"in_reply_to_id":179807203},"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/4693","id":173426172,"html_url":"https://github.com/python/mypy/pull/4693","diff_url":"https://github.com/python/mypy/pull/4693.diff","patch_url":"https://github.com/python/mypy/pull/4693.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/4693","number":4693,"state":"open","locked":false,"title":"Implement PEP561","user":{"login":"ethanhs","id":9504279,"avatar_url":"https://avatars0.githubusercontent.com/u/9504279?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanhs","html_url":"https://github.com/ethanhs","followers_url":"https://api.github.com/users/ethanhs/followers","following_url":"https://api.github.com/users/ethanhs/following{/other_user}","gists_url":"https://api.github.com/users/ethanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanhs/subscriptions","organizations_url":"https://api.github.com/users/ethanhs/orgs","repos_url":"https://api.github.com/users/ethanhs/repos","events_url":"https://api.github.com/users/ethanhs/events{/privacy}","received_events_url":"https://api.github.com/users/ethanhs/received_events","type":"User","site_admin":false},"body":"This is an implementation of PEP 561. I am picking up from https://github.com/python/mypy/pull/4403 because I'd rather not rebase over 100 commits (and some of the changes shouldn't go in!). Third times a charm I hope :)\r\n\r\nTasks:\r\n- [x] Test PEP 561 implementation\r\n- [x] Check PEP 561 conformance to [resolution order](https://www.python.org/dev/peps/pep-0561/#type-checker-module-resolution-order)\r\n- [x] support running with alternate Python executable ``--python-executable``\r\n- [x] document PEP 561 features\r\n- [x] document ``--python-executable`` flag\r\n- [x] test ``--python-executable`` flag\r\n- [x] test ``--no-site-packages`` flag\r\n- [x] document `--no-site-packages` flag\r\n- [x] `--python-version` flag sets `--python-executable` and visa-versa if possible\r\n\r\nThis branch likely works as intended and is feature complete, but it is possible that I've overlooked something/made a mistake.\r\n\r\nFixes #2625, #1190, #965.","created_at":"2018-03-07T11:36:34Z","updated_at":"2018-04-06T21:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9b60415050591c05df0a854b367c94ecc74661b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/4693/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/4693/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/4693/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/6916b0907a53627cf18b730ae8ac12a99d2474d8","head":{"label":"ethanhs:impl-pep561","ref":"impl-pep561","sha":"6916b0907a53627cf18b730ae8ac12a99d2474d8","user":{"login":"ethanhs","id":9504279,"avatar_url":"https://avatars0.githubusercontent.com/u/9504279?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanhs","html_url":"https://github.com/ethanhs","followers_url":"https://api.github.com/users/ethanhs/followers","following_url":"https://api.github.com/users/ethanhs/following{/other_user}","gists_url":"https://api.github.com/users/ethanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanhs/subscriptions","organizations_url":"https://api.github.com/users/ethanhs/orgs","repos_url":"https://api.github.com/users/ethanhs/repos","events_url":"https://api.github.com/users/ethanhs/events{/privacy}","received_events_url":"https://api.github.com/users/ethanhs/received_events","type":"User","site_admin":false},"repo":{"id":96048813,"name":"mypy","full_name":"ethanhs/mypy","owner":{"login":"ethanhs","id":9504279,"avatar_url":"https://avatars0.githubusercontent.com/u/9504279?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanhs","html_url":"https://github.com/ethanhs","followers_url":"https://api.github.com/users/ethanhs/followers","following_url":"https://api.github.com/users/ethanhs/following{/other_user}","gists_url":"https://api.github.com/users/ethanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanhs/subscriptions","organizations_url":"https://api.github.com/users/ethanhs/orgs","repos_url":"https://api.github.com/users/ethanhs/repos","events_url":"https://api.github.com/users/ethanhs/events{/privacy}","received_events_url":"https://api.github.com/users/ethanhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethanhs/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":true,"url":"https://api.github.com/repos/ethanhs/mypy","forks_url":"https://api.github.com/repos/ethanhs/mypy/forks","keys_url":"https://api.github.com/repos/ethanhs/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethanhs/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethanhs/mypy/teams","hooks_url":"https://api.github.com/repos/ethanhs/mypy/hooks","issue_events_url":"https://api.github.com/repos/ethanhs/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/ethanhs/mypy/events","assignees_url":"https://api.github.com/repos/ethanhs/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/ethanhs/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/ethanhs/mypy/tags","blobs_url":"https://api.github.com/repos/ethanhs/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethanhs/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethanhs/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethanhs/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethanhs/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/ethanhs/mypy/languages","stargazers_url":"https://api.github.com/repos/ethanhs/mypy/stargazers","contributors_url":"https://api.github.com/repos/ethanhs/mypy/contributors","subscribers_url":"https://api.github.com/repos/ethanhs/mypy/subscribers","subscription_url":"https://api.github.com/repos/ethanhs/mypy/subscription","commits_url":"https://api.github.com/repos/ethanhs/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethanhs/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethanhs/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethanhs/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethanhs/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/ethanhs/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethanhs/mypy/merges","archive_url":"https://api.github.com/repos/ethanhs/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethanhs/mypy/downloads","issues_url":"https://api.github.com/repos/ethanhs/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/ethanhs/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/ethanhs/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/ethanhs/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethanhs/mypy/labels{/name}","releases_url":"https://api.github.com/repos/ethanhs/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/ethanhs/mypy/deployments","created_at":"2017-07-02T21:02:36Z","updated_at":"2018-03-29T00:34:23Z","pushed_at":"2018-04-05T03:45:14Z","git_url":"git://github.com/ethanhs/mypy.git","ssh_url":"git@github.com:ethanhs/mypy.git","clone_url":"https://github.com/ethanhs/mypy.git","svn_url":"https://github.com/ethanhs/mypy","homepage":"http://www.mypy-lang.org/","size":25785,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"5ce23c69473a8af7c1ac39513a6a3492616db439","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"name":"mypy","full_name":"python/mypy","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2018-04-06T18:57:33Z","pushed_at":"2018-04-06T18:51:39Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":25293,"stargazers_count":3664,"watchers_count":3664,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":865,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":482,"open_issues":865,"watchers":3664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/4693"},"html":{"href":"https://github.com/python/mypy/pull/4693"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/4693"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/4693/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/4693/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/4693/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/6916b0907a53627cf18b730ae8ac12a99d2474d8"}},"author_association":"COLLABORATOR"}} | {
"id": 7053637,
"name": "python/mypy",
"url": "https://api.github.com/repos/python/mypy"
} | {
"id": 9504279,
"login": "ethanhs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9504279?",
"url": "https://api.github.com/users/ethanhs"
} | {
"id": 1525981,
"login": "python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1525981?",
"url": "https://api.github.com/orgs/python"
} | 2018-04-06T21:56:57 | 7493366643 | {"actor":{"display_login":"ethanhs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/227179037","pull_request_review_id":167158997,"id":227179037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE3OTAzNw==","diff_hunk":"@@ -333,39 +333,46 @@ tuplerepr(PyTupleObject *v)\n return NULL;\n }\n \n-/* The addend 82520, was selected from the range(0, 1000000) for\n- generating the greatest number of prime multipliers for tuples\n- up to length eight:\n \n- 1082527, 1165049, 1082531, 1165057, 1247581, 1330103, 1082533,\n- 1330111, 1412633, 1165069, 1247599, 1495177, 1577699\n+/* Hash for tuples. This is a slightly simplified version of the xxHash\n+ non-cryptographic hash:\n+ - we do not use any parallellism, there is only 1 accumulator.\n+ - we drop the final mixing since this is just a permutation of the\n+ output space: it does not help against collisions.\n+ - at the end, we mangle the length with a single constant as a\n+ \"class signature\" to make tuple hashes different from other hashes\n+ based on xxHash.\n+ For the xxHash specification, see\n+ https://github.com/Cyan4973/xxHash/wiki/xxHash-specification-(draft)\n \n Tests have shown that it's not worth to cache the hash value, see\n- issue #9685.\n+ https://bugs.python.org/issue9685\n */\n-\n static Py_hash_t\n tuplehash(PyTupleObject *v)\n {\n- Py_uhash_t x; /* Unsigned for defined overflow behavior. */\n- Py_hash_t y;\n- Py_ssize_t len = Py_SIZE(v);\n- PyObject **p;\n- Py_uhash_t mult = _PyHASH_MULTIPLIER;\n- x = 0x345678UL;\n- p = v->ob_item;\n- while (--len >= 0) {\n- y = PyObject_Hash(*p++);\n- if (y == -1)\n+ Py_ssize_t i, len = Py_SIZE(v);\n+ PyObject **item = v->ob_item;\n+\n+ Py_uhash_t acc = _PyHASH_XXPRIME_5;\n+ for (i = 0; i < len; i++) {\n+ Py_uhash_t lane = PyObject_Hash(item[i]);\n+ if (lane == (Py_uhash_t)-1) {\n return -1;\n- x = (x ^ y) * mult;\n- /* the cast might truncate len; that doesn't change hash stability */\n- mult += (Py_hash_t)(82520UL + len + len);\n+ }\n+ acc += lane * _PyHASH_XXPRIME_2;\n+ acc = _PyHASH_XXROTATE(acc);\n+ acc *= _PyHASH_XXPRIME_1;\n+ }\n+\n+ /* Add input length, mangled to provide a class signature. The constant\n+ is chosen to keep the historical value of hash(()). */\n+ acc += len ^ (_PyHASH_XXPRIME_5 ^ 3527539);\n+\n+ if (acc == (Py_uhash_t)-1) {\n+ return -2;","path":"Objects/tupleobject.c","position":61,"original_position":61,"commit_id":"8440ccb6b93a2d6f29d6484abd3fe5c384d169de","original_commit_id":"8440ccb6b93a2d6f29d6484abd3fe5c384d169de","user":{"login":"rhettinger","id":1623689,"node_id":"MDQ6VXNlcjE2MjM2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1623689?v=4","gravatar_id":"","url":"https://api.github.com/users/rhettinger","html_url":"https://github.com/rhettinger","followers_url":"https://api.github.com/users/rhettinger/followers","following_url":"https://api.github.com/users/rhettinger/following{/other_user}","gists_url":"https://api.github.com/users/rhettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/rhettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhettinger/subscriptions","organizations_url":"https://api.github.com/users/rhettinger/orgs","repos_url":"https://api.github.com/users/rhettinger/repos","events_url":"https://api.github.com/users/rhettinger/events{/privacy}","received_events_url":"https://api.github.com/users/rhettinger/received_events","type":"User","site_admin":false},"body":"While we're at it, we could return a more interesting value than -2, something random and large.","created_at":"2018-10-23T00:04:58Z","updated_at":"2018-10-23T00:04:58Z","html_url":"https://github.com/python/cpython/pull/9471#discussion_r227179037","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/9471","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/227179037"},"html":{"href":"https://github.com/python/cpython/pull/9471#discussion_r227179037"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/9471"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/9471","id":217273596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjczNTk2","html_url":"https://github.com/python/cpython/pull/9471","diff_url":"https://github.com/python/cpython/pull/9471.diff","patch_url":"https://github.com/python/cpython/pull/9471.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/9471","number":9471,"state":"open","locked":false,"title":"bpo-34751: improved hash function for tuples","user":{"login":"jdemeyer","id":3625785,"node_id":"MDQ6VXNlcjM2MjU3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3625785?v=4","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"body":"This patch improves the hash code for tuples to avoid the structural hash collision\r\n```\r\nhash((3, 3)) == hash((-3, -3))\r\n```\r\n\r\nThe new hash function is a simplified variant of [xxHash](https://github.com/Cyan4973/xxHash)\r\n\r\n<!-- issue-number: [bpo-34751](https://www.bugs.python.org/issue34751) -->\r\nhttps://bugs.python.org/issue34751\r\n<!-- /issue-number -->\r\n","created_at":"2018-09-21T12:50:55Z","updated_at":"2018-10-23T00:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae29c4088b31b8fd4665805f67c8640c3652c997","assignee":{"login":"rhettinger","id":1623689,"node_id":"MDQ6VXNlcjE2MjM2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1623689?v=4","gravatar_id":"","url":"https://api.github.com/users/rhettinger","html_url":"https://github.com/rhettinger","followers_url":"https://api.github.com/users/rhettinger/followers","following_url":"https://api.github.com/users/rhettinger/following{/other_user}","gists_url":"https://api.github.com/users/rhettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/rhettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhettinger/subscriptions","organizations_url":"https://api.github.com/users/rhettinger/orgs","repos_url":"https://api.github.com/users/rhettinger/repos","events_url":"https://api.github.com/users/rhettinger/events{/privacy}","received_events_url":"https://api.github.com/users/rhettinger/received_events","type":"User","site_admin":false},"assignees":[{"login":"rhettinger","id":1623689,"node_id":"MDQ6VXNlcjE2MjM2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1623689?v=4","gravatar_id":"","url":"https://api.github.com/users/rhettinger","html_url":"https://github.com/rhettinger","followers_url":"https://api.github.com/users/rhettinger/followers","following_url":"https://api.github.com/users/rhettinger/following{/other_user}","gists_url":"https://api.github.com/users/rhettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/rhettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhettinger/subscriptions","organizations_url":"https://api.github.com/users/rhettinger/orgs","repos_url":"https://api.github.com/users/rhettinger/repos","events_url":"https://api.github.com/users/rhettinger/events{/privacy}","received_events_url":"https://api.github.com/users/rhettinger/received_events","type":"User","site_admin":false},{"login":"tim-one","id":14852019,"node_id":"MDQ6VXNlcjE0ODUyMDE5","avatar_url":"https://avatars3.githubusercontent.com/u/14852019?v=4","gravatar_id":"","url":"https://api.github.com/users/tim-one","html_url":"https://github.com/tim-one","followers_url":"https://api.github.com/users/tim-one/followers","following_url":"https://api.github.com/users/tim-one/following{/other_user}","gists_url":"https://api.github.com/users/tim-one/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-one/subscriptions","organizations_url":"https://api.github.com/users/tim-one/orgs","repos_url":"https://api.github.com/users/tim-one/repos","events_url":"https://api.github.com/users/tim-one/events{/privacy}","received_events_url":"https://api.github.com/users/tim-one/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979988,"node_id":"MDU6TGFiZWw2NjY5Nzk5ODg=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20change%20review","name":"awaiting change review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/9471/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/9471/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/9471/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/8440ccb6b93a2d6f29d6484abd3fe5c384d169de","head":{"label":"jdemeyer:bpo34751","ref":"bpo34751","sha":"8440ccb6b93a2d6f29d6484abd3fe5c384d169de","user":{"login":"jdemeyer","id":3625785,"node_id":"MDQ6VXNlcjM2MjU3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3625785?v=4","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"repo":{"id":125263704,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNjM3MDQ=","name":"cpython","full_name":"jdemeyer/cpython","private":false,"owner":{"login":"jdemeyer","id":3625785,"node_id":"MDQ6VXNlcjM2MjU3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3625785?v=4","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdemeyer/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/jdemeyer/cpython","forks_url":"https://api.github.com/repos/jdemeyer/cpython/forks","keys_url":"https://api.github.com/repos/jdemeyer/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdemeyer/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdemeyer/cpython/teams","hooks_url":"https://api.github.com/repos/jdemeyer/cpython/hooks","issue_events_url":"https://api.github.com/repos/jdemeyer/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/jdemeyer/cpython/events","assignees_url":"https://api.github.com/repos/jdemeyer/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/jdemeyer/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/jdemeyer/cpython/tags","blobs_url":"https://api.github.com/repos/jdemeyer/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdemeyer/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdemeyer/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdemeyer/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdemeyer/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/jdemeyer/cpython/languages","stargazers_url":"https://api.github.com/repos/jdemeyer/cpython/stargazers","contributors_url":"https://api.github.com/repos/jdemeyer/cpython/contributors","subscribers_url":"https://api.github.com/repos/jdemeyer/cpython/subscribers","subscription_url":"https://api.github.com/repos/jdemeyer/cpython/subscription","commits_url":"https://api.github.com/repos/jdemeyer/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdemeyer/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdemeyer/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdemeyer/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdemeyer/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/jdemeyer/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdemeyer/cpython/merges","archive_url":"https://api.github.com/repos/jdemeyer/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdemeyer/cpython/downloads","issues_url":"https://api.github.com/repos/jdemeyer/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/jdemeyer/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/jdemeyer/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/jdemeyer/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdemeyer/cpython/labels{/name}","releases_url":"https://api.github.com/repos/jdemeyer/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/jdemeyer/cpython/deployments","created_at":"2018-03-14T19:30:49Z","updated_at":"2018-07-09T09:50:04Z","pushed_at":"2018-10-22T13:31:30Z","git_url":"git://github.com/jdemeyer/cpython.git","ssh_url":"git@github.com:jdemeyer/cpython.git","clone_url":"https://github.com/jdemeyer/cpython.git","svn_url":"https://github.com/jdemeyer/cpython","homepage":"https://www.python.org/","size":246468,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"121eb1694cab14df857ba6abe9839654cada15cf","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-10-22T19:49:28Z","pushed_at":"2018-10-22T22:54:27Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":252875,"stargazers_count":20435,"watchers_count":20435,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7233,"mirror_url":null,"archived":false,"open_issues_count":937,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7233,"open_issues":937,"watchers":20435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/9471"},"html":{"href":"https://github.com/python/cpython/pull/9471"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/9471"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/9471/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/9471/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/9471/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/8440ccb6b93a2d6f29d6484abd3fe5c384d169de"}},"author_association":"CONTRIBUTOR"}} | {
"id": 81598961,
"name": "python/cpython",
"url": "https://api.github.com/repos/python/cpython"
} | {
"id": 1623689,
"login": "rhettinger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1623689?",
"url": "https://api.github.com/users/rhettinger"
} | {
"id": 1525981,
"login": "python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1525981?",
"url": "https://api.github.com/orgs/python"
} | 2018-10-23T00:04:58 | 8461972604 | {"actor":{"display_login":"rhettinger"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/halide/Halide/pulls/comments/222351157","pull_request_review_id":161216286,"id":222351157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM1MTE1Nw==","diff_hunk":"@@ -2111,7 +2076,7 @@ WEAK int halide_d3d12compute_device_malloc(void *user_context, halide_buffer_t *\n \n #ifdef DEBUG_RUNTIME\n uint64_t t_after = halide_current_time_ns(user_context);\n- debug(user_context) << TRACEINDENT << \"Time: \" << (t_after - t_before) / 1.0e6 << \" ms\\n\";\n+ TRACEPRINT( \"Time: \" << (t_after - t_before) / 1.0e6 << \" ms\\n\" );","path":"src/runtime/d3d12compute.cpp","position":354,"original_position":354,"commit_id":"dbf75159454a6380a41eef7e2ee90922919ee423","original_commit_id":"dbf75159454a6380a41eef7e2ee90922919ee423","user":{"login":"shoaibkamil","id":382556,"node_id":"MDQ6VXNlcjM4MjU1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/382556?v=4","gravatar_id":"","url":"https://api.github.com/users/shoaibkamil","html_url":"https://github.com/shoaibkamil","followers_url":"https://api.github.com/users/shoaibkamil/followers","following_url":"https://api.github.com/users/shoaibkamil/following{/other_user}","gists_url":"https://api.github.com/users/shoaibkamil/gists{/gist_id}","starred_url":"https://api.github.com/users/shoaibkamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoaibkamil/subscriptions","organizations_url":"https://api.github.com/users/shoaibkamil/orgs","repos_url":"https://api.github.com/users/shoaibkamil/repos","events_url":"https://api.github.com/users/shoaibkamil/events{/privacy}","received_events_url":"https://api.github.com/users/shoaibkamil/received_events","type":"User","site_admin":false},"body":"Extraneous spaces","created_at":"2018-10-03T15:13:51Z","updated_at":"2018-10-03T15:13:51Z","html_url":"https://github.com/halide/Halide/pull/3305#discussion_r222351157","pull_request_url":"https://api.github.com/repos/halide/Halide/pulls/3305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments/222351157"},"html":{"href":"https://github.com/halide/Halide/pull/3305#discussion_r222351157"},"pull_request":{"href":"https://api.github.com/repos/halide/Halide/pulls/3305"}}},"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/3305","id":219867682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODY3Njgy","html_url":"https://github.com/halide/Halide/pull/3305","diff_url":"https://github.com/halide/Halide/pull/3305.diff","patch_url":"https://github.com/halide/Halide/pull/3305.patch","issue_url":"https://api.github.com/repos/halide/Halide/issues/3305","number":3305,"state":"open","locked":false,"title":"Direct3D 12 bug-fixes","user":{"login":"slomp","id":526886,"node_id":"MDQ6VXNlcjUyNjg4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/526886?v=4","gravatar_id":"","url":"https://api.github.com/users/slomp","html_url":"https://github.com/slomp","followers_url":"https://api.github.com/users/slomp/followers","following_url":"https://api.github.com/users/slomp/following{/other_user}","gists_url":"https://api.github.com/users/slomp/gists{/gist_id}","starred_url":"https://api.github.com/users/slomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slomp/subscriptions","organizations_url":"https://api.github.com/users/slomp/orgs","repos_url":"https://api.github.com/users/slomp/repos","events_url":"https://api.github.com/users/slomp/events{/privacy}","received_events_url":"https://api.github.com/users/slomp/received_events","type":"User","site_admin":false},"body":"One bug still remain: `generator_aot_cleanup_on_error` (I solved the issue with conflicting `malloc` interfaces, but there's something else going on)","created_at":"2018-10-02T22:44:32Z","updated_at":"2018-10-03T15:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de0e0f7df824f425a0199124d70e5a32346ea6af","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zvookin","id":1501716,"node_id":"MDQ6VXNlcjE1MDE3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1501716?v=4","gravatar_id":"","url":"https://api.github.com/users/zvookin","html_url":"https://github.com/zvookin","followers_url":"https://api.github.com/users/zvookin/followers","following_url":"https://api.github.com/users/zvookin/following{/other_user}","gists_url":"https://api.github.com/users/zvookin/gists{/gist_id}","starred_url":"https://api.github.com/users/zvookin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvookin/subscriptions","organizations_url":"https://api.github.com/users/zvookin/orgs","repos_url":"https://api.github.com/users/zvookin/repos","events_url":"https://api.github.com/users/zvookin/events{/privacy}","received_events_url":"https://api.github.com/users/zvookin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/halide/Halide/pulls/3305/commits","review_comments_url":"https://api.github.com/repos/halide/Halide/pulls/3305/comments","review_comment_url":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halide/Halide/issues/3305/comments","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/dbf75159454a6380a41eef7e2ee90922919ee423","head":{"label":"halide:slomp-d3d12-fix","ref":"slomp-d3d12-fix","sha":"dbf75159454a6380a41eef7e2ee90922919ee423","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-10-03T15:04:30Z","pushed_at":"2018-10-03T08:51:20Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":251958,"stargazers_count":2545,"watchers_count":2545,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":524,"mirror_url":null,"archived":false,"open_issues_count":506,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":524,"open_issues":506,"watchers":2545,"default_branch":"master"}},"base":{"label":"halide:master","ref":"master","sha":"5569b3ac254a5c4f603e81091cdd3d448ed99802","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-10-03T15:04:30Z","pushed_at":"2018-10-03T08:51:20Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":251958,"stargazers_count":2545,"watchers_count":2545,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":524,"mirror_url":null,"archived":false,"open_issues_count":506,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":524,"open_issues":506,"watchers":2545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/3305"},"html":{"href":"https://github.com/halide/Halide/pull/3305"},"issue":{"href":"https://api.github.com/repos/halide/Halide/issues/3305"},"comments":{"href":"https://api.github.com/repos/halide/Halide/issues/3305/comments"},"review_comments":{"href":"https://api.github.com/repos/halide/Halide/pulls/3305/comments"},"review_comment":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halide/Halide/pulls/3305/commits"},"statuses":{"href":"https://api.github.com/repos/halide/Halide/statuses/dbf75159454a6380a41eef7e2ee90922919ee423"}},"author_association":"CONTRIBUTOR"}} | {
"id": 5241312,
"name": "halide/Halide",
"url": "https://api.github.com/repos/halide/Halide"
} | {
"id": 382556,
"login": "shoaibkamil",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/382556?",
"url": "https://api.github.com/users/shoaibkamil"
} | {
"id": 1548551,
"login": "halide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1548551?",
"url": "https://api.github.com/orgs/halide"
} | 2018-10-03T15:13:51 | 8361818968 | {"actor":{"display_login":"shoaibkamil"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zalando/logbook/pulls/comments/223303312","pull_request_review_id":162394085,"id":223303312,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzMwMzMxMg==","diff_hunk":"@@ -0,0 +1,100 @@\n+package org.zalando.logbook;\n+\n+import lombok.extern.slf4j.Slf4j;\n+import org.w3c.dom.Document;\n+import org.w3c.dom.Node;\n+import org.w3c.dom.NodeList;\n+\n+import javax.annotation.Nullable;\n+import javax.xml.parsers.DocumentBuilder;\n+import javax.xml.parsers.DocumentBuilderFactory;\n+import javax.xml.transform.Transformer;\n+import javax.xml.transform.TransformerFactory;\n+import javax.xml.transform.dom.DOMSource;\n+import javax.xml.transform.stream.StreamResult;\n+import javax.xml.xpath.XPath;\n+import javax.xml.xpath.XPathFactory;\n+import java.io.ByteArrayInputStream;\n+import java.io.StringWriter;\n+import java.util.function.Predicate;\n+import java.util.stream.Stream;\n+\n+import static javax.xml.transform.OutputKeys.INDENT;\n+import static javax.xml.transform.OutputKeys.OMIT_XML_DECLARATION;\n+import static javax.xml.xpath.XPathConstants.NODESET;\n+import static org.zalando.fauxpas.FauxPas.throwingSupplier;\n+\n+@Slf4j\n+class XmlCompactingBodyFilter implements BodyFilter {\n+\n+ private final Predicate<String> contentTypes = MediaTypeQuery.compile(\"*/xml\", \"*/*+xml\");\n+ private final DocumentBuilderFactory documentBuilderFactory = documentBuilderFactory();\n+ private final Transformer transformer = transformer();\n+\n+ @Override\n+ public String filter(@Nullable final String contentType, final String body) {\n+ return contentTypes.test(contentType) && shouldCompact(body) ? compact(body) : body;\n+ }\n+\n+ private boolean shouldCompact(final String body) {\n+ return Stream.of(\"<?xml\", \"\\n\", \" \").anyMatch(body::contains);","path":"logbook-core/src/main/java/org/zalando/logbook/XmlCompactingBodyFilter.java","position":40,"original_position":40,"commit_id":"2beb3edc5b9fffc374fb41a1446fcc6edb048bb5","original_commit_id":"2beb3edc5b9fffc374fb41a1446fcc6edb048bb5","user":{"login":"whiskeysierra","id":429981,"node_id":"MDQ6VXNlcjQyOTk4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/429981?v=4","gravatar_id":"","url":"https://api.github.com/users/whiskeysierra","html_url":"https://github.com/whiskeysierra","followers_url":"https://api.github.com/users/whiskeysierra/followers","following_url":"https://api.github.com/users/whiskeysierra/following{/other_user}","gists_url":"https://api.github.com/users/whiskeysierra/gists{/gist_id}","starred_url":"https://api.github.com/users/whiskeysierra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whiskeysierra/subscriptions","organizations_url":"https://api.github.com/users/whiskeysierra/orgs","repos_url":"https://api.github.com/users/whiskeysierra/repos","events_url":"https://api.github.com/users/whiskeysierra/events{/privacy}","received_events_url":"https://api.github.com/users/whiskeysierra/received_events","type":"User","site_admin":false},"body":"The xml declaration is redundant and should be covered by the content type check, shouldn't it? Spaces would be generally ok, since the whole log message would still fit into a single line.\r\n\r\nI'd just change this in the same way as the json compactor:\r\n\r\n```\r\nreturn body.indexOf('\\n') != -1;\r\n```","created_at":"2018-10-08T09:40:02Z","updated_at":"2018-10-08T09:40:02Z","html_url":"https://github.com/zalando/logbook/pull/357#discussion_r223303312","pull_request_url":"https://api.github.com/repos/zalando/logbook/pulls/357","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zalando/logbook/pulls/comments/223303312"},"html":{"href":"https://github.com/zalando/logbook/pull/357#discussion_r223303312"},"pull_request":{"href":"https://api.github.com/repos/zalando/logbook/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/logbook/pulls/357","id":220934901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTM0OTAx","html_url":"https://github.com/zalando/logbook/pull/357","diff_url":"https://github.com/zalando/logbook/pull/357.diff","patch_url":"https://github.com/zalando/logbook/pull/357.patch","issue_url":"https://api.github.com/repos/zalando/logbook/issues/357","number":357,"state":"open","locked":false,"title":"Add compacting body filters","user":{"login":"nsmolenskii","id":1727762,"node_id":"MDQ6VXNlcjE3Mjc3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1727762?v=4","gravatar_id":"","url":"https://api.github.com/users/nsmolenskii","html_url":"https://github.com/nsmolenskii","followers_url":"https://api.github.com/users/nsmolenskii/followers","following_url":"https://api.github.com/users/nsmolenskii/following{/other_user}","gists_url":"https://api.github.com/users/nsmolenskii/gists{/gist_id}","starred_url":"https://api.github.com/users/nsmolenskii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsmolenskii/subscriptions","organizations_url":"https://api.github.com/users/nsmolenskii/orgs","repos_url":"https://api.github.com/users/nsmolenskii/repos","events_url":"https://api.github.com/users/nsmolenskii/events{/privacy}","received_events_url":"https://api.github.com/users/nsmolenskii/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\nAdd body filters to compact most common content types\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nCustom `HttpLogForrmatter`s (different from `JsonHttpLogFormatter`) have also need to minify message body. To reduce code duplication from formatter to formatter, it could be extracted as delegating body filters.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n","created_at":"2018-10-07T08:39:33Z","updated_at":"2018-10-08T09:40:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"399a16d746756f7ff71a3513474bc55016025b3f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlexanderYastrebov","id":697976,"node_id":"MDQ6VXNlcjY5Nzk3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/697976?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderYastrebov","html_url":"https://github.com/AlexanderYastrebov","followers_url":"https://api.github.com/users/AlexanderYastrebov/followers","following_url":"https://api.github.com/users/AlexanderYastrebov/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderYastrebov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderYastrebov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderYastrebov/subscriptions","organizations_url":"https://api.github.com/users/AlexanderYastrebov/orgs","repos_url":"https://api.github.com/users/AlexanderYastrebov/repos","events_url":"https://api.github.com/users/AlexanderYastrebov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderYastrebov/received_events","type":"User","site_admin":false},{"login":"lukasniemeier-zalando","id":10497901,"node_id":"MDQ6VXNlcjEwNDk3OTAx","avatar_url":"https://avatars0.githubusercontent.com/u/10497901?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasniemeier-zalando","html_url":"https://github.com/lukasniemeier-zalando","followers_url":"https://api.github.com/users/lukasniemeier-zalando/followers","following_url":"https://api.github.com/users/lukasniemeier-zalando/following{/other_user}","gists_url":"https://api.github.com/users/lukasniemeier-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasniemeier-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasniemeier-zalando/subscriptions","organizations_url":"https://api.github.com/users/lukasniemeier-zalando/orgs","repos_url":"https://api.github.com/users/lukasniemeier-zalando/repos","events_url":"https://api.github.com/users/lukasniemeier-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/lukasniemeier-zalando/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/logbook/pulls/357/commits","review_comments_url":"https://api.github.com/repos/zalando/logbook/pulls/357/comments","review_comment_url":"https://api.github.com/repos/zalando/logbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/logbook/issues/357/comments","statuses_url":"https://api.github.com/repos/zalando/logbook/statuses/2beb3edc5b9fffc374fb41a1446fcc6edb048bb5","head":{"label":"nsmolenskii:add-compacting-body-filters","ref":"add-compacting-body-filters","sha":"2beb3edc5b9fffc374fb41a1446fcc6edb048bb5","user":{"login":"nsmolenskii","id":1727762,"node_id":"MDQ6VXNlcjE3Mjc3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1727762?v=4","gravatar_id":"","url":"https://api.github.com/users/nsmolenskii","html_url":"https://github.com/nsmolenskii","followers_url":"https://api.github.com/users/nsmolenskii/followers","following_url":"https://api.github.com/users/nsmolenskii/following{/other_user}","gists_url":"https://api.github.com/users/nsmolenskii/gists{/gist_id}","starred_url":"https://api.github.com/users/nsmolenskii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsmolenskii/subscriptions","organizations_url":"https://api.github.com/users/nsmolenskii/orgs","repos_url":"https://api.github.com/users/nsmolenskii/repos","events_url":"https://api.github.com/users/nsmolenskii/events{/privacy}","received_events_url":"https://api.github.com/users/nsmolenskii/received_events","type":"User","site_admin":false},"repo":{"id":148286085,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyODYwODU=","name":"logbook","full_name":"nsmolenskii/logbook","private":false,"owner":{"login":"nsmolenskii","id":1727762,"node_id":"MDQ6VXNlcjE3Mjc3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1727762?v=4","gravatar_id":"","url":"https://api.github.com/users/nsmolenskii","html_url":"https://github.com/nsmolenskii","followers_url":"https://api.github.com/users/nsmolenskii/followers","following_url":"https://api.github.com/users/nsmolenskii/following{/other_user}","gists_url":"https://api.github.com/users/nsmolenskii/gists{/gist_id}","starred_url":"https://api.github.com/users/nsmolenskii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsmolenskii/subscriptions","organizations_url":"https://api.github.com/users/nsmolenskii/orgs","repos_url":"https://api.github.com/users/nsmolenskii/repos","events_url":"https://api.github.com/users/nsmolenskii/events{/privacy}","received_events_url":"https://api.github.com/users/nsmolenskii/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nsmolenskii/logbook","description":"An extensible Java library for HTTP request and response logging","fork":true,"url":"https://api.github.com/repos/nsmolenskii/logbook","forks_url":"https://api.github.com/repos/nsmolenskii/logbook/forks","keys_url":"https://api.github.com/repos/nsmolenskii/logbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsmolenskii/logbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsmolenskii/logbook/teams","hooks_url":"https://api.github.com/repos/nsmolenskii/logbook/hooks","issue_events_url":"https://api.github.com/repos/nsmolenskii/logbook/issues/events{/number}","events_url":"https://api.github.com/repos/nsmolenskii/logbook/events","assignees_url":"https://api.github.com/repos/nsmolenskii/logbook/assignees{/user}","branches_url":"https://api.github.com/repos/nsmolenskii/logbook/branches{/branch}","tags_url":"https://api.github.com/repos/nsmolenskii/logbook/tags","blobs_url":"https://api.github.com/repos/nsmolenskii/logbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsmolenskii/logbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsmolenskii/logbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsmolenskii/logbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsmolenskii/logbook/statuses/{sha}","languages_url":"https://api.github.com/repos/nsmolenskii/logbook/languages","stargazers_url":"https://api.github.com/repos/nsmolenskii/logbook/stargazers","contributors_url":"https://api.github.com/repos/nsmolenskii/logbook/contributors","subscribers_url":"https://api.github.com/repos/nsmolenskii/logbook/subscribers","subscription_url":"https://api.github.com/repos/nsmolenskii/logbook/subscription","commits_url":"https://api.github.com/repos/nsmolenskii/logbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsmolenskii/logbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsmolenskii/logbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsmolenskii/logbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsmolenskii/logbook/contents/{+path}","compare_url":"https://api.github.com/repos/nsmolenskii/logbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsmolenskii/logbook/merges","archive_url":"https://api.github.com/repos/nsmolenskii/logbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsmolenskii/logbook/downloads","issues_url":"https://api.github.com/repos/nsmolenskii/logbook/issues{/number}","pulls_url":"https://api.github.com/repos/nsmolenskii/logbook/pulls{/number}","milestones_url":"https://api.github.com/repos/nsmolenskii/logbook/milestones{/number}","notifications_url":"https://api.github.com/repos/nsmolenskii/logbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsmolenskii/logbook/labels{/name}","releases_url":"https://api.github.com/repos/nsmolenskii/logbook/releases{/id}","deployments_url":"https://api.github.com/repos/nsmolenskii/logbook/deployments","created_at":"2018-09-11T08:33:31Z","updated_at":"2018-09-11T08:33:34Z","pushed_at":"2018-10-08T09:36:15Z","git_url":"git://github.com/nsmolenskii/logbook.git","ssh_url":"git@github.com:nsmolenskii/logbook.git","clone_url":"https://github.com/nsmolenskii/logbook.git","svn_url":"https://github.com/nsmolenskii/logbook","homepage":"","size":1478,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"53cfc8e320aecd3b8d70a1b7047e4626f9e9758b","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":42457394,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ1NzM5NA==","name":"logbook","full_name":"zalando/logbook","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/logbook","description":"An extensible Java library for HTTP request and response logging","fork":false,"url":"https://api.github.com/repos/zalando/logbook","forks_url":"https://api.github.com/repos/zalando/logbook/forks","keys_url":"https://api.github.com/repos/zalando/logbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/logbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/logbook/teams","hooks_url":"https://api.github.com/repos/zalando/logbook/hooks","issue_events_url":"https://api.github.com/repos/zalando/logbook/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/logbook/events","assignees_url":"https://api.github.com/repos/zalando/logbook/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/logbook/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/logbook/tags","blobs_url":"https://api.github.com/repos/zalando/logbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/logbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/logbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/logbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/logbook/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/logbook/languages","stargazers_url":"https://api.github.com/repos/zalando/logbook/stargazers","contributors_url":"https://api.github.com/repos/zalando/logbook/contributors","subscribers_url":"https://api.github.com/repos/zalando/logbook/subscribers","subscription_url":"https://api.github.com/repos/zalando/logbook/subscription","commits_url":"https://api.github.com/repos/zalando/logbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/logbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/logbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/logbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/logbook/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/logbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/logbook/merges","archive_url":"https://api.github.com/repos/zalando/logbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/logbook/downloads","issues_url":"https://api.github.com/repos/zalando/logbook/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/logbook/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/logbook/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/logbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/logbook/labels{/name}","releases_url":"https://api.github.com/repos/zalando/logbook/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/logbook/deployments","created_at":"2015-09-14T15:29:12Z","updated_at":"2018-10-08T07:16:35Z","pushed_at":"2018-10-08T09:36:16Z","git_url":"git://github.com/zalando/logbook.git","ssh_url":"git@github.com:zalando/logbook.git","clone_url":"https://github.com/zalando/logbook.git","svn_url":"https://github.com/zalando/logbook","homepage":"","size":1474,"stargazers_count":263,"watchers_count":263,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":15,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/logbook/pulls/357"},"html":{"href":"https://github.com/zalando/logbook/pull/357"},"issue":{"href":"https://api.github.com/repos/zalando/logbook/issues/357"},"comments":{"href":"https://api.github.com/repos/zalando/logbook/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/logbook/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/logbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/logbook/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/logbook/statuses/2beb3edc5b9fffc374fb41a1446fcc6edb048bb5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 42457394,
"name": "zalando/logbook",
"url": "https://api.github.com/repos/zalando/logbook"
} | {
"id": 429981,
"login": "whiskeysierra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/429981?",
"url": "https://api.github.com/users/whiskeysierra"
} | {
"id": 1564818,
"login": "zalando",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1564818?",
"url": "https://api.github.com/orgs/zalando"
} | 2018-10-08T09:40:02 | 8382995288 | {"actor":{"display_login":"whiskeysierra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exodev/social/pulls/comments/230310309","pull_request_review_id":171019967,"id":230310309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDMxMDMwOQ==","diff_hunk":"@@ -149,6 +149,17 @@ UIActivity.label.About_A_Day=about a day ago\n UIActivity.label.About_?_Days=about {0} days ago\n UIActivity.label.About_A_Month=about a month ago\n UIActivity.label.About_?_Months=about {0} months ago\n+\n+UIActivityUpdated.label.Less_Than_A_Minute=commented less than a minute ago","path":"component/webui/src/main/resources/locale/social/Webui_en.properties","position":5,"original_position":5,"commit_id":"3dc2b14309fa65de24c6847df2dbe313a78d59fa","original_commit_id":"3dc2b14309fa65de24c6847df2dbe313a78d59fa","user":{"login":"aelbenney","id":42932906,"node_id":"MDQ6VXNlcjQyOTMyOTA2","avatar_url":"https://avatars3.githubusercontent.com/u/42932906?v=4","gravatar_id":"","url":"https://api.github.com/users/aelbenney","html_url":"https://github.com/aelbenney","followers_url":"https://api.github.com/users/aelbenney/followers","following_url":"https://api.github.com/users/aelbenney/following{/other_user}","gists_url":"https://api.github.com/users/aelbenney/gists{/gist_id}","starred_url":"https://api.github.com/users/aelbenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelbenney/subscriptions","organizations_url":"https://api.github.com/users/aelbenney/orgs","repos_url":"https://api.github.com/users/aelbenney/repos","events_url":"https://api.github.com/users/aelbenney/events{/privacy}","received_events_url":"https://api.github.com/users/aelbenney/received_events","type":"User","site_admin":false},"body":"Ahh okey , i didn't know about the Edit Activity feature.","created_at":"2018-11-02T09:17:34Z","updated_at":"2018-11-02T09:17:34Z","html_url":"https://github.com/exodev/social/pull/424#discussion_r230310309","pull_request_url":"https://api.github.com/repos/exodev/social/pulls/424","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/exodev/social/pulls/comments/230310309"},"html":{"href":"https://github.com/exodev/social/pull/424#discussion_r230310309"},"pull_request":{"href":"https://api.github.com/repos/exodev/social/pulls/424"}},"in_reply_to_id":230303740},"pull_request":{"url":"https://api.github.com/repos/exodev/social/pulls/424","id":227858504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODU4NTA0","html_url":"https://github.com/exodev/social/pull/424","diff_url":"https://github.com/exodev/social/pull/424.diff","patch_url":"https://github.com/exodev/social/pull/424.patch","issue_url":"https://api.github.com/repos/exodev/social/issues/424","number":424,"state":"open","locked":false,"title":"Improv/SOC-6099: Display last updated time of an activity next to its created time","user":{"login":"aelbenney","id":42932906,"node_id":"MDQ6VXNlcjQyOTMyOTA2","avatar_url":"https://avatars3.githubusercontent.com/u/42932906?v=4","gravatar_id":"","url":"https://api.github.com/users/aelbenney","html_url":"https://github.com/aelbenney","followers_url":"https://api.github.com/users/aelbenney/followers","following_url":"https://api.github.com/users/aelbenney/following{/other_user}","gists_url":"https://api.github.com/users/aelbenney/gists{/gist_id}","starred_url":"https://api.github.com/users/aelbenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelbenney/subscriptions","organizations_url":"https://api.github.com/users/aelbenney/orgs","repos_url":"https://api.github.com/users/aelbenney/repos","events_url":"https://api.github.com/users/aelbenney/events{/privacy}","received_events_url":"https://api.github.com/users/aelbenney/received_events","type":"User","site_admin":false},"body":"In the information displayed for an activity, we can only see the created date. We need to add the date of last updated which is the date of the last comment or reply.\r\nSo we need to add a new function getUpdatedTimeString in BaseUIActivity to return labels that they were added to the properties files of the last updated date formats.\r\n\r\nTested on : platform-5.2.x-SNAPSHOT.","created_at":"2018-11-02T08:01:47Z","updated_at":"2018-11-02T09:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c5dcb1ead1d8bcc8ce085e34379924acbbf6eca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exodev/social/pulls/424/commits","review_comments_url":"https://api.github.com/repos/exodev/social/pulls/424/comments","review_comment_url":"https://api.github.com/repos/exodev/social/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exodev/social/issues/424/comments","statuses_url":"https://api.github.com/repos/exodev/social/statuses/3dc2b14309fa65de24c6847df2dbe313a78d59fa","head":{"label":"exodev:improv/SOC-6099","ref":"improv/SOC-6099","sha":"3dc2b14309fa65de24c6847df2dbe313a78d59fa","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4003303,"node_id":"MDEwOlJlcG9zaXRvcnk0MDAzMzAz","name":"social","full_name":"exodev/social","private":false,"owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exodev/social","description":"eXo Social","fork":true,"url":"https://api.github.com/repos/exodev/social","forks_url":"https://api.github.com/repos/exodev/social/forks","keys_url":"https://api.github.com/repos/exodev/social/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/social/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/social/teams","hooks_url":"https://api.github.com/repos/exodev/social/hooks","issue_events_url":"https://api.github.com/repos/exodev/social/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/social/events","assignees_url":"https://api.github.com/repos/exodev/social/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/social/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/social/tags","blobs_url":"https://api.github.com/repos/exodev/social/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/social/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/social/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/social/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/social/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/social/languages","stargazers_url":"https://api.github.com/repos/exodev/social/stargazers","contributors_url":"https://api.github.com/repos/exodev/social/contributors","subscribers_url":"https://api.github.com/repos/exodev/social/subscribers","subscription_url":"https://api.github.com/repos/exodev/social/subscription","commits_url":"https://api.github.com/repos/exodev/social/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/social/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/social/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/social/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/social/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/social/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/social/merges","archive_url":"https://api.github.com/repos/exodev/social/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/social/downloads","issues_url":"https://api.github.com/repos/exodev/social/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/social/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/social/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/social/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/social/labels{/name}","releases_url":"https://api.github.com/repos/exodev/social/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/social/deployments","created_at":"2012-04-12T09:45:16Z","updated_at":"2018-10-31T16:59:05Z","pushed_at":"2018-11-02T08:15:54Z","git_url":"git://github.com/exodev/social.git","ssh_url":"git@github.com:exodev/social.git","clone_url":"https://github.com/exodev/social.git","svn_url":"https://github.com/exodev/social","homepage":null,"size":42862,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":20,"open_issues":35,"watchers":9,"default_branch":"develop"}},"base":{"label":"exodev:develop","ref":"develop","sha":"1549ee085edcd6a55bcd04f11d4fc267d673bc65","user":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"repo":{"id":4003303,"node_id":"MDEwOlJlcG9zaXRvcnk0MDAzMzAz","name":"social","full_name":"exodev/social","private":false,"owner":{"login":"exodev","id":1606522,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDY1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1606522?v=4","gravatar_id":"","url":"https://api.github.com/users/exodev","html_url":"https://github.com/exodev","followers_url":"https://api.github.com/users/exodev/followers","following_url":"https://api.github.com/users/exodev/following{/other_user}","gists_url":"https://api.github.com/users/exodev/gists{/gist_id}","starred_url":"https://api.github.com/users/exodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exodev/subscriptions","organizations_url":"https://api.github.com/users/exodev/orgs","repos_url":"https://api.github.com/users/exodev/repos","events_url":"https://api.github.com/users/exodev/events{/privacy}","received_events_url":"https://api.github.com/users/exodev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exodev/social","description":"eXo Social","fork":true,"url":"https://api.github.com/repos/exodev/social","forks_url":"https://api.github.com/repos/exodev/social/forks","keys_url":"https://api.github.com/repos/exodev/social/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exodev/social/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exodev/social/teams","hooks_url":"https://api.github.com/repos/exodev/social/hooks","issue_events_url":"https://api.github.com/repos/exodev/social/issues/events{/number}","events_url":"https://api.github.com/repos/exodev/social/events","assignees_url":"https://api.github.com/repos/exodev/social/assignees{/user}","branches_url":"https://api.github.com/repos/exodev/social/branches{/branch}","tags_url":"https://api.github.com/repos/exodev/social/tags","blobs_url":"https://api.github.com/repos/exodev/social/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exodev/social/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exodev/social/git/refs{/sha}","trees_url":"https://api.github.com/repos/exodev/social/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exodev/social/statuses/{sha}","languages_url":"https://api.github.com/repos/exodev/social/languages","stargazers_url":"https://api.github.com/repos/exodev/social/stargazers","contributors_url":"https://api.github.com/repos/exodev/social/contributors","subscribers_url":"https://api.github.com/repos/exodev/social/subscribers","subscription_url":"https://api.github.com/repos/exodev/social/subscription","commits_url":"https://api.github.com/repos/exodev/social/commits{/sha}","git_commits_url":"https://api.github.com/repos/exodev/social/git/commits{/sha}","comments_url":"https://api.github.com/repos/exodev/social/comments{/number}","issue_comment_url":"https://api.github.com/repos/exodev/social/issues/comments{/number}","contents_url":"https://api.github.com/repos/exodev/social/contents/{+path}","compare_url":"https://api.github.com/repos/exodev/social/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exodev/social/merges","archive_url":"https://api.github.com/repos/exodev/social/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exodev/social/downloads","issues_url":"https://api.github.com/repos/exodev/social/issues{/number}","pulls_url":"https://api.github.com/repos/exodev/social/pulls{/number}","milestones_url":"https://api.github.com/repos/exodev/social/milestones{/number}","notifications_url":"https://api.github.com/repos/exodev/social/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exodev/social/labels{/name}","releases_url":"https://api.github.com/repos/exodev/social/releases{/id}","deployments_url":"https://api.github.com/repos/exodev/social/deployments","created_at":"2012-04-12T09:45:16Z","updated_at":"2018-10-31T16:59:05Z","pushed_at":"2018-11-02T08:15:54Z","git_url":"git://github.com/exodev/social.git","ssh_url":"git@github.com:exodev/social.git","clone_url":"https://github.com/exodev/social.git","svn_url":"https://github.com/exodev/social","homepage":null,"size":42862,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":20,"open_issues":35,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exodev/social/pulls/424"},"html":{"href":"https://github.com/exodev/social/pull/424"},"issue":{"href":"https://api.github.com/repos/exodev/social/issues/424"},"comments":{"href":"https://api.github.com/repos/exodev/social/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/exodev/social/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/exodev/social/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exodev/social/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/exodev/social/statuses/3dc2b14309fa65de24c6847df2dbe313a78d59fa"}},"author_association":"NONE"}} | {
"id": 4003303,
"name": "exodev/social",
"url": "https://api.github.com/repos/exodev/social"
} | {
"id": 42932906,
"login": "aelbenney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42932906?",
"url": "https://api.github.com/users/aelbenney"
} | {
"id": 1606522,
"login": "exodev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1606522?",
"url": "https://api.github.com/orgs/exodev"
} | 2018-11-02T09:17:34 | 8524192198 | {"actor":{"display_login":"aelbenney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/comments/223647473","pull_request_review_id":162808181,"id":223647473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzY0NzQ3Mw==","diff_hunk":"@@ -8094,10 +8099,75 @@ static VkPipelineStageFlags ExpandPipelineStageFlags(VkPipelineStageFlags inflag\n VK_PIPELINE_STAGE_TASK_SHADER_BIT_NV | VK_PIPELINE_STAGE_MESH_SHADER_BIT_NV);\n }\n \n+static bool HasNonFramebufferStagePipelineStageFlags(VkPipelineStageFlags inflags) {\n+ return (inflags & ~(VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT |\n+ VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT)) != 0;\n+}\n+\n+static int GetGraphicsPipelineStageLogicalOrder(VkPipelineStageFlagBits flag) {\n+ const VkPipelineStageFlagBits ordered_array[] = {VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,\n+ VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT,\n+ VK_PIPELINE_STAGE_VERTEX_INPUT_BIT,\n+ VK_PIPELINE_STAGE_VERTEX_SHADER_BIT,\n+ VK_PIPELINE_STAGE_TESSELLATION_CONTROL_SHADER_BIT,\n+ VK_PIPELINE_STAGE_TESSELLATION_EVALUATION_SHADER_BIT,\n+ VK_PIPELINE_STAGE_GEOMETRY_SHADER_BIT,\n+ VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT,\n+ VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT,\n+ VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT,\n+ VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,\n+ VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT};\n+\n+ const int ordered_array_length = sizeof(ordered_array) / sizeof(VkPipelineStageFlagBits);\n+\n+ for (int i = 0; i < ordered_array_length; ++i) {\n+ if (ordered_array[i] == flag) {\n+ return i;\n+ }\n+ }\n+\n+ return -1;\n+}\n+\n+static VkPipelineStageFlagBits GetLogicallyEarliestGraphicsPipelineStage(VkPipelineStageFlags inflags) {\n+ VkPipelineStageFlagBits earliest_bit = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT;\n+ int earliest_bit_order = GetGraphicsPipelineStageLogicalOrder(earliest_bit);\n+\n+ for (int i = 0; i < sizeof(VkPipelineStageFlagBits); ++i) {\n+ if (inflags & 0x1u) {\n+ int new_order = GetGraphicsPipelineStageLogicalOrder((VkPipelineStageFlagBits)((inflags & 0x1u) << i));\n+ if (new_order != -1 && new_order < earliest_bit_order) {\n+ earliest_bit_order = new_order;\n+ earliest_bit = (VkPipelineStageFlagBits)((inflags & 0x1u) << i);\n+ }\n+ }\n+ inflags = inflags >> 1;\n+ }\n+ return earliest_bit;\n+}\n+\n+static VkPipelineStageFlagBits GetLogicallyLatestGraphicsPipelineStage(VkPipelineStageFlags inflags) {\n+ VkPipelineStageFlagBits latest_bit = VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT;\n+ int latest_bit_order = GetGraphicsPipelineStageLogicalOrder(latest_bit);","path":"layers/core_validation.cpp","position":70,"original_position":377,"commit_id":"6c00756fb3a50c643df7c53e5efc37506d5e2065","original_commit_id":"71562c5fae709116d0c669547d9064a4731ed05e","user":{"login":"jzulauf-lunarg","id":32470354,"node_id":"MDQ6VXNlcjMyNDcwMzU0","avatar_url":"https://avatars0.githubusercontent.com/u/32470354?v=4","gravatar_id":"","url":"https://api.github.com/users/jzulauf-lunarg","html_url":"https://github.com/jzulauf-lunarg","followers_url":"https://api.github.com/users/jzulauf-lunarg/followers","following_url":"https://api.github.com/users/jzulauf-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/jzulauf-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/jzulauf-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzulauf-lunarg/subscriptions","organizations_url":"https://api.github.com/users/jzulauf-lunarg/orgs","repos_url":"https://api.github.com/users/jzulauf-lunarg/repos","events_url":"https://api.github.com/users/jzulauf-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/jzulauf-lunarg/received_events","type":"User","site_admin":false},"body":"by order, it feels like you mean \"ordinal\" ","created_at":"2018-10-09T10:41:25Z","updated_at":"2018-10-09T10:48:24Z","html_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357#discussion_r223647473","pull_request_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/comments/223647473"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357#discussion_r223647473"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357","id":219113713,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTEzNzEz","html_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357","diff_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357.patch","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/357","number":357,"state":"open","locked":false,"title":"Add Validation for VK_KHR_create_renderpass2","user":{"login":"Tobski","id":3466723,"node_id":"MDQ6VXNlcjM0NjY3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3466723?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobski","html_url":"https://github.com/Tobski","followers_url":"https://api.github.com/users/Tobski/followers","following_url":"https://api.github.com/users/Tobski/following{/other_user}","gists_url":"https://api.github.com/users/Tobski/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobski/subscriptions","organizations_url":"https://api.github.com/users/Tobski/orgs","repos_url":"https://api.github.com/users/Tobski/repos","events_url":"https://api.github.com/users/Tobski/events{/privacy}","received_events_url":"https://api.github.com/users/Tobski/received_events","type":"User","site_admin":false},"body":"To achieve decent coverage for VK_KHR_create_renderpass2, I basically ended up implementing several dozen checks for existing renderpass validation holes as well, since there was (unsurprisingly!) enormous overlap. Due to the enormity of this task, I made sure there were tests in place for as many VUIDs as I could manage (though there's a couple I've still not looked at). Unsurprisingly, this is a rather large change to review, so I appreciate it might take some doing.\r\n\r\nThere is some churn in the tests, as I ended up renaming + regrouping several tests so that I could keep all the similar tests together in order to avoid going crazy whilst modifying them (sometimes several at a time needed a similar edit). Hopefully this is ok, I've confirmed the ones I moved all still test the things they were previously testing, and there are several new ones as well.\r\n\r\nThere's definitely scope for slightly more cleanliness in a few areas here, and I'm happy to take such feedback as it's pointed out.\r\n\r\nShould fix #313 ","created_at":"2018-09-29T00:36:28Z","updated_at":"2018-10-09T10:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"824b148a03d64433df95e8a3732688e227cd65a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tobine","id":7526739,"node_id":"MDQ6VXNlcjc1MjY3Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/7526739?v=4","gravatar_id":"","url":"https://api.github.com/users/tobine","html_url":"https://github.com/tobine","followers_url":"https://api.github.com/users/tobine/followers","following_url":"https://api.github.com/users/tobine/following{/other_user}","gists_url":"https://api.github.com/users/tobine/gists{/gist_id}","starred_url":"https://api.github.com/users/tobine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobine/subscriptions","organizations_url":"https://api.github.com/users/tobine/orgs","repos_url":"https://api.github.com/users/tobine/repos","events_url":"https://api.github.com/users/tobine/events{/privacy}","received_events_url":"https://api.github.com/users/tobine/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":921967308,"node_id":"MDU6TGFiZWw5MjE5NjczMDg=","url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/357/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/statuses/6c00756fb3a50c643df7c53e5efc37506d5e2065","head":{"label":"KhronosGroup:VK_KHR_create_renderpass2","ref":"VK_KHR_create_renderpass2","sha":"6c00756fb3a50c643df7c53e5efc37506d5e2065","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":132043451,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwNDM0NTE=","name":"Vulkan-ValidationLayers","full_name":"KhronosGroup/Vulkan-ValidationLayers","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers","description":"Vulkan Validation Layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/deployments","created_at":"2018-05-03T19:59:43Z","updated_at":"2018-10-08T18:51:46Z","pushed_at":"2018-10-09T10:46:28Z","git_url":"git://github.com/KhronosGroup/Vulkan-ValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-ValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers","homepage":"","size":37295,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":141,"watchers":44,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"b4f513e9d8af2986798756c3ca7f9ff972547e7c","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":132043451,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwNDM0NTE=","name":"Vulkan-ValidationLayers","full_name":"KhronosGroup/Vulkan-ValidationLayers","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers","description":"Vulkan Validation Layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/deployments","created_at":"2018-05-03T19:59:43Z","updated_at":"2018-10-08T18:51:46Z","pushed_at":"2018-10-09T10:46:28Z","git_url":"git://github.com/KhronosGroup/Vulkan-ValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-ValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-ValidationLayers","homepage":"","size":37295,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":141,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/357"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/357"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers/statuses/6c00756fb3a50c643df7c53e5efc37506d5e2065"}},"author_association":"NONE"}} | {
"id": 132043451,
"name": "KhronosGroup/Vulkan-ValidationLayers",
"url": "https://api.github.com/repos/KhronosGroup/Vulkan-ValidationLayers"
} | {
"id": 32470354,
"login": "jzulauf-lunarg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32470354?",
"url": "https://api.github.com/users/jzulauf-lunarg"
} | {
"id": 1608701,
"login": "KhronosGroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1608701?",
"url": "https://api.github.com/orgs/KhronosGroup"
} | 2018-10-09T10:41:25 | 8389850945 | {"actor":{"display_login":"jzulauf-lunarg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/comments/188611850","pull_request_review_id":120623811,"id":188611850,"diff_hunk":"@@ -56,18 +53,43 @@ Add the package to the pubspec dependencies:\n build_runner: ^0.8.8\n build_test: ^0.10.2\n build_web_compilers: ^0.4.0\n- test: ^0.12.30\n++ pageloader:\n++ git: https://github.com/google/pageloader.git\n+ test: ^0.12.35\n ```\n \n ## Imports\n \n-Include these imports at the top of your page object class:\n+Include these imports at the top of your page object file:\n \n-<?code-excerpt \"toh-2/test/app_po.dart (imports)\" title?>\n+<?code-excerpt \"toh-1/test/app_po.dart (imports)\" title?>\n ```\n import 'dart:async';\n \n- import 'package:pageloader/objects.dart';\n+ import 'package:pageloader/pageloader.dart';\n+```\n+\n+The `app_po.g.dart` file is generated by the pageloader builder","path":"src/angular/guide/testing/component/page-objects.md","position":63,"original_position":63,"commit_id":"cc86d4d6b01df5282318783022f2c570fd2d2f2f","original_commit_id":"cc86d4d6b01df5282318783022f2c570fd2d2f2f","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"Oops, that should have been taken out of that paragraph (it had been moved to later in the page). Done.","created_at":"2018-05-16T12:51:37Z","updated_at":"2018-05-16T12:51:37Z","html_url":"https://github.com/dart-lang/site-webdev/pull/1585#discussion_r188611850","pull_request_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/comments/188611850"},"html":{"href":"https://github.com/dart-lang/site-webdev/pull/1585#discussion_r188611850"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585"}},"in_reply_to_id":188472389},"pull_request":{"url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585","id":187504921,"html_url":"https://github.com/dart-lang/site-webdev/pull/1585","diff_url":"https://github.com/dart-lang/site-webdev/pull/1585.diff","patch_url":"https://github.com/dart-lang/site-webdev/pull/1585.patch","issue_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/1585","number":1585,"state":"open","locked":false,"title":"[WIP] Upgrade to pageloader 3.0.0-dev","user":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"body":"WIP. Status update:\r\n\r\n- [x] toh-1 to toh-5 have been converted. All tests should be passing.\r\n- [ ] toh-6\r\n- [ ] template-syntax, ...\r\n\r\nStaged at https://angulardart-org-dev2.firebaseapp.com/angular/guide/testing/component/page-objects","created_at":"2018-05-11T16:00:57Z","updated_at":"2018-05-16T12:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3592926cf1d3ef1cb6dee7fe24e51eec5d02d8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":502285333,"url":"https://api.github.com/repos/dart-lang/site-webdev/labels/Examples","name":"Examples","color":"ededed","default":false},{"id":731831910,"url":"https://api.github.com/repos/dart-lang/site-webdev/labels/Tests","name":"Tests","color":"d2e251","default":false},{"id":421018046,"url":"https://api.github.com/repos/dart-lang/site-webdev/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false},{"id":859318438,"url":"https://api.github.com/repos/dart-lang/site-webdev/labels/%E2%9A%A0%20WIP","name":"⚠ WIP","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/dart-lang/site-webdev/milestones/14","html_url":"https://github.com/dart-lang/site-webdev/milestone/14","labels_url":"https://api.github.com/repos/dart-lang/site-webdev/milestones/14/labels","id":3008684,"number":14,"title":"ng5-dev_18Q2","description":"","creator":{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":90,"state":"open","created_at":"2018-01-02T20:35:11Z","updated_at":"2018-05-14T16:20:32Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/1585/comments","statuses_url":"https://api.github.com/repos/dart-lang/site-webdev/statuses/cc86d4d6b01df5282318783022f2c570fd2d2f2f","head":{"label":"dart-lang:chalin-pageloader-v3-0510","ref":"chalin-pageloader-v3-0510","sha":"cc86d4d6b01df5282318783022f2c570fd2d2f2f","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63090054,"name":"site-webdev","full_name":"dart-lang/site-webdev","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-webdev","description":"Source for webdev.dartlang.org","fork":false,"url":"https://api.github.com/repos/dart-lang/site-webdev","forks_url":"https://api.github.com/repos/dart-lang/site-webdev/forks","keys_url":"https://api.github.com/repos/dart-lang/site-webdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-webdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-webdev/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-webdev/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-webdev/events","assignees_url":"https://api.github.com/repos/dart-lang/site-webdev/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-webdev/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-webdev/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-webdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-webdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-webdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-webdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-webdev/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-webdev/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-webdev/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-webdev/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-webdev/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-webdev/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-webdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-webdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-webdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-webdev/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-webdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-webdev/merges","archive_url":"https://api.github.com/repos/dart-lang/site-webdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-webdev/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-webdev/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-webdev/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-webdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-webdev/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-webdev/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-webdev/deployments","created_at":"2016-07-11T17:58:14Z","updated_at":"2018-05-16T00:39:55Z","pushed_at":"2018-05-16T00:40:07Z","git_url":"git://github.com/dart-lang/site-webdev.git","ssh_url":"git@github.com:dart-lang/site-webdev.git","clone_url":"https://github.com/dart-lang/site-webdev.git","svn_url":"https://github.com/dart-lang/site-webdev","homepage":"https://webdev.dartlang.org/","size":24214,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":112,"license":null,"forks":46,"open_issues":112,"watchers":28,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"1156d80a34fb87b9556f8a211f2924182b393d08","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63090054,"name":"site-webdev","full_name":"dart-lang/site-webdev","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-webdev","description":"Source for webdev.dartlang.org","fork":false,"url":"https://api.github.com/repos/dart-lang/site-webdev","forks_url":"https://api.github.com/repos/dart-lang/site-webdev/forks","keys_url":"https://api.github.com/repos/dart-lang/site-webdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-webdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-webdev/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-webdev/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-webdev/events","assignees_url":"https://api.github.com/repos/dart-lang/site-webdev/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-webdev/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-webdev/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-webdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-webdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-webdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-webdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-webdev/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-webdev/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-webdev/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-webdev/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-webdev/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-webdev/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-webdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-webdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-webdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-webdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-webdev/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-webdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-webdev/merges","archive_url":"https://api.github.com/repos/dart-lang/site-webdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-webdev/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-webdev/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-webdev/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-webdev/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-webdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-webdev/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-webdev/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-webdev/deployments","created_at":"2016-07-11T17:58:14Z","updated_at":"2018-05-16T00:39:55Z","pushed_at":"2018-05-16T00:40:07Z","git_url":"git://github.com/dart-lang/site-webdev.git","ssh_url":"git@github.com:dart-lang/site-webdev.git","clone_url":"https://github.com/dart-lang/site-webdev.git","svn_url":"https://github.com/dart-lang/site-webdev","homepage":"https://webdev.dartlang.org/","size":24214,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":112,"license":null,"forks":46,"open_issues":112,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585"},"html":{"href":"https://github.com/dart-lang/site-webdev/pull/1585"},"issue":{"href":"https://api.github.com/repos/dart-lang/site-webdev/issues/1585"},"comments":{"href":"https://api.github.com/repos/dart-lang/site-webdev/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/site-webdev/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/site-webdev/statuses/cc86d4d6b01df5282318783022f2c570fd2d2f2f"}},"author_association":"COLLABORATOR"}} | {
"id": 63090054,
"name": "dart-lang/site-webdev",
"url": "https://api.github.com/repos/dart-lang/site-webdev"
} | {
"id": 4140793,
"login": "chalin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4140793?",
"url": "https://api.github.com/users/chalin"
} | {
"id": 1609975,
"login": "dart-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1609975?",
"url": "https://api.github.com/orgs/dart-lang"
} | 2018-05-16T12:51:37 | 7683100685 | {"actor":{"display_login":"chalin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/comments/233940495","pull_request_review_id":175471192,"id":233940495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk0MDQ5NQ==","diff_hunk":"@@ -55,6 +55,8 @@\n <option disabled></option>\n <!--- Gists at https://gist.github.com/[value] -->\n <option value=\"215ba63265350c02dfbd586dfd30b8c3\">Hello World</option>\n+ <option value=\"e93b969fed77325db0b848a85f1cf78e\">Integers to Doubles</option>","path":"web/index.html","position":null,"original_position":4,"commit_id":"b20221671fc6201c3c33695b92fc160aa46e2e57","original_commit_id":"399e455718b4579ae9b0aae93de047085f64ee68","user":{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-11-15T17:33:48Z","updated_at":"2018-11-15T17:33:48Z","html_url":"https://github.com/dart-lang/dart-pad/pull/873#discussion_r233940495","pull_request_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/comments/233940495"},"html":{"href":"https://github.com/dart-lang/dart-pad/pull/873#discussion_r233940495"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873"}},"in_reply_to_id":233165204},"pull_request":{"url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873","id":229543982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTQzOTgy","html_url":"https://github.com/dart-lang/dart-pad/pull/873","diff_url":"https://github.com/dart-lang/dart-pad/pull/873.diff","patch_url":"https://github.com/dart-lang/dart-pad/pull/873.patch","issue_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/873","number":873,"state":"open","locked":false,"title":"WIP: 2.1 update for dart-pad","user":{"login":"jcollins-g","id":14116827,"node_id":"MDQ6VXNlcjE0MTE2ODI3","avatar_url":"https://avatars3.githubusercontent.com/u/14116827?v=4","gravatar_id":"","url":"https://api.github.com/users/jcollins-g","html_url":"https://github.com/jcollins-g","followers_url":"https://api.github.com/users/jcollins-g/followers","following_url":"https://api.github.com/users/jcollins-g/following{/other_user}","gists_url":"https://api.github.com/users/jcollins-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jcollins-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcollins-g/subscriptions","organizations_url":"https://api.github.com/users/jcollins-g/orgs","repos_url":"https://api.github.com/users/jcollins-g/repos","events_url":"https://api.github.com/users/jcollins-g/events{/privacy}","received_events_url":"https://api.github.com/users/jcollins-g/received_events","type":"User","site_admin":false},"body":"Fixes #867.\r\n\r\nDo not land; contains the test version URL.\r\n\r\nServing at https://jcollins-210dev93-test-dot-dart-pad.appspot.com/","created_at":"2018-11-08T23:38:14Z","updated_at":"2018-11-15T17:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efec11baf51021d5b903553afc3a33eb38819a1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":421017814,"node_id":"MDU6TGFiZWw0MjEwMTc4MTQ=","url":"https://api.github.com/repos/dart-lang/dart-pad/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873/commits","review_comments_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873/comments","review_comment_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/873/comments","statuses_url":"https://api.github.com/repos/dart-lang/dart-pad/statuses/b20221671fc6201c3c33695b92fc160aa46e2e57","head":{"label":"dart-lang:2.1-dartpad","ref":"2.1-dartpad","sha":"b20221671fc6201c3c33695b92fc160aa46e2e57","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":28887852,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4Nzg1Mg==","name":"dart-pad","full_name":"dart-lang/dart-pad","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/dart-pad","description":"The UI client for a web based interactive Dart service","fork":false,"url":"https://api.github.com/repos/dart-lang/dart-pad","forks_url":"https://api.github.com/repos/dart-lang/dart-pad/forks","keys_url":"https://api.github.com/repos/dart-lang/dart-pad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/dart-pad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/dart-pad/teams","hooks_url":"https://api.github.com/repos/dart-lang/dart-pad/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/dart-pad/events","assignees_url":"https://api.github.com/repos/dart-lang/dart-pad/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/dart-pad/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/dart-pad/tags","blobs_url":"https://api.github.com/repos/dart-lang/dart-pad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/dart-pad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/dart-pad/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/dart-pad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/dart-pad/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/dart-pad/languages","stargazers_url":"https://api.github.com/repos/dart-lang/dart-pad/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/dart-pad/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/dart-pad/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/dart-pad/subscription","commits_url":"https://api.github.com/repos/dart-lang/dart-pad/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/dart-pad/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/dart-pad/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/dart-pad/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/dart-pad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/dart-pad/merges","archive_url":"https://api.github.com/repos/dart-lang/dart-pad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/dart-pad/downloads","issues_url":"https://api.github.com/repos/dart-lang/dart-pad/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/dart-pad/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/dart-pad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/dart-pad/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/dart-pad/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/dart-pad/deployments","created_at":"2015-01-06T23:04:55Z","updated_at":"2018-11-13T18:19:15Z","pushed_at":"2018-11-15T16:59:53Z","git_url":"git://github.com/dart-lang/dart-pad.git","ssh_url":"git@github.com:dart-lang/dart-pad.git","clone_url":"https://github.com/dart-lang/dart-pad.git","svn_url":"https://github.com/dart-lang/dart-pad","homepage":"https://dartpad.dartlang.org/","size":8517,"stargazers_count":135,"watchers_count":135,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":36,"open_issues":57,"watchers":135,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"e13d8fb4c2663c9b19512cd37bec9927f66072cd","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":28887852,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4Nzg1Mg==","name":"dart-pad","full_name":"dart-lang/dart-pad","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/dart-pad","description":"The UI client for a web based interactive Dart service","fork":false,"url":"https://api.github.com/repos/dart-lang/dart-pad","forks_url":"https://api.github.com/repos/dart-lang/dart-pad/forks","keys_url":"https://api.github.com/repos/dart-lang/dart-pad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/dart-pad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/dart-pad/teams","hooks_url":"https://api.github.com/repos/dart-lang/dart-pad/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/dart-pad/events","assignees_url":"https://api.github.com/repos/dart-lang/dart-pad/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/dart-pad/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/dart-pad/tags","blobs_url":"https://api.github.com/repos/dart-lang/dart-pad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/dart-pad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/dart-pad/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/dart-pad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/dart-pad/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/dart-pad/languages","stargazers_url":"https://api.github.com/repos/dart-lang/dart-pad/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/dart-pad/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/dart-pad/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/dart-pad/subscription","commits_url":"https://api.github.com/repos/dart-lang/dart-pad/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/dart-pad/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/dart-pad/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/dart-pad/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/dart-pad/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/dart-pad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/dart-pad/merges","archive_url":"https://api.github.com/repos/dart-lang/dart-pad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/dart-pad/downloads","issues_url":"https://api.github.com/repos/dart-lang/dart-pad/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/dart-pad/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/dart-pad/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/dart-pad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/dart-pad/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/dart-pad/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/dart-pad/deployments","created_at":"2015-01-06T23:04:55Z","updated_at":"2018-11-13T18:19:15Z","pushed_at":"2018-11-15T16:59:53Z","git_url":"git://github.com/dart-lang/dart-pad.git","ssh_url":"git@github.com:dart-lang/dart-pad.git","clone_url":"https://github.com/dart-lang/dart-pad.git","svn_url":"https://github.com/dart-lang/dart-pad","homepage":"https://dartpad.dartlang.org/","size":8517,"stargazers_count":135,"watchers_count":135,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":36,"open_issues":57,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873"},"html":{"href":"https://github.com/dart-lang/dart-pad/pull/873"},"issue":{"href":"https://api.github.com/repos/dart-lang/dart-pad/issues/873"},"comments":{"href":"https://api.github.com/repos/dart-lang/dart-pad/issues/873/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/dart-pad/pulls/873/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/dart-pad/statuses/b20221671fc6201c3c33695b92fc160aa46e2e57"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28887852,
"name": "dart-lang/dart-pad",
"url": "https://api.github.com/repos/dart-lang/dart-pad"
} | {
"id": 14116827,
"login": "jcollins-g",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14116827?",
"url": "https://api.github.com/users/jcollins-g"
} | {
"id": 1609975,
"login": "dart-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1609975?",
"url": "https://api.github.com/orgs/dart-lang"
} | 2018-11-15T17:33:48 | 8597068530 | {"actor":{"display_login":"jcollins-g"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/comments/204333338","pull_request_review_id":139392115,"id":204333338,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDMzMzMzOA==","diff_hunk":"@@ -16,12 +16,10 @@ disabled by default.\n Enabling External Storage Support\n ---------------------------------\n \n-.. warning:: Enabling this app will disable the **Stay logged in** checkbox on the login page.\n+Tick the check box under Settings > Storage > \"Enable External Storage\".","path":"admin_manual/configuration/files/external_storage_configuration_gui.rst","position":5,"original_position":5,"commit_id":"7830b1ecd9d31e12ecfb1e8e9f904a8e7c07766e","original_commit_id":"7830b1ecd9d31e12ecfb1e8e9f904a8e7c07766e","user":{"login":"settermjd","id":196801,"node_id":"MDQ6VXNlcjE5NjgwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/196801?v=4","gravatar_id":"","url":"https://api.github.com/users/settermjd","html_url":"https://github.com/settermjd","followers_url":"https://api.github.com/users/settermjd/followers","following_url":"https://api.github.com/users/settermjd/following{/other_user}","gists_url":"https://api.github.com/users/settermjd/gists{/gist_id}","starred_url":"https://api.github.com/users/settermjd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/settermjd/subscriptions","organizations_url":"https://api.github.com/users/settermjd/orgs","repos_url":"https://api.github.com/users/settermjd/repos","events_url":"https://api.github.com/users/settermjd/events{/privacy}","received_events_url":"https://api.github.com/users/settermjd/received_events","type":"User","site_admin":false},"body":"s/check box/checkbox/g","created_at":"2018-07-23T09:16:46Z","updated_at":"2018-07-23T09:16:46Z","html_url":"https://github.com/owncloud/documentation/pull/4290#discussion_r204333338","pull_request_url":"https://api.github.com/repos/owncloud/documentation/pulls/4290","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments/204333338"},"html":{"href":"https://github.com/owncloud/documentation/pull/4290#discussion_r204333338"},"pull_request":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/4290"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/documentation/pulls/4290","id":201664096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjY0MDk2","html_url":"https://github.com/owncloud/documentation/pull/4290","diff_url":"https://github.com/owncloud/documentation/pull/4290.diff","patch_url":"https://github.com/owncloud/documentation/pull/4290.patch","issue_url":"https://api.github.com/repos/owncloud/documentation/issues/4290","number":4290,"state":"open","locked":false,"title":"Update external_storage_configuration_gui.rst","user":{"login":"voroyam","id":24212810,"node_id":"MDQ6VXNlcjI0MjEyODEw","avatar_url":"https://avatars0.githubusercontent.com/u/24212810?v=4","gravatar_id":"","url":"https://api.github.com/users/voroyam","html_url":"https://github.com/voroyam","followers_url":"https://api.github.com/users/voroyam/followers","following_url":"https://api.github.com/users/voroyam/following{/other_user}","gists_url":"https://api.github.com/users/voroyam/gists{/gist_id}","starred_url":"https://api.github.com/users/voroyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voroyam/subscriptions","organizations_url":"https://api.github.com/users/voroyam/orgs","repos_url":"https://api.github.com/users/voroyam/repos","events_url":"https://api.github.com/users/voroyam/events{/privacy}","received_events_url":"https://api.github.com/users/voroyam/received_events","type":"User","site_admin":false},"body":"new pictures, added FTP notice","created_at":"2018-07-16T14:55:03Z","updated_at":"2018-07-23T09:16:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2daa35ff8f0617635e3217f54295a4bbf7298fe7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":103463422,"node_id":"MDU6TGFiZWwxMDM0NjM0MjI=","url":"https://api.github.com/repos/owncloud/documentation/labels/Ready%20for%20Review","name":"Ready for Review","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/documentation/pulls/4290/commits","review_comments_url":"https://api.github.com/repos/owncloud/documentation/pulls/4290/comments","review_comment_url":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/documentation/issues/4290/comments","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/7830b1ecd9d31e12ecfb1e8e9f904a8e7c07766e","head":{"label":"owncloud:external-storage-update","ref":"external-storage-update","sha":"7830b1ecd9d31e12ecfb1e8e9f904a8e7c07766e","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MTcy","name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":":blue_book: The ownCloud documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/documentation/deployments","created_at":"2012-10-26T14:36:00Z","updated_at":"2018-07-23T09:03:47Z","pushed_at":"2018-07-23T09:12:14Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":"https://doc.owncloud.com/","size":143383,"stargazers_count":183,"watchers_count":183,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":202,"open_issues":170,"watchers":183,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"de7c3f16fff7ab01e513bdbb942e6252b5a74af8","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6405172,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MTcy","name":"documentation","full_name":"owncloud/documentation","owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/documentation","description":":blue_book: The ownCloud documentation and manual","fork":false,"url":"https://api.github.com/repos/owncloud/documentation","forks_url":"https://api.github.com/repos/owncloud/documentation/forks","keys_url":"https://api.github.com/repos/owncloud/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/documentation/teams","hooks_url":"https://api.github.com/repos/owncloud/documentation/hooks","issue_events_url":"https://api.github.com/repos/owncloud/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/documentation/events","assignees_url":"https://api.github.com/repos/owncloud/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/documentation/tags","blobs_url":"https://api.github.com/repos/owncloud/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/documentation/languages","stargazers_url":"https://api.github.com/repos/owncloud/documentation/stargazers","contributors_url":"https://api.github.com/repos/owncloud/documentation/contributors","subscribers_url":"https://api.github.com/repos/owncloud/documentation/subscribers","subscription_url":"https://api.github.com/repos/owncloud/documentation/subscription","commits_url":"https://api.github.com/repos/owncloud/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/documentation/merges","archive_url":"https://api.github.com/repos/owncloud/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/documentation/downloads","issues_url":"https://api.github.com/repos/owncloud/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/documentation/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/documentation/deployments","created_at":"2012-10-26T14:36:00Z","updated_at":"2018-07-23T09:03:47Z","pushed_at":"2018-07-23T09:12:14Z","git_url":"git://github.com/owncloud/documentation.git","ssh_url":"git@github.com:owncloud/documentation.git","clone_url":"https://github.com/owncloud/documentation.git","svn_url":"https://github.com/owncloud/documentation","homepage":"https://doc.owncloud.com/","size":143383,"stargazers_count":183,"watchers_count":183,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":202,"open_issues":170,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/4290"},"html":{"href":"https://github.com/owncloud/documentation/pull/4290"},"issue":{"href":"https://api.github.com/repos/owncloud/documentation/issues/4290"},"comments":{"href":"https://api.github.com/repos/owncloud/documentation/issues/4290/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/4290/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/documentation/pulls/4290/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/documentation/statuses/7830b1ecd9d31e12ecfb1e8e9f904a8e7c07766e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6405172,
"name": "owncloud/documentation",
"url": "https://api.github.com/repos/owncloud/documentation"
} | {
"id": 196801,
"login": "settermjd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/196801?",
"url": "https://api.github.com/users/settermjd"
} | {
"id": 1645051,
"login": "owncloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1645051?",
"url": "https://api.github.com/orgs/owncloud"
} | 2018-07-23T09:16:46 | 8002669657 | {"actor":{"display_login":"settermjd"}} |
Subsets and Splits