type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments/222288133","pull_request_review_id":161135928,"id":222288133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjI4ODEzMw==","diff_hunk":"@@ -92,6 +92,12 @@ type BinlogEventRule struct {\n \tAction ActionType `json:\"action\" toml:\"action\" yaml:\"action\"`\n }\n \n+// ToLower covert schema/table parttern to lower case","path":"pkg/binlog-filter/filter.go","position":4,"original_position":4,"commit_id":"88067977c2e322ca8f3dbc635450ab2ec41ca182","original_commit_id":"88067977c2e322ca8f3dbc635450ab2ec41ca182","user":{"login":"csuzhangxc","id":3183039,"node_id":"MDQ6VXNlcjMxODMwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3183039?v=4","gravatar_id":"","url":"https://api.github.com/users/csuzhangxc","html_url":"https://github.com/csuzhangxc","followers_url":"https://api.github.com/users/csuzhangxc/followers","following_url":"https://api.github.com/users/csuzhangxc/following{/other_user}","gists_url":"https://api.github.com/users/csuzhangxc/gists{/gist_id}","starred_url":"https://api.github.com/users/csuzhangxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csuzhangxc/subscriptions","organizations_url":"https://api.github.com/users/csuzhangxc/orgs","repos_url":"https://api.github.com/users/csuzhangxc/repos","events_url":"https://api.github.com/users/csuzhangxc/events{/privacy}","received_events_url":"https://api.github.com/users/csuzhangxc/received_events","type":"User","site_admin":false},"body":"you can update typo in L71. `ClassifyEevent` to `ClassifyEvent`","created_at":"2018-10-03T12:26:46Z","updated_at":"2018-10-03T12:30:45Z","html_url":"https://github.com/pingcap/tidb-tools/pull/76#discussion_r222288133","pull_request_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments/222288133"},"html":{"href":"https://github.com/pingcap/tidb-tools/pull/76#discussion_r222288133"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76","id":219900318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTAwMzE4","html_url":"https://github.com/pingcap/tidb-tools/pull/76","diff_url":"https://github.com/pingcap/tidb-tools/pull/76.diff","patch_url":"https://github.com/pingcap/tidb-tools/pull/76.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/76","number":76,"state":"open","locked":false,"title":"*: support case sensitive in binlog-filter. column-mapping. table route","user":{"login":"GregoryIan","id":10701973,"node_id":"MDQ6VXNlcjEwNzAxOTcz","avatar_url":"https://avatars3.githubusercontent.com/u/10701973?v=4","gravatar_id":"","url":"https://api.github.com/users/GregoryIan","html_url":"https://github.com/GregoryIan","followers_url":"https://api.github.com/users/GregoryIan/followers","following_url":"https://api.github.com/users/GregoryIan/following{/other_user}","gists_url":"https://api.github.com/users/GregoryIan/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryIan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryIan/subscriptions","organizations_url":"https://api.github.com/users/GregoryIan/orgs","repos_url":"https://api.github.com/users/GregoryIan/repos","events_url":"https://api.github.com/users/GregoryIan/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryIan/received_events","type":"User","site_admin":false},"body":"@csuzhangxc PTAL","created_at":"2018-10-03T02:48:05Z","updated_at":"2018-10-03T12:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2189c7dbd414732e5a664d0eafe701c4a2d79b08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/76/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/88067977c2e322ca8f3dbc635450ab2ec41ca182","head":{"label":"pingcap:ian/case-sensitive","ref":"ian/case-sensitive","sha":"88067977c2e322ca8f3dbc635450ab2ec41ca182","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":93518223,"node_id":"MDEwOlJlcG9zaXRvcnk5MzUxODIyMw==","name":"tidb-tools","full_name":"pingcap/tidb-tools","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb-tools","description":"tidb-tools are some useful tool collections for TiDB.","fork":false,"url":"https://api.github.com/repos/pingcap/tidb-tools","forks_url":"https://api.github.com/repos/pingcap/tidb-tools/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-tools/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-tools/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-tools/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-tools/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-tools/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-tools/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-tools/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-tools/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-tools/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-tools/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-tools/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-tools/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-tools/deployments","created_at":"2017-06-06T12:53:46Z","updated_at":"2018-10-02T11:55:13Z","pushed_at":"2018-10-03T03:45:43Z","git_url":"git://github.com/pingcap/tidb-tools.git","ssh_url":"git@github.com:pingcap/tidb-tools.git","clone_url":"https://github.com/pingcap/tidb-tools.git","svn_url":"https://github.com/pingcap/tidb-tools","homepage":"","size":7060,"stargazers_count":54,"watchers_count":54,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":5,"watchers":54,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"f2da141ada137b7b776985b67393763982b458fa","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":93518223,"node_id":"MDEwOlJlcG9zaXRvcnk5MzUxODIyMw==","name":"tidb-tools","full_name":"pingcap/tidb-tools","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb-tools","description":"tidb-tools are some useful tool collections for TiDB.","fork":false,"url":"https://api.github.com/repos/pingcap/tidb-tools","forks_url":"https://api.github.com/repos/pingcap/tidb-tools/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-tools/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-tools/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-tools/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-tools/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-tools/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-tools/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-tools/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-tools/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-tools/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-tools/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-tools/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-tools/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-tools/deployments","created_at":"2017-06-06T12:53:46Z","updated_at":"2018-10-02T11:55:13Z","pushed_at":"2018-10-03T03:45:43Z","git_url":"git://github.com/pingcap/tidb-tools.git","ssh_url":"git@github.com:pingcap/tidb-tools.git","clone_url":"https://github.com/pingcap/tidb-tools.git","svn_url":"https://github.com/pingcap/tidb-tools","homepage":"","size":7060,"stargazers_count":54,"watchers_count":54,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":5,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76"},"html":{"href":"https://github.com/pingcap/tidb-tools/pull/76"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-tools/issues/76"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-tools/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-tools/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-tools/statuses/88067977c2e322ca8f3dbc635450ab2ec41ca182"}},"author_association":"CONTRIBUTOR"}} | {
"id": 93518223,
"name": "pingcap/tidb-tools",
"url": "https://api.github.com/repos/pingcap/tidb-tools"
} | {
"id": 3183039,
"login": "csuzhangxc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3183039?",
"url": "https://api.github.com/users/csuzhangxc"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2018-10-03T12:26:46 | 8360735349 | {"actor":{"display_login":"csuzhangxc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/173610348","pull_request_review_id":102838681,"id":173610348,"diff_hunk":"@@ -58,41 +58,11 @@ type ShowExec struct {\n \tis infoschema.InfoSchema\n \n \tforChunk bool","path":"executor/show.go","position":3,"original_position":3,"commit_id":"1493a23d98f1ac43aba471e1a77c77d594948b7e","original_commit_id":"1493a23d98f1ac43aba471e1a77c77d594948b7e","user":{"login":"zz-jason","id":5268763,"avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"body":"after removing `Next`, `forChunk` will always be true, which should also be removed.","created_at":"2018-03-10T03:31:02Z","updated_at":"2018-03-10T03:31:02Z","html_url":"https://github.com/pingcap/tidb/pull/5998#discussion_r173610348","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/5998","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/173610348"},"html":{"href":"https://github.com/pingcap/tidb/pull/5998#discussion_r173610348"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5998"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/5998","id":174150566,"html_url":"https://github.com/pingcap/tidb/pull/5998","diff_url":"https://github.com/pingcap/tidb/pull/5998.diff","patch_url":"https://github.com/pingcap/tidb/pull/5998.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/5998","number":5998,"state":"open","locked":false,"title":"executor: remove Next function for ShowExec","user":{"login":"Anteoy","id":17495446,"avatar_url":"https://avatars0.githubusercontent.com/u/17495446?v=4","gravatar_id":"","url":"https://api.github.com/users/Anteoy","html_url":"https://github.com/Anteoy","followers_url":"https://api.github.com/users/Anteoy/followers","following_url":"https://api.github.com/users/Anteoy/following{/other_user}","gists_url":"https://api.github.com/users/Anteoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Anteoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anteoy/subscriptions","organizations_url":"https://api.github.com/users/Anteoy/orgs","repos_url":"https://api.github.com/users/Anteoy/repos","events_url":"https://api.github.com/users/Anteoy/events{/privacy}","received_events_url":"https://api.github.com/users/Anteoy/received_events","type":"User","site_admin":false},"body":"PTAL @zz-jason @coocood\r\n\r\nTo [#5985](https://github.com/pingcap/tidb/issues/5985)","created_at":"2018-03-10T03:23:31Z","updated_at":"2018-03-10T03:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fac826d4b98f08d76b5b96e44e4e47192d8d2bff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/5998/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/5998/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/5998/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/1493a23d98f1ac43aba471e1a77c77d594948b7e","head":{"label":"Anteoy:remove_show_next","ref":"remove_show_next","sha":"1493a23d98f1ac43aba471e1a77c77d594948b7e","user":{"login":"Anteoy","id":17495446,"avatar_url":"https://avatars0.githubusercontent.com/u/17495446?v=4","gravatar_id":"","url":"https://api.github.com/users/Anteoy","html_url":"https://github.com/Anteoy","followers_url":"https://api.github.com/users/Anteoy/followers","following_url":"https://api.github.com/users/Anteoy/following{/other_user}","gists_url":"https://api.github.com/users/Anteoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Anteoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anteoy/subscriptions","organizations_url":"https://api.github.com/users/Anteoy/orgs","repos_url":"https://api.github.com/users/Anteoy/repos","events_url":"https://api.github.com/users/Anteoy/events{/privacy}","received_events_url":"https://api.github.com/users/Anteoy/received_events","type":"User","site_admin":false},"repo":{"id":88353774,"name":"tidb","full_name":"Anteoy/tidb","owner":{"login":"Anteoy","id":17495446,"avatar_url":"https://avatars0.githubusercontent.com/u/17495446?v=4","gravatar_id":"","url":"https://api.github.com/users/Anteoy","html_url":"https://github.com/Anteoy","followers_url":"https://api.github.com/users/Anteoy/followers","following_url":"https://api.github.com/users/Anteoy/following{/other_user}","gists_url":"https://api.github.com/users/Anteoy/gists{/gist_id}","starred_url":"https://api.github.com/users/Anteoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anteoy/subscriptions","organizations_url":"https://api.github.com/users/Anteoy/orgs","repos_url":"https://api.github.com/users/Anteoy/repos","events_url":"https://api.github.com/users/Anteoy/events{/privacy}","received_events_url":"https://api.github.com/users/Anteoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Anteoy/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/Anteoy/tidb","forks_url":"https://api.github.com/repos/Anteoy/tidb/forks","keys_url":"https://api.github.com/repos/Anteoy/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anteoy/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anteoy/tidb/teams","hooks_url":"https://api.github.com/repos/Anteoy/tidb/hooks","issue_events_url":"https://api.github.com/repos/Anteoy/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/Anteoy/tidb/events","assignees_url":"https://api.github.com/repos/Anteoy/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/Anteoy/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/Anteoy/tidb/tags","blobs_url":"https://api.github.com/repos/Anteoy/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anteoy/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anteoy/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anteoy/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anteoy/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/Anteoy/tidb/languages","stargazers_url":"https://api.github.com/repos/Anteoy/tidb/stargazers","contributors_url":"https://api.github.com/repos/Anteoy/tidb/contributors","subscribers_url":"https://api.github.com/repos/Anteoy/tidb/subscribers","subscription_url":"https://api.github.com/repos/Anteoy/tidb/subscription","commits_url":"https://api.github.com/repos/Anteoy/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anteoy/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anteoy/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anteoy/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anteoy/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/Anteoy/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anteoy/tidb/merges","archive_url":"https://api.github.com/repos/Anteoy/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anteoy/tidb/downloads","issues_url":"https://api.github.com/repos/Anteoy/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/Anteoy/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/Anteoy/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/Anteoy/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anteoy/tidb/labels{/name}","releases_url":"https://api.github.com/repos/Anteoy/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/Anteoy/tidb/deployments","created_at":"2017-04-15T14:55:41Z","updated_at":"2017-04-15T14:55:45Z","pushed_at":"2018-03-10T03:19:00Z","git_url":"git://github.com/Anteoy/tidb.git","ssh_url":"git@github.com:Anteoy/tidb.git","clone_url":"https://github.com/Anteoy/tidb.git","svn_url":"https://github.com/Anteoy/tidb","homepage":"","size":42708,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"4a0e771cdd6414fb19560f3aa99630b03ab493bb","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-03-10T02:36:49Z","pushed_at":"2018-03-10T03:23:32Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":68686,"stargazers_count":12029,"watchers_count":12029,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1630,"mirror_url":null,"archived":false,"open_issues_count":394,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1630,"open_issues":394,"watchers":12029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5998"},"html":{"href":"https://github.com/pingcap/tidb/pull/5998"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/5998"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/5998/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5998/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5998/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/1493a23d98f1ac43aba471e1a77c77d594948b7e"}},"author_association":"NONE"}} | {
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
} | {
"id": 5268763,
"login": "zz-jason",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5268763?",
"url": "https://api.github.com/users/zz-jason"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2018-03-10T03:31:02 | 7359221628 | {"actor":{"display_login":"zz-jason"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/docs/pulls/comments/239330479","pull_request_review_id":182086416,"id":239330479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTMzMDQ3OQ==","diff_hunk":"@@ -319,32 +319,6 @@ SELECT /*+ TIDB_HJ(t1, t2) */ * from t1, t2 where t1.id = t2.id\n \n This variable is used to remind the optimizer to use the `Hash Join` algorithm. This algorithm executes threads concurrently. It runs faster but takes up more memory.\n \n-## _tidb_rowid\n-\n-This is a hidden column of TiDB, which represents the column name of the implicit ROW ID. It only exists on the tables with non-integer PK or without PK. You can execute the `SELECT`, `INSERT`, `UPDATE` and `DELETE` statements on this column, and the usage of these statements are as follows:\n-\n-- `SELECT`: `SELECT *, _tidb_rowid from t;`\n-- `INSERT`: `INSERT t (c, _tidb_rowid) VALUES (1, 1);`\n-- `UPDATE`: `UPDATE t SET c = c + 1 WHERE _tidb_rowid = 1;`\n-- `DELETE`: `DELETE FROM t WHERE _tidb_rowid = 1;`\n-\n-## SHARD_ROW_ID_BITS","path":"sql/tidb-specific.md","position":13,"original_position":13,"commit_id":"15e25b06ae2817f5cdfd22311857adb2ba9c82e7","original_commit_id":"15e25b06ae2817f5cdfd22311857adb2ba9c82e7","user":{"login":"lilin90","id":30922556,"node_id":"MDQ6VXNlcjMwOTIyNTU2","avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false},"body":"@GregoryIan What do you think about keeping the `SHARD_ROW_ID_BITS` section?","created_at":"2018-12-06T05:15:41Z","updated_at":"2018-12-06T05:15:41Z","html_url":"https://github.com/pingcap/docs/pull/801#discussion_r239330479","pull_request_url":"https://api.github.com/repos/pingcap/docs/pulls/801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/docs/pulls/comments/239330479"},"html":{"href":"https://github.com/pingcap/docs/pull/801#discussion_r239330479"},"pull_request":{"href":"https://api.github.com/repos/pingcap/docs/pulls/801"}},"in_reply_to_id":238974625},"pull_request":{"url":"https://api.github.com/repos/pingcap/docs/pulls/801","id":236089049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDg5MDQ5","html_url":"https://github.com/pingcap/docs/pull/801","diff_url":"https://github.com/pingcap/docs/pull/801.diff","patch_url":"https://github.com/pingcap/docs/pull/801.patch","issue_url":"https://api.github.com/repos/pingcap/docs/issues/801","number":801,"state":"open","locked":false,"title":"sql, tools: remove \"_tidb_rowid\"","user":{"login":"lilin90","id":30922556,"node_id":"MDQ6VXNlcjMwOTIyNTU2","avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false},"body":"@GregoryIan @CaitinChen PTAL\r\n\r\nVia: https://github.com/pingcap/docs-cn/pull/1037","created_at":"2018-12-05T08:44:33Z","updated_at":"2018-12-06T05:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"283463b59dee894d21ed4eef46d7b8189527fb3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shenli","id":1192573,"node_id":"MDQ6VXNlcjExOTI1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1192573?v=4","gravatar_id":"","url":"https://api.github.com/users/shenli","html_url":"https://github.com/shenli","followers_url":"https://api.github.com/users/shenli/followers","following_url":"https://api.github.com/users/shenli/following{/other_user}","gists_url":"https://api.github.com/users/shenli/gists{/gist_id}","starred_url":"https://api.github.com/users/shenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenli/subscriptions","organizations_url":"https://api.github.com/users/shenli/orgs","repos_url":"https://api.github.com/users/shenli/repos","events_url":"https://api.github.com/users/shenli/events{/privacy}","received_events_url":"https://api.github.com/users/shenli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/docs/pulls/801/commits","review_comments_url":"https://api.github.com/repos/pingcap/docs/pulls/801/comments","review_comment_url":"https://api.github.com/repos/pingcap/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/docs/issues/801/comments","statuses_url":"https://api.github.com/repos/pingcap/docs/statuses/15e25b06ae2817f5cdfd22311857adb2ba9c82e7","head":{"label":"lilin90:remove-tidb-rowid","ref":"remove-tidb-rowid","sha":"15e25b06ae2817f5cdfd22311857adb2ba9c82e7","user":{"login":"lilin90","id":30922556,"node_id":"MDQ6VXNlcjMwOTIyNTU2","avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false},"repo":{"id":116111014,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxMTEwMTQ=","name":"docs","full_name":"lilin90/docs","private":false,"owner":{"login":"lilin90","id":30922556,"node_id":"MDQ6VXNlcjMwOTIyNTU2","avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lilin90/docs","description":"TiDB/TiKV/PD documents.","fork":true,"url":"https://api.github.com/repos/lilin90/docs","forks_url":"https://api.github.com/repos/lilin90/docs/forks","keys_url":"https://api.github.com/repos/lilin90/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lilin90/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lilin90/docs/teams","hooks_url":"https://api.github.com/repos/lilin90/docs/hooks","issue_events_url":"https://api.github.com/repos/lilin90/docs/issues/events{/number}","events_url":"https://api.github.com/repos/lilin90/docs/events","assignees_url":"https://api.github.com/repos/lilin90/docs/assignees{/user}","branches_url":"https://api.github.com/repos/lilin90/docs/branches{/branch}","tags_url":"https://api.github.com/repos/lilin90/docs/tags","blobs_url":"https://api.github.com/repos/lilin90/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lilin90/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lilin90/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lilin90/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lilin90/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/lilin90/docs/languages","stargazers_url":"https://api.github.com/repos/lilin90/docs/stargazers","contributors_url":"https://api.github.com/repos/lilin90/docs/contributors","subscribers_url":"https://api.github.com/repos/lilin90/docs/subscribers","subscription_url":"https://api.github.com/repos/lilin90/docs/subscription","commits_url":"https://api.github.com/repos/lilin90/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lilin90/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lilin90/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lilin90/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lilin90/docs/contents/{+path}","compare_url":"https://api.github.com/repos/lilin90/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lilin90/docs/merges","archive_url":"https://api.github.com/repos/lilin90/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lilin90/docs/downloads","issues_url":"https://api.github.com/repos/lilin90/docs/issues{/number}","pulls_url":"https://api.github.com/repos/lilin90/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/lilin90/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/lilin90/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lilin90/docs/labels{/name}","releases_url":"https://api.github.com/repos/lilin90/docs/releases{/id}","deployments_url":"https://api.github.com/repos/lilin90/docs/deployments","created_at":"2018-01-03T08:18:49Z","updated_at":"2018-12-05T07:07:37Z","pushed_at":"2018-12-05T08:57:03Z","git_url":"git://github.com/lilin90/docs.git","ssh_url":"git@github.com:lilin90/docs.git","clone_url":"https://github.com/lilin90/docs.git","svn_url":"https://github.com/lilin90/docs","homepage":"https://pingcap.github.io/docs","size":21195,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"2f3d8ed8e904190f8de39fc397ed98f8ff1ef2e3","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":63995402,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzk5NTQwMg==","name":"docs","full_name":"pingcap/docs","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/docs","description":"TiDB/TiKV/PD documents.","fork":false,"url":"https://api.github.com/repos/pingcap/docs","forks_url":"https://api.github.com/repos/pingcap/docs/forks","keys_url":"https://api.github.com/repos/pingcap/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/docs/teams","hooks_url":"https://api.github.com/repos/pingcap/docs/hooks","issue_events_url":"https://api.github.com/repos/pingcap/docs/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/docs/events","assignees_url":"https://api.github.com/repos/pingcap/docs/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/docs/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/docs/tags","blobs_url":"https://api.github.com/repos/pingcap/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/docs/languages","stargazers_url":"https://api.github.com/repos/pingcap/docs/stargazers","contributors_url":"https://api.github.com/repos/pingcap/docs/contributors","subscribers_url":"https://api.github.com/repos/pingcap/docs/subscribers","subscription_url":"https://api.github.com/repos/pingcap/docs/subscription","commits_url":"https://api.github.com/repos/pingcap/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/docs/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/docs/merges","archive_url":"https://api.github.com/repos/pingcap/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/docs/downloads","issues_url":"https://api.github.com/repos/pingcap/docs/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/docs/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/docs/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/docs/deployments","created_at":"2016-07-23T02:39:04Z","updated_at":"2018-12-05T08:57:01Z","pushed_at":"2018-12-06T04:49:23Z","git_url":"git://github.com/pingcap/docs.git","ssh_url":"git@github.com:pingcap/docs.git","clone_url":"https://github.com/pingcap/docs.git","svn_url":"https://github.com/pingcap/docs","homepage":"https://www.pingcap.com/docs/","size":29345,"stargazers_count":229,"watchers_count":229,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":22,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/docs/pulls/801"},"html":{"href":"https://github.com/pingcap/docs/pull/801"},"issue":{"href":"https://api.github.com/repos/pingcap/docs/issues/801"},"comments":{"href":"https://api.github.com/repos/pingcap/docs/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/docs/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/docs/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/docs/statuses/15e25b06ae2817f5cdfd22311857adb2ba9c82e7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 63995402,
"name": "pingcap/docs",
"url": "https://api.github.com/repos/pingcap/docs"
} | {
"id": 30922556,
"login": "lilin90",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30922556?",
"url": "https://api.github.com/users/lilin90"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2018-12-06T05:15:41 | 8706889089 | {"actor":{"display_login":"lilin90"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/201294861","pull_request_review_id":135765779,"id":201294861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTI5NDg2MQ==","diff_hunk":"@@ -48,7 +48,19 @@ impl<S: Snapshot + 'static> DAGContext<S> {\n req_ctx: ReqContext,\n batch_row_limit: usize,\n ) -> Result<Self> {\n- let mut eval_cfg = box_try!(EvalConfig::new(req.get_time_zone_offset(), req.get_flags(),));\n+ let mut eval_cfg = {\n+ let time_zone_name = if req.has_time_zone_name() {","path":"src/coprocessor/dag/dag.rs","position":6,"original_position":6,"commit_id":"99ab891a9dd20b5ab5b7366450129dc88d6307f3","original_commit_id":"99ab891a9dd20b5ab5b7366450129dc88d6307f3","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"Nice idea. BTW I think we can refine it to a XxxBuilder style, which can be handed over to contributors.","created_at":"2018-07-10T10:36:58Z","updated_at":"2018-07-10T10:36:59Z","html_url":"https://github.com/pingcap/tikv/pull/3281#discussion_r201294861","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/3281","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/201294861"},"html":{"href":"https://github.com/pingcap/tikv/pull/3281#discussion_r201294861"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3281"}},"in_reply_to_id":201286028},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/3281","id":198868480,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODY4NDgw","html_url":"https://github.com/pingcap/tikv/pull/3281","diff_url":"https://github.com/pingcap/tikv/pull/3281.diff","patch_url":"https://github.com/pingcap/tikv/pull/3281.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/3281","number":3281,"state":"open","locked":false,"title":"Support specifying time zone by names","user":{"login":"breeswish","id":1916485,"node_id":"MDQ6VXNlcjE5MTY0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiKV! Please read TiKV's [CONTRIBUTING](https://github.com/pingcap/tikv/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\nTime zones can be specified in 2 ways, a fixed offset like \"+08:00\", or a name like \"Asia/Shanghai\". Previously we (TiKV & TiDB) only support fixed offset, so that DSTs are not respected. Now we also support specifying tz by names.\r\n\r\nThe upstreaming TiDB has already proposed [a PR](https://github.com/pingcap/tidb/pull/6823) to push down the time zone name. Based on this PR, we can utilize the time zone name field in the coprocessor request to correctly handle these time zones.\r\n\r\n- [x] Some non-logical changes are extracted to [this PR](https://github.com/pingcap/tikv/pull/3276), which should be merged first.\r\n- [x] Support \"SYSTEM\" time zone: MySQL uses time zone called \"SYSTEM\" to denote a local time zone, which is not handled currently.\r\n- [x] ~~Support \"Local\" time zone: TiDB uses time zone called \"Local\" to denote a local time zone, which is not handled currently. /cc @zhexuany I prefer to call it \"SYSTEM\" to be identical to MySQL.~~ TiDB change to SYSTEM\r\n- [x] ~~Possible chrono_tz bug: https://github.com/chronotope/chrono-tz/issues/23 It seems that chrono_tz has bugs when handling DST times that clocks are moved backward, so test cases in this PR won't pass.~~ We are not going to fix it since there will be too many changes to make to the chrono library.\r\n\r\n## What are the type of the changes? (mandatory)\r\n\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n- Bug fix (non-breaking change which fixes an issue)\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nUnit Test (is not passed currently)\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nNo.\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nNo.\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\nhttps://github.com/pingcap/tikv/pull/3276\r\n\r\nhttps://github.com/pingcap/tidb/pull/6823\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n","created_at":"2018-07-03T07:08:58Z","updated_at":"2018-07-10T10:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41fec3fe6951568f8db89fdb238222200c07d69d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/3281/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/3281/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/3281/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/99ab891a9dd20b5ab5b7366450129dc88d6307f3","head":{"label":"pingcap:_cop_dst","ref":"_cop_dst","sha":"99ab891a9dd20b5ab5b7366450129dc88d6307f3","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-07-10T08:31:33Z","pushed_at":"2018-07-10T09:49:02Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":14486,"stargazers_count":3345,"watchers_count":3345,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":427,"open_issues":222,"watchers":3345,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"238a2fd59430366f122d93480bcc032826107a71","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-07-10T08:31:33Z","pushed_at":"2018-07-10T09:49:02Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":14486,"stargazers_count":3345,"watchers_count":3345,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"open_issues_count":222,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":427,"open_issues":222,"watchers":3345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3281"},"html":{"href":"https://github.com/pingcap/tikv/pull/3281"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3281"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/3281/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3281/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/3281/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/99ab891a9dd20b5ab5b7366450129dc88d6307f3"}},"author_association":"MEMBER"}} | {
"id": 48833910,
"name": "pingcap/tikv",
"url": "https://api.github.com/repos/pingcap/tikv"
} | {
"id": 1916485,
"login": "breeswish",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1916485?",
"url": "https://api.github.com/users/breeswish"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2018-07-10T10:36:58 | 7942932505 | {"actor":{"display_login":"breeswish"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/244718561","pull_request_review_id":188655437,"id":244718561,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDcxODU2MQ==","diff_hunk":"@@ -596,13 +597,32 @@ func (b *PlanBuilder) buildProjectionField(id, position int, field *ast.SelectFi\n }\n \n // buildProjection returns a Projection plan and non-aux columns length.\n-func (b *PlanBuilder) buildProjection(p LogicalPlan, fields []*ast.SelectField, mapper map[*ast.AggregateFuncExpr]int) (LogicalPlan, int, error) {\n+func (b *PlanBuilder) buildProjection(p LogicalPlan, fields []*ast.SelectField, mapper map[*ast.AggregateFuncExpr]int, considerWindow bool) (LogicalPlan, int, error) {\n \tb.optFlag |= flagEliminateProjection\n \tb.curClause = fieldList\n \tproj := LogicalProjection{Exprs: make([]expression.Expression, 0, len(fields))}.Init(b.ctx)\n \tschema := expression.NewSchema(make([]*expression.Column, 0, len(fields))...)\n \toldLen := 0\n-\tfor _, field := range fields {\n+\tfor i, field := range fields {\n+\t\tif !field.Auxiliary {\n+\t\t\toldLen++\n+\t\t}\n+\n+\t\tisWindowFuncField := ast.HasWindowFlag(field.Expr)\n+\t\t// When `considerWindow` is false, we will only build fields for non-window functions, so we add fake placeholders.","path":"planner/core/logical_plan_builder.go","position":26,"original_position":26,"commit_id":"d047eb2c3c7d3db7a87be6e5ec20b6522a696463","original_commit_id":"71bdea15c07c5527e90defaf2dcda017b8db680a","user":{"login":"winoros","id":7846227,"node_id":"MDQ6VXNlcjc4NDYyMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7846227?v=4","gravatar_id":"","url":"https://api.github.com/users/winoros","html_url":"https://github.com/winoros","followers_url":"https://api.github.com/users/winoros/followers","following_url":"https://api.github.com/users/winoros/following{/other_user}","gists_url":"https://api.github.com/users/winoros/gists{/gist_id}","starred_url":"https://api.github.com/users/winoros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winoros/subscriptions","organizations_url":"https://api.github.com/users/winoros/orgs","repos_url":"https://api.github.com/users/winoros/repos","events_url":"https://api.github.com/users/winoros/events{/privacy}","received_events_url":"https://api.github.com/users/winoros/received_events","type":"User","site_admin":false},"body":"What about adding more comments to help others understand these codes.","created_at":"2019-01-02T11:54:19Z","updated_at":"2019-01-02T11:54:19Z","html_url":"https://github.com/pingcap/tidb/pull/8630#discussion_r244718561","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/8630","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/244718561"},"html":{"href":"https://github.com/pingcap/tidb/pull/8630#discussion_r244718561"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8630"}},"in_reply_to_id":244662464},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/8630","id":237186250,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTg2MjUw","html_url":"https://github.com/pingcap/tidb/pull/8630","diff_url":"https://github.com/pingcap/tidb/pull/8630.diff","patch_url":"https://github.com/pingcap/tidb/pull/8630.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/8630","number":8630,"state":"open","locked":false,"title":" planner: support window function","user":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nSupport the window function in planner.\r\n\r\n### What is changed and how it works?\r\n\r\nAdd logical and physical plan operator for window function. It resolves the name in window function before projection, and build the window funtion after processing the having clause. For partition by and order by clause in window functioin, it adds sort operator as it's child.\r\nThe named window and frame clause will be processed in next PR.\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n\r\nCode changes\r\n\r\n - Has exported function/method change\r\n\r\nSide effects\r\n\r\n - None\r\n\r\nRelated changes\r\n\r\n - https://github.com/pingcap/parser/pull/76\r\n\r\nPTAL @zz-jason @winoros @XuHuaiyu @eurekaka\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/8630)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-12-10T03:17:48Z","updated_at":"2019-01-02T11:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fffa9c5d371a8f41605d567431a1f454087c7302","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eurekaka","id":6261973,"node_id":"MDQ6VXNlcjYyNjE5NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/6261973?v=4","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":667671533,"node_id":"MDU6TGFiZWw2Njc2NzE1MzM=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/planner","name":"component/planner","color":"1d76db","default":false},{"id":564574080,"node_id":"MDU6TGFiZWw1NjQ1NzQwODA=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/LGT1","name":"status/LGT1","color":"d4c5f9","default":false},{"id":256872088,"node_id":"MDU6TGFiZWwyNTY4NzIwODg=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/enhancement","name":"type/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/8630/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/8630/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/8630/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/d047eb2c3c7d3db7a87be6e5ec20b6522a696463","head":{"label":"lamxTyler:window","ref":"window","sha":"d047eb2c3c7d3db7a87be6e5ec20b6522a696463","user":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"repo":{"id":107388999,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczODg5OTk=","name":"tidb","full_name":"lamxTyler/tidb","private":false,"owner":{"login":"lamxTyler","id":16222711,"node_id":"MDQ6VXNlcjE2MjIyNzEx","avatar_url":"https://avatars1.githubusercontent.com/u/16222711?v=4","gravatar_id":"","url":"https://api.github.com/users/lamxTyler","html_url":"https://github.com/lamxTyler","followers_url":"https://api.github.com/users/lamxTyler/followers","following_url":"https://api.github.com/users/lamxTyler/following{/other_user}","gists_url":"https://api.github.com/users/lamxTyler/gists{/gist_id}","starred_url":"https://api.github.com/users/lamxTyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamxTyler/subscriptions","organizations_url":"https://api.github.com/users/lamxTyler/orgs","repos_url":"https://api.github.com/users/lamxTyler/repos","events_url":"https://api.github.com/users/lamxTyler/events{/privacy}","received_events_url":"https://api.github.com/users/lamxTyler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lamxTyler/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/lamxTyler/tidb","forks_url":"https://api.github.com/repos/lamxTyler/tidb/forks","keys_url":"https://api.github.com/repos/lamxTyler/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamxTyler/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamxTyler/tidb/teams","hooks_url":"https://api.github.com/repos/lamxTyler/tidb/hooks","issue_events_url":"https://api.github.com/repos/lamxTyler/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/lamxTyler/tidb/events","assignees_url":"https://api.github.com/repos/lamxTyler/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/lamxTyler/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/lamxTyler/tidb/tags","blobs_url":"https://api.github.com/repos/lamxTyler/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamxTyler/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamxTyler/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamxTyler/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamxTyler/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/lamxTyler/tidb/languages","stargazers_url":"https://api.github.com/repos/lamxTyler/tidb/stargazers","contributors_url":"https://api.github.com/repos/lamxTyler/tidb/contributors","subscribers_url":"https://api.github.com/repos/lamxTyler/tidb/subscribers","subscription_url":"https://api.github.com/repos/lamxTyler/tidb/subscription","commits_url":"https://api.github.com/repos/lamxTyler/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamxTyler/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamxTyler/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamxTyler/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamxTyler/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/lamxTyler/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamxTyler/tidb/merges","archive_url":"https://api.github.com/repos/lamxTyler/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamxTyler/tidb/downloads","issues_url":"https://api.github.com/repos/lamxTyler/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/lamxTyler/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/lamxTyler/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/lamxTyler/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamxTyler/tidb/labels{/name}","releases_url":"https://api.github.com/repos/lamxTyler/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/lamxTyler/tidb/deployments","created_at":"2017-10-18T09:49:38Z","updated_at":"2019-01-02T08:23:07Z","pushed_at":"2019-01-02T11:32:49Z","git_url":"git://github.com/lamxTyler/tidb.git","ssh_url":"git@github.com:lamxTyler/tidb.git","clone_url":"https://github.com/lamxTyler/tidb.git","svn_url":"https://github.com/lamxTyler/tidb","homepage":"https://pingcap.com","size":67444,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"7a966426eec1e04d57325a829ab3a7700189711c","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2019-01-02T10:23:10Z","pushed_at":"2019-01-02T11:54:06Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":123765,"stargazers_count":16684,"watchers_count":16684,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2393,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2393,"open_issues":643,"watchers":16684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8630"},"html":{"href":"https://github.com/pingcap/tidb/pull/8630"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8630"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/8630/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8630/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/8630/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/d047eb2c3c7d3db7a87be6e5ec20b6522a696463"}},"author_association":"MEMBER"}} | {
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
} | {
"id": 7846227,
"login": "winoros",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7846227?",
"url": "https://api.github.com/users/winoros"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2019-01-02T11:54:19 | 8823028163 | {"actor":{"display_login":"winoros"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments/203447448","pull_request_review_id":138338535,"id":203447448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ0NzQ0OA==","diff_hunk":"@@ -0,0 +1,265 @@\n+/* eslint-disable no-underscore-dangle, no-use-before-define, no-param-reassign*/\n+import asap from 'asap/raw';\n+\n+const noop = () => {};\n+\n+// States:","path":"packages/zipkin-instrumentation-request-promise/src/promise.js","position":6,"original_position":6,"commit_id":"dbe372ba506b71f0e9a904fa558da88614603012","original_commit_id":"dbe372ba506b71f0e9a904fa558da88614603012","user":{"login":"adriancole","id":64215,"node_id":"MDQ6VXNlcjY0MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"thanks for the notes and the side note. Can you put the recap at the top of the file in some form?\r\n\r\nThat's it from me unless others have things to say.","created_at":"2018-07-18T16:33:17Z","updated_at":"2018-07-18T16:33:17Z","html_url":"https://github.com/openzipkin/zipkin-js/pull/189#discussion_r203447448","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments/203447448"},"html":{"href":"https://github.com/openzipkin/zipkin-js/pull/189#discussion_r203447448"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189"}},"in_reply_to_id":203225864},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189","id":169864217,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY5ODY0MjE3","html_url":"https://github.com/openzipkin/zipkin-js/pull/189","diff_url":"https://github.com/openzipkin/zipkin-js/pull/189.diff","patch_url":"https://github.com/openzipkin/zipkin-js/pull/189.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/189","number":189,"state":"open","locked":false,"title":"Adds zipkin-instrumentation-request-promise","user":{"login":"mkante","id":1507832,"node_id":"MDQ6VXNlcjE1MDc4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1507832?v=4","gravatar_id":"","url":"https://api.github.com/users/mkante","html_url":"https://github.com/mkante","followers_url":"https://api.github.com/users/mkante/followers","following_url":"https://api.github.com/users/mkante/following{/other_user}","gists_url":"https://api.github.com/users/mkante/gists{/gist_id}","starred_url":"https://api.github.com/users/mkante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkante/subscriptions","organizations_url":"https://api.github.com/users/mkante/orgs","repos_url":"https://api.github.com/users/mkante/repos","events_url":"https://api.github.com/users/mkante/events{/privacy}","received_events_url":"https://api.github.com/users/mkante/received_events","type":"User","site_admin":false},"body":"Fixes #179","created_at":"2018-02-19T01:40:01Z","updated_at":"2018-07-18T16:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b3712da6354776ee85cd622ac6a5a1e7239fdb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/189/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/dbe372ba506b71f0e9a904fa558da88614603012","head":{"label":"mkante:feature/issue-179","ref":"feature/issue-179","sha":"dbe372ba506b71f0e9a904fa558da88614603012","user":{"login":"mkante","id":1507832,"node_id":"MDQ6VXNlcjE1MDc4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1507832?v=4","gravatar_id":"","url":"https://api.github.com/users/mkante","html_url":"https://github.com/mkante","followers_url":"https://api.github.com/users/mkante/followers","following_url":"https://api.github.com/users/mkante/following{/other_user}","gists_url":"https://api.github.com/users/mkante/gists{/gist_id}","starred_url":"https://api.github.com/users/mkante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkante/subscriptions","organizations_url":"https://api.github.com/users/mkante/orgs","repos_url":"https://api.github.com/users/mkante/repos","events_url":"https://api.github.com/users/mkante/events{/privacy}","received_events_url":"https://api.github.com/users/mkante/received_events","type":"User","site_admin":false},"repo":{"id":116425694,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY0MjU2OTQ=","name":"zipkin-js","full_name":"mkante/zipkin-js","owner":{"login":"mkante","id":1507832,"node_id":"MDQ6VXNlcjE1MDc4MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1507832?v=4","gravatar_id":"","url":"https://api.github.com/users/mkante","html_url":"https://github.com/mkante","followers_url":"https://api.github.com/users/mkante/followers","following_url":"https://api.github.com/users/mkante/following{/other_user}","gists_url":"https://api.github.com/users/mkante/gists{/gist_id}","starred_url":"https://api.github.com/users/mkante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkante/subscriptions","organizations_url":"https://api.github.com/users/mkante/orgs","repos_url":"https://api.github.com/users/mkante/repos","events_url":"https://api.github.com/users/mkante/events{/privacy}","received_events_url":"https://api.github.com/users/mkante/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkante/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":true,"url":"https://api.github.com/repos/mkante/zipkin-js","forks_url":"https://api.github.com/repos/mkante/zipkin-js/forks","keys_url":"https://api.github.com/repos/mkante/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkante/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkante/zipkin-js/teams","hooks_url":"https://api.github.com/repos/mkante/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/mkante/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/mkante/zipkin-js/events","assignees_url":"https://api.github.com/repos/mkante/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/mkante/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/mkante/zipkin-js/tags","blobs_url":"https://api.github.com/repos/mkante/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkante/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkante/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkante/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkante/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/mkante/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/mkante/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/mkante/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/mkante/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/mkante/zipkin-js/subscription","commits_url":"https://api.github.com/repos/mkante/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkante/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkante/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkante/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkante/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/mkante/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkante/zipkin-js/merges","archive_url":"https://api.github.com/repos/mkante/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkante/zipkin-js/downloads","issues_url":"https://api.github.com/repos/mkante/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/mkante/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/mkante/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/mkante/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkante/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/mkante/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/mkante/zipkin-js/deployments","created_at":"2018-01-05T20:52:39Z","updated_at":"2018-01-05T20:52:41Z","pushed_at":"2018-07-17T18:55:08Z","git_url":"git://github.com/mkante/zipkin-js.git","ssh_url":"git@github.com:mkante/zipkin-js.git","clone_url":"https://github.com/mkante/zipkin-js.git","svn_url":"https://github.com/mkante/zipkin-js","homepage":"","size":619,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"c54590b5f1cec74d5cdc2d8f6207de7e1c8e4aa5","user":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":58535548,"node_id":"MDEwOlJlcG9zaXRvcnk1ODUzNTU0OA==","name":"zipkin-js","full_name":"openzipkin/zipkin-js","owner":{"login":"openzipkin","id":11860887,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-js","forks_url":"https://api.github.com/repos/openzipkin/zipkin-js/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-js/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-js/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-js/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-js/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-js/deployments","created_at":"2016-05-11T10:28:12Z","updated_at":"2018-07-18T06:55:20Z","pushed_at":"2018-07-18T06:55:16Z","git_url":"git://github.com/openzipkin/zipkin-js.git","ssh_url":"git@github.com:openzipkin/zipkin-js.git","clone_url":"https://github.com/openzipkin/zipkin-js.git","svn_url":"https://github.com/openzipkin/zipkin-js","homepage":"","size":609,"stargazers_count":232,"watchers_count":232,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":67,"license":null,"forks":104,"open_issues":67,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189"},"html":{"href":"https://github.com/openzipkin/zipkin-js/pull/189"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/189"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-js/statuses/dbe372ba506b71f0e9a904fa558da88614603012"}},"author_association":"CONTRIBUTOR"}} | {
"id": 58535548,
"name": "openzipkin/zipkin-js",
"url": "https://api.github.com/repos/openzipkin/zipkin-js"
} | {
"id": 64215,
"login": "adriancole",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/64215?",
"url": "https://api.github.com/users/adriancole"
} | {
"id": 11860887,
"login": "openzipkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11860887?",
"url": "https://api.github.com/orgs/openzipkin"
} | 2018-07-18T16:33:17 | 7984118041 | {"actor":{"display_login":"adriancole"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments/210018676","pull_request_review_id":146147418,"id":210018676,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDAxODY3Ng==","diff_hunk":"@@ -0,0 +1,393 @@\n+\"\"\"\n+Adapted from https://github.com/numba/conda-recipe-cudatoolkit\n+\n+BSD 2-Clause License\n+\n+Copyright (c) 2018 Onwards, Quansight, LLC\n+Copyright (c) 2017, Continuum Analytics, Inc.\n+\n+All rights reserved.\n+\n+\n+Redistribution and use in source and binary forms, with or without\n+modification, are permitted provided that the following conditions are met:\n+\n+* Redistributions of source code must retain the above copyright notice, this\n+ list of conditions and the following disclaimer.\n+\n+* Redistributions in binary form must reproduce the above copyright notice,\n+ this list of conditions and the following disclaimer in the documentation\n+ and/or other materials provided with the distribution.\n+\n+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE\n+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,\n+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. \"\"\"\n+\n+from __future__ import print_function\n+\n+import json\n+import os\n+import shutil\n+import stat\n+import subprocess\n+import sys\n+import urllib.parse as urlparse\n+from pathlib import Path\n+\n+from conda.exports import download, hashsum_file\n+\n+\n+def set_chmod(file_name):\n+ # Do a simple chmod +x for a file within python\n+ st = os.stat(file_name)\n+ os.chmod(file_name, st.st_mode | stat.S_IXOTH)\n+\n+\n+def copy_files(src, dst):\n+ try:\n+ if os.path.isfile(src):\n+ set_chmod(src)\n+ shutil.copy(src, dst)\n+ except FileExistsError:\n+ pass\n+\n+\n+class Extractor(object):\n+ \"\"\"Extractor base class, platform specific extractors should inherit\n+ from this class.\n+ \"\"\"\n+\n+ def __init__(self, cudatoolkit_config, platform_config):\n+ \"\"\"Initialise an instance:\n+ Arguments:\n+ cudatoolkit_config: the configuration for CUDA\n+ platform_config - the configuration for this platform\n+ \"\"\"\n+ self.cu_name = cudatoolkit_config[\"name\"]\n+ self.cu_version = cudatoolkit_config[\"version\"]\n+ self.md5_url = cudatoolkit_config[\"md5_url\"]\n+ self.base_url = cudatoolkit_config[\"base_url\"]\n+ self.patch_url_text = cudatoolkit_config[\"patch_url_ext\"]\n+ self.installers_url_ext = cudatoolkit_config[\"installers_url_ext\"]\n+ self.cu_blob = platform_config[\"blob\"]\n+ self.conda_prefix = os.environ.get(\"CONDA_PREFIX\")\n+ self.prefix = os.environ[\"PREFIX\"]\n+ self.src_dir = Path(self.conda_prefix) / \"pkgs\" / self.cu_name\n+ os.makedirs(self.src_dir, exist_ok=True)\n+\n+ self.symlinks = getplatform() == \"linux\"\n+ self.debug_install_path = os.environ.get(\"DEBUG_INSTALLER_PATH\")\n+\n+ def create_activate_and_deactivate_scripts(self):\n+ activate_dir_path = Path(self.conda_prefix) / \"etc\" / \"conda\" / \"activate.d\"\n+ deactivate_dir_path = Path(self.conda_prefix) / \"etc\" / \"conda\" / \"deactivate.d\"\n+\n+ os.makedirs(activate_dir_path, exist_ok=True)\n+ os.makedirs(deactivate_dir_path, exist_ok=True)\n+\n+ # Copy cudatoolkit-dev-activate and cudatoolkit-dev-deactivate\n+ # to activate.d and deactivate.d directories\n+\n+ scripts_dir = Path(self.prefix) / \"scripts\"\n+ activate_scripts_dir = scripts_dir / \"activate.d\"\n+ deactivate_scripts_dir = scripts_dir / \"deactivate.d\"\n+\n+ activate_scripts_list = [\n+ \"cudatoolkit-dev-activate.sh\",\n+ \"cudatoolkit-dev-activate.bat\",\n+ ]\n+ for file_name in activate_scripts_list:\n+ file_full_path = activate_scripts_dir / file_name\n+ shutil.copy(file_full_path, activate_dir_path)\n+\n+ deactivate_scripts_list = [\n+ \"cudatoolkit-dev-deactivate.sh\",\n+ \"cudatoolkit-dev-deactivate.bat\",\n+ ]\n+\n+ for file_name in deactivate_scripts_list:\n+ file_full_path = deactivate_scripts_dir / file_name\n+ shutil.copy(file_full_path, deactivate_dir_path)\n+\n+ def download_blobs(self):\n+ \"\"\"Downloads the binary blobs to the $SRC_DIR\n+ \"\"\"\n+ dl_url = urlparse.urljoin(self.base_url, self.installers_url_ext)\n+ dl_url = urlparse.urljoin(dl_url, self.cu_blob)\n+ dl_path = os.path.join(self.src_dir, self.cu_blob)\n+ if not self.debug_install_path:\n+ print(\"downloading %s to %s\" % (dl_url, dl_path))\n+ download(dl_url, dl_path)\n+\n+ else:\n+ existing_file = os.path.join(self.debug_install_path, self.cu_blob)\n+ print(\"DEBUG: copying %s to %s\" % (existing_file, dl_path))\n+ shutil.copy(existing_file, dl_path)\n+\n+ def check_md5(self):\n+ \"\"\"Checks the md5sums of the downloaded binaries\n+ \"\"\"\n+ md5file = self.md5_url.split(\"/\")[-1]\n+ path = os.path.join(self.src_dir, md5file)\n+ download(self.md5_url, path)\n+\n+ # compute hash of blob\n+ blob_path = os.path.join(self.src_dir, self.cu_blob)\n+ md5sum = hashsum_file(blob_path, \"md5\")\n+\n+ # get checksums\n+ with open(path, \"r\") as f:\n+ checksums = [x.strip().split() for x in f.read().splitlines() if x]\n+\n+ # check md5 and filename match up\n+ check_dict = {x[0]: x[1] for x in checksums}\n+ assert check_dict[md5sum].startswith(self.cu_blob[:-7])\n+\n+ def extract(self, *args):\n+ \"\"\"The method to extract files from the cuda binary blobs.\n+ Platform specific extractors must implement.\n+ \"\"\"\n+ raise RuntimeError(\"Must implement\")\n+\n+ def cleanup(self):\n+ \"\"\"The method to delete unnecessary files after\n+ the installation process.\n+ \"\"\"\n+ raise RuntimeError(\"Must implement\")\n+\n+\n+class WindowsExtractor(Extractor):\n+ \"\"\"The windows extractor\n+ \"\"\"\n+\n+ def extract(self):\n+ print(\"Extracting on Windows.....\")\n+ runfile = os.path.join(self.src_dir, self.cu_blob)\n+ cmd = [\"7za\", \"x\", \"-o%s\" % str(self.src_dir), runfile]\n+ try:\n+ subprocess.check_call(cmd)\n+ except subprocess.CalledProcessError as e:\n+ print(\n+ \"ERROR: Couldn't install Cudatoolkit: \\\n+ {reason}\".format(\n+ reason=e\n+ )\n+ )\n+\n+ def cleanup(self):\n+ pass\n+\n+\n+class LinuxExtractor(Extractor):\n+ \"\"\"The Linux Extractor\n+ \"\"\"\n+\n+ def extract(self):\n+ print(\"Extracting on Linux\")\n+ runfile = os.path.join(self.src_dir, self.cu_blob)\n+ os.chmod(runfile, 0o777)\n+ cmd = [\n+ runfile,\n+ \"--silent\",\n+ \"--toolkit\",\n+ \"--toolkitpath\",\n+ str(self.src_dir),\n+ \"--override\",\n+ ]\n+ try:\n+ subprocess.check_call(cmd)\n+ except subprocess.CalledProcessError as e:\n+ print(\n+ \"ERROR: Couldn't install Cudatoolkit: \\\n+ {reason}\".format(\n+ reason=e\n+ )\n+ )\n+\n+ def cleanup(self):\n+ blob_path = os.path.join(self.src_dir, self.cu_blob)\n+ if os.path.exists(blob_path):\n+ os.remove(blob_path)\n+\n+ else:\n+ pass\n+\n+\n+class OsxExtractor(Extractor):\n+ \"\"\"The osx Extractor\n+ \"\"\"\n+\n+ def _hdiutil_mount(self, temp_dir, file_name, install_dir):\n+ \"\"\"Function to mount osx dmg images, extracts the files\n+ from an image into store and ensure they are\n+ unmounted on exit.\n+ \"\"\"\n+ # open\n+ cmd = [\"hdiutil\", \"attach\", \"-mountpoint\", temp_dir, file_name]\n+ cmd = \" \".join(cmd)\n+ process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)\n+ process.wait()\n+ # find tar.gz files\n+ cmd = [\n+ \"find\",\n+ temp_dir,\n+ \"-name\",\n+ '\"*.tar.gz\"',\n+ \"-exec\",\n+ \"tar\",\n+ \"xvf\",\n+ \"'{}'\",\n+ \"--directory\",\n+ install_dir,\n+ \"';'\",\n+ ]\n+ cmd = \" \".join(cmd)\n+ process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)\n+ process.wait()\n+ # close\n+ cmd = [\"hdiutil\", \"detach\", temp_dir]\n+ cmd = \" \".join(cmd)\n+ process = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE)\n+ process.wait()\n+\n+ def copy_files(self):\n+ src = (\n+ Path(self.extract_temp_dir)\n+ / \"Developer\"\n+ / \"NVIDIA\"\n+ / \"CUDA-{}\".format(self.cu_version)\n+ )\n+ dst = self.src_dir\n+\n+ for f in os.listdir(src):\n+ source = src / f\n+ destination = dst / f\n+ try:\n+ shutil.copytree(source, destination)\n+ except NotADirectoryError:\n+ shutil.copy(source, destination)\n+ except FileExistsError:\n+ pass\n+\n+ def extract(self):\n+ runfile = os.path.join(self.src_dir, self.cu_blob)\n+ extract_store_name = \"tmpstore\"\n+ extract_temp_dir_name = \"tmp\"\n+ self.extract_store = os.path.join(self.src_dir, extract_store_name)\n+ self.extract_temp_dir = os.path.join(self.src_dir, extract_temp_dir_name)\n+ os.makedirs(self.extract_store, exist_ok=True)\n+ os.makedirs(self.extract_temp_dir, exist_ok=True)\n+ self._hdiutil_mount(self.extract_store, runfile, self.extract_temp_dir)\n+ self.copy_files()\n+\n+ def cleanup(self):\n+ blob_path = os.path.join(self.src_dir, self.cu_blob)\n+ if os.path.exists(blob_path):\n+ os.remove(blob_path)\n+\n+ else:\n+ pass\n+\n+ try:\n+ shutil.rmtree(self.extract_store)\n+\n+ except FileNotFoundError:\n+ pass\n+\n+ try:\n+ shutil.rmtree(self.extract_temp_dir)\n+\n+ except FileNotFoundError:\n+ pass\n+\n+\n+def getplatform():\n+ plt = sys.platform\n+ if plt.startswith(\"linux\"):\n+ return \"linux\"\n+ elif plt.startswith(\"win\"):\n+ return \"windows\"\n+ elif plt.startswith(\"darwin\"):\n+ return \"osx\"\n+ else:\n+ raise RuntimeError(\"Unknown platform\")\n+\n+\n+def set_config():\n+ \"\"\"Set necessary configurations\"\"\"\n+\n+ cudatoolkit = {\"linux\": {}, \"windows\": {}, \"osx\": {}}\n+ prefix = Path(os.environ[\"PREFIX\"])\n+ extra_args = dict()\n+ with open(prefix / \"bin\" / \"cudatoolkit-dev-extra-args.txt\", \"r\") as f:","path":"recipes/cudatoolkit-dev/cudatoolkit-dev-post-install.py","position":329,"original_position":329,"commit_id":"b7e630649e651831971f81984fdc28931342a34a","original_commit_id":"b7e630649e651831971f81984fdc28931342a34a","user":{"login":"scopatz","id":320553,"node_id":"MDQ6VXNlcjMyMDU1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/320553?v=4","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"body":"If this is a JSON file, it should end in a `*.json` extention, rather than a `*.txt` extension.","created_at":"2018-08-14T16:29:07Z","updated_at":"2018-08-14T16:29:07Z","html_url":"https://github.com/conda-forge/staged-recipes/pull/6372#discussion_r210018676","pull_request_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments/210018676"},"html":{"href":"https://github.com/conda-forge/staged-recipes/pull/6372#discussion_r210018676"},"pull_request":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372"}}},"pull_request":{"url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372","id":204895145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODk1MTQ1","html_url":"https://github.com/conda-forge/staged-recipes/pull/6372","diff_url":"https://github.com/conda-forge/staged-recipes/pull/6372.diff","patch_url":"https://github.com/conda-forge/staged-recipes/pull/6372.patch","issue_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/6372","number":6372,"state":"open","locked":false,"title":"Add cudatoolkit-dev","user":{"login":"andersy005","id":13301940,"node_id":"MDQ6VXNlcjEzMzAxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/13301940?v=4","gravatar_id":"","url":"https://api.github.com/users/andersy005","html_url":"https://github.com/andersy005","followers_url":"https://api.github.com/users/andersy005/followers","following_url":"https://api.github.com/users/andersy005/following{/other_user}","gists_url":"https://api.github.com/users/andersy005/gists{/gist_id}","starred_url":"https://api.github.com/users/andersy005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersy005/subscriptions","organizations_url":"https://api.github.com/users/andersy005/orgs","repos_url":"https://api.github.com/users/andersy005/repos","events_url":"https://api.github.com/users/andersy005/events{/privacy}","received_events_url":"https://api.github.com/users/andersy005/received_events","type":"User","site_admin":false},"body":"This PR adds a recipe for cudatoolkit for linux and osx. This recipe is different from https://github.com/conda-forge/staged-recipes/pull/6240 in that it consists of a post-install script that downloads and installs the \"full\" cuda toolkit (compiler, libraries, with the exception of cuda drivers). \r\n\r\nSupport for other platforms (win) will be added at a later time. ","created_at":"2018-07-30T18:45:38Z","updated_at":"2018-08-14T16:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"716413d902f0506eb2aad052474d3cd4707e3634","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372/commits","review_comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372/comments","review_comment_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/6372/comments","statuses_url":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/b7e630649e651831971f81984fdc28931342a34a","head":{"label":"andersy005:cudatoolkit-dev-linux","ref":"cudatoolkit-dev-linux","sha":"b7e630649e651831971f81984fdc28931342a34a","user":{"login":"andersy005","id":13301940,"node_id":"MDQ6VXNlcjEzMzAxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/13301940?v=4","gravatar_id":"","url":"https://api.github.com/users/andersy005","html_url":"https://github.com/andersy005","followers_url":"https://api.github.com/users/andersy005/followers","following_url":"https://api.github.com/users/andersy005/following{/other_user}","gists_url":"https://api.github.com/users/andersy005/gists{/gist_id}","starred_url":"https://api.github.com/users/andersy005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersy005/subscriptions","organizations_url":"https://api.github.com/users/andersy005/orgs","repos_url":"https://api.github.com/users/andersy005/repos","events_url":"https://api.github.com/users/andersy005/events{/privacy}","received_events_url":"https://api.github.com/users/andersy005/received_events","type":"User","site_admin":false},"repo":{"id":142045518,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNDU1MTg=","name":"staged-recipes","full_name":"andersy005/staged-recipes","owner":{"login":"andersy005","id":13301940,"node_id":"MDQ6VXNlcjEzMzAxOTQw","avatar_url":"https://avatars2.githubusercontent.com/u/13301940?v=4","gravatar_id":"","url":"https://api.github.com/users/andersy005","html_url":"https://github.com/andersy005","followers_url":"https://api.github.com/users/andersy005/followers","following_url":"https://api.github.com/users/andersy005/following{/other_user}","gists_url":"https://api.github.com/users/andersy005/gists{/gist_id}","starred_url":"https://api.github.com/users/andersy005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersy005/subscriptions","organizations_url":"https://api.github.com/users/andersy005/orgs","repos_url":"https://api.github.com/users/andersy005/repos","events_url":"https://api.github.com/users/andersy005/events{/privacy}","received_events_url":"https://api.github.com/users/andersy005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andersy005/staged-recipes","description":"A place to submit conda recipes before they become fully fledged conda-forge feedstocks","fork":true,"url":"https://api.github.com/repos/andersy005/staged-recipes","forks_url":"https://api.github.com/repos/andersy005/staged-recipes/forks","keys_url":"https://api.github.com/repos/andersy005/staged-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andersy005/staged-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andersy005/staged-recipes/teams","hooks_url":"https://api.github.com/repos/andersy005/staged-recipes/hooks","issue_events_url":"https://api.github.com/repos/andersy005/staged-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/andersy005/staged-recipes/events","assignees_url":"https://api.github.com/repos/andersy005/staged-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/andersy005/staged-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/andersy005/staged-recipes/tags","blobs_url":"https://api.github.com/repos/andersy005/staged-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andersy005/staged-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andersy005/staged-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/andersy005/staged-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andersy005/staged-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/andersy005/staged-recipes/languages","stargazers_url":"https://api.github.com/repos/andersy005/staged-recipes/stargazers","contributors_url":"https://api.github.com/repos/andersy005/staged-recipes/contributors","subscribers_url":"https://api.github.com/repos/andersy005/staged-recipes/subscribers","subscription_url":"https://api.github.com/repos/andersy005/staged-recipes/subscription","commits_url":"https://api.github.com/repos/andersy005/staged-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/andersy005/staged-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/andersy005/staged-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/andersy005/staged-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/andersy005/staged-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/andersy005/staged-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andersy005/staged-recipes/merges","archive_url":"https://api.github.com/repos/andersy005/staged-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andersy005/staged-recipes/downloads","issues_url":"https://api.github.com/repos/andersy005/staged-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/andersy005/staged-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/andersy005/staged-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/andersy005/staged-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andersy005/staged-recipes/labels{/name}","releases_url":"https://api.github.com/repos/andersy005/staged-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/andersy005/staged-recipes/deployments","created_at":"2018-07-23T17:15:29Z","updated_at":"2018-07-30T18:15:15Z","pushed_at":"2018-08-13T20:13:32Z","git_url":"git://github.com/andersy005/staged-recipes.git","ssh_url":"git@github.com:andersy005/staged-recipes.git","clone_url":"https://github.com/andersy005/staged-recipes.git","svn_url":"https://github.com/andersy005/staged-recipes","homepage":"https://conda-forge.org","size":19972,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conda-forge:master","ref":"master","sha":"5a03e68099c50806ab645b7d099c858357435c58","user":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"repo":{"id":41829476,"node_id":"MDEwOlJlcG9zaXRvcnk0MTgyOTQ3Ng==","name":"staged-recipes","full_name":"conda-forge/staged-recipes","owner":{"login":"conda-forge","id":11897326,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODk3MzI2","avatar_url":"https://avatars3.githubusercontent.com/u/11897326?v=4","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conda-forge/staged-recipes","description":"A place to submit conda recipes before they become fully fledged conda-forge feedstocks","fork":false,"url":"https://api.github.com/repos/conda-forge/staged-recipes","forks_url":"https://api.github.com/repos/conda-forge/staged-recipes/forks","keys_url":"https://api.github.com/repos/conda-forge/staged-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda-forge/staged-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda-forge/staged-recipes/teams","hooks_url":"https://api.github.com/repos/conda-forge/staged-recipes/hooks","issue_events_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/conda-forge/staged-recipes/events","assignees_url":"https://api.github.com/repos/conda-forge/staged-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/conda-forge/staged-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/conda-forge/staged-recipes/tags","blobs_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/conda-forge/staged-recipes/languages","stargazers_url":"https://api.github.com/repos/conda-forge/staged-recipes/stargazers","contributors_url":"https://api.github.com/repos/conda-forge/staged-recipes/contributors","subscribers_url":"https://api.github.com/repos/conda-forge/staged-recipes/subscribers","subscription_url":"https://api.github.com/repos/conda-forge/staged-recipes/subscription","commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda-forge/staged-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda-forge/staged-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda-forge/staged-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/conda-forge/staged-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda-forge/staged-recipes/merges","archive_url":"https://api.github.com/repos/conda-forge/staged-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda-forge/staged-recipes/downloads","issues_url":"https://api.github.com/repos/conda-forge/staged-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/conda-forge/staged-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/conda-forge/staged-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/conda-forge/staged-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda-forge/staged-recipes/labels{/name}","releases_url":"https://api.github.com/repos/conda-forge/staged-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/conda-forge/staged-recipes/deployments","created_at":"2015-09-02T21:49:20Z","updated_at":"2018-08-14T14:36:53Z","pushed_at":"2018-08-14T14:36:00Z","git_url":"git://github.com/conda-forge/staged-recipes.git","ssh_url":"git@github.com:conda-forge/staged-recipes.git","clone_url":"https://github.com/conda-forge/staged-recipes.git","svn_url":"https://github.com/conda-forge/staged-recipes","homepage":"https://conda-forge.org","size":20393,"stargazers_count":174,"watchers_count":174,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":932,"mirror_url":null,"archived":false,"open_issues_count":539,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":932,"open_issues":539,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372"},"html":{"href":"https://github.com/conda-forge/staged-recipes/pull/6372"},"issue":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/issues/6372"},"comments":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/issues/6372/comments"},"review_comments":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372/comments"},"review_comment":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/pulls/6372/commits"},"statuses":{"href":"https://api.github.com/repos/conda-forge/staged-recipes/statuses/b7e630649e651831971f81984fdc28931342a34a"}},"author_association":"NONE"}} | {
"id": 41829476,
"name": "conda-forge/staged-recipes",
"url": "https://api.github.com/repos/conda-forge/staged-recipes"
} | {
"id": 320553,
"login": "scopatz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/320553?",
"url": "https://api.github.com/users/scopatz"
} | {
"id": 11897326,
"login": "conda-forge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11897326?",
"url": "https://api.github.com/orgs/conda-forge"
} | 2018-08-14T16:29:07 | 8112353075 | {"actor":{"display_login":"scopatz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-core/pulls/comments/237213097","pull_request_review_id":179457589,"id":237213097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIxMzA5Nw==","diff_hunk":"@@ -0,0 +1,914 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,\n+ * You can obtain one at http://mozilla.org/MPL/2.0/. */\n+\n+#include \"brave/components/brave_ads/browser/ads_service_impl.h\"\n+\n+#include \"base/command_line.h\"\n+#include \"base/files/file_util.h\"\n+#include \"base/files/important_file_writer.h\"\n+#include \"base/guid.h\"\n+#include \"base/logging.h\"\n+#include \"base/memory/ptr_util.h\"\n+#include \"base/sequenced_task_runner.h\"\n+#include \"base/task_runner_util.h\"\n+#include \"base/task/post_task.h\"\n+#include \"bat/ads/notification_info.h\"\n+#include \"bat/ads/notification_result_type.h\"\n+#include \"bat/ads/resources/grit/bat_ads_resources.h\"\n+#include \"brave/components/brave_ads/browser/ad_notification.h\"\n+#include \"brave/components/brave_ads/browser/bundle_state_database.h\"\n+#include \"brave/components/brave_ads/common/pref_names.h\"\n+#include \"brave/components/brave_ads/common/switches.h\"\n+#include \"brave/components/services/bat_ads/public/cpp/ads_client_mojo_bridge.h\"\n+#include \"brave/components/services/bat_ads/public/interfaces/bat_ads.mojom.h\"\n+#include \"chrome/browser/browser_process.h\"\n+#include \"chrome/browser/notifications/notification_display_service.h\"\n+#include \"chrome/browser/notifications/notification_display_service_impl.h\"\n+#include \"chrome/browser/notifications/notification_handler.h\"\n+#include \"chrome/browser/profiles/profile.h\"\n+#include \"chrome/browser/ui/browser.h\"\n+#include \"chrome/browser/ui/browser_finder.h\"\n+#include \"chrome/browser/ui/browser_navigator_params.h\"\n+#include \"chrome/common/buildflags.h\"\n+#include \"chrome/common/chrome_constants.h\"\n+#include \"components/prefs/pref_service.h\"\n+#include \"components/wifi/wifi_service.h\"\n+#include \"content/public/browser/browser_thread.h\"\n+#include \"content/public/common/service_manager_connection.h\"\n+#include \"net/url_request/url_fetcher.h\"\n+#include \"services/service_manager/public/cpp/connector.h\"\n+#include \"third_party/dom_distiller_js/dom_distiller.pb.h\"\n+#include \"ui/base/l10n/l10n_util.h\"\n+#include \"ui/base/resource/resource_bundle.h\"\n+#include \"ui/message_center/public/cpp/notification.h\"\n+\n+#if defined(OS_ANDROID)\n+#include \"net/android/network_library.h\"\n+#endif\n+\n+namespace brave_ads {\n+\n+class LogStreamImpl : public ads::LogStream {\n+ public:\n+ LogStreamImpl(const char* file,\n+ int line,\n+ const ads::LogLevel log_level) {\n+ switch(log_level) {\n+ case ads::LogLevel::INFO:\n+ log_message_ = std::make_unique<logging::LogMessage>(file, line, logging::LOG_INFO);\n+ break;\n+ case ads::LogLevel::WARNING:\n+ log_message_ = std::make_unique<logging::LogMessage>(file, line, logging::LOG_WARNING);\n+ break;\n+ default:\n+ log_message_ = std::make_unique<logging::LogMessage>(file, line, logging::LOG_ERROR);\n+ }\n+ }\n+\n+ std::ostream& stream() override {\n+ return log_message_->stream();\n+ }\n+\n+ private:\n+ std::unique_ptr<logging::LogMessage> log_message_;\n+\n+ DISALLOW_COPY_AND_ASSIGN(LogStreamImpl);\n+};\n+\n+class AdsNotificationHandler : public NotificationHandler {\n+ public:\n+ AdsNotificationHandler(AdsServiceImpl* ads_service) :\n+ ads_service_(ads_service->AsWeakPtr()) {}\n+\n+ ~AdsNotificationHandler() override {}\n+\n+ // NotificationHandler implementation.\n+ void OnShow(Profile* profile,\n+ const std::string& notification_id) override {\n+ if (ads_service_)\n+ ads_service_->OnShow(profile, notification_id);\n+ }\n+\n+ void OnClose(Profile* profile,\n+ const GURL& origin,\n+ const std::string& notification_id,\n+ bool by_user,\n+ base::OnceClosure completed_closure) override {\n+ if (!ads_service_) {\n+ std::move(completed_closure).Run();\n+ return;\n+ }\n+\n+ ads_service_->OnClose(\n+ profile, origin, notification_id, by_user,\n+ std::move(completed_closure));\n+ }\n+\n+ void DisableNotifications(Profile* profile,\n+ const GURL& origin) override {}\n+\n+\n+ void OpenSettings(Profile* profile, const GURL& origin) override {\n+ if (ads_service_)\n+ ads_service_->OpenSettings(profile, origin);\n+ }\n+\n+ private:\n+ base::WeakPtr<AdsServiceImpl> ads_service_;\n+\n+ DISALLOW_COPY_AND_ASSIGN(AdsNotificationHandler);\n+};\n+\n+namespace {\n+\n+void Noop() {}\n+\n+int32_t ToMojomNotificationResultInfoResultType(\n+ ads::NotificationResultInfoResultType result_type) {\n+ return (int32_t)result_type;\n+}\n+\n+static std::map<std::string, int> g_schema_resource_ids = {\n+ {\"catalog\", IDR_ADS_CATALOG_SCHEMA},\n+ {\"bundle\", IDR_ADS_BUNDLE_SCHEMA},\n+};\n+\n+int GetSchemaResourceId(const std::string& name) {\n+ if (g_schema_resource_ids.find(name) != g_schema_resource_ids.end())\n+ return g_schema_resource_ids[name];\n+\n+ NOTREACHED();\n+ return 0;\n+}\n+\n+static std::map<std::string, int> g_user_model_resource_ids = {\n+ {\"de\", IDR_ADS_USER_MODEL_DE},\n+ {\"fr\", IDR_ADS_USER_MODEL_FR},\n+ {\"en\", IDR_ADS_USER_MODEL_EN},\n+};\n+\n+int GetUserModelResourceId(const std::string& locale) {\n+ if (g_user_model_resource_ids.find(locale) != g_user_model_resource_ids.end())\n+ return g_user_model_resource_ids[locale];\n+\n+ NOTREACHED();\n+ return 0;\n+}\n+\n+net::URLFetcher::RequestType URLMethodToRequestType(\n+ ads::URLRequestMethod method) {\n+ switch(method) {\n+ case ads::URLRequestMethod::GET:\n+ return net::URLFetcher::RequestType::GET;\n+ case ads::URLRequestMethod::POST:\n+ return net::URLFetcher::RequestType::POST;\n+ case ads::URLRequestMethod::PUT:\n+ return net::URLFetcher::RequestType::PUT;\n+ default:\n+ NOTREACHED();\n+ return net::URLFetcher::RequestType::GET;\n+ }\n+}\n+\n+void EnsureBaseDirectoryExists(const base::FilePath& path) {\n+ if (!DirectoryExists(path))\n+ base::CreateDirectory(path);\n+}\n+\n+void PostWriteCallback(\n+ const base::Callback<void(bool success)>& callback,\n+ scoped_refptr<base::SequencedTaskRunner> reply_task_runner,\n+ bool success) {\n+ // We can't run |callback| on the current thread. Bounce back to\n+ // the |reply_task_runner| which is the correct sequenced thread.\n+ reply_task_runner->PostTask(FROM_HERE,\n+ base::Bind(callback, success));\n+}\n+\n+std::string LoadOnFileTaskRunner(\n+ const base::FilePath& path) {\n+ std::string data;\n+ bool success = base::ReadFileToString(path, &data);\n+\n+ // Make sure the file isn't empty.\n+ if (!success || data.empty()) {\n+ LOG(ERROR) << \"Failed to read file: \" << path.MaybeAsASCII();\n+ return std::string();\n+ }\n+ return data;\n+}\n+\n+std::vector<ads::AdInfo> GetAdsForCategoryOnFileTaskRunner(\n+ const std::string category,\n+ BundleStateDatabase* backend) {\n+ std::vector<ads::AdInfo> ads;\n+ if (!backend)\n+ return ads;\n+\n+ backend->GetAdsForCategory(category, ads);\n+\n+ return ads;\n+}\n+\n+bool ResetOnFileTaskRunner(\n+ const base::FilePath& path) {\n+ return base::DeleteFile(path, false);\n+}\n+\n+bool SaveBundleStateOnFileTaskRunner(\n+ std::unique_ptr<ads::BundleState> bundle_state,\n+ BundleStateDatabase* backend) {\n+ if (backend && backend->SaveBundleState(*bundle_state))\n+ return true;\n+\n+ return false;\n+}\n+\n+}\n+\n+AdsServiceImpl::AdsServiceImpl(Profile* profile) :\n+ profile_(profile),\n+ file_task_runner_(base::CreateSequencedTaskRunnerWithTraits(\n+ {base::MayBlock(), base::TaskPriority::BEST_EFFORT,\n+ base::TaskShutdownBehavior::BLOCK_SHUTDOWN})),\n+ base_path_(profile_->GetPath().AppendASCII(\"ads_service\")),\n+ next_timer_id_(0),\n+ bundle_state_backend_(\n+ new BundleStateDatabase(base_path_.AppendASCII(\"bundle_state\"))),\n+ display_service_(NotificationDisplayService::GetForProfile(profile_)),\n+ enabled_(false),\n+ last_idle_state_(ui::IdleState::IDLE_STATE_ACTIVE),\n+ is_foreground_(!!chrome::FindBrowserWithActiveWindow()),\n+ bat_ads_client_binding_(new bat_ads::AdsClientMojoBridge(this)) {\n+ DCHECK(!profile_->IsOffTheRecord());\n+\n+ file_task_runner_->PostTask(FROM_HERE,\n+ base::BindOnce(&EnsureBaseDirectoryExists, base_path_));\n+ profile_pref_change_registrar_.Init(profile_->GetPrefs());\n+ profile_pref_change_registrar_.Add(\n+ prefs::kBraveAdsEnabled,\n+ base::Bind(&AdsServiceImpl::OnPrefsChanged,\n+ base::Unretained(this)));\n+ profile_pref_change_registrar_.Add(\n+ prefs::kBraveAdsIdleThreshold,\n+ base::Bind(&AdsServiceImpl::OnPrefsChanged,\n+ base::Unretained(this)));\n+\n+ auto* display_service_impl =\n+ static_cast<NotificationDisplayServiceImpl*>(display_service_);\n+\n+ display_service_impl->AddNotificationHandler(\n+ NotificationHandler::Type::BRAVE_ADS,\n+ std::make_unique<AdsNotificationHandler>(this));\n+\n+ if (is_enabled())\n+ Start();\n+ else\n+ Stop();\n+}\n+\n+AdsServiceImpl::~AdsServiceImpl() {\n+ file_task_runner_->DeleteSoon(FROM_HERE, bundle_state_backend_.release());\n+}\n+\n+void AdsServiceImpl::OnInitialize() {\n+ enabled_ = true;\n+ ResetTimer();\n+}\n+\n+void AdsServiceImpl::OnCreate() {\n+ if (!bat_ads_.is_bound()) {\n+ // TODO(bridiver) - reconnect?\n+ return;\n+ }\n+\n+ bat_ads_->Initialize(\n+ base::BindOnce(&AdsServiceImpl::OnInitialize, AsWeakPtr()));\n+}\n+\n+void ConnectionClosed() {\n+ // TODO(bridiver)\n+}\n+\n+void AdsServiceImpl::Start() {\n+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);\n+ DCHECK(is_enabled());\n+ DCHECK(!bat_ads_.is_bound());\n+\n+ bat_ads::mojom::BatAdsClientAssociatedPtrInfo client_ptr_info;\n+ bat_ads_client_binding_.Bind(mojo::MakeRequest(&client_ptr_info));\n+\n+ content::ServiceManagerConnection* connection =\n+ content::ServiceManagerConnection::GetForProcess();\n+\n+ if (!connection)\n+ return;\n+\n+ connection->GetConnector()->BindInterface(\n+ bat_ads::mojom::kServiceName, &bat_ads_service_);\n+\n+ bat_ads_service_.set_connection_error_handler(\n+ base::Bind(&ConnectionClosed));\n+\n+ bool is_production = false;\n+#if defined(OFFICIAL_BUILD)\n+ is_production = true;\n+#endif\n+ bool is_debug = true;\n+#if defined(NDEBUG)\n+ is_debug = false;\n+#endif\n+ bool is_testing = false;\n+\n+ const base::CommandLine& command_line =\n+ *base::CommandLine::ForCurrentProcess();\n+\n+ if (command_line.HasSwitch(switches::kProduction)) {\n+ is_production = true;\n+ }\n+ if (command_line.HasSwitch(switches::kDebug)) {\n+ is_debug = true;\n+ }\n+ if (command_line.HasSwitch(switches::kTesting)) {\n+ is_testing = true;\n+ }\n+\n+ bat_ads_service_->SetProduction(is_production, base::BindOnce(&Noop));\n+ bat_ads_service_->SetDebug(is_debug, base::BindOnce(&Noop));\n+ bat_ads_service_->SetTesting(is_testing, base::BindOnce(&Noop));\n+\n+ bat_ads_service_->Create(std::move(client_ptr_info), MakeRequest(&bat_ads_),\n+ base::BindOnce(&AdsServiceImpl::OnCreate, AsWeakPtr()));\n+}\n+\n+void AdsServiceImpl::Stop() {\n+ enabled_ = false;\n+ Shutdown();\n+}\n+\n+void AdsServiceImpl::ResetTimer() {\n+ idle_poll_timer_.Stop();\n+ idle_poll_timer_.Start(FROM_HERE,\n+ base::TimeDelta::FromSeconds(GetIdleThreshold()), this,\n+ &AdsServiceImpl::CheckIdleState);\n+}\n+\n+void AdsServiceImpl::CheckIdleState() {\n+ ui::CalculateIdleState(GetIdleThreshold(),\n+ base::BindRepeating(&AdsServiceImpl::OnIdleState,\n+ base::Unretained(this)));\n+}\n+\n+void AdsServiceImpl::OnIdleState(ui::IdleState idle_state) {\n+ if (!connected() || idle_state == last_idle_state_)\n+ return;\n+\n+ if (idle_state == ui::IdleState::IDLE_STATE_ACTIVE)\n+ bat_ads_->OnUnIdle(base::BindOnce(&Noop));\n+ else\n+ bat_ads_->OnIdle(base::BindOnce(&Noop));\n+\n+ last_idle_state_ = idle_state;\n+}\n+\n+void AdsServiceImpl::Shutdown() {\n+ for (const auto fetcher : fetchers_) {\n+ delete fetcher.first;\n+ }\n+ fetchers_.clear();\n+ idle_poll_timer_.Stop();\n+\n+ if (connected()) {\n+ bat_ads_->SaveCachedInfo(base::BindOnce(&Noop));\n+ if (!enabled_) {\n+ // this is kind of weird, but we need to call Initialize on disable too\n+ bat_ads_->Initialize(base::BindOnce(&Noop));\n+ }\n+ bat_ads_.reset();\n+ bat_ads_client_binding_.Close();\n+ }\n+\n+ for (NotificationInfoMap::iterator it = notification_ids_.begin();\n+ it != notification_ids_.end(); ++it) {\n+ const std::string notification_id = it->first;\n+ display_service_->Close(NotificationHandler::Type::BRAVE_ADS,\n+ notification_id);\n+ }\n+ notification_ids_.clear();\n+}\n+\n+void AdsServiceImpl::OnPrefsChanged(const std::string& pref) {\n+ if (pref == prefs::kBraveAdsEnabled) {\n+ if (is_enabled() && !enabled_) {\n+ Start();\n+ } else if (!is_enabled() && enabled_) {\n+ Stop();\n+ }\n+ } else if (pref == prefs::kBraveAdsIdleThreshold) {\n+ ResetTimer();\n+ }\n+}\n+\n+bool AdsServiceImpl::is_enabled() const {\n+ return profile_->GetPrefs()->GetBoolean(prefs::kBraveAdsEnabled);\n+}\n+\n+bool AdsServiceImpl::IsAdsEnabled() const {\n+ return is_enabled();\n+}\n+\n+void AdsServiceImpl::TabUpdated(SessionID tab_id,\n+ const GURL& url,\n+ const bool is_active) {\n+ if (!connected())\n+ return;\n+\n+ bat_ads_->TabUpdated(tab_id.id(),\n+ url.spec(),\n+ is_active,\n+ profile_->IsOffTheRecord(),\n+ base::BindOnce(&Noop));\n+\n+ if (is_foreground_ && !chrome::FindBrowserWithActiveWindow()) {\n+ bat_ads_->OnBackground(base::BindOnce(&Noop));\n+ } else if (!is_foreground_) {\n+ is_foreground_ = true;\n+ bat_ads_->OnForeground(base::BindOnce(&Noop));\n+ }\n+}\n+\n+void AdsServiceImpl::TabClosed(SessionID tab_id) {\n+ if (!connected())\n+ return\n+\n+ bat_ads_->TabClosed(tab_id.id(), base::BindOnce(&Noop));\n+}\n+\n+void AdsServiceImpl::ClassifyPage(const std::string& url,\n+ const std::string& page) {\n+ if (!connected())\n+ return\n+\n+ bat_ads_->ClassifyPage(url, page, base::BindOnce(&Noop));\n+}\n+\n+int AdsServiceImpl::GetIdleThreshold() {\n+ return profile_->GetPrefs()->GetInteger(prefs::kBraveAdsIdleThreshold);\n+}\n+\n+void AdsServiceImpl::SetIdleThreshold(const int threshold) {\n+ profile_->GetPrefs()->SetInteger(prefs::kBraveAdsIdleThreshold, threshold);\n+}\n+\n+bool AdsServiceImpl::IsNotificationsAvailable() const {\n+#if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)\n+ return true;\n+#else\n+ return false;\n+#endif\n+}\n+\n+void AdsServiceImpl::LoadUserModelForLocale(\n+ const std::string& locale,\n+ ads::OnLoadCallback callback) const {\n+ base::StringPiece user_model_raw =\n+ ui::ResourceBundle::GetSharedInstance().GetRawDataResource(\n+ GetUserModelResourceId(locale));\n+\n+ std::string user_model;\n+ user_model_raw.CopyToString(&user_model);\n+ callback(ads::Result::SUCCESS, user_model);\n+}\n+\n+void AdsServiceImpl::OnURLsDeleted(history::HistoryService* history_service,\n+ const history::DeletionInfo& deletion_info) {\n+ if (!connected())\n+ return;\n+\n+ bat_ads_->RemoveAllHistory(base::BindOnce(&Noop));\n+}\n+\n+void AdsServiceImpl::OnMediaStart(SessionID tab_id) {\n+ if (!connected())\n+ return;\n+\n+ bat_ads_->OnMediaPlaying(tab_id.id(), base::BindOnce(&Noop));\n+}\n+\n+void AdsServiceImpl::OnMediaStop(SessionID tab_id) {\n+ if (!connected())\n+ return;\n+\n+ bat_ads_->OnMediaStopped(tab_id.id(), base::BindOnce(&Noop));\n+}\n+\n+uint64_t AdsServiceImpl::GetAdsPerHour() const {\n+ return profile_->GetPrefs()->GetUint64(prefs::kBraveAdsPerHour);\n+}\n+\n+uint64_t AdsServiceImpl::GetAdsPerDay() const {\n+ return profile_->GetPrefs()->GetUint64(prefs::kBraveAdsPerDay);\n+}\n+\n+void AdsServiceImpl::ShowNotification(\n+ std::unique_ptr<ads::NotificationInfo> info) {\n+ std::string notification_id;\n+ auto notification =\n+ CreateAdNotification(*info, ¬ification_id);\n+\n+ notification_ids_[notification_id] = std::move(info);\n+\n+ display_service_->Display(NotificationHandler::Type::BRAVE_ADS,\n+ *notification);\n+}\n+\n+void AdsServiceImpl::Save(const std::string& name,\n+ const std::string& value,\n+ ads::OnSaveCallback callback) {\n+ base::ImportantFileWriter writer(\n+ base_path_.AppendASCII(name), file_task_runner_);\n+\n+ writer.RegisterOnNextWriteCallbacks(\n+ base::Closure(),\n+ base::Bind(\n+ &PostWriteCallback,\n+ base::Bind(&AdsServiceImpl::OnSaved, AsWeakPtr(),\n+ std::move(callback)),\n+ base::SequencedTaskRunnerHandle::Get()));\n+\n+ writer.WriteNow(std::make_unique<std::string>(value));\n+}\n+\n+void AdsServiceImpl::Load(const std::string& name,\n+ ads::OnLoadCallback callback) {\n+ base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE,\n+ base::BindOnce(&LoadOnFileTaskRunner, base_path_.AppendASCII(name)),\n+ base::BindOnce(&AdsServiceImpl::OnLoaded,\n+ AsWeakPtr(),\n+ std::move(callback)));\n+}\n+\n+const std::string AdsServiceImpl::LoadJsonSchema(const std::string& name) {\n+ base::StringPiece schema_raw =\n+ ui::ResourceBundle::GetSharedInstance().GetRawDataResource(\n+ GetSchemaResourceId(name));\n+\n+ std::string schema;\n+ schema_raw.CopyToString(&schema);\n+ return schema;\n+}\n+\n+void AdsServiceImpl::SaveBundleState(\n+ std::unique_ptr<ads::BundleState> bundle_state,\n+ ads::OnSaveCallback callback) {\n+ base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE,\n+ base::BindOnce(&SaveBundleStateOnFileTaskRunner,\n+ base::Passed(std::move(bundle_state)),\n+ bundle_state_backend_.get()),\n+ base::BindOnce(&AdsServiceImpl::OnSaveBundleState,\n+ AsWeakPtr(),\n+ callback));\n+}\n+\n+void AdsServiceImpl::OnSaveBundleState(const ads::OnSaveCallback& callback,\n+ bool success) {\n+ if (connected())\n+ callback(success ? ads::Result::SUCCESS : ads::Result::FAILED);\n+}\n+\n+void AdsServiceImpl::OnLoaded(\n+ const ads::OnLoadCallback& callback,\n+ const std::string& value) {\n+ if (!connected())\n+ return;\n+\n+ if (value.empty())\n+ callback(ads::Result::FAILED, value);\n+ else\n+ callback(ads::Result::SUCCESS, value);\n+}\n+\n+void AdsServiceImpl::OnSaved(\n+ const ads::OnSaveCallback& callback,\n+ bool success) {\n+ if (connected())\n+ callback(success ? ads::Result::SUCCESS : ads::Result::FAILED);\n+}\n+\n+void AdsServiceImpl::Reset(const std::string& name,\n+ ads::OnResetCallback callback) {\n+ base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE,\n+ base::BindOnce(&ResetOnFileTaskRunner, base_path_.AppendASCII(name)),\n+ base::BindOnce(&AdsServiceImpl::OnReset,\n+ AsWeakPtr(),\n+ std::move(callback)));\n+}\n+\n+void AdsServiceImpl::OnReset(const ads::OnResetCallback& callback,\n+ bool success) {\n+ if (connected())\n+ callback(success ? ads::Result::SUCCESS : ads::Result::FAILED);\n+}\n+\n+void AdsServiceImpl::GetAds(\n+ const std::string& region,\n+ const std::string& category,\n+ ads::OnGetAdsCallback callback) {\n+ base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE,\n+ base::BindOnce(&GetAdsForCategoryOnFileTaskRunner,\n+ category,\n+ bundle_state_backend_.get()),\n+ base::BindOnce(&AdsServiceImpl::OnGetAdsForCategory,\n+ AsWeakPtr(),\n+ std::move(callback),\n+ region,\n+ category));\n+}\n+\n+void AdsServiceImpl::OnGetAdsForCategory(\n+ const ads::OnGetAdsCallback& callback,\n+ const std::string& region,\n+ const std::string& category,\n+ const std::vector<ads::AdInfo>& ads) {\n+ if (!connected())\n+ return;\n+\n+ callback(ads.empty() ? ads::Result::FAILED : ads::Result::SUCCESS,\n+ region,\n+ category,\n+ ads);\n+}\n+\n+void AdsServiceImpl::LoadSampleBundle(\n+ ads::OnLoadSampleBundleCallback callback) {\n+ base::StringPiece sample_bundle_raw =\n+ ui::ResourceBundle::GetSharedInstance().GetRawDataResource(\n+ IDR_ADS_SAMPLE_BUNDLE);\n+\n+ std::string sample_bundle;\n+ sample_bundle_raw.CopyToString(&sample_bundle);\n+ callback(ads::Result::SUCCESS, sample_bundle);\n+}\n+\n+bool AdsServiceImpl::IsNetworkConnectionAvailable() {\n+ // TODO - implement this","path":"components/brave_ads/browser/ads_service_impl.cc","position":655,"original_position":655,"commit_id":"9cac132fb187fce94979006f896564dd164713c0","original_commit_id":"9cac132fb187fce94979006f896564dd164713c0","user":{"login":"bridiver","id":34129,"node_id":"MDQ6VXNlcjM0MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/34129?v=4","gravatar_id":"","url":"https://api.github.com/users/bridiver","html_url":"https://github.com/bridiver","followers_url":"https://api.github.com/users/bridiver/followers","following_url":"https://api.github.com/users/bridiver/following{/other_user}","gists_url":"https://api.github.com/users/bridiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bridiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridiver/subscriptions","organizations_url":"https://api.github.com/users/bridiver/orgs","repos_url":"https://api.github.com/users/bridiver/repos","events_url":"https://api.github.com/users/bridiver/events{/privacy}","received_events_url":"https://api.github.com/users/bridiver/received_events","type":"User","site_admin":false},"body":"this can be implemented in a follow-up. It was added kind of late in the process and I don't want to hold this PR up longer","created_at":"2018-11-28T18:46:18Z","updated_at":"2018-11-28T18:46:19Z","html_url":"https://github.com/brave/brave-core/pull/765#discussion_r237213097","pull_request_url":"https://api.github.com/repos/brave/brave-core/pulls/765","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments/237213097"},"html":{"href":"https://github.com/brave/brave-core/pull/765#discussion_r237213097"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-core/pulls/765"}},"in_reply_to_id":236906357},"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/765","id":226776845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Nzc2ODQ1","html_url":"https://github.com/brave/brave-core/pull/765","diff_url":"https://github.com/brave/brave-core/pull/765.diff","patch_url":"https://github.com/brave/brave-core/pull/765.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/765","number":765,"state":"open","locked":false,"title":"Brave ads","user":{"login":"bridiver","id":34129,"node_id":"MDQ6VXNlcjM0MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/34129?v=4","gravatar_id":"","url":"https://api.github.com/users/bridiver","html_url":"https://github.com/bridiver","followers_url":"https://api.github.com/users/bridiver/followers","following_url":"https://api.github.com/users/bridiver/following{/other_user}","gists_url":"https://api.github.com/users/bridiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bridiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridiver/subscriptions","organizations_url":"https://api.github.com/users/bridiver/orgs","repos_url":"https://api.github.com/users/bridiver/repos","events_url":"https://api.github.com/users/bridiver/events{/privacy}","received_events_url":"https://api.github.com/users/bridiver/received_events","type":"User","site_admin":false},"body":"## Submitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- Verified that these changes build without errors on\r\n - [ ] Windows\r\n - [ ] macOS\r\n - [ ] Linux\r\n- Verified that these changes pass automated tests (`npm test brave_unit_tests && npm test brave_browser_tests`) on\r\n - [ ] Windows\r\n - [ ] macOS\r\n - [ ] Linux\r\n- [ ] Ran `git rebase master` (if needed).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source","created_at":"2018-10-30T03:03:29Z","updated_at":"2018-11-28T18:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09142c0267d41a2e762abd2b27e83d0fb5cc3eb0","assignee":{"login":"bridiver","id":34129,"node_id":"MDQ6VXNlcjM0MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/34129?v=4","gravatar_id":"","url":"https://api.github.com/users/bridiver","html_url":"https://github.com/bridiver","followers_url":"https://api.github.com/users/bridiver/followers","following_url":"https://api.github.com/users/bridiver/following{/other_user}","gists_url":"https://api.github.com/users/bridiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bridiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridiver/subscriptions","organizations_url":"https://api.github.com/users/bridiver/orgs","repos_url":"https://api.github.com/users/bridiver/repos","events_url":"https://api.github.com/users/bridiver/events{/privacy}","received_events_url":"https://api.github.com/users/bridiver/received_events","type":"User","site_admin":false},"assignees":[{"login":"bridiver","id":34129,"node_id":"MDQ6VXNlcjM0MTI5","avatar_url":"https://avatars3.githubusercontent.com/u/34129?v=4","gravatar_id":"","url":"https://api.github.com/users/bridiver","html_url":"https://github.com/bridiver","followers_url":"https://api.github.com/users/bridiver/followers","following_url":"https://api.github.com/users/bridiver/following{/other_user}","gists_url":"https://api.github.com/users/bridiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bridiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridiver/subscriptions","organizations_url":"https://api.github.com/users/bridiver/orgs","repos_url":"https://api.github.com/users/bridiver/repos","events_url":"https://api.github.com/users/bridiver/events{/privacy}","received_events_url":"https://api.github.com/users/bridiver/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},{"login":"darkdh","id":11330831,"node_id":"MDQ6VXNlcjExMzMwODMx","avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/765/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/765/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/765/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/9cac132fb187fce94979006f896564dd164713c0","head":{"label":"brave:brave-ads","ref":"brave-ads","sha":"9cac132fb187fce94979006f896564dd164713c0","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-11-28T18:31:46Z","pushed_at":"2018-11-28T18:35:24Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":61471,"stargazers_count":215,"watchers_count":215,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":37,"watchers":215,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"f8f2b2e5bf97260f5568cfb18610491446950665","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-11-28T18:31:46Z","pushed_at":"2018-11-28T18:35:24Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":61471,"stargazers_count":215,"watchers_count":215,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":37,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/765"},"html":{"href":"https://github.com/brave/brave-core/pull/765"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/765"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/765/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/765/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/765/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/9cac132fb187fce94979006f896564dd164713c0"}},"author_association":"COLLABORATOR"}} | {
"id": 110198384,
"name": "brave/brave-core",
"url": "https://api.github.com/repos/brave/brave-core"
} | {
"id": 34129,
"login": "bridiver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34129?",
"url": "https://api.github.com/users/bridiver"
} | {
"id": 12301619,
"login": "brave",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12301619?",
"url": "https://api.github.com/orgs/brave"
} | 2018-11-28T18:46:18 | 8663953733 | {"actor":{"display_login":"bridiver"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/keymanapp/keyman/pulls/comments/235224091","pull_request_review_id":177041383,"id":235224091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTIyNDA5MQ==","diff_hunk":"@@ -33,56 +116,84 @@ class LMLayerWorker {\n * so that this can be tested **outside of a Worker**.\n */\n private _postMessage: PostMessage;\n- private _importScripts: ImportScripts;\n \n constructor(options = {\n postMessage: null,\n- importScripts: null\n }) {\n this._postMessage = options.postMessage || postMessage;\n- this._importScripts = options.importScripts || importScripts;\n }\n \n /**\n * A function that can be set as self.onmessage (the Worker\n * message handler).\n * NOTE! You must bind it to a specific instance, e.g.:\n- * \n+ *\n * // Do this!\n * self.onmessage = worker.onMessage.bind(worker);\n- * \n+ *\n * Incorrect:\n- * \n+ *\n * // Don't do this!\n * self.onmessage = worker.onMessage;\n- * \n+ *\n * See: .install();\n */\n onMessage(event: MessageEvent) {\n const {message} = event.data;\n+ // We must have gotten a message!\n if (!message) {\n throw new Error(`Missing required 'message' attribute: ${event.data}`)\n }\n \n- // Load the model.\n- let model = this._importScripts(event.data.model);\n+ // ...that message must have been 'initialize'!\n+ if (message !== 'initialize') {\n+ throw new Error(`invalid message; expected 'initialize' but got ${message}`);\n+ }\n+\n+ let payload: InitializeMessage = event.data;\n+\n+ let {model, configuration} = this.loadModel(\n+ // TODO: validate configuration, and provide valid configuration in tests.\n+ // @ts-ignore\n+ payload.model, payload.configuration || {}","path":"common/predictive-text/worker/index.ts","position":148,"original_position":148,"commit_id":"0ea5fc9766bd415ed459c143aa32cfcbc26808d5","original_commit_id":"17dfd2d76e52d3602a535d3eeed0480601e8ff85","user":{"login":"jahorton","id":25213402,"node_id":"MDQ6VXNlcjI1MjEzNDAy","avatar_url":"https://avatars3.githubusercontent.com/u/25213402?v=4","gravatar_id":"","url":"https://api.github.com/users/jahorton","html_url":"https://github.com/jahorton","followers_url":"https://api.github.com/users/jahorton/followers","following_url":"https://api.github.com/users/jahorton/following{/other_user}","gists_url":"https://api.github.com/users/jahorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jahorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahorton/subscriptions","organizations_url":"https://api.github.com/users/jahorton/orgs","repos_url":"https://api.github.com/users/jahorton/repos","events_url":"https://api.github.com/users/jahorton/events{/privacy}","received_events_url":"https://api.github.com/users/jahorton/received_events","type":"User","site_admin":false},"body":"I'm not entirely clear yet, so maybe a specific example might help me. If we have 10 different languages that implement FST-based predictive modeling, what you're saying means that none of them would share common code? No common FST lookup function library or anything?","created_at":"2018-11-21T01:06:32Z","updated_at":"2018-11-21T01:06:33Z","html_url":"https://github.com/keymanapp/keyman/pull/1331#discussion_r235224091","pull_request_url":"https://api.github.com/repos/keymanapp/keyman/pulls/1331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/comments/235224091"},"html":{"href":"https://github.com/keymanapp/keyman/pull/1331#discussion_r235224091"},"pull_request":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1331"}},"in_reply_to_id":234907244},"pull_request":{"url":"https://api.github.com/repos/keymanapp/keyman/pulls/1331","id":232177652,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTc3NjUy","html_url":"https://github.com/keymanapp/keyman/pull/1331","diff_url":"https://github.com/keymanapp/keyman/pull/1331.diff","patch_url":"https://github.com/keymanapp/keyman/pull/1331.patch","issue_url":"https://api.github.com/repos/keymanapp/keyman/issues/1331","number":1331,"state":"open","locked":false,"title":"[LMLayer] Karma integration tests, and remove importScripts()","user":{"login":"eddieantonio","id":2294397,"node_id":"MDQ6VXNlcjIyOTQzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2294397?v=4","gravatar_id":"","url":"https://api.github.com/users/eddieantonio","html_url":"https://github.com/eddieantonio","followers_url":"https://api.github.com/users/eddieantonio/followers","following_url":"https://api.github.com/users/eddieantonio/following{/other_user}","gists_url":"https://api.github.com/users/eddieantonio/gists{/gist_id}","starred_url":"https://api.github.com/users/eddieantonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddieantonio/subscriptions","organizations_url":"https://api.github.com/users/eddieantonio/orgs","repos_url":"https://api.github.com/users/eddieantonio/repos","events_url":"https://api.github.com/users/eddieantonio/events{/privacy}","received_events_url":"https://api.github.com/users/eddieantonio/received_events","type":"User","site_admin":false},"body":"This PR removes the need to mock `importScripts()`, and adds some Karma integration tests, using the two-stage compilation process to import `embedded_worker.js` in the browser, and run its code in a bona fide Web Worker.","created_at":"2018-11-20T03:02:31Z","updated_at":"2018-11-21T01:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"831ac4dc2eee076e44ca971f2fe5648fe8d91fd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1110906892,"node_id":"MDU6TGFiZWwxMTEwOTA2ODky","url":"https://api.github.com/repos/keymanapp/keyman/labels/lm-layer","name":"lm-layer","color":"a8b1f4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/keymanapp/keyman/pulls/1331/commits","review_comments_url":"https://api.github.com/repos/keymanapp/keyman/pulls/1331/comments","review_comment_url":"https://api.github.com/repos/keymanapp/keyman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keymanapp/keyman/issues/1331/comments","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/0ea5fc9766bd415ed459c143aa32cfcbc26808d5","head":{"label":"keymanapp:lmlayer-sans-import-scripts","ref":"lmlayer-sans-import-scripts","sha":"0ea5fc9766bd415ed459c143aa32cfcbc26808d5","user":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"repo":{"id":26063183,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA2MzE4Mw==","name":"keyman","full_name":"keymanapp/keyman","private":false,"owner":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keymanapp/keyman","description":"Keyman cross platform input methods","fork":false,"url":"https://api.github.com/repos/keymanapp/keyman","forks_url":"https://api.github.com/repos/keymanapp/keyman/forks","keys_url":"https://api.github.com/repos/keymanapp/keyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keymanapp/keyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keymanapp/keyman/teams","hooks_url":"https://api.github.com/repos/keymanapp/keyman/hooks","issue_events_url":"https://api.github.com/repos/keymanapp/keyman/issues/events{/number}","events_url":"https://api.github.com/repos/keymanapp/keyman/events","assignees_url":"https://api.github.com/repos/keymanapp/keyman/assignees{/user}","branches_url":"https://api.github.com/repos/keymanapp/keyman/branches{/branch}","tags_url":"https://api.github.com/repos/keymanapp/keyman/tags","blobs_url":"https://api.github.com/repos/keymanapp/keyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keymanapp/keyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keymanapp/keyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/keymanapp/keyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/{sha}","languages_url":"https://api.github.com/repos/keymanapp/keyman/languages","stargazers_url":"https://api.github.com/repos/keymanapp/keyman/stargazers","contributors_url":"https://api.github.com/repos/keymanapp/keyman/contributors","subscribers_url":"https://api.github.com/repos/keymanapp/keyman/subscribers","subscription_url":"https://api.github.com/repos/keymanapp/keyman/subscription","commits_url":"https://api.github.com/repos/keymanapp/keyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/keymanapp/keyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/keymanapp/keyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/keymanapp/keyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/keymanapp/keyman/contents/{+path}","compare_url":"https://api.github.com/repos/keymanapp/keyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keymanapp/keyman/merges","archive_url":"https://api.github.com/repos/keymanapp/keyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keymanapp/keyman/downloads","issues_url":"https://api.github.com/repos/keymanapp/keyman/issues{/number}","pulls_url":"https://api.github.com/repos/keymanapp/keyman/pulls{/number}","milestones_url":"https://api.github.com/repos/keymanapp/keyman/milestones{/number}","notifications_url":"https://api.github.com/repos/keymanapp/keyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keymanapp/keyman/labels{/name}","releases_url":"https://api.github.com/repos/keymanapp/keyman/releases{/id}","deployments_url":"https://api.github.com/repos/keymanapp/keyman/deployments","created_at":"2014-11-01T21:01:44Z","updated_at":"2018-11-19T06:27:30Z","pushed_at":"2018-11-20T18:12:14Z","git_url":"git://github.com/keymanapp/keyman.git","ssh_url":"git@github.com:keymanapp/keyman.git","clone_url":"https://github.com/keymanapp/keyman.git","svn_url":"https://github.com/keymanapp/keyman","homepage":"https://keyman.com/","size":182152,"stargazers_count":68,"watchers_count":68,"language":"Pascal","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":251,"license":null,"forks":27,"open_issues":251,"watchers":68,"default_branch":"master"}},"base":{"label":"keymanapp:lmlayer-init","ref":"lmlayer-init","sha":"c8454f3ba502d0cde719cd2ec746a4dc74ac1a64","user":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"repo":{"id":26063183,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA2MzE4Mw==","name":"keyman","full_name":"keymanapp/keyman","private":false,"owner":{"login":"keymanapp","id":12402926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAyOTI2","avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keymanapp/keyman","description":"Keyman cross platform input methods","fork":false,"url":"https://api.github.com/repos/keymanapp/keyman","forks_url":"https://api.github.com/repos/keymanapp/keyman/forks","keys_url":"https://api.github.com/repos/keymanapp/keyman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keymanapp/keyman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keymanapp/keyman/teams","hooks_url":"https://api.github.com/repos/keymanapp/keyman/hooks","issue_events_url":"https://api.github.com/repos/keymanapp/keyman/issues/events{/number}","events_url":"https://api.github.com/repos/keymanapp/keyman/events","assignees_url":"https://api.github.com/repos/keymanapp/keyman/assignees{/user}","branches_url":"https://api.github.com/repos/keymanapp/keyman/branches{/branch}","tags_url":"https://api.github.com/repos/keymanapp/keyman/tags","blobs_url":"https://api.github.com/repos/keymanapp/keyman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keymanapp/keyman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keymanapp/keyman/git/refs{/sha}","trees_url":"https://api.github.com/repos/keymanapp/keyman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keymanapp/keyman/statuses/{sha}","languages_url":"https://api.github.com/repos/keymanapp/keyman/languages","stargazers_url":"https://api.github.com/repos/keymanapp/keyman/stargazers","contributors_url":"https://api.github.com/repos/keymanapp/keyman/contributors","subscribers_url":"https://api.github.com/repos/keymanapp/keyman/subscribers","subscription_url":"https://api.github.com/repos/keymanapp/keyman/subscription","commits_url":"https://api.github.com/repos/keymanapp/keyman/commits{/sha}","git_commits_url":"https://api.github.com/repos/keymanapp/keyman/git/commits{/sha}","comments_url":"https://api.github.com/repos/keymanapp/keyman/comments{/number}","issue_comment_url":"https://api.github.com/repos/keymanapp/keyman/issues/comments{/number}","contents_url":"https://api.github.com/repos/keymanapp/keyman/contents/{+path}","compare_url":"https://api.github.com/repos/keymanapp/keyman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keymanapp/keyman/merges","archive_url":"https://api.github.com/repos/keymanapp/keyman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keymanapp/keyman/downloads","issues_url":"https://api.github.com/repos/keymanapp/keyman/issues{/number}","pulls_url":"https://api.github.com/repos/keymanapp/keyman/pulls{/number}","milestones_url":"https://api.github.com/repos/keymanapp/keyman/milestones{/number}","notifications_url":"https://api.github.com/repos/keymanapp/keyman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keymanapp/keyman/labels{/name}","releases_url":"https://api.github.com/repos/keymanapp/keyman/releases{/id}","deployments_url":"https://api.github.com/repos/keymanapp/keyman/deployments","created_at":"2014-11-01T21:01:44Z","updated_at":"2018-11-19T06:27:30Z","pushed_at":"2018-11-20T18:12:14Z","git_url":"git://github.com/keymanapp/keyman.git","ssh_url":"git@github.com:keymanapp/keyman.git","clone_url":"https://github.com/keymanapp/keyman.git","svn_url":"https://github.com/keymanapp/keyman","homepage":"https://keyman.com/","size":182152,"stargazers_count":68,"watchers_count":68,"language":"Pascal","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":251,"license":null,"forks":27,"open_issues":251,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1331"},"html":{"href":"https://github.com/keymanapp/keyman/pull/1331"},"issue":{"href":"https://api.github.com/repos/keymanapp/keyman/issues/1331"},"comments":{"href":"https://api.github.com/repos/keymanapp/keyman/issues/1331/comments"},"review_comments":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1331/comments"},"review_comment":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keymanapp/keyman/pulls/1331/commits"},"statuses":{"href":"https://api.github.com/repos/keymanapp/keyman/statuses/0ea5fc9766bd415ed459c143aa32cfcbc26808d5"}},"author_association":"NONE"}} | {
"id": 26063183,
"name": "keymanapp/keyman",
"url": "https://api.github.com/repos/keymanapp/keyman"
} | {
"id": 25213402,
"login": "jahorton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25213402?",
"url": "https://api.github.com/users/jahorton"
} | {
"id": 12402926,
"login": "keymanapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12402926?",
"url": "https://api.github.com/orgs/keymanapp"
} | 2018-11-21T01:06:32 | 8623685801 | {"actor":{"display_login":"jahorton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/keymanapp/keyboards/pulls/comments/171749562","pull_request_review_id":100658924,"id":171749562,"diff_hunk":"@@ -0,0 +1,10 @@\n+{\n+ \"license\": \"mit\",\n+ \"languages\": {\n+ \"som\": {}","path":"release/el/el_osmanya/el_osmanya.keyboard_info","position":4,"original_position":4,"commit_id":"dc4c56e59898091068921e89cfe9b25da8e63b4a","original_commit_id":"dc4c56e59898091068921e89cfe9b25da8e63b4a","user":{"login":"darcywong00","id":7358010,"avatar_url":"https://avatars0.githubusercontent.com/u/7358010?v=4","gravatar_id":"","url":"https://api.github.com/users/darcywong00","html_url":"https://github.com/darcywong00","followers_url":"https://api.github.com/users/darcywong00/followers","following_url":"https://api.github.com/users/darcywong00/following{/other_user}","gists_url":"https://api.github.com/users/darcywong00/gists{/gist_id}","starred_url":"https://api.github.com/users/darcywong00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcywong00/subscriptions","organizations_url":"https://api.github.com/users/darcywong00/orgs","repos_url":"https://api.github.com/users/darcywong00/repos","events_url":"https://api.github.com/users/darcywong00/events{/privacy}","received_events_url":"https://api.github.com/users/darcywong00/received_events","type":"User","site_admin":false},"body":"Going from ISO 639-3 to BCP 47 tags, the language tag will need to change per the CI server\r\n```\r\n'som' is a valid tag but is not canonical: 'som' should be 'so'\r\n```","created_at":"2018-03-02T02:06:25Z","updated_at":"2018-03-02T02:07:56Z","html_url":"https://github.com/keymanapp/keyboards/pull/71#discussion_r171749562","pull_request_url":"https://api.github.com/repos/keymanapp/keyboards/pulls/71","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/comments/171749562"},"html":{"href":"https://github.com/keymanapp/keyboards/pull/71#discussion_r171749562"},"pull_request":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/keymanapp/keyboards/pulls/71","id":133396669,"html_url":"https://github.com/keymanapp/keyboards/pull/71","diff_url":"https://github.com/keymanapp/keyboards/pull/71.diff","patch_url":"https://github.com/keymanapp/keyboards/pull/71.patch","issue_url":"https://api.github.com/repos/keymanapp/keyboards/issues/71","number":71,"state":"open","locked":false,"title":"[el_osmanya] Osmanya Keyboard","user":{"login":"MakaraSok","id":28331388,"avatar_url":"https://avatars3.githubusercontent.com/u/28331388?v=4","gravatar_id":"","url":"https://api.github.com/users/MakaraSok","html_url":"https://github.com/MakaraSok","followers_url":"https://api.github.com/users/MakaraSok/followers","following_url":"https://api.github.com/users/MakaraSok/following{/other_user}","gists_url":"https://api.github.com/users/MakaraSok/gists{/gist_id}","starred_url":"https://api.github.com/users/MakaraSok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakaraSok/subscriptions","organizations_url":"https://api.github.com/users/MakaraSok/orgs","repos_url":"https://api.github.com/users/MakaraSok/repos","events_url":"https://api.github.com/users/MakaraSok/events{/privacy}","received_events_url":"https://api.github.com/users/MakaraSok/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-01T06:25:15Z","updated_at":"2018-03-02T02:07:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcff69e327eb41f7e2aff5b757306b98d718a46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":636485513,"url":"https://api.github.com/repos/keymanapp/keyboards/labels/keyboard","name":"keyboard","color":"0e8a16","default":false},{"id":847589239,"url":"https://api.github.com/repos/keymanapp/keyboards/labels/new","name":"new","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/keymanapp/keyboards/pulls/71/commits","review_comments_url":"https://api.github.com/repos/keymanapp/keyboards/pulls/71/comments","review_comment_url":"https://api.github.com/repos/keymanapp/keyboards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keymanapp/keyboards/issues/71/comments","statuses_url":"https://api.github.com/repos/keymanapp/keyboards/statuses/dc4c56e59898091068921e89cfe9b25da8e63b4a","head":{"label":"MakaraSok:el_osmanya","ref":"el_osmanya","sha":"dc4c56e59898091068921e89cfe9b25da8e63b4a","user":{"login":"MakaraSok","id":28331388,"avatar_url":"https://avatars3.githubusercontent.com/u/28331388?v=4","gravatar_id":"","url":"https://api.github.com/users/MakaraSok","html_url":"https://github.com/MakaraSok","followers_url":"https://api.github.com/users/MakaraSok/followers","following_url":"https://api.github.com/users/MakaraSok/following{/other_user}","gists_url":"https://api.github.com/users/MakaraSok/gists{/gist_id}","starred_url":"https://api.github.com/users/MakaraSok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakaraSok/subscriptions","organizations_url":"https://api.github.com/users/MakaraSok/orgs","repos_url":"https://api.github.com/users/MakaraSok/repos","events_url":"https://api.github.com/users/MakaraSok/events{/privacy}","received_events_url":"https://api.github.com/users/MakaraSok/received_events","type":"User","site_admin":false},"repo":{"id":96071835,"name":"keyboards","full_name":"MakaraSok/keyboards","owner":{"login":"MakaraSok","id":28331388,"avatar_url":"https://avatars3.githubusercontent.com/u/28331388?v=4","gravatar_id":"","url":"https://api.github.com/users/MakaraSok","html_url":"https://github.com/MakaraSok","followers_url":"https://api.github.com/users/MakaraSok/followers","following_url":"https://api.github.com/users/MakaraSok/following{/other_user}","gists_url":"https://api.github.com/users/MakaraSok/gists{/gist_id}","starred_url":"https://api.github.com/users/MakaraSok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakaraSok/subscriptions","organizations_url":"https://api.github.com/users/MakaraSok/orgs","repos_url":"https://api.github.com/users/MakaraSok/repos","events_url":"https://api.github.com/users/MakaraSok/events{/privacy}","received_events_url":"https://api.github.com/users/MakaraSok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MakaraSok/keyboards","description":"Open Source Keyman keyboards","fork":true,"url":"https://api.github.com/repos/MakaraSok/keyboards","forks_url":"https://api.github.com/repos/MakaraSok/keyboards/forks","keys_url":"https://api.github.com/repos/MakaraSok/keyboards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MakaraSok/keyboards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MakaraSok/keyboards/teams","hooks_url":"https://api.github.com/repos/MakaraSok/keyboards/hooks","issue_events_url":"https://api.github.com/repos/MakaraSok/keyboards/issues/events{/number}","events_url":"https://api.github.com/repos/MakaraSok/keyboards/events","assignees_url":"https://api.github.com/repos/MakaraSok/keyboards/assignees{/user}","branches_url":"https://api.github.com/repos/MakaraSok/keyboards/branches{/branch}","tags_url":"https://api.github.com/repos/MakaraSok/keyboards/tags","blobs_url":"https://api.github.com/repos/MakaraSok/keyboards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MakaraSok/keyboards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MakaraSok/keyboards/git/refs{/sha}","trees_url":"https://api.github.com/repos/MakaraSok/keyboards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MakaraSok/keyboards/statuses/{sha}","languages_url":"https://api.github.com/repos/MakaraSok/keyboards/languages","stargazers_url":"https://api.github.com/repos/MakaraSok/keyboards/stargazers","contributors_url":"https://api.github.com/repos/MakaraSok/keyboards/contributors","subscribers_url":"https://api.github.com/repos/MakaraSok/keyboards/subscribers","subscription_url":"https://api.github.com/repos/MakaraSok/keyboards/subscription","commits_url":"https://api.github.com/repos/MakaraSok/keyboards/commits{/sha}","git_commits_url":"https://api.github.com/repos/MakaraSok/keyboards/git/commits{/sha}","comments_url":"https://api.github.com/repos/MakaraSok/keyboards/comments{/number}","issue_comment_url":"https://api.github.com/repos/MakaraSok/keyboards/issues/comments{/number}","contents_url":"https://api.github.com/repos/MakaraSok/keyboards/contents/{+path}","compare_url":"https://api.github.com/repos/MakaraSok/keyboards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MakaraSok/keyboards/merges","archive_url":"https://api.github.com/repos/MakaraSok/keyboards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MakaraSok/keyboards/downloads","issues_url":"https://api.github.com/repos/MakaraSok/keyboards/issues{/number}","pulls_url":"https://api.github.com/repos/MakaraSok/keyboards/pulls{/number}","milestones_url":"https://api.github.com/repos/MakaraSok/keyboards/milestones{/number}","notifications_url":"https://api.github.com/repos/MakaraSok/keyboards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MakaraSok/keyboards/labels{/name}","releases_url":"https://api.github.com/repos/MakaraSok/keyboards/releases{/id}","deployments_url":"https://api.github.com/repos/MakaraSok/keyboards/deployments","created_at":"2017-07-03T05:01:51Z","updated_at":"2017-07-03T05:01:54Z","pushed_at":"2018-02-22T08:03:00Z","git_url":"git://github.com/MakaraSok/keyboards.git","ssh_url":"git@github.com:MakaraSok/keyboards.git","clone_url":"https://github.com/MakaraSok/keyboards.git","svn_url":"https://github.com/MakaraSok/keyboards","homepage":null,"size":311593,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keymanapp:master","ref":"master","sha":"b40ad5b95e448edeb8378e799d6fb06bbb3d736c","user":{"login":"keymanapp","id":12402926,"avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"repo":{"id":11495975,"name":"keyboards","full_name":"keymanapp/keyboards","owner":{"login":"keymanapp","id":12402926,"avatar_url":"https://avatars1.githubusercontent.com/u/12402926?v=4","gravatar_id":"","url":"https://api.github.com/users/keymanapp","html_url":"https://github.com/keymanapp","followers_url":"https://api.github.com/users/keymanapp/followers","following_url":"https://api.github.com/users/keymanapp/following{/other_user}","gists_url":"https://api.github.com/users/keymanapp/gists{/gist_id}","starred_url":"https://api.github.com/users/keymanapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymanapp/subscriptions","organizations_url":"https://api.github.com/users/keymanapp/orgs","repos_url":"https://api.github.com/users/keymanapp/repos","events_url":"https://api.github.com/users/keymanapp/events{/privacy}","received_events_url":"https://api.github.com/users/keymanapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keymanapp/keyboards","description":"Open Source Keyman keyboards","fork":false,"url":"https://api.github.com/repos/keymanapp/keyboards","forks_url":"https://api.github.com/repos/keymanapp/keyboards/forks","keys_url":"https://api.github.com/repos/keymanapp/keyboards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keymanapp/keyboards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keymanapp/keyboards/teams","hooks_url":"https://api.github.com/repos/keymanapp/keyboards/hooks","issue_events_url":"https://api.github.com/repos/keymanapp/keyboards/issues/events{/number}","events_url":"https://api.github.com/repos/keymanapp/keyboards/events","assignees_url":"https://api.github.com/repos/keymanapp/keyboards/assignees{/user}","branches_url":"https://api.github.com/repos/keymanapp/keyboards/branches{/branch}","tags_url":"https://api.github.com/repos/keymanapp/keyboards/tags","blobs_url":"https://api.github.com/repos/keymanapp/keyboards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keymanapp/keyboards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keymanapp/keyboards/git/refs{/sha}","trees_url":"https://api.github.com/repos/keymanapp/keyboards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keymanapp/keyboards/statuses/{sha}","languages_url":"https://api.github.com/repos/keymanapp/keyboards/languages","stargazers_url":"https://api.github.com/repos/keymanapp/keyboards/stargazers","contributors_url":"https://api.github.com/repos/keymanapp/keyboards/contributors","subscribers_url":"https://api.github.com/repos/keymanapp/keyboards/subscribers","subscription_url":"https://api.github.com/repos/keymanapp/keyboards/subscription","commits_url":"https://api.github.com/repos/keymanapp/keyboards/commits{/sha}","git_commits_url":"https://api.github.com/repos/keymanapp/keyboards/git/commits{/sha}","comments_url":"https://api.github.com/repos/keymanapp/keyboards/comments{/number}","issue_comment_url":"https://api.github.com/repos/keymanapp/keyboards/issues/comments{/number}","contents_url":"https://api.github.com/repos/keymanapp/keyboards/contents/{+path}","compare_url":"https://api.github.com/repos/keymanapp/keyboards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keymanapp/keyboards/merges","archive_url":"https://api.github.com/repos/keymanapp/keyboards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keymanapp/keyboards/downloads","issues_url":"https://api.github.com/repos/keymanapp/keyboards/issues{/number}","pulls_url":"https://api.github.com/repos/keymanapp/keyboards/pulls{/number}","milestones_url":"https://api.github.com/repos/keymanapp/keyboards/milestones{/number}","notifications_url":"https://api.github.com/repos/keymanapp/keyboards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keymanapp/keyboards/labels{/name}","releases_url":"https://api.github.com/repos/keymanapp/keyboards/releases{/id}","deployments_url":"https://api.github.com/repos/keymanapp/keyboards/deployments","created_at":"2013-07-18T06:34:38Z","updated_at":"2018-01-24T20:43:34Z","pushed_at":"2018-02-27T19:49:49Z","git_url":"git://github.com/keymanapp/keyboards.git","ssh_url":"git@github.com:keymanapp/keyboards.git","clone_url":"https://github.com/keymanapp/keyboards.git","svn_url":"https://github.com/keymanapp/keyboards","homepage":null,"size":338262,"stargazers_count":16,"watchers_count":16,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":51,"license":null,"forks":37,"open_issues":51,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/71"},"html":{"href":"https://github.com/keymanapp/keyboards/pull/71"},"issue":{"href":"https://api.github.com/repos/keymanapp/keyboards/issues/71"},"comments":{"href":"https://api.github.com/repos/keymanapp/keyboards/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keymanapp/keyboards/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/keymanapp/keyboards/statuses/dc4c56e59898091068921e89cfe9b25da8e63b4a"}},"author_association":"COLLABORATOR"}} | {
"id": 11495975,
"name": "keymanapp/keyboards",
"url": "https://api.github.com/repos/keymanapp/keyboards"
} | {
"id": 7358010,
"login": "darcywong00",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7358010?",
"url": "https://api.github.com/users/darcywong00"
} | {
"id": 12402926,
"login": "keymanapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12402926?",
"url": "https://api.github.com/orgs/keymanapp"
} | 2018-03-02T02:06:25 | 7319668177 | {"actor":{"display_login":"darcywong00"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/comments/167045163","pull_request_review_id":95205909,"id":167045163,"diff_hunk":"@@ -11,26 +11,77 @@ desc <<-DESC.strip_heredoc.squish\n * rake hosts:sync_with_teamdynamix[hostname1,hostname2,..,hostnameX]\n DESC\n namespace :hosts do\n- task :sync_with_teamdynamix, [:hostnames] => :environment do |_task, args|\n- hostnames = Array.wrap(args.hostnames) + args.extras\n- if hostnames.present?\n- hosts = hostnames.collect { |hostname| Host.find_by(name: hostname) }\n- else\n- hosts = Host.all\n- end\n- error_count = 0\n-\n- hosts.each do |host|\n- td_api = host.td_api\n- asset_id = host.teamdynamix_asset_id\n- action = asset_id && td_api.asset_exist?(asset_id) ? :update : :create\n- begin\n- td_api.send(\"#{action}_asset\", host)\n- rescue StandardError => e\n- puts \"\\n\\tS.No | hostname | action | result\" if error_count.zero?\n- error_count += 1\n- puts \"\\t#{error_count} | #{host.name} | #{action} | Failed(#{e.message})\"\n+ task :sync_with_teamdynamix => :environment do |_task|\n+ @td_api = TeamdynamixApi.instance\n+ @errors = []\n+ @hosts_synced = []\n+\n+ sync_existing_assets_to_hosts\n+\n+ create_assets_for_unmapped_hosts\n+\n+ print_summary\n+ end\n+\n+ # rubocop:disable Metrics/AbcSize, Metrics/MethodLength\n+ def sync_existing_assets_to_hosts\n+ # sending empty search param to get all the assets in TD at once\n+ # Note: due to a limitation(possibly a bug) in TD search asset api\n+ # each and every search payload returns all the assets.\n+ @teamdynamix_assets = @td_api.search_asset({})\n+\n+ @teamdynamix_assets.each do |asset|\n+ asset_id = asset['ID']\n+ # WHEN Asset is already mapped to a host\n+ # THEN update the asset in TD as per current configuration\n+ host = Host.find_by(teamdynamix_asset_id: asset_id)\n+ if host.present?\n+ @hosts_synced << host.id\n+ @td_api.update_asset(host)\n+ next\n end\n+ hosts = Host.where('name IN (?)', [asset['Name'], asset['SerialNumber']])\n+ # WHEN Asset does not have a matching host, THEN Do nothing\n+ next if hosts.blank?\n+ # WHEN Asset has more than one matching host, THEN report error\n+ if hosts.count > 1\n+ @errors << \"#{hosts.count} matching hosts found for asset with ID #{asset['ID']}\"\n+ next\n+ end\n+ # WHEN Asset has a uniquely matching host which is not yet synced\n+ # THEN update the host with the asset ID\n+ # AND update the asset in TD as per current configuration\n+ host = hosts.first\n+ @hosts_synced << host.id\n+ host.teamdynamix_asset_id = asset_id\n+ @errors << \"failed to update host ##{host.id} for asset ID ##{asset_id}\" unless host.save\n+ @td_api.update_asset(host)\n+ end\n+ rescue StandardError => e\n+ @errors << \"component: syncing_assets_to_hosts, asset_id: #{asset['ID']},\n+ asset_name: #{asset['Name']}, Error: #{e.message}\"\n+ end\n+ # rubocop:enable Metrics/AbcSize, Metrics/MethodLength\n+\n+ # sync hosts that do not have assets created in Teamdynamix\n+ def create_assets_for_unmapped_hosts\n+ @hosts = Host.all\n+ unmapped_hosts = @hosts.reject { |host| @hosts_synced.include?(host.id) }\n+ unmapped_hosts.each do |host|\n+ @td_api.create_aset(host)","path":"lib/tasks/sync_hosts_with_teamdynamix.rake","position":71,"original_position":80,"commit_id":"774c37c03ffebd350184cfbc413f0dec82092e1a","original_commit_id":"774c37c03ffebd350184cfbc413f0dec82092e1a","user":{"login":"edestecd","id":107281,"avatar_url":"https://avatars0.githubusercontent.com/u/107281?v=4","gravatar_id":"","url":"https://api.github.com/users/edestecd","html_url":"https://github.com/edestecd","followers_url":"https://api.github.com/users/edestecd/followers","following_url":"https://api.github.com/users/edestecd/following{/other_user}","gists_url":"https://api.github.com/users/edestecd/gists{/gist_id}","starred_url":"https://api.github.com/users/edestecd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edestecd/subscriptions","organizations_url":"https://api.github.com/users/edestecd/orgs","repos_url":"https://api.github.com/users/edestecd/repos","events_url":"https://api.github.com/users/edestecd/events{/privacy}","received_events_url":"https://api.github.com/users/edestecd/received_events","type":"User","site_admin":false},"body":"Like here only with a save: https://github.com/MiamiOH/foreman_teamdynamix/blob/master/app/models/concerns/foreman_teamdynamix/host_extensions.rb#L18","created_at":"2018-02-08T19:37:35Z","updated_at":"2018-02-08T19:37:35Z","html_url":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24#discussion_r167045163","pull_request_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/comments/167045163"},"html":{"href":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24#discussion_r167045163"},"pull_request":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24"}},"in_reply_to_id":167044824},"pull_request":{"url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24","id":167448760,"html_url":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24","diff_url":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24.diff","patch_url":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24.patch","issue_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/24","number":24,"state":"open","locked":false,"title":"Issue8 - rake task to sync existing hosts with Teamdynamix","user":{"login":"nipendar","id":1654723,"avatar_url":"https://avatars0.githubusercontent.com/u/1654723?v=4","gravatar_id":"","url":"https://api.github.com/users/nipendar","html_url":"https://github.com/nipendar","followers_url":"https://api.github.com/users/nipendar/followers","following_url":"https://api.github.com/users/nipendar/following{/other_user}","gists_url":"https://api.github.com/users/nipendar/gists{/gist_id}","starred_url":"https://api.github.com/users/nipendar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipendar/subscriptions","organizations_url":"https://api.github.com/users/nipendar/orgs","repos_url":"https://api.github.com/users/nipendar/repos","events_url":"https://api.github.com/users/nipendar/events{/privacy}","received_events_url":"https://api.github.com/users/nipendar/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T15:39:42Z","updated_at":"2018-02-08T19:37:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83d4673fb8e1aa3658fbd1db7134b5846fe8422d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24/commits","review_comments_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24/comments","review_comment_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/24/comments","statuses_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/statuses/774c37c03ffebd350184cfbc413f0dec82092e1a","head":{"label":"nipendar:issue8","ref":"issue8","sha":"774c37c03ffebd350184cfbc413f0dec82092e1a","user":{"login":"nipendar","id":1654723,"avatar_url":"https://avatars0.githubusercontent.com/u/1654723?v=4","gravatar_id":"","url":"https://api.github.com/users/nipendar","html_url":"https://github.com/nipendar","followers_url":"https://api.github.com/users/nipendar/followers","following_url":"https://api.github.com/users/nipendar/following{/other_user}","gists_url":"https://api.github.com/users/nipendar/gists{/gist_id}","starred_url":"https://api.github.com/users/nipendar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipendar/subscriptions","organizations_url":"https://api.github.com/users/nipendar/orgs","repos_url":"https://api.github.com/users/nipendar/repos","events_url":"https://api.github.com/users/nipendar/events{/privacy}","received_events_url":"https://api.github.com/users/nipendar/received_events","type":"User","site_admin":false},"repo":{"id":114079528,"name":"foreman_teamdynamix","full_name":"nipendar/foreman_teamdynamix","owner":{"login":"nipendar","id":1654723,"avatar_url":"https://avatars0.githubusercontent.com/u/1654723?v=4","gravatar_id":"","url":"https://api.github.com/users/nipendar","html_url":"https://github.com/nipendar","followers_url":"https://api.github.com/users/nipendar/followers","following_url":"https://api.github.com/users/nipendar/following{/other_user}","gists_url":"https://api.github.com/users/nipendar/gists{/gist_id}","starred_url":"https://api.github.com/users/nipendar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipendar/subscriptions","organizations_url":"https://api.github.com/users/nipendar/orgs","repos_url":"https://api.github.com/users/nipendar/repos","events_url":"https://api.github.com/users/nipendar/events{/privacy}","received_events_url":"https://api.github.com/users/nipendar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nipendar/foreman_teamdynamix","description":"A Foreman Plugin for TeamDynamix","fork":true,"url":"https://api.github.com/repos/nipendar/foreman_teamdynamix","forks_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/forks","keys_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/teams","hooks_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/hooks","issue_events_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/issues/events{/number}","events_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/events","assignees_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/assignees{/user}","branches_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/branches{/branch}","tags_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/tags","blobs_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/statuses/{sha}","languages_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/languages","stargazers_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/stargazers","contributors_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/contributors","subscribers_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/subscribers","subscription_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/subscription","commits_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/contents/{+path}","compare_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/merges","archive_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/downloads","issues_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/issues{/number}","pulls_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/pulls{/number}","milestones_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/milestones{/number}","notifications_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/labels{/name}","releases_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/releases{/id}","deployments_url":"https://api.github.com/repos/nipendar/foreman_teamdynamix/deployments","created_at":"2017-12-13T05:48:46Z","updated_at":"2018-01-23T17:54:52Z","pushed_at":"2018-02-08T07:24:49Z","git_url":"git://github.com/nipendar/foreman_teamdynamix.git","ssh_url":"git@github.com:nipendar/foreman_teamdynamix.git","clone_url":"https://github.com/nipendar/foreman_teamdynamix.git","svn_url":"https://github.com/nipendar/foreman_teamdynamix","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MiamiOH:master","ref":"master","sha":"047a42e7e074869dfc4641d42c667116a5b963d0","user":{"login":"MiamiOH","id":12460283,"avatar_url":"https://avatars2.githubusercontent.com/u/12460283?v=4","gravatar_id":"","url":"https://api.github.com/users/MiamiOH","html_url":"https://github.com/MiamiOH","followers_url":"https://api.github.com/users/MiamiOH/followers","following_url":"https://api.github.com/users/MiamiOH/following{/other_user}","gists_url":"https://api.github.com/users/MiamiOH/gists{/gist_id}","starred_url":"https://api.github.com/users/MiamiOH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiamiOH/subscriptions","organizations_url":"https://api.github.com/users/MiamiOH/orgs","repos_url":"https://api.github.com/users/MiamiOH/repos","events_url":"https://api.github.com/users/MiamiOH/events{/privacy}","received_events_url":"https://api.github.com/users/MiamiOH/received_events","type":"Organization","site_admin":false},"repo":{"id":102141414,"name":"foreman_teamdynamix","full_name":"MiamiOH/foreman_teamdynamix","owner":{"login":"MiamiOH","id":12460283,"avatar_url":"https://avatars2.githubusercontent.com/u/12460283?v=4","gravatar_id":"","url":"https://api.github.com/users/MiamiOH","html_url":"https://github.com/MiamiOH","followers_url":"https://api.github.com/users/MiamiOH/followers","following_url":"https://api.github.com/users/MiamiOH/following{/other_user}","gists_url":"https://api.github.com/users/MiamiOH/gists{/gist_id}","starred_url":"https://api.github.com/users/MiamiOH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiamiOH/subscriptions","organizations_url":"https://api.github.com/users/MiamiOH/orgs","repos_url":"https://api.github.com/users/MiamiOH/repos","events_url":"https://api.github.com/users/MiamiOH/events{/privacy}","received_events_url":"https://api.github.com/users/MiamiOH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MiamiOH/foreman_teamdynamix","description":"A Foreman Plugin for TeamDynamix","fork":false,"url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix","forks_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/forks","keys_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/teams","hooks_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/hooks","issue_events_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/events{/number}","events_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/events","assignees_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/assignees{/user}","branches_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/branches{/branch}","tags_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/tags","blobs_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/statuses/{sha}","languages_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/languages","stargazers_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/stargazers","contributors_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/contributors","subscribers_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/subscribers","subscription_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/subscription","commits_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/comments{/number}","contents_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/contents/{+path}","compare_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/merges","archive_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/downloads","issues_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues{/number}","pulls_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls{/number}","milestones_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/milestones{/number}","notifications_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/labels{/name}","releases_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/releases{/id}","deployments_url":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/deployments","created_at":"2017-09-01T18:23:28Z","updated_at":"2018-01-05T14:53:50Z","pushed_at":"2018-02-08T07:24:50Z","git_url":"git://github.com/MiamiOH/foreman_teamdynamix.git","ssh_url":"git@github.com:MiamiOH/foreman_teamdynamix.git","clone_url":"https://github.com/MiamiOH/foreman_teamdynamix.git","svn_url":"https://github.com/MiamiOH/foreman_teamdynamix","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24"},"html":{"href":"https://github.com/MiamiOH/foreman_teamdynamix/pull/24"},"issue":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/24"},"comments":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/MiamiOH/foreman_teamdynamix/statuses/774c37c03ffebd350184cfbc413f0dec82092e1a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 102141414,
"name": "MiamiOH/foreman_teamdynamix",
"url": "https://api.github.com/repos/MiamiOH/foreman_teamdynamix"
} | {
"id": 107281,
"login": "edestecd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107281?",
"url": "https://api.github.com/users/edestecd"
} | {
"id": 12460283,
"login": "MiamiOH",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12460283?",
"url": "https://api.github.com/orgs/MiamiOH"
} | 2018-02-08T19:37:35 | 7218933644 | {"actor":{"display_login":"edestecd"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments/183121121","pull_request_review_id":114065216,"id":183121121,"diff_hunk":"@@ -13,6 +13,12 @@ Meteor.startup(function() {\n \t\t}\n \t}\n \n+\tvar mongoOptionStr = process.env.MONGO_OPTIONS;\n+\tif (typeof(mongoOptionStr) !== 'undefined') {","path":"server/startup/serverRunning.js","position":5,"original_position":5,"commit_id":"92e1f7e49dca492edf6cdc82828b9d51674e6dab","original_commit_id":"92e1f7e49dca492edf6cdc82828b9d51674e6dab","user":{"login":"graywolf336","id":850391,"avatar_url":"https://avatars1.githubusercontent.com/u/850391?v=4","gravatar_id":"","url":"https://api.github.com/users/graywolf336","html_url":"https://github.com/graywolf336","followers_url":"https://api.github.com/users/graywolf336/followers","following_url":"https://api.github.com/users/graywolf336/following{/other_user}","gists_url":"https://api.github.com/users/graywolf336/gists{/gist_id}","starred_url":"https://api.github.com/users/graywolf336/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graywolf336/subscriptions","organizations_url":"https://api.github.com/users/graywolf336/orgs","repos_url":"https://api.github.com/users/graywolf336/repos","events_url":"https://api.github.com/users/graywolf336/events{/privacy}","received_events_url":"https://api.github.com/users/graywolf336/received_events","type":"User","site_admin":false},"body":"Let's go with `typeof mongoOptionStr` to stay consistent with the rest of our codebase.","created_at":"2018-04-20T17:37:36Z","updated_at":"2018-04-20T17:37:50Z","html_url":"https://github.com/RocketChat/Rocket.Chat/pull/10529#discussion_r183121121","pull_request_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments/183121121"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/10529#discussion_r183121121"},"pull_request":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529"}}},"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529","id":183121749,"html_url":"https://github.com/RocketChat/Rocket.Chat/pull/10529","diff_url":"https://github.com/RocketChat/Rocket.Chat/pull/10529.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat/pull/10529.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/10529","number":10529,"state":"open","locked":false,"title":"Support passing extra connection options to the Mongo driver","user":{"login":"saplla","id":38278745,"avatar_url":"https://avatars0.githubusercontent.com/u/38278745?v=4","gravatar_id":"","url":"https://api.github.com/users/saplla","html_url":"https://github.com/saplla","followers_url":"https://api.github.com/users/saplla/followers","following_url":"https://api.github.com/users/saplla/following{/other_user}","gists_url":"https://api.github.com/users/saplla/gists{/gist_id}","starred_url":"https://api.github.com/users/saplla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saplla/subscriptions","organizations_url":"https://api.github.com/users/saplla/orgs","repos_url":"https://api.github.com/users/saplla/repos","events_url":"https://api.github.com/users/saplla/events{/privacy}","received_events_url":"https://api.github.com/users/saplla/received_events","type":"User","site_admin":false},"body":"Fixes #10526","created_at":"2018-04-20T17:14:37Z","updated_at":"2018-04-20T17:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4472a43eaa0515aba5fdfa6c2a44af46136c818","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/10529/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/92e1f7e49dca492edf6cdc82828b9d51674e6dab","head":{"label":"saplla:mongo-connection-options","ref":"mongo-connection-options","sha":"92e1f7e49dca492edf6cdc82828b9d51674e6dab","user":{"login":"saplla","id":38278745,"avatar_url":"https://avatars0.githubusercontent.com/u/38278745?v=4","gravatar_id":"","url":"https://api.github.com/users/saplla","html_url":"https://github.com/saplla","followers_url":"https://api.github.com/users/saplla/followers","following_url":"https://api.github.com/users/saplla/following{/other_user}","gists_url":"https://api.github.com/users/saplla/gists{/gist_id}","starred_url":"https://api.github.com/users/saplla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saplla/subscriptions","organizations_url":"https://api.github.com/users/saplla/orgs","repos_url":"https://api.github.com/users/saplla/repos","events_url":"https://api.github.com/users/saplla/events{/privacy}","received_events_url":"https://api.github.com/users/saplla/received_events","type":"User","site_admin":false},"repo":{"id":130350709,"name":"Rocket.Chat","full_name":"saplla/Rocket.Chat","owner":{"login":"saplla","id":38278745,"avatar_url":"https://avatars0.githubusercontent.com/u/38278745?v=4","gravatar_id":"","url":"https://api.github.com/users/saplla","html_url":"https://github.com/saplla","followers_url":"https://api.github.com/users/saplla/followers","following_url":"https://api.github.com/users/saplla/following{/other_user}","gists_url":"https://api.github.com/users/saplla/gists{/gist_id}","starred_url":"https://api.github.com/users/saplla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saplla/subscriptions","organizations_url":"https://api.github.com/users/saplla/orgs","repos_url":"https://api.github.com/users/saplla/repos","events_url":"https://api.github.com/users/saplla/events{/privacy}","received_events_url":"https://api.github.com/users/saplla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saplla/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":true,"url":"https://api.github.com/repos/saplla/Rocket.Chat","forks_url":"https://api.github.com/repos/saplla/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/saplla/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saplla/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saplla/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/saplla/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/saplla/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/saplla/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/saplla/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/saplla/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/saplla/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/saplla/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saplla/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saplla/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/saplla/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saplla/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/saplla/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/saplla/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/saplla/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/saplla/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/saplla/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/saplla/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/saplla/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/saplla/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/saplla/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/saplla/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/saplla/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saplla/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/saplla/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saplla/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/saplla/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/saplla/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/saplla/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/saplla/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saplla/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/saplla/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/saplla/Rocket.Chat/deployments","created_at":"2018-04-20T11:01:52Z","updated_at":"2018-04-20T11:01:59Z","pushed_at":"2018-04-20T17:15:34Z","git_url":"git://github.com/saplla/Rocket.Chat.git","ssh_url":"git@github.com:saplla/Rocket.Chat.git","clone_url":"https://github.com/saplla/Rocket.Chat.git","svn_url":"https://github.com/saplla/Rocket.Chat","homepage":"https://rocket.chat/","size":66117,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"2d123a8be7ac8d4732214b13c8044fb70d382aac","user":{"login":"RocketChat","id":12508788,"avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","owner":{"login":"RocketChat","id":12508788,"avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2018-04-20T16:17:51Z","pushed_at":"2018-04-20T17:15:36Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":66150,"stargazers_count":17479,"watchers_count":17479,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3743,"mirror_url":null,"archived":false,"open_issues_count":1983,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3743,"open_issues":1983,"watchers":17479,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/10529"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/10529"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/10529/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/10529/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/92e1f7e49dca492edf6cdc82828b9d51674e6dab"}},"author_association":"NONE"}} | {
"id": 35866694,
"name": "RocketChat/Rocket.Chat",
"url": "https://api.github.com/repos/RocketChat/Rocket.Chat"
} | {
"id": 850391,
"login": "graywolf336",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/850391?",
"url": "https://api.github.com/users/graywolf336"
} | {
"id": 12508788,
"login": "RocketChat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12508788?",
"url": "https://api.github.com/orgs/RocketChat"
} | 2018-04-20T17:37:36 | 7563174767 | {"actor":{"display_login":"graywolf336"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/178448913","pull_request_review_id":108509610,"id":178448913,"diff_hunk":"@@ -529,20 +529,20 @@ def __init__(self, sentences=None, size=100, alpha=0.025, window=5, min_count=5,\n super(Word2Vec, self).__init__(\n sentences=sentences, workers=workers, vector_size=size, epochs=iter, callbacks=callbacks,\n batch_words=batch_words, trim_rule=trim_rule, sg=sg, alpha=alpha, window=window, seed=seed,\n- hs=hs, negative=negative, cbow_mean=cbow_mean, min_alpha=min_alpha, compute_loss=compute_loss,\n+ hs=hs, negative=negative, num_bits=num_bits, cbow_mean=cbow_mean, min_alpha=min_alpha, compute_loss=compute_loss,\n fast_version=FAST_VERSION)\n \n def _do_train_job(self, sentences, alpha, inits):\n \"\"\"\n Train a single batch of sentences. Return 2-tuple `(effective word count after\n ignoring unknown words and sentence length trimming, total word count)`.\n \"\"\"\n- work, neu1 = inits\n+ work1, work2, neu1 = inits\n tally = 0\n if self.sg:\n- tally += train_batch_sg(self, sentences, alpha, work, self.compute_loss)\n+ tally += train_batch_sg(self, sentences, alpha, work1, self.compute_loss)\n else:\n- tally += train_batch_cbow(self, sentences, alpha, work, neu1, self.compute_loss)\n+ tally += train_batch_cbow(self, sentences, alpha, work1, work2, neu1, self.compute_loss, self.num_bits)","path":"gensim/models/word2vec.py","position":30,"original_position":30,"commit_id":"c0370962acff5c9d74f73d93b538c3ca2520e8fa","original_commit_id":"c0370962acff5c9d74f73d93b538c3ca2520e8fa","user":{"login":"menshikh-iv","id":15094669,"avatar_url":"https://avatars2.githubusercontent.com/u/15094669?v=4","gravatar_id":"","url":"https://api.github.com/users/menshikh-iv","html_url":"https://github.com/menshikh-iv","followers_url":"https://api.github.com/users/menshikh-iv/followers","following_url":"https://api.github.com/users/menshikh-iv/following{/other_user}","gists_url":"https://api.github.com/users/menshikh-iv/gists{/gist_id}","starred_url":"https://api.github.com/users/menshikh-iv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menshikh-iv/subscriptions","organizations_url":"https://api.github.com/users/menshikh-iv/orgs","repos_url":"https://api.github.com/users/menshikh-iv/repos","events_url":"https://api.github.com/users/menshikh-iv/events{/privacy}","received_events_url":"https://api.github.com/users/menshikh-iv/received_events","type":"User","site_admin":false},"body":"I think it's better to extract `num_bits` directly in cython from `self` (for save more consistent interfaces), like `cdef int negative = model.negative`","created_at":"2018-04-01T05:51:10Z","updated_at":"2018-04-01T05:54:42Z","html_url":"https://github.com/RaRe-Technologies/gensim/pull/2011#discussion_r178448913","pull_request_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/178448913"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/2011#discussion_r178448913"},"pull_request":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011"}}},"pull_request":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011","id":178690405,"html_url":"https://github.com/RaRe-Technologies/gensim/pull/2011","diff_url":"https://github.com/RaRe-Technologies/gensim/pull/2011.diff","patch_url":"https://github.com/RaRe-Technologies/gensim/pull/2011.patch","issue_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/2011","number":2011,"state":"open","locked":false,"title":"[WIP #1991]: Word2Bits benchmarks","user":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"body":"Pull request with intermediate results on [this issue](https://github.com/RaRe-Technologies/gensim/issues/1991).\r\n\r\nI've implemented quantization techniques as stated in [the paper](https://arxiv.org/pdf/1803.05651.pdf).\r\n\r\nI've just benchmarked it on `text8` corpus with 10 iterations over the dataset.\r\n\r\nOther params (almost as in paper except embedding size):\r\n* size = 128\r\n* 10 iterations\r\n* Window = 10\r\n* Negative = 12\r\n* Min count = 5\r\n* Subsampling = 1e-4\r\n* Learning rate = 0.05 (linearly decayed to 0.0001)\r\n\r\n\r\n\r\nBased on my initial benchmark results are not promising:\r\n\r\n| Training method | Quantization after training | Semantic accuracy | Syntactic accuracy |\r\n|----------------------------------|-----------------------------|-------------------|--------------------|\r\n| Original w2v (num_bits=0) | No quantization | 49.96% | 46.99% |\r\n| | 1 bit | 13.06% | 15.16% |\r\n| | 2 bits | 13.31% | 15.04% |\r\n| 1 bit quantization (num_bits=1) | No quantization | 29.51% | 29.85% |\r\n| | 1 bit | 19.18% | 13.28% |\r\n| 2 bits quantization (num_bits=2) | No quantization | 44.38% | 36.46% |\r\n| | 2 bits | 18.79% | 21.52% |\r\n\r\n\r\n\r\n* Quantized vectors work better if training phrase was done with quantization techniques.\r\n* But there is a large accuracy drop when training is done with quantization. I suppose that embedding size (128) is too small to encode all information when quantization is applied.\r\n\r\n\r\nSo, currently I'm training the same models but for **25 iterations** and with **size=400**. I'll post the results asap.\r\n\r\nAfter that, I will train the same setup on EN wikipedia (as was done in the paper).\r\n\r\n\r\n@menshikh-iv please, take a look at my code. Maybe there are some bugs and this leads to low accuracy.","created_at":"2018-03-31T16:46:55Z","updated_at":"2018-04-01T05:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"439eba71deee82efd8e94683ca2656d35bc82fee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011/commits","review_comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011/comments","review_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/2011/comments","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/c0370962acff5c9d74f73d93b538c3ca2520e8fa","head":{"label":"persiyanov:feature/word2bits","ref":"feature/word2bits","sha":"c0370962acff5c9d74f73d93b538c3ca2520e8fa","user":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"repo":{"id":123994588,"name":"gensim","full_name":"persiyanov/gensim","owner":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/persiyanov/gensim","description":"Topic Modelling for Humans","fork":true,"url":"https://api.github.com/repos/persiyanov/gensim","forks_url":"https://api.github.com/repos/persiyanov/gensim/forks","keys_url":"https://api.github.com/repos/persiyanov/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/persiyanov/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/persiyanov/gensim/teams","hooks_url":"https://api.github.com/repos/persiyanov/gensim/hooks","issue_events_url":"https://api.github.com/repos/persiyanov/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/persiyanov/gensim/events","assignees_url":"https://api.github.com/repos/persiyanov/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/persiyanov/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/persiyanov/gensim/tags","blobs_url":"https://api.github.com/repos/persiyanov/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/persiyanov/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/persiyanov/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/persiyanov/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/persiyanov/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/persiyanov/gensim/languages","stargazers_url":"https://api.github.com/repos/persiyanov/gensim/stargazers","contributors_url":"https://api.github.com/repos/persiyanov/gensim/contributors","subscribers_url":"https://api.github.com/repos/persiyanov/gensim/subscribers","subscription_url":"https://api.github.com/repos/persiyanov/gensim/subscription","commits_url":"https://api.github.com/repos/persiyanov/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/persiyanov/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/persiyanov/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/persiyanov/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/persiyanov/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/persiyanov/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/persiyanov/gensim/merges","archive_url":"https://api.github.com/repos/persiyanov/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/persiyanov/gensim/downloads","issues_url":"https://api.github.com/repos/persiyanov/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/persiyanov/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/persiyanov/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/persiyanov/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/persiyanov/gensim/labels{/name}","releases_url":"https://api.github.com/repos/persiyanov/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/persiyanov/gensim/deployments","created_at":"2018-03-05T23:59:24Z","updated_at":"2018-03-24T14:45:05Z","pushed_at":"2018-03-31T16:44:37Z","git_url":"git://github.com/persiyanov/gensim.git","ssh_url":"git@github.com:persiyanov/gensim.git","clone_url":"https://github.com/persiyanov/gensim.git","svn_url":"https://github.com/persiyanov/gensim","homepage":"","size":62112,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RaRe-Technologies:develop","ref":"develop","sha":"10a3dab8d00c0523ff871af75fb0badcff14848b","user":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":1349775,"name":"gensim","full_name":"RaRe-Technologies/gensim","owner":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RaRe-Technologies/gensim","description":"Topic Modelling for Humans","fork":false,"url":"https://api.github.com/repos/RaRe-Technologies/gensim","forks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/forks","keys_url":"https://api.github.com/repos/RaRe-Technologies/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaRe-Technologies/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaRe-Technologies/gensim/teams","hooks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/hooks","issue_events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/events","assignees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/RaRe-Technologies/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/tags","blobs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/RaRe-Technologies/gensim/languages","stargazers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/stargazers","contributors_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contributors","subscribers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscribers","subscription_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscription","commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/RaRe-Technologies/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaRe-Technologies/gensim/merges","archive_url":"https://api.github.com/repos/RaRe-Technologies/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaRe-Technologies/gensim/downloads","issues_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/RaRe-Technologies/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/RaRe-Technologies/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaRe-Technologies/gensim/labels{/name}","releases_url":"https://api.github.com/repos/RaRe-Technologies/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/deployments","created_at":"2011-02-10T07:43:04Z","updated_at":"2018-04-01T02:49:07Z","pushed_at":"2018-03-31T16:46:55Z","git_url":"git://github.com/RaRe-Technologies/gensim.git","ssh_url":"git@github.com:RaRe-Technologies/gensim.git","clone_url":"https://github.com/RaRe-Technologies/gensim.git","svn_url":"https://github.com/RaRe-Technologies/gensim","homepage":"","size":62196,"stargazers_count":6645,"watchers_count":6645,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2574,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":2574,"open_issues":173,"watchers":6645,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/2011"},"issue":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/2011"},"comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/2011/comments"},"review_comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011/comments"},"review_comment":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/2011/commits"},"statuses":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/c0370962acff5c9d74f73d93b538c3ca2520e8fa"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1349775,
"name": "RaRe-Technologies/gensim",
"url": "https://api.github.com/repos/RaRe-Technologies/gensim"
} | {
"id": 15094669,
"login": "menshikh-iv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15094669?",
"url": "https://api.github.com/users/menshikh-iv"
} | {
"id": 12515886,
"login": "RaRe-Technologies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12515886?",
"url": "https://api.github.com/orgs/RaRe-Technologies"
} | 2018-04-01T05:51:10 | 7463473959 | {"actor":{"display_login":"menshikh-iv"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/175184429","pull_request_review_id":104681202,"id":175184429,"diff_hunk":"@@ -154,6 +154,84 @@ def get_vector(self, entity):\n else:\n raise KeyError(\"'%s' not in vocabulary\" % entity)\n \n+ def add_entity(self, entity, weights, replace=False):\n+ \"\"\"Add entity vector in a manual way.\n+ If `entity` is already in the vocabulary, old vector is keeped unless `replace` flag is True.\n+\n+ Parameters\n+ ----------\n+ entity : str\n+ Entity specified by string tag.\n+ weights : np.array\n+ 1D numpy array with shape (`vector_size`,)\n+ replace: bool, optional\n+ Boolean flag indicating whether to replace old vector if entity is already in the vocabulary.\n+ Default, False, means that old vector is keeped.\n+ \"\"\"\n+ self.add_entities([entity], weights.reshape(1, -1), replace=replace)\n+\n+ def add_entities(self, entities, weights, replace=False):\n+ \"\"\"Add entities and theirs vectors in a manual way.\n+ If some entity is already in the vocabulary, old vector is keeped unless `replace` flag is True.\n+\n+ Parameters\n+ ----------\n+ entities : list of str\n+ Entities specified by string tags.\n+ weights: {list of numpy.ndarray, numpy.ndarray}\n+ List of 1D np.array vectors or 2D np.array of vectors.\n+ replace: bool, optional\n+ Flag indicating whether to replace vectors for entities which are already in the vocabulary,\n+ if True - replace vectors, otherwise - keep old vectors.\n+ \"\"\"\n+ if isinstance(weights, list):\n+ weights = np.array(weights)\n+\n+ in_vocab_mask = np.zeros(len(entities), dtype=np.bool)\n+ in_vocab_idxs = []\n+ out_vocab_entities = []\n+\n+ for idx, entity in zip(range(len(entities)), entities):\n+ if entity in self.vocab:\n+ in_vocab_mask[idx] = True\n+ in_vocab_idxs.append(self.vocab[entity].index)\n+ else:\n+ out_vocab_entities.append(entity)\n+\n+ # add new entities to the vocab\n+ for entity in out_vocab_entities:\n+ entity_id = len(self.vocab)\n+ self.vocab[entity] = Vocab(index=entity_id, count=1)\n+ self.index2entity.append(entity)\n+\n+ # add vectors for new entities\n+ if len(self.vectors) == 0:\n+ self.vectors = weights[~in_vocab_mask]\n+ else:\n+ self.vectors = vstack((self.vectors, weights[~in_vocab_mask]))","path":"gensim/models/keyedvectors.py","position":40,"original_position":58,"commit_id":"737cd369e02f7ad197f666ba1f58748f5e08708d","original_commit_id":"3611320822900d287adff7a1e92dfab6b1125fba","user":{"login":"gojomo","id":1641,"avatar_url":"https://avatars3.githubusercontent.com/u/1641?v=4","gravatar_id":"","url":"https://api.github.com/users/gojomo","html_url":"https://github.com/gojomo","followers_url":"https://api.github.com/users/gojomo/followers","following_url":"https://api.github.com/users/gojomo/following{/other_user}","gists_url":"https://api.github.com/users/gojomo/gists{/gist_id}","starred_url":"https://api.github.com/users/gojomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gojomo/subscriptions","organizations_url":"https://api.github.com/users/gojomo/orgs","repos_url":"https://api.github.com/users/gojomo/repos","events_url":"https://api.github.com/users/gojomo/events{/privacy}","received_events_url":"https://api.github.com/users/gojomo/received_events","type":"User","site_admin":false},"body":"Is it possible for an empty `KeyedVectors` to have a `self.vectors` that is already a proper-dimensioned `(0, vector_size)` empty ndarray? (Not sure myself, but would simplify things in later places like this.)","created_at":"2018-03-16T18:52:16Z","updated_at":"2018-03-16T18:52:16Z","html_url":"https://github.com/RaRe-Technologies/gensim/pull/1957#discussion_r175184429","pull_request_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments/175184429"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/1957#discussion_r175184429"},"pull_request":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957"}},"in_reply_to_id":174576420},"pull_request":{"url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957","id":173171001,"html_url":"https://github.com/RaRe-Technologies/gensim/pull/1957","diff_url":"https://github.com/RaRe-Technologies/gensim/pull/1957.diff","patch_url":"https://github.com/RaRe-Technologies/gensim/pull/1957.patch","issue_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1957","number":1957,"state":"open","locked":false,"title":"Add `gensim.models.BaseKeyedVectors.add_entity` method for fill `KeyedVectors` in manual way. Fix #1942","user":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"body":"Pull request related to [this](https://github.com/RaRe-Technologies/gensim/issues/1942) issue.\r\n\r\nWith these changes, it would be possible to add new word vectors into a `KeyedVectors` object.\r\n\r\n@menshikh-iv please, take a look. I will write tests on it after addressing your comments.\r\n\r\nMoreover, I have some questions/doubts:\r\n\r\n1. **Method name**: is it okay right now or maybe it should be named like `add_entity/add_word`?\r\n2. **Weights parameter**: should we check the type and shape of `weights` and raise an exception in a bad case?\r\n3. **`self.vectors` contiguity**: [here](https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/utils_any2vec.py#L231) `vectors` list is casted to C-contiguous array. Does numpy preserve C-contiguity after operations such as `np.vstack`? If so, I think I should add `numpy.ascontiguousarray` cast in my code.","created_at":"2018-03-06T14:19:31Z","updated_at":"2018-03-16T18:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1456c2de717ea48ed58eea8fe47e3a3bb14f98ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957/commits","review_comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957/comments","review_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1957/comments","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/737cd369e02f7ad197f666ba1f58748f5e08708d","head":{"label":"persiyanov:feature/add-word-method-to-keyed-vectors","ref":"feature/add-word-method-to-keyed-vectors","sha":"737cd369e02f7ad197f666ba1f58748f5e08708d","user":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"repo":{"id":123994588,"name":"gensim","full_name":"persiyanov/gensim","owner":{"login":"persiyanov","id":3997997,"avatar_url":"https://avatars1.githubusercontent.com/u/3997997?v=4","gravatar_id":"","url":"https://api.github.com/users/persiyanov","html_url":"https://github.com/persiyanov","followers_url":"https://api.github.com/users/persiyanov/followers","following_url":"https://api.github.com/users/persiyanov/following{/other_user}","gists_url":"https://api.github.com/users/persiyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/persiyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persiyanov/subscriptions","organizations_url":"https://api.github.com/users/persiyanov/orgs","repos_url":"https://api.github.com/users/persiyanov/repos","events_url":"https://api.github.com/users/persiyanov/events{/privacy}","received_events_url":"https://api.github.com/users/persiyanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/persiyanov/gensim","description":"Topic Modelling for Humans","fork":true,"url":"https://api.github.com/repos/persiyanov/gensim","forks_url":"https://api.github.com/repos/persiyanov/gensim/forks","keys_url":"https://api.github.com/repos/persiyanov/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/persiyanov/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/persiyanov/gensim/teams","hooks_url":"https://api.github.com/repos/persiyanov/gensim/hooks","issue_events_url":"https://api.github.com/repos/persiyanov/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/persiyanov/gensim/events","assignees_url":"https://api.github.com/repos/persiyanov/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/persiyanov/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/persiyanov/gensim/tags","blobs_url":"https://api.github.com/repos/persiyanov/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/persiyanov/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/persiyanov/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/persiyanov/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/persiyanov/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/persiyanov/gensim/languages","stargazers_url":"https://api.github.com/repos/persiyanov/gensim/stargazers","contributors_url":"https://api.github.com/repos/persiyanov/gensim/contributors","subscribers_url":"https://api.github.com/repos/persiyanov/gensim/subscribers","subscription_url":"https://api.github.com/repos/persiyanov/gensim/subscription","commits_url":"https://api.github.com/repos/persiyanov/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/persiyanov/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/persiyanov/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/persiyanov/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/persiyanov/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/persiyanov/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/persiyanov/gensim/merges","archive_url":"https://api.github.com/repos/persiyanov/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/persiyanov/gensim/downloads","issues_url":"https://api.github.com/repos/persiyanov/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/persiyanov/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/persiyanov/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/persiyanov/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/persiyanov/gensim/labels{/name}","releases_url":"https://api.github.com/repos/persiyanov/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/persiyanov/gensim/deployments","created_at":"2018-03-05T23:59:24Z","updated_at":"2018-03-05T23:59:28Z","pushed_at":"2018-03-16T14:21:57Z","git_url":"git://github.com/persiyanov/gensim.git","ssh_url":"git@github.com:persiyanov/gensim.git","clone_url":"https://github.com/persiyanov/gensim.git","svn_url":"https://github.com/persiyanov/gensim","homepage":"","size":61865,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RaRe-Technologies:develop","ref":"develop","sha":"dc97c5116ac01702c902405a7cd7e2ca8496ed5e","user":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":1349775,"name":"gensim","full_name":"RaRe-Technologies/gensim","owner":{"login":"RaRe-Technologies","id":12515886,"avatar_url":"https://avatars3.githubusercontent.com/u/12515886?v=4","gravatar_id":"","url":"https://api.github.com/users/RaRe-Technologies","html_url":"https://github.com/RaRe-Technologies","followers_url":"https://api.github.com/users/RaRe-Technologies/followers","following_url":"https://api.github.com/users/RaRe-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/RaRe-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/RaRe-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaRe-Technologies/subscriptions","organizations_url":"https://api.github.com/users/RaRe-Technologies/orgs","repos_url":"https://api.github.com/users/RaRe-Technologies/repos","events_url":"https://api.github.com/users/RaRe-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/RaRe-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RaRe-Technologies/gensim","description":"Topic Modelling for Humans","fork":false,"url":"https://api.github.com/repos/RaRe-Technologies/gensim","forks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/forks","keys_url":"https://api.github.com/repos/RaRe-Technologies/gensim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaRe-Technologies/gensim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaRe-Technologies/gensim/teams","hooks_url":"https://api.github.com/repos/RaRe-Technologies/gensim/hooks","issue_events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/events{/number}","events_url":"https://api.github.com/repos/RaRe-Technologies/gensim/events","assignees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/assignees{/user}","branches_url":"https://api.github.com/repos/RaRe-Technologies/gensim/branches{/branch}","tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/tags","blobs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/{sha}","languages_url":"https://api.github.com/repos/RaRe-Technologies/gensim/languages","stargazers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/stargazers","contributors_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contributors","subscribers_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscribers","subscription_url":"https://api.github.com/repos/RaRe-Technologies/gensim/subscription","commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaRe-Technologies/gensim/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaRe-Technologies/gensim/contents/{+path}","compare_url":"https://api.github.com/repos/RaRe-Technologies/gensim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaRe-Technologies/gensim/merges","archive_url":"https://api.github.com/repos/RaRe-Technologies/gensim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaRe-Technologies/gensim/downloads","issues_url":"https://api.github.com/repos/RaRe-Technologies/gensim/issues{/number}","pulls_url":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls{/number}","milestones_url":"https://api.github.com/repos/RaRe-Technologies/gensim/milestones{/number}","notifications_url":"https://api.github.com/repos/RaRe-Technologies/gensim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaRe-Technologies/gensim/labels{/name}","releases_url":"https://api.github.com/repos/RaRe-Technologies/gensim/releases{/id}","deployments_url":"https://api.github.com/repos/RaRe-Technologies/gensim/deployments","created_at":"2011-02-10T07:43:04Z","updated_at":"2018-03-16T17:30:51Z","pushed_at":"2018-03-16T14:22:02Z","git_url":"git://github.com/RaRe-Technologies/gensim.git","ssh_url":"git@github.com:RaRe-Technologies/gensim.git","clone_url":"https://github.com/RaRe-Technologies/gensim.git","svn_url":"https://github.com/RaRe-Technologies/gensim","homepage":"","size":62008,"stargazers_count":6509,"watchers_count":6509,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2539,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":2539,"open_issues":166,"watchers":6509,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957"},"html":{"href":"https://github.com/RaRe-Technologies/gensim/pull/1957"},"issue":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1957"},"comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/issues/1957/comments"},"review_comments":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957/comments"},"review_comment":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/pulls/1957/commits"},"statuses":{"href":"https://api.github.com/repos/RaRe-Technologies/gensim/statuses/737cd369e02f7ad197f666ba1f58748f5e08708d"}},"author_association":"NONE"}} | {
"id": 1349775,
"name": "RaRe-Technologies/gensim",
"url": "https://api.github.com/repos/RaRe-Technologies/gensim"
} | {
"id": 1641,
"login": "gojomo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1641?",
"url": "https://api.github.com/users/gojomo"
} | {
"id": 12515886,
"login": "RaRe-Technologies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12515886?",
"url": "https://api.github.com/orgs/RaRe-Technologies"
} | 2018-03-16T18:52:16 | 7392495186 | {"actor":{"display_login":"gojomo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/angr/archinfo/pulls/comments/199708777","pull_request_review_id":133878320,"id":199708777,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTcwODc3Nw==","diff_hunk":"@@ -40,13 +45,56 @@ def from_string(cls, tstr):\n def fullname(self):\n return \"%s.%s\" % (self.class_name, self.name)\n \n+ def matches_with_native_name(self, native_method):\n+ \"\"\"\n+ Name of native methods are getting encoded, s.t. they translate into valid C function names.\n+ :return: True, if name of soot method matches the mangled native name.\n+ \"\"\"\n+ \n+ if \"__\" in native_method:\n+ # if native methods are overloaded, two underscores are used\n+ # TODO check function signature\n+ raise NotImplementedError('Overloaded native methods are not supported.')\n+\n+ # demangle native name\n+ native_method = native_method.replace('_1', '_')\n+ # TODO unicode escaping\n+\n+ method_native_name = \"Java_{class_name}_{method_name}\".format(\n+ class_name=self.class_name,\n+ method_name=self.name)\n+ return native_method == method_native_name\n+\n @classmethod\n- def from_method(cls, method):\n- return cls(method.class_name, method.name, method.params)\n+ def from_soot_method(cls, soot_method):\n+ return cls(class_name=soot_method.class_name, \n+ name=soot_method.name, \n+ params=soot_method.params, \n+ soot_method=soot_method)","path":"archinfo/arch_soot.py","position":50,"original_position":50,"commit_id":"fa881a26257f75c3abe2d193d61e4ce69e089b20","original_commit_id":"fa881a26257f75c3abe2d193d61e4ce69e089b20","user":{"login":"ltfish","id":5071575,"node_id":"MDQ6VXNlcjUwNzE1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5071575?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfish","html_url":"https://github.com/ltfish","followers_url":"https://api.github.com/users/ltfish/followers","following_url":"https://api.github.com/users/ltfish/following{/other_user}","gists_url":"https://api.github.com/users/ltfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfish/subscriptions","organizations_url":"https://api.github.com/users/ltfish/orgs","repos_url":"https://api.github.com/users/ltfish/repos","events_url":"https://api.github.com/users/ltfish/events{/privacy}","received_events_url":"https://api.github.com/users/ltfish/received_events","type":"User","site_admin":false},"body":"_welp_\r\n\r\nFine. I don't really care. Nitpicks anyway.","created_at":"2018-07-03T07:33:56Z","updated_at":"2018-07-03T07:33:56Z","html_url":"https://github.com/angr/archinfo/pull/41#discussion_r199708777","pull_request_url":"https://api.github.com/repos/angr/archinfo/pulls/41","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angr/archinfo/pulls/comments/199708777"},"html":{"href":"https://github.com/angr/archinfo/pull/41#discussion_r199708777"},"pull_request":{"href":"https://api.github.com/repos/angr/archinfo/pulls/41"}},"in_reply_to_id":199704810},"pull_request":{"url":"https://api.github.com/repos/angr/archinfo/pulls/41","id":198869160,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODY5MTYw","html_url":"https://github.com/angr/archinfo/pull/41","diff_url":"https://github.com/angr/archinfo/pull/41.diff","patch_url":"https://github.com/angr/archinfo/pull/41.patch","issue_url":"https://api.github.com/repos/angr/archinfo/issues/41","number":41,"state":"open","locked":false,"title":"[WIP] Improved Java support.","user":{"login":"ltfish","id":5071575,"node_id":"MDQ6VXNlcjUwNzE1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5071575?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfish","html_url":"https://github.com/ltfish","followers_url":"https://api.github.com/users/ltfish/followers","following_url":"https://api.github.com/users/ltfish/following{/other_user}","gists_url":"https://api.github.com/users/ltfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfish/subscriptions","organizations_url":"https://api.github.com/users/ltfish/orgs","repos_url":"https://api.github.com/users/ltfish/repos","events_url":"https://api.github.com/users/ltfish/events{/privacy}","received_events_url":"https://api.github.com/users/ltfish/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-03T07:12:45Z","updated_at":"2018-07-03T07:33:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5b76e8915ea3880a3e9fd77b3113e4b293d29c0","assignee":{"login":"ltfish","id":5071575,"node_id":"MDQ6VXNlcjUwNzE1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5071575?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfish","html_url":"https://github.com/ltfish","followers_url":"https://api.github.com/users/ltfish/followers","following_url":"https://api.github.com/users/ltfish/following{/other_user}","gists_url":"https://api.github.com/users/ltfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfish/subscriptions","organizations_url":"https://api.github.com/users/ltfish/orgs","repos_url":"https://api.github.com/users/ltfish/repos","events_url":"https://api.github.com/users/ltfish/events{/privacy}","received_events_url":"https://api.github.com/users/ltfish/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltfish","id":5071575,"node_id":"MDQ6VXNlcjUwNzE1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5071575?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfish","html_url":"https://github.com/ltfish","followers_url":"https://api.github.com/users/ltfish/followers","following_url":"https://api.github.com/users/ltfish/following{/other_user}","gists_url":"https://api.github.com/users/ltfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfish/subscriptions","organizations_url":"https://api.github.com/users/ltfish/orgs","repos_url":"https://api.github.com/users/ltfish/repos","events_url":"https://api.github.com/users/ltfish/events{/privacy}","received_events_url":"https://api.github.com/users/ltfish/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":216779584,"node_id":"MDU6TGFiZWwyMTY3Nzk1ODQ=","url":"https://api.github.com/repos/angr/archinfo/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":795010635,"node_id":"MDU6TGFiZWw3OTUwMTA2MzU=","url":"https://api.github.com/repos/angr/archinfo/labels/feature","name":"feature","color":"afffbf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angr/archinfo/pulls/41/commits","review_comments_url":"https://api.github.com/repos/angr/archinfo/pulls/41/comments","review_comment_url":"https://api.github.com/repos/angr/archinfo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angr/archinfo/issues/41/comments","statuses_url":"https://api.github.com/repos/angr/archinfo/statuses/fa881a26257f75c3abe2d193d61e4ce69e089b20","head":{"label":"angr:feat/mixed_java","ref":"feat/mixed_java","sha":"fa881a26257f75c3abe2d193d61e4ce69e089b20","user":{"login":"angr","id":12520807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"repo":{"id":36355765,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM1NTc2NQ==","name":"archinfo","full_name":"angr/archinfo","owner":{"login":"angr","id":12520807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angr/archinfo","description":"Classes with architecture-specific information useful to other projects.","fork":false,"url":"https://api.github.com/repos/angr/archinfo","forks_url":"https://api.github.com/repos/angr/archinfo/forks","keys_url":"https://api.github.com/repos/angr/archinfo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angr/archinfo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angr/archinfo/teams","hooks_url":"https://api.github.com/repos/angr/archinfo/hooks","issue_events_url":"https://api.github.com/repos/angr/archinfo/issues/events{/number}","events_url":"https://api.github.com/repos/angr/archinfo/events","assignees_url":"https://api.github.com/repos/angr/archinfo/assignees{/user}","branches_url":"https://api.github.com/repos/angr/archinfo/branches{/branch}","tags_url":"https://api.github.com/repos/angr/archinfo/tags","blobs_url":"https://api.github.com/repos/angr/archinfo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angr/archinfo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angr/archinfo/git/refs{/sha}","trees_url":"https://api.github.com/repos/angr/archinfo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angr/archinfo/statuses/{sha}","languages_url":"https://api.github.com/repos/angr/archinfo/languages","stargazers_url":"https://api.github.com/repos/angr/archinfo/stargazers","contributors_url":"https://api.github.com/repos/angr/archinfo/contributors","subscribers_url":"https://api.github.com/repos/angr/archinfo/subscribers","subscription_url":"https://api.github.com/repos/angr/archinfo/subscription","commits_url":"https://api.github.com/repos/angr/archinfo/commits{/sha}","git_commits_url":"https://api.github.com/repos/angr/archinfo/git/commits{/sha}","comments_url":"https://api.github.com/repos/angr/archinfo/comments{/number}","issue_comment_url":"https://api.github.com/repos/angr/archinfo/issues/comments{/number}","contents_url":"https://api.github.com/repos/angr/archinfo/contents/{+path}","compare_url":"https://api.github.com/repos/angr/archinfo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angr/archinfo/merges","archive_url":"https://api.github.com/repos/angr/archinfo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angr/archinfo/downloads","issues_url":"https://api.github.com/repos/angr/archinfo/issues{/number}","pulls_url":"https://api.github.com/repos/angr/archinfo/pulls{/number}","milestones_url":"https://api.github.com/repos/angr/archinfo/milestones{/number}","notifications_url":"https://api.github.com/repos/angr/archinfo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angr/archinfo/labels{/name}","releases_url":"https://api.github.com/repos/angr/archinfo/releases{/id}","deployments_url":"https://api.github.com/repos/angr/archinfo/deployments","created_at":"2015-05-27T09:05:40Z","updated_at":"2018-07-02T06:41:53Z","pushed_at":"2018-07-03T07:12:45Z","git_url":"git://github.com/angr/archinfo.git","ssh_url":"git@github.com:angr/archinfo.git","clone_url":"https://github.com/angr/archinfo.git","svn_url":"https://github.com/angr/archinfo","homepage":null,"size":366,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":27,"open_issues":5,"watchers":40,"default_branch":"master"}},"base":{"label":"angr:master","ref":"master","sha":"59e95a4cc6b3ca74cb6608d0ffd0c3974d9c47a2","user":{"login":"angr","id":12520807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"repo":{"id":36355765,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM1NTc2NQ==","name":"archinfo","full_name":"angr/archinfo","owner":{"login":"angr","id":12520807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTIwODA3","avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angr/archinfo","description":"Classes with architecture-specific information useful to other projects.","fork":false,"url":"https://api.github.com/repos/angr/archinfo","forks_url":"https://api.github.com/repos/angr/archinfo/forks","keys_url":"https://api.github.com/repos/angr/archinfo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angr/archinfo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angr/archinfo/teams","hooks_url":"https://api.github.com/repos/angr/archinfo/hooks","issue_events_url":"https://api.github.com/repos/angr/archinfo/issues/events{/number}","events_url":"https://api.github.com/repos/angr/archinfo/events","assignees_url":"https://api.github.com/repos/angr/archinfo/assignees{/user}","branches_url":"https://api.github.com/repos/angr/archinfo/branches{/branch}","tags_url":"https://api.github.com/repos/angr/archinfo/tags","blobs_url":"https://api.github.com/repos/angr/archinfo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angr/archinfo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angr/archinfo/git/refs{/sha}","trees_url":"https://api.github.com/repos/angr/archinfo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angr/archinfo/statuses/{sha}","languages_url":"https://api.github.com/repos/angr/archinfo/languages","stargazers_url":"https://api.github.com/repos/angr/archinfo/stargazers","contributors_url":"https://api.github.com/repos/angr/archinfo/contributors","subscribers_url":"https://api.github.com/repos/angr/archinfo/subscribers","subscription_url":"https://api.github.com/repos/angr/archinfo/subscription","commits_url":"https://api.github.com/repos/angr/archinfo/commits{/sha}","git_commits_url":"https://api.github.com/repos/angr/archinfo/git/commits{/sha}","comments_url":"https://api.github.com/repos/angr/archinfo/comments{/number}","issue_comment_url":"https://api.github.com/repos/angr/archinfo/issues/comments{/number}","contents_url":"https://api.github.com/repos/angr/archinfo/contents/{+path}","compare_url":"https://api.github.com/repos/angr/archinfo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angr/archinfo/merges","archive_url":"https://api.github.com/repos/angr/archinfo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angr/archinfo/downloads","issues_url":"https://api.github.com/repos/angr/archinfo/issues{/number}","pulls_url":"https://api.github.com/repos/angr/archinfo/pulls{/number}","milestones_url":"https://api.github.com/repos/angr/archinfo/milestones{/number}","notifications_url":"https://api.github.com/repos/angr/archinfo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angr/archinfo/labels{/name}","releases_url":"https://api.github.com/repos/angr/archinfo/releases{/id}","deployments_url":"https://api.github.com/repos/angr/archinfo/deployments","created_at":"2015-05-27T09:05:40Z","updated_at":"2018-07-02T06:41:53Z","pushed_at":"2018-07-03T07:12:45Z","git_url":"git://github.com/angr/archinfo.git","ssh_url":"git@github.com:angr/archinfo.git","clone_url":"https://github.com/angr/archinfo.git","svn_url":"https://github.com/angr/archinfo","homepage":null,"size":366,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":27,"open_issues":5,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angr/archinfo/pulls/41"},"html":{"href":"https://github.com/angr/archinfo/pull/41"},"issue":{"href":"https://api.github.com/repos/angr/archinfo/issues/41"},"comments":{"href":"https://api.github.com/repos/angr/archinfo/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/angr/archinfo/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/angr/archinfo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angr/archinfo/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/angr/archinfo/statuses/fa881a26257f75c3abe2d193d61e4ce69e089b20"}},"author_association":"MEMBER"}} | {
"id": 36355765,
"name": "angr/archinfo",
"url": "https://api.github.com/repos/angr/archinfo"
} | {
"id": 5071575,
"login": "ltfish",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5071575?",
"url": "https://api.github.com/users/ltfish"
} | {
"id": 12520807,
"login": "angr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12520807?",
"url": "https://api.github.com/orgs/angr"
} | 2018-07-03T07:33:56 | 7910766851 | {"actor":{"display_login":"ltfish"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/comments/245440115","pull_request_review_id":189553767,"id":245440115,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ0MDExNQ==","diff_hunk":"@@ -926,9 +928,88 @@ def texts(self):\n #----------------------------------------------------------------\n def button_count(self):\n \"\"\"Return a number of buttons on the ToolBar\"\"\"\n- return len(self.children())\n+ children_list = self.children()\n+ if not children_list and self.element_info.handle is not None:\n+ btn_count = common_controls.ToolbarWrapper(self.element_info.handle).button_count()\n+ return btn_count\n+ else:\n+ return len(children_list)\n \n # ----------------------------------------------------------------\n+ def _menu_item_exists(self, btn_x_coord, btn_y_coord):\n+ # Check that element is exist\n+ button_elem_info = UIAElementInfo.from_point(btn_x_coord, btn_y_coord)\n+ return button_elem_info.control_type == 'MenuItem'\n+\n+ def _up_down_menu_items(self, btn_x_coord, btn_y_coord, side='right'):\n+ # Check items up, down, left and right from current item\n+ first_pos_y = btn_y_coord\n+ elem_y_pos = btn_y_coord\n+ menu_elem_list = []\n+ direction = 0\n+\n+ while direction <= 1:\n+ button_elem_info = UIAElementInfo.from_point(btn_x_coord, elem_y_pos)\n+\n+ if not direction and button_elem_info.control_type == 'MenuItem':\n+ elem_height = button_elem_info.rectangle.height()\n+ elem_width = button_elem_info.rectangle.width()\n+ right_x = btn_x_coord + elem_width\n+ left_x = btn_x_coord - elem_width\n+ menu_elem_list.append(button_elem_info)\n+\n+ if self._menu_item_exists(right_x, elem_y_pos) and side == 'right':\n+ # Check right side from the item\n+ menu_elem_list += self._up_down_menu_items(right_x, elem_y_pos, side='right')\n+ elif self._menu_item_exists(left_x, elem_y_pos):\n+ # Check left side from the item\n+ menu_elem_list += self._up_down_menu_items(left_x, elem_y_pos, side='left')\n+\n+ elem_y_pos += elem_height\n+\n+ elif not direction and button_elem_info.control_type != 'MenuItem':\n+ direction = 1\n+ elem_y_pos = first_pos_y\n+\n+ if direction and button_elem_info.control_type == 'MenuItem':\n+ elem_height = button_elem_info.rectangle.height()\n+ elem_width = button_elem_info.rectangle.width()\n+ right_x = btn_x_coord + elem_width\n+ left_x = btn_x_coord - elem_width\n+ menu_elem_list.append(button_elem_info)\n+\n+ if self._menu_item_exists(right_x, elem_y_pos) and side == 'right':\n+ # Check right side from the item\n+ menu_elem_list += self._up_down_menu_items(right_x, elem_y_pos, side='right')\n+ elif self._menu_item_exists(left_x, elem_y_pos):\n+ # Check left side from the item\n+ menu_elem_list += self._up_down_menu_items(left_x, elem_y_pos, side='left')\n+\n+ elem_y_pos -= elem_height\n+\n+ elif direction and button_elem_info.control_type != 'MenuItem':\n+ direction = 2\n+\n+ return menu_elem_list\n+\n+ def _collect_menu_items(self, btn_count):\n+ # Collect element info from toolbar buttons\n+ buttons_elem_list = []\n+ cc = []\n+ for btn_num in range(btn_count):\n+ button_coord = common_controls.ToolbarWrapper(self.element_info.handle) \\","path":"pywinauto/controls/uia_controls.py","position":null,"original_position":83,"commit_id":"396dec1feab495e5664d3f67a4d3a52146433266","original_commit_id":"c2593c4b85f0189914b6cada2411500c1881f45a","user":{"login":"Nebyt","id":22872852,"node_id":"MDQ6VXNlcjIyODcyODUy","avatar_url":"https://avatars2.githubusercontent.com/u/22872852?v=4","gravatar_id":"","url":"https://api.github.com/users/Nebyt","html_url":"https://github.com/Nebyt","followers_url":"https://api.github.com/users/Nebyt/followers","following_url":"https://api.github.com/users/Nebyt/following{/other_user}","gists_url":"https://api.github.com/users/Nebyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebyt/subscriptions","organizations_url":"https://api.github.com/users/Nebyt/orgs","repos_url":"https://api.github.com/users/Nebyt/repos","events_url":"https://api.github.com/users/Nebyt/events{/privacy}","received_events_url":"https://api.github.com/users/Nebyt/received_events","type":"User","site_admin":false},"body":"I delete `button_coord` variable and put `common_controls.ToolbarWrapper` into method ","created_at":"2019-01-04T22:39:07Z","updated_at":"2019-01-04T22:39:07Z","html_url":"https://github.com/pywinauto/pywinauto/pull/646#discussion_r245440115","pull_request_url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/comments/245440115"},"html":{"href":"https://github.com/pywinauto/pywinauto/pull/646#discussion_r245440115"},"pull_request":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646"}},"in_reply_to_id":245128504},"pull_request":{"url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646","id":242066925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDY2OTI1","html_url":"https://github.com/pywinauto/pywinauto/pull/646","diff_url":"https://github.com/pywinauto/pywinauto/pull/646.diff","patch_url":"https://github.com/pywinauto/pywinauto/pull/646.patch","issue_url":"https://api.github.com/repos/pywinauto/pywinauto/issues/646","number":646,"state":"open","locked":false,"title":"#413 MFC Toolbar","user":{"login":"Nebyt","id":22872852,"node_id":"MDQ6VXNlcjIyODcyODUy","avatar_url":"https://avatars2.githubusercontent.com/u/22872852?v=4","gravatar_id":"","url":"https://api.github.com/users/Nebyt","html_url":"https://github.com/Nebyt","followers_url":"https://api.github.com/users/Nebyt/followers","following_url":"https://api.github.com/users/Nebyt/following{/other_user}","gists_url":"https://api.github.com/users/Nebyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebyt/subscriptions","organizations_url":"https://api.github.com/users/Nebyt/orgs","repos_url":"https://api.github.com/users/Nebyt/repos","events_url":"https://api.github.com/users/Nebyt/events{/privacy}","received_events_url":"https://api.github.com/users/Nebyt/received_events","type":"User","site_admin":false},"body":"Issue #413 : try to handle MFC Toolbar","created_at":"2019-01-03T17:55:13Z","updated_at":"2019-01-04T22:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"507822c693cd32cf25b93deaf847cf56a61397cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646/commits","review_comments_url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646/comments","review_comment_url":"https://api.github.com/repos/pywinauto/pywinauto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pywinauto/pywinauto/issues/646/comments","statuses_url":"https://api.github.com/repos/pywinauto/pywinauto/statuses/396dec1feab495e5664d3f67a4d3a52146433266","head":{"label":"Nebyt:nebyt_pywinauto","ref":"nebyt_pywinauto","sha":"396dec1feab495e5664d3f67a4d3a52146433266","user":{"login":"Nebyt","id":22872852,"node_id":"MDQ6VXNlcjIyODcyODUy","avatar_url":"https://avatars2.githubusercontent.com/u/22872852?v=4","gravatar_id":"","url":"https://api.github.com/users/Nebyt","html_url":"https://github.com/Nebyt","followers_url":"https://api.github.com/users/Nebyt/followers","following_url":"https://api.github.com/users/Nebyt/following{/other_user}","gists_url":"https://api.github.com/users/Nebyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebyt/subscriptions","organizations_url":"https://api.github.com/users/Nebyt/orgs","repos_url":"https://api.github.com/users/Nebyt/repos","events_url":"https://api.github.com/users/Nebyt/events{/privacy}","received_events_url":"https://api.github.com/users/Nebyt/received_events","type":"User","site_admin":false},"repo":{"id":147964880,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc5NjQ4ODA=","name":"pywinauto","full_name":"Nebyt/pywinauto","private":false,"owner":{"login":"Nebyt","id":22872852,"node_id":"MDQ6VXNlcjIyODcyODUy","avatar_url":"https://avatars2.githubusercontent.com/u/22872852?v=4","gravatar_id":"","url":"https://api.github.com/users/Nebyt","html_url":"https://github.com/Nebyt","followers_url":"https://api.github.com/users/Nebyt/followers","following_url":"https://api.github.com/users/Nebyt/following{/other_user}","gists_url":"https://api.github.com/users/Nebyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Nebyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nebyt/subscriptions","organizations_url":"https://api.github.com/users/Nebyt/orgs","repos_url":"https://api.github.com/users/Nebyt/repos","events_url":"https://api.github.com/users/Nebyt/events{/privacy}","received_events_url":"https://api.github.com/users/Nebyt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Nebyt/pywinauto","description":"Windows GUI Automation with Python","fork":true,"url":"https://api.github.com/repos/Nebyt/pywinauto","forks_url":"https://api.github.com/repos/Nebyt/pywinauto/forks","keys_url":"https://api.github.com/repos/Nebyt/pywinauto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nebyt/pywinauto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nebyt/pywinauto/teams","hooks_url":"https://api.github.com/repos/Nebyt/pywinauto/hooks","issue_events_url":"https://api.github.com/repos/Nebyt/pywinauto/issues/events{/number}","events_url":"https://api.github.com/repos/Nebyt/pywinauto/events","assignees_url":"https://api.github.com/repos/Nebyt/pywinauto/assignees{/user}","branches_url":"https://api.github.com/repos/Nebyt/pywinauto/branches{/branch}","tags_url":"https://api.github.com/repos/Nebyt/pywinauto/tags","blobs_url":"https://api.github.com/repos/Nebyt/pywinauto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nebyt/pywinauto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nebyt/pywinauto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nebyt/pywinauto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nebyt/pywinauto/statuses/{sha}","languages_url":"https://api.github.com/repos/Nebyt/pywinauto/languages","stargazers_url":"https://api.github.com/repos/Nebyt/pywinauto/stargazers","contributors_url":"https://api.github.com/repos/Nebyt/pywinauto/contributors","subscribers_url":"https://api.github.com/repos/Nebyt/pywinauto/subscribers","subscription_url":"https://api.github.com/repos/Nebyt/pywinauto/subscription","commits_url":"https://api.github.com/repos/Nebyt/pywinauto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nebyt/pywinauto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nebyt/pywinauto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nebyt/pywinauto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nebyt/pywinauto/contents/{+path}","compare_url":"https://api.github.com/repos/Nebyt/pywinauto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nebyt/pywinauto/merges","archive_url":"https://api.github.com/repos/Nebyt/pywinauto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nebyt/pywinauto/downloads","issues_url":"https://api.github.com/repos/Nebyt/pywinauto/issues{/number}","pulls_url":"https://api.github.com/repos/Nebyt/pywinauto/pulls{/number}","milestones_url":"https://api.github.com/repos/Nebyt/pywinauto/milestones{/number}","notifications_url":"https://api.github.com/repos/Nebyt/pywinauto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nebyt/pywinauto/labels{/name}","releases_url":"https://api.github.com/repos/Nebyt/pywinauto/releases{/id}","deployments_url":"https://api.github.com/repos/Nebyt/pywinauto/deployments","created_at":"2018-09-08T19:47:23Z","updated_at":"2018-09-08T19:47:26Z","pushed_at":"2019-01-04T21:23:06Z","git_url":"git://github.com/Nebyt/pywinauto.git","ssh_url":"git@github.com:Nebyt/pywinauto.git","clone_url":"https://github.com/Nebyt/pywinauto.git","svn_url":"https://github.com/Nebyt/pywinauto","homepage":"http://pywinauto.github.io/","size":22116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pywinauto:master","ref":"master","sha":"4609ef878429895005afdb72bc675aaadebb26af","user":{"login":"pywinauto","id":12541065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQxMDY1","avatar_url":"https://avatars1.githubusercontent.com/u/12541065?v=4","gravatar_id":"","url":"https://api.github.com/users/pywinauto","html_url":"https://github.com/pywinauto","followers_url":"https://api.github.com/users/pywinauto/followers","following_url":"https://api.github.com/users/pywinauto/following{/other_user}","gists_url":"https://api.github.com/users/pywinauto/gists{/gist_id}","starred_url":"https://api.github.com/users/pywinauto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywinauto/subscriptions","organizations_url":"https://api.github.com/users/pywinauto/orgs","repos_url":"https://api.github.com/users/pywinauto/repos","events_url":"https://api.github.com/users/pywinauto/events{/privacy}","received_events_url":"https://api.github.com/users/pywinauto/received_events","type":"Organization","site_admin":false},"repo":{"id":36223210,"node_id":"MDEwOlJlcG9zaXRvcnkzNjIyMzIxMA==","name":"pywinauto","full_name":"pywinauto/pywinauto","private":false,"owner":{"login":"pywinauto","id":12541065,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQxMDY1","avatar_url":"https://avatars1.githubusercontent.com/u/12541065?v=4","gravatar_id":"","url":"https://api.github.com/users/pywinauto","html_url":"https://github.com/pywinauto","followers_url":"https://api.github.com/users/pywinauto/followers","following_url":"https://api.github.com/users/pywinauto/following{/other_user}","gists_url":"https://api.github.com/users/pywinauto/gists{/gist_id}","starred_url":"https://api.github.com/users/pywinauto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywinauto/subscriptions","organizations_url":"https://api.github.com/users/pywinauto/orgs","repos_url":"https://api.github.com/users/pywinauto/repos","events_url":"https://api.github.com/users/pywinauto/events{/privacy}","received_events_url":"https://api.github.com/users/pywinauto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pywinauto/pywinauto","description":"Windows GUI Automation with Python","fork":false,"url":"https://api.github.com/repos/pywinauto/pywinauto","forks_url":"https://api.github.com/repos/pywinauto/pywinauto/forks","keys_url":"https://api.github.com/repos/pywinauto/pywinauto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywinauto/pywinauto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywinauto/pywinauto/teams","hooks_url":"https://api.github.com/repos/pywinauto/pywinauto/hooks","issue_events_url":"https://api.github.com/repos/pywinauto/pywinauto/issues/events{/number}","events_url":"https://api.github.com/repos/pywinauto/pywinauto/events","assignees_url":"https://api.github.com/repos/pywinauto/pywinauto/assignees{/user}","branches_url":"https://api.github.com/repos/pywinauto/pywinauto/branches{/branch}","tags_url":"https://api.github.com/repos/pywinauto/pywinauto/tags","blobs_url":"https://api.github.com/repos/pywinauto/pywinauto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywinauto/pywinauto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywinauto/pywinauto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywinauto/pywinauto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywinauto/pywinauto/statuses/{sha}","languages_url":"https://api.github.com/repos/pywinauto/pywinauto/languages","stargazers_url":"https://api.github.com/repos/pywinauto/pywinauto/stargazers","contributors_url":"https://api.github.com/repos/pywinauto/pywinauto/contributors","subscribers_url":"https://api.github.com/repos/pywinauto/pywinauto/subscribers","subscription_url":"https://api.github.com/repos/pywinauto/pywinauto/subscription","commits_url":"https://api.github.com/repos/pywinauto/pywinauto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywinauto/pywinauto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywinauto/pywinauto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywinauto/pywinauto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywinauto/pywinauto/contents/{+path}","compare_url":"https://api.github.com/repos/pywinauto/pywinauto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywinauto/pywinauto/merges","archive_url":"https://api.github.com/repos/pywinauto/pywinauto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywinauto/pywinauto/downloads","issues_url":"https://api.github.com/repos/pywinauto/pywinauto/issues{/number}","pulls_url":"https://api.github.com/repos/pywinauto/pywinauto/pulls{/number}","milestones_url":"https://api.github.com/repos/pywinauto/pywinauto/milestones{/number}","notifications_url":"https://api.github.com/repos/pywinauto/pywinauto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywinauto/pywinauto/labels{/name}","releases_url":"https://api.github.com/repos/pywinauto/pywinauto/releases{/id}","deployments_url":"https://api.github.com/repos/pywinauto/pywinauto/deployments","created_at":"2015-05-25T09:50:40Z","updated_at":"2019-01-04T07:40:51Z","pushed_at":"2019-01-04T21:23:08Z","git_url":"git://github.com/pywinauto/pywinauto.git","ssh_url":"git@github.com:pywinauto/pywinauto.git","clone_url":"https://github.com/pywinauto/pywinauto.git","svn_url":"https://github.com/pywinauto/pywinauto","homepage":"http://pywinauto.github.io/","size":22241,"stargazers_count":1238,"watchers_count":1238,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":283,"open_issues":150,"watchers":1238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646"},"html":{"href":"https://github.com/pywinauto/pywinauto/pull/646"},"issue":{"href":"https://api.github.com/repos/pywinauto/pywinauto/issues/646"},"comments":{"href":"https://api.github.com/repos/pywinauto/pywinauto/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pywinauto/pywinauto/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/pywinauto/pywinauto/statuses/396dec1feab495e5664d3f67a4d3a52146433266"}},"author_association":"CONTRIBUTOR"}} | {
"id": 36223210,
"name": "pywinauto/pywinauto",
"url": "https://api.github.com/repos/pywinauto/pywinauto"
} | {
"id": 22872852,
"login": "Nebyt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22872852?",
"url": "https://api.github.com/users/Nebyt"
} | {
"id": 12541065,
"login": "pywinauto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12541065?",
"url": "https://api.github.com/orgs/pywinauto"
} | 2019-01-04T22:39:07 | 8836731469 | {"actor":{"display_login":"Nebyt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/diva/pulls/comments/203163605","pull_request_review_id":138000725,"id":203163605,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzE2MzYwNQ==","diff_hunk":"@@ -34,13 +34,13 @@ var c *config.Config\n // file. We cannot just look for the filelists file directly because a hash is\n // part of the filename. The repomd.xml file lists this file name so we can\n // construct the url using this value.\n-func buildFilelistsURL(repo *Repo, workingDir string) (string, error) {\n+func buildFilelistsURL(repo *Repo, workingDir string, update bool) (string, error) {\n \t// download repomd.xml\n \trepomdFile := filepath.Join(workingDir, \"repomd.xml\")\n \trepomdURL := fmt.Sprintf(\"%s/repodata/repomd.xml\", repo.URI)\n \t_, err := os.Stat(repomdFile)\n-\tif err != nil {\n-\t\terr = helpers.Download(repomdURL, repomdFile)\n+\tif err != nil || update {\n+\t\terr := helpers.Download(repomdURL, repomdFile)","path":"pkginfo/download_repo.go","position":13,"original_position":13,"commit_id":"1b5eb31245027750d6d839cf003b8b2b412531fd","original_commit_id":"1b5eb31245027750d6d839cf003b8b2b412531fd","user":{"login":"matthewrsj","id":12090084,"node_id":"MDQ6VXNlcjEyMDkwMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/12090084?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"body":"Also, if `update` you don't even need to do the stat right?","created_at":"2018-07-17T20:17:45Z","updated_at":"2018-07-17T20:17:45Z","html_url":"https://github.com/clearlinux/diva/pull/55#discussion_r203163605","pull_request_url":"https://api.github.com/repos/clearlinux/diva/pulls/55","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/comments/203163605"},"html":{"href":"https://github.com/clearlinux/diva/pull/55#discussion_r203163605"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/55"}},"in_reply_to_id":203163445},"pull_request":{"url":"https://api.github.com/repos/clearlinux/diva/pulls/55","id":202054115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDU0MTE1","html_url":"https://github.com/clearlinux/diva/pull/55","diff_url":"https://github.com/clearlinux/diva/pull/55.diff","patch_url":"https://github.com/clearlinux/diva/pull/55.patch","issue_url":"https://api.github.com/repos/clearlinux/diva/issues/55","number":55,"state":"open","locked":false,"title":"Provide option to update RPMs","user":{"login":"Gabib32","id":8284020,"node_id":"MDQ6VXNlcjgyODQwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8284020?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabib32","html_url":"https://github.com/Gabib32","followers_url":"https://api.github.com/users/Gabib32/followers","following_url":"https://api.github.com/users/Gabib32/following{/other_user}","gists_url":"https://api.github.com/users/Gabib32/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabib32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabib32/subscriptions","organizations_url":"https://api.github.com/users/Gabib32/orgs","repos_url":"https://api.github.com/users/Gabib32/repos","events_url":"https://api.github.com/users/Gabib32/events{/privacy}","received_events_url":"https://api.github.com/users/Gabib32/received_events","type":"User","site_admin":false},"body":"If an update flag is passed, check whether an RPM already\r\nexists for that package, and if so remove the cached\r\nRPM and download the new one.\r\n\r\nSigned-off-by: gabrielle beyer <gabrielle.n.beyer@intel.com>","created_at":"2018-07-17T20:05:48Z","updated_at":"2018-07-17T20:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc13930231544802efaffcf54adbf6da46d038aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tmarcu","id":574028,"node_id":"MDQ6VXNlcjU3NDAyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/diva/pulls/55/commits","review_comments_url":"https://api.github.com/repos/clearlinux/diva/pulls/55/comments","review_comment_url":"https://api.github.com/repos/clearlinux/diva/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/diva/issues/55/comments","statuses_url":"https://api.github.com/repos/clearlinux/diva/statuses/1b5eb31245027750d6d839cf003b8b2b412531fd","head":{"label":"Gabib32:rpmUpdate","ref":"rpmUpdate","sha":"1b5eb31245027750d6d839cf003b8b2b412531fd","user":{"login":"Gabib32","id":8284020,"node_id":"MDQ6VXNlcjgyODQwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8284020?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabib32","html_url":"https://github.com/Gabib32","followers_url":"https://api.github.com/users/Gabib32/followers","following_url":"https://api.github.com/users/Gabib32/following{/other_user}","gists_url":"https://api.github.com/users/Gabib32/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabib32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabib32/subscriptions","organizations_url":"https://api.github.com/users/Gabib32/orgs","repos_url":"https://api.github.com/users/Gabib32/repos","events_url":"https://api.github.com/users/Gabib32/events{/privacy}","received_events_url":"https://api.github.com/users/Gabib32/received_events","type":"User","site_admin":false},"repo":{"id":138335271,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMzUyNzE=","name":"diva","full_name":"Gabib32/diva","owner":{"login":"Gabib32","id":8284020,"node_id":"MDQ6VXNlcjgyODQwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8284020?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabib32","html_url":"https://github.com/Gabib32","followers_url":"https://api.github.com/users/Gabib32/followers","following_url":"https://api.github.com/users/Gabib32/following{/other_user}","gists_url":"https://api.github.com/users/Gabib32/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabib32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabib32/subscriptions","organizations_url":"https://api.github.com/users/Gabib32/orgs","repos_url":"https://api.github.com/users/Gabib32/repos","events_url":"https://api.github.com/users/Gabib32/events{/privacy}","received_events_url":"https://api.github.com/users/Gabib32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gabib32/diva","description":null,"fork":true,"url":"https://api.github.com/repos/Gabib32/diva","forks_url":"https://api.github.com/repos/Gabib32/diva/forks","keys_url":"https://api.github.com/repos/Gabib32/diva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gabib32/diva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gabib32/diva/teams","hooks_url":"https://api.github.com/repos/Gabib32/diva/hooks","issue_events_url":"https://api.github.com/repos/Gabib32/diva/issues/events{/number}","events_url":"https://api.github.com/repos/Gabib32/diva/events","assignees_url":"https://api.github.com/repos/Gabib32/diva/assignees{/user}","branches_url":"https://api.github.com/repos/Gabib32/diva/branches{/branch}","tags_url":"https://api.github.com/repos/Gabib32/diva/tags","blobs_url":"https://api.github.com/repos/Gabib32/diva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gabib32/diva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gabib32/diva/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gabib32/diva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gabib32/diva/statuses/{sha}","languages_url":"https://api.github.com/repos/Gabib32/diva/languages","stargazers_url":"https://api.github.com/repos/Gabib32/diva/stargazers","contributors_url":"https://api.github.com/repos/Gabib32/diva/contributors","subscribers_url":"https://api.github.com/repos/Gabib32/diva/subscribers","subscription_url":"https://api.github.com/repos/Gabib32/diva/subscription","commits_url":"https://api.github.com/repos/Gabib32/diva/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gabib32/diva/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gabib32/diva/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gabib32/diva/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gabib32/diva/contents/{+path}","compare_url":"https://api.github.com/repos/Gabib32/diva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gabib32/diva/merges","archive_url":"https://api.github.com/repos/Gabib32/diva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gabib32/diva/downloads","issues_url":"https://api.github.com/repos/Gabib32/diva/issues{/number}","pulls_url":"https://api.github.com/repos/Gabib32/diva/pulls{/number}","milestones_url":"https://api.github.com/repos/Gabib32/diva/milestones{/number}","notifications_url":"https://api.github.com/repos/Gabib32/diva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gabib32/diva/labels{/name}","releases_url":"https://api.github.com/repos/Gabib32/diva/releases{/id}","deployments_url":"https://api.github.com/repos/Gabib32/diva/deployments","created_at":"2018-06-22T18:24:50Z","updated_at":"2018-07-16T16:59:16Z","pushed_at":"2018-07-17T20:06:28Z","git_url":"git://github.com/Gabib32/diva.git","ssh_url":"git@github.com:Gabib32/diva.git","clone_url":"https://github.com/Gabib32/diva.git","svn_url":"https://github.com/Gabib32/diva","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"69e622993254295db883b3382af020c5bc55630d","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":133871444,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4NzE0NDQ=","name":"diva","full_name":"clearlinux/diva","owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/diva","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/diva","forks_url":"https://api.github.com/repos/clearlinux/diva/forks","keys_url":"https://api.github.com/repos/clearlinux/diva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/diva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/diva/teams","hooks_url":"https://api.github.com/repos/clearlinux/diva/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/diva/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/diva/events","assignees_url":"https://api.github.com/repos/clearlinux/diva/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/diva/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/diva/tags","blobs_url":"https://api.github.com/repos/clearlinux/diva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/diva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/diva/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/diva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/diva/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/diva/languages","stargazers_url":"https://api.github.com/repos/clearlinux/diva/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/diva/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/diva/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/diva/subscription","commits_url":"https://api.github.com/repos/clearlinux/diva/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/diva/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/diva/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/diva/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/diva/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/diva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/diva/merges","archive_url":"https://api.github.com/repos/clearlinux/diva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/diva/downloads","issues_url":"https://api.github.com/repos/clearlinux/diva/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/diva/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/diva/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/diva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/diva/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/diva/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/diva/deployments","created_at":"2018-05-17T21:42:55Z","updated_at":"2018-07-16T17:21:06Z","pushed_at":"2018-07-17T20:06:30Z","git_url":"git://github.com/clearlinux/diva.git","ssh_url":"git@github.com:clearlinux/diva.git","clone_url":"https://github.com/clearlinux/diva.git","svn_url":"https://github.com/clearlinux/diva","homepage":null,"size":84,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":20,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/55"},"html":{"href":"https://github.com/clearlinux/diva/pull/55"},"issue":{"href":"https://api.github.com/repos/clearlinux/diva/issues/55"},"comments":{"href":"https://api.github.com/repos/clearlinux/diva/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/diva/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/diva/statuses/1b5eb31245027750d6d839cf003b8b2b412531fd"}},"author_association":"COLLABORATOR"}} | {
"id": 133871444,
"name": "clearlinux/diva",
"url": "https://api.github.com/repos/clearlinux/diva"
} | {
"id": 12090084,
"login": "matthewrsj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12090084?",
"url": "https://api.github.com/users/matthewrsj"
} | {
"id": 12545216,
"login": "clearlinux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12545216?",
"url": "https://api.github.com/orgs/clearlinux"
} | 2018-07-17T20:17:45 | 7979025730 | {"actor":{"display_login":"matthewrsj"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/176115672","pull_request_review_id":105761915,"id":176115672,"diff_hunk":"@@ -315,7 +315,8 @@ def get_base_compile_args(options, compiler):\n except KeyError:\n pass\n try:\n- if options['b_ndebug'].value == 'true' or (options['b_ndebug'].value == 'if-release' and options['buildtype'] == 'release'):\n+ if (options['b_ndebug'].value == 'true' or\n+ (options['b_ndebug'].value == 'if-release' and options['buildtype'].value == 'release')):","path":"mesonbuild/compilers/compilers.py","position":6,"original_position":6,"commit_id":"c3d145782c49ce814c6ebd67eece9c0543d64878","original_commit_id":"c3d145782c49ce814c6ebd67eece9c0543d64878","user":{"login":"sarum9in","id":1058248,"avatar_url":"https://avatars3.githubusercontent.com/u/1058248?v=4","gravatar_id":"","url":"https://api.github.com/users/sarum9in","html_url":"https://github.com/sarum9in","followers_url":"https://api.github.com/users/sarum9in/followers","following_url":"https://api.github.com/users/sarum9in/following{/other_user}","gists_url":"https://api.github.com/users/sarum9in/gists{/gist_id}","starred_url":"https://api.github.com/users/sarum9in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarum9in/subscriptions","organizations_url":"https://api.github.com/users/sarum9in/orgs","repos_url":"https://api.github.com/users/sarum9in/repos","events_url":"https://api.github.com/users/sarum9in/events{/privacy}","received_events_url":"https://api.github.com/users/sarum9in/received_events","type":"User","site_admin":false},"body":"Will fix later, let's run tests.","created_at":"2018-03-21T15:05:03Z","updated_at":"2018-03-21T15:05:03Z","html_url":"https://github.com/mesonbuild/meson/pull/3274#discussion_r176115672","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3274","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/176115672"},"html":{"href":"https://github.com/mesonbuild/meson/pull/3274#discussion_r176115672"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3274"}},"in_reply_to_id":176114646},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/3274","id":176356812,"html_url":"https://github.com/mesonbuild/meson/pull/3274","diff_url":"https://github.com/mesonbuild/meson/pull/3274.diff","patch_url":"https://github.com/mesonbuild/meson/pull/3274.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/3274","number":3274,"state":"open","locked":false,"title":"Add tests for b_ndebug=if-release default option","user":{"login":"sarum9in","id":1058248,"avatar_url":"https://avatars3.githubusercontent.com/u/1058248?v=4","gravatar_id":"","url":"https://api.github.com/users/sarum9in","html_url":"https://github.com/sarum9in","followers_url":"https://api.github.com/users/sarum9in/followers","following_url":"https://api.github.com/users/sarum9in/following{/other_user}","gists_url":"https://api.github.com/users/sarum9in/gists{/gist_id}","starred_url":"https://api.github.com/users/sarum9in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarum9in/subscriptions","organizations_url":"https://api.github.com/users/sarum9in/orgs","repos_url":"https://api.github.com/users/sarum9in/repos","events_url":"https://api.github.com/users/sarum9in/events{/privacy}","received_events_url":"https://api.github.com/users/sarum9in/received_events","type":"User","site_admin":false},"body":"Co-authored-by: David Seifert <soap@gentoo.org>\r\n\r\nThis reveals a bug with `b_ndebug=if-release`. This feature was introduced in #1896 but it never worked and never was tested.\r\nCurrently `compilers.get_base_compile_args()` does not have target context, e.g. `buildtype`. The problem is `if-release` depends on target settings, particularly `buildtype`.\r\n\r\nSo the question is\r\n- Do we want `compilers.get_base_compile_args()` to be independent from target options?\r\n- Do we want to keep abstraction-breaking `if-release` at all? Probably yes because users like it. But it never worked...\r\n- Could it be that it should be `c_ndebug` option which can depend on target?","created_at":"2018-03-21T00:18:46Z","updated_at":"2018-03-21T15:05:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1c2626adcd2663b69368179e95e64361332152b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":588167272,"url":"https://api.github.com/repos/mesonbuild/meson/labels/WIP","name":"WIP","color":"000000","default":false},{"id":99546085,"url":"https://api.github.com/repos/mesonbuild/meson/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/mesonbuild/meson/milestones/25","html_url":"https://github.com/mesonbuild/meson/milestone/25","labels_url":"https://api.github.com/repos/mesonbuild/meson/milestones/25/labels","id":3163061,"number":25,"title":"0.45.1","description":null,"creator":{"login":"jpakkane","id":4079821,"avatar_url":"https://avatars3.githubusercontent.com/u/4079821?v=4","gravatar_id":"","url":"https://api.github.com/users/jpakkane","html_url":"https://github.com/jpakkane","followers_url":"https://api.github.com/users/jpakkane/followers","following_url":"https://api.github.com/users/jpakkane/following{/other_user}","gists_url":"https://api.github.com/users/jpakkane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpakkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpakkane/subscriptions","organizations_url":"https://api.github.com/users/jpakkane/orgs","repos_url":"https://api.github.com/users/jpakkane/repos","events_url":"https://api.github.com/users/jpakkane/events{/privacy}","received_events_url":"https://api.github.com/users/jpakkane/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2018-03-05T18:44:02Z","updated_at":"2018-03-21T00:35:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3274/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/3274/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/3274/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/c3d145782c49ce814c6ebd67eece9c0543d64878","head":{"label":"sarum9in:if-release","ref":"if-release","sha":"c3d145782c49ce814c6ebd67eece9c0543d64878","user":{"login":"sarum9in","id":1058248,"avatar_url":"https://avatars3.githubusercontent.com/u/1058248?v=4","gravatar_id":"","url":"https://api.github.com/users/sarum9in","html_url":"https://github.com/sarum9in","followers_url":"https://api.github.com/users/sarum9in/followers","following_url":"https://api.github.com/users/sarum9in/following{/other_user}","gists_url":"https://api.github.com/users/sarum9in/gists{/gist_id}","starred_url":"https://api.github.com/users/sarum9in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarum9in/subscriptions","organizations_url":"https://api.github.com/users/sarum9in/orgs","repos_url":"https://api.github.com/users/sarum9in/repos","events_url":"https://api.github.com/users/sarum9in/events{/privacy}","received_events_url":"https://api.github.com/users/sarum9in/received_events","type":"User","site_admin":false},"repo":{"id":118006635,"name":"meson","full_name":"sarum9in/meson","owner":{"login":"sarum9in","id":1058248,"avatar_url":"https://avatars3.githubusercontent.com/u/1058248?v=4","gravatar_id":"","url":"https://api.github.com/users/sarum9in","html_url":"https://github.com/sarum9in","followers_url":"https://api.github.com/users/sarum9in/followers","following_url":"https://api.github.com/users/sarum9in/following{/other_user}","gists_url":"https://api.github.com/users/sarum9in/gists{/gist_id}","starred_url":"https://api.github.com/users/sarum9in/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarum9in/subscriptions","organizations_url":"https://api.github.com/users/sarum9in/orgs","repos_url":"https://api.github.com/users/sarum9in/repos","events_url":"https://api.github.com/users/sarum9in/events{/privacy}","received_events_url":"https://api.github.com/users/sarum9in/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarum9in/meson","description":"The Meson Build System","fork":true,"url":"https://api.github.com/repos/sarum9in/meson","forks_url":"https://api.github.com/repos/sarum9in/meson/forks","keys_url":"https://api.github.com/repos/sarum9in/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarum9in/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarum9in/meson/teams","hooks_url":"https://api.github.com/repos/sarum9in/meson/hooks","issue_events_url":"https://api.github.com/repos/sarum9in/meson/issues/events{/number}","events_url":"https://api.github.com/repos/sarum9in/meson/events","assignees_url":"https://api.github.com/repos/sarum9in/meson/assignees{/user}","branches_url":"https://api.github.com/repos/sarum9in/meson/branches{/branch}","tags_url":"https://api.github.com/repos/sarum9in/meson/tags","blobs_url":"https://api.github.com/repos/sarum9in/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarum9in/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarum9in/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarum9in/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarum9in/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/sarum9in/meson/languages","stargazers_url":"https://api.github.com/repos/sarum9in/meson/stargazers","contributors_url":"https://api.github.com/repos/sarum9in/meson/contributors","subscribers_url":"https://api.github.com/repos/sarum9in/meson/subscribers","subscription_url":"https://api.github.com/repos/sarum9in/meson/subscription","commits_url":"https://api.github.com/repos/sarum9in/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarum9in/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarum9in/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarum9in/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarum9in/meson/contents/{+path}","compare_url":"https://api.github.com/repos/sarum9in/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarum9in/meson/merges","archive_url":"https://api.github.com/repos/sarum9in/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarum9in/meson/downloads","issues_url":"https://api.github.com/repos/sarum9in/meson/issues{/number}","pulls_url":"https://api.github.com/repos/sarum9in/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/sarum9in/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/sarum9in/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarum9in/meson/labels{/name}","releases_url":"https://api.github.com/repos/sarum9in/meson/releases{/id}","deployments_url":"https://api.github.com/repos/sarum9in/meson/deployments","created_at":"2018-01-18T16:15:05Z","updated_at":"2018-03-18T19:26:19Z","pushed_at":"2018-03-21T15:01:29Z","git_url":"git://github.com/sarum9in/meson.git","ssh_url":"git@github.com:sarum9in/meson.git","clone_url":"https://github.com/sarum9in/meson.git","svn_url":"https://github.com/sarum9in/meson","homepage":"http://mesonbuild.com","size":13663,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"dd614015e079d3ef6f64a38d349deca49b4f03ce","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars0.githubusercontent.com/u/12551236?v=4","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2018-03-21T12:33:39Z","pushed_at":"2018-03-21T15:01:31Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":"http://mesonbuild.com","size":13683,"stargazers_count":1353,"watchers_count":1353,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":352,"mirror_url":null,"archived":false,"open_issues_count":649,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":352,"open_issues":649,"watchers":1353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3274"},"html":{"href":"https://github.com/mesonbuild/meson/pull/3274"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/3274"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/3274/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3274/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/3274/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/c3d145782c49ce814c6ebd67eece9c0543d64878"}},"author_association":"OWNER"}} | {
"id": 19784232,
"name": "mesonbuild/meson",
"url": "https://api.github.com/repos/mesonbuild/meson"
} | {
"id": 1058248,
"login": "sarum9in",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1058248?",
"url": "https://api.github.com/users/sarum9in"
} | {
"id": 12551236,
"login": "mesonbuild",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12551236?",
"url": "https://api.github.com/orgs/mesonbuild"
} | 2018-03-21T15:05:03 | 7413457539 | {"actor":{"display_login":"sarum9in"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vtex-apps/shelf/pulls/comments/184201985","pull_request_review_id":115348832,"id":184201985,"diff_hunk":"@@ -98,7 +115,7 @@ class ShelfContent extends Component {\n }\n return (\n <div className={`${VTEXClasses.ITEM_EDIT_MODE} pa4`} key=\"1\">\n- <ShelfItem extentionId=\"shelfitem\" item={PLACEHOLDER_PRODUCT} />\n+ <ShelfItem extentionId=\"shelfitem\" />","path":"react/ShelfContent.js","position":128,"original_position":128,"commit_id":"b79efbcfa3e9f87c85452d9a0ed820145f1680fb","original_commit_id":"b79efbcfa3e9f87c85452d9a0ed820145f1680fb","user":{"login":"leticiawanderley","id":3407664,"avatar_url":"https://avatars2.githubusercontent.com/u/3407664?v=4","gravatar_id":"","url":"https://api.github.com/users/leticiawanderley","html_url":"https://github.com/leticiawanderley","followers_url":"https://api.github.com/users/leticiawanderley/followers","following_url":"https://api.github.com/users/leticiawanderley/following{/other_user}","gists_url":"https://api.github.com/users/leticiawanderley/gists{/gist_id}","starred_url":"https://api.github.com/users/leticiawanderley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leticiawanderley/subscriptions","organizations_url":"https://api.github.com/users/leticiawanderley/orgs","repos_url":"https://api.github.com/users/leticiawanderley/repos","events_url":"https://api.github.com/users/leticiawanderley/events{/privacy}","received_events_url":"https://api.github.com/users/leticiawanderley/received_events","type":"User","site_admin":false},"body":"Por que essa `key`?","created_at":"2018-04-25T20:52:13Z","updated_at":"2018-04-25T20:54:02Z","html_url":"https://github.com/vtex-apps/shelf/pull/33#discussion_r184201985","pull_request_url":"https://api.github.com/repos/vtex-apps/shelf/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/comments/184201985"},"html":{"href":"https://github.com/vtex-apps/shelf/pull/33#discussion_r184201985"},"pull_request":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/33"}},"in_reply_to_id":184201752},"pull_request":{"url":"https://api.github.com/repos/vtex-apps/shelf/pulls/33","id":184058945,"html_url":"https://github.com/vtex-apps/shelf/pull/33","diff_url":"https://github.com/vtex-apps/shelf/pull/33.diff","patch_url":"https://github.com/vtex-apps/shelf/pull/33.patch","issue_url":"https://api.github.com/repos/vtex-apps/shelf/issues/33","number":33,"state":"open","locked":false,"title":"Feature/dynamic items per page","user":{"login":"ClaudivanFilho","id":4960686,"avatar_url":"https://avatars2.githubusercontent.com/u/4960686?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaudivanFilho","html_url":"https://github.com/ClaudivanFilho","followers_url":"https://api.github.com/users/ClaudivanFilho/followers","following_url":"https://api.github.com/users/ClaudivanFilho/following{/other_user}","gists_url":"https://api.github.com/users/ClaudivanFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudivanFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudivanFilho/subscriptions","organizations_url":"https://api.github.com/users/ClaudivanFilho/orgs","repos_url":"https://api.github.com/users/ClaudivanFilho/repos","events_url":"https://api.github.com/users/ClaudivanFilho/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudivanFilho/received_events","type":"User","site_admin":false},"body":"#### What is the purpose of this pull request?\r\n- Adjust the `maximum number` of items inside the Shelf based on the screen resolution\r\n- Adjust shelf to adapt to any ExtensionPoint\r\n- Add default value to prop `title` in the Shelf\r\n- Change filename `theme.css` to `global.css` and import inside component\r\n- Remove `css` reference from `pages.json`\r\n- Remove PLACEHOLDER_PRODUCT\r\n\r\n#### Screenshots or example usage\r\n\r\nworkspace :arrow_forward: https://shelf-dynamic--storecomponents.myvtex.com/\r\n\r\n#### Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Requires change to documentation, which has been updated accordingly.\r\n","created_at":"2018-04-25T14:38:30Z","updated_at":"2018-04-25T20:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b5e310a7f928ca0cc758bb24f7af0e28c97bd7e","assignee":{"login":"ClaudivanFilho","id":4960686,"avatar_url":"https://avatars2.githubusercontent.com/u/4960686?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaudivanFilho","html_url":"https://github.com/ClaudivanFilho","followers_url":"https://api.github.com/users/ClaudivanFilho/followers","following_url":"https://api.github.com/users/ClaudivanFilho/following{/other_user}","gists_url":"https://api.github.com/users/ClaudivanFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudivanFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudivanFilho/subscriptions","organizations_url":"https://api.github.com/users/ClaudivanFilho/orgs","repos_url":"https://api.github.com/users/ClaudivanFilho/repos","events_url":"https://api.github.com/users/ClaudivanFilho/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudivanFilho/received_events","type":"User","site_admin":false},"assignees":[{"login":"ClaudivanFilho","id":4960686,"avatar_url":"https://avatars2.githubusercontent.com/u/4960686?v=4","gravatar_id":"","url":"https://api.github.com/users/ClaudivanFilho","html_url":"https://github.com/ClaudivanFilho","followers_url":"https://api.github.com/users/ClaudivanFilho/followers","following_url":"https://api.github.com/users/ClaudivanFilho/following{/other_user}","gists_url":"https://api.github.com/users/ClaudivanFilho/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudivanFilho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudivanFilho/subscriptions","organizations_url":"https://api.github.com/users/ClaudivanFilho/orgs","repos_url":"https://api.github.com/users/ClaudivanFilho/repos","events_url":"https://api.github.com/users/ClaudivanFilho/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudivanFilho/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andreldsa","id":2967288,"avatar_url":"https://avatars2.githubusercontent.com/u/2967288?v=4","gravatar_id":"","url":"https://api.github.com/users/andreldsa","html_url":"https://github.com/andreldsa","followers_url":"https://api.github.com/users/andreldsa/followers","following_url":"https://api.github.com/users/andreldsa/following{/other_user}","gists_url":"https://api.github.com/users/andreldsa/gists{/gist_id}","starred_url":"https://api.github.com/users/andreldsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreldsa/subscriptions","organizations_url":"https://api.github.com/users/andreldsa/orgs","repos_url":"https://api.github.com/users/andreldsa/repos","events_url":"https://api.github.com/users/andreldsa/events{/privacy}","received_events_url":"https://api.github.com/users/andreldsa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vtex-apps/shelf/pulls/33/commits","review_comments_url":"https://api.github.com/repos/vtex-apps/shelf/pulls/33/comments","review_comment_url":"https://api.github.com/repos/vtex-apps/shelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vtex-apps/shelf/issues/33/comments","statuses_url":"https://api.github.com/repos/vtex-apps/shelf/statuses/b79efbcfa3e9f87c85452d9a0ed820145f1680fb","head":{"label":"vtex-apps:feature/dynamic-items-per-page","ref":"feature/dynamic-items-per-page","sha":"b79efbcfa3e9f87c85452d9a0ed820145f1680fb","user":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars0.githubusercontent.com/u/12614072?v=4","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"repo":{"id":45184415,"name":"shelf","full_name":"vtex-apps/shelf","owner":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars0.githubusercontent.com/u/12614072?v=4","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vtex-apps/shelf","description":"VTEX Shelf app","fork":false,"url":"https://api.github.com/repos/vtex-apps/shelf","forks_url":"https://api.github.com/repos/vtex-apps/shelf/forks","keys_url":"https://api.github.com/repos/vtex-apps/shelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vtex-apps/shelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vtex-apps/shelf/teams","hooks_url":"https://api.github.com/repos/vtex-apps/shelf/hooks","issue_events_url":"https://api.github.com/repos/vtex-apps/shelf/issues/events{/number}","events_url":"https://api.github.com/repos/vtex-apps/shelf/events","assignees_url":"https://api.github.com/repos/vtex-apps/shelf/assignees{/user}","branches_url":"https://api.github.com/repos/vtex-apps/shelf/branches{/branch}","tags_url":"https://api.github.com/repos/vtex-apps/shelf/tags","blobs_url":"https://api.github.com/repos/vtex-apps/shelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vtex-apps/shelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vtex-apps/shelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/vtex-apps/shelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vtex-apps/shelf/statuses/{sha}","languages_url":"https://api.github.com/repos/vtex-apps/shelf/languages","stargazers_url":"https://api.github.com/repos/vtex-apps/shelf/stargazers","contributors_url":"https://api.github.com/repos/vtex-apps/shelf/contributors","subscribers_url":"https://api.github.com/repos/vtex-apps/shelf/subscribers","subscription_url":"https://api.github.com/repos/vtex-apps/shelf/subscription","commits_url":"https://api.github.com/repos/vtex-apps/shelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/vtex-apps/shelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/vtex-apps/shelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/vtex-apps/shelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/vtex-apps/shelf/contents/{+path}","compare_url":"https://api.github.com/repos/vtex-apps/shelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vtex-apps/shelf/merges","archive_url":"https://api.github.com/repos/vtex-apps/shelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vtex-apps/shelf/downloads","issues_url":"https://api.github.com/repos/vtex-apps/shelf/issues{/number}","pulls_url":"https://api.github.com/repos/vtex-apps/shelf/pulls{/number}","milestones_url":"https://api.github.com/repos/vtex-apps/shelf/milestones{/number}","notifications_url":"https://api.github.com/repos/vtex-apps/shelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vtex-apps/shelf/labels{/name}","releases_url":"https://api.github.com/repos/vtex-apps/shelf/releases{/id}","deployments_url":"https://api.github.com/repos/vtex-apps/shelf/deployments","created_at":"2015-10-29T13:21:47Z","updated_at":"2018-04-25T17:23:26Z","pushed_at":"2018-04-25T17:49:42Z","git_url":"git://github.com/vtex-apps/shelf.git","ssh_url":"git@github.com:vtex-apps/shelf.git","clone_url":"https://github.com/vtex-apps/shelf.git","svn_url":"https://github.com/vtex-apps/shelf","homepage":"","size":413,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"vtex-apps:master","ref":"master","sha":"f4ef5edec5500b9d5ce0c878d46eeff9e4c0f85c","user":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars0.githubusercontent.com/u/12614072?v=4","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"repo":{"id":45184415,"name":"shelf","full_name":"vtex-apps/shelf","owner":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars0.githubusercontent.com/u/12614072?v=4","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vtex-apps/shelf","description":"VTEX Shelf app","fork":false,"url":"https://api.github.com/repos/vtex-apps/shelf","forks_url":"https://api.github.com/repos/vtex-apps/shelf/forks","keys_url":"https://api.github.com/repos/vtex-apps/shelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vtex-apps/shelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vtex-apps/shelf/teams","hooks_url":"https://api.github.com/repos/vtex-apps/shelf/hooks","issue_events_url":"https://api.github.com/repos/vtex-apps/shelf/issues/events{/number}","events_url":"https://api.github.com/repos/vtex-apps/shelf/events","assignees_url":"https://api.github.com/repos/vtex-apps/shelf/assignees{/user}","branches_url":"https://api.github.com/repos/vtex-apps/shelf/branches{/branch}","tags_url":"https://api.github.com/repos/vtex-apps/shelf/tags","blobs_url":"https://api.github.com/repos/vtex-apps/shelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vtex-apps/shelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vtex-apps/shelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/vtex-apps/shelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vtex-apps/shelf/statuses/{sha}","languages_url":"https://api.github.com/repos/vtex-apps/shelf/languages","stargazers_url":"https://api.github.com/repos/vtex-apps/shelf/stargazers","contributors_url":"https://api.github.com/repos/vtex-apps/shelf/contributors","subscribers_url":"https://api.github.com/repos/vtex-apps/shelf/subscribers","subscription_url":"https://api.github.com/repos/vtex-apps/shelf/subscription","commits_url":"https://api.github.com/repos/vtex-apps/shelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/vtex-apps/shelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/vtex-apps/shelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/vtex-apps/shelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/vtex-apps/shelf/contents/{+path}","compare_url":"https://api.github.com/repos/vtex-apps/shelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vtex-apps/shelf/merges","archive_url":"https://api.github.com/repos/vtex-apps/shelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vtex-apps/shelf/downloads","issues_url":"https://api.github.com/repos/vtex-apps/shelf/issues{/number}","pulls_url":"https://api.github.com/repos/vtex-apps/shelf/pulls{/number}","milestones_url":"https://api.github.com/repos/vtex-apps/shelf/milestones{/number}","notifications_url":"https://api.github.com/repos/vtex-apps/shelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vtex-apps/shelf/labels{/name}","releases_url":"https://api.github.com/repos/vtex-apps/shelf/releases{/id}","deployments_url":"https://api.github.com/repos/vtex-apps/shelf/deployments","created_at":"2015-10-29T13:21:47Z","updated_at":"2018-04-25T17:23:26Z","pushed_at":"2018-04-25T17:49:42Z","git_url":"git://github.com/vtex-apps/shelf.git","ssh_url":"git@github.com:vtex-apps/shelf.git","clone_url":"https://github.com/vtex-apps/shelf.git","svn_url":"https://github.com/vtex-apps/shelf","homepage":"","size":413,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/33"},"html":{"href":"https://github.com/vtex-apps/shelf/pull/33"},"issue":{"href":"https://api.github.com/repos/vtex-apps/shelf/issues/33"},"comments":{"href":"https://api.github.com/repos/vtex-apps/shelf/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vtex-apps/shelf/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/vtex-apps/shelf/statuses/b79efbcfa3e9f87c85452d9a0ed820145f1680fb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 45184415,
"name": "vtex-apps/shelf",
"url": "https://api.github.com/repos/vtex-apps/shelf"
} | {
"id": 3407664,
"login": "leticiawanderley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3407664?",
"url": "https://api.github.com/users/leticiawanderley"
} | {
"id": 12614072,
"login": "vtex-apps",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12614072?",
"url": "https://api.github.com/orgs/vtex-apps"
} | 2018-04-25T20:52:13 | 7587465537 | {"actor":{"display_login":"leticiawanderley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/decentraland/marketplace/pulls/comments/221027479","pull_request_review_id":159577865,"id":221027479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTAyNzQ3OQ==","diff_hunk":"@@ -46,72 +38,54 @@ export default class SettingsPage extends React.PureComponent {\n }\n }\n \n- handleMortgageForManaApproval = (event, data) => {\n- const manaToApprove = data.checked ? getManaToApprove() : 0\n- this.props.onAuthorizeMortgageForMana(manaToApprove)\n+ handleTokenAllowance = (checked, contractName, tokenContractName) => {\n+ const amount = checked ? getTokenAmountToApprove() : 0\n+ this.props.onAllowToken(amount, contractName, tokenContractName)\n }\n \n- handleMortgageForRCNApproval = (event, data) => {\n- const rcnToApprove = data.checked ? getRCNToApprove() : 0\n- this.props.onAuthorizeMortgageForRCN(rcnToApprove)\n+ handleTokenApproval = (checked, contractName, tokenContractName) => {\n+ this.props.onApproveToken(checked, contractName, tokenContractName)\n }\n \n- getApproveTransaction() {\n- // Transactions are ordered, the last one corresponds to the last sent\n- const { approveManaTransactions } = this.props.wallet\n- return approveManaTransactions[approveManaTransactions.length - 1]\n- }\n+ getPendingTransactions() {\n+ const { allowTransactions, approveTransactions } = this.props\n+ const isPending = transaction =>\n+ transaction.status === txUtils.TRANSACTION_STATUS.pending","path":"webapp/src/components/SettingsPage/SettingsPage.js","position":80,"original_position":80,"commit_id":"0e0f1c606ed566c9c47012dab53ac12669404ddf","original_commit_id":"0e0f1c606ed566c9c47012dab53ac12669404ddf","user":{"login":"cazala","id":2781777,"node_id":"MDQ6VXNlcjI3ODE3Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2781777?v=4","gravatar_id":"","url":"https://api.github.com/users/cazala","html_url":"https://github.com/cazala","followers_url":"https://api.github.com/users/cazala/followers","following_url":"https://api.github.com/users/cazala/following{/other_user}","gists_url":"https://api.github.com/users/cazala/gists{/gist_id}","starred_url":"https://api.github.com/users/cazala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cazala/subscriptions","organizations_url":"https://api.github.com/users/cazala/orgs","repos_url":"https://api.github.com/users/cazala/repos","events_url":"https://api.github.com/users/cazala/events{/privacy}","received_events_url":"https://api.github.com/users/cazala/received_events","type":"User","site_admin":false},"body":"you should use `isPending(transaction.status)` from `@dapps/modules/transaction/utils` which handles also `null` and `queued` transaction status (which are \"pending\")","created_at":"2018-09-27T18:20:20Z","updated_at":"2018-09-27T18:20:28Z","html_url":"https://github.com/decentraland/marketplace/pull/484#discussion_r221027479","pull_request_url":"https://api.github.com/repos/decentraland/marketplace/pulls/484","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/comments/221027479"},"html":{"href":"https://github.com/decentraland/marketplace/pull/484#discussion_r221027479"},"pull_request":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/decentraland/marketplace/pulls/484","id":218054104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDU0MTA0","html_url":"https://github.com/decentraland/marketplace/pull/484","diff_url":"https://github.com/decentraland/marketplace/pull/484.diff","patch_url":"https://github.com/decentraland/marketplace/pull/484.patch","issue_url":"https://api.github.com/repos/decentraland/marketplace/issues/484","number":484,"state":"open","locked":false,"title":"feat: mkt v2 authorization","user":{"login":"NicoSantangelo","id":692077,"node_id":"MDQ6VXNlcjY5MjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/692077?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoSantangelo","html_url":"https://github.com/NicoSantangelo","followers_url":"https://api.github.com/users/NicoSantangelo/followers","following_url":"https://api.github.com/users/NicoSantangelo/following{/other_user}","gists_url":"https://api.github.com/users/NicoSantangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoSantangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoSantangelo/subscriptions","organizations_url":"https://api.github.com/users/NicoSantangelo/orgs","repos_url":"https://api.github.com/users/NicoSantangelo/repos","events_url":"https://api.github.com/users/NicoSantangelo/events{/privacy}","received_events_url":"https://api.github.com/users/NicoSantangelo/received_events","type":"User","site_admin":false},"body":"## Important\r\n\r\nDepends on PR on decentraland-eth https://github.com/decentraland/decentraland-eth/pull/37\r\n\r\nStill lacking better copies explaining what's going on, specially on the settings page, but we can update that later I suppose\r\n\r\nI left some questions on the code.\r\n\r\nThe authorization module can be easily extracted to decentraland-dapps\r\n\r\nCloses #344 ","created_at":"2018-09-25T17:06:10Z","updated_at":"2018-09-27T18:20:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cc6a7763687f857065450e02c3e0fd629ee8f78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decentraland/marketplace/pulls/484/commits","review_comments_url":"https://api.github.com/repos/decentraland/marketplace/pulls/484/comments","review_comment_url":"https://api.github.com/repos/decentraland/marketplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decentraland/marketplace/issues/484/comments","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/0e0f1c606ed566c9c47012dab53ac12669404ddf","head":{"label":"decentraland:feat/mkt-v2-authorization","ref":"feat/mkt-v2-authorization","sha":"0e0f1c606ed566c9c47012dab53ac12669404ddf","user":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":115438139,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MzgxMzk=","name":"marketplace","full_name":"decentraland/marketplace","private":false,"owner":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentraland/marketplace","description":"🏛️ Decentraland's LAND Marketplace","fork":false,"url":"https://api.github.com/repos/decentraland/marketplace","forks_url":"https://api.github.com/repos/decentraland/marketplace/forks","keys_url":"https://api.github.com/repos/decentraland/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/marketplace/teams","hooks_url":"https://api.github.com/repos/decentraland/marketplace/hooks","issue_events_url":"https://api.github.com/repos/decentraland/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/marketplace/events","assignees_url":"https://api.github.com/repos/decentraland/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/marketplace/tags","blobs_url":"https://api.github.com/repos/decentraland/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/marketplace/languages","stargazers_url":"https://api.github.com/repos/decentraland/marketplace/stargazers","contributors_url":"https://api.github.com/repos/decentraland/marketplace/contributors","subscribers_url":"https://api.github.com/repos/decentraland/marketplace/subscribers","subscription_url":"https://api.github.com/repos/decentraland/marketplace/subscription","commits_url":"https://api.github.com/repos/decentraland/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/marketplace/merges","archive_url":"https://api.github.com/repos/decentraland/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/marketplace/downloads","issues_url":"https://api.github.com/repos/decentraland/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/marketplace/deployments","created_at":"2017-12-26T16:31:44Z","updated_at":"2018-09-27T17:56:14Z","pushed_at":"2018-09-27T18:19:23Z","git_url":"git://github.com/decentraland/marketplace.git","ssh_url":"git@github.com:decentraland/marketplace.git","clone_url":"https://github.com/decentraland/marketplace.git","svn_url":"https://github.com/decentraland/marketplace","homepage":"https://market.decentraland.org","size":8566,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":47,"watchers":70,"default_branch":"master"}},"base":{"label":"decentraland:master","ref":"master","sha":"6a759c30be24df02987ca430d6a5f9774132ef60","user":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":115438139,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MzgxMzk=","name":"marketplace","full_name":"decentraland/marketplace","private":false,"owner":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentraland/marketplace","description":"🏛️ Decentraland's LAND Marketplace","fork":false,"url":"https://api.github.com/repos/decentraland/marketplace","forks_url":"https://api.github.com/repos/decentraland/marketplace/forks","keys_url":"https://api.github.com/repos/decentraland/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/marketplace/teams","hooks_url":"https://api.github.com/repos/decentraland/marketplace/hooks","issue_events_url":"https://api.github.com/repos/decentraland/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/marketplace/events","assignees_url":"https://api.github.com/repos/decentraland/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/marketplace/tags","blobs_url":"https://api.github.com/repos/decentraland/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/marketplace/languages","stargazers_url":"https://api.github.com/repos/decentraland/marketplace/stargazers","contributors_url":"https://api.github.com/repos/decentraland/marketplace/contributors","subscribers_url":"https://api.github.com/repos/decentraland/marketplace/subscribers","subscription_url":"https://api.github.com/repos/decentraland/marketplace/subscription","commits_url":"https://api.github.com/repos/decentraland/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/marketplace/merges","archive_url":"https://api.github.com/repos/decentraland/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/marketplace/downloads","issues_url":"https://api.github.com/repos/decentraland/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/marketplace/deployments","created_at":"2017-12-26T16:31:44Z","updated_at":"2018-09-27T17:56:14Z","pushed_at":"2018-09-27T18:19:23Z","git_url":"git://github.com/decentraland/marketplace.git","ssh_url":"git@github.com:decentraland/marketplace.git","clone_url":"https://github.com/decentraland/marketplace.git","svn_url":"https://github.com/decentraland/marketplace","homepage":"https://market.decentraland.org","size":8566,"stargazers_count":70,"watchers_count":70,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":47,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/484"},"html":{"href":"https://github.com/decentraland/marketplace/pull/484"},"issue":{"href":"https://api.github.com/repos/decentraland/marketplace/issues/484"},"comments":{"href":"https://api.github.com/repos/decentraland/marketplace/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/decentraland/marketplace/statuses/0e0f1c606ed566c9c47012dab53ac12669404ddf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 115438139,
"name": "decentraland/marketplace",
"url": "https://api.github.com/repos/decentraland/marketplace"
} | {
"id": 2781777,
"login": "cazala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2781777?",
"url": "https://api.github.com/users/cazala"
} | {
"id": 12685795,
"login": "decentraland",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12685795?",
"url": "https://api.github.com/orgs/decentraland"
} | 2018-09-27T18:20:20 | 8333554325 | {"actor":{"display_login":"cazala"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/radcli/radcli/pulls/comments/210716800","pull_request_review_id":146992966,"id":210716800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDcxNjgwMA==","diff_hunk":"@@ -1,5 +1,6 @@\n FROM fedora:21\n \n+RUN yum install -y yum-plugin-ovl","path":"tests/docker/Dockerfile-radius","position":3,"original_position":3,"commit_id":"845ee83bb6be0646d01364da37575752c8230aae","original_commit_id":"845ee83bb6be0646d01364da37575752c8230aae","user":{"login":"nmav","id":1745073,"node_id":"MDQ6VXNlcjE3NDUwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1745073?v=4","gravatar_id":"","url":"https://api.github.com/users/nmav","html_url":"https://github.com/nmav","followers_url":"https://api.github.com/users/nmav/followers","following_url":"https://api.github.com/users/nmav/following{/other_user}","gists_url":"https://api.github.com/users/nmav/gists{/gist_id}","starred_url":"https://api.github.com/users/nmav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmav/subscriptions","organizations_url":"https://api.github.com/users/nmav/orgs","repos_url":"https://api.github.com/users/nmav/repos","events_url":"https://api.github.com/users/nmav/events{/privacy}","received_events_url":"https://api.github.com/users/nmav/received_events","type":"User","site_admin":false},"body":"what is the problem this change is solving?","created_at":"2018-08-16T19:35:57Z","updated_at":"2018-08-16T19:35:57Z","html_url":"https://github.com/radcli/radcli/pull/45#discussion_r210716800","pull_request_url":"https://api.github.com/repos/radcli/radcli/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/radcli/radcli/pulls/comments/210716800"},"html":{"href":"https://github.com/radcli/radcli/pull/45#discussion_r210716800"},"pull_request":{"href":"https://api.github.com/repos/radcli/radcli/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/radcli/radcli/pulls/45","id":207758885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzU4ODg1","html_url":"https://github.com/radcli/radcli/pull/45","diff_url":"https://github.com/radcli/radcli/pull/45.diff","patch_url":"https://github.com/radcli/radcli/pull/45.patch","issue_url":"https://api.github.com/repos/radcli/radcli/issues/45","number":45,"state":"open","locked":false,"title":"Fix Docker build issue [RDY]","user":{"login":"aravindprasad90","id":6022784,"node_id":"MDQ6VXNlcjYwMjI3ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6022784?v=4","gravatar_id":"","url":"https://api.github.com/users/aravindprasad90","html_url":"https://github.com/aravindprasad90","followers_url":"https://api.github.com/users/aravindprasad90/followers","following_url":"https://api.github.com/users/aravindprasad90/following{/other_user}","gists_url":"https://api.github.com/users/aravindprasad90/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindprasad90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindprasad90/subscriptions","organizations_url":"https://api.github.com/users/aravindprasad90/orgs","repos_url":"https://api.github.com/users/aravindprasad90/repos","events_url":"https://api.github.com/users/aravindprasad90/events{/privacy}","received_events_url":"https://api.github.com/users/aravindprasad90/received_events","type":"User","site_admin":false},"body":"1) Fix for issue - https://github.com/radcli/radcli/issues/46 \r\n \r\nDescription:\r\n\"yum install -y yum-plugin-ovl\" was needed in Docker file for the build to pass.\r\n\r\nfrom MAN page:\r\nOpening a file on OverlayFS in read-only mode causes the file from\r\n lower layer to be opened, then later on, if the same file is opened\r\n in write mode, a copy-up into the upper layer takes place,\r\n resulting into a new file being opened.\r\n Since yum(8) needs to open the RPMdb first read-only, and then\r\n also with write access, we need to copy-up the files beforehand to\r\n make sure that the access is consistent.\r\n\r\n2) Cleanup of run-server.sh file to display the Server IP and command to run the tests","created_at":"2018-08-11T05:27:19Z","updated_at":"2018-08-16T19:35:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4bb3ec7ab13512b5d2d31b4119d23e8bb82d0cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radcli/radcli/pulls/45/commits","review_comments_url":"https://api.github.com/repos/radcli/radcli/pulls/45/comments","review_comment_url":"https://api.github.com/repos/radcli/radcli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radcli/radcli/issues/45/comments","statuses_url":"https://api.github.com/repos/radcli/radcli/statuses/845ee83bb6be0646d01364da37575752c8230aae","head":{"label":"aravindprasad90:fix-docker-build","ref":"fix-docker-build","sha":"845ee83bb6be0646d01364da37575752c8230aae","user":{"login":"aravindprasad90","id":6022784,"node_id":"MDQ6VXNlcjYwMjI3ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6022784?v=4","gravatar_id":"","url":"https://api.github.com/users/aravindprasad90","html_url":"https://github.com/aravindprasad90","followers_url":"https://api.github.com/users/aravindprasad90/followers","following_url":"https://api.github.com/users/aravindprasad90/following{/other_user}","gists_url":"https://api.github.com/users/aravindprasad90/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindprasad90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindprasad90/subscriptions","organizations_url":"https://api.github.com/users/aravindprasad90/orgs","repos_url":"https://api.github.com/users/aravindprasad90/repos","events_url":"https://api.github.com/users/aravindprasad90/events{/privacy}","received_events_url":"https://api.github.com/users/aravindprasad90/received_events","type":"User","site_admin":false},"repo":{"id":144269825,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyNjk4MjU=","name":"radcli","full_name":"aravindprasad90/radcli","owner":{"login":"aravindprasad90","id":6022784,"node_id":"MDQ6VXNlcjYwMjI3ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6022784?v=4","gravatar_id":"","url":"https://api.github.com/users/aravindprasad90","html_url":"https://github.com/aravindprasad90","followers_url":"https://api.github.com/users/aravindprasad90/followers","following_url":"https://api.github.com/users/aravindprasad90/following{/other_user}","gists_url":"https://api.github.com/users/aravindprasad90/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindprasad90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindprasad90/subscriptions","organizations_url":"https://api.github.com/users/aravindprasad90/orgs","repos_url":"https://api.github.com/users/aravindprasad90/repos","events_url":"https://api.github.com/users/aravindprasad90/events{/privacy}","received_events_url":"https://api.github.com/users/aravindprasad90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aravindprasad90/radcli","description":"A simple RADIUS client library http://radcli.github.io/radcli/","fork":true,"url":"https://api.github.com/repos/aravindprasad90/radcli","forks_url":"https://api.github.com/repos/aravindprasad90/radcli/forks","keys_url":"https://api.github.com/repos/aravindprasad90/radcli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aravindprasad90/radcli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aravindprasad90/radcli/teams","hooks_url":"https://api.github.com/repos/aravindprasad90/radcli/hooks","issue_events_url":"https://api.github.com/repos/aravindprasad90/radcli/issues/events{/number}","events_url":"https://api.github.com/repos/aravindprasad90/radcli/events","assignees_url":"https://api.github.com/repos/aravindprasad90/radcli/assignees{/user}","branches_url":"https://api.github.com/repos/aravindprasad90/radcli/branches{/branch}","tags_url":"https://api.github.com/repos/aravindprasad90/radcli/tags","blobs_url":"https://api.github.com/repos/aravindprasad90/radcli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aravindprasad90/radcli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aravindprasad90/radcli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aravindprasad90/radcli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aravindprasad90/radcli/statuses/{sha}","languages_url":"https://api.github.com/repos/aravindprasad90/radcli/languages","stargazers_url":"https://api.github.com/repos/aravindprasad90/radcli/stargazers","contributors_url":"https://api.github.com/repos/aravindprasad90/radcli/contributors","subscribers_url":"https://api.github.com/repos/aravindprasad90/radcli/subscribers","subscription_url":"https://api.github.com/repos/aravindprasad90/radcli/subscription","commits_url":"https://api.github.com/repos/aravindprasad90/radcli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aravindprasad90/radcli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aravindprasad90/radcli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aravindprasad90/radcli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aravindprasad90/radcli/contents/{+path}","compare_url":"https://api.github.com/repos/aravindprasad90/radcli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aravindprasad90/radcli/merges","archive_url":"https://api.github.com/repos/aravindprasad90/radcli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aravindprasad90/radcli/downloads","issues_url":"https://api.github.com/repos/aravindprasad90/radcli/issues{/number}","pulls_url":"https://api.github.com/repos/aravindprasad90/radcli/pulls{/number}","milestones_url":"https://api.github.com/repos/aravindprasad90/radcli/milestones{/number}","notifications_url":"https://api.github.com/repos/aravindprasad90/radcli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aravindprasad90/radcli/labels{/name}","releases_url":"https://api.github.com/repos/aravindprasad90/radcli/releases{/id}","deployments_url":"https://api.github.com/repos/aravindprasad90/radcli/deployments","created_at":"2018-08-10T10:00:08Z","updated_at":"2018-08-10T10:00:10Z","pushed_at":"2018-08-13T06:26:10Z","git_url":"git://github.com/aravindprasad90/radcli.git","ssh_url":"git@github.com:aravindprasad90/radcli.git","clone_url":"https://github.com/aravindprasad90/radcli.git","svn_url":"https://github.com/aravindprasad90/radcli","homepage":null,"size":2113,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radcli:master","ref":"master","sha":"abaa828587f74088a68a29ffbe79cd144e02c7e7","user":{"login":"radcli","id":12768625,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY4NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/12768625?v=4","gravatar_id":"","url":"https://api.github.com/users/radcli","html_url":"https://github.com/radcli","followers_url":"https://api.github.com/users/radcli/followers","following_url":"https://api.github.com/users/radcli/following{/other_user}","gists_url":"https://api.github.com/users/radcli/gists{/gist_id}","starred_url":"https://api.github.com/users/radcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radcli/subscriptions","organizations_url":"https://api.github.com/users/radcli/orgs","repos_url":"https://api.github.com/users/radcli/repos","events_url":"https://api.github.com/users/radcli/events{/privacy}","received_events_url":"https://api.github.com/users/radcli/received_events","type":"Organization","site_admin":false},"repo":{"id":46615396,"node_id":"MDEwOlJlcG9zaXRvcnk0NjYxNTM5Ng==","name":"radcli","full_name":"radcli/radcli","owner":{"login":"radcli","id":12768625,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzY4NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/12768625?v=4","gravatar_id":"","url":"https://api.github.com/users/radcli","html_url":"https://github.com/radcli","followers_url":"https://api.github.com/users/radcli/followers","following_url":"https://api.github.com/users/radcli/following{/other_user}","gists_url":"https://api.github.com/users/radcli/gists{/gist_id}","starred_url":"https://api.github.com/users/radcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radcli/subscriptions","organizations_url":"https://api.github.com/users/radcli/orgs","repos_url":"https://api.github.com/users/radcli/repos","events_url":"https://api.github.com/users/radcli/events{/privacy}","received_events_url":"https://api.github.com/users/radcli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/radcli/radcli","description":"A simple RADIUS client library http://radcli.github.io/radcli/","fork":false,"url":"https://api.github.com/repos/radcli/radcli","forks_url":"https://api.github.com/repos/radcli/radcli/forks","keys_url":"https://api.github.com/repos/radcli/radcli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radcli/radcli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radcli/radcli/teams","hooks_url":"https://api.github.com/repos/radcli/radcli/hooks","issue_events_url":"https://api.github.com/repos/radcli/radcli/issues/events{/number}","events_url":"https://api.github.com/repos/radcli/radcli/events","assignees_url":"https://api.github.com/repos/radcli/radcli/assignees{/user}","branches_url":"https://api.github.com/repos/radcli/radcli/branches{/branch}","tags_url":"https://api.github.com/repos/radcli/radcli/tags","blobs_url":"https://api.github.com/repos/radcli/radcli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radcli/radcli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radcli/radcli/git/refs{/sha}","trees_url":"https://api.github.com/repos/radcli/radcli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radcli/radcli/statuses/{sha}","languages_url":"https://api.github.com/repos/radcli/radcli/languages","stargazers_url":"https://api.github.com/repos/radcli/radcli/stargazers","contributors_url":"https://api.github.com/repos/radcli/radcli/contributors","subscribers_url":"https://api.github.com/repos/radcli/radcli/subscribers","subscription_url":"https://api.github.com/repos/radcli/radcli/subscription","commits_url":"https://api.github.com/repos/radcli/radcli/commits{/sha}","git_commits_url":"https://api.github.com/repos/radcli/radcli/git/commits{/sha}","comments_url":"https://api.github.com/repos/radcli/radcli/comments{/number}","issue_comment_url":"https://api.github.com/repos/radcli/radcli/issues/comments{/number}","contents_url":"https://api.github.com/repos/radcli/radcli/contents/{+path}","compare_url":"https://api.github.com/repos/radcli/radcli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radcli/radcli/merges","archive_url":"https://api.github.com/repos/radcli/radcli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radcli/radcli/downloads","issues_url":"https://api.github.com/repos/radcli/radcli/issues{/number}","pulls_url":"https://api.github.com/repos/radcli/radcli/pulls{/number}","milestones_url":"https://api.github.com/repos/radcli/radcli/milestones{/number}","notifications_url":"https://api.github.com/repos/radcli/radcli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radcli/radcli/labels{/name}","releases_url":"https://api.github.com/repos/radcli/radcli/releases{/id}","deployments_url":"https://api.github.com/repos/radcli/radcli/deployments","created_at":"2015-11-21T12:59:00Z","updated_at":"2018-08-08T12:25:25Z","pushed_at":"2018-08-13T06:26:11Z","git_url":"git://github.com/radcli/radcli.git","ssh_url":"git@github.com:radcli/radcli.git","clone_url":"https://github.com/radcli/radcli.git","svn_url":"https://github.com/radcli/radcli","homepage":null,"size":2108,"stargazers_count":21,"watchers_count":21,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":4,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radcli/radcli/pulls/45"},"html":{"href":"https://github.com/radcli/radcli/pull/45"},"issue":{"href":"https://api.github.com/repos/radcli/radcli/issues/45"},"comments":{"href":"https://api.github.com/repos/radcli/radcli/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/radcli/radcli/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/radcli/radcli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radcli/radcli/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/radcli/radcli/statuses/845ee83bb6be0646d01364da37575752c8230aae"}},"author_association":"CONTRIBUTOR"}} | {
"id": 46615396,
"name": "radcli/radcli",
"url": "https://api.github.com/repos/radcli/radcli"
} | {
"id": 1745073,
"login": "nmav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1745073?",
"url": "https://api.github.com/users/nmav"
} | {
"id": 12768625,
"login": "radcli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12768625?",
"url": "https://api.github.com/orgs/radcli"
} | 2018-08-16T19:35:57 | 8125048515 | {"actor":{"display_login":"nmav"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/money/pulls/comments/225114832","pull_request_review_id":164641593,"id":225114832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTExNDgzMg==","diff_hunk":"@@ -0,0 +1,990 @@\n+//\n+// Copyright 2018, TeamDev. All rights reserved.\n+//\n+// Redistribution and use in source and/or binary forms, with or without\n+// modification, must retain the above copyright notice and the following\n+// disclaimer.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+// \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+//\n+syntax = \"proto3\";\n+\n+package spine.money;\n+\n+import \"spine/options.proto\";\n+\n+option (type_url_prefix) = \"type.spine.io\";\n+option java_multiple_files = true;\n+option java_outer_classname = \"MoneyProto\";\n+option java_package = \"io.spine.money\";\n+\n+option (experimental_all) = true;\n+\n+import \"google/protobuf/descriptor.proto\";\n+\n+//\n+// The `Money` type below is modeled after one defined in Google APIs.\n+// For the original code see:\n+// https://raw.githubusercontent.com/googleapis/googleapis/master/google/type/money.proto)\n+// But in our type we use enumeration instead of a string currency code to provide more information\n+// about currencies for UI-related code.\n+//\n+\n+// An amount of money in its currency type.\n+message Money {\n+ // The currency of the amount of money.\n+ Currency currency = 1 [(required) = true];\n+\n+ // The whole units of the amount.\n+ //\n+ // For example, if `currency` is `EUR`, then 1 unit is one euro.\n+ int64 units = 2;\n+\n+ // Number of nano (10^-9) units of the amount.\n+ //\n+ // The value must be between -999,999,999 and +999,999,999 inclusive.\n+ // If `units` is positive, `nanos` must be positive or zero.\n+ // If `units` is zero, `nanos` can be positive, zero, or negative.\n+ // If `units` is negative, `nanos` must be negative or zero.\n+ // For example $-1.75 is represented as `units`=-1 and `nanos`=-750,000,000.\n+ int32 nanos = 3;\n+}\n+\n+// The ISO 4217 currency attributes (unless specifically noted).\n+message CurrencyOptions {\n+ // The name of the currency, e.g. \"US dollar\".\n+ string name = 1;\n+\n+ // The symbol of the currency, e.g. \"$\".\n+ // NOTE: ISO 4217 does not define any currency symbols.\n+ string symbol = 2;\n+\n+ // The numeric code of the currency.\n+ int32 numeric_code = 3;\n+\n+ // The number of digits after the decimal separator.\n+ // The value is less than zero if there are no minor units for this currency (e.g., for gold).\n+ // See ISO 4217 \"exponent\" definition for details.\n+ int32 exponent_digits = 4;\n+}\n+\n+extend google.protobuf.EnumValueOptions {\n+ // 1025 is globally unique field number obtained from Google. Do not change it.\n+ CurrencyOptions currency = 1025;\n+}\n+\n+// The set of ISO 4217 currency alphabetic codes with other currency options (such as\n+// currency name, numeric code etc).\n+// NOTE: numeric codes must consist of 3 digits when displayed (e.g., \"008\", \"050\" etc).\n+enum Currency {\n+ CURRENCY_UNDEFINED = 0;\n+ AED = 1 [(currency) = {\n+ name: \"UAE Dirham\",\n+ symbol: \"د.إ\",\n+ numeric_code: 784,\n+ exponent_digits: 2 }];\n+ AFN = 2 [(currency) = {\n+ name: \"Afghani\",\n+ symbol: \"؋\",\n+ numeric_code: 971,\n+ exponent_digits: 2 }];\n+ ALL = 3 [(currency) = {\n+ name: \"Lek\",\n+ symbol: \"Lek\",\n+ numeric_code: 8,\n+ exponent_digits: 2 }];\n+ AMD = 4 [(currency) = {\n+ name: \"Armenian Dram\",\n+ symbol: \"֏\",\n+ numeric_code: 51,\n+ exponent_digits: 2 }];\n+ ANG = 5 [(currency) = {\n+ name: \"Netherlands Antillean Guilder\",\n+ symbol: \"ƒ\",\n+ numeric_code: 532,\n+ exponent_digits: 2 }];\n+ AOA = 6 [(currency) = {\n+ name: \"Kwanza\",\n+ symbol: \"Kz\",\n+ numeric_code: 973,\n+\t\texponent_digits: 2 }];\n+ ARS = 7 [(currency) = {\n+ name: \"Argentine Peso\",\n+ symbol: \"$\",\n+ numeric_code: 32,\n+\t\texponent_digits: 2 }];","path":"money/src/main/proto/spine/money/money.proto","position":125,"original_position":125,"commit_id":"5e570b2eccc4bd2319a72306c03c83b42ef91826","original_commit_id":"d634ad5b5e0b8b2c7a86955aa8afa6f9a0001945","user":{"login":"armiol","id":82468,"node_id":"MDQ6VXNlcjgyNDY4","avatar_url":"https://avatars0.githubusercontent.com/u/82468?v=4","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false},"body":"Some weird formatting here and there. I think the idea was to indent `numeric_code` and `exponent_digits` additionally to improve readability. But that's not done for all enumeration members.","created_at":"2018-10-15T10:32:20Z","updated_at":"2018-10-15T10:34:17Z","html_url":"https://github.com/SpineEventEngine/money/pull/1#discussion_r225114832","pull_request_url":"https://api.github.com/repos/SpineEventEngine/money/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/comments/225114832"},"html":{"href":"https://github.com/SpineEventEngine/money/pull/1#discussion_r225114832"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/money/pulls/1","id":222745199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQ1MTk5","html_url":"https://github.com/SpineEventEngine/money/pull/1","diff_url":"https://github.com/SpineEventEngine/money/pull/1.diff","patch_url":"https://github.com/SpineEventEngine/money/pull/1.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/money/issues/1","number":1,"state":"open","locked":false,"title":"Initial config","user":{"login":"alexander-yevsyukov","id":3116444,"node_id":"MDQ6VXNlcjMxMTY0NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3116444?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false},"body":"This PR configures the project and adds the proto and Java code moved from `base`.\r\n\r\n","created_at":"2018-10-14T21:43:24Z","updated_at":"2018-10-15T10:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60d89882be6e765aa9883ad7866809a443e0b9ac","assignee":{"login":"alexander-yevsyukov","id":3116444,"node_id":"MDQ6VXNlcjMxMTY0NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3116444?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexander-yevsyukov","id":3116444,"node_id":"MDQ6VXNlcjMxMTY0NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3116444?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-yevsyukov","html_url":"https://github.com/alexander-yevsyukov","followers_url":"https://api.github.com/users/alexander-yevsyukov/followers","following_url":"https://api.github.com/users/alexander-yevsyukov/following{/other_user}","gists_url":"https://api.github.com/users/alexander-yevsyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-yevsyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-yevsyukov/subscriptions","organizations_url":"https://api.github.com/users/alexander-yevsyukov/orgs","repos_url":"https://api.github.com/users/alexander-yevsyukov/repos","events_url":"https://api.github.com/users/alexander-yevsyukov/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-yevsyukov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/money/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/money/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/money/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/money/issues/1/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/money/statuses/5e570b2eccc4bd2319a72306c03c83b42ef91826","head":{"label":"SpineEventEngine:initial-config","ref":"initial-config","sha":"5e570b2eccc4bd2319a72306c03c83b42ef91826","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":152783527,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3ODM1Mjc=","name":"money","full_name":"SpineEventEngine/money","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/money","description":"Currency and money data types and operations","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/money","forks_url":"https://api.github.com/repos/SpineEventEngine/money/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/money/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/money/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/money/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/money/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/money/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/money/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/money/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/money/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/money/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/money/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/money/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/money/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/money/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/money/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/money/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/money/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/money/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/money/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/money/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/money/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/money/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/money/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/money/deployments","created_at":"2018-10-12T17:09:27Z","updated_at":"2018-10-12T17:09:30Z","pushed_at":"2018-10-15T10:32:50Z","git_url":"git://github.com/SpineEventEngine/money.git","ssh_url":"git@github.com:SpineEventEngine/money.git","clone_url":"https://github.com/SpineEventEngine/money.git","svn_url":"https://github.com/SpineEventEngine/money","homepage":null,"size":108,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"SpineEventEngine:master","ref":"master","sha":"73d805299781ca447424c5bb84ff1696bf604bbd","user":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":152783527,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3ODM1Mjc=","name":"money","full_name":"SpineEventEngine/money","private":false,"owner":{"login":"SpineEventEngine","id":12821626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIxNjI2","avatar_url":"https://avatars3.githubusercontent.com/u/12821626?v=4","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpineEventEngine/money","description":"Currency and money data types and operations","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/money","forks_url":"https://api.github.com/repos/SpineEventEngine/money/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/money/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/money/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/money/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/money/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/money/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/money/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/money/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/money/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/money/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/money/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/money/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/money/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/money/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/money/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/money/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/money/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/money/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/money/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/money/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/money/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/money/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/money/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/money/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/money/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/money/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/money/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/money/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/money/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/money/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/money/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/money/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/money/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/money/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/money/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/money/deployments","created_at":"2018-10-12T17:09:27Z","updated_at":"2018-10-12T17:09:30Z","pushed_at":"2018-10-15T10:32:50Z","git_url":"git://github.com/SpineEventEngine/money.git","ssh_url":"git@github.com:SpineEventEngine/money.git","clone_url":"https://github.com/SpineEventEngine/money.git","svn_url":"https://github.com/SpineEventEngine/money","homepage":null,"size":108,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/1"},"html":{"href":"https://github.com/SpineEventEngine/money/pull/1"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/money/issues/1"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/money/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/money/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/money/statuses/5e570b2eccc4bd2319a72306c03c83b42ef91826"}},"author_association":"CONTRIBUTOR"}} | {
"id": 152783527,
"name": "SpineEventEngine/money",
"url": "https://api.github.com/repos/SpineEventEngine/money"
} | {
"id": 82468,
"login": "armiol",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/82468?",
"url": "https://api.github.com/users/armiol"
} | {
"id": 12821626,
"login": "SpineEventEngine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12821626?",
"url": "https://api.github.com/orgs/SpineEventEngine"
} | 2018-10-15T10:32:20 | 8420617685 | {"actor":{"display_login":"armiol"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/206906972","pull_request_review_id":142405661,"id":206906972,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkwNjk3Mg==","diff_hunk":"@@ -70,6 +70,8 @@ verifyToil pm bvd lockedAssets curEpoch verifyAllIsKnown =\n \n -- | Apply transactions from one block. They must be valid (for\n -- example, it implies topological sort).\n+\n+","path":"chain/src/Pos/Chain/Txp/Toil/Logic.hs","position":5,"original_position":5,"commit_id":"a226166504f17bb0be3c0529f1613e963e52974f","original_commit_id":"e5d6a1b2991a7fa8e52887c22c0d003d043a7294","user":{"login":"parsonsmatt","id":7310112,"node_id":"MDQ6VXNlcjczMTAxMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7310112?v=4","gravatar_id":"","url":"https://api.github.com/users/parsonsmatt","html_url":"https://github.com/parsonsmatt","followers_url":"https://api.github.com/users/parsonsmatt/followers","following_url":"https://api.github.com/users/parsonsmatt/following{/other_user}","gists_url":"https://api.github.com/users/parsonsmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/parsonsmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parsonsmatt/subscriptions","organizations_url":"https://api.github.com/users/parsonsmatt/orgs","repos_url":"https://api.github.com/users/parsonsmatt/repos","events_url":"https://api.github.com/users/parsonsmatt/events{/privacy}","received_events_url":"https://api.github.com/users/parsonsmatt/received_events","type":"User","site_admin":false},"body":"dead space","created_at":"2018-08-01T14:41:10Z","updated_at":"2018-08-01T14:59:53Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3332#discussion_r206906972","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/206906972"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/3332#discussion_r206906972"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332","id":205222835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjIyODM1","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3332","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3332.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3332.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3332","number":3332,"state":"open","locked":false,"title":"[CBR-97] structured logging","user":{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR introduces `katip` as the new logging library, a framework for structured logging (JSON structures). In a first step, we bring in this new library and clean all code from references to the old one. Unfortunately, this translates to changes all over the codebase.\r\n\r\n* introduce `katip` library for logging\r\n* provide compatible interface\r\n* logging in IO with `Trace`\r\n\r\n### notes to reviewers\r\n\r\nThe order of the commits follows the modules' dependencies.\r\nStart with 'util' where new logging is implemented. This is also the home of `Trace` (by AVieth).\r\nAll other modules can be reviewed independently (aka \"in parallel\").\r\n\r\n## Linked issues\r\n\r\n[CBR-97] U/S\r\n[CBR-207] introduce katip\r\n[CBR-208] rewriting Pos.Util.Log.LogSafe\r\n[CBR-209] 'katip' scribe for JSON logging\r\n[CBR-213] logging in IO - Pos.Util.Trace\r\n[CBR-271] logging configuration parser\r\n[CBR-274] tests for Pos.Util.Log (and Trace)\r\n\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [ ] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [x] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [x] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [x] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [x] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n```\r\nstack build\r\nstack test\r\n```\r\n\r\nor in a module, e.g. 'networking': `stack build cardano-sl-networking`\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n","created_at":"2018-07-31T19:49:36Z","updated_at":"2018-08-01T14:59:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76a85de863cea3fc186a6b097744359434244f5c","assignee":{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},"assignees":[{"login":"CodiePP","id":14063171,"node_id":"MDQ6VXNlcjE0MDYzMTcx","avatar_url":"https://avatars0.githubusercontent.com/u/14063171?v=4","gravatar_id":"","url":"https://api.github.com/users/CodiePP","html_url":"https://github.com/CodiePP","followers_url":"https://api.github.com/users/CodiePP/followers","following_url":"https://api.github.com/users/CodiePP/following{/other_user}","gists_url":"https://api.github.com/users/CodiePP/gists{/gist_id}","starred_url":"https://api.github.com/users/CodiePP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodiePP/subscriptions","organizations_url":"https://api.github.com/users/CodiePP/orgs","repos_url":"https://api.github.com/users/CodiePP/repos","events_url":"https://api.github.com/users/CodiePP/events{/privacy}","received_events_url":"https://api.github.com/users/CodiePP/received_events","type":"User","site_admin":false},{"login":"365andreas","id":18614147,"node_id":"MDQ6VXNlcjE4NjE0MTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/18614147?v=4","gravatar_id":"","url":"https://api.github.com/users/365andreas","html_url":"https://github.com/365andreas","followers_url":"https://api.github.com/users/365andreas/followers","following_url":"https://api.github.com/users/365andreas/following{/other_user}","gists_url":"https://api.github.com/users/365andreas/gists{/gist_id}","starred_url":"https://api.github.com/users/365andreas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/365andreas/subscriptions","organizations_url":"https://api.github.com/users/365andreas/orgs","repos_url":"https://api.github.com/users/365andreas/repos","events_url":"https://api.github.com/users/365andreas/events{/privacy}","received_events_url":"https://api.github.com/users/365andreas/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"angerman","id":40449,"node_id":"MDQ6VXNlcjQwNDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/40449?v=4","gravatar_id":"","url":"https://api.github.com/users/angerman","html_url":"https://github.com/angerman","followers_url":"https://api.github.com/users/angerman/followers","following_url":"https://api.github.com/users/angerman/following{/other_user}","gists_url":"https://api.github.com/users/angerman/gists{/gist_id}","starred_url":"https://api.github.com/users/angerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angerman/subscriptions","organizations_url":"https://api.github.com/users/angerman/orgs","repos_url":"https://api.github.com/users/angerman/repos","events_url":"https://api.github.com/users/angerman/events{/privacy}","received_events_url":"https://api.github.com/users/angerman/received_events","type":"User","site_admin":false},{"login":"vincenthz","id":174631,"node_id":"MDQ6VXNlcjE3NDYzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/174631?v=4","gravatar_id":"","url":"https://api.github.com/users/vincenthz","html_url":"https://github.com/vincenthz","followers_url":"https://api.github.com/users/vincenthz/followers","following_url":"https://api.github.com/users/vincenthz/following{/other_user}","gists_url":"https://api.github.com/users/vincenthz/gists{/gist_id}","starred_url":"https://api.github.com/users/vincenthz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincenthz/subscriptions","organizations_url":"https://api.github.com/users/vincenthz/orgs","repos_url":"https://api.github.com/users/vincenthz/repos","events_url":"https://api.github.com/users/vincenthz/events{/privacy}","received_events_url":"https://api.github.com/users/vincenthz/received_events","type":"User","site_admin":false},{"login":"coot","id":698209,"node_id":"MDQ6VXNlcjY5ODIwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/698209?v=4","gravatar_id":"","url":"https://api.github.com/users/coot","html_url":"https://github.com/coot","followers_url":"https://api.github.com/users/coot/followers","following_url":"https://api.github.com/users/coot/following{/other_user}","gists_url":"https://api.github.com/users/coot/gists{/gist_id}","starred_url":"https://api.github.com/users/coot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coot/subscriptions","organizations_url":"https://api.github.com/users/coot/orgs","repos_url":"https://api.github.com/users/coot/repos","events_url":"https://api.github.com/users/coot/events{/privacy}","received_events_url":"https://api.github.com/users/coot/received_events","type":"User","site_admin":false},{"login":"dcoutts","id":1339423,"node_id":"MDQ6VXNlcjEzMzk0MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1339423?v=4","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},{"login":"avieth","id":1420272,"node_id":"MDQ6VXNlcjE0MjAyNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420272?v=4","gravatar_id":"","url":"https://api.github.com/users/avieth","html_url":"https://github.com/avieth","followers_url":"https://api.github.com/users/avieth/followers","following_url":"https://api.github.com/users/avieth/following{/other_user}","gists_url":"https://api.github.com/users/avieth/gists{/gist_id}","starred_url":"https://api.github.com/users/avieth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avieth/subscriptions","organizations_url":"https://api.github.com/users/avieth/orgs","repos_url":"https://api.github.com/users/avieth/repos","events_url":"https://api.github.com/users/avieth/events{/privacy}","received_events_url":"https://api.github.com/users/avieth/received_events","type":"User","site_admin":false},{"login":"kantp","id":1433735,"node_id":"MDQ6VXNlcjE0MzM3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1433735?v=4","gravatar_id":"","url":"https://api.github.com/users/kantp","html_url":"https://github.com/kantp","followers_url":"https://api.github.com/users/kantp/followers","following_url":"https://api.github.com/users/kantp/following{/other_user}","gists_url":"https://api.github.com/users/kantp/gists{/gist_id}","starred_url":"https://api.github.com/users/kantp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kantp/subscriptions","organizations_url":"https://api.github.com/users/kantp/orgs","repos_url":"https://api.github.com/users/kantp/repos","events_url":"https://api.github.com/users/kantp/events{/privacy}","received_events_url":"https://api.github.com/users/kantp/received_events","type":"User","site_admin":false},{"login":"akegalj","id":2461951,"node_id":"MDQ6VXNlcjI0NjE5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2461951?v=4","gravatar_id":"","url":"https://api.github.com/users/akegalj","html_url":"https://github.com/akegalj","followers_url":"https://api.github.com/users/akegalj/followers","following_url":"https://api.github.com/users/akegalj/following{/other_user}","gists_url":"https://api.github.com/users/akegalj/gists{/gist_id}","starred_url":"https://api.github.com/users/akegalj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akegalj/subscriptions","organizations_url":"https://api.github.com/users/akegalj/orgs","repos_url":"https://api.github.com/users/akegalj/repos","events_url":"https://api.github.com/users/akegalj/events{/privacy}","received_events_url":"https://api.github.com/users/akegalj/received_events","type":"User","site_admin":false},{"login":"denisshevchenko","id":5082435,"node_id":"MDQ6VXNlcjUwODI0MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5082435?v=4","gravatar_id":"","url":"https://api.github.com/users/denisshevchenko","html_url":"https://github.com/denisshevchenko","followers_url":"https://api.github.com/users/denisshevchenko/followers","following_url":"https://api.github.com/users/denisshevchenko/following{/other_user}","gists_url":"https://api.github.com/users/denisshevchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/denisshevchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisshevchenko/subscriptions","organizations_url":"https://api.github.com/users/denisshevchenko/orgs","repos_url":"https://api.github.com/users/denisshevchenko/repos","events_url":"https://api.github.com/users/denisshevchenko/events{/privacy}","received_events_url":"https://api.github.com/users/denisshevchenko/received_events","type":"User","site_admin":false},{"login":"ksaric","id":6264437,"node_id":"MDQ6VXNlcjYyNjQ0Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6264437?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaric","html_url":"https://github.com/ksaric","followers_url":"https://api.github.com/users/ksaric/followers","following_url":"https://api.github.com/users/ksaric/following{/other_user}","gists_url":"https://api.github.com/users/ksaric/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaric/subscriptions","organizations_url":"https://api.github.com/users/ksaric/orgs","repos_url":"https://api.github.com/users/ksaric/repos","events_url":"https://api.github.com/users/ksaric/events{/privacy}","received_events_url":"https://api.github.com/users/ksaric/received_events","type":"User","site_admin":false},{"login":"ruhatch","id":8578982,"node_id":"MDQ6VXNlcjg1Nzg5ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8578982?v=4","gravatar_id":"","url":"https://api.github.com/users/ruhatch","html_url":"https://github.com/ruhatch","followers_url":"https://api.github.com/users/ruhatch/followers","following_url":"https://api.github.com/users/ruhatch/following{/other_user}","gists_url":"https://api.github.com/users/ruhatch/gists{/gist_id}","starred_url":"https://api.github.com/users/ruhatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruhatch/subscriptions","organizations_url":"https://api.github.com/users/ruhatch/orgs","repos_url":"https://api.github.com/users/ruhatch/repos","events_url":"https://api.github.com/users/ruhatch/events{/privacy}","received_events_url":"https://api.github.com/users/ruhatch/received_events","type":"User","site_admin":false},{"login":"njd42","id":28633284,"node_id":"MDQ6VXNlcjI4NjMzMjg0","avatar_url":"https://avatars3.githubusercontent.com/u/28633284?v=4","gravatar_id":"","url":"https://api.github.com/users/njd42","html_url":"https://github.com/njd42","followers_url":"https://api.github.com/users/njd42/followers","following_url":"https://api.github.com/users/njd42/following{/other_user}","gists_url":"https://api.github.com/users/njd42/gists{/gist_id}","starred_url":"https://api.github.com/users/njd42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njd42/subscriptions","organizations_url":"https://api.github.com/users/njd42/orgs","repos_url":"https://api.github.com/users/njd42/repos","events_url":"https://api.github.com/users/njd42/events{/privacy}","received_events_url":"https://api.github.com/users/njd42/received_events","type":"User","site_admin":false},{"login":"adinapoli-iohk","id":29383371,"node_id":"MDQ6VXNlcjI5MzgzMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/29383371?v=4","gravatar_id":"","url":"https://api.github.com/users/adinapoli-iohk","html_url":"https://github.com/adinapoli-iohk","followers_url":"https://api.github.com/users/adinapoli-iohk/followers","following_url":"https://api.github.com/users/adinapoli-iohk/following{/other_user}","gists_url":"https://api.github.com/users/adinapoli-iohk/gists{/gist_id}","starred_url":"https://api.github.com/users/adinapoli-iohk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adinapoli-iohk/subscriptions","organizations_url":"https://api.github.com/users/adinapoli-iohk/orgs","repos_url":"https://api.github.com/users/adinapoli-iohk/repos","events_url":"https://api.github.com/users/adinapoli-iohk/events{/privacy}","received_events_url":"https://api.github.com/users/adinapoli-iohk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1010667911,"node_id":"MDU6TGFiZWwxMDEwNjY3OTEx","url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels/release-1.4.0","name":"release-1.4.0","color":"4bbed8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3332/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/a226166504f17bb0be3c0529f1613e963e52974f","head":{"label":"input-output-hk:feature/CBR-97/PR","ref":"feature/CBR-97/PR","sha":"a226166504f17bb0be3c0529f1613e963e52974f","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxMzk5Nw==","name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-08-01T12:57:24Z","pushed_at":"2018-08-01T14:56:31Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":113545,"stargazers_count":2789,"watchers_count":2789,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":466,"open_issues":170,"watchers":2789,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"0fa0ce646cb83af8028878a1eed169f513a987b6","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxMzk5Nw==","name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2018-08-01T12:57:24Z","pushed_at":"2018-08-01T14:56:31Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":113545,"stargazers_count":2789,"watchers_count":2789,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":466,"open_issues":170,"watchers":2789,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/3332"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3332"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3332/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3332/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/a226166504f17bb0be3c0529f1613e963e52974f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 70913997,
"name": "input-output-hk/cardano-sl",
"url": "https://api.github.com/repos/input-output-hk/cardano-sl"
} | {
"id": 7310112,
"login": "parsonsmatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7310112?",
"url": "https://api.github.com/users/parsonsmatt"
} | {
"id": 12909177,
"login": "input-output-hk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12909177?",
"url": "https://api.github.com/orgs/input-output-hk"
} | 2018-08-01T14:41:10 | 8051026951 | {"actor":{"display_login":"parsonsmatt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/line/promgen/pulls/comments/174703785","pull_request_review_id":104105751,"id":174703785,"diff_hunk":"@@ -6,7 +6,7 @@ services:\n base:\n build: .\n image: promgen\n- command: sh -c \"promgen migrate && promgen register docker-demo localhost 9090\"\n+ command: sh -c \"until mysqladmin ping -h mysql --silent; do sleep 3; done; promgen migrate && promgen register docker-demo localhost 9090\"","path":"docker-compose.yml","position":5,"original_position":5,"commit_id":"c8b951456d0cd5c71f03784887babbed21e86e86","original_commit_id":"c8b951456d0cd5c71f03784887babbed21e86e86","user":{"login":"kfdm","id":89725,"avatar_url":"https://avatars0.githubusercontent.com/u/89725?v=4","gravatar_id":"","url":"https://api.github.com/users/kfdm","html_url":"https://github.com/kfdm","followers_url":"https://api.github.com/users/kfdm/followers","following_url":"https://api.github.com/users/kfdm/following{/other_user}","gists_url":"https://api.github.com/users/kfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/kfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfdm/subscriptions","organizations_url":"https://api.github.com/users/kfdm/orgs","repos_url":"https://api.github.com/users/kfdm/repos","events_url":"https://api.github.com/users/kfdm/events{/privacy}","received_events_url":"https://api.github.com/users/kfdm/received_events","type":"User","site_admin":false},"body":"This came up when talking with @seoester in #57 though I'm admittedly unfamiliar with docker best practices. I've seen other articles that talk about using 'wait-for' to see when the database is ready\r\n\r\nhttps://github.com/eficode/wait-for\r\nhttps://docs.docker.com/compose/startup-order/\r\n\r\nTrying to fit everything on a single line starts getting a bit messy, so perhaps it would be better to add this to docker-entrypoint.sh ?\r\n\r\n```sh\r\ndocker-compose-bootstrap)\r\n # Shortcut to wait for Mysql to startup and run migrations\r\n until mysqladmin ping -h mysql --silent\r\n do\r\n sleep 3\r\n done\r\n promgen migrate\r\n promgen register docker-demo\r\n ;;\r\n```\r\n\r\nAnd then we could just make this line\r\n```\r\ncommand: docker-compose-bootstrap","created_at":"2018-03-15T08:17:14Z","updated_at":"2018-03-15T08:17:19Z","html_url":"https://github.com/line/promgen/pull/71#discussion_r174703785","pull_request_url":"https://api.github.com/repos/line/promgen/pulls/71","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/line/promgen/pulls/comments/174703785"},"html":{"href":"https://github.com/line/promgen/pull/71#discussion_r174703785"},"pull_request":{"href":"https://api.github.com/repos/line/promgen/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/line/promgen/pulls/71","id":175145859,"html_url":"https://github.com/line/promgen/pull/71","diff_url":"https://github.com/line/promgen/pull/71.diff","patch_url":"https://github.com/line/promgen/pull/71.patch","issue_url":"https://api.github.com/repos/line/promgen/issues/71","number":71,"state":"open","locked":false,"title":"await mysql when promgen starts","user":{"login":"m-tkg","id":5688286,"avatar_url":"https://avatars3.githubusercontent.com/u/5688286?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tkg","html_url":"https://github.com/m-tkg","followers_url":"https://api.github.com/users/m-tkg/followers","following_url":"https://api.github.com/users/m-tkg/following{/other_user}","gists_url":"https://api.github.com/users/m-tkg/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tkg/subscriptions","organizations_url":"https://api.github.com/users/m-tkg/orgs","repos_url":"https://api.github.com/users/m-tkg/repos","events_url":"https://api.github.com/users/m-tkg/events{/privacy}","received_events_url":"https://api.github.com/users/m-tkg/received_events","type":"User","site_admin":false},"body":"web container for promgen migrate must await not only mysql-container but also mysql-server starts.\r\nso I implemented waiting loop using mysqladmin.","created_at":"2018-03-15T04:26:53Z","updated_at":"2018-03-15T08:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f90ea4d50b49ef27a1870c3b2bd310cb87e54ad","assignee":{"login":"kfdm","id":89725,"avatar_url":"https://avatars0.githubusercontent.com/u/89725?v=4","gravatar_id":"","url":"https://api.github.com/users/kfdm","html_url":"https://github.com/kfdm","followers_url":"https://api.github.com/users/kfdm/followers","following_url":"https://api.github.com/users/kfdm/following{/other_user}","gists_url":"https://api.github.com/users/kfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/kfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfdm/subscriptions","organizations_url":"https://api.github.com/users/kfdm/orgs","repos_url":"https://api.github.com/users/kfdm/repos","events_url":"https://api.github.com/users/kfdm/events{/privacy}","received_events_url":"https://api.github.com/users/kfdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"kfdm","id":89725,"avatar_url":"https://avatars0.githubusercontent.com/u/89725?v=4","gravatar_id":"","url":"https://api.github.com/users/kfdm","html_url":"https://github.com/kfdm","followers_url":"https://api.github.com/users/kfdm/followers","following_url":"https://api.github.com/users/kfdm/following{/other_user}","gists_url":"https://api.github.com/users/kfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/kfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfdm/subscriptions","organizations_url":"https://api.github.com/users/kfdm/orgs","repos_url":"https://api.github.com/users/kfdm/repos","events_url":"https://api.github.com/users/kfdm/events{/privacy}","received_events_url":"https://api.github.com/users/kfdm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/line/promgen/pulls/71/commits","review_comments_url":"https://api.github.com/repos/line/promgen/pulls/71/comments","review_comment_url":"https://api.github.com/repos/line/promgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/promgen/issues/71/comments","statuses_url":"https://api.github.com/repos/line/promgen/statuses/c8b951456d0cd5c71f03784887babbed21e86e86","head":{"label":"m-tkg:feature-await-mysql","ref":"feature-await-mysql","sha":"c8b951456d0cd5c71f03784887babbed21e86e86","user":{"login":"m-tkg","id":5688286,"avatar_url":"https://avatars3.githubusercontent.com/u/5688286?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tkg","html_url":"https://github.com/m-tkg","followers_url":"https://api.github.com/users/m-tkg/followers","following_url":"https://api.github.com/users/m-tkg/following{/other_user}","gists_url":"https://api.github.com/users/m-tkg/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tkg/subscriptions","organizations_url":"https://api.github.com/users/m-tkg/orgs","repos_url":"https://api.github.com/users/m-tkg/repos","events_url":"https://api.github.com/users/m-tkg/events{/privacy}","received_events_url":"https://api.github.com/users/m-tkg/received_events","type":"User","site_admin":false},"repo":{"id":125309575,"name":"promgen","full_name":"m-tkg/promgen","owner":{"login":"m-tkg","id":5688286,"avatar_url":"https://avatars3.githubusercontent.com/u/5688286?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tkg","html_url":"https://github.com/m-tkg","followers_url":"https://api.github.com/users/m-tkg/followers","following_url":"https://api.github.com/users/m-tkg/following{/other_user}","gists_url":"https://api.github.com/users/m-tkg/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tkg/subscriptions","organizations_url":"https://api.github.com/users/m-tkg/orgs","repos_url":"https://api.github.com/users/m-tkg/repos","events_url":"https://api.github.com/users/m-tkg/events{/privacy}","received_events_url":"https://api.github.com/users/m-tkg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m-tkg/promgen","description":"Promgen is a configuration file generator for Prometheus","fork":true,"url":"https://api.github.com/repos/m-tkg/promgen","forks_url":"https://api.github.com/repos/m-tkg/promgen/forks","keys_url":"https://api.github.com/repos/m-tkg/promgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-tkg/promgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-tkg/promgen/teams","hooks_url":"https://api.github.com/repos/m-tkg/promgen/hooks","issue_events_url":"https://api.github.com/repos/m-tkg/promgen/issues/events{/number}","events_url":"https://api.github.com/repos/m-tkg/promgen/events","assignees_url":"https://api.github.com/repos/m-tkg/promgen/assignees{/user}","branches_url":"https://api.github.com/repos/m-tkg/promgen/branches{/branch}","tags_url":"https://api.github.com/repos/m-tkg/promgen/tags","blobs_url":"https://api.github.com/repos/m-tkg/promgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-tkg/promgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-tkg/promgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-tkg/promgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-tkg/promgen/statuses/{sha}","languages_url":"https://api.github.com/repos/m-tkg/promgen/languages","stargazers_url":"https://api.github.com/repos/m-tkg/promgen/stargazers","contributors_url":"https://api.github.com/repos/m-tkg/promgen/contributors","subscribers_url":"https://api.github.com/repos/m-tkg/promgen/subscribers","subscription_url":"https://api.github.com/repos/m-tkg/promgen/subscription","commits_url":"https://api.github.com/repos/m-tkg/promgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-tkg/promgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-tkg/promgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-tkg/promgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-tkg/promgen/contents/{+path}","compare_url":"https://api.github.com/repos/m-tkg/promgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-tkg/promgen/merges","archive_url":"https://api.github.com/repos/m-tkg/promgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-tkg/promgen/downloads","issues_url":"https://api.github.com/repos/m-tkg/promgen/issues{/number}","pulls_url":"https://api.github.com/repos/m-tkg/promgen/pulls{/number}","milestones_url":"https://api.github.com/repos/m-tkg/promgen/milestones{/number}","notifications_url":"https://api.github.com/repos/m-tkg/promgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-tkg/promgen/labels{/name}","releases_url":"https://api.github.com/repos/m-tkg/promgen/releases{/id}","deployments_url":"https://api.github.com/repos/m-tkg/promgen/deployments","created_at":"2018-03-15T03:53:20Z","updated_at":"2018-03-15T04:18:22Z","pushed_at":"2018-03-15T04:20:48Z","git_url":"git://github.com/m-tkg/promgen.git","ssh_url":"git@github.com:m-tkg/promgen.git","clone_url":"https://github.com/m-tkg/promgen.git","svn_url":"https://github.com/m-tkg/promgen","homepage":"https://line.github.io/promgen/","size":3890,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"b557c00d3187090af765235c8a7fed057586e59e","user":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":64717629,"name":"promgen","full_name":"line/promgen","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/promgen","description":"Promgen is a configuration file generator for Prometheus","fork":false,"url":"https://api.github.com/repos/line/promgen","forks_url":"https://api.github.com/repos/line/promgen/forks","keys_url":"https://api.github.com/repos/line/promgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/promgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/promgen/teams","hooks_url":"https://api.github.com/repos/line/promgen/hooks","issue_events_url":"https://api.github.com/repos/line/promgen/issues/events{/number}","events_url":"https://api.github.com/repos/line/promgen/events","assignees_url":"https://api.github.com/repos/line/promgen/assignees{/user}","branches_url":"https://api.github.com/repos/line/promgen/branches{/branch}","tags_url":"https://api.github.com/repos/line/promgen/tags","blobs_url":"https://api.github.com/repos/line/promgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/promgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/promgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/promgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/promgen/statuses/{sha}","languages_url":"https://api.github.com/repos/line/promgen/languages","stargazers_url":"https://api.github.com/repos/line/promgen/stargazers","contributors_url":"https://api.github.com/repos/line/promgen/contributors","subscribers_url":"https://api.github.com/repos/line/promgen/subscribers","subscription_url":"https://api.github.com/repos/line/promgen/subscription","commits_url":"https://api.github.com/repos/line/promgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/promgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/promgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/promgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/promgen/contents/{+path}","compare_url":"https://api.github.com/repos/line/promgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/promgen/merges","archive_url":"https://api.github.com/repos/line/promgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/promgen/downloads","issues_url":"https://api.github.com/repos/line/promgen/issues{/number}","pulls_url":"https://api.github.com/repos/line/promgen/pulls{/number}","milestones_url":"https://api.github.com/repos/line/promgen/milestones{/number}","notifications_url":"https://api.github.com/repos/line/promgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/promgen/labels{/name}","releases_url":"https://api.github.com/repos/line/promgen/releases{/id}","deployments_url":"https://api.github.com/repos/line/promgen/deployments","created_at":"2016-08-02T02:35:13Z","updated_at":"2018-03-14T09:06:16Z","pushed_at":"2018-03-15T07:59:32Z","git_url":"git://github.com/line/promgen.git","ssh_url":"git@github.com:line/promgen.git","clone_url":"https://github.com/line/promgen.git","svn_url":"https://github.com/line/promgen","homepage":"https://line.github.io/promgen/","size":3890,"stargazers_count":174,"watchers_count":174,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":29,"open_issues":13,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/promgen/pulls/71"},"html":{"href":"https://github.com/line/promgen/pull/71"},"issue":{"href":"https://api.github.com/repos/line/promgen/issues/71"},"comments":{"href":"https://api.github.com/repos/line/promgen/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/line/promgen/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/line/promgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/promgen/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/line/promgen/statuses/c8b951456d0cd5c71f03784887babbed21e86e86"}},"author_association":"NONE"}} | {
"id": 64717629,
"name": "line/promgen",
"url": "https://api.github.com/repos/line/promgen"
} | {
"id": 89725,
"login": "kfdm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/89725?",
"url": "https://api.github.com/users/kfdm"
} | {
"id": 13128444,
"login": "line",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13128444?",
"url": "https://api.github.com/orgs/line"
} | 2018-03-15T08:17:14 | 7383085388 | {"actor":{"display_login":"kfdm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/comments/222133466","pull_request_review_id":160949162,"id":222133466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjEzMzQ2Ng==","diff_hunk":"@@ -0,0 +1,66 @@\n+package com.criptext.mail.push.data\n+\n+import android.app.IntentService\n+import android.app.NotificationManager\n+import android.content.Context\n+import android.content.Intent\n+\n+\n+class LinkDeviceActionService : IntentService(\"Link Device Action Service\") {\n+\n+ companion object {\n+ const val APPROVE = \"Approve\"\n+ const val DENY = \"Deny\"\n+\n+ private var pushDataSource: PushDataSource? = null\n+ private var randomId: String = \"\"\n+ private var manager: NotificationManager? = null\n+\n+ fun initDataSource(dataSource: PushDataSource, id: String){\n+ pushDataSource = dataSource\n+ randomId = id\n+ pushDataSource?.listener = dataSourceListener\n+ }\n+\n+ private val dataSourceListener = { result: PushResult ->\n+ when (result) {\n+ is PushResult.LinkAccept -> onLinkAccept(result)\n+ is PushResult.LinkDeny -> onLinkDeny(result)\n+ }\n+ }\n+\n+ private fun onLinkAccept(result: PushResult){\n+ when(result){\n+ is PushResult.LinkAccept.Success -> {\n+ manager?.cancel(result.notificationId)\n+ }\n+ }\n+ }\n+\n+ private fun onLinkDeny(result: PushResult){\n+ when(result){\n+ is PushResult.LinkDeny.Success -> {\n+ manager?.cancel(result.notificationId)\n+ }\n+ }\n+ }\n+ }\n+\n+\n+\n+ public override fun onHandleIntent(intent: Intent?) {\n+ val action = intent!!.action\n+ val notificationId = intent.getIntExtra(\"notificationId\", 0)\n+ when {","path":"src/main/kotlin/com/criptext/mail/push/data/LinkDeviceActionService.kt","position":54,"original_position":54,"commit_id":"ac07c33307c963ec0db0eab1f33715f20595aba5","original_commit_id":"ac07c33307c963ec0db0eab1f33715f20595aba5","user":{"login":"not-gabriel","id":14115856,"node_id":"MDQ6VXNlcjE0MTE1ODU2","avatar_url":"https://avatars0.githubusercontent.com/u/14115856?v=4","gravatar_id":"","url":"https://api.github.com/users/not-gabriel","html_url":"https://github.com/not-gabriel","followers_url":"https://api.github.com/users/not-gabriel/followers","following_url":"https://api.github.com/users/not-gabriel/following{/other_user}","gists_url":"https://api.github.com/users/not-gabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/not-gabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-gabriel/subscriptions","organizations_url":"https://api.github.com/users/not-gabriel/orgs","repos_url":"https://api.github.com/users/not-gabriel/repos","events_url":"https://api.github.com/users/not-gabriel/events{/privacy}","received_events_url":"https://api.github.com/users/not-gabriel/received_events","type":"User","site_admin":false},"body":"parsing arguments should be in it's own function.","created_at":"2018-10-02T22:34:21Z","updated_at":"2018-10-02T22:34:26Z","html_url":"https://github.com/Criptext/Android-Email-Client/pull/283#discussion_r222133466","pull_request_url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/comments/222133466"},"html":{"href":"https://github.com/Criptext/Android-Email-Client/pull/283#discussion_r222133466"},"pull_request":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283","id":219848635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODQ4NjM1","html_url":"https://github.com/Criptext/Android-Email-Client/pull/283","diff_url":"https://github.com/Criptext/Android-Email-Client/pull/283.diff","patch_url":"https://github.com/Criptext/Android-Email-Client/pull/283.patch","issue_url":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/283","number":283,"state":"open","locked":false,"title":"Now you can approve or deny device auth on push notifications.","user":{"login":"jorgeblacio","id":34110092,"node_id":"MDQ6VXNlcjM0MTEwMDky","avatar_url":"https://avatars3.githubusercontent.com/u/34110092?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgeblacio","html_url":"https://github.com/jorgeblacio","followers_url":"https://api.github.com/users/jorgeblacio/followers","following_url":"https://api.github.com/users/jorgeblacio/following{/other_user}","gists_url":"https://api.github.com/users/jorgeblacio/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgeblacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgeblacio/subscriptions","organizations_url":"https://api.github.com/users/jorgeblacio/orgs","repos_url":"https://api.github.com/users/jorgeblacio/repos","events_url":"https://api.github.com/users/jorgeblacio/events{/privacy}","received_events_url":"https://api.github.com/users/jorgeblacio/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T21:18:29Z","updated_at":"2018-10-02T22:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b54081db21d4db849763440232ebb6c1be7c1136","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283/commits","review_comments_url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283/comments","review_comment_url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/283/comments","statuses_url":"https://api.github.com/repos/Criptext/Android-Email-Client/statuses/ac07c33307c963ec0db0eab1f33715f20595aba5","head":{"label":"jorgeblacio:device_approve_push_notification","ref":"device_approve_push_notification","sha":"ac07c33307c963ec0db0eab1f33715f20595aba5","user":{"login":"jorgeblacio","id":34110092,"node_id":"MDQ6VXNlcjM0MTEwMDky","avatar_url":"https://avatars3.githubusercontent.com/u/34110092?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgeblacio","html_url":"https://github.com/jorgeblacio","followers_url":"https://api.github.com/users/jorgeblacio/followers","following_url":"https://api.github.com/users/jorgeblacio/following{/other_user}","gists_url":"https://api.github.com/users/jorgeblacio/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgeblacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgeblacio/subscriptions","organizations_url":"https://api.github.com/users/jorgeblacio/orgs","repos_url":"https://api.github.com/users/jorgeblacio/repos","events_url":"https://api.github.com/users/jorgeblacio/events{/privacy}","received_events_url":"https://api.github.com/users/jorgeblacio/received_events","type":"User","site_admin":false},"repo":{"id":144631609,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MzE2MDk=","name":"Android-Email-Client","full_name":"jorgeblacio/Android-Email-Client","private":false,"owner":{"login":"jorgeblacio","id":34110092,"node_id":"MDQ6VXNlcjM0MTEwMDky","avatar_url":"https://avatars3.githubusercontent.com/u/34110092?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgeblacio","html_url":"https://github.com/jorgeblacio","followers_url":"https://api.github.com/users/jorgeblacio/followers","following_url":"https://api.github.com/users/jorgeblacio/following{/other_user}","gists_url":"https://api.github.com/users/jorgeblacio/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgeblacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgeblacio/subscriptions","organizations_url":"https://api.github.com/users/jorgeblacio/orgs","repos_url":"https://api.github.com/users/jorgeblacio/repos","events_url":"https://api.github.com/users/jorgeblacio/events{/privacy}","received_events_url":"https://api.github.com/users/jorgeblacio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jorgeblacio/Android-Email-Client","description":null,"fork":true,"url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client","forks_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/forks","keys_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/teams","hooks_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/hooks","issue_events_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/issues/events{/number}","events_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/events","assignees_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/assignees{/user}","branches_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/branches{/branch}","tags_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/tags","blobs_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/statuses/{sha}","languages_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/languages","stargazers_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/stargazers","contributors_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/contributors","subscribers_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/subscribers","subscription_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/subscription","commits_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/contents/{+path}","compare_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/merges","archive_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/downloads","issues_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/issues{/number}","pulls_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/pulls{/number}","milestones_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/milestones{/number}","notifications_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/labels{/name}","releases_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/releases{/id}","deployments_url":"https://api.github.com/repos/jorgeblacio/Android-Email-Client/deployments","created_at":"2018-08-13T20:42:01Z","updated_at":"2018-10-02T14:40:09Z","pushed_at":"2018-10-02T21:40:44Z","git_url":"git://github.com/jorgeblacio/Android-Email-Client.git","ssh_url":"git@github.com:jorgeblacio/Android-Email-Client.git","clone_url":"https://github.com/jorgeblacio/Android-Email-Client.git","svn_url":"https://github.com/jorgeblacio/Android-Email-Client","homepage":null,"size":6453,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Criptext:master","ref":"master","sha":"c9b491c5dfd434407b0f8120013c368aadd663a2","user":{"login":"Criptext","id":13144821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ0ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/13144821?v=4","gravatar_id":"","url":"https://api.github.com/users/Criptext","html_url":"https://github.com/Criptext","followers_url":"https://api.github.com/users/Criptext/followers","following_url":"https://api.github.com/users/Criptext/following{/other_user}","gists_url":"https://api.github.com/users/Criptext/gists{/gist_id}","starred_url":"https://api.github.com/users/Criptext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Criptext/subscriptions","organizations_url":"https://api.github.com/users/Criptext/orgs","repos_url":"https://api.github.com/users/Criptext/repos","events_url":"https://api.github.com/users/Criptext/events{/privacy}","received_events_url":"https://api.github.com/users/Criptext/received_events","type":"Organization","site_admin":false},"repo":{"id":118518189,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MTgxODk=","name":"Android-Email-Client","full_name":"Criptext/Android-Email-Client","private":false,"owner":{"login":"Criptext","id":13144821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ0ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/13144821?v=4","gravatar_id":"","url":"https://api.github.com/users/Criptext","html_url":"https://github.com/Criptext","followers_url":"https://api.github.com/users/Criptext/followers","following_url":"https://api.github.com/users/Criptext/following{/other_user}","gists_url":"https://api.github.com/users/Criptext/gists{/gist_id}","starred_url":"https://api.github.com/users/Criptext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Criptext/subscriptions","organizations_url":"https://api.github.com/users/Criptext/orgs","repos_url":"https://api.github.com/users/Criptext/repos","events_url":"https://api.github.com/users/Criptext/events{/privacy}","received_events_url":"https://api.github.com/users/Criptext/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Criptext/Android-Email-Client","description":"Criptext for Android","fork":false,"url":"https://api.github.com/repos/Criptext/Android-Email-Client","forks_url":"https://api.github.com/repos/Criptext/Android-Email-Client/forks","keys_url":"https://api.github.com/repos/Criptext/Android-Email-Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Criptext/Android-Email-Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Criptext/Android-Email-Client/teams","hooks_url":"https://api.github.com/repos/Criptext/Android-Email-Client/hooks","issue_events_url":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/events{/number}","events_url":"https://api.github.com/repos/Criptext/Android-Email-Client/events","assignees_url":"https://api.github.com/repos/Criptext/Android-Email-Client/assignees{/user}","branches_url":"https://api.github.com/repos/Criptext/Android-Email-Client/branches{/branch}","tags_url":"https://api.github.com/repos/Criptext/Android-Email-Client/tags","blobs_url":"https://api.github.com/repos/Criptext/Android-Email-Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Criptext/Android-Email-Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Criptext/Android-Email-Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Criptext/Android-Email-Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Criptext/Android-Email-Client/statuses/{sha}","languages_url":"https://api.github.com/repos/Criptext/Android-Email-Client/languages","stargazers_url":"https://api.github.com/repos/Criptext/Android-Email-Client/stargazers","contributors_url":"https://api.github.com/repos/Criptext/Android-Email-Client/contributors","subscribers_url":"https://api.github.com/repos/Criptext/Android-Email-Client/subscribers","subscription_url":"https://api.github.com/repos/Criptext/Android-Email-Client/subscription","commits_url":"https://api.github.com/repos/Criptext/Android-Email-Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Criptext/Android-Email-Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Criptext/Android-Email-Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Criptext/Android-Email-Client/contents/{+path}","compare_url":"https://api.github.com/repos/Criptext/Android-Email-Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Criptext/Android-Email-Client/merges","archive_url":"https://api.github.com/repos/Criptext/Android-Email-Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Criptext/Android-Email-Client/downloads","issues_url":"https://api.github.com/repos/Criptext/Android-Email-Client/issues{/number}","pulls_url":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls{/number}","milestones_url":"https://api.github.com/repos/Criptext/Android-Email-Client/milestones{/number}","notifications_url":"https://api.github.com/repos/Criptext/Android-Email-Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Criptext/Android-Email-Client/labels{/name}","releases_url":"https://api.github.com/repos/Criptext/Android-Email-Client/releases{/id}","deployments_url":"https://api.github.com/repos/Criptext/Android-Email-Client/deployments","created_at":"2018-01-22T21:34:49Z","updated_at":"2018-10-02T14:39:33Z","pushed_at":"2018-10-02T21:40:45Z","git_url":"git://github.com/Criptext/Android-Email-Client.git","ssh_url":"git@github.com:Criptext/Android-Email-Client.git","clone_url":"https://github.com/Criptext/Android-Email-Client.git","svn_url":"https://github.com/Criptext/Android-Email-Client","homepage":"https://criptext.com","size":6399,"stargazers_count":3,"watchers_count":3,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":46,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283"},"html":{"href":"https://github.com/Criptext/Android-Email-Client/pull/283"},"issue":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/283"},"comments":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/Criptext/Android-Email-Client/statuses/ac07c33307c963ec0db0eab1f33715f20595aba5"}},"author_association":"COLLABORATOR"}} | {
"id": 118518189,
"name": "Criptext/Android-Email-Client",
"url": "https://api.github.com/repos/Criptext/Android-Email-Client"
} | {
"id": 14115856,
"login": "not-gabriel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14115856?",
"url": "https://api.github.com/users/not-gabriel"
} | {
"id": 13144821,
"login": "Criptext",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13144821?",
"url": "https://api.github.com/orgs/Criptext"
} | 2018-10-02T22:34:21 | 8357693479 | {"actor":{"display_login":"not-gabriel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/karafka/karafka/pulls/comments/190957535","pull_request_review_id":123450255,"id":190957535,"diff_hunk":"@@ -16,30 +16,26 @@ def initialize(consumer_group)\n \n # Runs prefetch callbacks and executes the main listener fetch loop\n def call\n- Karafka::Callbacks.before_fetch_loop(\n- @consumer_group,\n- client\n- )\n+ Karafka::Callbacks.before_fetch_loop(@consumer_group, client)\n fetch_loop\n end\n \n private\n \n # Opens connection, gets messages and calls a block for each of the incoming messages\n- # @yieldparam [String] consumer group id\n- # @yieldparam [Array<Kafka::FetchedMessage>] kafka fetched messages\n- # @note This will yield with a raw message - no preprocessing or reformatting\n # @note We catch all the errors here, so they don't affect other listeners (or this one)\n # so we will be able to listen and consume other incoming messages.\n # Since it is run inside Karafka::Connection::ActorCluster - catching all the exceptions\n # won't crash the whole cluster. Here we mostly focus on catchin the exceptions related to\n # Kafka connections / Internet connection issues / Etc. Business logic problems should not\n # propagate this far\n def fetch_loop\n- client.fetch_loop do |raw_messages|\n- # @note What happens here is a delegation of processing to a proper processor based\n- # on the incoming messages characteristics\n- Karafka::Connection::Delegator.call(@consumer_group.id, raw_messages)\n+ delegators = { message: MessageDelegator, batch: BatchDelegator }","path":"lib/karafka/connection/listener.rb","position":29,"original_position":29,"commit_id":"fc28fb1650d2955c589b268c114bb7f843cba0b5","original_commit_id":"fc28fb1650d2955c589b268c114bb7f843cba0b5","user":{"login":"nijikon","id":150547,"avatar_url":"https://avatars3.githubusercontent.com/u/150547?v=4","gravatar_id":"","url":"https://api.github.com/users/nijikon","html_url":"https://github.com/nijikon","followers_url":"https://api.github.com/users/nijikon/followers","following_url":"https://api.github.com/users/nijikon/following{/other_user}","gists_url":"https://api.github.com/users/nijikon/gists{/gist_id}","starred_url":"https://api.github.com/users/nijikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijikon/subscriptions","organizations_url":"https://api.github.com/users/nijikon/orgs","repos_url":"https://api.github.com/users/nijikon/repos","events_url":"https://api.github.com/users/nijikon/events{/privacy}","received_events_url":"https://api.github.com/users/nijikon/received_events","type":"User","site_admin":false},"body":"Move this to constant maybe?","created_at":"2018-05-25T17:15:48Z","updated_at":"2018-05-25T17:17:39Z","html_url":"https://github.com/karafka/karafka/pull/349#discussion_r190957535","pull_request_url":"https://api.github.com/repos/karafka/karafka/pulls/349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/karafka/karafka/pulls/comments/190957535"},"html":{"href":"https://github.com/karafka/karafka/pull/349#discussion_r190957535"},"pull_request":{"href":"https://api.github.com/repos/karafka/karafka/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/karafka/karafka/pulls/349","id":190632372,"html_url":"https://github.com/karafka/karafka/pull/349","diff_url":"https://github.com/karafka/karafka/pull/349.diff","patch_url":"https://github.com/karafka/karafka/pull/349.patch","issue_url":"https://api.github.com/repos/karafka/karafka/issues/349","number":349,"state":"open","locked":false,"title":"issue-341","user":{"login":"mensfeld","id":392754,"avatar_url":"https://avatars3.githubusercontent.com/u/392754?v=4","gravatar_id":"","url":"https://api.github.com/users/mensfeld","html_url":"https://github.com/mensfeld","followers_url":"https://api.github.com/users/mensfeld/followers","following_url":"https://api.github.com/users/mensfeld/following{/other_user}","gists_url":"https://api.github.com/users/mensfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/mensfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mensfeld/subscriptions","organizations_url":"https://api.github.com/users/mensfeld/orgs","repos_url":"https://api.github.com/users/mensfeld/repos","events_url":"https://api.github.com/users/mensfeld/events{/privacy}","received_events_url":"https://api.github.com/users/mensfeld/received_events","type":"User","site_admin":false},"body":"closes #341 ","created_at":"2018-05-25T16:02:37Z","updated_at":"2018-05-25T17:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94eb7aa74bf83ebd1981136bf0d617a33ed78d47","assignee":{"login":"nijikon","id":150547,"avatar_url":"https://avatars3.githubusercontent.com/u/150547?v=4","gravatar_id":"","url":"https://api.github.com/users/nijikon","html_url":"https://github.com/nijikon","followers_url":"https://api.github.com/users/nijikon/followers","following_url":"https://api.github.com/users/nijikon/following{/other_user}","gists_url":"https://api.github.com/users/nijikon/gists{/gist_id}","starred_url":"https://api.github.com/users/nijikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijikon/subscriptions","organizations_url":"https://api.github.com/users/nijikon/orgs","repos_url":"https://api.github.com/users/nijikon/repos","events_url":"https://api.github.com/users/nijikon/events{/privacy}","received_events_url":"https://api.github.com/users/nijikon/received_events","type":"User","site_admin":false},"assignees":[{"login":"nijikon","id":150547,"avatar_url":"https://avatars3.githubusercontent.com/u/150547?v=4","gravatar_id":"","url":"https://api.github.com/users/nijikon","html_url":"https://github.com/nijikon","followers_url":"https://api.github.com/users/nijikon/followers","following_url":"https://api.github.com/users/nijikon/following{/other_user}","gists_url":"https://api.github.com/users/nijikon/gists{/gist_id}","starred_url":"https://api.github.com/users/nijikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nijikon/subscriptions","organizations_url":"https://api.github.com/users/nijikon/orgs","repos_url":"https://api.github.com/users/nijikon/repos","events_url":"https://api.github.com/users/nijikon/events{/privacy}","received_events_url":"https://api.github.com/users/nijikon/received_events","type":"User","site_admin":false},{"login":"agwozdowski","id":10708382,"avatar_url":"https://avatars3.githubusercontent.com/u/10708382?v=4","gravatar_id":"","url":"https://api.github.com/users/agwozdowski","html_url":"https://github.com/agwozdowski","followers_url":"https://api.github.com/users/agwozdowski/followers","following_url":"https://api.github.com/users/agwozdowski/following{/other_user}","gists_url":"https://api.github.com/users/agwozdowski/gists{/gist_id}","starred_url":"https://api.github.com/users/agwozdowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agwozdowski/subscriptions","organizations_url":"https://api.github.com/users/agwozdowski/orgs","repos_url":"https://api.github.com/users/agwozdowski/repos","events_url":"https://api.github.com/users/agwozdowski/events{/privacy}","received_events_url":"https://api.github.com/users/agwozdowski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"agwozdowski","id":10708382,"avatar_url":"https://avatars3.githubusercontent.com/u/10708382?v=4","gravatar_id":"","url":"https://api.github.com/users/agwozdowski","html_url":"https://github.com/agwozdowski","followers_url":"https://api.github.com/users/agwozdowski/followers","following_url":"https://api.github.com/users/agwozdowski/following{/other_user}","gists_url":"https://api.github.com/users/agwozdowski/gists{/gist_id}","starred_url":"https://api.github.com/users/agwozdowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agwozdowski/subscriptions","organizations_url":"https://api.github.com/users/agwozdowski/orgs","repos_url":"https://api.github.com/users/agwozdowski/repos","events_url":"https://api.github.com/users/agwozdowski/events{/privacy}","received_events_url":"https://api.github.com/users/agwozdowski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/karafka/karafka/pulls/349/commits","review_comments_url":"https://api.github.com/repos/karafka/karafka/pulls/349/comments","review_comment_url":"https://api.github.com/repos/karafka/karafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/karafka/karafka/issues/349/comments","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/fc28fb1650d2955c589b268c114bb7f843cba0b5","head":{"label":"karafka:issue-341","ref":"issue-341","sha":"fc28fb1650d2955c589b268c114bb7f843cba0b5","user":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"repo":{"id":39947871,"name":"karafka","full_name":"karafka/karafka","owner":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karafka/karafka","description":"Framework for Apache Kafka based Ruby and Rails applications development.","fork":false,"url":"https://api.github.com/repos/karafka/karafka","forks_url":"https://api.github.com/repos/karafka/karafka/forks","keys_url":"https://api.github.com/repos/karafka/karafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karafka/karafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karafka/karafka/teams","hooks_url":"https://api.github.com/repos/karafka/karafka/hooks","issue_events_url":"https://api.github.com/repos/karafka/karafka/issues/events{/number}","events_url":"https://api.github.com/repos/karafka/karafka/events","assignees_url":"https://api.github.com/repos/karafka/karafka/assignees{/user}","branches_url":"https://api.github.com/repos/karafka/karafka/branches{/branch}","tags_url":"https://api.github.com/repos/karafka/karafka/tags","blobs_url":"https://api.github.com/repos/karafka/karafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karafka/karafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karafka/karafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/karafka/karafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/{sha}","languages_url":"https://api.github.com/repos/karafka/karafka/languages","stargazers_url":"https://api.github.com/repos/karafka/karafka/stargazers","contributors_url":"https://api.github.com/repos/karafka/karafka/contributors","subscribers_url":"https://api.github.com/repos/karafka/karafka/subscribers","subscription_url":"https://api.github.com/repos/karafka/karafka/subscription","commits_url":"https://api.github.com/repos/karafka/karafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/karafka/karafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/karafka/karafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/karafka/karafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/karafka/karafka/contents/{+path}","compare_url":"https://api.github.com/repos/karafka/karafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karafka/karafka/merges","archive_url":"https://api.github.com/repos/karafka/karafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karafka/karafka/downloads","issues_url":"https://api.github.com/repos/karafka/karafka/issues{/number}","pulls_url":"https://api.github.com/repos/karafka/karafka/pulls{/number}","milestones_url":"https://api.github.com/repos/karafka/karafka/milestones{/number}","notifications_url":"https://api.github.com/repos/karafka/karafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karafka/karafka/labels{/name}","releases_url":"https://api.github.com/repos/karafka/karafka/releases{/id}","deployments_url":"https://api.github.com/repos/karafka/karafka/deployments","created_at":"2015-07-30T11:49:27Z","updated_at":"2018-05-25T10:30:04Z","pushed_at":"2018-05-25T16:54:26Z","git_url":"git://github.com/karafka/karafka.git","ssh_url":"git@github.com:karafka/karafka.git","clone_url":"https://github.com/karafka/karafka.git","svn_url":"https://github.com/karafka/karafka","homepage":"","size":1222,"stargazers_count":703,"watchers_count":703,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":54,"open_issues":13,"watchers":703,"default_branch":"master"}},"base":{"label":"karafka:1.3-wip","ref":"1.3-wip","sha":"aed40a9ec3584bb60adc10fc48ea26f67db9be95","user":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"repo":{"id":39947871,"name":"karafka","full_name":"karafka/karafka","owner":{"login":"karafka","id":13313336,"avatar_url":"https://avatars2.githubusercontent.com/u/13313336?v=4","gravatar_id":"","url":"https://api.github.com/users/karafka","html_url":"https://github.com/karafka","followers_url":"https://api.github.com/users/karafka/followers","following_url":"https://api.github.com/users/karafka/following{/other_user}","gists_url":"https://api.github.com/users/karafka/gists{/gist_id}","starred_url":"https://api.github.com/users/karafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karafka/subscriptions","organizations_url":"https://api.github.com/users/karafka/orgs","repos_url":"https://api.github.com/users/karafka/repos","events_url":"https://api.github.com/users/karafka/events{/privacy}","received_events_url":"https://api.github.com/users/karafka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/karafka/karafka","description":"Framework for Apache Kafka based Ruby and Rails applications development.","fork":false,"url":"https://api.github.com/repos/karafka/karafka","forks_url":"https://api.github.com/repos/karafka/karafka/forks","keys_url":"https://api.github.com/repos/karafka/karafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karafka/karafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karafka/karafka/teams","hooks_url":"https://api.github.com/repos/karafka/karafka/hooks","issue_events_url":"https://api.github.com/repos/karafka/karafka/issues/events{/number}","events_url":"https://api.github.com/repos/karafka/karafka/events","assignees_url":"https://api.github.com/repos/karafka/karafka/assignees{/user}","branches_url":"https://api.github.com/repos/karafka/karafka/branches{/branch}","tags_url":"https://api.github.com/repos/karafka/karafka/tags","blobs_url":"https://api.github.com/repos/karafka/karafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karafka/karafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karafka/karafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/karafka/karafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karafka/karafka/statuses/{sha}","languages_url":"https://api.github.com/repos/karafka/karafka/languages","stargazers_url":"https://api.github.com/repos/karafka/karafka/stargazers","contributors_url":"https://api.github.com/repos/karafka/karafka/contributors","subscribers_url":"https://api.github.com/repos/karafka/karafka/subscribers","subscription_url":"https://api.github.com/repos/karafka/karafka/subscription","commits_url":"https://api.github.com/repos/karafka/karafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/karafka/karafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/karafka/karafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/karafka/karafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/karafka/karafka/contents/{+path}","compare_url":"https://api.github.com/repos/karafka/karafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karafka/karafka/merges","archive_url":"https://api.github.com/repos/karafka/karafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karafka/karafka/downloads","issues_url":"https://api.github.com/repos/karafka/karafka/issues{/number}","pulls_url":"https://api.github.com/repos/karafka/karafka/pulls{/number}","milestones_url":"https://api.github.com/repos/karafka/karafka/milestones{/number}","notifications_url":"https://api.github.com/repos/karafka/karafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karafka/karafka/labels{/name}","releases_url":"https://api.github.com/repos/karafka/karafka/releases{/id}","deployments_url":"https://api.github.com/repos/karafka/karafka/deployments","created_at":"2015-07-30T11:49:27Z","updated_at":"2018-05-25T10:30:04Z","pushed_at":"2018-05-25T16:54:26Z","git_url":"git://github.com/karafka/karafka.git","ssh_url":"git@github.com:karafka/karafka.git","clone_url":"https://github.com/karafka/karafka.git","svn_url":"https://github.com/karafka/karafka","homepage":"","size":1222,"stargazers_count":703,"watchers_count":703,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":54,"open_issues":13,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/karafka/karafka/pulls/349"},"html":{"href":"https://github.com/karafka/karafka/pull/349"},"issue":{"href":"https://api.github.com/repos/karafka/karafka/issues/349"},"comments":{"href":"https://api.github.com/repos/karafka/karafka/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/karafka/karafka/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/karafka/karafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/karafka/karafka/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/karafka/karafka/statuses/fc28fb1650d2955c589b268c114bb7f843cba0b5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 39947871,
"name": "karafka/karafka",
"url": "https://api.github.com/repos/karafka/karafka"
} | {
"id": 150547,
"login": "nijikon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/150547?",
"url": "https://api.github.com/users/nijikon"
} | {
"id": 13313336,
"login": "karafka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13313336?",
"url": "https://api.github.com/orgs/karafka"
} | 2018-05-25T17:15:48 | 7731181652 | {"actor":{"display_login":"nijikon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/207697395","pull_request_review_id":143370350,"id":207697395,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY5NzM5NQ==","diff_hunk":"@@ -8,6 +8,7 @@\n <listEntry value=\"1\"/>\n </listAttribute>\n <booleanAttribute key=\"org.eclipse.debug.ui.ATTR_LAUNCH_IN_BACKGROUND\" value=\"false\"/>\n+<stringAttribute key=\"org.eclipse.jdt.launching.CLASSPATH_PROVIDER\" value=\"org.eclipse.buildship.core.classpathprovider\"/>","path":"eclipse/launchers/GameRunner.launch","position":4,"original_position":4,"commit_id":"0c828534f2489b9c98e2fc7405da23b3ad511d0c","original_commit_id":"0c828534f2489b9c98e2fc7405da23b3ad511d0c","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"body":"This attribute was apparently added with Oxygen.3. This is the first time this launch configuration has been edited since the release of Oxygen.3. The other two launch configurations have been recently edited, and this attribute is already present in those files.","created_at":"2018-08-04T02:27:11Z","updated_at":"2018-08-04T02:27:15Z","html_url":"https://github.com/triplea-game/triplea/pull/3717#discussion_r207697395","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/3717","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/207697395"},"html":{"href":"https://github.com/triplea-game/triplea/pull/3717#discussion_r207697395"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/3717"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/3717","id":206170549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTcwNTQ5","html_url":"https://github.com/triplea-game/triplea/pull/3717","diff_url":"https://github.com/triplea-game/triplea/pull/3717.diff","patch_url":"https://github.com/triplea-game/triplea/pull/3717.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/3717","number":3717,"state":"open","locked":false,"title":"Rename Eclipse launch configurations","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nRenamed the `GameRunner` and `HeadlessGameServer` launch configurations. The qualifiers in the file names seem redundant, especially since there are no other variants for each `main` class.\r\n\r\n## Functional Changes\r\n\r\nNone.\r\n\r\n## Manual Testing Performed\r\n\r\nVerified both launch configurations run as expected from the IDE.","created_at":"2018-08-04T02:26:43Z","updated_at":"2018-08-04T02:27:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd1062e4870c4923d22311d080114a1aceaca419","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/3717/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/3717/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/3717/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/0c828534f2489b9c98e2fc7405da23b3ad511d0c","head":{"label":"ssoloff:rename-launch-configurations","ref":"rename-launch-configurations","sha":"0c828534f2489b9c98e2fc7405da23b3ad511d0c","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"repo":{"id":76764435,"node_id":"MDEwOlJlcG9zaXRvcnk3Njc2NDQzNQ==","name":"triplea-game-triplea","full_name":"ssoloff/triplea-game-triplea","owner":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssoloff/triplea-game-triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea","forks_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/forks","keys_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/teams","hooks_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/hooks","issue_events_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues/events{/number}","events_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/events","assignees_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/assignees{/user}","branches_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/branches{/branch}","tags_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/tags","blobs_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/languages","stargazers_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/stargazers","contributors_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/contributors","subscribers_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/subscribers","subscription_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/subscription","commits_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/contents/{+path}","compare_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/merges","archive_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/downloads","issues_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues{/number}","pulls_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/labels{/name}","releases_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/releases{/id}","deployments_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/deployments","created_at":"2016-12-18T05:24:33Z","updated_at":"2018-08-03T23:24:10Z","pushed_at":"2018-08-04T01:34:22Z","git_url":"git://github.com/ssoloff/triplea-game-triplea.git","ssh_url":"git@github.com:ssoloff/triplea-game-triplea.git","clone_url":"https://github.com/ssoloff/triplea-game-triplea.git","svn_url":"https://github.com/ssoloff/triplea-game-triplea","homepage":null,"size":739081,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"74ec9c4f2bae2edfc7d8a40b3105e018c27179a5","user":{"login":"triplea-game","id":13318615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NjE1","avatar_url":"https://avatars0.githubusercontent.com/u/13318615?v=4","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"node_id":"MDEwOlJlcG9zaXRvcnkzOTc2NjMwOA==","name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NjE1","avatar_url":"https://avatars0.githubusercontent.com/u/13318615?v=4","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/triplea-game/triplea/deployments","created_at":"2015-07-27T09:32:58Z","updated_at":"2018-08-03T23:20:49Z","pushed_at":"2018-08-04T02:26:44Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":"https://triplea-game.org/","size":747463,"stargazers_count":115,"watchers_count":115,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":55,"open_issues":108,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/3717"},"html":{"href":"https://github.com/triplea-game/triplea/pull/3717"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/3717"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/3717/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/3717/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/3717/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/0c828534f2489b9c98e2fc7405da23b3ad511d0c"}},"author_association":"MEMBER"}} | {
"id": 39766308,
"name": "triplea-game/triplea",
"url": "https://api.github.com/repos/triplea-game/triplea"
} | {
"id": 4826349,
"login": "ssoloff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4826349?",
"url": "https://api.github.com/users/ssoloff"
} | {
"id": 13318615,
"login": "triplea-game",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13318615?",
"url": "https://api.github.com/orgs/triplea-game"
} | 2018-08-04T02:27:11 | 8065507909 | {"actor":{"display_login":"ssoloff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/220792519","pull_request_review_id":159282554,"id":220792519,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDc5MjUxOQ==","diff_hunk":"@@ -358,253 +372,264 @@ public void refreshValue()\n \t}\n \n \t/**\n-\t *\tActionListener\n-\t * @param e ActionEvent\n+\t * ActionListener\n+\t * \n+\t * @param e ActionEvent\n \t */\n \t@Override\n \tpublic void actionPerformed(ActionEvent e)\n \t{\n-\t\t//\tWarehouse/Product\n-\t\tint only_Warehouse_ID = getOnly_Warehouse_ID();\n-\t\tint only_Product_ID = getOnly_Product_ID();\n-\t\tlog.info(\"Only Warehouse_ID=\" + only_Warehouse_ID\n-\t\t\t+ \", Product_ID=\" + only_Product_ID);\n-\n-\t\t//\tText Entry ok\n-\t\tif (e.getSource() == m_text \n-\t\t\t&& actionText(only_Warehouse_ID, only_Product_ID))\n+\t\t// Warehouse/Product\n+\t\tfinal WarehouseId only_Warehouse_ID = getOnly_Warehouse_ID();\n+\t\tfinal int only_Product_ID = getOnly_Product_ID();\n+\n+\t\t// Text Entry ok\n+\t\tif (e.getSource() == m_text\n+\t\t\t\t&& actionText(only_Warehouse_ID, only_Product_ID))\n \t\t\treturn;\n \n-\t\t//\t Button - Start Dialog\n+\t\t// Button - Start Dialog\n \t\tint M_Locator_ID = 0;\n \t\tif (m_value instanceof Integer)\n \t\t\tM_Locator_ID = ((Integer)m_value).intValue();\n \t\t//\n-\t\tm_mLocator.setOnly_Warehouse_ID(only_Warehouse_ID);\n+\t\tm_mLocator.setOnly_Warehouse_ID(WarehouseId.toRepoId(only_Warehouse_ID));\n \t\tm_mLocator.setOnly_Product_ID(getOnly_Product_ID());\n \t\tVLocatorDialog ld = new VLocatorDialog(SwingUtils.getFrame(this),\n-\t\t\tServices.get(IMsgBL.class).translate(Env.getCtx(), m_columnName),\n-\t\t\tm_mLocator, M_Locator_ID, isMandatory(), only_Warehouse_ID);\n-\t\t//\tdisplay\n+\t\t\t\tServices.get(IMsgBL.class).translate(Env.getCtx(), m_columnName),\n+\t\t\t\tm_mLocator, M_Locator_ID, isMandatory(),\n+\t\t\t\tonly_Warehouse_ID);\n+\t\t// display\n \t\tld.setVisible(true);\n \t\tm_mLocator.setOnly_Warehouse_ID(0);\n \n-\t\t//\tredisplay\n+\t\t// redisplay\n \t\tif (!ld.isChanged())\n \t\t\treturn;\n-\t\tsetValue (ld.getValue(), true);\n-\t}\t//\tactionPerformed\n+\t\tsetValue(ld.getValue(), true);\n+\t}\t// actionPerformed\n \n \t/**\n-\t * \tHit Enter in Text Field\n-\t * \t@param only_Warehouse_ID if not 0 restrict warehouse\n-\t * \t@param only_Product_ID of not 0 restricted product\n-\t * \t@return true if found\n+\t * Hit Enter in Text Field\n+\t * \n+\t * @param only_Warehouse_ID if not 0 restrict warehouse\n+\t * @param only_Product_ID of not 0 restricted product\n+\t * @return true if found\n \t */\n-\tprivate boolean actionText (int only_Warehouse_ID, int only_Product_ID)\n+\tprivate boolean actionText(final WarehouseId only_Warehouse_ID, final int only_Product_ID)","path":"de.metas.adempiere.adempiere/client/src/main/java-legacy/org/compiere/grid/ed/VLocator.java","position":510,"original_position":510,"commit_id":"429ec52b3d3471f681316a57a7df8e91a0d8ebfc","original_commit_id":"429ec52b3d3471f681316a57a7df8e91a0d8ebfc","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [The method actionText() has an NPath complexity of 896](https://app.codacy.com/app/metasfresh/metasfresh/pullRequest?prid=2177150)","created_at":"2018-09-27T04:48:59Z","updated_at":"2018-09-27T04:48:59Z","html_url":"https://github.com/metasfresh/metasfresh/pull/4578#discussion_r220792519","pull_request_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments/220792519"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4578#discussion_r220792519"},"pull_request":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578"}}},"pull_request":{"url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578","id":214841771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODQxNzcx","html_url":"https://github.com/metasfresh/metasfresh/pull/4578","diff_url":"https://github.com/metasfresh/metasfresh/pull/4578.diff","patch_url":"https://github.com/metasfresh/metasfresh/pull/4578.patch","issue_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4578","number":4578,"state":"open","locked":false,"title":"New Picking&Packing Workflow (gh4577)","user":{"login":"teosarca","id":1244701,"node_id":"MDQ6VXNlcjEyNDQ3MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1244701?v=4","gravatar_id":"","url":"https://api.github.com/users/teosarca","html_url":"https://github.com/teosarca","followers_url":"https://api.github.com/users/teosarca/followers","following_url":"https://api.github.com/users/teosarca/following{/other_user}","gists_url":"https://api.github.com/users/teosarca/gists{/gist_id}","starred_url":"https://api.github.com/users/teosarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teosarca/subscriptions","organizations_url":"https://api.github.com/users/teosarca/orgs","repos_url":"https://api.github.com/users/teosarca/repos","events_url":"https://api.github.com/users/teosarca/events{/privacy}","received_events_url":"https://api.github.com/users/teosarca/received_events","type":"User","site_admin":false},"body":"https://github.com/metasfresh/metasfresh/issues/4577","created_at":"2018-09-12T05:45:02Z","updated_at":"2018-09-27T04:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd53951aada5224d59617be3ec96fef24df2b461","assignee":{"login":"teosarca","id":1244701,"node_id":"MDQ6VXNlcjEyNDQ3MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1244701?v=4","gravatar_id":"","url":"https://api.github.com/users/teosarca","html_url":"https://github.com/teosarca","followers_url":"https://api.github.com/users/teosarca/followers","following_url":"https://api.github.com/users/teosarca/following{/other_user}","gists_url":"https://api.github.com/users/teosarca/gists{/gist_id}","starred_url":"https://api.github.com/users/teosarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teosarca/subscriptions","organizations_url":"https://api.github.com/users/teosarca/orgs","repos_url":"https://api.github.com/users/teosarca/repos","events_url":"https://api.github.com/users/teosarca/events{/privacy}","received_events_url":"https://api.github.com/users/teosarca/received_events","type":"User","site_admin":false},"assignees":[{"login":"teosarca","id":1244701,"node_id":"MDQ6VXNlcjEyNDQ3MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1244701?v=4","gravatar_id":"","url":"https://api.github.com/users/teosarca","html_url":"https://github.com/teosarca","followers_url":"https://api.github.com/users/teosarca/followers","following_url":"https://api.github.com/users/teosarca/following{/other_user}","gists_url":"https://api.github.com/users/teosarca/gists{/gist_id}","starred_url":"https://api.github.com/users/teosarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teosarca/subscriptions","organizations_url":"https://api.github.com/users/teosarca/orgs","repos_url":"https://api.github.com/users/teosarca/repos","events_url":"https://api.github.com/users/teosarca/events{/privacy}","received_events_url":"https://api.github.com/users/teosarca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578/commits","review_comments_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578/comments","review_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/4578/comments","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/429ec52b3d3471f681316a57a7df8e91a0d8ebfc","head":{"label":"metasfresh:gh4577","ref":"gh4577","sha":"429ec52b3d3471f681316a57a7df8e91a0d8ebfc","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","private":false,"owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-09-26T10:23:12Z","pushed_at":"2018-09-27T04:37:41Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":86496,"stargazers_count":247,"watchers_count":247,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":891,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":114,"open_issues":891,"watchers":247,"default_branch":"master"}},"base":{"label":"metasfresh:master","ref":"master","sha":"8bbc476b4403c0517dd9958172c5db4dceca1426","user":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"repo":{"id":43760104,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzc2MDEwNA==","name":"metasfresh","full_name":"metasfresh/metasfresh","private":false,"owner":{"login":"metasfresh","id":13364239,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzY0MjM5","avatar_url":"https://avatars3.githubusercontent.com/u/13364239?v=4","gravatar_id":"","url":"https://api.github.com/users/metasfresh","html_url":"https://github.com/metasfresh","followers_url":"https://api.github.com/users/metasfresh/followers","following_url":"https://api.github.com/users/metasfresh/following{/other_user}","gists_url":"https://api.github.com/users/metasfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/metasfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metasfresh/subscriptions","organizations_url":"https://api.github.com/users/metasfresh/orgs","repos_url":"https://api.github.com/users/metasfresh/repos","events_url":"https://api.github.com/users/metasfresh/events{/privacy}","received_events_url":"https://api.github.com/users/metasfresh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metasfresh/metasfresh","description":"Fast, Flexible & Free ERP for your Business Growth.","fork":false,"url":"https://api.github.com/repos/metasfresh/metasfresh","forks_url":"https://api.github.com/repos/metasfresh/metasfresh/forks","keys_url":"https://api.github.com/repos/metasfresh/metasfresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metasfresh/metasfresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metasfresh/metasfresh/teams","hooks_url":"https://api.github.com/repos/metasfresh/metasfresh/hooks","issue_events_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/events{/number}","events_url":"https://api.github.com/repos/metasfresh/metasfresh/events","assignees_url":"https://api.github.com/repos/metasfresh/metasfresh/assignees{/user}","branches_url":"https://api.github.com/repos/metasfresh/metasfresh/branches{/branch}","tags_url":"https://api.github.com/repos/metasfresh/metasfresh/tags","blobs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metasfresh/metasfresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metasfresh/metasfresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/metasfresh/metasfresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metasfresh/metasfresh/statuses/{sha}","languages_url":"https://api.github.com/repos/metasfresh/metasfresh/languages","stargazers_url":"https://api.github.com/repos/metasfresh/metasfresh/stargazers","contributors_url":"https://api.github.com/repos/metasfresh/metasfresh/contributors","subscribers_url":"https://api.github.com/repos/metasfresh/metasfresh/subscribers","subscription_url":"https://api.github.com/repos/metasfresh/metasfresh/subscription","commits_url":"https://api.github.com/repos/metasfresh/metasfresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/metasfresh/metasfresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/metasfresh/metasfresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/metasfresh/metasfresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/metasfresh/metasfresh/contents/{+path}","compare_url":"https://api.github.com/repos/metasfresh/metasfresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metasfresh/metasfresh/merges","archive_url":"https://api.github.com/repos/metasfresh/metasfresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metasfresh/metasfresh/downloads","issues_url":"https://api.github.com/repos/metasfresh/metasfresh/issues{/number}","pulls_url":"https://api.github.com/repos/metasfresh/metasfresh/pulls{/number}","milestones_url":"https://api.github.com/repos/metasfresh/metasfresh/milestones{/number}","notifications_url":"https://api.github.com/repos/metasfresh/metasfresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metasfresh/metasfresh/labels{/name}","releases_url":"https://api.github.com/repos/metasfresh/metasfresh/releases{/id}","deployments_url":"https://api.github.com/repos/metasfresh/metasfresh/deployments","created_at":"2015-10-06T15:38:11Z","updated_at":"2018-09-26T10:23:12Z","pushed_at":"2018-09-27T04:37:41Z","git_url":"git://github.com/metasfresh/metasfresh.git","ssh_url":"git@github.com:metasfresh/metasfresh.git","clone_url":"https://github.com/metasfresh/metasfresh.git","svn_url":"https://github.com/metasfresh/metasfresh","homepage":"http://metasfresh.com/en","size":86496,"stargazers_count":247,"watchers_count":247,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":891,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":114,"open_issues":891,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578"},"html":{"href":"https://github.com/metasfresh/metasfresh/pull/4578"},"issue":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4578"},"comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/issues/4578/comments"},"review_comments":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578/comments"},"review_comment":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metasfresh/metasfresh/pulls/4578/commits"},"statuses":{"href":"https://api.github.com/repos/metasfresh/metasfresh/statuses/429ec52b3d3471f681316a57a7df8e91a0d8ebfc"}},"author_association":"MEMBER"}} | {
"id": 43760104,
"name": "metasfresh/metasfresh",
"url": "https://api.github.com/repos/metasfresh/metasfresh"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 13364239,
"login": "metasfresh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13364239?",
"url": "https://api.github.com/orgs/metasfresh"
} | 2018-09-27T04:48:59 | 8329126655 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/comments/245068021","pull_request_review_id":189099043,"id":245068021,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA2ODAyMQ==","diff_hunk":"@@ -72,49 +72,15 @@ public function __construct($debug = false)\n *\n * @param string $message - description of the error\n * @param PDOException $e - exception object\n- * @param bool $fatal - should this error shutdown the script?\n- * @param bool $sendEmail - should Email about error should be send?","path":"Utils/Database/OcPdo.php","position":22,"original_position":22,"commit_id":"5c0b661890f705a7bffe0b755fc04e87aa4ec3eb","original_commit_id":"5c0b661890f705a7bffe0b755fc04e87aa4ec3eb","user":{"login":"following5","id":1614754,"node_id":"MDQ6VXNlcjE2MTQ3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1614754?v=4","gravatar_id":"","url":"https://api.github.com/users/following5","html_url":"https://github.com/following5","followers_url":"https://api.github.com/users/following5/followers","following_url":"https://api.github.com/users/following5/following{/other_user}","gists_url":"https://api.github.com/users/following5/gists{/gist_id}","starred_url":"https://api.github.com/users/following5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/following5/subscriptions","organizations_url":"https://api.github.com/users/following5/orgs","repos_url":"https://api.github.com/users/following5/repos","events_url":"https://api.github.com/users/following5/events{/privacy}","received_events_url":"https://api.github.com/users/following5/received_events","type":"User","site_admin":false},"body":"No more error classification here. Any call to this method will throw the same kind of Exception, which then can either be caught, or will ultimately be processed by the global error handler and abort the script.","created_at":"2019-01-03T17:08:07Z","updated_at":"2019-01-03T17:16:08Z","html_url":"https://github.com/opencaching/opencaching-pl/pull/1809#discussion_r245068021","pull_request_url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/comments/245068021"},"html":{"href":"https://github.com/opencaching/opencaching-pl/pull/1809#discussion_r245068021"},"pull_request":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809"}}},"pull_request":{"url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809","id":242054751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDU0NzUx","html_url":"https://github.com/opencaching/opencaching-pl/pull/1809","diff_url":"https://github.com/opencaching/opencaching-pl/pull/1809.diff","patch_url":"https://github.com/opencaching/opencaching-pl/pull/1809.patch","issue_url":"https://api.github.com/repos/opencaching/opencaching-pl/issues/1809","number":1809,"state":"open","locked":false,"title":"Add global error handler; rebase PDO error handling on that","user":{"login":"following5","id":1614754,"node_id":"MDQ6VXNlcjE2MTQ3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1614754?v=4","gravatar_id":"","url":"https://api.github.com/users/following5","html_url":"https://github.com/following5","followers_url":"https://api.github.com/users/following5/followers","following_url":"https://api.github.com/users/following5/following{/other_user}","gists_url":"https://api.github.com/users/following5/gists{/gist_id}","starred_url":"https://api.github.com/users/following5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/following5/subscriptions","organizations_url":"https://api.github.com/users/following5/orgs","repos_url":"https://api.github.com/users/following5/repos","events_url":"https://api.github.com/users/following5/events{/privacy}","received_events_url":"https://api.github.com/users/following5/received_events","type":"User","site_admin":false},"body":"This implements error handling as proposed in https://github.com/opencaching/opencaching-pl/issues/1792#issuecomment-450436586. It will handle anything except PHP syntax errors (E_PARSE), which cannot be caught.","created_at":"2019-01-03T17:04:12Z","updated_at":"2019-01-03T17:16:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b40cc1d18017ab64dfecb8c3546cd3d704f038d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809/commits","review_comments_url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809/comments","review_comment_url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencaching/opencaching-pl/issues/1809/comments","statuses_url":"https://api.github.com/repos/opencaching/opencaching-pl/statuses/5c0b661890f705a7bffe0b755fc04e87aa4ec3eb","head":{"label":"following5:errorhandler","ref":"errorhandler","sha":"5c0b661890f705a7bffe0b755fc04e87aa4ec3eb","user":{"login":"following5","id":1614754,"node_id":"MDQ6VXNlcjE2MTQ3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1614754?v=4","gravatar_id":"","url":"https://api.github.com/users/following5","html_url":"https://github.com/following5","followers_url":"https://api.github.com/users/following5/followers","following_url":"https://api.github.com/users/following5/following{/other_user}","gists_url":"https://api.github.com/users/following5/gists{/gist_id}","starred_url":"https://api.github.com/users/following5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/following5/subscriptions","organizations_url":"https://api.github.com/users/following5/orgs","repos_url":"https://api.github.com/users/following5/repos","events_url":"https://api.github.com/users/following5/events{/privacy}","received_events_url":"https://api.github.com/users/following5/received_events","type":"User","site_admin":false},"repo":{"id":42244802,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI0NDgwMg==","name":"opencaching-pl","full_name":"following5/opencaching-pl","private":false,"owner":{"login":"following5","id":1614754,"node_id":"MDQ6VXNlcjE2MTQ3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1614754?v=4","gravatar_id":"","url":"https://api.github.com/users/following5","html_url":"https://github.com/following5","followers_url":"https://api.github.com/users/following5/followers","following_url":"https://api.github.com/users/following5/following{/other_user}","gists_url":"https://api.github.com/users/following5/gists{/gist_id}","starred_url":"https://api.github.com/users/following5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/following5/subscriptions","organizations_url":"https://api.github.com/users/following5/orgs","repos_url":"https://api.github.com/users/following5/repos","events_url":"https://api.github.com/users/following5/events{/privacy}","received_events_url":"https://api.github.com/users/following5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/following5/opencaching-pl","description":"The source code of Opencaching.PL (and some other domains)","fork":true,"url":"https://api.github.com/repos/following5/opencaching-pl","forks_url":"https://api.github.com/repos/following5/opencaching-pl/forks","keys_url":"https://api.github.com/repos/following5/opencaching-pl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/following5/opencaching-pl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/following5/opencaching-pl/teams","hooks_url":"https://api.github.com/repos/following5/opencaching-pl/hooks","issue_events_url":"https://api.github.com/repos/following5/opencaching-pl/issues/events{/number}","events_url":"https://api.github.com/repos/following5/opencaching-pl/events","assignees_url":"https://api.github.com/repos/following5/opencaching-pl/assignees{/user}","branches_url":"https://api.github.com/repos/following5/opencaching-pl/branches{/branch}","tags_url":"https://api.github.com/repos/following5/opencaching-pl/tags","blobs_url":"https://api.github.com/repos/following5/opencaching-pl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/following5/opencaching-pl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/following5/opencaching-pl/git/refs{/sha}","trees_url":"https://api.github.com/repos/following5/opencaching-pl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/following5/opencaching-pl/statuses/{sha}","languages_url":"https://api.github.com/repos/following5/opencaching-pl/languages","stargazers_url":"https://api.github.com/repos/following5/opencaching-pl/stargazers","contributors_url":"https://api.github.com/repos/following5/opencaching-pl/contributors","subscribers_url":"https://api.github.com/repos/following5/opencaching-pl/subscribers","subscription_url":"https://api.github.com/repos/following5/opencaching-pl/subscription","commits_url":"https://api.github.com/repos/following5/opencaching-pl/commits{/sha}","git_commits_url":"https://api.github.com/repos/following5/opencaching-pl/git/commits{/sha}","comments_url":"https://api.github.com/repos/following5/opencaching-pl/comments{/number}","issue_comment_url":"https://api.github.com/repos/following5/opencaching-pl/issues/comments{/number}","contents_url":"https://api.github.com/repos/following5/opencaching-pl/contents/{+path}","compare_url":"https://api.github.com/repos/following5/opencaching-pl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/following5/opencaching-pl/merges","archive_url":"https://api.github.com/repos/following5/opencaching-pl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/following5/opencaching-pl/downloads","issues_url":"https://api.github.com/repos/following5/opencaching-pl/issues{/number}","pulls_url":"https://api.github.com/repos/following5/opencaching-pl/pulls{/number}","milestones_url":"https://api.github.com/repos/following5/opencaching-pl/milestones{/number}","notifications_url":"https://api.github.com/repos/following5/opencaching-pl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/following5/opencaching-pl/labels{/name}","releases_url":"https://api.github.com/repos/following5/opencaching-pl/releases{/id}","deployments_url":"https://api.github.com/repos/following5/opencaching-pl/deployments","created_at":"2015-09-10T13:02:44Z","updated_at":"2018-12-22T22:23:20Z","pushed_at":"2019-01-03T16:57:35Z","git_url":"git://github.com/following5/opencaching-pl.git","ssh_url":"git@github.com:following5/opencaching-pl.git","clone_url":"https://github.com/following5/opencaching-pl.git","svn_url":"https://github.com/following5/opencaching-pl","homepage":"http://opencaching.pl/","size":152357,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencaching:master","ref":"master","sha":"475b84bb334e9f9439c886d23b64472cb2f7617c","user":{"login":"opencaching","id":13405646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA1NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/13405646?v=4","gravatar_id":"","url":"https://api.github.com/users/opencaching","html_url":"https://github.com/opencaching","followers_url":"https://api.github.com/users/opencaching/followers","following_url":"https://api.github.com/users/opencaching/following{/other_user}","gists_url":"https://api.github.com/users/opencaching/gists{/gist_id}","starred_url":"https://api.github.com/users/opencaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencaching/subscriptions","organizations_url":"https://api.github.com/users/opencaching/orgs","repos_url":"https://api.github.com/users/opencaching/repos","events_url":"https://api.github.com/users/opencaching/events{/privacy}","received_events_url":"https://api.github.com/users/opencaching/received_events","type":"Organization","site_admin":false},"repo":{"id":39498924,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ5ODkyNA==","name":"opencaching-pl","full_name":"opencaching/opencaching-pl","private":false,"owner":{"login":"opencaching","id":13405646,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA1NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/13405646?v=4","gravatar_id":"","url":"https://api.github.com/users/opencaching","html_url":"https://github.com/opencaching","followers_url":"https://api.github.com/users/opencaching/followers","following_url":"https://api.github.com/users/opencaching/following{/other_user}","gists_url":"https://api.github.com/users/opencaching/gists{/gist_id}","starred_url":"https://api.github.com/users/opencaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencaching/subscriptions","organizations_url":"https://api.github.com/users/opencaching/orgs","repos_url":"https://api.github.com/users/opencaching/repos","events_url":"https://api.github.com/users/opencaching/events{/privacy}","received_events_url":"https://api.github.com/users/opencaching/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opencaching/opencaching-pl","description":"The source code of Opencaching.PL (and some other domains)","fork":false,"url":"https://api.github.com/repos/opencaching/opencaching-pl","forks_url":"https://api.github.com/repos/opencaching/opencaching-pl/forks","keys_url":"https://api.github.com/repos/opencaching/opencaching-pl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencaching/opencaching-pl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencaching/opencaching-pl/teams","hooks_url":"https://api.github.com/repos/opencaching/opencaching-pl/hooks","issue_events_url":"https://api.github.com/repos/opencaching/opencaching-pl/issues/events{/number}","events_url":"https://api.github.com/repos/opencaching/opencaching-pl/events","assignees_url":"https://api.github.com/repos/opencaching/opencaching-pl/assignees{/user}","branches_url":"https://api.github.com/repos/opencaching/opencaching-pl/branches{/branch}","tags_url":"https://api.github.com/repos/opencaching/opencaching-pl/tags","blobs_url":"https://api.github.com/repos/opencaching/opencaching-pl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencaching/opencaching-pl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencaching/opencaching-pl/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencaching/opencaching-pl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencaching/opencaching-pl/statuses/{sha}","languages_url":"https://api.github.com/repos/opencaching/opencaching-pl/languages","stargazers_url":"https://api.github.com/repos/opencaching/opencaching-pl/stargazers","contributors_url":"https://api.github.com/repos/opencaching/opencaching-pl/contributors","subscribers_url":"https://api.github.com/repos/opencaching/opencaching-pl/subscribers","subscription_url":"https://api.github.com/repos/opencaching/opencaching-pl/subscription","commits_url":"https://api.github.com/repos/opencaching/opencaching-pl/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencaching/opencaching-pl/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencaching/opencaching-pl/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencaching/opencaching-pl/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencaching/opencaching-pl/contents/{+path}","compare_url":"https://api.github.com/repos/opencaching/opencaching-pl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencaching/opencaching-pl/merges","archive_url":"https://api.github.com/repos/opencaching/opencaching-pl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencaching/opencaching-pl/downloads","issues_url":"https://api.github.com/repos/opencaching/opencaching-pl/issues{/number}","pulls_url":"https://api.github.com/repos/opencaching/opencaching-pl/pulls{/number}","milestones_url":"https://api.github.com/repos/opencaching/opencaching-pl/milestones{/number}","notifications_url":"https://api.github.com/repos/opencaching/opencaching-pl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencaching/opencaching-pl/labels{/name}","releases_url":"https://api.github.com/repos/opencaching/opencaching-pl/releases{/id}","deployments_url":"https://api.github.com/repos/opencaching/opencaching-pl/deployments","created_at":"2015-07-22T09:59:54Z","updated_at":"2019-01-02T23:11:45Z","pushed_at":"2019-01-03T17:04:12Z","git_url":"git://github.com/opencaching/opencaching-pl.git","ssh_url":"git@github.com:opencaching/opencaching-pl.git","clone_url":"https://github.com/opencaching/opencaching-pl.git","svn_url":"https://github.com/opencaching/opencaching-pl","homepage":"https://opencaching.pl/","size":152273,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":298,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":27,"open_issues":298,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809"},"html":{"href":"https://github.com/opencaching/opencaching-pl/pull/1809"},"issue":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/issues/1809"},"comments":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/issues/1809/comments"},"review_comments":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809/comments"},"review_comment":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/pulls/1809/commits"},"statuses":{"href":"https://api.github.com/repos/opencaching/opencaching-pl/statuses/5c0b661890f705a7bffe0b755fc04e87aa4ec3eb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 39498924,
"name": "opencaching/opencaching-pl",
"url": "https://api.github.com/repos/opencaching/opencaching-pl"
} | {
"id": 1614754,
"login": "following5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1614754?",
"url": "https://api.github.com/users/following5"
} | {
"id": 13405646,
"login": "opencaching",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13405646?",
"url": "https://api.github.com/orgs/opencaching"
} | 2019-01-03T17:08:07 | 8829885634 | {"actor":{"display_login":"following5"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/comments/220387766","pull_request_review_id":158782686,"id":220387766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDM4Nzc2Ng==","diff_hunk":"@@ -0,0 +1,116 @@\n+Python is an interpreted, object-oriented, high-level programming language with dynamic semantics.\n+Its high-level built in data structures, combined with dynamic typing and dynamic binding, \n+make it very attractive for Rapid Application Development, as well as for use as a scripting or \n+glue language to connect existing components together. Python's simple, easy to learn syntax \n+emphasizes readability and therefore reduces the cost of program maintenance. \n+\n+\n+## Python versions\n+Sherlock features two different versions of Python: 2.7 and 3.6.1. \n+The reason for the two versions is that some code, or modules, will only work with old features \n+of version 2 while most code with work on version 3. \n+The general consensus is to use Python 3 whenever you can, especially for most numerical based modules \n+(for example: numpy, scipy, tensorflow, keras, etc).\n+\n+You can load either version on Sherlock by doing the following:\n+ \n+```\n+$ ml python/3.6.1\n+```\n+For Python 3\n+\n+or\n+ \n+```\n+$ ml python/2.7.13\n+```\n+\n+If just load \"python\" without a version number, it will default to Python 2.7.\n+\n+\n+## Installing Python modules in your environment\n+Python supports modules and packages which allows programs to be modularity.\n+\n+Python provides a utility, called `pip`, that allows users to easily install modules \n+from its extensive library.\n+\n+To install Python modules from with `pip`, we recommend using the `--user` option \n+when installing so that it installs inside of your environment. \n+\n+For example: \n+```\n+$ pip install <module name> --user\n+```\n+\n+For Python 3, use `pip3`:\n+\n+```\n+$ pip3 install <module name> --user\n+```\n+\n+\n+### Install a list of modules using a requirement file\n+\n+Python's `pip` utility also allows you to install a list of modules by using a file called `requirements.txt`. \n+\n+In order to do this, create a text file called `requirements.txt` and place the module you would like to install on its own line like so:\n+```\n+numpy\n+scikit-learn\n+keras\n+tensorflow\n+```\n+\n+You can now install your modules like so:\n+```\n+$ pip3 install -r requirements.txt --user\n+```\n+\n+### Upgrading packages\n+\n+`Pip` can update a package by:\n+\n+```\n+$ pip3 install <module name> --upgrade --user\n+\n+```\n+\n+It even easier with a `requirements.txt` file:\n+\n+```\n+$ pip3 install -r requirements.txt --upgrade --user\n+\n+```\n+\n+### Anaconda\n+\n+`Anaconda` can be used in Sherlock by loading the module:\n+```\n+$ ml anaconda/5.0.0-py36\n+\n+```\n+\n+Although for installing modules we prefer using the `pip` utility on Sherlock. \n+\n+\n+### Uninstallation\n+\n+To uninstall a Python module:\n+\n+```\n+$ pip3 uninstall <module name> --upgrade --user","path":"src/docs/software/using/python.md","position":101,"original_position":101,"commit_id":"6e196ed739493510dbbf43ba15243962b04e4cfd","original_commit_id":"6e196ed739493510dbbf43ba15243962b04e4cfd","user":{"login":"kcgthb","id":186807,"node_id":"MDQ6VXNlcjE4NjgwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/186807?v=4","gravatar_id":"","url":"https://api.github.com/users/kcgthb","html_url":"https://github.com/kcgthb","followers_url":"https://api.github.com/users/kcgthb/followers","following_url":"https://api.github.com/users/kcgthb/following{/other_user}","gists_url":"https://api.github.com/users/kcgthb/gists{/gist_id}","starred_url":"https://api.github.com/users/kcgthb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcgthb/subscriptions","organizations_url":"https://api.github.com/users/kcgthb/orgs","repos_url":"https://api.github.com/users/kcgthb/repos","events_url":"https://api.github.com/users/kcgthb/events{/privacy}","received_events_url":"https://api.github.com/users/kcgthb/received_events","type":"User","site_admin":false},"body":"Don't know if `--upgrade` is a valid option for `pip uninstall`","created_at":"2018-09-25T23:34:06Z","updated_at":"2018-09-25T23:53:02Z","html_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5#discussion_r220387766","pull_request_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/comments/220387766"},"html":{"href":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5#discussion_r220387766"},"pull_request":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5","id":218133820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTMzODIw","html_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5","diff_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5.diff","patch_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5.patch","issue_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/5","number":5,"state":"open","locked":false,"title":"Randy edits","user":{"login":"romxero","id":1442911,"node_id":"MDQ6VXNlcjE0NDI5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1442911?v=4","gravatar_id":"","url":"https://api.github.com/users/romxero","html_url":"https://github.com/romxero","followers_url":"https://api.github.com/users/romxero/followers","following_url":"https://api.github.com/users/romxero/following{/other_user}","gists_url":"https://api.github.com/users/romxero/gists{/gist_id}","starred_url":"https://api.github.com/users/romxero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romxero/subscriptions","organizations_url":"https://api.github.com/users/romxero/orgs","repos_url":"https://api.github.com/users/romxero/repos","events_url":"https://api.github.com/users/romxero/events{/privacy}","received_events_url":"https://api.github.com/users/romxero/received_events","type":"User","site_admin":false},"body":"Python section for Sherlock documentation","created_at":"2018-09-25T22:06:33Z","updated_at":"2018-09-25T23:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87e9c1369fc030ef44e63bd8fe64cc52fc172bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5/commits","review_comments_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5/comments","review_comment_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/5/comments","statuses_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/statuses/6e196ed739493510dbbf43ba15243962b04e4cfd","head":{"label":"romxero:randy_edits","ref":"randy_edits","sha":"6e196ed739493510dbbf43ba15243962b04e4cfd","user":{"login":"romxero","id":1442911,"node_id":"MDQ6VXNlcjE0NDI5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1442911?v=4","gravatar_id":"","url":"https://api.github.com/users/romxero","html_url":"https://github.com/romxero","followers_url":"https://api.github.com/users/romxero/followers","following_url":"https://api.github.com/users/romxero/following{/other_user}","gists_url":"https://api.github.com/users/romxero/gists{/gist_id}","starred_url":"https://api.github.com/users/romxero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romxero/subscriptions","organizations_url":"https://api.github.com/users/romxero/orgs","repos_url":"https://api.github.com/users/romxero/repos","events_url":"https://api.github.com/users/romxero/events{/privacy}","received_events_url":"https://api.github.com/users/romxero/received_events","type":"User","site_admin":false},"repo":{"id":150291471,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyOTE0NzE=","name":"www.sherlock.stanford.edu","full_name":"romxero/www.sherlock.stanford.edu","private":false,"owner":{"login":"romxero","id":1442911,"node_id":"MDQ6VXNlcjE0NDI5MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1442911?v=4","gravatar_id":"","url":"https://api.github.com/users/romxero","html_url":"https://github.com/romxero","followers_url":"https://api.github.com/users/romxero/followers","following_url":"https://api.github.com/users/romxero/following{/other_user}","gists_url":"https://api.github.com/users/romxero/gists{/gist_id}","starred_url":"https://api.github.com/users/romxero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romxero/subscriptions","organizations_url":"https://api.github.com/users/romxero/orgs","repos_url":"https://api.github.com/users/romxero/repos","events_url":"https://api.github.com/users/romxero/events{/privacy}","received_events_url":"https://api.github.com/users/romxero/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romxero/www.sherlock.stanford.edu","description":"The Sherlock website","fork":true,"url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu","forks_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/forks","keys_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/teams","hooks_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/hooks","issue_events_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/issues/events{/number}","events_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/events","assignees_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/assignees{/user}","branches_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/branches{/branch}","tags_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/tags","blobs_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/git/refs{/sha}","trees_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/statuses/{sha}","languages_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/languages","stargazers_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/stargazers","contributors_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/contributors","subscribers_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/subscribers","subscription_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/subscription","commits_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/commits{/sha}","git_commits_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/git/commits{/sha}","comments_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/comments{/number}","issue_comment_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/issues/comments{/number}","contents_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/contents/{+path}","compare_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/merges","archive_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/downloads","issues_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/issues{/number}","pulls_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/pulls{/number}","milestones_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/milestones{/number}","notifications_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/labels{/name}","releases_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/releases{/id}","deployments_url":"https://api.github.com/repos/romxero/www.sherlock.stanford.edu/deployments","created_at":"2018-09-25T15:52:35Z","updated_at":"2018-09-25T15:52:37Z","pushed_at":"2018-09-25T22:03:51Z","git_url":"git://github.com/romxero/www.sherlock.stanford.edu.git","ssh_url":"git@github.com:romxero/www.sherlock.stanford.edu.git","clone_url":"https://github.com/romxero/www.sherlock.stanford.edu.git","svn_url":"https://github.com/romxero/www.sherlock.stanford.edu","homepage":"https://www.sherlock.stanford.edu","size":49382,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"docs"}},"base":{"label":"stanford-rc:docs","ref":"docs","sha":"dcc22086df9a1c0e4fe42088d72604d3c3b5ce32","user":{"login":"stanford-rc","id":13439289,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDM5Mjg5","avatar_url":"https://avatars3.githubusercontent.com/u/13439289?v=4","gravatar_id":"","url":"https://api.github.com/users/stanford-rc","html_url":"https://github.com/stanford-rc","followers_url":"https://api.github.com/users/stanford-rc/followers","following_url":"https://api.github.com/users/stanford-rc/following{/other_user}","gists_url":"https://api.github.com/users/stanford-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/stanford-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanford-rc/subscriptions","organizations_url":"https://api.github.com/users/stanford-rc/orgs","repos_url":"https://api.github.com/users/stanford-rc/repos","events_url":"https://api.github.com/users/stanford-rc/events{/privacy}","received_events_url":"https://api.github.com/users/stanford-rc/received_events","type":"Organization","site_admin":false},"repo":{"id":128125149,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMjUxNDk=","name":"www.sherlock.stanford.edu","full_name":"stanford-rc/www.sherlock.stanford.edu","private":false,"owner":{"login":"stanford-rc","id":13439289,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDM5Mjg5","avatar_url":"https://avatars3.githubusercontent.com/u/13439289?v=4","gravatar_id":"","url":"https://api.github.com/users/stanford-rc","html_url":"https://github.com/stanford-rc","followers_url":"https://api.github.com/users/stanford-rc/followers","following_url":"https://api.github.com/users/stanford-rc/following{/other_user}","gists_url":"https://api.github.com/users/stanford-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/stanford-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanford-rc/subscriptions","organizations_url":"https://api.github.com/users/stanford-rc/orgs","repos_url":"https://api.github.com/users/stanford-rc/repos","events_url":"https://api.github.com/users/stanford-rc/events{/privacy}","received_events_url":"https://api.github.com/users/stanford-rc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu","description":"The Sherlock website","fork":false,"url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu","forks_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/forks","keys_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/teams","hooks_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/hooks","issue_events_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/events{/number}","events_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/events","assignees_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/assignees{/user}","branches_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/branches{/branch}","tags_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/tags","blobs_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/git/refs{/sha}","trees_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/statuses/{sha}","languages_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/languages","stargazers_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/stargazers","contributors_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/contributors","subscribers_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/subscribers","subscription_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/subscription","commits_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/commits{/sha}","git_commits_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/git/commits{/sha}","comments_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/comments{/number}","issue_comment_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/comments{/number}","contents_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/contents/{+path}","compare_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/merges","archive_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/downloads","issues_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues{/number}","pulls_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls{/number}","milestones_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/milestones{/number}","notifications_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/labels{/name}","releases_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/releases{/id}","deployments_url":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/deployments","created_at":"2018-04-04T21:38:03Z","updated_at":"2018-09-21T23:22:08Z","pushed_at":"2018-09-25T22:06:34Z","git_url":"git://github.com/stanford-rc/www.sherlock.stanford.edu.git","ssh_url":"git@github.com:stanford-rc/www.sherlock.stanford.edu.git","clone_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu.git","svn_url":"https://github.com/stanford-rc/www.sherlock.stanford.edu","homepage":"https://www.sherlock.stanford.edu","size":49379,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"docs"}},"_links":{"self":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5"},"html":{"href":"https://github.com/stanford-rc/www.sherlock.stanford.edu/pull/5"},"issue":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/5"},"comments":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu/statuses/6e196ed739493510dbbf43ba15243962b04e4cfd"}},"author_association":"NONE"}} | {
"id": 128125149,
"name": "stanford-rc/www.sherlock.stanford.edu",
"url": "https://api.github.com/repos/stanford-rc/www.sherlock.stanford.edu"
} | {
"id": 186807,
"login": "kcgthb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/186807?",
"url": "https://api.github.com/users/kcgthb"
} | {
"id": 13439289,
"login": "stanford-rc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13439289?",
"url": "https://api.github.com/orgs/stanford-rc"
} | 2018-09-25T23:34:06 | 8321387665 | {"actor":{"display_login":"kcgthb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments/198598220","pull_request_review_id":132556409,"id":198598220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODU5ODIyMA==","diff_hunk":"@@ -598,90 +620,11 @@ func TestSdkCredentialEnumerateAzureSuccess(t *testing.T) {\n \t\t// Setup client\n \tc := api.NewOpenStorageCredentialsClient(s.Conn())\n \n-\t// Enumerate Azure Credentials\n-\tresp, err := c.EnumerateForAzure(context.Background(), req)\n+\t// Inspect\n+\tresp, err := c.Inspect(context.Background(), req)","path":"api/server/sdk/credentials_test.go","position":471,"original_position":471,"commit_id":"0ae41818927dedbb7a0a303a96d798d7b5c22456","original_commit_id":"0ae41818927dedbb7a0a303a96d798d7b5c22456","user":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"body":"Actually, there is an example on line 627, but I'll add more info to the proto file docs.","created_at":"2018-06-27T18:31:21Z","updated_at":"2018-06-27T18:31:22Z","html_url":"https://github.com/libopenstorage/openstorage/pull/486#discussion_r198598220","pull_request_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments/198598220"},"html":{"href":"https://github.com/libopenstorage/openstorage/pull/486#discussion_r198598220"},"pull_request":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486"}},"in_reply_to_id":198438446},"pull_request":{"url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486","id":197165195,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTY1MTk1","html_url":"https://github.com/libopenstorage/openstorage/pull/486","diff_url":"https://github.com/libopenstorage/openstorage/pull/486.diff","patch_url":"https://github.com/libopenstorage/openstorage/pull/486.patch","issue_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/486","number":486,"state":"open","locked":false,"title":"sdk: Rework credentials apis","user":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nInstead of having an API per credential type, we now use the OneOf tags in proto files, making it much easier to use and implement.\r\n\r\n**Which issue(s) this PR fixes** (optional)\r\nCloses #469 \r\nPart of #407 \r\n\r\n**Special notes for your reviewer**:\r\n* Added Inspect call.\r\n* Generated files moved to their own commit.","created_at":"2018-06-25T16:14:38Z","updated_at":"2018-06-27T18:31:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"999c5e1f9a00efe5d54947742806b7056a2f0341","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ipochi","id":6972950,"node_id":"MDQ6VXNlcjY5NzI5NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/6972950?v=4","gravatar_id":"","url":"https://api.github.com/users/ipochi","html_url":"https://github.com/ipochi","followers_url":"https://api.github.com/users/ipochi/followers","following_url":"https://api.github.com/users/ipochi/following{/other_user}","gists_url":"https://api.github.com/users/ipochi/gists{/gist_id}","starred_url":"https://api.github.com/users/ipochi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipochi/subscriptions","organizations_url":"https://api.github.com/users/ipochi/orgs","repos_url":"https://api.github.com/users/ipochi/repos","events_url":"https://api.github.com/users/ipochi/events{/privacy}","received_events_url":"https://api.github.com/users/ipochi/received_events","type":"User","site_admin":false},{"login":"talakad","id":13106822,"node_id":"MDQ6VXNlcjEzMTA2ODIy","avatar_url":"https://avatars3.githubusercontent.com/u/13106822?v=4","gravatar_id":"","url":"https://api.github.com/users/talakad","html_url":"https://github.com/talakad","followers_url":"https://api.github.com/users/talakad/followers","following_url":"https://api.github.com/users/talakad/following{/other_user}","gists_url":"https://api.github.com/users/talakad/gists{/gist_id}","starred_url":"https://api.github.com/users/talakad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talakad/subscriptions","organizations_url":"https://api.github.com/users/talakad/orgs","repos_url":"https://api.github.com/users/talakad/repos","events_url":"https://api.github.com/users/talakad/events{/privacy}","received_events_url":"https://api.github.com/users/talakad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/486/comments","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/0ae41818927dedbb7a0a303a96d798d7b5c22456","head":{"label":"lpabon:b469","ref":"b469","sha":"0ae41818927dedbb7a0a303a96d798d7b5c22456","user":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"repo":{"id":104810652,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4MTA2NTI=","name":"openstorage","full_name":"lpabon/openstorage","owner":{"login":"lpabon","id":3880001,"node_id":"MDQ6VXNlcjM4ODAwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/3880001?v=4","gravatar_id":"","url":"https://api.github.com/users/lpabon","html_url":"https://github.com/lpabon","followers_url":"https://api.github.com/users/lpabon/followers","following_url":"https://api.github.com/users/lpabon/following{/other_user}","gists_url":"https://api.github.com/users/lpabon/gists{/gist_id}","starred_url":"https://api.github.com/users/lpabon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpabon/subscriptions","organizations_url":"https://api.github.com/users/lpabon/orgs","repos_url":"https://api.github.com/users/lpabon/repos","events_url":"https://api.github.com/users/lpabon/events{/privacy}","received_events_url":"https://api.github.com/users/lpabon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpabon/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":true,"url":"https://api.github.com/repos/lpabon/openstorage","forks_url":"https://api.github.com/repos/lpabon/openstorage/forks","keys_url":"https://api.github.com/repos/lpabon/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpabon/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpabon/openstorage/teams","hooks_url":"https://api.github.com/repos/lpabon/openstorage/hooks","issue_events_url":"https://api.github.com/repos/lpabon/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/lpabon/openstorage/events","assignees_url":"https://api.github.com/repos/lpabon/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/lpabon/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/lpabon/openstorage/tags","blobs_url":"https://api.github.com/repos/lpabon/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpabon/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpabon/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpabon/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpabon/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/lpabon/openstorage/languages","stargazers_url":"https://api.github.com/repos/lpabon/openstorage/stargazers","contributors_url":"https://api.github.com/repos/lpabon/openstorage/contributors","subscribers_url":"https://api.github.com/repos/lpabon/openstorage/subscribers","subscription_url":"https://api.github.com/repos/lpabon/openstorage/subscription","commits_url":"https://api.github.com/repos/lpabon/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpabon/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpabon/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpabon/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpabon/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/lpabon/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpabon/openstorage/merges","archive_url":"https://api.github.com/repos/lpabon/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpabon/openstorage/downloads","issues_url":"https://api.github.com/repos/lpabon/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/lpabon/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/lpabon/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/lpabon/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpabon/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/lpabon/openstorage/releases{/id}","deployments_url":"https://api.github.com/repos/lpabon/openstorage/deployments","created_at":"2017-09-25T23:03:33Z","updated_at":"2017-09-25T23:03:35Z","pushed_at":"2018-06-27T04:51:18Z","git_url":"git://github.com/lpabon/openstorage.git","ssh_url":"git@github.com:lpabon/openstorage.git","clone_url":"https://github.com/lpabon/openstorage.git","svn_url":"https://github.com/lpabon/openstorage","homepage":"","size":22099,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"7acd0b5f00855b98a509ed0d0735655aa232d0ec","user":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39651750,"node_id":"MDEwOlJlcG9zaXRvcnkzOTY1MTc1MA==","name":"openstorage","full_name":"libopenstorage/openstorage","owner":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/openstorage","description":"A multi-host clustered implementation of the open storage specification","fork":false,"url":"https://api.github.com/repos/libopenstorage/openstorage","forks_url":"https://api.github.com/repos/libopenstorage/openstorage/forks","keys_url":"https://api.github.com/repos/libopenstorage/openstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/openstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/openstorage/teams","hooks_url":"https://api.github.com/repos/libopenstorage/openstorage/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/openstorage/events","assignees_url":"https://api.github.com/repos/libopenstorage/openstorage/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/openstorage/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/openstorage/tags","blobs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/openstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/openstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/openstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/openstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/openstorage/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/openstorage/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/openstorage/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/openstorage/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/openstorage/subscription","commits_url":"https://api.github.com/repos/libopenstorage/openstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/openstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/openstorage/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/openstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/openstorage/merges","archive_url":"https://api.github.com/repos/libopenstorage/openstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/openstorage/downloads","issues_url":"https://api.github.com/repos/libopenstorage/openstorage/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/openstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/openstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/openstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/openstorage/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/openstorage/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/openstorage/deployments","created_at":"2015-07-24T19:01:34Z","updated_at":"2018-06-27T05:39:15Z","pushed_at":"2018-06-27T16:09:00Z","git_url":"git://github.com/libopenstorage/openstorage.git","ssh_url":"git@github.com:libopenstorage/openstorage.git","clone_url":"https://github.com/libopenstorage/openstorage.git","svn_url":"https://github.com/libopenstorage/openstorage","homepage":"","size":21987,"stargazers_count":291,"watchers_count":291,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":84,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486"},"html":{"href":"https://github.com/libopenstorage/openstorage/pull/486"},"issue":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/486"},"comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/openstorage/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/openstorage/statuses/0ae41818927dedbb7a0a303a96d798d7b5c22456"}},"author_association":"MEMBER"}} | {
"id": 39651750,
"name": "libopenstorage/openstorage",
"url": "https://api.github.com/repos/libopenstorage/openstorage"
} | {
"id": 3880001,
"login": "lpabon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3880001?",
"url": "https://api.github.com/users/lpabon"
} | {
"id": 13478636,
"login": "libopenstorage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13478636?",
"url": "https://api.github.com/orgs/libopenstorage"
} | 2018-06-27T18:31:21 | 7887452375 | {"actor":{"display_login":"lpabon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/202217396","pull_request_review_id":136869097,"id":202217396,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIxNzM5Ng==","diff_hunk":"@@ -149,28 +137,108 @@ func TestDevicePluginReRegistration(t *testing.T) {\n \t\trequire.Equal(t, 2, len(devices2[testResourceName]), \"Devices shouldn't change.\")\n \n \t\t// Test the scenario that a plugin re-registers with different devices.\n-\t\tp3 := NewDevicePluginStub(devsForRegistration, pluginSocketName+\".third\")\n+\t\tp3 := NewDevicePluginStub(devsForRegistration, pluginSocketName+\".third\", testResourceName, preStartContainerFlag)\n \t\terr = p3.Start()\n \t\trequire.NoError(t, err)\n \t\tatomic.StoreInt32(&expCallbackCount, 3)\n-\t\tp3.Register(socketName, testResourceName, preStartContainerFlag)\n+\t\tp3.Register(socketName, testResourceName)\n \t\t// Wait for the second callback to be issued.\n \t\tselect {\n \t\tcase <-callbackChan:\n \t\t\tbreak\n \t\tcase <-time.After(time.Second):\n \t\t\tt.FailNow()\n \t\t}\n+\n \t\tdevices3 := m.Devices()\n \t\trequire.Equal(t, 1, len(devices3[testResourceName]), \"Devices of plugin previously registered should be removed.\")\n \t\tp2.Stop()\n \t\tp3.Stop()\n-\t\tcleanup(t, m, p1)\n+\t\tcleanup(t, m, p1, nil)\n \t\tclose(callbackChan)\n+\n+\t}\n+}\n+\n+// Tests that the device plugin manager correctly handles registration and re-registration by\n+// making sure that after registration, devices are correctly updated and if a re-registration\n+// happens, we will NOT delete devices; and no orphaned devices left.\n+// While testing above scenario, plugin discovery and registration will be done using\n+// Kubelet probe based mechanism\n+func TestDevicePluginReRegistrationProbeMode(t *testing.T) {\n+\tsocketDir, socketName, pluginSocketName, err := tmpSocketDir()\n+\trequire.NoError(t, err)\n+\tdefer os.RemoveAll(socketDir)\n+\tdevs := []*pluginapi.Device{\n+\t\t{ID: \"Dev1\", Health: pluginapi.Healthy},\n+\t\t{ID: \"Dev2\", Health: pluginapi.Healthy},\n+\t}\n+\tdevsForRegistration := []*pluginapi.Device{\n+\t\t{ID: \"Dev3\", Health: pluginapi.Healthy},\n+\t}\n+\n+\texpCallbackCount := int32(0)\n+\tcallbackCount := int32(0)\n+\tcallbackChan := make(chan int32)\n+\tcallback := func(n string, a, u, r []pluginapi.Device) {\n+\t\tcallbackCount++\n+\t\tif callbackCount > atomic.LoadInt32(&expCallbackCount) {\n+\t\t\tt.FailNow()\n+\t\t}\n+\t\tcallbackChan <- callbackCount\n+\t}\n+\tm, p1, w := setupInProbeMode(t, devs, callback, socketName, pluginSocketName)\n+\tatomic.StoreInt32(&expCallbackCount, 1)\n+\t//p1.Register(socketName, testResourceName)\n+\t// Wait for the first callback to be issued.\n+\tselect {\n+\tcase <-callbackChan:\n+\t\tbreak\n+\tcase <-time.After(time.Second):\n+\t\tt.FailNow()\n \t}\n+\tdevices := m.Devices()\n+\trequire.Equal(t, 2, len(devices[testResourceName]), \"Devices are not updated.\")\n+\n+\tp2 := NewDevicePluginStub(devs, pluginSocketName+\".new\", testResourceName, false)\n+\terr = p2.Start()\n+\trequire.NoError(t, err)\n+\tatomic.StoreInt32(&expCallbackCount, 2)\n+\t//p2.Register(socketName, testResourceName)","path":"pkg/kubelet/cm/devicemanager/manager_test.go","position":156,"original_position":156,"commit_id":"dd23c209d63da5bdb87ad06d2a6b51081bdca94e","original_commit_id":"dd23c209d63da5bdb87ad06d2a6b51081bdca94e","user":{"login":"jiayingz","id":29497748,"node_id":"MDQ6VXNlcjI5NDk3NzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"body":"remove this line?","created_at":"2018-07-13T00:36:41Z","updated_at":"2018-07-13T01:01:37Z","html_url":"https://github.com/kubernetes/kubernetes/pull/58755#discussion_r202217396","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/202217396"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/58755#discussion_r202217396"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755","id":164909591,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY0OTA5NTkx","html_url":"https://github.com/kubernetes/kubernetes/pull/58755","diff_url":"https://github.com/kubernetes/kubernetes/pull/58755.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58755.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58755","number":58755,"state":"open","locked":false,"title":"Use probe based plugin watcher mechanism in Device Manager","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nUses this probe based utility in the device plugin manager.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #56944 \r\n\r\n**Notes For Reviewers**:\r\nChanges are backward compatible and existing device plugins will continue to work. At the same time, any new plugins that has required support for probing model (Identity service implementation), will also work. \r\n\r\n\r\n**Release note**\r\n```release-note\r\nAdd support kubelet plugin watcher in device manager.\r\n```\r\n/sig node\r\n/area hw-accelerators\r\n/cc /cc @jiayingz @RenaudWasTaken @vishh @ScorpioCPH @sjenning @derekwaynecarr @jeremyeder @lichuqiang @tengqm @saad-ali @chakri-nelluri @ConnorDoyle ","created_at":"2018-01-24T17:13:25Z","updated_at":"2018-07-13T01:01:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09bfea857bed33dbd205df57ee1ca9ca4f388c33","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mindprince","id":695290,"node_id":"MDQ6VXNlcjY5NTI5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},{"login":"yifan-gu","id":3278588,"node_id":"MDQ6VXNlcjMyNzg1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3278588?v=4","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},{"login":"Random-Liu","id":5821883,"node_id":"MDQ6VXNlcjU4MjE4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":644163893,"node_id":"MDU6TGFiZWw2NDQxNjM4OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/hw-accelerators","name":"area/hw-accelerators","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58755/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dd23c209d63da5bdb87ad06d2a6b51081bdca94e","head":{"label":"vikaschoudhary16:probing-mode","ref":"probing-mode","sha":"dd23c209d63da5bdb87ad06d2a6b51081bdca94e","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"repo":{"id":70860655,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg2MDY1NQ==","name":"kubernetes","full_name":"vikaschoudhary16/kubernetes","owner":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikaschoudhary16/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/vikaschoudhary16/kubernetes","forks_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/forks","keys_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/teams","hooks_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/events","assignees_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/tags","blobs_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/subscription","commits_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/merges","archive_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/downloads","issues_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vikaschoudhary16/kubernetes/deployments","created_at":"2016-10-14T00:56:54Z","updated_at":"2018-07-09T09:48:59Z","pushed_at":"2018-07-09T09:48:52Z","git_url":"git://github.com/vikaschoudhary16/kubernetes.git","ssh_url":"git@github.com:vikaschoudhary16/kubernetes.git","clone_url":"https://github.com/vikaschoudhary16/kubernetes.git","svn_url":"https://github.com/vikaschoudhary16/kubernetes","homepage":"http://kubernetes.io","size":562594,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c5967fbb7400b3bd1fce65df508c661fb0a15aed","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-07-13T00:59:51Z","pushed_at":"2018-07-13T00:57:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":792911,"stargazers_count":38659,"watchers_count":38659,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13521,"mirror_url":null,"archived":false,"open_issues_count":3087,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13521,"open_issues":3087,"watchers":38659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/58755"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/58755"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/58755/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58755/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/dd23c209d63da5bdb87ad06d2a6b51081bdca94e"}},"author_association":"MEMBER"}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 29497748,
"login": "jiayingz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29497748?",
"url": "https://api.github.com/users/jiayingz"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-07-13T00:36:41 | 7959470579 | {"actor":{"display_login":"jiayingz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/sig-release/pulls/comments/193830288","pull_request_review_id":126883360,"id":193830288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzgzMDI4OA==","diff_hunk":"@@ -1,13 +1,13 @@\n | **Role** | **Name** (**GitHub / Slack ID**) | **Shadow Name(s) (GitHub / Slack ID)** |\n | ------ | ------ | ------ |\n-| Lead |||\n-| Features | Stephen Augustus ([@justaugustus](https://github.com/justaugustus)) ||\n-| CI Signal |||\n-| Test Infra |||\n+| Lead | Tim Pepper ([@tpepper](https://github.com/tpepper)) | Aishwarya Sundar ([@AishSundar](https://github.com/AishSundar)) |\n+| Features | Stephen Augustus ([@justaugustus](https://github.com/justaugustus)) | Kendrick Coleman ([@kacole2](https://github.com/kacole2)) |\n+| CI Signal || Christian Hernandez ([@christianh814](https://github.com/christianh814)) |\n+| Test Infra | Cole Wagner ([@cjwagner](https://github.com/cjwagner)) | Amit Watve ([@amwat](https://github.com/amwat)) |\n | Bug Triage |||\n | Branch Manager |||\n-| Docs |||\n+| Docs | Zach Arnold ([@zparnold](https://github.com/zparnold)) | Samuel Tauil ([@samueltauil](https://github.com/samueltauil)) |\n | Release Notes |||\n-| Communications |||\n+| Communications | Kaitlyn Barnard ([@kbarnard10](https://github.com/kbarnard10)) ||\n | Patch Release Manager |||","path":"releases/release-1.12/release_team.md","position":18,"original_position":18,"commit_id":"92844cfcde061b254314ee480c56398bcaaf942f","original_commit_id":"92844cfcde061b254314ee480c56398bcaaf942f","user":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"body":"Sounds good, @feiskyer. Thanks for volunteering!","created_at":"2018-06-07T17:32:46Z","updated_at":"2018-06-07T17:32:47Z","html_url":"https://github.com/kubernetes/sig-release/pull/168#discussion_r193830288","pull_request_url":"https://api.github.com/repos/kubernetes/sig-release/pulls/168","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/comments/193830288"},"html":{"href":"https://github.com/kubernetes/sig-release/pull/168#discussion_r193830288"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/168"}},"in_reply_to_id":193792906},"pull_request":{"url":"https://api.github.com/repos/kubernetes/sig-release/pulls/168","id":192854868,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODU0ODY4","html_url":"https://github.com/kubernetes/sig-release/pull/168","diff_url":"https://github.com/kubernetes/sig-release/pull/168.diff","patch_url":"https://github.com/kubernetes/sig-release/pull/168.patch","issue_url":"https://api.github.com/repos/kubernetes/sig-release/issues/168","number":168,"state":"open","locked":false,"title":"Add first-round drafts for k8s 1.12 Release Team","user":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"body":"ref: #167 \r\n\r\n/assign @tpepper @jberkus @jdumars \r\n/cc @tpepper @AishSundar @kacole2\r\n\r\nSigned-off-by: Stephen Augustus <foo@agst.us>","created_at":"2018-06-05T22:35:10Z","updated_at":"2018-06-07T17:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bef7b4f828becfacd9470dbd53b3073cd6626f81","assignee":{"login":"jberkus","id":115146,"node_id":"MDQ6VXNlcjExNTE0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/115146?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkus","html_url":"https://github.com/jberkus","followers_url":"https://api.github.com/users/jberkus/followers","following_url":"https://api.github.com/users/jberkus/following{/other_user}","gists_url":"https://api.github.com/users/jberkus/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkus/subscriptions","organizations_url":"https://api.github.com/users/jberkus/orgs","repos_url":"https://api.github.com/users/jberkus/repos","events_url":"https://api.github.com/users/jberkus/events{/privacy}","received_events_url":"https://api.github.com/users/jberkus/received_events","type":"User","site_admin":false},"assignees":[{"login":"jberkus","id":115146,"node_id":"MDQ6VXNlcjExNTE0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/115146?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkus","html_url":"https://github.com/jberkus","followers_url":"https://api.github.com/users/jberkus/followers","following_url":"https://api.github.com/users/jberkus/following{/other_user}","gists_url":"https://api.github.com/users/jberkus/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkus/subscriptions","organizations_url":"https://api.github.com/users/jberkus/orgs","repos_url":"https://api.github.com/users/jberkus/repos","events_url":"https://api.github.com/users/jberkus/events{/privacy}","received_events_url":"https://api.github.com/users/jberkus/received_events","type":"User","site_admin":false},{"login":"jdumars","id":1085157,"node_id":"MDQ6VXNlcjEwODUxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1085157?v=4","gravatar_id":"","url":"https://api.github.com/users/jdumars","html_url":"https://github.com/jdumars","followers_url":"https://api.github.com/users/jdumars/followers","following_url":"https://api.github.com/users/jdumars/following{/other_user}","gists_url":"https://api.github.com/users/jdumars/gists{/gist_id}","starred_url":"https://api.github.com/users/jdumars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdumars/subscriptions","organizations_url":"https://api.github.com/users/jdumars/orgs","repos_url":"https://api.github.com/users/jdumars/repos","events_url":"https://api.github.com/users/jdumars/events{/privacy}","received_events_url":"https://api.github.com/users/jdumars/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tpepper","id":2745300,"node_id":"MDQ6VXNlcjI3NDUzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2745300?v=4","gravatar_id":"","url":"https://api.github.com/users/tpepper","html_url":"https://github.com/tpepper","followers_url":"https://api.github.com/users/tpepper/followers","following_url":"https://api.github.com/users/tpepper/following{/other_user}","gists_url":"https://api.github.com/users/tpepper/gists{/gist_id}","starred_url":"https://api.github.com/users/tpepper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpepper/subscriptions","organizations_url":"https://api.github.com/users/tpepper/orgs","repos_url":"https://api.github.com/users/tpepper/repos","events_url":"https://api.github.com/users/tpepper/events{/privacy}","received_events_url":"https://api.github.com/users/tpepper/received_events","type":"User","site_admin":false},{"login":"AishSundar","id":20229685,"node_id":"MDQ6VXNlcjIwMjI5Njg1","avatar_url":"https://avatars0.githubusercontent.com/u/20229685?v=4","gravatar_id":"","url":"https://api.github.com/users/AishSundar","html_url":"https://github.com/AishSundar","followers_url":"https://api.github.com/users/AishSundar/followers","following_url":"https://api.github.com/users/AishSundar/following{/other_user}","gists_url":"https://api.github.com/users/AishSundar/gists{/gist_id}","starred_url":"https://api.github.com/users/AishSundar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AishSundar/subscriptions","organizations_url":"https://api.github.com/users/AishSundar/orgs","repos_url":"https://api.github.com/users/AishSundar/repos","events_url":"https://api.github.com/users/AishSundar/events{/privacy}","received_events_url":"https://api.github.com/users/AishSundar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":667741726,"node_id":"MDU6TGFiZWw2Njc3NDE3MjY=","url":"https://api.github.com/repos/kubernetes/sig-release/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":764021612,"node_id":"MDU6TGFiZWw3NjQwMjE2MTI=","url":"https://api.github.com/repos/kubernetes/sig-release/labels/sig/release","name":"sig/release","color":"d2b48c","default":false},{"id":756295481,"node_id":"MDU6TGFiZWw3NTYyOTU0ODE=","url":"https://api.github.com/repos/kubernetes/sig-release/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/sig-release/pulls/168/commits","review_comments_url":"https://api.github.com/repos/kubernetes/sig-release/pulls/168/comments","review_comment_url":"https://api.github.com/repos/kubernetes/sig-release/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/sig-release/issues/168/comments","statuses_url":"https://api.github.com/repos/kubernetes/sig-release/statuses/92844cfcde061b254314ee480c56398bcaaf942f","head":{"label":"justaugustus:v1.12-team","ref":"v1.12-team","sha":"92844cfcde061b254314ee480c56398bcaaf942f","user":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"repo":{"id":128124730,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMjQ3MzA=","name":"sig-release","full_name":"justaugustus/sig-release","owner":{"login":"justaugustus","id":567897,"node_id":"MDQ6VXNlcjU2Nzg5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/567897?v=4","gravatar_id":"","url":"https://api.github.com/users/justaugustus","html_url":"https://github.com/justaugustus","followers_url":"https://api.github.com/users/justaugustus/followers","following_url":"https://api.github.com/users/justaugustus/following{/other_user}","gists_url":"https://api.github.com/users/justaugustus/gists{/gist_id}","starred_url":"https://api.github.com/users/justaugustus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justaugustus/subscriptions","organizations_url":"https://api.github.com/users/justaugustus/orgs","repos_url":"https://api.github.com/users/justaugustus/repos","events_url":"https://api.github.com/users/justaugustus/events{/privacy}","received_events_url":"https://api.github.com/users/justaugustus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justaugustus/sig-release","description":"Repo for SIG release","fork":true,"url":"https://api.github.com/repos/justaugustus/sig-release","forks_url":"https://api.github.com/repos/justaugustus/sig-release/forks","keys_url":"https://api.github.com/repos/justaugustus/sig-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justaugustus/sig-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justaugustus/sig-release/teams","hooks_url":"https://api.github.com/repos/justaugustus/sig-release/hooks","issue_events_url":"https://api.github.com/repos/justaugustus/sig-release/issues/events{/number}","events_url":"https://api.github.com/repos/justaugustus/sig-release/events","assignees_url":"https://api.github.com/repos/justaugustus/sig-release/assignees{/user}","branches_url":"https://api.github.com/repos/justaugustus/sig-release/branches{/branch}","tags_url":"https://api.github.com/repos/justaugustus/sig-release/tags","blobs_url":"https://api.github.com/repos/justaugustus/sig-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justaugustus/sig-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justaugustus/sig-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/justaugustus/sig-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justaugustus/sig-release/statuses/{sha}","languages_url":"https://api.github.com/repos/justaugustus/sig-release/languages","stargazers_url":"https://api.github.com/repos/justaugustus/sig-release/stargazers","contributors_url":"https://api.github.com/repos/justaugustus/sig-release/contributors","subscribers_url":"https://api.github.com/repos/justaugustus/sig-release/subscribers","subscription_url":"https://api.github.com/repos/justaugustus/sig-release/subscription","commits_url":"https://api.github.com/repos/justaugustus/sig-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/justaugustus/sig-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/justaugustus/sig-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/justaugustus/sig-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/justaugustus/sig-release/contents/{+path}","compare_url":"https://api.github.com/repos/justaugustus/sig-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justaugustus/sig-release/merges","archive_url":"https://api.github.com/repos/justaugustus/sig-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justaugustus/sig-release/downloads","issues_url":"https://api.github.com/repos/justaugustus/sig-release/issues{/number}","pulls_url":"https://api.github.com/repos/justaugustus/sig-release/pulls{/number}","milestones_url":"https://api.github.com/repos/justaugustus/sig-release/milestones{/number}","notifications_url":"https://api.github.com/repos/justaugustus/sig-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justaugustus/sig-release/labels{/name}","releases_url":"https://api.github.com/repos/justaugustus/sig-release/releases{/id}","deployments_url":"https://api.github.com/repos/justaugustus/sig-release/deployments","created_at":"2018-04-04T21:33:23Z","updated_at":"2018-04-04T21:33:25Z","pushed_at":"2018-06-06T23:51:45Z","git_url":"git://github.com/justaugustus/sig-release.git","ssh_url":"git@github.com:justaugustus/sig-release.git","clone_url":"https://github.com/justaugustus/sig-release.git","svn_url":"https://github.com/justaugustus/sig-release","homepage":null,"size":3032,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"410b07f28a9490d6409adf1254600b1a8ccd135b","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":97860239,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzg2MDIzOQ==","name":"sig-release","full_name":"kubernetes/sig-release","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/sig-release","description":"Repo for SIG release","fork":false,"url":"https://api.github.com/repos/kubernetes/sig-release","forks_url":"https://api.github.com/repos/kubernetes/sig-release/forks","keys_url":"https://api.github.com/repos/kubernetes/sig-release/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/sig-release/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/sig-release/teams","hooks_url":"https://api.github.com/repos/kubernetes/sig-release/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/sig-release/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/sig-release/events","assignees_url":"https://api.github.com/repos/kubernetes/sig-release/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/sig-release/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/sig-release/tags","blobs_url":"https://api.github.com/repos/kubernetes/sig-release/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/sig-release/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/sig-release/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/sig-release/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/sig-release/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/sig-release/languages","stargazers_url":"https://api.github.com/repos/kubernetes/sig-release/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/sig-release/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/sig-release/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/sig-release/subscription","commits_url":"https://api.github.com/repos/kubernetes/sig-release/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/sig-release/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/sig-release/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/sig-release/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/sig-release/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/sig-release/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/sig-release/merges","archive_url":"https://api.github.com/repos/kubernetes/sig-release/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/sig-release/downloads","issues_url":"https://api.github.com/repos/kubernetes/sig-release/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/sig-release/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/sig-release/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/sig-release/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/sig-release/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/sig-release/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/sig-release/deployments","created_at":"2017-07-20T17:12:45Z","updated_at":"2018-06-06T17:52:41Z","pushed_at":"2018-06-06T23:51:46Z","git_url":"git://github.com/kubernetes/sig-release.git","ssh_url":"git@github.com:kubernetes/sig-release.git","clone_url":"https://github.com/kubernetes/sig-release.git","svn_url":"https://github.com/kubernetes/sig-release","homepage":null,"size":3027,"stargazers_count":33,"watchers_count":33,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":45,"open_issues":23,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/168"},"html":{"href":"https://github.com/kubernetes/sig-release/pull/168"},"issue":{"href":"https://api.github.com/repos/kubernetes/sig-release/issues/168"},"comments":{"href":"https://api.github.com/repos/kubernetes/sig-release/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/sig-release/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/sig-release/statuses/92844cfcde061b254314ee480c56398bcaaf942f"}},"author_association":"MEMBER"}} | {
"id": 97860239,
"name": "kubernetes/sig-release",
"url": "https://api.github.com/repos/kubernetes/sig-release"
} | {
"id": 567897,
"login": "justaugustus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/567897?",
"url": "https://api.github.com/users/justaugustus"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-06-07T17:32:46 | 7792350302 | {"actor":{"display_login":"justaugustus"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/website/pulls/comments/235773823","pull_request_review_id":177715493,"id":235773823,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc3MzgyMw==","diff_hunk":"@@ -0,0 +1,297 @@\n+---\n+reviewers:\n+- eparis\n+- mikedanese\n+title: Kubernetes 101\n+content_template: templates/tutorial\n+---\n+\n+{{% capture overview %}}\n+\n+<!--\n+For Kubernetes 101, we will cover kubectl, Pods, Volumes, and multiple containers.\n+-->\n+对于 Kubernetes 101，我们将涵盖 kubectl, Pods, Volumes 和多个容器这些内容。\n+\n+{{% /capture %}}\n+\n+{{% capture objectives %}}\n+\n+<!--\n+* What is `kubectl`.\n+* Manage a Pod.\n+* Create and mount a volume.\n+* Create multiple containers in a Pod.\n+-->\n+* `kubectl` 是什么。\n+* 管理 Pod。\n+* 创建和挂载卷。\n+* 在一个 Pod 中创建多个容器。\n+\n+{{% /capture %}}\n+\n+{{% capture prerequisites %}}\n+\n+<!--\n+* {{< include \"task-tutorial-prereqs.md\" >}} {{< version-check >}}\n+* In order for the kubectl usage examples to work, make sure you have an example directory locally, either from [a release](https://github.com/kubernetes/kubernetes/releases) or the latest `.yaml` files located [here](https://github.com/kubernetes/website/tree/master/content/en/docs/tutorials).\n+-->\n+* {{< include \"task-tutorial-prereqs.md\" >}} {{< version-check >}}\n+* 为了 kubectl 使用示例能正常工作，请确保您在本地有一个示例目录，可以从 [一个发行版本](https://github.com/kubernetes/kubernetes/releases) 或者最新的 `.yaml` 文件 [这里](https://github.com/kubernetes/website/tree/master/content/en/docs/tutorials) 获取。\n+\n+{{% /capture %}}\n+\n+{{% capture lessoncontent %}}\n+\n+<!--\n+## Kubectl CLI\n+\n+The easiest way to interact with Kubernetes is through the kubectl command-line interface.\n+\n+For more info about kubectl, including its usage, commands, and parameters, see [Overview of kubectl](/docs/reference/kubectl/overview/).\n+\n+For more information about installing and configuring kubectl, see [Install and Set Up kubectl](/docs/tasks/tools/install-kubectl/).\n+-->\n+## Kubectl 命令行\n+\n+与 Kubernetes 进行交互最简单的方法就是通过 kubectl 命令行。\n+\n+想要了解更多关于 kubectl，包括它的使用、命令和参数，查看 [kubectl 概览](/docs/reference/kubectl/overview/)。\n+\n+想要了解更多关于 kubectl 的安装和配置，查看 [安装和设置 kubectl](/docs/tasks/tools/install-kubectl/)。\n+\n+<!--\n+## Pods\n+\n+In Kubernetes, a group of one or more containers is called a _Pod_. Containers in a Pod are deployed together, and are started, stopped, and replicated as a group.\n+\n+For more information, see [Pods](/docs/concepts/workloads/pods/pod/).\n+-->\n+## Pods\n+\n+在 Kubernetes 中，一组一个或者多个容器被称为 _Pod_ 。在一个 Pod 里的容器是在一起部署的，它们作为一组一起启动、停止和伸缩容。\n+\n+想要了解更多, 查看 [Pods](/docs/concepts/workloads/pods/pod/)。\n+\n+<!--\n+#### Pod Definition\n+\n+The simplest Pod definition describes the deployment of a single container. For example, an nginx web server Pod might be defined as:\n+\n+{{< codenew file=\"pods/simple-pod.yaml\" >}}\n+\n+A Pod definition is a declaration of a _desired state_. Desired state is a very important concept in the Kubernetes model. Many things present a desired state to the system, and Kubernetes' ensures that the current state matches the desired state. For example, when you create a Pod and declare that the containers in it to be running. If the containers happen not to be running because of a program failure, Kubernetes continues to (re-)create the Pod in order to drive the pod to the desired state. This process continues until you delete the Pod.\n+\n+For more information, see [Kubernetes Design Documents and Proposals](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/README.md).\n+-->\n+#### Pod 定义\n+\n+最简单的 Pod 定义描述了 Deployment 中的单个容器。例如，一个 nginx web 服务器的 Pod 可能被定义为：\n+\n+{{< codenew file=\"pods/simple-pod.yaml\" >}}\n+\n+一个 Pod 定义是对预期状态的声明。预期状态在 Kubernetes 模型中是一个非常重要的概念。在这个系统中的很多东西都呈现为预期的状态，Kubernetes 保证现在的状态和预期的状态保持一致。例如，当您创建了一个 Pod 并且声明了将要在里面运行的容器。如果这些容器因为程序故障没有运行，Kubernetes 将继续创建或者重新创建这个 Pod 以使这个 Pod 达到期望状态。这个过程会一直持续直到您删除这个 Pod。","path":"content/zh/docs/tutorials/k8s101.md","position":93,"original_position":93,"commit_id":"9b0bac13dc17f2aa0b0402a2fb1aa5f68c8bfa4b","original_commit_id":"9b0bac13dc17f2aa0b0402a2fb1aa5f68c8bfa4b","user":{"login":"markthink","id":1718716,"node_id":"MDQ6VXNlcjE3MTg3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1718716?v=4","gravatar_id":"","url":"https://api.github.com/users/markthink","html_url":"https://github.com/markthink","followers_url":"https://api.github.com/users/markthink/followers","following_url":"https://api.github.com/users/markthink/following{/other_user}","gists_url":"https://api.github.com/users/markthink/gists{/gist_id}","starred_url":"https://api.github.com/users/markthink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markthink/subscriptions","organizations_url":"https://api.github.com/users/markthink/orgs","repos_url":"https://api.github.com/users/markthink/repos","events_url":"https://api.github.com/users/markthink/events{/privacy}","received_events_url":"https://api.github.com/users/markthink/received_events","type":"User","site_admin":false},"body":"一个 Pod 定义是对预期状态的声明\r\nA Pod definition is a declaration of a _desired state_.\r\n建议译为：\r\nPod 是对预期状态的声明的定义","created_at":"2018-11-22T16:04:19Z","updated_at":"2018-11-22T16:14:48Z","html_url":"https://github.com/kubernetes/website/pull/11183#discussion_r235773823","pull_request_url":"https://api.github.com/repos/kubernetes/website/pulls/11183","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments/235773823"},"html":{"href":"https://github.com/kubernetes/website/pull/11183#discussion_r235773823"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/website/pulls/11183"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/11183","id":233006657,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDA2NjU3","html_url":"https://github.com/kubernetes/website/pull/11183","diff_url":"https://github.com/kubernetes/website/pull/11183.diff","patch_url":"https://github.com/kubernetes/website/pull/11183.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/11183","number":11183,"state":"open","locked":false,"title":"zh-trans: /docs/tutorials/k8s101.md","user":{"login":"pigletfly","id":877790,"node_id":"MDQ6VXNlcjg3Nzc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/877790?v=4","gravatar_id":"","url":"https://api.github.com/users/pigletfly","html_url":"https://github.com/pigletfly","followers_url":"https://api.github.com/users/pigletfly/followers","following_url":"https://api.github.com/users/pigletfly/following{/other_user}","gists_url":"https://api.github.com/users/pigletfly/gists{/gist_id}","starred_url":"https://api.github.com/users/pigletfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pigletfly/subscriptions","organizations_url":"https://api.github.com/users/pigletfly/orgs","repos_url":"https://api.github.com/users/pigletfly/repos","events_url":"https://api.github.com/users/pigletfly/events{/privacy}","received_events_url":"https://api.github.com/users/pigletfly/received_events","type":"User","site_admin":false},"body":"chinese translation for /docs/tutorials/k8s101.md","created_at":"2018-11-22T14:58:16Z","updated_at":"2018-11-22T16:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d08471424ade161f9f42aea6522f73467f822ec1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tengqm","id":5094756,"node_id":"MDQ6VXNlcjUwOTQ3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5094756?v=4","gravatar_id":"","url":"https://api.github.com/users/tengqm","html_url":"https://github.com/tengqm","followers_url":"https://api.github.com/users/tengqm/followers","following_url":"https://api.github.com/users/tengqm/following{/other_user}","gists_url":"https://api.github.com/users/tengqm/gists{/gist_id}","starred_url":"https://api.github.com/users/tengqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tengqm/subscriptions","organizations_url":"https://api.github.com/users/tengqm/orgs","repos_url":"https://api.github.com/users/tengqm/repos","events_url":"https://api.github.com/users/tengqm/events{/privacy}","received_events_url":"https://api.github.com/users/tengqm/received_events","type":"User","site_admin":false},{"login":"zhangxiaoyu-zidif","id":5154334,"node_id":"MDQ6VXNlcjUxNTQzMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5154334?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxiaoyu-zidif","html_url":"https://github.com/zhangxiaoyu-zidif","followers_url":"https://api.github.com/users/zhangxiaoyu-zidif/followers","following_url":"https://api.github.com/users/zhangxiaoyu-zidif/following{/other_user}","gists_url":"https://api.github.com/users/zhangxiaoyu-zidif/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxiaoyu-zidif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxiaoyu-zidif/subscriptions","organizations_url":"https://api.github.com/users/zhangxiaoyu-zidif/orgs","repos_url":"https://api.github.com/users/zhangxiaoyu-zidif/repos","events_url":"https://api.github.com/users/zhangxiaoyu-zidif/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxiaoyu-zidif/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1078399953,"node_id":"MDU6TGFiZWwxMDc4Mzk5OTUz","url":"https://api.github.com/repos/kubernetes/website/labels/language/zh","name":"language/zh","color":"e9b3f9","default":false},{"id":679457866,"node_id":"MDU6TGFiZWw2Nzk0NTc4NjY=","url":"https://api.github.com/repos/kubernetes/website/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/11183/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/11183/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/11183/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/9b0bac13dc17f2aa0b0402a2fb1aa5f68c8bfa4b","head":{"label":"pigletfly:k8s-101","ref":"k8s-101","sha":"9b0bac13dc17f2aa0b0402a2fb1aa5f68c8bfa4b","user":{"login":"pigletfly","id":877790,"node_id":"MDQ6VXNlcjg3Nzc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/877790?v=4","gravatar_id":"","url":"https://api.github.com/users/pigletfly","html_url":"https://github.com/pigletfly","followers_url":"https://api.github.com/users/pigletfly/followers","following_url":"https://api.github.com/users/pigletfly/following{/other_user}","gists_url":"https://api.github.com/users/pigletfly/gists{/gist_id}","starred_url":"https://api.github.com/users/pigletfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pigletfly/subscriptions","organizations_url":"https://api.github.com/users/pigletfly/orgs","repos_url":"https://api.github.com/users/pigletfly/repos","events_url":"https://api.github.com/users/pigletfly/events{/privacy}","received_events_url":"https://api.github.com/users/pigletfly/received_events","type":"User","site_admin":false},"repo":{"id":153226693,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyMjY2OTM=","name":"website","full_name":"pigletfly/website","private":false,"owner":{"login":"pigletfly","id":877790,"node_id":"MDQ6VXNlcjg3Nzc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/877790?v=4","gravatar_id":"","url":"https://api.github.com/users/pigletfly","html_url":"https://github.com/pigletfly","followers_url":"https://api.github.com/users/pigletfly/followers","following_url":"https://api.github.com/users/pigletfly/following{/other_user}","gists_url":"https://api.github.com/users/pigletfly/gists{/gist_id}","starred_url":"https://api.github.com/users/pigletfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pigletfly/subscriptions","organizations_url":"https://api.github.com/users/pigletfly/orgs","repos_url":"https://api.github.com/users/pigletfly/repos","events_url":"https://api.github.com/users/pigletfly/events{/privacy}","received_events_url":"https://api.github.com/users/pigletfly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pigletfly/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/pigletfly/website","forks_url":"https://api.github.com/repos/pigletfly/website/forks","keys_url":"https://api.github.com/repos/pigletfly/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pigletfly/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pigletfly/website/teams","hooks_url":"https://api.github.com/repos/pigletfly/website/hooks","issue_events_url":"https://api.github.com/repos/pigletfly/website/issues/events{/number}","events_url":"https://api.github.com/repos/pigletfly/website/events","assignees_url":"https://api.github.com/repos/pigletfly/website/assignees{/user}","branches_url":"https://api.github.com/repos/pigletfly/website/branches{/branch}","tags_url":"https://api.github.com/repos/pigletfly/website/tags","blobs_url":"https://api.github.com/repos/pigletfly/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pigletfly/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pigletfly/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/pigletfly/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pigletfly/website/statuses/{sha}","languages_url":"https://api.github.com/repos/pigletfly/website/languages","stargazers_url":"https://api.github.com/repos/pigletfly/website/stargazers","contributors_url":"https://api.github.com/repos/pigletfly/website/contributors","subscribers_url":"https://api.github.com/repos/pigletfly/website/subscribers","subscription_url":"https://api.github.com/repos/pigletfly/website/subscription","commits_url":"https://api.github.com/repos/pigletfly/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/pigletfly/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/pigletfly/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/pigletfly/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/pigletfly/website/contents/{+path}","compare_url":"https://api.github.com/repos/pigletfly/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pigletfly/website/merges","archive_url":"https://api.github.com/repos/pigletfly/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pigletfly/website/downloads","issues_url":"https://api.github.com/repos/pigletfly/website/issues{/number}","pulls_url":"https://api.github.com/repos/pigletfly/website/pulls{/number}","milestones_url":"https://api.github.com/repos/pigletfly/website/milestones{/number}","notifications_url":"https://api.github.com/repos/pigletfly/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pigletfly/website/labels{/name}","releases_url":"https://api.github.com/repos/pigletfly/website/releases{/id}","deployments_url":"https://api.github.com/repos/pigletfly/website/deployments","created_at":"2018-10-16T05:18:14Z","updated_at":"2018-11-20T01:54:07Z","pushed_at":"2018-11-22T14:57:20Z","git_url":"git://github.com/pigletfly/website.git","ssh_url":"git@github.com:pigletfly/website.git","clone_url":"https://github.com/pigletfly/website.git","svn_url":"https://github.com/pigletfly/website","homepage":"https://kubernetes.io","size":133581,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a7a88c9163f075ccd95ca631f7274dbef923d987","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2018-11-22T08:25:47Z","pushed_at":"2018-11-22T15:54:47Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":164361,"stargazers_count":882,"watchers_count":882,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3520,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":3520,"open_issues":468,"watchers":882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/11183"},"html":{"href":"https://github.com/kubernetes/website/pull/11183"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/11183"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/11183/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/11183/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/11183/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/9b0bac13dc17f2aa0b0402a2fb1aa5f68c8bfa4b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51478266,
"name": "kubernetes/website",
"url": "https://api.github.com/repos/kubernetes/website"
} | {
"id": 1718716,
"login": "markthink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1718716?",
"url": "https://api.github.com/users/markthink"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-11-22T16:04:19 | 8634260910 | {"actor":{"display_login":"markthink"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/192964148","pull_request_review_id":125839235,"id":192964148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk2NDE0OA==","diff_hunk":"@@ -468,6 +471,9 @@ func (c *Configuration) setDefaults() {\n \tif c.SigMention.Regexp == \"\" {\n \t\tc.SigMention.Regexp = `(?m)@kubernetes/sig-([\\w-]*)-(misc|test-failures|bugs|feature-requests|proposals|pr-reviews|api-reviews)`\n \t}\n+\tif c.Owners.LabelsBlackList == nil {","path":"prow/plugins/plugins.go","position":14,"original_position":14,"commit_id":"70839636eaf1be5f7471770ff73b966ddb2e837c","original_commit_id":"70839636eaf1be5f7471770ff73b966ddb2e837c","user":{"login":"matthyx","id":20683409,"node_id":"MDQ6VXNlcjIwNjgzNDA5","avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"body":"I think it does: https://play.golang.org/p/9hZW4mTf9r2","created_at":"2018-06-05T06:52:43Z","updated_at":"2018-06-05T06:52:43Z","html_url":"https://github.com/kubernetes/test-infra/pull/8023#discussion_r192964148","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/192964148"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8023#discussion_r192964148"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023"}},"in_reply_to_id":192892242},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023","id":187640559,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjQwNTU5","html_url":"https://github.com/kubernetes/test-infra/pull/8023","diff_url":"https://github.com/kubernetes/test-infra/pull/8023.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/8023.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8023","number":8023,"state":"open","locked":false,"title":"Fix #7571 add plugin to check OWNERS file","user":{"login":"matthyx","id":20683409,"node_id":"MDQ6VXNlcjIwNjgzNDA5","avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"body":"Is this what you meant by having a blacklist? Or should it be declared somewhere more global?","created_at":"2018-05-12T21:13:29Z","updated_at":"2018-06-05T06:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d456ef99edd87ed8cfefa80ea096bfcd97bdbbb0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582641099,"node_id":"MDU6TGFiZWw1ODI2NDEwOTk=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":671133125,"node_id":"MDU6TGFiZWw2NzExMzMxMjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/8023/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/70839636eaf1be5f7471770ff73b966ddb2e837c","head":{"label":"matthyx:master","ref":"master","sha":"70839636eaf1be5f7471770ff73b966ddb2e837c","user":{"login":"matthyx","id":20683409,"node_id":"MDQ6VXNlcjIwNjgzNDA5","avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"repo":{"id":130222275,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyMjIyNzU=","name":"test-infra","full_name":"matthyx/test-infra","owner":{"login":"matthyx","id":20683409,"node_id":"MDQ6VXNlcjIwNjgzNDA5","avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthyx/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/matthyx/test-infra","forks_url":"https://api.github.com/repos/matthyx/test-infra/forks","keys_url":"https://api.github.com/repos/matthyx/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthyx/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthyx/test-infra/teams","hooks_url":"https://api.github.com/repos/matthyx/test-infra/hooks","issue_events_url":"https://api.github.com/repos/matthyx/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/matthyx/test-infra/events","assignees_url":"https://api.github.com/repos/matthyx/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/matthyx/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/matthyx/test-infra/tags","blobs_url":"https://api.github.com/repos/matthyx/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthyx/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthyx/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthyx/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthyx/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/matthyx/test-infra/languages","stargazers_url":"https://api.github.com/repos/matthyx/test-infra/stargazers","contributors_url":"https://api.github.com/repos/matthyx/test-infra/contributors","subscribers_url":"https://api.github.com/repos/matthyx/test-infra/subscribers","subscription_url":"https://api.github.com/repos/matthyx/test-infra/subscription","commits_url":"https://api.github.com/repos/matthyx/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthyx/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthyx/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthyx/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthyx/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/matthyx/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthyx/test-infra/merges","archive_url":"https://api.github.com/repos/matthyx/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthyx/test-infra/downloads","issues_url":"https://api.github.com/repos/matthyx/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/matthyx/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/matthyx/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/matthyx/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthyx/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/matthyx/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/matthyx/test-infra/deployments","created_at":"2018-04-19T13:47:25Z","updated_at":"2018-06-04T13:10:11Z","pushed_at":"2018-06-04T13:10:08Z","git_url":"git://github.com/matthyx/test-infra.git","ssh_url":"git@github.com:matthyx/test-infra.git","clone_url":"https://github.com/matthyx/test-infra.git","svn_url":"https://github.com/matthyx/test-infra","homepage":null,"size":52690,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2606fdca35d1aabb81b414c29c7cccf2a5da12a7","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-06-05T02:38:09Z","pushed_at":"2018-06-05T04:48:04Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":54424,"stargazers_count":397,"watchers_count":397,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":465,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":465,"open_issues":308,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/8023"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8023"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/8023/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/8023/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/70839636eaf1be5f7471770ff73b966ddb2e837c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 57333709,
"name": "kubernetes/test-infra",
"url": "https://api.github.com/repos/kubernetes/test-infra"
} | {
"id": 20683409,
"login": "matthyx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20683409?",
"url": "https://api.github.com/users/matthyx"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-06-05T06:52:43 | 7776118366 | {"actor":{"display_login":"matthyx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/225449672","pull_request_review_id":165047882,"id":225449672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ0OTY3Mg==","diff_hunk":"@@ -400,20 +400,38 @@ var _ volume.Detacher = &csiAttacher{}\n var _ volume.DeviceUnmounter = &csiAttacher{}\n \n func (c *csiAttacher) Detach(volumeName string, nodeName types.NodeName) error {\n-\t// volumeName in format driverName<SEP>volumeHandle generated by plugin.GetVolumeName()\n+\tvar attachID string\n+\tvar volID string\n+\n \tif volumeName == \"\" {\n \t\tglog.Error(log(\"detacher.Detach missing value for parameter volumeName\"))\n \t\treturn errors.New(\"missing expected parameter volumeName\")\n \t}\n-\tparts := strings.Split(volumeName, volNameSep)\n-\tif len(parts) != 2 {\n-\t\tglog.Error(log(\"detacher.Detach insufficient info encoded in volumeName\"))\n-\t\treturn errors.New(\"volumeName missing expected data\")\n+\n+\tif isAttachmentName(volumeName) {\n+\t\t// Detach can also be called with the attach ID as the `volumeName`. This codepath is\n+\t\t// his only when we have migrated an in-tree volume to CSI and the A/D Controller is shut","path":"pkg/volume/csi/csi_attacher.go","position":19,"original_position":19,"commit_id":"94bade5ec8b4e91a13457616ab51caf8849850e0","original_commit_id":"94bade5ec8b4e91a13457616ab51caf8849850e0","user":{"login":"ddebroy","id":22652369,"node_id":"MDQ6VXNlcjIyNjUyMzY5","avatar_url":"https://avatars2.githubusercontent.com/u/22652369?v=4","gravatar_id":"","url":"https://api.github.com/users/ddebroy","html_url":"https://github.com/ddebroy","followers_url":"https://api.github.com/users/ddebroy/followers","following_url":"https://api.github.com/users/ddebroy/following{/other_user}","gists_url":"https://api.github.com/users/ddebroy/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebroy/subscriptions","organizations_url":"https://api.github.com/users/ddebroy/orgs","repos_url":"https://api.github.com/users/ddebroy/repos","events_url":"https://api.github.com/users/ddebroy/events{/privacy}","received_events_url":"https://api.github.com/users/ddebroy/received_events","type":"User","site_admin":false},"body":"typo: `his`","created_at":"2018-10-16T08:47:58Z","updated_at":"2018-10-16T08:47:58Z","html_url":"https://github.com/kubernetes/kubernetes/pull/69830#discussion_r225449672","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/225449672"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/69830#discussion_r225449672"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830","id":223050080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDUwMDgw","html_url":"https://github.com/kubernetes/kubernetes/pull/69830","diff_url":"https://github.com/kubernetes/kubernetes/pull/69830.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69830.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69830","number":69830,"state":"open","locked":false,"title":"[WIP] In-Tree to CSI Migration logic for PersistentVolume Attach/Detach","user":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR \"sets the stage\" for in-tree to CSI Migration. It introduces the main feature flag, as well as the GCE PD Specific feature flag, the IsMigrated() Plugin interface method, as well as an implementation of the Migration for Attach/Detach for PersistentVolumes only.\r\n\r\nThis PR has been validated by turning on migration (through flags), deploying the GCE Driver (with a modified external attacher: xref https://github.com/kubernetes-csi/external-attacher/pull/78), and running all the in-tree GCE PD tests and validating that the CSI driver is receiving and reacting to the attach/detach calls and that the in-tree driver is standing down for Attach/Detach.\r\n\r\nFeature tracking issue: https://github.com/kubernetes/features/issues/625\r\n\r\n/sig storage\r\n/kind feature\r\n/assign @jsafrane @saad-ali \r\n/cc @msau42 @ddebroy @leakingtapan \r\n\r\nCommits have been seperated out as:\r\n1. Godep import of migration library\r\n2. Plugin `isMigratable` change and boilerplate code\r\n3. Feature flags and Attach/Detach migration logic\r\n\r\nThis feature is off by default and this is a partial implementation only, not sure if it needs a release note, will defer to @saad-ali \r\n```release-note\r\nNONE\r\n```","created_at":"2018-10-15T21:33:00Z","updated_at":"2018-10-16T08:47:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be65ddc4ae99297b39ced72a5f990c2d6dde87fc","assignee":{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"leakingtapan","id":5259480,"node_id":"MDQ6VXNlcjUyNTk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5259480?v=4","gravatar_id":"","url":"https://api.github.com/users/leakingtapan","html_url":"https://github.com/leakingtapan","followers_url":"https://api.github.com/users/leakingtapan/followers","following_url":"https://api.github.com/users/leakingtapan/following{/other_user}","gists_url":"https://api.github.com/users/leakingtapan/gists{/gist_id}","starred_url":"https://api.github.com/users/leakingtapan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leakingtapan/subscriptions","organizations_url":"https://api.github.com/users/leakingtapan/orgs","repos_url":"https://api.github.com/users/leakingtapan/repos","events_url":"https://api.github.com/users/leakingtapan/events{/privacy}","received_events_url":"https://api.github.com/users/leakingtapan/received_events","type":"User","site_admin":false},{"login":"msau42","id":24448061,"node_id":"MDQ6VXNlcjI0NDQ4MDYx","avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69830/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/94bade5ec8b4e91a13457616ab51caf8849850e0","head":{"label":"davidz627:feature/csiTranslationMigration","ref":"feature/csiTranslationMigration","sha":"94bade5ec8b4e91a13457616ab51caf8849850e0","user":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"repo":{"id":97973920,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzk3MzkyMA==","name":"kubernetes","full_name":"davidz627/kubernetes","private":false,"owner":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidz627/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/davidz627/kubernetes","forks_url":"https://api.github.com/repos/davidz627/kubernetes/forks","keys_url":"https://api.github.com/repos/davidz627/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidz627/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidz627/kubernetes/teams","hooks_url":"https://api.github.com/repos/davidz627/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/davidz627/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/davidz627/kubernetes/events","assignees_url":"https://api.github.com/repos/davidz627/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/davidz627/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/davidz627/kubernetes/tags","blobs_url":"https://api.github.com/repos/davidz627/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidz627/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidz627/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidz627/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidz627/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/davidz627/kubernetes/languages","stargazers_url":"https://api.github.com/repos/davidz627/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/davidz627/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/davidz627/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/davidz627/kubernetes/subscription","commits_url":"https://api.github.com/repos/davidz627/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidz627/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidz627/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidz627/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidz627/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/davidz627/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidz627/kubernetes/merges","archive_url":"https://api.github.com/repos/davidz627/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidz627/kubernetes/downloads","issues_url":"https://api.github.com/repos/davidz627/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/davidz627/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/davidz627/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/davidz627/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidz627/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/davidz627/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/davidz627/kubernetes/deployments","created_at":"2017-07-21T17:57:08Z","updated_at":"2018-10-10T23:01:27Z","pushed_at":"2018-10-15T22:56:40Z","git_url":"git://github.com/davidz627/kubernetes.git","ssh_url":"git@github.com:davidz627/kubernetes.git","clone_url":"https://github.com/davidz627/kubernetes.git","svn_url":"https://github.com/davidz627/kubernetes","homepage":"http://kubernetes.io","size":578914,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f6b54f79fb8163af7cd39a4c2c9c31f973c2becf","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-10-16T08:41:06Z","pushed_at":"2018-10-16T08:10:17Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":811230,"stargazers_count":42595,"watchers_count":42595,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14804,"mirror_url":null,"archived":false,"open_issues_count":3215,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14804,"open_issues":3215,"watchers":42595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/69830"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/69830"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/69830/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69830/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/94bade5ec8b4e91a13457616ab51caf8849850e0"}},"author_association":"COLLABORATOR"}} | {
"id": 20580498,
"name": "kubernetes/kubernetes",
"url": "https://api.github.com/repos/kubernetes/kubernetes"
} | {
"id": 22652369,
"login": "ddebroy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22652369?",
"url": "https://api.github.com/users/ddebroy"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-10-16T08:47:58 | 8426840399 | {"actor":{"display_login":"ddebroy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/187457411","pull_request_review_id":119244059,"id":187457411,"diff_hunk":"@@ -142,19 +146,24 @@ func jobRequirements(jobs []Presubmit, branch string, after bool) []string {\n \t\tif !after && !j.AlwaysRun && j.RunIfChanged == \"\" {\n \t\t\tcontinue // No\n \t\t}\n-\t\tif !j.SkipReport && !j.Optional { // This job needs a context\n+\t\tif j.ContextRequired() { // This job needs a context\n \t\t\trequired = append(required, j.Context)\n+\t\t} else {\n+\t\t\toptional = append(optional, j.Context)\n \t\t}\n \t\t// Check which children require contexts\n-\t\trequired = append(required, jobRequirements(j.RunAfterSuccess, branch, true)...)\n+\t\tr, o := jobRequirements(j.RunAfterSuccess, branch, true)\n+\t\trequired = append(required, r...)\n+\t\toptional = append(optional, o...)\n \t}\n-\treturn required\n+\treturn\n }\n \n-func branchRequirements(org, repo, branch string, presubmits map[string][]Presubmit) []string {\n+// BranchRequirements returns required and optional presubmits prow jobs for a given org, repo branch.\n+func BranchRequirements(org, repo, branch string, presubmits map[string][]Presubmit) (required, optional []string) {\n \tp, ok := presubmits[org+\"/\"+repo]\n \tif !ok {\n-\t\treturn nil\n+\t\treturn","path":"prow/config/branch_protection.go","position":null,"original_position":77,"commit_id":"ecb61ce24bb9db31f2bb736ca8ff14c6b3808e05","original_commit_id":"74adb1e4efe3093dbca78b8c723597ad4ff7242c","user":{"login":"sebastienvas","id":17773671,"avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-05-10T20:54:52Z","updated_at":"2018-05-10T20:54:52Z","html_url":"https://github.com/kubernetes/test-infra/pull/7983#discussion_r187457411","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/187457411"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/7983#discussion_r187457411"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983"}},"in_reply_to_id":187177566},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983","id":187038071,"html_url":"https://github.com/kubernetes/test-infra/pull/7983","diff_url":"https://github.com/kubernetes/test-infra/pull/7983.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/7983.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7983","number":7983,"state":"open","locked":false,"title":"Adds ability to set required and optional checks","user":{"login":"sebastienvas","id":17773671,"avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},"body":"Redoing #7457 as it takes forever to load.\r\n\r\nRef: https://goo.gl/cd9MEu which was discussed with @fejta @cjwagner @BenTheElder \r\n\r\nInstead of getting required checks from the github api, it will use the branch protection configuration and infere the required context from it. We are also adding a optional options to Prow Presubmits.\r\n\r\nConfig would look like this:\r\n```yaml\r\n...\r\nbranch-protection:\r\n skip-unknown-contexts: true\r\n\r\n...\r\npresubmits:\r\n org/repo:\r\n - name: my-presubmit\r\n optional: true\r\n...\r\n```\r\n#7140","created_at":"2018-05-09T20:56:48Z","updated_at":"2018-05-10T20:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21dfa685e7ebee19380f1e8d71edeb80791d41df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cjwagner","id":5334145,"avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":412127043,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":484580953,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":718255965,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":671133252,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/7983/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/ecb61ce24bb9db31f2bb736ca8ff14c6b3808e05","head":{"label":"sebastienvas:tide","ref":"tide","sha":"ecb61ce24bb9db31f2bb736ca8ff14c6b3808e05","user":{"login":"sebastienvas","id":17773671,"avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},"repo":{"id":102048948,"name":"k8s-test-infra","full_name":"sebastienvas/k8s-test-infra","owner":{"login":"sebastienvas","id":17773671,"avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastienvas/k8s-test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/sebastienvas/k8s-test-infra","forks_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/forks","keys_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/teams","hooks_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/hooks","issue_events_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/events","assignees_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/tags","blobs_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/languages","stargazers_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/stargazers","contributors_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/contributors","subscribers_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/subscribers","subscription_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/subscription","commits_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/merges","archive_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/downloads","issues_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/labels{/name}","releases_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/sebastienvas/k8s-test-infra/deployments","created_at":"2017-08-31T21:58:27Z","updated_at":"2017-08-31T21:59:33Z","pushed_at":"2018-05-10T20:54:36Z","git_url":"git://github.com/sebastienvas/k8s-test-infra.git","ssh_url":"git@github.com:sebastienvas/k8s-test-infra.git","clone_url":"https://github.com/sebastienvas/k8s-test-infra.git","svn_url":"https://github.com/sebastienvas/k8s-test-infra","homepage":null,"size":92731,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"02bc556d770730a2512929553734ca2736025e55","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-05-10T20:52:04Z","pushed_at":"2018-05-10T20:54:37Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":52403,"stargazers_count":366,"watchers_count":366,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":434,"mirror_url":null,"archived":false,"open_issues_count":317,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":434,"open_issues":317,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/7983"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/7983"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/7983/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/7983/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/ecb61ce24bb9db31f2bb736ca8ff14c6b3808e05"}},"author_association":"COLLABORATOR"}} | {
"id": 57333709,
"name": "kubernetes/test-infra",
"url": "https://api.github.com/repos/kubernetes/test-infra"
} | {
"id": 17773671,
"login": "sebastienvas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17773671?",
"url": "https://api.github.com/users/sebastienvas"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-05-10T20:54:52 | 7657801025 | {"actor":{"display_login":"sebastienvas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/207197998","pull_request_review_id":142758365,"id":207197998,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE5Nzk5OA==","diff_hunk":"@@ -0,0 +1,71 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package measurement\n+\n+import (\n+\t\"sync\"\n+\n+\tclientset \"k8s.io/client-go/kubernetes\"\n+)\n+\n+// MeasurementManager manages all measurement executions.\n+type MeasurementManager struct {\n+\tfactory *MeasurementFactory\n+\tclientSet clientset.Interface\n+\n+\tlock sync.Mutex\n+\t// measurements is a map from method type and identifier to measurement instance.\n+\tmeasurements map[string]map[string]Measurement\n+}\n+\n+// CreateMeasurementManager creates new instance of MeasurementManager.\n+func CreateMeasurementManager(factory *MeasurementFactory, clientSet clientset.Interface) *MeasurementManager {\n+\treturn &MeasurementManager{\n+\t\tfactory: factory,","path":"clusterloader2/pkg/measurement/manager.go","position":38,"original_position":38,"commit_id":"6a4ae24abb6e7c1963c4f82f955dc078cb94ecbd","original_commit_id":"6a4ae24abb6e7c1963c4f82f955dc078cb94ecbd","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"body":"> Infact, you could just merge factory and manager into single struct, as each of them pretty much holds 1 variable.\r\n\r\nTL;DR: I will be very unhappy to merge those two structures.\r\nThose two are two separated concept. Factory should be something on global level, that is aware of how to create measurement instances.\r\nManager exists in some context (test context in this case) - it uses factory to create measurement instances. Managers also stores states of instances.\r\n\r\n> Initialize a new instance of factory in CreateMeasurementManager (so you don't need that global variable anymore)\r\nMake Register() a public method on the MeasurementManager and make the Register() for the factory a private one, and call the latter from the former\r\n\r\nCould you explain to me, how will measurement methods will register in factory? I still missing the point where Register is called by the measurement method implementation or measurement is added to manager.\r\n\r\nWith this implementation I try to do similar thing to how apis register to legacyscheme.","created_at":"2018-08-02T11:54:22Z","updated_at":"2018-08-02T11:54:23Z","html_url":"https://github.com/kubernetes/perf-tests/pull/180#discussion_r207197998","pull_request_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/207197998"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/180#discussion_r207197998"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180"}},"in_reply_to_id":207177372},"pull_request":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180","id":205438473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDM4NDcz","html_url":"https://github.com/kubernetes/perf-tests/pull/180","diff_url":"https://github.com/kubernetes/perf-tests/pull/180.diff","patch_url":"https://github.com/kubernetes/perf-tests/pull/180.patch","issue_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/180","number":180,"state":"open","locked":false,"title":"ClusterLoader - Adding measurement manager","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"body":"Implementation of measurement factory and measurement manager.\r\nCloudProvider will be add in future PR.","created_at":"2018-08-01T14:10:10Z","updated_at":"2018-08-02T11:54:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aff52fc26561a7dcb84cee00f960c17212277650","assignee":{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false},"assignees":[{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gmarek","id":1703842,"node_id":"MDQ6VXNlcjE3MDM4NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1703842?v=4","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":492296491,"node_id":"MDU6TGFiZWw0OTIyOTY0OTE=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":764010528,"node_id":"MDU6TGFiZWw3NjQwMTA1Mjg=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180/commits","review_comments_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180/comments","review_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/180/comments","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/6a4ae24abb6e7c1963c4f82f955dc078cb94ecbd","head":{"label":"krzysied:cluster_loader_measurements_manager","ref":"cluster_loader_measurements_manager","sha":"6a4ae24abb6e7c1963c4f82f955dc078cb94ecbd","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"repo":{"id":128908558,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MDg1NTg=","name":"perf-tests","full_name":"krzysied/perf-tests","owner":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krzysied/perf-tests","description":"Performance tests and benchmarks","fork":true,"url":"https://api.github.com/repos/krzysied/perf-tests","forks_url":"https://api.github.com/repos/krzysied/perf-tests/forks","keys_url":"https://api.github.com/repos/krzysied/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krzysied/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krzysied/perf-tests/teams","hooks_url":"https://api.github.com/repos/krzysied/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/krzysied/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/krzysied/perf-tests/events","assignees_url":"https://api.github.com/repos/krzysied/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/krzysied/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/krzysied/perf-tests/tags","blobs_url":"https://api.github.com/repos/krzysied/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krzysied/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krzysied/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/krzysied/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krzysied/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/krzysied/perf-tests/languages","stargazers_url":"https://api.github.com/repos/krzysied/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/krzysied/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/krzysied/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/krzysied/perf-tests/subscription","commits_url":"https://api.github.com/repos/krzysied/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/krzysied/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/krzysied/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/krzysied/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/krzysied/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/krzysied/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krzysied/perf-tests/merges","archive_url":"https://api.github.com/repos/krzysied/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krzysied/perf-tests/downloads","issues_url":"https://api.github.com/repos/krzysied/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/krzysied/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/krzysied/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/krzysied/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krzysied/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/krzysied/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/krzysied/perf-tests/deployments","created_at":"2018-04-10T09:33:00Z","updated_at":"2018-04-10T09:33:03Z","pushed_at":"2018-08-02T09:40:40Z","git_url":"git://github.com/krzysied/perf-tests.git","ssh_url":"git@github.com:krzysied/perf-tests.git","clone_url":"https://github.com/krzysied/perf-tests.git","svn_url":"https://github.com/krzysied/perf-tests","homepage":null,"size":51093,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5b571a52711055c262b012c64b86d0bc051e594c","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":68769911,"node_id":"MDEwOlJlcG9zaXRvcnk2ODc2OTkxMQ==","name":"perf-tests","full_name":"kubernetes/perf-tests","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/perf-tests","description":"Performance tests and benchmarks","fork":false,"url":"https://api.github.com/repos/kubernetes/perf-tests","forks_url":"https://api.github.com/repos/kubernetes/perf-tests/forks","keys_url":"https://api.github.com/repos/kubernetes/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/perf-tests/teams","hooks_url":"https://api.github.com/repos/kubernetes/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/perf-tests/events","assignees_url":"https://api.github.com/repos/kubernetes/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/perf-tests/tags","blobs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/perf-tests/languages","stargazers_url":"https://api.github.com/repos/kubernetes/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/perf-tests/subscription","commits_url":"https://api.github.com/repos/kubernetes/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/perf-tests/merges","archive_url":"https://api.github.com/repos/kubernetes/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/perf-tests/downloads","issues_url":"https://api.github.com/repos/kubernetes/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/perf-tests/deployments","created_at":"2016-09-21T01:59:44Z","updated_at":"2018-08-01T18:25:14Z","pushed_at":"2018-08-02T09:40:42Z","git_url":"git://github.com/kubernetes/perf-tests.git","ssh_url":"git@github.com:kubernetes/perf-tests.git","clone_url":"https://github.com/kubernetes/perf-tests.git","svn_url":"https://github.com/kubernetes/perf-tests","homepage":null,"size":51088,"stargazers_count":108,"watchers_count":108,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":10,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/180"},"issue":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/180"},"comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/perf-tests/statuses/6a4ae24abb6e7c1963c4f82f955dc078cb94ecbd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 68769911,
"name": "kubernetes/perf-tests",
"url": "https://api.github.com/repos/kubernetes/perf-tests"
} | {
"id": 25119199,
"login": "krzysied",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25119199?",
"url": "https://api.github.com/users/krzysied"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-08-02T11:54:22 | 8056194628 | {"actor":{"display_login":"krzysied"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/community/pulls/comments/213931963","pull_request_review_id":150871786,"id":213931963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzkzMTk2Mw==","diff_hunk":"@@ -46,7 +46,7 @@ remain active contributors to the community.\n forums, Stack Overflow)\n - Subscribed to [kubernetes-dev@googlegroups.com]\n - Have read the [contributor guide]\n-- Actively contributing to 1 or more subprojects.\n+- Actively contributing non-trival pulls to 1 or more subprojects.","path":"community-membership.md","position":5,"original_position":5,"commit_id":"6f26df6cfcd0b8784e0c47aeaf745fe270052167","original_commit_id":"6f26df6cfcd0b8784e0c47aeaf745fe270052167","user":{"login":"nikhita","id":16105680,"node_id":"MDQ6VXNlcjE2MTA1Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"body":"I'm concerned that non-trivial is subjective. There is no strict codified definition of what is non-trivial and what isn't. While we can agree that typos are trivial, the line soon blurs down.\r\n\r\nLike @cblecker mentioned, I would also expect that if an existing member is sponsoring someone to become a member, they would only do so if they have had close interactions with the non-member and they think that the non-member's contributions are \"non-trival enough according to them\" for warranting membership.","created_at":"2018-08-30T07:43:22Z","updated_at":"2018-08-30T07:43:22Z","html_url":"https://github.com/kubernetes/community/pull/2602#discussion_r213931963","pull_request_url":"https://api.github.com/repos/kubernetes/community/pulls/2602","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments/213931963"},"html":{"href":"https://github.com/kubernetes/community/pull/2602#discussion_r213931963"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2602"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/community/pulls/2602","id":211931332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTMxMzMy","html_url":"https://github.com/kubernetes/community/pull/2602","diff_url":"https://github.com/kubernetes/community/pull/2602.diff","patch_url":"https://github.com/kubernetes/community/pull/2602.patch","issue_url":"https://api.github.com/repos/kubernetes/community/issues/2602","number":2602,"state":"open","locked":false,"title":"Reduce trival pull flooding by restricting requirement","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"body":"if you notice, more & more trival pulls is flooding for requesting a membership which is sometimes 🙉. add this restriction might possibly help frequency of trival pulls.\r\n\r\n/cc @nikhita ","created_at":"2018-08-30T01:33:41Z","updated_at":"2018-08-30T07:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffdb1d30c2e23fe08c427f279c68c00153546b3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":486032367,"node_id":"MDU6TGFiZWw0ODYwMzIzNjc=","url":"https://api.github.com/repos/kubernetes/community/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":653942921,"node_id":"MDU6TGFiZWw2NTM5NDI5MjE=","url":"https://api.github.com/repos/kubernetes/community/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/community/pulls/2602/commits","review_comments_url":"https://api.github.com/repos/kubernetes/community/pulls/2602/comments","review_comment_url":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/community/issues/2602/comments","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/6f26df6cfcd0b8784e0c47aeaf745fe270052167","head":{"label":"yue9944882:chore/restrict-trival-pull-flood","ref":"chore/restrict-trival-pull-flood","sha":"6f26df6cfcd0b8784e0c47aeaf745fe270052167","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"repo":{"id":146678614,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2Nzg2MTQ=","name":"community","full_name":"yue9944882/community","owner":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yue9944882/community","description":"Kubernetes community content","fork":true,"url":"https://api.github.com/repos/yue9944882/community","forks_url":"https://api.github.com/repos/yue9944882/community/forks","keys_url":"https://api.github.com/repos/yue9944882/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yue9944882/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yue9944882/community/teams","hooks_url":"https://api.github.com/repos/yue9944882/community/hooks","issue_events_url":"https://api.github.com/repos/yue9944882/community/issues/events{/number}","events_url":"https://api.github.com/repos/yue9944882/community/events","assignees_url":"https://api.github.com/repos/yue9944882/community/assignees{/user}","branches_url":"https://api.github.com/repos/yue9944882/community/branches{/branch}","tags_url":"https://api.github.com/repos/yue9944882/community/tags","blobs_url":"https://api.github.com/repos/yue9944882/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yue9944882/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yue9944882/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/yue9944882/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yue9944882/community/statuses/{sha}","languages_url":"https://api.github.com/repos/yue9944882/community/languages","stargazers_url":"https://api.github.com/repos/yue9944882/community/stargazers","contributors_url":"https://api.github.com/repos/yue9944882/community/contributors","subscribers_url":"https://api.github.com/repos/yue9944882/community/subscribers","subscription_url":"https://api.github.com/repos/yue9944882/community/subscription","commits_url":"https://api.github.com/repos/yue9944882/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/yue9944882/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/yue9944882/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/yue9944882/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/yue9944882/community/contents/{+path}","compare_url":"https://api.github.com/repos/yue9944882/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yue9944882/community/merges","archive_url":"https://api.github.com/repos/yue9944882/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yue9944882/community/downloads","issues_url":"https://api.github.com/repos/yue9944882/community/issues{/number}","pulls_url":"https://api.github.com/repos/yue9944882/community/pulls{/number}","milestones_url":"https://api.github.com/repos/yue9944882/community/milestones{/number}","notifications_url":"https://api.github.com/repos/yue9944882/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yue9944882/community/labels{/name}","releases_url":"https://api.github.com/repos/yue9944882/community/releases{/id}","deployments_url":"https://api.github.com/repos/yue9944882/community/deployments","created_at":"2018-08-30T01:22:41Z","updated_at":"2018-08-30T01:22:46Z","pushed_at":"2018-08-30T01:25:23Z","git_url":"git://github.com/yue9944882/community.git","ssh_url":"git@github.com:yue9944882/community.git","clone_url":"https://github.com/yue9944882/community.git","svn_url":"https://github.com/yue9944882/community","homepage":"","size":31077,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b455dec4ab98359b06997dfd4ae1274055bdb305","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57939112,"node_id":"MDEwOlJlcG9zaXRvcnk1NzkzOTExMg==","name":"community","full_name":"kubernetes/community","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/community","description":"Kubernetes community content","fork":false,"url":"https://api.github.com/repos/kubernetes/community","forks_url":"https://api.github.com/repos/kubernetes/community/forks","keys_url":"https://api.github.com/repos/kubernetes/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/community/teams","hooks_url":"https://api.github.com/repos/kubernetes/community/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/community/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/community/events","assignees_url":"https://api.github.com/repos/kubernetes/community/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/community/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/community/tags","blobs_url":"https://api.github.com/repos/kubernetes/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/community/languages","stargazers_url":"https://api.github.com/repos/kubernetes/community/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/community/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/community/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/community/subscription","commits_url":"https://api.github.com/repos/kubernetes/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/community/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/community/merges","archive_url":"https://api.github.com/repos/kubernetes/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/community/downloads","issues_url":"https://api.github.com/repos/kubernetes/community/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/community/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/community/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/community/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/community/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/community/deployments","created_at":"2016-05-03T03:36:05Z","updated_at":"2018-08-30T03:23:16Z","pushed_at":"2018-08-30T06:59:36Z","git_url":"git://github.com/kubernetes/community.git","ssh_url":"git@github.com:kubernetes/community.git","clone_url":"https://github.com/kubernetes/community.git","svn_url":"https://github.com/kubernetes/community","homepage":"","size":31750,"stargazers_count":2410,"watchers_count":2410,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1406,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1406,"open_issues":217,"watchers":2410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2602"},"html":{"href":"https://github.com/kubernetes/community/pull/2602"},"issue":{"href":"https://api.github.com/repos/kubernetes/community/issues/2602"},"comments":{"href":"https://api.github.com/repos/kubernetes/community/issues/2602/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2602/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2602/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/community/statuses/6f26df6cfcd0b8784e0c47aeaf745fe270052167"}},"author_association":"MEMBER"}} | {
"id": 57939112,
"name": "kubernetes/community",
"url": "https://api.github.com/repos/kubernetes/community"
} | {
"id": 16105680,
"login": "nikhita",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16105680?",
"url": "https://api.github.com/users/nikhita"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-08-30T07:43:22 | 8189511086 | {"actor":{"display_login":"nikhita"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/187733694","pull_request_review_id":119580702,"id":187733694,"diff_hunk":"@@ -12,50 +12,220 @@\n # See the License for the specific language governing permissions and\n # limitations under the License.\n \n-#!/bin/sh\n+#!/bin/bash\n+set -euo pipefail\n \n-# Simple early detection of nvidia card\n-grep 10de102d /proc/bus/pci/devices || exit 0\n+#################################################\n+# Settings\n \n-# p2.xlarge\n-# 00f0\t10de102d\t4b\t 84000000\t 100000000c\t 0\t 8200000c\t 0\t 0\t 0\t 1000000\t 400000000\t 0\t 2000000\t 0\t 0\t 0\tnvidia\n+# A place on the host machine to cache these huge 1.6GB+ downloads in between reboots.\n+ROOTFS_DIR=/rootfs\n+CACHE_DIR_HOST=/nvidia-bootstrap-cache\n+CACHE_DIR_CONTAINER=\"${ROOTFS_DIR}${CACHE_DIR_HOST}\"\n \n+# AWS Instance Types to Nvidia Card Mapping (cut and pasted from AWS docs)\n+# Load the correct driver for the correct instance type\n+# Instances Product Type Product Series Product\n+# G2 GRID GRID Series GRID K520 <-- I think they meant G3","path":"hooks/nvidia-bootstrap/image/run.sh","position":23,"original_position":23,"commit_id":"ef958a7f870eb3dc20981617859b8ad69057bb2a","original_commit_id":"ef958a7f870eb3dc20981617859b8ad69057bb2a","user":{"login":"115100","id":10553164,"avatar_url":"https://avatars2.githubusercontent.com/u/10553164?v=4","gravatar_id":"","url":"https://api.github.com/users/115100","html_url":"https://github.com/115100","followers_url":"https://api.github.com/users/115100/followers","following_url":"https://api.github.com/users/115100/following{/other_user}","gists_url":"https://api.github.com/users/115100/gists{/gist_id}","starred_url":"https://api.github.com/users/115100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/115100/subscriptions","organizations_url":"https://api.github.com/users/115100/orgs","repos_url":"https://api.github.com/users/115100/repos","events_url":"https://api.github.com/users/115100/events{/privacy}","received_events_url":"https://api.github.com/users/115100/received_events","type":"User","site_admin":false},"body":"Ah, I see a new set of drivers. It was a while back and it did take a while to support the newer kernel though.","created_at":"2018-05-11T21:08:24Z","updated_at":"2018-05-11T21:08:24Z","html_url":"https://github.com/kubernetes/kops/pull/4971#discussion_r187733694","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/4971","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/187733694"},"html":{"href":"https://github.com/kubernetes/kops/pull/4971#discussion_r187733694"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/4971"}},"in_reply_to_id":187623522},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/4971","id":181008883,"html_url":"https://github.com/kubernetes/kops/pull/4971","diff_url":"https://github.com/kubernetes/kops/pull/4971.diff","patch_url":"https://github.com/kubernetes/kops/pull/4971.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/4971","number":4971,"state":"open","locked":false,"title":"[GPU] Updated Kops GPU Setup Hook","user":{"login":"dcwangmit01","id":1733071,"avatar_url":"https://avatars0.githubusercontent.com/u/1733071?v=4","gravatar_id":"","url":"https://api.github.com/users/dcwangmit01","html_url":"https://github.com/dcwangmit01","followers_url":"https://api.github.com/users/dcwangmit01/followers","following_url":"https://api.github.com/users/dcwangmit01/following{/other_user}","gists_url":"https://api.github.com/users/dcwangmit01/gists{/gist_id}","starred_url":"https://api.github.com/users/dcwangmit01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcwangmit01/subscriptions","organizations_url":"https://api.github.com/users/dcwangmit01/orgs","repos_url":"https://api.github.com/users/dcwangmit01/repos","events_url":"https://api.github.com/users/dcwangmit01/events{/privacy}","received_events_url":"https://api.github.com/users/dcwangmit01/received_events","type":"User","site_admin":false},"body":"Docker image for testing located at: dcwangmit01/aws-nvidia-bootstrap:0.1.1\r\n\r\nCompatible with instructions here: https://github.com/kubernetes/kops/blob/master/docs/gpu.md\r\n\r\n===\r\n* Changed Dockerfile base image to debian for systemctl and bash.\r\n* Added autodetect of AWS ec2 instanceclass p2, p3, g3.\r\n* For each detected instance class, added the installation of the proper driver\r\n according to the specific NVIDIA hardware.\r\n - G3 instance types require Nvidia Grid Series/Grid K520 drivers\r\n - P2 instance types require Nvidia Tesla K-Series drivers\r\n - P3 instance types require Nvidia Tesla V-Series drivers\r\n* Set custom nvidia-smi configurations according to nvidia hardware per ec2\r\n instanceclass, according to the AWS GPU optimization document.\r\n* Added the installation and patches of the latest cuda 9.1 libraries.\r\n* Added restart of kubelet on kube node at end of successful hook run, thereby\r\n fixing a race condition where kubelet would start before the Nvidia drivers\r\n were loaded, thus not allowing kubernetes to detect GPUS on the kube node.\r\n* Ensured build of nvidia drivers used same gcc version as that which built\r\n default kops kernel.\r\n* Fixed issue where *every* run of this container would download all the NVIDIA\r\n drivers + cuda libs (1GB+), by caching the files on the kube node.\r\n* Fixed issue where after reboot, subsequent runs of this script would fail\r\n because mknod would try to create a previously-created device node and fail.\r\n This previously caused download loop as systemd perpetually restarted the\r\n unit upon failure.\r\n* Tested with p2.xlarge, p3.2xlarge, and g3.4xlarge","created_at":"2018-04-11T19:47:35Z","updated_at":"2018-05-11T21:08:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67141ddcd0f5d5f3e8ff26d45e7087ca287b73be","assignee":{"login":"KashifSaadat","id":6972966,"avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false},"assignees":[{"login":"KashifSaadat","id":6972966,"avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":485059302,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":583153471,"url":"https://api.github.com/repos/kubernetes/kops/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676485644,"url":"https://api.github.com/repos/kubernetes/kops/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/4971/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/4971/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/4971/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/ef958a7f870eb3dc20981617859b8ad69057bb2a","head":{"label":"dcwangmit01:update_gpu_hook","ref":"update_gpu_hook","sha":"ef958a7f870eb3dc20981617859b8ad69057bb2a","user":{"login":"dcwangmit01","id":1733071,"avatar_url":"https://avatars0.githubusercontent.com/u/1733071?v=4","gravatar_id":"","url":"https://api.github.com/users/dcwangmit01","html_url":"https://github.com/dcwangmit01","followers_url":"https://api.github.com/users/dcwangmit01/followers","following_url":"https://api.github.com/users/dcwangmit01/following{/other_user}","gists_url":"https://api.github.com/users/dcwangmit01/gists{/gist_id}","starred_url":"https://api.github.com/users/dcwangmit01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcwangmit01/subscriptions","organizations_url":"https://api.github.com/users/dcwangmit01/orgs","repos_url":"https://api.github.com/users/dcwangmit01/repos","events_url":"https://api.github.com/users/dcwangmit01/events{/privacy}","received_events_url":"https://api.github.com/users/dcwangmit01/received_events","type":"User","site_admin":false},"repo":{"id":129145648,"name":"kops","full_name":"dcwangmit01/kops","owner":{"login":"dcwangmit01","id":1733071,"avatar_url":"https://avatars0.githubusercontent.com/u/1733071?v=4","gravatar_id":"","url":"https://api.github.com/users/dcwangmit01","html_url":"https://github.com/dcwangmit01","followers_url":"https://api.github.com/users/dcwangmit01/followers","following_url":"https://api.github.com/users/dcwangmit01/following{/other_user}","gists_url":"https://api.github.com/users/dcwangmit01/gists{/gist_id}","starred_url":"https://api.github.com/users/dcwangmit01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcwangmit01/subscriptions","organizations_url":"https://api.github.com/users/dcwangmit01/orgs","repos_url":"https://api.github.com/users/dcwangmit01/repos","events_url":"https://api.github.com/users/dcwangmit01/events{/privacy}","received_events_url":"https://api.github.com/users/dcwangmit01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcwangmit01/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/dcwangmit01/kops","forks_url":"https://api.github.com/repos/dcwangmit01/kops/forks","keys_url":"https://api.github.com/repos/dcwangmit01/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcwangmit01/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcwangmit01/kops/teams","hooks_url":"https://api.github.com/repos/dcwangmit01/kops/hooks","issue_events_url":"https://api.github.com/repos/dcwangmit01/kops/issues/events{/number}","events_url":"https://api.github.com/repos/dcwangmit01/kops/events","assignees_url":"https://api.github.com/repos/dcwangmit01/kops/assignees{/user}","branches_url":"https://api.github.com/repos/dcwangmit01/kops/branches{/branch}","tags_url":"https://api.github.com/repos/dcwangmit01/kops/tags","blobs_url":"https://api.github.com/repos/dcwangmit01/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcwangmit01/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcwangmit01/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcwangmit01/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcwangmit01/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/dcwangmit01/kops/languages","stargazers_url":"https://api.github.com/repos/dcwangmit01/kops/stargazers","contributors_url":"https://api.github.com/repos/dcwangmit01/kops/contributors","subscribers_url":"https://api.github.com/repos/dcwangmit01/kops/subscribers","subscription_url":"https://api.github.com/repos/dcwangmit01/kops/subscription","commits_url":"https://api.github.com/repos/dcwangmit01/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcwangmit01/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcwangmit01/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcwangmit01/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcwangmit01/kops/contents/{+path}","compare_url":"https://api.github.com/repos/dcwangmit01/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcwangmit01/kops/merges","archive_url":"https://api.github.com/repos/dcwangmit01/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcwangmit01/kops/downloads","issues_url":"https://api.github.com/repos/dcwangmit01/kops/issues{/number}","pulls_url":"https://api.github.com/repos/dcwangmit01/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/dcwangmit01/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/dcwangmit01/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcwangmit01/kops/labels{/name}","releases_url":"https://api.github.com/repos/dcwangmit01/kops/releases{/id}","deployments_url":"https://api.github.com/repos/dcwangmit01/kops/deployments","created_at":"2018-04-11T19:46:22Z","updated_at":"2018-04-11T19:46:28Z","pushed_at":"2018-04-12T15:21:28Z","git_url":"git://github.com/dcwangmit01/kops.git","ssh_url":"git@github.com:dcwangmit01/kops.git","clone_url":"https://github.com/dcwangmit01/kops.git","svn_url":"https://github.com/dcwangmit01/kops","homepage":"","size":174340,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3781d63ca3c9f0ee7dc7adf93dbd78e2c2152742","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2018-05-11T17:50:48Z","pushed_at":"2018-05-11T17:50:31Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":194891,"stargazers_count":5316,"watchers_count":5316,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1526,"mirror_url":null,"archived":false,"open_issues_count":617,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1526,"open_issues":617,"watchers":5316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/4971"},"html":{"href":"https://github.com/kubernetes/kops/pull/4971"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/4971"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/4971/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/4971/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/4971/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/ef958a7f870eb3dc20981617859b8ad69057bb2a"}},"author_association":"NONE"}} | {
"id": 62091339,
"name": "kubernetes/kops",
"url": "https://api.github.com/repos/kubernetes/kops"
} | {
"id": 10553164,
"login": "115100",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10553164?",
"url": "https://api.github.com/users/115100"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-05-11T21:08:24 | 7663393780 | {"actor":{"display_login":"115100"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/216184968","pull_request_review_id":153609723,"id":216184968,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE4NDk2OA==","diff_hunk":"@@ -257,17 +257,51 @@ func (sink *influxdbSink) createDatabase() error {\n \tif sink.dbExists {\n \t\treturn nil\n \t}\n+\n+\t// check whether the specific database exist or not","path":"metrics/sinks/influxdb/influxdb.go","position":5,"original_position":5,"commit_id":"435ccd02bda040407ca7667f37b29536e36a6da5","original_commit_id":"435ccd02bda040407ca7667f37b29536e36a6da5","user":{"login":"andyxning","id":2404712,"node_id":"MDQ6VXNlcjI0MDQ3MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"body":"`exist` -> `exists`","created_at":"2018-09-10T02:28:17Z","updated_at":"2018-09-10T02:28:17Z","html_url":"https://github.com/kubernetes/heapster/pull/2086#discussion_r216184968","pull_request_url":"https://api.github.com/repos/kubernetes/heapster/pulls/2086","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/216184968"},"html":{"href":"https://github.com/kubernetes/heapster/pull/2086#discussion_r216184968"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/2086"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/2086","id":212338360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzM4MzYw","html_url":"https://github.com/kubernetes/heapster/pull/2086","diff_url":"https://github.com/kubernetes/heapster/pull/2086.diff","patch_url":"https://github.com/kubernetes/heapster/pull/2086.patch","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/2086","number":2086,"state":"open","locked":false,"title":"Fix retention policy in influxdb sink","user":{"login":"ringtail","id":3116693,"node_id":"MDQ6VXNlcjMxMTY2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3116693?v=4","gravatar_id":"","url":"https://api.github.com/users/ringtail","html_url":"https://github.com/ringtail","followers_url":"https://api.github.com/users/ringtail/followers","following_url":"https://api.github.com/users/ringtail/following{/other_user}","gists_url":"https://api.github.com/users/ringtail/gists{/gist_id}","starred_url":"https://api.github.com/users/ringtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringtail/subscriptions","organizations_url":"https://api.github.com/users/ringtail/orgs","repos_url":"https://api.github.com/users/ringtail/repos","events_url":"https://api.github.com/users/ringtail/events{/privacy}","received_events_url":"https://api.github.com/users/ringtail/received_events","type":"User","site_admin":false},"body":"Here is the influxdb retention policy creation in master branch. \r\n```\r\nq := influxdb.Query{\r\n\tCommand: fmt.Sprintf(`CREATE DATABASE %s WITH NAME \"default\"`, sink.c.DbName),\r\n}\r\n\r\nif resp, err := sink.client.Query(q); err != nil {\r\n if !(resp != nil && resp.Err != nil && strings.Contains(resp.Err.Error(), \"already exists\")) {\r\n\t\terr := sink.createRetentionPolicy()\r\n\t\tif err != nil {\r\n\t\t\treturn err\r\n\t\t}\r\n\t}\r\n}\r\n```\r\nIf the database is not exist,heapster will create a retention policy named `default` without duration. The retention policy with duration will only be called when the query `CREATE DATABASE %s WITH NAME \"default\"` failed. \r\n\r\nbut this query will never fail,even the database has been existed. It will return the msg below.\r\n```\r\nHTTP/1.1 200 OK\r\nContent-Type: application/json\r\nRequest-Id: 36d40f46-aabf-11e8-802d-000000000000\r\nX-Influxdb-Build: OSS\r\nX-Influxdb-Version: unknown\r\nX-Request-Id: 36d40f46-aabf-11e8-802d-000000000000\r\nDate: Tue, 28 Aug 2018 12:38:07 GMT\r\nTransfer-Encoding: chunked\r\n\r\n{\"results\":[{\"statement_id\":0}]}\r\n``` \r\nSo I change the condition of checking database existing with query `SHOW DATABASES`,And create retention policy with duration when the database is not exist before and created by heapster.\r\n\r\n**What this PR does**\r\nfixes #2084","created_at":"2018-08-31T10:17:28Z","updated_at":"2018-09-10T02:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c1ca8475b602d90c73376c9534c181547a470ce","assignee":{"login":"andyxning","id":2404712,"node_id":"MDQ6VXNlcjI0MDQ3MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false},"assignees":[{"login":"andyxning","id":2404712,"node_id":"MDQ6VXNlcjI0MDQ3MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2404712?v=4","gravatar_id":"","url":"https://api.github.com/users/andyxning","html_url":"https://github.com/andyxning","followers_url":"https://api.github.com/users/andyxning/followers","following_url":"https://api.github.com/users/andyxning/following{/other_user}","gists_url":"https://api.github.com/users/andyxning/gists{/gist_id}","starred_url":"https://api.github.com/users/andyxning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyxning/subscriptions","organizations_url":"https://api.github.com/users/andyxning/orgs","repos_url":"https://api.github.com/users/andyxning/repos","events_url":"https://api.github.com/users/andyxning/events{/privacy}","received_events_url":"https://api.github.com/users/andyxning/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"piosz","id":10819974,"node_id":"MDQ6VXNlcjEwODE5OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485076006,"node_id":"MDU6TGFiZWw0ODUwNzYwMDY=","url":"https://api.github.com/repos/kubernetes/heapster/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680049655,"node_id":"MDU6TGFiZWw2ODAwNDk2NTU=","url":"https://api.github.com/repos/kubernetes/heapster/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/heapster/pulls/2086/commits","review_comments_url":"https://api.github.com/repos/kubernetes/heapster/pulls/2086/comments","review_comment_url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/2086/comments","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/435ccd02bda040407ca7667f37b29536e36a6da5","head":{"label":"ringtail:master","ref":"master","sha":"435ccd02bda040407ca7667f37b29536e36a6da5","user":{"login":"ringtail","id":3116693,"node_id":"MDQ6VXNlcjMxMTY2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3116693?v=4","gravatar_id":"","url":"https://api.github.com/users/ringtail","html_url":"https://github.com/ringtail","followers_url":"https://api.github.com/users/ringtail/followers","following_url":"https://api.github.com/users/ringtail/following{/other_user}","gists_url":"https://api.github.com/users/ringtail/gists{/gist_id}","starred_url":"https://api.github.com/users/ringtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringtail/subscriptions","organizations_url":"https://api.github.com/users/ringtail/orgs","repos_url":"https://api.github.com/users/ringtail/repos","events_url":"https://api.github.com/users/ringtail/events{/privacy}","received_events_url":"https://api.github.com/users/ringtail/received_events","type":"User","site_admin":false},"repo":{"id":146865363,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NjUzNjM=","name":"heapster","full_name":"ringtail/heapster","owner":{"login":"ringtail","id":3116693,"node_id":"MDQ6VXNlcjMxMTY2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3116693?v=4","gravatar_id":"","url":"https://api.github.com/users/ringtail","html_url":"https://github.com/ringtail","followers_url":"https://api.github.com/users/ringtail/followers","following_url":"https://api.github.com/users/ringtail/following{/other_user}","gists_url":"https://api.github.com/users/ringtail/gists{/gist_id}","starred_url":"https://api.github.com/users/ringtail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringtail/subscriptions","organizations_url":"https://api.github.com/users/ringtail/orgs","repos_url":"https://api.github.com/users/ringtail/repos","events_url":"https://api.github.com/users/ringtail/events{/privacy}","received_events_url":"https://api.github.com/users/ringtail/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ringtail/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":true,"url":"https://api.github.com/repos/ringtail/heapster","forks_url":"https://api.github.com/repos/ringtail/heapster/forks","keys_url":"https://api.github.com/repos/ringtail/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringtail/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringtail/heapster/teams","hooks_url":"https://api.github.com/repos/ringtail/heapster/hooks","issue_events_url":"https://api.github.com/repos/ringtail/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/ringtail/heapster/events","assignees_url":"https://api.github.com/repos/ringtail/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/ringtail/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/ringtail/heapster/tags","blobs_url":"https://api.github.com/repos/ringtail/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringtail/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringtail/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringtail/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringtail/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/ringtail/heapster/languages","stargazers_url":"https://api.github.com/repos/ringtail/heapster/stargazers","contributors_url":"https://api.github.com/repos/ringtail/heapster/contributors","subscribers_url":"https://api.github.com/repos/ringtail/heapster/subscribers","subscription_url":"https://api.github.com/repos/ringtail/heapster/subscription","commits_url":"https://api.github.com/repos/ringtail/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringtail/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringtail/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringtail/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/ringtail/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/ringtail/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringtail/heapster/merges","archive_url":"https://api.github.com/repos/ringtail/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringtail/heapster/downloads","issues_url":"https://api.github.com/repos/ringtail/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/ringtail/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/ringtail/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/ringtail/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringtail/heapster/labels{/name}","releases_url":"https://api.github.com/repos/ringtail/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/ringtail/heapster/deployments","created_at":"2018-08-31T08:40:31Z","updated_at":"2018-09-06T03:03:55Z","pushed_at":"2018-09-07T05:56:52Z","git_url":"git://github.com/ringtail/heapster.git","ssh_url":"git@github.com:ringtail/heapster.git","clone_url":"https://github.com/ringtail/heapster.git","svn_url":"https://github.com/ringtail/heapster","homepage":"","size":40018,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f28b60c7176b7a8a3ce9014ca00b9f4e58203203","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"node_id":"MDEwOlJlcG9zaXRvcnkyMzI3MjUxMA==","name":"heapster","full_name":"kubernetes/heapster","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/heapster","forks_url":"https://api.github.com/repos/kubernetes/heapster/forks","keys_url":"https://api.github.com/repos/kubernetes/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/heapster/teams","hooks_url":"https://api.github.com/repos/kubernetes/heapster/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/heapster/events","assignees_url":"https://api.github.com/repos/kubernetes/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/heapster/tags","blobs_url":"https://api.github.com/repos/kubernetes/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/heapster/languages","stargazers_url":"https://api.github.com/repos/kubernetes/heapster/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/heapster/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/heapster/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/heapster/subscription","commits_url":"https://api.github.com/repos/kubernetes/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/heapster/merges","archive_url":"https://api.github.com/repos/kubernetes/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/heapster/downloads","issues_url":"https://api.github.com/repos/kubernetes/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/heapster/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/heapster/deployments","created_at":"2014-08-24T03:50:18Z","updated_at":"2018-09-09T13:21:22Z","pushed_at":"2018-09-06T03:03:55Z","git_url":"git://github.com/kubernetes/heapster.git","ssh_url":"git@github.com:kubernetes/heapster.git","clone_url":"https://github.com/kubernetes/heapster.git","svn_url":"https://github.com/kubernetes/heapster","homepage":"","size":44814,"stargazers_count":2293,"watchers_count":2293,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1098,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1098,"open_issues":39,"watchers":2293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/2086"},"html":{"href":"https://github.com/kubernetes/heapster/pull/2086"},"issue":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/2086"},"comments":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/2086/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/2086/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/2086/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/heapster/statuses/435ccd02bda040407ca7667f37b29536e36a6da5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 23272510,
"name": "kubernetes/heapster",
"url": "https://api.github.com/repos/kubernetes/heapster"
} | {
"id": 2404712,
"login": "andyxning",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2404712?",
"url": "https://api.github.com/users/andyxning"
} | {
"id": 13629408,
"login": "kubernetes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13629408?",
"url": "https://api.github.com/orgs/kubernetes"
} | 2018-09-10T02:28:17 | 8237362226 | {"actor":{"display_login":"andyxning"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/recharts/recharts/pulls/comments/231428789","pull_request_review_id":172380133,"id":231428789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQyODc4OQ==","diff_hunk":"@@ -0,0 +1,444 @@\n+/**\n+ * @fileOverview Render sectors of a funnel\n+ */\n+import React, { Component } from 'react';\n+import PropTypes from 'prop-types';\n+import Animate from 'react-smooth';\n+import classNames from 'classnames';\n+import _ from 'lodash';\n+import pureRender from '../util/PureRender';\n+import Layer from '../container/Layer';\n+import Trapezoid from '../shape/Trapezoid';\n+import Curve from '../shape/Curve';\n+import Text from './Text';\n+import Cell from './Cell';\n+import { PRESENTATION_ATTRIBUTES, EVENT_ATTRIBUTES,\n+ getPresentationAttributes, findAllByType, filterEventsOfChild, isSsr } from '../util/ReactUtils';\n+import { interpolateNumber, uniqueId } from '../util/DataUtils';\n+import { getValueByDataKey } from '../util/ChartUtils';\n+\n+@pureRender\n+class Funnel extends Component {\n+\n+ static displayName = 'Funnel';\n+\n+ static propTypes = {\n+ ...PRESENTATION_ATTRIBUTES,\n+ ...EVENT_ATTRIBUTES,\n+ className: PropTypes.string,\n+ animationId: PropTypes.number,\n+ dataKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.func]).isRequired,\n+ nameKey: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.func]),\n+ data: PropTypes.arrayOf(PropTypes.object),\n+ width: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.func]),\n+ trapezoids: PropTypes.arrayOf(PropTypes.object),\n+ hide: PropTypes.bool,\n+ labelLine: PropTypes.oneOfType([\n+ PropTypes.object, PropTypes.func, PropTypes.element, PropTypes.bool,\n+ ]),\n+ label: PropTypes.oneOfType([\n+ PropTypes.object, PropTypes.func, PropTypes.element, PropTypes.bool,\n+ ]),\n+ activeShape: PropTypes.oneOfType([\n+ PropTypes.object, PropTypes.func, PropTypes.element,\n+ ]),\n+ activeIndex: PropTypes.oneOfType([PropTypes.number, PropTypes.arrayOf(PropTypes.number)]),\n+\n+ isAnimationActive: PropTypes.bool,\n+ animationBegin: PropTypes.number,\n+ animationDuration: PropTypes.number,\n+ animationEasing: PropTypes.oneOf([\n+ 'ease',\n+ 'ease-in',\n+ 'ease-out',\n+ 'ease-in-out',\n+ 'spring',\n+ 'linear',\n+ ]),\n+ id: PropTypes.string,\n+ };\n+\n+ static defaultProps = {\n+ stroke: '#fff',\n+ fill: '#808080',\n+ legendType: 'rect',\n+ // The abscissa of pole\n+ cx: '0%',\n+ // The ordinate of pole\n+ cy: '0%',\n+ labelLine: true,\n+ hide: false,\n+ isAnimationActive: !isSsr(),\n+ animationBegin: 400,\n+ animationDuration: 1500,\n+ animationEasing: 'ease',\n+ nameKey: 'name',\n+ };\n+\n+ static getRealFunnelData = (item) => {\n+ const { data, children } = item.props;\n+ const presentationProps = getPresentationAttributes(item.props);\n+ const cells = findAllByType(children, Cell);\n+\n+ if (data && data.length) {\n+ return data.map((entry, index) => ({\n+ payload: entry,\n+ ...presentationProps,\n+ ...entry,\n+ ...(cells && cells[index] && cells[index].props),\n+ }));\n+ }\n+\n+ if (cells && cells.length) {\n+ return cells.map(cell => ({ ...presentationProps, ...cell.props }));\n+ }\n+\n+ return [];\n+ };\n+\n+ static getRealWidthHeight = (item, offset) => {\n+ const customWidth = item.props.width;\n+ const { width, height, left, right, top, bottom } = offset;\n+ const realHeight = height;\n+ let realWidth = width;\n+\n+ if (_.isNumber(customWidth)) {\n+ realWidth = customWidth;\n+ } else if (_.isString(customWidth)) {\n+ realWidth = realWidth * parseFloat(customWidth) / 100;\n+ }\n+\n+ return {\n+ realWidth: realWidth - left - right - 50,\n+ realHeight: realHeight - bottom - top,\n+ offsetX: (width - realWidth) / 2,\n+ offsetY: (height - realHeight) / 2,\n+ };\n+ }\n+\n+ static getComposedData = ({ item, offset, onItemMouseLeave, onItemMouseEnter }) => {\n+ const funnelData = Funnel.getRealFunnelData(item);\n+ const { dataKey, nameKey } = item.props;\n+ const { left, top } = offset;\n+ const { realHeight, realWidth, offsetX, offsetY } = Funnel.getRealWidthHeight(item, offset);\n+ const maxValue = getValueByDataKey(funnelData[0], dataKey, 0);\n+ const len = funnelData.length;\n+ const rowHeight = realHeight / len;\n+\n+ const trapezoids = funnelData.map((entry, i) => {\n+ const val = getValueByDataKey(entry, dataKey, 0);\n+ const name = getValueByDataKey(entry, nameKey, i);\n+ let nextVal = 0;\n+ if (i !== (len - 1)) {\n+ nextVal = getValueByDataKey(funnelData[i + 1], dataKey, 0);\n+ }\n+\n+ const x = (maxValue - val) * realWidth / (2 * maxValue) + top + 25 + offsetX;\n+ const y = realHeight / len * i + left + offsetY;\n+ const upperWidth = val / maxValue * realWidth;\n+ const lowerWidth = nextVal / maxValue * realWidth;\n+\n+ const tooltipPayload = [{ name, value: val, payload: entry }];\n+ const tooltipPosition = {\n+ x: x + upperWidth / 2,\n+ y: y + rowHeight / 2,\n+ };\n+\n+ return {\n+ x,\n+ y,\n+ upperWidth,\n+ lowerWidth,\n+ height: rowHeight,\n+ name,\n+ val,\n+ tooltipPayload,\n+ tooltipPosition,\n+ ..._.omit(entry, 'width'),\n+ payload: entry\n+ };\n+ });\n+\n+ return {\n+ trapezoids,\n+ data: funnelData,\n+ onMouseLeave: onItemMouseLeave,\n+ onMouseEnter: onItemMouseEnter,\n+ };\n+ }\n+\n+ state = { isAnimationFinished: false };\n+\n+ componentWillReceiveProps(nextProps) {\n+ const { animationId, trapezoids } = this.props;\n+\n+ if (nextProps.isAnimationActive !== this.props.isAnimationActive) {\n+ this.cachePrevData([]);\n+ } else if (nextProps.animationId !== animationId) {\n+ this.cachePrevData(trapezoids);\n+ }\n+ }\n+\n+ static getTextAnchor(x, cx) {\n+ if (x > cx) {\n+ return 'start';\n+ } if (x < cx) {\n+ return 'end';\n+ }\n+\n+ return 'middle';\n+ }\n+\n+ id = uniqueId('recharts-pie-');\n+\n+ cachePrevData = (trapezoids) => {\n+ this.setState({ prevTrapezoids: trapezoids });\n+ };\n+\n+ isActiveIndex(i) {\n+ const { activeIndex } = this.props;\n+\n+ if (Array.isArray(activeIndex)) {\n+ return activeIndex.indexOf(i) !== -1;\n+ }\n+\n+ return i === activeIndex;\n+ }\n+\n+ handleAnimationEnd = () => {\n+ const { onAnimationEnd } = this.props;\n+\n+ this.setState({\n+ isAnimationFinished: true,\n+ });\n+\n+ if (_.isFunction(onAnimationEnd)) {\n+ onAnimationEnd();\n+ }\n+ };\n+\n+ handleAnimationStart = () => {\n+ const { onAnimationStart } = this.props;\n+\n+ this.setState({\n+ isAnimationFinished: false,\n+ });\n+\n+ if (_.isFunction(onAnimationStart)) {\n+ onAnimationStart();\n+ }\n+ }\n+\n+ static renderLabelLineItem(option, props) {\n+ if (React.isValidElement(option)) {\n+ return React.cloneElement(option, props);\n+ } if (_.isFunction(option)) {\n+ return option(props);\n+ }\n+\n+ return <Curve {...props} type=\"linear\" className=\"recharts-funnel-label-line\" />;\n+ }\n+\n+ static renderLabelItem(option, props, value) {\n+ if (React.isValidElement(option)) {\n+ return React.cloneElement(option, props);\n+ }\n+ let label = value;\n+ if (_.isFunction(option)) {\n+ label = option(props);\n+ if (React.isValidElement(label)) {\n+ return label;\n+ }\n+ }\n+\n+ const { name } = props;\n+ return (\n+ <Text\n+ {...props}\n+ verticalAnchor=\"middle\"\n+ className=\"recharts-funnel-label-text\"\n+ >\n+ {`${name}:${label}`}\n+ </Text>\n+ );\n+ }\n+\n+ renderLabels(trapezoids) {\n+ const { isAnimationActive } = this.props;\n+ if (isAnimationActive && !this.state.isAnimationFinished) {\n+ return null;\n+ }\n+ const { label, labelLine, dataKey } = this.props;\n+ const funnelProps = _.omit(getPresentationAttributes(this.props), 'width');\n+ const customLabelProps = getPresentationAttributes(label);\n+ const customLabelLineProps = getPresentationAttributes(labelLine);\n+\n+ const labels = trapezoids.map((entry, i) => {\n+ let labelProps = {\n+ ...funnelProps,\n+ ...entry,\n+ stroke: '#000',\n+ fill: '#000',\n+ ...customLabelProps,\n+ index: i,\n+ textAnchor: 'middle',\n+ x: entry.x + entry.upperWidth / 2,\n+ y: entry.y + entry.height / 2,\n+ };\n+ let lineProps = {\n+ ...funnelProps,\n+ ...entry,\n+ fill: 'none',\n+ stroke: entry.fill,\n+ ...customLabelLineProps,\n+ index: i,\n+ };\n+\n+ if (label.position === 'right') {\n+ const labelX = entry.x + entry.upperWidth - (entry.upperWidth - entry.lowerWidth) / 4;\n+ const labelY = entry.y + entry.height / 2;\n+ labelProps = {\n+ ...labelProps,\n+ textAnchor: 'start',\n+ stroke: entry.fill,\n+ x: labelX + 20,\n+ y: labelY,\n+ };\n+ lineProps = {\n+ fill: entry.fill,\n+ stroke: entry.fill,\n+ points: [{\n+ x: labelX + 5,\n+ y: labelY,\n+ }, {\n+ x: labelX + 15,\n+ y: labelY,\n+ }],\n+ };\n+ }\n+\n+ return (\n+ <Layer key={`label-${i}`}>\n+ {labelLine && this.constructor.renderLabelLineItem(labelLine, lineProps)}\n+ {this.constructor.renderLabelItem(\n+ label,\n+ labelProps,\n+ getValueByDataKey(entry, dataKey)\n+ )}\n+ </Layer>\n+ );\n+ });\n+\n+ return <Layer className=\"recharts-funnel-labels\">{labels}</Layer>;\n+ }\n+\n+ static renderTrapezoidItem(option, props) {\n+ if (React.isValidElement(option)) {\n+ return React.cloneElement(option, props);\n+ } if (_.isFunction(option)) {\n+ return option(props);\n+ } if (_.isPlainObject(option)) {\n+ return <Trapezoid {...props} {...option} />;\n+ }\n+\n+ return <Trapezoid {...props} />;\n+ }\n+\n+ renderTrapezoidsStatically(trapezoids) {\n+ const { activeShape } = this.props;\n+\n+ return trapezoids.map((entry, i) => {\n+ const trapezoidOptions = this.isActiveIndex(i) ? activeShape : null;\n+ const trapezoidProps = {\n+ ...entry,\n+ stroke: entry.stroke\n+ };\n+\n+ return (\n+ <Layer\n+ className=\"recharts-funnel-trapezoid\"\n+ {...filterEventsOfChild(this.props, entry, i)}\n+ key={`trapezoid-${i}`}\n+ >\n+ {this.constructor.renderTrapezoidItem(trapezoidOptions, trapezoidProps)}\n+ </Layer>\n+ );\n+ });\n+ }\n+\n+ renderTrapezoidsWithAnimation() {\n+ const { trapezoids, isAnimationActive, animationBegin, animationDuration,\n+ animationEasing, animationId } = this.props;\n+ const { prevTrapezoids } = this.state;\n+ return (\n+ <Animate\n+ begin={animationBegin}\n+ duration={animationDuration}\n+ isActive={isAnimationActive}\n+ easing={animationEasing}\n+ from={{ t: 0 }}\n+ to={{ t: 1 }}\n+ key={`funnel-${animationId}`}\n+ onAnimationEnd={this.handleAnimationEnd}\n+ onAnimationStart={this.handleAnimationStart}\n+ >\n+ {\n+ ({ t }) => {\n+ const stepData = trapezoids.map((entry, index) => {\n+ const prev = prevTrapezoids && prevTrapezoids[index];\n+ if (prev) {\n+ const interpolatorX = interpolateNumber(prev.x, entry.x);\n+ const interpolatorY = interpolateNumber(prev.y, entry.y);\n+\n+ return {\n+ ...entry,\n+ x: interpolatorX(t),\n+ y: interpolatorY(t),\n+ };\n+ }\n+\n+ const interpolatorX = interpolateNumber(0, entry.x);","path":"src/component/Funnel.js","position":400,"original_position":400,"commit_id":"8326ae77673061e749011c50213876249709c3dd","original_commit_id":"8326ae77673061e749011c50213876249709c3dd","user":{"login":"xile611","id":6111424,"node_id":"MDQ6VXNlcjYxMTE0MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6111424?v=4","gravatar_id":"","url":"https://api.github.com/users/xile611","html_url":"https://github.com/xile611","followers_url":"https://api.github.com/users/xile611/followers","following_url":"https://api.github.com/users/xile611/following{/other_user}","gists_url":"https://api.github.com/users/xile611/gists{/gist_id}","starred_url":"https://api.github.com/users/xile611/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xile611/subscriptions","organizations_url":"https://api.github.com/users/xile611/orgs","repos_url":"https://api.github.com/users/xile611/repos","events_url":"https://api.github.com/users/xile611/events{/privacy}","received_events_url":"https://api.github.com/users/xile611/received_events","type":"User","site_admin":false},"body":"It's strange to only interpolate `x` and `y`","created_at":"2018-11-07T09:15:27Z","updated_at":"2018-11-07T09:37:58Z","html_url":"https://github.com/recharts/recharts/pull/1556#discussion_r231428789","pull_request_url":"https://api.github.com/repos/recharts/recharts/pulls/1556","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/recharts/recharts/pulls/comments/231428789"},"html":{"href":"https://github.com/recharts/recharts/pull/1556#discussion_r231428789"},"pull_request":{"href":"https://api.github.com/repos/recharts/recharts/pulls/1556"}}},"pull_request":{"url":"https://api.github.com/repos/recharts/recharts/pulls/1556","id":228927629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTI3NjI5","html_url":"https://github.com/recharts/recharts/pull/1556","diff_url":"https://github.com/recharts/recharts/pull/1556.diff","patch_url":"https://github.com/recharts/recharts/pull/1556.patch","issue_url":"https://api.github.com/repos/recharts/recharts/issues/1556","number":1556,"state":"open","locked":false,"title":"feat: add funnel ","user":{"login":"huxiaoyun","id":4345248,"node_id":"MDQ6VXNlcjQzNDUyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4345248?v=4","gravatar_id":"","url":"https://api.github.com/users/huxiaoyun","html_url":"https://github.com/huxiaoyun","followers_url":"https://api.github.com/users/huxiaoyun/followers","following_url":"https://api.github.com/users/huxiaoyun/following{/other_user}","gists_url":"https://api.github.com/users/huxiaoyun/gists{/gist_id}","starred_url":"https://api.github.com/users/huxiaoyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huxiaoyun/subscriptions","organizations_url":"https://api.github.com/users/huxiaoyun/orgs","repos_url":"https://api.github.com/users/huxiaoyun/repos","events_url":"https://api.github.com/users/huxiaoyun/events{/privacy}","received_events_url":"https://api.github.com/users/huxiaoyun/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-07T06:15:11Z","updated_at":"2018-11-07T09:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"469fab400ba9ec361f779e2c456b3481368130ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/recharts/recharts/pulls/1556/commits","review_comments_url":"https://api.github.com/repos/recharts/recharts/pulls/1556/comments","review_comment_url":"https://api.github.com/repos/recharts/recharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/recharts/recharts/issues/1556/comments","statuses_url":"https://api.github.com/repos/recharts/recharts/statuses/8326ae77673061e749011c50213876249709c3dd","head":{"label":"huxiaoyun:master","ref":"master","sha":"8326ae77673061e749011c50213876249709c3dd","user":{"login":"huxiaoyun","id":4345248,"node_id":"MDQ6VXNlcjQzNDUyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4345248?v=4","gravatar_id":"","url":"https://api.github.com/users/huxiaoyun","html_url":"https://github.com/huxiaoyun","followers_url":"https://api.github.com/users/huxiaoyun/followers","following_url":"https://api.github.com/users/huxiaoyun/following{/other_user}","gists_url":"https://api.github.com/users/huxiaoyun/gists{/gist_id}","starred_url":"https://api.github.com/users/huxiaoyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huxiaoyun/subscriptions","organizations_url":"https://api.github.com/users/huxiaoyun/orgs","repos_url":"https://api.github.com/users/huxiaoyun/repos","events_url":"https://api.github.com/users/huxiaoyun/events{/privacy}","received_events_url":"https://api.github.com/users/huxiaoyun/received_events","type":"User","site_admin":false},"repo":{"id":116241918,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYyNDE5MTg=","name":"recharts","full_name":"huxiaoyun/recharts","private":false,"owner":{"login":"huxiaoyun","id":4345248,"node_id":"MDQ6VXNlcjQzNDUyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4345248?v=4","gravatar_id":"","url":"https://api.github.com/users/huxiaoyun","html_url":"https://github.com/huxiaoyun","followers_url":"https://api.github.com/users/huxiaoyun/followers","following_url":"https://api.github.com/users/huxiaoyun/following{/other_user}","gists_url":"https://api.github.com/users/huxiaoyun/gists{/gist_id}","starred_url":"https://api.github.com/users/huxiaoyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huxiaoyun/subscriptions","organizations_url":"https://api.github.com/users/huxiaoyun/orgs","repos_url":"https://api.github.com/users/huxiaoyun/repos","events_url":"https://api.github.com/users/huxiaoyun/events{/privacy}","received_events_url":"https://api.github.com/users/huxiaoyun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/huxiaoyun/recharts","description":"Redefined chart library built with React and D3","fork":true,"url":"https://api.github.com/repos/huxiaoyun/recharts","forks_url":"https://api.github.com/repos/huxiaoyun/recharts/forks","keys_url":"https://api.github.com/repos/huxiaoyun/recharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huxiaoyun/recharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huxiaoyun/recharts/teams","hooks_url":"https://api.github.com/repos/huxiaoyun/recharts/hooks","issue_events_url":"https://api.github.com/repos/huxiaoyun/recharts/issues/events{/number}","events_url":"https://api.github.com/repos/huxiaoyun/recharts/events","assignees_url":"https://api.github.com/repos/huxiaoyun/recharts/assignees{/user}","branches_url":"https://api.github.com/repos/huxiaoyun/recharts/branches{/branch}","tags_url":"https://api.github.com/repos/huxiaoyun/recharts/tags","blobs_url":"https://api.github.com/repos/huxiaoyun/recharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huxiaoyun/recharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huxiaoyun/recharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/huxiaoyun/recharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huxiaoyun/recharts/statuses/{sha}","languages_url":"https://api.github.com/repos/huxiaoyun/recharts/languages","stargazers_url":"https://api.github.com/repos/huxiaoyun/recharts/stargazers","contributors_url":"https://api.github.com/repos/huxiaoyun/recharts/contributors","subscribers_url":"https://api.github.com/repos/huxiaoyun/recharts/subscribers","subscription_url":"https://api.github.com/repos/huxiaoyun/recharts/subscription","commits_url":"https://api.github.com/repos/huxiaoyun/recharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/huxiaoyun/recharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/huxiaoyun/recharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/huxiaoyun/recharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/huxiaoyun/recharts/contents/{+path}","compare_url":"https://api.github.com/repos/huxiaoyun/recharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huxiaoyun/recharts/merges","archive_url":"https://api.github.com/repos/huxiaoyun/recharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huxiaoyun/recharts/downloads","issues_url":"https://api.github.com/repos/huxiaoyun/recharts/issues{/number}","pulls_url":"https://api.github.com/repos/huxiaoyun/recharts/pulls{/number}","milestones_url":"https://api.github.com/repos/huxiaoyun/recharts/milestones{/number}","notifications_url":"https://api.github.com/repos/huxiaoyun/recharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huxiaoyun/recharts/labels{/name}","releases_url":"https://api.github.com/repos/huxiaoyun/recharts/releases{/id}","deployments_url":"https://api.github.com/repos/huxiaoyun/recharts/deployments","created_at":"2018-01-04T09:37:21Z","updated_at":"2018-11-07T06:21:48Z","pushed_at":"2018-11-07T06:21:46Z","git_url":"git://github.com/huxiaoyun/recharts.git","ssh_url":"git@github.com:huxiaoyun/recharts.git","clone_url":"https://github.com/huxiaoyun/recharts.git","svn_url":"https://github.com/huxiaoyun/recharts","homepage":"http://recharts.org","size":5202,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"recharts:master","ref":"master","sha":"9b9546122c168bb3c3d2e9b061784c971834e73e","user":{"login":"recharts","id":13690587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjkwNTg3","avatar_url":"https://avatars0.githubusercontent.com/u/13690587?v=4","gravatar_id":"","url":"https://api.github.com/users/recharts","html_url":"https://github.com/recharts","followers_url":"https://api.github.com/users/recharts/followers","following_url":"https://api.github.com/users/recharts/following{/other_user}","gists_url":"https://api.github.com/users/recharts/gists{/gist_id}","starred_url":"https://api.github.com/users/recharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recharts/subscriptions","organizations_url":"https://api.github.com/users/recharts/orgs","repos_url":"https://api.github.com/users/recharts/repos","events_url":"https://api.github.com/users/recharts/events{/privacy}","received_events_url":"https://api.github.com/users/recharts/received_events","type":"Organization","site_admin":false},"repo":{"id":40345658,"node_id":"MDEwOlJlcG9zaXRvcnk0MDM0NTY1OA==","name":"recharts","full_name":"recharts/recharts","private":false,"owner":{"login":"recharts","id":13690587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjkwNTg3","avatar_url":"https://avatars0.githubusercontent.com/u/13690587?v=4","gravatar_id":"","url":"https://api.github.com/users/recharts","html_url":"https://github.com/recharts","followers_url":"https://api.github.com/users/recharts/followers","following_url":"https://api.github.com/users/recharts/following{/other_user}","gists_url":"https://api.github.com/users/recharts/gists{/gist_id}","starred_url":"https://api.github.com/users/recharts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recharts/subscriptions","organizations_url":"https://api.github.com/users/recharts/orgs","repos_url":"https://api.github.com/users/recharts/repos","events_url":"https://api.github.com/users/recharts/events{/privacy}","received_events_url":"https://api.github.com/users/recharts/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/recharts/recharts","description":"Redefined chart library built with React and D3","fork":false,"url":"https://api.github.com/repos/recharts/recharts","forks_url":"https://api.github.com/repos/recharts/recharts/forks","keys_url":"https://api.github.com/repos/recharts/recharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recharts/recharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recharts/recharts/teams","hooks_url":"https://api.github.com/repos/recharts/recharts/hooks","issue_events_url":"https://api.github.com/repos/recharts/recharts/issues/events{/number}","events_url":"https://api.github.com/repos/recharts/recharts/events","assignees_url":"https://api.github.com/repos/recharts/recharts/assignees{/user}","branches_url":"https://api.github.com/repos/recharts/recharts/branches{/branch}","tags_url":"https://api.github.com/repos/recharts/recharts/tags","blobs_url":"https://api.github.com/repos/recharts/recharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recharts/recharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recharts/recharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/recharts/recharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recharts/recharts/statuses/{sha}","languages_url":"https://api.github.com/repos/recharts/recharts/languages","stargazers_url":"https://api.github.com/repos/recharts/recharts/stargazers","contributors_url":"https://api.github.com/repos/recharts/recharts/contributors","subscribers_url":"https://api.github.com/repos/recharts/recharts/subscribers","subscription_url":"https://api.github.com/repos/recharts/recharts/subscription","commits_url":"https://api.github.com/repos/recharts/recharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/recharts/recharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/recharts/recharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/recharts/recharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/recharts/recharts/contents/{+path}","compare_url":"https://api.github.com/repos/recharts/recharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recharts/recharts/merges","archive_url":"https://api.github.com/repos/recharts/recharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recharts/recharts/downloads","issues_url":"https://api.github.com/repos/recharts/recharts/issues{/number}","pulls_url":"https://api.github.com/repos/recharts/recharts/pulls{/number}","milestones_url":"https://api.github.com/repos/recharts/recharts/milestones{/number}","notifications_url":"https://api.github.com/repos/recharts/recharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recharts/recharts/labels{/name}","releases_url":"https://api.github.com/repos/recharts/recharts/releases{/id}","deployments_url":"https://api.github.com/repos/recharts/recharts/deployments","created_at":"2015-08-07T06:50:27Z","updated_at":"2018-11-07T08:42:01Z","pushed_at":"2018-11-07T06:21:48Z","git_url":"git://github.com/recharts/recharts.git","ssh_url":"git@github.com:recharts/recharts.git","clone_url":"https://github.com/recharts/recharts.git","svn_url":"https://github.com/recharts/recharts","homepage":"http://recharts.org","size":5376,"stargazers_count":10244,"watchers_count":10244,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":780,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":780,"open_issues":501,"watchers":10244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/recharts/recharts/pulls/1556"},"html":{"href":"https://github.com/recharts/recharts/pull/1556"},"issue":{"href":"https://api.github.com/repos/recharts/recharts/issues/1556"},"comments":{"href":"https://api.github.com/repos/recharts/recharts/issues/1556/comments"},"review_comments":{"href":"https://api.github.com/repos/recharts/recharts/pulls/1556/comments"},"review_comment":{"href":"https://api.github.com/repos/recharts/recharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/recharts/recharts/pulls/1556/commits"},"statuses":{"href":"https://api.github.com/repos/recharts/recharts/statuses/8326ae77673061e749011c50213876249709c3dd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 40345658,
"name": "recharts/recharts",
"url": "https://api.github.com/repos/recharts/recharts"
} | {
"id": 6111424,
"login": "xile611",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6111424?",
"url": "https://api.github.com/users/xile611"
} | {
"id": 13690587,
"login": "recharts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13690587?",
"url": "https://api.github.com/orgs/recharts"
} | 2018-11-07T09:15:27 | 8548403725 | {"actor":{"display_login":"xile611"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/comments/176946629","pull_request_review_id":106736306,"id":176946629,"diff_hunk":"@@ -135,4 +136,16 @@ private function replaceCommentHeadlines($html)\n {\n return preg_replace('/<h\\d+.*?>(.*?)<\\\\/h\\d+>/i',\"<p><strong>\\\\1</strong></p>\", $html);\n }\n+\n+ /**\n+ * @param string $html\n+ *\n+ * @return string\n+ */\n+ private function replaceImageUrlForProxy($html)\n+ {\n+ return preg_replace_callback('/(<img[^>]+?)src=\"(.+?)\"/i', function($matches) {","path":"components/Formatter.php","position":20,"original_position":20,"commit_id":"dd0d29087d896e48727dd511a27b67fbeff41379","original_commit_id":"dd0d29087d896e48727dd511a27b67fbeff41379","user":{"login":"samdark","id":47294,"avatar_url":"https://avatars2.githubusercontent.com/u/47294?v=4","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"body":"Instead of `\"`, `'` or nothing could be used for attribute values. Correct regexp would be:\r\n\r\n```php\r\nreturn preg_replace_callback('/(<img[^>]+?)src=(?:[\"']([^\"']+)[\"']|([^\\s\"'`=<>]+))/i', function($matches) {\r\n```\r\n\r\n","created_at":"2018-03-25T17:00:18Z","updated_at":"2018-03-25T17:00:18Z","html_url":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288#discussion_r176946629","pull_request_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/comments/176946629"},"html":{"href":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288#discussion_r176946629"},"pull_request":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288","id":177279772,"html_url":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288","diff_url":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288.diff","patch_url":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288.patch","issue_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/288","number":288,"state":"open","locked":false,"title":"Fixes #261: mixed content: proxy images that are non-https in Markdown of wiki and extensions","user":{"login":"prodex","id":2266293,"avatar_url":"https://avatars3.githubusercontent.com/u/2266293?v=4","gravatar_id":"","url":"https://api.github.com/users/prodex","html_url":"https://github.com/prodex","followers_url":"https://api.github.com/users/prodex/followers","following_url":"https://api.github.com/users/prodex/following{/other_user}","gists_url":"https://api.github.com/users/prodex/gists{/gist_id}","starred_url":"https://api.github.com/users/prodex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prodex/subscriptions","organizations_url":"https://api.github.com/users/prodex/orgs","repos_url":"https://api.github.com/users/prodex/repos","events_url":"https://api.github.com/users/prodex/events{/privacy}","received_events_url":"https://api.github.com/users/prodex/received_events","type":"User","site_admin":false},"body":"issue #261 \r\n\r\nI suggest a variant with static caching. Replace url in `<img src = \"?\">` if it `http://` and not `https://www.yiiframework.com`.\r\n\r\nConfig nginx:\r\n```nginx\r\nlocation /storageProxyFile/ {\r\n internal; #Direct file access is closed.\r\n\r\n alias /var/site/runtime/storageProxyFile/;\r\n expires max;\r\n}\r\n```\r\nBy cron, you can periodically clean old files.\r\n\r\n","created_at":"2018-03-25T09:04:55Z","updated_at":"2018-03-25T17:00:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f39a751f89e95bea8f1c3fcc9ee7666cc837c281","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":145633571,"url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/milestones/3","html_url":"https://github.com/yiisoft-contrib/yiiframework.com/milestone/3","labels_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/milestones/3/labels","id":1760024,"number":3,"title":"after launch priority","description":"should be fixed quite fast after launch","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars0.githubusercontent.com/u/189796?v=4","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":11,"state":"open","created_at":"2016-05-11T12:45:43Z","updated_at":"2018-03-25T16:50:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288/commits","review_comments_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288/comments","review_comment_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/288/comments","statuses_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/statuses/dd0d29087d896e48727dd511a27b67fbeff41379","head":{"label":"prodex:task-261","ref":"task-261","sha":"dd0d29087d896e48727dd511a27b67fbeff41379","user":{"login":"prodex","id":2266293,"avatar_url":"https://avatars3.githubusercontent.com/u/2266293?v=4","gravatar_id":"","url":"https://api.github.com/users/prodex","html_url":"https://github.com/prodex","followers_url":"https://api.github.com/users/prodex/followers","following_url":"https://api.github.com/users/prodex/following{/other_user}","gists_url":"https://api.github.com/users/prodex/gists{/gist_id}","starred_url":"https://api.github.com/users/prodex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prodex/subscriptions","organizations_url":"https://api.github.com/users/prodex/orgs","repos_url":"https://api.github.com/users/prodex/repos","events_url":"https://api.github.com/users/prodex/events{/privacy}","received_events_url":"https://api.github.com/users/prodex/received_events","type":"User","site_admin":false},"repo":{"id":61668452,"name":"yiiframework.com","full_name":"prodex/yiiframework.com","owner":{"login":"prodex","id":2266293,"avatar_url":"https://avatars3.githubusercontent.com/u/2266293?v=4","gravatar_id":"","url":"https://api.github.com/users/prodex","html_url":"https://github.com/prodex","followers_url":"https://api.github.com/users/prodex/followers","following_url":"https://api.github.com/users/prodex/following{/other_user}","gists_url":"https://api.github.com/users/prodex/gists{/gist_id}","starred_url":"https://api.github.com/users/prodex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prodex/subscriptions","organizations_url":"https://api.github.com/users/prodex/orgs","repos_url":"https://api.github.com/users/prodex/repos","events_url":"https://api.github.com/users/prodex/events{/privacy}","received_events_url":"https://api.github.com/users/prodex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prodex/yiiframework.com","description":"Source code for official Yii website, WIP:","fork":true,"url":"https://api.github.com/repos/prodex/yiiframework.com","forks_url":"https://api.github.com/repos/prodex/yiiframework.com/forks","keys_url":"https://api.github.com/repos/prodex/yiiframework.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prodex/yiiframework.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prodex/yiiframework.com/teams","hooks_url":"https://api.github.com/repos/prodex/yiiframework.com/hooks","issue_events_url":"https://api.github.com/repos/prodex/yiiframework.com/issues/events{/number}","events_url":"https://api.github.com/repos/prodex/yiiframework.com/events","assignees_url":"https://api.github.com/repos/prodex/yiiframework.com/assignees{/user}","branches_url":"https://api.github.com/repos/prodex/yiiframework.com/branches{/branch}","tags_url":"https://api.github.com/repos/prodex/yiiframework.com/tags","blobs_url":"https://api.github.com/repos/prodex/yiiframework.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prodex/yiiframework.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prodex/yiiframework.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/prodex/yiiframework.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prodex/yiiframework.com/statuses/{sha}","languages_url":"https://api.github.com/repos/prodex/yiiframework.com/languages","stargazers_url":"https://api.github.com/repos/prodex/yiiframework.com/stargazers","contributors_url":"https://api.github.com/repos/prodex/yiiframework.com/contributors","subscribers_url":"https://api.github.com/repos/prodex/yiiframework.com/subscribers","subscription_url":"https://api.github.com/repos/prodex/yiiframework.com/subscription","commits_url":"https://api.github.com/repos/prodex/yiiframework.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/prodex/yiiframework.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/prodex/yiiframework.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/prodex/yiiframework.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/prodex/yiiframework.com/contents/{+path}","compare_url":"https://api.github.com/repos/prodex/yiiframework.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prodex/yiiframework.com/merges","archive_url":"https://api.github.com/repos/prodex/yiiframework.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prodex/yiiframework.com/downloads","issues_url":"https://api.github.com/repos/prodex/yiiframework.com/issues{/number}","pulls_url":"https://api.github.com/repos/prodex/yiiframework.com/pulls{/number}","milestones_url":"https://api.github.com/repos/prodex/yiiframework.com/milestones{/number}","notifications_url":"https://api.github.com/repos/prodex/yiiframework.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prodex/yiiframework.com/labels{/name}","releases_url":"https://api.github.com/repos/prodex/yiiframework.com/releases{/id}","deployments_url":"https://api.github.com/repos/prodex/yiiframework.com/deployments","created_at":"2016-06-21T21:29:43Z","updated_at":"2018-03-25T08:44:57Z","pushed_at":"2018-03-25T09:55:30Z","git_url":"git://github.com/prodex/yiiframework.com.git","ssh_url":"git@github.com:prodex/yiiframework.com.git","clone_url":"https://github.com/prodex/yiiframework.com.git","svn_url":"https://github.com/prodex/yiiframework.com","homepage":"http://yiiframework.domain-na.me/","size":75669,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft-contrib:master","ref":"master","sha":"b3f351e26902bd0fcc74385a4081c51f83561e14","user":{"login":"yiisoft-contrib","id":13801908,"avatar_url":"https://avatars2.githubusercontent.com/u/13801908?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft-contrib","html_url":"https://github.com/yiisoft-contrib","followers_url":"https://api.github.com/users/yiisoft-contrib/followers","following_url":"https://api.github.com/users/yiisoft-contrib/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft-contrib/subscriptions","organizations_url":"https://api.github.com/users/yiisoft-contrib/orgs","repos_url":"https://api.github.com/users/yiisoft-contrib/repos","events_url":"https://api.github.com/users/yiisoft-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":26328526,"name":"yiiframework.com","full_name":"yiisoft-contrib/yiiframework.com","owner":{"login":"yiisoft-contrib","id":13801908,"avatar_url":"https://avatars2.githubusercontent.com/u/13801908?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft-contrib","html_url":"https://github.com/yiisoft-contrib","followers_url":"https://api.github.com/users/yiisoft-contrib/followers","following_url":"https://api.github.com/users/yiisoft-contrib/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft-contrib/subscriptions","organizations_url":"https://api.github.com/users/yiisoft-contrib/orgs","repos_url":"https://api.github.com/users/yiisoft-contrib/repos","events_url":"https://api.github.com/users/yiisoft-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft-contrib/yiiframework.com","description":"Source code for official Yii website","fork":false,"url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com","forks_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/forks","keys_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/teams","hooks_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/hooks","issue_events_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/events","assignees_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/tags","blobs_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/languages","stargazers_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/stargazers","contributors_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/contributors","subscribers_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/subscribers","subscription_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/subscription","commits_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/merges","archive_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/downloads","issues_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/deployments","created_at":"2014-11-07T16:47:33Z","updated_at":"2018-03-25T02:45:42Z","pushed_at":"2018-03-25T09:56:53Z","git_url":"git://github.com/yiisoft-contrib/yiiframework.com.git","ssh_url":"git@github.com:yiisoft-contrib/yiiframework.com.git","clone_url":"https://github.com/yiisoft-contrib/yiiframework.com.git","svn_url":"https://github.com/yiisoft-contrib/yiiframework.com","homepage":"http://yiiframework.com/","size":75680,"stargazers_count":186,"watchers_count":186,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":66,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288"},"html":{"href":"https://github.com/yiisoft-contrib/yiiframework.com/pull/288"},"issue":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/288"},"comments":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft-contrib/yiiframework.com/statuses/dd0d29087d896e48727dd511a27b67fbeff41379"}},"author_association":"CONTRIBUTOR"}} | {
"id": 26328526,
"name": "yiisoft-contrib/yiiframework.com",
"url": "https://api.github.com/repos/yiisoft-contrib/yiiframework.com"
} | {
"id": 47294,
"login": "samdark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47294?",
"url": "https://api.github.com/users/samdark"
} | {
"id": 13801908,
"login": "yiisoft-contrib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13801908?",
"url": "https://api.github.com/orgs/yiisoft-contrib"
} | 2018-03-25T17:00:18 | 7431675515 | {"actor":{"display_login":"samdark"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/214680463","pull_request_review_id":151786373,"id":214680463,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDY4MDQ2Mw==","diff_hunk":"@@ -135,10 +135,34 @@ def __init__(self, smartplug):\n self.temperature = None\n self.current_consumption = None\n self.total_consumption = None\n+ self.available = False\n+ self._n_tried = 0\n+ self._last_tried = None\n \n def update(self):\n \"\"\"Get the latest data from the smart plug.\"\"\"\n- self.state = self.smartplug.state\n+ if self._last_tried is not None:","path":"homeassistant/components/switch/dlink.py","position":126,"original_position":126,"commit_id":"24be475aa90c9b6257e429ba64c6bebbb20aad50","original_commit_id":"24be475aa90c9b6257e429ba64c6bebbb20aad50","user":{"login":"Danielhiversen","id":650502,"node_id":"MDQ6VXNlcjY1MDUwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/650502?v=4","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},"body":"Thanks for the review.\r\nI do not think that Trottle is optimal here.\r\nSometimes the switch becomes unresponsible. If HA then tries to reconnect to often, it seems that the switch get stuck forever and would require a hard reset. \r\n\r\nSo I want to wait longer than the normal update frequency after a failure. ","created_at":"2018-09-03T12:52:26Z","updated_at":"2018-09-03T12:52:26Z","html_url":"https://github.com/home-assistant/home-assistant/pull/16346#discussion_r214680463","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/214680463"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/16346#discussion_r214680463"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346"}},"in_reply_to_id":214645698},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346","id":212540230,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTQwMjMw","html_url":"https://github.com/home-assistant/home-assistant/pull/16346","diff_url":"https://github.com/home-assistant/home-assistant/pull/16346.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/16346.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16346","number":16346,"state":"open","locked":false,"title":"Clean up dlink and some bug fix","user":{"login":"Danielhiversen","id":650502,"node_id":"MDQ6VXNlcjY1MDUwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/650502?v=4","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},"body":"## Description:\r\nClean up dlink and some bug fix\r\n\r\n\r\n* current_power_watt -> current_power_w\r\n* Add `available` property\r\n\r\n* When the connection to the device fail. Make sure we wait before retrying. Reducing the chance for this issue https://github.com/LinuxChristian/pyW215/issues/9\r\n\r\n## Checklist:\r\n - [x] The code change is tested and works locally.\r\n - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\ncc: @LinuxChristian","created_at":"2018-09-01T10:13:02Z","updated_at":"2018-09-03T12:52:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b9a1b155e505c3a921b45ab4e3282bfd6ee71f4","assignee":{"login":"Danielhiversen","id":650502,"node_id":"MDQ6VXNlcjY1MDUwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/650502?v=4","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false},"assignees":[{"login":"Danielhiversen","id":650502,"node_id":"MDQ6VXNlcjY1MDUwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/650502?v=4","gravatar_id":"","url":"https://api.github.com/users/Danielhiversen","html_url":"https://github.com/Danielhiversen","followers_url":"https://api.github.com/users/Danielhiversen/followers","following_url":"https://api.github.com/users/Danielhiversen/following{/other_user}","gists_url":"https://api.github.com/users/Danielhiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/Danielhiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danielhiversen/subscriptions","organizations_url":"https://api.github.com/users/Danielhiversen/orgs","repos_url":"https://api.github.com/users/Danielhiversen/repos","events_url":"https://api.github.com/users/Danielhiversen/events{/privacy}","received_events_url":"https://api.github.com/users/Danielhiversen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":536493965,"node_id":"MDU6TGFiZWw1MzY0OTM5NjU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20switch.dlink","name":"platform: switch.dlink","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16346/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/24be475aa90c9b6257e429ba64c6bebbb20aad50","head":{"label":"home-assistant:dlink","ref":"dlink","sha":"24be475aa90c9b6257e429ba64c6bebbb20aad50","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-09-03T12:17:32Z","pushed_at":"2018-09-03T12:17:09Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":87675,"stargazers_count":16431,"watchers_count":16431,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4842,"mirror_url":null,"archived":false,"open_issues_count":883,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4842,"open_issues":883,"watchers":16431,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"2c7d6ee6b538de16e0de4c93b0667faf4d934a33","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-09-03T12:17:32Z","pushed_at":"2018-09-03T12:17:09Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":87675,"stargazers_count":16431,"watchers_count":16431,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4842,"mirror_url":null,"archived":false,"open_issues_count":883,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4842,"open_issues":883,"watchers":16431,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/16346"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16346"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16346/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16346/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/24be475aa90c9b6257e429ba64c6bebbb20aad50"}},"author_association":"MEMBER"}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 650502,
"login": "Danielhiversen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/650502?",
"url": "https://api.github.com/users/Danielhiversen"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2018-09-03T12:52:26 | 8206232563 | {"actor":{"display_login":"Danielhiversen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/168082344","pull_request_review_id":96391063,"id":168082344,"diff_hunk":"@@ -460,21 +460,26 @@ class RequestDataValidator:\n Will return a 400 if no JSON provided or doesn't match schema.\n \"\"\"\n \n- def __init__(self, schema):\n+ def __init__(self, schema, allow_empty=False):\n \"\"\"Initialize the decorator.\"\"\"\n self._schema = schema\n+ self._allow_empty = allow_empty\n \n def __call__(self, method):\n \"\"\"Decorate a function.\"\"\"\n @asyncio.coroutine\n @wraps(method)\n def wrapper(view, request, *args, **kwargs):\n \"\"\"Wrap a request handler with data validation.\"\"\"\n+ data = None\n try:\n data = yield from request.json()\n except ValueError:\n- _LOGGER.error('Invalid JSON received.')\n- return view.json_message('Invalid JSON.', 400)\n+ if not self._allow_empty or \\\n+ (yield from request.content.read()) != b'':","path":"homeassistant/components/http/__init__.py","position":23,"original_position":23,"commit_id":"e494d3064d13986fbb8960ea5c52adfefc9f4971","original_commit_id":"86660a78003c88ad20aa66ab4fe4e38b42821672","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"I've opened a separate PR with this change and added tests. Will rebase htis PR after it is merged https://github.com/home-assistant/home-assistant/pull/12401","created_at":"2018-02-14T05:52:36Z","updated_at":"2018-02-14T05:52:36Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12079#discussion_r168082344","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/168082344"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12079#discussion_r168082344"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079"}},"in_reply_to_id":167835609},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079","id":166183567,"html_url":"https://github.com/home-assistant/home-assistant/pull/12079","diff_url":"https://github.com/home-assistant/home-assistant/pull/12079.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12079.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12079","number":12079,"state":"open","locked":false,"title":"Initial support for Config Entries","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"Video of this in action https://youtu.be/_qpKe-FW9Yk\r\n\r\n## Description:\r\nThis is the implementation of #11947. I've taken most comments into consideration.\r\n\r\nConfig entries are set up when component is set up. First `async_setup` is called, then `async_setup_entry` for each entry. For more information, see the documentation in the source code.\r\n\r\nFrontend PR https://github.com/home-assistant/home-assistant-polymer/pull/861\r\n\r\nHere is an architecture diagram of how it all works together: \r\n\r\n\r\n\r\n\r\nhttps://docs.google.com/drawings/d/10ESEPcVplCzcBg7_Ir4bpgka5YjVbtBRnsebetYkpxA/edit?usp=sharing\r\n\r\n\r\n\r\nTasks:\r\n - [x] Add a config manager\r\n - [x] Add config entry flow base class\r\n - [x] Load config entries on startup\r\n - [x] Expose config manager via API\r\n - [x] Frontend: show form based on config manager steps\r\n - [x] Support removing a config entry\r\n - [x] Add example component with config flow support\r\n - [x] Support for discovery\r\n\r\nFor Future PRs:\r\n - [ ] Translations\r\n - [ ] Migrations\r\n - [ ] Add support for removing config entries for platforms\r\n - [ ] Expose config entry ID on entity?\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Checklist:\r\n - [x] The code change is tested and works locally.\r\n\r\nIf the code does not interact with devices:\r\n - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n\r\nFixes #11947","created_at":"2018-01-31T07:23:34Z","updated_at":"2018-02-14T05:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddb567a22f582ccd52c241413dcd424b6f5f9e87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":451931292,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12079/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e494d3064d13986fbb8960ea5c52adfefc9f4971","head":{"label":"home-assistant:config-manager","ref":"config-manager","sha":"e494d3064d13986fbb8960ea5c52adfefc9f4971","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-14T03:21:02Z","pushed_at":"2018-02-14T05:52:12Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78853,"stargazers_count":12520,"watchers_count":12520,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3609,"mirror_url":null,"archived":false,"open_issues_count":829,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3609,"open_issues":829,"watchers":12520,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"2c202690d8db4e6ccdfaf09b5935e8d47057a778","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-14T03:21:02Z","pushed_at":"2018-02-14T05:52:12Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78853,"stargazers_count":12520,"watchers_count":12520,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3609,"mirror_url":null,"archived":false,"open_issues_count":829,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3609,"open_issues":829,"watchers":12520,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12079"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12079"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12079/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12079/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e494d3064d13986fbb8960ea5c52adfefc9f4971"}},"author_association":"OWNER"}} | {
"id": 12888993,
"name": "home-assistant/home-assistant",
"url": "https://api.github.com/repos/home-assistant/home-assistant"
} | {
"id": 1444314,
"login": "balloob",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1444314?",
"url": "https://api.github.com/users/balloob"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2018-02-14T05:52:36 | 7242136416 | {"actor":{"display_login":"balloob"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/comments/245478576","pull_request_review_id":189597593,"id":245478576,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ3ODU3Ng==","diff_hunk":"@@ -47,6 +47,21 @@ climate:\n operation_mode_comfort_address: '5/1/7'\n ```\n \n+`operation_mode_frost_protection_address` / `operation_mode_night_address` / `operation_mode_comfort_address` are not necessary if `operation_mode_address` is specified.\n+\n+If your device doesn't support setpoint_shift calculations (i.e. if you don't provide a `setpoint_shift_address` value) please set the `min_temp` and `max_temp`\n+attributes of the climate device to avoid issues with increasing the temperature in the frontend.\n+\n+The following values are valid for the `operation_modes` attribute:\n+\n+- Comfort","path":"source/_components/climate.knx.markdown","position":null,"original_position":11,"commit_id":"3a8df439b345acb5f4687e5bab1814c94be0c774","original_commit_id":"cc1ce37ea2e421c4cf4fffe6f22d0e98980e6ff8","user":{"login":"marvin-w","id":708887,"node_id":"MDQ6VXNlcjcwODg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/708887?v=4","gravatar_id":"","url":"https://api.github.com/users/marvin-w","html_url":"https://github.com/marvin-w","followers_url":"https://api.github.com/users/marvin-w/followers","following_url":"https://api.github.com/users/marvin-w/following{/other_user}","gists_url":"https://api.github.com/users/marvin-w/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin-w/subscriptions","organizations_url":"https://api.github.com/users/marvin-w/orgs","repos_url":"https://api.github.com/users/marvin-w/repos","events_url":"https://api.github.com/users/marvin-w/events{/privacy}","received_events_url":"https://api.github.com/users/marvin-w/received_events","type":"User","site_admin":false},"body":"I added the mapping.","created_at":"2019-01-05T13:57:06Z","updated_at":"2019-01-05T13:57:07Z","html_url":"https://github.com/home-assistant/home-assistant.io/pull/7937#discussion_r245478576","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/comments/245478576"},"html":{"href":"https://github.com/home-assistant/home-assistant.io/pull/7937#discussion_r245478576"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937"}},"in_reply_to_id":244537773},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937","id":240695317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjk1MzE3","html_url":"https://github.com/home-assistant/home-assistant.io/pull/7937","diff_url":"https://github.com/home-assistant/home-assistant.io/pull/7937.diff","patch_url":"https://github.com/home-assistant/home-assistant.io/pull/7937.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/7937","number":7937,"state":"open","locked":false,"title":"Updated docs of knx climate device","user":{"login":"marvin-w","id":708887,"node_id":"MDQ6VXNlcjcwODg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/708887?v=4","gravatar_id":"","url":"https://api.github.com/users/marvin-w","html_url":"https://github.com/marvin-w","followers_url":"https://api.github.com/users/marvin-w/followers","following_url":"https://api.github.com/users/marvin-w/following{/other_user}","gists_url":"https://api.github.com/users/marvin-w/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin-w/subscriptions","organizations_url":"https://api.github.com/users/marvin-w/orgs","repos_url":"https://api.github.com/users/marvin-w/repos","events_url":"https://api.github.com/users/marvin-w/events{/privacy}","received_events_url":"https://api.github.com/users/marvin-w/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\nUpdated docs for KNX climate devices.\r\n\r\n**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/home-assistant#19546\r\n\r\n## Checklist:\r\n\r\n- [x] Branch: `next` is for changes and new documentation that will go public with the next [home-assistant](https://github.com/home-assistant/home-assistant) release. Fixes, changes and adjustments for the current release should be created against `current`.\r\n- [x] The documentation follows the [standards][standards].\r\n\r\n[standards]: https://developers.home-assistant.io/docs/documentation_standards.html\r\n","created_at":"2018-12-23T18:36:58Z","updated_at":"2019-01-05T13:57:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12c6196106f53778654507330ce0826ea68d63c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":978446869,"node_id":"MDU6TGFiZWw5Nzg0NDY4Njk=","url":"https://api.github.com/repos/home-assistant/home-assistant.io/labels/has-parent","name":"has-parent","color":"0ab7d6","default":false},{"id":467102229,"node_id":"MDU6TGFiZWw0NjcxMDIyMjk=","url":"https://api.github.com/repos/home-assistant/home-assistant.io/labels/new-feature","name":"new-feature","color":"d4c5f9","default":false},{"id":978446546,"node_id":"MDU6TGFiZWw5Nzg0NDY1NDY=","url":"https://api.github.com/repos/home-assistant/home-assistant.io/labels/next","name":"next","color":"dffc9c","default":false},{"id":532489888,"node_id":"MDU6TGFiZWw1MzI0ODk4ODg=","url":"https://api.github.com/repos/home-assistant/home-assistant.io/labels/ready-for-review","name":"ready-for-review","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/7937/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant.io/statuses/3a8df439b345acb5f4687e5bab1814c94be0c774","head":{"label":"marvin-w:feature/added-docs-for-new-knx-version","ref":"feature/added-docs-for-new-knx-version","sha":"3a8df439b345acb5f4687e5bab1814c94be0c774","user":{"login":"marvin-w","id":708887,"node_id":"MDQ6VXNlcjcwODg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/708887?v=4","gravatar_id":"","url":"https://api.github.com/users/marvin-w","html_url":"https://github.com/marvin-w","followers_url":"https://api.github.com/users/marvin-w/followers","following_url":"https://api.github.com/users/marvin-w/following{/other_user}","gists_url":"https://api.github.com/users/marvin-w/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin-w/subscriptions","organizations_url":"https://api.github.com/users/marvin-w/orgs","repos_url":"https://api.github.com/users/marvin-w/repos","events_url":"https://api.github.com/users/marvin-w/events{/privacy}","received_events_url":"https://api.github.com/users/marvin-w/received_events","type":"User","site_admin":false},"repo":{"id":162352885,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzNTI4ODU=","name":"home-assistant.io","full_name":"marvin-w/home-assistant.io","private":false,"owner":{"login":"marvin-w","id":708887,"node_id":"MDQ6VXNlcjcwODg4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/708887?v=4","gravatar_id":"","url":"https://api.github.com/users/marvin-w","html_url":"https://github.com/marvin-w","followers_url":"https://api.github.com/users/marvin-w/followers","following_url":"https://api.github.com/users/marvin-w/following{/other_user}","gists_url":"https://api.github.com/users/marvin-w/gists{/gist_id}","starred_url":"https://api.github.com/users/marvin-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvin-w/subscriptions","organizations_url":"https://api.github.com/users/marvin-w/orgs","repos_url":"https://api.github.com/users/marvin-w/repos","events_url":"https://api.github.com/users/marvin-w/events{/privacy}","received_events_url":"https://api.github.com/users/marvin-w/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marvin-w/home-assistant.io","description":":blue_book: Home Assistant User documentation","fork":true,"url":"https://api.github.com/repos/marvin-w/home-assistant.io","forks_url":"https://api.github.com/repos/marvin-w/home-assistant.io/forks","keys_url":"https://api.github.com/repos/marvin-w/home-assistant.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marvin-w/home-assistant.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marvin-w/home-assistant.io/teams","hooks_url":"https://api.github.com/repos/marvin-w/home-assistant.io/hooks","issue_events_url":"https://api.github.com/repos/marvin-w/home-assistant.io/issues/events{/number}","events_url":"https://api.github.com/repos/marvin-w/home-assistant.io/events","assignees_url":"https://api.github.com/repos/marvin-w/home-assistant.io/assignees{/user}","branches_url":"https://api.github.com/repos/marvin-w/home-assistant.io/branches{/branch}","tags_url":"https://api.github.com/repos/marvin-w/home-assistant.io/tags","blobs_url":"https://api.github.com/repos/marvin-w/home-assistant.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marvin-w/home-assistant.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marvin-w/home-assistant.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/marvin-w/home-assistant.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marvin-w/home-assistant.io/statuses/{sha}","languages_url":"https://api.github.com/repos/marvin-w/home-assistant.io/languages","stargazers_url":"https://api.github.com/repos/marvin-w/home-assistant.io/stargazers","contributors_url":"https://api.github.com/repos/marvin-w/home-assistant.io/contributors","subscribers_url":"https://api.github.com/repos/marvin-w/home-assistant.io/subscribers","subscription_url":"https://api.github.com/repos/marvin-w/home-assistant.io/subscription","commits_url":"https://api.github.com/repos/marvin-w/home-assistant.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/marvin-w/home-assistant.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/marvin-w/home-assistant.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/marvin-w/home-assistant.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/marvin-w/home-assistant.io/contents/{+path}","compare_url":"https://api.github.com/repos/marvin-w/home-assistant.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marvin-w/home-assistant.io/merges","archive_url":"https://api.github.com/repos/marvin-w/home-assistant.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marvin-w/home-assistant.io/downloads","issues_url":"https://api.github.com/repos/marvin-w/home-assistant.io/issues{/number}","pulls_url":"https://api.github.com/repos/marvin-w/home-assistant.io/pulls{/number}","milestones_url":"https://api.github.com/repos/marvin-w/home-assistant.io/milestones{/number}","notifications_url":"https://api.github.com/repos/marvin-w/home-assistant.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marvin-w/home-assistant.io/labels{/name}","releases_url":"https://api.github.com/repos/marvin-w/home-assistant.io/releases{/id}","deployments_url":"https://api.github.com/repos/marvin-w/home-assistant.io/deployments","created_at":"2018-12-18T22:31:54Z","updated_at":"2018-12-23T18:12:42Z","pushed_at":"2019-01-05T13:56:30Z","git_url":"git://github.com/marvin-w/home-assistant.io.git","ssh_url":"git@github.com:marvin-w/home-assistant.io.git","clone_url":"https://github.com/marvin-w/home-assistant.io.git","svn_url":"https://github.com/marvin-w/home-assistant.io","homepage":"https://www.home-assistant.io","size":317869,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"home-assistant:next","ref":"next","sha":"250f8ec3c2f54b4c71d6abd792cd84e1f9ef55c7","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":28312955,"node_id":"MDEwOlJlcG9zaXRvcnkyODMxMjk1NQ==","name":"home-assistant.io","full_name":"home-assistant/home-assistant.io","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant.io","description":":blue_book: Home Assistant User documentation","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant.io","forks_url":"https://api.github.com/repos/home-assistant/home-assistant.io/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant.io/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant.io/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant.io/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant.io/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant.io/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant.io/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant.io/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant.io/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant.io/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant.io/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant.io/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant.io/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant.io/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant.io/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant.io/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant.io/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant.io/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant.io/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant.io/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant.io/deployments","created_at":"2014-12-21T20:59:21Z","updated_at":"2019-01-05T11:30:28Z","pushed_at":"2019-01-05T13:56:32Z","git_url":"git://github.com/home-assistant/home-assistant.io.git","ssh_url":"git@github.com:home-assistant/home-assistant.io.git","clone_url":"https://github.com/home-assistant/home-assistant.io.git","svn_url":"https://github.com/home-assistant/home-assistant.io","homepage":"https://www.home-assistant.io","size":318099,"stargazers_count":563,"watchers_count":563,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2717,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2717,"open_issues":121,"watchers":563,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937"},"html":{"href":"https://github.com/home-assistant/home-assistant.io/pull/7937"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/7937"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/issues/7937/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/pulls/7937/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant.io/statuses/3a8df439b345acb5f4687e5bab1814c94be0c774"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28312955,
"name": "home-assistant/home-assistant.io",
"url": "https://api.github.com/repos/home-assistant/home-assistant.io"
} | {
"id": 708887,
"login": "marvin-w",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/708887?",
"url": "https://api.github.com/users/marvin-w"
} | {
"id": 13844975,
"login": "home-assistant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13844975?",
"url": "https://api.github.com/orgs/home-assistant"
} | 2019-01-05T13:57:06 | 8838128629 | {"actor":{"display_login":"marvin-w"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments/177727074","pull_request_review_id":107650184,"id":177727074,"diff_hunk":"@@ -1,7 +1,10 @@\n import { connect } from 'react-redux';\n-import { doSearch } from 'redux/actions/search';\n-import { makeSelectSearchUris, selectIsSearching } from 'redux/selectors/search';\n-import { selectSearchDownloadUris } from 'redux/selectors/file_info';\n+import {\n+ doSearch,\n+ makeSelectSearchUris,\n+ selectIsSearching,\n+ selectSearchDownloadUris,\n+} from 'lbry-redux';","path":"src/renderer/component/fileListSearch/index.js","position":10,"original_position":10,"commit_id":"8a8d9951c5ed341554a49b2b070382239eeb7d5d","original_commit_id":"8a8d9951c5ed341554a49b2b070382239eeb7d5d","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: ['dispatch' is not defined. (no-undef)](https://app.codacy.com/app/LBRY/lbry-app/pullRequest?prid=1387823)","created_at":"2018-03-28T12:12:05Z","updated_at":"2018-03-28T12:12:05Z","html_url":"https://github.com/lbryio/lbry-app/pull/942#discussion_r177727074","pull_request_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/942","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments/177727074"},"html":{"href":"https://github.com/lbryio/lbry-app/pull/942#discussion_r177727074"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/942"}}},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry-app/pulls/942","id":162368757,"html_url":"https://github.com/lbryio/lbry-app/pull/942","diff_url":"https://github.com/lbryio/lbry-app/pull/942.diff","patch_url":"https://github.com/lbryio/lbry-app/pull/942.patch","issue_url":"https://api.github.com/repos/lbryio/lbry-app/issues/942","number":942,"state":"open","locked":false,"title":"Common components refactor","user":{"login":"akinwale","id":4160319,"avatar_url":"https://avatars0.githubusercontent.com/u/4160319?v=4","gravatar_id":"","url":"https://api.github.com/users/akinwale","html_url":"https://github.com/akinwale","followers_url":"https://api.github.com/users/akinwale/followers","following_url":"https://api.github.com/users/akinwale/following{/other_user}","gists_url":"https://api.github.com/users/akinwale/gists{/gist_id}","starred_url":"https://api.github.com/users/akinwale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akinwale/subscriptions","organizations_url":"https://api.github.com/users/akinwale/orgs","repos_url":"https://api.github.com/users/akinwale/repos","events_url":"https://api.github.com/users/akinwale/events{/privacy}","received_events_url":"https://api.github.com/users/akinwale/received_events","type":"User","site_admin":false},"body":"First steps towards refactoring common components that can be shared by both the desktop and mobile apps. The common component repository can be found at https://github.com/lbryio/lbry-redux\r\n\r\nNeed some input and / or feedback about the current approach to packaging and if anything needs to be modified or changed before I port more code.","created_at":"2018-01-11T12:22:52Z","updated_at":"2018-03-28T12:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75961d6ede9f045f1455d272e623ed69780ef6ff","assignee":{"login":"kauffj","id":530774,"avatar_url":"https://avatars0.githubusercontent.com/u/530774?v=4","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},"assignees":[{"login":"kauffj","id":530774,"avatar_url":"https://avatars0.githubusercontent.com/u/530774?v=4","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},{"login":"liamcardenas","id":5027235,"avatar_url":"https://avatars1.githubusercontent.com/u/5027235?v=4","gravatar_id":"","url":"https://api.github.com/users/liamcardenas","html_url":"https://github.com/liamcardenas","followers_url":"https://api.github.com/users/liamcardenas/followers","following_url":"https://api.github.com/users/liamcardenas/following{/other_user}","gists_url":"https://api.github.com/users/liamcardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/liamcardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamcardenas/subscriptions","organizations_url":"https://api.github.com/users/liamcardenas/orgs","repos_url":"https://api.github.com/users/liamcardenas/repos","events_url":"https://api.github.com/users/liamcardenas/events{/privacy}","received_events_url":"https://api.github.com/users/liamcardenas/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kauffj","id":530774,"avatar_url":"https://avatars0.githubusercontent.com/u/530774?v=4","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},{"login":"liamcardenas","id":5027235,"avatar_url":"https://avatars1.githubusercontent.com/u/5027235?v=4","gravatar_id":"","url":"https://api.github.com/users/liamcardenas","html_url":"https://github.com/liamcardenas","followers_url":"https://api.github.com/users/liamcardenas/followers","following_url":"https://api.github.com/users/liamcardenas/following{/other_user}","gists_url":"https://api.github.com/users/liamcardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/liamcardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamcardenas/subscriptions","organizations_url":"https://api.github.com/users/liamcardenas/orgs","repos_url":"https://api.github.com/users/liamcardenas/repos","events_url":"https://api.github.com/users/liamcardenas/events{/privacy}","received_events_url":"https://api.github.com/users/liamcardenas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/942/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/942/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry-app/issues/942/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry-app/statuses/8a8d9951c5ed341554a49b2b070382239eeb7d5d","head":{"label":"lbryio:common-components-refactor","ref":"common-components-refactor","sha":"8a8d9951c5ed341554a49b2b070382239eeb7d5d","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":79149882,"name":"lbry-app","full_name":"lbryio/lbry-app","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry-app","description":"A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.","fork":false,"url":"https://api.github.com/repos/lbryio/lbry-app","forks_url":"https://api.github.com/repos/lbryio/lbry-app/forks","keys_url":"https://api.github.com/repos/lbryio/lbry-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry-app/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry-app/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry-app/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry-app/events","assignees_url":"https://api.github.com/repos/lbryio/lbry-app/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry-app/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry-app/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry-app/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry-app/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry-app/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry-app/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry-app/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry-app/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry-app/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry-app/merges","archive_url":"https://api.github.com/repos/lbryio/lbry-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry-app/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry-app/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry-app/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry-app/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry-app/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry-app/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry-app/deployments","created_at":"2017-01-16T19:05:32Z","updated_at":"2018-03-28T01:16:24Z","pushed_at":"2018-03-28T12:07:16Z","git_url":"git://github.com/lbryio/lbry-app.git","ssh_url":"git@github.com:lbryio/lbry-app.git","clone_url":"https://github.com/lbryio/lbry-app.git","svn_url":"https://github.com/lbryio/lbry-app","homepage":"https://lbry.io","size":19580,"stargazers_count":333,"watchers_count":333,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":98,"open_issues":209,"watchers":333,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"e46a7548d416b7488b2d66669f57e247d9418943","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":79149882,"name":"lbry-app","full_name":"lbryio/lbry-app","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry-app","description":"A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.","fork":false,"url":"https://api.github.com/repos/lbryio/lbry-app","forks_url":"https://api.github.com/repos/lbryio/lbry-app/forks","keys_url":"https://api.github.com/repos/lbryio/lbry-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry-app/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry-app/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry-app/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry-app/events","assignees_url":"https://api.github.com/repos/lbryio/lbry-app/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry-app/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry-app/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry-app/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry-app/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry-app/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry-app/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry-app/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry-app/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry-app/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry-app/merges","archive_url":"https://api.github.com/repos/lbryio/lbry-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry-app/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry-app/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry-app/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry-app/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry-app/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry-app/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry-app/deployments","created_at":"2017-01-16T19:05:32Z","updated_at":"2018-03-28T01:16:24Z","pushed_at":"2018-03-28T12:07:16Z","git_url":"git://github.com/lbryio/lbry-app.git","ssh_url":"git@github.com:lbryio/lbry-app.git","clone_url":"https://github.com/lbryio/lbry-app.git","svn_url":"https://github.com/lbryio/lbry-app","homepage":"https://lbry.io","size":19580,"stargazers_count":333,"watchers_count":333,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":98,"open_issues":209,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/942"},"html":{"href":"https://github.com/lbryio/lbry-app/pull/942"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry-app/issues/942"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry-app/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry-app/statuses/8a8d9951c5ed341554a49b2b070382239eeb7d5d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 79149882,
"name": "lbryio/lbry-app",
"url": "https://api.github.com/repos/lbryio/lbry-app"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 13889222,
"login": "lbryio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13889222?",
"url": "https://api.github.com/orgs/lbryio"
} | 2018-03-28T12:12:05 | 7447335135 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/comments/166178171","pull_request_review_id":94216210,"id":166178171,"diff_hunk":"@@ -290,7 +290,7 @@ spelling-store-unknown-words=no\n [FORMAT]\n \n # Maximum number of characters on a single line.\n-max-line-length=100\n+max-line-length=120","path":".pylintrc","position":5,"original_position":5,"commit_id":"a15ae2c1083d999eaddbf774900530b134c56a17","original_commit_id":"a15ae2c1083d999eaddbf774900530b134c56a17","user":{"login":"eukreign","id":69960,"avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false},"body":"I've been thinking that maybe 120 is too much. In cases where you want to have two files side by side, even in PyCharm at slightly enlarged font (like mine), I can't comfortably fit two 120 lines side by side. 100 fits though... what do you think? Also, Python PEP8 suggests 100 as the max: https://www.python.org/dev/peps/pep-0008/#maximum-line-length","created_at":"2018-02-06T03:21:17Z","updated_at":"2018-02-06T03:28:20Z","html_url":"https://github.com/lbryio/lbry/pull/1025#discussion_r166178171","pull_request_url":"https://api.github.com/repos/lbryio/lbry/pulls/1025","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments/166178171"},"html":{"href":"https://github.com/lbryio/lbry/pull/1025#discussion_r166178171"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1025"}}},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/1025","id":157858267,"html_url":"https://github.com/lbryio/lbry/pull/1025","diff_url":"https://github.com/lbryio/lbry/pull/1025.diff","patch_url":"https://github.com/lbryio/lbry/pull/1025.patch","issue_url":"https://api.github.com/repos/lbryio/lbry/issues/1025","number":1025,"state":"open","locked":false,"title":"refactor databases","user":{"login":"jackrobison","id":11979920,"avatar_url":"https://avatars3.githubusercontent.com/u/11979920?v=4","gravatar_id":"","url":"https://api.github.com/users/jackrobison","html_url":"https://github.com/jackrobison","followers_url":"https://api.github.com/users/jackrobison/followers","following_url":"https://api.github.com/users/jackrobison/following{/other_user}","gists_url":"https://api.github.com/users/jackrobison/gists{/gist_id}","starred_url":"https://api.github.com/users/jackrobison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackrobison/subscriptions","organizations_url":"https://api.github.com/users/jackrobison/orgs","repos_url":"https://api.github.com/users/jackrobison/repos","events_url":"https://api.github.com/users/jackrobison/events{/privacy}","received_events_url":"https://api.github.com/users/jackrobison/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-12T15:28:35Z","updated_at":"2018-02-06T03:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c71f7d37709e3d6b9a5c5d7fabd19fbed4d73f6d","assignee":{"login":"jackrobison","id":11979920,"avatar_url":"https://avatars3.githubusercontent.com/u/11979920?v=4","gravatar_id":"","url":"https://api.github.com/users/jackrobison","html_url":"https://github.com/jackrobison","followers_url":"https://api.github.com/users/jackrobison/followers","following_url":"https://api.github.com/users/jackrobison/following{/other_user}","gists_url":"https://api.github.com/users/jackrobison/gists{/gist_id}","starred_url":"https://api.github.com/users/jackrobison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackrobison/subscriptions","organizations_url":"https://api.github.com/users/jackrobison/orgs","repos_url":"https://api.github.com/users/jackrobison/repos","events_url":"https://api.github.com/users/jackrobison/events{/privacy}","received_events_url":"https://api.github.com/users/jackrobison/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackrobison","id":11979920,"avatar_url":"https://avatars3.githubusercontent.com/u/11979920?v=4","gravatar_id":"","url":"https://api.github.com/users/jackrobison","html_url":"https://github.com/jackrobison","followers_url":"https://api.github.com/users/jackrobison/followers","following_url":"https://api.github.com/users/jackrobison/following{/other_user}","gists_url":"https://api.github.com/users/jackrobison/gists{/gist_id}","starred_url":"https://api.github.com/users/jackrobison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackrobison/subscriptions","organizations_url":"https://api.github.com/users/jackrobison/orgs","repos_url":"https://api.github.com/users/jackrobison/repos","events_url":"https://api.github.com/users/jackrobison/events{/privacy}","received_events_url":"https://api.github.com/users/jackrobison/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry/pulls/1025/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry/pulls/1025/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry/issues/1025/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/a15ae2c1083d999eaddbf774900530b134c56a17","head":{"label":"lbryio:database-refactor","ref":"database-refactor","sha":"a15ae2c1083d999eaddbf774900530b134c56a17","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":41103286,"name":"lbry","full_name":"lbryio/lbry","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry","description":"A fully decentralized network for distributing data","fork":false,"url":"https://api.github.com/repos/lbryio/lbry","forks_url":"https://api.github.com/repos/lbryio/lbry/forks","keys_url":"https://api.github.com/repos/lbryio/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry/events","assignees_url":"https://api.github.com/repos/lbryio/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry/merges","archive_url":"https://api.github.com/repos/lbryio/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry/deployments","created_at":"2015-08-20T15:24:10Z","updated_at":"2018-02-05T21:45:30Z","pushed_at":"2018-02-06T03:12:07Z","git_url":"git://github.com/lbryio/lbry.git","ssh_url":"git@github.com:lbryio/lbry.git","clone_url":"https://github.com/lbryio/lbry.git","svn_url":"https://github.com/lbryio/lbry","homepage":"https://lbry.io","size":7130,"stargazers_count":3679,"watchers_count":3679,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":208,"open_issues":143,"watchers":3679,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"1f68d29d73e22682cfff27a068fbb849cd685256","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":41103286,"name":"lbry","full_name":"lbryio/lbry","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry","description":"A fully decentralized network for distributing data","fork":false,"url":"https://api.github.com/repos/lbryio/lbry","forks_url":"https://api.github.com/repos/lbryio/lbry/forks","keys_url":"https://api.github.com/repos/lbryio/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry/events","assignees_url":"https://api.github.com/repos/lbryio/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry/merges","archive_url":"https://api.github.com/repos/lbryio/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry/deployments","created_at":"2015-08-20T15:24:10Z","updated_at":"2018-02-05T21:45:30Z","pushed_at":"2018-02-06T03:12:07Z","git_url":"git://github.com/lbryio/lbry.git","ssh_url":"git@github.com:lbryio/lbry.git","clone_url":"https://github.com/lbryio/lbry.git","svn_url":"https://github.com/lbryio/lbry","homepage":"https://lbry.io","size":7130,"stargazers_count":3679,"watchers_count":3679,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":208,"open_issues":143,"watchers":3679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1025"},"html":{"href":"https://github.com/lbryio/lbry/pull/1025"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1025"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1025/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1025/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1025/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry/statuses/a15ae2c1083d999eaddbf774900530b134c56a17"}},"author_association":"MEMBER"}} | {
"id": 41103286,
"name": "lbryio/lbry",
"url": "https://api.github.com/repos/lbryio/lbry"
} | {
"id": 69960,
"login": "eukreign",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69960?",
"url": "https://api.github.com/users/eukreign"
} | {
"id": 13889222,
"login": "lbryio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13889222?",
"url": "https://api.github.com/orgs/lbryio"
} | 2018-02-06T03:21:17 | 7202363147 | {"actor":{"display_login":"eukreign"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments/172310898","pull_request_review_id":101306486,"id":172310898,"diff_hunk":"@@ -15,13 +15,37 @@ reducers[ACTIONS.FETCH_FEATURED_CONTENT_STARTED] = state =>\n reducers[ACTIONS.FETCH_FEATURED_CONTENT_COMPLETED] = (state, action) => {\n const { uris, success } = action.data;\n \n+ console.log(\"FETCH_FEATURED_CONTENT_COMPLETED\");","path":"src/renderer/redux/reducers/content.js","position":4,"original_position":4,"commit_id":"cc0bf4144e4853cacdec1735595e2db6ae25b44d","original_commit_id":"cc0bf4144e4853cacdec1735595e2db6ae25b44d","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Unexpected console statement. (no-console)](https://app.codacy.com/app/LBRY/lbry-app/pullRequest?prid=1397827)","created_at":"2018-03-05T20:00:57Z","updated_at":"2018-03-05T20:00:58Z","html_url":"https://github.com/lbryio/lbry-app/pull/1064#discussion_r172310898","pull_request_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments/172310898"},"html":{"href":"https://github.com/lbryio/lbry-app/pull/1064#discussion_r172310898"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064","id":172960476,"html_url":"https://github.com/lbryio/lbry-app/pull/1064","diff_url":"https://github.com/lbryio/lbry-app/pull/1064.diff","patch_url":"https://github.com/lbryio/lbry-app/pull/1064.patch","issue_url":"https://api.github.com/repos/lbryio/lbry-app/issues/1064","number":1064,"state":"open","locked":false,"title":"fetch featured channels","user":{"login":"daovist","id":34498824,"avatar_url":"https://avatars2.githubusercontent.com/u/34498824?v=4","gravatar_id":"","url":"https://api.github.com/users/daovist","html_url":"https://github.com/daovist","followers_url":"https://api.github.com/users/daovist/followers","following_url":"https://api.github.com/users/daovist/following{/other_user}","gists_url":"https://api.github.com/users/daovist/gists{/gist_id}","starred_url":"https://api.github.com/users/daovist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daovist/subscriptions","organizations_url":"https://api.github.com/users/daovist/orgs","repos_url":"https://api.github.com/users/daovist/repos","events_url":"https://api.github.com/users/daovist/events{/privacy}","received_events_url":"https://api.github.com/users/daovist/received_events","type":"User","site_admin":false},"body":"fetches data for featured channels and puts it into store.content.featuredUris\r\n\r\nwork in progress, channels are not displaying yet...","created_at":"2018-03-05T19:18:59Z","updated_at":"2018-03-05T20:00:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85bd53bb81ca95051f70bdd7df0bd3a6182b608c","assignee":{"login":"liamcardenas","id":5027235,"avatar_url":"https://avatars1.githubusercontent.com/u/5027235?v=4","gravatar_id":"","url":"https://api.github.com/users/liamcardenas","html_url":"https://github.com/liamcardenas","followers_url":"https://api.github.com/users/liamcardenas/followers","following_url":"https://api.github.com/users/liamcardenas/following{/other_user}","gists_url":"https://api.github.com/users/liamcardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/liamcardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamcardenas/subscriptions","organizations_url":"https://api.github.com/users/liamcardenas/orgs","repos_url":"https://api.github.com/users/liamcardenas/repos","events_url":"https://api.github.com/users/liamcardenas/events{/privacy}","received_events_url":"https://api.github.com/users/liamcardenas/received_events","type":"User","site_admin":false},"assignees":[{"login":"liamcardenas","id":5027235,"avatar_url":"https://avatars1.githubusercontent.com/u/5027235?v=4","gravatar_id":"","url":"https://api.github.com/users/liamcardenas","html_url":"https://github.com/liamcardenas","followers_url":"https://api.github.com/users/liamcardenas/followers","following_url":"https://api.github.com/users/liamcardenas/following{/other_user}","gists_url":"https://api.github.com/users/liamcardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/liamcardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamcardenas/subscriptions","organizations_url":"https://api.github.com/users/liamcardenas/orgs","repos_url":"https://api.github.com/users/liamcardenas/repos","events_url":"https://api.github.com/users/liamcardenas/events{/privacy}","received_events_url":"https://api.github.com/users/liamcardenas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry-app/issues/1064/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry-app/statuses/cc0bf4144e4853cacdec1735595e2db6ae25b44d","head":{"label":"daovist:featured-channels","ref":"featured-channels","sha":"cc0bf4144e4853cacdec1735595e2db6ae25b44d","user":{"login":"daovist","id":34498824,"avatar_url":"https://avatars2.githubusercontent.com/u/34498824?v=4","gravatar_id":"","url":"https://api.github.com/users/daovist","html_url":"https://github.com/daovist","followers_url":"https://api.github.com/users/daovist/followers","following_url":"https://api.github.com/users/daovist/following{/other_user}","gists_url":"https://api.github.com/users/daovist/gists{/gist_id}","starred_url":"https://api.github.com/users/daovist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daovist/subscriptions","organizations_url":"https://api.github.com/users/daovist/orgs","repos_url":"https://api.github.com/users/daovist/repos","events_url":"https://api.github.com/users/daovist/events{/privacy}","received_events_url":"https://api.github.com/users/daovist/received_events","type":"User","site_admin":false},"repo":{"id":114157588,"name":"lbry-app","full_name":"daovist/lbry-app","owner":{"login":"daovist","id":34498824,"avatar_url":"https://avatars2.githubusercontent.com/u/34498824?v=4","gravatar_id":"","url":"https://api.github.com/users/daovist","html_url":"https://github.com/daovist","followers_url":"https://api.github.com/users/daovist/followers","following_url":"https://api.github.com/users/daovist/following{/other_user}","gists_url":"https://api.github.com/users/daovist/gists{/gist_id}","starred_url":"https://api.github.com/users/daovist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daovist/subscriptions","organizations_url":"https://api.github.com/users/daovist/orgs","repos_url":"https://api.github.com/users/daovist/repos","events_url":"https://api.github.com/users/daovist/events{/privacy}","received_events_url":"https://api.github.com/users/daovist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daovist/lbry-app","description":"A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.","fork":true,"url":"https://api.github.com/repos/daovist/lbry-app","forks_url":"https://api.github.com/repos/daovist/lbry-app/forks","keys_url":"https://api.github.com/repos/daovist/lbry-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daovist/lbry-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daovist/lbry-app/teams","hooks_url":"https://api.github.com/repos/daovist/lbry-app/hooks","issue_events_url":"https://api.github.com/repos/daovist/lbry-app/issues/events{/number}","events_url":"https://api.github.com/repos/daovist/lbry-app/events","assignees_url":"https://api.github.com/repos/daovist/lbry-app/assignees{/user}","branches_url":"https://api.github.com/repos/daovist/lbry-app/branches{/branch}","tags_url":"https://api.github.com/repos/daovist/lbry-app/tags","blobs_url":"https://api.github.com/repos/daovist/lbry-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daovist/lbry-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daovist/lbry-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/daovist/lbry-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daovist/lbry-app/statuses/{sha}","languages_url":"https://api.github.com/repos/daovist/lbry-app/languages","stargazers_url":"https://api.github.com/repos/daovist/lbry-app/stargazers","contributors_url":"https://api.github.com/repos/daovist/lbry-app/contributors","subscribers_url":"https://api.github.com/repos/daovist/lbry-app/subscribers","subscription_url":"https://api.github.com/repos/daovist/lbry-app/subscription","commits_url":"https://api.github.com/repos/daovist/lbry-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/daovist/lbry-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/daovist/lbry-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/daovist/lbry-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/daovist/lbry-app/contents/{+path}","compare_url":"https://api.github.com/repos/daovist/lbry-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daovist/lbry-app/merges","archive_url":"https://api.github.com/repos/daovist/lbry-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daovist/lbry-app/downloads","issues_url":"https://api.github.com/repos/daovist/lbry-app/issues{/number}","pulls_url":"https://api.github.com/repos/daovist/lbry-app/pulls{/number}","milestones_url":"https://api.github.com/repos/daovist/lbry-app/milestones{/number}","notifications_url":"https://api.github.com/repos/daovist/lbry-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daovist/lbry-app/labels{/name}","releases_url":"https://api.github.com/repos/daovist/lbry-app/releases{/id}","deployments_url":"https://api.github.com/repos/daovist/lbry-app/deployments","created_at":"2017-12-13T18:55:51Z","updated_at":"2017-12-29T20:23:18Z","pushed_at":"2018-03-05T19:57:58Z","git_url":"git://github.com/daovist/lbry-app.git","ssh_url":"git@github.com:daovist/lbry-app.git","clone_url":"https://github.com/daovist/lbry-app.git","svn_url":"https://github.com/daovist/lbry-app","homepage":"https://lbry.io","size":18288,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"539dea931ad49f51718c73b4193c98e28e2a025f","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":79149882,"name":"lbry-app","full_name":"lbryio/lbry-app","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry-app","description":"A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.","fork":false,"url":"https://api.github.com/repos/lbryio/lbry-app","forks_url":"https://api.github.com/repos/lbryio/lbry-app/forks","keys_url":"https://api.github.com/repos/lbryio/lbry-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry-app/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry-app/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry-app/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry-app/events","assignees_url":"https://api.github.com/repos/lbryio/lbry-app/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry-app/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry-app/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry-app/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry-app/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry-app/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry-app/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry-app/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry-app/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry-app/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry-app/merges","archive_url":"https://api.github.com/repos/lbryio/lbry-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry-app/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry-app/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry-app/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry-app/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry-app/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry-app/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry-app/deployments","created_at":"2017-01-16T19:05:32Z","updated_at":"2018-03-05T19:53:27Z","pushed_at":"2018-03-05T19:58:00Z","git_url":"git://github.com/lbryio/lbry-app.git","ssh_url":"git@github.com:lbryio/lbry-app.git","clone_url":"https://github.com/lbryio/lbry-app.git","svn_url":"https://github.com/lbryio/lbry-app","homepage":"https://lbry.io","size":18734,"stargazers_count":327,"watchers_count":327,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":98,"open_issues":194,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064"},"html":{"href":"https://github.com/lbryio/lbry-app/pull/1064"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry-app/issues/1064"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry-app/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry-app/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry-app/statuses/cc0bf4144e4853cacdec1735595e2db6ae25b44d"}},"author_association":"COLLABORATOR"}} | {
"id": 79149882,
"name": "lbryio/lbry-app",
"url": "https://api.github.com/repos/lbryio/lbry-app"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 13889222,
"login": "lbryio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13889222?",
"url": "https://api.github.com/orgs/lbryio"
} | 2018-03-05T20:00:57 | 7333626683 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments/197313324","pull_request_review_id":131035803,"id":197313324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzMxMzMyNA==","diff_hunk":"@@ -157,6 +157,12 @@ block content\n data-deactivate-dispute\n )\n svg.-pen.block.align-top(width='14' height='18'): use(xlink:href='#svg-ban-circle')\n+ else\n+ tr\n+ td(colspan=6 class=\"text-center\")\n+ | No Results","path":"views/admin/disputes/index.pug","position":24,"original_position":24,"commit_id":"b8ed11f04e85a7e2f3f0957a8acf0e3aa6fbe1ea","original_commit_id":"b8ed11f04e85a7e2f3f0957a8acf0e3aa6fbe1ea","user":{"login":"marcondag","id":24264157,"node_id":"MDQ6VXNlcjI0MjY0MTU3","avatar_url":"https://avatars3.githubusercontent.com/u/24264157?v=4","gravatar_id":"","url":"https://api.github.com/users/marcondag","html_url":"https://github.com/marcondag","followers_url":"https://api.github.com/users/marcondag/followers","following_url":"https://api.github.com/users/marcondag/following{/other_user}","gists_url":"https://api.github.com/users/marcondag/gists{/gist_id}","starred_url":"https://api.github.com/users/marcondag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcondag/subscriptions","organizations_url":"https://api.github.com/users/marcondag/orgs","repos_url":"https://api.github.com/users/marcondag/repos","events_url":"https://api.github.com/users/marcondag/events{/privacy}","received_events_url":"https://api.github.com/users/marcondag/received_events","type":"User","site_admin":false},"body":":+1:\r\n","created_at":"2018-06-22T00:31:40Z","updated_at":"2018-06-22T00:31:40Z","html_url":"https://github.com/debtcollective/dispute-tools/pull/44#discussion_r197313324","pull_request_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments/197313324"},"html":{"href":"https://github.com/debtcollective/dispute-tools/pull/44#discussion_r197313324"},"pull_request":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44","id":196607662,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjA3NjYy","html_url":"https://github.com/debtcollective/dispute-tools/pull/44","diff_url":"https://github.com/debtcollective/dispute-tools/pull/44.diff","patch_url":"https://github.com/debtcollective/dispute-tools/pull/44.patch","issue_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/44","number":44,"state":"open","locked":false,"title":"Small css fixes","user":{"login":"orlando","id":849872,"node_id":"MDQ6VXNlcjg0OTg3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/849872?v=4","gravatar_id":"","url":"https://api.github.com/users/orlando","html_url":"https://github.com/orlando","followers_url":"https://api.github.com/users/orlando/followers","following_url":"https://api.github.com/users/orlando/following{/other_user}","gists_url":"https://api.github.com/users/orlando/gists{/gist_id}","starred_url":"https://api.github.com/users/orlando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlando/subscriptions","organizations_url":"https://api.github.com/users/orlando/orgs","repos_url":"https://api.github.com/users/orlando/repos","events_url":"https://api.github.com/users/orlando/events{/privacy}","received_events_url":"https://api.github.com/users/orlando/received_events","type":"User","site_admin":false},"body":"This PR fixes issues with css/html in the tools\r\n\r\nCloses https://github.com/debtcollective/parent/issues/166\r\n\r\n# Media\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-06-22T00:08:42Z","updated_at":"2018-06-22T00:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99c34d0ca608cbbc2808bc3988d821ad958efc7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44/commits","review_comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44/comments","review_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/44/comments","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/b8ed11f04e85a7e2f3f0957a8acf0e3aa6fbe1ea","head":{"label":"debtcollective:od/fixes","ref":"od/fixes","sha":"b8ed11f04e85a7e2f3f0957a8acf0e3aa6fbe1ea","user":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":122767402,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3Njc0MDI=","name":"dispute-tools","full_name":"debtcollective/dispute-tools","owner":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/debtcollective/dispute-tools","description":"The Debt Collective dispute tools service","fork":false,"url":"https://api.github.com/repos/debtcollective/dispute-tools","forks_url":"https://api.github.com/repos/debtcollective/dispute-tools/forks","keys_url":"https://api.github.com/repos/debtcollective/dispute-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debtcollective/dispute-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debtcollective/dispute-tools/teams","hooks_url":"https://api.github.com/repos/debtcollective/dispute-tools/hooks","issue_events_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/events{/number}","events_url":"https://api.github.com/repos/debtcollective/dispute-tools/events","assignees_url":"https://api.github.com/repos/debtcollective/dispute-tools/assignees{/user}","branches_url":"https://api.github.com/repos/debtcollective/dispute-tools/branches{/branch}","tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/tags","blobs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/debtcollective/dispute-tools/languages","stargazers_url":"https://api.github.com/repos/debtcollective/dispute-tools/stargazers","contributors_url":"https://api.github.com/repos/debtcollective/dispute-tools/contributors","subscribers_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscribers","subscription_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscription","commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/debtcollective/dispute-tools/contents/{+path}","compare_url":"https://api.github.com/repos/debtcollective/dispute-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debtcollective/dispute-tools/merges","archive_url":"https://api.github.com/repos/debtcollective/dispute-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debtcollective/dispute-tools/downloads","issues_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues{/number}","pulls_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/debtcollective/dispute-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/debtcollective/dispute-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debtcollective/dispute-tools/labels{/name}","releases_url":"https://api.github.com/repos/debtcollective/dispute-tools/releases{/id}","deployments_url":"https://api.github.com/repos/debtcollective/dispute-tools/deployments","created_at":"2018-02-24T18:27:05Z","updated_at":"2018-06-21T18:36:23Z","pushed_at":"2018-06-22T00:08:43Z","git_url":"git://github.com/debtcollective/dispute-tools.git","ssh_url":"git@github.com:debtcollective/dispute-tools.git","clone_url":"https://github.com/debtcollective/dispute-tools.git","svn_url":"https://github.com/debtcollective/dispute-tools","homepage":null,"size":20796,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"development"}},"base":{"label":"debtcollective:development","ref":"development","sha":"3fd00526ceb66be5098dccbb4534fe522e57556e","user":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":122767402,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3Njc0MDI=","name":"dispute-tools","full_name":"debtcollective/dispute-tools","owner":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/debtcollective/dispute-tools","description":"The Debt Collective dispute tools service","fork":false,"url":"https://api.github.com/repos/debtcollective/dispute-tools","forks_url":"https://api.github.com/repos/debtcollective/dispute-tools/forks","keys_url":"https://api.github.com/repos/debtcollective/dispute-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debtcollective/dispute-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debtcollective/dispute-tools/teams","hooks_url":"https://api.github.com/repos/debtcollective/dispute-tools/hooks","issue_events_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/events{/number}","events_url":"https://api.github.com/repos/debtcollective/dispute-tools/events","assignees_url":"https://api.github.com/repos/debtcollective/dispute-tools/assignees{/user}","branches_url":"https://api.github.com/repos/debtcollective/dispute-tools/branches{/branch}","tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/tags","blobs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/debtcollective/dispute-tools/languages","stargazers_url":"https://api.github.com/repos/debtcollective/dispute-tools/stargazers","contributors_url":"https://api.github.com/repos/debtcollective/dispute-tools/contributors","subscribers_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscribers","subscription_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscription","commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/debtcollective/dispute-tools/contents/{+path}","compare_url":"https://api.github.com/repos/debtcollective/dispute-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debtcollective/dispute-tools/merges","archive_url":"https://api.github.com/repos/debtcollective/dispute-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debtcollective/dispute-tools/downloads","issues_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues{/number}","pulls_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/debtcollective/dispute-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/debtcollective/dispute-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debtcollective/dispute-tools/labels{/name}","releases_url":"https://api.github.com/repos/debtcollective/dispute-tools/releases{/id}","deployments_url":"https://api.github.com/repos/debtcollective/dispute-tools/deployments","created_at":"2018-02-24T18:27:05Z","updated_at":"2018-06-21T18:36:23Z","pushed_at":"2018-06-22T00:08:43Z","git_url":"git://github.com/debtcollective/dispute-tools.git","ssh_url":"git@github.com:debtcollective/dispute-tools.git","clone_url":"https://github.com/debtcollective/dispute-tools.git","svn_url":"https://github.com/debtcollective/dispute-tools","homepage":null,"size":20796,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44"},"html":{"href":"https://github.com/debtcollective/dispute-tools/pull/44"},"issue":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/issues/44"},"comments":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/b8ed11f04e85a7e2f3f0957a8acf0e3aa6fbe1ea"}},"author_association":"CONTRIBUTOR"}} | {
"id": 122767402,
"name": "debtcollective/dispute-tools",
"url": "https://api.github.com/repos/debtcollective/dispute-tools"
} | {
"id": 24264157,
"login": "marcondag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24264157?",
"url": "https://api.github.com/users/marcondag"
} | {
"id": 13947390,
"login": "debtcollective",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13947390?",
"url": "https://api.github.com/orgs/debtcollective"
} | 2018-06-22T00:31:40 | 7861448231 | {"actor":{"display_login":"marcondag"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments/217892024","pull_request_review_id":155721401,"id":217892024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg5MjAyNA==","diff_hunk":"@@ -0,0 +1,76 @@\n+/* globals Class, BaseController, User, UserMailer */\n+const Raven = require('raven');","path":"controllers/SessionsController.js","position":2,"original_position":2,"commit_id":"618e2e983f6b9bfdc00c625bfd662ec7fd2d530c","original_commit_id":"618e2e983f6b9bfdc00c625bfd662ec7fd2d530c","user":{"login":"marcondag","id":24264157,"node_id":"MDQ6VXNlcjI0MjY0MTU3","avatar_url":"https://avatars3.githubusercontent.com/u/24264157?v=4","gravatar_id":"","url":"https://api.github.com/users/marcondag","html_url":"https://github.com/marcondag","followers_url":"https://api.github.com/users/marcondag/followers","following_url":"https://api.github.com/users/marcondag/following{/other_user}","gists_url":"https://api.github.com/users/marcondag/gists{/gist_id}","starred_url":"https://api.github.com/users/marcondag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcondag/subscriptions","organizations_url":"https://api.github.com/users/marcondag/orgs","repos_url":"https://api.github.com/users/marcondag/repos","events_url":"https://api.github.com/users/marcondag/events{/privacy}","received_events_url":"https://api.github.com/users/marcondag/received_events","type":"User","site_admin":false},"body":"We should import Raven from `$lib`","created_at":"2018-09-15T18:27:58Z","updated_at":"2018-09-15T18:52:44Z","html_url":"https://github.com/debtcollective/dispute-tools/pull/61#discussion_r217892024","pull_request_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments/217892024"},"html":{"href":"https://github.com/debtcollective/dispute-tools/pull/61#discussion_r217892024"},"pull_request":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61","id":215747780,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzQ3Nzgw","html_url":"https://github.com/debtcollective/dispute-tools/pull/61","diff_url":"https://github.com/debtcollective/dispute-tools/pull/61.diff","patch_url":"https://github.com/debtcollective/dispute-tools/pull/61.patch","issue_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/61","number":61,"state":"open","locked":false,"title":"sessions decoupling from discourse","user":{"login":"orlando","id":849872,"node_id":"MDQ6VXNlcjg0OTg3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/849872?v=4","gravatar_id":"","url":"https://api.github.com/users/orlando","html_url":"https://github.com/orlando","followers_url":"https://api.github.com/users/orlando/followers","following_url":"https://api.github.com/users/orlando/following{/other_user}","gists_url":"https://api.github.com/users/orlando/gists{/gist_id}","starred_url":"https://api.github.com/users/orlando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlando/subscriptions","organizations_url":"https://api.github.com/users/orlando/orgs","repos_url":"https://api.github.com/users/orlando/repos","events_url":"https://api.github.com/users/orlando/events{/privacy}","received_events_url":"https://api.github.com/users/orlando/received_events","type":"User","site_admin":false},"body":"This PR refactors authentication. The goal is to reduce API calls to Discourse and decouple the app a bit from it.\r\n\r\nI tried to keep this PR just to remove the sessions, but I changed some parts of the app to remove unnecessary calls to Discourse.\r\n\r\nHere I list the changes https://gist.github.com/orlando/64b924034b3a649a80bd44badd811777, I didn't include specific implementation since it was more of adapting what we have to use Passport. The passport integration with Discourse SSO was done in `lib/passport` folder.\r\n\r\nMost of the problems I had was with testing, I removed some logging in order to make failures more readable. Also, we are hiding too much of the implementation of these tests, which make them hard to debug.\r\n\r\nFixes https://github.com/debtcollective/parent/issues/190, https://github.com/debtcollective/parent/issues/167, https://github.com/debtcollective/parent/issues/191","created_at":"2018-09-15T03:48:11Z","updated_at":"2018-09-15T18:52:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e44b418235b09923689920d6bf92ebb85cbce6aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shoshber","id":1402948,"node_id":"MDQ6VXNlcjE0MDI5NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1402948?v=4","gravatar_id":"","url":"https://api.github.com/users/shoshber","html_url":"https://github.com/shoshber","followers_url":"https://api.github.com/users/shoshber/followers","following_url":"https://api.github.com/users/shoshber/following{/other_user}","gists_url":"https://api.github.com/users/shoshber/gists{/gist_id}","starred_url":"https://api.github.com/users/shoshber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoshber/subscriptions","organizations_url":"https://api.github.com/users/shoshber/orgs","repos_url":"https://api.github.com/users/shoshber/repos","events_url":"https://api.github.com/users/shoshber/events{/privacy}","received_events_url":"https://api.github.com/users/shoshber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61/commits","review_comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61/comments","review_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/61/comments","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/618e2e983f6b9bfdc00c625bfd662ec7fd2d530c","head":{"label":"debtcollective:od/sessions","ref":"od/sessions","sha":"618e2e983f6b9bfdc00c625bfd662ec7fd2d530c","user":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":122767402,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3Njc0MDI=","name":"dispute-tools","full_name":"debtcollective/dispute-tools","private":false,"owner":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/debtcollective/dispute-tools","description":"The Debt Collective dispute tools service","fork":false,"url":"https://api.github.com/repos/debtcollective/dispute-tools","forks_url":"https://api.github.com/repos/debtcollective/dispute-tools/forks","keys_url":"https://api.github.com/repos/debtcollective/dispute-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debtcollective/dispute-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debtcollective/dispute-tools/teams","hooks_url":"https://api.github.com/repos/debtcollective/dispute-tools/hooks","issue_events_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/events{/number}","events_url":"https://api.github.com/repos/debtcollective/dispute-tools/events","assignees_url":"https://api.github.com/repos/debtcollective/dispute-tools/assignees{/user}","branches_url":"https://api.github.com/repos/debtcollective/dispute-tools/branches{/branch}","tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/tags","blobs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/debtcollective/dispute-tools/languages","stargazers_url":"https://api.github.com/repos/debtcollective/dispute-tools/stargazers","contributors_url":"https://api.github.com/repos/debtcollective/dispute-tools/contributors","subscribers_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscribers","subscription_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscription","commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/debtcollective/dispute-tools/contents/{+path}","compare_url":"https://api.github.com/repos/debtcollective/dispute-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debtcollective/dispute-tools/merges","archive_url":"https://api.github.com/repos/debtcollective/dispute-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debtcollective/dispute-tools/downloads","issues_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues{/number}","pulls_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/debtcollective/dispute-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/debtcollective/dispute-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debtcollective/dispute-tools/labels{/name}","releases_url":"https://api.github.com/repos/debtcollective/dispute-tools/releases{/id}","deployments_url":"https://api.github.com/repos/debtcollective/dispute-tools/deployments","created_at":"2018-02-24T18:27:05Z","updated_at":"2018-09-05T18:53:47Z","pushed_at":"2018-09-15T18:23:23Z","git_url":"git://github.com/debtcollective/dispute-tools.git","ssh_url":"git@github.com:debtcollective/dispute-tools.git","clone_url":"https://github.com/debtcollective/dispute-tools.git","svn_url":"https://github.com/debtcollective/dispute-tools","homepage":null,"size":20841,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"development"}},"base":{"label":"debtcollective:development","ref":"development","sha":"148f74d163cbb923110b72bf0062faf3a4a49bd4","user":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":122767402,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3Njc0MDI=","name":"dispute-tools","full_name":"debtcollective/dispute-tools","private":false,"owner":{"login":"debtcollective","id":13947390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQ3Mzkw","avatar_url":"https://avatars0.githubusercontent.com/u/13947390?v=4","gravatar_id":"","url":"https://api.github.com/users/debtcollective","html_url":"https://github.com/debtcollective","followers_url":"https://api.github.com/users/debtcollective/followers","following_url":"https://api.github.com/users/debtcollective/following{/other_user}","gists_url":"https://api.github.com/users/debtcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/debtcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debtcollective/subscriptions","organizations_url":"https://api.github.com/users/debtcollective/orgs","repos_url":"https://api.github.com/users/debtcollective/repos","events_url":"https://api.github.com/users/debtcollective/events{/privacy}","received_events_url":"https://api.github.com/users/debtcollective/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/debtcollective/dispute-tools","description":"The Debt Collective dispute tools service","fork":false,"url":"https://api.github.com/repos/debtcollective/dispute-tools","forks_url":"https://api.github.com/repos/debtcollective/dispute-tools/forks","keys_url":"https://api.github.com/repos/debtcollective/dispute-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debtcollective/dispute-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debtcollective/dispute-tools/teams","hooks_url":"https://api.github.com/repos/debtcollective/dispute-tools/hooks","issue_events_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/events{/number}","events_url":"https://api.github.com/repos/debtcollective/dispute-tools/events","assignees_url":"https://api.github.com/repos/debtcollective/dispute-tools/assignees{/user}","branches_url":"https://api.github.com/repos/debtcollective/dispute-tools/branches{/branch}","tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/tags","blobs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/debtcollective/dispute-tools/languages","stargazers_url":"https://api.github.com/repos/debtcollective/dispute-tools/stargazers","contributors_url":"https://api.github.com/repos/debtcollective/dispute-tools/contributors","subscribers_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscribers","subscription_url":"https://api.github.com/repos/debtcollective/dispute-tools/subscription","commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/debtcollective/dispute-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/debtcollective/dispute-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/debtcollective/dispute-tools/contents/{+path}","compare_url":"https://api.github.com/repos/debtcollective/dispute-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debtcollective/dispute-tools/merges","archive_url":"https://api.github.com/repos/debtcollective/dispute-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debtcollective/dispute-tools/downloads","issues_url":"https://api.github.com/repos/debtcollective/dispute-tools/issues{/number}","pulls_url":"https://api.github.com/repos/debtcollective/dispute-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/debtcollective/dispute-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/debtcollective/dispute-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debtcollective/dispute-tools/labels{/name}","releases_url":"https://api.github.com/repos/debtcollective/dispute-tools/releases{/id}","deployments_url":"https://api.github.com/repos/debtcollective/dispute-tools/deployments","created_at":"2018-02-24T18:27:05Z","updated_at":"2018-09-05T18:53:47Z","pushed_at":"2018-09-15T18:23:23Z","git_url":"git://github.com/debtcollective/dispute-tools.git","ssh_url":"git@github.com:debtcollective/dispute-tools.git","clone_url":"https://github.com/debtcollective/dispute-tools.git","svn_url":"https://github.com/debtcollective/dispute-tools","homepage":null,"size":20841,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61"},"html":{"href":"https://github.com/debtcollective/dispute-tools/pull/61"},"issue":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/issues/61"},"comments":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/debtcollective/dispute-tools/statuses/618e2e983f6b9bfdc00c625bfd662ec7fd2d530c"}},"author_association":"MEMBER"}} | {
"id": 122767402,
"name": "debtcollective/dispute-tools",
"url": "https://api.github.com/repos/debtcollective/dispute-tools"
} | {
"id": 24264157,
"login": "marcondag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24264157?",
"url": "https://api.github.com/users/marcondag"
} | {
"id": 13947390,
"login": "debtcollective",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13947390?",
"url": "https://api.github.com/orgs/debtcollective"
} | 2018-09-15T18:27:58 | 8270470621 | {"actor":{"display_login":"marcondag"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/222731968","pull_request_review_id":161690531,"id":222731968,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjczMTk2OA==","diff_hunk":"@@ -0,0 +1,21 @@\n+/* trap_types.h - Trap types for MIPS and RISC-V","path":"simulator/infra/trap_types.h","position":1,"original_position":1,"commit_id":"78d7e2ffc92f26d936bc09caff6577e1c6e7b538","original_commit_id":"78d7e2ffc92f26d936bc09caff6577e1c6e7b538","user":{"login":"trexxet","id":4649497,"node_id":"MDQ6VXNlcjQ2NDk0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4649497?v=4","gravatar_id":"","url":"https://api.github.com/users/trexxet","html_url":"https://github.com/trexxet","followers_url":"https://api.github.com/users/trexxet/followers","following_url":"https://api.github.com/users/trexxet/following{/other_user}","gists_url":"https://api.github.com/users/trexxet/gists{/gist_id}","starred_url":"https://api.github.com/users/trexxet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trexxet/subscriptions","organizations_url":"https://api.github.com/users/trexxet/orgs","repos_url":"https://api.github.com/users/trexxet/repos","events_url":"https://api.github.com/users/trexxet/events{/privacy}","received_events_url":"https://api.github.com/users/trexxet/received_events","type":"User","site_admin":false},"body":"Yes, but it's used by `mips_instr` and `riscv_instr`. If we had a base ISA-independent class for instruction, it would fit well in it. Also, it can be moved to trap implementation.","created_at":"2018-10-04T16:05:30Z","updated_at":"2018-10-04T16:05:30Z","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/601#discussion_r222731968","pull_request_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/222731968"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/601#discussion_r222731968"},"pull_request":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601"}},"in_reply_to_id":222728453},"pull_request":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601","id":220423693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDIzNjkz","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/601","diff_url":"https://github.com/MIPT-ILab/mipt-mips/pull/601.diff","patch_url":"https://github.com/MIPT-ILab/mipt-mips/pull/601.patch","issue_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/601","number":601,"state":"open","locked":false,"title":"Stop FuncSim on trap hit","user":{"login":"trexxet","id":4649497,"node_id":"MDQ6VXNlcjQ2NDk0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4649497?v=4","gravatar_id":"","url":"https://api.github.com/users/trexxet","html_url":"https://github.com/trexxet","followers_url":"https://api.github.com/users/trexxet/followers","following_url":"https://api.github.com/users/trexxet/following{/other_user}","gists_url":"https://api.github.com/users/trexxet/gists{/gist_id}","starred_url":"https://api.github.com/users/trexxet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trexxet/subscriptions","organizations_url":"https://api.github.com/users/trexxet/orgs","repos_url":"https://api.github.com/users/trexxet/repos","events_url":"https://api.github.com/users/trexxet/events{/privacy}","received_events_url":"https://api.github.com/users/trexxet/received_events","type":"User","site_admin":false},"body":"Breakpoint, syscall and other traps stops FuncSim execution (as I did it in #557). ","created_at":"2018-10-04T15:35:35Z","updated_at":"2018-10-04T16:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9db527b49b3b32d30a497e99e0039e2c2d28ff6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601/commits","review_comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601/comments","review_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/601/comments","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/78d7e2ffc92f26d936bc09caff6577e1c6e7b538","head":{"label":"trexxet:break_trap_instr","ref":"break_trap_instr","sha":"78d7e2ffc92f26d936bc09caff6577e1c6e7b538","user":{"login":"trexxet","id":4649497,"node_id":"MDQ6VXNlcjQ2NDk0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4649497?v=4","gravatar_id":"","url":"https://api.github.com/users/trexxet","html_url":"https://github.com/trexxet","followers_url":"https://api.github.com/users/trexxet/followers","following_url":"https://api.github.com/users/trexxet/following{/other_user}","gists_url":"https://api.github.com/users/trexxet/gists{/gist_id}","starred_url":"https://api.github.com/users/trexxet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trexxet/subscriptions","organizations_url":"https://api.github.com/users/trexxet/orgs","repos_url":"https://api.github.com/users/trexxet/repos","events_url":"https://api.github.com/users/trexxet/events{/privacy}","received_events_url":"https://api.github.com/users/trexxet/received_events","type":"User","site_admin":false},"repo":{"id":140254165,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyNTQxNjU=","name":"mipt-mips","full_name":"trexxet/mipt-mips","private":false,"owner":{"login":"trexxet","id":4649497,"node_id":"MDQ6VXNlcjQ2NDk0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4649497?v=4","gravatar_id":"","url":"https://api.github.com/users/trexxet","html_url":"https://github.com/trexxet","followers_url":"https://api.github.com/users/trexxet/followers","following_url":"https://api.github.com/users/trexxet/following{/other_user}","gists_url":"https://api.github.com/users/trexxet/gists{/gist_id}","starred_url":"https://api.github.com/users/trexxet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trexxet/subscriptions","organizations_url":"https://api.github.com/users/trexxet/orgs","repos_url":"https://api.github.com/users/trexxet/repos","events_url":"https://api.github.com/users/trexxet/events{/privacy}","received_events_url":"https://api.github.com/users/trexxet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trexxet/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":true,"url":"https://api.github.com/repos/trexxet/mipt-mips","forks_url":"https://api.github.com/repos/trexxet/mipt-mips/forks","keys_url":"https://api.github.com/repos/trexxet/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trexxet/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trexxet/mipt-mips/teams","hooks_url":"https://api.github.com/repos/trexxet/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/trexxet/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/trexxet/mipt-mips/events","assignees_url":"https://api.github.com/repos/trexxet/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/trexxet/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/trexxet/mipt-mips/tags","blobs_url":"https://api.github.com/repos/trexxet/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trexxet/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trexxet/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/trexxet/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trexxet/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/trexxet/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/trexxet/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/trexxet/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/trexxet/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/trexxet/mipt-mips/subscription","commits_url":"https://api.github.com/repos/trexxet/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/trexxet/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/trexxet/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/trexxet/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/trexxet/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/trexxet/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trexxet/mipt-mips/merges","archive_url":"https://api.github.com/repos/trexxet/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trexxet/mipt-mips/downloads","issues_url":"https://api.github.com/repos/trexxet/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/trexxet/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/trexxet/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/trexxet/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trexxet/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/trexxet/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/trexxet/mipt-mips/deployments","created_at":"2018-07-09T08:22:52Z","updated_at":"2018-10-03T22:44:28Z","pushed_at":"2018-10-04T15:29:56Z","git_url":"git://github.com/trexxet/mipt-mips.git","ssh_url":"git@github.com:trexxet/mipt-mips.git","clone_url":"https://github.com/trexxet/mipt-mips.git","svn_url":"https://github.com/trexxet/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":10782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MIPT-ILab:master","ref":"master","sha":"0f0fa26dd4b9ad7bde791212133820294aef9172","user":{"login":"MIPT-ILab","id":13999586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTk5NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"repo":{"id":42990634,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjk5MDYzNA==","name":"mipt-mips","full_name":"MIPT-ILab/mipt-mips","private":false,"owner":{"login":"MIPT-ILab","id":13999586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTk5NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MIPT-ILab/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":false,"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips","forks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/forks","keys_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/teams","hooks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/events","assignees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/tags","blobs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscription","commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/merges","archive_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/downloads","issues_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/deployments","created_at":"2015-09-23T09:12:26Z","updated_at":"2018-10-03T21:44:55Z","pushed_at":"2018-10-04T15:35:36Z","git_url":"git://github.com/MIPT-ILab/mipt-mips.git","ssh_url":"git@github.com:MIPT-ILab/mipt-mips.git","clone_url":"https://github.com/MIPT-ILab/mipt-mips.git","svn_url":"https://github.com/MIPT-ILab/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":115781,"stargazers_count":68,"watchers_count":68,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":72,"open_issues":53,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/601"},"issue":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/601"},"comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/78d7e2ffc92f26d936bc09caff6577e1c6e7b538"}},"author_association":"COLLABORATOR"}} | {
"id": 42990634,
"name": "MIPT-ILab/mipt-mips",
"url": "https://api.github.com/repos/MIPT-ILab/mipt-mips"
} | {
"id": 4649497,
"login": "trexxet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4649497?",
"url": "https://api.github.com/users/trexxet"
} | {
"id": 13999586,
"login": "MIPT-ILab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13999586?",
"url": "https://api.github.com/orgs/MIPT-ILab"
} | 2018-10-04T16:05:30 | 8368999979 | {"actor":{"display_login":"trexxet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/175172732","pull_request_review_id":104666914,"id":175172732,"diff_hunk":"@@ -0,0 +1,150 @@\n+/**\n+ * Unit tests for rf\n+ * @author Alexander Misevich\n+ * Copyright 2018 MIPT-MIPS\n+ */\n+\n+// generic C\n+#include <cassert>\n+#include <cstdlib>\n+#include <cmath>\n+\n+// Google Test library\n+#include <gtest/gtest.h>\n+\n+// MIPS-MIPS modules\n+#include <mips/mips.h>\n+#include \"../rf.h\"\n+\n+#define GTEST_ASSERT_NO_DEATH(statement) \\\n+ ASSERT_EXIT({{ statement } ::exit(EXIT_SUCCESS); }, ::testing::ExitedWithCode(0), \"\")\n+\n+static_assert(MIPSRegister::MAX_REG >= 32);\n+\n+// Testing methods of the class\n+TEST( Rf, empty_rf)\n+{\n+ // Create array of 35 Regs\n+ ASSERT_FALSE( RF<MIPS>().array.empty()); \n+}\n+\n+TEST( RF, read_write_rf)\n+{\n+ auto rf = std::make_unique<RF<MIPS>>();\n+ \n+ // Fill array using write() and check correctness using read()\n+ for( size_t i = 0; i < 32; ++i)\n+ { \n+ rf->write( MIPSRegister(i), i);\n+ \n+ // Try to write something in zero register\n+ rf->write( MIPSRegister::zero, i);\n+ \n+ // Checks\n+ ASSERT_EQ( rf->read( MIPSRegister(i)), i);\n+ ASSERT_FALSE( rf->read( MIPSRegister::zero));\n+ }\n+\n+ // Additional checks for mips_hi_lo \n+ rf->write( MIPSRegister::mips_hi_lo, pow(2, 32));\n+ ASSERT_EQ( rf->read( MIPSRegister::mips_hi), 1u);\n+ ASSERT_FALSE( rf->read( MIPSRegister::mips_lo));\n+}\n+\n+TEST( RF, read_sources_write_dst_rf)\n+{\n+ auto rf = std::make_unique<RF<MIPS>>();\n+\n+ // Fill Reg 25(it's src2) with some value\n+ rf->write( MIPSRegister(25), 1);\n+\n+ // Create the instr( for example, \"add\")\n+ auto instr = new MIPSInstr( 0x01398820);\n+ // Use read_sources( \"add\") method( initialize src1 and src2)\n+ rf->read_sources( instr);\n+ // Execute instruction( to change v_dst field)\n+ instr->execute();\n+ // Check\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+\n+ // Same \n+ instr = new MIPSInstr( 0x01398821);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398824);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x0139880a);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x0139880b);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x71398802);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398827);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398825);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x03298804);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x03298806);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398822);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398823);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x01398826);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);\n+ instr = new MIPSInstr( 0x0139882a);\n+ rf->read_sources( instr);\n+ instr->execute();\n+ ASSERT_EQ( instr->get_v_src2(), 1u);\n+ ASSERT_FALSE( instr->get_v_dst() == NO_VAL64);","path":"simulator/func_sim/rf/t/unit_test.cpp","position":136,"original_position":136,"commit_id":"a6ccee000625dddee7a05cd29b2cc33cb9f2e57c","original_commit_id":"a6ccee000625dddee7a05cd29b2cc33cb9f2e57c","user":{"login":"pavelkryukov","id":11466405,"avatar_url":"https://avatars3.githubusercontent.com/u/11466405?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkryukov","html_url":"https://github.com/pavelkryukov","followers_url":"https://api.github.com/users/pavelkryukov/followers","following_url":"https://api.github.com/users/pavelkryukov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkryukov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkryukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkryukov/subscriptions","organizations_url":"https://api.github.com/users/pavelkryukov/orgs","repos_url":"https://api.github.com/users/pavelkryukov/repos","events_url":"https://api.github.com/users/pavelkryukov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkryukov/received_events","type":"User","site_admin":false},"body":"GoogleTest has `ASSERT_NE` macro for that","created_at":"2018-03-16T18:07:08Z","updated_at":"2018-03-16T18:07:12Z","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/345#discussion_r175172732","pull_request_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/175172732"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/345#discussion_r175172732"},"pull_request":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345","id":175599994,"html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/345","diff_url":"https://github.com/MIPT-ILab/mipt-mips/pull/345.diff","patch_url":"https://github.com/MIPT-ILab/mipt-mips/pull/345.patch","issue_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/345","number":345,"state":"open","locked":false,"title":"Add unit test for RF","user":{"login":"alex19999","id":25909133,"avatar_url":"https://avatars2.githubusercontent.com/u/25909133?v=4","gravatar_id":"","url":"https://api.github.com/users/alex19999","html_url":"https://github.com/alex19999","followers_url":"https://api.github.com/users/alex19999/followers","following_url":"https://api.github.com/users/alex19999/following{/other_user}","gists_url":"https://api.github.com/users/alex19999/gists{/gist_id}","starred_url":"https://api.github.com/users/alex19999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex19999/subscriptions","organizations_url":"https://api.github.com/users/alex19999/orgs","repos_url":"https://api.github.com/users/alex19999/repos","events_url":"https://api.github.com/users/alex19999/events{/privacy}","received_events_url":"https://api.github.com/users/alex19999/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-16T17:34:02Z","updated_at":"2018-03-16T18:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3dae31a5ea06abb6e172344d28e0c784d77b6e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345/commits","review_comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345/comments","review_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/345/comments","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/a6ccee000625dddee7a05cd29b2cc33cb9f2e57c","head":{"label":"alex19999:master","ref":"master","sha":"a6ccee000625dddee7a05cd29b2cc33cb9f2e57c","user":{"login":"alex19999","id":25909133,"avatar_url":"https://avatars2.githubusercontent.com/u/25909133?v=4","gravatar_id":"","url":"https://api.github.com/users/alex19999","html_url":"https://github.com/alex19999","followers_url":"https://api.github.com/users/alex19999/followers","following_url":"https://api.github.com/users/alex19999/following{/other_user}","gists_url":"https://api.github.com/users/alex19999/gists{/gist_id}","starred_url":"https://api.github.com/users/alex19999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex19999/subscriptions","organizations_url":"https://api.github.com/users/alex19999/orgs","repos_url":"https://api.github.com/users/alex19999/repos","events_url":"https://api.github.com/users/alex19999/events{/privacy}","received_events_url":"https://api.github.com/users/alex19999/received_events","type":"User","site_admin":false},"repo":{"id":104506353,"name":"mipt-mips","full_name":"alex19999/mipt-mips","owner":{"login":"alex19999","id":25909133,"avatar_url":"https://avatars2.githubusercontent.com/u/25909133?v=4","gravatar_id":"","url":"https://api.github.com/users/alex19999","html_url":"https://github.com/alex19999","followers_url":"https://api.github.com/users/alex19999/followers","following_url":"https://api.github.com/users/alex19999/following{/other_user}","gists_url":"https://api.github.com/users/alex19999/gists{/gist_id}","starred_url":"https://api.github.com/users/alex19999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex19999/subscriptions","organizations_url":"https://api.github.com/users/alex19999/orgs","repos_url":"https://api.github.com/users/alex19999/repos","events_url":"https://api.github.com/users/alex19999/events{/privacy}","received_events_url":"https://api.github.com/users/alex19999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex19999/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":true,"url":"https://api.github.com/repos/alex19999/mipt-mips","forks_url":"https://api.github.com/repos/alex19999/mipt-mips/forks","keys_url":"https://api.github.com/repos/alex19999/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex19999/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex19999/mipt-mips/teams","hooks_url":"https://api.github.com/repos/alex19999/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/alex19999/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/alex19999/mipt-mips/events","assignees_url":"https://api.github.com/repos/alex19999/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/alex19999/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/alex19999/mipt-mips/tags","blobs_url":"https://api.github.com/repos/alex19999/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex19999/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex19999/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex19999/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex19999/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/alex19999/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/alex19999/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/alex19999/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/alex19999/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/alex19999/mipt-mips/subscription","commits_url":"https://api.github.com/repos/alex19999/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex19999/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex19999/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex19999/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex19999/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/alex19999/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex19999/mipt-mips/merges","archive_url":"https://api.github.com/repos/alex19999/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex19999/mipt-mips/downloads","issues_url":"https://api.github.com/repos/alex19999/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/alex19999/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/alex19999/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/alex19999/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex19999/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/alex19999/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/alex19999/mipt-mips/deployments","created_at":"2017-09-22T18:32:04Z","updated_at":"2018-03-16T17:36:32Z","pushed_at":"2018-03-16T17:36:30Z","git_url":"git://github.com/alex19999/mipt-mips.git","ssh_url":"git@github.com:alex19999/mipt-mips.git","clone_url":"https://github.com/alex19999/mipt-mips.git","svn_url":"https://github.com/alex19999/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":10162,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MIPT-ILab:master","ref":"master","sha":"3bdbb14bb14d480f9c11c5411aa00c331c21f6fd","user":{"login":"MIPT-ILab","id":13999586,"avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"repo":{"id":42990634,"name":"mipt-mips","full_name":"MIPT-ILab/mipt-mips","owner":{"login":"MIPT-ILab","id":13999586,"avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MIPT-ILab/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":false,"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips","forks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/forks","keys_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/teams","hooks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/events","assignees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/tags","blobs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscription","commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/merges","archive_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/downloads","issues_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/deployments","created_at":"2015-09-23T09:12:26Z","updated_at":"2018-03-15T21:21:45Z","pushed_at":"2018-03-16T17:36:31Z","git_url":"git://github.com/MIPT-ILab/mipt-mips.git","ssh_url":"git@github.com:MIPT-ILab/mipt-mips.git","clone_url":"https://github.com/MIPT-ILab/mipt-mips.git","svn_url":"https://github.com/MIPT-ILab/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":115117,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":46,"open_issues":33,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/345"},"issue":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/345"},"comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/a6ccee000625dddee7a05cd29b2cc33cb9f2e57c"}},"author_association":"COLLABORATOR"}} | {
"id": 42990634,
"name": "MIPT-ILab/mipt-mips",
"url": "https://api.github.com/repos/MIPT-ILab/mipt-mips"
} | {
"id": 11466405,
"login": "pavelkryukov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11466405?",
"url": "https://api.github.com/users/pavelkryukov"
} | {
"id": 13999586,
"login": "MIPT-ILab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13999586?",
"url": "https://api.github.com/orgs/MIPT-ILab"
} | 2018-03-16T18:07:08 | 7392280141 | {"actor":{"display_login":"pavelkryukov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/212168534","pull_request_review_id":148741360,"id":212168534,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjE2ODUzNA==","diff_hunk":"@@ -408,6 +408,76 @@ SELECT count(*) FROM subdept;\n 48\n (1 row)\n \n+-- MPP-29458","path":"src/test/regress/expected/join_gp.out","position":4,"original_position":4,"commit_id":"e001b02bee93de297a92cdde8e8e31554b5f3015","original_commit_id":"40657fb61ba4cdae1dd18c0a4c35e1bc9a980ab7","user":{"login":"baobao0206","id":17561680,"node_id":"MDQ6VXNlcjE3NTYxNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/17561680?v=4","gravatar_id":"","url":"https://api.github.com/users/baobao0206","html_url":"https://github.com/baobao0206","followers_url":"https://api.github.com/users/baobao0206/followers","following_url":"https://api.github.com/users/baobao0206/following{/other_user}","gists_url":"https://api.github.com/users/baobao0206/gists{/gist_id}","starred_url":"https://api.github.com/users/baobao0206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baobao0206/subscriptions","organizations_url":"https://api.github.com/users/baobao0206/orgs","repos_url":"https://api.github.com/users/baobao0206/repos","events_url":"https://api.github.com/users/baobao0206/events{/privacy}","received_events_url":"https://api.github.com/users/baobao0206/received_events","type":"User","site_admin":false},"body":"Yeah, Have add a commit and fixed these problems.","created_at":"2018-08-23T02:48:15Z","updated_at":"2018-08-23T02:48:16Z","html_url":"https://github.com/greenplum-db/gpdb/pull/5496#discussion_r212168534","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/212168534"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5496#discussion_r212168534"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496"}},"in_reply_to_id":211484967},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496","id":208499046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDk5MDQ2","html_url":"https://github.com/greenplum-db/gpdb/pull/5496","diff_url":"https://github.com/greenplum-db/gpdb/pull/5496.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/5496.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5496","number":5496,"state":"open","locked":false,"title":"Fix redistribute bug on some types which need to convert","user":{"login":"baobao0206","id":17561680,"node_id":"MDQ6VXNlcjE3NTYxNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/17561680?v=4","gravatar_id":"","url":"https://api.github.com/users/baobao0206","html_url":"https://github.com/baobao0206","followers_url":"https://api.github.com/users/baobao0206/followers","following_url":"https://api.github.com/users/baobao0206/following{/other_user}","gists_url":"https://api.github.com/users/baobao0206/gists{/gist_id}","starred_url":"https://api.github.com/users/baobao0206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baobao0206/subscriptions","organizations_url":"https://api.github.com/users/baobao0206/orgs","repos_url":"https://api.github.com/users/baobao0206/repos","events_url":"https://api.github.com/users/baobao0206/events{/privacy}","received_events_url":"https://api.github.com/users/baobao0206/received_events","type":"User","site_admin":false},"body":"After 8.4 merge, we have two restrictlist 'mergeclause_list'\r\nand 'hashclause_list' in function 'add_paths_to_joinrel'. We\r\nuse mergeclause_list in cdb motion in hashjoin. But some of\r\nkeys should not been used as distribution keys.\r\n\r\nWe can use restrictinfo->hashjoinoperator to determine if\r\na RestrictInfo in mergeclause_list can be a redistribute\r\nkey. Considered there are different requirements for\r\nRestrictInfo for redistribution and merge, We can make a\r\nnew function to make a cdbclause_list,rather than use\r\nmergeclause_list as redistribute keys in merge and hash join.","created_at":"2018-08-15T08:13:52Z","updated_at":"2018-08-23T02:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfa4ef8b495dca0bc7b0d6f1109b1d8ecd593f46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5496/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e001b02bee93de297a92cdde8e8e31554b5f3015","head":{"label":"baobao0206:fix_redistribute_5x","ref":"fix_redistribute_5x","sha":"e001b02bee93de297a92cdde8e8e31554b5f3015","user":{"login":"baobao0206","id":17561680,"node_id":"MDQ6VXNlcjE3NTYxNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/17561680?v=4","gravatar_id":"","url":"https://api.github.com/users/baobao0206","html_url":"https://github.com/baobao0206","followers_url":"https://api.github.com/users/baobao0206/followers","following_url":"https://api.github.com/users/baobao0206/following{/other_user}","gists_url":"https://api.github.com/users/baobao0206/gists{/gist_id}","starred_url":"https://api.github.com/users/baobao0206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baobao0206/subscriptions","organizations_url":"https://api.github.com/users/baobao0206/orgs","repos_url":"https://api.github.com/users/baobao0206/repos","events_url":"https://api.github.com/users/baobao0206/events{/privacy}","received_events_url":"https://api.github.com/users/baobao0206/received_events","type":"User","site_admin":false},"repo":{"id":133338522,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMzg1MjI=","name":"gpdb","full_name":"baobao0206/gpdb","owner":{"login":"baobao0206","id":17561680,"node_id":"MDQ6VXNlcjE3NTYxNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/17561680?v=4","gravatar_id":"","url":"https://api.github.com/users/baobao0206","html_url":"https://github.com/baobao0206","followers_url":"https://api.github.com/users/baobao0206/followers","following_url":"https://api.github.com/users/baobao0206/following{/other_user}","gists_url":"https://api.github.com/users/baobao0206/gists{/gist_id}","starred_url":"https://api.github.com/users/baobao0206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baobao0206/subscriptions","organizations_url":"https://api.github.com/users/baobao0206/orgs","repos_url":"https://api.github.com/users/baobao0206/repos","events_url":"https://api.github.com/users/baobao0206/events{/privacy}","received_events_url":"https://api.github.com/users/baobao0206/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baobao0206/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/baobao0206/gpdb","forks_url":"https://api.github.com/repos/baobao0206/gpdb/forks","keys_url":"https://api.github.com/repos/baobao0206/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baobao0206/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baobao0206/gpdb/teams","hooks_url":"https://api.github.com/repos/baobao0206/gpdb/hooks","issue_events_url":"https://api.github.com/repos/baobao0206/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/baobao0206/gpdb/events","assignees_url":"https://api.github.com/repos/baobao0206/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/baobao0206/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/baobao0206/gpdb/tags","blobs_url":"https://api.github.com/repos/baobao0206/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baobao0206/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baobao0206/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/baobao0206/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baobao0206/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/baobao0206/gpdb/languages","stargazers_url":"https://api.github.com/repos/baobao0206/gpdb/stargazers","contributors_url":"https://api.github.com/repos/baobao0206/gpdb/contributors","subscribers_url":"https://api.github.com/repos/baobao0206/gpdb/subscribers","subscription_url":"https://api.github.com/repos/baobao0206/gpdb/subscription","commits_url":"https://api.github.com/repos/baobao0206/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/baobao0206/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/baobao0206/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/baobao0206/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/baobao0206/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/baobao0206/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baobao0206/gpdb/merges","archive_url":"https://api.github.com/repos/baobao0206/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baobao0206/gpdb/downloads","issues_url":"https://api.github.com/repos/baobao0206/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/baobao0206/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/baobao0206/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/baobao0206/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baobao0206/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/baobao0206/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/baobao0206/gpdb/deployments","created_at":"2018-05-14T09:39:40Z","updated_at":"2018-08-21T08:55:24Z","pushed_at":"2018-08-22T10:58:16Z","git_url":"git://github.com/baobao0206/gpdb.git","ssh_url":"git@github.com:baobao0206/gpdb.git","clone_url":"https://github.com/baobao0206/gpdb.git","svn_url":"https://github.com/baobao0206/gpdb","homepage":"http://greenplum.org","size":293958,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:5X_STABLE","ref":"5X_STABLE","sha":"b3ac5d7763b652a61208ddfc97450c356ef8c6c3","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-08-23T01:41:23Z","pushed_at":"2018-08-23T01:41:10Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":294604,"stargazers_count":2630,"watchers_count":2630,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":239,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":812,"open_issues":239,"watchers":2630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5496"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5496"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5496/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5496/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e001b02bee93de297a92cdde8e8e31554b5f3015"}},"author_association":"MEMBER"}} | {
"id": 44781140,
"name": "greenplum-db/gpdb",
"url": "https://api.github.com/repos/greenplum-db/gpdb"
} | {
"id": 17561680,
"login": "baobao0206",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17561680?",
"url": "https://api.github.com/users/baobao0206"
} | {
"id": 14097842,
"login": "greenplum-db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14097842?",
"url": "https://api.github.com/orgs/greenplum-db"
} | 2018-08-23T02:48:15 | 8154354110 | {"actor":{"display_login":"baobao0206"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/178317941","pull_request_review_id":108365148,"id":178317941,"diff_hunk":"@@ -2612,6 +2647,7 @@ class SemanticsConfiguration {\n .._value = _value","path":"packages/flutter/lib/src/semantics/semantics.dart","position":157,"original_position":157,"commit_id":"00137a94cda909bb158804b05df88409ce3a6099","original_commit_id":"00137a94cda909bb158804b05df88409ce3a6099","user":{"login":"goderbauer","id":1227763,"avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"I can't comment on the correct line, but `routeName` probably also needs to be handled in `absorb` and `isCompatibleWith` above.\r\n\r\nAlso, is it ok for the `routeName` to implicitly get merged into other semantics nodes? Or should a node that specifies a routeName always be a semantics boundary meaning that semantic information from that route cannot bubble up to parent nodes of that route?","created_at":"2018-03-30T16:01:36Z","updated_at":"2018-03-30T16:01:36Z","html_url":"https://github.com/flutter/flutter/pull/16081#discussion_r178317941","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/16081","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/178317941"},"html":{"href":"https://github.com/flutter/flutter/pull/16081#discussion_r178317941"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/16081"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/16081","id":178440652,"html_url":"https://github.com/flutter/flutter/pull/16081","diff_url":"https://github.com/flutter/flutter/pull/16081.diff","patch_url":"https://github.com/flutter/flutter/pull/16081.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/16081","number":16081,"state":"open","locked":false,"title":"(WIP) Semantics object support for edge triggered semantics","user":{"login":"jonahwilliams","id":8975114,"avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"Framework support for flutter/flutter#13704. Also requires https://github.com/flutter/engine/pull/4901 in the engine first.\r\n\r\nAlso adds some examples to the gallery app routes and drawer.","created_at":"2018-03-29T21:01:20Z","updated_at":"2018-03-30T16:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa5b80cf6cb7f16274c843f628648f15f10627d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/16081/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/16081/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/16081/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/00137a94cda909bb158804b05df88409ce3a6099","head":{"label":"jonahwilliams:access","ref":"access","sha":"00137a94cda909bb158804b05df88409ce3a6099","user":{"login":"jonahwilliams","id":8975114,"avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"repo":{"id":123957473,"name":"flutter","full_name":"jonahwilliams/flutter","owner":{"login":"jonahwilliams","id":8975114,"avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonahwilliams/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/jonahwilliams/flutter","forks_url":"https://api.github.com/repos/jonahwilliams/flutter/forks","keys_url":"https://api.github.com/repos/jonahwilliams/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonahwilliams/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonahwilliams/flutter/teams","hooks_url":"https://api.github.com/repos/jonahwilliams/flutter/hooks","issue_events_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jonahwilliams/flutter/events","assignees_url":"https://api.github.com/repos/jonahwilliams/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jonahwilliams/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jonahwilliams/flutter/tags","blobs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonahwilliams/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonahwilliams/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonahwilliams/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jonahwilliams/flutter/languages","stargazers_url":"https://api.github.com/repos/jonahwilliams/flutter/stargazers","contributors_url":"https://api.github.com/repos/jonahwilliams/flutter/contributors","subscribers_url":"https://api.github.com/repos/jonahwilliams/flutter/subscribers","subscription_url":"https://api.github.com/repos/jonahwilliams/flutter/subscription","commits_url":"https://api.github.com/repos/jonahwilliams/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonahwilliams/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonahwilliams/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonahwilliams/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jonahwilliams/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonahwilliams/flutter/merges","archive_url":"https://api.github.com/repos/jonahwilliams/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonahwilliams/flutter/downloads","issues_url":"https://api.github.com/repos/jonahwilliams/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jonahwilliams/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jonahwilliams/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jonahwilliams/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonahwilliams/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jonahwilliams/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jonahwilliams/flutter/deployments","created_at":"2018-03-05T17:57:36Z","updated_at":"2018-03-26T16:03:34Z","pushed_at":"2018-03-30T04:44:08Z","git_url":"git://github.com/jonahwilliams/flutter.git","ssh_url":"git@github.com:jonahwilliams/flutter.git","clone_url":"https://github.com/jonahwilliams/flutter.git","svn_url":"https://github.com/jonahwilliams/flutter","homepage":"https://flutter.io","size":36423,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"b4274ef6851207e40651585060cf47bcd2581d22","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-03-30T15:50:59Z","pushed_at":"2018-03-30T15:35:49Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":36389,"stargazers_count":20379,"watchers_count":20379,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":2740,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1666,"open_issues":2740,"watchers":20379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/16081"},"html":{"href":"https://github.com/flutter/flutter/pull/16081"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/16081"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/16081/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/16081/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/16081/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/00137a94cda909bb158804b05df88409ce3a6099"}},"author_association":"CONTRIBUTOR"}} | {
"id": 31792824,
"name": "flutter/flutter",
"url": "https://api.github.com/repos/flutter/flutter"
} | {
"id": 1227763,
"login": "goderbauer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1227763?",
"url": "https://api.github.com/users/goderbauer"
} | {
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
} | 2018-03-30T16:01:36 | 7459606827 | {"actor":{"display_login":"goderbauer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/218954629","pull_request_review_id":157010252,"id":218954629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk1NDYyOQ==","diff_hunk":"@@ -240,57 +239,68 @@ class _Compiler {\n \n printTrace('Listening to compiler controller...');\n compilerController.stream.listen((_CompilationRequest request) async {\n- final bool isEmpty = compilationQueue.isEmpty;\n compilationQueue.add(request);\n // Only trigger processing if queue was empty - i.e. no other requests\n // are currently being processed. This effectively enforces \"one\n // compilation request at a time\".\n- if (isEmpty) {\n- while (compilationQueue.isNotEmpty) {\n- final _CompilationRequest request = compilationQueue.first;\n- printTrace('Compiling ${request.path}');\n- final Stopwatch compilerTime = Stopwatch()..start();\n- bool firstCompile = false;\n- if (compiler == null) {\n- compiler = createCompiler();\n- firstCompile = true;\n- }\n- suppressOutput = false;\n- final CompilerOutput compilerOutput = await handleTimeout<CompilerOutput>(\n- compiler.recompile(\n- request.path,\n- <String>[request.path],\n- outputPath: outputDill.path),\n- request.path);\n- final String outputPath = compilerOutput?.outputFilename;\n-\n- // In case compiler didn't produce output or reported compilation\n- // errors, pass [null] upwards to the consumer and shutdown the\n- // compiler to avoid reusing compiler that might have gotten into\n- // a weird state.\n- if (outputPath == null || compilerOutput.errorCount > 0) {\n- request.result.complete(null);\n- await _shutdown();\n- } else {\n- final File outputFile = fs.file(outputPath);\n- final File kernelReadyToRun = await outputFile.copy('${request.path}.dill');\n- final File testCache = fs.file(testFilePath);\n- if (firstCompile || !testCache.existsSync() || (testCache.lengthSync() < outputFile.lengthSync())) {\n- // The idea is to keep the cache file up-to-date and include as\n- // much as possible in an effort to re-use as many packages as\n- // possible.\n- ensureDirectoryExists(testFilePath);\n- await outputFile.copy(testFilePath);\n- }\n- request.result.complete(kernelReadyToRun.path);\n- compiler.accept();\n- compiler.reset();\n+ ResidentCompiler compiler;\n+ String outputDill;\n+ bool firstCompile = false;\n+ if (idleCompilers.isEmpty && compilers < concurrency ) {\n+ // Create compiler\n+ compiler = createCompiler();\n+ firstCompile = true;\n+ compilers++;\n+ outputDill = outputDillDirectory.childFile('output_$compilers.dill').path;\n+ printTrace('Compiler will use the following file as its incremental dill file: $outputDill');","path":"packages/flutter_tools/lib/src/test/flutter_platform.dart","position":91,"original_position":91,"commit_id":"492fa34eb05597cf5c6e2faf08a953b496a1e2b8","original_commit_id":"492fa34eb05597cf5c6e2faf08a953b496a1e2b8","user":{"login":"a-siva","id":8633293,"node_id":"MDQ6VXNlcjg2MzMyOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8633293?v=4","gravatar_id":"","url":"https://api.github.com/users/a-siva","html_url":"https://github.com/a-siva","followers_url":"https://api.github.com/users/a-siva/followers","following_url":"https://api.github.com/users/a-siva/following{/other_user}","gists_url":"https://api.github.com/users/a-siva/gists{/gist_id}","starred_url":"https://api.github.com/users/a-siva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-siva/subscriptions","organizations_url":"https://api.github.com/users/a-siva/orgs","repos_url":"https://api.github.com/users/a-siva/repos","events_url":"https://api.github.com/users/a-siva/events{/privacy}","received_events_url":"https://api.github.com/users/a-siva/received_events","type":"User","site_admin":false},"body":"We are going to see multiples of these trace messages depending on the number of compilers being used, maybe the message should also say which compiler number it is referring to\r\n'Compiler($compilers) will use ...'","created_at":"2018-09-19T20:35:17Z","updated_at":"2018-09-19T20:44:07Z","html_url":"https://github.com/flutter/flutter/pull/21763#discussion_r218954629","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/21763","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/218954629"},"html":{"href":"https://github.com/flutter/flutter/pull/21763#discussion_r218954629"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21763"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/21763","id":215127108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTI3MTA4","html_url":"https://github.com/flutter/flutter/pull/21763","diff_url":"https://github.com/flutter/flutter/pull/21763.diff","patch_url":"https://github.com/flutter/flutter/pull/21763.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21763","number":21763,"state":"open","locked":false,"title":"Parallelize flutter platform compilation by number of cores available.","user":{"login":"aam","id":381137,"node_id":"MDQ6VXNlcjM4MTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"body":"Gives ~3x performance boost on \"standard\" 28 core linux desktop\r\n\r\nbefore\r\n```\r\n$FH/flutter/packages/flutter$ $FH/flutter/bin/flutter test\r\n02:52 +3093 ~25: All tests passed! \r\n$FH/flutter/bin/flutter test 930.92s user 130.69s system 606% cpu 2:55.15 total\r\n```\r\n\r\nafter\r\n```\r\n$FH/flutter/packages/flutter$ $FH/flutter/bin/flutter test\r\n00:47 +3093 ~25: All tests passed! \r\n$FH/flutter/bin/flutter test 1144.62s user 127.94s system 2553% cpu 49.843 total\r\n```\r\n\r\n\"Inspired\" by @jensjoha 's https://github.com/flutter/flutter/pull/15511","created_at":"2018-09-12T23:47:34Z","updated_at":"2018-09-19T20:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ffdbeda3b308da02476a9b7677c7d310dcdb8df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jensjoha","id":20773519,"node_id":"MDQ6VXNlcjIwNzczNTE5","avatar_url":"https://avatars3.githubusercontent.com/u/20773519?v=4","gravatar_id":"","url":"https://api.github.com/users/jensjoha","html_url":"https://github.com/jensjoha","followers_url":"https://api.github.com/users/jensjoha/followers","following_url":"https://api.github.com/users/jensjoha/following{/other_user}","gists_url":"https://api.github.com/users/jensjoha/gists{/gist_id}","starred_url":"https://api.github.com/users/jensjoha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensjoha/subscriptions","organizations_url":"https://api.github.com/users/jensjoha/orgs","repos_url":"https://api.github.com/users/jensjoha/repos","events_url":"https://api.github.com/users/jensjoha/events{/privacy}","received_events_url":"https://api.github.com/users/jensjoha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/21763/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/21763/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21763/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/492fa34eb05597cf5c6e2faf08a953b496a1e2b8","head":{"label":"aam:parallelize-flutter-platform-compiler","ref":"parallelize-flutter-platform-compiler","sha":"492fa34eb05597cf5c6e2faf08a953b496a1e2b8","user":{"login":"aam","id":381137,"node_id":"MDQ6VXNlcjM4MTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"repo":{"id":48006917,"node_id":"MDEwOlJlcG9zaXRvcnk0ODAwNjkxNw==","name":"flutter","full_name":"aam/flutter","private":false,"owner":{"login":"aam","id":381137,"node_id":"MDQ6VXNlcjM4MTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aam/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/aam/flutter","forks_url":"https://api.github.com/repos/aam/flutter/forks","keys_url":"https://api.github.com/repos/aam/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aam/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aam/flutter/teams","hooks_url":"https://api.github.com/repos/aam/flutter/hooks","issue_events_url":"https://api.github.com/repos/aam/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/aam/flutter/events","assignees_url":"https://api.github.com/repos/aam/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/aam/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/aam/flutter/tags","blobs_url":"https://api.github.com/repos/aam/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aam/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aam/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/aam/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aam/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/aam/flutter/languages","stargazers_url":"https://api.github.com/repos/aam/flutter/stargazers","contributors_url":"https://api.github.com/repos/aam/flutter/contributors","subscribers_url":"https://api.github.com/repos/aam/flutter/subscribers","subscription_url":"https://api.github.com/repos/aam/flutter/subscription","commits_url":"https://api.github.com/repos/aam/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/aam/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/aam/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/aam/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/aam/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/aam/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aam/flutter/merges","archive_url":"https://api.github.com/repos/aam/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aam/flutter/downloads","issues_url":"https://api.github.com/repos/aam/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/aam/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/aam/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/aam/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aam/flutter/labels{/name}","releases_url":"https://api.github.com/repos/aam/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/aam/flutter/deployments","created_at":"2015-12-14T23:14:18Z","updated_at":"2018-09-19T17:35:21Z","pushed_at":"2018-09-19T17:35:18Z","git_url":"git://github.com/aam/flutter.git","ssh_url":"git@github.com:aam/flutter.git","clone_url":"https://github.com/aam/flutter.git","svn_url":"https://github.com/aam/flutter","homepage":"http://flutter.io","size":47383,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"ccd070a5b42d18d1b8dfce4e8b59417373122dc2","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-09-19T20:35:49Z","pushed_at":"2018-09-19T20:43:15Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":47190,"stargazers_count":37436,"watchers_count":37436,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3552,"mirror_url":null,"archived":false,"open_issues_count":3930,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3552,"open_issues":3930,"watchers":37436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21763"},"html":{"href":"https://github.com/flutter/flutter/pull/21763"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/21763"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/21763/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21763/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21763/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/492fa34eb05597cf5c6e2faf08a953b496a1e2b8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 31792824,
"name": "flutter/flutter",
"url": "https://api.github.com/repos/flutter/flutter"
} | {
"id": 8633293,
"login": "a-siva",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8633293?",
"url": "https://api.github.com/users/a-siva"
} | {
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
} | 2018-09-19T20:35:17 | 8291527367 | {"actor":{"display_login":"a-siva"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/166143442","pull_request_review_id":94177932,"id":166143442,"diff_hunk":"@@ -227,6 +253,7 @@ class _FrontendCompiler implements CompilerInterface {\n return Uri.base.resolve(uriPath);\n }\n \n+","path":"frontend_server/lib/server.dart","position":87,"original_position":87,"commit_id":"23c1d8964bbb3bca4b5fe47ab5ee2565c3301a74","original_commit_id":"23c1d8964bbb3bca4b5fe47ab5ee2565c3301a74","user":{"login":"aam","id":381137,"avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"body":"accidentally added newline?","created_at":"2018-02-05T23:16:23Z","updated_at":"2018-02-05T23:16:23Z","html_url":"https://github.com/flutter/engine/pull/4529#discussion_r166143442","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/4529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/166143442"},"html":{"href":"https://github.com/flutter/engine/pull/4529#discussion_r166143442"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/4529"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/4529","id":161931788,"html_url":"https://github.com/flutter/engine/pull/4529","diff_url":"https://github.com/flutter/engine/pull/4529.diff","patch_url":"https://github.com/flutter/engine/pull/4529.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/4529","number":4529,"state":"open","locked":false,"title":"Track widget creation locations.","user":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"Run an optional kernel transform to rewrite all calls to create widgets to track the location the call was made from.","created_at":"2018-01-09T17:30:38Z","updated_at":"2018-02-05T23:16:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"092ae7d9ff90ea90e0ee0efe180152e0ef9bf14f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mraleph","id":131846,"avatar_url":"https://avatars3.githubusercontent.com/u/131846?v=4","gravatar_id":"","url":"https://api.github.com/users/mraleph","html_url":"https://github.com/mraleph","followers_url":"https://api.github.com/users/mraleph/followers","following_url":"https://api.github.com/users/mraleph/following{/other_user}","gists_url":"https://api.github.com/users/mraleph/gists{/gist_id}","starred_url":"https://api.github.com/users/mraleph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mraleph/subscriptions","organizations_url":"https://api.github.com/users/mraleph/orgs","repos_url":"https://api.github.com/users/mraleph/repos","events_url":"https://api.github.com/users/mraleph/events{/privacy}","received_events_url":"https://api.github.com/users/mraleph/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/4529/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/4529/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/4529/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/23c1d8964bbb3bca4b5fe47ab5ee2565c3301a74","head":{"label":"jacob314:track_locations","ref":"track_locations","sha":"23c1d8964bbb3bca4b5fe47ab5ee2565c3301a74","user":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"repo":{"id":114038675,"name":"engine","full_name":"jacob314/engine","owner":{"login":"jacob314","id":1226812,"avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacob314/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/jacob314/engine","forks_url":"https://api.github.com/repos/jacob314/engine/forks","keys_url":"https://api.github.com/repos/jacob314/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacob314/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacob314/engine/teams","hooks_url":"https://api.github.com/repos/jacob314/engine/hooks","issue_events_url":"https://api.github.com/repos/jacob314/engine/issues/events{/number}","events_url":"https://api.github.com/repos/jacob314/engine/events","assignees_url":"https://api.github.com/repos/jacob314/engine/assignees{/user}","branches_url":"https://api.github.com/repos/jacob314/engine/branches{/branch}","tags_url":"https://api.github.com/repos/jacob314/engine/tags","blobs_url":"https://api.github.com/repos/jacob314/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacob314/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacob314/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacob314/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacob314/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jacob314/engine/languages","stargazers_url":"https://api.github.com/repos/jacob314/engine/stargazers","contributors_url":"https://api.github.com/repos/jacob314/engine/contributors","subscribers_url":"https://api.github.com/repos/jacob314/engine/subscribers","subscription_url":"https://api.github.com/repos/jacob314/engine/subscription","commits_url":"https://api.github.com/repos/jacob314/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacob314/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacob314/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacob314/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacob314/engine/contents/{+path}","compare_url":"https://api.github.com/repos/jacob314/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacob314/engine/merges","archive_url":"https://api.github.com/repos/jacob314/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacob314/engine/downloads","issues_url":"https://api.github.com/repos/jacob314/engine/issues{/number}","pulls_url":"https://api.github.com/repos/jacob314/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jacob314/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jacob314/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacob314/engine/labels{/name}","releases_url":"https://api.github.com/repos/jacob314/engine/releases{/id}","deployments_url":"https://api.github.com/repos/jacob314/engine/deployments","created_at":"2017-12-12T21:00:49Z","updated_at":"2017-12-12T21:00:55Z","pushed_at":"2018-02-05T18:51:21Z","git_url":"git://github.com/jacob314/engine.git","ssh_url":"git@github.com:jacob314/engine.git","clone_url":"https://github.com/jacob314/engine.git","svn_url":"https://github.com/jacob314/engine","homepage":"http://flutter.io","size":118150,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"151bb37435282fc2081349803489c95ae26badd1","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2018-02-05T23:02:55Z","pushed_at":"2018-02-05T23:14:14Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":118157,"stargazers_count":1114,"watchers_count":1114,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":309,"open_issues":7,"watchers":1114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/4529"},"html":{"href":"https://github.com/flutter/engine/pull/4529"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/4529"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/4529/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/4529/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/4529/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/23c1d8964bbb3bca4b5fe47ab5ee2565c3301a74"}},"author_association":"NONE"}} | {
"id": 39211337,
"name": "flutter/engine",
"url": "https://api.github.com/repos/flutter/engine"
} | {
"id": 381137,
"login": "aam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/381137?",
"url": "https://api.github.com/users/aam"
} | {
"id": 14101776,
"login": "flutter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14101776?",
"url": "https://api.github.com/orgs/flutter"
} | 2018-02-05T23:16:23 | 7201597600 | {"actor":{"display_login":"aam"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/243700583","pull_request_review_id":187549287,"id":243700583,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzcwMDU4Mw==","diff_hunk":"@@ -144,6 +144,9 @@ process.env.SERVE_MODE;\n window.IS_AMP_ALT;\n \n // Exposed to ads.\n+// TODO: @erwinmombay I do believe this is safe to remove because\n+// All are passed to ampcontext in JsonObject. While isMaster and master is\n+// calculated in ampcontext-integration within the iframe.","path":"build-system/amp.extern.js","position":null,"original_position":6,"commit_id":"94a92daad98e1469015367c331e4e1b83e9efdb0","original_commit_id":"c2c9fb93bd8b69d6dd7326c31236544df3cfda62","user":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"Asked @erwinmombay offline. We want to leave the extern for future optimization that is not related to singlepass. I removed my comment. We will need to add missing variables to the externs, or use bracket notation. ","created_at":"2018-12-21T21:54:43Z","updated_at":"2018-12-21T21:54:43Z","html_url":"https://github.com/ampproject/amphtml/pull/19987#discussion_r243700583","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19987","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/243700583"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19987#discussion_r243700583"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19987"}},"in_reply_to_id":243697080},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/19987","id":239955758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTU1NzU4","html_url":"https://github.com/ampproject/amphtml/pull/19987","diff_url":"https://github.com/ampproject/amphtml/pull/19987.diff","patch_url":"https://github.com/ampproject/amphtml/pull/19987.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/19987","number":19987,"state":"open","locked":false,"title":"Fix Ampcontext variables in singlepass","user":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"Since ad script within iframe can access the variables, I believe we should add the vars to externs. \r\nLet me know if this is the correct fix. \r\n\r\nOne thing that confuses me is that does it mean we should add every var and method from ampcontext.js to the extern list. \r\n\r\nto @erwinmombay @lannka \r\n\r\nCloses #20002","created_at":"2018-12-19T19:53:20Z","updated_at":"2018-12-21T21:54:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0899102fe988e55484df9d012cb1f9312226ebce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19987/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19987/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/19987/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/94a92daad98e1469015367c331e4e1b83e9efdb0","head":{"label":"zhouyx:extern","ref":"extern","sha":"94a92daad98e1469015367c331e4e1b83e9efdb0","user":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"repo":{"id":55454453,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQ1NDQ1Mw==","name":"amphtml","full_name":"zhouyx/amphtml","private":false,"owner":{"login":"zhouyx","id":5419904,"node_id":"MDQ6VXNlcjU0MTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhouyx/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":true,"url":"https://api.github.com/repos/zhouyx/amphtml","forks_url":"https://api.github.com/repos/zhouyx/amphtml/forks","keys_url":"https://api.github.com/repos/zhouyx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhouyx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhouyx/amphtml/teams","hooks_url":"https://api.github.com/repos/zhouyx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/zhouyx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/zhouyx/amphtml/events","assignees_url":"https://api.github.com/repos/zhouyx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/zhouyx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/zhouyx/amphtml/tags","blobs_url":"https://api.github.com/repos/zhouyx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhouyx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhouyx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhouyx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhouyx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/zhouyx/amphtml/languages","stargazers_url":"https://api.github.com/repos/zhouyx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/zhouyx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/zhouyx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/zhouyx/amphtml/subscription","commits_url":"https://api.github.com/repos/zhouyx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhouyx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhouyx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhouyx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhouyx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/zhouyx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhouyx/amphtml/merges","archive_url":"https://api.github.com/repos/zhouyx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhouyx/amphtml/downloads","issues_url":"https://api.github.com/repos/zhouyx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/zhouyx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/zhouyx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/zhouyx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhouyx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/zhouyx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/zhouyx/amphtml/deployments","created_at":"2016-04-05T00:10:42Z","updated_at":"2018-12-21T21:49:59Z","pushed_at":"2018-12-21T21:52:43Z","git_url":"git://github.com/zhouyx/amphtml.git","ssh_url":"git@github.com:zhouyx/amphtml.git","clone_url":"https://github.com/zhouyx/amphtml.git","svn_url":"https://github.com/zhouyx/amphtml","homepage":"https://ampproject.org","size":567273,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"871fd5682870e0eab2e48b3da1c33896839281b0","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation. See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-12-21T21:53:01Z","pushed_at":"2018-12-21T21:52:53Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":566989,"stargazers_count":12249,"watchers_count":12249,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2745,"mirror_url":null,"archived":false,"open_issues_count":1584,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2745,"open_issues":1584,"watchers":12249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19987"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19987"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19987"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19987/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19987/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19987/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/94a92daad98e1469015367c331e4e1b83e9efdb0"}},"author_association":"COLLABORATOR"}} | {
"id": 41766002,
"name": "ampproject/amphtml",
"url": "https://api.github.com/repos/ampproject/amphtml"
} | {
"id": 5419904,
"login": "zhouyx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5419904?",
"url": "https://api.github.com/users/zhouyx"
} | {
"id": 14114390,
"login": "ampproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14114390?",
"url": "https://api.github.com/orgs/ampproject"
} | 2018-12-21T21:54:43 | 8793865458 | {"actor":{"display_login":"zhouyx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/comments/168183194","pull_request_review_id":96504198,"id":168183194,"diff_hunk":"@@ -265,15 +271,27 @@ object AuditTaskTable {\n auditTasks.filter(_.userId === userId.toString).list.lastOption\n }\n \n+ /**\n+ * Returns a true if the user has a completed audit task for the given street edge, false otherwise.\n+ *\n+ * @param streetEdgeId\n+ * @param user\n+ * @return\n+ */\n+ def userHasAuditedStreet(streetEdgeId: Int, user: UUID): Boolean = db.withSession { implicit session =>\n+ completedTasks.filter(task => task.streetEdgeId === streetEdgeId && task.userId === user.toString).list.nonEmpty\n+ }\n+\n /**\n * Return audited street edges\n *\n * @return\n */\n def selectStreetsAudited: List[StreetEdge] = db.withSession { implicit session =>\n- val _streetEdges = (for {","path":"app/models/audit/AuditTaskTable.scala","position":82,"original_position":82,"commit_id":"e3fdfa662f725153bf948354d0d0e5b536e57cf0","original_commit_id":"e3fdfa662f725153bf948354d0d0e5b536e57cf0","user":{"login":"misaugstad","id":6518824,"avatar_url":"https://avatars2.githubusercontent.com/u/6518824?v=4","gravatar_id":"","url":"https://api.github.com/users/misaugstad","html_url":"https://github.com/misaugstad","followers_url":"https://api.github.com/users/misaugstad/followers","following_url":"https://api.github.com/users/misaugstad/following{/other_user}","gists_url":"https://api.github.com/users/misaugstad/gists{/gist_id}","starred_url":"https://api.github.com/users/misaugstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misaugstad/subscriptions","organizations_url":"https://api.github.com/users/misaugstad/orgs","repos_url":"https://api.github.com/users/misaugstad/repos","events_url":"https://api.github.com/users/misaugstad/events{/privacy}","received_events_url":"https://api.github.com/users/misaugstad/received_events","type":"User","site_admin":false},"body":"Cosmetic change, just using a value defined at the top of this file.","created_at":"2018-02-14T14:06:43Z","updated_at":"2018-02-14T14:57:54Z","html_url":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212#discussion_r168183194","pull_request_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/comments/168183194"},"html":{"href":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212#discussion_r168183194"},"pull_request":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212"}}},"pull_request":{"url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212","id":169001503,"html_url":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212","diff_url":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212.diff","patch_url":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212.patch","issue_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/1212","number":1212,"state":"open","locked":false,"title":"1207 full priority based routing","user":{"login":"misaugstad","id":6518824,"avatar_url":"https://avatars2.githubusercontent.com/u/6518824?v=4","gravatar_id":"","url":"https://api.github.com/users/misaugstad","html_url":"https://github.com/misaugstad","followers_url":"https://api.github.com/users/misaugstad/followers","following_url":"https://api.github.com/users/misaugstad/following{/other_user}","gists_url":"https://api.github.com/users/misaugstad/gists{/gist_id}","starred_url":"https://api.github.com/users/misaugstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misaugstad/subscriptions","organizations_url":"https://api.github.com/users/misaugstad/orgs","repos_url":"https://api.github.com/users/misaugstad/repos","events_url":"https://api.github.com/users/misaugstad/events{/privacy}","received_events_url":"https://api.github.com/users/misaugstad/received_events","type":"User","site_admin":false},"body":"#### What this PR does\r\n* Updates the front-end routing to be entirely based on priority\r\n* Rewrites the task selection code in AuditTaskTable.scala to assign tasks based on priority instead of completion count. This is the most annoying part to test, because there are something like 6 different cases to test for.\r\n* Removes a few large-ish chunks of code that we are no longer using, and I don't see a reason to keep - let me know if you disagree with any of those choices :)\r\n* Generally cleaned up any code I saw that needed some cleaning... So I removed a bunch of unused import statements (which is why the PR has 11 modified files), fixed misspellings, renamed variable, made some minor changes to syntax to make things more readable/consistent, etc. I'm going to go through the PR and add comments next to anything that is essentially just cosmetic, and I don't think requires testing.\r\n\r\n#### Description of how new priority-based routing works\r\nThis PR primarily fleshes out the priority based routing that @maddalihanumateja had started working on for the front-end. Users are now always routed to a street that has roughly the same priority level as the highest priority street in the region in which they are auditing. To do this, I discretized the priority (which goes from 0 to 1) into 4 levels; [0,0.25), [0.25,0.5), [0.5,0.75), [0.75,1].\r\n\r\nSince our priority system is currently just based on audit count, where priority = 1/(1+audit_count), for audit counts 0, 1, 2, 3, 4, 5, ...; we have priority 1, 0.5, 0.33, 0.25, 0.2, 0.17, ...; this maps into priority levels 3, 2, 1, 1, 0, 0, ... Thus, within a given region, all streets with audit count = 0 will be audited, followed by those with audit count = 1, then those with audit count _either_ 2 _or_ 3, followed by anything else.\r\n\r\nThe way this works in practice is analogous to how we had talked about routing based on audit count beforehand, @manaswis. Example: If the entire region has been audited completely twice over, then when a user finishes a street, they will only jump if _none_ of the adjacent streets have an audit count of 2 or 3 (i.e., a street with region-wide maximum discretized priority). If the user does not have to jump, we take the highest priority adjacent street. If they do jump, we take the highest priority street in the entire region.\r\n\r\n#### How to test\r\n1. For the changes to the functions in AuditTaskTable.scala: I would go to each function that has been rewritten, add a print statement of some sort (to verify that this code was actually run when you try to test it), add in whatever print statements or whatever else you need to assure yourself that it is correct. Each one is sort of different, and I think you should just do whatever you need to feel good about its correctness.\r\n\r\n I made the comment above each of these functions more descriptive, so it now tells you when the code should be called, hopefully making testing easier. For example, I changed one description from \"Get a task that is in a given region.\" to \"Get a task that is in a given region. Used if a user has already been assigned a region, or from /audit/region.\"\r\n\r\n2. For the priority-based routing code: I added some console logging statements to help guide you with this. For example, when a user finishes a street, I log the highest priority task in the region, the list of adjacent streets, then the list of adjacent streets after filtering out the ones with priority that is too low. You should go through and make sure the behavior seems correct, in the you get routed down streets with appropriate priority, you are only forced to jump when the priority of adjacent streets is too low, when you do jump you should be sent to a high-priority street, etc.\r\n\r\n In the console, I found the following functions of the Tasks to be useful: isCompleted(), getStreetEdgeId(), getStreetPriority(), getStreetPriorityDiscretized(), getStreetCompletionCount().\r\n\r\n\r\nLet me know if I can clarify anything. Thanks!\r\n\r\nResolves #1207 ","created_at":"2018-02-14T01:29:25Z","updated_at":"2018-02-14T14:57:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9157cf728c3d8a6233bc6a5206861d1843868b3","assignee":{"login":"manaswis","id":2873216,"avatar_url":"https://avatars0.githubusercontent.com/u/2873216?v=4","gravatar_id":"","url":"https://api.github.com/users/manaswis","html_url":"https://github.com/manaswis","followers_url":"https://api.github.com/users/manaswis/followers","following_url":"https://api.github.com/users/manaswis/following{/other_user}","gists_url":"https://api.github.com/users/manaswis/gists{/gist_id}","starred_url":"https://api.github.com/users/manaswis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manaswis/subscriptions","organizations_url":"https://api.github.com/users/manaswis/orgs","repos_url":"https://api.github.com/users/manaswis/repos","events_url":"https://api.github.com/users/manaswis/events{/privacy}","received_events_url":"https://api.github.com/users/manaswis/received_events","type":"User","site_admin":false},"assignees":[{"login":"manaswis","id":2873216,"avatar_url":"https://avatars0.githubusercontent.com/u/2873216?v=4","gravatar_id":"","url":"https://api.github.com/users/manaswis","html_url":"https://github.com/manaswis","followers_url":"https://api.github.com/users/manaswis/followers","following_url":"https://api.github.com/users/manaswis/following{/other_user}","gists_url":"https://api.github.com/users/manaswis/gists{/gist_id}","starred_url":"https://api.github.com/users/manaswis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manaswis/subscriptions","organizations_url":"https://api.github.com/users/manaswis/orgs","repos_url":"https://api.github.com/users/manaswis/repos","events_url":"https://api.github.com/users/manaswis/events{/privacy}","received_events_url":"https://api.github.com/users/manaswis/received_events","type":"User","site_admin":false},{"login":"misaugstad","id":6518824,"avatar_url":"https://avatars2.githubusercontent.com/u/6518824?v=4","gravatar_id":"","url":"https://api.github.com/users/misaugstad","html_url":"https://github.com/misaugstad","followers_url":"https://api.github.com/users/misaugstad/followers","following_url":"https://api.github.com/users/misaugstad/following{/other_user}","gists_url":"https://api.github.com/users/misaugstad/gists{/gist_id}","starred_url":"https://api.github.com/users/misaugstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misaugstad/subscriptions","organizations_url":"https://api.github.com/users/misaugstad/orgs","repos_url":"https://api.github.com/users/misaugstad/repos","events_url":"https://api.github.com/users/misaugstad/events{/privacy}","received_events_url":"https://api.github.com/users/misaugstad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463349498,"url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/labels/pull-request-submitted","name":"pull-request-submitted","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212/commits","review_comments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212/comments","review_comment_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/1212/comments","statuses_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/statuses/e3fdfa662f725153bf948354d0d0e5b536e57cf0","head":{"label":"ProjectSidewalk:1207-full-priority-based-routing","ref":"1207-full-priority-based-routing","sha":"e3fdfa662f725153bf948354d0d0e5b536e57cf0","user":{"login":"ProjectSidewalk","id":14115044,"avatar_url":"https://avatars2.githubusercontent.com/u/14115044?v=4","gravatar_id":"","url":"https://api.github.com/users/ProjectSidewalk","html_url":"https://github.com/ProjectSidewalk","followers_url":"https://api.github.com/users/ProjectSidewalk/followers","following_url":"https://api.github.com/users/ProjectSidewalk/following{/other_user}","gists_url":"https://api.github.com/users/ProjectSidewalk/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectSidewalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectSidewalk/subscriptions","organizations_url":"https://api.github.com/users/ProjectSidewalk/orgs","repos_url":"https://api.github.com/users/ProjectSidewalk/repos","events_url":"https://api.github.com/users/ProjectSidewalk/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectSidewalk/received_events","type":"Organization","site_admin":false},"repo":{"id":39593035,"name":"SidewalkWebpage","full_name":"ProjectSidewalk/SidewalkWebpage","owner":{"login":"ProjectSidewalk","id":14115044,"avatar_url":"https://avatars2.githubusercontent.com/u/14115044?v=4","gravatar_id":"","url":"https://api.github.com/users/ProjectSidewalk","html_url":"https://github.com/ProjectSidewalk","followers_url":"https://api.github.com/users/ProjectSidewalk/followers","following_url":"https://api.github.com/users/ProjectSidewalk/following{/other_user}","gists_url":"https://api.github.com/users/ProjectSidewalk/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectSidewalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectSidewalk/subscriptions","organizations_url":"https://api.github.com/users/ProjectSidewalk/orgs","repos_url":"https://api.github.com/users/ProjectSidewalk/repos","events_url":"https://api.github.com/users/ProjectSidewalk/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectSidewalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProjectSidewalk/SidewalkWebpage","description":"Project Sidewalk web page","fork":false,"url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage","forks_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/forks","keys_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/teams","hooks_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/hooks","issue_events_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/events{/number}","events_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/events","assignees_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/assignees{/user}","branches_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/branches{/branch}","tags_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/tags","blobs_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/statuses/{sha}","languages_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/languages","stargazers_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/stargazers","contributors_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/contributors","subscribers_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/subscribers","subscription_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/subscription","commits_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/contents/{+path}","compare_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/merges","archive_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/downloads","issues_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues{/number}","pulls_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls{/number}","milestones_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/milestones{/number}","notifications_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/labels{/name}","releases_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/releases{/id}","deployments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/deployments","created_at":"2015-07-23T21:09:48Z","updated_at":"2018-02-07T16:43:19Z","pushed_at":"2018-02-14T01:29:26Z","git_url":"git://github.com/ProjectSidewalk/SidewalkWebpage.git","ssh_url":"git@github.com:ProjectSidewalk/SidewalkWebpage.git","clone_url":"https://github.com/ProjectSidewalk/SidewalkWebpage.git","svn_url":"https://github.com/ProjectSidewalk/SidewalkWebpage","homepage":"http://projectsidewalk.io","size":238014,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":315,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":315,"watchers":24,"default_branch":"master"}},"base":{"label":"ProjectSidewalk:develop","ref":"develop","sha":"4f3ca99cb6a762ff2e9889ab412b2cc9c4639031","user":{"login":"ProjectSidewalk","id":14115044,"avatar_url":"https://avatars2.githubusercontent.com/u/14115044?v=4","gravatar_id":"","url":"https://api.github.com/users/ProjectSidewalk","html_url":"https://github.com/ProjectSidewalk","followers_url":"https://api.github.com/users/ProjectSidewalk/followers","following_url":"https://api.github.com/users/ProjectSidewalk/following{/other_user}","gists_url":"https://api.github.com/users/ProjectSidewalk/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectSidewalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectSidewalk/subscriptions","organizations_url":"https://api.github.com/users/ProjectSidewalk/orgs","repos_url":"https://api.github.com/users/ProjectSidewalk/repos","events_url":"https://api.github.com/users/ProjectSidewalk/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectSidewalk/received_events","type":"Organization","site_admin":false},"repo":{"id":39593035,"name":"SidewalkWebpage","full_name":"ProjectSidewalk/SidewalkWebpage","owner":{"login":"ProjectSidewalk","id":14115044,"avatar_url":"https://avatars2.githubusercontent.com/u/14115044?v=4","gravatar_id":"","url":"https://api.github.com/users/ProjectSidewalk","html_url":"https://github.com/ProjectSidewalk","followers_url":"https://api.github.com/users/ProjectSidewalk/followers","following_url":"https://api.github.com/users/ProjectSidewalk/following{/other_user}","gists_url":"https://api.github.com/users/ProjectSidewalk/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectSidewalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectSidewalk/subscriptions","organizations_url":"https://api.github.com/users/ProjectSidewalk/orgs","repos_url":"https://api.github.com/users/ProjectSidewalk/repos","events_url":"https://api.github.com/users/ProjectSidewalk/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectSidewalk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProjectSidewalk/SidewalkWebpage","description":"Project Sidewalk web page","fork":false,"url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage","forks_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/forks","keys_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/teams","hooks_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/hooks","issue_events_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/events{/number}","events_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/events","assignees_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/assignees{/user}","branches_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/branches{/branch}","tags_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/tags","blobs_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/statuses/{sha}","languages_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/languages","stargazers_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/stargazers","contributors_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/contributors","subscribers_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/subscribers","subscription_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/subscription","commits_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/contents/{+path}","compare_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/merges","archive_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/downloads","issues_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues{/number}","pulls_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls{/number}","milestones_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/milestones{/number}","notifications_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/labels{/name}","releases_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/releases{/id}","deployments_url":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/deployments","created_at":"2015-07-23T21:09:48Z","updated_at":"2018-02-07T16:43:19Z","pushed_at":"2018-02-14T01:29:26Z","git_url":"git://github.com/ProjectSidewalk/SidewalkWebpage.git","ssh_url":"git@github.com:ProjectSidewalk/SidewalkWebpage.git","clone_url":"https://github.com/ProjectSidewalk/SidewalkWebpage.git","svn_url":"https://github.com/ProjectSidewalk/SidewalkWebpage","homepage":"http://projectsidewalk.io","size":238014,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":315,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":315,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212"},"html":{"href":"https://github.com/ProjectSidewalk/SidewalkWebpage/pull/1212"},"issue":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/1212"},"comments":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/issues/1212/comments"},"review_comments":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212/comments"},"review_comment":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/pulls/1212/commits"},"statuses":{"href":"https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage/statuses/e3fdfa662f725153bf948354d0d0e5b536e57cf0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 39593035,
"name": "ProjectSidewalk/SidewalkWebpage",
"url": "https://api.github.com/repos/ProjectSidewalk/SidewalkWebpage"
} | {
"id": 6518824,
"login": "misaugstad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6518824?",
"url": "https://api.github.com/users/misaugstad"
} | {
"id": 14115044,
"login": "ProjectSidewalk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14115044?",
"url": "https://api.github.com/orgs/ProjectSidewalk"
} | 2018-02-14T14:06:43 | 7244375638 | {"actor":{"display_login":"misaugstad"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/comments/165999974","pull_request_review_id":94011112,"id":165999974,"diff_hunk":"@@ -0,0 +1,87 @@\n+using Autofac;\n+using Common;\n+using Common.Log;\n+using Lykke.RabbitMqBroker;\n+using Lykke.RabbitMqBroker.Subscriber;\n+using Lykke.Service.ExchangeDataStore.Core.Domain.Events;\n+using Lykke.Service.ExchangeDataStore.Core.Domain.OrderBooks;\n+using Lykke.Service.ExchangeDataStore.Core.Settings.ServiceSettings;\n+using Lykke.Service.ExchangeDataStore.Services.Helpers;\n+using System.Threading.Tasks;\n+\n+// ReSharper disable MemberCanBePrivate.Global - AsyncEvent must be public\n+\n+namespace Lykke.Service.ExchangeDataStore.Services.DataHarvesters\n+{\n+ // ReSharper disable once ClassNeverInstantiated.Global - autofac instantiated\n+ public class OrderbookDataHarvester : IStartable, IStopable\n+ {\n+ private readonly ILog _log;\n+ private RabbitMqSubscriber<OrderBook> _rabbit;\n+ private readonly bool _enabled;\n+ private readonly RabbitMqExchangeConfiguration _orderBookQueueConfig;\n+ private string Component = nameof(OrderbookDataHarvester);\n+\n+ public static AsyncEvent<OrderBook> OrderBookReceived = null;\n+\n+ protected virtual Task OnOrderBookReceived(OrderBook orderBook)\n+ {\n+ return OrderBookReceived.NullableInvokeAsync(this, orderBook);\n+ }\n+\n+ public OrderbookDataHarvester(ILog log, RabbitMqExchangeConfiguration orderBookQueueConfig)\n+ {\n+ _log = log;\n+ _enabled = orderBookQueueConfig.Enabled;\n+ _orderBookQueueConfig = orderBookQueueConfig;\n+ SubsribeToMessageQueue();\n+ }\n+\n+ private void SubsribeToMessageQueue()\n+ {\n+ var rabbitSettings = new RabbitMqSubscriptionSettings\n+ {\n+ ConnectionString = _orderBookQueueConfig.ConnectionString,\n+ ExchangeName = _orderBookQueueConfig.Exchange,\n+ QueueName = _orderBookQueueConfig.Queue\n+ };\n+ var errorStrategy = new DefaultErrorHandlingStrategy(_log, rabbitSettings);\n+ _rabbit = new RabbitMqSubscriber<OrderBook>(rabbitSettings, errorStrategy)\n+ .SetMessageDeserializer(new GenericRabbitModelConverter<OrderBook>())\n+ .SetMessageReadStrategy(new MessageReadWithTemporaryQueueStrategy())","path":"src/Lykke.Service.ExchangeDataStore/Lykke.Service.ExchangeDataStore.Services/DataHarvesters/OrderbookDataHarvester.cs","position":51,"original_position":51,"commit_id":"2ff2b25e3c8721b72b952ae5519ba99903fe3c3c","original_commit_id":"2ff2b25e3c8721b72b952ae5519ba99903fe3c3c","user":{"login":"MikhailGerasimov","id":30234290,"avatar_url":"https://avatars3.githubusercontent.com/u/30234290?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailGerasimov","html_url":"https://github.com/MikhailGerasimov","followers_url":"https://api.github.com/users/MikhailGerasimov/followers","following_url":"https://api.github.com/users/MikhailGerasimov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailGerasimov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailGerasimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailGerasimov/subscriptions","organizations_url":"https://api.github.com/users/MikhailGerasimov/orgs","repos_url":"https://api.github.com/users/MikhailGerasimov/repos","events_url":"https://api.github.com/users/MikhailGerasimov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailGerasimov/received_events","type":"User","site_admin":false},"body":"Not sure that here should be a *Temporary* queue","created_at":"2018-02-05T15:12:08Z","updated_at":"2018-02-05T15:36:28Z","html_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29#discussion_r165999974","pull_request_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/comments/165999974"},"html":{"href":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29#discussion_r165999974"},"pull_request":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29","id":167101963,"html_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29","diff_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29.diff","patch_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29.patch","issue_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/29","number":29,"state":"open","locked":false,"title":"Feature lewdev 5341 move saving order book in own project","user":{"login":"filip-prime","id":31731644,"avatar_url":"https://avatars2.githubusercontent.com/u/31731644?v=4","gravatar_id":"","url":"https://api.github.com/users/filip-prime","html_url":"https://github.com/filip-prime","followers_url":"https://api.github.com/users/filip-prime/followers","following_url":"https://api.github.com/users/filip-prime/following{/other_user}","gists_url":"https://api.github.com/users/filip-prime/gists{/gist_id}","starred_url":"https://api.github.com/users/filip-prime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filip-prime/subscriptions","organizations_url":"https://api.github.com/users/filip-prime/orgs","repos_url":"https://api.github.com/users/filip-prime/repos","events_url":"https://api.github.com/users/filip-prime/events{/privacy}","received_events_url":"https://api.github.com/users/filip-prime/received_events","type":"User","site_admin":false},"body":"Added new solution folder with projects for new service - Lykke.Service.ExchangeConnector.DataStore.\r\nName can be changed if not good - suggestions are welcome.\r\nThe new project follows Lykke's template service structure. It is meant to be started separatly - for my tests have been starting it through VS - start multiple projects. Not sure how it would be started once deployed on dev though - I can set it to be started by the main project (Lykke.Service.ExchangeConnector) if thats needed. **_Update_** - I think I would either have to make Lykke.Service.ExchangeConnector.DataStore to be run and executed in the context of Lykke.Service.ExchangeConnector or have the entire Lykke.Service.ExchangeConnector.DataStore moved to its own solution with separate config, build etc. They way it is implemented at the moment (with its own Program.cs) seems difficult or impossible to sun outside of VS (via run multiple projects). \r\n\r\n**Please, note** I needed to extend the timestamp format by 'which the orderbook snapshots are saved in DB - **adding an extra two 'ff' to the milliseconds part** - i.e. yyyyMMddTHHmmss.fff**ff**. That was needed because I was getting multiple snapshots from the queue with the same timestamp - with unique data on them, so I need to save all of them to ensure no data gets lost - having five fffff is enough to differentiate the snapshots, and save them without overriding one another in azure. Having just three f's was not enough - timestamp up to the 3rd millisecond digit is the same.\r\n\r\nAs far as the service itself:\r\n\r\nAdded OrderbookDataPersister - save orderbooks to Azure. OrderbookDataPersister subscribes to OrderbookDataHarvester.OrderBookReceived event for getting new orderbooks. OrderbookDataHarvester in turn is subscribed to RabbitMQ and raises an OrderBookReceived event each time new order book is received.\r\n","created_at":"2018-02-05T10:07:26Z","updated_at":"2018-02-05T15:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06014de74c28457db81e67ca21fe968d7060d4c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29/commits","review_comments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29/comments","review_comment_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/29/comments","statuses_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/statuses/2ff2b25e3c8721b72b952ae5519ba99903fe3c3c","head":{"label":"LykkeCity:feature_LEWDEV-5341_MoveSavingOrderBookInOwnProject","ref":"feature_LEWDEV-5341_MoveSavingOrderBookInOwnProject","sha":"2ff2b25e3c8721b72b952ae5519ba99903fe3c3c","user":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":90874307,"name":"Lykke.Service.ExchangeConnector","full_name":"LykkeCity/Lykke.Service.ExchangeConnector","owner":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector","description":null,"fork":false,"url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector","forks_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/forks","keys_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/teams","hooks_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/events","assignees_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/tags","blobs_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/subscription","commits_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/merges","archive_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/downloads","issues_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/deployments","created_at":"2017-05-10T14:35:30Z","updated_at":"2017-10-26T09:31:37Z","pushed_at":"2018-02-05T10:07:26Z","git_url":"git://github.com/LykkeCity/Lykke.Service.ExchangeConnector.git","ssh_url":"git@github.com:LykkeCity/Lykke.Service.ExchangeConnector.git","clone_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector.git","svn_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector","homepage":null,"size":2628,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"LykkeCity:develop","ref":"develop","sha":"6b6135743d1c59fb73a439707fa83b9fc6ae94c0","user":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":90874307,"name":"Lykke.Service.ExchangeConnector","full_name":"LykkeCity/Lykke.Service.ExchangeConnector","owner":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector","description":null,"fork":false,"url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector","forks_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/forks","keys_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/teams","hooks_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/events","assignees_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/tags","blobs_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/subscription","commits_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/merges","archive_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/downloads","issues_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/deployments","created_at":"2017-05-10T14:35:30Z","updated_at":"2017-10-26T09:31:37Z","pushed_at":"2018-02-05T10:07:26Z","git_url":"git://github.com/LykkeCity/Lykke.Service.ExchangeConnector.git","ssh_url":"git@github.com:LykkeCity/Lykke.Service.ExchangeConnector.git","clone_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector.git","svn_url":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector","homepage":null,"size":2628,"stargazers_count":14,"watchers_count":14,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29"},"html":{"href":"https://github.com/LykkeCity/Lykke.Service.ExchangeConnector/pull/29"},"issue":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/29"},"comments":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector/statuses/2ff2b25e3c8721b72b952ae5519ba99903fe3c3c"}},"author_association":"COLLABORATOR"}} | {
"id": 90874307,
"name": "LykkeCity/Lykke.Service.ExchangeConnector",
"url": "https://api.github.com/repos/LykkeCity/Lykke.Service.ExchangeConnector"
} | {
"id": 30234290,
"login": "MikhailGerasimov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30234290?",
"url": "https://api.github.com/users/MikhailGerasimov"
} | {
"id": 14153330,
"login": "LykkeCity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14153330?",
"url": "https://api.github.com/orgs/LykkeCity"
} | 2018-02-05T15:12:08 | 7199313071 | {"actor":{"display_login":"MikhailGerasimov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/comments/208387960","pull_request_review_id":144187873,"id":208387960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM4Nzk2MA==","diff_hunk":"@@ -217,43 +223,76 @@ private static string CheckProperty<T>(PropertyInfo property, T model)\n break;\n }\n \n- foreach (string val in valuesToCheck)\n- {\n- if (string.IsNullOrWhiteSpace(val))\n- {\n- var optionalAttribute = property.GetCustomAttribute(typeof(OptionalAttribute));\n- if (optionalAttribute == null)\n- throw new CheckFieldException(property.Name, val, \"Empty setting value\");\n- continue;\n- }\n+ tasks = valuesToCheck.Select(val => DoCheck(model, property, checker, val)).ToList();\n \n- var checkResult = checker.CheckField(model, property.Name, val);\n- Console.WriteLine(checkResult.Description);\n- if (!checkResult.Result && checkResult.ThrowExceptionOnFail)\n- return checkResult.Description;\n- }\n+ errorMessages = (await Task.WhenAll(tasks))\n+ .Where(item => !string.IsNullOrEmpty(item))\n+ .ToList();\n+\n+ return errorMessages.Count == 0 ? null : string.Join(Environment.NewLine, errorMessages);\n }\n- else if (property.CanWrite)\n+\n+ if (!property.CanWrite) \n+ return null;\n+ \n+ object[] values = GetValuesToCheck(property, model);\n+\n+ tasks = values.Select(ProcessChecks).ToList();\n+\n+ errorMessages = (await Task.WhenAll(tasks))\n+ .Where(item => !string.IsNullOrEmpty(item))\n+ .ToList();\n+ \n+ return errorMessages.Count == 0 ? null : string.Join(Environment.NewLine, errorMessages);\n+ }\n+\n+ private static async Task<string> DoCheck<T>(T model, PropertyInfo property, ISettingsFieldChecker checker, string val)\n+ {\n+ if (string.IsNullOrWhiteSpace(val))\n {\n- object[] values = GetValuesToCheck(property, model);\n- var errorMessages = new List<string>();\n- Parallel.ForEach(values, val =>\n- {\n- string errorMessage = ProcessChecks(val);\n- if (errorMessage == null)\n- return;\n+ var optionalAttribute = property.GetCustomAttribute(typeof(OptionalAttribute));\n+ \n+ if (optionalAttribute == null)\n+ throw new CheckFieldException(property.Name, val, \"Empty setting value\");\n+ \n+ return null;\n+ }\n \n- lock (errorMessages)\n- {\n- errorMessages.Add(errorMessage);\n- }\n- });\n+ int retryCount = 0;\n+ CheckFieldResult checkResult;\n \n- return errorMessages.Count == 0 ? null : string.Join(Environment.NewLine, errorMessages);\n+ do\n+ {\n+ if (retryCount > 0)\n+ Thread.Sleep(100);","path":"src/Lykke.SettingsReader/SettingsProcessor/SettingsProcessor.cs","position":275,"original_position":275,"commit_id":"7898287875654a51c15137ed63c28a8c4a21bb8c","original_commit_id":"7898287875654a51c15137ed63c28a8c4a21bb8c","user":{"login":"MikhailGerasimov","id":30234290,"node_id":"MDQ6VXNlcjMwMjM0Mjkw","avatar_url":"https://avatars3.githubusercontent.com/u/30234290?v=4","gravatar_id":"","url":"https://api.github.com/users/MikhailGerasimov","html_url":"https://github.com/MikhailGerasimov","followers_url":"https://api.github.com/users/MikhailGerasimov/followers","following_url":"https://api.github.com/users/MikhailGerasimov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailGerasimov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailGerasimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailGerasimov/subscriptions","organizations_url":"https://api.github.com/users/MikhailGerasimov/orgs","repos_url":"https://api.github.com/users/MikhailGerasimov/repos","events_url":"https://api.github.com/users/MikhailGerasimov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailGerasimov/received_events","type":"User","site_admin":false},"body":"If it is an async method use Task.Delay()","created_at":"2018-08-07T21:15:38Z","updated_at":"2018-08-07T21:17:52Z","html_url":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34#discussion_r208387960","pull_request_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/comments/208387960"},"html":{"href":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34#discussion_r208387960"},"pull_request":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34","id":206742650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NzQyNjUw","html_url":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34","diff_url":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34.diff","patch_url":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34.patch","issue_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/34","number":34,"state":"open","locked":false,"title":"Moved checks to a separate method","user":{"login":"samodovdi","id":4929842,"node_id":"MDQ6VXNlcjQ5Mjk4NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4929842?v=4","gravatar_id":"","url":"https://api.github.com/users/samodovdi","html_url":"https://github.com/samodovdi","followers_url":"https://api.github.com/users/samodovdi/followers","following_url":"https://api.github.com/users/samodovdi/following{/other_user}","gists_url":"https://api.github.com/users/samodovdi/gists{/gist_id}","starred_url":"https://api.github.com/users/samodovdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samodovdi/subscriptions","organizations_url":"https://api.github.com/users/samodovdi/orgs","repos_url":"https://api.github.com/users/samodovdi/repos","events_url":"https://api.github.com/users/samodovdi/events{/privacy}","received_events_url":"https://api.github.com/users/samodovdi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-07T15:42:06Z","updated_at":"2018-08-07T21:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e9df6e538bc1ddfd43b85b30b3b02ba36936330","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34/commits","review_comments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34/comments","review_comment_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/34/comments","statuses_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/statuses/7898287875654a51c15137ed63c28a8c4a21bb8c","head":{"label":"LykkeCity:checks","ref":"checks","sha":"7898287875654a51c15137ed63c28a8c4a21bb8c","user":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":91567480,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU2NzQ4MA==","name":"LykkeSettingsParser","full_name":"LykkeCity/LykkeSettingsParser","owner":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/LykkeSettingsParser","description":null,"fork":false,"url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser","forks_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/forks","keys_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/teams","hooks_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/events","assignees_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/tags","blobs_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/subscription","commits_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/merges","archive_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/downloads","issues_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/deployments","created_at":"2017-05-17T11:10:39Z","updated_at":"2018-06-30T08:25:23Z","pushed_at":"2018-08-07T15:45:24Z","git_url":"git://github.com/LykkeCity/LykkeSettingsParser.git","ssh_url":"git@github.com:LykkeCity/LykkeSettingsParser.git","clone_url":"https://github.com/LykkeCity/LykkeSettingsParser.git","svn_url":"https://github.com/LykkeCity/LykkeSettingsParser","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"LykkeCity:master","ref":"master","sha":"17ff519a3d612c50661ae471bfc6b304d3582276","user":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":91567480,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU2NzQ4MA==","name":"LykkeSettingsParser","full_name":"LykkeCity/LykkeSettingsParser","owner":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/LykkeSettingsParser","description":null,"fork":false,"url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser","forks_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/forks","keys_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/teams","hooks_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/events","assignees_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/tags","blobs_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/subscription","commits_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/merges","archive_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/downloads","issues_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/deployments","created_at":"2017-05-17T11:10:39Z","updated_at":"2018-06-30T08:25:23Z","pushed_at":"2018-08-07T15:45:24Z","git_url":"git://github.com/LykkeCity/LykkeSettingsParser.git","ssh_url":"git@github.com:LykkeCity/LykkeSettingsParser.git","clone_url":"https://github.com/LykkeCity/LykkeSettingsParser.git","svn_url":"https://github.com/LykkeCity/LykkeSettingsParser","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34"},"html":{"href":"https://github.com/LykkeCity/LykkeSettingsParser/pull/34"},"issue":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/34"},"comments":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/LykkeCity/LykkeSettingsParser/statuses/7898287875654a51c15137ed63c28a8c4a21bb8c"}},"author_association":"MEMBER"}} | {
"id": 91567480,
"name": "LykkeCity/LykkeSettingsParser",
"url": "https://api.github.com/repos/LykkeCity/LykkeSettingsParser"
} | {
"id": 30234290,
"login": "MikhailGerasimov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30234290?",
"url": "https://api.github.com/users/MikhailGerasimov"
} | {
"id": 14153330,
"login": "LykkeCity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14153330?",
"url": "https://api.github.com/orgs/LykkeCity"
} | 2018-08-07T21:15:38 | 8080285543 | {"actor":{"display_login":"MikhailGerasimov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/comments/242487535","pull_request_review_id":186006298,"id":242487535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ4NzUzNQ==","diff_hunk":"@@ -31,26 +32,29 @@ class PerformanceStatsLogger @Autowired constructor(private val monitoringDataba\n \n val totalTime = PrintUtils.convertToString2(typeStats.totalTime.toDouble() / typeStats.count)\n val processingTime = PrintUtils.convertToString2(typeStats.processingTime.toDouble() / typeStats.count)\n- val persistTime = PrintUtils.convertToString2(typeStats.persistTime.toDouble() / typeStats.persistTimeCount)\n- LOGGER.info(\"$type: count: ${typeStats.count}, \" +\n+ val persistTime = PrintUtils.convertToString2(typeStats.persistTime.toDouble() / typeStats.persistsCount)\n+ val writeResponseTime = PrintUtils.convertToString2(typeStats.writeResponseTime.toDouble() / typeStats.writeResponseCount)\n+ LOGGER.info(\"App version: ${AppVersion.VERSION}, $type: count: ${typeStats.count}, \" +\n (inputQueueTime?.let { \"input queue time: $it, \" } ?: \"\") +\n (preProcessingTime?.let { \"pre processing time: $it, \" } ?: \"\") +\n \"pre processed message queue time: $preProcessedMessageQueueTime, \" +\n \"processing time: $processingTime \" +\n- \"(persist time: $persistTime), \" +\n- \"persist count: ${typeStats.persistTimeCount}, \" +\n+ \"(persist time: $persistTime, write response time: $writeResponseTime), \" +\n+ \"persist count: ${typeStats.persistsCount}, \" +\n \"total time: $totalTime\")\n \n monitoringDatabaseAccessor.savePerformanceStats(TypePerformanceStats(now,\n type,\n+ AppVersion.VERSION,","path":"src/main/kotlin/com/lykke/matching/engine/performance/PerformanceStatsLogger.kt","position":29,"original_position":29,"commit_id":"df2851a965e777999fc9588452b166a83793a8d9","original_commit_id":"df2851a965e777999fc9588452b166a83793a8d9","user":{"login":"rocketmannot","id":2168075,"node_id":"MDQ6VXNlcjIxNjgwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2168075?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketmannot","html_url":"https://github.com/rocketmannot","followers_url":"https://api.github.com/users/rocketmannot/followers","following_url":"https://api.github.com/users/rocketmannot/following{/other_user}","gists_url":"https://api.github.com/users/rocketmannot/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketmannot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketmannot/subscriptions","organizations_url":"https://api.github.com/users/rocketmannot/orgs","repos_url":"https://api.github.com/users/rocketmannot/repos","events_url":"https://api.github.com/users/rocketmannot/events{/privacy}","received_events_url":"https://api.github.com/users/rocketmannot/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-12-18T10:45:58Z","updated_at":"2018-12-18T10:45:58Z","html_url":"https://github.com/LykkeCity/MatchingEngine/pull/236#discussion_r242487535","pull_request_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/comments/242487535"},"html":{"href":"https://github.com/LykkeCity/MatchingEngine/pull/236#discussion_r242487535"},"pull_request":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236"}},"in_reply_to_id":242444726},"pull_request":{"url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236","id":239104202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTA0MjAy","html_url":"https://github.com/LykkeCity/MatchingEngine/pull/236","diff_url":"https://github.com/LykkeCity/MatchingEngine/pull/236.diff","patch_url":"https://github.com/LykkeCity/MatchingEngine/pull/236.patch","issue_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/236","number":236,"state":"open","locked":false,"title":"LWDEV-10200 Add additional info to performance logs","user":{"login":"rocketmannot","id":2168075,"node_id":"MDQ6VXNlcjIxNjgwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2168075?v=4","gravatar_id":"","url":"https://api.github.com/users/rocketmannot","html_url":"https://github.com/rocketmannot","followers_url":"https://api.github.com/users/rocketmannot/followers","following_url":"https://api.github.com/users/rocketmannot/following{/other_user}","gists_url":"https://api.github.com/users/rocketmannot/gists{/gist_id}","starred_url":"https://api.github.com/users/rocketmannot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocketmannot/subscriptions","organizations_url":"https://api.github.com/users/rocketmannot/orgs","repos_url":"https://api.github.com/users/rocketmannot/repos","events_url":"https://api.github.com/users/rocketmannot/events{/privacy}","received_events_url":"https://api.github.com/users/rocketmannot/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-17T11:02:43Z","updated_at":"2018-12-18T10:45:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1058cc6b2a04642f30b6f97921611866f1144304","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236/commits","review_comments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236/comments","review_comment_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/236/comments","statuses_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/statuses/df2851a965e777999fc9588452b166a83793a8d9","head":{"label":"LykkeCity:LWDEV-10200","ref":"LWDEV-10200","sha":"df2851a965e777999fc9588452b166a83793a8d9","user":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":52304364,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwNDM2NA==","name":"MatchingEngine","full_name":"LykkeCity/MatchingEngine","private":false,"owner":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LykkeCity/MatchingEngine","description":"Matching Engine for spot market","fork":false,"url":"https://api.github.com/repos/LykkeCity/MatchingEngine","forks_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/forks","keys_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/teams","hooks_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/events","assignees_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/tags","blobs_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/subscription","commits_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/merges","archive_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/downloads","issues_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/deployments","created_at":"2016-02-22T20:45:52Z","updated_at":"2018-12-18T03:03:58Z","pushed_at":"2018-12-18T10:41:31Z","git_url":"git://github.com/LykkeCity/MatchingEngine.git","ssh_url":"git@github.com:LykkeCity/MatchingEngine.git","clone_url":"https://github.com/LykkeCity/MatchingEngine.git","svn_url":"https://github.com/LykkeCity/MatchingEngine","homepage":"","size":6075,"stargazers_count":23,"watchers_count":23,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":5,"watchers":23,"default_branch":"master"}},"base":{"label":"LykkeCity:master","ref":"master","sha":"6efb6287f0091fce39e21ea96ed97f48cc14d3f3","user":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":52304364,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwNDM2NA==","name":"MatchingEngine","full_name":"LykkeCity/MatchingEngine","private":false,"owner":{"login":"LykkeCity","id":14153330,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTUzMzMw","avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LykkeCity/MatchingEngine","description":"Matching Engine for spot market","fork":false,"url":"https://api.github.com/repos/LykkeCity/MatchingEngine","forks_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/forks","keys_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/teams","hooks_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/events","assignees_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/tags","blobs_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/subscription","commits_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/merges","archive_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/downloads","issues_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/MatchingEngine/deployments","created_at":"2016-02-22T20:45:52Z","updated_at":"2018-12-18T03:03:58Z","pushed_at":"2018-12-18T10:41:31Z","git_url":"git://github.com/LykkeCity/MatchingEngine.git","ssh_url":"git@github.com:LykkeCity/MatchingEngine.git","clone_url":"https://github.com/LykkeCity/MatchingEngine.git","svn_url":"https://github.com/LykkeCity/MatchingEngine","homepage":"","size":6075,"stargazers_count":23,"watchers_count":23,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":5,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236"},"html":{"href":"https://github.com/LykkeCity/MatchingEngine/pull/236"},"issue":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/236"},"comments":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/LykkeCity/MatchingEngine/statuses/df2851a965e777999fc9588452b166a83793a8d9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52304364,
"name": "LykkeCity/MatchingEngine",
"url": "https://api.github.com/repos/LykkeCity/MatchingEngine"
} | {
"id": 2168075,
"login": "rocketmannot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2168075?",
"url": "https://api.github.com/users/rocketmannot"
} | {
"id": 14153330,
"login": "LykkeCity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14153330?",
"url": "https://api.github.com/orgs/LykkeCity"
} | 2018-12-18T10:45:58 | 8771158944 | {"actor":{"display_login":"rocketmannot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/EDyO/appu/pulls/comments/198275757","pull_request_review_id":132178343,"id":198275757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI3NTc1Nw==","diff_hunk":"@@ -0,0 +1,445 @@\n+* Cómo publicar un episodio de Entre Dev y Ops\r\n+:PROPERTIES:\r\n+:END:\r\n+\r\n+** Definición del programa\r\n+*** Objetivos\r\n+ Éste programa permite publicar un episodio grabado, en formato audio MP3, y compartido en [[https://www.dropbox.com][Dropbox]].\r\n+ La grabación disponible será:\r\n+ - Descargada\r\n+ - Editada para añadir las cuñas de entrada y salida, y normalizar el volumen\r\n+ - Publicar el audio editado\r\n+ - Comprobada su publicación\r\n+\r\n+ El programa se llama ~publish_podcast.sh~.\r\n+\r\n+*** Condiciones\r\n+ La grabación usada no se podrá editar durante el proceso, por lo que, en caso necesario, deberá ser previamente editada.\r\n+\r\n+*** Requerimientos\r\n+ Para usar el programa será necesario tener acceso a:\r\n+ - La carpeta compartida en [[Dropbox]]\r\n+ - [[https://developers.google.com/identity/protocols/OAuth2][Credenciales de Google Drive]] con acceso a la carpeta compartida ~EDYO~.\r\n+ \r\n+ Aunque es de acceso público, el programa accede al CI de Travis para ~appu~.\r\n+\r\n+ Las dependencias de este programa son:\r\n+ - [[https://www.dropboxwiki.com/tips-and-tricks/using-the-official-dropbox-command-line-interface-cli#PUBURL][Dropbox CLI]]: El CLI debe estar instalado en el sistema.\r\n+ - [[https://github.com/EDyO/appu][appu]]: El programa clonará o actualizará ~appu~, en el /path/ indicado.\r\n+ - [[https://github.com/EDyO/pan][pan]]: ~pan~ está instalado en el servidor de publicación.\r\n+ - [[https://github.com/prasmussen/gdrive][gdrive]]: Es un CLI para Google Drive que se necesita localmente.\r\n+ - [[https://github.com/ChrisTrenkamp/goxpath][goxpath]]: Es una herramienta CLI para conslutar XPath.\r\n+ - [[https://github.com/rrthomas/recode/][recode]]: Es una herrmienta CLI GNU para recodificar.\r\n+ - [[https://stedolan.github.io/jq/][jq]]: Es una herramienta CLI para consultar JSON.\r\n+\r\n+*** Entradas, salidas y resultados del programa\r\n+ Las entradas del programa son:\r\n+ - La grabación maestra del episodio a publicar: El fichero en la carpeta de Dropbox local, con el /path/ completo. Por ejemplo, ~${HOME}/Dropbox/EDyO/podcast/edyo-32.master.mp3~.\r\n+\r\n+ El programa no tendrá salidas, más que los anuncios de los pasos que vaya dando, o los errores que pueda encontrar.\r\n+ No obstante, si no hay errores, el programa resultará en la publicación del episodio indicado.\r\n+\r\n+*** Variables globales y constantes\r\n+ A continuación se definen las siguientes variables globales:\r\n+ - ~DRIVE_CREDENTIALS_FILE~: Será el /path/ relativo desde ~${HOME}/.gdrive~ al fichero de credenciales con acceso a la carpeta compartida en Drive.\r\n+ - ~DROPBOX_CLI~: Será el /path/ completo al CLI de Dropbox. Si se han seguido las instrucciones de la documentación del CLI, debería ser ~${HOME}/bin/dropbox.py~.\r\n+ - ~PROJECTS_PATH~: Será el /path/ dónde el programa clonará o actualizará ~appu~.\r\n+ - ~PUBLIC_FEED~: Será la URL al /feed/ del /podcast/.\r\n+ \r\n+*** Pasos del programa\r\n+ El programa realizará los siguientes pasos:\r\n+ - ~get_dropbox_url~: [[Obtener el enlace del fichero en Dropbox]]\r\n+ - ~clone_appu~: [[Clonar o actualizar el repositorio de ~appu~]]\r\n+ - ~get_episode_details~: [[Obtener los detalles del episodio a publicar]]\r\n+ - ~run_appu~: [[Utilizar el CI de ~appu~ para editar el episodio]]\r\n+ - ~ssh_server~: [[Acceder al servidor de publicación]]\r\n+ - ~download_edited_mp3~: [[Descargar el episodio editado en el servidor de publicación]]\r\n+ - ~update_feed~: [[Actualizar el /feed/ del podcast, con los datos]]\r\n+ - ~validate_publishing~: [[Validar la publicación]]\r\n+ - ~check_publishing~: [[Comprobar que la publicación está disponible]]\r\n+ - ~check_publishing_all~: [[Comprobar que la publicación está disponible en todos los feeds]]\r\n+ \r\n+ Otros pasos, de soporte y ayuda son:\r\n+ - ~get_episode_script~: [[Obtener el guión del episodio]]\r\n+ - ~count_tracks~: [[Obtener la pista correspondiente al episodio]]\r\n+\r\n+ #+BEGIN_SRC sh :noweb yes :tangle ../bin/publish_podcast.sh :tangle-mode (identity #o755)\r","path":"doc/publish_podcast.org","position":67,"original_position":66,"commit_id":"98c0a2075f0267ff96baace2a36f76aa2e38809a","original_commit_id":"961883a44e1966aedca51adbaebbcd9be2a12140","user":{"login":"ifosch","id":2912400,"node_id":"MDQ6VXNlcjI5MTI0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2912400?v=4","gravatar_id":"","url":"https://api.github.com/users/ifosch","html_url":"https://github.com/ifosch","followers_url":"https://api.github.com/users/ifosch/followers","following_url":"https://api.github.com/users/ifosch/following{/other_user}","gists_url":"https://api.github.com/users/ifosch/gists{/gist_id}","starred_url":"https://api.github.com/users/ifosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifosch/subscriptions","organizations_url":"https://api.github.com/users/ifosch/orgs","repos_url":"https://api.github.com/users/ifosch/repos","events_url":"https://api.github.com/users/ifosch/events{/privacy}","received_events_url":"https://api.github.com/users/ifosch/received_events","type":"User","site_admin":false},"body":"Éste código es un marcador de bloque de org-mode (plugin org-babel) que permite escribir código:\r\n- Indica que está escrito en shell\r\n- La marca `:noweb yes` indica a org-mode que ha de reemplazar los bloques entre `<>` con los bloques con los nombres correspondientes\r\n- La marca `:tangle ../bin/publish_podcast.sh` indica a org-mode que el fichero resultante debe ser guardado con ése path\r\n- La marca `:tangle-mode (identity #o755)` indica a org-mode que el fichero resultante debe tener permisos de ejecución","created_at":"2018-06-26T19:52:12Z","updated_at":"2018-06-26T19:52:12Z","html_url":"https://github.com/EDyO/appu/pull/13#discussion_r198275757","pull_request_url":"https://api.github.com/repos/EDyO/appu/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EDyO/appu/pulls/comments/198275757"},"html":{"href":"https://github.com/EDyO/appu/pull/13#discussion_r198275757"},"pull_request":{"href":"https://api.github.com/repos/EDyO/appu/pulls/13"}},"in_reply_to_id":198195947},"pull_request":{"url":"https://api.github.com/repos/EDyO/appu/pulls/13","id":195347857,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzQ3ODU3","html_url":"https://github.com/EDyO/appu/pull/13","diff_url":"https://github.com/EDyO/appu/pull/13.diff","patch_url":"https://github.com/EDyO/appu/pull/13.patch","issue_url":"https://api.github.com/repos/EDyO/appu/issues/13","number":13,"state":"open","locked":false,"title":"Add automated process document and templates","user":{"login":"ifosch","id":2912400,"node_id":"MDQ6VXNlcjI5MTI0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2912400?v=4","gravatar_id":"","url":"https://api.github.com/users/ifosch","html_url":"https://github.com/ifosch","followers_url":"https://api.github.com/users/ifosch/followers","following_url":"https://api.github.com/users/ifosch/following{/other_user}","gists_url":"https://api.github.com/users/ifosch/gists{/gist_id}","starred_url":"https://api.github.com/users/ifosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifosch/subscriptions","organizations_url":"https://api.github.com/users/ifosch/orgs","repos_url":"https://api.github.com/users/ifosch/repos","events_url":"https://api.github.com/users/ifosch/events{/privacy}","received_events_url":"https://api.github.com/users/ifosch/received_events","type":"User","site_admin":false},"body":"This change contains the automated process document, and the templates for using it","created_at":"2018-06-16T20:33:13Z","updated_at":"2018-06-26T19:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c604781e882bb66f7bbb78877d60acb15c16cdd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EDyO/appu/pulls/13/commits","review_comments_url":"https://api.github.com/repos/EDyO/appu/pulls/13/comments","review_comment_url":"https://api.github.com/repos/EDyO/appu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EDyO/appu/issues/13/comments","statuses_url":"https://api.github.com/repos/EDyO/appu/statuses/98c0a2075f0267ff96baace2a36f76aa2e38809a","head":{"label":"ifosch:automated-process","ref":"automated-process","sha":"98c0a2075f0267ff96baace2a36f76aa2e38809a","user":{"login":"ifosch","id":2912400,"node_id":"MDQ6VXNlcjI5MTI0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2912400?v=4","gravatar_id":"","url":"https://api.github.com/users/ifosch","html_url":"https://github.com/ifosch","followers_url":"https://api.github.com/users/ifosch/followers","following_url":"https://api.github.com/users/ifosch/following{/other_user}","gists_url":"https://api.github.com/users/ifosch/gists{/gist_id}","starred_url":"https://api.github.com/users/ifosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifosch/subscriptions","organizations_url":"https://api.github.com/users/ifosch/orgs","repos_url":"https://api.github.com/users/ifosch/repos","events_url":"https://api.github.com/users/ifosch/events{/privacy}","received_events_url":"https://api.github.com/users/ifosch/received_events","type":"User","site_admin":false},"repo":{"id":121063665,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEwNjM2NjU=","name":"appu","full_name":"ifosch/appu","owner":{"login":"ifosch","id":2912400,"node_id":"MDQ6VXNlcjI5MTI0MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2912400?v=4","gravatar_id":"","url":"https://api.github.com/users/ifosch","html_url":"https://github.com/ifosch","followers_url":"https://api.github.com/users/ifosch/followers","following_url":"https://api.github.com/users/ifosch/following{/other_user}","gists_url":"https://api.github.com/users/ifosch/gists{/gist_id}","starred_url":"https://api.github.com/users/ifosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifosch/subscriptions","organizations_url":"https://api.github.com/users/ifosch/orgs","repos_url":"https://api.github.com/users/ifosch/repos","events_url":"https://api.github.com/users/ifosch/events{/privacy}","received_events_url":"https://api.github.com/users/ifosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifosch/appu","description":"Automatic Podcast Publisher","fork":true,"url":"https://api.github.com/repos/ifosch/appu","forks_url":"https://api.github.com/repos/ifosch/appu/forks","keys_url":"https://api.github.com/repos/ifosch/appu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifosch/appu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifosch/appu/teams","hooks_url":"https://api.github.com/repos/ifosch/appu/hooks","issue_events_url":"https://api.github.com/repos/ifosch/appu/issues/events{/number}","events_url":"https://api.github.com/repos/ifosch/appu/events","assignees_url":"https://api.github.com/repos/ifosch/appu/assignees{/user}","branches_url":"https://api.github.com/repos/ifosch/appu/branches{/branch}","tags_url":"https://api.github.com/repos/ifosch/appu/tags","blobs_url":"https://api.github.com/repos/ifosch/appu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifosch/appu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifosch/appu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifosch/appu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifosch/appu/statuses/{sha}","languages_url":"https://api.github.com/repos/ifosch/appu/languages","stargazers_url":"https://api.github.com/repos/ifosch/appu/stargazers","contributors_url":"https://api.github.com/repos/ifosch/appu/contributors","subscribers_url":"https://api.github.com/repos/ifosch/appu/subscribers","subscription_url":"https://api.github.com/repos/ifosch/appu/subscription","commits_url":"https://api.github.com/repos/ifosch/appu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifosch/appu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifosch/appu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifosch/appu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifosch/appu/contents/{+path}","compare_url":"https://api.github.com/repos/ifosch/appu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifosch/appu/merges","archive_url":"https://api.github.com/repos/ifosch/appu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifosch/appu/downloads","issues_url":"https://api.github.com/repos/ifosch/appu/issues{/number}","pulls_url":"https://api.github.com/repos/ifosch/appu/pulls{/number}","milestones_url":"https://api.github.com/repos/ifosch/appu/milestones{/number}","notifications_url":"https://api.github.com/repos/ifosch/appu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifosch/appu/labels{/name}","releases_url":"https://api.github.com/repos/ifosch/appu/releases{/id}","deployments_url":"https://api.github.com/repos/ifosch/appu/deployments","created_at":"2018-02-10T23:28:15Z","updated_at":"2018-04-04T22:53:02Z","pushed_at":"2018-06-26T19:48:09Z","git_url":"git://github.com/ifosch/appu.git","ssh_url":"git@github.com:ifosch/appu.git","clone_url":"https://github.com/ifosch/appu.git","svn_url":"https://github.com/ifosch/appu","homepage":"","size":1331505,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EDyO:master","ref":"master","sha":"f540183ea85424a0a74a415c09a65dd97526c000","user":{"login":"EDyO","id":14165758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/14165758?v=4","gravatar_id":"","url":"https://api.github.com/users/EDyO","html_url":"https://github.com/EDyO","followers_url":"https://api.github.com/users/EDyO/followers","following_url":"https://api.github.com/users/EDyO/following{/other_user}","gists_url":"https://api.github.com/users/EDyO/gists{/gist_id}","starred_url":"https://api.github.com/users/EDyO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDyO/subscriptions","organizations_url":"https://api.github.com/users/EDyO/orgs","repos_url":"https://api.github.com/users/EDyO/repos","events_url":"https://api.github.com/users/EDyO/events{/privacy}","received_events_url":"https://api.github.com/users/EDyO/received_events","type":"Organization","site_admin":false},"repo":{"id":72918611,"node_id":"MDEwOlJlcG9zaXRvcnk3MjkxODYxMQ==","name":"appu","full_name":"EDyO/appu","owner":{"login":"EDyO","id":14165758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/14165758?v=4","gravatar_id":"","url":"https://api.github.com/users/EDyO","html_url":"https://github.com/EDyO","followers_url":"https://api.github.com/users/EDyO/followers","following_url":"https://api.github.com/users/EDyO/following{/other_user}","gists_url":"https://api.github.com/users/EDyO/gists{/gist_id}","starred_url":"https://api.github.com/users/EDyO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDyO/subscriptions","organizations_url":"https://api.github.com/users/EDyO/orgs","repos_url":"https://api.github.com/users/EDyO/repos","events_url":"https://api.github.com/users/EDyO/events{/privacy}","received_events_url":"https://api.github.com/users/EDyO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EDyO/appu","description":"Automatic Podcast Publisher","fork":false,"url":"https://api.github.com/repos/EDyO/appu","forks_url":"https://api.github.com/repos/EDyO/appu/forks","keys_url":"https://api.github.com/repos/EDyO/appu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EDyO/appu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EDyO/appu/teams","hooks_url":"https://api.github.com/repos/EDyO/appu/hooks","issue_events_url":"https://api.github.com/repos/EDyO/appu/issues/events{/number}","events_url":"https://api.github.com/repos/EDyO/appu/events","assignees_url":"https://api.github.com/repos/EDyO/appu/assignees{/user}","branches_url":"https://api.github.com/repos/EDyO/appu/branches{/branch}","tags_url":"https://api.github.com/repos/EDyO/appu/tags","blobs_url":"https://api.github.com/repos/EDyO/appu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EDyO/appu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EDyO/appu/git/refs{/sha}","trees_url":"https://api.github.com/repos/EDyO/appu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EDyO/appu/statuses/{sha}","languages_url":"https://api.github.com/repos/EDyO/appu/languages","stargazers_url":"https://api.github.com/repos/EDyO/appu/stargazers","contributors_url":"https://api.github.com/repos/EDyO/appu/contributors","subscribers_url":"https://api.github.com/repos/EDyO/appu/subscribers","subscription_url":"https://api.github.com/repos/EDyO/appu/subscription","commits_url":"https://api.github.com/repos/EDyO/appu/commits{/sha}","git_commits_url":"https://api.github.com/repos/EDyO/appu/git/commits{/sha}","comments_url":"https://api.github.com/repos/EDyO/appu/comments{/number}","issue_comment_url":"https://api.github.com/repos/EDyO/appu/issues/comments{/number}","contents_url":"https://api.github.com/repos/EDyO/appu/contents/{+path}","compare_url":"https://api.github.com/repos/EDyO/appu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EDyO/appu/merges","archive_url":"https://api.github.com/repos/EDyO/appu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EDyO/appu/downloads","issues_url":"https://api.github.com/repos/EDyO/appu/issues{/number}","pulls_url":"https://api.github.com/repos/EDyO/appu/pulls{/number}","milestones_url":"https://api.github.com/repos/EDyO/appu/milestones{/number}","notifications_url":"https://api.github.com/repos/EDyO/appu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EDyO/appu/labels{/name}","releases_url":"https://api.github.com/repos/EDyO/appu/releases{/id}","deployments_url":"https://api.github.com/repos/EDyO/appu/deployments","created_at":"2016-11-05T10:15:25Z","updated_at":"2018-06-16T20:18:44Z","pushed_at":"2018-06-26T19:48:11Z","git_url":"git://github.com/EDyO/appu.git","ssh_url":"git@github.com:EDyO/appu.git","clone_url":"https://github.com/EDyO/appu.git","svn_url":"https://github.com/EDyO/appu","homepage":"","size":1396175,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EDyO/appu/pulls/13"},"html":{"href":"https://github.com/EDyO/appu/pull/13"},"issue":{"href":"https://api.github.com/repos/EDyO/appu/issues/13"},"comments":{"href":"https://api.github.com/repos/EDyO/appu/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/EDyO/appu/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/EDyO/appu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EDyO/appu/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/EDyO/appu/statuses/98c0a2075f0267ff96baace2a36f76aa2e38809a"}},"author_association":"MEMBER"}} | {
"id": 72918611,
"name": "EDyO/appu",
"url": "https://api.github.com/repos/EDyO/appu"
} | {
"id": 2912400,
"login": "ifosch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2912400?",
"url": "https://api.github.com/users/ifosch"
} | {
"id": 14165758,
"login": "EDyO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14165758?",
"url": "https://api.github.com/orgs/EDyO"
} | 2018-06-26T19:52:12 | 7881667505 | {"actor":{"display_login":"ifosch"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/166319363","pull_request_review_id":94362153,"id":166319363,"diff_hunk":"@@ -0,0 +1,139 @@\n+// Copyright 2017 Parity Technologies (UK) Ltd.\n+// This file is part of Polkadot.\n+\n+// Polkadot is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+\n+// Polkadot is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU General Public License for more details.\n+\n+// You should have received a copy of the GNU General Public License\n+// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.\n+\n+//! Polkadot runtime functions.\n+//! This describes a function that can be called from an external transaction.\n+\n+use bytes::Vec;\n+use codec::Slicable;\n+\n+/// Public functions that can be dispatched to.\n+#[derive(Debug, Clone, Copy, PartialEq, Eq)]\n+#[cfg_attr(feature = \"std\", derive(Serialize, Deserialize))]\n+#[repr(u8)]\n+enum FunctionId {\n+\t/// Staking subsystem: begin staking.\n+\tStakingStake = 0,\n+\t/// Staking subsystem: stop staking.\n+\tStakingUnstake = 1,\n+\t/// Staking subsystem: transfer stake.\n+\tStakingTransfer = 2,\n+\t/// Set temporary session key as a validator.\n+\tSessionSetKey = 3,\n+\t/// Set the timestamp.\n+\tTimestampSet = 4,\n+\t/// Make a proposal for the governance system.\n+\tGovernancePropose = 5,\n+\t/// Approve a proposal for the governance system.\n+\tGovernanceApprove = 6,\n+}\n+\n+impl FunctionId {\n+\t/// Derive `Some` value from a `u8`, or `None` if it's invalid.\n+\tfn from_u8(value: u8) -> Option<FunctionId> {\n+\t\tmatch value {\n+\t\t\t0 => Some(FunctionId::StakingStake),\n+\t\t\t1 => Some(FunctionId::StakingUnstake),\n+\t\t\t2 => Some(FunctionId::StakingTransfer),\n+\t\t\t3 => Some(FunctionId::SessionSetKey),\n+\t\t\t4 => Some(FunctionId::TimestampSet),\n+\t\t\t5 => Some(FunctionId::GovernancePropose),\n+\t\t\t6 => Some(FunctionId::GovernanceApprove),\n+\t\t\t_ => None,\n+\t\t}\n+\t}\n+}\n+\n+/// Functions on the runtime.\n+#[derive(Debug, Clone, PartialEq, Eq)]\n+#[cfg_attr(feature = \"std\", derive(Serialize, Deserialize))]\n+pub enum Function {\n+\t/// Staking subsystem: begin staking.\n+\tStakingStake,\n+\t/// Staking subsystem: stop staking.\n+\tStakingUnstake,\n+\t/// Staking subsystem: transfer stake.\n+\tStakingTransfer(::AccountId, ::Balance),\n+\t/// Set temporary session key as a validator.\n+\tSessionSetKey(::SessionKey),\n+\t/// Set the timestamp.\n+\tTimestampSet(::Timestamp),\n+\t/// Make a proposal for the governance system.\n+\tGovernancePropose(::proposal::Proposal),\n+\t/// Approve a proposal for the governance system.\n+\tGovernanceApprove(::block::Number),\n+}\n+\n+impl Slicable for Function {\n+\tfn from_slice(value: &mut &[u8]) -> Option<Self> {\n+\t\tlet id = try_opt!(u8::from_slice(value).and_then(FunctionId::from_u8));\n+\t\tSome(match id {\n+\t\t\tFunctionId::StakingStake => Function::StakingStake,\n+\t\t\tFunctionId::StakingUnstake => Function::StakingUnstake,\n+\t\t\tFunctionId::StakingTransfer => Function::StakingTransfer(\n+\t\t\t\ttry_opt!(Slicable::from_slice(value)),","path":"primitives/src/runtime_function.rs","position":87,"original_position":87,"commit_id":"6d36db7a33b70555421dfa29a9855f20fc53ce0e","original_commit_id":"6d36db7a33b70555421dfa29a9855f20fc53ce0e","user":{"login":"gavofyork","id":138296,"avatar_url":"https://avatars0.githubusercontent.com/u/138296?v=4","gravatar_id":"","url":"https://api.github.com/users/gavofyork","html_url":"https://github.com/gavofyork","followers_url":"https://api.github.com/users/gavofyork/followers","following_url":"https://api.github.com/users/gavofyork/following{/other_user}","gists_url":"https://api.github.com/users/gavofyork/gists{/gist_id}","starred_url":"https://api.github.com/users/gavofyork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavofyork/subscriptions","organizations_url":"https://api.github.com/users/gavofyork/orgs","repos_url":"https://api.github.com/users/gavofyork/repos","events_url":"https://api.github.com/users/gavofyork/events{/privacy}","received_events_url":"https://api.github.com/users/gavofyork/received_events","type":"User","site_admin":false},"body":"does this really deserialise in the correct order?","created_at":"2018-02-06T14:30:30Z","updated_at":"2018-02-06T14:30:31Z","html_url":"https://github.com/paritytech/polkadot/pull/58#discussion_r166319363","pull_request_url":"https://api.github.com/repos/paritytech/polkadot/pulls/58","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments/166319363"},"html":{"href":"https://github.com/paritytech/polkadot/pull/58#discussion_r166319363"},"pull_request":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/polkadot/pulls/58","id":167387648,"html_url":"https://github.com/paritytech/polkadot/pull/58","diff_url":"https://github.com/paritytech/polkadot/pull/58.diff","patch_url":"https://github.com/paritytech/polkadot/pull/58.patch","issue_url":"https://api.github.com/repos/paritytech/polkadot/issues/58","number":58,"state":"open","locked":false,"title":"Unify primitives from polkadot-primitives and polkadot-runtime","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars1.githubusercontent.com/u/10121380?v=4","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"Unifies the `polkadot-primitives` crate with the `native-runtime/primitives` module.\r\nExtracts out the codec to its own bottom-level crate, simplifying slightly.","created_at":"2018-02-06T11:27:21Z","updated_at":"2018-02-06T14:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5919bf0843e8ee42b28e62928e0d2d23f799fcc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/polkadot/pulls/58/commits","review_comments_url":"https://api.github.com/repos/paritytech/polkadot/pulls/58/comments","review_comment_url":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/polkadot/issues/58/comments","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/6d36db7a33b70555421dfa29a9855f20fc53ce0e","head":{"label":"paritytech:unify-primitives","ref":"unify-primitives","sha":"6d36db7a33b70555421dfa29a9855f20fc53ce0e","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-02-04T03:05:36Z","pushed_at":"2018-02-06T14:05:18Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":1419,"stargazers_count":67,"watchers_count":67,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":21,"watchers":67,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"8ee3c40b34fedf26581d16f2932dbcd6c1c5488e","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"name":"polkadot","full_name":"paritytech/polkadot","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/polkadot","description":"Polkadot Node Implementation","fork":false,"url":"https://api.github.com/repos/paritytech/polkadot","forks_url":"https://api.github.com/repos/paritytech/polkadot/forks","keys_url":"https://api.github.com/repos/paritytech/polkadot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/polkadot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/polkadot/teams","hooks_url":"https://api.github.com/repos/paritytech/polkadot/hooks","issue_events_url":"https://api.github.com/repos/paritytech/polkadot/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/polkadot/events","assignees_url":"https://api.github.com/repos/paritytech/polkadot/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/polkadot/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/polkadot/tags","blobs_url":"https://api.github.com/repos/paritytech/polkadot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/polkadot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/polkadot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/polkadot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/polkadot/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/polkadot/languages","stargazers_url":"https://api.github.com/repos/paritytech/polkadot/stargazers","contributors_url":"https://api.github.com/repos/paritytech/polkadot/contributors","subscribers_url":"https://api.github.com/repos/paritytech/polkadot/subscribers","subscription_url":"https://api.github.com/repos/paritytech/polkadot/subscription","commits_url":"https://api.github.com/repos/paritytech/polkadot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/polkadot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/polkadot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/polkadot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/polkadot/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/polkadot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/polkadot/merges","archive_url":"https://api.github.com/repos/paritytech/polkadot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/polkadot/downloads","issues_url":"https://api.github.com/repos/paritytech/polkadot/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/polkadot/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/polkadot/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/polkadot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/polkadot/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/polkadot/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/polkadot/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2018-02-04T03:05:36Z","pushed_at":"2018-02-06T14:05:18Z","git_url":"git://github.com/paritytech/polkadot.git","ssh_url":"git@github.com:paritytech/polkadot.git","clone_url":"https://github.com/paritytech/polkadot.git","svn_url":"https://github.com/paritytech/polkadot","homepage":null,"size":1419,"stargazers_count":67,"watchers_count":67,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":21,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/58"},"html":{"href":"https://github.com/paritytech/polkadot/pull/58"},"issue":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/58"},"comments":{"href":"https://api.github.com/repos/paritytech/polkadot/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/polkadot/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/polkadot/statuses/6d36db7a33b70555421dfa29a9855f20fc53ce0e"}},"author_association":"MEMBER"}} | {
"id": 109872620,
"name": "paritytech/polkadot",
"url": "https://api.github.com/repos/paritytech/polkadot"
} | {
"id": 138296,
"login": "gavofyork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/138296?",
"url": "https://api.github.com/users/gavofyork"
} | {
"id": 14176906,
"login": "paritytech",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14176906?",
"url": "https://api.github.com/orgs/paritytech"
} | 2018-02-06T14:30:30 | 7204988805 | {"actor":{"display_login":"gavofyork"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/comments/193346096","pull_request_review_id":126289821,"id":193346096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzM0NjA5Ng==","diff_hunk":"@@ -0,0 +1,67 @@\n+'use strict';\n+\n+var CLOUD_WIDTH = 420;\n+var CLOUD_HEIGHT = 270;\n+var CLOUD_X = 100;\n+var CLOUD_Y = 10;\n+var CLOUD_GAP = 10;\n+var TEXT_HEIGHT = 16;\n+var TEXT_FONT = '16px MONO';\n+var TEXT_GAP = 10;\n+var TEXT_BOTTOM = 'bottom';\n+var TEXT_TOP = 'top';\n+var FIRST_MESSAGE_PHRASE = 'Ура вы победили!';\n+var SECOND_MESSAGE_PHRASE = 'Список результатов:';\n+var BAR_WIDTH = 40;\n+var BAR_HEIGHT = 150;\n+var BAR_GAP = 50;\n+var LAST_PLAYER = 'Вы';\n+var BLACK_COLOR = '#000';\n+var WHITE_COLOR = '#fff';\n+\n+var renderCloud = function (ctx, x, y, color) {\n+ ctx.fillStyle = color;\n+ ctx.fillRect(x, y, CLOUD_WIDTH, CLOUD_HEIGHT);\n+};\n+\n+var getMaxElement = function (arr) {\n+ var maxElement = arr[0];\n+\n+ for (var i = 0; i < arr.length; i++) {\n+ if (arr[i] > maxElement) {\n+ maxElement = arr[i];\n+ }\n+ }\n+\n+ return Math.floor(maxElement);\n+};\n+\n+var getRandomArbitrary = function (min, max) {\n+ return Math.round(Math.random() * (max - min) + min);\n+};\n+\n+var getColor = function (x) {\n+ return 'rgb(8, 133, ' + String(getRandomArbitrary(150, 250) + x) + ')';\n+};\n+\n+window.renderStatistics = function (ctx, players, times) {\n+ renderCloud(ctx, CLOUD_X + CLOUD_GAP, CLOUD_Y + CLOUD_GAP, 'rgba(0, 0, 0, 0.7)');\n+ renderCloud(ctx, CLOUD_X, CLOUD_Y, WHITE_COLOR);\n+\n+ ctx.fillStyle = BLACK_COLOR;\n+ ctx.font = TEXT_FONT;\n+ ctx.textBaseline = TEXT_TOP;\n+ ctx.fillText(FIRST_MESSAGE_PHRASE, CLOUD_X + TEXT_GAP, TEXT_GAP * 3);\n+ ctx.fillText(SECOND_MESSAGE_PHRASE, CLOUD_X + TEXT_GAP, TEXT_HEIGHT + TEXT_GAP * 3);","path":"js/stat.js","position":55,"original_position":55,"commit_id":"5bae512b9d1c2b0cbdf5845cee31a2f29f2e8266","original_commit_id":"5bae512b9d1c2b0cbdf5845cee31a2f29f2e8266","user":{"login":"archangel-irk","id":1079509,"node_id":"MDQ6VXNlcjEwNzk1MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1079509?v=4","gravatar_id":"","url":"https://api.github.com/users/archangel-irk","html_url":"https://github.com/archangel-irk","followers_url":"https://api.github.com/users/archangel-irk/followers","following_url":"https://api.github.com/users/archangel-irk/following{/other_user}","gists_url":"https://api.github.com/users/archangel-irk/gists{/gist_id}","starred_url":"https://api.github.com/users/archangel-irk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archangel-irk/subscriptions","organizations_url":"https://api.github.com/users/archangel-irk/orgs","repos_url":"https://api.github.com/users/archangel-irk/repos","events_url":"https://api.github.com/users/archangel-irk/events{/privacy}","received_events_url":"https://api.github.com/users/archangel-irk/received_events","type":"User","site_admin":false},"body":"Давайте создадим отдельную функцию отрисовки цветного текста на координатах. Так будет удобнее :)","created_at":"2018-06-06T09:18:18Z","updated_at":"2018-06-06T09:18:55Z","html_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2#discussion_r193346096","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/comments/193346096"},"html":{"href":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2#discussion_r193346096"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2","id":192677691,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjc3Njkx","html_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2","diff_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2.diff","patch_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/2","number":2,"state":"open","locked":false,"title":"Учебный проект «Холст»","user":{"login":"SempreMai","id":22892048,"node_id":"MDQ6VXNlcjIyODkyMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/22892048?v=4","gravatar_id":"","url":"https://api.github.com/users/SempreMai","html_url":"https://github.com/SempreMai","followers_url":"https://api.github.com/users/SempreMai/followers","following_url":"https://api.github.com/users/SempreMai/following{/other_user}","gists_url":"https://api.github.com/users/SempreMai/gists{/gist_id}","starred_url":"https://api.github.com/users/SempreMai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SempreMai/subscriptions","organizations_url":"https://api.github.com/users/SempreMai/orgs","repos_url":"https://api.github.com/users/SempreMai/repos","events_url":"https://api.github.com/users/SempreMai/events{/privacy}","received_events_url":"https://api.github.com/users/SempreMai/received_events","type":"User","site_admin":false},"body":"Pull-request from module2-task1\n\n---\n:mortar_board: [Учебный проект «Холст»](https://up.htmlacademy.ru/javascript/14/user/224497/tasks/10)\n\n:boom: https://htmlacademy-javascript.github.io/224497-code-and-magick/2/","created_at":"2018-06-05T11:40:08Z","updated_at":"2018-06-06T09:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb43d98e451f493210b4d119f1273e4ac0525f4","assignee":{"login":"archangel-irk","id":1079509,"node_id":"MDQ6VXNlcjEwNzk1MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1079509?v=4","gravatar_id":"","url":"https://api.github.com/users/archangel-irk","html_url":"https://github.com/archangel-irk","followers_url":"https://api.github.com/users/archangel-irk/followers","following_url":"https://api.github.com/users/archangel-irk/following{/other_user}","gists_url":"https://api.github.com/users/archangel-irk/gists{/gist_id}","starred_url":"https://api.github.com/users/archangel-irk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archangel-irk/subscriptions","organizations_url":"https://api.github.com/users/archangel-irk/orgs","repos_url":"https://api.github.com/users/archangel-irk/repos","events_url":"https://api.github.com/users/archangel-irk/events{/privacy}","received_events_url":"https://api.github.com/users/archangel-irk/received_events","type":"User","site_admin":false},"assignees":[{"login":"archangel-irk","id":1079509,"node_id":"MDQ6VXNlcjEwNzk1MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1079509?v=4","gravatar_id":"","url":"https://api.github.com/users/archangel-irk","html_url":"https://github.com/archangel-irk","followers_url":"https://api.github.com/users/archangel-irk/followers","following_url":"https://api.github.com/users/archangel-irk/following{/other_user}","gists_url":"https://api.github.com/users/archangel-irk/gists{/gist_id}","starred_url":"https://api.github.com/users/archangel-irk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archangel-irk/subscriptions","organizations_url":"https://api.github.com/users/archangel-irk/orgs","repos_url":"https://api.github.com/users/archangel-irk/repos","events_url":"https://api.github.com/users/archangel-irk/events{/privacy}","received_events_url":"https://api.github.com/users/archangel-irk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/statuses/5bae512b9d1c2b0cbdf5845cee31a2f29f2e8266","head":{"label":"SempreMai:module2-task1","ref":"module2-task1","sha":"5bae512b9d1c2b0cbdf5845cee31a2f29f2e8266","user":{"login":"SempreMai","id":22892048,"node_id":"MDQ6VXNlcjIyODkyMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/22892048?v=4","gravatar_id":"","url":"https://api.github.com/users/SempreMai","html_url":"https://github.com/SempreMai","followers_url":"https://api.github.com/users/SempreMai/followers","following_url":"https://api.github.com/users/SempreMai/following{/other_user}","gists_url":"https://api.github.com/users/SempreMai/gists{/gist_id}","starred_url":"https://api.github.com/users/SempreMai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SempreMai/subscriptions","organizations_url":"https://api.github.com/users/SempreMai/orgs","repos_url":"https://api.github.com/users/SempreMai/repos","events_url":"https://api.github.com/users/SempreMai/events{/privacy}","received_events_url":"https://api.github.com/users/SempreMai/received_events","type":"User","site_admin":false},"repo":{"id":135584954,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1ODQ5NTQ=","name":"224497-code-and-magick","full_name":"SempreMai/224497-code-and-magick","owner":{"login":"SempreMai","id":22892048,"node_id":"MDQ6VXNlcjIyODkyMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/22892048?v=4","gravatar_id":"","url":"https://api.github.com/users/SempreMai","html_url":"https://github.com/SempreMai","followers_url":"https://api.github.com/users/SempreMai/followers","following_url":"https://api.github.com/users/SempreMai/following{/other_user}","gists_url":"https://api.github.com/users/SempreMai/gists{/gist_id}","starred_url":"https://api.github.com/users/SempreMai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SempreMai/subscriptions","organizations_url":"https://api.github.com/users/SempreMai/orgs","repos_url":"https://api.github.com/users/SempreMai/repos","events_url":"https://api.github.com/users/SempreMai/events{/privacy}","received_events_url":"https://api.github.com/users/SempreMai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SempreMai/224497-code-and-magick","description":"Liubov Kudrina","fork":true,"url":"https://api.github.com/repos/SempreMai/224497-code-and-magick","forks_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/forks","keys_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/teams","hooks_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/events","assignees_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/tags","blobs_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/subscription","commits_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/merges","archive_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/downloads","issues_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/SempreMai/224497-code-and-magick/deployments","created_at":"2018-05-31T13:07:08Z","updated_at":"2018-06-04T14:36:24Z","pushed_at":"2018-06-05T17:18:54Z","git_url":"git://github.com/SempreMai/224497-code-and-magick.git","ssh_url":"git@github.com:SempreMai/224497-code-and-magick.git","clone_url":"https://github.com/SempreMai/224497-code-and-magick.git","svn_url":"https://github.com/SempreMai/224497-code-and-magick","homepage":null,"size":1104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"f8ab1070b57947f6defc7a9e9daa6559382b1a1f","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":135418775,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0MTg3NzU=","name":"224497-code-and-magick","full_name":"htmlacademy-javascript/224497-code-and-magick","owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick","description":"Liubov Kudrina","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick","forks_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/deployments","created_at":"2018-05-30T09:18:16Z","updated_at":"2018-06-04T14:19:06Z","pushed_at":"2018-06-06T09:10:15Z","git_url":"git://github.com/htmlacademy-javascript/224497-code-and-magick.git","ssh_url":"git@github.com:htmlacademy-javascript/224497-code-and-magick.git","clone_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick.git","svn_url":"https://github.com/htmlacademy-javascript/224497-code-and-magick","homepage":"https://github.com/SempreMai/224497-code-and-magick","size":1106,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2"},"html":{"href":"https://github.com/htmlacademy-javascript/224497-code-and-magick/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick/statuses/5bae512b9d1c2b0cbdf5845cee31a2f29f2e8266"}},"author_association":"CONTRIBUTOR"}} | {
"id": 135418775,
"name": "htmlacademy-javascript/224497-code-and-magick",
"url": "https://api.github.com/repos/htmlacademy-javascript/224497-code-and-magick"
} | {
"id": 1079509,
"login": "archangel-irk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1079509?",
"url": "https://api.github.com/users/archangel-irk"
} | {
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
} | 2018-06-06T09:18:18 | 7783248358 | {"actor":{"display_login":"archangel-irk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/comments/196628707","pull_request_review_id":130217334,"id":196628707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjYyODcwNw==","diff_hunk":"@@ -108,7 +108,60 @@ var renderMainPost = function (mainPost) {\n var allPosts = getRandomPosts(POSTS_COUNT);\n var postsFragment = document.createDocumentFragment();\n showPosts(picturesList, postsFragment, allPosts);\n-renderMainPost(allPosts[0]);\n \n document.querySelector('.social__comment-count').classList.add('visually-hidden');\n document.querySelector('.social__loadmore').classList.add('visually-hidden');\n+\n+// отображаем\n+var uploadField = document.querySelector('#upload-file');\n+var imgEditor = document.querySelector('.img-upload__overlay');\n+var cancelButton = document.querySelector('.img-upload__cancel');\n+uploadField.addEventListener('click', function (event) {\n+ event.preventDefault();\n+ imgEditor.classList.remove('hidden');\n+});\n+\n+cancelButton.addEventListener('click', function () {\n+ imgEditor.classList.add('hidden');\n+});\n+\n+var scalePin = document.querySelector('.scale__pin');\n+var photoFilters = document.querySelectorAll('input[name=effect]');\n+var uploadPhoto = document.querySelector('.img-upload__preview img');\n+var effectsList = document.querySelector('.effects__list');\n+\n+// scalePin.addEventListener('mouseup', function () {\n+\n+// });\n+\n+// Для эффекта «Хром» — filter: grayscale(0..1);\n+// Для эффекта «Сепия» — filter: sepia(0..1);\n+// Для эффекта «Марвин» — filter: invert(0..100%);\n+// Для эффекта «Фобос» — filter: blur(0..3px);\n+// Для эффекта «Зной» — filter: brightness(1..3).\n+\n+effectsList.addEventListener('click', function (evt) {\n+ uploadPhoto.removeAttribute('style');\n+ var activeFilter = 'filter-' + evt.target.value;\n+ console.log(activeFilter);\n+ switch (activeFilter) {\n+ case 'filter-chrome':","path":"js/pictures.js","position":51,"original_position":51,"commit_id":"ec094ca79680289ca9ce8fa892cdb93b8ff0e52f","original_commit_id":"ec094ca79680289ca9ce8fa892cdb93b8ff0e52f","user":{"login":"SPavelhjk","id":21310048,"node_id":"MDQ6VXNlcjIxMzEwMDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/21310048?v=4","gravatar_id":"","url":"https://api.github.com/users/SPavelhjk","html_url":"https://github.com/SPavelhjk","followers_url":"https://api.github.com/users/SPavelhjk/followers","following_url":"https://api.github.com/users/SPavelhjk/following{/other_user}","gists_url":"https://api.github.com/users/SPavelhjk/gists{/gist_id}","starred_url":"https://api.github.com/users/SPavelhjk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SPavelhjk/subscriptions","organizations_url":"https://api.github.com/users/SPavelhjk/orgs","repos_url":"https://api.github.com/users/SPavelhjk/repos","events_url":"https://api.github.com/users/SPavelhjk/events{/privacy}","received_events_url":"https://api.github.com/users/SPavelhjk/received_events","type":"User","site_admin":false},"body":"Потом получать его по ключу и передавать в `upload.setAttribute`","created_at":"2018-06-20T01:55:06Z","updated_at":"2018-06-20T01:55:10Z","html_url":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3#discussion_r196628707","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/comments/196628707"},"html":{"href":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3#discussion_r196628707"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3"}},"in_reply_to_id":196628623},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3","id":195932431,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTMyNDMx","html_url":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3","diff_url":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3.diff","patch_url":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/3","number":3,"state":"open","locked":false,"title":"Личный проект: подробности","user":{"login":"VesialouIvan","id":33086705,"node_id":"MDQ6VXNlcjMzMDg2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/33086705?v=4","gravatar_id":"","url":"https://api.github.com/users/VesialouIvan","html_url":"https://github.com/VesialouIvan","followers_url":"https://api.github.com/users/VesialouIvan/followers","following_url":"https://api.github.com/users/VesialouIvan/following{/other_user}","gists_url":"https://api.github.com/users/VesialouIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/VesialouIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesialouIvan/subscriptions","organizations_url":"https://api.github.com/users/VesialouIvan/orgs","repos_url":"https://api.github.com/users/VesialouIvan/repos","events_url":"https://api.github.com/users/VesialouIvan/events{/privacy}","received_events_url":"https://api.github.com/users/VesialouIvan/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Личный проект: подробности](https://up.htmlacademy.ru/javascript/14/user/406853/tasks/15)\n\n:boom: https://htmlacademy-javascript.github.io/406853-kekstagram/3/","created_at":"2018-06-19T19:25:01Z","updated_at":"2018-06-20T01:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"425c0c7764b0342fb8ce15db3710c8435558160e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/statuses/ec094ca79680289ca9ce8fa892cdb93b8ff0e52f","head":{"label":"VesialouIvan:module4-task1","ref":"module4-task1","sha":"ec094ca79680289ca9ce8fa892cdb93b8ff0e52f","user":{"login":"VesialouIvan","id":33086705,"node_id":"MDQ6VXNlcjMzMDg2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/33086705?v=4","gravatar_id":"","url":"https://api.github.com/users/VesialouIvan","html_url":"https://github.com/VesialouIvan","followers_url":"https://api.github.com/users/VesialouIvan/followers","following_url":"https://api.github.com/users/VesialouIvan/following{/other_user}","gists_url":"https://api.github.com/users/VesialouIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/VesialouIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesialouIvan/subscriptions","organizations_url":"https://api.github.com/users/VesialouIvan/orgs","repos_url":"https://api.github.com/users/VesialouIvan/repos","events_url":"https://api.github.com/users/VesialouIvan/events{/privacy}","received_events_url":"https://api.github.com/users/VesialouIvan/received_events","type":"User","site_admin":false},"repo":{"id":135342311,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNDIzMTE=","name":"406853-kekstagram","full_name":"VesialouIvan/406853-kekstagram","owner":{"login":"VesialouIvan","id":33086705,"node_id":"MDQ6VXNlcjMzMDg2NzA1","avatar_url":"https://avatars0.githubusercontent.com/u/33086705?v=4","gravatar_id":"","url":"https://api.github.com/users/VesialouIvan","html_url":"https://github.com/VesialouIvan","followers_url":"https://api.github.com/users/VesialouIvan/followers","following_url":"https://api.github.com/users/VesialouIvan/following{/other_user}","gists_url":"https://api.github.com/users/VesialouIvan/gists{/gist_id}","starred_url":"https://api.github.com/users/VesialouIvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VesialouIvan/subscriptions","organizations_url":"https://api.github.com/users/VesialouIvan/orgs","repos_url":"https://api.github.com/users/VesialouIvan/repos","events_url":"https://api.github.com/users/VesialouIvan/events{/privacy}","received_events_url":"https://api.github.com/users/VesialouIvan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VesialouIvan/406853-kekstagram","description":"Иван Веселов","fork":true,"url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram","forks_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/forks","keys_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/teams","hooks_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/hooks","issue_events_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/issues/events{/number}","events_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/events","assignees_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/assignees{/user}","branches_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/branches{/branch}","tags_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/tags","blobs_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/git/refs{/sha}","trees_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/statuses/{sha}","languages_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/languages","stargazers_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/stargazers","contributors_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/contributors","subscribers_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/subscribers","subscription_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/subscription","commits_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/commits{/sha}","git_commits_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/git/commits{/sha}","comments_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/comments{/number}","issue_comment_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/issues/comments{/number}","contents_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/contents/{+path}","compare_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/merges","archive_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/downloads","issues_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/issues{/number}","pulls_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/pulls{/number}","milestones_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/milestones{/number}","notifications_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/labels{/name}","releases_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/releases{/id}","deployments_url":"https://api.github.com/repos/VesialouIvan/406853-kekstagram/deployments","created_at":"2018-05-29T19:16:55Z","updated_at":"2018-06-19T15:42:14Z","pushed_at":"2018-06-19T19:23:53Z","git_url":"git://github.com/VesialouIvan/406853-kekstagram.git","ssh_url":"git@github.com:VesialouIvan/406853-kekstagram.git","clone_url":"https://github.com/VesialouIvan/406853-kekstagram.git","svn_url":"https://github.com/VesialouIvan/406853-kekstagram","homepage":null,"size":2202,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"a7e519a259d8d893b436d4093b5d0075e1dfad18","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":135341343,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNDEzNDM=","name":"406853-kekstagram","full_name":"htmlacademy-javascript/406853-kekstagram","owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-javascript/406853-kekstagram","description":"Иван Веселов","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram","forks_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/deployments","created_at":"2018-05-29T19:07:20Z","updated_at":"2018-06-17T02:11:05Z","pushed_at":"2018-06-20T01:48:21Z","git_url":"git://github.com/htmlacademy-javascript/406853-kekstagram.git","ssh_url":"git@github.com:htmlacademy-javascript/406853-kekstagram.git","clone_url":"https://github.com/htmlacademy-javascript/406853-kekstagram.git","svn_url":"https://github.com/htmlacademy-javascript/406853-kekstagram","homepage":"https://github.com/VesialouIvan/406853-kekstagram","size":2205,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3"},"html":{"href":"https://github.com/htmlacademy-javascript/406853-kekstagram/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram/statuses/ec094ca79680289ca9ce8fa892cdb93b8ff0e52f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 135341343,
"name": "htmlacademy-javascript/406853-kekstagram",
"url": "https://api.github.com/repos/htmlacademy-javascript/406853-kekstagram"
} | {
"id": 21310048,
"login": "SPavelhjk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21310048?",
"url": "https://api.github.com/users/SPavelhjk"
} | {
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
} | 2018-06-20T01:55:06 | 7849174649 | {"actor":{"display_login":"SPavelhjk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/comments/241512907","pull_request_review_id":184805434,"id":241512907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTUxMjkwNw==","diff_hunk":"@@ -0,0 +1,170 @@\n+'use strict';\n+var CARD_TYPES = ['palace', 'flat', 'house', 'bungalo'];\n+var CARD_CHECK_INS = ['12:00', '13:00', '14:00'];\n+var CARD_COUNT = 8;\n+var MIN_PRICE = 1000;\n+var MAX_PRICE = 1000000;\n+var MAX_ROOMS_COUNT = 5;\n+var MAX_GUESTS = 20;\n+var MIN_X_POSITION = 50;\n+var MAX_X_POSITION = 1000;\n+var MIN_Y_POSITION = 130;\n+var MAX_Y_POSITION = 630;\n+var MAP_PIN_WIDTH = 40;\n+var MAP_PIN_HEIGHT = 60;\n+var CARD_POPUP_NUMBER = 0;\n+var CARD_TITLES = [\n+ 'Большая уютная квартира',\n+ 'Маленькая неуютная квартира',\n+ 'Огромный прекрасный дворец',\n+ 'Маленький ужасный дворец',\n+ 'Красивый гостевой домик',\n+ 'Некрасивый негостеприимный домик',\n+ 'Уютное бунгало далеко от моря',\n+ 'Неуютное бунгало по колено в воде'\n+];\n+var CARD_FEATURES = [\n+ 'wifi',\n+ 'dishwasher',\n+ 'parking',\n+ 'washer',\n+ 'elevator',\n+ 'conditioner'\n+];\n+var CARD_PHOTOS = [\n+ 'http://o0.github.io/assets/images/tokyo/hotel1.jpg',\n+ 'http://o0.github.io/assets/images/tokyo/hotel2.jpg',\n+ 'http://o0.github.io/assets/images/tokyo/hotel3.jpg'\n+];\n+\n+var getRandomInteger = function (min, max) {\n+ return Math.floor(Math.random() * (max - min + 1)) + min;\n+};\n+\n+var getRandomComparison = function () {\n+ return Math.random() - 0.5;\n+};\n+\n+var getArrayClone = function (arrayToClone) {\n+ var arrayCopy = arrayToClone.slice();\n+ arrayCopy.sort(getRandomComparison);\n+ return arrayCopy;\n+};\n+\n+var getCardFeatures = function (featuresNumber) {\n+ var cardFeaturesCopy = getArrayClone(CARD_FEATURES);\n+ var featuresList = cardFeaturesCopy.splice(featuresNumber - 1);\n+ return featuresList;\n+};\n+\n+var createPhotoNumbers = function (numberOfPhotos) {\n+ var photoNumbers = [];\n+ for (var i = 1; i < numberOfPhotos + 1; i++) {\n+ photoNumbers.push(i);\n+ }\n+ return photoNumbers;\n+};\n+\n+var getRusCardType = function (TypeToTranslate) {\n+ var cardTypesRus = TypeToTranslate;\n+ if (cardTypesRus === 'flat') {\n+ cardTypesRus = 'Квартира';\n+ } else if (cardTypesRus === 'bungalo') {\n+ cardTypesRus = 'Бунгало';\n+ } else if (cardTypesRus === 'palace') {\n+ cardTypesRus = 'Дворец';\n+ } else if (cardTypesRus === 'house') {\n+ cardTypesRus = 'Дом';\n+ }\n+ return cardTypesRus;\n+};\n+\n+var cardTitles = getArrayClone(CARD_TITLES).sort(getRandomComparison);\n+var cardTypes = getArrayClone(CARD_TYPES).sort(getRandomComparison);\n+var cardPhotos = getArrayClone(CARD_PHOTOS).sort(getRandomComparison);\n+var cardCheckIns = getArrayClone(CARD_CHECK_INS).sort(getRandomComparison);\n+var cardPhotoNumbers = createPhotoNumbers(CARD_COUNT).sort(getRandomComparison);","path":"js/main.js","position":86,"original_position":86,"commit_id":"c877a495c45066f7503db960594a6f9c881fefdc","original_commit_id":"c877a495c45066f7503db960594a6f9c881fefdc","user":{"login":"RangerDin","id":19785814,"node_id":"MDQ6VXNlcjE5Nzg1ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/19785814?v=4","gravatar_id":"","url":"https://api.github.com/users/RangerDin","html_url":"https://github.com/RangerDin","followers_url":"https://api.github.com/users/RangerDin/followers","following_url":"https://api.github.com/users/RangerDin/following{/other_user}","gists_url":"https://api.github.com/users/RangerDin/gists{/gist_id}","starred_url":"https://api.github.com/users/RangerDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RangerDin/subscriptions","organizations_url":"https://api.github.com/users/RangerDin/orgs","repos_url":"https://api.github.com/users/RangerDin/repos","events_url":"https://api.github.com/users/RangerDin/events{/privacy}","received_events_url":"https://api.github.com/users/RangerDin/received_events","type":"User","site_admin":false},"body":"Если держишь сгенерированные случайные данные в глобальной области видимости, то оформи их как константы.\r\nЛибо перенести в функцию, в которой они нужны.","created_at":"2018-12-13T18:30:18Z","updated_at":"2018-12-13T18:30:18Z","html_url":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2#discussion_r241512907","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/comments/241512907"},"html":{"href":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2#discussion_r241512907"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2","id":238158772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTU4Nzcy","html_url":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2","diff_url":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2.diff","patch_url":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/2","number":2,"state":"open","locked":false,"title":"Личный проект: пока все дома","user":{"login":"Shmitkin","id":39678755,"node_id":"MDQ6VXNlcjM5Njc4NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/39678755?v=4","gravatar_id":"","url":"https://api.github.com/users/Shmitkin","html_url":"https://github.com/Shmitkin","followers_url":"https://api.github.com/users/Shmitkin/followers","following_url":"https://api.github.com/users/Shmitkin/following{/other_user}","gists_url":"https://api.github.com/users/Shmitkin/gists{/gist_id}","starred_url":"https://api.github.com/users/Shmitkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shmitkin/subscriptions","organizations_url":"https://api.github.com/users/Shmitkin/orgs","repos_url":"https://api.github.com/users/Shmitkin/repos","events_url":"https://api.github.com/users/Shmitkin/events{/privacy}","received_events_url":"https://api.github.com/users/Shmitkin/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Личный проект: пока все дома](https://up.htmlacademy.ru/javascript/16/user/791669/tasks/13)","created_at":"2018-12-12T19:41:20Z","updated_at":"2018-12-13T18:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0d46676cae1e2c34bee7829458b08de9783fae0","assignee":{"login":"RangerDin","id":19785814,"node_id":"MDQ6VXNlcjE5Nzg1ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/19785814?v=4","gravatar_id":"","url":"https://api.github.com/users/RangerDin","html_url":"https://github.com/RangerDin","followers_url":"https://api.github.com/users/RangerDin/followers","following_url":"https://api.github.com/users/RangerDin/following{/other_user}","gists_url":"https://api.github.com/users/RangerDin/gists{/gist_id}","starred_url":"https://api.github.com/users/RangerDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RangerDin/subscriptions","organizations_url":"https://api.github.com/users/RangerDin/orgs","repos_url":"https://api.github.com/users/RangerDin/repos","events_url":"https://api.github.com/users/RangerDin/events{/privacy}","received_events_url":"https://api.github.com/users/RangerDin/received_events","type":"User","site_admin":false},"assignees":[{"login":"RangerDin","id":19785814,"node_id":"MDQ6VXNlcjE5Nzg1ODE0","avatar_url":"https://avatars1.githubusercontent.com/u/19785814?v=4","gravatar_id":"","url":"https://api.github.com/users/RangerDin","html_url":"https://github.com/RangerDin","followers_url":"https://api.github.com/users/RangerDin/followers","following_url":"https://api.github.com/users/RangerDin/following{/other_user}","gists_url":"https://api.github.com/users/RangerDin/gists{/gist_id}","starred_url":"https://api.github.com/users/RangerDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RangerDin/subscriptions","organizations_url":"https://api.github.com/users/RangerDin/orgs","repos_url":"https://api.github.com/users/RangerDin/repos","events_url":"https://api.github.com/users/RangerDin/events{/privacy}","received_events_url":"https://api.github.com/users/RangerDin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/2/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/statuses/c877a495c45066f7503db960594a6f9c881fefdc","head":{"label":"Shmitkin:module3-task1","ref":"module3-task1","sha":"c877a495c45066f7503db960594a6f9c881fefdc","user":{"login":"Shmitkin","id":39678755,"node_id":"MDQ6VXNlcjM5Njc4NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/39678755?v=4","gravatar_id":"","url":"https://api.github.com/users/Shmitkin","html_url":"https://github.com/Shmitkin","followers_url":"https://api.github.com/users/Shmitkin/followers","following_url":"https://api.github.com/users/Shmitkin/following{/other_user}","gists_url":"https://api.github.com/users/Shmitkin/gists{/gist_id}","starred_url":"https://api.github.com/users/Shmitkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shmitkin/subscriptions","organizations_url":"https://api.github.com/users/Shmitkin/orgs","repos_url":"https://api.github.com/users/Shmitkin/repos","events_url":"https://api.github.com/users/Shmitkin/events{/privacy}","received_events_url":"https://api.github.com/users/Shmitkin/received_events","type":"User","site_admin":false},"repo":{"id":159504336,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1MDQzMzY=","name":"791669-keksobooking","full_name":"Shmitkin/791669-keksobooking","private":false,"owner":{"login":"Shmitkin","id":39678755,"node_id":"MDQ6VXNlcjM5Njc4NzU1","avatar_url":"https://avatars3.githubusercontent.com/u/39678755?v=4","gravatar_id":"","url":"https://api.github.com/users/Shmitkin","html_url":"https://github.com/Shmitkin","followers_url":"https://api.github.com/users/Shmitkin/followers","following_url":"https://api.github.com/users/Shmitkin/following{/other_user}","gists_url":"https://api.github.com/users/Shmitkin/gists{/gist_id}","starred_url":"https://api.github.com/users/Shmitkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shmitkin/subscriptions","organizations_url":"https://api.github.com/users/Shmitkin/orgs","repos_url":"https://api.github.com/users/Shmitkin/repos","events_url":"https://api.github.com/users/Shmitkin/events{/privacy}","received_events_url":"https://api.github.com/users/Shmitkin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shmitkin/791669-keksobooking","description":"Олег Митькин","fork":true,"url":"https://api.github.com/repos/Shmitkin/791669-keksobooking","forks_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/forks","keys_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/teams","hooks_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/hooks","issue_events_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/issues/events{/number}","events_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/events","assignees_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/assignees{/user}","branches_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/branches{/branch}","tags_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/tags","blobs_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/statuses/{sha}","languages_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/languages","stargazers_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/stargazers","contributors_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/contributors","subscribers_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/subscribers","subscription_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/subscription","commits_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/contents/{+path}","compare_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/merges","archive_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/downloads","issues_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/issues{/number}","pulls_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/pulls{/number}","milestones_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/milestones{/number}","notifications_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/labels{/name}","releases_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/releases{/id}","deployments_url":"https://api.github.com/repos/Shmitkin/791669-keksobooking/deployments","created_at":"2018-11-28T13:13:10Z","updated_at":"2018-11-28T13:13:13Z","pushed_at":"2018-12-13T17:25:09Z","git_url":"git://github.com/Shmitkin/791669-keksobooking.git","ssh_url":"git@github.com:Shmitkin/791669-keksobooking.git","clone_url":"https://github.com/Shmitkin/791669-keksobooking.git","svn_url":"https://github.com/Shmitkin/791669-keksobooking","homepage":null,"size":884,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"a6713c836d525f386820434b44f744c43f0c3a6c","user":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":159504188,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1MDQxODg=","name":"791669-keksobooking","full_name":"htmlacademy-javascript/791669-keksobooking","private":false,"owner":{"login":"htmlacademy-javascript","id":14179712,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc5NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/htmlacademy-javascript/791669-keksobooking","description":"Олег Митькин","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking","forks_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/deployments","created_at":"2018-11-28T13:12:18Z","updated_at":"2018-11-28T13:29:23Z","pushed_at":"2018-12-13T17:25:11Z","git_url":"git://github.com/htmlacademy-javascript/791669-keksobooking.git","ssh_url":"git@github.com:htmlacademy-javascript/791669-keksobooking.git","clone_url":"https://github.com/htmlacademy-javascript/791669-keksobooking.git","svn_url":"https://github.com/htmlacademy-javascript/791669-keksobooking","homepage":"https://github.com/Shmitkin/791669-keksobooking","size":877,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2"},"html":{"href":"https://github.com/htmlacademy-javascript/791669-keksobooking/pull/2"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/2"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking/statuses/c877a495c45066f7503db960594a6f9c881fefdc"}},"author_association":"CONTRIBUTOR"}} | {
"id": 159504188,
"name": "htmlacademy-javascript/791669-keksobooking",
"url": "https://api.github.com/repos/htmlacademy-javascript/791669-keksobooking"
} | {
"id": 19785814,
"login": "RangerDin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19785814?",
"url": "https://api.github.com/users/RangerDin"
} | {
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
} | 2018-12-13T18:30:18 | 8750199226 | {"actor":{"display_login":"RangerDin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/comments/183218189","pull_request_review_id":114182205,"id":183218189,"diff_hunk":"@@ -0,0 +1,226 @@\n+'use strict';\n+\n+// Стартовые\n+var PRICE = {\n+ max: 1000000,\n+ min: 1000\n+};\n+\n+var GUEST = {\n+ min: 1,\n+ max: 10\n+};\n+\n+var TITLES = [\n+ 'Большая уютная квартира',\n+ 'Маленькая неуютная квартира',\n+ 'Огромный прекрасный дворец',\n+ 'Маленький ужасный дворец',\n+ 'Красивый гостевой домик',\n+ 'Некрасивый негостеприимный домик',\n+ 'Уютное бунгало далеко от моря',\n+ 'Неуютное бунгало по колено в воде'\n+];\n+\n+var TYPES = [\n+ 'palace',\n+ 'flat',\n+ 'house',\n+ 'bungalo'\n+];\n+\n+var VAR_ROOMS = {\n+ min: 1,\n+ max: 5\n+};\n+\n+var CHECKOUT_TIMES = [\n+ '12:00',\n+ '13:00',\n+ '14:00'\n+];\n+\n+var FEATURES = [\n+ 'wifi',\n+ 'dishwasher',\n+ 'parking',\n+ 'washer',\n+ 'elevator',\n+ 'conditioner'\n+];\n+\n+var PIN_HEIGHT = 40;\n+var PIN_WIDTH = 44;\n+\n+var COORD = {\n+ X: {\n+ min: 300,\n+ max: 900\n+ },\n+ Y: {\n+ min: 150,\n+ max: 500\n+ }\n+};\n+\n+var PHOTOS = [\n+ 'http://o0.github.io/assets/images/tokyo/hotel1.jpg',\n+ 'http://o0.github.io/assets/images/tokyo/hotel2.jpg',\n+ 'http://o0.github.io/assets/images/tokyo/hotel3.jpg'\n+];\n+\n+// карту и блок объявления из неактивного состояния в активное\n+var userUp = document.querySelector('.map');\n+userUp.classList.remove('map--faded');\n+var userSup = document.querySelector('.ad-form');\n+userSup.classList.remove('ad-form--disabled');\n+\n+// функция случайного числа\n+var getRandomInteger = function (min, max) {\n+ return Math.floor(Math.random() * (max - min + 1) + min);\n+};\n+\n+// функция создания массива аватарок\n+var getAvatars = function () {","path":"js/map.js","position":84,"original_position":84,"commit_id":"dc450f480e492b626868afc118d8b1e30a81a76f","original_commit_id":"dc450f480e492b626868afc118d8b1e30a81a76f","user":{"login":"AnnTV","id":12914050,"avatar_url":"https://avatars2.githubusercontent.com/u/12914050?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnTV","html_url":"https://github.com/AnnTV","followers_url":"https://api.github.com/users/AnnTV/followers","following_url":"https://api.github.com/users/AnnTV/following{/other_user}","gists_url":"https://api.github.com/users/AnnTV/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnTV/subscriptions","organizations_url":"https://api.github.com/users/AnnTV/orgs","repos_url":"https://api.github.com/users/AnnTV/repos","events_url":"https://api.github.com/users/AnnTV/events{/privacy}","received_events_url":"https://api.github.com/users/AnnTV/received_events","type":"User","site_admin":false},"body":"здесь снова лучше воспользоваться push\r\nи свернуть if в тернарный оператор\r\n","created_at":"2018-04-21T20:16:27Z","updated_at":"2018-04-21T20:26:28Z","html_url":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4#discussion_r183218189","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/comments/183218189"},"html":{"href":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4#discussion_r183218189"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4","id":182865929,"html_url":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4","diff_url":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4.diff","patch_url":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/4","number":4,"state":"open","locked":false,"title":"Личный проект: милый DOM","user":{"login":"SrgKuz","id":37806143,"avatar_url":"https://avatars2.githubusercontent.com/u/37806143?v=4","gravatar_id":"","url":"https://api.github.com/users/SrgKuz","html_url":"https://github.com/SrgKuz","followers_url":"https://api.github.com/users/SrgKuz/followers","following_url":"https://api.github.com/users/SrgKuz/following{/other_user}","gists_url":"https://api.github.com/users/SrgKuz/gists{/gist_id}","starred_url":"https://api.github.com/users/SrgKuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SrgKuz/subscriptions","organizations_url":"https://api.github.com/users/SrgKuz/orgs","repos_url":"https://api.github.com/users/SrgKuz/repos","events_url":"https://api.github.com/users/SrgKuz/events{/privacy}","received_events_url":"https://api.github.com/users/SrgKuz/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Личный проект: милый DOM](https://up.htmlacademy.ru/javascript/13/user/482063/tasks/13)","created_at":"2018-04-19T18:49:57Z","updated_at":"2018-04-21T20:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5e3794aed8386baed4296e0ae1d2d73a39c5378","assignee":{"login":"AnnTV","id":12914050,"avatar_url":"https://avatars2.githubusercontent.com/u/12914050?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnTV","html_url":"https://github.com/AnnTV","followers_url":"https://api.github.com/users/AnnTV/followers","following_url":"https://api.github.com/users/AnnTV/following{/other_user}","gists_url":"https://api.github.com/users/AnnTV/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnTV/subscriptions","organizations_url":"https://api.github.com/users/AnnTV/orgs","repos_url":"https://api.github.com/users/AnnTV/repos","events_url":"https://api.github.com/users/AnnTV/events{/privacy}","received_events_url":"https://api.github.com/users/AnnTV/received_events","type":"User","site_admin":false},"assignees":[{"login":"AnnTV","id":12914050,"avatar_url":"https://avatars2.githubusercontent.com/u/12914050?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnTV","html_url":"https://github.com/AnnTV","followers_url":"https://api.github.com/users/AnnTV/followers","following_url":"https://api.github.com/users/AnnTV/following{/other_user}","gists_url":"https://api.github.com/users/AnnTV/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnTV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnTV/subscriptions","organizations_url":"https://api.github.com/users/AnnTV/orgs","repos_url":"https://api.github.com/users/AnnTV/repos","events_url":"https://api.github.com/users/AnnTV/events{/privacy}","received_events_url":"https://api.github.com/users/AnnTV/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/4/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/statuses/dc450f480e492b626868afc118d8b1e30a81a76f","head":{"label":"SrgKuz:module3-task1","ref":"module3-task1","sha":"dc450f480e492b626868afc118d8b1e30a81a76f","user":{"login":"SrgKuz","id":37806143,"avatar_url":"https://avatars2.githubusercontent.com/u/37806143?v=4","gravatar_id":"","url":"https://api.github.com/users/SrgKuz","html_url":"https://github.com/SrgKuz","followers_url":"https://api.github.com/users/SrgKuz/followers","following_url":"https://api.github.com/users/SrgKuz/following{/other_user}","gists_url":"https://api.github.com/users/SrgKuz/gists{/gist_id}","starred_url":"https://api.github.com/users/SrgKuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SrgKuz/subscriptions","organizations_url":"https://api.github.com/users/SrgKuz/orgs","repos_url":"https://api.github.com/users/SrgKuz/repos","events_url":"https://api.github.com/users/SrgKuz/events{/privacy}","received_events_url":"https://api.github.com/users/SrgKuz/received_events","type":"User","site_admin":false},"repo":{"id":127037157,"name":"482063-keksobooking","full_name":"SrgKuz/482063-keksobooking","owner":{"login":"SrgKuz","id":37806143,"avatar_url":"https://avatars2.githubusercontent.com/u/37806143?v=4","gravatar_id":"","url":"https://api.github.com/users/SrgKuz","html_url":"https://github.com/SrgKuz","followers_url":"https://api.github.com/users/SrgKuz/followers","following_url":"https://api.github.com/users/SrgKuz/following{/other_user}","gists_url":"https://api.github.com/users/SrgKuz/gists{/gist_id}","starred_url":"https://api.github.com/users/SrgKuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SrgKuz/subscriptions","organizations_url":"https://api.github.com/users/SrgKuz/orgs","repos_url":"https://api.github.com/users/SrgKuz/repos","events_url":"https://api.github.com/users/SrgKuz/events{/privacy}","received_events_url":"https://api.github.com/users/SrgKuz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SrgKuz/482063-keksobooking","description":"Сергей Кузаков","fork":true,"url":"https://api.github.com/repos/SrgKuz/482063-keksobooking","forks_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/forks","keys_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/teams","hooks_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/hooks","issue_events_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/issues/events{/number}","events_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/events","assignees_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/assignees{/user}","branches_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/branches{/branch}","tags_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/tags","blobs_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/git/refs{/sha}","trees_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/statuses/{sha}","languages_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/languages","stargazers_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/stargazers","contributors_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/contributors","subscribers_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/subscribers","subscription_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/subscription","commits_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/commits{/sha}","git_commits_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/git/commits{/sha}","comments_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/comments{/number}","issue_comment_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/issues/comments{/number}","contents_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/contents/{+path}","compare_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/merges","archive_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/downloads","issues_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/issues{/number}","pulls_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/pulls{/number}","milestones_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/milestones{/number}","notifications_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/labels{/name}","releases_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/releases{/id}","deployments_url":"https://api.github.com/repos/SrgKuz/482063-keksobooking/deployments","created_at":"2018-03-27T19:38:41Z","updated_at":"2018-04-14T11:25:14Z","pushed_at":"2018-04-21T17:15:43Z","git_url":"git://github.com/SrgKuz/482063-keksobooking.git","ssh_url":"git@github.com:SrgKuz/482063-keksobooking.git","clone_url":"https://github.com/SrgKuz/482063-keksobooking.git","svn_url":"https://github.com/SrgKuz/482063-keksobooking","homepage":null,"size":597,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"484d1a0bfc5628a92520eec77a141eb1c8ff3b91","user":{"login":"htmlacademy-javascript","id":14179712,"avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":127034880,"name":"482063-keksobooking","full_name":"htmlacademy-javascript/482063-keksobooking","owner":{"login":"htmlacademy-javascript","id":14179712,"avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-javascript/482063-keksobooking","description":"Сергей Кузаков","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking","forks_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/deployments","created_at":"2018-03-27T19:17:53Z","updated_at":"2018-03-31T07:17:59Z","pushed_at":"2018-04-21T17:15:44Z","git_url":"git://github.com/htmlacademy-javascript/482063-keksobooking.git","ssh_url":"git@github.com:htmlacademy-javascript/482063-keksobooking.git","clone_url":"https://github.com/htmlacademy-javascript/482063-keksobooking.git","svn_url":"https://github.com/htmlacademy-javascript/482063-keksobooking","homepage":"https://github.com/SrgKuz/482063-keksobooking","size":578,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4"},"html":{"href":"https://github.com/htmlacademy-javascript/482063-keksobooking/pull/4"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/4"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking/statuses/dc450f480e492b626868afc118d8b1e30a81a76f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 127034880,
"name": "htmlacademy-javascript/482063-keksobooking",
"url": "https://api.github.com/repos/htmlacademy-javascript/482063-keksobooking"
} | {
"id": 12914050,
"login": "AnnTV",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12914050?",
"url": "https://api.github.com/users/AnnTV"
} | {
"id": 14179712,
"login": "htmlacademy-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14179712?",
"url": "https://api.github.com/orgs/htmlacademy-javascript"
} | 2018-04-21T20:16:27 | 7566429337 | {"actor":{"display_login":"AnnTV"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/comments/235417373","pull_request_review_id":177277111,"id":235417373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQxNzM3Mw==","diff_hunk":"@@ -9,16 +9,16 @@ source:\n sha256: 612a16f2bba580c47183e4f752ed40b034852541ca3e96e480d01fb30ad9570c\n \n build:\n- number: 1\n- skip: True # [py27]\n+ number: 2\n+ noarch: python\n script: python -m pip install --no-deps --ignore-installed .\n entry_points:\n - snakemake = snakemake:main\n - snakemake-bash-completion = snakemake:bash_completion\n \n requirements:\n host:","path":"recipes/snakemake-minimal/meta.yaml","position":14,"original_position":14,"commit_id":"83e7ec8b6ab4e4eaf3da9e4bb4acfde8b9b6faf1","original_commit_id":"83e7ec8b6ab4e4eaf3da9e4bb4acfde8b9b6faf1","user":{"login":"johanneskoester","id":1858646,"node_id":"MDQ6VXNlcjE4NTg2NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1858646?v=4","gravatar_id":"","url":"https://api.github.com/users/johanneskoester","html_url":"https://github.com/johanneskoester","followers_url":"https://api.github.com/users/johanneskoester/followers","following_url":"https://api.github.com/users/johanneskoester/following{/other_user}","gists_url":"https://api.github.com/users/johanneskoester/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneskoester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneskoester/subscriptions","organizations_url":"https://api.github.com/users/johanneskoester/orgs","repos_url":"https://api.github.com/users/johanneskoester/repos","events_url":"https://api.github.com/users/johanneskoester/events{/privacy}","received_events_url":"https://api.github.com/users/johanneskoester/received_events","type":"User","site_admin":false},"body":"Yes indeed. It was necessary in some previous release. But not anymore.","created_at":"2018-11-21T14:52:51Z","updated_at":"2018-11-21T14:52:51Z","html_url":"https://github.com/bioconda/bioconda-recipes/pull/12274#discussion_r235417373","pull_request_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/comments/235417373"},"html":{"href":"https://github.com/bioconda/bioconda-recipes/pull/12274#discussion_r235417373"},"pull_request":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274"}},"in_reply_to_id":235350598},"pull_request":{"url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274","id":232618504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjE4NTA0","html_url":"https://github.com/bioconda/bioconda-recipes/pull/12274","diff_url":"https://github.com/bioconda/bioconda-recipes/pull/12274.diff","patch_url":"https://github.com/bioconda/bioconda-recipes/pull/12274.patch","issue_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/12274","number":12274,"state":"open","locked":false,"title":"Make snakemake a noarch package.","user":{"login":"johanneskoester","id":1858646,"node_id":"MDQ6VXNlcjE4NTg2NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1858646?v=4","gravatar_id":"","url":"https://api.github.com/users/johanneskoester","html_url":"https://github.com/johanneskoester","followers_url":"https://api.github.com/users/johanneskoester/followers","following_url":"https://api.github.com/users/johanneskoester/following{/other_user}","gists_url":"https://api.github.com/users/johanneskoester/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneskoester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneskoester/subscriptions","organizations_url":"https://api.github.com/users/johanneskoester/orgs","repos_url":"https://api.github.com/users/johanneskoester/repos","events_url":"https://api.github.com/users/johanneskoester/events{/privacy}","received_events_url":"https://api.github.com/users/johanneskoester/received_events","type":"User","site_admin":false},"body":"* [x] I have read the [guidelines for bioconda recipes](https://bioconda.github.io/guidelines.html).\r\n* [ ] This PR adds a new recipe.\r\n* [x] AFAIK, this recipe **is directly relevant to the biological sciences** (otherwise, please submit to the more general purpose [conda-forge channel](https://conda-forge.org/docs/)).\r\n* [x] This PR updates an existing recipe.\r\n* [ ] This PR does something else (explain below).\r\n","created_at":"2018-11-21T10:52:22Z","updated_at":"2018-11-21T14:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db20a030f39a38eb64a07d62a3e8ef0b0172e842","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274/commits","review_comments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274/comments","review_comment_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/12274/comments","statuses_url":"https://api.github.com/repos/bioconda/bioconda-recipes/statuses/83e7ec8b6ab4e4eaf3da9e4bb4acfde8b9b6faf1","head":{"label":"bioconda:snakemake-noarch","ref":"snakemake-noarch","sha":"83e7ec8b6ab4e4eaf3da9e4bb4acfde8b9b6faf1","user":{"login":"bioconda","id":14253259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjUzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14253259?v=4","gravatar_id":"","url":"https://api.github.com/users/bioconda","html_url":"https://github.com/bioconda","followers_url":"https://api.github.com/users/bioconda/followers","following_url":"https://api.github.com/users/bioconda/following{/other_user}","gists_url":"https://api.github.com/users/bioconda/gists{/gist_id}","starred_url":"https://api.github.com/users/bioconda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bioconda/subscriptions","organizations_url":"https://api.github.com/users/bioconda/orgs","repos_url":"https://api.github.com/users/bioconda/repos","events_url":"https://api.github.com/users/bioconda/events{/privacy}","received_events_url":"https://api.github.com/users/bioconda/received_events","type":"Organization","site_admin":false},"repo":{"id":42372094,"node_id":"MDEwOlJlcG9zaXRvcnk0MjM3MjA5NA==","name":"bioconda-recipes","full_name":"bioconda/bioconda-recipes","private":false,"owner":{"login":"bioconda","id":14253259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjUzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14253259?v=4","gravatar_id":"","url":"https://api.github.com/users/bioconda","html_url":"https://github.com/bioconda","followers_url":"https://api.github.com/users/bioconda/followers","following_url":"https://api.github.com/users/bioconda/following{/other_user}","gists_url":"https://api.github.com/users/bioconda/gists{/gist_id}","starred_url":"https://api.github.com/users/bioconda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bioconda/subscriptions","organizations_url":"https://api.github.com/users/bioconda/orgs","repos_url":"https://api.github.com/users/bioconda/repos","events_url":"https://api.github.com/users/bioconda/events{/privacy}","received_events_url":"https://api.github.com/users/bioconda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bioconda/bioconda-recipes","description":"Conda recipes for the bioconda channel.","fork":false,"url":"https://api.github.com/repos/bioconda/bioconda-recipes","forks_url":"https://api.github.com/repos/bioconda/bioconda-recipes/forks","keys_url":"https://api.github.com/repos/bioconda/bioconda-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bioconda/bioconda-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bioconda/bioconda-recipes/teams","hooks_url":"https://api.github.com/repos/bioconda/bioconda-recipes/hooks","issue_events_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/bioconda/bioconda-recipes/events","assignees_url":"https://api.github.com/repos/bioconda/bioconda-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/bioconda/bioconda-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/bioconda/bioconda-recipes/tags","blobs_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bioconda/bioconda-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/bioconda/bioconda-recipes/languages","stargazers_url":"https://api.github.com/repos/bioconda/bioconda-recipes/stargazers","contributors_url":"https://api.github.com/repos/bioconda/bioconda-recipes/contributors","subscribers_url":"https://api.github.com/repos/bioconda/bioconda-recipes/subscribers","subscription_url":"https://api.github.com/repos/bioconda/bioconda-recipes/subscription","commits_url":"https://api.github.com/repos/bioconda/bioconda-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bioconda/bioconda-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/bioconda/bioconda-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bioconda/bioconda-recipes/merges","archive_url":"https://api.github.com/repos/bioconda/bioconda-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bioconda/bioconda-recipes/downloads","issues_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/bioconda/bioconda-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/bioconda/bioconda-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bioconda/bioconda-recipes/labels{/name}","releases_url":"https://api.github.com/repos/bioconda/bioconda-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/deployments","created_at":"2015-09-12T20:33:30Z","updated_at":"2018-11-21T11:15:18Z","pushed_at":"2018-11-21T14:31:10Z","git_url":"git://github.com/bioconda/bioconda-recipes.git","ssh_url":"git@github.com:bioconda/bioconda-recipes.git","clone_url":"https://github.com/bioconda/bioconda-recipes.git","svn_url":"https://github.com/bioconda/bioconda-recipes","homepage":"https://bioconda.github.io","size":177630,"stargazers_count":840,"watchers_count":840,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":897,"mirror_url":null,"archived":false,"open_issues_count":551,"license":null,"forks":897,"open_issues":551,"watchers":840,"default_branch":"master"}},"base":{"label":"bioconda:master","ref":"master","sha":"13453d3f5a6b174cdaeadd77999315b582440571","user":{"login":"bioconda","id":14253259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjUzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14253259?v=4","gravatar_id":"","url":"https://api.github.com/users/bioconda","html_url":"https://github.com/bioconda","followers_url":"https://api.github.com/users/bioconda/followers","following_url":"https://api.github.com/users/bioconda/following{/other_user}","gists_url":"https://api.github.com/users/bioconda/gists{/gist_id}","starred_url":"https://api.github.com/users/bioconda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bioconda/subscriptions","organizations_url":"https://api.github.com/users/bioconda/orgs","repos_url":"https://api.github.com/users/bioconda/repos","events_url":"https://api.github.com/users/bioconda/events{/privacy}","received_events_url":"https://api.github.com/users/bioconda/received_events","type":"Organization","site_admin":false},"repo":{"id":42372094,"node_id":"MDEwOlJlcG9zaXRvcnk0MjM3MjA5NA==","name":"bioconda-recipes","full_name":"bioconda/bioconda-recipes","private":false,"owner":{"login":"bioconda","id":14253259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjUzMjU5","avatar_url":"https://avatars3.githubusercontent.com/u/14253259?v=4","gravatar_id":"","url":"https://api.github.com/users/bioconda","html_url":"https://github.com/bioconda","followers_url":"https://api.github.com/users/bioconda/followers","following_url":"https://api.github.com/users/bioconda/following{/other_user}","gists_url":"https://api.github.com/users/bioconda/gists{/gist_id}","starred_url":"https://api.github.com/users/bioconda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bioconda/subscriptions","organizations_url":"https://api.github.com/users/bioconda/orgs","repos_url":"https://api.github.com/users/bioconda/repos","events_url":"https://api.github.com/users/bioconda/events{/privacy}","received_events_url":"https://api.github.com/users/bioconda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bioconda/bioconda-recipes","description":"Conda recipes for the bioconda channel.","fork":false,"url":"https://api.github.com/repos/bioconda/bioconda-recipes","forks_url":"https://api.github.com/repos/bioconda/bioconda-recipes/forks","keys_url":"https://api.github.com/repos/bioconda/bioconda-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bioconda/bioconda-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bioconda/bioconda-recipes/teams","hooks_url":"https://api.github.com/repos/bioconda/bioconda-recipes/hooks","issue_events_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/bioconda/bioconda-recipes/events","assignees_url":"https://api.github.com/repos/bioconda/bioconda-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/bioconda/bioconda-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/bioconda/bioconda-recipes/tags","blobs_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bioconda/bioconda-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/bioconda/bioconda-recipes/languages","stargazers_url":"https://api.github.com/repos/bioconda/bioconda-recipes/stargazers","contributors_url":"https://api.github.com/repos/bioconda/bioconda-recipes/contributors","subscribers_url":"https://api.github.com/repos/bioconda/bioconda-recipes/subscribers","subscription_url":"https://api.github.com/repos/bioconda/bioconda-recipes/subscription","commits_url":"https://api.github.com/repos/bioconda/bioconda-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bioconda/bioconda-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bioconda/bioconda-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/bioconda/bioconda-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bioconda/bioconda-recipes/merges","archive_url":"https://api.github.com/repos/bioconda/bioconda-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bioconda/bioconda-recipes/downloads","issues_url":"https://api.github.com/repos/bioconda/bioconda-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/bioconda/bioconda-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/bioconda/bioconda-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bioconda/bioconda-recipes/labels{/name}","releases_url":"https://api.github.com/repos/bioconda/bioconda-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/bioconda/bioconda-recipes/deployments","created_at":"2015-09-12T20:33:30Z","updated_at":"2018-11-21T11:15:18Z","pushed_at":"2018-11-21T14:31:10Z","git_url":"git://github.com/bioconda/bioconda-recipes.git","ssh_url":"git@github.com:bioconda/bioconda-recipes.git","clone_url":"https://github.com/bioconda/bioconda-recipes.git","svn_url":"https://github.com/bioconda/bioconda-recipes","homepage":"https://bioconda.github.io","size":177630,"stargazers_count":840,"watchers_count":840,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":897,"mirror_url":null,"archived":false,"open_issues_count":551,"license":null,"forks":897,"open_issues":551,"watchers":840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274"},"html":{"href":"https://github.com/bioconda/bioconda-recipes/pull/12274"},"issue":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/12274"},"comments":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/issues/12274/comments"},"review_comments":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274/comments"},"review_comment":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/pulls/12274/commits"},"statuses":{"href":"https://api.github.com/repos/bioconda/bioconda-recipes/statuses/83e7ec8b6ab4e4eaf3da9e4bb4acfde8b9b6faf1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 42372094,
"name": "bioconda/bioconda-recipes",
"url": "https://api.github.com/repos/bioconda/bioconda-recipes"
} | {
"id": 1858646,
"login": "johanneskoester",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1858646?",
"url": "https://api.github.com/users/johanneskoester"
} | {
"id": 14253259,
"login": "bioconda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14253259?",
"url": "https://api.github.com/orgs/bioconda"
} | 2018-11-21T14:52:51 | 8627398098 | {"actor":{"display_login":"johanneskoester"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/comments/171083318","pull_request_review_id":99874799,"id":171083318,"diff_hunk":"@@ -0,0 +1,273 @@\n+import {computed, useStrict, when} from 'mobx';\n+\n+import {Failable} from '.';","path":"src/failable/derived.test.ts","position":3,"original_position":3,"commit_id":"ae12d34b9074ea67b0db27ef95641b30d0c3f515","original_commit_id":"ae12d34b9074ea67b0db27ef95641b30d0c3f515","user":{"login":"benbayard","id":1026035,"avatar_url":"https://avatars0.githubusercontent.com/u/1026035?v=4","gravatar_id":"","url":"https://api.github.com/users/benbayard","html_url":"https://github.com/benbayard","followers_url":"https://api.github.com/users/benbayard/followers","following_url":"https://api.github.com/users/benbayard/following{/other_user}","gists_url":"https://api.github.com/users/benbayard/gists{/gist_id}","starred_url":"https://api.github.com/users/benbayard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbayard/subscriptions","organizations_url":"https://api.github.com/users/benbayard/orgs","repos_url":"https://api.github.com/users/benbayard/repos","events_url":"https://api.github.com/users/benbayard/events{/privacy}","received_events_url":"https://api.github.com/users/benbayard/received_events","type":"User","site_admin":false},"body":"it seems like the last bit is what needs enforcing:\r\n\r\n Groups of imports are delineated by blank lines. You can use these to group imports\r\n however you like, e.g. by first- vs. third-party or thematically or can you can\r\n enforce a grouping of third-party, parent directories and the current directory.\r\n\r\nI don't see the config for that enforcement though. ","created_at":"2018-02-27T22:08:34Z","updated_at":"2018-02-27T22:08:34Z","html_url":"https://github.com/UrbanDoor/mobx-failable/pull/3#discussion_r171083318","pull_request_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/comments/171083318"},"html":{"href":"https://github.com/UrbanDoor/mobx-failable/pull/3#discussion_r171083318"},"pull_request":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3"}},"in_reply_to_id":171033829},"pull_request":{"url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3","id":165025429,"html_url":"https://github.com/UrbanDoor/mobx-failable/pull/3","diff_url":"https://github.com/UrbanDoor/mobx-failable/pull/3.diff","patch_url":"https://github.com/UrbanDoor/mobx-failable/pull/3.patch","issue_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/3","number":3,"state":"open","locked":false,"title":"Readonly Futures and derivations","user":{"login":"kourge","id":6445,"avatar_url":"https://avatars3.githubusercontent.com/u/6445?v=4","gravatar_id":"","url":"https://api.github.com/users/kourge","html_url":"https://github.com/kourge","followers_url":"https://api.github.com/users/kourge/followers","following_url":"https://api.github.com/users/kourge/following{/other_user}","gists_url":"https://api.github.com/users/kourge/gists{/gist_id}","starred_url":"https://api.github.com/users/kourge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kourge/subscriptions","organizations_url":"https://api.github.com/users/kourge/orgs","repos_url":"https://api.github.com/users/kourge/repos","events_url":"https://api.github.com/users/kourge/events{/privacy}","received_events_url":"https://api.github.com/users/kourge/received_events","type":"User","site_admin":false},"body":"This is ongoing work for https://github.com/UrbanDoor/mobx-failable/issues/2, which proposes _read-only futures_, which is the read-only variant of a `Future` (the common interface uniting `Failable` and `Loadable`), as well as _derived futures_, which are read-only futures whose state and value are twinned with the futures from which they derive. Rebases will occur frequently. Note that a large part of this is inspired by [`com.twitter.util.Future`](https://twitter.github.io/util/docs/com/twitter/util/Future.html).\r\n\r\n### Happenings past, present, and future\r\nHere is a combined checklist that is both a commit highlight reel as well as a to-do list:\r\n- [x] 9f70a93, Introduce `ReadonlyFuture<T>`\r\n- [x] d7aba5e, Reshape `Future.DeriveOptions`, which describes the option object that the slated `.derive(...)` method takes. The intent is that it should not be possible to say `.derive({})`.\r\n- [x] e76adbe, Initial `DerivedFailable<T>` implementation. This is an internal class that consumers should not directly instantiate.\r\n- [x] 58ecc23, Ensure that the mirroring of the underlying future happens consistently. For example, when a derived failable is constructed with only a success transform, it should still become a failure if its underlying future becomes a failure.\r\n- [x] 1ba56fb, Lots of tests! Maybe not enough. Please comment if there are any missing edge cases.\r\n- [x] 9a6f797, Implement and document `derive` and its shorthands `map` and `rescue`. See the link to the documentation for `com.twitter.util.Future` for comparison.\r\n- [x] 74af47d, Write tests for the shorthand methods.\r\n- [x] 137c8b7, Extend derivation support to `Loadable` as well. This involves restructuring the file system organization of it, just like `Failable`.\r\n- [x] 315da0c, Add the three new methods into the interfaces `Future` and `ReadonlyFuture`.\r\n\r\n### Examples\r\n\r\nTransforming success values:\r\n\r\n```ts\r\nconst asyncDates = new Failable<Date[]>();\r\nconst localeDates = asyncDates.map(dates => dates.map(d => d.toLocaleString()));\r\n// something mutates `asyncDates`\r\n// `localeDates` updates automatically\r\n```\r\n\r\nTransforming success to failure:\r\n\r\n```ts\r\ndeclare interface User { ... }\r\n\r\n// Throws if `Server.User` is malformed\r\ndeclare function verifyUser(in: Server.User): User;\r\n\r\nconst rawUserData = new Failable<Server.User>();\r\nconst user = rawUserData.map(verifyUser);\r\n```\r\n\r\nPlease, all nits are welcome. Bring 'em in.","created_at":"2018-01-25T04:11:46Z","updated_at":"2018-02-27T22:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c17adb383431a7d6111d83e92211d4cd669b0c3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3/commits","review_comments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3/comments","review_comment_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/3/comments","statuses_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/statuses/ae12d34b9074ea67b0db27ef95641b30d0c3f515","head":{"label":"UrbanDoor:readonly_future","ref":"readonly_future","sha":"ae12d34b9074ea67b0db27ef95641b30d0c3f515","user":{"login":"UrbanDoor","id":14318185,"avatar_url":"https://avatars1.githubusercontent.com/u/14318185?v=4","gravatar_id":"","url":"https://api.github.com/users/UrbanDoor","html_url":"https://github.com/UrbanDoor","followers_url":"https://api.github.com/users/UrbanDoor/followers","following_url":"https://api.github.com/users/UrbanDoor/following{/other_user}","gists_url":"https://api.github.com/users/UrbanDoor/gists{/gist_id}","starred_url":"https://api.github.com/users/UrbanDoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UrbanDoor/subscriptions","organizations_url":"https://api.github.com/users/UrbanDoor/orgs","repos_url":"https://api.github.com/users/UrbanDoor/repos","events_url":"https://api.github.com/users/UrbanDoor/events{/privacy}","received_events_url":"https://api.github.com/users/UrbanDoor/received_events","type":"Organization","site_admin":false},"repo":{"id":89973045,"name":"mobx-failable","full_name":"UrbanDoor/mobx-failable","owner":{"login":"UrbanDoor","id":14318185,"avatar_url":"https://avatars1.githubusercontent.com/u/14318185?v=4","gravatar_id":"","url":"https://api.github.com/users/UrbanDoor","html_url":"https://github.com/UrbanDoor","followers_url":"https://api.github.com/users/UrbanDoor/followers","following_url":"https://api.github.com/users/UrbanDoor/following{/other_user}","gists_url":"https://api.github.com/users/UrbanDoor/gists{/gist_id}","starred_url":"https://api.github.com/users/UrbanDoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UrbanDoor/subscriptions","organizations_url":"https://api.github.com/users/UrbanDoor/orgs","repos_url":"https://api.github.com/users/UrbanDoor/repos","events_url":"https://api.github.com/users/UrbanDoor/events{/privacy}","received_events_url":"https://api.github.com/users/UrbanDoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UrbanDoor/mobx-failable","description":"Simplified error handling in MobX","fork":false,"url":"https://api.github.com/repos/UrbanDoor/mobx-failable","forks_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/forks","keys_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/teams","hooks_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/hooks","issue_events_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/events{/number}","events_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/events","assignees_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/assignees{/user}","branches_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/branches{/branch}","tags_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/tags","blobs_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/refs{/sha}","trees_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/statuses/{sha}","languages_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/languages","stargazers_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/stargazers","contributors_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/contributors","subscribers_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/subscribers","subscription_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/subscription","commits_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/commits{/sha}","git_commits_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/commits{/sha}","comments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/comments{/number}","issue_comment_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/comments{/number}","contents_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/contents/{+path}","compare_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/merges","archive_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/downloads","issues_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues{/number}","pulls_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls{/number}","milestones_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/milestones{/number}","notifications_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/labels{/name}","releases_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/releases{/id}","deployments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/deployments","created_at":"2017-05-01T23:55:24Z","updated_at":"2018-01-29T21:16:55Z","pushed_at":"2018-02-27T03:52:59Z","git_url":"git://github.com/UrbanDoor/mobx-failable.git","ssh_url":"git@github.com:UrbanDoor/mobx-failable.git","clone_url":"https://github.com/UrbanDoor/mobx-failable.git","svn_url":"https://github.com/UrbanDoor/mobx-failable","homepage":null,"size":120,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"UrbanDoor:master","ref":"master","sha":"748063b045cce97f669d3b35af9ecd3a2e514add","user":{"login":"UrbanDoor","id":14318185,"avatar_url":"https://avatars1.githubusercontent.com/u/14318185?v=4","gravatar_id":"","url":"https://api.github.com/users/UrbanDoor","html_url":"https://github.com/UrbanDoor","followers_url":"https://api.github.com/users/UrbanDoor/followers","following_url":"https://api.github.com/users/UrbanDoor/following{/other_user}","gists_url":"https://api.github.com/users/UrbanDoor/gists{/gist_id}","starred_url":"https://api.github.com/users/UrbanDoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UrbanDoor/subscriptions","organizations_url":"https://api.github.com/users/UrbanDoor/orgs","repos_url":"https://api.github.com/users/UrbanDoor/repos","events_url":"https://api.github.com/users/UrbanDoor/events{/privacy}","received_events_url":"https://api.github.com/users/UrbanDoor/received_events","type":"Organization","site_admin":false},"repo":{"id":89973045,"name":"mobx-failable","full_name":"UrbanDoor/mobx-failable","owner":{"login":"UrbanDoor","id":14318185,"avatar_url":"https://avatars1.githubusercontent.com/u/14318185?v=4","gravatar_id":"","url":"https://api.github.com/users/UrbanDoor","html_url":"https://github.com/UrbanDoor","followers_url":"https://api.github.com/users/UrbanDoor/followers","following_url":"https://api.github.com/users/UrbanDoor/following{/other_user}","gists_url":"https://api.github.com/users/UrbanDoor/gists{/gist_id}","starred_url":"https://api.github.com/users/UrbanDoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UrbanDoor/subscriptions","organizations_url":"https://api.github.com/users/UrbanDoor/orgs","repos_url":"https://api.github.com/users/UrbanDoor/repos","events_url":"https://api.github.com/users/UrbanDoor/events{/privacy}","received_events_url":"https://api.github.com/users/UrbanDoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UrbanDoor/mobx-failable","description":"Simplified error handling in MobX","fork":false,"url":"https://api.github.com/repos/UrbanDoor/mobx-failable","forks_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/forks","keys_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/teams","hooks_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/hooks","issue_events_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/events{/number}","events_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/events","assignees_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/assignees{/user}","branches_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/branches{/branch}","tags_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/tags","blobs_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/refs{/sha}","trees_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/statuses/{sha}","languages_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/languages","stargazers_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/stargazers","contributors_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/contributors","subscribers_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/subscribers","subscription_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/subscription","commits_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/commits{/sha}","git_commits_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/git/commits{/sha}","comments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/comments{/number}","issue_comment_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/comments{/number}","contents_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/contents/{+path}","compare_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/merges","archive_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/downloads","issues_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues{/number}","pulls_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls{/number}","milestones_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/milestones{/number}","notifications_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/labels{/name}","releases_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/releases{/id}","deployments_url":"https://api.github.com/repos/UrbanDoor/mobx-failable/deployments","created_at":"2017-05-01T23:55:24Z","updated_at":"2018-01-29T21:16:55Z","pushed_at":"2018-02-27T03:52:59Z","git_url":"git://github.com/UrbanDoor/mobx-failable.git","ssh_url":"git@github.com:UrbanDoor/mobx-failable.git","clone_url":"https://github.com/UrbanDoor/mobx-failable.git","svn_url":"https://github.com/UrbanDoor/mobx-failable","homepage":null,"size":120,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3"},"html":{"href":"https://github.com/UrbanDoor/mobx-failable/pull/3"},"issue":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/3"},"comments":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/UrbanDoor/mobx-failable/statuses/ae12d34b9074ea67b0db27ef95641b30d0c3f515"}},"author_association":"CONTRIBUTOR"}} | {
"id": 89973045,
"name": "UrbanDoor/mobx-failable",
"url": "https://api.github.com/repos/UrbanDoor/mobx-failable"
} | {
"id": 1026035,
"login": "benbayard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1026035?",
"url": "https://api.github.com/users/benbayard"
} | {
"id": 14318185,
"login": "UrbanDoor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14318185?",
"url": "https://api.github.com/orgs/UrbanDoor"
} | 2018-02-27T22:08:34 | 7306454556 | {"actor":{"display_login":"benbayard"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/201658640","pull_request_review_id":136201298,"id":201658640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY1ODY0MA==","diff_hunk":"@@ -0,0 +1,131 @@\n+use futures_core::future::Future;\n+use futures_core::task::{self, AtomicWaker, Poll};\n+use std::marker::Unpin;\n+use std::mem::PinMut;\n+use std::sync::Arc;\n+use std::sync::atomic::{AtomicBool, Ordering};\n+\n+/// A future which can be remotely short-circuited using an `AbortHandle`.\n+#[derive(Debug, Clone)]\n+#[must_use = \"futures do nothing unless polled\"]\n+pub struct Abortable<T> {\n+ future: T,\n+ inner: Arc<AbortInner>,\n+}\n+\n+impl<T: Unpin> Unpin for Abortable<T> {}\n+\n+impl<T> Abortable<T> where T: Future {\n+ /// Creates a new `Abortable` future using an existing `AbortRegistration`.\n+ /// `AbortRegistration`s can be acquired through `AbortHandle::new`.\n+ ///\n+ /// When `abort` is called on the handle tied to `reg` or if `abort` has\n+ /// already been called, the future will complete immediately without making\n+ /// any further progress.\n+ pub fn new(future: T, reg: AbortRegistration) -> Self {","path":"futures-util/src/future/abortable.rs","position":25,"original_position":25,"commit_id":"8b0d4aeb522584bc25de70ab0d706665f139c845","original_commit_id":"8b0d4aeb522584bc25de70ab0d706665f139c845","user":{"login":"MajorBreakfast","id":340142,"node_id":"MDQ6VXNlcjM0MDE0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/340142?v=4","gravatar_id":"","url":"https://api.github.com/users/MajorBreakfast","html_url":"https://github.com/MajorBreakfast","followers_url":"https://api.github.com/users/MajorBreakfast/followers","following_url":"https://api.github.com/users/MajorBreakfast/following{/other_user}","gists_url":"https://api.github.com/users/MajorBreakfast/gists{/gist_id}","starred_url":"https://api.github.com/users/MajorBreakfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajorBreakfast/subscriptions","organizations_url":"https://api.github.com/users/MajorBreakfast/orgs","repos_url":"https://api.github.com/users/MajorBreakfast/repos","events_url":"https://api.github.com/users/MajorBreakfast/events{/privacy}","received_events_url":"https://api.github.com/users/MajorBreakfast/received_events","type":"User","site_admin":false},"body":"Probably should be private","created_at":"2018-07-11T11:42:52Z","updated_at":"2018-07-11T11:42:52Z","html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1079#discussion_r201658640","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments/201658640"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/1079#discussion_r201658640"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079","id":200552681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTUyNjgx","html_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1079","diff_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1079.diff","patch_url":"https://github.com/rust-lang-nursery/futures-rs/pull/1079.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1079","number":1079,"state":"open","locked":false,"title":"Add abortable combinator","user":{"login":"cramertj","id":5963049,"node_id":"MDQ6VXNlcjU5NjMwNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5963049?v=4","gravatar_id":"","url":"https://api.github.com/users/cramertj","html_url":"https://github.com/cramertj","followers_url":"https://api.github.com/users/cramertj/followers","following_url":"https://api.github.com/users/cramertj/following{/other_user}","gists_url":"https://api.github.com/users/cramertj/gists{/gist_id}","starred_url":"https://api.github.com/users/cramertj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramertj/subscriptions","organizations_url":"https://api.github.com/users/cramertj/orgs","repos_url":"https://api.github.com/users/cramertj/repos","events_url":"https://api.github.com/users/cramertj/events{/privacy}","received_events_url":"https://api.github.com/users/cramertj/received_events","type":"User","site_admin":false},"body":"Retargeting of #696\r\ncc @carllerche ","created_at":"2018-07-10T23:46:45Z","updated_at":"2018-07-11T11:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8da461aecb16c2c85148f73a58b90e5f2843e71f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1079/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/8b0d4aeb522584bc25de70ab0d706665f139c845","head":{"label":"cramertj:abort","ref":"abort","sha":"8b0d4aeb522584bc25de70ab0d706665f139c845","user":{"login":"cramertj","id":5963049,"node_id":"MDQ6VXNlcjU5NjMwNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5963049?v=4","gravatar_id":"","url":"https://api.github.com/users/cramertj","html_url":"https://github.com/cramertj","followers_url":"https://api.github.com/users/cramertj/followers","following_url":"https://api.github.com/users/cramertj/following{/other_user}","gists_url":"https://api.github.com/users/cramertj/gists{/gist_id}","starred_url":"https://api.github.com/users/cramertj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramertj/subscriptions","organizations_url":"https://api.github.com/users/cramertj/orgs","repos_url":"https://api.github.com/users/cramertj/repos","events_url":"https://api.github.com/users/cramertj/events{/privacy}","received_events_url":"https://api.github.com/users/cramertj/received_events","type":"User","site_admin":false},"repo":{"id":66052660,"node_id":"MDEwOlJlcG9zaXRvcnk2NjA1MjY2MA==","name":"futures-rs","full_name":"cramertj/futures-rs","owner":{"login":"cramertj","id":5963049,"node_id":"MDQ6VXNlcjU5NjMwNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5963049?v=4","gravatar_id":"","url":"https://api.github.com/users/cramertj","html_url":"https://github.com/cramertj","followers_url":"https://api.github.com/users/cramertj/followers","following_url":"https://api.github.com/users/cramertj/following{/other_user}","gists_url":"https://api.github.com/users/cramertj/gists{/gist_id}","starred_url":"https://api.github.com/users/cramertj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramertj/subscriptions","organizations_url":"https://api.github.com/users/cramertj/orgs","repos_url":"https://api.github.com/users/cramertj/repos","events_url":"https://api.github.com/users/cramertj/events{/privacy}","received_events_url":"https://api.github.com/users/cramertj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cramertj/futures-rs","description":"Zero-cost futures and streams in Rust","fork":true,"url":"https://api.github.com/repos/cramertj/futures-rs","forks_url":"https://api.github.com/repos/cramertj/futures-rs/forks","keys_url":"https://api.github.com/repos/cramertj/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cramertj/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cramertj/futures-rs/teams","hooks_url":"https://api.github.com/repos/cramertj/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/cramertj/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/cramertj/futures-rs/events","assignees_url":"https://api.github.com/repos/cramertj/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/cramertj/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/cramertj/futures-rs/tags","blobs_url":"https://api.github.com/repos/cramertj/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cramertj/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cramertj/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cramertj/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cramertj/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/cramertj/futures-rs/languages","stargazers_url":"https://api.github.com/repos/cramertj/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/cramertj/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/cramertj/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/cramertj/futures-rs/subscription","commits_url":"https://api.github.com/repos/cramertj/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cramertj/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cramertj/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cramertj/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cramertj/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/cramertj/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cramertj/futures-rs/merges","archive_url":"https://api.github.com/repos/cramertj/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cramertj/futures-rs/downloads","issues_url":"https://api.github.com/repos/cramertj/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/cramertj/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/cramertj/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/cramertj/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cramertj/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/cramertj/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/cramertj/futures-rs/deployments","created_at":"2016-08-19T04:30:33Z","updated_at":"2016-08-19T04:30:34Z","pushed_at":"2018-07-10T23:47:09Z","git_url":"git://github.com/cramertj/futures-rs.git","ssh_url":"git@github.com:cramertj/futures-rs.git","clone_url":"https://github.com/cramertj/futures-rs.git","svn_url":"https://github.com/cramertj/futures-rs","homepage":"http://alexcrichton.com/futures-rs","size":4992,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:0.3","ref":"0.3","sha":"ba4ec7f908beb7ca8ef838ebb23b760f055684fe","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":55077261,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA3NzI2MQ==","name":"futures-rs","full_name":"rust-lang-nursery/futures-rs","owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/futures-rs","description":"Zero-cost futures and streams in Rust","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/futures-rs","forks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/futures-rs/deployments","created_at":"2016-03-30T16:03:08Z","updated_at":"2018-07-11T05:32:38Z","pushed_at":"2018-07-11T11:29:02Z","git_url":"git://github.com/rust-lang-nursery/futures-rs.git","ssh_url":"git@github.com:rust-lang-nursery/futures-rs.git","clone_url":"https://github.com/rust-lang-nursery/futures-rs.git","svn_url":"https://github.com/rust-lang-nursery/futures-rs","homepage":"https://docs.rs/futures","size":13384,"stargazers_count":2068,"watchers_count":2068,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":247,"open_issues":90,"watchers":2068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079"},"html":{"href":"https://github.com/rust-lang-nursery/futures-rs/pull/1079"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1079"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/futures-rs/statuses/8b0d4aeb522584bc25de70ab0d706665f139c845"}},"author_association":"COLLABORATOR"}} | {
"id": 55077261,
"name": "rust-lang-nursery/futures-rs",
"url": "https://api.github.com/repos/rust-lang-nursery/futures-rs"
} | {
"id": 340142,
"login": "MajorBreakfast",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/340142?",
"url": "https://api.github.com/users/MajorBreakfast"
} | {
"id": 14631425,
"login": "rust-lang-nursery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14631425?",
"url": "https://api.github.com/orgs/rust-lang-nursery"
} | 2018-07-11T11:42:52 | 7949523884 | {"actor":{"display_login":"MajorBreakfast"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments/244906999","pull_request_review_id":188893651,"id":244906999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDkwNjk5OQ==","diff_hunk":"@@ -6,13 +6,13 @@ can be evaluated at compile-time.\n \n ## Constant expressions\n \n-Certain types of expressions can be evaluated at compile time. These are called\n-_constant expressions_ and are required in const contexts. In\n-other places, such as in [`let` statements](statements.html#let-statements),\n-constant expressions may be evaluated at compile time. If errors, such as out\n-of bounds [array indexing] or [overflow] occurs,\n-then it is a compiler error if the value must be evaluated at compile time,\n-otherwise it is just a warning, but the code will most likely panic when run.\n+Certain types of expressions, called constant expressions, can be evaluated at\n+compile time. In [const contexts](#const-context), these are the only allowed\n+expressions, and are always evaluated at compile time. In other places, such as\n+in [`let` statements](statements.html#let-statements), constant expressions are","path":"src/const_eval.md","position":14,"original_position":14,"commit_id":"9b6041d57445568b48c0d8ace8c3bceee22de266","original_commit_id":"9b6041d57445568b48c0d8ace8c3bceee22de266","user":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n[`let` statements](statements.html#let-statements), constant expressions are\r\n```","created_at":"2019-01-03T03:24:43Z","updated_at":"2019-01-03T03:33:03Z","html_url":"https://github.com/rust-lang-nursery/reference/pull/498#discussion_r244906999","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments/244906999"},"html":{"href":"https://github.com/rust-lang-nursery/reference/pull/498#discussion_r244906999"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498","id":241897802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODk3ODAy","html_url":"https://github.com/rust-lang-nursery/reference/pull/498","diff_url":"https://github.com/rust-lang-nursery/reference/pull/498.diff","patch_url":"https://github.com/rust-lang-nursery/reference/pull/498.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/498","number":498,"state":"open","locked":false,"title":"\"Improve language in 'Constant Expressions'.","user":{"login":"chriskrycho","id":2403023,"node_id":"MDQ6VXNlcjI0MDMwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2403023?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskrycho","html_url":"https://github.com/chriskrycho","followers_url":"https://api.github.com/users/chriskrycho/followers","following_url":"https://api.github.com/users/chriskrycho/following{/other_user}","gists_url":"https://api.github.com/users/chriskrycho/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskrycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskrycho/subscriptions","organizations_url":"https://api.github.com/users/chriskrycho/orgs","repos_url":"https://api.github.com/users/chriskrycho/repos","events_url":"https://api.github.com/users/chriskrycho/events{/privacy}","received_events_url":"https://api.github.com/users/chriskrycho/received_events","type":"User","site_admin":false},"body":"Fixes #497.","created_at":"2019-01-03T03:20:53Z","updated_at":"2019-01-03T03:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa1fd51728328c871d5f407be933b362a828a36c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/498/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/9b6041d57445568b48c0d8ace8c3bceee22de266","head":{"label":"chriskrycho:const-evaluation-467","ref":"const-evaluation-467","sha":"9b6041d57445568b48c0d8ace8c3bceee22de266","user":{"login":"chriskrycho","id":2403023,"node_id":"MDQ6VXNlcjI0MDMwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2403023?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskrycho","html_url":"https://github.com/chriskrycho","followers_url":"https://api.github.com/users/chriskrycho/followers","following_url":"https://api.github.com/users/chriskrycho/following{/other_user}","gists_url":"https://api.github.com/users/chriskrycho/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskrycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskrycho/subscriptions","organizations_url":"https://api.github.com/users/chriskrycho/orgs","repos_url":"https://api.github.com/users/chriskrycho/repos","events_url":"https://api.github.com/users/chriskrycho/events{/privacy}","received_events_url":"https://api.github.com/users/chriskrycho/received_events","type":"User","site_admin":false},"repo":{"id":86920421,"node_id":"MDEwOlJlcG9zaXRvcnk4NjkyMDQyMQ==","name":"reference","full_name":"chriskrycho/reference","private":false,"owner":{"login":"chriskrycho","id":2403023,"node_id":"MDQ6VXNlcjI0MDMwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2403023?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskrycho","html_url":"https://github.com/chriskrycho","followers_url":"https://api.github.com/users/chriskrycho/followers","following_url":"https://api.github.com/users/chriskrycho/following{/other_user}","gists_url":"https://api.github.com/users/chriskrycho/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskrycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskrycho/subscriptions","organizations_url":"https://api.github.com/users/chriskrycho/orgs","repos_url":"https://api.github.com/users/chriskrycho/repos","events_url":"https://api.github.com/users/chriskrycho/events{/privacy}","received_events_url":"https://api.github.com/users/chriskrycho/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chriskrycho/reference","description":"The Rust Reference","fork":true,"url":"https://api.github.com/repos/chriskrycho/reference","forks_url":"https://api.github.com/repos/chriskrycho/reference/forks","keys_url":"https://api.github.com/repos/chriskrycho/reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chriskrycho/reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chriskrycho/reference/teams","hooks_url":"https://api.github.com/repos/chriskrycho/reference/hooks","issue_events_url":"https://api.github.com/repos/chriskrycho/reference/issues/events{/number}","events_url":"https://api.github.com/repos/chriskrycho/reference/events","assignees_url":"https://api.github.com/repos/chriskrycho/reference/assignees{/user}","branches_url":"https://api.github.com/repos/chriskrycho/reference/branches{/branch}","tags_url":"https://api.github.com/repos/chriskrycho/reference/tags","blobs_url":"https://api.github.com/repos/chriskrycho/reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chriskrycho/reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chriskrycho/reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/chriskrycho/reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chriskrycho/reference/statuses/{sha}","languages_url":"https://api.github.com/repos/chriskrycho/reference/languages","stargazers_url":"https://api.github.com/repos/chriskrycho/reference/stargazers","contributors_url":"https://api.github.com/repos/chriskrycho/reference/contributors","subscribers_url":"https://api.github.com/repos/chriskrycho/reference/subscribers","subscription_url":"https://api.github.com/repos/chriskrycho/reference/subscription","commits_url":"https://api.github.com/repos/chriskrycho/reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/chriskrycho/reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/chriskrycho/reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/chriskrycho/reference/issues/comments{/number}","contents_url":"https://api.github.com/repos/chriskrycho/reference/contents/{+path}","compare_url":"https://api.github.com/repos/chriskrycho/reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chriskrycho/reference/merges","archive_url":"https://api.github.com/repos/chriskrycho/reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chriskrycho/reference/downloads","issues_url":"https://api.github.com/repos/chriskrycho/reference/issues{/number}","pulls_url":"https://api.github.com/repos/chriskrycho/reference/pulls{/number}","milestones_url":"https://api.github.com/repos/chriskrycho/reference/milestones{/number}","notifications_url":"https://api.github.com/repos/chriskrycho/reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chriskrycho/reference/labels{/name}","releases_url":"https://api.github.com/repos/chriskrycho/reference/releases{/id}","deployments_url":"https://api.github.com/repos/chriskrycho/reference/deployments","created_at":"2017-04-01T14:52:39Z","updated_at":"2017-04-01T14:52:40Z","pushed_at":"2019-01-03T03:20:32Z","git_url":"git://github.com/chriskrycho/reference.git","ssh_url":"git@github.com:chriskrycho/reference.git","clone_url":"https://github.com/chriskrycho/reference.git","svn_url":"https://github.com/chriskrycho/reference","homepage":"https://doc.rust-lang.org/nightly/reference/","size":1719,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"6112697175a8ee57830c6f8634124473449d9917","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":83575374,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU3NTM3NA==","name":"reference","full_name":"rust-lang-nursery/reference","private":false,"owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang-nursery/reference","description":"The Rust Reference","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/reference","forks_url":"https://api.github.com/repos/rust-lang-nursery/reference/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/reference/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/reference/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/reference/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/reference/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/reference/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/reference/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/reference/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/reference/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/reference/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/reference/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/reference/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/reference/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/reference/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/reference/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/reference/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/reference/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/reference/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/reference/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/reference/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/reference/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/reference/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/reference/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/reference/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/reference/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/reference/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/reference/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/reference/deployments","created_at":"2017-03-01T16:21:06Z","updated_at":"2019-01-02T02:36:13Z","pushed_at":"2019-01-03T03:20:54Z","git_url":"git://github.com/rust-lang-nursery/reference.git","ssh_url":"git@github.com:rust-lang-nursery/reference.git","clone_url":"https://github.com/rust-lang-nursery/reference.git","svn_url":"https://github.com/rust-lang-nursery/reference","homepage":"https://doc.rust-lang.org/nightly/reference/","size":2597,"stargazers_count":106,"watchers_count":106,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":98,"open_issues":84,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498"},"html":{"href":"https://github.com/rust-lang-nursery/reference/pull/498"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/issues/498"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/reference/statuses/9b6041d57445568b48c0d8ace8c3bceee22de266"}},"author_association":"CONTRIBUTOR"}} | {
"id": 83575374,
"name": "rust-lang-nursery/reference",
"url": "https://api.github.com/repos/rust-lang-nursery/reference"
} | {
"id": 855702,
"login": "Centril",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/855702?",
"url": "https://api.github.com/users/Centril"
} | {
"id": 14631425,
"login": "rust-lang-nursery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14631425?",
"url": "https://api.github.com/orgs/rust-lang-nursery"
} | 2019-01-03T03:24:43 | 8826627109 | {"actor":{"display_login":"Centril"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NGEET/fates/pulls/comments/226475486","pull_request_review_id":166307860,"id":226475486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ3NTQ4Ng==","diff_hunk":"@@ -1685,7 +944,8 @@ subroutine recruitment( currentSite, currentPatch, bc_in )\n real(r8) :: a_sapwood ! sapwood cross section are [m2] (dummy)\n real(r8) :: b_agw ! Above ground biomass [kgC]\n real(r8) :: b_bgw ! Below ground biomass [kgC]\n-\n+ real(r8) :: b_dead","path":"biogeochem/EDPhysiologyMod.F90","position":1124,"original_position":1124,"commit_id":"ee3936465e056f744cbd088b90dfbf1ee7fc68c3","original_commit_id":"26f4c7084d74155fba80df0262f5e7bef457e3e9","user":{"login":"rgknox","id":5891980,"node_id":"MDQ6VXNlcjU4OTE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5891980?v=4","gravatar_id":"","url":"https://api.github.com/users/rgknox","html_url":"https://github.com/rgknox","followers_url":"https://api.github.com/users/rgknox/followers","following_url":"https://api.github.com/users/rgknox/following{/other_user}","gists_url":"https://api.github.com/users/rgknox/gists{/gist_id}","starred_url":"https://api.github.com/users/rgknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgknox/subscriptions","organizations_url":"https://api.github.com/users/rgknox/orgs","repos_url":"https://api.github.com/users/rgknox/repos","events_url":"https://api.github.com/users/rgknox/events{/privacy}","received_events_url":"https://api.github.com/users/rgknox/received_events","type":"User","site_admin":false},"body":"created an issue #430","created_at":"2018-10-18T21:42:20Z","updated_at":"2018-10-18T21:42:20Z","html_url":"https://github.com/NGEET/fates/pull/421#discussion_r226475486","pull_request_url":"https://api.github.com/repos/NGEET/fates/pulls/421","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NGEET/fates/pulls/comments/226475486"},"html":{"href":"https://github.com/NGEET/fates/pull/421#discussion_r226475486"},"pull_request":{"href":"https://api.github.com/repos/NGEET/fates/pulls/421"}},"in_reply_to_id":226380612},"pull_request":{"url":"https://api.github.com/repos/NGEET/fates/pulls/421","id":219915676,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTE1Njc2","html_url":"https://github.com/NGEET/fates/pull/421","diff_url":"https://github.com/NGEET/fates/pull/421.diff","patch_url":"https://github.com/NGEET/fates/pull/421.patch","issue_url":"https://api.github.com/repos/NGEET/fates/issues/421","number":421,"state":"open","locked":false,"title":"parteh v1","user":{"login":"rgknox","id":5891980,"node_id":"MDQ6VXNlcjU4OTE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5891980?v=4","gravatar_id":"","url":"https://api.github.com/users/rgknox","html_url":"https://github.com/rgknox","followers_url":"https://api.github.com/users/rgknox/followers","following_url":"https://api.github.com/users/rgknox/following{/other_user}","gists_url":"https://api.github.com/users/rgknox/gists{/gist_id}","starred_url":"https://api.github.com/users/rgknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgknox/subscriptions","organizations_url":"https://api.github.com/users/rgknox/orgs","repos_url":"https://api.github.com/users/rgknox/repos","events_url":"https://api.github.com/users/rgknox/events{/privacy}","received_events_url":"https://api.github.com/users/rgknox/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n### Description:\r\n<!--- Describe your changes in detail -->\r\n<!--- please add issue number if one exists -->\r\n\r\nThis changeset contains the first implementation of the Plant Allocation and Reactive Transport Extensible Hypotheses. The parteh system is designed to enable flexibility in which organs and species are enabled in a plant allocation hypothesis, and also how many discrete spatial positions for those organs are enabled.\r\n\r\nSome notes:\r\n1) Only the carbon-only hypothesis, pre-existing, is implemented\r\n2) Generic/object looping for populating and reading restarts has been added, but nothing special for history output\r\n3) A functional unit testing framework has also been added, see the new folder functional_unit_testing/parteh\r\n4) New and changed parameters\r\n5) Re-translocation of C&N&P has been added\r\n6) Helper functions for event based leaf-drop, leaf-flush, burning and seed drop have been added\r\n\r\nSynced with: https://github.com/ESCOMP/ctsm/pull/537\r\n\r\nDocumentation PR: https://github.com/NGEET/fates-docs/pull/13\r\n\r\n### Collaborators:\r\n<!--- List names of collaborators or people who have interacted -->\r\n<!--- in bringing about this set of changes -->\r\n<!--- consultation, discussions, etc. -->\r\n\r\n@ckoven, @bishtgautam , @rosiealice , @xuchongang , @jkshuman , @tompowell9 , @bchristo , @jenniferholm \r\n\r\n### Expectation of Answer Changes:\r\n<!--- Please describe under what conditions, if any, -->\r\n<!--- the model is expected to generated different answers -->\r\n<!--- from the master version of the code -->\r\n\r\nAnswers are expected to change, but only slightly. So much code has changed, but it is intended to generate the same answers within reasonable precision.\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the in-code documentation .AND. (the [technical note](https://github.com/NGEET/fates-docs) .OR. the wiki) accordingly.\r\n- [x] I have read the [**CONTRIBUTING**](https://github.com/NGEET/fates/blob/master/CONTRIBUTING.md) document.\r\n- [ ] FATES PASS/FAIL regression tests were run\r\n- [ ] If answers were expected to change, evaluation was performed and provided\r\n\r\n\r\n### Test Results:\r\n<!--- Non-trivial changes require the PASS/FAIL regression tests. -->\r\n<!--- If changes to code are NOT expected to change answers, tests must -->\r\n<!--- be run against a baseline. -->\r\n\r\n30 Year regression test against master at BCI (no inventory): https://drive.google.com/file/d/1HwoBhMw1QBR_2qcCyzTmagouismT_C9b/view?usp=sharing\r\n\r\nFATES test suite TBD\r\n\r\nCTSM (or) E3SM (specify which) test hash-tag:\r\n\r\nCTSM (or) E3SM (specify which) baseline hash-tag:\r\n\r\nFATES baseline hash-tag:\r\n\r\nTest Output:\r\n\r\n<!--- paste in test results here -->\r\n\r\n\r\n<!--this template is from https://www.talater.com/open-source-templates/#/page/99--> \r\n\r\n","created_at":"2018-10-03T05:02:00Z","updated_at":"2018-10-18T21:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b911dec6d684c4e66ee90975854b1fe8eb068d08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1077602705,"node_id":"MDU6TGFiZWwxMDc3NjAyNzA1","url":"https://api.github.com/repos/NGEET/fates/labels/Not%20Ready","name":"Not Ready","color":"f4ed64","default":false},{"id":297660733,"node_id":"MDU6TGFiZWwyOTc2NjA3MzM=","url":"https://api.github.com/repos/NGEET/fates/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/NGEET/fates/pulls/421/commits","review_comments_url":"https://api.github.com/repos/NGEET/fates/pulls/421/comments","review_comment_url":"https://api.github.com/repos/NGEET/fates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NGEET/fates/issues/421/comments","statuses_url":"https://api.github.com/repos/NGEET/fates/statuses/ee3936465e056f744cbd088b90dfbf1ee7fc68c3","head":{"label":"rgknox:rgknox-parteh","ref":"rgknox-parteh","sha":"ee3936465e056f744cbd088b90dfbf1ee7fc68c3","user":{"login":"rgknox","id":5891980,"node_id":"MDQ6VXNlcjU4OTE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5891980?v=4","gravatar_id":"","url":"https://api.github.com/users/rgknox","html_url":"https://github.com/rgknox","followers_url":"https://api.github.com/users/rgknox/followers","following_url":"https://api.github.com/users/rgknox/following{/other_user}","gists_url":"https://api.github.com/users/rgknox/gists{/gist_id}","starred_url":"https://api.github.com/users/rgknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgknox/subscriptions","organizations_url":"https://api.github.com/users/rgknox/orgs","repos_url":"https://api.github.com/users/rgknox/repos","events_url":"https://api.github.com/users/rgknox/events{/privacy}","received_events_url":"https://api.github.com/users/rgknox/received_events","type":"User","site_admin":false},"repo":{"id":148710789,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3MTA3ODk=","name":"fates","full_name":"rgknox/fates","private":false,"owner":{"login":"rgknox","id":5891980,"node_id":"MDQ6VXNlcjU4OTE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/5891980?v=4","gravatar_id":"","url":"https://api.github.com/users/rgknox","html_url":"https://github.com/rgknox","followers_url":"https://api.github.com/users/rgknox/followers","following_url":"https://api.github.com/users/rgknox/following{/other_user}","gists_url":"https://api.github.com/users/rgknox/gists{/gist_id}","starred_url":"https://api.github.com/users/rgknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgknox/subscriptions","organizations_url":"https://api.github.com/users/rgknox/orgs","repos_url":"https://api.github.com/users/rgknox/repos","events_url":"https://api.github.com/users/rgknox/events{/privacy}","received_events_url":"https://api.github.com/users/rgknox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rgknox/fates","description":"repository for the Functionally Assembled Terestrial Ecosystem Simulator (FATES)","fork":true,"url":"https://api.github.com/repos/rgknox/fates","forks_url":"https://api.github.com/repos/rgknox/fates/forks","keys_url":"https://api.github.com/repos/rgknox/fates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgknox/fates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgknox/fates/teams","hooks_url":"https://api.github.com/repos/rgknox/fates/hooks","issue_events_url":"https://api.github.com/repos/rgknox/fates/issues/events{/number}","events_url":"https://api.github.com/repos/rgknox/fates/events","assignees_url":"https://api.github.com/repos/rgknox/fates/assignees{/user}","branches_url":"https://api.github.com/repos/rgknox/fates/branches{/branch}","tags_url":"https://api.github.com/repos/rgknox/fates/tags","blobs_url":"https://api.github.com/repos/rgknox/fates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgknox/fates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgknox/fates/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgknox/fates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgknox/fates/statuses/{sha}","languages_url":"https://api.github.com/repos/rgknox/fates/languages","stargazers_url":"https://api.github.com/repos/rgknox/fates/stargazers","contributors_url":"https://api.github.com/repos/rgknox/fates/contributors","subscribers_url":"https://api.github.com/repos/rgknox/fates/subscribers","subscription_url":"https://api.github.com/repos/rgknox/fates/subscription","commits_url":"https://api.github.com/repos/rgknox/fates/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgknox/fates/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgknox/fates/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgknox/fates/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgknox/fates/contents/{+path}","compare_url":"https://api.github.com/repos/rgknox/fates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgknox/fates/merges","archive_url":"https://api.github.com/repos/rgknox/fates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgknox/fates/downloads","issues_url":"https://api.github.com/repos/rgknox/fates/issues{/number}","pulls_url":"https://api.github.com/repos/rgknox/fates/pulls{/number}","milestones_url":"https://api.github.com/repos/rgknox/fates/milestones{/number}","notifications_url":"https://api.github.com/repos/rgknox/fates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgknox/fates/labels{/name}","releases_url":"https://api.github.com/repos/rgknox/fates/releases{/id}","deployments_url":"https://api.github.com/repos/rgknox/fates/deployments","created_at":"2018-09-13T23:43:58Z","updated_at":"2018-09-13T23:44:00Z","pushed_at":"2018-10-18T21:38:29Z","git_url":"git://github.com/rgknox/fates.git","ssh_url":"git@github.com:rgknox/fates.git","clone_url":"https://github.com/rgknox/fates.git","svn_url":"https://github.com/rgknox/fates","homepage":"","size":40333,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NGEET:master","ref":"master","sha":"44d45f5496bfe0aab071e5e90f25e8e4635bbc66","user":{"login":"NGEET","id":14792952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzkyOTUy","avatar_url":"https://avatars2.githubusercontent.com/u/14792952?v=4","gravatar_id":"","url":"https://api.github.com/users/NGEET","html_url":"https://github.com/NGEET","followers_url":"https://api.github.com/users/NGEET/followers","following_url":"https://api.github.com/users/NGEET/following{/other_user}","gists_url":"https://api.github.com/users/NGEET/gists{/gist_id}","starred_url":"https://api.github.com/users/NGEET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGEET/subscriptions","organizations_url":"https://api.github.com/users/NGEET/orgs","repos_url":"https://api.github.com/users/NGEET/repos","events_url":"https://api.github.com/users/NGEET/events{/privacy}","received_events_url":"https://api.github.com/users/NGEET/received_events","type":"Organization","site_admin":false},"repo":{"id":47725250,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcyNTI1MA==","name":"fates","full_name":"NGEET/fates","private":false,"owner":{"login":"NGEET","id":14792952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NzkyOTUy","avatar_url":"https://avatars2.githubusercontent.com/u/14792952?v=4","gravatar_id":"","url":"https://api.github.com/users/NGEET","html_url":"https://github.com/NGEET","followers_url":"https://api.github.com/users/NGEET/followers","following_url":"https://api.github.com/users/NGEET/following{/other_user}","gists_url":"https://api.github.com/users/NGEET/gists{/gist_id}","starred_url":"https://api.github.com/users/NGEET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NGEET/subscriptions","organizations_url":"https://api.github.com/users/NGEET/orgs","repos_url":"https://api.github.com/users/NGEET/repos","events_url":"https://api.github.com/users/NGEET/events{/privacy}","received_events_url":"https://api.github.com/users/NGEET/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NGEET/fates","description":"repository for the Functionally Assembled Terrestrial Ecosystem Simulator (FATES)","fork":false,"url":"https://api.github.com/repos/NGEET/fates","forks_url":"https://api.github.com/repos/NGEET/fates/forks","keys_url":"https://api.github.com/repos/NGEET/fates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NGEET/fates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NGEET/fates/teams","hooks_url":"https://api.github.com/repos/NGEET/fates/hooks","issue_events_url":"https://api.github.com/repos/NGEET/fates/issues/events{/number}","events_url":"https://api.github.com/repos/NGEET/fates/events","assignees_url":"https://api.github.com/repos/NGEET/fates/assignees{/user}","branches_url":"https://api.github.com/repos/NGEET/fates/branches{/branch}","tags_url":"https://api.github.com/repos/NGEET/fates/tags","blobs_url":"https://api.github.com/repos/NGEET/fates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NGEET/fates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NGEET/fates/git/refs{/sha}","trees_url":"https://api.github.com/repos/NGEET/fates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NGEET/fates/statuses/{sha}","languages_url":"https://api.github.com/repos/NGEET/fates/languages","stargazers_url":"https://api.github.com/repos/NGEET/fates/stargazers","contributors_url":"https://api.github.com/repos/NGEET/fates/contributors","subscribers_url":"https://api.github.com/repos/NGEET/fates/subscribers","subscription_url":"https://api.github.com/repos/NGEET/fates/subscription","commits_url":"https://api.github.com/repos/NGEET/fates/commits{/sha}","git_commits_url":"https://api.github.com/repos/NGEET/fates/git/commits{/sha}","comments_url":"https://api.github.com/repos/NGEET/fates/comments{/number}","issue_comment_url":"https://api.github.com/repos/NGEET/fates/issues/comments{/number}","contents_url":"https://api.github.com/repos/NGEET/fates/contents/{+path}","compare_url":"https://api.github.com/repos/NGEET/fates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NGEET/fates/merges","archive_url":"https://api.github.com/repos/NGEET/fates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NGEET/fates/downloads","issues_url":"https://api.github.com/repos/NGEET/fates/issues{/number}","pulls_url":"https://api.github.com/repos/NGEET/fates/pulls{/number}","milestones_url":"https://api.github.com/repos/NGEET/fates/milestones{/number}","notifications_url":"https://api.github.com/repos/NGEET/fates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NGEET/fates/labels{/name}","releases_url":"https://api.github.com/repos/NGEET/fates/releases{/id}","deployments_url":"https://api.github.com/repos/NGEET/fates/deployments","created_at":"2015-12-09T23:18:30Z","updated_at":"2018-10-16T20:14:49Z","pushed_at":"2018-10-18T21:38:31Z","git_url":"git://github.com/NGEET/fates.git","ssh_url":"git@github.com:NGEET/fates.git","clone_url":"https://github.com/NGEET/fates.git","svn_url":"https://github.com/NGEET/fates","homepage":"","size":39723,"stargazers_count":13,"watchers_count":13,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":89,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NGEET/fates/pulls/421"},"html":{"href":"https://github.com/NGEET/fates/pull/421"},"issue":{"href":"https://api.github.com/repos/NGEET/fates/issues/421"},"comments":{"href":"https://api.github.com/repos/NGEET/fates/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/NGEET/fates/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/NGEET/fates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NGEET/fates/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/NGEET/fates/statuses/ee3936465e056f744cbd088b90dfbf1ee7fc68c3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 47725250,
"name": "NGEET/fates",
"url": "https://api.github.com/repos/NGEET/fates"
} | {
"id": 5891980,
"login": "rgknox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5891980?",
"url": "https://api.github.com/users/rgknox"
} | {
"id": 14792952,
"login": "NGEET",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14792952?",
"url": "https://api.github.com/orgs/NGEET"
} | 2018-10-18T21:42:20 | 8445493681 | {"actor":{"display_login":"rgknox"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/comments/218577258","pull_request_review_id":156547091,"id":218577258,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODU3NzI1OA==","diff_hunk":"@@ -1,5 +1,15 @@\n # What's New\n \n+## v6.0\n+\n+Release date: TBD\n+\n+* NEW: `getProjectionMatrix` can match the behavior of the latest Mapbox (when called witch `farZMultiplier: viewport.height`)\n+* NEW: `addMetersToLngLat` utility\n+* FIX: returned values by `getDistanceScales` now reflect the flipped y-direction between spherical coordinates and the WebMercator world.\n+* FIX: `WebMercatorViewport`'s `project` and `unproject` handle altitude correctly\n+* BREAKING: `getWorldPosition` is removed","path":"docs/whats-new.md","position":11,"original_position":11,"commit_id":"2acd08c87e257d73cd27ce677a5da341ddda8a70","original_commit_id":"2acd08c87e257d73cd27ce677a5da341ddda8a70","user":{"login":"ibgreen","id":7025232,"node_id":"MDQ6VXNlcjcwMjUyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7025232?v=4","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"body":"Nit: Should we add an upgrade guide? Or at least say something about how this can be worked around/implications.","created_at":"2018-09-18T20:11:21Z","updated_at":"2018-09-18T20:13:17Z","html_url":"https://github.com/uber-common/viewport-mercator-project/pull/81#discussion_r218577258","pull_request_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/comments/218577258"},"html":{"href":"https://github.com/uber-common/viewport-mercator-project/pull/81#discussion_r218577258"},"pull_request":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81","id":216411906,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDExOTA2","html_url":"https://github.com/uber-common/viewport-mercator-project/pull/81","diff_url":"https://github.com/uber-common/viewport-mercator-project/pull/81.diff","patch_url":"https://github.com/uber-common/viewport-mercator-project/pull/81.patch","issue_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/81","number":81,"state":"open","locked":false,"title":"Remove getWorldPosition","user":{"login":"Pessimistress","id":2059298,"node_id":"MDQ6VXNlcjIwNTkyOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2059298?v=4","gravatar_id":"","url":"https://api.github.com/users/Pessimistress","html_url":"https://github.com/Pessimistress","followers_url":"https://api.github.com/users/Pessimistress/followers","following_url":"https://api.github.com/users/Pessimistress/following{/other_user}","gists_url":"https://api.github.com/users/Pessimistress/gists{/gist_id}","starred_url":"https://api.github.com/users/Pessimistress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pessimistress/subscriptions","organizations_url":"https://api.github.com/users/Pessimistress/orgs","repos_url":"https://api.github.com/users/Pessimistress/repos","events_url":"https://api.github.com/users/Pessimistress/events{/privacy}","received_events_url":"https://api.github.com/users/Pessimistress/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-18T19:05:30Z","updated_at":"2018-09-18T20:13:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"768fafd0ecc511fb3330f6d8f17897893f1bded9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81/commits","review_comments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81/comments","review_comment_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/81/comments","statuses_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/statuses/2acd08c87e257d73cd27ce677a5da341ddda8a70","head":{"label":"uber-common:get-world-position","ref":"get-world-position","sha":"2acd08c87e257d73cd27ce677a5da341ddda8a70","user":{"login":"uber-common","id":14812045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODEyMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/14812045?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"repo":{"id":42538625,"node_id":"MDEwOlJlcG9zaXRvcnk0MjUzODYyNQ==","name":"viewport-mercator-project","full_name":"uber-common/viewport-mercator-project","private":false,"owner":{"login":"uber-common","id":14812045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODEyMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/14812045?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber-common/viewport-mercator-project","description":"A map viewport converter using mercator projection","fork":false,"url":"https://api.github.com/repos/uber-common/viewport-mercator-project","forks_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/forks","keys_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/teams","hooks_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/hooks","issue_events_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/events{/number}","events_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/events","assignees_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/assignees{/user}","branches_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/branches{/branch}","tags_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/tags","blobs_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/languages","stargazers_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/stargazers","contributors_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/contributors","subscribers_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/subscribers","subscription_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/subscription","commits_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/contents/{+path}","compare_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/merges","archive_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/downloads","issues_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues{/number}","pulls_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/labels{/name}","releases_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/releases{/id}","deployments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/deployments","created_at":"2015-09-15T18:32:37Z","updated_at":"2018-09-18T20:02:35Z","pushed_at":"2018-09-18T20:02:33Z","git_url":"git://github.com/uber-common/viewport-mercator-project.git","ssh_url":"git@github.com:uber-common/viewport-mercator-project.git","clone_url":"https://github.com/uber-common/viewport-mercator-project.git","svn_url":"https://github.com/uber-common/viewport-mercator-project","homepage":"http://uber-common.github.io/viewport-mercator-project/#/documentation/overview","size":1139,"stargazers_count":94,"watchers_count":94,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":14,"watchers":94,"default_branch":"master"}},"base":{"label":"uber-common:meter-offset-to-lnglat-delta","ref":"meter-offset-to-lnglat-delta","sha":"bd28f20ed444db85d165c87f186366a19bbbf064","user":{"login":"uber-common","id":14812045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODEyMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/14812045?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"repo":{"id":42538625,"node_id":"MDEwOlJlcG9zaXRvcnk0MjUzODYyNQ==","name":"viewport-mercator-project","full_name":"uber-common/viewport-mercator-project","private":false,"owner":{"login":"uber-common","id":14812045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODEyMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/14812045?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-common","html_url":"https://github.com/uber-common","followers_url":"https://api.github.com/users/uber-common/followers","following_url":"https://api.github.com/users/uber-common/following{/other_user}","gists_url":"https://api.github.com/users/uber-common/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-common/subscriptions","organizations_url":"https://api.github.com/users/uber-common/orgs","repos_url":"https://api.github.com/users/uber-common/repos","events_url":"https://api.github.com/users/uber-common/events{/privacy}","received_events_url":"https://api.github.com/users/uber-common/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber-common/viewport-mercator-project","description":"A map viewport converter using mercator projection","fork":false,"url":"https://api.github.com/repos/uber-common/viewport-mercator-project","forks_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/forks","keys_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/teams","hooks_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/hooks","issue_events_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/events{/number}","events_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/events","assignees_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/assignees{/user}","branches_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/branches{/branch}","tags_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/tags","blobs_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/languages","stargazers_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/stargazers","contributors_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/contributors","subscribers_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/subscribers","subscription_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/subscription","commits_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/contents/{+path}","compare_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/merges","archive_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/downloads","issues_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues{/number}","pulls_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/labels{/name}","releases_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/releases{/id}","deployments_url":"https://api.github.com/repos/uber-common/viewport-mercator-project/deployments","created_at":"2015-09-15T18:32:37Z","updated_at":"2018-09-18T20:02:35Z","pushed_at":"2018-09-18T20:02:33Z","git_url":"git://github.com/uber-common/viewport-mercator-project.git","ssh_url":"git@github.com:uber-common/viewport-mercator-project.git","clone_url":"https://github.com/uber-common/viewport-mercator-project.git","svn_url":"https://github.com/uber-common/viewport-mercator-project","homepage":"http://uber-common.github.io/viewport-mercator-project/#/documentation/overview","size":1139,"stargazers_count":94,"watchers_count":94,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":14,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81"},"html":{"href":"https://github.com/uber-common/viewport-mercator-project/pull/81"},"issue":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/81"},"comments":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/uber-common/viewport-mercator-project/statuses/2acd08c87e257d73cd27ce677a5da341ddda8a70"}},"author_association":"CONTRIBUTOR"}} | {
"id": 42538625,
"name": "uber-common/viewport-mercator-project",
"url": "https://api.github.com/repos/uber-common/viewport-mercator-project"
} | {
"id": 7025232,
"login": "ibgreen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7025232?",
"url": "https://api.github.com/users/ibgreen"
} | {
"id": 14812045,
"login": "uber-common",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14812045?",
"url": "https://api.github.com/orgs/uber-common"
} | 2018-09-18T20:11:21 | 8284657762 | {"actor":{"display_login":"ibgreen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/comments/204194692","pull_request_review_id":139240867,"id":204194692,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5NDY5Mg==","diff_hunk":"@@ -1,4 +1,4 @@\n-websites:\n+websites:","path":"_data/banking.yml","position":2,"original_position":2,"commit_id":"1d68dffebfbbb1dfd770789a5f5c7b0525302bb9","original_commit_id":"1d68dffebfbbb1dfd770789a5f5c7b0525302bb9","user":{"login":"gothicman02","id":38589956,"node_id":"MDQ6VXNlcjM4NTg5OTU2","avatar_url":"https://avatars2.githubusercontent.com/u/38589956?v=4","gravatar_id":"","url":"https://api.github.com/users/gothicman02","html_url":"https://github.com/gothicman02","followers_url":"https://api.github.com/users/gothicman02/followers","following_url":"https://api.github.com/users/gothicman02/following{/other_user}","gists_url":"https://api.github.com/users/gothicman02/gists{/gist_id}","starred_url":"https://api.github.com/users/gothicman02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gothicman02/subscriptions","organizations_url":"https://api.github.com/users/gothicman02/orgs","repos_url":"https://api.github.com/users/gothicman02/repos","events_url":"https://api.github.com/users/gothicman02/events{/privacy}","received_events_url":"https://api.github.com/users/gothicman02/received_events","type":"User","site_admin":false},"body":"I believe this may have happened when I accidentally hit delete on the top line when editting, and corrected it, by undoing. I did a diff and they look identical currently compared to the original. Also it appears the checks have passed as well, and I double checked other pull requests to make sure the spacing, line placement, etc. is correct. Am I missing something?","created_at":"2018-07-21T00:22:55Z","updated_at":"2018-07-21T00:22:55Z","html_url":"https://github.com/2factorauth/twofactorauth/pull/3309#discussion_r204194692","pull_request_url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/comments/204194692"},"html":{"href":"https://github.com/2factorauth/twofactorauth/pull/3309#discussion_r204194692"},"pull_request":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309"}},"in_reply_to_id":204184188},"pull_request":{"url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309","id":202965819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTY1ODE5","html_url":"https://github.com/2factorauth/twofactorauth/pull/3309","diff_url":"https://github.com/2factorauth/twofactorauth/pull/3309.diff","patch_url":"https://github.com/2factorauth/twofactorauth/pull/3309.patch","issue_url":"https://api.github.com/repos/2factorauth/twofactorauth/issues/3309","number":3309,"state":"open","locked":false,"title":"adding ncsecu","user":{"login":"gothicman02","id":38589956,"node_id":"MDQ6VXNlcjM4NTg5OTU2","avatar_url":"https://avatars2.githubusercontent.com/u/38589956?v=4","gravatar_id":"","url":"https://api.github.com/users/gothicman02","html_url":"https://github.com/gothicman02","followers_url":"https://api.github.com/users/gothicman02/followers","following_url":"https://api.github.com/users/gothicman02/following{/other_user}","gists_url":"https://api.github.com/users/gothicman02/gists{/gist_id}","starred_url":"https://api.github.com/users/gothicman02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gothicman02/subscriptions","organizations_url":"https://api.github.com/users/gothicman02/orgs","repos_url":"https://api.github.com/users/gothicman02/repos","events_url":"https://api.github.com/users/gothicman02/events{/privacy}","received_events_url":"https://api.github.com/users/gothicman02/received_events","type":"User","site_admin":false},"body":"Edited in notepad. Let me know if there are any issues.","created_at":"2018-07-20T22:00:35Z","updated_at":"2018-07-21T00:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d4c41b75ab3229f7e83bea571cdeb210397d5b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309/commits","review_comments_url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309/comments","review_comment_url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/2factorauth/twofactorauth/issues/3309/comments","statuses_url":"https://api.github.com/repos/2factorauth/twofactorauth/statuses/1d68dffebfbbb1dfd770789a5f5c7b0525302bb9","head":{"label":"gothicman02:master","ref":"master","sha":"1d68dffebfbbb1dfd770789a5f5c7b0525302bb9","user":{"login":"gothicman02","id":38589956,"node_id":"MDQ6VXNlcjM4NTg5OTU2","avatar_url":"https://avatars2.githubusercontent.com/u/38589956?v=4","gravatar_id":"","url":"https://api.github.com/users/gothicman02","html_url":"https://github.com/gothicman02","followers_url":"https://api.github.com/users/gothicman02/followers","following_url":"https://api.github.com/users/gothicman02/following{/other_user}","gists_url":"https://api.github.com/users/gothicman02/gists{/gist_id}","starred_url":"https://api.github.com/users/gothicman02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gothicman02/subscriptions","organizations_url":"https://api.github.com/users/gothicman02/orgs","repos_url":"https://api.github.com/users/gothicman02/repos","events_url":"https://api.github.com/users/gothicman02/events{/privacy}","received_events_url":"https://api.github.com/users/gothicman02/received_events","type":"User","site_admin":false},"repo":{"id":141754200,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NTQyMDA=","name":"twofactorauth","full_name":"gothicman02/twofactorauth","owner":{"login":"gothicman02","id":38589956,"node_id":"MDQ6VXNlcjM4NTg5OTU2","avatar_url":"https://avatars2.githubusercontent.com/u/38589956?v=4","gravatar_id":"","url":"https://api.github.com/users/gothicman02","html_url":"https://github.com/gothicman02","followers_url":"https://api.github.com/users/gothicman02/followers","following_url":"https://api.github.com/users/gothicman02/following{/other_user}","gists_url":"https://api.github.com/users/gothicman02/gists{/gist_id}","starred_url":"https://api.github.com/users/gothicman02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gothicman02/subscriptions","organizations_url":"https://api.github.com/users/gothicman02/orgs","repos_url":"https://api.github.com/users/gothicman02/repos","events_url":"https://api.github.com/users/gothicman02/events{/privacy}","received_events_url":"https://api.github.com/users/gothicman02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gothicman02/twofactorauth","description":"List of sites with two factor auth support which includes SMS, email, phone calls, hardware, and software.","fork":true,"url":"https://api.github.com/repos/gothicman02/twofactorauth","forks_url":"https://api.github.com/repos/gothicman02/twofactorauth/forks","keys_url":"https://api.github.com/repos/gothicman02/twofactorauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gothicman02/twofactorauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gothicman02/twofactorauth/teams","hooks_url":"https://api.github.com/repos/gothicman02/twofactorauth/hooks","issue_events_url":"https://api.github.com/repos/gothicman02/twofactorauth/issues/events{/number}","events_url":"https://api.github.com/repos/gothicman02/twofactorauth/events","assignees_url":"https://api.github.com/repos/gothicman02/twofactorauth/assignees{/user}","branches_url":"https://api.github.com/repos/gothicman02/twofactorauth/branches{/branch}","tags_url":"https://api.github.com/repos/gothicman02/twofactorauth/tags","blobs_url":"https://api.github.com/repos/gothicman02/twofactorauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gothicman02/twofactorauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gothicman02/twofactorauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/gothicman02/twofactorauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gothicman02/twofactorauth/statuses/{sha}","languages_url":"https://api.github.com/repos/gothicman02/twofactorauth/languages","stargazers_url":"https://api.github.com/repos/gothicman02/twofactorauth/stargazers","contributors_url":"https://api.github.com/repos/gothicman02/twofactorauth/contributors","subscribers_url":"https://api.github.com/repos/gothicman02/twofactorauth/subscribers","subscription_url":"https://api.github.com/repos/gothicman02/twofactorauth/subscription","commits_url":"https://api.github.com/repos/gothicman02/twofactorauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/gothicman02/twofactorauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/gothicman02/twofactorauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/gothicman02/twofactorauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/gothicman02/twofactorauth/contents/{+path}","compare_url":"https://api.github.com/repos/gothicman02/twofactorauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gothicman02/twofactorauth/merges","archive_url":"https://api.github.com/repos/gothicman02/twofactorauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gothicman02/twofactorauth/downloads","issues_url":"https://api.github.com/repos/gothicman02/twofactorauth/issues{/number}","pulls_url":"https://api.github.com/repos/gothicman02/twofactorauth/pulls{/number}","milestones_url":"https://api.github.com/repos/gothicman02/twofactorauth/milestones{/number}","notifications_url":"https://api.github.com/repos/gothicman02/twofactorauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gothicman02/twofactorauth/labels{/name}","releases_url":"https://api.github.com/repos/gothicman02/twofactorauth/releases{/id}","deployments_url":"https://api.github.com/repos/gothicman02/twofactorauth/deployments","created_at":"2018-07-20T20:19:21Z","updated_at":"2018-07-20T21:38:33Z","pushed_at":"2018-07-20T21:38:29Z","git_url":"git://github.com/gothicman02/twofactorauth.git","ssh_url":"git@github.com:gothicman02/twofactorauth.git","clone_url":"https://github.com/gothicman02/twofactorauth.git","svn_url":"https://github.com/gothicman02/twofactorauth","homepage":"https://twofactorauth.org","size":10914,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"2factorauth:master","ref":"master","sha":"22f4e0d7803b604bf64dff03874bfd4e3be7dec9","user":{"login":"2factorauth","id":14816858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODE2ODU4","avatar_url":"https://avatars0.githubusercontent.com/u/14816858?v=4","gravatar_id":"","url":"https://api.github.com/users/2factorauth","html_url":"https://github.com/2factorauth","followers_url":"https://api.github.com/users/2factorauth/followers","following_url":"https://api.github.com/users/2factorauth/following{/other_user}","gists_url":"https://api.github.com/users/2factorauth/gists{/gist_id}","starred_url":"https://api.github.com/users/2factorauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2factorauth/subscriptions","organizations_url":"https://api.github.com/users/2factorauth/orgs","repos_url":"https://api.github.com/users/2factorauth/repos","events_url":"https://api.github.com/users/2factorauth/events{/privacy}","received_events_url":"https://api.github.com/users/2factorauth/received_events","type":"Organization","site_admin":false},"repo":{"id":17724730,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcyNDczMA==","name":"twofactorauth","full_name":"2factorauth/twofactorauth","owner":{"login":"2factorauth","id":14816858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODE2ODU4","avatar_url":"https://avatars0.githubusercontent.com/u/14816858?v=4","gravatar_id":"","url":"https://api.github.com/users/2factorauth","html_url":"https://github.com/2factorauth","followers_url":"https://api.github.com/users/2factorauth/followers","following_url":"https://api.github.com/users/2factorauth/following{/other_user}","gists_url":"https://api.github.com/users/2factorauth/gists{/gist_id}","starred_url":"https://api.github.com/users/2factorauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2factorauth/subscriptions","organizations_url":"https://api.github.com/users/2factorauth/orgs","repos_url":"https://api.github.com/users/2factorauth/repos","events_url":"https://api.github.com/users/2factorauth/events{/privacy}","received_events_url":"https://api.github.com/users/2factorauth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2factorauth/twofactorauth","description":"List of sites with two factor auth support which includes SMS, email, phone calls, hardware, and software.","fork":false,"url":"https://api.github.com/repos/2factorauth/twofactorauth","forks_url":"https://api.github.com/repos/2factorauth/twofactorauth/forks","keys_url":"https://api.github.com/repos/2factorauth/twofactorauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2factorauth/twofactorauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2factorauth/twofactorauth/teams","hooks_url":"https://api.github.com/repos/2factorauth/twofactorauth/hooks","issue_events_url":"https://api.github.com/repos/2factorauth/twofactorauth/issues/events{/number}","events_url":"https://api.github.com/repos/2factorauth/twofactorauth/events","assignees_url":"https://api.github.com/repos/2factorauth/twofactorauth/assignees{/user}","branches_url":"https://api.github.com/repos/2factorauth/twofactorauth/branches{/branch}","tags_url":"https://api.github.com/repos/2factorauth/twofactorauth/tags","blobs_url":"https://api.github.com/repos/2factorauth/twofactorauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2factorauth/twofactorauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2factorauth/twofactorauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/2factorauth/twofactorauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2factorauth/twofactorauth/statuses/{sha}","languages_url":"https://api.github.com/repos/2factorauth/twofactorauth/languages","stargazers_url":"https://api.github.com/repos/2factorauth/twofactorauth/stargazers","contributors_url":"https://api.github.com/repos/2factorauth/twofactorauth/contributors","subscribers_url":"https://api.github.com/repos/2factorauth/twofactorauth/subscribers","subscription_url":"https://api.github.com/repos/2factorauth/twofactorauth/subscription","commits_url":"https://api.github.com/repos/2factorauth/twofactorauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/2factorauth/twofactorauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/2factorauth/twofactorauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/2factorauth/twofactorauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/2factorauth/twofactorauth/contents/{+path}","compare_url":"https://api.github.com/repos/2factorauth/twofactorauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2factorauth/twofactorauth/merges","archive_url":"https://api.github.com/repos/2factorauth/twofactorauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2factorauth/twofactorauth/downloads","issues_url":"https://api.github.com/repos/2factorauth/twofactorauth/issues{/number}","pulls_url":"https://api.github.com/repos/2factorauth/twofactorauth/pulls{/number}","milestones_url":"https://api.github.com/repos/2factorauth/twofactorauth/milestones{/number}","notifications_url":"https://api.github.com/repos/2factorauth/twofactorauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2factorauth/twofactorauth/labels{/name}","releases_url":"https://api.github.com/repos/2factorauth/twofactorauth/releases{/id}","deployments_url":"https://api.github.com/repos/2factorauth/twofactorauth/deployments","created_at":"2014-03-13T20:20:07Z","updated_at":"2018-07-20T10:41:40Z","pushed_at":"2018-07-20T22:00:36Z","git_url":"git://github.com/2factorauth/twofactorauth.git","ssh_url":"git@github.com:2factorauth/twofactorauth.git","clone_url":"https://github.com/2factorauth/twofactorauth.git","svn_url":"https://github.com/2factorauth/twofactorauth","homepage":"https://twofactorauth.org","size":11219,"stargazers_count":1763,"watchers_count":1763,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1121,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1121,"open_issues":127,"watchers":1763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309"},"html":{"href":"https://github.com/2factorauth/twofactorauth/pull/3309"},"issue":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/issues/3309"},"comments":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/issues/3309/comments"},"review_comments":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309/comments"},"review_comment":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/pulls/3309/commits"},"statuses":{"href":"https://api.github.com/repos/2factorauth/twofactorauth/statuses/1d68dffebfbbb1dfd770789a5f5c7b0525302bb9"}},"author_association":"NONE"}} | {
"id": 17724730,
"name": "2factorauth/twofactorauth",
"url": "https://api.github.com/repos/2factorauth/twofactorauth"
} | {
"id": 38589956,
"login": "gothicman02",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38589956?",
"url": "https://api.github.com/users/gothicman02"
} | {
"id": 14816858,
"login": "2factorauth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14816858?",
"url": "https://api.github.com/orgs/2factorauth"
} | 2018-07-21T00:22:55 | 7997718702 | {"actor":{"display_login":"gothicman02"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/comments/222046527","pull_request_review_id":160841313,"id":222046527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA0NjUyNw==","diff_hunk":"@@ -23,10 +18,14 @@\n private Integer tagHierachyId;\n \n @NotBlank\n+ @Column(unique = true)\n private String name;\n \n @Override\n public Integer getId() {\n return this.tagHierachyId;\n }\n+\n+ @OneToMany(mappedBy = \"definedIn\")","path":"src/main/java/cat/udl/eps/entsoftarch/textannot/domain/TagHierarchy.java","position":31,"original_position":31,"commit_id":"94c86f8c7e6059b7535ae75b96b73dfd77cb958c","original_commit_id":"94c86f8c7e6059b7535ae75b96b73dfd77cb958c","user":{"login":"rogargon","id":1313870,"node_id":"MDQ6VXNlcjEzMTM4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1313870?v=4","gravatar_id":"","url":"https://api.github.com/users/rogargon","html_url":"https://github.com/rogargon","followers_url":"https://api.github.com/users/rogargon/followers","following_url":"https://api.github.com/users/rogargon/following{/other_user}","gists_url":"https://api.github.com/users/rogargon/gists{/gist_id}","starred_url":"https://api.github.com/users/rogargon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogargon/subscriptions","organizations_url":"https://api.github.com/users/rogargon/orgs","repos_url":"https://api.github.com/users/rogargon/repos","events_url":"https://api.github.com/users/rogargon/events{/privacy}","received_events_url":"https://api.github.com/users/rogargon/received_events","type":"User","site_admin":false},"body":"TODO: remove to avoid bidirectional relationships as agreed. Use findBy... repository method instead","created_at":"2018-10-02T17:41:01Z","updated_at":"2018-10-02T17:41:01Z","html_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53#discussion_r222046527","pull_request_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/comments/222046527"},"html":{"href":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53#discussion_r222046527"},"pull_request":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53","id":219721984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzIxOTg0","html_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53","diff_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53.diff","patch_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53.patch","issue_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/53","number":53,"state":"open","locked":false,"title":"Create tag hierarchy with relationships","user":{"login":"Guillem96","id":21279306,"node_id":"MDQ6VXNlcjIxMjc5MzA2","avatar_url":"https://avatars1.githubusercontent.com/u/21279306?v=4","gravatar_id":"","url":"https://api.github.com/users/Guillem96","html_url":"https://github.com/Guillem96","followers_url":"https://api.github.com/users/Guillem96/followers","following_url":"https://api.github.com/users/Guillem96/following{/other_user}","gists_url":"https://api.github.com/users/Guillem96/gists{/gist_id}","starred_url":"https://api.github.com/users/Guillem96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guillem96/subscriptions","organizations_url":"https://api.github.com/users/Guillem96/orgs","repos_url":"https://api.github.com/users/Guillem96/repos","events_url":"https://api.github.com/users/Guillem96/events{/privacy}","received_events_url":"https://api.github.com/users/Guillem96/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T14:21:51Z","updated_at":"2018-10-02T17:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"599945b6882cbf0246db4754b8e9c4d34620fb9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53/commits","review_comments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53/comments","review_comment_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/53/comments","statuses_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/statuses/94c86f8c7e6059b7535ae75b96b73dfd77cb958c","head":{"label":"UdL-EPS-SoftArch:create-tag-hierarchy","ref":"create-tag-hierarchy","sha":"94c86f8c7e6059b7535ae75b96b73dfd77cb958c","user":{"login":"UdL-EPS-SoftArch","id":14834841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM0ODQx","avatar_url":"https://avatars3.githubusercontent.com/u/14834841?v=4","gravatar_id":"","url":"https://api.github.com/users/UdL-EPS-SoftArch","html_url":"https://github.com/UdL-EPS-SoftArch","followers_url":"https://api.github.com/users/UdL-EPS-SoftArch/followers","following_url":"https://api.github.com/users/UdL-EPS-SoftArch/following{/other_user}","gists_url":"https://api.github.com/users/UdL-EPS-SoftArch/gists{/gist_id}","starred_url":"https://api.github.com/users/UdL-EPS-SoftArch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdL-EPS-SoftArch/subscriptions","organizations_url":"https://api.github.com/users/UdL-EPS-SoftArch/orgs","repos_url":"https://api.github.com/users/UdL-EPS-SoftArch/repos","events_url":"https://api.github.com/users/UdL-EPS-SoftArch/events{/privacy}","received_events_url":"https://api.github.com/users/UdL-EPS-SoftArch/received_events","type":"Organization","site_admin":false},"repo":{"id":121632695,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2MzI2OTU=","name":"TextAnnot-API","full_name":"UdL-EPS-SoftArch/TextAnnot-API","private":false,"owner":{"login":"UdL-EPS-SoftArch","id":14834841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM0ODQx","avatar_url":"https://avatars3.githubusercontent.com/u/14834841?v=4","gravatar_id":"","url":"https://api.github.com/users/UdL-EPS-SoftArch","html_url":"https://github.com/UdL-EPS-SoftArch","followers_url":"https://api.github.com/users/UdL-EPS-SoftArch/followers","following_url":"https://api.github.com/users/UdL-EPS-SoftArch/following{/other_user}","gists_url":"https://api.github.com/users/UdL-EPS-SoftArch/gists{/gist_id}","starred_url":"https://api.github.com/users/UdL-EPS-SoftArch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdL-EPS-SoftArch/subscriptions","organizations_url":"https://api.github.com/users/UdL-EPS-SoftArch/orgs","repos_url":"https://api.github.com/users/UdL-EPS-SoftArch/repos","events_url":"https://api.github.com/users/UdL-EPS-SoftArch/events{/privacy}","received_events_url":"https://api.github.com/users/UdL-EPS-SoftArch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API","description":"Written Corpus Annotation tool","fork":false,"url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API","forks_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/forks","keys_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/teams","hooks_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/hooks","issue_events_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/events{/number}","events_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/events","assignees_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/assignees{/user}","branches_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/branches{/branch}","tags_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/tags","blobs_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/statuses/{sha}","languages_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/languages","stargazers_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/stargazers","contributors_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/contributors","subscribers_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/subscribers","subscription_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/subscription","commits_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/contents/{+path}","compare_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/merges","archive_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/downloads","issues_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues{/number}","pulls_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls{/number}","milestones_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/milestones{/number}","notifications_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/labels{/name}","releases_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/releases{/id}","deployments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/deployments","created_at":"2018-02-15T13:25:47Z","updated_at":"2018-10-02T14:35:49Z","pushed_at":"2018-10-02T14:47:01Z","git_url":"git://github.com/UdL-EPS-SoftArch/TextAnnot-API.git","ssh_url":"git@github.com:UdL-EPS-SoftArch/TextAnnot-API.git","clone_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API.git","svn_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API","homepage":"","size":395,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":10,"watchers":2,"default_branch":"master"}},"base":{"label":"UdL-EPS-SoftArch:master","ref":"master","sha":"d6839a3fd1ee258a585389e2ff584b9289eb3182","user":{"login":"UdL-EPS-SoftArch","id":14834841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM0ODQx","avatar_url":"https://avatars3.githubusercontent.com/u/14834841?v=4","gravatar_id":"","url":"https://api.github.com/users/UdL-EPS-SoftArch","html_url":"https://github.com/UdL-EPS-SoftArch","followers_url":"https://api.github.com/users/UdL-EPS-SoftArch/followers","following_url":"https://api.github.com/users/UdL-EPS-SoftArch/following{/other_user}","gists_url":"https://api.github.com/users/UdL-EPS-SoftArch/gists{/gist_id}","starred_url":"https://api.github.com/users/UdL-EPS-SoftArch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdL-EPS-SoftArch/subscriptions","organizations_url":"https://api.github.com/users/UdL-EPS-SoftArch/orgs","repos_url":"https://api.github.com/users/UdL-EPS-SoftArch/repos","events_url":"https://api.github.com/users/UdL-EPS-SoftArch/events{/privacy}","received_events_url":"https://api.github.com/users/UdL-EPS-SoftArch/received_events","type":"Organization","site_admin":false},"repo":{"id":121632695,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2MzI2OTU=","name":"TextAnnot-API","full_name":"UdL-EPS-SoftArch/TextAnnot-API","private":false,"owner":{"login":"UdL-EPS-SoftArch","id":14834841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM0ODQx","avatar_url":"https://avatars3.githubusercontent.com/u/14834841?v=4","gravatar_id":"","url":"https://api.github.com/users/UdL-EPS-SoftArch","html_url":"https://github.com/UdL-EPS-SoftArch","followers_url":"https://api.github.com/users/UdL-EPS-SoftArch/followers","following_url":"https://api.github.com/users/UdL-EPS-SoftArch/following{/other_user}","gists_url":"https://api.github.com/users/UdL-EPS-SoftArch/gists{/gist_id}","starred_url":"https://api.github.com/users/UdL-EPS-SoftArch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdL-EPS-SoftArch/subscriptions","organizations_url":"https://api.github.com/users/UdL-EPS-SoftArch/orgs","repos_url":"https://api.github.com/users/UdL-EPS-SoftArch/repos","events_url":"https://api.github.com/users/UdL-EPS-SoftArch/events{/privacy}","received_events_url":"https://api.github.com/users/UdL-EPS-SoftArch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API","description":"Written Corpus Annotation tool","fork":false,"url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API","forks_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/forks","keys_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/teams","hooks_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/hooks","issue_events_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/events{/number}","events_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/events","assignees_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/assignees{/user}","branches_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/branches{/branch}","tags_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/tags","blobs_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/statuses/{sha}","languages_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/languages","stargazers_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/stargazers","contributors_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/contributors","subscribers_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/subscribers","subscription_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/subscription","commits_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/contents/{+path}","compare_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/merges","archive_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/downloads","issues_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues{/number}","pulls_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls{/number}","milestones_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/milestones{/number}","notifications_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/labels{/name}","releases_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/releases{/id}","deployments_url":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/deployments","created_at":"2018-02-15T13:25:47Z","updated_at":"2018-10-02T14:35:49Z","pushed_at":"2018-10-02T14:47:01Z","git_url":"git://github.com/UdL-EPS-SoftArch/TextAnnot-API.git","ssh_url":"git@github.com:UdL-EPS-SoftArch/TextAnnot-API.git","clone_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API.git","svn_url":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API","homepage":"","size":395,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53"},"html":{"href":"https://github.com/UdL-EPS-SoftArch/TextAnnot-API/pull/53"},"issue":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/53"},"comments":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API/statuses/94c86f8c7e6059b7535ae75b96b73dfd77cb958c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 121632695,
"name": "UdL-EPS-SoftArch/TextAnnot-API",
"url": "https://api.github.com/repos/UdL-EPS-SoftArch/TextAnnot-API"
} | {
"id": 1313870,
"login": "rogargon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1313870?",
"url": "https://api.github.com/users/rogargon"
} | {
"id": 14834841,
"login": "UdL-EPS-SoftArch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14834841?",
"url": "https://api.github.com/orgs/UdL-EPS-SoftArch"
} | 2018-10-02T17:41:01 | 8356161945 | {"actor":{"display_login":"rogargon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/secdev/scapy/pulls/comments/243741803","pull_request_review_id":187598025,"id":243741803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc0MTgwMw==","diff_hunk":"@@ -664,17 +664,11 @@ def run(self):\n ins = self.socket\n \n while 1:\n- pkts = ins.sniff(timeout=1, count=1)\n- if len(pkts) == 1:\n- cf = pkts[0]\n- else:\n- cf = None\n+ ins.sniff(store=False, timeout=1,","path":"scapy/contrib/isotp.py","position":9,"original_position":9,"commit_id":"19ab27062d6ecbf1515c6c718c2a5fb98c5ec933","original_commit_id":"789bf554b9f8973a2161748b748a443df2b02a46","user":{"login":"gpotter2","id":10530980,"node_id":"MDQ6VXNlcjEwNTMwOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"body":"Correct... I had a prototype https://github.com/secdev/scapy/pull/1523 of a such implementation, but that wasnt clean enough (now it's outdated).\r\n\r\nI'll come back to you if i get any additional options available","created_at":"2018-12-22T17:17:36Z","updated_at":"2018-12-22T17:17:37Z","html_url":"https://github.com/secdev/scapy/pull/1756#discussion_r243741803","pull_request_url":"https://api.github.com/repos/secdev/scapy/pulls/1756","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments/243741803"},"html":{"href":"https://github.com/secdev/scapy/pull/1756#discussion_r243741803"},"pull_request":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1756"}},"in_reply_to_id":243738671},"pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/1756","id":240638668,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjM4NjY4","html_url":"https://github.com/secdev/scapy/pull/1756","diff_url":"https://github.com/secdev/scapy/pull/1756.diff","patch_url":"https://github.com/secdev/scapy/pull/1756.patch","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1756","number":1756,"state":"open","locked":false,"title":"Refactoring of ReceiveThread in ISOTPSoftSocket","user":{"login":"polybassa","id":1676055,"node_id":"MDQ6VXNlcjE2NzYwNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1676055?v=4","gravatar_id":"","url":"https://api.github.com/users/polybassa","html_url":"https://github.com/polybassa","followers_url":"https://api.github.com/users/polybassa/followers","following_url":"https://api.github.com/users/polybassa/following{/other_user}","gists_url":"https://api.github.com/users/polybassa/gists{/gist_id}","starred_url":"https://api.github.com/users/polybassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polybassa/subscriptions","organizations_url":"https://api.github.com/users/polybassa/orgs","repos_url":"https://api.github.com/users/polybassa/repos","events_url":"https://api.github.com/users/polybassa/events{/privacy}","received_events_url":"https://api.github.com/users/polybassa/received_events","type":"User","site_admin":false},"body":"This should reduce packet losses in ISOTPSoftSocket\r\n\r\n","created_at":"2018-12-22T14:48:23Z","updated_at":"2018-12-22T17:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1d8827a37fa030100abf533d4db3cc7875b265d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/secdev/scapy/pulls/1756/commits","review_comments_url":"https://api.github.com/repos/secdev/scapy/pulls/1756/comments","review_comment_url":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1756/comments","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/19ab27062d6ecbf1515c6c718c2a5fb98c5ec933","head":{"label":"polybassa:ISOTPSoftSocketImprovement","ref":"ISOTPSoftSocketImprovement","sha":"19ab27062d6ecbf1515c6c718c2a5fb98c5ec933","user":{"login":"polybassa","id":1676055,"node_id":"MDQ6VXNlcjE2NzYwNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1676055?v=4","gravatar_id":"","url":"https://api.github.com/users/polybassa","html_url":"https://github.com/polybassa","followers_url":"https://api.github.com/users/polybassa/followers","following_url":"https://api.github.com/users/polybassa/following{/other_user}","gists_url":"https://api.github.com/users/polybassa/gists{/gist_id}","starred_url":"https://api.github.com/users/polybassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polybassa/subscriptions","organizations_url":"https://api.github.com/users/polybassa/orgs","repos_url":"https://api.github.com/users/polybassa/repos","events_url":"https://api.github.com/users/polybassa/events{/privacy}","received_events_url":"https://api.github.com/users/polybassa/received_events","type":"User","site_admin":false},"repo":{"id":123542597,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1NDI1OTc=","name":"scapy-1","full_name":"polybassa/scapy-1","private":false,"owner":{"login":"polybassa","id":1676055,"node_id":"MDQ6VXNlcjE2NzYwNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1676055?v=4","gravatar_id":"","url":"https://api.github.com/users/polybassa","html_url":"https://github.com/polybassa","followers_url":"https://api.github.com/users/polybassa/followers","following_url":"https://api.github.com/users/polybassa/following{/other_user}","gists_url":"https://api.github.com/users/polybassa/gists{/gist_id}","starred_url":"https://api.github.com/users/polybassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polybassa/subscriptions","organizations_url":"https://api.github.com/users/polybassa/orgs","repos_url":"https://api.github.com/users/polybassa/repos","events_url":"https://api.github.com/users/polybassa/events{/privacy}","received_events_url":"https://api.github.com/users/polybassa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/polybassa/scapy-1","description":"Scapy: the python-based interactive packet manipulation program & library. Supports Python 2 & Python 3.","fork":true,"url":"https://api.github.com/repos/polybassa/scapy-1","forks_url":"https://api.github.com/repos/polybassa/scapy-1/forks","keys_url":"https://api.github.com/repos/polybassa/scapy-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polybassa/scapy-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polybassa/scapy-1/teams","hooks_url":"https://api.github.com/repos/polybassa/scapy-1/hooks","issue_events_url":"https://api.github.com/repos/polybassa/scapy-1/issues/events{/number}","events_url":"https://api.github.com/repos/polybassa/scapy-1/events","assignees_url":"https://api.github.com/repos/polybassa/scapy-1/assignees{/user}","branches_url":"https://api.github.com/repos/polybassa/scapy-1/branches{/branch}","tags_url":"https://api.github.com/repos/polybassa/scapy-1/tags","blobs_url":"https://api.github.com/repos/polybassa/scapy-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polybassa/scapy-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polybassa/scapy-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/polybassa/scapy-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polybassa/scapy-1/statuses/{sha}","languages_url":"https://api.github.com/repos/polybassa/scapy-1/languages","stargazers_url":"https://api.github.com/repos/polybassa/scapy-1/stargazers","contributors_url":"https://api.github.com/repos/polybassa/scapy-1/contributors","subscribers_url":"https://api.github.com/repos/polybassa/scapy-1/subscribers","subscription_url":"https://api.github.com/repos/polybassa/scapy-1/subscription","commits_url":"https://api.github.com/repos/polybassa/scapy-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/polybassa/scapy-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/polybassa/scapy-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/polybassa/scapy-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/polybassa/scapy-1/contents/{+path}","compare_url":"https://api.github.com/repos/polybassa/scapy-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polybassa/scapy-1/merges","archive_url":"https://api.github.com/repos/polybassa/scapy-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polybassa/scapy-1/downloads","issues_url":"https://api.github.com/repos/polybassa/scapy-1/issues{/number}","pulls_url":"https://api.github.com/repos/polybassa/scapy-1/pulls{/number}","milestones_url":"https://api.github.com/repos/polybassa/scapy-1/milestones{/number}","notifications_url":"https://api.github.com/repos/polybassa/scapy-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polybassa/scapy-1/labels{/name}","releases_url":"https://api.github.com/repos/polybassa/scapy-1/releases{/id}","deployments_url":"https://api.github.com/repos/polybassa/scapy-1/deployments","created_at":"2018-03-02T06:57:23Z","updated_at":"2018-11-28T13:04:18Z","pushed_at":"2018-12-22T17:12:36Z","git_url":"git://github.com/polybassa/scapy-1.git","ssh_url":"git@github.com:polybassa/scapy-1.git","clone_url":"https://github.com/polybassa/scapy-1.git","svn_url":"https://github.com/polybassa/scapy-1","homepage":"http://www.secdev.org/projects/scapy/","size":72955,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"secdev:master","ref":"master","sha":"179c13a15c0f829a78d41390e70c518329e08ce1","user":{"login":"secdev","id":14927208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTI3MjA4","avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"repo":{"id":43509302,"node_id":"MDEwOlJlcG9zaXRvcnk0MzUwOTMwMg==","name":"scapy","full_name":"secdev/scapy","private":false,"owner":{"login":"secdev","id":14927208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTI3MjA4","avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/secdev/scapy","description":"Scapy: the Python-based interactive packet manipulation program & library. Supports Python 2 & Python 3.","fork":false,"url":"https://api.github.com/repos/secdev/scapy","forks_url":"https://api.github.com/repos/secdev/scapy/forks","keys_url":"https://api.github.com/repos/secdev/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/secdev/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/secdev/scapy/teams","hooks_url":"https://api.github.com/repos/secdev/scapy/hooks","issue_events_url":"https://api.github.com/repos/secdev/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/secdev/scapy/events","assignees_url":"https://api.github.com/repos/secdev/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/secdev/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/secdev/scapy/tags","blobs_url":"https://api.github.com/repos/secdev/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/secdev/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/secdev/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/secdev/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/secdev/scapy/languages","stargazers_url":"https://api.github.com/repos/secdev/scapy/stargazers","contributors_url":"https://api.github.com/repos/secdev/scapy/contributors","subscribers_url":"https://api.github.com/repos/secdev/scapy/subscribers","subscription_url":"https://api.github.com/repos/secdev/scapy/subscription","commits_url":"https://api.github.com/repos/secdev/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/secdev/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/secdev/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/secdev/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/secdev/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/secdev/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/secdev/scapy/merges","archive_url":"https://api.github.com/repos/secdev/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/secdev/scapy/downloads","issues_url":"https://api.github.com/repos/secdev/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/secdev/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/secdev/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/secdev/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/secdev/scapy/labels{/name}","releases_url":"https://api.github.com/repos/secdev/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/secdev/scapy/deployments","created_at":"2015-10-01T17:06:46Z","updated_at":"2018-12-22T10:01:34Z","pushed_at":"2018-12-22T17:15:36Z","git_url":"git://github.com/secdev/scapy.git","ssh_url":"git@github.com:secdev/scapy.git","clone_url":"https://github.com/secdev/scapy.git","svn_url":"https://github.com/secdev/scapy","homepage":"https://scapy.net","size":73064,"stargazers_count":3315,"watchers_count":3315,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":758,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":758,"open_issues":64,"watchers":3315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1756"},"html":{"href":"https://github.com/secdev/scapy/pull/1756"},"issue":{"href":"https://api.github.com/repos/secdev/scapy/issues/1756"},"comments":{"href":"https://api.github.com/repos/secdev/scapy/issues/1756/comments"},"review_comments":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1756/comments"},"review_comment":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1756/commits"},"statuses":{"href":"https://api.github.com/repos/secdev/scapy/statuses/19ab27062d6ecbf1515c6c718c2a5fb98c5ec933"}},"author_association":"CONTRIBUTOR"}} | {
"id": 43509302,
"name": "secdev/scapy",
"url": "https://api.github.com/repos/secdev/scapy"
} | {
"id": 10530980,
"login": "gpotter2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10530980?",
"url": "https://api.github.com/users/gpotter2"
} | {
"id": 14927208,
"login": "secdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14927208?",
"url": "https://api.github.com/orgs/secdev"
} | 2018-12-22T17:17:36 | 8795565302 | {"actor":{"display_login":"gpotter2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments/172014221","pull_request_review_id":100972365,"id":172014221,"diff_hunk":"@@ -46,7 +46,7 @@ public function createListQueryBuilder(array $entityConfig, $sortField = null, $\n $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);\n }\n \n- if (!empty($dqlFilter)) {","path":"src/Search/QueryBuilder.php","position":4,"original_position":4,"commit_id":"fb328d8fbb8835e079a6bdab8079e4a9e526377e","original_commit_id":"fb328d8fbb8835e079a6bdab8079e4a9e526377e","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?","created_at":"2018-03-03T11:20:13Z","updated_at":"2018-03-03T11:21:27Z","html_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116#discussion_r172014221","pull_request_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments/172014221"},"html":{"href":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116#discussion_r172014221"},"pull_request":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116"}}},"pull_request":{"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116","id":172621899,"html_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116","diff_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116.diff","patch_url":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116.patch","issue_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2116","number":2116,"state":"open","locked":false,"title":"'empty(...)' usage","user":{"login":"grachevko","id":8628465,"avatar_url":"https://avatars0.githubusercontent.com/u/8628465?v=4","gravatar_id":"","url":"https://api.github.com/users/grachevko","html_url":"https://github.com/grachevko","followers_url":"https://api.github.com/users/grachevko/followers","following_url":"https://api.github.com/users/grachevko/following{/other_user}","gists_url":"https://api.github.com/users/grachevko/gists{/gist_id}","starred_url":"https://api.github.com/users/grachevko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grachevko/subscriptions","organizations_url":"https://api.github.com/users/grachevko/orgs","repos_url":"https://api.github.com/users/grachevko/repos","events_url":"https://api.github.com/users/grachevko/events{/privacy}","received_events_url":"https://api.github.com/users/grachevko/received_events","type":"User","site_admin":false},"body":"https://github.com/kalessil/phpinspectionsea/blob/master/docs/types-compatibility.md#empty-usage","created_at":"2018-03-02T22:37:32Z","updated_at":"2018-03-03T11:21:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"897cf18a597b8714b8499d8eebdeabb71fe24ffb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116/commits","review_comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116/comments","review_comment_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2116/comments","statuses_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/fb328d8fbb8835e079a6bdab8079e4a9e526377e","head":{"label":"grachevko:empty-usage","ref":"empty-usage","sha":"fb328d8fbb8835e079a6bdab8079e4a9e526377e","user":{"login":"grachevko","id":8628465,"avatar_url":"https://avatars0.githubusercontent.com/u/8628465?v=4","gravatar_id":"","url":"https://api.github.com/users/grachevko","html_url":"https://github.com/grachevko","followers_url":"https://api.github.com/users/grachevko/followers","following_url":"https://api.github.com/users/grachevko/following{/other_user}","gists_url":"https://api.github.com/users/grachevko/gists{/gist_id}","starred_url":"https://api.github.com/users/grachevko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grachevko/subscriptions","organizations_url":"https://api.github.com/users/grachevko/orgs","repos_url":"https://api.github.com/users/grachevko/repos","events_url":"https://api.github.com/users/grachevko/events{/privacy}","received_events_url":"https://api.github.com/users/grachevko/received_events","type":"User","site_admin":false},"repo":{"id":93300107,"name":"EasyAdminBundle","full_name":"grachevko/EasyAdminBundle","owner":{"login":"grachevko","id":8628465,"avatar_url":"https://avatars0.githubusercontent.com/u/8628465?v=4","gravatar_id":"","url":"https://api.github.com/users/grachevko","html_url":"https://github.com/grachevko","followers_url":"https://api.github.com/users/grachevko/followers","following_url":"https://api.github.com/users/grachevko/following{/other_user}","gists_url":"https://api.github.com/users/grachevko/gists{/gist_id}","starred_url":"https://api.github.com/users/grachevko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grachevko/subscriptions","organizations_url":"https://api.github.com/users/grachevko/orgs","repos_url":"https://api.github.com/users/grachevko/repos","events_url":"https://api.github.com/users/grachevko/events{/privacy}","received_events_url":"https://api.github.com/users/grachevko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grachevko/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":true,"url":"https://api.github.com/repos/grachevko/EasyAdminBundle","forks_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/grachevko/EasyAdminBundle/deployments","created_at":"2017-06-04T08:26:40Z","updated_at":"2017-06-04T08:26:43Z","pushed_at":"2018-03-03T11:20:18Z","git_url":"git://github.com/grachevko/EasyAdminBundle.git","ssh_url":"git@github.com:grachevko/EasyAdminBundle.git","clone_url":"https://github.com/grachevko/EasyAdminBundle.git","svn_url":"https://github.com/grachevko/EasyAdminBundle","homepage":"","size":11141,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyCorp:master","ref":"master","sha":"601f93d379c437b3bf32cf74f16a602781c9a858","user":{"login":"EasyCorp","id":14944619,"avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"repo":{"id":29126334,"name":"EasyAdminBundle","full_name":"EasyCorp/EasyAdminBundle","owner":{"login":"EasyCorp","id":14944619,"avatar_url":"https://avatars3.githubusercontent.com/u/14944619?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyCorp","html_url":"https://github.com/EasyCorp","followers_url":"https://api.github.com/users/EasyCorp/followers","following_url":"https://api.github.com/users/EasyCorp/following{/other_user}","gists_url":"https://api.github.com/users/EasyCorp/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyCorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyCorp/subscriptions","organizations_url":"https://api.github.com/users/EasyCorp/orgs","repos_url":"https://api.github.com/users/EasyCorp/repos","events_url":"https://api.github.com/users/EasyCorp/events{/privacy}","received_events_url":"https://api.github.com/users/EasyCorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EasyCorp/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":false,"url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle","forks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/deployments","created_at":"2015-01-12T08:43:02Z","updated_at":"2018-03-02T19:36:30Z","pushed_at":"2018-03-03T11:17:38Z","git_url":"git://github.com/EasyCorp/EasyAdminBundle.git","ssh_url":"git@github.com:EasyCorp/EasyAdminBundle.git","clone_url":"https://github.com/EasyCorp/EasyAdminBundle.git","svn_url":"https://github.com/EasyCorp/EasyAdminBundle","homepage":"","size":11476,"stargazers_count":2010,"watchers_count":2010,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":430,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":430,"open_issues":12,"watchers":2010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116"},"html":{"href":"https://github.com/EasyCorp/EasyAdminBundle/pull/2116"},"issue":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2116"},"comments":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/issues/2116/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/pulls/2116/commits"},"statuses":{"href":"https://api.github.com/repos/EasyCorp/EasyAdminBundle/statuses/fb328d8fbb8835e079a6bdab8079e4a9e526377e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 29126334,
"name": "EasyCorp/EasyAdminBundle",
"url": "https://api.github.com/repos/EasyCorp/EasyAdminBundle"
} | {
"id": 73419,
"login": "javiereguiluz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/73419?",
"url": "https://api.github.com/users/javiereguiluz"
} | {
"id": 14944619,
"login": "EasyCorp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14944619?",
"url": "https://api.github.com/orgs/EasyCorp"
} | 2018-03-03T11:20:13 | 7325617679 | {"actor":{"display_login":"javiereguiluz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments/231075365","pull_request_review_id":171957212,"id":231075365,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA3NTM2NQ==","diff_hunk":"@@ -35,10 +57,88 @@ def get_planned_changes(self):\n \n return move_entries, should_archive_source\n \n+ def is_source_valid(self):\n+ \"\"\"\n+ Returns whether the specified source company is a valid merge source.\n+\n+ This checks whether there are any references to the source company (other than\n+ references through the relations specified in ALLOWED_RELATIONS_FOR_MERGING).\n+ It also checks if the source company has any references to other companies.\n+ Merging is not permitted if either of those types of reference exists.\n+ \"\"\"\n+ if not hasattr(self, '_cached_is_source_valid'):\n+ self._cached_is_source_valid = self._is_source_valid()\n+\n+ return self._cached_is_source_valid\n+\n+ def is_target_valid(self):\n+ \"\"\"\n+ Returns whether the specified target company is a valid merge target.\n+\n+ This checks that the target company isn't archived.\n+ \"\"\"\n+ return not self.target_company.archived\n+\n+ def is_valid(self):\n+ \"\"\"Returns whether the merge is allowed.\"\"\"\n+ return self.is_source_valid() and self.is_target_valid()\n+\n+ @transaction.atomic\n+ def perform_merge(self, user):\n+ \"\"\"\n+ Merges the source company into the target company.\n+\n+ is_valid() should be called first to check if the merge is allowed. DataHubException\n+ will be raised if the merge is not allowed, and perform_merge() was called anyway.\n+ \"\"\"\n+ if not self.is_valid():\n+ raise MergeNotAllowedError()\n+\n+ num_interactions_moved = 0\n+ num_contacts_moved = 0\n+\n+ for interaction in self.source_company.interactions.iterator():\n+ interaction.company = self.target_company\n+ interaction.save(update_fields=('company',))\n+ num_interactions_moved += 1\n+\n+ for contact in self.source_company.contacts.iterator():\n+ contact.company = self.target_company\n+ contact.save(update_fields=('company',))\n+ num_contacts_moved += 1\n+\n+ self.source_company.mark_as_transferred(\n+ self.target_company,\n+ Company.TRANSFER_REASONS.duplicate,\n+ user,\n+ )\n+\n+ return MergeResult(num_interactions_moved, num_contacts_moved)\n+\n @staticmethod\n def _append_move_entry(to_move, count, model):\n if count == 0:\n return\n \n move_item = MoveEntry(count, model._meta)\n to_move.append(move_item)\n+\n+ def _is_source_valid(self):\n+ # Checks that there are no references to the source company from other objects\n+ # (other than via the fields specified in ALLOWED_RELATIONS_FOR_MERGING).","path":"datahub/company/merge.py","position":116,"original_position":116,"commit_id":"7cd6241f3571f95e9d9a680d069c59d4e3bc5f84","original_commit_id":"6f7c3b968a0af873efb8c537ba7262cfe09b2fbf","user":{"login":"elcct","id":5889630,"node_id":"MDQ6VXNlcjU4ODk2MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5889630?v=4","gravatar_id":"","url":"https://api.github.com/users/elcct","html_url":"https://github.com/elcct","followers_url":"https://api.github.com/users/elcct/followers","following_url":"https://api.github.com/users/elcct/following{/other_user}","gists_url":"https://api.github.com/users/elcct/gists{/gist_id}","starred_url":"https://api.github.com/users/elcct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcct/subscriptions","organizations_url":"https://api.github.com/users/elcct/orgs","repos_url":"https://api.github.com/users/elcct/repos","events_url":"https://api.github.com/users/elcct/events{/privacy}","received_events_url":"https://api.github.com/users/elcct/received_events","type":"User","site_admin":false},"body":"It is good now, thanks!","created_at":"2018-11-06T10:44:31Z","updated_at":"2018-11-06T10:44:31Z","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/1206#discussion_r231075365","pull_request_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments/231075365"},"html":{"href":"https://github.com/uktrade/data-hub-leeloo/pull/1206#discussion_r231075365"},"pull_request":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206"}},"in_reply_to_id":231071591},"pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206","id":228374000,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mzc0MDAw","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/1206","diff_url":"https://github.com/uktrade/data-hub-leeloo/pull/1206.diff","patch_url":"https://github.com/uktrade/data-hub-leeloo/pull/1206.patch","issue_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1206","number":1206,"state":"open","locked":false,"title":"Implement merging part of company merging tool","user":{"login":"reupen","id":12693549,"node_id":"MDQ6VXNlcjEyNjkzNTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/12693549?v=4","gravatar_id":"","url":"https://api.github.com/users/reupen","html_url":"https://github.com/reupen","followers_url":"https://api.github.com/users/reupen/followers","following_url":"https://api.github.com/users/reupen/following{/other_user}","gists_url":"https://api.github.com/users/reupen/gists{/gist_id}","starred_url":"https://api.github.com/users/reupen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reupen/subscriptions","organizations_url":"https://api.github.com/users/reupen/orgs","repos_url":"https://api.github.com/users/reupen/repos","events_url":"https://api.github.com/users/reupen/events{/privacy}","received_events_url":"https://api.github.com/users/reupen/received_events","type":"User","site_admin":false},"body":"### Description of change\r\n\r\nThis implements the actual merging logic, so that the merging tool actually merges the two companies selected.\r\n\r\nIt also moves all the existing merging logic (that was on the model) to the DuplicateCompanyMerger class to keep it in one place.\r\n\r\nI'd like to make the messages more specific about the reason for not allowing the merge, but I'll come back to that if I get time (it could get complicated).\r\n\r\nNext up after this will be to handle the resulting Elasticsearch sync activity properly.\r\n\r\n### Checklist\r\n\r\n* [ ] Has a new newsfragment been created? Check [changelog/README.rst](https://github.com/uktrade/data-hub-leeloo/blob/master/changelog/README.rst) for instructions\r\n* [ ] Have any relevant search models been updated?\r\n* [ ] Have any relevant fixtures (`fixtures/test_data.yaml`) been updated?\r\n* [ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?\r\n* [ ] Has the admin site been updated (for new models, fields etc.)?\r\n* [ ] Has the README been updated (if needed)?\r\n","created_at":"2018-11-05T14:38:58Z","updated_at":"2018-11-06T10:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcfaa09e3bc213e0c775ae6adb359aa5eefa7f96","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marcuspp","id":8222658,"node_id":"MDQ6VXNlcjgyMjI2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8222658?v=4","gravatar_id":"","url":"https://api.github.com/users/marcuspp","html_url":"https://github.com/marcuspp","followers_url":"https://api.github.com/users/marcuspp/followers","following_url":"https://api.github.com/users/marcuspp/following{/other_user}","gists_url":"https://api.github.com/users/marcuspp/gists{/gist_id}","starred_url":"https://api.github.com/users/marcuspp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcuspp/subscriptions","organizations_url":"https://api.github.com/users/marcuspp/orgs","repos_url":"https://api.github.com/users/marcuspp/repos","events_url":"https://api.github.com/users/marcuspp/events{/privacy}","received_events_url":"https://api.github.com/users/marcuspp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1206/comments","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/7cd6241f3571f95e9d9a680d069c59d4e3bc5f84","head":{"label":"uktrade:feature/company-transfer-tool-pt5","ref":"feature/company-transfer-tool-pt5","sha":"7cd6241f3571f95e9d9a680d069c59d4e3bc5f84","user":{"login":"uktrade","id":15107524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTA3NTI0","avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":73379434,"node_id":"MDEwOlJlcG9zaXRvcnk3MzM3OTQzNA==","name":"data-hub-leeloo","full_name":"uktrade/data-hub-leeloo","private":false,"owner":{"login":"uktrade","id":15107524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTA3NTI0","avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uktrade/data-hub-leeloo","description":"Django API for Data Hub frontend","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-leeloo","forks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/deployments","created_at":"2016-11-10T12:21:01Z","updated_at":"2018-11-06T10:33:50Z","pushed_at":"2018-11-06T10:42:59Z","git_url":"git://github.com/uktrade/data-hub-leeloo.git","ssh_url":"git@github.com:uktrade/data-hub-leeloo.git","clone_url":"https://github.com/uktrade/data-hub-leeloo.git","svn_url":"https://github.com/uktrade/data-hub-leeloo","homepage":null,"size":6166,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":1,"default_branch":"develop"}},"base":{"label":"uktrade:develop","ref":"develop","sha":"252368875500a506826f09a794659aac70bcc72a","user":{"login":"uktrade","id":15107524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTA3NTI0","avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":73379434,"node_id":"MDEwOlJlcG9zaXRvcnk3MzM3OTQzNA==","name":"data-hub-leeloo","full_name":"uktrade/data-hub-leeloo","private":false,"owner":{"login":"uktrade","id":15107524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTA3NTI0","avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uktrade/data-hub-leeloo","description":"Django API for Data Hub frontend","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-leeloo","forks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/deployments","created_at":"2016-11-10T12:21:01Z","updated_at":"2018-11-06T10:33:50Z","pushed_at":"2018-11-06T10:42:59Z","git_url":"git://github.com/uktrade/data-hub-leeloo.git","ssh_url":"git@github.com:uktrade/data-hub-leeloo.git","clone_url":"https://github.com/uktrade/data-hub-leeloo.git","svn_url":"https://github.com/uktrade/data-hub-leeloo","homepage":null,"size":6166,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206"},"html":{"href":"https://github.com/uktrade/data-hub-leeloo/pull/1206"},"issue":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1206"},"comments":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/7cd6241f3571f95e9d9a680d069c59d4e3bc5f84"}},"author_association":"MEMBER"}} | {
"id": 73379434,
"name": "uktrade/data-hub-leeloo",
"url": "https://api.github.com/repos/uktrade/data-hub-leeloo"
} | {
"id": 5889630,
"login": "elcct",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5889630?",
"url": "https://api.github.com/users/elcct"
} | {
"id": 15107524,
"login": "uktrade",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15107524?",
"url": "https://api.github.com/orgs/uktrade"
} | 2018-11-06T10:44:31 | 8541773539 | {"actor":{"display_login":"elcct"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/src-d/gitbase/pulls/comments/199531276","pull_request_review_id":133667529,"id":199531276,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTUzMTI3Ng==","diff_hunk":"@@ -96,6 +96,17 @@ func TestSquashJoins(t *testing.T) {\n \n \tresult, err := SquashJoins(sql.NewEmptyContext(), analyzer.NewDefault(nil), node)\n \trequire.NoError(err)\n+\tresult, err = result.TransformUp(func(n sql.Node) (sql.Node, error) {\n+\t\tfmt.Printf(\"%T\\n\", n)","path":"internal/rule/squashjoins_test.go","position":5,"original_position":5,"commit_id":"f3bb928e7d15667b2341f6ce313a7a417412a189","original_commit_id":"f3bb928e7d15667b2341f6ce313a7a417412a189","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-07-02T15:15:05Z","updated_at":"2018-07-02T15:15:05Z","html_url":"https://github.com/src-d/gitbase/pull/363#discussion_r199531276","pull_request_url":"https://api.github.com/repos/src-d/gitbase/pulls/363","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/comments/199531276"},"html":{"href":"https://github.com/src-d/gitbase/pull/363#discussion_r199531276"},"pull_request":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/363"}},"in_reply_to_id":199529798},"pull_request":{"url":"https://api.github.com/repos/src-d/gitbase/pulls/363","id":198688460,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Njg4NDYw","html_url":"https://github.com/src-d/gitbase/pull/363","diff_url":"https://github.com/src-d/gitbase/pull/363.diff","patch_url":"https://github.com/src-d/gitbase/pull/363.patch","issue_url":"https://api.github.com/repos/src-d/gitbase/issues/363","number":363,"state":"open","locked":false,"title":"internal/rule: fix indexes of filters in squash","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"body":"Fixes #359 ","created_at":"2018-07-02T13:58:16Z","updated_at":"2018-07-02T15:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"394658aacb8d9e9c93af26f260d62ca04ca93634","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/gitbase/pulls/363/commits","review_comments_url":"https://api.github.com/repos/src-d/gitbase/pulls/363/comments","review_comment_url":"https://api.github.com/repos/src-d/gitbase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/gitbase/issues/363/comments","statuses_url":"https://api.github.com/repos/src-d/gitbase/statuses/f3bb928e7d15667b2341f6ce313a7a417412a189","head":{"label":"erizocosmico:fix/squash-filter","ref":"fix/squash-filter","sha":"f3bb928e7d15667b2341f6ce313a7a417412a189","user":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"repo":{"id":121739891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3Mzk4OTE=","name":"gitquery","full_name":"erizocosmico/gitquery","owner":{"login":"erizocosmico","id":1312023,"node_id":"MDQ6VXNlcjEzMTIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1312023?v=4","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erizocosmico/gitquery","description":"SQL interface to Git repositories, written in Go.","fork":true,"url":"https://api.github.com/repos/erizocosmico/gitquery","forks_url":"https://api.github.com/repos/erizocosmico/gitquery/forks","keys_url":"https://api.github.com/repos/erizocosmico/gitquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erizocosmico/gitquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erizocosmico/gitquery/teams","hooks_url":"https://api.github.com/repos/erizocosmico/gitquery/hooks","issue_events_url":"https://api.github.com/repos/erizocosmico/gitquery/issues/events{/number}","events_url":"https://api.github.com/repos/erizocosmico/gitquery/events","assignees_url":"https://api.github.com/repos/erizocosmico/gitquery/assignees{/user}","branches_url":"https://api.github.com/repos/erizocosmico/gitquery/branches{/branch}","tags_url":"https://api.github.com/repos/erizocosmico/gitquery/tags","blobs_url":"https://api.github.com/repos/erizocosmico/gitquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erizocosmico/gitquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erizocosmico/gitquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/erizocosmico/gitquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erizocosmico/gitquery/statuses/{sha}","languages_url":"https://api.github.com/repos/erizocosmico/gitquery/languages","stargazers_url":"https://api.github.com/repos/erizocosmico/gitquery/stargazers","contributors_url":"https://api.github.com/repos/erizocosmico/gitquery/contributors","subscribers_url":"https://api.github.com/repos/erizocosmico/gitquery/subscribers","subscription_url":"https://api.github.com/repos/erizocosmico/gitquery/subscription","commits_url":"https://api.github.com/repos/erizocosmico/gitquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/erizocosmico/gitquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/erizocosmico/gitquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/erizocosmico/gitquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/erizocosmico/gitquery/contents/{+path}","compare_url":"https://api.github.com/repos/erizocosmico/gitquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erizocosmico/gitquery/merges","archive_url":"https://api.github.com/repos/erizocosmico/gitquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erizocosmico/gitquery/downloads","issues_url":"https://api.github.com/repos/erizocosmico/gitquery/issues{/number}","pulls_url":"https://api.github.com/repos/erizocosmico/gitquery/pulls{/number}","milestones_url":"https://api.github.com/repos/erizocosmico/gitquery/milestones{/number}","notifications_url":"https://api.github.com/repos/erizocosmico/gitquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erizocosmico/gitquery/labels{/name}","releases_url":"https://api.github.com/repos/erizocosmico/gitquery/releases{/id}","deployments_url":"https://api.github.com/repos/erizocosmico/gitquery/deployments","created_at":"2018-02-16T10:42:56Z","updated_at":"2018-02-16T10:42:58Z","pushed_at":"2018-07-02T14:23:10Z","git_url":"git://github.com/erizocosmico/gitquery.git","ssh_url":"git@github.com:erizocosmico/gitquery.git","clone_url":"https://github.com/erizocosmico/gitquery.git","svn_url":"https://github.com/erizocosmico/gitquery","homepage":"","size":74633,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"9825ae20f48f1c534296b4dad824c85990971e63","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":68594286,"node_id":"MDEwOlJlcG9zaXRvcnk2ODU5NDI4Ng==","name":"gitbase","full_name":"src-d/gitbase","owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/gitbase","description":"SQL interface to Git repositories, written in Go. https://docs.sourced.tech/gitbase","fork":false,"url":"https://api.github.com/repos/src-d/gitbase","forks_url":"https://api.github.com/repos/src-d/gitbase/forks","keys_url":"https://api.github.com/repos/src-d/gitbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/gitbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/gitbase/teams","hooks_url":"https://api.github.com/repos/src-d/gitbase/hooks","issue_events_url":"https://api.github.com/repos/src-d/gitbase/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/gitbase/events","assignees_url":"https://api.github.com/repos/src-d/gitbase/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/gitbase/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/gitbase/tags","blobs_url":"https://api.github.com/repos/src-d/gitbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/gitbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/gitbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/gitbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/gitbase/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/gitbase/languages","stargazers_url":"https://api.github.com/repos/src-d/gitbase/stargazers","contributors_url":"https://api.github.com/repos/src-d/gitbase/contributors","subscribers_url":"https://api.github.com/repos/src-d/gitbase/subscribers","subscription_url":"https://api.github.com/repos/src-d/gitbase/subscription","commits_url":"https://api.github.com/repos/src-d/gitbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/gitbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/gitbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/gitbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/gitbase/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/gitbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/gitbase/merges","archive_url":"https://api.github.com/repos/src-d/gitbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/gitbase/downloads","issues_url":"https://api.github.com/repos/src-d/gitbase/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/gitbase/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/gitbase/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/gitbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/gitbase/labels{/name}","releases_url":"https://api.github.com/repos/src-d/gitbase/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/gitbase/deployments","created_at":"2016-09-19T10:14:13Z","updated_at":"2018-07-02T10:47:23Z","pushed_at":"2018-07-02T14:23:11Z","git_url":"git://github.com/src-d/gitbase.git","ssh_url":"git@github.com:src-d/gitbase.git","clone_url":"https://github.com/src-d/gitbase.git","svn_url":"https://github.com/src-d/gitbase","homepage":"","size":74514,"stargazers_count":1080,"watchers_count":1080,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":23,"watchers":1080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/363"},"html":{"href":"https://github.com/src-d/gitbase/pull/363"},"issue":{"href":"https://api.github.com/repos/src-d/gitbase/issues/363"},"comments":{"href":"https://api.github.com/repos/src-d/gitbase/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/gitbase/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/gitbase/statuses/f3bb928e7d15667b2341f6ce313a7a417412a189"}},"author_association":"MEMBER"}} | {
"id": 68594286,
"name": "src-d/gitbase",
"url": "https://api.github.com/repos/src-d/gitbase"
} | {
"id": 1312023,
"login": "erizocosmico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1312023?",
"url": "https://api.github.com/users/erizocosmico"
} | {
"id": 15128793,
"login": "src-d",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15128793?",
"url": "https://api.github.com/orgs/src-d"
} | 2018-07-02T15:15:05 | 7907302483 | {"actor":{"display_login":"erizocosmico"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments/226019234","pull_request_review_id":165742021,"id":226019234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjAxOTIzNA==","diff_hunk":"@@ -0,0 +1,156 @@\n+{\n+ \"project_one_line\": {\n+ \"start_header\": null,\n+ \"end_header\": null,\n+ \"source\": \"https://github.com/open-source-economics/OG-USA\",\n+ \"type\": \"html\",\n+ \"data\": \"<p>Dynamic Tax Scoring Model</p>\"\n+ },\n+ \"key_features\": {\n+ \"start_header\": null,\n+ \"end_header\": null,\n+ \"source\": null,\n+ \"type\": null,\n+ \"data\": null\n+ },\n+ \"project_overview\": {\n+ \"start_header\": \"OG-USA\",\n+ \"end_header\": \"Disclaimer\",\n+ \"source\": \"README.md\",\n+ \"type\": \"github_file\",\n+ \"data\": null\n+ },\n+ \"citation\": {\n+ \"start_header\": \"Citing OG-USA\",\n+ \"end_header\": null,\n+ \"source\": \"README.md\",\n+ \"type\": \"github_file\",\n+ \"data\": null","path":"PSL_catalog.json","position":28,"original_position":28,"commit_id":"ae01f3ed1d92a747a6ad4a3ca657cc6ee6f74bc4","original_commit_id":"ae01f3ed1d92a747a6ad4a3ca657cc6ee6f74bc4","user":{"login":"jdebacker","id":10715924,"node_id":"MDQ6VXNlcjEwNzE1OTI0","avatar_url":"https://avatars1.githubusercontent.com/u/10715924?v=4","gravatar_id":"","url":"https://api.github.com/users/jdebacker","html_url":"https://github.com/jdebacker","followers_url":"https://api.github.com/users/jdebacker/followers","following_url":"https://api.github.com/users/jdebacker/following{/other_user}","gists_url":"https://api.github.com/users/jdebacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jdebacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdebacker/subscriptions","organizations_url":"https://api.github.com/users/jdebacker/orgs","repos_url":"https://api.github.com/users/jdebacker/repos","events_url":"https://api.github.com/users/jdebacker/events{/privacy}","received_events_url":"https://api.github.com/users/jdebacker/received_events","type":"User","site_admin":false},"body":"Data:\r\n`<p>Please cite the source of your analysis as \"OG-USA release #.#.#, author's calculations.\" If you wish to link to OG-USA, https://github.com/open-source-economics/OG-USA is preferred. Additionally, we strongly recommend that you describe the input data used, and provide a link to the materials required to replicate your analysis or, at least, note that those materials are available upon request.</p>`","created_at":"2018-10-17T17:11:26Z","updated_at":"2018-10-17T17:11:26Z","html_url":"https://github.com/open-source-economics/OG-USA/pull/396#discussion_r226019234","pull_request_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments/226019234"},"html":{"href":"https://github.com/open-source-economics/OG-USA/pull/396#discussion_r226019234"},"pull_request":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396","id":223627773,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjI3Nzcz","html_url":"https://github.com/open-source-economics/OG-USA/pull/396","diff_url":"https://github.com/open-source-economics/OG-USA/pull/396.diff","patch_url":"https://github.com/open-source-economics/OG-USA/pull/396.patch","issue_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/396","number":396,"state":"open","locked":false,"title":"Add PSL Catalog JSON File","user":{"login":"andersonfrailey","id":20684675,"node_id":"MDQ6VXNlcjIwNjg0Njc1","avatar_url":"https://avatars0.githubusercontent.com/u/20684675?v=4","gravatar_id":"","url":"https://api.github.com/users/andersonfrailey","html_url":"https://github.com/andersonfrailey","followers_url":"https://api.github.com/users/andersonfrailey/followers","following_url":"https://api.github.com/users/andersonfrailey/following{/other_user}","gists_url":"https://api.github.com/users/andersonfrailey/gists{/gist_id}","starred_url":"https://api.github.com/users/andersonfrailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersonfrailey/subscriptions","organizations_url":"https://api.github.com/users/andersonfrailey/orgs","repos_url":"https://api.github.com/users/andersonfrailey/repos","events_url":"https://api.github.com/users/andersonfrailey/events{/privacy}","received_events_url":"https://api.github.com/users/andersonfrailey/received_events","type":"User","site_admin":false},"body":"This PR proposes adding a JSON file containing the data needed to generate a webpage for OG-USA on the PSL website. Documentation describing how this works can be found [here](https://github.com/open-source-economics/PSL-Core/tree/master/Core/Tools/Catalog-Builder). @hdoupe opened a [similar PR](https://github.com/open-source-economics/Tax-Calculator/pull/2082) in Tax-Calculator and you can see what the Tax-Calculator page looks like [here](https://open-source-economics.github.io/PSL-Core/Core/Tools/Web/pages/projects/Tax-Calculator.html).\r\n\r\n@rickecon and @jdebacker, y'all's review would be especially helpful to make sure I got all of the information correct.","created_at":"2018-10-17T14:30:23Z","updated_at":"2018-10-17T17:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d1d08b8d4df0964e5846bb2ab85159e9d62802e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/396/comments","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/ae01f3ed1d92a747a6ad4a3ca657cc6ee6f74bc4","head":{"label":"andersonfrailey:psl_catalog","ref":"psl_catalog","sha":"ae01f3ed1d92a747a6ad4a3ca657cc6ee6f74bc4","user":{"login":"andersonfrailey","id":20684675,"node_id":"MDQ6VXNlcjIwNjg0Njc1","avatar_url":"https://avatars0.githubusercontent.com/u/20684675?v=4","gravatar_id":"","url":"https://api.github.com/users/andersonfrailey","html_url":"https://github.com/andersonfrailey","followers_url":"https://api.github.com/users/andersonfrailey/followers","following_url":"https://api.github.com/users/andersonfrailey/following{/other_user}","gists_url":"https://api.github.com/users/andersonfrailey/gists{/gist_id}","starred_url":"https://api.github.com/users/andersonfrailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersonfrailey/subscriptions","organizations_url":"https://api.github.com/users/andersonfrailey/orgs","repos_url":"https://api.github.com/users/andersonfrailey/repos","events_url":"https://api.github.com/users/andersonfrailey/events{/privacy}","received_events_url":"https://api.github.com/users/andersonfrailey/received_events","type":"User","site_admin":false},"repo":{"id":152642510,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2NDI1MTA=","name":"OG-USA","full_name":"andersonfrailey/OG-USA","private":false,"owner":{"login":"andersonfrailey","id":20684675,"node_id":"MDQ6VXNlcjIwNjg0Njc1","avatar_url":"https://avatars0.githubusercontent.com/u/20684675?v=4","gravatar_id":"","url":"https://api.github.com/users/andersonfrailey","html_url":"https://github.com/andersonfrailey","followers_url":"https://api.github.com/users/andersonfrailey/followers","following_url":"https://api.github.com/users/andersonfrailey/following{/other_user}","gists_url":"https://api.github.com/users/andersonfrailey/gists{/gist_id}","starred_url":"https://api.github.com/users/andersonfrailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersonfrailey/subscriptions","organizations_url":"https://api.github.com/users/andersonfrailey/orgs","repos_url":"https://api.github.com/users/andersonfrailey/repos","events_url":"https://api.github.com/users/andersonfrailey/events{/privacy}","received_events_url":"https://api.github.com/users/andersonfrailey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andersonfrailey/OG-USA","description":"Dynamic Tax Scoring Model","fork":true,"url":"https://api.github.com/repos/andersonfrailey/OG-USA","forks_url":"https://api.github.com/repos/andersonfrailey/OG-USA/forks","keys_url":"https://api.github.com/repos/andersonfrailey/OG-USA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andersonfrailey/OG-USA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andersonfrailey/OG-USA/teams","hooks_url":"https://api.github.com/repos/andersonfrailey/OG-USA/hooks","issue_events_url":"https://api.github.com/repos/andersonfrailey/OG-USA/issues/events{/number}","events_url":"https://api.github.com/repos/andersonfrailey/OG-USA/events","assignees_url":"https://api.github.com/repos/andersonfrailey/OG-USA/assignees{/user}","branches_url":"https://api.github.com/repos/andersonfrailey/OG-USA/branches{/branch}","tags_url":"https://api.github.com/repos/andersonfrailey/OG-USA/tags","blobs_url":"https://api.github.com/repos/andersonfrailey/OG-USA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andersonfrailey/OG-USA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andersonfrailey/OG-USA/git/refs{/sha}","trees_url":"https://api.github.com/repos/andersonfrailey/OG-USA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andersonfrailey/OG-USA/statuses/{sha}","languages_url":"https://api.github.com/repos/andersonfrailey/OG-USA/languages","stargazers_url":"https://api.github.com/repos/andersonfrailey/OG-USA/stargazers","contributors_url":"https://api.github.com/repos/andersonfrailey/OG-USA/contributors","subscribers_url":"https://api.github.com/repos/andersonfrailey/OG-USA/subscribers","subscription_url":"https://api.github.com/repos/andersonfrailey/OG-USA/subscription","commits_url":"https://api.github.com/repos/andersonfrailey/OG-USA/commits{/sha}","git_commits_url":"https://api.github.com/repos/andersonfrailey/OG-USA/git/commits{/sha}","comments_url":"https://api.github.com/repos/andersonfrailey/OG-USA/comments{/number}","issue_comment_url":"https://api.github.com/repos/andersonfrailey/OG-USA/issues/comments{/number}","contents_url":"https://api.github.com/repos/andersonfrailey/OG-USA/contents/{+path}","compare_url":"https://api.github.com/repos/andersonfrailey/OG-USA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andersonfrailey/OG-USA/merges","archive_url":"https://api.github.com/repos/andersonfrailey/OG-USA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andersonfrailey/OG-USA/downloads","issues_url":"https://api.github.com/repos/andersonfrailey/OG-USA/issues{/number}","pulls_url":"https://api.github.com/repos/andersonfrailey/OG-USA/pulls{/number}","milestones_url":"https://api.github.com/repos/andersonfrailey/OG-USA/milestones{/number}","notifications_url":"https://api.github.com/repos/andersonfrailey/OG-USA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andersonfrailey/OG-USA/labels{/name}","releases_url":"https://api.github.com/repos/andersonfrailey/OG-USA/releases{/id}","deployments_url":"https://api.github.com/repos/andersonfrailey/OG-USA/deployments","created_at":"2018-10-11T19:09:11Z","updated_at":"2018-10-11T19:09:16Z","pushed_at":"2018-10-17T13:46:37Z","git_url":"git://github.com/andersonfrailey/OG-USA.git","ssh_url":"git@github.com:andersonfrailey/OG-USA.git","clone_url":"https://github.com/andersonfrailey/OG-USA.git","svn_url":"https://github.com/andersonfrailey/OG-USA","homepage":"","size":729062,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"007e59847e48fbf03b9f9b8faa191d412df476cb","user":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":30023836,"node_id":"MDEwOlJlcG9zaXRvcnkzMDAyMzgzNg==","name":"OG-USA","full_name":"open-source-economics/OG-USA","private":false,"owner":{"login":"open-source-economics","id":15148101,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTQ4MTAx","avatar_url":"https://avatars2.githubusercontent.com/u/15148101?v=4","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-source-economics/OG-USA","description":"Dynamic Tax Scoring Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/OG-USA","forks_url":"https://api.github.com/repos/open-source-economics/OG-USA/forks","keys_url":"https://api.github.com/repos/open-source-economics/OG-USA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/OG-USA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/OG-USA/teams","hooks_url":"https://api.github.com/repos/open-source-economics/OG-USA/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/OG-USA/events","assignees_url":"https://api.github.com/repos/open-source-economics/OG-USA/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/OG-USA/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/tags","blobs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/OG-USA/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/OG-USA/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/OG-USA/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/OG-USA/subscription","commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/OG-USA/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/OG-USA/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/OG-USA/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/OG-USA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/OG-USA/merges","archive_url":"https://api.github.com/repos/open-source-economics/OG-USA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/OG-USA/downloads","issues_url":"https://api.github.com/repos/open-source-economics/OG-USA/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/OG-USA/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/OG-USA/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/OG-USA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/OG-USA/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/OG-USA/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/OG-USA/deployments","created_at":"2015-01-29T14:33:14Z","updated_at":"2018-10-03T17:58:28Z","pushed_at":"2018-10-17T14:30:24Z","git_url":"git://github.com/open-source-economics/OG-USA.git","ssh_url":"git@github.com:open-source-economics/OG-USA.git","clone_url":"https://github.com/open-source-economics/OG-USA.git","svn_url":"https://github.com/open-source-economics/OG-USA","homepage":"","size":729200,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":28,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396"},"html":{"href":"https://github.com/open-source-economics/OG-USA/pull/396"},"issue":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/396"},"comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/OG-USA/statuses/ae01f3ed1d92a747a6ad4a3ca657cc6ee6f74bc4"}},"author_association":"NONE"}} | {
"id": 30023836,
"name": "open-source-economics/OG-USA",
"url": "https://api.github.com/repos/open-source-economics/OG-USA"
} | {
"id": 10715924,
"login": "jdebacker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10715924?",
"url": "https://api.github.com/users/jdebacker"
} | {
"id": 15148101,
"login": "open-source-economics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15148101?",
"url": "https://api.github.com/orgs/open-source-economics"
} | 2018-10-17T17:11:26 | 8437122354 | {"actor":{"display_login":"jdebacker"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/radicalbit/NSDb/pulls/comments/198628421","pull_request_review_id":132593271,"id":198628421,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYyODQyMQ==","diff_hunk":"@@ -342,6 +370,19 @@ class ShardReaderActor(val basePath: String, val db: String, val namespace: Stri\n \n override def receive: Receive = readOps\n \n+ private def retrieveField(values: Seq[Bit],","path":"nsdb-core/src/main/scala/io/radicalbit/nsdb/actors/ShardReaderActor.scala","position":83,"original_position":83,"commit_id":"6a891b82118efcd23fd3b107813e86a45a9f1495","original_commit_id":"6a891b82118efcd23fd3b107813e86a45a9f1495","user":{"login":"saveveltri","id":2499904,"node_id":"MDQ6VXNlcjI0OTk5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2499904?v=4","gravatar_id":"","url":"https://api.github.com/users/saveveltri","html_url":"https://github.com/saveveltri","followers_url":"https://api.github.com/users/saveveltri/followers","following_url":"https://api.github.com/users/saveveltri/following{/other_user}","gists_url":"https://api.github.com/users/saveveltri/gists{/gist_id}","starred_url":"https://api.github.com/users/saveveltri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveveltri/subscriptions","organizations_url":"https://api.github.com/users/saveveltri/orgs","repos_url":"https://api.github.com/users/saveveltri/repos","events_url":"https://api.github.com/users/saveveltri/events{/privacy}","received_events_url":"https://api.github.com/users/saveveltri/received_events","type":"User","site_admin":false},"body":"The two methods below are quite cryptic. It got a while to figure out what's their purpose. Maybe It would be better to add comments, but it's not mandatory for this PR.","created_at":"2018-06-27T20:22:16Z","updated_at":"2018-06-27T20:22:16Z","html_url":"https://github.com/radicalbit/NSDb/pull/14#discussion_r198628421","pull_request_url":"https://api.github.com/repos/radicalbit/NSDb/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/comments/198628421"},"html":{"href":"https://github.com/radicalbit/NSDb/pull/14#discussion_r198628421"},"pull_request":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/radicalbit/NSDb/pulls/14","id":197662683,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjYyNjgz","html_url":"https://github.com/radicalbit/NSDb/pull/14","diff_url":"https://github.com/radicalbit/NSDb/pull/14.diff","patch_url":"https://github.com/radicalbit/NSDb/pull/14.patch","issue_url":"https://api.github.com/repos/radicalbit/NSDb/issues/14","number":14,"state":"open","locked":false,"title":"Introduction of tags: first step","user":{"login":"robbenti","id":2085933,"node_id":"MDQ6VXNlcjIwODU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2085933?v=4","gravatar_id":"","url":"https://api.github.com/users/robbenti","html_url":"https://github.com/robbenti","followers_url":"https://api.github.com/users/robbenti/followers","following_url":"https://api.github.com/users/robbenti/following{/other_user}","gists_url":"https://api.github.com/users/robbenti/gists{/gist_id}","starred_url":"https://api.github.com/users/robbenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbenti/subscriptions","organizations_url":"https://api.github.com/users/robbenti/orgs","repos_url":"https://api.github.com/users/robbenti/repos","events_url":"https://api.github.com/users/robbenti/events{/privacy}","received_events_url":"https://api.github.com/users/robbenti/received_events","type":"User","site_admin":false},"body":"This is the first step about the implementation of tags","created_at":"2018-06-27T09:02:18Z","updated_at":"2018-06-27T20:22:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35ac675a3f028fc56ad0c6ac71c5d619f1c53e7c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mascetti101","id":3973086,"node_id":"MDQ6VXNlcjM5NzMwODY=","avatar_url":"https://avatars3.githubusercontent.com/u/3973086?v=4","gravatar_id":"","url":"https://api.github.com/users/mascetti101","html_url":"https://github.com/mascetti101","followers_url":"https://api.github.com/users/mascetti101/followers","following_url":"https://api.github.com/users/mascetti101/following{/other_user}","gists_url":"https://api.github.com/users/mascetti101/gists{/gist_id}","starred_url":"https://api.github.com/users/mascetti101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mascetti101/subscriptions","organizations_url":"https://api.github.com/users/mascetti101/orgs","repos_url":"https://api.github.com/users/mascetti101/repos","events_url":"https://api.github.com/users/mascetti101/events{/privacy}","received_events_url":"https://api.github.com/users/mascetti101/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radicalbit/NSDb/pulls/14/commits","review_comments_url":"https://api.github.com/repos/radicalbit/NSDb/pulls/14/comments","review_comment_url":"https://api.github.com/repos/radicalbit/NSDb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radicalbit/NSDb/issues/14/comments","statuses_url":"https://api.github.com/repos/radicalbit/NSDb/statuses/6a891b82118efcd23fd3b107813e86a45a9f1495","head":{"label":"robbenti:feature/add_tags_to_api","ref":"feature/add_tags_to_api","sha":"6a891b82118efcd23fd3b107813e86a45a9f1495","user":{"login":"robbenti","id":2085933,"node_id":"MDQ6VXNlcjIwODU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2085933?v=4","gravatar_id":"","url":"https://api.github.com/users/robbenti","html_url":"https://github.com/robbenti","followers_url":"https://api.github.com/users/robbenti/followers","following_url":"https://api.github.com/users/robbenti/following{/other_user}","gists_url":"https://api.github.com/users/robbenti/gists{/gist_id}","starred_url":"https://api.github.com/users/robbenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbenti/subscriptions","organizations_url":"https://api.github.com/users/robbenti/orgs","repos_url":"https://api.github.com/users/robbenti/repos","events_url":"https://api.github.com/users/robbenti/events{/privacy}","received_events_url":"https://api.github.com/users/robbenti/received_events","type":"User","site_admin":false},"repo":{"id":135586639,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1ODY2Mzk=","name":"NSDb","full_name":"robbenti/NSDb","owner":{"login":"robbenti","id":2085933,"node_id":"MDQ6VXNlcjIwODU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2085933?v=4","gravatar_id":"","url":"https://api.github.com/users/robbenti","html_url":"https://github.com/robbenti","followers_url":"https://api.github.com/users/robbenti/followers","following_url":"https://api.github.com/users/robbenti/following{/other_user}","gists_url":"https://api.github.com/users/robbenti/gists{/gist_id}","starred_url":"https://api.github.com/users/robbenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbenti/subscriptions","organizations_url":"https://api.github.com/users/robbenti/orgs","repos_url":"https://api.github.com/users/robbenti/repos","events_url":"https://api.github.com/users/robbenti/events{/privacy}","received_events_url":"https://api.github.com/users/robbenti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robbenti/NSDb","description":"Natural Series Database","fork":true,"url":"https://api.github.com/repos/robbenti/NSDb","forks_url":"https://api.github.com/repos/robbenti/NSDb/forks","keys_url":"https://api.github.com/repos/robbenti/NSDb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbenti/NSDb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbenti/NSDb/teams","hooks_url":"https://api.github.com/repos/robbenti/NSDb/hooks","issue_events_url":"https://api.github.com/repos/robbenti/NSDb/issues/events{/number}","events_url":"https://api.github.com/repos/robbenti/NSDb/events","assignees_url":"https://api.github.com/repos/robbenti/NSDb/assignees{/user}","branches_url":"https://api.github.com/repos/robbenti/NSDb/branches{/branch}","tags_url":"https://api.github.com/repos/robbenti/NSDb/tags","blobs_url":"https://api.github.com/repos/robbenti/NSDb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbenti/NSDb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbenti/NSDb/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbenti/NSDb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbenti/NSDb/statuses/{sha}","languages_url":"https://api.github.com/repos/robbenti/NSDb/languages","stargazers_url":"https://api.github.com/repos/robbenti/NSDb/stargazers","contributors_url":"https://api.github.com/repos/robbenti/NSDb/contributors","subscribers_url":"https://api.github.com/repos/robbenti/NSDb/subscribers","subscription_url":"https://api.github.com/repos/robbenti/NSDb/subscription","commits_url":"https://api.github.com/repos/robbenti/NSDb/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbenti/NSDb/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbenti/NSDb/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbenti/NSDb/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbenti/NSDb/contents/{+path}","compare_url":"https://api.github.com/repos/robbenti/NSDb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbenti/NSDb/merges","archive_url":"https://api.github.com/repos/robbenti/NSDb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbenti/NSDb/downloads","issues_url":"https://api.github.com/repos/robbenti/NSDb/issues{/number}","pulls_url":"https://api.github.com/repos/robbenti/NSDb/pulls{/number}","milestones_url":"https://api.github.com/repos/robbenti/NSDb/milestones{/number}","notifications_url":"https://api.github.com/repos/robbenti/NSDb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbenti/NSDb/labels{/name}","releases_url":"https://api.github.com/repos/robbenti/NSDb/releases{/id}","deployments_url":"https://api.github.com/repos/robbenti/NSDb/deployments","created_at":"2018-05-31T13:21:12Z","updated_at":"2018-06-27T09:46:31Z","pushed_at":"2018-06-27T09:51:19Z","git_url":"git://github.com/robbenti/NSDb.git","ssh_url":"git@github.com:robbenti/NSDb.git","clone_url":"https://github.com/robbenti/NSDb.git","svn_url":"https://github.com/robbenti/NSDb","homepage":null,"size":2447,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radicalbit:master","ref":"master","sha":"d5bd83a3366a02301b36f61bcb71ee3edae58569","user":{"login":"radicalbit","id":15193199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTkzMTk5","avatar_url":"https://avatars2.githubusercontent.com/u/15193199?v=4","gravatar_id":"","url":"https://api.github.com/users/radicalbit","html_url":"https://github.com/radicalbit","followers_url":"https://api.github.com/users/radicalbit/followers","following_url":"https://api.github.com/users/radicalbit/following{/other_user}","gists_url":"https://api.github.com/users/radicalbit/gists{/gist_id}","starred_url":"https://api.github.com/users/radicalbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radicalbit/subscriptions","organizations_url":"https://api.github.com/users/radicalbit/orgs","repos_url":"https://api.github.com/users/radicalbit/repos","events_url":"https://api.github.com/users/radicalbit/events{/privacy}","received_events_url":"https://api.github.com/users/radicalbit/received_events","type":"Organization","site_admin":false},"repo":{"id":135549948,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU1NDk5NDg=","name":"NSDb","full_name":"radicalbit/NSDb","owner":{"login":"radicalbit","id":15193199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTkzMTk5","avatar_url":"https://avatars2.githubusercontent.com/u/15193199?v=4","gravatar_id":"","url":"https://api.github.com/users/radicalbit","html_url":"https://github.com/radicalbit","followers_url":"https://api.github.com/users/radicalbit/followers","following_url":"https://api.github.com/users/radicalbit/following{/other_user}","gists_url":"https://api.github.com/users/radicalbit/gists{/gist_id}","starred_url":"https://api.github.com/users/radicalbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radicalbit/subscriptions","organizations_url":"https://api.github.com/users/radicalbit/orgs","repos_url":"https://api.github.com/users/radicalbit/repos","events_url":"https://api.github.com/users/radicalbit/events{/privacy}","received_events_url":"https://api.github.com/users/radicalbit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/radicalbit/NSDb","description":"Natural Series Database","fork":false,"url":"https://api.github.com/repos/radicalbit/NSDb","forks_url":"https://api.github.com/repos/radicalbit/NSDb/forks","keys_url":"https://api.github.com/repos/radicalbit/NSDb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radicalbit/NSDb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radicalbit/NSDb/teams","hooks_url":"https://api.github.com/repos/radicalbit/NSDb/hooks","issue_events_url":"https://api.github.com/repos/radicalbit/NSDb/issues/events{/number}","events_url":"https://api.github.com/repos/radicalbit/NSDb/events","assignees_url":"https://api.github.com/repos/radicalbit/NSDb/assignees{/user}","branches_url":"https://api.github.com/repos/radicalbit/NSDb/branches{/branch}","tags_url":"https://api.github.com/repos/radicalbit/NSDb/tags","blobs_url":"https://api.github.com/repos/radicalbit/NSDb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radicalbit/NSDb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radicalbit/NSDb/git/refs{/sha}","trees_url":"https://api.github.com/repos/radicalbit/NSDb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radicalbit/NSDb/statuses/{sha}","languages_url":"https://api.github.com/repos/radicalbit/NSDb/languages","stargazers_url":"https://api.github.com/repos/radicalbit/NSDb/stargazers","contributors_url":"https://api.github.com/repos/radicalbit/NSDb/contributors","subscribers_url":"https://api.github.com/repos/radicalbit/NSDb/subscribers","subscription_url":"https://api.github.com/repos/radicalbit/NSDb/subscription","commits_url":"https://api.github.com/repos/radicalbit/NSDb/commits{/sha}","git_commits_url":"https://api.github.com/repos/radicalbit/NSDb/git/commits{/sha}","comments_url":"https://api.github.com/repos/radicalbit/NSDb/comments{/number}","issue_comment_url":"https://api.github.com/repos/radicalbit/NSDb/issues/comments{/number}","contents_url":"https://api.github.com/repos/radicalbit/NSDb/contents/{+path}","compare_url":"https://api.github.com/repos/radicalbit/NSDb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radicalbit/NSDb/merges","archive_url":"https://api.github.com/repos/radicalbit/NSDb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radicalbit/NSDb/downloads","issues_url":"https://api.github.com/repos/radicalbit/NSDb/issues{/number}","pulls_url":"https://api.github.com/repos/radicalbit/NSDb/pulls{/number}","milestones_url":"https://api.github.com/repos/radicalbit/NSDb/milestones{/number}","notifications_url":"https://api.github.com/repos/radicalbit/NSDb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radicalbit/NSDb/labels{/name}","releases_url":"https://api.github.com/repos/radicalbit/NSDb/releases{/id}","deployments_url":"https://api.github.com/repos/radicalbit/NSDb/deployments","created_at":"2018-05-31T07:42:24Z","updated_at":"2018-06-27T09:45:11Z","pushed_at":"2018-06-27T09:51:22Z","git_url":"git://github.com/radicalbit/NSDb.git","ssh_url":"git@github.com:radicalbit/NSDb.git","clone_url":"https://github.com/radicalbit/NSDb.git","svn_url":"https://github.com/radicalbit/NSDb","homepage":null,"size":2423,"stargazers_count":16,"watchers_count":16,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":3,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/14"},"html":{"href":"https://github.com/radicalbit/NSDb/pull/14"},"issue":{"href":"https://api.github.com/repos/radicalbit/NSDb/issues/14"},"comments":{"href":"https://api.github.com/repos/radicalbit/NSDb/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radicalbit/NSDb/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/radicalbit/NSDb/statuses/6a891b82118efcd23fd3b107813e86a45a9f1495"}},"author_association":"MEMBER"}} | {
"id": 135549948,
"name": "radicalbit/NSDb",
"url": "https://api.github.com/repos/radicalbit/NSDb"
} | {
"id": 2499904,
"login": "saveveltri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2499904?",
"url": "https://api.github.com/users/saveveltri"
} | {
"id": 15193199,
"login": "radicalbit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15193199?",
"url": "https://api.github.com/orgs/radicalbit"
} | 2018-06-27T20:22:16 | 7887972056 | {"actor":{"display_login":"saveveltri"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/230925531","pull_request_review_id":171770911,"id":230925531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkyNTUzMQ==","diff_hunk":"@@ -0,0 +1,229 @@\n+# ProvenHeaders specifications\n+## Table of contents\n+\n+- [Problem overview](#problem-overview)\n+\n+- [Solution abstract overview](#solution-abstract-overview)\n+\n+- [Basic constructs](#basic-constructs)\n+\n+- [Structure of proven header](#structure-of-proven-header)\n+\n+- [Assumptions](#assumptions)\n+\n+- [Best chain selection](#best-chain-selection)\n+\n+- [Changes required for the C# node](#changes-required-for-the-c-node)\n+\n+ \n+\n+\n+## Problem overview\n+\n+Syncing with headers is used for quick blockchain download. Node can ask its peers for headers using *getheaders* message and asked peer will send up to 2000 headers per *headers* message. When the headers are received they are used in order to ask peers for blocks that are represented by those headers. This protocol is new and used on bitcoin network because it has some advantages in terms of resources usage over using *inv* messages.\n+\n+On PoW chains headers can't be easily faked because creating a valid header requires spending a lot of hashing power to meet the PoW difficulty target.\n+\n+On PoS networks like Stratis it is easy to construct a fake chain of headers of any length and almost arbitrary chainwork. \n+\n+With our C# node implementation, if an attacker constructs a fake chain of headers that has more work than the valid chain and sends it to a node that node will switch to a fake chain of headers. After switching the node will ask for blocks that are represented by the fake headers but those blocks will never be received so the node will stay out of sync with the network until the moment network eventually produces a longer chain and the node switches back.\n+\n+*Therefore it is possible to perform an attack on any node that uses getheaders and keep it out of sync for a long period of time.* \n+\n+## Solution abstract overview\n+\n+In order to prevent attacks using fake headers we propose construction of proven headers. \n+\n+New type of network messages needs to be introduced to allow syncing using proven headers -\n+\n+1. *provhdr* - `ProvenHeadersPayload` which contains list of up to 2000 proven headers.\n+2. *sendprovhdr* - `SendProvenHeadersPayload` which informs the peer that we are only willing to sync using the proven headers and not the old type of headers.\n+3. *getprovhdr* - `GetProvenHeadersPayload` which requests proven headers using a similar mechanism as the `getheaders` protocol message.\n+\n+\n+\n+\n+\n+## Basic constructs\n+\n+#### Coinstake age\n+\n+ `coinstakeAge` is a consensus constant that specifies how old (confirmation-wise) a UTXO has to be in order to be allowed to be used as a coinstake's kernel. \n+\n+This means that if we are synced till the block of height `x` and we receive a proven header that represents a block within the range from `x + 1` to `x + coinstakeAge` then we have enough data to validate the coinstake's kernel because a valid kernel couldn't have been originated in a block with height greater than `coinstakeAge`. \n+\n+It's important to mention that other coinstake transaction data may be fake (non-kernel inputs, fees claimed) but we don't care about this since this data is not related to the chain work. \n+\n+\n+\n+#### Trusted base\n+\n+We define `trustedBase` as the block up until the node has UTXO set for that it trusts (including that block). In the C# Stratis full node `trustedBase` is represented by the consensus tip, and in Stratis C# light wallet node it is currently not represented. More on how trusted base should be represented for the light wallet is in the [trusted base for the light wallet](#trusted-base-for-the-light-wallet) section.\n+\n+\n+\n+#### Long reorg protection\n+\n+PoS blockchains similar to Stratis need to have a protection against long reorganizations. Stratis protocol prevents the node from switching to another chain that would replace more than 500 blocks. We denote this parameter as `maxReorg`.\n+\n+\n+\n+## Structure of proven header\n+\n+Proven header consists of:\n+\n+1. Block header (in the C# node is represented by `BlockHeader` class) which contains merkle tree root.\n+\n+2. Block header signature (in the C# node it's represented by `BlockSignature` class), which is signed with the private key which corresponds to coinstake's Second output's public key.\n+\n+3. Its coinstake transaction (in the C# node it is represented by `Transaction` class). \n+\n+4. Merkle proof that proves the coinstake tx is included in a block that is being represented by the provided header. \n+\n+ In the C# node the merkle proof can be represented by the `PartialMerkleTree` class.\n+\n+\n+\n+## Assumptions\n+\n+This document is written under assumption that a softfork that changes `coinstakeAge` consensus parameter from 50 to 500 is activated for Stratis.\n+\n+Solution proposed in this document should be implemented for the C# nodes only when miners that control at least 51% of all stake adopted the softfork. \n+\n+\n+\n+#### Reasons behind changing coinstakeAge\n+\n+If the `coinstakeAge < maxReorg` then it is possible to create a valid coinstake kernel which will use UTXO originated in a block within the bounds of long reorg protection. Such coinstake can't always be validated with a small proof.\n+\n+Alternative solutions with longer proofs have been explored as well but they always introduce new attack vectors and additional complexity to the code which makes those solutions inferior to just implementing syncing with the *inv* messages.\n+\n+ \n+\n+\n+## Changes required for the C# node\n+\n+In this section changes that will be required for the C# node to support syncing with *proven headers* are covered. \n+\n+#### Handshake\n+\n+Also after the handshake is completed *sendprovhdr* message should be sent instead of *sendheaders*.\n+\n+*sendprovhdr* message is a message just as *sendheaders* is and it is just another message type to distinguish between those two. Also it will contain height from which we prefer having proven headers over normal headers.\n+\n+\n+\n+#### Storing chain of proven headers\n+\n+Currently on the C# node we have ChainRepository which stores chain of headers. It should be extended to store the full *proven headers* chain for blocks that were created after the `activationHeight`.","path":"Documentation/ProvenHeaders.md","position":118,"original_position":118,"commit_id":"2afee77d417198935df8175587a596fd89d46ee7","original_commit_id":"2afee77d417198935df8175587a596fd89d46ee7","user":{"login":"bokobza","id":1867877,"node_id":"MDQ6VXNlcjE4Njc4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1867877?v=4","gravatar_id":"","url":"https://api.github.com/users/bokobza","html_url":"https://github.com/bokobza","followers_url":"https://api.github.com/users/bokobza/followers","following_url":"https://api.github.com/users/bokobza/following{/other_user}","gists_url":"https://api.github.com/users/bokobza/gists{/gist_id}","starred_url":"https://api.github.com/users/bokobza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokobza/subscriptions","organizations_url":"https://api.github.com/users/bokobza/orgs","repos_url":"https://api.github.com/users/bokobza/repos","events_url":"https://api.github.com/users/bokobza/events{/privacy}","received_events_url":"https://api.github.com/users/bokobza/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nCurrently on the C# node we have ChainRepository which stores the chain of headers. It should be extended to store the full *proven headers* chain for blocks that were created after the `activationHeight`.\r\n```","created_at":"2018-11-05T21:48:37Z","updated_at":"2018-11-05T21:50:48Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679#discussion_r230925531","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/230925531"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679#discussion_r230925531"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679","id":228381758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzgxNzU4","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2679","number":2679,"state":"open","locked":false,"title":"Create ProvenHeaders.md","user":{"login":"dangershony","id":7487930,"node_id":"MDQ6VXNlcjc0ODc5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-05T15:02:13Z","updated_at":"2018-11-05T21:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4af9f43ebfc29c9d5cdab74ddd9d177abf9f17a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2679/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2afee77d417198935df8175587a596fd89d46ee7","head":{"label":"stratisproject:dangershony-patch-1","ref":"dangershony-patch-1","sha":"2afee77d417198935df8175587a596fd89d46ee7","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","private":false,"owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-11-05T19:49:07Z","pushed_at":"2018-11-05T20:01:54Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":38280,"stargazers_count":591,"watchers_count":591,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":260,"open_issues":206,"watchers":591,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"584239994719ff608b5a19bbd31b84d3814be203","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","private":false,"owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-11-05T19:49:07Z","pushed_at":"2018-11-05T20:01:54Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":38280,"stargazers_count":591,"watchers_count":591,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":260,"open_issues":206,"watchers":591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/2679"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2679"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/2679/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/2679/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2afee77d417198935df8175587a596fd89d46ee7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 67271290,
"name": "stratisproject/StratisBitcoinFullNode",
"url": "https://api.github.com/repos/stratisproject/StratisBitcoinFullNode"
} | {
"id": 1867877,
"login": "bokobza",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1867877?",
"url": "https://api.github.com/users/bokobza"
} | {
"id": 15229748,
"login": "stratisproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15229748?",
"url": "https://api.github.com/orgs/stratisproject"
} | 2018-11-05T21:48:37 | 8538758328 | {"actor":{"display_login":"bokobza"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/comments/233433104","pull_request_review_id":174843107,"id":233433104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzQzMzEwNA==","diff_hunk":"@@ -92,17 +97,17 @@ public void SynchronizeSynchronizesWithChainAndSurvivesRestart()\n {\n ConcurrentChain chain = BuildChain(5);\n \n- string dataDir = GetTestDirectoryPath(this);\n+ string dataDir = CreateTestDir(this);\n+ var dataFolder = new DataFolder(dataDir);\n var nodeSettings = new NodeSettings(this.network, NBitcoin.Protocol.ProtocolVersion.ALT_PROTOCOL_VERSION,","path":"src/Stratis.FederatedPeg.Tests/CrossChainTransferStoreTests.cs","position":47,"original_position":47,"commit_id":"f3db01b4f895c5d6d216a8ba79a86df6080b5fc7","original_commit_id":"f3db01b4f895c5d6d216a8ba79a86df6080b5fc7","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-11-14T12:52:11Z","updated_at":"2018-11-14T12:52:12Z","html_url":"https://github.com/stratisproject/FederatedSidechains/pull/167#discussion_r233433104","pull_request_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/comments/233433104"},"html":{"href":"https://github.com/stratisproject/FederatedSidechains/pull/167#discussion_r233433104"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167"}},"in_reply_to_id":233404079},"pull_request":{"url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167","id":230725723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzI1NzIz","html_url":"https://github.com/stratisproject/FederatedSidechains/pull/167","diff_url":"https://github.com/stratisproject/FederatedSidechains/pull/167.diff","patch_url":"https://github.com/stratisproject/FederatedSidechains/pull/167.patch","issue_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/167","number":167,"state":"open","locked":false,"title":"Add sanity check to sync between store and wallet","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"body":"Relates to #137 \r\n\r\n- On restart we have to check that our transaction's UTXO's are still valid.\r\n- Once ProcessTransaction has been called we want to check that UTXO's are not re-used.","created_at":"2018-11-14T06:36:01Z","updated_at":"2018-11-14T12:52:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9d490755825c92e0a22b6c526e95f8598c69896","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167/commits","review_comments_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167/comments","review_comment_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/167/comments","statuses_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/statuses/f3db01b4f895c5d6d216a8ba79a86df6080b5fc7","head":{"label":"quantumagi:xchainstore4","ref":"xchainstore4","sha":"f3db01b4f895c5d6d216a8ba79a86df6080b5fc7","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"repo":{"id":155503990,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1MDM5OTA=","name":"FederatedSidechains","full_name":"quantumagi/FederatedSidechains","private":false,"owner":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/quantumagi/FederatedSidechains","description":null,"fork":true,"url":"https://api.github.com/repos/quantumagi/FederatedSidechains","forks_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/forks","keys_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/teams","hooks_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/hooks","issue_events_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/issues/events{/number}","events_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/events","assignees_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/assignees{/user}","branches_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/branches{/branch}","tags_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/tags","blobs_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/statuses/{sha}","languages_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/languages","stargazers_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/stargazers","contributors_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/contributors","subscribers_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/subscribers","subscription_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/subscription","commits_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/contents/{+path}","compare_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/merges","archive_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/downloads","issues_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/issues{/number}","pulls_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/pulls{/number}","milestones_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/milestones{/number}","notifications_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/labels{/name}","releases_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/releases{/id}","deployments_url":"https://api.github.com/repos/quantumagi/FederatedSidechains/deployments","created_at":"2018-10-31T05:32:11Z","updated_at":"2018-11-14T04:21:27Z","pushed_at":"2018-11-14T10:49:53Z","git_url":"git://github.com/quantumagi/FederatedSidechains.git","ssh_url":"git@github.com:quantumagi/FederatedSidechains.git","clone_url":"https://github.com/quantumagi/FederatedSidechains.git","svn_url":"https://github.com/quantumagi/FederatedSidechains","homepage":null,"size":3171,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"fbce4faa540b7c2ba17a5a0b9aac7c0fd4a0212c","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":136144492,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxNDQ0OTI=","name":"FederatedSidechains","full_name":"stratisproject/FederatedSidechains","private":false,"owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stratisproject/FederatedSidechains","description":null,"fork":false,"url":"https://api.github.com/repos/stratisproject/FederatedSidechains","forks_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/forks","keys_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/teams","hooks_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/events","assignees_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/tags","blobs_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/languages","stargazers_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/subscription","commits_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/merges","archive_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/downloads","issues_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/FederatedSidechains/deployments","created_at":"2018-06-05T08:21:50Z","updated_at":"2018-11-14T12:27:19Z","pushed_at":"2018-11-14T12:27:17Z","git_url":"git://github.com/stratisproject/FederatedSidechains.git","ssh_url":"git@github.com:stratisproject/FederatedSidechains.git","clone_url":"https://github.com/stratisproject/FederatedSidechains.git","svn_url":"https://github.com/stratisproject/FederatedSidechains","homepage":null,"size":3111,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":24,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167"},"html":{"href":"https://github.com/stratisproject/FederatedSidechains/pull/167"},"issue":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/167"},"comments":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/FederatedSidechains/statuses/f3db01b4f895c5d6d216a8ba79a86df6080b5fc7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 136144492,
"name": "stratisproject/FederatedSidechains",
"url": "https://api.github.com/repos/stratisproject/FederatedSidechains"
} | {
"id": 29645989,
"login": "quantumagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29645989?",
"url": "https://api.github.com/users/quantumagi"
} | {
"id": 15229748,
"login": "stratisproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15229748?",
"url": "https://api.github.com/orgs/stratisproject"
} | 2018-11-14T12:52:11 | 8587972142 | {"actor":{"display_login":"quantumagi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/165813153","pull_request_review_id":93815239,"id":165813153,"diff_hunk":"@@ -134,4 +135,43 @@ public void SetErrorHandler(ConsensusRule errorHandler)\n }\n }\n }\n+\n+ /// <summary>\n+ /// Consensus rules that represent a Proof-Of-Work blockchain.\n+ /// </summary>\n+ public class PowConsensusRules : ConsensusRules","path":"src/Stratis.Bitcoin.Features.Consensus/Rules/ConsensusRules.cs","position":32,"original_position":32,"commit_id":"36276b0d0d10435e2b61d55d85acc0c72025ce0f","original_commit_id":"36276b0d0d10435e2b61d55d85acc0c72025ce0f","user":{"login":"fassadlr","id":4281271,"avatar_url":"https://avatars3.githubusercontent.com/u/4281271?v=4","gravatar_id":"","url":"https://api.github.com/users/fassadlr","html_url":"https://github.com/fassadlr","followers_url":"https://api.github.com/users/fassadlr/followers","following_url":"https://api.github.com/users/fassadlr/following{/other_user}","gists_url":"https://api.github.com/users/fassadlr/gists{/gist_id}","starred_url":"https://api.github.com/users/fassadlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fassadlr/subscriptions","organizations_url":"https://api.github.com/users/fassadlr/orgs","repos_url":"https://api.github.com/users/fassadlr/repos","events_url":"https://api.github.com/users/fassadlr/events{/privacy}","received_events_url":"https://api.github.com/users/fassadlr/received_events","type":"User","site_admin":false},"body":"@dangershony can we maybe put these into seperate files? I believe there was some agreement made a while back on this ;)","created_at":"2018-02-03T12:11:20Z","updated_at":"2018-02-03T12:11:30Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128#discussion_r165813153","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/165813153"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128#discussion_r165813153"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128","id":166689466,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1128","number":1128,"state":"open","locked":false,"title":"Rules for checking the next difficulty for both pos and pow","user":{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-02T00:29:38Z","updated_at":"2018-02-03T12:11:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd2fd2a23157cf80fd897789ef2531242481655","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bokobza","id":1867877,"avatar_url":"https://avatars3.githubusercontent.com/u/1867877?v=4","gravatar_id":"","url":"https://api.github.com/users/bokobza","html_url":"https://github.com/bokobza","followers_url":"https://api.github.com/users/bokobza/followers","following_url":"https://api.github.com/users/bokobza/following{/other_user}","gists_url":"https://api.github.com/users/bokobza/gists{/gist_id}","starred_url":"https://api.github.com/users/bokobza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokobza/subscriptions","organizations_url":"https://api.github.com/users/bokobza/orgs","repos_url":"https://api.github.com/users/bokobza/repos","events_url":"https://api.github.com/users/bokobza/events{/privacy}","received_events_url":"https://api.github.com/users/bokobza/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1128/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/36276b0d0d10435e2b61d55d85acc0c72025ce0f","head":{"label":"dangershony:rules-pos-pow","ref":"rules-pos-pow","sha":"36276b0d0d10435e2b61d55d85acc0c72025ce0f","user":{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"repo":{"id":68708758,"name":"StratisBitcoinFullNode","full_name":"dangershony/StratisBitcoinFullNode","owner":{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dangershony/StratisBitcoinFullNode","description":null,"fork":true,"url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/dangershony/StratisBitcoinFullNode/deployments","created_at":"2016-09-20T12:18:08Z","updated_at":"2016-09-20T12:18:09Z","pushed_at":"2018-02-03T01:57:13Z","git_url":"git://github.com/dangershony/StratisBitcoinFullNode.git","ssh_url":"git@github.com:dangershony/StratisBitcoinFullNode.git","clone_url":"https://github.com/dangershony/StratisBitcoinFullNode.git","svn_url":"https://github.com/dangershony/StratisBitcoinFullNode","homepage":null,"size":10147,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"08dc7764c25b97a734a04b0c67c6a4c48a9ed5db","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-02-03T10:33:57Z","pushed_at":"2018-02-03T01:57:14Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":9991,"stargazers_count":364,"watchers_count":364,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":144,"open_issues":87,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1128"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1128"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1128/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1128/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/36276b0d0d10435e2b61d55d85acc0c72025ce0f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 67271290,
"name": "stratisproject/StratisBitcoinFullNode",
"url": "https://api.github.com/repos/stratisproject/StratisBitcoinFullNode"
} | {
"id": 4281271,
"login": "fassadlr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4281271?",
"url": "https://api.github.com/users/fassadlr"
} | {
"id": 15229748,
"login": "stratisproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15229748?",
"url": "https://api.github.com/orgs/stratisproject"
} | 2018-02-03T12:11:20 | 7193058397 | {"actor":{"display_login":"fassadlr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/venicegeo/bf-api/pulls/comments/183725273","pull_request_review_id":114776507,"id":183725273,"diff_hunk":"@@ -104,7 +104,7 @@ public String oauthLogout(HttpServletResponse response, Authentication authentic\n \t\tuserProfileService.invalidateKey(userProfileService.getProfileFromAuthentication(authentication));\n \n \t\t// Construct redirect url for server side logout\n-\t\tfinal String uiUrl = \"beachfront.\" + domain;\n+\t\tfinal String uiUrl = \"http://beachfront.\" + domain;","path":"src/main/java/org/venice/beachfront/bfapi/controllers/OAuthController.java","position":5,"original_position":5,"commit_id":"71dc94cbe1ee9bdfd3012a3e6dd0d2615ebdb0b0","original_commit_id":"71dc94cbe1ee9bdfd3012a3e6dd0d2615ebdb0b0","user":{"login":"johnmcmahon","id":5760212,"avatar_url":"https://avatars2.githubusercontent.com/u/5760212?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmcmahon","html_url":"https://github.com/johnmcmahon","followers_url":"https://api.github.com/users/johnmcmahon/followers","following_url":"https://api.github.com/users/johnmcmahon/following{/other_user}","gists_url":"https://api.github.com/users/johnmcmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcmahon/subscriptions","organizations_url":"https://api.github.com/users/johnmcmahon/orgs","repos_url":"https://api.github.com/users/johnmcmahon/repos","events_url":"https://api.github.com/users/johnmcmahon/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcmahon/received_events","type":"User","site_admin":false},"body":"haha yes, and that was addressed in Waymond's email. I was initially concerned about this (and i don't know why they didn't/couldn't just register it as https but that's an approved url they put on our whitelist for logout redirecting. It ends up taking you to https anyhow, so i guess it's not that big a deal?","created_at":"2018-04-24T13:17:27Z","updated_at":"2018-04-24T13:17:27Z","html_url":"https://github.com/venicegeo/bf-api/pull/264#discussion_r183725273","pull_request_url":"https://api.github.com/repos/venicegeo/bf-api/pulls/264","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/comments/183725273"},"html":{"href":"https://github.com/venicegeo/bf-api/pull/264#discussion_r183725273"},"pull_request":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/264"}},"in_reply_to_id":183696637},"pull_request":{"url":"https://api.github.com/repos/venicegeo/bf-api/pulls/264","id":183600706,"html_url":"https://github.com/venicegeo/bf-api/pull/264","diff_url":"https://github.com/venicegeo/bf-api/pull/264.diff","patch_url":"https://github.com/venicegeo/bf-api/pull/264.patch","issue_url":"https://api.github.com/repos/venicegeo/bf-api/issues/264","number":264,"state":"open","locked":false,"title":"Fix logout url","user":{"login":"johnmcmahon","id":5760212,"avatar_url":"https://avatars2.githubusercontent.com/u/5760212?v=4","gravatar_id":"","url":"https://api.github.com/users/johnmcmahon","html_url":"https://github.com/johnmcmahon","followers_url":"https://api.github.com/users/johnmcmahon/followers","following_url":"https://api.github.com/users/johnmcmahon/following{/other_user}","gists_url":"https://api.github.com/users/johnmcmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmcmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmcmahon/subscriptions","organizations_url":"https://api.github.com/users/johnmcmahon/orgs","repos_url":"https://api.github.com/users/johnmcmahon/repos","events_url":"https://api.github.com/users/johnmcmahon/events{/privacy}","received_events_url":"https://api.github.com/users/johnmcmahon/received_events","type":"User","site_admin":false},"body":"GX gave us a new url that should work for logging out... giving this a shot","created_at":"2018-04-24T01:50:52Z","updated_at":"2018-04-24T13:17:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98dda36b7ddbc95fef49a90eef0a3e8c8e43a3fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/venicegeo/bf-api/pulls/264/commits","review_comments_url":"https://api.github.com/repos/venicegeo/bf-api/pulls/264/comments","review_comment_url":"https://api.github.com/repos/venicegeo/bf-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/venicegeo/bf-api/issues/264/comments","statuses_url":"https://api.github.com/repos/venicegeo/bf-api/statuses/71dc94cbe1ee9bdfd3012a3e6dd0d2615ebdb0b0","head":{"label":"venicegeo:BT-206","ref":"BT-206","sha":"71dc94cbe1ee9bdfd3012a3e6dd0d2615ebdb0b0","user":{"login":"venicegeo","id":15457149,"avatar_url":"https://avatars2.githubusercontent.com/u/15457149?v=4","gravatar_id":"","url":"https://api.github.com/users/venicegeo","html_url":"https://github.com/venicegeo","followers_url":"https://api.github.com/users/venicegeo/followers","following_url":"https://api.github.com/users/venicegeo/following{/other_user}","gists_url":"https://api.github.com/users/venicegeo/gists{/gist_id}","starred_url":"https://api.github.com/users/venicegeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venicegeo/subscriptions","organizations_url":"https://api.github.com/users/venicegeo/orgs","repos_url":"https://api.github.com/users/venicegeo/repos","events_url":"https://api.github.com/users/venicegeo/events{/privacy}","received_events_url":"https://api.github.com/users/venicegeo/received_events","type":"Organization","site_admin":false},"repo":{"id":73200854,"name":"bf-api","full_name":"venicegeo/bf-api","owner":{"login":"venicegeo","id":15457149,"avatar_url":"https://avatars2.githubusercontent.com/u/15457149?v=4","gravatar_id":"","url":"https://api.github.com/users/venicegeo","html_url":"https://github.com/venicegeo","followers_url":"https://api.github.com/users/venicegeo/followers","following_url":"https://api.github.com/users/venicegeo/following{/other_user}","gists_url":"https://api.github.com/users/venicegeo/gists{/gist_id}","starred_url":"https://api.github.com/users/venicegeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venicegeo/subscriptions","organizations_url":"https://api.github.com/users/venicegeo/orgs","repos_url":"https://api.github.com/users/venicegeo/repos","events_url":"https://api.github.com/users/venicegeo/events{/privacy}","received_events_url":"https://api.github.com/users/venicegeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/venicegeo/bf-api","description":"Web service providing automated global vector shoreline extraction.","fork":false,"url":"https://api.github.com/repos/venicegeo/bf-api","forks_url":"https://api.github.com/repos/venicegeo/bf-api/forks","keys_url":"https://api.github.com/repos/venicegeo/bf-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venicegeo/bf-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venicegeo/bf-api/teams","hooks_url":"https://api.github.com/repos/venicegeo/bf-api/hooks","issue_events_url":"https://api.github.com/repos/venicegeo/bf-api/issues/events{/number}","events_url":"https://api.github.com/repos/venicegeo/bf-api/events","assignees_url":"https://api.github.com/repos/venicegeo/bf-api/assignees{/user}","branches_url":"https://api.github.com/repos/venicegeo/bf-api/branches{/branch}","tags_url":"https://api.github.com/repos/venicegeo/bf-api/tags","blobs_url":"https://api.github.com/repos/venicegeo/bf-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venicegeo/bf-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venicegeo/bf-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/venicegeo/bf-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venicegeo/bf-api/statuses/{sha}","languages_url":"https://api.github.com/repos/venicegeo/bf-api/languages","stargazers_url":"https://api.github.com/repos/venicegeo/bf-api/stargazers","contributors_url":"https://api.github.com/repos/venicegeo/bf-api/contributors","subscribers_url":"https://api.github.com/repos/venicegeo/bf-api/subscribers","subscription_url":"https://api.github.com/repos/venicegeo/bf-api/subscription","commits_url":"https://api.github.com/repos/venicegeo/bf-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/venicegeo/bf-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/venicegeo/bf-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/venicegeo/bf-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/venicegeo/bf-api/contents/{+path}","compare_url":"https://api.github.com/repos/venicegeo/bf-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venicegeo/bf-api/merges","archive_url":"https://api.github.com/repos/venicegeo/bf-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venicegeo/bf-api/downloads","issues_url":"https://api.github.com/repos/venicegeo/bf-api/issues{/number}","pulls_url":"https://api.github.com/repos/venicegeo/bf-api/pulls{/number}","milestones_url":"https://api.github.com/repos/venicegeo/bf-api/milestones{/number}","notifications_url":"https://api.github.com/repos/venicegeo/bf-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venicegeo/bf-api/labels{/name}","releases_url":"https://api.github.com/repos/venicegeo/bf-api/releases{/id}","deployments_url":"https://api.github.com/repos/venicegeo/bf-api/deployments","created_at":"2016-11-08T15:41:07Z","updated_at":"2018-04-23T17:57:58Z","pushed_at":"2018-04-24T01:50:54Z","git_url":"git://github.com/venicegeo/bf-api.git","ssh_url":"git@github.com:venicegeo/bf-api.git","clone_url":"https://github.com/venicegeo/bf-api.git","svn_url":"https://github.com/venicegeo/bf-api","homepage":"","size":93702,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":119,"license":null,"forks":1,"open_issues":119,"watchers":1,"default_branch":"master"}},"base":{"label":"venicegeo:master","ref":"master","sha":"01c6d49cfef816228dbe7cab39b4bd14baca907e","user":{"login":"venicegeo","id":15457149,"avatar_url":"https://avatars2.githubusercontent.com/u/15457149?v=4","gravatar_id":"","url":"https://api.github.com/users/venicegeo","html_url":"https://github.com/venicegeo","followers_url":"https://api.github.com/users/venicegeo/followers","following_url":"https://api.github.com/users/venicegeo/following{/other_user}","gists_url":"https://api.github.com/users/venicegeo/gists{/gist_id}","starred_url":"https://api.github.com/users/venicegeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venicegeo/subscriptions","organizations_url":"https://api.github.com/users/venicegeo/orgs","repos_url":"https://api.github.com/users/venicegeo/repos","events_url":"https://api.github.com/users/venicegeo/events{/privacy}","received_events_url":"https://api.github.com/users/venicegeo/received_events","type":"Organization","site_admin":false},"repo":{"id":73200854,"name":"bf-api","full_name":"venicegeo/bf-api","owner":{"login":"venicegeo","id":15457149,"avatar_url":"https://avatars2.githubusercontent.com/u/15457149?v=4","gravatar_id":"","url":"https://api.github.com/users/venicegeo","html_url":"https://github.com/venicegeo","followers_url":"https://api.github.com/users/venicegeo/followers","following_url":"https://api.github.com/users/venicegeo/following{/other_user}","gists_url":"https://api.github.com/users/venicegeo/gists{/gist_id}","starred_url":"https://api.github.com/users/venicegeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venicegeo/subscriptions","organizations_url":"https://api.github.com/users/venicegeo/orgs","repos_url":"https://api.github.com/users/venicegeo/repos","events_url":"https://api.github.com/users/venicegeo/events{/privacy}","received_events_url":"https://api.github.com/users/venicegeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/venicegeo/bf-api","description":"Web service providing automated global vector shoreline extraction.","fork":false,"url":"https://api.github.com/repos/venicegeo/bf-api","forks_url":"https://api.github.com/repos/venicegeo/bf-api/forks","keys_url":"https://api.github.com/repos/venicegeo/bf-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venicegeo/bf-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venicegeo/bf-api/teams","hooks_url":"https://api.github.com/repos/venicegeo/bf-api/hooks","issue_events_url":"https://api.github.com/repos/venicegeo/bf-api/issues/events{/number}","events_url":"https://api.github.com/repos/venicegeo/bf-api/events","assignees_url":"https://api.github.com/repos/venicegeo/bf-api/assignees{/user}","branches_url":"https://api.github.com/repos/venicegeo/bf-api/branches{/branch}","tags_url":"https://api.github.com/repos/venicegeo/bf-api/tags","blobs_url":"https://api.github.com/repos/venicegeo/bf-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venicegeo/bf-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venicegeo/bf-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/venicegeo/bf-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venicegeo/bf-api/statuses/{sha}","languages_url":"https://api.github.com/repos/venicegeo/bf-api/languages","stargazers_url":"https://api.github.com/repos/venicegeo/bf-api/stargazers","contributors_url":"https://api.github.com/repos/venicegeo/bf-api/contributors","subscribers_url":"https://api.github.com/repos/venicegeo/bf-api/subscribers","subscription_url":"https://api.github.com/repos/venicegeo/bf-api/subscription","commits_url":"https://api.github.com/repos/venicegeo/bf-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/venicegeo/bf-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/venicegeo/bf-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/venicegeo/bf-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/venicegeo/bf-api/contents/{+path}","compare_url":"https://api.github.com/repos/venicegeo/bf-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venicegeo/bf-api/merges","archive_url":"https://api.github.com/repos/venicegeo/bf-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venicegeo/bf-api/downloads","issues_url":"https://api.github.com/repos/venicegeo/bf-api/issues{/number}","pulls_url":"https://api.github.com/repos/venicegeo/bf-api/pulls{/number}","milestones_url":"https://api.github.com/repos/venicegeo/bf-api/milestones{/number}","notifications_url":"https://api.github.com/repos/venicegeo/bf-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venicegeo/bf-api/labels{/name}","releases_url":"https://api.github.com/repos/venicegeo/bf-api/releases{/id}","deployments_url":"https://api.github.com/repos/venicegeo/bf-api/deployments","created_at":"2016-11-08T15:41:07Z","updated_at":"2018-04-23T17:57:58Z","pushed_at":"2018-04-24T01:50:54Z","git_url":"git://github.com/venicegeo/bf-api.git","ssh_url":"git@github.com:venicegeo/bf-api.git","clone_url":"https://github.com/venicegeo/bf-api.git","svn_url":"https://github.com/venicegeo/bf-api","homepage":"","size":93702,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":119,"license":null,"forks":1,"open_issues":119,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/264"},"html":{"href":"https://github.com/venicegeo/bf-api/pull/264"},"issue":{"href":"https://api.github.com/repos/venicegeo/bf-api/issues/264"},"comments":{"href":"https://api.github.com/repos/venicegeo/bf-api/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/venicegeo/bf-api/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/venicegeo/bf-api/statuses/71dc94cbe1ee9bdfd3012a3e6dd0d2615ebdb0b0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 73200854,
"name": "venicegeo/bf-api",
"url": "https://api.github.com/repos/venicegeo/bf-api"
} | {
"id": 5760212,
"login": "johnmcmahon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5760212?",
"url": "https://api.github.com/users/johnmcmahon"
} | {
"id": 15457149,
"login": "venicegeo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15457149?",
"url": "https://api.github.com/orgs/venicegeo"
} | 2018-04-24T13:17:27 | 7578370073 | {"actor":{"display_login":"johnmcmahon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/173414562","pull_request_review_id":102602801,"id":173414562,"diff_hunk":"@@ -1330,6 +1330,151 @@ def assert_shape_match(inp, out):\n return (res_outputs, new_state)\n \n \n+class LayerNormBasicGRUCell(rnn_cell_impl._LayerRNNCell):\n+ \"\"\"GRU unit with layer normalization.\n+\n+ This class adds layer normalization to a\n+ basic GRU unit. Layer normalization implementation is based on:\n+\n+ https://arxiv.org/abs/1607.06450.\n+\n+ \"Layer Normalization\"\n+ Jimmy Lei Ba, Jamie Ryan Kiros, Geoffrey E. Hinton\n+\n+ and is applied before the internal nonlinearities.\n+ \"\"\"\n+\n+ def __init__(self, num_units,\n+ activation=math_ops.tanh,\n+ layer_norm=True,\n+ norm_gain=1.0,\n+ norm_shift=0.0,\n+ reuse=None):\n+ \"\"\"Initializes the cell.\n+\n+ Args:\n+ num_units: int, The number of units in the GRU cell.\n+ activation: Activation function of the inner states.\n+ layer_norm: If `True`, layer normalization will be applied.\n+ norm_gain: float, The layer normalization gain initial value. If\n+ `layer_norm` has been set to `False`, this argument will be ignored.\n+ norm_shift: float, The layer normalization shift initial value. If\n+ `layer_norm` has been set to `False`, this argument will be ignored.\n+ \"\"\"\n+\n+ super(LayerNormBasicGRUCell, self).__init__(_reuse=reuse)\n+\n+ self._num_units = num_units\n+ self._activation = activation\n+ self._layer_norm = layer_norm\n+ self._g = norm_gain\n+ self._b = norm_shift\n+ self._reuse = reuse\n+\n+ @property\n+ def state_size(self):\n+ return self._num_units\n+\n+ @property\n+ def output_size(self):\n+ return self._num_units\n+\n+ def _linear(self, args, kernel, bias):\n+ out = math_ops.matmul(args, kernel)\n+ if not self._layer_norm:\n+ out = nn_ops.bias_add(out, bias)\n+ return out\n+\n+ def _norm(self, inp, scope):\n+ return layers.layer_norm(inp, reuse=True, scope=scope)\n+\n+ def build(self, inputs_shape):\n+ if inputs_shape[1].value is None:\n+\n+ raise ValueError(\"Expected inputs.shape[-1] to be known, saw shape: %s\"\n+ % inputs_shape)\n+\n+ input_depth = inputs_shape[1].value\n+\n+ # Initialize beta and gamma for use by layer_norm.\n+ if self._layer_norm:\n+ scopes = [\"update_gate\",\n+ \"reset_gate\",\n+ \"candidate_linear_x\",\n+ \"candidate_linear_h\"]\n+ for scope in scopes:\n+ self.add_variable(scope+\"/gamma\",\n+ shape=[self._num_units],\n+ initializer=init_ops.constant_initializer(self._g))\n+ self.add_variable(scope+\"/beta\",\n+ shape=[self._num_units],\n+ initializer=init_ops.constant_initializer(self._b))\n+\n+ self.update_gate_kernel = self.add_variable(","path":"tensorflow/contrib/rnn/python/ops/rnn_cell.py","position":null,"original_position":84,"commit_id":"000474bf24f86dc11136f0ef8bb03af98d7a7754","original_commit_id":"134510d9d80fbb7bb62b24f310c05573bd8fc642","user":{"login":"KiewanVillatel","id":6458145,"avatar_url":"https://avatars2.githubusercontent.com/u/6458145?v=4","gravatar_id":"","url":"https://api.github.com/users/KiewanVillatel","html_url":"https://github.com/KiewanVillatel","followers_url":"https://api.github.com/users/KiewanVillatel/followers","following_url":"https://api.github.com/users/KiewanVillatel/following{/other_user}","gists_url":"https://api.github.com/users/KiewanVillatel/gists{/gist_id}","starred_url":"https://api.github.com/users/KiewanVillatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiewanVillatel/subscriptions","organizations_url":"https://api.github.com/users/KiewanVillatel/orgs","repos_url":"https://api.github.com/users/KiewanVillatel/repos","events_url":"https://api.github.com/users/KiewanVillatel/events{/privacy}","received_events_url":"https://api.github.com/users/KiewanVillatel/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-03-09T10:28:30Z","updated_at":"2018-03-09T10:28:30Z","html_url":"https://github.com/tensorflow/tensorflow/pull/14578#discussion_r173414562","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/173414562"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/14578#discussion_r173414562"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578"}},"in_reply_to_id":172739794},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578","id":152726247,"html_url":"https://github.com/tensorflow/tensorflow/pull/14578","diff_url":"https://github.com/tensorflow/tensorflow/pull/14578.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/14578.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/14578","number":14578,"state":"open","locked":false,"title":"Implements LayerNormBasicGRUCell","user":{"login":"KiewanVillatel","id":6458145,"avatar_url":"https://avatars2.githubusercontent.com/u/6458145?v=4","gravatar_id":"","url":"https://api.github.com/users/KiewanVillatel","html_url":"https://github.com/KiewanVillatel","followers_url":"https://api.github.com/users/KiewanVillatel/followers","following_url":"https://api.github.com/users/KiewanVillatel/following{/other_user}","gists_url":"https://api.github.com/users/KiewanVillatel/gists{/gist_id}","starred_url":"https://api.github.com/users/KiewanVillatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiewanVillatel/subscriptions","organizations_url":"https://api.github.com/users/KiewanVillatel/orgs","repos_url":"https://api.github.com/users/KiewanVillatel/repos","events_url":"https://api.github.com/users/KiewanVillatel/events{/privacy}","received_events_url":"https://api.github.com/users/KiewanVillatel/received_events","type":"User","site_admin":false},"body":"LayerNormBasicGRUCell add layer normalization to basic GRU unit.\r\n\r\nLayer Normalization implementation is based on https://arxiv.org/abs/1607.06450 (\"Layer Normalization\", Jimmy Lei Ba, Jamie Ryan Kiros, Geoffrey E. Hinton) and is applied before the internal nonlinearities.","created_at":"2017-11-15T09:42:02Z","updated_at":"2018-03-09T10:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a947477196c1671a557084ef9a60c9c556f9b5e","assignee":{"login":"jhseu","id":170179,"avatar_url":"https://avatars1.githubusercontent.com/u/170179?v=4","gravatar_id":"","url":"https://api.github.com/users/jhseu","html_url":"https://github.com/jhseu","followers_url":"https://api.github.com/users/jhseu/followers","following_url":"https://api.github.com/users/jhseu/following{/other_user}","gists_url":"https://api.github.com/users/jhseu/gists{/gist_id}","starred_url":"https://api.github.com/users/jhseu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhseu/subscriptions","organizations_url":"https://api.github.com/users/jhseu/orgs","repos_url":"https://api.github.com/users/jhseu/repos","events_url":"https://api.github.com/users/jhseu/events{/privacy}","received_events_url":"https://api.github.com/users/jhseu/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhseu","id":170179,"avatar_url":"https://avatars1.githubusercontent.com/u/170179?v=4","gravatar_id":"","url":"https://api.github.com/users/jhseu","html_url":"https://github.com/jhseu","followers_url":"https://api.github.com/users/jhseu/followers","following_url":"https://api.github.com/users/jhseu/following{/other_user}","gists_url":"https://api.github.com/users/jhseu/gists{/gist_id}","starred_url":"https://api.github.com/users/jhseu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhseu/subscriptions","organizations_url":"https://api.github.com/users/jhseu/orgs","repos_url":"https://api.github.com/users/jhseu/repos","events_url":"https://api.github.com/users/jhseu/events{/privacy}","received_events_url":"https://api.github.com/users/jhseu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":300136587,"url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":386191887,"url":"https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response","name":"stat:awaiting response","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/14578/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/000474bf24f86dc11136f0ef8bb03af98d7a7754","head":{"label":"criteo-forks:master","ref":"master","sha":"000474bf24f86dc11136f0ef8bb03af98d7a7754","user":{"login":"criteo-forks","id":9960514,"avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":110692260,"name":"tensorflow","full_name":"criteo-forks/tensorflow","owner":{"login":"criteo-forks","id":9960514,"avatar_url":"https://avatars0.githubusercontent.com/u/9960514?v=4","gravatar_id":"","url":"https://api.github.com/users/criteo-forks","html_url":"https://github.com/criteo-forks","followers_url":"https://api.github.com/users/criteo-forks/followers","following_url":"https://api.github.com/users/criteo-forks/following{/other_user}","gists_url":"https://api.github.com/users/criteo-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/criteo-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criteo-forks/subscriptions","organizations_url":"https://api.github.com/users/criteo-forks/orgs","repos_url":"https://api.github.com/users/criteo-forks/repos","events_url":"https://api.github.com/users/criteo-forks/events{/privacy}","received_events_url":"https://api.github.com/users/criteo-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criteo-forks/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/criteo-forks/tensorflow","forks_url":"https://api.github.com/repos/criteo-forks/tensorflow/forks","keys_url":"https://api.github.com/repos/criteo-forks/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criteo-forks/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criteo-forks/tensorflow/teams","hooks_url":"https://api.github.com/repos/criteo-forks/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/criteo-forks/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/criteo-forks/tensorflow/events","assignees_url":"https://api.github.com/repos/criteo-forks/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/criteo-forks/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/criteo-forks/tensorflow/tags","blobs_url":"https://api.github.com/repos/criteo-forks/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criteo-forks/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criteo-forks/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/criteo-forks/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criteo-forks/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/criteo-forks/tensorflow/languages","stargazers_url":"https://api.github.com/repos/criteo-forks/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/criteo-forks/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/criteo-forks/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/criteo-forks/tensorflow/subscription","commits_url":"https://api.github.com/repos/criteo-forks/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/criteo-forks/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/criteo-forks/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/criteo-forks/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/criteo-forks/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/criteo-forks/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criteo-forks/tensorflow/merges","archive_url":"https://api.github.com/repos/criteo-forks/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criteo-forks/tensorflow/downloads","issues_url":"https://api.github.com/repos/criteo-forks/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/criteo-forks/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/criteo-forks/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/criteo-forks/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criteo-forks/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/criteo-forks/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/criteo-forks/tensorflow/deployments","created_at":"2017-11-14T13:14:23Z","updated_at":"2017-11-14T13:14:56Z","pushed_at":"2018-03-09T10:10:34Z","git_url":"git://github.com/criteo-forks/tensorflow.git","ssh_url":"git@github.com:criteo-forks/tensorflow.git","clone_url":"https://github.com/criteo-forks/tensorflow.git","svn_url":"https://github.com/criteo-forks/tensorflow","homepage":"http://tensorflow.org","size":148957,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"bd0d204700df1a1a245b0593a11efd8ede139311","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-03-09T10:15:36Z","pushed_at":"2018-03-09T10:10:58Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":154873,"stargazers_count":91909,"watchers_count":91909,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59260,"mirror_url":null,"archived":false,"open_issues_count":1458,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":59260,"open_issues":1458,"watchers":91909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/14578"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/14578"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/14578/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14578/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/000474bf24f86dc11136f0ef8bb03af98d7a7754"}},"author_association":"NONE"}} | {
"id": 45717250,
"name": "tensorflow/tensorflow",
"url": "https://api.github.com/repos/tensorflow/tensorflow"
} | {
"id": 6458145,
"login": "KiewanVillatel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6458145?",
"url": "https://api.github.com/users/KiewanVillatel"
} | {
"id": 15658638,
"login": "tensorflow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15658638?",
"url": "https://api.github.com/orgs/tensorflow"
} | 2018-03-09T10:28:30 | 7355277272 | {"actor":{"display_login":"KiewanVillatel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments/200068540","pull_request_review_id":134309334,"id":200068540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDA2ODU0MA==","diff_hunk":"@@ -150,23 +150,20 @@ go.app = function() {\n question: (\"This number previously opted out of NurseConnect messages. Are <you/they> sure <you/they> want to sign up again?\"),\n choices: [\n new Choice('yes', ('Yes')),\n- new Choice('no', ('No'))\n+ new Choice('state_no_subscription', ('No'))\n ],\n next: function(choice) {\n if (choice.value === 'yes') {\n- var optin_info = {\n- \"request_source\": self.im.config.name || \"ussd_nurse\",\n- \"address_type\": \"msisdn\"\n+\n //identity will be set here\n //address will be set here\n- };\n- return is\n- .optin(optin_info)\n- .then(function() {\n- return 'state_faccode';\n- });\n- }else {\n- return self.states.create('state_no_subscription');\n+ //address type will be set here","path":"go-app-ussd_nurse_rapidpro.js","position":59,"original_position":59,"commit_id":"1fe87c38a0f51fb3082ca4beba7726f63d791c3a","original_commit_id":"1fe87c38a0f51fb3082ca4beba7726f63d791c3a","user":{"login":"OMosimege","id":28597626,"node_id":"MDQ6VXNlcjI4NTk3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/28597626?v=4","gravatar_id":"","url":"https://api.github.com/users/OMosimege","html_url":"https://github.com/OMosimege","followers_url":"https://api.github.com/users/OMosimege/followers","following_url":"https://api.github.com/users/OMosimege/following{/other_user}","gists_url":"https://api.github.com/users/OMosimege/gists{/gist_id}","starred_url":"https://api.github.com/users/OMosimege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OMosimege/subscriptions","organizations_url":"https://api.github.com/users/OMosimege/orgs","repos_url":"https://api.github.com/users/OMosimege/repos","events_url":"https://api.github.com/users/OMosimege/events{/privacy}","received_events_url":"https://api.github.com/users/OMosimege/received_events","type":"User","site_admin":false},"body":"These all will be replaced once new functions that Seed functions, but will change 👍 ","created_at":"2018-07-04T09:42:57Z","updated_at":"2018-07-04T09:42:57Z","html_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166#discussion_r200068540","pull_request_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments/200068540"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166#discussion_r200068540"},"pull_request":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166"}},"in_reply_to_id":200067422},"pull_request":{"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166","id":198710882,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzEwODgy","html_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166","diff_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166.diff","patch_url":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166.patch","issue_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/166","number":166,"state":"open","locked":false,"title":"Feature/ussd nurse rapidpro","user":{"login":"OMosimege","id":28597626,"node_id":"MDQ6VXNlcjI4NTk3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/28597626?v=4","gravatar_id":"","url":"https://api.github.com/users/OMosimege","html_url":"https://github.com/OMosimege","followers_url":"https://api.github.com/users/OMosimege/followers","following_url":"https://api.github.com/users/OMosimege/following{/other_user}","gists_url":"https://api.github.com/users/OMosimege/gists{/gist_id}","starred_url":"https://api.github.com/users/OMosimege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OMosimege/subscriptions","organizations_url":"https://api.github.com/users/OMosimege/orgs","repos_url":"https://api.github.com/users/OMosimege/repos","events_url":"https://api.github.com/users/OMosimege/events{/privacy}","received_events_url":"https://api.github.com/users/OMosimege/received_events","type":"User","site_admin":false},"body":"Moving NurseConnect over to rapid pro\r\n\r\nAll Identity Store functions will be replaced with the NurseConnect Companion App functions\r\n\r\nComments are added for functions that will be added later on","created_at":"2018-07-02T15:14:50Z","updated_at":"2018-07-04T09:42:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"382f731a39872e017657b8dd42d7c8561f20118b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166/commits","review_comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166/comments","review_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/166/comments","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/1fe87c38a0f51fb3082ca4beba7726f63d791c3a","head":{"label":"praekeltfoundation:feature/ussd-nurse-rapidpro","ref":"feature/ussd-nurse-rapidpro","sha":"1fe87c38a0f51fb3082ca4beba7726f63d791c3a","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732866,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjg2Ng==","name":"ndoh-jsbox","full_name":"praekeltfoundation/ndoh-jsbox","owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekeltfoundation/ndoh-jsbox","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/deployments","created_at":"2016-06-22T16:05:38Z","updated_at":"2018-06-28T14:23:57Z","pushed_at":"2018-07-04T09:13:07Z","git_url":"git://github.com/praekeltfoundation/ndoh-jsbox.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-jsbox.git","clone_url":"https://github.com/praekeltfoundation/ndoh-jsbox.git","svn_url":"https://github.com/praekeltfoundation/ndoh-jsbox","homepage":null,"size":1738,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"praekeltfoundation:develop","ref":"develop","sha":"ee740ba2eb3a351a327ad93822be490d4b74a62b","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":61732866,"node_id":"MDEwOlJlcG9zaXRvcnk2MTczMjg2Ng==","name":"ndoh-jsbox","full_name":"praekeltfoundation/ndoh-jsbox","owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekeltfoundation/ndoh-jsbox","description":null,"fork":false,"url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox","forks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/deployments","created_at":"2016-06-22T16:05:38Z","updated_at":"2018-06-28T14:23:57Z","pushed_at":"2018-07-04T09:13:07Z","git_url":"git://github.com/praekeltfoundation/ndoh-jsbox.git","ssh_url":"git@github.com:praekeltfoundation/ndoh-jsbox.git","clone_url":"https://github.com/praekeltfoundation/ndoh-jsbox.git","svn_url":"https://github.com/praekeltfoundation/ndoh-jsbox","homepage":null,"size":1738,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166"},"html":{"href":"https://github.com/praekeltfoundation/ndoh-jsbox/pull/166"},"issue":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/166"},"comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/praekeltfoundation/ndoh-jsbox/statuses/1fe87c38a0f51fb3082ca4beba7726f63d791c3a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 61732866,
"name": "praekeltfoundation/ndoh-jsbox",
"url": "https://api.github.com/repos/praekeltfoundation/ndoh-jsbox"
} | {
"id": 28597626,
"login": "OMosimege",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28597626?",
"url": "https://api.github.com/users/OMosimege"
} | {
"id": 15786759,
"login": "praekeltfoundation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15786759?",
"url": "https://api.github.com/orgs/praekeltfoundation"
} | 2018-07-04T09:42:57 | 7917397195 | {"actor":{"display_login":"OMosimege"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eggjs/egg/pulls/comments/165873592","pull_request_review_id":93874834,"id":165873592,"diff_hunk":"@@ -1 +1,467 @@\n-this document is still waiting for translation, see [Chinese Version](/zh-cn/advanced/plugin.html)\n\\ No newline at end of file\n+\n+title: Plugin Development\n+---\n+\n+Plugins is the most important feature in Egg framework. It keeps Egg simple, stable and effeciently, and also it can make the best reuse of bussiness logic, to build an entire ecosystem. Some should be get confused","path":"docs/source/en/advanced/plugin.md","position":7,"original_position":7,"commit_id":"609a795275be4bd792e5191bb168d8b476eb430e","original_commit_id":"609a795275be4bd792e5191bb168d8b476eb430e","user":{"login":"SunShinewyf","id":11244400,"avatar_url":"https://avatars3.githubusercontent.com/u/11244400?v=4","gravatar_id":"","url":"https://api.github.com/users/SunShinewyf","html_url":"https://github.com/SunShinewyf","followers_url":"https://api.github.com/users/SunShinewyf/followers","following_url":"https://api.github.com/users/SunShinewyf/following{/other_user}","gists_url":"https://api.github.com/users/SunShinewyf/gists{/gist_id}","starred_url":"https://api.github.com/users/SunShinewyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SunShinewyf/subscriptions","organizations_url":"https://api.github.com/users/SunShinewyf/orgs","repos_url":"https://api.github.com/users/SunShinewyf/repos","events_url":"https://api.github.com/users/SunShinewyf/events{/privacy}","received_events_url":"https://api.github.com/users/SunShinewyf/received_events","type":"User","site_admin":false},"body":"effeciently -> efficient (这里使用形容词）\r\nbussiness -> business\r\nSome should be get confused -> some people may be confused 感觉这样会好一点","created_at":"2018-02-05T03:06:20Z","updated_at":"2018-02-05T03:44:55Z","html_url":"https://github.com/eggjs/egg/pull/2075#discussion_r165873592","pull_request_url":"https://api.github.com/repos/eggjs/egg/pulls/2075","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg/pulls/comments/165873592"},"html":{"href":"https://github.com/eggjs/egg/pull/2075#discussion_r165873592"},"pull_request":{"href":"https://api.github.com/repos/eggjs/egg/pulls/2075"}}},"pull_request":{"url":"https://api.github.com/repos/eggjs/egg/pulls/2075","id":166713708,"html_url":"https://github.com/eggjs/egg/pull/2075","diff_url":"https://github.com/eggjs/egg/pull/2075.diff","patch_url":"https://github.com/eggjs/egg/pull/2075.patch","issue_url":"https://api.github.com/repos/eggjs/egg/issues/2075","number":2075,"state":"open","locked":false,"title":"翻译 docs/source/en/advanced/plugin.md","user":{"login":"AdoBeatTheWorld","id":1528180,"avatar_url":"https://avatars1.githubusercontent.com/u/1528180?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoBeatTheWorld","html_url":"https://github.com/AdoBeatTheWorld","followers_url":"https://api.github.com/users/AdoBeatTheWorld/followers","following_url":"https://api.github.com/users/AdoBeatTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/AdoBeatTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoBeatTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoBeatTheWorld/subscriptions","organizations_url":"https://api.github.com/users/AdoBeatTheWorld/orgs","repos_url":"https://api.github.com/users/AdoBeatTheWorld/repos","events_url":"https://api.github.com/users/AdoBeatTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/AdoBeatTheWorld/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\nBug fixes and new features should include tests and possibly benchmarks.\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n\r\n感谢您贡献代码。请确认下列 checklist 的完成情况。\r\nBug 修复和新功能必须包含测试，必要时请附上性能测试。\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `npm test` passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ x] documentation is changed or added\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n英文翻译 docs/source/en/advanced/plugin.md","created_at":"2018-02-02T04:05:46Z","updated_at":"2018-02-05T03:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8599a016b669fd799e21163d9d7a1aa6d23b616","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/eggjs/egg/pulls/2075/commits","review_comments_url":"https://api.github.com/repos/eggjs/egg/pulls/2075/comments","review_comment_url":"https://api.github.com/repos/eggjs/egg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggjs/egg/issues/2075/comments","statuses_url":"https://api.github.com/repos/eggjs/egg/statuses/609a795275be4bd792e5191bb168d8b476eb430e","head":{"label":"AdoBeatTheWorld:master","ref":"master","sha":"609a795275be4bd792e5191bb168d8b476eb430e","user":{"login":"AdoBeatTheWorld","id":1528180,"avatar_url":"https://avatars1.githubusercontent.com/u/1528180?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoBeatTheWorld","html_url":"https://github.com/AdoBeatTheWorld","followers_url":"https://api.github.com/users/AdoBeatTheWorld/followers","following_url":"https://api.github.com/users/AdoBeatTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/AdoBeatTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoBeatTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoBeatTheWorld/subscriptions","organizations_url":"https://api.github.com/users/AdoBeatTheWorld/orgs","repos_url":"https://api.github.com/users/AdoBeatTheWorld/repos","events_url":"https://api.github.com/users/AdoBeatTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/AdoBeatTheWorld/received_events","type":"User","site_admin":false},"repo":{"id":119920595,"name":"egg","full_name":"AdoBeatTheWorld/egg","owner":{"login":"AdoBeatTheWorld","id":1528180,"avatar_url":"https://avatars1.githubusercontent.com/u/1528180?v=4","gravatar_id":"","url":"https://api.github.com/users/AdoBeatTheWorld","html_url":"https://github.com/AdoBeatTheWorld","followers_url":"https://api.github.com/users/AdoBeatTheWorld/followers","following_url":"https://api.github.com/users/AdoBeatTheWorld/following{/other_user}","gists_url":"https://api.github.com/users/AdoBeatTheWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoBeatTheWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoBeatTheWorld/subscriptions","organizations_url":"https://api.github.com/users/AdoBeatTheWorld/orgs","repos_url":"https://api.github.com/users/AdoBeatTheWorld/repos","events_url":"https://api.github.com/users/AdoBeatTheWorld/events{/privacy}","received_events_url":"https://api.github.com/users/AdoBeatTheWorld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdoBeatTheWorld/egg","description":"Born to build better enterprise frameworks and apps with Node.js & Koa","fork":true,"url":"https://api.github.com/repos/AdoBeatTheWorld/egg","forks_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/forks","keys_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/teams","hooks_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/hooks","issue_events_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/issues/events{/number}","events_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/events","assignees_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/assignees{/user}","branches_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/branches{/branch}","tags_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/tags","blobs_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/languages","stargazers_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/stargazers","contributors_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/contributors","subscribers_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/subscribers","subscription_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/subscription","commits_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/contents/{+path}","compare_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/merges","archive_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/downloads","issues_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/issues{/number}","pulls_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/labels{/name}","releases_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/releases{/id}","deployments_url":"https://api.github.com/repos/AdoBeatTheWorld/egg/deployments","created_at":"2018-02-02T02:26:47Z","updated_at":"2018-02-02T02:26:50Z","pushed_at":"2018-02-02T04:02:23Z","git_url":"git://github.com/AdoBeatTheWorld/egg.git","ssh_url":"git@github.com:AdoBeatTheWorld/egg.git","clone_url":"https://github.com/AdoBeatTheWorld/egg.git","svn_url":"https://github.com/AdoBeatTheWorld/egg","homepage":"https://eggjs.org","size":39998,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eggjs:master","ref":"master","sha":"7e9f330eea2efcc26e99eb89ad3fb40c517e0101","user":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars1.githubusercontent.com/u/15833670?v=4","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"repo":{"id":61421257,"name":"egg","full_name":"eggjs/egg","owner":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars1.githubusercontent.com/u/15833670?v=4","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggjs/egg","description":"Born to build better enterprise frameworks and apps with Node.js & Koa","fork":false,"url":"https://api.github.com/repos/eggjs/egg","forks_url":"https://api.github.com/repos/eggjs/egg/forks","keys_url":"https://api.github.com/repos/eggjs/egg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggjs/egg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggjs/egg/teams","hooks_url":"https://api.github.com/repos/eggjs/egg/hooks","issue_events_url":"https://api.github.com/repos/eggjs/egg/issues/events{/number}","events_url":"https://api.github.com/repos/eggjs/egg/events","assignees_url":"https://api.github.com/repos/eggjs/egg/assignees{/user}","branches_url":"https://api.github.com/repos/eggjs/egg/branches{/branch}","tags_url":"https://api.github.com/repos/eggjs/egg/tags","blobs_url":"https://api.github.com/repos/eggjs/egg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggjs/egg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggjs/egg/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggjs/egg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggjs/egg/statuses/{sha}","languages_url":"https://api.github.com/repos/eggjs/egg/languages","stargazers_url":"https://api.github.com/repos/eggjs/egg/stargazers","contributors_url":"https://api.github.com/repos/eggjs/egg/contributors","subscribers_url":"https://api.github.com/repos/eggjs/egg/subscribers","subscription_url":"https://api.github.com/repos/eggjs/egg/subscription","commits_url":"https://api.github.com/repos/eggjs/egg/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggjs/egg/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggjs/egg/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggjs/egg/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggjs/egg/contents/{+path}","compare_url":"https://api.github.com/repos/eggjs/egg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggjs/egg/merges","archive_url":"https://api.github.com/repos/eggjs/egg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggjs/egg/downloads","issues_url":"https://api.github.com/repos/eggjs/egg/issues{/number}","pulls_url":"https://api.github.com/repos/eggjs/egg/pulls{/number}","milestones_url":"https://api.github.com/repos/eggjs/egg/milestones{/number}","notifications_url":"https://api.github.com/repos/eggjs/egg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggjs/egg/labels{/name}","releases_url":"https://api.github.com/repos/eggjs/egg/releases{/id}","deployments_url":"https://api.github.com/repos/eggjs/egg/deployments","created_at":"2016-06-18T06:53:23Z","updated_at":"2018-02-05T02:55:52Z","pushed_at":"2018-02-03T04:30:43Z","git_url":"git://github.com/eggjs/egg.git","ssh_url":"git@github.com:eggjs/egg.git","clone_url":"https://github.com/eggjs/egg.git","svn_url":"https://github.com/eggjs/egg","homepage":"https://eggjs.org","size":40089,"stargazers_count":6829,"watchers_count":6829,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":692,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":692,"open_issues":90,"watchers":6829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg/pulls/2075"},"html":{"href":"https://github.com/eggjs/egg/pull/2075"},"issue":{"href":"https://api.github.com/repos/eggjs/egg/issues/2075"},"comments":{"href":"https://api.github.com/repos/eggjs/egg/issues/2075/comments"},"review_comments":{"href":"https://api.github.com/repos/eggjs/egg/pulls/2075/comments"},"review_comment":{"href":"https://api.github.com/repos/eggjs/egg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggjs/egg/pulls/2075/commits"},"statuses":{"href":"https://api.github.com/repos/eggjs/egg/statuses/609a795275be4bd792e5191bb168d8b476eb430e"}},"author_association":"NONE"}} | {
"id": 61421257,
"name": "eggjs/egg",
"url": "https://api.github.com/repos/eggjs/egg"
} | {
"id": 11244400,
"login": "SunShinewyf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11244400?",
"url": "https://api.github.com/users/SunShinewyf"
} | {
"id": 15833670,
"login": "eggjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15833670?",
"url": "https://api.github.com/orgs/eggjs"
} | 2018-02-05T03:06:20 | 7196543661 | {"actor":{"display_login":"SunShinewyf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-android/pulls/comments/166318334","pull_request_review_id":94346258,"id":166318334,"diff_hunk":"@@ -0,0 +1,93 @@\n+/**\n+ * Wire\n+ * Copyright (C) 2018 Wire Swiss GmbH\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+package com.waz.zclient.participants\n+\n+import android.content.Context\n+import android.view.View\n+import com.waz.model._\n+import com.waz.service.ZMessaging\n+import com.waz.utils.events.{EventContext, EventStream, Signal}\n+import com.waz.zclient.conversation.ConversationController\n+import com.waz.zclient.utils.{ConversationMembersSignal, UiStorage}\n+import com.waz.zclient.{Injectable, Injector}\n+import com.waz.ZLog.ImplicitTag._\n+import com.waz.zclient.messages.UsersController\n+\n+import scala.concurrent.Future\n+\n+class ParticipantsController(implicit injector: Injector, context: Context, ec: EventContext) extends Injectable {\n+\n+ import com.waz.threading.Threading.Implicits.Background\n+\n+ implicit private lazy val uiStorage = inject[UiStorage]\n+\n+ private lazy val zms = inject[Signal[ZMessaging]]\n+ private lazy val convController = inject[ConversationController]\n+ private lazy val usersController = inject[UsersController]\n+\n+ private val selectedParticipant = Signal[Option[UserId]](None)\n+\n+ val otherParticipants = for {\n+ z <- zms\n+ convId <- convController.currentConvId\n+ memberIds <- ConversationMembersSignal(convId)\n+ members <- Signal.future(z.users.getUsers(memberIds.toSeq))","path":"app/src/main/scala/com/waz/zclient/participants/ParticipantsController.scala","position":49,"original_position":49,"commit_id":"50bffac6ac09644c6654fa4660ca550bd0e25b8b","original_commit_id":"50bffac6ac09644c6654fa4660ca550bd0e25b8b","user":{"login":"deanrobertcook","id":5234193,"avatar_url":"https://avatars3.githubusercontent.com/u/5234193?v=4","gravatar_id":"","url":"https://api.github.com/users/deanrobertcook","html_url":"https://github.com/deanrobertcook","followers_url":"https://api.github.com/users/deanrobertcook/followers","following_url":"https://api.github.com/users/deanrobertcook/following{/other_user}","gists_url":"https://api.github.com/users/deanrobertcook/gists{/gist_id}","starred_url":"https://api.github.com/users/deanrobertcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanrobertcook/subscriptions","organizations_url":"https://api.github.com/users/deanrobertcook/orgs","repos_url":"https://api.github.com/users/deanrobertcook/repos","events_url":"https://api.github.com/users/deanrobertcook/events{/privacy}","received_events_url":"https://api.github.com/users/deanrobertcook/received_events","type":"User","site_admin":false},"body":"Also, careful when using `Signal.future` if the user data changes, then we won't get those updates here...","created_at":"2018-02-06T14:28:52Z","updated_at":"2018-02-06T14:39:40Z","html_url":"https://github.com/wireapp/wire-android/pull/1394#discussion_r166318334","pull_request_url":"https://api.github.com/repos/wireapp/wire-android/pulls/1394","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/comments/166318334"},"html":{"href":"https://github.com/wireapp/wire-android/pull/1394#discussion_r166318334"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/1394"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-android/pulls/1394","id":165763758,"html_url":"https://github.com/wireapp/wire-android/pull/1394","diff_url":"https://github.com/wireapp/wire-android/pull/1394.diff","patch_url":"https://github.com/wireapp/wire-android/pull/1394.patch","issue_url":"https://api.github.com/repos/wireapp/wire-android/issues/1394","number":1394,"state":"open","locked":false,"title":"rewrite participants fragments in Scala","user":{"login":"makingthematrix","id":4498008,"avatar_url":"https://avatars0.githubusercontent.com/u/4498008?v=4","gravatar_id":"","url":"https://api.github.com/users/makingthematrix","html_url":"https://github.com/makingthematrix","followers_url":"https://api.github.com/users/makingthematrix/followers","following_url":"https://api.github.com/users/makingthematrix/following{/other_user}","gists_url":"https://api.github.com/users/makingthematrix/gists{/gist_id}","starred_url":"https://api.github.com/users/makingthematrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makingthematrix/subscriptions","organizations_url":"https://api.github.com/users/makingthematrix/orgs","repos_url":"https://api.github.com/users/makingthematrix/repos","events_url":"https://api.github.com/users/makingthematrix/events{/privacy}","received_events_url":"https://api.github.com/users/makingthematrix/received_events","type":"User","site_admin":false},"body":"More changes to `ParticipantBodyFragment` and additionally a fix to `ParticipantChatheadAdapter` to correctly show separators.\n#### APK\n[Download build #10161](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10161/artifact/build/artifact/wire-dev-PR1394-10161.apk)\n[Download build #10162](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10162/artifact/build/artifact/wire-dev-PR1394-10162.apk)\n[Download build #10180](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10180/artifact/build/artifact/wire-dev-PR1394-10180.apk)\n[Download build #10181](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10181/artifact/build/artifact/wire-dev-PR1394-10181.apk)\n[Download build #10182](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10182/artifact/build/artifact/wire-dev-PR1394-10182.apk)\n[Download build #10188](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10188/artifact/build/artifact/wire-dev-PR1394-10188.apk)\n[Download build #10189](http://192.168.10.18:8080/job/Pull%20Request%20Builder/10189/artifact/build/artifact/wire-dev-PR1394-10189.apk)","created_at":"2018-01-29T17:10:30Z","updated_at":"2018-02-06T14:39:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3940281b7f0c4c9efe9e0120db36388bda7fcbf3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-android/pulls/1394/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-android/pulls/1394/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-android/issues/1394/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-android/statuses/50bffac6ac09644c6654fa4660ca550bd0e25b8b","head":{"label":"wireapp:participants_refactoring","ref":"participants_refactoring","sha":"50bffac6ac09644c6654fa4660ca550bd0e25b8b","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":50094455,"name":"wire-android","full_name":"wireapp/wire-android","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-android","description":":phone: Wire for Android","fork":false,"url":"https://api.github.com/repos/wireapp/wire-android","forks_url":"https://api.github.com/repos/wireapp/wire-android/forks","keys_url":"https://api.github.com/repos/wireapp/wire-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-android/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-android/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-android/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-android/events","assignees_url":"https://api.github.com/repos/wireapp/wire-android/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-android/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-android/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-android/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-android/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-android/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-android/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-android/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-android/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-android/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-android/merges","archive_url":"https://api.github.com/repos/wireapp/wire-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-android/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-android/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-android/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-android/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-android/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-android/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-android/deployments","created_at":"2016-01-21T08:50:07Z","updated_at":"2018-02-05T06:09:42Z","pushed_at":"2018-02-06T13:46:17Z","git_url":"git://github.com/wireapp/wire-android.git","ssh_url":"git@github.com:wireapp/wire-android.git","clone_url":"https://github.com/wireapp/wire-android.git","svn_url":"https://github.com/wireapp/wire-android","homepage":"https://wire.com/download/","size":60443,"stargazers_count":2030,"watchers_count":2030,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"archived":false,"open_issues_count":321,"license":null,"forks":370,"open_issues":321,"watchers":2030,"default_branch":"master"}},"base":{"label":"wireapp:integrations_ui","ref":"integrations_ui","sha":"0abe69f03d22948a2d1e820eaa6a031632e11592","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":50094455,"name":"wire-android","full_name":"wireapp/wire-android","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-android","description":":phone: Wire for Android","fork":false,"url":"https://api.github.com/repos/wireapp/wire-android","forks_url":"https://api.github.com/repos/wireapp/wire-android/forks","keys_url":"https://api.github.com/repos/wireapp/wire-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-android/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-android/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-android/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-android/events","assignees_url":"https://api.github.com/repos/wireapp/wire-android/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-android/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-android/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-android/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-android/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-android/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-android/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-android/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-android/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-android/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-android/merges","archive_url":"https://api.github.com/repos/wireapp/wire-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-android/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-android/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-android/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-android/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-android/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-android/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-android/deployments","created_at":"2016-01-21T08:50:07Z","updated_at":"2018-02-05T06:09:42Z","pushed_at":"2018-02-06T13:46:17Z","git_url":"git://github.com/wireapp/wire-android.git","ssh_url":"git@github.com:wireapp/wire-android.git","clone_url":"https://github.com/wireapp/wire-android.git","svn_url":"https://github.com/wireapp/wire-android","homepage":"https://wire.com/download/","size":60443,"stargazers_count":2030,"watchers_count":2030,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"archived":false,"open_issues_count":321,"license":null,"forks":370,"open_issues":321,"watchers":2030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/1394"},"html":{"href":"https://github.com/wireapp/wire-android/pull/1394"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-android/issues/1394"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-android/issues/1394/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/1394/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-android/pulls/1394/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-android/statuses/50bffac6ac09644c6654fa4660ca550bd0e25b8b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 50094455,
"name": "wireapp/wire-android",
"url": "https://api.github.com/repos/wireapp/wire-android"
} | {
"id": 5234193,
"login": "deanrobertcook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5234193?",
"url": "https://api.github.com/users/deanrobertcook"
} | {
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
} | 2018-02-06T14:28:52 | 7205041269 | {"actor":{"display_login":"deanrobertcook"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/221243475","pull_request_review_id":159847451,"id":221243475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI0MzQ3NQ==","diff_hunk":"@@ -191,8 +188,9 @@ ko.bindingHandlers.resize = (function() {\n const params = ko.unwrap(valueAccessor()) || {};\n triggerValue = params.triggerValue;\n syncElement = document.querySelector(params.syncElement);\n+ throttledResizeTextarea = _.throttle(resizeTextarea, 100, {leading: !params.delayedResize});","path":"app/script/view_model/bindings/CommonBindings.js","position":39,"original_position":39,"commit_id":"876d9673f72de08f030002eb67473dfa4165a45f","original_commit_id":"876d9673f72de08f030002eb67473dfa4165a45f","user":{"login":"atomrc","id":1090716,"node_id":"MDQ6VXNlcjEwOTA3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1090716?v=4","gravatar_id":"","url":"https://api.github.com/users/atomrc","html_url":"https://github.com/atomrc","followers_url":"https://api.github.com/users/atomrc/followers","following_url":"https://api.github.com/users/atomrc/following{/other_user}","gists_url":"https://api.github.com/users/atomrc/gists{/gist_id}","starred_url":"https://api.github.com/users/atomrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomrc/subscriptions","organizations_url":"https://api.github.com/users/atomrc/orgs","repos_url":"https://api.github.com/users/atomrc/repos","events_url":"https://api.github.com/users/atomrc/events{/privacy}","received_events_url":"https://api.github.com/users/atomrc/received_events","type":"User","site_admin":false},"body":"There might a problem here, I should create the throttled version in the `init` function instead","created_at":"2018-09-28T12:58:27Z","updated_at":"2018-09-28T12:58:27Z","html_url":"https://github.com/wireapp/wire-webapp/pull/4759#discussion_r221243475","pull_request_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/221243475"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/4759#discussion_r221243475"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759","id":218944001,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTQ0MDAx","html_url":"https://github.com/wireapp/wire-webapp/pull/4759","diff_url":"https://github.com/wireapp/wire-webapp/pull/4759.diff","patch_url":"https://github.com/wireapp/wire-webapp/pull/4759.patch","issue_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/4759","number":4759,"state":"open","locked":false,"title":"refactor: Run textarea resizing asynchronously (WEBAPP-5548)","user":{"login":"atomrc","id":1090716,"node_id":"MDQ6VXNlcjEwOTA3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1090716?v=4","gravatar_id":"","url":"https://api.github.com/users/atomrc","html_url":"https://github.com/atomrc","followers_url":"https://api.github.com/users/atomrc/followers","following_url":"https://api.github.com/users/atomrc/following{/other_user}","gists_url":"https://api.github.com/users/atomrc/gists{/gist_id}","starred_url":"https://api.github.com/users/atomrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomrc/subscriptions","organizations_url":"https://api.github.com/users/atomrc/orgs","repos_url":"https://api.github.com/users/atomrc/repos","events_url":"https://api.github.com/users/atomrc/events{/privacy}","received_events_url":"https://api.github.com/users/atomrc/received_events","type":"User","site_admin":false},"body":"Will prevent reflow operations to block the thread while typing in the textarea","created_at":"2018-09-28T11:55:30Z","updated_at":"2018-09-28T12:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f187fe3d9b1582121feedd8f7b474798df8ee51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/4759/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/876d9673f72de08f030002eb67473dfa4165a45f","head":{"label":"wireapp:fix/delayed_reflow","ref":"fix/delayed_reflow","sha":"876d9673f72de08f030002eb67473dfa4165a45f","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MTMyOA==","name":"wire-webapp","full_name":"wireapp/wire-webapp","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2018-09-28T12:57:04Z","pushed_at":"2018-09-28T12:57:03Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":28413,"stargazers_count":803,"watchers_count":803,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":177,"open_issues":49,"watchers":803,"default_branch":"dev"}},"base":{"label":"wireapp:dev","ref":"dev","sha":"edf4ff568d5afe95778725f46c6eebce6ded3c9c","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MTMyOA==","name":"wire-webapp","full_name":"wireapp/wire-webapp","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2018-09-28T12:57:04Z","pushed_at":"2018-09-28T12:57:03Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":28413,"stargazers_count":803,"watchers_count":803,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":177,"open_issues":49,"watchers":803,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/4759"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/4759"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/4759/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/4759/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-webapp/statuses/876d9673f72de08f030002eb67473dfa4165a45f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 63881328,
"name": "wireapp/wire-webapp",
"url": "https://api.github.com/repos/wireapp/wire-webapp"
} | {
"id": 1090716,
"login": "atomrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1090716?",
"url": "https://api.github.com/users/atomrc"
} | {
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
} | 2018-09-28T12:58:27 | 8337964087 | {"actor":{"display_login":"atomrc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments/225659469","pull_request_review_id":165306609,"id":225659469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY1OTQ2OQ==","diff_hunk":"@@ -77,7 +77,7 @@ template<class T> inline void Zero(T * first, size_t cnt) { memset(first, 0,\n template<class T, class U> inline void Copy(T & dst, U const & src)\n {\n static_assert(sizeof(T) == sizeof(U), \"copy_objects_of_different_size\");\n- memcpy_s(&dst, sizeof(dst), &src, sizeof(dst));\n+ std::copy(std::begin(src), std::end(src), std::begin(dst));","path":"_studio/mfx_lib/encode_hw/h265/include/mfx_h265_encode_hw_utils.h","position":5,"original_position":5,"commit_id":"e2ecad74f29180433622cc7022963bec1fbb02b4","original_commit_id":"e2ecad74f29180433622cc7022963bec1fbb02b4","user":{"login":"mgonchar","id":13066027,"node_id":"MDQ6VXNlcjEzMDY2MDI3","avatar_url":"https://avatars0.githubusercontent.com/u/13066027?v=4","gravatar_id":"","url":"https://api.github.com/users/mgonchar","html_url":"https://github.com/mgonchar","followers_url":"https://api.github.com/users/mgonchar/followers","following_url":"https://api.github.com/users/mgonchar/following{/other_user}","gists_url":"https://api.github.com/users/mgonchar/gists{/gist_id}","starred_url":"https://api.github.com/users/mgonchar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgonchar/subscriptions","organizations_url":"https://api.github.com/users/mgonchar/orgs","repos_url":"https://api.github.com/users/mgonchar/repos","events_url":"https://api.github.com/users/mgonchar/events{/privacy}","received_events_url":"https://api.github.com/users/mgonchar/received_events","type":"User","site_admin":false},"body":"no, I disagree. Passed arguments might have any type. It could even be non-POD, so previous code was super dangerous. Remove this template function at all and fix copying in place everywhere it used. I don't see other way","created_at":"2018-10-16T18:32:22Z","updated_at":"2018-10-16T18:37:57Z","html_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761#discussion_r225659469","pull_request_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments/225659469"},"html":{"href":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761#discussion_r225659469"},"pull_request":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761"}}},"pull_request":{"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761","id":223290243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjkwMjQz","html_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761","diff_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761.diff","patch_url":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761.patch","issue_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/761","number":761,"state":"open","locked":false,"title":"h265e- use C++ primitives (memcpy => std::copy)","user":{"login":"ilapichev","id":43004070,"node_id":"MDQ6VXNlcjQzMDA0MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/43004070?v=4","gravatar_id":"","url":"https://api.github.com/users/ilapichev","html_url":"https://github.com/ilapichev","followers_url":"https://api.github.com/users/ilapichev/followers","following_url":"https://api.github.com/users/ilapichev/following{/other_user}","gists_url":"https://api.github.com/users/ilapichev/gists{/gist_id}","starred_url":"https://api.github.com/users/ilapichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilapichev/subscriptions","organizations_url":"https://api.github.com/users/ilapichev/orgs","repos_url":"https://api.github.com/users/ilapichev/repos","events_url":"https://api.github.com/users/ilapichev/events{/privacy}","received_events_url":"https://api.github.com/users/ilapichev/received_events","type":"User","site_admin":false},"body":"Issue: MDP-50973","created_at":"2018-10-16T15:13:06Z","updated_at":"2018-10-16T18:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55d923fab38efee1f0961cee926e9f7408557ca2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dmitryermilov","id":19732160,"node_id":"MDQ6VXNlcjE5NzMyMTYw","avatar_url":"https://avatars2.githubusercontent.com/u/19732160?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitryermilov","html_url":"https://github.com/dmitryermilov","followers_url":"https://api.github.com/users/dmitryermilov/followers","following_url":"https://api.github.com/users/dmitryermilov/following{/other_user}","gists_url":"https://api.github.com/users/dmitryermilov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitryermilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitryermilov/subscriptions","organizations_url":"https://api.github.com/users/dmitryermilov/orgs","repos_url":"https://api.github.com/users/dmitryermilov/repos","events_url":"https://api.github.com/users/dmitryermilov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitryermilov/received_events","type":"User","site_admin":false},{"login":"onabiull","id":28653530,"node_id":"MDQ6VXNlcjI4NjUzNTMw","avatar_url":"https://avatars0.githubusercontent.com/u/28653530?v=4","gravatar_id":"","url":"https://api.github.com/users/onabiull","html_url":"https://github.com/onabiull","followers_url":"https://api.github.com/users/onabiull/followers","following_url":"https://api.github.com/users/onabiull/following{/other_user}","gists_url":"https://api.github.com/users/onabiull/gists{/gist_id}","starred_url":"https://api.github.com/users/onabiull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onabiull/subscriptions","organizations_url":"https://api.github.com/users/onabiull/orgs","repos_url":"https://api.github.com/users/onabiull/repos","events_url":"https://api.github.com/users/onabiull/events{/privacy}","received_events_url":"https://api.github.com/users/onabiull/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761/commits","review_comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761/comments","review_comment_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/761/comments","statuses_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/e2ecad74f29180433622cc7022963bec1fbb02b4","head":{"label":"ilapichev:h265e_use_C++_primitives","ref":"h265e_use_C++_primitives","sha":"e2ecad74f29180433622cc7022963bec1fbb02b4","user":{"login":"ilapichev","id":43004070,"node_id":"MDQ6VXNlcjQzMDA0MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/43004070?v=4","gravatar_id":"","url":"https://api.github.com/users/ilapichev","html_url":"https://github.com/ilapichev","followers_url":"https://api.github.com/users/ilapichev/followers","following_url":"https://api.github.com/users/ilapichev/following{/other_user}","gists_url":"https://api.github.com/users/ilapichev/gists{/gist_id}","starred_url":"https://api.github.com/users/ilapichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilapichev/subscriptions","organizations_url":"https://api.github.com/users/ilapichev/orgs","repos_url":"https://api.github.com/users/ilapichev/repos","events_url":"https://api.github.com/users/ilapichev/events{/privacy}","received_events_url":"https://api.github.com/users/ilapichev/received_events","type":"User","site_admin":false},"repo":{"id":147665850,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NjU4NTA=","name":"MediaSDK","full_name":"ilapichev/MediaSDK","private":false,"owner":{"login":"ilapichev","id":43004070,"node_id":"MDQ6VXNlcjQzMDA0MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/43004070?v=4","gravatar_id":"","url":"https://api.github.com/users/ilapichev","html_url":"https://github.com/ilapichev","followers_url":"https://api.github.com/users/ilapichev/followers","following_url":"https://api.github.com/users/ilapichev/following{/other_user}","gists_url":"https://api.github.com/users/ilapichev/gists{/gist_id}","starred_url":"https://api.github.com/users/ilapichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilapichev/subscriptions","organizations_url":"https://api.github.com/users/ilapichev/orgs","repos_url":"https://api.github.com/users/ilapichev/repos","events_url":"https://api.github.com/users/ilapichev/events{/privacy}","received_events_url":"https://api.github.com/users/ilapichev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ilapichev/MediaSDK","description":"The Intel® Media SDK","fork":true,"url":"https://api.github.com/repos/ilapichev/MediaSDK","forks_url":"https://api.github.com/repos/ilapichev/MediaSDK/forks","keys_url":"https://api.github.com/repos/ilapichev/MediaSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilapichev/MediaSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilapichev/MediaSDK/teams","hooks_url":"https://api.github.com/repos/ilapichev/MediaSDK/hooks","issue_events_url":"https://api.github.com/repos/ilapichev/MediaSDK/issues/events{/number}","events_url":"https://api.github.com/repos/ilapichev/MediaSDK/events","assignees_url":"https://api.github.com/repos/ilapichev/MediaSDK/assignees{/user}","branches_url":"https://api.github.com/repos/ilapichev/MediaSDK/branches{/branch}","tags_url":"https://api.github.com/repos/ilapichev/MediaSDK/tags","blobs_url":"https://api.github.com/repos/ilapichev/MediaSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilapichev/MediaSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilapichev/MediaSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilapichev/MediaSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilapichev/MediaSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ilapichev/MediaSDK/languages","stargazers_url":"https://api.github.com/repos/ilapichev/MediaSDK/stargazers","contributors_url":"https://api.github.com/repos/ilapichev/MediaSDK/contributors","subscribers_url":"https://api.github.com/repos/ilapichev/MediaSDK/subscribers","subscription_url":"https://api.github.com/repos/ilapichev/MediaSDK/subscription","commits_url":"https://api.github.com/repos/ilapichev/MediaSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilapichev/MediaSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilapichev/MediaSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilapichev/MediaSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilapichev/MediaSDK/contents/{+path}","compare_url":"https://api.github.com/repos/ilapichev/MediaSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilapichev/MediaSDK/merges","archive_url":"https://api.github.com/repos/ilapichev/MediaSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilapichev/MediaSDK/downloads","issues_url":"https://api.github.com/repos/ilapichev/MediaSDK/issues{/number}","pulls_url":"https://api.github.com/repos/ilapichev/MediaSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ilapichev/MediaSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ilapichev/MediaSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilapichev/MediaSDK/labels{/name}","releases_url":"https://api.github.com/repos/ilapichev/MediaSDK/releases{/id}","deployments_url":"https://api.github.com/repos/ilapichev/MediaSDK/deployments","created_at":"2018-09-06T11:50:03Z","updated_at":"2018-10-16T08:12:11Z","pushed_at":"2018-10-16T15:12:24Z","git_url":"git://github.com/ilapichev/MediaSDK.git","ssh_url":"git@github.com:ilapichev/MediaSDK.git","clone_url":"https://github.com/ilapichev/MediaSDK.git","svn_url":"https://github.com/ilapichev/MediaSDK","homepage":"http://mediasdk.intel.com","size":23418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-Media-SDK:master","ref":"master","sha":"9468899fa0678c3589e3bbd0fc56aa82baa4a84e","user":{"login":"Intel-Media-SDK","id":16081150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDgxMTUw","avatar_url":"https://avatars1.githubusercontent.com/u/16081150?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-Media-SDK","html_url":"https://github.com/Intel-Media-SDK","followers_url":"https://api.github.com/users/Intel-Media-SDK/followers","following_url":"https://api.github.com/users/Intel-Media-SDK/following{/other_user}","gists_url":"https://api.github.com/users/Intel-Media-SDK/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-Media-SDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-Media-SDK/subscriptions","organizations_url":"https://api.github.com/users/Intel-Media-SDK/orgs","repos_url":"https://api.github.com/users/Intel-Media-SDK/repos","events_url":"https://api.github.com/users/Intel-Media-SDK/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-Media-SDK/received_events","type":"Organization","site_admin":false},"repo":{"id":87199173,"node_id":"MDEwOlJlcG9zaXRvcnk4NzE5OTE3Mw==","name":"MediaSDK","full_name":"Intel-Media-SDK/MediaSDK","private":false,"owner":{"login":"Intel-Media-SDK","id":16081150,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDgxMTUw","avatar_url":"https://avatars1.githubusercontent.com/u/16081150?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-Media-SDK","html_url":"https://github.com/Intel-Media-SDK","followers_url":"https://api.github.com/users/Intel-Media-SDK/followers","following_url":"https://api.github.com/users/Intel-Media-SDK/following{/other_user}","gists_url":"https://api.github.com/users/Intel-Media-SDK/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-Media-SDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-Media-SDK/subscriptions","organizations_url":"https://api.github.com/users/Intel-Media-SDK/orgs","repos_url":"https://api.github.com/users/Intel-Media-SDK/repos","events_url":"https://api.github.com/users/Intel-Media-SDK/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-Media-SDK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Intel-Media-SDK/MediaSDK","description":"The Intel® Media SDK","fork":false,"url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK","forks_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/forks","keys_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/teams","hooks_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/hooks","issue_events_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/events","assignees_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/tags","blobs_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/languages","stargazers_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/stargazers","contributors_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/contributors","subscribers_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/subscribers","subscription_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/subscription","commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/merges","archive_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/downloads","issues_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/labels{/name}","releases_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/deployments","created_at":"2017-04-04T14:52:06Z","updated_at":"2018-10-16T14:24:58Z","pushed_at":"2018-10-16T17:38:45Z","git_url":"git://github.com/Intel-Media-SDK/MediaSDK.git","ssh_url":"git@github.com:Intel-Media-SDK/MediaSDK.git","clone_url":"https://github.com/Intel-Media-SDK/MediaSDK.git","svn_url":"https://github.com/Intel-Media-SDK/MediaSDK","homepage":"http://mediasdk.intel.com","size":24051,"stargazers_count":204,"watchers_count":204,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":114,"open_issues":90,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761"},"html":{"href":"https://github.com/Intel-Media-SDK/MediaSDK/pull/761"},"issue":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/761"},"comments":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/issues/761/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/pulls/761/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-Media-SDK/MediaSDK/statuses/e2ecad74f29180433622cc7022963bec1fbb02b4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87199173,
"name": "Intel-Media-SDK/MediaSDK",
"url": "https://api.github.com/repos/Intel-Media-SDK/MediaSDK"
} | {
"id": 13066027,
"login": "mgonchar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13066027?",
"url": "https://api.github.com/users/mgonchar"
} | {
"id": 16081150,
"login": "Intel-Media-SDK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16081150?",
"url": "https://api.github.com/orgs/Intel-Media-SDK"
} | 2018-10-16T18:32:22 | 8430543126 | {"actor":{"display_login":"mgonchar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/open62541/open62541/pulls/comments/191314709","pull_request_review_id":123860430,"id":191314709,"diff_hunk":"@@ -203,11 +203,13 @@ typeCheckVariableNode(UA_Server *server, UA_Session *session,\n }\n \n /* Check array dimensions against the vt */\n- if(!compatibleArrayDimensions(vt->arrayDimensionsSize, vt->arrayDimensions,","path":"src/server/ua_services_nodemanagement.c","position":4,"original_position":4,"commit_id":"0c3fbe90318c524e2012888f0cab1929c19bd551","original_commit_id":"0c3fbe90318c524e2012888f0cab1929c19bd551","user":{"login":"basyskom-jvoe","id":33348624,"avatar_url":"https://avatars2.githubusercontent.com/u/33348624?v=4","gravatar_id":"","url":"https://api.github.com/users/basyskom-jvoe","html_url":"https://github.com/basyskom-jvoe","followers_url":"https://api.github.com/users/basyskom-jvoe/followers","following_url":"https://api.github.com/users/basyskom-jvoe/following{/other_user}","gists_url":"https://api.github.com/users/basyskom-jvoe/gists{/gist_id}","starred_url":"https://api.github.com/users/basyskom-jvoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basyskom-jvoe/subscriptions","organizations_url":"https://api.github.com/users/basyskom-jvoe/orgs","repos_url":"https://api.github.com/users/basyskom-jvoe/repos","events_url":"https://api.github.com/users/basyskom-jvoe/events{/privacy}","received_events_url":"https://api.github.com/users/basyskom-jvoe/received_events","type":"User","site_admin":false},"body":"-2 is \"scalar or an array with any number of dimensions\". The OPC UA foundation nodesets seem to rely on that. Without this exception, several nodes can't be instantiated. You can try this out by only applying the changes for the python scripts and starting a server with generated full namespace 0, DI, PLCOpen and ADI nodesets.","created_at":"2018-05-29T06:28:26Z","updated_at":"2018-05-29T06:28:26Z","html_url":"https://github.com/open62541/open62541/pull/1810#discussion_r191314709","pull_request_url":"https://api.github.com/repos/open62541/open62541/pulls/1810","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open62541/open62541/pulls/comments/191314709"},"html":{"href":"https://github.com/open62541/open62541/pull/1810#discussion_r191314709"},"pull_request":{"href":"https://api.github.com/repos/open62541/open62541/pulls/1810"}},"in_reply_to_id":191265761},"pull_request":{"url":"https://api.github.com/repos/open62541/open62541/pulls/1810","id":190861226,"html_url":"https://github.com/open62541/open62541/pull/1810","diff_url":"https://github.com/open62541/open62541/pull/1810.diff","patch_url":"https://github.com/open62541/open62541/pull/1810.patch","issue_url":"https://api.github.com/repos/open62541/open62541/issues/1810","number":1810,"state":"open","locked":false,"title":"WIP: Add all attributes of VariableType nodes in the nodeset compiler","user":{"login":"basyskom-jvoe","id":33348624,"avatar_url":"https://avatars2.githubusercontent.com/u/33348624?v=4","gravatar_id":"","url":"https://api.github.com/users/basyskom-jvoe","html_url":"https://github.com/basyskom-jvoe","followers_url":"https://api.github.com/users/basyskom-jvoe/followers","following_url":"https://api.github.com/users/basyskom-jvoe/following{/other_user}","gists_url":"https://api.github.com/users/basyskom-jvoe/gists{/gist_id}","starred_url":"https://api.github.com/users/basyskom-jvoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basyskom-jvoe/subscriptions","organizations_url":"https://api.github.com/users/basyskom-jvoe/orgs","repos_url":"https://api.github.com/users/basyskom-jvoe/repos","events_url":"https://api.github.com/users/basyskom-jvoe/events{/privacy}","received_events_url":"https://api.github.com/users/basyskom-jvoe/received_events","type":"User","site_admin":false},"body":"This patch extends the nodeset compiler to support all possible attributes of the VariableType node class.\r\n\r\nUsing the DataType id from the xml description instead of BaseDataType causes an error when adding two nodes from Opc.Ua.NodeSet2.xml (i=17306 and i=17292 fail with \"AddNodes: The value is incompatible with the datatype of the VariableType\").\r\nBoth VariableType nodes use String as DataType attribute and are a subtype of i=16309. i=16309 has DataType i=862 which is a subtype of Struct.\r\n\r\nCould there be something wrong with the type checking in ua_services_nodemanagement.c?\r\nPage 30 of part 3 of the spec states \"The VariableType NodeClass also defines a set of Attributes that describe the default or initial value of its instance Variables\". Doesn't this imply that the DataType attribute can be changed in a variable instance?","created_at":"2018-05-28T07:57:46Z","updated_at":"2018-05-29T06:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41e77aa04902c08a0d7014331a476f0e3282da8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open62541/open62541/pulls/1810/commits","review_comments_url":"https://api.github.com/repos/open62541/open62541/pulls/1810/comments","review_comment_url":"https://api.github.com/repos/open62541/open62541/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open62541/open62541/issues/1810/comments","statuses_url":"https://api.github.com/repos/open62541/open62541/statuses/0c3fbe90318c524e2012888f0cab1929c19bd551","head":{"label":"basyskom-jvoe:nodesetcompiler-variabletype","ref":"nodesetcompiler-variabletype","sha":"0c3fbe90318c524e2012888f0cab1929c19bd551","user":{"login":"basyskom-jvoe","id":33348624,"avatar_url":"https://avatars2.githubusercontent.com/u/33348624?v=4","gravatar_id":"","url":"https://api.github.com/users/basyskom-jvoe","html_url":"https://github.com/basyskom-jvoe","followers_url":"https://api.github.com/users/basyskom-jvoe/followers","following_url":"https://api.github.com/users/basyskom-jvoe/following{/other_user}","gists_url":"https://api.github.com/users/basyskom-jvoe/gists{/gist_id}","starred_url":"https://api.github.com/users/basyskom-jvoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basyskom-jvoe/subscriptions","organizations_url":"https://api.github.com/users/basyskom-jvoe/orgs","repos_url":"https://api.github.com/users/basyskom-jvoe/repos","events_url":"https://api.github.com/users/basyskom-jvoe/events{/privacy}","received_events_url":"https://api.github.com/users/basyskom-jvoe/received_events","type":"User","site_admin":false},"repo":{"id":110235334,"name":"open62541","full_name":"basyskom-jvoe/open62541","owner":{"login":"basyskom-jvoe","id":33348624,"avatar_url":"https://avatars2.githubusercontent.com/u/33348624?v=4","gravatar_id":"","url":"https://api.github.com/users/basyskom-jvoe","html_url":"https://github.com/basyskom-jvoe","followers_url":"https://api.github.com/users/basyskom-jvoe/followers","following_url":"https://api.github.com/users/basyskom-jvoe/following{/other_user}","gists_url":"https://api.github.com/users/basyskom-jvoe/gists{/gist_id}","starred_url":"https://api.github.com/users/basyskom-jvoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basyskom-jvoe/subscriptions","organizations_url":"https://api.github.com/users/basyskom-jvoe/orgs","repos_url":"https://api.github.com/users/basyskom-jvoe/repos","events_url":"https://api.github.com/users/basyskom-jvoe/events{/privacy}","received_events_url":"https://api.github.com/users/basyskom-jvoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basyskom-jvoe/open62541","description":"Open source implementation of OPC UA (OPC Unified Architecture) aka IEC 62541 licensed under Mozilla Public License v2.0","fork":true,"url":"https://api.github.com/repos/basyskom-jvoe/open62541","forks_url":"https://api.github.com/repos/basyskom-jvoe/open62541/forks","keys_url":"https://api.github.com/repos/basyskom-jvoe/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basyskom-jvoe/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basyskom-jvoe/open62541/teams","hooks_url":"https://api.github.com/repos/basyskom-jvoe/open62541/hooks","issue_events_url":"https://api.github.com/repos/basyskom-jvoe/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/basyskom-jvoe/open62541/events","assignees_url":"https://api.github.com/repos/basyskom-jvoe/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/basyskom-jvoe/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/basyskom-jvoe/open62541/tags","blobs_url":"https://api.github.com/repos/basyskom-jvoe/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basyskom-jvoe/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basyskom-jvoe/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/basyskom-jvoe/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basyskom-jvoe/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/basyskom-jvoe/open62541/languages","stargazers_url":"https://api.github.com/repos/basyskom-jvoe/open62541/stargazers","contributors_url":"https://api.github.com/repos/basyskom-jvoe/open62541/contributors","subscribers_url":"https://api.github.com/repos/basyskom-jvoe/open62541/subscribers","subscription_url":"https://api.github.com/repos/basyskom-jvoe/open62541/subscription","commits_url":"https://api.github.com/repos/basyskom-jvoe/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/basyskom-jvoe/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/basyskom-jvoe/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/basyskom-jvoe/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/basyskom-jvoe/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/basyskom-jvoe/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basyskom-jvoe/open62541/merges","archive_url":"https://api.github.com/repos/basyskom-jvoe/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basyskom-jvoe/open62541/downloads","issues_url":"https://api.github.com/repos/basyskom-jvoe/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/basyskom-jvoe/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/basyskom-jvoe/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/basyskom-jvoe/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basyskom-jvoe/open62541/labels{/name}","releases_url":"https://api.github.com/repos/basyskom-jvoe/open62541/releases{/id}","deployments_url":"https://api.github.com/repos/basyskom-jvoe/open62541/deployments","created_at":"2017-11-10T10:33:35Z","updated_at":"2018-05-28T07:29:45Z","pushed_at":"2018-05-28T13:28:30Z","git_url":"git://github.com/basyskom-jvoe/open62541.git","ssh_url":"git@github.com:basyskom-jvoe/open62541.git","clone_url":"https://github.com/basyskom-jvoe/open62541.git","svn_url":"https://github.com/basyskom-jvoe/open62541","homepage":"http://open62541.org","size":15944,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open62541:master","ref":"master","sha":"6aeb2fddf6cd7fe3b167128a2929952381d30ed1","user":{"login":"open62541","id":16096536,"avatar_url":"https://avatars1.githubusercontent.com/u/16096536?v=4","gravatar_id":"","url":"https://api.github.com/users/open62541","html_url":"https://github.com/open62541","followers_url":"https://api.github.com/users/open62541/followers","following_url":"https://api.github.com/users/open62541/following{/other_user}","gists_url":"https://api.github.com/users/open62541/gists{/gist_id}","starred_url":"https://api.github.com/users/open62541/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open62541/subscriptions","organizations_url":"https://api.github.com/users/open62541/orgs","repos_url":"https://api.github.com/users/open62541/repos","events_url":"https://api.github.com/users/open62541/events{/privacy}","received_events_url":"https://api.github.com/users/open62541/received_events","type":"Organization","site_admin":false},"repo":{"id":15333809,"name":"open62541","full_name":"open62541/open62541","owner":{"login":"open62541","id":16096536,"avatar_url":"https://avatars1.githubusercontent.com/u/16096536?v=4","gravatar_id":"","url":"https://api.github.com/users/open62541","html_url":"https://github.com/open62541","followers_url":"https://api.github.com/users/open62541/followers","following_url":"https://api.github.com/users/open62541/following{/other_user}","gists_url":"https://api.github.com/users/open62541/gists{/gist_id}","starred_url":"https://api.github.com/users/open62541/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open62541/subscriptions","organizations_url":"https://api.github.com/users/open62541/orgs","repos_url":"https://api.github.com/users/open62541/repos","events_url":"https://api.github.com/users/open62541/events{/privacy}","received_events_url":"https://api.github.com/users/open62541/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open62541/open62541","description":"Open source implementation of OPC UA (OPC Unified Architecture) aka IEC 62541 licensed under Mozilla Public License v2.0","fork":false,"url":"https://api.github.com/repos/open62541/open62541","forks_url":"https://api.github.com/repos/open62541/open62541/forks","keys_url":"https://api.github.com/repos/open62541/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open62541/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open62541/open62541/teams","hooks_url":"https://api.github.com/repos/open62541/open62541/hooks","issue_events_url":"https://api.github.com/repos/open62541/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/open62541/open62541/events","assignees_url":"https://api.github.com/repos/open62541/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/open62541/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/open62541/open62541/tags","blobs_url":"https://api.github.com/repos/open62541/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open62541/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open62541/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/open62541/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open62541/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/open62541/open62541/languages","stargazers_url":"https://api.github.com/repos/open62541/open62541/stargazers","contributors_url":"https://api.github.com/repos/open62541/open62541/contributors","subscribers_url":"https://api.github.com/repos/open62541/open62541/subscribers","subscription_url":"https://api.github.com/repos/open62541/open62541/subscription","commits_url":"https://api.github.com/repos/open62541/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/open62541/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/open62541/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/open62541/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/open62541/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/open62541/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open62541/open62541/merges","archive_url":"https://api.github.com/repos/open62541/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open62541/open62541/downloads","issues_url":"https://api.github.com/repos/open62541/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/open62541/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/open62541/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/open62541/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open62541/open62541/labels{/name}","releases_url":"https://api.github.com/repos/open62541/open62541/releases{/id}","deployments_url":"https://api.github.com/repos/open62541/open62541/deployments","created_at":"2013-12-20T08:45:05Z","updated_at":"2018-05-28T18:11:06Z","pushed_at":"2018-05-28T18:39:24Z","git_url":"git://github.com/open62541/open62541.git","ssh_url":"git@github.com:open62541/open62541.git","clone_url":"https://github.com/open62541/open62541.git","svn_url":"https://github.com/open62541/open62541","homepage":"http://open62541.org","size":15995,"stargazers_count":443,"watchers_count":443,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":249,"open_issues":96,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open62541/open62541/pulls/1810"},"html":{"href":"https://github.com/open62541/open62541/pull/1810"},"issue":{"href":"https://api.github.com/repos/open62541/open62541/issues/1810"},"comments":{"href":"https://api.github.com/repos/open62541/open62541/issues/1810/comments"},"review_comments":{"href":"https://api.github.com/repos/open62541/open62541/pulls/1810/comments"},"review_comment":{"href":"https://api.github.com/repos/open62541/open62541/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open62541/open62541/pulls/1810/commits"},"statuses":{"href":"https://api.github.com/repos/open62541/open62541/statuses/0c3fbe90318c524e2012888f0cab1929c19bd551"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15333809,
"name": "open62541/open62541",
"url": "https://api.github.com/repos/open62541/open62541"
} | {
"id": 33348624,
"login": "basyskom-jvoe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33348624?",
"url": "https://api.github.com/users/basyskom-jvoe"
} | {
"id": 16096536,
"login": "open62541",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16096536?",
"url": "https://api.github.com/orgs/open62541"
} | 2018-05-29T06:28:26 | 7741569584 | {"actor":{"display_login":"basyskom-jvoe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments/171509842","pull_request_review_id":100371451,"id":171509842,"diff_hunk":"@@ -0,0 +1,7 @@\n+package uk.gov.justice.raml.jms.interceptor;\n+\n+public interface EventFilterConstants {","path":"generators/messaging-adapter-generator/src/main/java/uk/gov/justice/raml/jms/interceptor/EventFilterConstants.java","position":3,"original_position":3,"commit_id":"c2e6c622e50de969c5abfaed237e5a1bd831621e","original_commit_id":"c2e6c622e50de969c5abfaed237e5a1bd831621e","user":{"login":"cjs-common-platform-ci","id":17479508,"avatar_url":"https://avatars2.githubusercontent.com/u/17479508?v=4","gravatar_id":"","url":"https://api.github.com/users/cjs-common-platform-ci","html_url":"https://github.com/cjs-common-platform-ci","followers_url":"https://api.github.com/users/cjs-common-platform-ci/followers","following_url":"https://api.github.com/users/cjs-common-platform-ci/following{/other_user}","gists_url":"https://api.github.com/users/cjs-common-platform-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/cjs-common-platform-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjs-common-platform-ci/subscriptions","organizations_url":"https://api.github.com/users/cjs-common-platform-ci/orgs","repos_url":"https://api.github.com/users/cjs-common-platform-ci/repos","events_url":"https://api.github.com/users/cjs-common-platform-ci/events{/privacy}","received_events_url":"https://api.github.com/users/cjs-common-platform-ci/received_events","type":"User","site_admin":false},"body":" Move constants to a class or enum. [](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1214)\n","created_at":"2018-03-01T09:59:10Z","updated_at":"2018-03-01T09:59:10Z","html_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551#discussion_r171509842","pull_request_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments/171509842"},"html":{"href":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551#discussion_r171509842"},"pull_request":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551","id":172186713,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551","diff_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551.diff","patch_url":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551.patch","issue_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/551","number":551,"state":"open","locked":false,"title":"Add message adapter generator support for multiple event listeners","user":{"login":"mapingo","id":11291215,"avatar_url":"https://avatars3.githubusercontent.com/u/11291215?v=4","gravatar_id":"","url":"https://api.github.com/users/mapingo","html_url":"https://github.com/mapingo","followers_url":"https://api.github.com/users/mapingo/followers","following_url":"https://api.github.com/users/mapingo/following{/other_user}","gists_url":"https://api.github.com/users/mapingo/gists{/gist_id}","starred_url":"https://api.github.com/users/mapingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapingo/subscriptions","organizations_url":"https://api.github.com/users/mapingo/orgs","repos_url":"https://api.github.com/users/mapingo/repos","events_url":"https://api.github.com/users/mapingo/events{/privacy}","received_events_url":"https://api.github.com/users/mapingo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-01T09:44:57Z","updated_at":"2018-03-01T09:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e01459030589122d87e50acac700e4d70bae167","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551/commits","review_comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551/comments","review_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/551/comments","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/c2e6c622e50de969c5abfaed237e5a1bd831621e","head":{"label":"CJSCommonPlatform:multi-listener-fix","ref":"multi-listener-fix","sha":"c2e6c622e50de969c5abfaed237e5a1bd831621e","user":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars3.githubusercontent.com/u/16131145?v=4","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":51292541,"name":"microservice_framework","full_name":"CJSCommonPlatform/microservice_framework","owner":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars3.githubusercontent.com/u/16131145?v=4","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework","description":"A Java framework to support applications utilising CQRS and Event Sourcing architectures","fork":false,"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework","forks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/forks","keys_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/teams","hooks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/hooks","issue_events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/events{/number}","events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/events","assignees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/assignees{/user}","branches_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/branches{/branch}","tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/tags","blobs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/{sha}","languages_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/languages","stargazers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/stargazers","contributors_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contributors","subscribers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscribers","subscription_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscription","commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contents/{+path}","compare_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/merges","archive_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/downloads","issues_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues{/number}","pulls_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls{/number}","milestones_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/milestones{/number}","notifications_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/labels{/name}","releases_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/releases{/id}","deployments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/deployments","created_at":"2016-02-08T10:51:31Z","updated_at":"2018-02-23T12:29:56Z","pushed_at":"2018-03-01T09:44:58Z","git_url":"git://github.com/CJSCommonPlatform/microservice_framework.git","ssh_url":"git@github.com:CJSCommonPlatform/microservice_framework.git","clone_url":"https://github.com/CJSCommonPlatform/microservice_framework.git","svn_url":"https://github.com/CJSCommonPlatform/microservice_framework","homepage":"","size":8773,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":26,"open_issues":23,"watchers":20,"default_branch":"master"}},"base":{"label":"CJSCommonPlatform:master","ref":"master","sha":"ef0eb0c1ddfcffd1051acfefde3d0dd923f6d1a0","user":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars3.githubusercontent.com/u/16131145?v=4","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":51292541,"name":"microservice_framework","full_name":"CJSCommonPlatform/microservice_framework","owner":{"login":"CJSCommonPlatform","id":16131145,"avatar_url":"https://avatars3.githubusercontent.com/u/16131145?v=4","gravatar_id":"","url":"https://api.github.com/users/CJSCommonPlatform","html_url":"https://github.com/CJSCommonPlatform","followers_url":"https://api.github.com/users/CJSCommonPlatform/followers","following_url":"https://api.github.com/users/CJSCommonPlatform/following{/other_user}","gists_url":"https://api.github.com/users/CJSCommonPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/CJSCommonPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJSCommonPlatform/subscriptions","organizations_url":"https://api.github.com/users/CJSCommonPlatform/orgs","repos_url":"https://api.github.com/users/CJSCommonPlatform/repos","events_url":"https://api.github.com/users/CJSCommonPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/CJSCommonPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CJSCommonPlatform/microservice_framework","description":"A Java framework to support applications utilising CQRS and Event Sourcing architectures","fork":false,"url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework","forks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/forks","keys_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/teams","hooks_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/hooks","issue_events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/events{/number}","events_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/events","assignees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/assignees{/user}","branches_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/branches{/branch}","tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/tags","blobs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/{sha}","languages_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/languages","stargazers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/stargazers","contributors_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contributors","subscribers_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscribers","subscription_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/subscription","commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/contents/{+path}","compare_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/merges","archive_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/downloads","issues_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues{/number}","pulls_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls{/number}","milestones_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/milestones{/number}","notifications_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/labels{/name}","releases_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/releases{/id}","deployments_url":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/deployments","created_at":"2016-02-08T10:51:31Z","updated_at":"2018-02-23T12:29:56Z","pushed_at":"2018-03-01T09:44:58Z","git_url":"git://github.com/CJSCommonPlatform/microservice_framework.git","ssh_url":"git@github.com:CJSCommonPlatform/microservice_framework.git","clone_url":"https://github.com/CJSCommonPlatform/microservice_framework.git","svn_url":"https://github.com/CJSCommonPlatform/microservice_framework","homepage":"","size":8773,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":26,"open_issues":23,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551"},"html":{"href":"https://github.com/CJSCommonPlatform/microservice_framework/pull/551"},"issue":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/551"},"comments":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/CJSCommonPlatform/microservice_framework/statuses/c2e6c622e50de969c5abfaed237e5a1bd831621e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51292541,
"name": "CJSCommonPlatform/microservice_framework",
"url": "https://api.github.com/repos/CJSCommonPlatform/microservice_framework"
} | {
"id": 17479508,
"login": "cjs-common-platform-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17479508?",
"url": "https://api.github.com/users/cjs-common-platform-ci"
} | {
"id": 16131145,
"login": "CJSCommonPlatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16131145?",
"url": "https://api.github.com/orgs/CJSCommonPlatform"
} | 2018-03-01T09:59:10 | 7315132475 | {"actor":{"display_login":"cjs-common-platform-ci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/216905759","pull_request_review_id":154494594,"id":216905759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjkwNTc1OQ==","diff_hunk":"@@ -85,7 +85,7 @@ void Slaac::UpdateAddresses(otInstance * aInstance,\n }\n }\n \n- if (!found)","path":"src/core/utils/slaac_address.cpp","position":4,"original_position":4,"commit_id":"d0953479f7d3d14857eb51e44bfecf4ad4e20637","original_commit_id":"d0953479f7d3d14857eb51e44bfecf4ad4e20637","user":{"login":"marcoster","id":4045424,"node_id":"MDQ6VXNlcjQwNDU0MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4045424?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoster","html_url":"https://github.com/marcoster","followers_url":"https://api.github.com/users/marcoster/followers","following_url":"https://api.github.com/users/marcoster/following{/other_user}","gists_url":"https://api.github.com/users/marcoster/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoster/subscriptions","organizations_url":"https://api.github.com/users/marcoster/orgs","repos_url":"https://api.github.com/users/marcoster/repos","events_url":"https://api.github.com/users/marcoster/events{/privacy}","received_events_url":"https://api.github.com/users/marcoster/received_events","type":"User","site_admin":false},"body":"Sorry - I just took a look at the upstream code again - guess my problem is fixed by the addition of\r\n*otIp6AddUnicastAddress(aInstance, address)* in line 119 - missed that.","created_at":"2018-09-12T06:04:32Z","updated_at":"2018-09-12T06:04:32Z","html_url":"https://github.com/openthread/openthread/pull/3069#discussion_r216905759","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/3069","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/216905759"},"html":{"href":"https://github.com/openthread/openthread/pull/3069#discussion_r216905759"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/3069"}},"in_reply_to_id":216903136},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/3069","id":214837893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODM3ODkz","html_url":"https://github.com/openthread/openthread/pull/3069","diff_url":"https://github.com/openthread/openthread/pull/3069.diff","patch_url":"https://github.com/openthread/openthread/pull/3069.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/3069","number":3069,"state":"open","locked":false,"title":"slaac-utility: remove addresses properly","user":{"login":"marcoster","id":4045424,"node_id":"MDQ6VXNlcjQwNDU0MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4045424?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoster","html_url":"https://github.com/marcoster","followers_url":"https://api.github.com/users/marcoster/followers","following_url":"https://api.github.com/users/marcoster/following{/other_user}","gists_url":"https://api.github.com/users/marcoster/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoster/subscriptions","organizations_url":"https://api.github.com/users/marcoster/orgs","repos_url":"https://api.github.com/users/marcoster/repos","events_url":"https://api.github.com/users/marcoster/events{/privacy}","received_events_url":"https://api.github.com/users/marcoster/received_events","type":"User","site_admin":false},"body":"This commit fixes the removeal of slaac-addresses in Slaac::UpdateAddresses.\r\nWhen a address now matches a prefix, it is properly removed.","created_at":"2018-09-12T05:15:26Z","updated_at":"2018-09-12T06:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b8ef98d40d9293a8b91b51878a77f74ff7ac2a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/3069/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/3069/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/3069/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/d0953479f7d3d14857eb51e44bfecf4ad4e20637","head":{"label":"marcoster:slaac_fix","ref":"slaac_fix","sha":"d0953479f7d3d14857eb51e44bfecf4ad4e20637","user":{"login":"marcoster","id":4045424,"node_id":"MDQ6VXNlcjQwNDU0MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4045424?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoster","html_url":"https://github.com/marcoster","followers_url":"https://api.github.com/users/marcoster/followers","following_url":"https://api.github.com/users/marcoster/following{/other_user}","gists_url":"https://api.github.com/users/marcoster/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoster/subscriptions","organizations_url":"https://api.github.com/users/marcoster/orgs","repos_url":"https://api.github.com/users/marcoster/repos","events_url":"https://api.github.com/users/marcoster/events{/privacy}","received_events_url":"https://api.github.com/users/marcoster/received_events","type":"User","site_admin":false},"repo":{"id":148309167,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMDkxNjc=","name":"openthread","full_name":"marcoster/openthread","owner":{"login":"marcoster","id":4045424,"node_id":"MDQ6VXNlcjQwNDU0MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4045424?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoster","html_url":"https://github.com/marcoster","followers_url":"https://api.github.com/users/marcoster/followers","following_url":"https://api.github.com/users/marcoster/following{/other_user}","gists_url":"https://api.github.com/users/marcoster/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoster/subscriptions","organizations_url":"https://api.github.com/users/marcoster/orgs","repos_url":"https://api.github.com/users/marcoster/repos","events_url":"https://api.github.com/users/marcoster/events{/privacy}","received_events_url":"https://api.github.com/users/marcoster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcoster/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/marcoster/openthread","forks_url":"https://api.github.com/repos/marcoster/openthread/forks","keys_url":"https://api.github.com/repos/marcoster/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcoster/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcoster/openthread/teams","hooks_url":"https://api.github.com/repos/marcoster/openthread/hooks","issue_events_url":"https://api.github.com/repos/marcoster/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/marcoster/openthread/events","assignees_url":"https://api.github.com/repos/marcoster/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/marcoster/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/marcoster/openthread/tags","blobs_url":"https://api.github.com/repos/marcoster/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcoster/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcoster/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcoster/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcoster/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/marcoster/openthread/languages","stargazers_url":"https://api.github.com/repos/marcoster/openthread/stargazers","contributors_url":"https://api.github.com/repos/marcoster/openthread/contributors","subscribers_url":"https://api.github.com/repos/marcoster/openthread/subscribers","subscription_url":"https://api.github.com/repos/marcoster/openthread/subscription","commits_url":"https://api.github.com/repos/marcoster/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcoster/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcoster/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcoster/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcoster/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/marcoster/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcoster/openthread/merges","archive_url":"https://api.github.com/repos/marcoster/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcoster/openthread/downloads","issues_url":"https://api.github.com/repos/marcoster/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/marcoster/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/marcoster/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/marcoster/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcoster/openthread/labels{/name}","releases_url":"https://api.github.com/repos/marcoster/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/marcoster/openthread/deployments","created_at":"2018-09-11T11:49:34Z","updated_at":"2018-09-11T11:49:39Z","pushed_at":"2018-09-12T05:12:35Z","git_url":"git://github.com/marcoster/openthread.git","ssh_url":"git@github.com:marcoster/openthread.git","clone_url":"https://github.com/marcoster/openthread.git","svn_url":"https://github.com/marcoster/openthread","homepage":"","size":52917,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"c4f44ae0cae10fb09990435a7e74024b9717dd4b","user":{"login":"openthread","id":16142269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTQyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/16142269?v=4","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"node_id":"MDEwOlJlcG9zaXRvcnk1NTgwODc4Nw==","name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTQyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/16142269?v=4","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2018-09-12T00:57:04Z","pushed_at":"2018-09-12T05:47:32Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":52921,"stargazers_count":1647,"watchers_count":1647,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":487,"open_issues":51,"watchers":1647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/3069"},"html":{"href":"https://github.com/openthread/openthread/pull/3069"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/3069"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/3069/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/3069/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/3069/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/d0953479f7d3d14857eb51e44bfecf4ad4e20637"}},"author_association":"NONE"}} | {
"id": 55808787,
"name": "openthread/openthread",
"url": "https://api.github.com/repos/openthread/openthread"
} | {
"id": 4045424,
"login": "marcoster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4045424?",
"url": "https://api.github.com/users/marcoster"
} | {
"id": 16142269,
"login": "openthread",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16142269?",
"url": "https://api.github.com/orgs/openthread"
} | 2018-09-12T06:04:32 | 8250991989 | {"actor":{"display_login":"marcoster"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/comments/170437762","pull_request_review_id":99128415,"id":170437762,"diff_hunk":"@@ -38,17 +38,21 @@\n static int build_url (char **url, const char *host, int port, const char *path)\n {\n int len;\n+ char *tmp;\n \n assert (url != NULL);\n assert (host != NULL);\n assert (port > 0 && port < 32768);\n assert (path != NULL);\n \n len = strlen (host) + strlen (path) + 14;\n- *url = (char *) safemalloc (len);\n- if (*url == NULL)\n+ \n+ tmp = (char *) saferealloc (*url, len);","path":"src/transparent-proxy.c","position":15,"original_position":15,"commit_id":"e077819626b31be31ca9eaef7962a186682c3691","original_commit_id":"e077819626b31be31ca9eaef7962a186682c3691","user":{"login":"bertliao","id":36528160,"avatar_url":"https://avatars1.githubusercontent.com/u/36528160?v=4","gravatar_id":"","url":"https://api.github.com/users/bertliao","html_url":"https://github.com/bertliao","followers_url":"https://api.github.com/users/bertliao/followers","following_url":"https://api.github.com/users/bertliao/following{/other_user}","gists_url":"https://api.github.com/users/bertliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bertliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertliao/subscriptions","organizations_url":"https://api.github.com/users/bertliao/orgs","repos_url":"https://api.github.com/users/bertliao/repos","events_url":"https://api.github.com/users/bertliao/events{/privacy}","received_events_url":"https://api.github.com/users/bertliao/received_events","type":"User","site_admin":false},"body":"The temporary var is not necessary\r\n`*url = (char *) saferealloc (*url, len);`\r\n\r\nEnv:\r\nOpenwrt/Linux 3.3.8, uClibc-0.9.33.2, MIPS/x86","created_at":"2018-02-25T00:52:55Z","updated_at":"2018-02-25T00:52:55Z","html_url":"https://github.com/tinyproxy/tinyproxy/pull/142#discussion_r170437762","pull_request_url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/comments/170437762"},"html":{"href":"https://github.com/tinyproxy/tinyproxy/pull/142#discussion_r170437762"},"pull_request":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142"}},"in_reply_to_id":170170476},"pull_request":{"url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142","id":170934928,"html_url":"https://github.com/tinyproxy/tinyproxy/pull/142","diff_url":"https://github.com/tinyproxy/tinyproxy/pull/142.diff","patch_url":"https://github.com/tinyproxy/tinyproxy/pull/142.patch","issue_url":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/142","number":142,"state":"open","locked":false,"title":"Fix 2 memory leak for #141","user":{"login":"bertliao","id":36528160,"avatar_url":"https://avatars1.githubusercontent.com/u/36528160?v=4","gravatar_id":"","url":"https://api.github.com/users/bertliao","html_url":"https://github.com/bertliao","followers_url":"https://api.github.com/users/bertliao/followers","following_url":"https://api.github.com/users/bertliao/following{/other_user}","gists_url":"https://api.github.com/users/bertliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bertliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertliao/subscriptions","organizations_url":"https://api.github.com/users/bertliao/orgs","repos_url":"https://api.github.com/users/bertliao/repos","events_url":"https://api.github.com/users/bertliao/events{/privacy}","received_events_url":"https://api.github.com/users/bertliao/received_events","type":"User","site_admin":false},"body":"Fix 2 memory leak for #141","created_at":"2018-02-23T05:18:48Z","updated_at":"2018-02-25T00:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ad00f0f28cf3a0277c87ae2c079eb18e332077","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142/commits","review_comments_url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142/comments","review_comment_url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/142/comments","statuses_url":"https://api.github.com/repos/tinyproxy/tinyproxy/statuses/e077819626b31be31ca9eaef7962a186682c3691","head":{"label":"bertliao:memoryleak","ref":"memoryleak","sha":"e077819626b31be31ca9eaef7962a186682c3691","user":{"login":"bertliao","id":36528160,"avatar_url":"https://avatars1.githubusercontent.com/u/36528160?v=4","gravatar_id":"","url":"https://api.github.com/users/bertliao","html_url":"https://github.com/bertliao","followers_url":"https://api.github.com/users/bertliao/followers","following_url":"https://api.github.com/users/bertliao/following{/other_user}","gists_url":"https://api.github.com/users/bertliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bertliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertliao/subscriptions","organizations_url":"https://api.github.com/users/bertliao/orgs","repos_url":"https://api.github.com/users/bertliao/repos","events_url":"https://api.github.com/users/bertliao/events{/privacy}","received_events_url":"https://api.github.com/users/bertliao/received_events","type":"User","site_admin":false},"repo":{"id":122471007,"name":"tinyproxy","full_name":"bertliao/tinyproxy","owner":{"login":"bertliao","id":36528160,"avatar_url":"https://avatars1.githubusercontent.com/u/36528160?v=4","gravatar_id":"","url":"https://api.github.com/users/bertliao","html_url":"https://github.com/bertliao","followers_url":"https://api.github.com/users/bertliao/followers","following_url":"https://api.github.com/users/bertliao/following{/other_user}","gists_url":"https://api.github.com/users/bertliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bertliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertliao/subscriptions","organizations_url":"https://api.github.com/users/bertliao/orgs","repos_url":"https://api.github.com/users/bertliao/repos","events_url":"https://api.github.com/users/bertliao/events{/privacy}","received_events_url":"https://api.github.com/users/bertliao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bertliao/tinyproxy","description":"tinyproxy - a light-weight HTTP/HTTPS proxy daemon for POSIX operating systems","fork":true,"url":"https://api.github.com/repos/bertliao/tinyproxy","forks_url":"https://api.github.com/repos/bertliao/tinyproxy/forks","keys_url":"https://api.github.com/repos/bertliao/tinyproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bertliao/tinyproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bertliao/tinyproxy/teams","hooks_url":"https://api.github.com/repos/bertliao/tinyproxy/hooks","issue_events_url":"https://api.github.com/repos/bertliao/tinyproxy/issues/events{/number}","events_url":"https://api.github.com/repos/bertliao/tinyproxy/events","assignees_url":"https://api.github.com/repos/bertliao/tinyproxy/assignees{/user}","branches_url":"https://api.github.com/repos/bertliao/tinyproxy/branches{/branch}","tags_url":"https://api.github.com/repos/bertliao/tinyproxy/tags","blobs_url":"https://api.github.com/repos/bertliao/tinyproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bertliao/tinyproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bertliao/tinyproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bertliao/tinyproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bertliao/tinyproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/bertliao/tinyproxy/languages","stargazers_url":"https://api.github.com/repos/bertliao/tinyproxy/stargazers","contributors_url":"https://api.github.com/repos/bertliao/tinyproxy/contributors","subscribers_url":"https://api.github.com/repos/bertliao/tinyproxy/subscribers","subscription_url":"https://api.github.com/repos/bertliao/tinyproxy/subscription","commits_url":"https://api.github.com/repos/bertliao/tinyproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bertliao/tinyproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bertliao/tinyproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bertliao/tinyproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bertliao/tinyproxy/contents/{+path}","compare_url":"https://api.github.com/repos/bertliao/tinyproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bertliao/tinyproxy/merges","archive_url":"https://api.github.com/repos/bertliao/tinyproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bertliao/tinyproxy/downloads","issues_url":"https://api.github.com/repos/bertliao/tinyproxy/issues{/number}","pulls_url":"https://api.github.com/repos/bertliao/tinyproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/bertliao/tinyproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/bertliao/tinyproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bertliao/tinyproxy/labels{/name}","releases_url":"https://api.github.com/repos/bertliao/tinyproxy/releases{/id}","deployments_url":"https://api.github.com/repos/bertliao/tinyproxy/deployments","created_at":"2018-02-22T11:42:14Z","updated_at":"2018-02-22T11:42:16Z","pushed_at":"2018-02-23T04:28:39Z","git_url":"git://github.com/bertliao/tinyproxy.git","ssh_url":"git@github.com:bertliao/tinyproxy.git","clone_url":"https://github.com/bertliao/tinyproxy.git","svn_url":"https://github.com/bertliao/tinyproxy","homepage":null,"size":1718,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tinyproxy:master","ref":"master","sha":"9acb0cb16cb65a554c5443f0409f827390379249","user":{"login":"tinyproxy","id":16191467,"avatar_url":"https://avatars1.githubusercontent.com/u/16191467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyproxy","html_url":"https://github.com/tinyproxy","followers_url":"https://api.github.com/users/tinyproxy/followers","following_url":"https://api.github.com/users/tinyproxy/following{/other_user}","gists_url":"https://api.github.com/users/tinyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyproxy/subscriptions","organizations_url":"https://api.github.com/users/tinyproxy/orgs","repos_url":"https://api.github.com/users/tinyproxy/repos","events_url":"https://api.github.com/users/tinyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/tinyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":47556049,"name":"tinyproxy","full_name":"tinyproxy/tinyproxy","owner":{"login":"tinyproxy","id":16191467,"avatar_url":"https://avatars1.githubusercontent.com/u/16191467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyproxy","html_url":"https://github.com/tinyproxy","followers_url":"https://api.github.com/users/tinyproxy/followers","following_url":"https://api.github.com/users/tinyproxy/following{/other_user}","gists_url":"https://api.github.com/users/tinyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyproxy/subscriptions","organizations_url":"https://api.github.com/users/tinyproxy/orgs","repos_url":"https://api.github.com/users/tinyproxy/repos","events_url":"https://api.github.com/users/tinyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/tinyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tinyproxy/tinyproxy","description":"tinyproxy - a light-weight HTTP/HTTPS proxy daemon for POSIX operating systems","fork":false,"url":"https://api.github.com/repos/tinyproxy/tinyproxy","forks_url":"https://api.github.com/repos/tinyproxy/tinyproxy/forks","keys_url":"https://api.github.com/repos/tinyproxy/tinyproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinyproxy/tinyproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinyproxy/tinyproxy/teams","hooks_url":"https://api.github.com/repos/tinyproxy/tinyproxy/hooks","issue_events_url":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/events{/number}","events_url":"https://api.github.com/repos/tinyproxy/tinyproxy/events","assignees_url":"https://api.github.com/repos/tinyproxy/tinyproxy/assignees{/user}","branches_url":"https://api.github.com/repos/tinyproxy/tinyproxy/branches{/branch}","tags_url":"https://api.github.com/repos/tinyproxy/tinyproxy/tags","blobs_url":"https://api.github.com/repos/tinyproxy/tinyproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinyproxy/tinyproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinyproxy/tinyproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinyproxy/tinyproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinyproxy/tinyproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/tinyproxy/tinyproxy/languages","stargazers_url":"https://api.github.com/repos/tinyproxy/tinyproxy/stargazers","contributors_url":"https://api.github.com/repos/tinyproxy/tinyproxy/contributors","subscribers_url":"https://api.github.com/repos/tinyproxy/tinyproxy/subscribers","subscription_url":"https://api.github.com/repos/tinyproxy/tinyproxy/subscription","commits_url":"https://api.github.com/repos/tinyproxy/tinyproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinyproxy/tinyproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinyproxy/tinyproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinyproxy/tinyproxy/contents/{+path}","compare_url":"https://api.github.com/repos/tinyproxy/tinyproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinyproxy/tinyproxy/merges","archive_url":"https://api.github.com/repos/tinyproxy/tinyproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinyproxy/tinyproxy/downloads","issues_url":"https://api.github.com/repos/tinyproxy/tinyproxy/issues{/number}","pulls_url":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/tinyproxy/tinyproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/tinyproxy/tinyproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinyproxy/tinyproxy/labels{/name}","releases_url":"https://api.github.com/repos/tinyproxy/tinyproxy/releases{/id}","deployments_url":"https://api.github.com/repos/tinyproxy/tinyproxy/deployments","created_at":"2015-12-07T14:11:44Z","updated_at":"2018-02-24T08:39:10Z","pushed_at":"2018-02-24T17:18:58Z","git_url":"git://github.com/tinyproxy/tinyproxy.git","ssh_url":"git@github.com:tinyproxy/tinyproxy.git","clone_url":"https://github.com/tinyproxy/tinyproxy.git","svn_url":"https://github.com/tinyproxy/tinyproxy","homepage":null,"size":1718,"stargazers_count":898,"watchers_count":898,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":194,"open_issues":73,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142"},"html":{"href":"https://github.com/tinyproxy/tinyproxy/pull/142"},"issue":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/142"},"comments":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/tinyproxy/tinyproxy/statuses/e077819626b31be31ca9eaef7962a186682c3691"}},"author_association":"NONE"}} | {
"id": 47556049,
"name": "tinyproxy/tinyproxy",
"url": "https://api.github.com/repos/tinyproxy/tinyproxy"
} | {
"id": 36528160,
"login": "bertliao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36528160?",
"url": "https://api.github.com/users/bertliao"
} | {
"id": 16191467,
"login": "tinyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16191467?",
"url": "https://api.github.com/orgs/tinyproxy"
} | 2018-02-25T00:52:55 | 7292427548 | {"actor":{"display_login":"bertliao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/comments/172399000","pull_request_review_id":101407601,"id":172399000,"diff_hunk":"@@ -77,12 +77,18 @@ cd $BUILDDIR/$ARCH\n \n # =========== libicuXX.so ===========\n \n-[ -e libicuuc.so ] || {\n+[ -e libicuuc$LIBSUFFIX.so ] || {\n \n \t[ -e ../icu4c-55_1-src.tgz ] || exit 1\n \n \ttar xvf ../icu4c-55_1-src.tgz\n \n+\t# The ENVVAR LIBSUFFIX should add the suffix only to the libname and not to the symbols.\n+\t# ToDo: Find the right way in Swift to refer to an alternative library with symbol prefixing or any other method to remove this.\n+\tif $[ -n \"$LIBSUFFIX\" ]; then","path":"build.sh","position":13,"original_position":13,"commit_id":"f843f77bd11290c274c8d3d2bc9342d6eaa6643a","original_commit_id":"f843f77bd11290c274c8d3d2bc9342d6eaa6643a","user":{"login":"AndrewSB","id":3814772,"avatar_url":"https://avatars1.githubusercontent.com/u/3814772?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewSB","html_url":"https://github.com/AndrewSB","followers_url":"https://api.github.com/users/AndrewSB/followers","following_url":"https://api.github.com/users/AndrewSB/following{/other_user}","gists_url":"https://api.github.com/users/AndrewSB/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewSB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewSB/subscriptions","organizations_url":"https://api.github.com/users/AndrewSB/orgs","repos_url":"https://api.github.com/users/AndrewSB/repos","events_url":"https://api.github.com/users/AndrewSB/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewSB/received_events","type":"User","site_admin":false},"body":"@gonzalolarralde is the `$` in front of the `[]` supposed to be here? This line is failing on my machine","created_at":"2018-03-06T03:17:01Z","updated_at":"2018-03-06T03:17:01Z","html_url":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7#discussion_r172399000","pull_request_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/comments/172399000"},"html":{"href":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7#discussion_r172399000"},"pull_request":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7","id":169135055,"html_url":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7","diff_url":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7.diff","patch_url":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7.patch","issue_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/7","number":7,"state":"closed","locked":false,"title":"Add an ENVVAR to append a suffix to the lib names.","user":{"login":"gonzalolarralde","id":132825,"avatar_url":"https://avatars1.githubusercontent.com/u/132825?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzalolarralde","html_url":"https://github.com/gonzalolarralde","followers_url":"https://api.github.com/users/gonzalolarralde/followers","following_url":"https://api.github.com/users/gonzalolarralde/following{/other_user}","gists_url":"https://api.github.com/users/gonzalolarralde/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalolarralde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalolarralde/subscriptions","organizations_url":"https://api.github.com/users/gonzalolarralde/orgs","repos_url":"https://api.github.com/users/gonzalolarralde/repos","events_url":"https://api.github.com/users/gonzalolarralde/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalolarralde/received_events","type":"User","site_admin":false},"body":"Swift is expecting this libraries to be named `icuucswift` for Android to avoid name collision with Android's `icuuc`.\r\n\r\nThis should be temporal, a more appropriate solution (if any) should be applied to solve this lib conflict.\r\n\r\nWith this patch now the expected set of libraries can be created by just calling `env LIBSUFFIX=swift ./build.sh`, avoiding a complicated set of setps detailed in Swift's `Android.md`. If this or any other change to reduce the impact of this requirement is merged I'll update the docs in `Android.md`.\r\n\r\nThe change is additive, when used as before (just calling `build.sh`) it shouldn't produce any different outcome.","created_at":"2018-02-14T15:08:29Z","updated_at":"2018-03-06T03:17:01Z","closed_at":"2018-03-04T00:20:53Z","merged_at":"2018-03-04T00:20:53Z","merge_commit_sha":"4bc78f4646bd54f71fa5fd13322b8ab1e8fe9d2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7/commits","review_comments_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7/comments","review_comment_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/7/comments","statuses_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/statuses/f843f77bd11290c274c8d3d2bc9342d6eaa6643a","head":{"label":"gonzalolarralde:libsuffix","ref":"libsuffix","sha":"f843f77bd11290c274c8d3d2bc9342d6eaa6643a","user":{"login":"gonzalolarralde","id":132825,"avatar_url":"https://avatars1.githubusercontent.com/u/132825?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzalolarralde","html_url":"https://github.com/gonzalolarralde","followers_url":"https://api.github.com/users/gonzalolarralde/followers","following_url":"https://api.github.com/users/gonzalolarralde/following{/other_user}","gists_url":"https://api.github.com/users/gonzalolarralde/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalolarralde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalolarralde/subscriptions","organizations_url":"https://api.github.com/users/gonzalolarralde/orgs","repos_url":"https://api.github.com/users/gonzalolarralde/repos","events_url":"https://api.github.com/users/gonzalolarralde/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalolarralde/received_events","type":"User","site_admin":false},"repo":{"id":65271528,"name":"libiconv-libicu-android","full_name":"gonzalolarralde/libiconv-libicu-android","owner":{"login":"gonzalolarralde","id":132825,"avatar_url":"https://avatars1.githubusercontent.com/u/132825?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzalolarralde","html_url":"https://github.com/gonzalolarralde","followers_url":"https://api.github.com/users/gonzalolarralde/followers","following_url":"https://api.github.com/users/gonzalolarralde/following{/other_user}","gists_url":"https://api.github.com/users/gonzalolarralde/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzalolarralde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzalolarralde/subscriptions","organizations_url":"https://api.github.com/users/gonzalolarralde/orgs","repos_url":"https://api.github.com/users/gonzalolarralde/repos","events_url":"https://api.github.com/users/gonzalolarralde/events{/privacy}","received_events_url":"https://api.github.com/users/gonzalolarralde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gonzalolarralde/libiconv-libicu-android","description":"Port of libiconv and libicu to Android","fork":true,"url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android","forks_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/forks","keys_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/teams","hooks_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/hooks","issue_events_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/issues/events{/number}","events_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/events","assignees_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/assignees{/user}","branches_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/branches{/branch}","tags_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/tags","blobs_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/statuses/{sha}","languages_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/languages","stargazers_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/stargazers","contributors_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/contributors","subscribers_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/subscribers","subscription_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/subscription","commits_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/contents/{+path}","compare_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/merges","archive_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/downloads","issues_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/issues{/number}","pulls_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/pulls{/number}","milestones_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/milestones{/number}","notifications_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/labels{/name}","releases_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/releases{/id}","deployments_url":"https://api.github.com/repos/gonzalolarralde/libiconv-libicu-android/deployments","created_at":"2016-08-09T07:05:34Z","updated_at":"2016-08-09T07:05:35Z","pushed_at":"2018-02-21T23:37:29Z","git_url":"git://github.com/gonzalolarralde/libiconv-libicu-android.git","ssh_url":"git@github.com:gonzalolarralde/libiconv-libicu-android.git","clone_url":"https://github.com/gonzalolarralde/libiconv-libicu-android.git","svn_url":"https://github.com/gonzalolarralde/libiconv-libicu-android","homepage":null,"size":70541,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SwiftAndroid:master","ref":"master","sha":"877921d5c13cd2b35c048311d08a50bced9c5dc4","user":{"login":"SwiftAndroid","id":16200657,"avatar_url":"https://avatars0.githubusercontent.com/u/16200657?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftAndroid","html_url":"https://github.com/SwiftAndroid","followers_url":"https://api.github.com/users/SwiftAndroid/followers","following_url":"https://api.github.com/users/SwiftAndroid/following{/other_user}","gists_url":"https://api.github.com/users/SwiftAndroid/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftAndroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftAndroid/subscriptions","organizations_url":"https://api.github.com/users/SwiftAndroid/orgs","repos_url":"https://api.github.com/users/SwiftAndroid/repos","events_url":"https://api.github.com/users/SwiftAndroid/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftAndroid/received_events","type":"Organization","site_admin":false},"repo":{"id":47593954,"name":"libiconv-libicu-android","full_name":"SwiftAndroid/libiconv-libicu-android","owner":{"login":"SwiftAndroid","id":16200657,"avatar_url":"https://avatars0.githubusercontent.com/u/16200657?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftAndroid","html_url":"https://github.com/SwiftAndroid","followers_url":"https://api.github.com/users/SwiftAndroid/followers","following_url":"https://api.github.com/users/SwiftAndroid/following{/other_user}","gists_url":"https://api.github.com/users/SwiftAndroid/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftAndroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftAndroid/subscriptions","organizations_url":"https://api.github.com/users/SwiftAndroid/orgs","repos_url":"https://api.github.com/users/SwiftAndroid/repos","events_url":"https://api.github.com/users/SwiftAndroid/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftAndroid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SwiftAndroid/libiconv-libicu-android","description":"Port of libiconv and libicu to Android","fork":true,"url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android","forks_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/forks","keys_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/teams","hooks_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/hooks","issue_events_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/events{/number}","events_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/events","assignees_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/assignees{/user}","branches_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/branches{/branch}","tags_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/tags","blobs_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/statuses/{sha}","languages_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/languages","stargazers_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/stargazers","contributors_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/contributors","subscribers_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/subscribers","subscription_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/subscription","commits_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/contents/{+path}","compare_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/merges","archive_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/downloads","issues_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues{/number}","pulls_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls{/number}","milestones_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/milestones{/number}","notifications_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/labels{/name}","releases_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/releases{/id}","deployments_url":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/deployments","created_at":"2015-12-08T02:42:00Z","updated_at":"2017-09-27T12:59:43Z","pushed_at":"2018-03-06T03:11:34Z","git_url":"git://github.com/SwiftAndroid/libiconv-libicu-android.git","ssh_url":"git@github.com:SwiftAndroid/libiconv-libicu-android.git","clone_url":"https://github.com/SwiftAndroid/libiconv-libicu-android.git","svn_url":"https://github.com/SwiftAndroid/libiconv-libicu-android","homepage":null,"size":77527,"stargazers_count":31,"watchers_count":31,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":16,"open_issues":4,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7"},"html":{"href":"https://github.com/SwiftAndroid/libiconv-libicu-android/pull/7"},"issue":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/7"},"comments":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android/statuses/f843f77bd11290c274c8d3d2bc9342d6eaa6643a"}},"author_association":"OWNER"}} | {
"id": 47593954,
"name": "SwiftAndroid/libiconv-libicu-android",
"url": "https://api.github.com/repos/SwiftAndroid/libiconv-libicu-android"
} | {
"id": 3814772,
"login": "AndrewSB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3814772?",
"url": "https://api.github.com/users/AndrewSB"
} | {
"id": 16200657,
"login": "SwiftAndroid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16200657?",
"url": "https://api.github.com/orgs/SwiftAndroid"
} | 2018-03-06T03:17:01 | 7335318308 | {"actor":{"display_login":"AndrewSB"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/194296396","pull_request_review_id":127439187,"id":194296396,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI5NjM5Ng==","diff_hunk":"@@ -222,8 +222,8 @@ public void start(Boolean isPrimary) throws IOException {\n (int) Configuration.getMs(PropertyKey.MASTER_LOG_CONFIG_REPORT_HEARTBEAT_INTERVAL)));\n } else {\n // Standby master should setup MetaMasterSync to communicate with the leader master\n- MetaMasterMasterClient metaMasterClient =\n- new MetaMasterMasterClient(MasterClientConfig.defaults());\n+ RetryHandlingMetaMasterMasterClient metaMasterClient =","path":"core/server/master/src/main/java/alluxio/master/meta/DefaultMetaMaster.java","position":6,"original_position":6,"commit_id":"0efadf9441002267b2cbe608958253578aa91062","original_commit_id":"0efadf9441002267b2cbe608958253578aa91062","user":{"login":"aaudiber","id":3455177,"node_id":"MDQ6VXNlcjM0NTUxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"I renamed the class from `MetaMasterMasterClient` to `RetryHandlingMetaMasterMasterClient` without changing its functionality - do you mean the log was messy before this PR, or after?","created_at":"2018-06-11T05:43:40Z","updated_at":"2018-06-11T05:43:40Z","html_url":"https://github.com/Alluxio/alluxio/pull/7366#discussion_r194296396","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/194296396"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7366#discussion_r194296396"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366"}},"in_reply_to_id":194244426},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366","id":193463997,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDYzOTk3","html_url":"https://github.com/Alluxio/alluxio/pull/7366","diff_url":"https://github.com/Alluxio/alluxio/pull/7366.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/7366.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7366","number":7366,"state":"closed","locked":false,"title":"[SMALLFIX] Prevent master sync from timing out","user":{"login":"aaudiber","id":3455177,"node_id":"MDQ6VXNlcjM0NTUxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"Letting this time out leaves the master in a crippled state where configuration checker can no longer work.","created_at":"2018-06-07T22:25:21Z","updated_at":"2018-06-11T05:43:40Z","closed_at":"2018-06-10T18:23:58Z","merged_at":"2018-06-10T18:23:58Z","merge_commit_sha":"9e50476c6a07f21b2e0216db25e626d0ac26179f","assignee":{"login":"apc999","id":1413748,"node_id":"MDQ6VXNlcjE0MTM3NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"assignees":[{"login":"apc999","id":1413748,"node_id":"MDQ6VXNlcjE0MTM3NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/7366/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/0efadf9441002267b2cbe608958253578aa91062","head":{"label":"aaudiber:meta-master-sync-timeout","ref":"meta-master-sync-timeout","sha":"0efadf9441002267b2cbe608958253578aa91062","user":{"login":"aaudiber","id":3455177,"node_id":"MDQ6VXNlcjM0NTUxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"repo":{"id":52421920,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQyMTkyMA==","name":"alluxio","full_name":"aaudiber/alluxio","owner":{"login":"aaudiber","id":3455177,"node_id":"MDQ6VXNlcjM0NTUxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaudiber/alluxio","description":"Memory-Centric Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/aaudiber/alluxio","forks_url":"https://api.github.com/repos/aaudiber/alluxio/forks","keys_url":"https://api.github.com/repos/aaudiber/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaudiber/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaudiber/alluxio/teams","hooks_url":"https://api.github.com/repos/aaudiber/alluxio/hooks","issue_events_url":"https://api.github.com/repos/aaudiber/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/aaudiber/alluxio/events","assignees_url":"https://api.github.com/repos/aaudiber/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/aaudiber/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/aaudiber/alluxio/tags","blobs_url":"https://api.github.com/repos/aaudiber/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaudiber/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaudiber/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaudiber/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaudiber/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/aaudiber/alluxio/languages","stargazers_url":"https://api.github.com/repos/aaudiber/alluxio/stargazers","contributors_url":"https://api.github.com/repos/aaudiber/alluxio/contributors","subscribers_url":"https://api.github.com/repos/aaudiber/alluxio/subscribers","subscription_url":"https://api.github.com/repos/aaudiber/alluxio/subscription","commits_url":"https://api.github.com/repos/aaudiber/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaudiber/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaudiber/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaudiber/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaudiber/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/aaudiber/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaudiber/alluxio/merges","archive_url":"https://api.github.com/repos/aaudiber/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaudiber/alluxio/downloads","issues_url":"https://api.github.com/repos/aaudiber/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/aaudiber/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/aaudiber/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/aaudiber/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaudiber/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/aaudiber/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/aaudiber/alluxio/deployments","created_at":"2016-02-24T07:07:15Z","updated_at":"2018-06-04T21:26:42Z","pushed_at":"2018-06-09T05:09:17Z","git_url":"git://github.com/aaudiber/alluxio.git","ssh_url":"git@github.com:aaudiber/alluxio.git","clone_url":"https://github.com/aaudiber/alluxio.git","svn_url":"https://github.com/aaudiber/alluxio","homepage":"http://www.alluxio.org/","size":89028,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"3906dda26990382bc90e16f04c9863a163ada646","user":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc2OTU0","name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjAzNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-06-11T05:22:23Z","pushed_at":"2018-06-10T22:22:26Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":89259,"stargazers_count":3513,"watchers_count":3513,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1904,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1904,"open_issues":22,"watchers":3513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/7366"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7366"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/7366/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/7366/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/0efadf9441002267b2cbe608958253578aa91062"}},"author_association":"COLLABORATOR"}} | {
"id": 7276954,
"name": "Alluxio/alluxio",
"url": "https://api.github.com/repos/Alluxio/alluxio"
} | {
"id": 3455177,
"login": "aaudiber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3455177?",
"url": "https://api.github.com/users/aaudiber"
} | {
"id": 16203694,
"login": "Alluxio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16203694?",
"url": "https://api.github.com/orgs/Alluxio"
} | 2018-06-11T05:43:40 | 7804100343 | {"actor":{"display_login":"aaudiber"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/173901379","pull_request_review_id":103166655,"id":173901379,"diff_hunk":"@@ -708,12 +709,24 @@ private void processWorkerAddedBlocks(MasterWorkerInfo workerInfo,\n mLostBlocks.remove(blockId);\n }\n } else {\n- LOG.warn(\"Failed to register workerId: {} to blockId: {}\", workerInfo.getId(), blockId);\n+ LOG.warn(\"Invalid block: {} from worker {}.\", blockId,\n+ workerInfo.getWorkerAddress().getHost());\n }\n }\n }\n }\n \n+ @GuardedBy(\"workerInfo\")\n+ private void processWorkerOrphanedBlocks(MasterWorkerInfo workerInfo) {\n+ for (long block: workerInfo.getBlocks()) {","path":"core/server/master/src/main/java/alluxio/master/block/DefaultBlockMaster.java","position":22,"original_position":22,"commit_id":"d0529166631ac300244058c25efe0aeade131ac8","original_commit_id":"d0529166631ac300244058c25efe0aeade131ac8","user":{"login":"gpang","id":429032,"avatar_url":"https://avatars2.githubusercontent.com/u/429032?v=4","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"body":"NIT: should there be a space before `:`?","created_at":"2018-03-12T18:28:33Z","updated_at":"2018-03-12T18:32:04Z","html_url":"https://github.com/Alluxio/alluxio/pull/6947#discussion_r173901379","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/173901379"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6947#discussion_r173901379"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947","id":174090342,"html_url":"https://github.com/Alluxio/alluxio/pull/6947","diff_url":"https://github.com/Alluxio/alluxio/pull/6947.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/6947.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6947","number":6947,"state":"open","locked":false,"title":"[ALLUXIO-818] Clean up orphaned blocks on register.","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-818","created_at":"2018-03-09T19:37:39Z","updated_at":"2018-03-12T18:32:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96cb66b8fa1447914070ebe2e2c6ab15cc8f4f99","assignee":{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"assignees":[{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6947/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/d0529166631ac300244058c25efe0aeade131ac8","head":{"label":"calvinjia:alluxio-818","ref":"alluxio-818","sha":"d0529166631ac300244058c25efe0aeade131ac8","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"repo":{"id":9278135,"name":"tachyon","full_name":"calvinjia/tachyon","owner":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calvinjia/tachyon","description":"Tachyon","fork":true,"url":"https://api.github.com/repos/calvinjia/tachyon","forks_url":"https://api.github.com/repos/calvinjia/tachyon/forks","keys_url":"https://api.github.com/repos/calvinjia/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calvinjia/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calvinjia/tachyon/teams","hooks_url":"https://api.github.com/repos/calvinjia/tachyon/hooks","issue_events_url":"https://api.github.com/repos/calvinjia/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/calvinjia/tachyon/events","assignees_url":"https://api.github.com/repos/calvinjia/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/calvinjia/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/calvinjia/tachyon/tags","blobs_url":"https://api.github.com/repos/calvinjia/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calvinjia/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calvinjia/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/calvinjia/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calvinjia/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/calvinjia/tachyon/languages","stargazers_url":"https://api.github.com/repos/calvinjia/tachyon/stargazers","contributors_url":"https://api.github.com/repos/calvinjia/tachyon/contributors","subscribers_url":"https://api.github.com/repos/calvinjia/tachyon/subscribers","subscription_url":"https://api.github.com/repos/calvinjia/tachyon/subscription","commits_url":"https://api.github.com/repos/calvinjia/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/calvinjia/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/calvinjia/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/calvinjia/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/calvinjia/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/calvinjia/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calvinjia/tachyon/merges","archive_url":"https://api.github.com/repos/calvinjia/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calvinjia/tachyon/downloads","issues_url":"https://api.github.com/repos/calvinjia/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/calvinjia/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/calvinjia/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/calvinjia/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calvinjia/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/calvinjia/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/calvinjia/tachyon/deployments","created_at":"2013-04-07T14:56:38Z","updated_at":"2016-10-24T17:48:26Z","pushed_at":"2018-03-12T18:12:41Z","git_url":"git://github.com/calvinjia/tachyon.git","ssh_url":"git@github.com:calvinjia/tachyon.git","clone_url":"https://github.com/calvinjia/tachyon.git","svn_url":"https://github.com/calvinjia/tachyon","homepage":null,"size":86819,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Alluxio:branch-1.7","ref":"branch-1.7","sha":"8b4373da7d80b91c132ebcc3baea27fdfef621e2","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-03-12T09:55:11Z","pushed_at":"2018-03-12T18:29:26Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":86497,"stargazers_count":3376,"watchers_count":3376,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1755,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1755,"open_issues":8,"watchers":3376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6947"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6947"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6947/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6947/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/d0529166631ac300244058c25efe0aeade131ac8"}},"author_association":"COLLABORATOR"}} | {
"id": 7276954,
"name": "Alluxio/alluxio",
"url": "https://api.github.com/repos/Alluxio/alluxio"
} | {
"id": 429032,
"login": "gpang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/429032?",
"url": "https://api.github.com/users/gpang"
} | {
"id": 16203694,
"login": "Alluxio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16203694?",
"url": "https://api.github.com/orgs/Alluxio"
} | 2018-03-12T18:28:33 | 7367515741 | {"actor":{"display_login":"gpang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/comments/189392365","pull_request_review_id":121571456,"id":189392365,"diff_hunk":"@@ -8,4 +8,40 @@\n static const char** FileWriterNames; /* Array with pointers to all file names */\n static unsigned int FileWriterNames_n = 0; /* Number of files */\n \n+void* prependString(const char* fileName, const char* string){","path":"IBPSA/Resources/C-Sources/fileWriterStructure.h","position":4,"original_position":4,"commit_id":"2b9a8f57ad73da9f3919de771a53988717564e0f","original_commit_id":"2b9a8f57ad73da9f3919de771a53988717564e0f","user":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars0.githubusercontent.com/u/1329080?v=4","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"body":"Functions belong into a `*.c` file.","created_at":"2018-05-18T21:01:31Z","updated_at":"2018-05-18T21:01:32Z","html_url":"https://github.com/ibpsa/modelica-ibpsa/pull/925#discussion_r189392365","pull_request_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/comments/189392365"},"html":{"href":"https://github.com/ibpsa/modelica-ibpsa/pull/925#discussion_r189392365"},"pull_request":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925"}}},"pull_request":{"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925","id":187871990,"html_url":"https://github.com/ibpsa/modelica-ibpsa/pull/925","diff_url":"https://github.com/ibpsa/modelica-ibpsa/pull/925.diff","patch_url":"https://github.com/ibpsa/modelica-ibpsa/pull/925.patch","issue_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/925","number":925,"state":"open","locked":false,"title":"Issue924 csv reader writer","user":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars0.githubusercontent.com/u/5970879?v=4","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"body":"@mwetter thanks for revising the code! To unittest the implementation, I extended the functionality of the CSV reader a bit further such that it can write files in the format of `CombiTimeTable`. This requires the correct header to be prepended to the file, which contains the number of rows, which are only available upon completion fo the simulation. Therefore the header has to be prepended to the file. I do this by reading the file to memory and then writing a new file. I'm not sure whether this is the most appropriate solution. Perhaps this functionality should be disabled by default.","created_at":"2018-05-14T15:49:45Z","updated_at":"2018-05-18T21:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2b45a0a81c377fb617ac4d39a2461433a577fb9","assignee":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars0.githubusercontent.com/u/5970879?v=4","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"assignees":[{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars0.githubusercontent.com/u/5970879?v=4","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925/commits","review_comments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925/comments","review_comment_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/925/comments","statuses_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/statuses/2b9a8f57ad73da9f3919de771a53988717564e0f","head":{"label":"ibpsa:issue924_csvReaderWriter","ref":"issue924_csvReaderWriter","sha":"2b9a8f57ad73da9f3919de771a53988717564e0f","user":{"login":"ibpsa","id":16223588,"avatar_url":"https://avatars3.githubusercontent.com/u/16223588?v=4","gravatar_id":"","url":"https://api.github.com/users/ibpsa","html_url":"https://github.com/ibpsa","followers_url":"https://api.github.com/users/ibpsa/followers","following_url":"https://api.github.com/users/ibpsa/following{/other_user}","gists_url":"https://api.github.com/users/ibpsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ibpsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibpsa/subscriptions","organizations_url":"https://api.github.com/users/ibpsa/orgs","repos_url":"https://api.github.com/users/ibpsa/repos","events_url":"https://api.github.com/users/ibpsa/events{/privacy}","received_events_url":"https://api.github.com/users/ibpsa/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-ibpsa","full_name":"ibpsa/modelica-ibpsa","owner":{"login":"ibpsa","id":16223588,"avatar_url":"https://avatars3.githubusercontent.com/u/16223588?v=4","gravatar_id":"","url":"https://api.github.com/users/ibpsa","html_url":"https://github.com/ibpsa","followers_url":"https://api.github.com/users/ibpsa/followers","following_url":"https://api.github.com/users/ibpsa/following{/other_user}","gists_url":"https://api.github.com/users/ibpsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ibpsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibpsa/subscriptions","organizations_url":"https://api.github.com/users/ibpsa/orgs","repos_url":"https://api.github.com/users/ibpsa/repos","events_url":"https://api.github.com/users/ibpsa/events{/privacy}","received_events_url":"https://api.github.com/users/ibpsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ibpsa/modelica-ibpsa","description":"Modelica library for building and district energy systems developed within IBPSA Project 1","fork":false,"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa","forks_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/forks","keys_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/teams","hooks_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/hooks","issue_events_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/events{/number}","events_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/events","assignees_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/assignees{/user}","branches_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/branches{/branch}","tags_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/tags","blobs_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/statuses/{sha}","languages_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/languages","stargazers_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/stargazers","contributors_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/contributors","subscribers_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/subscribers","subscription_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/subscription","commits_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/contents/{+path}","compare_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/merges","archive_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/downloads","issues_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues{/number}","pulls_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls{/number}","milestones_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/milestones{/number}","notifications_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/labels{/name}","releases_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/releases{/id}","deployments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/deployments","created_at":"2013-09-21T05:49:03Z","updated_at":"2018-05-16T07:41:52Z","pushed_at":"2018-05-18T20:58:44Z","git_url":"git://github.com/ibpsa/modelica-ibpsa.git","ssh_url":"git@github.com:ibpsa/modelica-ibpsa.git","clone_url":"https://github.com/ibpsa/modelica-ibpsa.git","svn_url":"https://github.com/ibpsa/modelica-ibpsa","homepage":"https://ibpsa.github.io/project1","size":26584,"stargazers_count":37,"watchers_count":37,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":43,"open_issues":32,"watchers":37,"default_branch":"master"}},"base":{"label":"ibpsa:issue924_csv","ref":"issue924_csv","sha":"d80556582efab1139933a1928e0ab1c85c036abf","user":{"login":"ibpsa","id":16223588,"avatar_url":"https://avatars3.githubusercontent.com/u/16223588?v=4","gravatar_id":"","url":"https://api.github.com/users/ibpsa","html_url":"https://github.com/ibpsa","followers_url":"https://api.github.com/users/ibpsa/followers","following_url":"https://api.github.com/users/ibpsa/following{/other_user}","gists_url":"https://api.github.com/users/ibpsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ibpsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibpsa/subscriptions","organizations_url":"https://api.github.com/users/ibpsa/orgs","repos_url":"https://api.github.com/users/ibpsa/repos","events_url":"https://api.github.com/users/ibpsa/events{/privacy}","received_events_url":"https://api.github.com/users/ibpsa/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-ibpsa","full_name":"ibpsa/modelica-ibpsa","owner":{"login":"ibpsa","id":16223588,"avatar_url":"https://avatars3.githubusercontent.com/u/16223588?v=4","gravatar_id":"","url":"https://api.github.com/users/ibpsa","html_url":"https://github.com/ibpsa","followers_url":"https://api.github.com/users/ibpsa/followers","following_url":"https://api.github.com/users/ibpsa/following{/other_user}","gists_url":"https://api.github.com/users/ibpsa/gists{/gist_id}","starred_url":"https://api.github.com/users/ibpsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibpsa/subscriptions","organizations_url":"https://api.github.com/users/ibpsa/orgs","repos_url":"https://api.github.com/users/ibpsa/repos","events_url":"https://api.github.com/users/ibpsa/events{/privacy}","received_events_url":"https://api.github.com/users/ibpsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ibpsa/modelica-ibpsa","description":"Modelica library for building and district energy systems developed within IBPSA Project 1","fork":false,"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa","forks_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/forks","keys_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/teams","hooks_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/hooks","issue_events_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/events{/number}","events_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/events","assignees_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/assignees{/user}","branches_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/branches{/branch}","tags_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/tags","blobs_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/statuses/{sha}","languages_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/languages","stargazers_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/stargazers","contributors_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/contributors","subscribers_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/subscribers","subscription_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/subscription","commits_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/contents/{+path}","compare_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/merges","archive_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/downloads","issues_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues{/number}","pulls_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls{/number}","milestones_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/milestones{/number}","notifications_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/labels{/name}","releases_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/releases{/id}","deployments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/deployments","created_at":"2013-09-21T05:49:03Z","updated_at":"2018-05-16T07:41:52Z","pushed_at":"2018-05-18T20:58:44Z","git_url":"git://github.com/ibpsa/modelica-ibpsa.git","ssh_url":"git@github.com:ibpsa/modelica-ibpsa.git","clone_url":"https://github.com/ibpsa/modelica-ibpsa.git","svn_url":"https://github.com/ibpsa/modelica-ibpsa","homepage":"https://ibpsa.github.io/project1","size":26584,"stargazers_count":37,"watchers_count":37,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":43,"open_issues":32,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925"},"html":{"href":"https://github.com/ibpsa/modelica-ibpsa/pull/925"},"issue":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/925"},"comments":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/925/comments"},"review_comments":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925/comments"},"review_comment":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/925/commits"},"statuses":{"href":"https://api.github.com/repos/ibpsa/modelica-ibpsa/statuses/2b9a8f57ad73da9f3919de771a53988717564e0f"}},"author_association":"MEMBER"}} | {
"id": 12990303,
"name": "ibpsa/modelica-ibpsa",
"url": "https://api.github.com/repos/ibpsa/modelica-ibpsa"
} | {
"id": 1329080,
"login": "mwetter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1329080?",
"url": "https://api.github.com/users/mwetter"
} | {
"id": 16223588,
"login": "ibpsa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16223588?",
"url": "https://api.github.com/orgs/ibpsa"
} | 2018-05-18T21:01:31 | 7698010348 | {"actor":{"display_login":"mwetter"}} |
Subsets and Splits