type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/235024582","pull_request_review_id":176792148,"id":235024582,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTAyNDU4Mg==","diff_hunk":"@@ -0,0 +1,63 @@\n+/*\n+ * Copyright 2018 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.cloud.stream.app.security.common;\n+\n+import org.springframework.boot.autoconfigure.AutoConfigureBefore;\n+import org.springframework.boot.autoconfigure.condition.AnyNestedCondition;\n+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;\n+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;\n+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;\n+import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;\n+import org.springframework.boot.autoconfigure.security.servlet.WebSecurityEnablerConfiguration;\n+import org.springframework.context.annotation.Conditional;\n+import org.springframework.context.annotation.Configuration;\n+import org.springframework.context.annotation.ConfigurationCondition;\n+import org.springframework.context.annotation.Import;\n+import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;\n+\n+/**\n+ * @author Christian Tzolov\n+ * @author Artem Bilan\n+ *\n+ * @since 2.1\n+ */\n+@Configuration\n+@ConditionalOnClass(WebSecurityConfigurerAdapter.class)\n+@ConditionalOnMissingBean(WebSecurityConfigurerAdapter.class)\n+@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.ANY)\n+@Conditional(AppStarterWebSecurityAutoConfiguration.OnHttpCsrfOrSecurityDisabled.class)\n+@AutoConfigureBefore(name = {\n+\t\t\"org.springframework.boot.actuate.autoconfigure.security.servlet.ManagementWebSecurityAutoConfiguration\",\n+\t\t\"org.springframework.boot.autoconfigure.security.servlet.SecurityAutoConfiguration\"","path":"common/app-starters-security-common/src/main/java/org/springframework/cloud/stream/app/security/common/AppStarterWebSecurityAutoConfiguration.java","position":45,"original_position":45,"commit_id":"a0b6ff7277571e742e00b703cce3decc14e604da","original_commit_id":"a0b6ff7277571e742e00b703cce3decc14e604da","user":{"login":"artembilan","id":1071590,"node_id":"MDQ6VXNlcjEwNzE1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1071590?v=4","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"I think that's fully to use classes here instead of their name as long as you have dependencies for them in this project.","created_at":"2018-11-20T14:33:10Z","updated_at":"2018-11-20T14:35:13Z","html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/59#discussion_r235024582","pull_request_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/235024582"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/59#discussion_r235024582"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59","id":231870890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODcwODkw","html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/59","diff_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/59.diff","patch_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/59.patch","issue_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/59","number":59,"state":"open","locked":false,"title":"Disable security for Info, LogFile, Bindings and Health endpoints only","user":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"body":" - By default web security is enabled for all endpoints but Info, LogFile, Health and Bindings\r\n - Use spring.cloud.stream.security.enabled = false (default: true) to disable security for all endpoints\r\n - Use spring.cloud.stream.security.csrf-enabled (default: false) to disable security for CSRF\r\n - Update documentation.\r\n\r\nResolves #56","created_at":"2018-11-19T06:56:14Z","updated_at":"2018-11-20T14:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1e790484cfe25694a38ec8194b13235fadd0d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":535323636,"node_id":"MDU6TGFiZWw1MzUzMjM2MzY=","url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels/in%20pr","name":"in pr","color":"ededed","default":false},{"id":815381776,"node_id":"MDU6TGFiZWw4MTUzODE3NzY=","url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59/commits","review_comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59/comments","review_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/59/comments","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/a0b6ff7277571e742e00b703cce3decc14e604da","head":{"label":"tzolov:gh_56_enable_info_health_logfile_bindings_endpoints","ref":"gh_56_enable_info_health_logfile_bindings_endpoints","sha":"a0b6ff7277571e742e00b703cce3decc14e604da","user":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"repo":{"id":120959535,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NTk1MzU=","name":"core","full_name":"tzolov/core","private":false,"owner":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tzolov/core","description":"Core components shared by other projects in the app starters organization","fork":true,"url":"https://api.github.com/repos/tzolov/core","forks_url":"https://api.github.com/repos/tzolov/core/forks","keys_url":"https://api.github.com/repos/tzolov/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzolov/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzolov/core/teams","hooks_url":"https://api.github.com/repos/tzolov/core/hooks","issue_events_url":"https://api.github.com/repos/tzolov/core/issues/events{/number}","events_url":"https://api.github.com/repos/tzolov/core/events","assignees_url":"https://api.github.com/repos/tzolov/core/assignees{/user}","branches_url":"https://api.github.com/repos/tzolov/core/branches{/branch}","tags_url":"https://api.github.com/repos/tzolov/core/tags","blobs_url":"https://api.github.com/repos/tzolov/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzolov/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzolov/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzolov/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzolov/core/statuses/{sha}","languages_url":"https://api.github.com/repos/tzolov/core/languages","stargazers_url":"https://api.github.com/repos/tzolov/core/stargazers","contributors_url":"https://api.github.com/repos/tzolov/core/contributors","subscribers_url":"https://api.github.com/repos/tzolov/core/subscribers","subscription_url":"https://api.github.com/repos/tzolov/core/subscription","commits_url":"https://api.github.com/repos/tzolov/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzolov/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzolov/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzolov/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzolov/core/contents/{+path}","compare_url":"https://api.github.com/repos/tzolov/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzolov/core/merges","archive_url":"https://api.github.com/repos/tzolov/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzolov/core/downloads","issues_url":"https://api.github.com/repos/tzolov/core/issues{/number}","pulls_url":"https://api.github.com/repos/tzolov/core/pulls{/number}","milestones_url":"https://api.github.com/repos/tzolov/core/milestones{/number}","notifications_url":"https://api.github.com/repos/tzolov/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzolov/core/labels{/name}","releases_url":"https://api.github.com/repos/tzolov/core/releases{/id}","deployments_url":"https://api.github.com/repos/tzolov/core/deployments","created_at":"2018-02-09T21:51:10Z","updated_at":"2018-11-06T22:06:08Z","pushed_at":"2018-11-20T13:37:03Z","git_url":"git://github.com/tzolov/core.git","ssh_url":"git@github.com:tzolov/core.git","clone_url":"https://github.com/tzolov/core.git","svn_url":"https://github.com/tzolov/core","homepage":null,"size":304,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud-stream-app-starters:master","ref":"master","sha":"6d27754db419310962c43b731bbb27fd5963d46f","user":{"login":"spring-cloud-stream-app-starters","id":22753134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUzMTM0","avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"repo":{"id":70517478,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUxNzQ3OA==","name":"core","full_name":"spring-cloud-stream-app-starters/core","private":false,"owner":{"login":"spring-cloud-stream-app-starters","id":22753134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUzMTM0","avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-cloud-stream-app-starters/core","description":"Core components shared by other projects in the app starters organization","fork":false,"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core","forks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/forks","keys_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/teams","hooks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/events","assignees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/tags","blobs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/languages","stargazers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscription","commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/merges","archive_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/downloads","issues_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/deployments","created_at":"2016-10-10T18:37:48Z","updated_at":"2018-11-13T02:16:35Z","pushed_at":"2018-11-20T13:37:04Z","git_url":"git://github.com/spring-cloud-stream-app-starters/core.git","ssh_url":"git@github.com:spring-cloud-stream-app-starters/core.git","clone_url":"https://github.com/spring-cloud-stream-app-starters/core.git","svn_url":"https://github.com/spring-cloud-stream-app-starters/core","homepage":null,"size":277,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/59"},"issue":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/59"},"comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/a0b6ff7277571e742e00b703cce3decc14e604da"}},"author_association":"CONTRIBUTOR"}} | {
"id": 70517478,
"name": "spring-cloud-stream-app-starters/core",
"url": "https://api.github.com/repos/spring-cloud-stream-app-starters/core"
} | {
"id": 1071590,
"login": "artembilan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1071590?",
"url": "https://api.github.com/users/artembilan"
} | {
"id": 22753134,
"login": "spring-cloud-stream-app-starters",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22753134?",
"url": "https://api.github.com/orgs/spring-cloud-stream-app-starters"
} | 2018-11-20T14:33:10 | 8620246812 | {"actor":{"display_login":"artembilan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/230433984","pull_request_review_id":171170562,"id":230433984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQzMzk4NA==","diff_hunk":"@@ -0,0 +1,57 @@\n+/*\n+ * Copyright 2015-2016 the original author or authors.\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.cloud.stream.app.security.common;\n+\n+import org.springframework.boot.context.properties.ConfigurationProperties;\n+import org.springframework.validation.annotation.Validated;\n+\n+/**\n+ * {@code SecurityCommonAutoConfiguration} properties.\n+ *\n+ * @author Christian Tzolov\n+ * @author Artem Bilan\n+ */\n+@ConfigurationProperties(\"spring.cloud.security\")","path":"common/app-starters-security-common/src/main/java/org/springframework/cloud/stream/app/security/common/SecurityCommonAutoConfigurationProperties.java","position":27,"original_position":27,"commit_id":"5f3a472df53aa78d4d79c1f356de6a1e31a49fa4","original_commit_id":"5f3a472df53aa78d4d79c1f356de6a1e31a49fa4","user":{"login":"artembilan","id":1071590,"node_id":"MDQ6VXNlcjEwNzE1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1071590?v=4","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"I think would better to name it as `spring.cloud.stream.security`.\r\nJust `spring.cloud` sounds too generic and may be treated as a matter for the whole Spring Cloud.\r\n\r\nAlthough I agree that it is going to work automatically when we place this artifact into classpath any way 😄","created_at":"2018-11-02T16:27:16Z","updated_at":"2018-11-02T16:39:54Z","html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/49#discussion_r230433984","pull_request_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments/230433984"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/49#discussion_r230433984"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49","id":215071504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDcxNTA0","html_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/49","diff_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/49.diff","patch_url":"https://github.com/spring-cloud-stream-app-starters/core/pull/49.patch","issue_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/49","number":49,"state":"open","locked":false,"title":"[DO Not Merge] Add property to disable security for applications","user":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"body":" - Add new SecurityDisabledEnvironmentPostProcessor that uses the spring.cloud.security.disabled property to exclude or add the SecurityAutoconfiguration\r\n - The PostProcessor will not alter any spring.autoconfigure.exclude set outside the scope of the post-processor.\r\n\r\n Resolves spring-cloud-stream-app-starters/app-starters-release#161","created_at":"2018-09-12T19:34:00Z","updated_at":"2018-11-02T16:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7007c199d3b35fc7ae96e1c10d9cb673fac0ce69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":535323636,"node_id":"MDU6TGFiZWw1MzUzMjM2MzY=","url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels/in%20pr","name":"in pr","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49/commits","review_comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49/comments","review_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/49/comments","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/5f3a472df53aa78d4d79c1f356de6a1e31a49fa4","head":{"label":"tzolov:gh_161_add_disable_security_property","ref":"gh_161_add_disable_security_property","sha":"5f3a472df53aa78d4d79c1f356de6a1e31a49fa4","user":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"repo":{"id":120959535,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NTk1MzU=","name":"core","full_name":"tzolov/core","private":false,"owner":{"login":"tzolov","id":1351573,"node_id":"MDQ6VXNlcjEzNTE1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1351573?v=4","gravatar_id":"","url":"https://api.github.com/users/tzolov","html_url":"https://github.com/tzolov","followers_url":"https://api.github.com/users/tzolov/followers","following_url":"https://api.github.com/users/tzolov/following{/other_user}","gists_url":"https://api.github.com/users/tzolov/gists{/gist_id}","starred_url":"https://api.github.com/users/tzolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzolov/subscriptions","organizations_url":"https://api.github.com/users/tzolov/orgs","repos_url":"https://api.github.com/users/tzolov/repos","events_url":"https://api.github.com/users/tzolov/events{/privacy}","received_events_url":"https://api.github.com/users/tzolov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tzolov/core","description":"Core components shared by other projects in the app starters organization","fork":true,"url":"https://api.github.com/repos/tzolov/core","forks_url":"https://api.github.com/repos/tzolov/core/forks","keys_url":"https://api.github.com/repos/tzolov/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzolov/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzolov/core/teams","hooks_url":"https://api.github.com/repos/tzolov/core/hooks","issue_events_url":"https://api.github.com/repos/tzolov/core/issues/events{/number}","events_url":"https://api.github.com/repos/tzolov/core/events","assignees_url":"https://api.github.com/repos/tzolov/core/assignees{/user}","branches_url":"https://api.github.com/repos/tzolov/core/branches{/branch}","tags_url":"https://api.github.com/repos/tzolov/core/tags","blobs_url":"https://api.github.com/repos/tzolov/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzolov/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzolov/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzolov/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzolov/core/statuses/{sha}","languages_url":"https://api.github.com/repos/tzolov/core/languages","stargazers_url":"https://api.github.com/repos/tzolov/core/stargazers","contributors_url":"https://api.github.com/repos/tzolov/core/contributors","subscribers_url":"https://api.github.com/repos/tzolov/core/subscribers","subscription_url":"https://api.github.com/repos/tzolov/core/subscription","commits_url":"https://api.github.com/repos/tzolov/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzolov/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzolov/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzolov/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzolov/core/contents/{+path}","compare_url":"https://api.github.com/repos/tzolov/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzolov/core/merges","archive_url":"https://api.github.com/repos/tzolov/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzolov/core/downloads","issues_url":"https://api.github.com/repos/tzolov/core/issues{/number}","pulls_url":"https://api.github.com/repos/tzolov/core/pulls{/number}","milestones_url":"https://api.github.com/repos/tzolov/core/milestones{/number}","notifications_url":"https://api.github.com/repos/tzolov/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzolov/core/labels{/name}","releases_url":"https://api.github.com/repos/tzolov/core/releases{/id}","deployments_url":"https://api.github.com/repos/tzolov/core/deployments","created_at":"2018-02-09T21:51:10Z","updated_at":"2018-10-24T09:49:12Z","pushed_at":"2018-11-02T16:22:44Z","git_url":"git://github.com/tzolov/core.git","ssh_url":"git@github.com:tzolov/core.git","clone_url":"https://github.com/tzolov/core.git","svn_url":"https://github.com/tzolov/core","homepage":null,"size":282,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud-stream-app-starters:master","ref":"master","sha":"53825b1535957e88141c0d70cd152ecee6a8bb88","user":{"login":"spring-cloud-stream-app-starters","id":22753134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUzMTM0","avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"repo":{"id":70517478,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUxNzQ3OA==","name":"core","full_name":"spring-cloud-stream-app-starters/core","private":false,"owner":{"login":"spring-cloud-stream-app-starters","id":22753134,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzUzMTM0","avatar_url":"https://avatars1.githubusercontent.com/u/22753134?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud-stream-app-starters","html_url":"https://github.com/spring-cloud-stream-app-starters","followers_url":"https://api.github.com/users/spring-cloud-stream-app-starters/followers","following_url":"https://api.github.com/users/spring-cloud-stream-app-starters/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud-stream-app-starters/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud-stream-app-starters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud-stream-app-starters/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud-stream-app-starters/orgs","repos_url":"https://api.github.com/users/spring-cloud-stream-app-starters/repos","events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud-stream-app-starters/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-cloud-stream-app-starters/core","description":"Core components shared by other projects in the app starters organization","fork":false,"url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core","forks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/forks","keys_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/teams","hooks_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/events","assignees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/tags","blobs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/languages","stargazers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/subscription","commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/merges","archive_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/downloads","issues_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/deployments","created_at":"2016-10-10T18:37:48Z","updated_at":"2018-11-01T15:21:07Z","pushed_at":"2018-11-02T16:22:45Z","git_url":"git://github.com/spring-cloud-stream-app-starters/core.git","ssh_url":"git@github.com:spring-cloud-stream-app-starters/core.git","clone_url":"https://github.com/spring-cloud-stream-app-starters/core.git","svn_url":"https://github.com/spring-cloud-stream-app-starters/core","homepage":null,"size":274,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49"},"html":{"href":"https://github.com/spring-cloud-stream-app-starters/core/pull/49"},"issue":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/49"},"comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud-stream-app-starters/core/statuses/5f3a472df53aa78d4d79c1f356de6a1e31a49fa4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 70517478,
"name": "spring-cloud-stream-app-starters/core",
"url": "https://api.github.com/repos/spring-cloud-stream-app-starters/core"
} | {
"id": 1071590,
"login": "artembilan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1071590?",
"url": "https://api.github.com/users/artembilan"
} | {
"id": 22753134,
"login": "spring-cloud-stream-app-starters",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22753134?",
"url": "https://api.github.com/orgs/spring-cloud-stream-app-starters"
} | 2018-11-02T16:27:16 | 8526573487 | {"actor":{"display_login":"artembilan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/comments/208875593","pull_request_review_id":144774012,"id":208875593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg3NTU5Mw==","diff_hunk":"@@ -16,11 +15,37 @@ function validate(req, res, next) {\n }\n }\n \n-/* GET home page. */\n+/* POST */\n router.post(\"/userprofiles\", validate, (req, res, next) => {\n- const user: Jurisdiction = fetchUsers(new Jurisdiction(req.body.jurisdictionName, \"AAAAA\"));\n- res.render(\"jurisdictions\", { jurisdictionName: user.id });\n+\n+ fetchUserProfilesByJurisdiction(req).then((response) => {\n+ res.status(201);\n+ const responseContent: { [k: string]: any } = {};\n+ responseContent.userprofiles = JSON.parse(response);\n+ res.render(\"jurisdictions\", responseContent);\n+ })\n+ .catch((error) => {\n+ // Call the next middleware, which is the error handler\n+ next(error);\n+ });\n+});\n+\n+/* GET */\n+router.get(\"/userprofiles\", (req, res, next) => {\n+\n+ fetchUserProfilesByJurisdiction(req).then((response) => {\n+ res.status(201);\n+ const responseContent: { [k: string]: any } = {};\n+ responseContent.userprofiles = JSON.parse(response);\n+ if (req.session.sucess) {\n+ responseContent.sucess = req.session.sucess;","path":"src/main/routes/userprofiles.ts","position":38,"original_position":38,"commit_id":"abffd2a21de0c489bebf31d7cadb0744863f9a56","original_commit_id":"abffd2a21de0c489bebf31d7cadb0744863f9a56","user":{"login":"mohammedanas","id":7723785,"node_id":"MDQ6VXNlcjc3MjM3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7723785?v=4","gravatar_id":"","url":"https://api.github.com/users/mohammedanas","html_url":"https://github.com/mohammedanas","followers_url":"https://api.github.com/users/mohammedanas/followers","following_url":"https://api.github.com/users/mohammedanas/following{/other_user}","gists_url":"https://api.github.com/users/mohammedanas/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammedanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammedanas/subscriptions","organizations_url":"https://api.github.com/users/mohammedanas/orgs","repos_url":"https://api.github.com/users/mohammedanas/repos","events_url":"https://api.github.com/users/mohammedanas/events{/privacy}","received_events_url":"https://api.github.com/users/mohammedanas/received_events","type":"User","site_admin":false},"body":"corrected","created_at":"2018-08-09T10:10:29Z","updated_at":"2018-08-09T10:10:30Z","html_url":"https://github.com/hmcts/ccd-admin-web/pull/33#discussion_r208875593","pull_request_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/comments/208875593"},"html":{"href":"https://github.com/hmcts/ccd-admin-web/pull/33#discussion_r208875593"},"pull_request":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33"}},"in_reply_to_id":208868602},"pull_request":{"url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33","id":205131572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTMxNTcy","html_url":"https://github.com/hmcts/ccd-admin-web/pull/33","diff_url":"https://github.com/hmcts/ccd-admin-web/pull/33.diff","patch_url":"https://github.com/hmcts/ccd-admin-web/pull/33.patch","issue_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/33","number":33,"state":"open","locked":false,"title":"Rdm 2401","user":{"login":"mohammedanas","id":7723785,"node_id":"MDQ6VXNlcjc3MjM3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7723785?v=4","gravatar_id":"","url":"https://api.github.com/users/mohammedanas","html_url":"https://github.com/mohammedanas","followers_url":"https://api.github.com/users/mohammedanas/followers","following_url":"https://api.github.com/users/mohammedanas/following{/other_user}","gists_url":"https://api.github.com/users/mohammedanas/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammedanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammedanas/subscriptions","organizations_url":"https://api.github.com/users/mohammedanas/orgs","repos_url":"https://api.github.com/users/mohammedanas/repos","events_url":"https://api.github.com/users/mohammedanas/events{/privacy}","received_events_url":"https://api.github.com/users/mohammedanas/received_events","type":"User","site_admin":false},"body":"**Before creating a pull request make sure that:**\r\n\r\n- [x] commit messages are meaningful and follow good commit message guidelines\r\n- [ ] README and other documentation has been updated / added (if needed)\r\n- [x] tests have been updated / new tests has been added (if needed)\r\n\r\nPlease remove this line and everything above and fill the following sections:\r\n\r\n\r\nhttps://tools.hmcts.net/jira/browse/RDM-2401\r\n\r\n\r\n\r\nThe new change displays a list of user profile based on jurisdiction\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2018-07-31T14:26:03Z","updated_at":"2018-08-09T10:10:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"356b5084ac7e156e558126694d2d8aa70ea5bb81","assignee":{"login":"mohammedanas","id":7723785,"node_id":"MDQ6VXNlcjc3MjM3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7723785?v=4","gravatar_id":"","url":"https://api.github.com/users/mohammedanas","html_url":"https://github.com/mohammedanas","followers_url":"https://api.github.com/users/mohammedanas/followers","following_url":"https://api.github.com/users/mohammedanas/following{/other_user}","gists_url":"https://api.github.com/users/mohammedanas/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammedanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammedanas/subscriptions","organizations_url":"https://api.github.com/users/mohammedanas/orgs","repos_url":"https://api.github.com/users/mohammedanas/repos","events_url":"https://api.github.com/users/mohammedanas/events{/privacy}","received_events_url":"https://api.github.com/users/mohammedanas/received_events","type":"User","site_admin":false},"assignees":[{"login":"mohammedanas","id":7723785,"node_id":"MDQ6VXNlcjc3MjM3ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/7723785?v=4","gravatar_id":"","url":"https://api.github.com/users/mohammedanas","html_url":"https://github.com/mohammedanas","followers_url":"https://api.github.com/users/mohammedanas/followers","following_url":"https://api.github.com/users/mohammedanas/following{/other_user}","gists_url":"https://api.github.com/users/mohammedanas/gists{/gist_id}","starred_url":"https://api.github.com/users/mohammedanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohammedanas/subscriptions","organizations_url":"https://api.github.com/users/mohammedanas/orgs","repos_url":"https://api.github.com/users/mohammedanas/repos","events_url":"https://api.github.com/users/mohammedanas/events{/privacy}","received_events_url":"https://api.github.com/users/mohammedanas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33/commits","review_comments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33/comments","review_comment_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/33/comments","statuses_url":"https://api.github.com/repos/hmcts/ccd-admin-web/statuses/abffd2a21de0c489bebf31d7cadb0744863f9a56","head":{"label":"hmcts:RDM-2401","ref":"RDM-2401","sha":"abffd2a21de0c489bebf31d7cadb0744863f9a56","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":128912469,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MTI0Njk=","name":"ccd-admin-web","full_name":"hmcts/ccd-admin-web","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/ccd-admin-web","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/ccd-admin-web","forks_url":"https://api.github.com/repos/hmcts/ccd-admin-web/forks","keys_url":"https://api.github.com/repos/hmcts/ccd-admin-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/ccd-admin-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/ccd-admin-web/teams","hooks_url":"https://api.github.com/repos/hmcts/ccd-admin-web/hooks","issue_events_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/ccd-admin-web/events","assignees_url":"https://api.github.com/repos/hmcts/ccd-admin-web/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/ccd-admin-web/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/ccd-admin-web/tags","blobs_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/ccd-admin-web/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/ccd-admin-web/languages","stargazers_url":"https://api.github.com/repos/hmcts/ccd-admin-web/stargazers","contributors_url":"https://api.github.com/repos/hmcts/ccd-admin-web/contributors","subscribers_url":"https://api.github.com/repos/hmcts/ccd-admin-web/subscribers","subscription_url":"https://api.github.com/repos/hmcts/ccd-admin-web/subscription","commits_url":"https://api.github.com/repos/hmcts/ccd-admin-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/ccd-admin-web/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/ccd-admin-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/ccd-admin-web/merges","archive_url":"https://api.github.com/repos/hmcts/ccd-admin-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/ccd-admin-web/downloads","issues_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/ccd-admin-web/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/ccd-admin-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/ccd-admin-web/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/ccd-admin-web/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/deployments","created_at":"2018-04-10T10:02:58Z","updated_at":"2018-08-09T08:53:45Z","pushed_at":"2018-08-09T08:53:53Z","git_url":"git://github.com/hmcts/ccd-admin-web.git","ssh_url":"git@github.com:hmcts/ccd-admin-web.git","clone_url":"https://github.com/hmcts/ccd-admin-web.git","svn_url":"https://github.com/hmcts/ccd-admin-web","homepage":null,"size":1957,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"4bf7235a3841c26839bbc5300ca329f90c239a2f","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":128912469,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MTI0Njk=","name":"ccd-admin-web","full_name":"hmcts/ccd-admin-web","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/ccd-admin-web","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/ccd-admin-web","forks_url":"https://api.github.com/repos/hmcts/ccd-admin-web/forks","keys_url":"https://api.github.com/repos/hmcts/ccd-admin-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/ccd-admin-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/ccd-admin-web/teams","hooks_url":"https://api.github.com/repos/hmcts/ccd-admin-web/hooks","issue_events_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/ccd-admin-web/events","assignees_url":"https://api.github.com/repos/hmcts/ccd-admin-web/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/ccd-admin-web/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/ccd-admin-web/tags","blobs_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/ccd-admin-web/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/ccd-admin-web/languages","stargazers_url":"https://api.github.com/repos/hmcts/ccd-admin-web/stargazers","contributors_url":"https://api.github.com/repos/hmcts/ccd-admin-web/contributors","subscribers_url":"https://api.github.com/repos/hmcts/ccd-admin-web/subscribers","subscription_url":"https://api.github.com/repos/hmcts/ccd-admin-web/subscription","commits_url":"https://api.github.com/repos/hmcts/ccd-admin-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/ccd-admin-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/ccd-admin-web/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/ccd-admin-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/ccd-admin-web/merges","archive_url":"https://api.github.com/repos/hmcts/ccd-admin-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/ccd-admin-web/downloads","issues_url":"https://api.github.com/repos/hmcts/ccd-admin-web/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/ccd-admin-web/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/ccd-admin-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/ccd-admin-web/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/ccd-admin-web/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/ccd-admin-web/deployments","created_at":"2018-04-10T10:02:58Z","updated_at":"2018-08-09T08:53:45Z","pushed_at":"2018-08-09T08:53:53Z","git_url":"git://github.com/hmcts/ccd-admin-web.git","ssh_url":"git@github.com:hmcts/ccd-admin-web.git","clone_url":"https://github.com/hmcts/ccd-admin-web.git","svn_url":"https://github.com/hmcts/ccd-admin-web","homepage":null,"size":1957,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33"},"html":{"href":"https://github.com/hmcts/ccd-admin-web/pull/33"},"issue":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/33"},"comments":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/ccd-admin-web/statuses/abffd2a21de0c489bebf31d7cadb0744863f9a56"}},"author_association":"CONTRIBUTOR"}} | {
"id": 128912469,
"name": "hmcts/ccd-admin-web",
"url": "https://api.github.com/repos/hmcts/ccd-admin-web"
} | {
"id": 7723785,
"login": "mohammedanas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7723785?",
"url": "https://api.github.com/users/mohammedanas"
} | {
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
} | 2018-08-09T10:10:29 | 8089222988 | {"actor":{"display_login":"mohammedanas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/comments/204602359","pull_request_review_id":139709529,"id":204602359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYwMjM1OQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+class MoneyView{","path":"js/MoneyView.js","position":1,"original_position":1,"commit_id":"effc7b4313cae05b8a81bd4d7d10e7f6669bdbd8","original_commit_id":"effc7b4313cae05b8a81bd4d7d10e7f6669bdbd8","user":{"login":"nigayo","id":1456761,"node_id":"MDQ6VXNlcjE0NTY3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1456761?v=4","gravatar_id":"","url":"https://api.github.com/users/nigayo","html_url":"https://github.com/nigayo","followers_url":"https://api.github.com/users/nigayo/followers","following_url":"https://api.github.com/users/nigayo/following{/other_user}","gists_url":"https://api.github.com/users/nigayo/gists{/gist_id}","starred_url":"https://api.github.com/users/nigayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigayo/subscriptions","organizations_url":"https://api.github.com/users/nigayo/orgs","repos_url":"https://api.github.com/users/nigayo/repos","events_url":"https://api.github.com/users/nigayo/events{/privacy}","received_events_url":"https://api.github.com/users/nigayo/received_events","type":"User","site_admin":false},"body":"클래스의 크기는 작지만 하는일이 명확하고 분리할 수 있다고 생각해요.\r\nview의 크기는 이렇게 작을수도 있음.","created_at":"2018-07-24T01:46:11Z","updated_at":"2018-07-24T01:51:30Z","html_url":"https://github.com/code-squad/javascript-vm/pull/59#discussion_r204602359","pull_request_url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/comments/204602359"},"html":{"href":"https://github.com/code-squad/javascript-vm/pull/59#discussion_r204602359"},"pull_request":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59","id":203230286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjMwMjg2","html_url":"https://github.com/code-squad/javascript-vm/pull/59","diff_url":"https://github.com/code-squad/javascript-vm/pull/59.diff","patch_url":"https://github.com/code-squad/javascript-vm/pull/59.patch","issue_url":"https://api.github.com/repos/code-squad/javascript-vm/issues/59","number":59,"state":"open","locked":false,"title":"[woogie]지갑에서 돈 선택STEP4","user":{"login":"Imdonguk","id":36391296,"node_id":"MDQ6VXNlcjM2MzkxMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/36391296?v=4","gravatar_id":"","url":"https://api.github.com/users/Imdonguk","html_url":"https://github.com/Imdonguk","followers_url":"https://api.github.com/users/Imdonguk/followers","following_url":"https://api.github.com/users/Imdonguk/following{/other_user}","gists_url":"https://api.github.com/users/Imdonguk/gists{/gist_id}","starred_url":"https://api.github.com/users/Imdonguk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Imdonguk/subscriptions","organizations_url":"https://api.github.com/users/Imdonguk/orgs","repos_url":"https://api.github.com/users/Imdonguk/repos","events_url":"https://api.github.com/users/Imdonguk/events{/privacy}","received_events_url":"https://api.github.com/users/Imdonguk/received_events","type":"User","site_admin":false},"body":"## 오른쪽에 동전버튼을 클릭했을 때\r\n1. 넣은 동전의 개수가 몇 개인지 표시합니다.\r\n2. 넣은 동전의 금액만큼 바로 지갑에 있는 돈이 빠져나갑니다.\r\n3. 넣은 동전의 금액만큼 자판기에 추가됩니다.\r\n4. 콘솔창에 선택한 동전과 현재 금액, 넣은 금액을 표시하였습니다.","created_at":"2018-07-23T14:04:21Z","updated_at":"2018-07-24T01:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b82c3c0317af01d866576b5c491037fefb57b188","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59/commits","review_comments_url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59/comments","review_comment_url":"https://api.github.com/repos/code-squad/javascript-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/javascript-vm/issues/59/comments","statuses_url":"https://api.github.com/repos/code-squad/javascript-vm/statuses/effc7b4313cae05b8a81bd4d7d10e7f6669bdbd8","head":{"label":"Imdonguk:step4","ref":"step4","sha":"effc7b4313cae05b8a81bd4d7d10e7f6669bdbd8","user":{"login":"Imdonguk","id":36391296,"node_id":"MDQ6VXNlcjM2MzkxMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/36391296?v=4","gravatar_id":"","url":"https://api.github.com/users/Imdonguk","html_url":"https://github.com/Imdonguk","followers_url":"https://api.github.com/users/Imdonguk/followers","following_url":"https://api.github.com/users/Imdonguk/following{/other_user}","gists_url":"https://api.github.com/users/Imdonguk/gists{/gist_id}","starred_url":"https://api.github.com/users/Imdonguk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Imdonguk/subscriptions","organizations_url":"https://api.github.com/users/Imdonguk/orgs","repos_url":"https://api.github.com/users/Imdonguk/repos","events_url":"https://api.github.com/users/Imdonguk/events{/privacy}","received_events_url":"https://api.github.com/users/Imdonguk/received_events","type":"User","site_admin":false},"repo":{"id":137021580,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMjE1ODA=","name":"javascript-vm","full_name":"Imdonguk/javascript-vm","owner":{"login":"Imdonguk","id":36391296,"node_id":"MDQ6VXNlcjM2MzkxMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/36391296?v=4","gravatar_id":"","url":"https://api.github.com/users/Imdonguk","html_url":"https://github.com/Imdonguk","followers_url":"https://api.github.com/users/Imdonguk/followers","following_url":"https://api.github.com/users/Imdonguk/following{/other_user}","gists_url":"https://api.github.com/users/Imdonguk/gists{/gist_id}","starred_url":"https://api.github.com/users/Imdonguk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Imdonguk/subscriptions","organizations_url":"https://api.github.com/users/Imdonguk/orgs","repos_url":"https://api.github.com/users/Imdonguk/repos","events_url":"https://api.github.com/users/Imdonguk/events{/privacy}","received_events_url":"https://api.github.com/users/Imdonguk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Imdonguk/javascript-vm","description":"레벨3","fork":true,"url":"https://api.github.com/repos/Imdonguk/javascript-vm","forks_url":"https://api.github.com/repos/Imdonguk/javascript-vm/forks","keys_url":"https://api.github.com/repos/Imdonguk/javascript-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Imdonguk/javascript-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Imdonguk/javascript-vm/teams","hooks_url":"https://api.github.com/repos/Imdonguk/javascript-vm/hooks","issue_events_url":"https://api.github.com/repos/Imdonguk/javascript-vm/issues/events{/number}","events_url":"https://api.github.com/repos/Imdonguk/javascript-vm/events","assignees_url":"https://api.github.com/repos/Imdonguk/javascript-vm/assignees{/user}","branches_url":"https://api.github.com/repos/Imdonguk/javascript-vm/branches{/branch}","tags_url":"https://api.github.com/repos/Imdonguk/javascript-vm/tags","blobs_url":"https://api.github.com/repos/Imdonguk/javascript-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Imdonguk/javascript-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Imdonguk/javascript-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Imdonguk/javascript-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Imdonguk/javascript-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/Imdonguk/javascript-vm/languages","stargazers_url":"https://api.github.com/repos/Imdonguk/javascript-vm/stargazers","contributors_url":"https://api.github.com/repos/Imdonguk/javascript-vm/contributors","subscribers_url":"https://api.github.com/repos/Imdonguk/javascript-vm/subscribers","subscription_url":"https://api.github.com/repos/Imdonguk/javascript-vm/subscription","commits_url":"https://api.github.com/repos/Imdonguk/javascript-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Imdonguk/javascript-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Imdonguk/javascript-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Imdonguk/javascript-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Imdonguk/javascript-vm/contents/{+path}","compare_url":"https://api.github.com/repos/Imdonguk/javascript-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Imdonguk/javascript-vm/merges","archive_url":"https://api.github.com/repos/Imdonguk/javascript-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Imdonguk/javascript-vm/downloads","issues_url":"https://api.github.com/repos/Imdonguk/javascript-vm/issues{/number}","pulls_url":"https://api.github.com/repos/Imdonguk/javascript-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/Imdonguk/javascript-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/Imdonguk/javascript-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Imdonguk/javascript-vm/labels{/name}","releases_url":"https://api.github.com/repos/Imdonguk/javascript-vm/releases{/id}","deployments_url":"https://api.github.com/repos/Imdonguk/javascript-vm/deployments","created_at":"2018-06-12T05:30:30Z","updated_at":"2018-06-12T05:30:32Z","pushed_at":"2018-07-23T13:59:37Z","git_url":"git://github.com/Imdonguk/javascript-vm.git","ssh_url":"git@github.com:Imdonguk/javascript-vm.git","clone_url":"https://github.com/Imdonguk/javascript-vm.git","svn_url":"https://github.com/Imdonguk/javascript-vm","homepage":"","size":16653,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:Imdonguk","ref":"Imdonguk","sha":"786fdf7379a61e436a93b6b6036f88b11fdf73fb","user":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":107010265,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwMTAyNjU=","name":"javascript-vm","full_name":"code-squad/javascript-vm","owner":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-squad/javascript-vm","description":"레벨3","fork":false,"url":"https://api.github.com/repos/code-squad/javascript-vm","forks_url":"https://api.github.com/repos/code-squad/javascript-vm/forks","keys_url":"https://api.github.com/repos/code-squad/javascript-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/javascript-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/javascript-vm/teams","hooks_url":"https://api.github.com/repos/code-squad/javascript-vm/hooks","issue_events_url":"https://api.github.com/repos/code-squad/javascript-vm/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/javascript-vm/events","assignees_url":"https://api.github.com/repos/code-squad/javascript-vm/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/javascript-vm/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/javascript-vm/tags","blobs_url":"https://api.github.com/repos/code-squad/javascript-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/javascript-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/javascript-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/javascript-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/javascript-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/javascript-vm/languages","stargazers_url":"https://api.github.com/repos/code-squad/javascript-vm/stargazers","contributors_url":"https://api.github.com/repos/code-squad/javascript-vm/contributors","subscribers_url":"https://api.github.com/repos/code-squad/javascript-vm/subscribers","subscription_url":"https://api.github.com/repos/code-squad/javascript-vm/subscription","commits_url":"https://api.github.com/repos/code-squad/javascript-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/javascript-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/javascript-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/javascript-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/javascript-vm/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/javascript-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/javascript-vm/merges","archive_url":"https://api.github.com/repos/code-squad/javascript-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/javascript-vm/downloads","issues_url":"https://api.github.com/repos/code-squad/javascript-vm/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/javascript-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/javascript-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/javascript-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/javascript-vm/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/javascript-vm/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/javascript-vm/deployments","created_at":"2017-10-15T12:29:59Z","updated_at":"2018-05-09T06:08:27Z","pushed_at":"2018-07-23T14:04:21Z","git_url":"git://github.com/code-squad/javascript-vm.git","ssh_url":"git@github.com:code-squad/javascript-vm.git","clone_url":"https://github.com/code-squad/javascript-vm.git","svn_url":"https://github.com/code-squad/javascript-vm","homepage":"","size":24770,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":15,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59"},"html":{"href":"https://github.com/code-squad/javascript-vm/pull/59"},"issue":{"href":"https://api.github.com/repos/code-squad/javascript-vm/issues/59"},"comments":{"href":"https://api.github.com/repos/code-squad/javascript-vm/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/javascript-vm/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/javascript-vm/statuses/effc7b4313cae05b8a81bd4d7d10e7f6669bdbd8"}},"author_association":"NONE"}} | {
"id": 107010265,
"name": "code-squad/javascript-vm",
"url": "https://api.github.com/repos/code-squad/javascript-vm"
} | {
"id": 1456761,
"login": "nigayo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1456761?",
"url": "https://api.github.com/users/nigayo"
} | {
"id": 22832280,
"login": "code-squad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22832280?",
"url": "https://api.github.com/orgs/code-squad"
} | 2018-07-24T01:46:11 | 8007340129 | {"actor":{"display_login":"nigayo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/221978799","pull_request_review_id":160755115,"id":221978799,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk3ODc5OQ==","diff_hunk":"@@ -177,10 +177,11 @@ echo \"Inserting concept table data ... \"\n bq --quiet --project=$BQ_PROJECT query --nouse_legacy_sql \\\n \"INSERT INTO \\`$WORKBENCH_PROJECT.$WORKBENCH_DATASET.concept\\`\n (concept_id, concept_name, domain_id, vocabulary_id, concept_class_id, standard_concept,\n-concept_code, count_value, prevalence, source_count_value)\n-SELECT c.concept_id, c.concept_name, c.domain_id, c.vocabulary_id, c.concept_class_id, c.standard_concept, c.concept_code,\n-0 as count_value , 0.0 as prevalence, 0 as source_count_value\n-from \\`$BQ_PROJECT.$BQ_DATASET.concept\\` c\"\n+concept_code, count_value, prevalence, source_count_value, synonyms)\n+select c.concept_id, c.concept_name, c.domain_id, c.vocabulary_id, c.concept_class_id, c.standard_concept, c.concept_code,\n+0 as count_value , 0.0 as prevalence, 0 as source_count_value,concat(cast(c.concept_id as string),'\\\\|',c.vocabulary_id,':',c.concept_code,'\\\\|',c.concept_name,'\\\\|',string_agg(cs.concept_synonym_name,'\\\\|')) as synonyms","path":"api/db-cdr/generate-cdr/make-bq-data.sh","position":19,"original_position":19,"commit_id":"d7112246b46bcf0739a98ed421fb5a1506e57149","original_commit_id":"d7112246b46bcf0739a98ed421fb5a1506e57149","user":{"login":"danqrodney","id":12536316,"node_id":"MDQ6VXNlcjEyNTM2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"So it looks like the delimiter is now \\| instead of |?\r\n\r\nThat's OK, and this definitely reduces the chance of the delimiter appearing in a concept name or synonym, though it's still technically possible. If we wanted to avoid any possibility of this happening, what you'd do is escape occurrences of the delimiter in concept names or synonyms... so you could (for example) use | as the delimiter but replace all occurrences of | with || or whatever.\r\n\r\nAnyway... I think this combination of characters is sufficiently unlikely to occur that we should be OK.","created_at":"2018-10-02T14:40:11Z","updated_at":"2018-10-02T14:46:34Z","html_url":"https://github.com/all-of-us/workbench/pull/1255#discussion_r221978799","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/1255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/221978799"},"html":{"href":"https://github.com/all-of-us/workbench/pull/1255#discussion_r221978799"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/1255"}}},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/1255","id":219074012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDc0MDEy","html_url":"https://github.com/all-of-us/workbench/pull/1255","diff_url":"https://github.com/all-of-us/workbench/pull/1255.diff","patch_url":"https://github.com/all-of-us/workbench/pull/1255.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/1255","number":1255,"state":"open","locked":false,"title":"concept synonym domain vocabu info data changes [risk=low]","user":{"login":"SrushtiGangireddy","id":21062724,"node_id":"MDQ6VXNlcjIxMDYyNzI0","avatar_url":"https://avatars1.githubusercontent.com/u/21062724?v=4","gravatar_id":"","url":"https://api.github.com/users/SrushtiGangireddy","html_url":"https://github.com/SrushtiGangireddy","followers_url":"https://api.github.com/users/SrushtiGangireddy/followers","following_url":"https://api.github.com/users/SrushtiGangireddy/following{/other_user}","gists_url":"https://api.github.com/users/SrushtiGangireddy/gists{/gist_id}","starred_url":"https://api.github.com/users/SrushtiGangireddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SrushtiGangireddy/subscriptions","organizations_url":"https://api.github.com/users/SrushtiGangireddy/orgs","repos_url":"https://api.github.com/users/SrushtiGangireddy/repos","events_url":"https://api.github.com/users/SrushtiGangireddy/events{/privacy}","received_events_url":"https://api.github.com/users/SrushtiGangireddy/received_events","type":"User","site_admin":false},"body":"1. Update the synonym column in concept table to quicken the search.\r\n2. Fill in counts of domain vocabulary info table.\r\n3. Round up the counts to bins of 20 instead of to nearest integer in public data.","created_at":"2018-09-28T20:13:22Z","updated_at":"2018-10-02T14:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a1fd9af4ad1aa450e689a17804e83dd47025d9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/1255/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/1255/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/1255/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/d7112246b46bcf0739a98ed421fb5a1506e57149","head":{"label":"all-of-us:SrushtiGangireddy/ConceptSynonym_DomainVocabuInfo_DataChanges","ref":"SrushtiGangireddy/ConceptSynonym_DomainVocabuInfo_DataChanges","sha":"d7112246b46bcf0739a98ed421fb5a1506e57149","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/workbench","description":"All of Us Researcher Workbench","fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-10-01T22:14:36Z","pushed_at":"2018-10-02T13:34:34Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":"","size":200569,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":12,"watchers":7,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"22ebf1a32fa2f6f99d68221b03671b857dfe11a3","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/workbench","description":"All of Us Researcher Workbench","fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-10-01T22:14:36Z","pushed_at":"2018-10-02T13:34:34Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":"","size":200569,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/1255"},"html":{"href":"https://github.com/all-of-us/workbench/pull/1255"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/1255"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/1255/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/1255/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/1255/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/d7112246b46bcf0739a98ed421fb5a1506e57149"}},"author_association":"COLLABORATOR"}} | {
"id": 95247186,
"name": "all-of-us/workbench",
"url": "https://api.github.com/repos/all-of-us/workbench"
} | {
"id": 12536316,
"login": "danqrodney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12536316?",
"url": "https://api.github.com/users/danqrodney"
} | {
"id": 22846942,
"login": "all-of-us",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22846942?",
"url": "https://api.github.com/orgs/all-of-us"
} | 2018-10-02T14:40:11 | 8355042345 | {"actor":{"display_login":"danqrodney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/comments/173813633","pull_request_review_id":103063285,"id":173813633,"diff_hunk":"@@ -11,7 +11,7 @@\n \n ARGUMENTS=$@\n if [ -z \"$ARGUMENTS\" ]; then\n- ARGUMENTS=`go list ./...`\n+ ARGUMENTS=`go list ./... | sed '/e2e/d'` #skip e2e package - integration tests by default","path":"bin/test","position":5,"original_position":5,"commit_id":"ca5551760d766b4f380b3c96505db790c48b56ed","original_commit_id":"14826ff96756b77f1f195f0c3a15213ecb77f4f5","user":{"login":"tadovas","id":1046590,"avatar_url":"https://avatars3.githubusercontent.com/u/1046590?v=4","gravatar_id":"","url":"https://api.github.com/users/tadovas","html_url":"https://github.com/tadovas","followers_url":"https://api.github.com/users/tadovas/followers","following_url":"https://api.github.com/users/tadovas/following{/other_user}","gists_url":"https://api.github.com/users/tadovas/gists{/gist_id}","starred_url":"https://api.github.com/users/tadovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadovas/subscriptions","organizations_url":"https://api.github.com/users/tadovas/orgs","repos_url":"https://api.github.com/users/tadovas/repos","events_url":"https://api.github.com/users/tadovas/events{/privacy}","received_events_url":"https://api.github.com/users/tadovas/received_events","type":"User","site_admin":false},"body":"Yea will need to investigate further - maybe some other time.","created_at":"2018-03-12T14:23:52Z","updated_at":"2018-03-12T14:23:53Z","html_url":"https://github.com/MysteriumNetwork/node/pull/195#discussion_r173813633","pull_request_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/comments/173813633"},"html":{"href":"https://github.com/MysteriumNetwork/node/pull/195#discussion_r173813633"},"pull_request":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195"}},"in_reply_to_id":173188673},"pull_request":{"url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195","id":173676960,"html_url":"https://github.com/MysteriumNetwork/node/pull/195","diff_url":"https://github.com/MysteriumNetwork/node/pull/195.diff","patch_url":"https://github.com/MysteriumNetwork/node/pull/195.patch","issue_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/195","number":195,"state":"open","locked":false,"title":"Feature/enable-e2e-tests-on-pull-requests","user":{"login":"tadovas","id":1046590,"avatar_url":"https://avatars3.githubusercontent.com/u/1046590?v=4","gravatar_id":"","url":"https://api.github.com/users/tadovas","html_url":"https://github.com/tadovas","followers_url":"https://api.github.com/users/tadovas/followers","following_url":"https://api.github.com/users/tadovas/following{/other_user}","gists_url":"https://api.github.com/users/tadovas/gists{/gist_id}","starred_url":"https://api.github.com/users/tadovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadovas/subscriptions","organizations_url":"https://api.github.com/users/tadovas/orgs","repos_url":"https://api.github.com/users/tadovas/repos","events_url":"https://api.github.com/users/tadovas/events{/privacy}","received_events_url":"https://api.github.com/users/tadovas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-08T08:49:53Z","updated_at":"2018-03-12T14:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"118de9a44f4629842d8859a932801db909509dfc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shroomist","id":95058,"avatar_url":"https://avatars3.githubusercontent.com/u/95058?v=4","gravatar_id":"","url":"https://api.github.com/users/shroomist","html_url":"https://github.com/shroomist","followers_url":"https://api.github.com/users/shroomist/followers","following_url":"https://api.github.com/users/shroomist/following{/other_user}","gists_url":"https://api.github.com/users/shroomist/gists{/gist_id}","starred_url":"https://api.github.com/users/shroomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shroomist/subscriptions","organizations_url":"https://api.github.com/users/shroomist/orgs","repos_url":"https://api.github.com/users/shroomist/repos","events_url":"https://api.github.com/users/shroomist/events{/privacy}","received_events_url":"https://api.github.com/users/shroomist/received_events","type":"User","site_admin":false},{"login":"ignasbernotas","id":402965,"avatar_url":"https://avatars2.githubusercontent.com/u/402965?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasbernotas","html_url":"https://github.com/ignasbernotas","followers_url":"https://api.github.com/users/ignasbernotas/followers","following_url":"https://api.github.com/users/ignasbernotas/following{/other_user}","gists_url":"https://api.github.com/users/ignasbernotas/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasbernotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasbernotas/subscriptions","organizations_url":"https://api.github.com/users/ignasbernotas/orgs","repos_url":"https://api.github.com/users/ignasbernotas/repos","events_url":"https://api.github.com/users/ignasbernotas/events{/privacy}","received_events_url":"https://api.github.com/users/ignasbernotas/received_events","type":"User","site_admin":false},{"login":"interro","id":1106290,"avatar_url":"https://avatars3.githubusercontent.com/u/1106290?v=4","gravatar_id":"","url":"https://api.github.com/users/interro","html_url":"https://github.com/interro","followers_url":"https://api.github.com/users/interro/followers","following_url":"https://api.github.com/users/interro/following{/other_user}","gists_url":"https://api.github.com/users/interro/gists{/gist_id}","starred_url":"https://api.github.com/users/interro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interro/subscriptions","organizations_url":"https://api.github.com/users/interro/orgs","repos_url":"https://api.github.com/users/interro/repos","events_url":"https://api.github.com/users/interro/events{/privacy}","received_events_url":"https://api.github.com/users/interro/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195/commits","review_comments_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195/comments","review_comment_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/195/comments","statuses_url":"https://api.github.com/repos/MysteriumNetwork/node/statuses/ca5551760d766b4f380b3c96505db790c48b56ed","head":{"label":"MysteriumNetwork:feature/master-integration-tests","ref":"feature/master-integration-tests","sha":"ca5551760d766b4f380b3c96505db790c48b56ed","user":{"login":"MysteriumNetwork","id":23056638,"avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"name":"node","full_name":"MysteriumNetwork/node","owner":{"login":"MysteriumNetwork","id":23056638,"avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MysteriumNetwork/node","description":"Decentralised VPN built on blockchain","fork":false,"url":"https://api.github.com/repos/MysteriumNetwork/node","forks_url":"https://api.github.com/repos/MysteriumNetwork/node/forks","keys_url":"https://api.github.com/repos/MysteriumNetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MysteriumNetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MysteriumNetwork/node/teams","hooks_url":"https://api.github.com/repos/MysteriumNetwork/node/hooks","issue_events_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/MysteriumNetwork/node/events","assignees_url":"https://api.github.com/repos/MysteriumNetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/MysteriumNetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/MysteriumNetwork/node/tags","blobs_url":"https://api.github.com/repos/MysteriumNetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MysteriumNetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MysteriumNetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/MysteriumNetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MysteriumNetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/MysteriumNetwork/node/languages","stargazers_url":"https://api.github.com/repos/MysteriumNetwork/node/stargazers","contributors_url":"https://api.github.com/repos/MysteriumNetwork/node/contributors","subscribers_url":"https://api.github.com/repos/MysteriumNetwork/node/subscribers","subscription_url":"https://api.github.com/repos/MysteriumNetwork/node/subscription","commits_url":"https://api.github.com/repos/MysteriumNetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/MysteriumNetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/MysteriumNetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/MysteriumNetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/MysteriumNetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MysteriumNetwork/node/merges","archive_url":"https://api.github.com/repos/MysteriumNetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MysteriumNetwork/node/downloads","issues_url":"https://api.github.com/repos/MysteriumNetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/MysteriumNetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/MysteriumNetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MysteriumNetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/MysteriumNetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/MysteriumNetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2018-03-12T14:23:09Z","pushed_at":"2018-03-12T14:22:25Z","git_url":"git://github.com/MysteriumNetwork/node.git","ssh_url":"git@github.com:MysteriumNetwork/node.git","clone_url":"https://github.com/MysteriumNetwork/node.git","svn_url":"https://github.com/MysteriumNetwork/node","homepage":"https://mysterium.network/","size":2901,"stargazers_count":398,"watchers_count":398,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":52,"open_issues":17,"watchers":398,"default_branch":"master"}},"base":{"label":"MysteriumNetwork:master","ref":"master","sha":"d0a0850ad5f2f1b250472279ac61fb2c93892e8e","user":{"login":"MysteriumNetwork","id":23056638,"avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":80073079,"name":"node","full_name":"MysteriumNetwork/node","owner":{"login":"MysteriumNetwork","id":23056638,"avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MysteriumNetwork/node","description":"Decentralised VPN built on blockchain","fork":false,"url":"https://api.github.com/repos/MysteriumNetwork/node","forks_url":"https://api.github.com/repos/MysteriumNetwork/node/forks","keys_url":"https://api.github.com/repos/MysteriumNetwork/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MysteriumNetwork/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MysteriumNetwork/node/teams","hooks_url":"https://api.github.com/repos/MysteriumNetwork/node/hooks","issue_events_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/events{/number}","events_url":"https://api.github.com/repos/MysteriumNetwork/node/events","assignees_url":"https://api.github.com/repos/MysteriumNetwork/node/assignees{/user}","branches_url":"https://api.github.com/repos/MysteriumNetwork/node/branches{/branch}","tags_url":"https://api.github.com/repos/MysteriumNetwork/node/tags","blobs_url":"https://api.github.com/repos/MysteriumNetwork/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MysteriumNetwork/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MysteriumNetwork/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/MysteriumNetwork/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MysteriumNetwork/node/statuses/{sha}","languages_url":"https://api.github.com/repos/MysteriumNetwork/node/languages","stargazers_url":"https://api.github.com/repos/MysteriumNetwork/node/stargazers","contributors_url":"https://api.github.com/repos/MysteriumNetwork/node/contributors","subscribers_url":"https://api.github.com/repos/MysteriumNetwork/node/subscribers","subscription_url":"https://api.github.com/repos/MysteriumNetwork/node/subscription","commits_url":"https://api.github.com/repos/MysteriumNetwork/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/MysteriumNetwork/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/MysteriumNetwork/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/MysteriumNetwork/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/MysteriumNetwork/node/contents/{+path}","compare_url":"https://api.github.com/repos/MysteriumNetwork/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MysteriumNetwork/node/merges","archive_url":"https://api.github.com/repos/MysteriumNetwork/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MysteriumNetwork/node/downloads","issues_url":"https://api.github.com/repos/MysteriumNetwork/node/issues{/number}","pulls_url":"https://api.github.com/repos/MysteriumNetwork/node/pulls{/number}","milestones_url":"https://api.github.com/repos/MysteriumNetwork/node/milestones{/number}","notifications_url":"https://api.github.com/repos/MysteriumNetwork/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MysteriumNetwork/node/labels{/name}","releases_url":"https://api.github.com/repos/MysteriumNetwork/node/releases{/id}","deployments_url":"https://api.github.com/repos/MysteriumNetwork/node/deployments","created_at":"2017-01-26T00:43:08Z","updated_at":"2018-03-12T14:23:09Z","pushed_at":"2018-03-12T14:22:25Z","git_url":"git://github.com/MysteriumNetwork/node.git","ssh_url":"git@github.com:MysteriumNetwork/node.git","clone_url":"https://github.com/MysteriumNetwork/node.git","svn_url":"https://github.com/MysteriumNetwork/node","homepage":"https://mysterium.network/","size":2901,"stargazers_count":398,"watchers_count":398,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":52,"open_issues":17,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195"},"html":{"href":"https://github.com/MysteriumNetwork/node/pull/195"},"issue":{"href":"https://api.github.com/repos/MysteriumNetwork/node/issues/195"},"comments":{"href":"https://api.github.com/repos/MysteriumNetwork/node/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MysteriumNetwork/node/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/MysteriumNetwork/node/statuses/ca5551760d766b4f380b3c96505db790c48b56ed"}},"author_association":"MEMBER"}} | {
"id": 80073079,
"name": "MysteriumNetwork/node",
"url": "https://api.github.com/repos/MysteriumNetwork/node"
} | {
"id": 1046590,
"login": "tadovas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1046590?",
"url": "https://api.github.com/users/tadovas"
} | {
"id": 23056638,
"login": "MysteriumNetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23056638?",
"url": "https://api.github.com/orgs/MysteriumNetwork"
} | 2018-03-12T14:23:52 | 7365970910 | {"actor":{"display_login":"tadovas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/comments/188906911","pull_request_review_id":120972200,"id":188906911,"diff_hunk":"@@ -0,0 +1,12 @@\n+<?php\n+\n+use Slim\\Http\\Request;","path":"src/routes.php","position":3,"original_position":3,"commit_id":"366ca20ce25f35c96711dd2ec86b578c8e096aaa","original_commit_id":"366ca20ce25f35c96711dd2ec86b578c8e096aaa","user":{"login":"mporam","id":6569497,"avatar_url":"https://avatars2.githubusercontent.com/u/6569497?v=4","gravatar_id":"","url":"https://api.github.com/users/mporam","html_url":"https://github.com/mporam","followers_url":"https://api.github.com/users/mporam/followers","following_url":"https://api.github.com/users/mporam/following{/other_user}","gists_url":"https://api.github.com/users/mporam/gists{/gist_id}","starred_url":"https://api.github.com/users/mporam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mporam/subscriptions","organizations_url":"https://api.github.com/users/mporam/orgs","repos_url":"https://api.github.com/users/mporam/repos","events_url":"https://api.github.com/users/mporam/events{/privacy}","received_events_url":"https://api.github.com/users/mporam/received_events","type":"User","site_admin":false},"body":"dont need these anymore","created_at":"2018-05-17T10:13:54Z","updated_at":"2018-05-17T10:16:03Z","html_url":"https://github.com/Mayden-Academy/AcademyPortal/pull/12#discussion_r188906911","pull_request_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/comments/188906911"},"html":{"href":"https://github.com/Mayden-Academy/AcademyPortal/pull/12#discussion_r188906911"},"pull_request":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12","id":188444194,"html_url":"https://github.com/Mayden-Academy/AcademyPortal/pull/12","diff_url":"https://github.com/Mayden-Academy/AcademyPortal/pull/12.diff","patch_url":"https://github.com/Mayden-Academy/AcademyPortal/pull/12.patch","issue_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/12","number":12,"state":"open","locked":false,"title":"Story1 login authentication","user":{"login":"nsantiagoblair","id":31820450,"avatar_url":"https://avatars2.githubusercontent.com/u/31820450?v=4","gravatar_id":"","url":"https://api.github.com/users/nsantiagoblair","html_url":"https://github.com/nsantiagoblair","followers_url":"https://api.github.com/users/nsantiagoblair/followers","following_url":"https://api.github.com/users/nsantiagoblair/following{/other_user}","gists_url":"https://api.github.com/users/nsantiagoblair/gists{/gist_id}","starred_url":"https://api.github.com/users/nsantiagoblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsantiagoblair/subscriptions","organizations_url":"https://api.github.com/users/nsantiagoblair/orgs","repos_url":"https://api.github.com/users/nsantiagoblair/repos","events_url":"https://api.github.com/users/nsantiagoblair/events{/privacy}","received_events_url":"https://api.github.com/users/nsantiagoblair/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-16T14:03:41Z","updated_at":"2018-05-17T10:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d36a285093ff21771357a34c20bf2666ae6a329c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/12/comments","statuses_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/statuses/366ca20ce25f35c96711dd2ec86b578c8e096aaa","head":{"label":"Mayden-Academy:story1-loginAuthentication","ref":"story1-loginAuthentication","sha":"366ca20ce25f35c96711dd2ec86b578c8e096aaa","user":{"login":"Mayden-Academy","id":23072457,"avatar_url":"https://avatars2.githubusercontent.com/u/23072457?v=4","gravatar_id":"","url":"https://api.github.com/users/Mayden-Academy","html_url":"https://github.com/Mayden-Academy","followers_url":"https://api.github.com/users/Mayden-Academy/followers","following_url":"https://api.github.com/users/Mayden-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Mayden-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayden-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayden-Academy/subscriptions","organizations_url":"https://api.github.com/users/Mayden-Academy/orgs","repos_url":"https://api.github.com/users/Mayden-Academy/repos","events_url":"https://api.github.com/users/Mayden-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Mayden-Academy/received_events","type":"Organization","site_admin":false},"repo":{"id":133332416,"name":"AcademyPortal","full_name":"Mayden-Academy/AcademyPortal","owner":{"login":"Mayden-Academy","id":23072457,"avatar_url":"https://avatars2.githubusercontent.com/u/23072457?v=4","gravatar_id":"","url":"https://api.github.com/users/Mayden-Academy","html_url":"https://github.com/Mayden-Academy","followers_url":"https://api.github.com/users/Mayden-Academy/followers","following_url":"https://api.github.com/users/Mayden-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Mayden-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayden-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayden-Academy/subscriptions","organizations_url":"https://api.github.com/users/Mayden-Academy/orgs","repos_url":"https://api.github.com/users/Mayden-Academy/repos","events_url":"https://api.github.com/users/Mayden-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Mayden-Academy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mayden-Academy/AcademyPortal","description":null,"fork":false,"url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal","forks_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/forks","keys_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/teams","hooks_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/hooks","issue_events_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/events{/number}","events_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/events","assignees_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/assignees{/user}","branches_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/branches{/branch}","tags_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/tags","blobs_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/statuses/{sha}","languages_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/languages","stargazers_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/stargazers","contributors_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/contributors","subscribers_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/subscribers","subscription_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/subscription","commits_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/contents/{+path}","compare_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/merges","archive_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/downloads","issues_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues{/number}","pulls_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls{/number}","milestones_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/milestones{/number}","notifications_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/labels{/name}","releases_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/releases{/id}","deployments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/deployments","created_at":"2018-05-14T08:54:04Z","updated_at":"2018-05-14T08:56:26Z","pushed_at":"2018-05-17T09:53:55Z","git_url":"git://github.com/Mayden-Academy/AcademyPortal.git","ssh_url":"git@github.com:Mayden-Academy/AcademyPortal.git","clone_url":"https://github.com/Mayden-Academy/AcademyPortal.git","svn_url":"https://github.com/Mayden-Academy/AcademyPortal","homepage":null,"size":100,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Mayden-Academy:master","ref":"master","sha":"64044d6177a9d5ee42ce525172c4814a9340cd0e","user":{"login":"Mayden-Academy","id":23072457,"avatar_url":"https://avatars2.githubusercontent.com/u/23072457?v=4","gravatar_id":"","url":"https://api.github.com/users/Mayden-Academy","html_url":"https://github.com/Mayden-Academy","followers_url":"https://api.github.com/users/Mayden-Academy/followers","following_url":"https://api.github.com/users/Mayden-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Mayden-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayden-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayden-Academy/subscriptions","organizations_url":"https://api.github.com/users/Mayden-Academy/orgs","repos_url":"https://api.github.com/users/Mayden-Academy/repos","events_url":"https://api.github.com/users/Mayden-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Mayden-Academy/received_events","type":"Organization","site_admin":false},"repo":{"id":133332416,"name":"AcademyPortal","full_name":"Mayden-Academy/AcademyPortal","owner":{"login":"Mayden-Academy","id":23072457,"avatar_url":"https://avatars2.githubusercontent.com/u/23072457?v=4","gravatar_id":"","url":"https://api.github.com/users/Mayden-Academy","html_url":"https://github.com/Mayden-Academy","followers_url":"https://api.github.com/users/Mayden-Academy/followers","following_url":"https://api.github.com/users/Mayden-Academy/following{/other_user}","gists_url":"https://api.github.com/users/Mayden-Academy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mayden-Academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mayden-Academy/subscriptions","organizations_url":"https://api.github.com/users/Mayden-Academy/orgs","repos_url":"https://api.github.com/users/Mayden-Academy/repos","events_url":"https://api.github.com/users/Mayden-Academy/events{/privacy}","received_events_url":"https://api.github.com/users/Mayden-Academy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mayden-Academy/AcademyPortal","description":null,"fork":false,"url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal","forks_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/forks","keys_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/teams","hooks_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/hooks","issue_events_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/events{/number}","events_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/events","assignees_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/assignees{/user}","branches_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/branches{/branch}","tags_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/tags","blobs_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/statuses/{sha}","languages_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/languages","stargazers_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/stargazers","contributors_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/contributors","subscribers_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/subscribers","subscription_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/subscription","commits_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/contents/{+path}","compare_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/merges","archive_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/downloads","issues_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues{/number}","pulls_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls{/number}","milestones_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/milestones{/number}","notifications_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/labels{/name}","releases_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/releases{/id}","deployments_url":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/deployments","created_at":"2018-05-14T08:54:04Z","updated_at":"2018-05-14T08:56:26Z","pushed_at":"2018-05-17T09:53:55Z","git_url":"git://github.com/Mayden-Academy/AcademyPortal.git","ssh_url":"git@github.com:Mayden-Academy/AcademyPortal.git","clone_url":"https://github.com/Mayden-Academy/AcademyPortal.git","svn_url":"https://github.com/Mayden-Academy/AcademyPortal","homepage":null,"size":100,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12"},"html":{"href":"https://github.com/Mayden-Academy/AcademyPortal/pull/12"},"issue":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/12"},"comments":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Mayden-Academy/AcademyPortal/statuses/366ca20ce25f35c96711dd2ec86b578c8e096aaa"}},"author_association":"NONE"}} | {
"id": 133332416,
"name": "Mayden-Academy/AcademyPortal",
"url": "https://api.github.com/repos/Mayden-Academy/AcademyPortal"
} | {
"id": 6569497,
"login": "mporam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6569497?",
"url": "https://api.github.com/users/mporam"
} | {
"id": 23072457,
"login": "Mayden-Academy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23072457?",
"url": "https://api.github.com/orgs/Mayden-Academy"
} | 2018-05-17T10:13:54 | 7688708602 | {"actor":{"display_login":"mporam"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum-doc/pulls/comments/222712549","pull_request_review_id":161665883,"id":222712549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjcxMjU0OQ==","diff_hunk":"@@ -0,0 +1,467 @@\n+# Managing Exonum Services with the Help of Light Client\n+\n+In our previous tutorials we covered the principle of structuring and operation\n+of the backend part of Exonum services. In this tutorial we intend to disclose\n+how the services interact and are managed with Exonum light client. For this\n+purpose we will mostly refer to the tutorial for the\n+[Service with Data Proofs](https://exonum.com/doc/get-started/data-proofs/) and\n+partly to the [Exonum Timestamping Demo](https://github.com/exonum/exonum/tree/master/examples/timestamping).\n+\n+Light client is a JavaScript library used for a number of purposes:\n+ - forming and sending transactions to the blockchain\n+ - creating digital signatures over transactions\n+ - obtaining and checking cryptographic proofs of data authenticity and\n+ integrity.\n+\n+Below we will provide you with the detailed description of how said\n+functionality is executed in Exonum light client.\n+\n+## Before You Start\n+\n+To start using Exonum light client, include [exonum-client](https://github.com/exonum/exonum-client#getting-started)\n+into your JavaScript application. Please refer to our detailed guide\n+for instructions on how to customize your client. The present tutorial will\n+show you the ready-made examples of the client use. \n+\n+## Execute a Transaction\n+\n+A transaction is an atomic operation that introduces changes to the blockchain\n+state. The structure, contents and number of transaction types within one\n+service vary depending on the business logic of each service.\n+\n+The general algorithm of executing a transaction in Exonum includes 4 stages:\n+- define transaction schema with its data types\n+- define transaction data\n+- generate a signing key pair (if required) and sign the transaction\n+- send transaction to the blockchain.\n+\n+!!! note\n+ In our Timestamping demo we generate a new signing key pair for each new\n+ timestamp. In the Service with Data Proofs we generate a key pair that\n+ corresponds to a certain wallet and its user and, thus, is applied for\n+ signing all transactions made on its behalf.\n+\n+Below we provide some examples of transaction execution in Exonum services.\n+\n+### Transaction for Creating a Wallet\n+\n+Define `CreateWallet` transaction schema and data types:\n+\n+```javascript\n+const CreateWallet = Exonum.newMessage({\n+ protocol_version: 0,\n+ service_id: 128,\n+ message_id: 2,\n+ fields: [\n+ { name: 'pub_key', type: Exonum.PublicKey },\n+ { name: 'name', type: Exonum.String }\n+ ]\n+})\n+```\n+\n+- `message_id` - represents the serial number of the transaction type in the\n+ service.\n+\n+Prepare transaction data according to the above-mentioned schema:\n+\n+```javascript\n+const data = {\n+ pub_key: keyPair.publicKey,\n+ name: name\n+}\n+```\n+\n+- `name` - represents name of a user owning the new wallet as String.\n+\n+Generate a new signing key pair for signing and sending the transaction. This\n+key pair will be further used for all the transactions executed in respect of\n+this wallet:\n+\n+```javascript\n+const keyPair = Exonum.keyPair()\n+```\n+\n+Sign the transaction with the obtained secret key:\n+\n+```javascript\n+const signature = CreateWallet.sign(keyPair.secretKey, data)\n+```\n+\n+Finally, send the resulted transaction into the blockchain:\n+\n+```javascript\n+CreateWallet.send(transactionEndpoint, explorerBasePath, data, signature)\n+```\n+\n+- `transactionEndpoint` - represents API address of transaction handler at a\n+ blockchain node\n+- `explorerBasePath` - represents API address of transaction explorer where your\n+ you can see transaction details at a blockchain node.\n+\n+### Transaction for Transferring Funds from One Wallet to Another\n+\n+To execute this type of transaction, obviously, you need to create at least two\n+wallets as described above.\n+\n+Define `TransferFunds` transaction schema and data types:\n+\n+```javascript\n+const TransferFunds = Exonum.newMessage({\n+ protocol_version: 0,\n+ service_id: 128,\n+ message_id: 0,\n+ fields: [\n+ { name: 'from', type: Exonum.PublicKey },\n+ { name: 'to', type: Exonum.PublicKey },\n+ { name: 'amount', type: Exonum.Uint64 },\n+ { name: 'seed', type: Exonum.Uint64 }\n+ ]\n+})\n+```\n+\n+As you might know from our very first Cryptocurrency demo, in order to\n+transfer funds from one wallet to another a \"seed\" is included into each\n+such transaction. This prevents transactions from being hacked by a third\n+person. You can generate seed as follows:\n+\n+```javascript\n+const seed = Exonum.randomUint64()\n+```\n+\n+Prepare transaction data according to the above-defined schema. Note that we\n+identify the sender by the public key of his wallet that was generated when\n+creating said wallet:\n+\n+```javascript\n+const data = {\n+ from: keyPair.publicKey,\n+ to: receiver,\n+ amount: amount,\n+ seed: seed\n+}\n+```\n+\n+- `receiver` - represents public key of the receiver's wallet\n+- `amount` - represents amount to be transferred from one wallet to the other\n+ passed as String\n+- `seed` - represents a random number of cryptographic quality.\n+\n+Now you can sign transaction with the sender's secret key from the key pair\n+generated when creating his wallet and send the resulted transaction into the","path":"src/get-started/light-client.md","position":null,"original_position":150,"commit_id":"0238db276b1b801cc2d90b887c50a1b839a4212d","original_commit_id":"15b09dacae4d419cf7c7112310cb8ec9029d073d","user":{"login":"boguslavsky","id":303763,"node_id":"MDQ6VXNlcjMwMzc2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/303763?v=4","gravatar_id":"","url":"https://api.github.com/users/boguslavsky","html_url":"https://github.com/boguslavsky","followers_url":"https://api.github.com/users/boguslavsky/followers","following_url":"https://api.github.com/users/boguslavsky/following{/other_user}","gists_url":"https://api.github.com/users/boguslavsky/gists{/gist_id}","starred_url":"https://api.github.com/users/boguslavsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boguslavsky/subscriptions","organizations_url":"https://api.github.com/users/boguslavsky/orgs","repos_url":"https://api.github.com/users/boguslavsky/repos","events_url":"https://api.github.com/users/boguslavsky/events{/privacy}","received_events_url":"https://api.github.com/users/boguslavsky/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-10-04T15:16:25Z","updated_at":"2018-10-04T15:16:25Z","html_url":"https://github.com/exonum/exonum-doc/pull/245#discussion_r222712549","pull_request_url":"https://api.github.com/repos/exonum/exonum-doc/pulls/245","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/comments/222712549"},"html":{"href":"https://github.com/exonum/exonum-doc/pull/245#discussion_r222712549"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/245"}},"in_reply_to_id":222659119},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum-doc/pulls/245","id":219395469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mzk1NDY5","html_url":"https://github.com/exonum/exonum-doc/pull/245","diff_url":"https://github.com/exonum/exonum-doc/pull/245.diff","patch_url":"https://github.com/exonum/exonum-doc/pull/245.patch","issue_url":"https://api.github.com/repos/exonum/exonum-doc/issues/245","number":245,"state":"open","locked":false,"title":"Tutorial on interraction of the Exonum Light Client with Exonum services","user":{"login":"Maria-Nosyk","id":29862040,"node_id":"MDQ6VXNlcjI5ODYyMDQw","avatar_url":"https://avatars3.githubusercontent.com/u/29862040?v=4","gravatar_id":"","url":"https://api.github.com/users/Maria-Nosyk","html_url":"https://github.com/Maria-Nosyk","followers_url":"https://api.github.com/users/Maria-Nosyk/followers","following_url":"https://api.github.com/users/Maria-Nosyk/following{/other_user}","gists_url":"https://api.github.com/users/Maria-Nosyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Maria-Nosyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maria-Nosyk/subscriptions","organizations_url":"https://api.github.com/users/Maria-Nosyk/orgs","repos_url":"https://api.github.com/users/Maria-Nosyk/repos","events_url":"https://api.github.com/users/Maria-Nosyk/events{/privacy}","received_events_url":"https://api.github.com/users/Maria-Nosyk/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease target the following branch:\r\n- `master` if your pull request fixes bugs in the documentation, describes\r\n released features, etc. In other words,\r\n a pull request targeting `master` should be possible to merge and\r\n push to https://exonum.com/doc/ at any time.\r\n- `develop` if your pull request describes features introduced into an upcoming\r\n version of Exonum. A request targeting `develop` should be pushed to\r\n https://exonum.com/doc/ no earlier than this upcoming version is released.\r\n-->\r\n","created_at":"2018-10-01T14:25:19Z","updated_at":"2018-10-04T15:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4b9432884d4a91acf89ed3d681389329a771c8a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qvantor","id":9914154,"node_id":"MDQ6VXNlcjk5MTQxNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9914154?v=4","gravatar_id":"","url":"https://api.github.com/users/qvantor","html_url":"https://github.com/qvantor","followers_url":"https://api.github.com/users/qvantor/followers","following_url":"https://api.github.com/users/qvantor/following{/other_user}","gists_url":"https://api.github.com/users/qvantor/gists{/gist_id}","starred_url":"https://api.github.com/users/qvantor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qvantor/subscriptions","organizations_url":"https://api.github.com/users/qvantor/orgs","repos_url":"https://api.github.com/users/qvantor/repos","events_url":"https://api.github.com/users/qvantor/events{/privacy}","received_events_url":"https://api.github.com/users/qvantor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum-doc/pulls/245/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum-doc/pulls/245/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum-doc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum-doc/issues/245/comments","statuses_url":"https://api.github.com/repos/exonum/exonum-doc/statuses/0238db276b1b801cc2d90b887c50a1b839a4212d","head":{"label":"Maria-Nosyk:light-client","ref":"light-client","sha":"0238db276b1b801cc2d90b887c50a1b839a4212d","user":{"login":"Maria-Nosyk","id":29862040,"node_id":"MDQ6VXNlcjI5ODYyMDQw","avatar_url":"https://avatars3.githubusercontent.com/u/29862040?v=4","gravatar_id":"","url":"https://api.github.com/users/Maria-Nosyk","html_url":"https://github.com/Maria-Nosyk","followers_url":"https://api.github.com/users/Maria-Nosyk/followers","following_url":"https://api.github.com/users/Maria-Nosyk/following{/other_user}","gists_url":"https://api.github.com/users/Maria-Nosyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Maria-Nosyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maria-Nosyk/subscriptions","organizations_url":"https://api.github.com/users/Maria-Nosyk/orgs","repos_url":"https://api.github.com/users/Maria-Nosyk/repos","events_url":"https://api.github.com/users/Maria-Nosyk/events{/privacy}","received_events_url":"https://api.github.com/users/Maria-Nosyk/received_events","type":"User","site_admin":false},"repo":{"id":97567096,"node_id":"MDEwOlJlcG9zaXRvcnk5NzU2NzA5Ng==","name":"exonum-doc","full_name":"Maria-Nosyk/exonum-doc","private":false,"owner":{"login":"Maria-Nosyk","id":29862040,"node_id":"MDQ6VXNlcjI5ODYyMDQw","avatar_url":"https://avatars3.githubusercontent.com/u/29862040?v=4","gravatar_id":"","url":"https://api.github.com/users/Maria-Nosyk","html_url":"https://github.com/Maria-Nosyk","followers_url":"https://api.github.com/users/Maria-Nosyk/followers","following_url":"https://api.github.com/users/Maria-Nosyk/following{/other_user}","gists_url":"https://api.github.com/users/Maria-Nosyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Maria-Nosyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maria-Nosyk/subscriptions","organizations_url":"https://api.github.com/users/Maria-Nosyk/orgs","repos_url":"https://api.github.com/users/Maria-Nosyk/repos","events_url":"https://api.github.com/users/Maria-Nosyk/events{/privacy}","received_events_url":"https://api.github.com/users/Maria-Nosyk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Maria-Nosyk/exonum-doc","description":"Exonum documentation","fork":true,"url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc","forks_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/forks","keys_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/teams","hooks_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/hooks","issue_events_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/issues/events{/number}","events_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/events","assignees_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/assignees{/user}","branches_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/branches{/branch}","tags_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/tags","blobs_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/languages","stargazers_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/stargazers","contributors_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/contributors","subscribers_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/subscribers","subscription_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/subscription","commits_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/contents/{+path}","compare_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/merges","archive_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/downloads","issues_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/issues{/number}","pulls_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/labels{/name}","releases_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/releases{/id}","deployments_url":"https://api.github.com/repos/Maria-Nosyk/exonum-doc/deployments","created_at":"2017-07-18T07:22:27Z","updated_at":"2018-09-26T10:01:38Z","pushed_at":"2018-10-04T15:15:40Z","git_url":"git://github.com/Maria-Nosyk/exonum-doc.git","ssh_url":"git@github.com:Maria-Nosyk/exonum-doc.git","clone_url":"https://github.com/Maria-Nosyk/exonum-doc.git","svn_url":"https://github.com/Maria-Nosyk/exonum-doc","homepage":"http://exonum.com/doc/","size":3083,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"19e89a92d5a23c7fd1eb3205d6eaff9272d7591e","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":87934894,"node_id":"MDEwOlJlcG9zaXRvcnk4NzkzNDg5NA==","name":"exonum-doc","full_name":"exonum/exonum-doc","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum-doc","description":"Exonum documentation","fork":false,"url":"https://api.github.com/repos/exonum/exonum-doc","forks_url":"https://api.github.com/repos/exonum/exonum-doc/forks","keys_url":"https://api.github.com/repos/exonum/exonum-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-doc/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-doc/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-doc/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-doc/events","assignees_url":"https://api.github.com/repos/exonum/exonum-doc/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-doc/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-doc/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-doc/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-doc/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-doc/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-doc/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-doc/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-doc/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-doc/merges","archive_url":"https://api.github.com/repos/exonum/exonum-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-doc/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-doc/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-doc/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-doc/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-doc/deployments","created_at":"2017-04-11T13:04:24Z","updated_at":"2018-10-04T11:18:14Z","pushed_at":"2018-10-04T15:15:42Z","git_url":"git://github.com/exonum/exonum-doc.git","ssh_url":"git@github.com:exonum/exonum-doc.git","clone_url":"https://github.com/exonum/exonum-doc.git","svn_url":"https://github.com/exonum/exonum-doc","homepage":"http://exonum.com/doc/","size":2957,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":23,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/245"},"html":{"href":"https://github.com/exonum/exonum-doc/pull/245"},"issue":{"href":"https://api.github.com/repos/exonum/exonum-doc/issues/245"},"comments":{"href":"https://api.github.com/repos/exonum/exonum-doc/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum-doc/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum-doc/statuses/0238db276b1b801cc2d90b887c50a1b839a4212d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87934894,
"name": "exonum/exonum-doc",
"url": "https://api.github.com/repos/exonum/exonum-doc"
} | {
"id": 303763,
"login": "boguslavsky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/303763?",
"url": "https://api.github.com/users/boguslavsky"
} | {
"id": 23138442,
"login": "exonum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23138442?",
"url": "https://api.github.com/orgs/exonum"
} | 2018-10-04T15:16:25 | 8368660426 | {"actor":{"display_login":"boguslavsky"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/comments/224483715","pull_request_review_id":163862562,"id":224483715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDQ4MzcxNQ==","diff_hunk":"@@ -761,9 +770,28 @@ def _react_to_subtask_result_accepted(self, msg):\n self.disconnect(message.base.Disconnect.REASON.BadProtocol)\r\n return\r\n \r\n- if not self.check_requestor_for_subtask(msg.subtask_id):\r\n+ try:\r\n+ msg.verify_owners(\r\n+ provider_public_key=self.my_public_key,\r\n+ requestor_public_key=decode_hex(self.key_id),\r\n+ )\r\n+ except (msg_exceptions.InvalidSignature,\r\n+ msg_exceptions.OwnershipMismatch) as e:\r\n+ logger.error(\"SubtaskResultAccepted has %s: %s\",\r\n+ e.__class__.__name__, e)\r\n+ self.dropped()\r\n+ return\r\n+\r\n+ transaction_system = self.task_server.client.transaction_system\r\n+ if not transaction_system.is_income_expected(\r","path":"golem/task/tasksession.py","position":124,"original_position":124,"commit_id":"4d9b4aea581825afafac5e5677b8bc6f0c384e17","original_commit_id":"4d9b4aea581825afafac5e5677b8bc6f0c384e17","user":{"login":"Krigpl","id":3904252,"node_id":"MDQ6VXNlcjM5MDQyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3904252?v=4","gravatar_id":"","url":"https://api.github.com/users/Krigpl","html_url":"https://github.com/Krigpl","followers_url":"https://api.github.com/users/Krigpl/followers","following_url":"https://api.github.com/users/Krigpl/following{/other_user}","gists_url":"https://api.github.com/users/Krigpl/gists{/gist_id}","starred_url":"https://api.github.com/users/Krigpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krigpl/subscriptions","organizations_url":"https://api.github.com/users/Krigpl/orgs","repos_url":"https://api.github.com/users/Krigpl/repos","events_url":"https://api.github.com/users/Krigpl/events{/privacy}","received_events_url":"https://api.github.com/users/Krigpl/received_events","type":"User","site_admin":false},"body":"I think so, yes. Imo the `is_income_expected` check should live inside `check_requestor_for_subtask`'s if body.","created_at":"2018-10-11T15:00:26Z","updated_at":"2018-10-11T15:00:26Z","html_url":"https://github.com/golemfactory/golem/pull/3428#discussion_r224483715","pull_request_url":"https://api.github.com/repos/golemfactory/golem/pulls/3428","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments/224483715"},"html":{"href":"https://github.com/golemfactory/golem/pull/3428#discussion_r224483715"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3428"}},"in_reply_to_id":224478818},"pull_request":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/3428","id":222130786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTMwNzg2","html_url":"https://github.com/golemfactory/golem/pull/3428","diff_url":"https://github.com/golemfactory/golem/pull/3428.diff","patch_url":"https://github.com/golemfactory/golem/pull/3428.patch","issue_url":"https://api.github.com/repos/golemfactory/golem/issues/3428","number":3428,"state":"open","locked":false,"title":"Accept SRA without `comp_task_keeper` record","user":{"login":"etam","id":220752,"node_id":"MDQ6VXNlcjIyMDc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/220752?v=4","gravatar_id":"","url":"https://api.github.com/users/etam","html_url":"https://github.com/etam","followers_url":"https://api.github.com/users/etam/followers","following_url":"https://api.github.com/users/etam/following{/other_user}","gists_url":"https://api.github.com/users/etam/gists{/gist_id}","starred_url":"https://api.github.com/users/etam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etam/subscriptions","organizations_url":"https://api.github.com/users/etam/orgs","repos_url":"https://api.github.com/users/etam/repos","events_url":"https://api.github.com/users/etam/events{/privacy}","received_events_url":"https://api.github.com/users/etam/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-11T13:06:10Z","updated_at":"2018-10-11T15:00:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df770d7bebfb0ec8eab392960c56ff70d73f73a","assignee":{"login":"etam","id":220752,"node_id":"MDQ6VXNlcjIyMDc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/220752?v=4","gravatar_id":"","url":"https://api.github.com/users/etam","html_url":"https://github.com/etam","followers_url":"https://api.github.com/users/etam/followers","following_url":"https://api.github.com/users/etam/following{/other_user}","gists_url":"https://api.github.com/users/etam/gists{/gist_id}","starred_url":"https://api.github.com/users/etam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etam/subscriptions","organizations_url":"https://api.github.com/users/etam/orgs","repos_url":"https://api.github.com/users/etam/repos","events_url":"https://api.github.com/users/etam/events{/privacy}","received_events_url":"https://api.github.com/users/etam/received_events","type":"User","site_admin":false},"assignees":[{"login":"etam","id":220752,"node_id":"MDQ6VXNlcjIyMDc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/220752?v=4","gravatar_id":"","url":"https://api.github.com/users/etam","html_url":"https://github.com/etam","followers_url":"https://api.github.com/users/etam/followers","following_url":"https://api.github.com/users/etam/following{/other_user}","gists_url":"https://api.github.com/users/etam/gists{/gist_id}","starred_url":"https://api.github.com/users/etam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etam/subscriptions","organizations_url":"https://api.github.com/users/etam/orgs","repos_url":"https://api.github.com/users/etam/repos","events_url":"https://api.github.com/users/etam/events{/privacy}","received_events_url":"https://api.github.com/users/etam/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jiivan","id":293058,"node_id":"MDQ6VXNlcjI5MzA1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/293058?v=4","gravatar_id":"","url":"https://api.github.com/users/jiivan","html_url":"https://github.com/jiivan","followers_url":"https://api.github.com/users/jiivan/followers","following_url":"https://api.github.com/users/jiivan/following{/other_user}","gists_url":"https://api.github.com/users/jiivan/gists{/gist_id}","starred_url":"https://api.github.com/users/jiivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiivan/subscriptions","organizations_url":"https://api.github.com/users/jiivan/orgs","repos_url":"https://api.github.com/users/jiivan/repos","events_url":"https://api.github.com/users/jiivan/events{/privacy}","received_events_url":"https://api.github.com/users/jiivan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":990281118,"node_id":"MDU6TGFiZWw5OTAyODExMTg=","url":"https://api.github.com/repos/golemfactory/golem/labels/_current","name":"_current","color":"ffdd33","default":false},{"id":983911058,"node_id":"MDU6TGFiZWw5ODM5MTEwNTg=","url":"https://api.github.com/repos/golemfactory/golem/labels/brass","name":"brass","color":"ff7d11","default":false},{"id":288910350,"node_id":"MDU6TGFiZWwyODg5MTAzNTA=","url":"https://api.github.com/repos/golemfactory/golem/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/golem/pulls/3428/commits","review_comments_url":"https://api.github.com/repos/golemfactory/golem/pulls/3428/comments","review_comment_url":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/golem/issues/3428/comments","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/4d9b4aea581825afafac5e5677b8bc6f0c384e17","head":{"label":"golemfactory:fix_accept_sra","ref":"fix_accept_sra","sha":"4d9b4aea581825afafac5e5677b8bc6f0c384e17","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQzMzkzNw==","name":"golem","full_name":"golemfactory/golem","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2018-10-11T14:15:20Z","pushed_at":"2018-10-11T14:32:29Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":142960,"stargazers_count":2619,"watchers_count":2619,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":412,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":264,"open_issues":412,"watchers":2619,"default_branch":"develop"}},"base":{"label":"golemfactory:b0.18.0","ref":"b0.18.0","sha":"0b7e8c7664e44fc0e513ddd16c371d73cda80305","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQzMzkzNw==","name":"golem","full_name":"golemfactory/golem","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2018-10-11T14:15:20Z","pushed_at":"2018-10-11T14:32:29Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":142960,"stargazers_count":2619,"watchers_count":2619,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":412,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":264,"open_issues":412,"watchers":2619,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3428"},"html":{"href":"https://github.com/golemfactory/golem/pull/3428"},"issue":{"href":"https://api.github.com/repos/golemfactory/golem/issues/3428"},"comments":{"href":"https://api.github.com/repos/golemfactory/golem/issues/3428/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3428/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/3428/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/golem/statuses/4d9b4aea581825afafac5e5677b8bc6f0c384e17"}},"author_association":"CONTRIBUTOR"}} | {
"id": 46433937,
"name": "golemfactory/golem",
"url": "https://api.github.com/repos/golemfactory/golem"
} | {
"id": 3904252,
"login": "Krigpl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3904252?",
"url": "https://api.github.com/users/Krigpl"
} | {
"id": 23193179,
"login": "golemfactory",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23193179?",
"url": "https://api.github.com/orgs/golemfactory"
} | 2018-10-11T15:00:26 | 8405328570 | {"actor":{"display_login":"Krigpl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments/235557440","pull_request_review_id":177451589,"id":235557440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU1NzQ0MA==","diff_hunk":"@@ -397,10 +399,34 @@ task siteStableLatestXml(type:Copy) {\n }\n }\n \n+// sign all .jar file under specified dir\n+ext.signJar = { File dir ->\n+ def keystorepass = project.hasProperty('keystorepass') ? keystorepass : '';\n+ if (keystorepass.isEmpty()) {\n+ print 'to sign eclipse plugins, set \"keystorepass\" project property'","path":"eclipsePlugin/build.gradle","position":14,"original_position":14,"commit_id":"516aade02495b36a3d946bd1e430106cf2e565f1","original_commit_id":"516aade02495b36a3d946bd1e430106cf2e565f1","user":{"login":"KengoTODA","id":505751,"node_id":"MDQ6VXNlcjUwNTc1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/505751?v=4","gravatar_id":"","url":"https://api.github.com/users/KengoTODA","html_url":"https://github.com/KengoTODA","followers_url":"https://api.github.com/users/KengoTODA/followers","following_url":"https://api.github.com/users/KengoTODA/following{/other_user}","gists_url":"https://api.github.com/users/KengoTODA/gists{/gist_id}","starred_url":"https://api.github.com/users/KengoTODA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KengoTODA/subscriptions","organizations_url":"https://api.github.com/users/KengoTODA/orgs","repos_url":"https://api.github.com/users/KengoTODA/repos","events_url":"https://api.github.com/users/KengoTODA/events{/privacy}","received_events_url":"https://api.github.com/users/KengoTODA/received_events","type":"User","site_admin":false},"body":"To sign in local, we need to [create Java KeyStore file](https://docs.oracle.com/javase/tutorial/security/toolsign/step3.html) first. We can generate self-signed one by:\r\n\r\n```sh\r\n$ keytool -genkey -alias eclipse-plugin -keystore $PROJECT_ROOT/spotbugs.jks -storepass changeit\r\n```\r\n\r\nThen use `-Pkeystorepass` option or `gradle.properties` to set project properties:\r\n\r\n```sh\r\n$ ./gradlew clean eclipseSite -Pkeystorepass=changeit\r\n```","created_at":"2018-11-21T22:36:20Z","updated_at":"2018-11-21T22:36:21Z","html_url":"https://github.com/spotbugs/spotbugs/pull/803#discussion_r235557440","pull_request_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments/235557440"},"html":{"href":"https://github.com/spotbugs/spotbugs/pull/803#discussion_r235557440"},"pull_request":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803"}},"in_reply_to_id":235418498},"pull_request":{"url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803","id":232588137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTg4MTM3","html_url":"https://github.com/spotbugs/spotbugs/pull/803","diff_url":"https://github.com/spotbugs/spotbugs/pull/803.diff","patch_url":"https://github.com/spotbugs/spotbugs/pull/803.patch","issue_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/803","number":803,"state":"open","locked":false,"title":"Sign Eclipse plugins ","user":{"login":"KengoTODA","id":505751,"node_id":"MDQ6VXNlcjUwNTc1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/505751?v=4","gravatar_id":"","url":"https://api.github.com/users/KengoTODA","html_url":"https://github.com/KengoTODA","followers_url":"https://api.github.com/users/KengoTODA/followers","following_url":"https://api.github.com/users/KengoTODA/following{/other_user}","gists_url":"https://api.github.com/users/KengoTODA/gists{/gist_id}","starred_url":"https://api.github.com/users/KengoTODA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KengoTODA/subscriptions","organizations_url":"https://api.github.com/users/KengoTODA/orgs","repos_url":"https://api.github.com/users/KengoTODA/repos","events_url":"https://api.github.com/users/KengoTODA/events{/privacy}","received_events_url":"https://api.github.com/users/KengoTODA/received_events","type":"User","site_admin":false},"body":"Sign eclipse plugin jar files by certificate provided by Let's Encrypt.\r\nWe can verify that jar file is certainly signed by the following command:\r\n\r\n```\r\n$ jarsigner -verify -verbose -certs eclipsePlugin/build/site/eclipse/plugins/com.github.spotbugs.plugin.eclipse_3.1.9.201811211256-95f25b7.jar\r\n\r\ns 10109 Wed Nov 21 12:57:06 CST 2018 META-INF/MANIFEST.MF\r\n\r\n [entry was signed on 11/21/18 12:57 PM]\r\n X.509, CN=spotbugs.kengo-toda.jp\r\n [certificate is valid from 11/20/18 2:42 PM to 2/18/19 2:42 PM]\r\n [ExtendedKeyUsage extension does not support code signing]\r\n X.509, CN=Let's Encrypt Authority X3, O=Let's Encrypt, C=US\r\n [certificate is valid from 3/18/16 12:40 AM to 3/18/21 12:40 AM]\r\n [CertPath not validated: Path does not chain with any of the trust anchors]\r\n```","created_at":"2018-11-21T09:15:59Z","updated_at":"2018-11-21T22:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"496ee6ed4789edcf899c94a6511b9ed21a4aed90","assignee":{"login":"KengoTODA","id":505751,"node_id":"MDQ6VXNlcjUwNTc1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/505751?v=4","gravatar_id":"","url":"https://api.github.com/users/KengoTODA","html_url":"https://github.com/KengoTODA","followers_url":"https://api.github.com/users/KengoTODA/followers","following_url":"https://api.github.com/users/KengoTODA/following{/other_user}","gists_url":"https://api.github.com/users/KengoTODA/gists{/gist_id}","starred_url":"https://api.github.com/users/KengoTODA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KengoTODA/subscriptions","organizations_url":"https://api.github.com/users/KengoTODA/orgs","repos_url":"https://api.github.com/users/KengoTODA/repos","events_url":"https://api.github.com/users/KengoTODA/events{/privacy}","received_events_url":"https://api.github.com/users/KengoTODA/received_events","type":"User","site_admin":false},"assignees":[{"login":"KengoTODA","id":505751,"node_id":"MDQ6VXNlcjUwNTc1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/505751?v=4","gravatar_id":"","url":"https://api.github.com/users/KengoTODA","html_url":"https://github.com/KengoTODA","followers_url":"https://api.github.com/users/KengoTODA/followers","following_url":"https://api.github.com/users/KengoTODA/following{/other_user}","gists_url":"https://api.github.com/users/KengoTODA/gists{/gist_id}","starred_url":"https://api.github.com/users/KengoTODA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KengoTODA/subscriptions","organizations_url":"https://api.github.com/users/KengoTODA/orgs","repos_url":"https://api.github.com/users/KengoTODA/repos","events_url":"https://api.github.com/users/KengoTODA/events{/privacy}","received_events_url":"https://api.github.com/users/KengoTODA/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":803509353,"node_id":"MDU6TGFiZWw4MDM1MDkzNTM=","url":"https://api.github.com/repos/spotbugs/spotbugs/labels/build","name":"build","color":"1d76db","default":false},{"id":475523329,"node_id":"MDU6TGFiZWw0NzU1MjMzMjk=","url":"https://api.github.com/repos/spotbugs/spotbugs/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803/commits","review_comments_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803/comments","review_comment_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/803/comments","statuses_url":"https://api.github.com/repos/spotbugs/spotbugs/statuses/516aade02495b36a3d946bd1e430106cf2e565f1","head":{"label":"spotbugs:issue-779","ref":"issue-779","sha":"516aade02495b36a3d946bd1e430106cf2e565f1","user":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"repo":{"id":72889410,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg4OTQxMA==","name":"spotbugs","full_name":"spotbugs/spotbugs","private":false,"owner":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotbugs/spotbugs","description":"SpotBugs is FindBugs' successor. A tool for static analysis to look for bugs in Java code.","fork":false,"url":"https://api.github.com/repos/spotbugs/spotbugs","forks_url":"https://api.github.com/repos/spotbugs/spotbugs/forks","keys_url":"https://api.github.com/repos/spotbugs/spotbugs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotbugs/spotbugs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotbugs/spotbugs/teams","hooks_url":"https://api.github.com/repos/spotbugs/spotbugs/hooks","issue_events_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/events{/number}","events_url":"https://api.github.com/repos/spotbugs/spotbugs/events","assignees_url":"https://api.github.com/repos/spotbugs/spotbugs/assignees{/user}","branches_url":"https://api.github.com/repos/spotbugs/spotbugs/branches{/branch}","tags_url":"https://api.github.com/repos/spotbugs/spotbugs/tags","blobs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotbugs/spotbugs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotbugs/spotbugs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotbugs/spotbugs/statuses/{sha}","languages_url":"https://api.github.com/repos/spotbugs/spotbugs/languages","stargazers_url":"https://api.github.com/repos/spotbugs/spotbugs/stargazers","contributors_url":"https://api.github.com/repos/spotbugs/spotbugs/contributors","subscribers_url":"https://api.github.com/repos/spotbugs/spotbugs/subscribers","subscription_url":"https://api.github.com/repos/spotbugs/spotbugs/subscription","commits_url":"https://api.github.com/repos/spotbugs/spotbugs/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotbugs/spotbugs/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotbugs/spotbugs/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotbugs/spotbugs/contents/{+path}","compare_url":"https://api.github.com/repos/spotbugs/spotbugs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotbugs/spotbugs/merges","archive_url":"https://api.github.com/repos/spotbugs/spotbugs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotbugs/spotbugs/downloads","issues_url":"https://api.github.com/repos/spotbugs/spotbugs/issues{/number}","pulls_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls{/number}","milestones_url":"https://api.github.com/repos/spotbugs/spotbugs/milestones{/number}","notifications_url":"https://api.github.com/repos/spotbugs/spotbugs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotbugs/spotbugs/labels{/name}","releases_url":"https://api.github.com/repos/spotbugs/spotbugs/releases{/id}","deployments_url":"https://api.github.com/repos/spotbugs/spotbugs/deployments","created_at":"2016-11-04T22:18:08Z","updated_at":"2018-11-21T10:41:45Z","pushed_at":"2018-11-21T09:16:00Z","git_url":"git://github.com/spotbugs/spotbugs.git","ssh_url":"git@github.com:spotbugs/spotbugs.git","clone_url":"https://github.com/spotbugs/spotbugs.git","svn_url":"https://github.com/spotbugs/spotbugs","homepage":"https://spotbugs.github.io/","size":160066,"stargazers_count":983,"watchers_count":983,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":149,"open_issues":166,"watchers":983,"default_branch":"release-3.1"}},"base":{"label":"spotbugs:release-3.1","ref":"release-3.1","sha":"fd29bff72610e034f8e8a93f2d2c4fdfd40ec3cd","user":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"repo":{"id":72889410,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg4OTQxMA==","name":"spotbugs","full_name":"spotbugs/spotbugs","private":false,"owner":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotbugs/spotbugs","description":"SpotBugs is FindBugs' successor. A tool for static analysis to look for bugs in Java code.","fork":false,"url":"https://api.github.com/repos/spotbugs/spotbugs","forks_url":"https://api.github.com/repos/spotbugs/spotbugs/forks","keys_url":"https://api.github.com/repos/spotbugs/spotbugs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotbugs/spotbugs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotbugs/spotbugs/teams","hooks_url":"https://api.github.com/repos/spotbugs/spotbugs/hooks","issue_events_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/events{/number}","events_url":"https://api.github.com/repos/spotbugs/spotbugs/events","assignees_url":"https://api.github.com/repos/spotbugs/spotbugs/assignees{/user}","branches_url":"https://api.github.com/repos/spotbugs/spotbugs/branches{/branch}","tags_url":"https://api.github.com/repos/spotbugs/spotbugs/tags","blobs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotbugs/spotbugs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotbugs/spotbugs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotbugs/spotbugs/statuses/{sha}","languages_url":"https://api.github.com/repos/spotbugs/spotbugs/languages","stargazers_url":"https://api.github.com/repos/spotbugs/spotbugs/stargazers","contributors_url":"https://api.github.com/repos/spotbugs/spotbugs/contributors","subscribers_url":"https://api.github.com/repos/spotbugs/spotbugs/subscribers","subscription_url":"https://api.github.com/repos/spotbugs/spotbugs/subscription","commits_url":"https://api.github.com/repos/spotbugs/spotbugs/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotbugs/spotbugs/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotbugs/spotbugs/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotbugs/spotbugs/contents/{+path}","compare_url":"https://api.github.com/repos/spotbugs/spotbugs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotbugs/spotbugs/merges","archive_url":"https://api.github.com/repos/spotbugs/spotbugs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotbugs/spotbugs/downloads","issues_url":"https://api.github.com/repos/spotbugs/spotbugs/issues{/number}","pulls_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls{/number}","milestones_url":"https://api.github.com/repos/spotbugs/spotbugs/milestones{/number}","notifications_url":"https://api.github.com/repos/spotbugs/spotbugs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotbugs/spotbugs/labels{/name}","releases_url":"https://api.github.com/repos/spotbugs/spotbugs/releases{/id}","deployments_url":"https://api.github.com/repos/spotbugs/spotbugs/deployments","created_at":"2016-11-04T22:18:08Z","updated_at":"2018-11-21T10:41:45Z","pushed_at":"2018-11-21T09:16:00Z","git_url":"git://github.com/spotbugs/spotbugs.git","ssh_url":"git@github.com:spotbugs/spotbugs.git","clone_url":"https://github.com/spotbugs/spotbugs.git","svn_url":"https://github.com/spotbugs/spotbugs","homepage":"https://spotbugs.github.io/","size":160066,"stargazers_count":983,"watchers_count":983,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":149,"open_issues":166,"watchers":983,"default_branch":"release-3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803"},"html":{"href":"https://github.com/spotbugs/spotbugs/pull/803"},"issue":{"href":"https://api.github.com/repos/spotbugs/spotbugs/issues/803"},"comments":{"href":"https://api.github.com/repos/spotbugs/spotbugs/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/spotbugs/spotbugs/statuses/516aade02495b36a3d946bd1e430106cf2e565f1"}},"author_association":"MEMBER"}} | {
"id": 72889410,
"name": "spotbugs/spotbugs",
"url": "https://api.github.com/repos/spotbugs/spotbugs"
} | {
"id": 505751,
"login": "KengoTODA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/505751?",
"url": "https://api.github.com/users/KengoTODA"
} | {
"id": 23269302,
"login": "spotbugs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23269302?",
"url": "https://api.github.com/orgs/spotbugs"
} | 2018-11-21T22:36:20 | 8629885599 | {"actor":{"display_login":"KengoTODA"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/qlik-oss/core-website/pulls/comments/201649378","pull_request_review_id":136189928,"id":201649378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY0OTM3OA==","diff_hunk":"@@ -605,3 +605,42 @@ user.region matches \"us-[^-]+-(1|2)\"\n \n This regular expression matches regions starting with `us-`, followed by one ore more characters that are anything but\n `-`, followed by `-1` or `-2`.\n+\n+## Adding existing apps\n+\n+By adding an existing app (qvf) to the engine running access control, you first have to import that app using engines api.\n+This has to be done because the access control feature expects the app to follow a specific file structure.\n+This structure is created when importing an app.\n+","path":"docs/services/qix-engine/access-control.md","position":10,"original_position":10,"commit_id":"016de76af881ee58569761d292ffec01d4f2c646","original_commit_id":"016de76af881ee58569761d292ffec01d4f2c646","user":{"login":"hrigner","id":25030951,"node_id":"MDQ6VXNlcjI1MDMwOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/25030951?v=4","gravatar_id":"","url":"https://api.github.com/users/hrigner","html_url":"https://github.com/hrigner","followers_url":"https://api.github.com/users/hrigner/followers","following_url":"https://api.github.com/users/hrigner/following{/other_user}","gists_url":"https://api.github.com/users/hrigner/gists{/gist_id}","starred_url":"https://api.github.com/users/hrigner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrigner/subscriptions","organizations_url":"https://api.github.com/users/hrigner/orgs","repos_url":"https://api.github.com/users/hrigner/repos","events_url":"https://api.github.com/users/hrigner/events{/privacy}","received_events_url":"https://api.github.com/users/hrigner/received_events","type":"User","site_admin":false},"body":"Just some rephrasing, maybe sth like \"If you want to add an existing app (qvf) to an engine running access control, you will have to import the app using the engine API. The access control feature expects the app to follow a specific file structure, which is created when an app is being imported.\"","created_at":"2018-07-11T11:04:14Z","updated_at":"2018-07-11T11:04:14Z","html_url":"https://github.com/qlik-oss/core-website/pull/349#discussion_r201649378","pull_request_url":"https://api.github.com/repos/qlik-oss/core-website/pulls/349","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/comments/201649378"},"html":{"href":"https://github.com/qlik-oss/core-website/pull/349#discussion_r201649378"},"pull_request":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/qlik-oss/core-website/pulls/349","id":200627723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjI3NzIz","html_url":"https://github.com/qlik-oss/core-website/pull/349","diff_url":"https://github.com/qlik-oss/core-website/pull/349.diff","patch_url":"https://github.com/qlik-oss/core-website/pull/349.patch","issue_url":"https://api.github.com/repos/qlik-oss/core-website/issues/349","number":349,"state":"open","locked":false,"title":"Document import app","user":{"login":"carlioth","id":908670,"node_id":"MDQ6VXNlcjkwODY3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/908670?v=4","gravatar_id":"","url":"https://api.github.com/users/carlioth","html_url":"https://github.com/carlioth","followers_url":"https://api.github.com/users/carlioth/followers","following_url":"https://api.github.com/users/carlioth/following{/other_user}","gists_url":"https://api.github.com/users/carlioth/gists{/gist_id}","starred_url":"https://api.github.com/users/carlioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlioth/subscriptions","organizations_url":"https://api.github.com/users/carlioth/orgs","repos_url":"https://api.github.com/users/carlioth/repos","events_url":"https://api.github.com/users/carlioth/events{/privacy}","received_events_url":"https://api.github.com/users/carlioth/received_events","type":"User","site_admin":false},"body":"Threw this together to help with the import. Please have a look if it makes sense to have it at the end of the doc. What is missing, and what should be removed? \r\n\r\nCloses #348 ","created_at":"2018-07-11T08:48:48Z","updated_at":"2018-07-11T11:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc4988ac11e0d0c77e5d36cbdee018ac6d777d6a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sublibra","id":3288294,"node_id":"MDQ6VXNlcjMyODgyOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3288294?v=4","gravatar_id":"","url":"https://api.github.com/users/sublibra","html_url":"https://github.com/sublibra","followers_url":"https://api.github.com/users/sublibra/followers","following_url":"https://api.github.com/users/sublibra/following{/other_user}","gists_url":"https://api.github.com/users/sublibra/gists{/gist_id}","starred_url":"https://api.github.com/users/sublibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublibra/subscriptions","organizations_url":"https://api.github.com/users/sublibra/orgs","repos_url":"https://api.github.com/users/sublibra/repos","events_url":"https://api.github.com/users/sublibra/events{/privacy}","received_events_url":"https://api.github.com/users/sublibra/received_events","type":"User","site_admin":false},{"login":"kyleweishaar","id":22196349,"node_id":"MDQ6VXNlcjIyMTk2MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22196349?v=4","gravatar_id":"","url":"https://api.github.com/users/kyleweishaar","html_url":"https://github.com/kyleweishaar","followers_url":"https://api.github.com/users/kyleweishaar/followers","following_url":"https://api.github.com/users/kyleweishaar/following{/other_user}","gists_url":"https://api.github.com/users/kyleweishaar/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleweishaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleweishaar/subscriptions","organizations_url":"https://api.github.com/users/kyleweishaar/orgs","repos_url":"https://api.github.com/users/kyleweishaar/repos","events_url":"https://api.github.com/users/kyleweishaar/events{/privacy}","received_events_url":"https://api.github.com/users/kyleweishaar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qlik-oss/core-website/pulls/349/commits","review_comments_url":"https://api.github.com/repos/qlik-oss/core-website/pulls/349/comments","review_comment_url":"https://api.github.com/repos/qlik-oss/core-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qlik-oss/core-website/issues/349/comments","statuses_url":"https://api.github.com/repos/qlik-oss/core-website/statuses/016de76af881ee58569761d292ffec01d4f2c646","head":{"label":"qlik-oss:importapp","ref":"importapp","sha":"016de76af881ee58569761d292ffec01d4f2c646","user":{"login":"qlik-oss","id":23365920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzY1OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23365920?v=4","gravatar_id":"","url":"https://api.github.com/users/qlik-oss","html_url":"https://github.com/qlik-oss","followers_url":"https://api.github.com/users/qlik-oss/followers","following_url":"https://api.github.com/users/qlik-oss/following{/other_user}","gists_url":"https://api.github.com/users/qlik-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/qlik-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlik-oss/subscriptions","organizations_url":"https://api.github.com/users/qlik-oss/orgs","repos_url":"https://api.github.com/users/qlik-oss/repos","events_url":"https://api.github.com/users/qlik-oss/events{/privacy}","received_events_url":"https://api.github.com/users/qlik-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":90375451,"node_id":"MDEwOlJlcG9zaXRvcnk5MDM3NTQ1MQ==","name":"core-website","full_name":"qlik-oss/core-website","owner":{"login":"qlik-oss","id":23365920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzY1OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23365920?v=4","gravatar_id":"","url":"https://api.github.com/users/qlik-oss","html_url":"https://github.com/qlik-oss","followers_url":"https://api.github.com/users/qlik-oss/followers","following_url":"https://api.github.com/users/qlik-oss/following{/other_user}","gists_url":"https://api.github.com/users/qlik-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/qlik-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlik-oss/subscriptions","organizations_url":"https://api.github.com/users/qlik-oss/orgs","repos_url":"https://api.github.com/users/qlik-oss/repos","events_url":"https://api.github.com/users/qlik-oss/events{/privacy}","received_events_url":"https://api.github.com/users/qlik-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qlik-oss/core-website","description":"Source code for the qlikcore.com website.","fork":false,"url":"https://api.github.com/repos/qlik-oss/core-website","forks_url":"https://api.github.com/repos/qlik-oss/core-website/forks","keys_url":"https://api.github.com/repos/qlik-oss/core-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qlik-oss/core-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qlik-oss/core-website/teams","hooks_url":"https://api.github.com/repos/qlik-oss/core-website/hooks","issue_events_url":"https://api.github.com/repos/qlik-oss/core-website/issues/events{/number}","events_url":"https://api.github.com/repos/qlik-oss/core-website/events","assignees_url":"https://api.github.com/repos/qlik-oss/core-website/assignees{/user}","branches_url":"https://api.github.com/repos/qlik-oss/core-website/branches{/branch}","tags_url":"https://api.github.com/repos/qlik-oss/core-website/tags","blobs_url":"https://api.github.com/repos/qlik-oss/core-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qlik-oss/core-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qlik-oss/core-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/qlik-oss/core-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qlik-oss/core-website/statuses/{sha}","languages_url":"https://api.github.com/repos/qlik-oss/core-website/languages","stargazers_url":"https://api.github.com/repos/qlik-oss/core-website/stargazers","contributors_url":"https://api.github.com/repos/qlik-oss/core-website/contributors","subscribers_url":"https://api.github.com/repos/qlik-oss/core-website/subscribers","subscription_url":"https://api.github.com/repos/qlik-oss/core-website/subscription","commits_url":"https://api.github.com/repos/qlik-oss/core-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/qlik-oss/core-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/qlik-oss/core-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/qlik-oss/core-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/qlik-oss/core-website/contents/{+path}","compare_url":"https://api.github.com/repos/qlik-oss/core-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qlik-oss/core-website/merges","archive_url":"https://api.github.com/repos/qlik-oss/core-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qlik-oss/core-website/downloads","issues_url":"https://api.github.com/repos/qlik-oss/core-website/issues{/number}","pulls_url":"https://api.github.com/repos/qlik-oss/core-website/pulls{/number}","milestones_url":"https://api.github.com/repos/qlik-oss/core-website/milestones{/number}","notifications_url":"https://api.github.com/repos/qlik-oss/core-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qlik-oss/core-website/labels{/name}","releases_url":"https://api.github.com/repos/qlik-oss/core-website/releases{/id}","deployments_url":"https://api.github.com/repos/qlik-oss/core-website/deployments","created_at":"2017-05-05T12:53:42Z","updated_at":"2018-07-10T19:34:27Z","pushed_at":"2018-07-11T10:31:20Z","git_url":"git://github.com/qlik-oss/core-website.git","ssh_url":"git@github.com:qlik-oss/core-website.git","clone_url":"https://github.com/qlik-oss/core-website.git","svn_url":"https://github.com/qlik-oss/core-website","homepage":"https://www.qlikcore.com/","size":58791,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":8,"watchers":11,"default_branch":"master"}},"base":{"label":"qlik-oss:master","ref":"master","sha":"f5f509dc3bf830c3a506d96537739d2b0e958d1c","user":{"login":"qlik-oss","id":23365920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzY1OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23365920?v=4","gravatar_id":"","url":"https://api.github.com/users/qlik-oss","html_url":"https://github.com/qlik-oss","followers_url":"https://api.github.com/users/qlik-oss/followers","following_url":"https://api.github.com/users/qlik-oss/following{/other_user}","gists_url":"https://api.github.com/users/qlik-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/qlik-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlik-oss/subscriptions","organizations_url":"https://api.github.com/users/qlik-oss/orgs","repos_url":"https://api.github.com/users/qlik-oss/repos","events_url":"https://api.github.com/users/qlik-oss/events{/privacy}","received_events_url":"https://api.github.com/users/qlik-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":90375451,"node_id":"MDEwOlJlcG9zaXRvcnk5MDM3NTQ1MQ==","name":"core-website","full_name":"qlik-oss/core-website","owner":{"login":"qlik-oss","id":23365920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzY1OTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23365920?v=4","gravatar_id":"","url":"https://api.github.com/users/qlik-oss","html_url":"https://github.com/qlik-oss","followers_url":"https://api.github.com/users/qlik-oss/followers","following_url":"https://api.github.com/users/qlik-oss/following{/other_user}","gists_url":"https://api.github.com/users/qlik-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/qlik-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlik-oss/subscriptions","organizations_url":"https://api.github.com/users/qlik-oss/orgs","repos_url":"https://api.github.com/users/qlik-oss/repos","events_url":"https://api.github.com/users/qlik-oss/events{/privacy}","received_events_url":"https://api.github.com/users/qlik-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qlik-oss/core-website","description":"Source code for the qlikcore.com website.","fork":false,"url":"https://api.github.com/repos/qlik-oss/core-website","forks_url":"https://api.github.com/repos/qlik-oss/core-website/forks","keys_url":"https://api.github.com/repos/qlik-oss/core-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qlik-oss/core-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qlik-oss/core-website/teams","hooks_url":"https://api.github.com/repos/qlik-oss/core-website/hooks","issue_events_url":"https://api.github.com/repos/qlik-oss/core-website/issues/events{/number}","events_url":"https://api.github.com/repos/qlik-oss/core-website/events","assignees_url":"https://api.github.com/repos/qlik-oss/core-website/assignees{/user}","branches_url":"https://api.github.com/repos/qlik-oss/core-website/branches{/branch}","tags_url":"https://api.github.com/repos/qlik-oss/core-website/tags","blobs_url":"https://api.github.com/repos/qlik-oss/core-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qlik-oss/core-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qlik-oss/core-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/qlik-oss/core-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qlik-oss/core-website/statuses/{sha}","languages_url":"https://api.github.com/repos/qlik-oss/core-website/languages","stargazers_url":"https://api.github.com/repos/qlik-oss/core-website/stargazers","contributors_url":"https://api.github.com/repos/qlik-oss/core-website/contributors","subscribers_url":"https://api.github.com/repos/qlik-oss/core-website/subscribers","subscription_url":"https://api.github.com/repos/qlik-oss/core-website/subscription","commits_url":"https://api.github.com/repos/qlik-oss/core-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/qlik-oss/core-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/qlik-oss/core-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/qlik-oss/core-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/qlik-oss/core-website/contents/{+path}","compare_url":"https://api.github.com/repos/qlik-oss/core-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qlik-oss/core-website/merges","archive_url":"https://api.github.com/repos/qlik-oss/core-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qlik-oss/core-website/downloads","issues_url":"https://api.github.com/repos/qlik-oss/core-website/issues{/number}","pulls_url":"https://api.github.com/repos/qlik-oss/core-website/pulls{/number}","milestones_url":"https://api.github.com/repos/qlik-oss/core-website/milestones{/number}","notifications_url":"https://api.github.com/repos/qlik-oss/core-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qlik-oss/core-website/labels{/name}","releases_url":"https://api.github.com/repos/qlik-oss/core-website/releases{/id}","deployments_url":"https://api.github.com/repos/qlik-oss/core-website/deployments","created_at":"2017-05-05T12:53:42Z","updated_at":"2018-07-10T19:34:27Z","pushed_at":"2018-07-11T10:31:20Z","git_url":"git://github.com/qlik-oss/core-website.git","ssh_url":"git@github.com:qlik-oss/core-website.git","clone_url":"https://github.com/qlik-oss/core-website.git","svn_url":"https://github.com/qlik-oss/core-website","homepage":"https://www.qlikcore.com/","size":58791,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":8,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/349"},"html":{"href":"https://github.com/qlik-oss/core-website/pull/349"},"issue":{"href":"https://api.github.com/repos/qlik-oss/core-website/issues/349"},"comments":{"href":"https://api.github.com/repos/qlik-oss/core-website/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qlik-oss/core-website/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/qlik-oss/core-website/statuses/016de76af881ee58569761d292ffec01d4f2c646"}},"author_association":"MEMBER"}} | {
"id": 90375451,
"name": "qlik-oss/core-website",
"url": "https://api.github.com/repos/qlik-oss/core-website"
} | {
"id": 25030951,
"login": "hrigner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25030951?",
"url": "https://api.github.com/users/hrigner"
} | {
"id": 23365920,
"login": "qlik-oss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23365920?",
"url": "https://api.github.com/orgs/qlik-oss"
} | 2018-07-11T11:04:14 | 7949349858 | {"actor":{"display_login":"hrigner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/174598433","pull_request_review_id":95660081,"id":174598433,"diff_hunk":"@@ -0,0 +1,98 @@\n+// Copyright 2017 JanusGraph Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package org.janusgraph.graphdb.predicate;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+import org.janusgraph.graphdb.query.JanusGraphPredicate;\n+\n+/**\n+ * @author David Clement (david.clement90@laposte.net)\n+ */\n+public abstract class ConnectiveJanusPredicate extends ArrayList<JanusGraphPredicate> implements JanusGraphPredicate {\n+\n+ private static final long serialVersionUID = 1558788908114391360L;\n+\n+ public ConnectiveJanusPredicate(){\n+ super();\n+ }\n+\n+ public ConnectiveJanusPredicate(final List<JanusGraphPredicate> predicates) {\n+ super(predicates);\n+ }\n+\n+ abstract ConnectiveJanusPredicate getNewNegateIntance();\n+\n+ abstract boolean isOr();\n+\n+ @Override\n+ @SuppressWarnings(\"unchecked\")\n+ public boolean isValidCondition(Object condition) {\n+ if (!(condition instanceof List) || ((List<?>)condition).size() != this.size()){\n+ return false;\n+ }\n+ final List<Object> conditions = ((List<Object>) condition);\n+ for (int i = 0; i< this.size(); i++) {\n+ if(!this.get(i).isValidCondition(conditions.get(i))) {","path":"janusgraph-core/src/main/java/org/janusgraph/graphdb/predicate/ConnectiveJanusPredicate.java","position":48,"original_position":48,"commit_id":"b6302cf6fbffd28387fc4da320157eaf6d420aff","original_commit_id":"b6302cf6fbffd28387fc4da320157eaf6d420aff","user":{"login":"amcp","id":1066771,"avatar_url":"https://avatars0.githubusercontent.com/u/1066771?v=4","gravatar_id":"","url":"https://api.github.com/users/amcp","html_url":"https://github.com/amcp","followers_url":"https://api.github.com/users/amcp/followers","following_url":"https://api.github.com/users/amcp/following{/other_user}","gists_url":"https://api.github.com/users/amcp/gists{/gist_id}","starred_url":"https://api.github.com/users/amcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcp/subscriptions","organizations_url":"https://api.github.com/users/amcp/orgs","repos_url":"https://api.github.com/users/amcp/repos","events_url":"https://api.github.com/users/amcp/events{/privacy}","received_events_url":"https://api.github.com/users/amcp/received_events","type":"User","site_admin":false},"body":"consider using a \r\n```java\r\nif (stream.anyMatch) {\r\n return false;\r\n}\r\nreturn true;\r\n```","created_at":"2018-03-14T20:23:58Z","updated_at":"2018-03-14T20:26:56Z","html_url":"https://github.com/JanusGraph/janusgraph/pull/927#discussion_r174598433","pull_request_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments/174598433"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/927#discussion_r174598433"},"pull_request":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927"}},"in_reply_to_id":167438116},"pull_request":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927","id":168455510,"html_url":"https://github.com/JanusGraph/janusgraph/pull/927","diff_url":"https://github.com/JanusGraph/janusgraph/pull/927.diff","patch_url":"https://github.com/JanusGraph/janusgraph/pull/927.patch","issue_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/927","number":927,"state":"open","locked":false,"title":"Add better OR support for mixed indexes.","user":{"login":"davidclement90","id":20819752,"avatar_url":"https://avatars2.githubusercontent.com/u/20819752?v=4","gravatar_id":"","url":"https://api.github.com/users/davidclement90","html_url":"https://github.com/davidclement90","followers_url":"https://api.github.com/users/davidclement90/followers","following_url":"https://api.github.com/users/davidclement90/following{/other_user}","gists_url":"https://api.github.com/users/davidclement90/gists{/gist_id}","starred_url":"https://api.github.com/users/davidclement90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidclement90/subscriptions","organizations_url":"https://api.github.com/users/davidclement90/orgs","repos_url":"https://api.github.com/users/davidclement90/repos","events_url":"https://api.github.com/users/davidclement90/events{/privacy}","received_events_url":"https://api.github.com/users/davidclement90/received_events","type":"User","site_admin":false},"body":"Issue : #163\r\nThis PR add better OR support.\r\nIf one backend can handle the all query, we use this backend\r\nIf not it will create one query by OR's child\r\n\r\nNow all these queries can use indexes instead of using full-scan\r\n```\r\ng.V().or(__.has(\"name\", \"Hiro\"),__.has(\"age\", 2)));\r\ng.V().or(__.has(\"name\", \"Totoro\"),__.has(\"age\", 2)));\r\ng.V().or(__.has(\"name\", \"Totoro\").has(\"age\", 1),__.has(\"age\", 2)));\r\ng.V().or(__.and(__.has(\"name\", \"Totoro\"), __.has(\"age\", 1)),__.has(\"age\", 2)));\r\ng.V().has(\"length\", P.lte(100)).or(__.has(\"name\", \"Totoro\"),__.has(\"age\", P.gte(2)))\r\ng.V().or(__.has(\"name\", \"Totoro\"),__.has(\"age\", P.gte(2))).has(\"length\", P.lte(100))\r\ng.V().or(__.has(\"name\", \"Totoro\"),__.has(\"age\", 2)).order().by(\"age\")\r\ng.V().or(__.has(\"name\", \"Totoro\"), __.has(\"length\", P.lte(120)).order().by(\"length\"))\r\ng.V().or(__.has(\"name\", \"Totoro\"), __.has(\"length\", P.lte(120)).order()\r\n.by(\"length\")).order().by(\"age\")\r\ng.V().or(__.has(\"name\", \"Totoro\"), __.has(\"length\", P.lte(120))).order().by(\"age\").limit(2)\r\ng.V().or(__.has(\"name\", \"Totoro\"), __.has(\"length\", P.lte(120))).order().by(\"age\")\r\n.range(2, 3)\r\ng.V().has(\"length\", P.gte(130).or(P.lt(100))).order().by(\"age\")\r\ng.V().has(\"length\", P.gte(80).and(P.gte(130).or(P.lt(100)))).order().by(\"age\")\r\n```\r\nIf the backend can handle not query-normal-form as Elasticsearch or Lucene, the query will use mixed indexes :\r\n`g.V().has(\"length\", P.gte(80).and(P.gte(130)).or(P.gte(80).and(P.lt(100))))`\r\n\r\nSigned-off-by: David Clement <david.clement90@laposte.net>\r\n\r\n-----\r\n\r\nThank you for contributing to JanusGraph!\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there an issue associated with this PR? Is it referenced in the commit message?\r\n- [x] Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you written and/or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [ ] If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?\r\n- [ ] If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n- [ ] If this PR is a documentation-only change, have you added a `[skip ci]`\r\n tag to the first line of your commit message to avoid spending CPU cycles in\r\n Travis CI when no code, tests, or build configuration are modified?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.\r\n\r\n","created_at":"2018-02-11T14:19:36Z","updated_at":"2018-03-14T20:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513c86b770d4121110387203bebb2c2233b12243","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":507215572,"url":"https://api.github.com/repos/JanusGraph/janusgraph/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":507186125,"url":"https://api.github.com/repos/JanusGraph/janusgraph/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones/4","html_url":"https://github.com/JanusGraph/janusgraph/milestone/4","labels_url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones/4/labels","id":2802018,"number":4,"title":"Release v0.3.0","description":"","creator":{"login":"sjudeng","id":11000076,"avatar_url":"https://avatars3.githubusercontent.com/u/11000076?v=4","gravatar_id":"","url":"https://api.github.com/users/sjudeng","html_url":"https://github.com/sjudeng","followers_url":"https://api.github.com/users/sjudeng/followers","following_url":"https://api.github.com/users/sjudeng/following{/other_user}","gists_url":"https://api.github.com/users/sjudeng/gists{/gist_id}","starred_url":"https://api.github.com/users/sjudeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjudeng/subscriptions","organizations_url":"https://api.github.com/users/sjudeng/orgs","repos_url":"https://api.github.com/users/sjudeng/repos","events_url":"https://api.github.com/users/sjudeng/events{/privacy}","received_events_url":"https://api.github.com/users/sjudeng/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":80,"state":"open","created_at":"2017-09-29T04:07:52Z","updated_at":"2018-03-14T20:07:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927/commits","review_comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927/comments","review_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/927/comments","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/b6302cf6fbffd28387fc4da320157eaf6d420aff","head":{"label":"davidclement90:betterOrSupport","ref":"betterOrSupport","sha":"b6302cf6fbffd28387fc4da320157eaf6d420aff","user":{"login":"davidclement90","id":20819752,"avatar_url":"https://avatars2.githubusercontent.com/u/20819752?v=4","gravatar_id":"","url":"https://api.github.com/users/davidclement90","html_url":"https://github.com/davidclement90","followers_url":"https://api.github.com/users/davidclement90/followers","following_url":"https://api.github.com/users/davidclement90/following{/other_user}","gists_url":"https://api.github.com/users/davidclement90/gists{/gist_id}","starred_url":"https://api.github.com/users/davidclement90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidclement90/subscriptions","organizations_url":"https://api.github.com/users/davidclement90/orgs","repos_url":"https://api.github.com/users/davidclement90/repos","events_url":"https://api.github.com/users/davidclement90/events{/privacy}","received_events_url":"https://api.github.com/users/davidclement90/received_events","type":"User","site_admin":false},"repo":{"id":85077593,"name":"janusgraph","full_name":"davidclement90/janusgraph","owner":{"login":"davidclement90","id":20819752,"avatar_url":"https://avatars2.githubusercontent.com/u/20819752?v=4","gravatar_id":"","url":"https://api.github.com/users/davidclement90","html_url":"https://github.com/davidclement90","followers_url":"https://api.github.com/users/davidclement90/followers","following_url":"https://api.github.com/users/davidclement90/following{/other_user}","gists_url":"https://api.github.com/users/davidclement90/gists{/gist_id}","starred_url":"https://api.github.com/users/davidclement90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidclement90/subscriptions","organizations_url":"https://api.github.com/users/davidclement90/orgs","repos_url":"https://api.github.com/users/davidclement90/repos","events_url":"https://api.github.com/users/davidclement90/events{/privacy}","received_events_url":"https://api.github.com/users/davidclement90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidclement90/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":true,"url":"https://api.github.com/repos/davidclement90/janusgraph","forks_url":"https://api.github.com/repos/davidclement90/janusgraph/forks","keys_url":"https://api.github.com/repos/davidclement90/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidclement90/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidclement90/janusgraph/teams","hooks_url":"https://api.github.com/repos/davidclement90/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/davidclement90/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/davidclement90/janusgraph/events","assignees_url":"https://api.github.com/repos/davidclement90/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/davidclement90/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/davidclement90/janusgraph/tags","blobs_url":"https://api.github.com/repos/davidclement90/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidclement90/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidclement90/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidclement90/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidclement90/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/davidclement90/janusgraph/languages","stargazers_url":"https://api.github.com/repos/davidclement90/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/davidclement90/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/davidclement90/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/davidclement90/janusgraph/subscription","commits_url":"https://api.github.com/repos/davidclement90/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidclement90/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidclement90/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidclement90/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidclement90/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/davidclement90/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidclement90/janusgraph/merges","archive_url":"https://api.github.com/repos/davidclement90/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidclement90/janusgraph/downloads","issues_url":"https://api.github.com/repos/davidclement90/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/davidclement90/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/davidclement90/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/davidclement90/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidclement90/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/davidclement90/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/davidclement90/janusgraph/deployments","created_at":"2017-03-15T13:46:10Z","updated_at":"2017-03-15T13:46:17Z","pushed_at":"2018-02-11T14:17:38Z","git_url":"git://github.com/davidclement90/janusgraph.git","ssh_url":"git@github.com:davidclement90/janusgraph.git","clone_url":"https://github.com/davidclement90/janusgraph.git","svn_url":"https://github.com/davidclement90/janusgraph","homepage":"http://janusgraph.org","size":49780,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JanusGraph:master","ref":"master","sha":"6c3130fa868aa91c19c3c6ed4fbe656e43f74689","user":{"login":"JanusGraph","id":23411090,"avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"repo":{"id":77385607,"name":"janusgraph","full_name":"JanusGraph/janusgraph","owner":{"login":"JanusGraph","id":23411090,"avatar_url":"https://avatars1.githubusercontent.com/u/23411090?v=4","gravatar_id":"","url":"https://api.github.com/users/JanusGraph","html_url":"https://github.com/JanusGraph","followers_url":"https://api.github.com/users/JanusGraph/followers","following_url":"https://api.github.com/users/JanusGraph/following{/other_user}","gists_url":"https://api.github.com/users/JanusGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/JanusGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanusGraph/subscriptions","organizations_url":"https://api.github.com/users/JanusGraph/orgs","repos_url":"https://api.github.com/users/JanusGraph/repos","events_url":"https://api.github.com/users/JanusGraph/events{/privacy}","received_events_url":"https://api.github.com/users/JanusGraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JanusGraph/janusgraph","description":"JanusGraph: an open-source, distributed graph database","fork":false,"url":"https://api.github.com/repos/JanusGraph/janusgraph","forks_url":"https://api.github.com/repos/JanusGraph/janusgraph/forks","keys_url":"https://api.github.com/repos/JanusGraph/janusgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JanusGraph/janusgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JanusGraph/janusgraph/teams","hooks_url":"https://api.github.com/repos/JanusGraph/janusgraph/hooks","issue_events_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/events{/number}","events_url":"https://api.github.com/repos/JanusGraph/janusgraph/events","assignees_url":"https://api.github.com/repos/JanusGraph/janusgraph/assignees{/user}","branches_url":"https://api.github.com/repos/JanusGraph/janusgraph/branches{/branch}","tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/tags","blobs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/JanusGraph/janusgraph/languages","stargazers_url":"https://api.github.com/repos/JanusGraph/janusgraph/stargazers","contributors_url":"https://api.github.com/repos/JanusGraph/janusgraph/contributors","subscribers_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscribers","subscription_url":"https://api.github.com/repos/JanusGraph/janusgraph/subscription","commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/JanusGraph/janusgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/JanusGraph/janusgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/JanusGraph/janusgraph/contents/{+path}","compare_url":"https://api.github.com/repos/JanusGraph/janusgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JanusGraph/janusgraph/merges","archive_url":"https://api.github.com/repos/JanusGraph/janusgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JanusGraph/janusgraph/downloads","issues_url":"https://api.github.com/repos/JanusGraph/janusgraph/issues{/number}","pulls_url":"https://api.github.com/repos/JanusGraph/janusgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/JanusGraph/janusgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/JanusGraph/janusgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JanusGraph/janusgraph/labels{/name}","releases_url":"https://api.github.com/repos/JanusGraph/janusgraph/releases{/id}","deployments_url":"https://api.github.com/repos/JanusGraph/janusgraph/deployments","created_at":"2016-12-26T13:26:29Z","updated_at":"2018-03-14T20:07:46Z","pushed_at":"2018-03-14T20:24:48Z","git_url":"git://github.com/JanusGraph/janusgraph.git","ssh_url":"git@github.com:JanusGraph/janusgraph.git","clone_url":"https://github.com/JanusGraph/janusgraph.git","svn_url":"https://github.com/JanusGraph/janusgraph","homepage":"http://janusgraph.org","size":49761,"stargazers_count":1268,"watchers_count":1268,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":284,"open_issues":256,"watchers":1268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927"},"html":{"href":"https://github.com/JanusGraph/janusgraph/pull/927"},"issue":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/927"},"comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/issues/927/comments"},"review_comments":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927/comments"},"review_comment":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/pulls/927/commits"},"statuses":{"href":"https://api.github.com/repos/JanusGraph/janusgraph/statuses/b6302cf6fbffd28387fc4da320157eaf6d420aff"}},"author_association":"CONTRIBUTOR"}} | {
"id": 77385607,
"name": "JanusGraph/janusgraph",
"url": "https://api.github.com/repos/JanusGraph/janusgraph"
} | {
"id": 1066771,
"login": "amcp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1066771?",
"url": "https://api.github.com/users/amcp"
} | {
"id": 23411090,
"login": "JanusGraph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23411090?",
"url": "https://api.github.com/orgs/JanusGraph"
} | 2018-03-14T20:23:58 | 7380785878 | {"actor":{"display_login":"amcp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/comments/202104619","pull_request_review_id":136737505,"id":202104619,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjEwNDYxOQ==","diff_hunk":"@@ -0,0 +1,85 @@\n+package org.dice.factcheckbenchmark.benchmark.rdf;\n+\n+import org.apache.jena.rdf.model.*;\n+\n+import java.util.*;\n+\n+/**\n+ * @author DANISH AHMED on 3/22/2018\n+ */\n+public class RDFResource {\n+\n+ protected Resource resource;\n+ protected Model model;\n+ protected String label;\n+ public String uri;\n+\n+ private Property owlSameAsProperty = ResourceFactory.createProperty(Constants.OWL_NAMESPACE + \"sameAs\");\n+\n+ public List<Resource> owlSameAsList = new ArrayList<Resource>(); // only considering english for now\n+ public Map<String, String> langLabelsMap = new HashMap<String, String>();","path":"src/main/java/org/dice/factcheckbenchmark/benchmark/rdf/RDFResource.java","position":20,"original_position":20,"commit_id":"c3b66bc5c050d376512d5a7bd69270fa8ab4b9a0","original_commit_id":"c3b66bc5c050d376512d5a7bd69270fa8ab4b9a0","user":{"login":"zafarsyed","id":21986293,"node_id":"MDQ6VXNlcjIxOTg2Mjkz","avatar_url":"https://avatars3.githubusercontent.com/u/21986293?v=4","gravatar_id":"","url":"https://api.github.com/users/zafarsyed","html_url":"https://github.com/zafarsyed","followers_url":"https://api.github.com/users/zafarsyed/followers","following_url":"https://api.github.com/users/zafarsyed/following{/other_user}","gists_url":"https://api.github.com/users/zafarsyed/gists{/gist_id}","starred_url":"https://api.github.com/users/zafarsyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zafarsyed/subscriptions","organizations_url":"https://api.github.com/users/zafarsyed/orgs","repos_url":"https://api.github.com/users/zafarsyed/repos","events_url":"https://api.github.com/users/zafarsyed/events{/privacy}","received_events_url":"https://api.github.com/users/zafarsyed/received_events","type":"User","site_admin":false},"body":"The alternate labels are part of FactBench files and available for three languages at the moment (@en, @fr, @de). DefactoModel reads all skos:altLabel and make it available as a Set of labels. So the alternate labels are used in FactCheck.","created_at":"2018-07-12T16:47:38Z","updated_at":"2018-07-12T16:47:38Z","html_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1#discussion_r202104619","pull_request_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/comments/202104619"},"html":{"href":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1#discussion_r202104619"},"pull_request":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1"}},"in_reply_to_id":201998466},"pull_request":{"url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1","id":200951848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTUxODQ4","html_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1","diff_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1.diff","patch_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1.patch","issue_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/1","number":1,"state":"open","locked":false,"title":"Adding benchmark components implementation","user":{"login":"oshando","id":32812797,"node_id":"MDQ6VXNlcjMyODEyNzk3","avatar_url":"https://avatars1.githubusercontent.com/u/32812797?v=4","gravatar_id":"","url":"https://api.github.com/users/oshando","html_url":"https://github.com/oshando","followers_url":"https://api.github.com/users/oshando/followers","following_url":"https://api.github.com/users/oshando/following{/other_user}","gists_url":"https://api.github.com/users/oshando/gists{/gist_id}","starred_url":"https://api.github.com/users/oshando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshando/subscriptions","organizations_url":"https://api.github.com/users/oshando/orgs","repos_url":"https://api.github.com/users/oshando/repos","events_url":"https://api.github.com/users/oshando/events{/privacy}","received_events_url":"https://api.github.com/users/oshando/received_events","type":"User","site_admin":false},"body":"The pull request provides the implementation for all components required by HOBBIT benchmarking platform.","created_at":"2018-07-12T10:10:35Z","updated_at":"2018-07-12T16:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d326c855d6195516fd3fdd9fdca5110ab0b617","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1/commits","review_comments_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1/comments","review_comment_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/1/comments","statuses_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/statuses/c3b66bc5c050d376512d5a7bd69270fa8ab4b9a0","head":{"label":"oshando:master","ref":"master","sha":"c3b66bc5c050d376512d5a7bd69270fa8ab4b9a0","user":{"login":"oshando","id":32812797,"node_id":"MDQ6VXNlcjMyODEyNzk3","avatar_url":"https://avatars1.githubusercontent.com/u/32812797?v=4","gravatar_id":"","url":"https://api.github.com/users/oshando","html_url":"https://github.com/oshando","followers_url":"https://api.github.com/users/oshando/followers","following_url":"https://api.github.com/users/oshando/following{/other_user}","gists_url":"https://api.github.com/users/oshando/gists{/gist_id}","starred_url":"https://api.github.com/users/oshando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshando/subscriptions","organizations_url":"https://api.github.com/users/oshando/orgs","repos_url":"https://api.github.com/users/oshando/repos","events_url":"https://api.github.com/users/oshando/events{/privacy}","received_events_url":"https://api.github.com/users/oshando/received_events","type":"User","site_admin":false},"repo":{"id":139415870,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MTU4NzA=","name":"Fact-Checking-Benchmark","full_name":"oshando/Fact-Checking-Benchmark","owner":{"login":"oshando","id":32812797,"node_id":"MDQ6VXNlcjMyODEyNzk3","avatar_url":"https://avatars1.githubusercontent.com/u/32812797?v=4","gravatar_id":"","url":"https://api.github.com/users/oshando","html_url":"https://github.com/oshando","followers_url":"https://api.github.com/users/oshando/followers","following_url":"https://api.github.com/users/oshando/following{/other_user}","gists_url":"https://api.github.com/users/oshando/gists{/gist_id}","starred_url":"https://api.github.com/users/oshando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshando/subscriptions","organizations_url":"https://api.github.com/users/oshando/orgs","repos_url":"https://api.github.com/users/oshando/repos","events_url":"https://api.github.com/users/oshando/events{/privacy}","received_events_url":"https://api.github.com/users/oshando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oshando/Fact-Checking-Benchmark","description":null,"fork":true,"url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark","forks_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/forks","keys_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/teams","hooks_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/hooks","issue_events_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/events","assignees_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/tags","blobs_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/languages","stargazers_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/stargazers","contributors_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/contributors","subscribers_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/subscribers","subscription_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/subscription","commits_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/merges","archive_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/downloads","issues_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/labels{/name}","releases_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/releases{/id}","deployments_url":"https://api.github.com/repos/oshando/Fact-Checking-Benchmark/deployments","created_at":"2018-07-02T08:45:40Z","updated_at":"2018-07-12T10:07:09Z","pushed_at":"2018-07-12T10:07:08Z","git_url":"git://github.com/oshando/Fact-Checking-Benchmark.git","ssh_url":"git@github.com:oshando/Fact-Checking-Benchmark.git","clone_url":"https://github.com/oshando/Fact-Checking-Benchmark.git","svn_url":"https://github.com/oshando/Fact-Checking-Benchmark","homepage":null,"size":58343,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hobbit-project:master","ref":"master","sha":"e2387f78a0f6d0cef7100c22c2071898eaf1aafa","user":{"login":"hobbit-project","id":23450005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDUwMDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23450005?v=4","gravatar_id":"","url":"https://api.github.com/users/hobbit-project","html_url":"https://github.com/hobbit-project","followers_url":"https://api.github.com/users/hobbit-project/followers","following_url":"https://api.github.com/users/hobbit-project/following{/other_user}","gists_url":"https://api.github.com/users/hobbit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/hobbit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hobbit-project/subscriptions","organizations_url":"https://api.github.com/users/hobbit-project/orgs","repos_url":"https://api.github.com/users/hobbit-project/repos","events_url":"https://api.github.com/users/hobbit-project/events{/privacy}","received_events_url":"https://api.github.com/users/hobbit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":139414493,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MTQ0OTM=","name":"Fact-Checking-Benchmark","full_name":"hobbit-project/Fact-Checking-Benchmark","owner":{"login":"hobbit-project","id":23450005,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDUwMDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23450005?v=4","gravatar_id":"","url":"https://api.github.com/users/hobbit-project","html_url":"https://github.com/hobbit-project","followers_url":"https://api.github.com/users/hobbit-project/followers","following_url":"https://api.github.com/users/hobbit-project/following{/other_user}","gists_url":"https://api.github.com/users/hobbit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/hobbit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hobbit-project/subscriptions","organizations_url":"https://api.github.com/users/hobbit-project/orgs","repos_url":"https://api.github.com/users/hobbit-project/repos","events_url":"https://api.github.com/users/hobbit-project/events{/privacy}","received_events_url":"https://api.github.com/users/hobbit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark","description":null,"fork":false,"url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark","forks_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/forks","keys_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/teams","hooks_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/hooks","issue_events_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/events{/number}","events_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/events","assignees_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/assignees{/user}","branches_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/branches{/branch}","tags_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/tags","blobs_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/git/refs{/sha}","trees_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/statuses/{sha}","languages_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/languages","stargazers_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/stargazers","contributors_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/contributors","subscribers_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/subscribers","subscription_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/subscription","commits_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/commits{/sha}","git_commits_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/git/commits{/sha}","comments_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/comments{/number}","issue_comment_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/comments{/number}","contents_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/contents/{+path}","compare_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/merges","archive_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/downloads","issues_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues{/number}","pulls_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls{/number}","milestones_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/milestones{/number}","notifications_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/labels{/name}","releases_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/releases{/id}","deployments_url":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/deployments","created_at":"2018-07-02T08:34:28Z","updated_at":"2018-07-02T08:37:24Z","pushed_at":"2018-07-12T10:10:36Z","git_url":"git://github.com/hobbit-project/Fact-Checking-Benchmark.git","ssh_url":"git@github.com:hobbit-project/Fact-Checking-Benchmark.git","clone_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark.git","svn_url":"https://github.com/hobbit-project/Fact-Checking-Benchmark","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1"},"html":{"href":"https://github.com/hobbit-project/Fact-Checking-Benchmark/pull/1"},"issue":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/1"},"comments":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark/statuses/c3b66bc5c050d376512d5a7bd69270fa8ab4b9a0"}},"author_association":"NONE"}} | {
"id": 139414493,
"name": "hobbit-project/Fact-Checking-Benchmark",
"url": "https://api.github.com/repos/hobbit-project/Fact-Checking-Benchmark"
} | {
"id": 21986293,
"login": "zafarsyed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21986293?",
"url": "https://api.github.com/users/zafarsyed"
} | {
"id": 23450005,
"login": "hobbit-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23450005?",
"url": "https://api.github.com/orgs/hobbit-project"
} | 2018-07-12T16:47:38 | 7957453542 | {"actor":{"display_login":"zafarsyed"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/comments/181234015","pull_request_review_id":111810487,"id":181234015,"diff_hunk":"@@ -56,9 +59,140 @@ func TestKarmaBehavior(t *testing.T) {\n \tassert.Equal(t, expected, result)\n }\n \n-// TestKarmaCommandDefaults\n-// TestKarmaCommandWithCountFlag\n-// TestKarmaCommandWithAscendingFlag\n-// TestKarmaCommandUserInputErrors\n-func TestKarmaCommandWithDefaults(t *testing.T) {\n+func TestKarmaCommand(t *testing.T) {\n+\tstore := newMemoryStore(t)\n+\tkarma := models.Karma{\n+\t\t\"alpha\": models.KarmaEntry{Upvotes: 10, Downvotes: 0},\n+\t}\n+\n+\tif err := store.Write(db.KarmaKey, karma); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\tw := bytes.NewBuffer(nil)\n+\tcmd := NewKarmaCommand(store, w)\n+\tif err := slackbot.NewTestApp(cmd).Run(strings.Split(\"iqvbot karma alpha\", \" \")); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\toutput := w.String()\n+\tfor name, values := range karma {\n+\t\tassert.Contains(t, output, name)\n+\t\tassert.Contains(t, output, strconv.Itoa(values.Downvotes))\n+\t\tassert.Contains(t, output, strconv.Itoa(values.Upvotes))\n+\t}\n+}\n+\n+func TestKarmaCommandWithCountFlag(t *testing.T) {\n+\tstore := newMemoryStore(t)\n+\tkarma := models.Karma{\n+\t\t\"alpha\": models.KarmaEntry{Upvotes: 1, Downvotes: 0},\n+\t\t\"beta\": models.KarmaEntry{Upvotes: 2, Downvotes: 0},\n+\t\t\"charlie\": models.KarmaEntry{Upvotes: 3, Downvotes: 0},\n+\t\t\"delta\": models.KarmaEntry{Upvotes: 4, Downvotes: 0},\n+\t\t\"echo\": models.KarmaEntry{Upvotes: 5, Downvotes: 0},\n+\t\t\"foxtrot\": models.KarmaEntry{Upvotes: 6, Downvotes: 0},\n+\t\t\"golf\": models.KarmaEntry{Upvotes: 7, Downvotes: 0},\n+\t\t\"hotel\": models.KarmaEntry{Upvotes: 8, Downvotes: 0},\n+\t\t\"india\": models.KarmaEntry{Upvotes: 9, Downvotes: 0},\n+\t\t\"juliett\": models.KarmaEntry{Upvotes: 10, Downvotes: 0},\n+\t\t\"kilo\": models.KarmaEntry{Upvotes: 11, Downvotes: 0},\n+\t}\n+\n+\tif err := store.Write(db.KarmaKey, karma); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\tcases := map[string]struct {\n+\t\tInput []string\n+\t\tExpected int\n+\t}{\n+\t\t\"check default\": {\n+\t\t\tInput: strings.Split(\"iqvbot karma *\", \" \"),\n+\t\t\tExpected: 10,\n+\t\t},\n+\t\t\"count one\": {\n+\t\t\tInput: strings.Split(\"iqvbot karma --count=1 *\", \" \"),\n+\t\t\tExpected: 1,\n+\t\t},\n+\t\t\"count three\": {\n+\t\t\tInput: strings.Split(\"iqvbot karma --count=3 *\", \" \"),\n+\t\t\tExpected: 3,\n+\t\t},\n+\t}\n+\n+\tfor name := range cases {\n+\t\tt.Run(name, func(t *testing.T) {\n+\t\t\tw := bytes.NewBuffer(nil)\n+\t\t\tcmd := NewKarmaCommand(store, w)\n+\n+\t\t\tif err := slackbot.NewTestApp(cmd).Run(cases[name].Input); err != nil {\n+\t\t\t\tt.Fatal(err)\n+\t\t\t}\n+\n+\t\t\tassert.Len(t, strings.Split(w.String(), \"\\n\"), cases[name].Expected)\n+\t\t})\n+\t}\n+}\n+\n+func TestKarmaCommandWithAscendingFlag(t *testing.T) {\n+\tstore := newMemoryStore(t)\n+\tkarma := models.Karma{\n+\t\t\"alpha\": models.KarmaEntry{Upvotes: 1, Downvotes: 0},\n+\t\t\"beta\": models.KarmaEntry{Upvotes: 2, Downvotes: 0},\n+\t\t\"charlie\": models.KarmaEntry{Upvotes: 3, Downvotes: 0},\n+\t}\n+\n+\tif err := store.Write(db.KarmaKey, karma); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\tcases := map[string]struct {\n+\t\tInput []string\n+\t\tExpected []string\n+\t}{\n+\t\t\"enabled\": {\n+\t\t\tInput: strings.Split(\"iqvbot karma --ascending *\", \" \"),\n+\t\t\tExpected: []string{\"1\", \"2\", \"3\"},","path":"bot/karma_test.go","position":114,"original_position":114,"commit_id":"f416956654fb5ec3ad38d61b5a20d6fbe02053b6","original_commit_id":"f416956654fb5ec3ad38d61b5a20d6fbe02053b6","user":{"login":"zpatrick","id":2894436,"avatar_url":"https://avatars2.githubusercontent.com/u/2894436?v=4","gravatar_id":"","url":"https://api.github.com/users/zpatrick","html_url":"https://github.com/zpatrick","followers_url":"https://api.github.com/users/zpatrick/followers","following_url":"https://api.github.com/users/zpatrick/following{/other_user}","gists_url":"https://api.github.com/users/zpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/zpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpatrick/subscriptions","organizations_url":"https://api.github.com/users/zpatrick/orgs","repos_url":"https://api.github.com/users/zpatrick/repos","events_url":"https://api.github.com/users/zpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/zpatrick/received_events","type":"User","site_admin":false},"body":"I think it's functionally the same thing - but instead of testing the karma count output, you test the entry name. \r\nI think asserting that the correct entry gets displayed is more important; making sure that the correct karma count gets displayed seems less important to me. ","created_at":"2018-04-12T21:57:09Z","updated_at":"2018-04-12T21:57:09Z","html_url":"https://github.com/quintilesims/iqvbot/pull/17#discussion_r181234015","pull_request_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/comments/181234015"},"html":{"href":"https://github.com/quintilesims/iqvbot/pull/17#discussion_r181234015"},"pull_request":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17"}},"in_reply_to_id":181175199},"pull_request":{"url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17","id":181279695,"html_url":"https://github.com/quintilesims/iqvbot/pull/17","diff_url":"https://github.com/quintilesims/iqvbot/pull/17.diff","patch_url":"https://github.com/quintilesims/iqvbot/pull/17.patch","issue_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/17","number":17,"state":"open","locked":false,"title":"Karma tests and foundation for testing pattern","user":{"login":"nehayward","id":6733030,"avatar_url":"https://avatars1.githubusercontent.com/u/6733030?v=4","gravatar_id":"","url":"https://api.github.com/users/nehayward","html_url":"https://github.com/nehayward","followers_url":"https://api.github.com/users/nehayward/followers","following_url":"https://api.github.com/users/nehayward/following{/other_user}","gists_url":"https://api.github.com/users/nehayward/gists{/gist_id}","starred_url":"https://api.github.com/users/nehayward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nehayward/subscriptions","organizations_url":"https://api.github.com/users/nehayward/orgs","repos_url":"https://api.github.com/users/nehayward/repos","events_url":"https://api.github.com/users/nehayward/events{/privacy}","received_events_url":"https://api.github.com/users/nehayward/received_events","type":"User","site_admin":false},"body":"## IQVBOT Testing Pattern\r\nThis will lay the foundation for future testing patterns, so let's try and be as meticulous as possible in terms of using as assert and been lean and precise which each unit test.\r\n\r\nresolves #16 ","created_at":"2018-04-12T17:52:45Z","updated_at":"2018-04-12T21:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a944ca8584a9fc6361362b34f54293e887b5eeee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17/commits","review_comments_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17/comments","review_comment_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/17/comments","statuses_url":"https://api.github.com/repos/quintilesims/iqvbot/statuses/f416956654fb5ec3ad38d61b5a20d6fbe02053b6","head":{"label":"quintilesims:tests","ref":"tests","sha":"f416956654fb5ec3ad38d61b5a20d6fbe02053b6","user":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"repo":{"id":128460416,"name":"iqvbot","full_name":"quintilesims/iqvbot","owner":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quintilesims/iqvbot","description":null,"fork":false,"url":"https://api.github.com/repos/quintilesims/iqvbot","forks_url":"https://api.github.com/repos/quintilesims/iqvbot/forks","keys_url":"https://api.github.com/repos/quintilesims/iqvbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quintilesims/iqvbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quintilesims/iqvbot/teams","hooks_url":"https://api.github.com/repos/quintilesims/iqvbot/hooks","issue_events_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/events{/number}","events_url":"https://api.github.com/repos/quintilesims/iqvbot/events","assignees_url":"https://api.github.com/repos/quintilesims/iqvbot/assignees{/user}","branches_url":"https://api.github.com/repos/quintilesims/iqvbot/branches{/branch}","tags_url":"https://api.github.com/repos/quintilesims/iqvbot/tags","blobs_url":"https://api.github.com/repos/quintilesims/iqvbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quintilesims/iqvbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quintilesims/iqvbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/quintilesims/iqvbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quintilesims/iqvbot/statuses/{sha}","languages_url":"https://api.github.com/repos/quintilesims/iqvbot/languages","stargazers_url":"https://api.github.com/repos/quintilesims/iqvbot/stargazers","contributors_url":"https://api.github.com/repos/quintilesims/iqvbot/contributors","subscribers_url":"https://api.github.com/repos/quintilesims/iqvbot/subscribers","subscription_url":"https://api.github.com/repos/quintilesims/iqvbot/subscription","commits_url":"https://api.github.com/repos/quintilesims/iqvbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/quintilesims/iqvbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/quintilesims/iqvbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/quintilesims/iqvbot/contents/{+path}","compare_url":"https://api.github.com/repos/quintilesims/iqvbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quintilesims/iqvbot/merges","archive_url":"https://api.github.com/repos/quintilesims/iqvbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quintilesims/iqvbot/downloads","issues_url":"https://api.github.com/repos/quintilesims/iqvbot/issues{/number}","pulls_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls{/number}","milestones_url":"https://api.github.com/repos/quintilesims/iqvbot/milestones{/number}","notifications_url":"https://api.github.com/repos/quintilesims/iqvbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quintilesims/iqvbot/labels{/name}","releases_url":"https://api.github.com/repos/quintilesims/iqvbot/releases{/id}","deployments_url":"https://api.github.com/repos/quintilesims/iqvbot/deployments","created_at":"2018-04-06T19:43:40Z","updated_at":"2018-04-11T22:29:13Z","pushed_at":"2018-04-12T17:52:46Z","git_url":"git://github.com/quintilesims/iqvbot.git","ssh_url":"git@github.com:quintilesims/iqvbot.git","clone_url":"https://github.com/quintilesims/iqvbot.git","svn_url":"https://github.com/quintilesims/iqvbot","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"quintilesims:master","ref":"master","sha":"a38ef1afa76e170e1792ae5862ac6a91c1c4f1fe","user":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"repo":{"id":128460416,"name":"iqvbot","full_name":"quintilesims/iqvbot","owner":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quintilesims/iqvbot","description":null,"fork":false,"url":"https://api.github.com/repos/quintilesims/iqvbot","forks_url":"https://api.github.com/repos/quintilesims/iqvbot/forks","keys_url":"https://api.github.com/repos/quintilesims/iqvbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quintilesims/iqvbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quintilesims/iqvbot/teams","hooks_url":"https://api.github.com/repos/quintilesims/iqvbot/hooks","issue_events_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/events{/number}","events_url":"https://api.github.com/repos/quintilesims/iqvbot/events","assignees_url":"https://api.github.com/repos/quintilesims/iqvbot/assignees{/user}","branches_url":"https://api.github.com/repos/quintilesims/iqvbot/branches{/branch}","tags_url":"https://api.github.com/repos/quintilesims/iqvbot/tags","blobs_url":"https://api.github.com/repos/quintilesims/iqvbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quintilesims/iqvbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quintilesims/iqvbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/quintilesims/iqvbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quintilesims/iqvbot/statuses/{sha}","languages_url":"https://api.github.com/repos/quintilesims/iqvbot/languages","stargazers_url":"https://api.github.com/repos/quintilesims/iqvbot/stargazers","contributors_url":"https://api.github.com/repos/quintilesims/iqvbot/contributors","subscribers_url":"https://api.github.com/repos/quintilesims/iqvbot/subscribers","subscription_url":"https://api.github.com/repos/quintilesims/iqvbot/subscription","commits_url":"https://api.github.com/repos/quintilesims/iqvbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/quintilesims/iqvbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/quintilesims/iqvbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/quintilesims/iqvbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/quintilesims/iqvbot/contents/{+path}","compare_url":"https://api.github.com/repos/quintilesims/iqvbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quintilesims/iqvbot/merges","archive_url":"https://api.github.com/repos/quintilesims/iqvbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quintilesims/iqvbot/downloads","issues_url":"https://api.github.com/repos/quintilesims/iqvbot/issues{/number}","pulls_url":"https://api.github.com/repos/quintilesims/iqvbot/pulls{/number}","milestones_url":"https://api.github.com/repos/quintilesims/iqvbot/milestones{/number}","notifications_url":"https://api.github.com/repos/quintilesims/iqvbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quintilesims/iqvbot/labels{/name}","releases_url":"https://api.github.com/repos/quintilesims/iqvbot/releases{/id}","deployments_url":"https://api.github.com/repos/quintilesims/iqvbot/deployments","created_at":"2018-04-06T19:43:40Z","updated_at":"2018-04-11T22:29:13Z","pushed_at":"2018-04-12T17:52:46Z","git_url":"git://github.com/quintilesims/iqvbot.git","ssh_url":"git@github.com:quintilesims/iqvbot.git","clone_url":"https://github.com/quintilesims/iqvbot.git","svn_url":"https://github.com/quintilesims/iqvbot","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17"},"html":{"href":"https://github.com/quintilesims/iqvbot/pull/17"},"issue":{"href":"https://api.github.com/repos/quintilesims/iqvbot/issues/17"},"comments":{"href":"https://api.github.com/repos/quintilesims/iqvbot/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quintilesims/iqvbot/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/quintilesims/iqvbot/statuses/f416956654fb5ec3ad38d61b5a20d6fbe02053b6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 128460416,
"name": "quintilesims/iqvbot",
"url": "https://api.github.com/repos/quintilesims/iqvbot"
} | {
"id": 2894436,
"login": "zpatrick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2894436?",
"url": "https://api.github.com/users/zpatrick"
} | {
"id": 23506699,
"login": "quintilesims",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23506699?",
"url": "https://api.github.com/orgs/quintilesims"
} | 2018-04-12T21:57:09 | 7522862164 | {"actor":{"display_login":"zpatrick"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments/243873016","pull_request_review_id":187746159,"id":243873016,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzg3MzAxNg==","diff_hunk":"@@ -0,0 +1,196 @@\n+# Guide of local development\n+\n+You will learn how to develop programs in local under the guide of this document.\n+\n+## Requirements of code\n+- Please refer to the coding note format of [Doxygen](http://www.stack.nl/~dimitri/doxygen/) \n+- Make sure that option of builder `WITH_STYLE_CHECK` is on and the build could pass through the code style check.\n+- Unit test is a need for all codes.\n+- Pass through all unit tests.\n+- Please follow [regulations of submitting code](#regulations of submitting code).\n+\n+It tells you how to submit code as follows.\n+## [Fork](https://help.github.com/articles/fork-a-repo/)\n+\n+Transfer to the homepage of Github [PaddlePaddle](https://github.com/PaddlePaddle/Paddle),and then click button`Fork` to generate the repository under your own file directory,such as <https://github.com/USERNAME/Paddle>.\n+\n+## Clone\n+\n+Clone remote repository to local:\n+\n+```bash\n+➜ git clone https://github.com/USERNAME/Paddle\n+➜ cd Paddle\n+```\n+\n+\n+## Create local branch\n+\n+At present [Git stream branch model](http://nvie.com/posts/a-successful-git-branching-model/) is applied to Paddle to undergo task of development,test,release and maintenance.Please refer to [branch regulation of Paddle](https://github.com/PaddlePaddle/Paddle/blob/develop/doc/design/releasing_process.md#paddle-分支规范) about details。\n+\n+All development tasks of feature and bug fix should be finished in a new branch which is extended from `develop` branch.\n+\n+Create and change into a new branch with command `git checkout -b`.\n+\n+```bash\n+➜ git checkout -b my-cool-stuff\n+```\n+\n+Atentions should be paid that current branch be clean before checkout,otherwise the untracked files will also be shifted to the new branch,which could be viewed with command `git status`.\n+\n+## Use `pre-commit` hook\n+\n+Paddle developers manage Git pre-commit hook with [pre-commit](http://pre-commit.com/),which could help us to fomulate source code(C++，Python) and automatically review certain details,such as only one EOL of every file and no large file added to Git,before your commit.","path":"local_dev_guide_en.md","position":43,"original_position":43,"commit_id":"91a8e17d1d715aa528b88070da49cf6f76fbad0d","original_commit_id":"91a8e17d1d715aa528b88070da49cf6f76fbad0d","user":{"login":"shanyi15","id":35982308,"node_id":"MDQ6VXNlcjM1OTgyMzA4","avatar_url":"https://avatars1.githubusercontent.com/u/35982308?v=4","gravatar_id":"","url":"https://api.github.com/users/shanyi15","html_url":"https://github.com/shanyi15","followers_url":"https://api.github.com/users/shanyi15/followers","following_url":"https://api.github.com/users/shanyi15/following{/other_user}","gists_url":"https://api.github.com/users/shanyi15/gists{/gist_id}","starred_url":"https://api.github.com/users/shanyi15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanyi15/subscriptions","organizations_url":"https://api.github.com/users/shanyi15/orgs","repos_url":"https://api.github.com/users/shanyi15/repos","events_url":"https://api.github.com/users/shanyi15/events{/privacy}","received_events_url":"https://api.github.com/users/shanyi15/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nPaddle developers use the [pre-commit](http://pre-commit.com/) tool to manage Git pre-commit hooks. It helps us format the source code (C++, Python) and automatically check some basic things before committing (such as having only one EOL per file, not adding large files in Git, etc.).\r\n```","created_at":"2018-12-25T04:14:52Z","updated_at":"2018-12-25T04:31:29Z","html_url":"https://github.com/PaddlePaddle/FluidDoc/pull/500#discussion_r243873016","pull_request_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments/243873016"},"html":{"href":"https://github.com/PaddlePaddle/FluidDoc/pull/500#discussion_r243873016"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500","id":239063577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDYzNTc3","html_url":"https://github.com/PaddlePaddle/FluidDoc/pull/500","diff_url":"https://github.com/PaddlePaddle/FluidDoc/pull/500.diff","patch_url":"https://github.com/PaddlePaddle/FluidDoc/pull/500.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/500","number":500,"state":"open","locked":false,"title":"Submit pr guide en","user":{"login":"HongyingG","id":44694098,"node_id":"MDQ6VXNlcjQ0Njk0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/44694098?v=4","gravatar_id":"","url":"https://api.github.com/users/HongyingG","html_url":"https://github.com/HongyingG","followers_url":"https://api.github.com/users/HongyingG/followers","following_url":"https://api.github.com/users/HongyingG/following{/other_user}","gists_url":"https://api.github.com/users/HongyingG/gists{/gist_id}","starred_url":"https://api.github.com/users/HongyingG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HongyingG/subscriptions","organizations_url":"https://api.github.com/users/HongyingG/orgs","repos_url":"https://api.github.com/users/HongyingG/repos","events_url":"https://api.github.com/users/HongyingG/events{/privacy}","received_events_url":"https://api.github.com/users/HongyingG/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-17T08:38:01Z","updated_at":"2018-12-25T04:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6602493fa8f8d122881a43cb1e4b03855bc1bc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/500/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/91a8e17d1d715aa528b88070da49cf6f76fbad0d","head":{"label":"HongyingG:submit_pr_guide_en","ref":"submit_pr_guide_en","sha":"91a8e17d1d715aa528b88070da49cf6f76fbad0d","user":{"login":"HongyingG","id":44694098,"node_id":"MDQ6VXNlcjQ0Njk0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/44694098?v=4","gravatar_id":"","url":"https://api.github.com/users/HongyingG","html_url":"https://github.com/HongyingG","followers_url":"https://api.github.com/users/HongyingG/followers","following_url":"https://api.github.com/users/HongyingG/following{/other_user}","gists_url":"https://api.github.com/users/HongyingG/gists{/gist_id}","starred_url":"https://api.github.com/users/HongyingG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HongyingG/subscriptions","organizations_url":"https://api.github.com/users/HongyingG/orgs","repos_url":"https://api.github.com/users/HongyingG/repos","events_url":"https://api.github.com/users/HongyingG/events{/privacy}","received_events_url":"https://api.github.com/users/HongyingG/received_events","type":"User","site_admin":false},"repo":{"id":156147880,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxNDc4ODA=","name":"FluidDoc","full_name":"HongyingG/FluidDoc","private":false,"owner":{"login":"HongyingG","id":44694098,"node_id":"MDQ6VXNlcjQ0Njk0MDk4","avatar_url":"https://avatars2.githubusercontent.com/u/44694098?v=4","gravatar_id":"","url":"https://api.github.com/users/HongyingG","html_url":"https://github.com/HongyingG","followers_url":"https://api.github.com/users/HongyingG/followers","following_url":"https://api.github.com/users/HongyingG/following{/other_user}","gists_url":"https://api.github.com/users/HongyingG/gists{/gist_id}","starred_url":"https://api.github.com/users/HongyingG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HongyingG/subscriptions","organizations_url":"https://api.github.com/users/HongyingG/orgs","repos_url":"https://api.github.com/users/HongyingG/repos","events_url":"https://api.github.com/users/HongyingG/events{/privacy}","received_events_url":"https://api.github.com/users/HongyingG/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HongyingG/FluidDoc","description":"Documentations for PaddlePaddle","fork":true,"url":"https://api.github.com/repos/HongyingG/FluidDoc","forks_url":"https://api.github.com/repos/HongyingG/FluidDoc/forks","keys_url":"https://api.github.com/repos/HongyingG/FluidDoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HongyingG/FluidDoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HongyingG/FluidDoc/teams","hooks_url":"https://api.github.com/repos/HongyingG/FluidDoc/hooks","issue_events_url":"https://api.github.com/repos/HongyingG/FluidDoc/issues/events{/number}","events_url":"https://api.github.com/repos/HongyingG/FluidDoc/events","assignees_url":"https://api.github.com/repos/HongyingG/FluidDoc/assignees{/user}","branches_url":"https://api.github.com/repos/HongyingG/FluidDoc/branches{/branch}","tags_url":"https://api.github.com/repos/HongyingG/FluidDoc/tags","blobs_url":"https://api.github.com/repos/HongyingG/FluidDoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HongyingG/FluidDoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HongyingG/FluidDoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/HongyingG/FluidDoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HongyingG/FluidDoc/statuses/{sha}","languages_url":"https://api.github.com/repos/HongyingG/FluidDoc/languages","stargazers_url":"https://api.github.com/repos/HongyingG/FluidDoc/stargazers","contributors_url":"https://api.github.com/repos/HongyingG/FluidDoc/contributors","subscribers_url":"https://api.github.com/repos/HongyingG/FluidDoc/subscribers","subscription_url":"https://api.github.com/repos/HongyingG/FluidDoc/subscription","commits_url":"https://api.github.com/repos/HongyingG/FluidDoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/HongyingG/FluidDoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/HongyingG/FluidDoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/HongyingG/FluidDoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/HongyingG/FluidDoc/contents/{+path}","compare_url":"https://api.github.com/repos/HongyingG/FluidDoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HongyingG/FluidDoc/merges","archive_url":"https://api.github.com/repos/HongyingG/FluidDoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HongyingG/FluidDoc/downloads","issues_url":"https://api.github.com/repos/HongyingG/FluidDoc/issues{/number}","pulls_url":"https://api.github.com/repos/HongyingG/FluidDoc/pulls{/number}","milestones_url":"https://api.github.com/repos/HongyingG/FluidDoc/milestones{/number}","notifications_url":"https://api.github.com/repos/HongyingG/FluidDoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HongyingG/FluidDoc/labels{/name}","releases_url":"https://api.github.com/repos/HongyingG/FluidDoc/releases{/id}","deployments_url":"https://api.github.com/repos/HongyingG/FluidDoc/deployments","created_at":"2018-11-05T02:13:32Z","updated_at":"2018-11-05T02:13:34Z","pushed_at":"2018-12-23T15:21:57Z","git_url":"git://github.com/HongyingG/FluidDoc.git","ssh_url":"git@github.com:HongyingG/FluidDoc.git","clone_url":"https://github.com/HongyingG/FluidDoc.git","svn_url":"https://github.com/HongyingG/FluidDoc","homepage":"http://paddlepaddle.org/documentation/zh","size":33602,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"c93aa2ad34d9f23a3bd3c341c3f2b52b59d08052","user":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":136450404,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NTA0MDQ=","name":"FluidDoc","full_name":"PaddlePaddle/FluidDoc","private":false,"owner":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaddlePaddle/FluidDoc","description":"Documentations for PaddlePaddle","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc","forks_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/deployments","created_at":"2018-06-07T08:58:28Z","updated_at":"2018-12-19T12:58:00Z","pushed_at":"2018-12-24T03:56:33Z","git_url":"git://github.com/PaddlePaddle/FluidDoc.git","ssh_url":"git@github.com:PaddlePaddle/FluidDoc.git","clone_url":"https://github.com/PaddlePaddle/FluidDoc.git","svn_url":"https://github.com/PaddlePaddle/FluidDoc","homepage":"http://paddlepaddle.org/documentation/zh","size":35965,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":44,"open_issues":22,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500"},"html":{"href":"https://github.com/PaddlePaddle/FluidDoc/pull/500"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/500"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/91a8e17d1d715aa528b88070da49cf6f76fbad0d"}},"author_association":"COLLABORATOR"}} | {
"id": 136450404,
"name": "PaddlePaddle/FluidDoc",
"url": "https://api.github.com/repos/PaddlePaddle/FluidDoc"
} | {
"id": 35982308,
"login": "shanyi15",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35982308?",
"url": "https://api.github.com/users/shanyi15"
} | {
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
} | 2018-12-25T04:14:52 | 8800720407 | {"actor":{"display_login":"shanyi15"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments/239121995","pull_request_review_id":181827721,"id":239121995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTEyMTk5NQ==","diff_hunk":"@@ -0,0 +1,15 @@\n+## High/Low-level API简介\n+","path":"doc/fluid/api_cn/api_guides/high_low_level_api.md","position":2,"original_position":2,"commit_id":"7f0cba61bafe18d837d489635594923a676f1184","original_commit_id":"7f0cba61bafe18d837d489635594923a676f1184","user":{"login":"shanyi15","id":35982308,"node_id":"MDQ6VXNlcjM1OTgyMzA4","avatar_url":"https://avatars1.githubusercontent.com/u/35982308?v=4","gravatar_id":"","url":"https://api.github.com/users/shanyi15","html_url":"https://github.com/shanyi15","followers_url":"https://api.github.com/users/shanyi15/followers","following_url":"https://api.github.com/users/shanyi15/following{/other_user}","gists_url":"https://api.github.com/users/shanyi15/gists{/gist_id}","starred_url":"https://api.github.com/users/shanyi15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanyi15/subscriptions","organizations_url":"https://api.github.com/users/shanyi15/orgs","repos_url":"https://api.github.com/users/shanyi15/repos","events_url":"https://api.github.com/users/shanyi15/events{/privacy}","received_events_url":"https://api.github.com/users/shanyi15/received_events","type":"User","site_admin":false},"body":"已有文档请用软链接，以方便维护，下同","created_at":"2018-12-05T15:50:11Z","updated_at":"2018-12-05T15:54:14Z","html_url":"https://github.com/PaddlePaddle/FluidDoc/pull/437#discussion_r239121995","pull_request_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments/239121995"},"html":{"href":"https://github.com/PaddlePaddle/FluidDoc/pull/437#discussion_r239121995"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437","id":236219201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjE5MjAx","html_url":"https://github.com/PaddlePaddle/FluidDoc/pull/437","diff_url":"https://github.com/PaddlePaddle/FluidDoc/pull/437.diff","patch_url":"https://github.com/PaddlePaddle/FluidDoc/pull/437.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/437","number":437,"state":"open","locked":false,"title":"add_api_cn","user":{"login":"tink2123","id":31891223,"node_id":"MDQ6VXNlcjMxODkxMjIz","avatar_url":"https://avatars3.githubusercontent.com/u/31891223?v=4","gravatar_id":"","url":"https://api.github.com/users/tink2123","html_url":"https://github.com/tink2123","followers_url":"https://api.github.com/users/tink2123/followers","following_url":"https://api.github.com/users/tink2123/following{/other_user}","gists_url":"https://api.github.com/users/tink2123/gists{/gist_id}","starred_url":"https://api.github.com/users/tink2123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tink2123/subscriptions","organizations_url":"https://api.github.com/users/tink2123/orgs","repos_url":"https://api.github.com/users/tink2123/repos","events_url":"https://api.github.com/users/tink2123/events{/privacy}","received_events_url":"https://api.github.com/users/tink2123/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-05T15:36:16Z","updated_at":"2018-12-05T15:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a1f0035d8fe042cdeeacc3e95159c64e8d00055","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/437/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/7f0cba61bafe18d837d489635594923a676f1184","head":{"label":"tink2123:api_cn_1205","ref":"api_cn_1205","sha":"7f0cba61bafe18d837d489635594923a676f1184","user":{"login":"tink2123","id":31891223,"node_id":"MDQ6VXNlcjMxODkxMjIz","avatar_url":"https://avatars3.githubusercontent.com/u/31891223?v=4","gravatar_id":"","url":"https://api.github.com/users/tink2123","html_url":"https://github.com/tink2123","followers_url":"https://api.github.com/users/tink2123/followers","following_url":"https://api.github.com/users/tink2123/following{/other_user}","gists_url":"https://api.github.com/users/tink2123/gists{/gist_id}","starred_url":"https://api.github.com/users/tink2123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tink2123/subscriptions","organizations_url":"https://api.github.com/users/tink2123/orgs","repos_url":"https://api.github.com/users/tink2123/repos","events_url":"https://api.github.com/users/tink2123/events{/privacy}","received_events_url":"https://api.github.com/users/tink2123/received_events","type":"User","site_admin":false},"repo":{"id":143846616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4NDY2MTY=","name":"FluidDoc","full_name":"tink2123/FluidDoc","private":false,"owner":{"login":"tink2123","id":31891223,"node_id":"MDQ6VXNlcjMxODkxMjIz","avatar_url":"https://avatars3.githubusercontent.com/u/31891223?v=4","gravatar_id":"","url":"https://api.github.com/users/tink2123","html_url":"https://github.com/tink2123","followers_url":"https://api.github.com/users/tink2123/followers","following_url":"https://api.github.com/users/tink2123/following{/other_user}","gists_url":"https://api.github.com/users/tink2123/gists{/gist_id}","starred_url":"https://api.github.com/users/tink2123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tink2123/subscriptions","organizations_url":"https://api.github.com/users/tink2123/orgs","repos_url":"https://api.github.com/users/tink2123/repos","events_url":"https://api.github.com/users/tink2123/events{/privacy}","received_events_url":"https://api.github.com/users/tink2123/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tink2123/FluidDoc","description":null,"fork":true,"url":"https://api.github.com/repos/tink2123/FluidDoc","forks_url":"https://api.github.com/repos/tink2123/FluidDoc/forks","keys_url":"https://api.github.com/repos/tink2123/FluidDoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tink2123/FluidDoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tink2123/FluidDoc/teams","hooks_url":"https://api.github.com/repos/tink2123/FluidDoc/hooks","issue_events_url":"https://api.github.com/repos/tink2123/FluidDoc/issues/events{/number}","events_url":"https://api.github.com/repos/tink2123/FluidDoc/events","assignees_url":"https://api.github.com/repos/tink2123/FluidDoc/assignees{/user}","branches_url":"https://api.github.com/repos/tink2123/FluidDoc/branches{/branch}","tags_url":"https://api.github.com/repos/tink2123/FluidDoc/tags","blobs_url":"https://api.github.com/repos/tink2123/FluidDoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tink2123/FluidDoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tink2123/FluidDoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tink2123/FluidDoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tink2123/FluidDoc/statuses/{sha}","languages_url":"https://api.github.com/repos/tink2123/FluidDoc/languages","stargazers_url":"https://api.github.com/repos/tink2123/FluidDoc/stargazers","contributors_url":"https://api.github.com/repos/tink2123/FluidDoc/contributors","subscribers_url":"https://api.github.com/repos/tink2123/FluidDoc/subscribers","subscription_url":"https://api.github.com/repos/tink2123/FluidDoc/subscription","commits_url":"https://api.github.com/repos/tink2123/FluidDoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tink2123/FluidDoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tink2123/FluidDoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tink2123/FluidDoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tink2123/FluidDoc/contents/{+path}","compare_url":"https://api.github.com/repos/tink2123/FluidDoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tink2123/FluidDoc/merges","archive_url":"https://api.github.com/repos/tink2123/FluidDoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tink2123/FluidDoc/downloads","issues_url":"https://api.github.com/repos/tink2123/FluidDoc/issues{/number}","pulls_url":"https://api.github.com/repos/tink2123/FluidDoc/pulls{/number}","milestones_url":"https://api.github.com/repos/tink2123/FluidDoc/milestones{/number}","notifications_url":"https://api.github.com/repos/tink2123/FluidDoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tink2123/FluidDoc/labels{/name}","releases_url":"https://api.github.com/repos/tink2123/FluidDoc/releases{/id}","deployments_url":"https://api.github.com/repos/tink2123/FluidDoc/deployments","created_at":"2018-08-07T08:55:30Z","updated_at":"2018-10-12T08:22:24Z","pushed_at":"2018-12-05T15:35:24Z","git_url":"git://github.com/tink2123/FluidDoc.git","ssh_url":"git@github.com:tink2123/FluidDoc.git","clone_url":"https://github.com/tink2123/FluidDoc.git","svn_url":"https://github.com/tink2123/FluidDoc","homepage":null,"size":35814,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"757b96fe62e4af28fc049c272756014130672628","user":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":136450404,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NTA0MDQ=","name":"FluidDoc","full_name":"PaddlePaddle/FluidDoc","private":false,"owner":{"login":"PaddlePaddle","id":23534030,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0MDMw","avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaddlePaddle/FluidDoc","description":"Documentations for PaddlePaddle","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/FluidDoc","forks_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/FluidDoc/deployments","created_at":"2018-06-07T08:58:28Z","updated_at":"2018-12-05T12:58:11Z","pushed_at":"2018-12-05T15:36:17Z","git_url":"git://github.com/PaddlePaddle/FluidDoc.git","ssh_url":"git@github.com:PaddlePaddle/FluidDoc.git","clone_url":"https://github.com/PaddlePaddle/FluidDoc.git","svn_url":"https://github.com/PaddlePaddle/FluidDoc","homepage":"http://paddlepaddle.org/documentation/zh","size":35447,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":42,"open_issues":24,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437"},"html":{"href":"https://github.com/PaddlePaddle/FluidDoc/pull/437"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/437"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/FluidDoc/statuses/7f0cba61bafe18d837d489635594923a676f1184"}},"author_association":"COLLABORATOR"}} | {
"id": 136450404,
"name": "PaddlePaddle/FluidDoc",
"url": "https://api.github.com/repos/PaddlePaddle/FluidDoc"
} | {
"id": 35982308,
"login": "shanyi15",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35982308?",
"url": "https://api.github.com/users/shanyi15"
} | {
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
} | 2018-12-05T15:50:11 | 8703105045 | {"actor":{"display_login":"shanyi15"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/218034161","pull_request_review_id":155879844,"id":218034161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODAzNDE2MQ==","diff_hunk":"@@ -171,23 +190,70 @@ func (s *DiscoveryServer) updateCluster(push *model.PushContext, clusterName str\n \t// We still lock the access to the LoadAssignments.\n \tedsCluster.mutex.Lock()\n \tdefer edsCluster.mutex.Unlock()\n-\tedsCluster.LoadAssignment = &xdsapi.ClusterLoadAssignment{\n-\t\tClusterName: clusterName,\n-\t\tEndpoints: locEps,\n-\t}\n-\tif len(locEps) > 0 && edsCluster.NonEmptyTime.IsZero() {\n-\t\tedsCluster.NonEmptyTime = time.Now()\n+\tfor n, locEps := range locEpsByNetwork {\n+\t\tedsCluster.ClusterLoadAssignments[n] = &xdsapi.ClusterLoadAssignment{\n+\t\t\tClusterName: clusterName,\n+\t\t\tEndpoints: locEps,\n+\t\t}\n+\t\tedsCluster.GatewaysEndpoints[n] = networkGateway(n, locEps, edsCluster.discovery.env.ServiceDiscovery)\n+\n+\t\tif len(locEps) > 0 && edsCluster.NonEmptyTime.IsZero() {\n+\t\t\tedsCluster.NonEmptyTime = time.Now()\n+\t\t}\n \t}\n \n \treturn nil\n }\n \n+// networkGateway returns an endpoint to the gateway of a remote Istio network.\n+// The weight of the endpoint will equal to the number of endpoints in the\n+// remote network. If the remote network has no cluster endpoints (weight 0)\n+// nil will be returned.\n+func networkGateway(network string, eps []endpoint.LocalityLbEndpoints, sd model.ServiceDiscovery) *endpoint.LocalityLbEndpoints {\n+\tweight := 0\n+\tfor _, ep := range eps {\n+\t\tweight += len(ep.LbEndpoints)\n+\t}\n+\tif weight == 0 {\n+\t\treturn nil\n+\t}\n+\n+\t// TODO: verify the right gateway service hostname and labels\n+\thostname := model.Hostname(\"istio-ingress.istio-system.svc.cluster.local\")\n+\tport := 80\n+\tlabels := model.LabelsCollection{model.Labels{\"istio\": \"ingress\", \"ISTIO_NETWORK\": network}}","path":"pilot/pkg/proxy/envoy/v2/eds.go","position":100,"original_position":100,"commit_id":"c801fb0a8db4f73b139cb8b6207ceefdd17d9590","original_commit_id":"c801fb0a8db4f73b139cb8b6207ceefdd17d9590","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"body":"I think that both IP and Port config parameters should be specified to create the endpoint address. Is that right?\r\nIIUC the logic will be to first see if the config params exist. If they don't then get the public IP of the LB service? So basically no needs to search for instances for the Istio ingress, etc.\r\n\r\nAlso an open question is what if we have multiple gateways.","created_at":"2018-09-17T11:28:29Z","updated_at":"2018-09-17T11:28:29Z","html_url":"https://github.com/istio/istio/pull/8529#discussion_r218034161","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/218034161"},"html":{"href":"https://github.com/istio/istio/pull/8529#discussion_r218034161"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8529"}},"in_reply_to_id":217730782},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8529","id":213700799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzAwNzk5","html_url":"https://github.com/istio/istio/pull/8529","diff_url":"https://github.com/istio/istio/pull/8529.diff","patch_url":"https://github.com/istio/istio/pull/8529.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8529","number":8529,"state":"open","locked":false,"title":"[WIP] Split Horizon EDS","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"body":"Preliminary changes to Pilot to support the Split Horizon EDS.\r\nThis PR is just for the sake of discussion around the changes needed and appropriate data structures for keeping this scalable and avoid affecting a single cluster/network.\r\n\r\ncc @costinm @linsun ","created_at":"2018-09-06T17:55:50Z","updated_at":"2018-09-17T11:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b348ad2ebef622d16a952d1bbf2ef4920ea0fe07","assignee":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"assignees":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":957605109,"node_id":"MDU6TGFiZWw5NTc2MDUxMDk=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8529/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8529/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8529/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/c801fb0a8db4f73b139cb8b6207ceefdd17d9590","head":{"label":"ymesika:splitHorizonEds","ref":"splitHorizonEds","sha":"c801fb0a8db4f73b139cb8b6207ceefdd17d9590","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"repo":{"id":109562402,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1NjI0MDI=","name":"istio","full_name":"ymesika/istio","private":false,"owner":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ymesika/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/ymesika/istio","forks_url":"https://api.github.com/repos/ymesika/istio/forks","keys_url":"https://api.github.com/repos/ymesika/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymesika/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymesika/istio/teams","hooks_url":"https://api.github.com/repos/ymesika/istio/hooks","issue_events_url":"https://api.github.com/repos/ymesika/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ymesika/istio/events","assignees_url":"https://api.github.com/repos/ymesika/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ymesika/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ymesika/istio/tags","blobs_url":"https://api.github.com/repos/ymesika/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymesika/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymesika/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymesika/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymesika/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ymesika/istio/languages","stargazers_url":"https://api.github.com/repos/ymesika/istio/stargazers","contributors_url":"https://api.github.com/repos/ymesika/istio/contributors","subscribers_url":"https://api.github.com/repos/ymesika/istio/subscribers","subscription_url":"https://api.github.com/repos/ymesika/istio/subscription","commits_url":"https://api.github.com/repos/ymesika/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymesika/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymesika/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymesika/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymesika/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ymesika/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymesika/istio/merges","archive_url":"https://api.github.com/repos/ymesika/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymesika/istio/downloads","issues_url":"https://api.github.com/repos/ymesika/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ymesika/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ymesika/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ymesika/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymesika/istio/labels{/name}","releases_url":"https://api.github.com/repos/ymesika/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ymesika/istio/deployments","created_at":"2017-11-05T09:15:48Z","updated_at":"2018-05-13T07:28:45Z","pushed_at":"2018-09-17T05:49:23Z","git_url":"git://github.com/ymesika/istio.git","ssh_url":"git@github.com:ymesika/istio.git","clone_url":"https://github.com/ymesika/istio.git","svn_url":"https://github.com/ymesika/istio","homepage":"https://istio.io","size":47878,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"8630030c6549965374bc638dc64ecbe210b72dd8","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-09-17T10:23:56Z","pushed_at":"2018-09-17T09:39:12Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":48804,"stargazers_count":11711,"watchers_count":11711,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1701,"mirror_url":null,"archived":false,"open_issues_count":918,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1701,"open_issues":918,"watchers":11711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8529"},"html":{"href":"https://github.com/istio/istio/pull/8529"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8529"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8529/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8529/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8529/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/c801fb0a8db4f73b139cb8b6207ceefdd17d9590"}},"author_association":"CONTRIBUTOR"}} | {
"id": 74175805,
"name": "istio/istio",
"url": "https://api.github.com/repos/istio/istio"
} | {
"id": 26809068,
"login": "ymesika",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26809068?",
"url": "https://api.github.com/users/ymesika"
} | {
"id": 23534644,
"login": "istio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534644?",
"url": "https://api.github.com/orgs/istio"
} | 2018-09-17T11:28:29 | 8274928503 | {"actor":{"display_login":"ymesika"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/233979527","pull_request_review_id":175520115,"id":233979527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk3OTUyNw==","diff_hunk":"@@ -194,6 +194,7 @@ func createRetryPushFn(pushCount *int, expReqTS [][]*monitoring.TimeSeries, with\n \t\t\t\tlen(expReqTS), len(withError), len(failedTS), *pushCount)\n \t\t\treturn nil\n \t\t}\n+\t\t// nolint: unparam\n \t\tdefer func(pc *int) {\n \t\t\t(*pushCount)++","path":"mixer/adapter/stackdriver/metric/bufferedClient_test.go","position":null,"original_position":6,"commit_id":"e006e4e651b001e8cd3ab038f0473769ec9e12c2","original_commit_id":"554a79974b9a231cd7eec956ae18523d083d1347","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"Added a fix. Thanks.","created_at":"2018-11-15T19:32:40Z","updated_at":"2018-11-15T19:32:41Z","html_url":"https://github.com/istio/istio/pull/9990#discussion_r233979527","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/9990","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/233979527"},"html":{"href":"https://github.com/istio/istio/pull/9990#discussion_r233979527"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/9990"}},"in_reply_to_id":233974296},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9990","id":231304416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzA0NDE2","html_url":"https://github.com/istio/istio/pull/9990","diff_url":"https://github.com/istio/istio/pull/9990.diff","patch_url":"https://github.com/istio/istio/pull/9990.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/9990","number":9990,"state":"open","locked":false,"title":"ci: simplify code with unparam linter","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Kuat Yessenov <kuat@google.com>","created_at":"2018-11-15T19:15:18Z","updated_at":"2018-11-15T19:32:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6ccbbf90c1ac8e08716fa79785cb70df308d2f3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},{"login":"hklai","id":31747472,"node_id":"MDQ6VXNlcjMxNzQ3NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/31747472?v=4","gravatar_id":"","url":"https://api.github.com/users/hklai","html_url":"https://github.com/hklai","followers_url":"https://api.github.com/users/hklai/followers","following_url":"https://api.github.com/users/hklai/following{/other_user}","gists_url":"https://api.github.com/users/hklai/gists{/gist_id}","starred_url":"https://api.github.com/users/hklai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hklai/subscriptions","organizations_url":"https://api.github.com/users/hklai/orgs","repos_url":"https://api.github.com/users/hklai/repos","events_url":"https://api.github.com/users/hklai/events{/privacy}","received_events_url":"https://api.github.com/users/hklai/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/9990/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/9990/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/9990/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/e006e4e651b001e8cd3ab038f0473769ec9e12c2","head":{"label":"kyessenov:unparam","ref":"unparam","sha":"e006e4e651b001e8cd3ab038f0473769ec9e12c2","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":84379582,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM3OTU4Mg==","name":"istio","full_name":"kyessenov/istio","private":false,"owner":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kyessenov/istio","description":"A service mesh for polyglot microservices","fork":true,"url":"https://api.github.com/repos/kyessenov/istio","forks_url":"https://api.github.com/repos/kyessenov/istio/forks","keys_url":"https://api.github.com/repos/kyessenov/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/istio/teams","hooks_url":"https://api.github.com/repos/kyessenov/istio/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/istio/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/istio/events","assignees_url":"https://api.github.com/repos/kyessenov/istio/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/istio/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/istio/tags","blobs_url":"https://api.github.com/repos/kyessenov/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/istio/languages","stargazers_url":"https://api.github.com/repos/kyessenov/istio/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/istio/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/istio/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/istio/subscription","commits_url":"https://api.github.com/repos/kyessenov/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/istio/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/istio/merges","archive_url":"https://api.github.com/repos/kyessenov/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/istio/downloads","issues_url":"https://api.github.com/repos/kyessenov/istio/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/istio/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/istio/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/istio/deployments","created_at":"2017-03-09T00:25:48Z","updated_at":"2017-03-09T00:25:50Z","pushed_at":"2018-11-15T19:32:28Z","git_url":"git://github.com/kyessenov/istio.git","ssh_url":"git@github.com:kyessenov/istio.git","clone_url":"https://github.com/kyessenov/istio.git","svn_url":"https://github.com/kyessenov/istio","homepage":"","size":137743,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.1","ref":"release-1.1","sha":"8978f3768f6a72c210e7298d2c627fd11eb62e2e","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-11-15T17:50:48Z","pushed_at":"2018-11-15T19:32:30Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":53995,"stargazers_count":13086,"watchers_count":13086,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1988,"mirror_url":null,"archived":false,"open_issues_count":1089,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1988,"open_issues":1089,"watchers":13086,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/9990"},"html":{"href":"https://github.com/istio/istio/pull/9990"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/9990"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/9990/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/9990/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/9990/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/e006e4e651b001e8cd3ab038f0473769ec9e12c2"}},"author_association":"MEMBER"}} | {
"id": 74175805,
"name": "istio/istio",
"url": "https://api.github.com/repos/istio/istio"
} | {
"id": 9537734,
"login": "kyessenov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9537734?",
"url": "https://api.github.com/users/kyessenov"
} | {
"id": 23534644,
"login": "istio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534644?",
"url": "https://api.github.com/orgs/istio"
} | 2018-11-15T19:32:40 | 8597719660 | {"actor":{"display_login":"kyessenov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/195255676","pull_request_review_id":128588064,"id":195255676,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI1NTY3Ng==","diff_hunk":"@@ -9,3 +9,4 @@ approvers:\n - rshriram\n - vadimeisenbergibm\n - zackbutcher\n+ - baodongli","path":"pilot/OWNERS","position":4,"original_position":4,"commit_id":"ea383c22394e6656037e4bdc4acfe1265f9d0c57","original_commit_id":"ea383c22394e6656037e4bdc4acfe1265f9d0c57","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"could you scope this to specific packages to start with?","created_at":"2018-06-13T22:29:07Z","updated_at":"2018-06-13T22:29:07Z","html_url":"https://github.com/istio/istio/pull/6255#discussion_r195255676","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/6255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/195255676"},"html":{"href":"https://github.com/istio/istio/pull/6255#discussion_r195255676"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/6255"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6255","id":194708860,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzA4ODYw","html_url":"https://github.com/istio/istio/pull/6255","diff_url":"https://github.com/istio/istio/pull/6255.diff","patch_url":"https://github.com/istio/istio/pull/6255.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/6255","number":6255,"state":"open","locked":false,"title":"Self nominating Baodong (Robert) Li to OWNERS file of pilot","user":{"login":"baodongli","id":3081257,"node_id":"MDQ6VXNlcjMwODEyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3081257?v=4","gravatar_id":"","url":"https://api.github.com/users/baodongli","html_url":"https://github.com/baodongli","followers_url":"https://api.github.com/users/baodongli/followers","following_url":"https://api.github.com/users/baodongli/following{/other_user}","gists_url":"https://api.github.com/users/baodongli/gists{/gist_id}","starred_url":"https://api.github.com/users/baodongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baodongli/subscriptions","organizations_url":"https://api.github.com/users/baodongli/orgs","repos_url":"https://api.github.com/users/baodongli/repos","events_url":"https://api.github.com/users/baodongli/events{/privacy}","received_events_url":"https://api.github.com/users/baodongli/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-13T20:41:16Z","updated_at":"2018-06-13T22:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"016d2bdddaeed7678dcea167fbac488494b1b29c","assignee":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"assignees":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/6255/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/6255/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/6255/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/ea383c22394e6656037e4bdc4acfe1265f9d0c57","head":{"label":"baodongli:owner","ref":"owner","sha":"ea383c22394e6656037e4bdc4acfe1265f9d0c57","user":{"login":"baodongli","id":3081257,"node_id":"MDQ6VXNlcjMwODEyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3081257?v=4","gravatar_id":"","url":"https://api.github.com/users/baodongli","html_url":"https://github.com/baodongli","followers_url":"https://api.github.com/users/baodongli/followers","following_url":"https://api.github.com/users/baodongli/following{/other_user}","gists_url":"https://api.github.com/users/baodongli/gists{/gist_id}","starred_url":"https://api.github.com/users/baodongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baodongli/subscriptions","organizations_url":"https://api.github.com/users/baodongli/orgs","repos_url":"https://api.github.com/users/baodongli/repos","events_url":"https://api.github.com/users/baodongli/events{/privacy}","received_events_url":"https://api.github.com/users/baodongli/received_events","type":"User","site_admin":false},"repo":{"id":109305530,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDU1MzA=","name":"istio","full_name":"baodongli/istio","owner":{"login":"baodongli","id":3081257,"node_id":"MDQ6VXNlcjMwODEyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3081257?v=4","gravatar_id":"","url":"https://api.github.com/users/baodongli","html_url":"https://github.com/baodongli","followers_url":"https://api.github.com/users/baodongli/followers","following_url":"https://api.github.com/users/baodongli/following{/other_user}","gists_url":"https://api.github.com/users/baodongli/gists{/gist_id}","starred_url":"https://api.github.com/users/baodongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baodongli/subscriptions","organizations_url":"https://api.github.com/users/baodongli/orgs","repos_url":"https://api.github.com/users/baodongli/repos","events_url":"https://api.github.com/users/baodongli/events{/privacy}","received_events_url":"https://api.github.com/users/baodongli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baodongli/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/baodongli/istio","forks_url":"https://api.github.com/repos/baodongli/istio/forks","keys_url":"https://api.github.com/repos/baodongli/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baodongli/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baodongli/istio/teams","hooks_url":"https://api.github.com/repos/baodongli/istio/hooks","issue_events_url":"https://api.github.com/repos/baodongli/istio/issues/events{/number}","events_url":"https://api.github.com/repos/baodongli/istio/events","assignees_url":"https://api.github.com/repos/baodongli/istio/assignees{/user}","branches_url":"https://api.github.com/repos/baodongli/istio/branches{/branch}","tags_url":"https://api.github.com/repos/baodongli/istio/tags","blobs_url":"https://api.github.com/repos/baodongli/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baodongli/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baodongli/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/baodongli/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baodongli/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/baodongli/istio/languages","stargazers_url":"https://api.github.com/repos/baodongli/istio/stargazers","contributors_url":"https://api.github.com/repos/baodongli/istio/contributors","subscribers_url":"https://api.github.com/repos/baodongli/istio/subscribers","subscription_url":"https://api.github.com/repos/baodongli/istio/subscription","commits_url":"https://api.github.com/repos/baodongli/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/baodongli/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/baodongli/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/baodongli/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/baodongli/istio/contents/{+path}","compare_url":"https://api.github.com/repos/baodongli/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baodongli/istio/merges","archive_url":"https://api.github.com/repos/baodongli/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baodongli/istio/downloads","issues_url":"https://api.github.com/repos/baodongli/istio/issues{/number}","pulls_url":"https://api.github.com/repos/baodongli/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/baodongli/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/baodongli/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baodongli/istio/labels{/name}","releases_url":"https://api.github.com/repos/baodongli/istio/releases{/id}","deployments_url":"https://api.github.com/repos/baodongli/istio/deployments","created_at":"2017-11-02T18:48:55Z","updated_at":"2018-04-05T19:53:18Z","pushed_at":"2018-06-13T18:28:51Z","git_url":"git://github.com/baodongli/istio.git","ssh_url":"git@github.com:baodongli/istio.git","clone_url":"https://github.com/baodongli/istio.git","svn_url":"https://github.com/baodongli/istio","homepage":"https://istio.io","size":37754,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"2dd8f38090cff6a69c8cc72df9f565c6bf776500","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-13T22:10:00Z","pushed_at":"2018-06-13T22:28:21Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":38222,"stargazers_count":8666,"watchers_count":8666,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1182,"mirror_url":null,"archived":false,"open_issues_count":857,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1182,"open_issues":857,"watchers":8666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/6255"},"html":{"href":"https://github.com/istio/istio/pull/6255"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/6255"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/6255/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/6255/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/6255/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/ea383c22394e6656037e4bdc4acfe1265f9d0c57"}},"author_association":"CONTRIBUTOR"}} | {
"id": 74175805,
"name": "istio/istio",
"url": "https://api.github.com/repos/istio/istio"
} | {
"id": 8202871,
"login": "rshriram",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8202871?",
"url": "https://api.github.com/users/rshriram"
} | {
"id": 23534644,
"login": "istio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534644?",
"url": "https://api.github.com/orgs/istio"
} | 2018-06-13T22:29:07 | 7821761141 | {"actor":{"display_login":"rshriram"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.io/pulls/comments/221413082","pull_request_review_id":160063218,"id":221413082,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQxMzA4Mg==","diff_hunk":"@@ -114,7 +114,13 @@ This guide installs the current release version of Istio.\n $ helm del istio --purge\n {{< /text >}}\n \n-1. Delete the Istio custom resource definitions:\n+ If your Helm version is less than 2.9.0, then you need to manually cleanup extra job resource before redeploy new version of Istio chart:\n+\n+ {{< text bash >}}\n+ $ kubectl -n istio-system delete job --all\n+ {{< /text >}}\n+\n+1. If desired, delete the Istio custom resource definitions:","path":"content/docs/setup/kubernetes/quick-start-ibm/index.md","position":20,"original_position":20,"commit_id":"ce9f73fdda294e3c1306ea658120e0c83dd47a53","original_commit_id":"ce9f73fdda294e3c1306ea658120e0c83dd47a53","user":{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"body":"@morvencao does Istio helm chart include post uninstall hooks can help delete those CRD? If so, I think we do not require the end user to delete those CRDs manually?","created_at":"2018-09-29T02:42:38Z","updated_at":"2018-09-29T02:43:51Z","html_url":"https://github.com/istio/istio.io/pull/2705#discussion_r221413082","pull_request_url":"https://api.github.com/repos/istio/istio.io/pulls/2705","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments/221413082"},"html":{"href":"https://github.com/istio/istio.io/pull/2705#discussion_r221413082"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2705"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.io/pulls/2705","id":219088546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDg4NTQ2","html_url":"https://github.com/istio/istio.io/pull/2705","diff_url":"https://github.com/istio/istio.io/pull/2705.diff","patch_url":"https://github.com/istio/istio.io/pull/2705.patch","issue_url":"https://api.github.com/repos/istio/istio.io/issues/2705","number":2705,"state":"open","locked":false,"title":"update helm instruct for 2.10 and uninstall","user":{"login":"linsun","id":1588319,"node_id":"MDQ6VXNlcjE1ODgzMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1588319?v=4","gravatar_id":"","url":"https://api.github.com/users/linsun","html_url":"https://github.com/linsun","followers_url":"https://api.github.com/users/linsun/followers","following_url":"https://api.github.com/users/linsun/following{/other_user}","gists_url":"https://api.github.com/users/linsun/gists{/gist_id}","starred_url":"https://api.github.com/users/linsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linsun/subscriptions","organizations_url":"https://api.github.com/users/linsun/orgs","repos_url":"https://api.github.com/users/linsun/repos","events_url":"https://api.github.com/users/linsun/events{/privacy}","received_events_url":"https://api.github.com/users/linsun/received_events","type":"User","site_admin":false},"body":"for 2.9","created_at":"2018-09-28T21:19:00Z","updated_at":"2018-09-29T02:43:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"017922913f76707452a990e8aae86e9453b84a29","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},{"login":"rcaballeromx","id":10066027,"node_id":"MDQ6VXNlcjEwMDY2MDI3","avatar_url":"https://avatars1.githubusercontent.com/u/10066027?v=4","gravatar_id":"","url":"https://api.github.com/users/rcaballeromx","html_url":"https://github.com/rcaballeromx","followers_url":"https://api.github.com/users/rcaballeromx/followers","following_url":"https://api.github.com/users/rcaballeromx/following{/other_user}","gists_url":"https://api.github.com/users/rcaballeromx/gists{/gist_id}","starred_url":"https://api.github.com/users/rcaballeromx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcaballeromx/subscriptions","organizations_url":"https://api.github.com/users/rcaballeromx/orgs","repos_url":"https://api.github.com/users/rcaballeromx/repos","events_url":"https://api.github.com/users/rcaballeromx/events{/privacy}","received_events_url":"https://api.github.com/users/rcaballeromx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"node_id":"MDU6TGFiZWw4ODQyNDc0NzU=","url":"https://api.github.com/repos/istio/istio.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.io/pulls/2705/commits","review_comments_url":"https://api.github.com/repos/istio/istio.io/pulls/2705/comments","review_comment_url":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.io/issues/2705/comments","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/ce9f73fdda294e3c1306ea658120e0c83dd47a53","head":{"label":"istio:linsun-patch-1","ref":"linsun-patch-1","sha":"ce9f73fdda294e3c1306ea658120e0c83dd47a53","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.io","full_name":"istio/istio.io","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.io","forks_url":"https://api.github.com/repos/istio/istio.io/forks","keys_url":"https://api.github.com/repos/istio/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.io/events","assignees_url":"https://api.github.com/repos/istio/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.io/merges","archive_url":"https://api.github.com/repos/istio/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-09-28T23:11:55Z","pushed_at":"2018-09-28T23:11:50Z","git_url":"git://github.com/istio/istio.io.git","ssh_url":"git@github.com:istio/istio.io.git","clone_url":"https://github.com/istio/istio.io.git","svn_url":"https://github.com/istio/istio.io","homepage":"https://istio.io/","size":35801,"stargazers_count":127,"watchers_count":127,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":358,"open_issues":99,"watchers":127,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"706cdf2335cb65f2fbe16de6f3c9540a8c950919","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.io","full_name":"istio/istio.io","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.io","forks_url":"https://api.github.com/repos/istio/istio.io/forks","keys_url":"https://api.github.com/repos/istio/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.io/events","assignees_url":"https://api.github.com/repos/istio/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.io/merges","archive_url":"https://api.github.com/repos/istio/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-09-28T23:11:55Z","pushed_at":"2018-09-28T23:11:50Z","git_url":"git://github.com/istio/istio.io.git","ssh_url":"git@github.com:istio/istio.io.git","clone_url":"https://github.com/istio/istio.io.git","svn_url":"https://github.com/istio/istio.io","homepage":"https://istio.io/","size":35801,"stargazers_count":127,"watchers_count":127,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":358,"open_issues":99,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2705"},"html":{"href":"https://github.com/istio/istio.io/pull/2705"},"issue":{"href":"https://api.github.com/repos/istio/istio.io/issues/2705"},"comments":{"href":"https://api.github.com/repos/istio/istio.io/issues/2705/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2705/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.io/pulls/2705/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.io/statuses/ce9f73fdda294e3c1306ea658120e0c83dd47a53"}},"author_association":"MEMBER"}} | {
"id": 82706976,
"name": "istio/istio.io",
"url": "https://api.github.com/repos/istio/istio.io"
} | {
"id": 4461983,
"login": "gyliu513",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4461983?",
"url": "https://api.github.com/users/gyliu513"
} | {
"id": 23534644,
"login": "istio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534644?",
"url": "https://api.github.com/orgs/istio"
} | 2018-09-29T02:42:38 | 8341291493 | {"actor":{"display_login":"gyliu513"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/clearcontainers/tests/pulls/comments/176752918","pull_request_review_id":106515255,"id":176752918,"diff_hunk":"@@ -29,15 +29,16 @@ TEST_ARGS=\"$@\"\n # These values are a basic configuration for a FIO job\n # execution, however they could be overridden in order to\n # run a customized FIO job.\n-BLOCK_SIZE=\"4k\"\n+BLOCK_SIZE=\"16k\"","path":"metrics/storage/fio_job.sh","position":5,"original_position":5,"commit_id":"272c4970677c30786aa55851d54f02342d44286c","original_commit_id":"a4bb66cc56a8451610a4e2262324900af1507d33","user":{"login":"grahamwhaley","id":4761717,"avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"body":"The '4k' in the `fio_job.sh` file is just a default - the expectation is that when it is invoked via a higher level script (like `run_metrics_ci`), then that script will explicitly set the block size and other parameters it wants. `fio_job.sh` should be generic, and then the invocation scripts set it up specifically.\r\nSo, we can set sensible defaults in `fio_job.sh`, in case anybody does run it directly or does not set up all the parameters, but what really matters is how we set up `run_metrics_ci.sh` to invoke it under the CI system.\r\n\r\nThe name - ah, I see the `run_metrics_ci.sh` [sets the name explicitly](https://github.com/clearcontainers/tests/blob/master/.ci/run_metrics_ci.sh#L134) using the `-t` option - that may be where the name confusion is coming from.","created_at":"2018-03-23T14:31:31Z","updated_at":"2018-03-23T14:31:31Z","html_url":"https://github.com/clearcontainers/tests/pull/957#discussion_r176752918","pull_request_url":"https://api.github.com/repos/clearcontainers/tests/pulls/957","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/comments/176752918"},"html":{"href":"https://github.com/clearcontainers/tests/pull/957#discussion_r176752918"},"pull_request":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/957"}},"in_reply_to_id":176025854},"pull_request":{"url":"https://api.github.com/repos/clearcontainers/tests/pulls/957","id":176266467,"html_url":"https://github.com/clearcontainers/tests/pull/957","diff_url":"https://github.com/clearcontainers/tests/pull/957.diff","patch_url":"https://github.com/clearcontainers/tests/pull/957.patch","issue_url":"https://api.github.com/repos/clearcontainers/tests/issues/957","number":957,"state":"open","locked":false,"title":"metrics: Add FIO flags to produce stable results.","user":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars1.githubusercontent.com/u/20359065?v=4","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"body":"Add FIO flags like time_based, drop host pages,\r\ninvalidate, direct, etc to produce more stable results.\r\n\r\nFixes #956\r\n\r\nSigned-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>","created_at":"2018-03-20T17:28:32Z","updated_at":"2018-03-23T14:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bf1ae0191f392b8d984e789f54d173e8e0daf80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":603247782,"url":"https://api.github.com/repos/clearcontainers/tests/labels/WIP","name":"WIP","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/clearcontainers/tests/pulls/957/commits","review_comments_url":"https://api.github.com/repos/clearcontainers/tests/pulls/957/comments","review_comment_url":"https://api.github.com/repos/clearcontainers/tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearcontainers/tests/issues/957/comments","statuses_url":"https://api.github.com/repos/clearcontainers/tests/statuses/272c4970677c30786aa55851d54f02342d44286c","head":{"label":"GabyCT:topic/improvefio","ref":"topic/improvefio","sha":"272c4970677c30786aa55851d54f02342d44286c","user":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars1.githubusercontent.com/u/20359065?v=4","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"repo":{"id":92962967,"name":"tests","full_name":"GabyCT/tests","owner":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars1.githubusercontent.com/u/20359065?v=4","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GabyCT/tests","description":"Clear Container Tests Repository","fork":true,"url":"https://api.github.com/repos/GabyCT/tests","forks_url":"https://api.github.com/repos/GabyCT/tests/forks","keys_url":"https://api.github.com/repos/GabyCT/tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GabyCT/tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GabyCT/tests/teams","hooks_url":"https://api.github.com/repos/GabyCT/tests/hooks","issue_events_url":"https://api.github.com/repos/GabyCT/tests/issues/events{/number}","events_url":"https://api.github.com/repos/GabyCT/tests/events","assignees_url":"https://api.github.com/repos/GabyCT/tests/assignees{/user}","branches_url":"https://api.github.com/repos/GabyCT/tests/branches{/branch}","tags_url":"https://api.github.com/repos/GabyCT/tests/tags","blobs_url":"https://api.github.com/repos/GabyCT/tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GabyCT/tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GabyCT/tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/GabyCT/tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GabyCT/tests/statuses/{sha}","languages_url":"https://api.github.com/repos/GabyCT/tests/languages","stargazers_url":"https://api.github.com/repos/GabyCT/tests/stargazers","contributors_url":"https://api.github.com/repos/GabyCT/tests/contributors","subscribers_url":"https://api.github.com/repos/GabyCT/tests/subscribers","subscription_url":"https://api.github.com/repos/GabyCT/tests/subscription","commits_url":"https://api.github.com/repos/GabyCT/tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/GabyCT/tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/GabyCT/tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/GabyCT/tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/GabyCT/tests/contents/{+path}","compare_url":"https://api.github.com/repos/GabyCT/tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GabyCT/tests/merges","archive_url":"https://api.github.com/repos/GabyCT/tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GabyCT/tests/downloads","issues_url":"https://api.github.com/repos/GabyCT/tests/issues{/number}","pulls_url":"https://api.github.com/repos/GabyCT/tests/pulls{/number}","milestones_url":"https://api.github.com/repos/GabyCT/tests/milestones{/number}","notifications_url":"https://api.github.com/repos/GabyCT/tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GabyCT/tests/labels{/name}","releases_url":"https://api.github.com/repos/GabyCT/tests/releases{/id}","deployments_url":"https://api.github.com/repos/GabyCT/tests/deployments","created_at":"2017-05-31T15:51:10Z","updated_at":"2017-05-31T15:51:12Z","pushed_at":"2018-03-22T20:30:18Z","git_url":"git://github.com/GabyCT/tests.git","ssh_url":"git@github.com:GabyCT/tests.git","clone_url":"https://github.com/GabyCT/tests.git","svn_url":"https://github.com/GabyCT/tests","homepage":null,"size":5079,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearcontainers:master","ref":"master","sha":"0ff37fa9ea2a7aecb13df52cc9566c685770830f","user":{"login":"clearcontainers","id":24325390,"avatar_url":"https://avatars1.githubusercontent.com/u/24325390?v=4","gravatar_id":"","url":"https://api.github.com/users/clearcontainers","html_url":"https://github.com/clearcontainers","followers_url":"https://api.github.com/users/clearcontainers/followers","following_url":"https://api.github.com/users/clearcontainers/following{/other_user}","gists_url":"https://api.github.com/users/clearcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/clearcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearcontainers/subscriptions","organizations_url":"https://api.github.com/users/clearcontainers/orgs","repos_url":"https://api.github.com/users/clearcontainers/repos","events_url":"https://api.github.com/users/clearcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/clearcontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":89639557,"name":"tests","full_name":"clearcontainers/tests","owner":{"login":"clearcontainers","id":24325390,"avatar_url":"https://avatars1.githubusercontent.com/u/24325390?v=4","gravatar_id":"","url":"https://api.github.com/users/clearcontainers","html_url":"https://github.com/clearcontainers","followers_url":"https://api.github.com/users/clearcontainers/followers","following_url":"https://api.github.com/users/clearcontainers/following{/other_user}","gists_url":"https://api.github.com/users/clearcontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/clearcontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearcontainers/subscriptions","organizations_url":"https://api.github.com/users/clearcontainers/orgs","repos_url":"https://api.github.com/users/clearcontainers/repos","events_url":"https://api.github.com/users/clearcontainers/events{/privacy}","received_events_url":"https://api.github.com/users/clearcontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearcontainers/tests","description":"Clear Container Tests Repository","fork":false,"url":"https://api.github.com/repos/clearcontainers/tests","forks_url":"https://api.github.com/repos/clearcontainers/tests/forks","keys_url":"https://api.github.com/repos/clearcontainers/tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearcontainers/tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearcontainers/tests/teams","hooks_url":"https://api.github.com/repos/clearcontainers/tests/hooks","issue_events_url":"https://api.github.com/repos/clearcontainers/tests/issues/events{/number}","events_url":"https://api.github.com/repos/clearcontainers/tests/events","assignees_url":"https://api.github.com/repos/clearcontainers/tests/assignees{/user}","branches_url":"https://api.github.com/repos/clearcontainers/tests/branches{/branch}","tags_url":"https://api.github.com/repos/clearcontainers/tests/tags","blobs_url":"https://api.github.com/repos/clearcontainers/tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearcontainers/tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearcontainers/tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearcontainers/tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearcontainers/tests/statuses/{sha}","languages_url":"https://api.github.com/repos/clearcontainers/tests/languages","stargazers_url":"https://api.github.com/repos/clearcontainers/tests/stargazers","contributors_url":"https://api.github.com/repos/clearcontainers/tests/contributors","subscribers_url":"https://api.github.com/repos/clearcontainers/tests/subscribers","subscription_url":"https://api.github.com/repos/clearcontainers/tests/subscription","commits_url":"https://api.github.com/repos/clearcontainers/tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearcontainers/tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearcontainers/tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearcontainers/tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearcontainers/tests/contents/{+path}","compare_url":"https://api.github.com/repos/clearcontainers/tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearcontainers/tests/merges","archive_url":"https://api.github.com/repos/clearcontainers/tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearcontainers/tests/downloads","issues_url":"https://api.github.com/repos/clearcontainers/tests/issues{/number}","pulls_url":"https://api.github.com/repos/clearcontainers/tests/pulls{/number}","milestones_url":"https://api.github.com/repos/clearcontainers/tests/milestones{/number}","notifications_url":"https://api.github.com/repos/clearcontainers/tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearcontainers/tests/labels{/name}","releases_url":"https://api.github.com/repos/clearcontainers/tests/releases{/id}","deployments_url":"https://api.github.com/repos/clearcontainers/tests/deployments","created_at":"2017-04-27T20:54:34Z","updated_at":"2018-03-22T16:25:11Z","pushed_at":"2018-03-22T20:30:19Z","git_url":"git://github.com/clearcontainers/tests.git","ssh_url":"git@github.com:clearcontainers/tests.git","clone_url":"https://github.com/clearcontainers/tests.git","svn_url":"https://github.com/clearcontainers/tests","homepage":null,"size":5086,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":20,"open_issues":76,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/957"},"html":{"href":"https://github.com/clearcontainers/tests/pull/957"},"issue":{"href":"https://api.github.com/repos/clearcontainers/tests/issues/957"},"comments":{"href":"https://api.github.com/repos/clearcontainers/tests/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearcontainers/tests/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/clearcontainers/tests/statuses/272c4970677c30786aa55851d54f02342d44286c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 89639557,
"name": "clearcontainers/tests",
"url": "https://api.github.com/repos/clearcontainers/tests"
} | {
"id": 4761717,
"login": "grahamwhaley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4761717?",
"url": "https://api.github.com/users/grahamwhaley"
} | {
"id": 24325390,
"login": "clearcontainers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24325390?",
"url": "https://api.github.com/orgs/clearcontainers"
} | 2018-03-23T14:31:31 | 7425724549 | {"actor":{"display_login":"grahamwhaley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/comments/175807628","pull_request_review_id":105398131,"id":175807628,"diff_hunk":"@@ -0,0 +1,50 @@\n+<?php\n+\n+namespace AppBundle\\Security;\n+\n+use AppBundle\\Entity\\Adherent;\n+use AppBundle\\Exception\\AccountNotValidatedException;\n+use Symfony\\Bundle\\FrameworkBundle\\Routing\\Router;\n+use Symfony\\Component\\Security\\Core\\Exception\\DisabledException;\n+use Symfony\\Component\\Security\\Core\\User\\UserCheckerInterface;\n+use Symfony\\Component\\Security\\Core\\User\\UserInterface;\n+\n+class UserChecker implements UserCheckerInterface\n+{\n+ private $router;\n+\n+ public function __construct(Router $router)\n+ {\n+ $this->router = $router;\n+ }\n+\n+ /**\n+ * {@inheritdoc}\n+ */\n+ public function checkPreAuth(UserInterface $user)\n+ {\n+ }\n+\n+ /**\n+ * {@inheritdoc}\n+ */\n+ public function checkPostAuth(UserInterface $user)\n+ {\n+ /** @var Adherent $user */\n+ if (!$user instanceof Adherent) {\n+ throw new \\UnexpectedValueException('You have to pass an Adherent instance.');\n+ }\n+\n+ if ($user->isEnabled()) {\n+ return;","path":"src/Security/UserChecker.php","position":39,"original_position":39,"commit_id":"adeadc76e1926315ebf34c3d48d4dd8833277062","original_commit_id":"adeadc76e1926315ebf34c3d48d4dd8833277062","user":{"login":"B-Galati","id":895123,"avatar_url":"https://avatars3.githubusercontent.com/u/895123?v=4","gravatar_id":"","url":"https://api.github.com/users/B-Galati","html_url":"https://github.com/B-Galati","followers_url":"https://api.github.com/users/B-Galati/followers","following_url":"https://api.github.com/users/B-Galati/following{/other_user}","gists_url":"https://api.github.com/users/B-Galati/gists{/gist_id}","starred_url":"https://api.github.com/users/B-Galati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/B-Galati/subscriptions","organizations_url":"https://api.github.com/users/B-Galati/orgs","repos_url":"https://api.github.com/users/B-Galati/repos","events_url":"https://api.github.com/users/B-Galati/events{/privacy}","received_events_url":"https://api.github.com/users/B-Galati/received_events","type":"User","site_admin":false},"body":"To make things clearer, I would prefer to invert the test and throw the exception here.","created_at":"2018-03-20T15:21:05Z","updated_at":"2018-03-20T15:21:25Z","html_url":"https://github.com/EnMarche/en-marche.fr/pull/2283#discussion_r175807628","pull_request_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/comments/175807628"},"html":{"href":"https://github.com/EnMarche/en-marche.fr/pull/2283#discussion_r175807628"},"pull_request":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283"}}},"pull_request":{"url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283","id":175286407,"html_url":"https://github.com/EnMarche/en-marche.fr/pull/2283","diff_url":"https://github.com/EnMarche/en-marche.fr/pull/2283.diff","patch_url":"https://github.com/EnMarche/en-marche.fr/pull/2283.patch","issue_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/2283","number":2283,"state":"open","locked":false,"title":"[ch3176] Resend email validation and notify the user to check his mailbox","user":{"login":"cacahouwete","id":1099956,"avatar_url":"https://avatars3.githubusercontent.com/u/1099956?v=4","gravatar_id":"","url":"https://api.github.com/users/cacahouwete","html_url":"https://github.com/cacahouwete","followers_url":"https://api.github.com/users/cacahouwete/followers","following_url":"https://api.github.com/users/cacahouwete/following{/other_user}","gists_url":"https://api.github.com/users/cacahouwete/gists{/gist_id}","starred_url":"https://api.github.com/users/cacahouwete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacahouwete/subscriptions","organizations_url":"https://api.github.com/users/cacahouwete/orgs","repos_url":"https://api.github.com/users/cacahouwete/repos","events_url":"https://api.github.com/users/cacahouwete/events{/privacy}","received_events_url":"https://api.github.com/users/cacahouwete/received_events","type":"User","site_admin":false},"body":"https://app.clubhouse.io/enmarche/story/3176/mettre-un-message-d-erreur-avec-proposition-de-renvoi-d-e-mail-lorsqu-un-nouvel-adh%C3%A9rent-n-a-pas-valid%C3%A9-son-adresse-mail","created_at":"2018-03-15T15:24:02Z","updated_at":"2018-03-20T15:21:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ede68529e406983936cf7bc5496c7782ac4943cd","assignee":{"login":"cacahouwete","id":1099956,"avatar_url":"https://avatars3.githubusercontent.com/u/1099956?v=4","gravatar_id":"","url":"https://api.github.com/users/cacahouwete","html_url":"https://github.com/cacahouwete","followers_url":"https://api.github.com/users/cacahouwete/followers","following_url":"https://api.github.com/users/cacahouwete/following{/other_user}","gists_url":"https://api.github.com/users/cacahouwete/gists{/gist_id}","starred_url":"https://api.github.com/users/cacahouwete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacahouwete/subscriptions","organizations_url":"https://api.github.com/users/cacahouwete/orgs","repos_url":"https://api.github.com/users/cacahouwete/repos","events_url":"https://api.github.com/users/cacahouwete/events{/privacy}","received_events_url":"https://api.github.com/users/cacahouwete/received_events","type":"User","site_admin":false},"assignees":[{"login":"cacahouwete","id":1099956,"avatar_url":"https://avatars3.githubusercontent.com/u/1099956?v=4","gravatar_id":"","url":"https://api.github.com/users/cacahouwete","html_url":"https://github.com/cacahouwete","followers_url":"https://api.github.com/users/cacahouwete/followers","following_url":"https://api.github.com/users/cacahouwete/following{/other_user}","gists_url":"https://api.github.com/users/cacahouwete/gists{/gist_id}","starred_url":"https://api.github.com/users/cacahouwete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacahouwete/subscriptions","organizations_url":"https://api.github.com/users/cacahouwete/orgs","repos_url":"https://api.github.com/users/cacahouwete/repos","events_url":"https://api.github.com/users/cacahouwete/events{/privacy}","received_events_url":"https://api.github.com/users/cacahouwete/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"illusionOfParadise","id":15227655,"avatar_url":"https://avatars2.githubusercontent.com/u/15227655?v=4","gravatar_id":"","url":"https://api.github.com/users/illusionOfParadise","html_url":"https://github.com/illusionOfParadise","followers_url":"https://api.github.com/users/illusionOfParadise/followers","following_url":"https://api.github.com/users/illusionOfParadise/following{/other_user}","gists_url":"https://api.github.com/users/illusionOfParadise/gists{/gist_id}","starred_url":"https://api.github.com/users/illusionOfParadise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illusionOfParadise/subscriptions","organizations_url":"https://api.github.com/users/illusionOfParadise/orgs","repos_url":"https://api.github.com/users/illusionOfParadise/repos","events_url":"https://api.github.com/users/illusionOfParadise/events{/privacy}","received_events_url":"https://api.github.com/users/illusionOfParadise/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":503589417,"url":"https://api.github.com/repos/EnMarche/en-marche.fr/labels/Ready%20for%20code%20review","name":"Ready for code review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283/commits","review_comments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283/comments","review_comment_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/2283/comments","statuses_url":"https://api.github.com/repos/EnMarche/en-marche.fr/statuses/adeadc76e1926315ebf34c3d48d4dd8833277062","head":{"label":"EnMarche:feature/ch3176/mettre-un-message-d-erreur-avec-proposition","ref":"feature/ch3176/mettre-un-message-d-erreur-avec-proposition","sha":"adeadc76e1926315ebf34c3d48d4dd8833277062","user":{"login":"EnMarche","id":24521375,"avatar_url":"https://avatars0.githubusercontent.com/u/24521375?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMarche","html_url":"https://github.com/EnMarche","followers_url":"https://api.github.com/users/EnMarche/followers","following_url":"https://api.github.com/users/EnMarche/following{/other_user}","gists_url":"https://api.github.com/users/EnMarche/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMarche/subscriptions","organizations_url":"https://api.github.com/users/EnMarche/orgs","repos_url":"https://api.github.com/users/EnMarche/repos","events_url":"https://api.github.com/users/EnMarche/events{/privacy}","received_events_url":"https://api.github.com/users/EnMarche/received_events","type":"Organization","site_admin":false},"repo":{"id":76485630,"name":"en-marche.fr","full_name":"EnMarche/en-marche.fr","owner":{"login":"EnMarche","id":24521375,"avatar_url":"https://avatars0.githubusercontent.com/u/24521375?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMarche","html_url":"https://github.com/EnMarche","followers_url":"https://api.github.com/users/EnMarche/followers","following_url":"https://api.github.com/users/EnMarche/following{/other_user}","gists_url":"https://api.github.com/users/EnMarche/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMarche/subscriptions","organizations_url":"https://api.github.com/users/EnMarche/orgs","repos_url":"https://api.github.com/users/EnMarche/repos","events_url":"https://api.github.com/users/EnMarche/events{/privacy}","received_events_url":"https://api.github.com/users/EnMarche/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnMarche/en-marche.fr","description":"Le site principal du mouvement En Marche ! ","fork":false,"url":"https://api.github.com/repos/EnMarche/en-marche.fr","forks_url":"https://api.github.com/repos/EnMarche/en-marche.fr/forks","keys_url":"https://api.github.com/repos/EnMarche/en-marche.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnMarche/en-marche.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnMarche/en-marche.fr/teams","hooks_url":"https://api.github.com/repos/EnMarche/en-marche.fr/hooks","issue_events_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/events{/number}","events_url":"https://api.github.com/repos/EnMarche/en-marche.fr/events","assignees_url":"https://api.github.com/repos/EnMarche/en-marche.fr/assignees{/user}","branches_url":"https://api.github.com/repos/EnMarche/en-marche.fr/branches{/branch}","tags_url":"https://api.github.com/repos/EnMarche/en-marche.fr/tags","blobs_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnMarche/en-marche.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/EnMarche/en-marche.fr/languages","stargazers_url":"https://api.github.com/repos/EnMarche/en-marche.fr/stargazers","contributors_url":"https://api.github.com/repos/EnMarche/en-marche.fr/contributors","subscribers_url":"https://api.github.com/repos/EnMarche/en-marche.fr/subscribers","subscription_url":"https://api.github.com/repos/EnMarche/en-marche.fr/subscription","commits_url":"https://api.github.com/repos/EnMarche/en-marche.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnMarche/en-marche.fr/contents/{+path}","compare_url":"https://api.github.com/repos/EnMarche/en-marche.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnMarche/en-marche.fr/merges","archive_url":"https://api.github.com/repos/EnMarche/en-marche.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnMarche/en-marche.fr/downloads","issues_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues{/number}","pulls_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/EnMarche/en-marche.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/EnMarche/en-marche.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnMarche/en-marche.fr/labels{/name}","releases_url":"https://api.github.com/repos/EnMarche/en-marche.fr/releases{/id}","deployments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/deployments","created_at":"2016-12-14T18:22:36Z","updated_at":"2018-03-19T14:47:12Z","pushed_at":"2018-03-20T15:20:30Z","git_url":"git://github.com/EnMarche/en-marche.fr.git","ssh_url":"git@github.com:EnMarche/en-marche.fr.git","clone_url":"https://github.com/EnMarche/en-marche.fr.git","svn_url":"https://github.com/EnMarche/en-marche.fr","homepage":"https://en-marche.fr","size":131967,"stargazers_count":652,"watchers_count":652,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":147,"open_issues":25,"watchers":652,"default_branch":"develop"}},"base":{"label":"EnMarche:develop","ref":"develop","sha":"47f5c2942f8590508027b1d78c1cb3ae6a072987","user":{"login":"EnMarche","id":24521375,"avatar_url":"https://avatars0.githubusercontent.com/u/24521375?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMarche","html_url":"https://github.com/EnMarche","followers_url":"https://api.github.com/users/EnMarche/followers","following_url":"https://api.github.com/users/EnMarche/following{/other_user}","gists_url":"https://api.github.com/users/EnMarche/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMarche/subscriptions","organizations_url":"https://api.github.com/users/EnMarche/orgs","repos_url":"https://api.github.com/users/EnMarche/repos","events_url":"https://api.github.com/users/EnMarche/events{/privacy}","received_events_url":"https://api.github.com/users/EnMarche/received_events","type":"Organization","site_admin":false},"repo":{"id":76485630,"name":"en-marche.fr","full_name":"EnMarche/en-marche.fr","owner":{"login":"EnMarche","id":24521375,"avatar_url":"https://avatars0.githubusercontent.com/u/24521375?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMarche","html_url":"https://github.com/EnMarche","followers_url":"https://api.github.com/users/EnMarche/followers","following_url":"https://api.github.com/users/EnMarche/following{/other_user}","gists_url":"https://api.github.com/users/EnMarche/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMarche/subscriptions","organizations_url":"https://api.github.com/users/EnMarche/orgs","repos_url":"https://api.github.com/users/EnMarche/repos","events_url":"https://api.github.com/users/EnMarche/events{/privacy}","received_events_url":"https://api.github.com/users/EnMarche/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnMarche/en-marche.fr","description":"Le site principal du mouvement En Marche ! ","fork":false,"url":"https://api.github.com/repos/EnMarche/en-marche.fr","forks_url":"https://api.github.com/repos/EnMarche/en-marche.fr/forks","keys_url":"https://api.github.com/repos/EnMarche/en-marche.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnMarche/en-marche.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnMarche/en-marche.fr/teams","hooks_url":"https://api.github.com/repos/EnMarche/en-marche.fr/hooks","issue_events_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/events{/number}","events_url":"https://api.github.com/repos/EnMarche/en-marche.fr/events","assignees_url":"https://api.github.com/repos/EnMarche/en-marche.fr/assignees{/user}","branches_url":"https://api.github.com/repos/EnMarche/en-marche.fr/branches{/branch}","tags_url":"https://api.github.com/repos/EnMarche/en-marche.fr/tags","blobs_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnMarche/en-marche.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/EnMarche/en-marche.fr/languages","stargazers_url":"https://api.github.com/repos/EnMarche/en-marche.fr/stargazers","contributors_url":"https://api.github.com/repos/EnMarche/en-marche.fr/contributors","subscribers_url":"https://api.github.com/repos/EnMarche/en-marche.fr/subscribers","subscription_url":"https://api.github.com/repos/EnMarche/en-marche.fr/subscription","commits_url":"https://api.github.com/repos/EnMarche/en-marche.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnMarche/en-marche.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnMarche/en-marche.fr/contents/{+path}","compare_url":"https://api.github.com/repos/EnMarche/en-marche.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnMarche/en-marche.fr/merges","archive_url":"https://api.github.com/repos/EnMarche/en-marche.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnMarche/en-marche.fr/downloads","issues_url":"https://api.github.com/repos/EnMarche/en-marche.fr/issues{/number}","pulls_url":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/EnMarche/en-marche.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/EnMarche/en-marche.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnMarche/en-marche.fr/labels{/name}","releases_url":"https://api.github.com/repos/EnMarche/en-marche.fr/releases{/id}","deployments_url":"https://api.github.com/repos/EnMarche/en-marche.fr/deployments","created_at":"2016-12-14T18:22:36Z","updated_at":"2018-03-19T14:47:12Z","pushed_at":"2018-03-20T15:20:30Z","git_url":"git://github.com/EnMarche/en-marche.fr.git","ssh_url":"git@github.com:EnMarche/en-marche.fr.git","clone_url":"https://github.com/EnMarche/en-marche.fr.git","svn_url":"https://github.com/EnMarche/en-marche.fr","homepage":"https://en-marche.fr","size":131967,"stargazers_count":652,"watchers_count":652,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":147,"open_issues":25,"watchers":652,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283"},"html":{"href":"https://github.com/EnMarche/en-marche.fr/pull/2283"},"issue":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/2283"},"comments":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/issues/2283/comments"},"review_comments":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283/comments"},"review_comment":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/pulls/2283/commits"},"statuses":{"href":"https://api.github.com/repos/EnMarche/en-marche.fr/statuses/adeadc76e1926315ebf34c3d48d4dd8833277062"}},"author_association":"CONTRIBUTOR"}} | {
"id": 76485630,
"name": "EnMarche/en-marche.fr",
"url": "https://api.github.com/repos/EnMarche/en-marche.fr"
} | {
"id": 895123,
"login": "B-Galati",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/895123?",
"url": "https://api.github.com/users/B-Galati"
} | {
"id": 24521375,
"login": "EnMarche",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24521375?",
"url": "https://api.github.com/orgs/EnMarche"
} | 2018-03-20T15:21:05 | 7407378065 | {"actor":{"display_login":"B-Galati"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/comments/201040568","pull_request_review_id":135464005,"id":201040568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA0MDU2OA==","diff_hunk":"@@ -9,6 +9,7 @@ const Input = ({ classes, input, type, placeholder }) => {\n \t\t\t<input\n \t\t\t\tclassName={classes.textInput}\n \t\t\t\ttype={type}\n+\t\t\t\tstyle={{ fontSize: input.name === 'prcName' ? '30px' : '18px' }}","path":"client/js/components/input.js","position":4,"original_position":4,"commit_id":"6fca01ee2acca72ea2dd2a0191ee85dcf30db3a5","original_commit_id":"6fca01ee2acca72ea2dd2a0191ee85dcf30db3a5","user":{"login":"karenmrose","id":6378435,"node_id":"MDQ6VXNlcjYzNzg0MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6378435?v=4","gravatar_id":"","url":"https://api.github.com/users/karenmrose","html_url":"https://github.com/karenmrose","followers_url":"https://api.github.com/users/karenmrose/followers","following_url":"https://api.github.com/users/karenmrose/following{/other_user}","gists_url":"https://api.github.com/users/karenmrose/gists{/gist_id}","starred_url":"https://api.github.com/users/karenmrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenmrose/subscriptions","organizations_url":"https://api.github.com/users/karenmrose/orgs","repos_url":"https://api.github.com/users/karenmrose/repos","events_url":"https://api.github.com/users/karenmrose/events{/privacy}","received_events_url":"https://api.github.com/users/karenmrose/received_events","type":"User","site_admin":false},"body":"This can actually be done in JSS. If you create a new property on the styles object with a text size of `30px` then you can apply the styles accordingly. ","created_at":"2018-07-09T15:15:49Z","updated_at":"2018-07-09T15:15:49Z","html_url":"https://github.com/HelpAssistHer/help-assist-her/pull/91#discussion_r201040568","pull_request_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/comments/201040568"},"html":{"href":"https://github.com/HelpAssistHer/help-assist-her/pull/91#discussion_r201040568"},"pull_request":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91","id":197272984,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjcyOTg0","html_url":"https://github.com/HelpAssistHer/help-assist-her/pull/91","diff_url":"https://github.com/HelpAssistHer/help-assist-her/pull/91.diff","patch_url":"https://github.com/HelpAssistHer/help-assist-her/pull/91.patch","issue_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/91","number":91,"state":"open","locked":false,"title":"Left align headings and center the Verified heading, add Spacers.","user":{"login":"vzajkov","id":29736643,"node_id":"MDQ6VXNlcjI5NzM2NjQz","avatar_url":"https://avatars1.githubusercontent.com/u/29736643?v=4","gravatar_id":"","url":"https://api.github.com/users/vzajkov","html_url":"https://github.com/vzajkov","followers_url":"https://api.github.com/users/vzajkov/followers","following_url":"https://api.github.com/users/vzajkov/following{/other_user}","gists_url":"https://api.github.com/users/vzajkov/gists{/gist_id}","starred_url":"https://api.github.com/users/vzajkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vzajkov/subscriptions","organizations_url":"https://api.github.com/users/vzajkov/orgs","repos_url":"https://api.github.com/users/vzajkov/repos","events_url":"https://api.github.com/users/vzajkov/events{/privacy}","received_events_url":"https://api.github.com/users/vzajkov/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdded size prop to Heading component (small & medium styling). Changed \"Verified\" heading into Heading component and centered it above checkboxes. Added \"medium\" size prop to Services heading. Added headingGrid CSS styling for easy left-aligning of headings. Added Spacers at proper locations. Combined Services and General Info under one wrapping div (the big classes.formSection div) for future alignment needs.\r\n## Test Plan\r\nVerify Next Resource button works, everything is displayed neatly.\r\n","created_at":"2018-06-26T00:47:18Z","updated_at":"2018-07-09T15:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddfc3723ac2441185a34dbf26fc3c459a51bb418","assignee":null,"assignees":[],"requested_reviewers":[{"login":"katelynsills","id":2441069,"node_id":"MDQ6VXNlcjI0NDEwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2441069?v=4","gravatar_id":"","url":"https://api.github.com/users/katelynsills","html_url":"https://github.com/katelynsills","followers_url":"https://api.github.com/users/katelynsills/followers","following_url":"https://api.github.com/users/katelynsills/following{/other_user}","gists_url":"https://api.github.com/users/katelynsills/gists{/gist_id}","starred_url":"https://api.github.com/users/katelynsills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katelynsills/subscriptions","organizations_url":"https://api.github.com/users/katelynsills/orgs","repos_url":"https://api.github.com/users/katelynsills/repos","events_url":"https://api.github.com/users/katelynsills/events{/privacy}","received_events_url":"https://api.github.com/users/katelynsills/received_events","type":"User","site_admin":false},{"login":"bhavyaab","id":20171729,"node_id":"MDQ6VXNlcjIwMTcxNzI5","avatar_url":"https://avatars2.githubusercontent.com/u/20171729?v=4","gravatar_id":"","url":"https://api.github.com/users/bhavyaab","html_url":"https://github.com/bhavyaab","followers_url":"https://api.github.com/users/bhavyaab/followers","following_url":"https://api.github.com/users/bhavyaab/following{/other_user}","gists_url":"https://api.github.com/users/bhavyaab/gists{/gist_id}","starred_url":"https://api.github.com/users/bhavyaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhavyaab/subscriptions","organizations_url":"https://api.github.com/users/bhavyaab/orgs","repos_url":"https://api.github.com/users/bhavyaab/repos","events_url":"https://api.github.com/users/bhavyaab/events{/privacy}","received_events_url":"https://api.github.com/users/bhavyaab/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91/commits","review_comments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91/comments","review_comment_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/91/comments","statuses_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/statuses/6fca01ee2acca72ea2dd2a0191ee85dcf30db3a5","head":{"label":"HelpAssistHer:polish-general-info","ref":"polish-general-info","sha":"6fca01ee2acca72ea2dd2a0191ee85dcf30db3a5","user":{"login":"HelpAssistHer","id":24535520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTM1NTIw","avatar_url":"https://avatars0.githubusercontent.com/u/24535520?v=4","gravatar_id":"","url":"https://api.github.com/users/HelpAssistHer","html_url":"https://github.com/HelpAssistHer","followers_url":"https://api.github.com/users/HelpAssistHer/followers","following_url":"https://api.github.com/users/HelpAssistHer/following{/other_user}","gists_url":"https://api.github.com/users/HelpAssistHer/gists{/gist_id}","starred_url":"https://api.github.com/users/HelpAssistHer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelpAssistHer/subscriptions","organizations_url":"https://api.github.com/users/HelpAssistHer/orgs","repos_url":"https://api.github.com/users/HelpAssistHer/repos","events_url":"https://api.github.com/users/HelpAssistHer/events{/privacy}","received_events_url":"https://api.github.com/users/HelpAssistHer/received_events","type":"Organization","site_admin":false},"repo":{"id":76312200,"node_id":"MDEwOlJlcG9zaXRvcnk3NjMxMjIwMA==","name":"help-assist-her","full_name":"HelpAssistHer/help-assist-her","owner":{"login":"HelpAssistHer","id":24535520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTM1NTIw","avatar_url":"https://avatars0.githubusercontent.com/u/24535520?v=4","gravatar_id":"","url":"https://api.github.com/users/HelpAssistHer","html_url":"https://github.com/HelpAssistHer","followers_url":"https://api.github.com/users/HelpAssistHer/followers","following_url":"https://api.github.com/users/HelpAssistHer/following{/other_user}","gists_url":"https://api.github.com/users/HelpAssistHer/gists{/gist_id}","starred_url":"https://api.github.com/users/HelpAssistHer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelpAssistHer/subscriptions","organizations_url":"https://api.github.com/users/HelpAssistHer/orgs","repos_url":"https://api.github.com/users/HelpAssistHer/repos","events_url":"https://api.github.com/users/HelpAssistHer/events{/privacy}","received_events_url":"https://api.github.com/users/HelpAssistHer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HelpAssistHer/help-assist-her","description":"Women's healthcare resources in the palm of your hand","fork":false,"url":"https://api.github.com/repos/HelpAssistHer/help-assist-her","forks_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/forks","keys_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/teams","hooks_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/hooks","issue_events_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/events{/number}","events_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/events","assignees_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/assignees{/user}","branches_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/branches{/branch}","tags_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/tags","blobs_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/refs{/sha}","trees_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/statuses/{sha}","languages_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/languages","stargazers_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/stargazers","contributors_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/contributors","subscribers_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/subscribers","subscription_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/subscription","commits_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/commits{/sha}","git_commits_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/commits{/sha}","comments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/comments{/number}","issue_comment_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/comments{/number}","contents_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/contents/{+path}","compare_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/merges","archive_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/downloads","issues_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues{/number}","pulls_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls{/number}","milestones_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/milestones{/number}","notifications_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/labels{/name}","releases_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/releases{/id}","deployments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/deployments","created_at":"2016-12-13T01:47:01Z","updated_at":"2018-07-09T14:58:04Z","pushed_at":"2018-07-09T14:58:04Z","git_url":"git://github.com/HelpAssistHer/help-assist-her.git","ssh_url":"git@github.com:HelpAssistHer/help-assist-her.git","clone_url":"https://github.com/HelpAssistHer/help-assist-her.git","svn_url":"https://github.com/HelpAssistHer/help-assist-her","homepage":"http://www.helpassisther.com","size":4180,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":8,"default_branch":"master"}},"base":{"label":"HelpAssistHer:master","ref":"master","sha":"f907d6c900e40a21738a4750b8d25b8e5778dac1","user":{"login":"HelpAssistHer","id":24535520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTM1NTIw","avatar_url":"https://avatars0.githubusercontent.com/u/24535520?v=4","gravatar_id":"","url":"https://api.github.com/users/HelpAssistHer","html_url":"https://github.com/HelpAssistHer","followers_url":"https://api.github.com/users/HelpAssistHer/followers","following_url":"https://api.github.com/users/HelpAssistHer/following{/other_user}","gists_url":"https://api.github.com/users/HelpAssistHer/gists{/gist_id}","starred_url":"https://api.github.com/users/HelpAssistHer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelpAssistHer/subscriptions","organizations_url":"https://api.github.com/users/HelpAssistHer/orgs","repos_url":"https://api.github.com/users/HelpAssistHer/repos","events_url":"https://api.github.com/users/HelpAssistHer/events{/privacy}","received_events_url":"https://api.github.com/users/HelpAssistHer/received_events","type":"Organization","site_admin":false},"repo":{"id":76312200,"node_id":"MDEwOlJlcG9zaXRvcnk3NjMxMjIwMA==","name":"help-assist-her","full_name":"HelpAssistHer/help-assist-her","owner":{"login":"HelpAssistHer","id":24535520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTM1NTIw","avatar_url":"https://avatars0.githubusercontent.com/u/24535520?v=4","gravatar_id":"","url":"https://api.github.com/users/HelpAssistHer","html_url":"https://github.com/HelpAssistHer","followers_url":"https://api.github.com/users/HelpAssistHer/followers","following_url":"https://api.github.com/users/HelpAssistHer/following{/other_user}","gists_url":"https://api.github.com/users/HelpAssistHer/gists{/gist_id}","starred_url":"https://api.github.com/users/HelpAssistHer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelpAssistHer/subscriptions","organizations_url":"https://api.github.com/users/HelpAssistHer/orgs","repos_url":"https://api.github.com/users/HelpAssistHer/repos","events_url":"https://api.github.com/users/HelpAssistHer/events{/privacy}","received_events_url":"https://api.github.com/users/HelpAssistHer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HelpAssistHer/help-assist-her","description":"Women's healthcare resources in the palm of your hand","fork":false,"url":"https://api.github.com/repos/HelpAssistHer/help-assist-her","forks_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/forks","keys_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/teams","hooks_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/hooks","issue_events_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/events{/number}","events_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/events","assignees_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/assignees{/user}","branches_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/branches{/branch}","tags_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/tags","blobs_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/refs{/sha}","trees_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/statuses/{sha}","languages_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/languages","stargazers_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/stargazers","contributors_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/contributors","subscribers_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/subscribers","subscription_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/subscription","commits_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/commits{/sha}","git_commits_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/git/commits{/sha}","comments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/comments{/number}","issue_comment_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/comments{/number}","contents_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/contents/{+path}","compare_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/merges","archive_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/downloads","issues_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues{/number}","pulls_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls{/number}","milestones_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/milestones{/number}","notifications_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/labels{/name}","releases_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/releases{/id}","deployments_url":"https://api.github.com/repos/HelpAssistHer/help-assist-her/deployments","created_at":"2016-12-13T01:47:01Z","updated_at":"2018-07-09T14:58:04Z","pushed_at":"2018-07-09T14:58:04Z","git_url":"git://github.com/HelpAssistHer/help-assist-her.git","ssh_url":"git@github.com:HelpAssistHer/help-assist-her.git","clone_url":"https://github.com/HelpAssistHer/help-assist-her.git","svn_url":"https://github.com/HelpAssistHer/help-assist-her","homepage":"http://www.helpassisther.com","size":4180,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91"},"html":{"href":"https://github.com/HelpAssistHer/help-assist-her/pull/91"},"issue":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/91"},"comments":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/HelpAssistHer/help-assist-her/statuses/6fca01ee2acca72ea2dd2a0191ee85dcf30db3a5"}},"author_association":"COLLABORATOR"}} | {
"id": 76312200,
"name": "HelpAssistHer/help-assist-her",
"url": "https://api.github.com/repos/HelpAssistHer/help-assist-her"
} | {
"id": 6378435,
"login": "karenmrose",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6378435?",
"url": "https://api.github.com/users/karenmrose"
} | {
"id": 24535520,
"login": "HelpAssistHer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24535520?",
"url": "https://api.github.com/orgs/HelpAssistHer"
} | 2018-07-09T15:15:49 | 7938301783 | {"actor":{"display_login":"karenmrose"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nucypher/nucypher/pulls/comments/228722202","pull_request_review_id":169065687,"id":228722202,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODcyMjIwMg==","diff_hunk":"@@ -0,0 +1,30 @@\n+import json\n+import random\n+from os.path import abspath, dirname, join\n+\n+HERE = BASE_DIR = abspath(dirname(__file__))\n+with open(join(HERE, 'web_colors.json')) as f:\n+ colors = json.load(f)\n+\n+with open(join(HERE, 'zodiac.json')) as f:\n+ zodiac = json.load(f)\n+\n+eastern = zodiac['eastern_zodiac']\n+western = zodiac['western_zodiac']\n+\n+eastern_list = list(eastern.keys())\n+western_list = list(western.keys())\n+\n+colors = colors['colors']\n+pairs = []\n+\n+\n+def nickname_from_seed(seed):\n+ random.seed(seed)\n+ color1 = random.choice(colors)\n+ color2 = random.choice(colors)\n+ western_symbol = random.choice(western_list)\n+ eastern_symbol = random.choice(eastern_list)\n+ nickname = \"{}ish {} {} {}\".format(color1['color'], color2['color'], western_symbol, eastern_symbol)\n+ nickname_metadata = (color1, color2, western[western_symbol], eastern[eastern_symbol])","path":"nucypher/network/nicknames/__init__.py","position":29,"original_position":29,"commit_id":"38fd821a1dbdbc3cca9c8c0955e247792489b643","original_commit_id":"38fd821a1dbdbc3cca9c8c0955e247792489b643","user":{"login":"cygnusv","id":2564234,"node_id":"MDQ6VXNlcjI1NjQyMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2564234?v=4","gravatar_id":"","url":"https://api.github.com/users/cygnusv","html_url":"https://github.com/cygnusv","followers_url":"https://api.github.com/users/cygnusv/followers","following_url":"https://api.github.com/users/cygnusv/following{/other_user}","gists_url":"https://api.github.com/users/cygnusv/gists{/gist_id}","starred_url":"https://api.github.com/users/cygnusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cygnusv/subscriptions","organizations_url":"https://api.github.com/users/cygnusv/orgs","repos_url":"https://api.github.com/users/cygnusv/repos","events_url":"https://api.github.com/users/cygnusv/events{/privacy}","received_events_url":"https://api.github.com/users/cygnusv/received_events","type":"User","site_admin":false},"body":"just my 2 cents: I find the format `color symbol color symbol` to be more appealing. Kind of a \"_crouching tiger hidden dragon_\" sort of thing.","created_at":"2018-10-27T18:33:07Z","updated_at":"2018-10-27T18:39:06Z","html_url":"https://github.com/nucypher/nucypher/pull/498#discussion_r228722202","pull_request_url":"https://api.github.com/repos/nucypher/nucypher/pulls/498","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/comments/228722202"},"html":{"href":"https://github.com/nucypher/nucypher/pull/498#discussion_r228722202"},"pull_request":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/498"}}},"pull_request":{"url":"https://api.github.com/repos/nucypher/nucypher/pulls/498","id":226312320,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzEyMzIw","html_url":"https://github.com/nucypher/nucypher/pull/498","diff_url":"https://github.com/nucypher/nucypher/pull/498.diff","patch_url":"https://github.com/nucypher/nucypher/pull/498.patch","issue_url":"https://api.github.com/repos/nucypher/nucypher/issues/498","number":498,"state":"open","locked":false,"title":"Nicknames","user":{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},"body":"Nodes now get nicknames generated based on their checksum address in the format:\r\n\r\n\"{color}ish color {western zodiac sign} {eatern zodiac sign}\"\r\n\r\nFor example:\r\n\r\n* Aquaish DarkTurquoise Leo Dragon\r\n* SeaGreenish CadetBlue Pisces Goat\r\n\r\nThese names are not generated in a cryptographically-secure way; they are meant for use only in monitoring dashboards or other places where human-readability is paramount and verification can occur against the actual checksum address. The total space is only 2822400, so we can expect an honest collision every 2000 or so nodes.\r\n\r\nIn addition to the `nickname`, nodes are also given `nickname_metadata`, which contains information useful for making visual icons based on the nickname: hex values for the two colors and unicode characters for the two signs.","created_at":"2018-10-27T18:02:46Z","updated_at":"2018-10-27T18:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e0a3490c2d2482fa7145526270dcf4d6542539c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nucypher/nucypher/pulls/498/commits","review_comments_url":"https://api.github.com/repos/nucypher/nucypher/pulls/498/comments","review_comment_url":"https://api.github.com/repos/nucypher/nucypher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nucypher/nucypher/issues/498/comments","statuses_url":"https://api.github.com/repos/nucypher/nucypher/statuses/38fd821a1dbdbc3cca9c8c0955e247792489b643","head":{"label":"jMyles:network","ref":"network","sha":"38fd821a1dbdbc3cca9c8c0955e247792489b643","user":{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},"repo":{"id":101236972,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyMzY5NzI=","name":"nucypher","full_name":"jMyles/nucypher","private":false,"owner":{"login":"jMyles","id":311973,"node_id":"MDQ6VXNlcjMxMTk3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/311973?v=4","gravatar_id":"","url":"https://api.github.com/users/jMyles","html_url":"https://github.com/jMyles","followers_url":"https://api.github.com/users/jMyles/followers","following_url":"https://api.github.com/users/jMyles/following{/other_user}","gists_url":"https://api.github.com/users/jMyles/gists{/gist_id}","starred_url":"https://api.github.com/users/jMyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jMyles/subscriptions","organizations_url":"https://api.github.com/users/jMyles/orgs","repos_url":"https://api.github.com/users/jMyles/repos","events_url":"https://api.github.com/users/jMyles/events{/privacy}","received_events_url":"https://api.github.com/users/jMyles/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jMyles/nucypher","description":" A proxy re-encryption network to empower privacy in decentralized systems. https://nucypher.com ","fork":true,"url":"https://api.github.com/repos/jMyles/nucypher","forks_url":"https://api.github.com/repos/jMyles/nucypher/forks","keys_url":"https://api.github.com/repos/jMyles/nucypher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jMyles/nucypher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jMyles/nucypher/teams","hooks_url":"https://api.github.com/repos/jMyles/nucypher/hooks","issue_events_url":"https://api.github.com/repos/jMyles/nucypher/issues/events{/number}","events_url":"https://api.github.com/repos/jMyles/nucypher/events","assignees_url":"https://api.github.com/repos/jMyles/nucypher/assignees{/user}","branches_url":"https://api.github.com/repos/jMyles/nucypher/branches{/branch}","tags_url":"https://api.github.com/repos/jMyles/nucypher/tags","blobs_url":"https://api.github.com/repos/jMyles/nucypher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jMyles/nucypher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jMyles/nucypher/git/refs{/sha}","trees_url":"https://api.github.com/repos/jMyles/nucypher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jMyles/nucypher/statuses/{sha}","languages_url":"https://api.github.com/repos/jMyles/nucypher/languages","stargazers_url":"https://api.github.com/repos/jMyles/nucypher/stargazers","contributors_url":"https://api.github.com/repos/jMyles/nucypher/contributors","subscribers_url":"https://api.github.com/repos/jMyles/nucypher/subscribers","subscription_url":"https://api.github.com/repos/jMyles/nucypher/subscription","commits_url":"https://api.github.com/repos/jMyles/nucypher/commits{/sha}","git_commits_url":"https://api.github.com/repos/jMyles/nucypher/git/commits{/sha}","comments_url":"https://api.github.com/repos/jMyles/nucypher/comments{/number}","issue_comment_url":"https://api.github.com/repos/jMyles/nucypher/issues/comments{/number}","contents_url":"https://api.github.com/repos/jMyles/nucypher/contents/{+path}","compare_url":"https://api.github.com/repos/jMyles/nucypher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jMyles/nucypher/merges","archive_url":"https://api.github.com/repos/jMyles/nucypher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jMyles/nucypher/downloads","issues_url":"https://api.github.com/repos/jMyles/nucypher/issues{/number}","pulls_url":"https://api.github.com/repos/jMyles/nucypher/pulls{/number}","milestones_url":"https://api.github.com/repos/jMyles/nucypher/milestones{/number}","notifications_url":"https://api.github.com/repos/jMyles/nucypher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jMyles/nucypher/labels{/name}","releases_url":"https://api.github.com/repos/jMyles/nucypher/releases{/id}","deployments_url":"https://api.github.com/repos/jMyles/nucypher/deployments","created_at":"2017-08-24T00:35:44Z","updated_at":"2018-08-09T21:31:07Z","pushed_at":"2018-10-27T17:31:41Z","git_url":"git://github.com/jMyles/nucypher.git","ssh_url":"git@github.com:jMyles/nucypher.git","clone_url":"https://github.com/jMyles/nucypher.git","svn_url":"https://github.com/jMyles/nucypher","homepage":"","size":8289,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nucypher:cedar","ref":"cedar","sha":"e5896ff74d410cea59c9633e7f178ebd7ca1a873","user":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"repo":{"id":100446516,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0NDY1MTY=","name":"nucypher","full_name":"nucypher/nucypher","private":false,"owner":{"login":"nucypher","id":24552990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTUyOTkw","avatar_url":"https://avatars0.githubusercontent.com/u/24552990?v=4","gravatar_id":"","url":"https://api.github.com/users/nucypher","html_url":"https://github.com/nucypher","followers_url":"https://api.github.com/users/nucypher/followers","following_url":"https://api.github.com/users/nucypher/following{/other_user}","gists_url":"https://api.github.com/users/nucypher/gists{/gist_id}","starred_url":"https://api.github.com/users/nucypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nucypher/subscriptions","organizations_url":"https://api.github.com/users/nucypher/orgs","repos_url":"https://api.github.com/users/nucypher/repos","events_url":"https://api.github.com/users/nucypher/events{/privacy}","received_events_url":"https://api.github.com/users/nucypher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nucypher/nucypher","description":"A proxy re-encryption network to empower privacy in decentralized systems.","fork":false,"url":"https://api.github.com/repos/nucypher/nucypher","forks_url":"https://api.github.com/repos/nucypher/nucypher/forks","keys_url":"https://api.github.com/repos/nucypher/nucypher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nucypher/nucypher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nucypher/nucypher/teams","hooks_url":"https://api.github.com/repos/nucypher/nucypher/hooks","issue_events_url":"https://api.github.com/repos/nucypher/nucypher/issues/events{/number}","events_url":"https://api.github.com/repos/nucypher/nucypher/events","assignees_url":"https://api.github.com/repos/nucypher/nucypher/assignees{/user}","branches_url":"https://api.github.com/repos/nucypher/nucypher/branches{/branch}","tags_url":"https://api.github.com/repos/nucypher/nucypher/tags","blobs_url":"https://api.github.com/repos/nucypher/nucypher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nucypher/nucypher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nucypher/nucypher/git/refs{/sha}","trees_url":"https://api.github.com/repos/nucypher/nucypher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nucypher/nucypher/statuses/{sha}","languages_url":"https://api.github.com/repos/nucypher/nucypher/languages","stargazers_url":"https://api.github.com/repos/nucypher/nucypher/stargazers","contributors_url":"https://api.github.com/repos/nucypher/nucypher/contributors","subscribers_url":"https://api.github.com/repos/nucypher/nucypher/subscribers","subscription_url":"https://api.github.com/repos/nucypher/nucypher/subscription","commits_url":"https://api.github.com/repos/nucypher/nucypher/commits{/sha}","git_commits_url":"https://api.github.com/repos/nucypher/nucypher/git/commits{/sha}","comments_url":"https://api.github.com/repos/nucypher/nucypher/comments{/number}","issue_comment_url":"https://api.github.com/repos/nucypher/nucypher/issues/comments{/number}","contents_url":"https://api.github.com/repos/nucypher/nucypher/contents/{+path}","compare_url":"https://api.github.com/repos/nucypher/nucypher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nucypher/nucypher/merges","archive_url":"https://api.github.com/repos/nucypher/nucypher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nucypher/nucypher/downloads","issues_url":"https://api.github.com/repos/nucypher/nucypher/issues{/number}","pulls_url":"https://api.github.com/repos/nucypher/nucypher/pulls{/number}","milestones_url":"https://api.github.com/repos/nucypher/nucypher/milestones{/number}","notifications_url":"https://api.github.com/repos/nucypher/nucypher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nucypher/nucypher/labels{/name}","releases_url":"https://api.github.com/repos/nucypher/nucypher/releases{/id}","deployments_url":"https://api.github.com/repos/nucypher/nucypher/deployments","created_at":"2017-08-16T04:07:25Z","updated_at":"2018-10-26T07:18:08Z","pushed_at":"2018-10-27T18:37:22Z","git_url":"git://github.com/nucypher/nucypher.git","ssh_url":"git@github.com:nucypher/nucypher.git","clone_url":"https://github.com/nucypher/nucypher.git","svn_url":"https://github.com/nucypher/nucypher","homepage":"https://nucypher.com","size":8134,"stargazers_count":118,"watchers_count":118,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":80,"license":null,"forks":31,"open_issues":80,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/498"},"html":{"href":"https://github.com/nucypher/nucypher/pull/498"},"issue":{"href":"https://api.github.com/repos/nucypher/nucypher/issues/498"},"comments":{"href":"https://api.github.com/repos/nucypher/nucypher/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nucypher/nucypher/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/nucypher/nucypher/statuses/38fd821a1dbdbc3cca9c8c0955e247792489b643"}},"author_association":"MEMBER"}} | {
"id": 100446516,
"name": "nucypher/nucypher",
"url": "https://api.github.com/repos/nucypher/nucypher"
} | {
"id": 2564234,
"login": "cygnusv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2564234?",
"url": "https://api.github.com/users/cygnusv"
} | {
"id": 24552990,
"login": "nucypher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24552990?",
"url": "https://api.github.com/orgs/nucypher"
} | 2018-10-27T18:33:07 | 8492023658 | {"actor":{"display_login":"cygnusv"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apifytech/apify-js/pulls/comments/210261456","pull_request_review_id":146436888,"id":210261456,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI2MTQ1Ng==","diff_hunk":"@@ -231,13 +231,13 @@ export default class PuppeteerCrawler {\n if (!isPromise(promise)) throw new Error('User provided handlePageFunction must return a Promise.');\n \n return promise;\n- });\n-\n- return handlePagePromise\n+ })\n .timeout(this.pageOpsTimeoutMillis, 'PuppeteerCrawler: handlePageFunction timed out.')\n .finally(() => {\n return Promise\n- .try(() => page.close())\n+ .try(() => {\n+ if (page) return page.close();","path":"src/puppeteer_crawler.js","position":null,"original_position":22,"commit_id":"60e1a37dc88ca4137385695cfe36c7c411e3f392","original_commit_id":"7246e8c1adc960c36d8c733bb348397d2482c282","user":{"login":"jancurn","id":10612996,"node_id":"MDQ6VXNlcjEwNjEyOTk2","avatar_url":"https://avatars1.githubusercontent.com/u/10612996?v=4","gravatar_id":"","url":"https://api.github.com/users/jancurn","html_url":"https://github.com/jancurn","followers_url":"https://api.github.com/users/jancurn/followers","following_url":"https://api.github.com/users/jancurn/following{/other_user}","gists_url":"https://api.github.com/users/jancurn/gists{/gist_id}","starred_url":"https://api.github.com/users/jancurn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancurn/subscriptions","organizations_url":"https://api.github.com/users/jancurn/orgs","repos_url":"https://api.github.com/users/jancurn/repos","events_url":"https://api.github.com/users/jancurn/events{/privacy}","received_events_url":"https://api.github.com/users/jancurn/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-08-15T13:07:23Z","updated_at":"2018-08-15T13:07:23Z","html_url":"https://github.com/apifytech/apify-js/pull/147#discussion_r210261456","pull_request_url":"https://api.github.com/repos/apifytech/apify-js/pulls/147","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/comments/210261456"},"html":{"href":"https://github.com/apifytech/apify-js/pull/147#discussion_r210261456"},"pull_request":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/147"}},"in_reply_to_id":210215953},"pull_request":{"url":"https://api.github.com/repos/apifytech/apify-js/pulls/147","id":208294121,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Mjk0MTIx","html_url":"https://github.com/apifytech/apify-js/pull/147","diff_url":"https://github.com/apifytech/apify-js/pull/147.diff","patch_url":"https://github.com/apifytech/apify-js/pull/147.patch","issue_url":"https://api.github.com/repos/apifytech/apify-js/issues/147","number":147,"state":"open","locked":false,"title":"Added Apify.utils.puppeteer.blockResources() - Eureka!","user":{"login":"jancurn","id":10612996,"node_id":"MDQ6VXNlcjEwNjEyOTk2","avatar_url":"https://avatars1.githubusercontent.com/u/10612996?v=4","gravatar_id":"","url":"https://api.github.com/users/jancurn","html_url":"https://github.com/jancurn","followers_url":"https://api.github.com/users/jancurn/followers","following_url":"https://api.github.com/users/jancurn/following{/other_user}","gists_url":"https://api.github.com/users/jancurn/gists{/gist_id}","starred_url":"https://api.github.com/users/jancurn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancurn/subscriptions","organizations_url":"https://api.github.com/users/jancurn/orgs","repos_url":"https://api.github.com/users/jancurn/repos","events_url":"https://api.github.com/users/jancurn/events{/privacy}","received_events_url":"https://api.github.com/users/jancurn/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-14T14:07:23Z","updated_at":"2018-08-15T13:07:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be0fc2f30a6cc9a58e0a506626ffbb9f66549517","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gippy","id":3171028,"node_id":"MDQ6VXNlcjMxNzEwMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3171028?v=4","gravatar_id":"","url":"https://api.github.com/users/gippy","html_url":"https://github.com/gippy","followers_url":"https://api.github.com/users/gippy/followers","following_url":"https://api.github.com/users/gippy/following{/other_user}","gists_url":"https://api.github.com/users/gippy/gists{/gist_id}","starred_url":"https://api.github.com/users/gippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gippy/subscriptions","organizations_url":"https://api.github.com/users/gippy/orgs","repos_url":"https://api.github.com/users/gippy/repos","events_url":"https://api.github.com/users/gippy/events{/privacy}","received_events_url":"https://api.github.com/users/gippy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apifytech/apify-js/pulls/147/commits","review_comments_url":"https://api.github.com/repos/apifytech/apify-js/pulls/147/comments","review_comment_url":"https://api.github.com/repos/apifytech/apify-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apifytech/apify-js/issues/147/comments","statuses_url":"https://api.github.com/repos/apifytech/apify-js/statuses/60e1a37dc88ca4137385695cfe36c7c411e3f392","head":{"label":"apifytech:feature/block-resources","ref":"feature/block-resources","sha":"60e1a37dc88ca4137385695cfe36c7c411e3f392","user":{"login":"apifytech","id":24586296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg2Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/24586296?v=4","gravatar_id":"","url":"https://api.github.com/users/apifytech","html_url":"https://github.com/apifytech","followers_url":"https://api.github.com/users/apifytech/followers","following_url":"https://api.github.com/users/apifytech/following{/other_user}","gists_url":"https://api.github.com/users/apifytech/gists{/gist_id}","starred_url":"https://api.github.com/users/apifytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apifytech/subscriptions","organizations_url":"https://api.github.com/users/apifytech/orgs","repos_url":"https://api.github.com/users/apifytech/repos","events_url":"https://api.github.com/users/apifytech/events{/privacy}","received_events_url":"https://api.github.com/users/apifytech/received_events","type":"Organization","site_admin":false},"repo":{"id":66670819,"node_id":"MDEwOlJlcG9zaXRvcnk2NjY3MDgxOQ==","name":"apify-js","full_name":"apifytech/apify-js","owner":{"login":"apifytech","id":24586296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg2Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/24586296?v=4","gravatar_id":"","url":"https://api.github.com/users/apifytech","html_url":"https://github.com/apifytech","followers_url":"https://api.github.com/users/apifytech/followers","following_url":"https://api.github.com/users/apifytech/following{/other_user}","gists_url":"https://api.github.com/users/apifytech/gists{/gist_id}","starred_url":"https://api.github.com/users/apifytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apifytech/subscriptions","organizations_url":"https://api.github.com/users/apifytech/orgs","repos_url":"https://api.github.com/users/apifytech/repos","events_url":"https://api.github.com/users/apifytech/events{/privacy}","received_events_url":"https://api.github.com/users/apifytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apifytech/apify-js","description":"Apify SDK: The web scraping and automation library for JavaScript / Node.js. Enables development of web scrapers, crawlers and web automation jobs (not only) with headless Chrome and Puppeteer.","fork":false,"url":"https://api.github.com/repos/apifytech/apify-js","forks_url":"https://api.github.com/repos/apifytech/apify-js/forks","keys_url":"https://api.github.com/repos/apifytech/apify-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apifytech/apify-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apifytech/apify-js/teams","hooks_url":"https://api.github.com/repos/apifytech/apify-js/hooks","issue_events_url":"https://api.github.com/repos/apifytech/apify-js/issues/events{/number}","events_url":"https://api.github.com/repos/apifytech/apify-js/events","assignees_url":"https://api.github.com/repos/apifytech/apify-js/assignees{/user}","branches_url":"https://api.github.com/repos/apifytech/apify-js/branches{/branch}","tags_url":"https://api.github.com/repos/apifytech/apify-js/tags","blobs_url":"https://api.github.com/repos/apifytech/apify-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apifytech/apify-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apifytech/apify-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/apifytech/apify-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apifytech/apify-js/statuses/{sha}","languages_url":"https://api.github.com/repos/apifytech/apify-js/languages","stargazers_url":"https://api.github.com/repos/apifytech/apify-js/stargazers","contributors_url":"https://api.github.com/repos/apifytech/apify-js/contributors","subscribers_url":"https://api.github.com/repos/apifytech/apify-js/subscribers","subscription_url":"https://api.github.com/repos/apifytech/apify-js/subscription","commits_url":"https://api.github.com/repos/apifytech/apify-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/apifytech/apify-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/apifytech/apify-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/apifytech/apify-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/apifytech/apify-js/contents/{+path}","compare_url":"https://api.github.com/repos/apifytech/apify-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apifytech/apify-js/merges","archive_url":"https://api.github.com/repos/apifytech/apify-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apifytech/apify-js/downloads","issues_url":"https://api.github.com/repos/apifytech/apify-js/issues{/number}","pulls_url":"https://api.github.com/repos/apifytech/apify-js/pulls{/number}","milestones_url":"https://api.github.com/repos/apifytech/apify-js/milestones{/number}","notifications_url":"https://api.github.com/repos/apifytech/apify-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apifytech/apify-js/labels{/name}","releases_url":"https://api.github.com/repos/apifytech/apify-js/releases{/id}","deployments_url":"https://api.github.com/repos/apifytech/apify-js/deployments","created_at":"2016-08-26T18:35:03Z","updated_at":"2018-08-11T16:07:42Z","pushed_at":"2018-08-15T12:26:16Z","git_url":"git://github.com/apifytech/apify-js.git","ssh_url":"git@github.com:apifytech/apify-js.git","clone_url":"https://github.com/apifytech/apify-js.git","svn_url":"https://github.com/apifytech/apify-js","homepage":"https://www.npmjs.com/package/apify","size":941,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":27,"watchers":53,"default_branch":"master"}},"base":{"label":"apifytech:develop","ref":"develop","sha":"6e6a2aef81975f71a1448b82c9ef2d5f0de6d8d0","user":{"login":"apifytech","id":24586296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg2Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/24586296?v=4","gravatar_id":"","url":"https://api.github.com/users/apifytech","html_url":"https://github.com/apifytech","followers_url":"https://api.github.com/users/apifytech/followers","following_url":"https://api.github.com/users/apifytech/following{/other_user}","gists_url":"https://api.github.com/users/apifytech/gists{/gist_id}","starred_url":"https://api.github.com/users/apifytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apifytech/subscriptions","organizations_url":"https://api.github.com/users/apifytech/orgs","repos_url":"https://api.github.com/users/apifytech/repos","events_url":"https://api.github.com/users/apifytech/events{/privacy}","received_events_url":"https://api.github.com/users/apifytech/received_events","type":"Organization","site_admin":false},"repo":{"id":66670819,"node_id":"MDEwOlJlcG9zaXRvcnk2NjY3MDgxOQ==","name":"apify-js","full_name":"apifytech/apify-js","owner":{"login":"apifytech","id":24586296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg2Mjk2","avatar_url":"https://avatars3.githubusercontent.com/u/24586296?v=4","gravatar_id":"","url":"https://api.github.com/users/apifytech","html_url":"https://github.com/apifytech","followers_url":"https://api.github.com/users/apifytech/followers","following_url":"https://api.github.com/users/apifytech/following{/other_user}","gists_url":"https://api.github.com/users/apifytech/gists{/gist_id}","starred_url":"https://api.github.com/users/apifytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apifytech/subscriptions","organizations_url":"https://api.github.com/users/apifytech/orgs","repos_url":"https://api.github.com/users/apifytech/repos","events_url":"https://api.github.com/users/apifytech/events{/privacy}","received_events_url":"https://api.github.com/users/apifytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apifytech/apify-js","description":"Apify SDK: The web scraping and automation library for JavaScript / Node.js. Enables development of web scrapers, crawlers and web automation jobs (not only) with headless Chrome and Puppeteer.","fork":false,"url":"https://api.github.com/repos/apifytech/apify-js","forks_url":"https://api.github.com/repos/apifytech/apify-js/forks","keys_url":"https://api.github.com/repos/apifytech/apify-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apifytech/apify-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apifytech/apify-js/teams","hooks_url":"https://api.github.com/repos/apifytech/apify-js/hooks","issue_events_url":"https://api.github.com/repos/apifytech/apify-js/issues/events{/number}","events_url":"https://api.github.com/repos/apifytech/apify-js/events","assignees_url":"https://api.github.com/repos/apifytech/apify-js/assignees{/user}","branches_url":"https://api.github.com/repos/apifytech/apify-js/branches{/branch}","tags_url":"https://api.github.com/repos/apifytech/apify-js/tags","blobs_url":"https://api.github.com/repos/apifytech/apify-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apifytech/apify-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apifytech/apify-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/apifytech/apify-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apifytech/apify-js/statuses/{sha}","languages_url":"https://api.github.com/repos/apifytech/apify-js/languages","stargazers_url":"https://api.github.com/repos/apifytech/apify-js/stargazers","contributors_url":"https://api.github.com/repos/apifytech/apify-js/contributors","subscribers_url":"https://api.github.com/repos/apifytech/apify-js/subscribers","subscription_url":"https://api.github.com/repos/apifytech/apify-js/subscription","commits_url":"https://api.github.com/repos/apifytech/apify-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/apifytech/apify-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/apifytech/apify-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/apifytech/apify-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/apifytech/apify-js/contents/{+path}","compare_url":"https://api.github.com/repos/apifytech/apify-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apifytech/apify-js/merges","archive_url":"https://api.github.com/repos/apifytech/apify-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apifytech/apify-js/downloads","issues_url":"https://api.github.com/repos/apifytech/apify-js/issues{/number}","pulls_url":"https://api.github.com/repos/apifytech/apify-js/pulls{/number}","milestones_url":"https://api.github.com/repos/apifytech/apify-js/milestones{/number}","notifications_url":"https://api.github.com/repos/apifytech/apify-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apifytech/apify-js/labels{/name}","releases_url":"https://api.github.com/repos/apifytech/apify-js/releases{/id}","deployments_url":"https://api.github.com/repos/apifytech/apify-js/deployments","created_at":"2016-08-26T18:35:03Z","updated_at":"2018-08-11T16:07:42Z","pushed_at":"2018-08-15T12:26:16Z","git_url":"git://github.com/apifytech/apify-js.git","ssh_url":"git@github.com:apifytech/apify-js.git","clone_url":"https://github.com/apifytech/apify-js.git","svn_url":"https://github.com/apifytech/apify-js","homepage":"https://www.npmjs.com/package/apify","size":941,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":27,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/147"},"html":{"href":"https://github.com/apifytech/apify-js/pull/147"},"issue":{"href":"https://api.github.com/repos/apifytech/apify-js/issues/147"},"comments":{"href":"https://api.github.com/repos/apifytech/apify-js/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apifytech/apify-js/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/apifytech/apify-js/statuses/60e1a37dc88ca4137385695cfe36c7c411e3f392"}},"author_association":"MEMBER"}} | {
"id": 66670819,
"name": "apifytech/apify-js",
"url": "https://api.github.com/repos/apifytech/apify-js"
} | {
"id": 10612996,
"login": "jancurn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10612996?",
"url": "https://api.github.com/users/jancurn"
} | {
"id": 24586296,
"login": "apifytech",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24586296?",
"url": "https://api.github.com/orgs/apifytech"
} | 2018-08-15T13:07:23 | 8116888746 | {"actor":{"display_login":"jancurn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/1024pix/pix/pulls/comments/235765612","pull_request_review_id":177707669,"id":235765612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc2NTYxMg==","diff_hunk":"@@ -0,0 +1,173 @@\n+const { expect, factory, sinon } = require('../../../test-helper');\n+const findUserAssessmentsByFilters = require('../../../../lib/domain/usecases/find-user-assessments-by-filters');\n+\n+describe('Unit | UseCase | find-user-assessments-by-filters', () => {\n+\n+ const assessmentRepository = {\n+ getByFilters: () => {\n+ },\n+ findByCampaignFilters: () => {\n+ },\n+ getByCertificationCourseId: () => {\n+ }\n+ };\n+\n+ let sandbox;\n+\n+ beforeEach(() => {\n+ sandbox = sinon.sandbox.create();\n+ });\n+\n+ afterEach(() => {\n+ sandbox.restore();\n+ });\n+\n+ context('when this is a campaign placement', () => {\n+ it('should call repository with filters to find assessments', () => {","path":"api/tests/unit/domain/usecases/find-user-assessments-by-filters_test.js","position":26,"original_position":26,"commit_id":"8f9695f540b4d58731aedeca558b55c047ad71ec","original_commit_id":"8f9695f540b4d58731aedeca558b55c047ad71ec","user":{"login":"sroccaserra","id":7529,"node_id":"MDQ6VXNlcjc1Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/7529?v=4","gravatar_id":"","url":"https://api.github.com/users/sroccaserra","html_url":"https://github.com/sroccaserra","followers_url":"https://api.github.com/users/sroccaserra/followers","following_url":"https://api.github.com/users/sroccaserra/following{/other_user}","gists_url":"https://api.github.com/users/sroccaserra/gists{/gist_id}","starred_url":"https://api.github.com/users/sroccaserra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroccaserra/subscriptions","organizations_url":"https://api.github.com/users/sroccaserra/orgs","repos_url":"https://api.github.com/users/sroccaserra/repos","events_url":"https://api.github.com/users/sroccaserra/events{/privacy}","received_events_url":"https://api.github.com/users/sroccaserra/received_events","type":"User","site_admin":false},"body":"Q: est-ce qu'on a besoin de garder ce test ?","created_at":"2018-11-22T15:38:09Z","updated_at":"2018-11-22T15:38:10Z","html_url":"https://github.com/1024pix/pix/pull/275#discussion_r235765612","pull_request_url":"https://api.github.com/repos/1024pix/pix/pulls/275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/1024pix/pix/pulls/comments/235765612"},"html":{"href":"https://github.com/1024pix/pix/pull/275#discussion_r235765612"},"pull_request":{"href":"https://api.github.com/repos/1024pix/pix/pulls/275"}}},"pull_request":{"url":"https://api.github.com/repos/1024pix/pix/pulls/275","id":231932951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTMyOTUx","html_url":"https://github.com/1024pix/pix/pull/275","diff_url":"https://github.com/1024pix/pix/pull/275.diff","patch_url":"https://github.com/1024pix/pix/pull/275.patch","issue_url":"https://api.github.com/repos/1024pix/pix/issues/275","number":275,"state":"open","locked":false,"title":"[BUGFIX] Même si un utilisateur ouvre plusieurs onglets pour se positionner sur une compétence, un seul positionnement est créé. (PF-430).","user":{"login":"lisequesnel","id":23451175,"node_id":"MDQ6VXNlcjIzNDUxMTc1","avatar_url":"https://avatars1.githubusercontent.com/u/23451175?v=4","gravatar_id":"","url":"https://api.github.com/users/lisequesnel","html_url":"https://github.com/lisequesnel","followers_url":"https://api.github.com/users/lisequesnel/followers","following_url":"https://api.github.com/users/lisequesnel/following{/other_user}","gists_url":"https://api.github.com/users/lisequesnel/gists{/gist_id}","starred_url":"https://api.github.com/users/lisequesnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisequesnel/subscriptions","organizations_url":"https://api.github.com/users/lisequesnel/orgs","repos_url":"https://api.github.com/users/lisequesnel/repos","events_url":"https://api.github.com/users/lisequesnel/events{/privacy}","received_events_url":"https://api.github.com/users/lisequesnel/received_events","type":"User","site_admin":false},"body":"# 🤷♀️ 🤷♂️ Besoin : \r\nSi un utilisateur de Pix commence plusieurs fois un positionnement sur une même compétence, c'est le même positionnement (fonctionne comme une reprise). Comportement auparavant : il commençait son positionnement ET sa seconde chance en même temps. \r\n\r\n# 👩💻👨💻 Technique : \r\nCréation d'un assessment seulement si il n'en existe pas déjà un commencé et non terminé pour la même compétence et le même utilisateur.","created_at":"2018-11-19T11:05:18Z","updated_at":"2018-11-22T15:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53015db11dc7394e229f2d8813f0a7597d06da17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1128820237,"node_id":"MDU6TGFiZWwxMTI4ODIwMjM3","url":"https://api.github.com/repos/1024pix/pix/labels/TECH%20REVIEW%20ASKED","name":"TECH REVIEW ASKED","color":"ff1ca1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/1024pix/pix/pulls/275/commits","review_comments_url":"https://api.github.com/repos/1024pix/pix/pulls/275/comments","review_comment_url":"https://api.github.com/repos/1024pix/pix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/1024pix/pix/issues/275/comments","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/8f9695f540b4d58731aedeca558b55c047ad71ec","head":{"label":"1024pix:pf-430-bugfix-two-assessments","ref":"pf-430-bugfix-two-assessments","sha":"8f9695f540b4d58731aedeca558b55c047ad71ec","user":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"repo":{"id":126852331,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NTIzMzE=","name":"pix","full_name":"1024pix/pix","private":false,"owner":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/1024pix/pix","description":"Plateforme d'évaluation et de certification des compétences numériques à l'usage de tous les citoyens francophones.","fork":false,"url":"https://api.github.com/repos/1024pix/pix","forks_url":"https://api.github.com/repos/1024pix/pix/forks","keys_url":"https://api.github.com/repos/1024pix/pix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1024pix/pix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1024pix/pix/teams","hooks_url":"https://api.github.com/repos/1024pix/pix/hooks","issue_events_url":"https://api.github.com/repos/1024pix/pix/issues/events{/number}","events_url":"https://api.github.com/repos/1024pix/pix/events","assignees_url":"https://api.github.com/repos/1024pix/pix/assignees{/user}","branches_url":"https://api.github.com/repos/1024pix/pix/branches{/branch}","tags_url":"https://api.github.com/repos/1024pix/pix/tags","blobs_url":"https://api.github.com/repos/1024pix/pix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1024pix/pix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1024pix/pix/git/refs{/sha}","trees_url":"https://api.github.com/repos/1024pix/pix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/{sha}","languages_url":"https://api.github.com/repos/1024pix/pix/languages","stargazers_url":"https://api.github.com/repos/1024pix/pix/stargazers","contributors_url":"https://api.github.com/repos/1024pix/pix/contributors","subscribers_url":"https://api.github.com/repos/1024pix/pix/subscribers","subscription_url":"https://api.github.com/repos/1024pix/pix/subscription","commits_url":"https://api.github.com/repos/1024pix/pix/commits{/sha}","git_commits_url":"https://api.github.com/repos/1024pix/pix/git/commits{/sha}","comments_url":"https://api.github.com/repos/1024pix/pix/comments{/number}","issue_comment_url":"https://api.github.com/repos/1024pix/pix/issues/comments{/number}","contents_url":"https://api.github.com/repos/1024pix/pix/contents/{+path}","compare_url":"https://api.github.com/repos/1024pix/pix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1024pix/pix/merges","archive_url":"https://api.github.com/repos/1024pix/pix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1024pix/pix/downloads","issues_url":"https://api.github.com/repos/1024pix/pix/issues{/number}","pulls_url":"https://api.github.com/repos/1024pix/pix/pulls{/number}","milestones_url":"https://api.github.com/repos/1024pix/pix/milestones{/number}","notifications_url":"https://api.github.com/repos/1024pix/pix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1024pix/pix/labels{/name}","releases_url":"https://api.github.com/repos/1024pix/pix/releases{/id}","deployments_url":"https://api.github.com/repos/1024pix/pix/deployments","created_at":"2018-03-26T15:47:12Z","updated_at":"2018-11-21T12:38:48Z","pushed_at":"2018-11-22T14:31:30Z","git_url":"git://github.com/1024pix/pix.git","ssh_url":"git@github.com:1024pix/pix.git","clone_url":"https://github.com/1024pix/pix.git","svn_url":"https://github.com/1024pix/pix","homepage":"https://pix.fr","size":202705,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":5,"open_issues":7,"watchers":22,"default_branch":"dev"}},"base":{"label":"1024pix:dev","ref":"dev","sha":"fd972a10ac3761d6dcbdc4bbc1311afd1cdd9fa3","user":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"repo":{"id":126852331,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NTIzMzE=","name":"pix","full_name":"1024pix/pix","private":false,"owner":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/1024pix/pix","description":"Plateforme d'évaluation et de certification des compétences numériques à l'usage de tous les citoyens francophones.","fork":false,"url":"https://api.github.com/repos/1024pix/pix","forks_url":"https://api.github.com/repos/1024pix/pix/forks","keys_url":"https://api.github.com/repos/1024pix/pix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1024pix/pix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1024pix/pix/teams","hooks_url":"https://api.github.com/repos/1024pix/pix/hooks","issue_events_url":"https://api.github.com/repos/1024pix/pix/issues/events{/number}","events_url":"https://api.github.com/repos/1024pix/pix/events","assignees_url":"https://api.github.com/repos/1024pix/pix/assignees{/user}","branches_url":"https://api.github.com/repos/1024pix/pix/branches{/branch}","tags_url":"https://api.github.com/repos/1024pix/pix/tags","blobs_url":"https://api.github.com/repos/1024pix/pix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1024pix/pix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1024pix/pix/git/refs{/sha}","trees_url":"https://api.github.com/repos/1024pix/pix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/{sha}","languages_url":"https://api.github.com/repos/1024pix/pix/languages","stargazers_url":"https://api.github.com/repos/1024pix/pix/stargazers","contributors_url":"https://api.github.com/repos/1024pix/pix/contributors","subscribers_url":"https://api.github.com/repos/1024pix/pix/subscribers","subscription_url":"https://api.github.com/repos/1024pix/pix/subscription","commits_url":"https://api.github.com/repos/1024pix/pix/commits{/sha}","git_commits_url":"https://api.github.com/repos/1024pix/pix/git/commits{/sha}","comments_url":"https://api.github.com/repos/1024pix/pix/comments{/number}","issue_comment_url":"https://api.github.com/repos/1024pix/pix/issues/comments{/number}","contents_url":"https://api.github.com/repos/1024pix/pix/contents/{+path}","compare_url":"https://api.github.com/repos/1024pix/pix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1024pix/pix/merges","archive_url":"https://api.github.com/repos/1024pix/pix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1024pix/pix/downloads","issues_url":"https://api.github.com/repos/1024pix/pix/issues{/number}","pulls_url":"https://api.github.com/repos/1024pix/pix/pulls{/number}","milestones_url":"https://api.github.com/repos/1024pix/pix/milestones{/number}","notifications_url":"https://api.github.com/repos/1024pix/pix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1024pix/pix/labels{/name}","releases_url":"https://api.github.com/repos/1024pix/pix/releases{/id}","deployments_url":"https://api.github.com/repos/1024pix/pix/deployments","created_at":"2018-03-26T15:47:12Z","updated_at":"2018-11-21T12:38:48Z","pushed_at":"2018-11-22T14:31:30Z","git_url":"git://github.com/1024pix/pix.git","ssh_url":"git@github.com:1024pix/pix.git","clone_url":"https://github.com/1024pix/pix.git","svn_url":"https://github.com/1024pix/pix","homepage":"https://pix.fr","size":202705,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":5,"open_issues":7,"watchers":22,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/1024pix/pix/pulls/275"},"html":{"href":"https://github.com/1024pix/pix/pull/275"},"issue":{"href":"https://api.github.com/repos/1024pix/pix/issues/275"},"comments":{"href":"https://api.github.com/repos/1024pix/pix/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/1024pix/pix/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/1024pix/pix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/1024pix/pix/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/1024pix/pix/statuses/8f9695f540b4d58731aedeca558b55c047ad71ec"}},"author_association":"CONTRIBUTOR"}} | {
"id": 126852331,
"name": "1024pix/pix",
"url": "https://api.github.com/repos/1024pix/pix"
} | {
"id": 7529,
"login": "sroccaserra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7529?",
"url": "https://api.github.com/users/sroccaserra"
} | {
"id": 24589578,
"login": "1024pix",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24589578?",
"url": "https://api.github.com/orgs/1024pix"
} | 2018-11-22T15:38:09 | 8634057142 | {"actor":{"display_login":"sroccaserra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/comments/177675672","pull_request_review_id":107587292,"id":177675672,"diff_hunk":"@@ -727,6 +734,56 @@ char *ecommunity_ecom2str(struct ecommunity *ecom, int format, int filter)\n \t\t\t\t\t\t \"MM:%u\", seqnum);\n \t\t\t} else\n \t\t\t\tunk_ecom = 1;\n+\t\t} else if (type == ECOMMUNITY_ENCODE_TRANS_EXP) {\n+\t\t\tsub_type = *pnt++;\n+\n+\t\t\tif (sub_type == ECOMMUNITY_TRAFFIC_ACTION) {\n+\t\t\t\tchar action[64];\n+\t\t\t\tchar *ptr = action;\n+\n+\t\t\t\tif (*(pnt+3) ==\n+\t\t\t\t 1 << FLOWSPEC_TRAFFIC_ACTION_TERMINAL)\n+\t\t\t\t\tptr += sprintf(ptr,\n+\t\t\t\t\t\t \"terminate (apply)\");\n+\t\t\t\telse\n+\t\t\t\t\tptr += sprintf(ptr, \"eval stops\");\n+\t\t\t\tif (*(pnt+3) ==\n+\t\t\t\t 1 << FLOWSPEC_TRAFFIC_ACTION_SAMPLE)\n+\t\t\t\t\tsprintf(ptr, \", sample\");\n+\t\t\t\tlen = sprintf(str_buf + str_pnt,","path":"bgpd/bgp_ecommunity.c","position":34,"original_position":34,"commit_id":"042e4a5ad3b2302bec480b392d4e65b4f8d6a54a","original_commit_id":"042e4a5ad3b2302bec480b392d4e65b4f8d6a54a","user":{"login":"vjardin6WIND","id":8383368,"avatar_url":"https://avatars3.githubusercontent.com/u/8383368?v=4","gravatar_id":"","url":"https://api.github.com/users/vjardin6WIND","html_url":"https://github.com/vjardin6WIND","followers_url":"https://api.github.com/users/vjardin6WIND/followers","following_url":"https://api.github.com/users/vjardin6WIND/following{/other_user}","gists_url":"https://api.github.com/users/vjardin6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/vjardin6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjardin6WIND/subscriptions","organizations_url":"https://api.github.com/users/vjardin6WIND/orgs","repos_url":"https://api.github.com/users/vjardin6WIND/repos","events_url":"https://api.github.com/users/vjardin6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/vjardin6WIND/received_events","type":"User","site_admin":false},"body":"snprintf()","created_at":"2018-03-28T08:37:13Z","updated_at":"2018-03-28T08:55:30Z","html_url":"https://github.com/FRRouting/frr/pull/1817#discussion_r177675672","pull_request_url":"https://api.github.com/repos/FRRouting/frr/pulls/1817","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments/177675672"},"html":{"href":"https://github.com/FRRouting/frr/pull/1817#discussion_r177675672"},"pull_request":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1817"}}},"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/1817","id":172479200,"html_url":"https://github.com/FRRouting/frr/pull/1817","diff_url":"https://github.com/FRRouting/frr/pull/1817.diff","patch_url":"https://github.com/FRRouting/frr/pull/1817.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/1817","number":1817,"state":"open","locked":false,"title":"Flowspec client","user":{"login":"pguibert6WIND","id":16295538,"avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"body":"This set of commits introduces BGP flowspec protocol in frr.\r\nIt handles the possibility to:\r\n- activate BGP flowspec feature on vty\r\n- handle incoming BGP FS NLRI entries by storing it into BGP RIB.\r\n- display it through show bgp ipv4 flowspec [detail]\r\n- introduce [no] debug bgp flowspec for dumping incoming NLRI.\r\n\r\nThis is first set of test.\r\nothers will come.\r\nHaving FS protocol is not enough.\r\nNext step is to convert FS entries into policy route entries, so that the incoming NLRI will be configured by the underlying system.\r\n\r\nCheers,","created_at":"2018-03-02T11:19:03Z","updated_at":"2018-03-28T08:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e408f6e2141031af5bf474860adfc61417fcc2b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/1817/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/1817/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/1817/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/042e4a5ad3b2302bec480b392d4e65b4f8d6a54a","head":{"label":"pguibert6WIND:flowspec_client","ref":"flowspec_client","sha":"042e4a5ad3b2302bec480b392d4e65b4f8d6a54a","user":{"login":"pguibert6WIND","id":16295538,"avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"repo":{"id":78088116,"name":"frr","full_name":"pguibert6WIND/frr","owner":{"login":"pguibert6WIND","id":16295538,"avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pguibert6WIND/frr","description":"FRR - The FreeRangeRouting Protocol Suite forked from Quagga","fork":true,"url":"https://api.github.com/repos/pguibert6WIND/frr","forks_url":"https://api.github.com/repos/pguibert6WIND/frr/forks","keys_url":"https://api.github.com/repos/pguibert6WIND/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pguibert6WIND/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pguibert6WIND/frr/teams","hooks_url":"https://api.github.com/repos/pguibert6WIND/frr/hooks","issue_events_url":"https://api.github.com/repos/pguibert6WIND/frr/issues/events{/number}","events_url":"https://api.github.com/repos/pguibert6WIND/frr/events","assignees_url":"https://api.github.com/repos/pguibert6WIND/frr/assignees{/user}","branches_url":"https://api.github.com/repos/pguibert6WIND/frr/branches{/branch}","tags_url":"https://api.github.com/repos/pguibert6WIND/frr/tags","blobs_url":"https://api.github.com/repos/pguibert6WIND/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pguibert6WIND/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pguibert6WIND/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pguibert6WIND/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pguibert6WIND/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/pguibert6WIND/frr/languages","stargazers_url":"https://api.github.com/repos/pguibert6WIND/frr/stargazers","contributors_url":"https://api.github.com/repos/pguibert6WIND/frr/contributors","subscribers_url":"https://api.github.com/repos/pguibert6WIND/frr/subscribers","subscription_url":"https://api.github.com/repos/pguibert6WIND/frr/subscription","commits_url":"https://api.github.com/repos/pguibert6WIND/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pguibert6WIND/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pguibert6WIND/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pguibert6WIND/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pguibert6WIND/frr/contents/{+path}","compare_url":"https://api.github.com/repos/pguibert6WIND/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pguibert6WIND/frr/merges","archive_url":"https://api.github.com/repos/pguibert6WIND/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pguibert6WIND/frr/downloads","issues_url":"https://api.github.com/repos/pguibert6WIND/frr/issues{/number}","pulls_url":"https://api.github.com/repos/pguibert6WIND/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/pguibert6WIND/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/pguibert6WIND/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pguibert6WIND/frr/labels{/name}","releases_url":"https://api.github.com/repos/pguibert6WIND/frr/releases{/id}","deployments_url":"https://api.github.com/repos/pguibert6WIND/frr/deployments","created_at":"2017-01-05T06:56:15Z","updated_at":"2017-01-05T06:56:22Z","pushed_at":"2018-03-28T08:55:24Z","git_url":"git://github.com/pguibert6WIND/frr.git","ssh_url":"git@github.com:pguibert6WIND/frr.git","clone_url":"https://github.com/pguibert6WIND/frr.git","svn_url":"https://github.com/pguibert6WIND/frr","homepage":"","size":37859,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"6a32d26634c2b25489bba94694da374544978c57","user":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"name":"frr","full_name":"FRRouting/frr","owner":{"login":"FRRouting","id":24592672,"avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-03-28T06:19:32Z","pushed_at":"2018-03-27T21:59:22Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":37315,"stargazers_count":455,"watchers_count":455,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"archived":false,"open_issues_count":183,"license":null,"forks":175,"open_issues":183,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1817"},"html":{"href":"https://github.com/FRRouting/frr/pull/1817"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/1817"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/1817/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1817/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/1817/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/042e4a5ad3b2302bec480b392d4e65b4f8d6a54a"}},"author_association":"MEMBER"}} | {
"id": 76599439,
"name": "FRRouting/frr",
"url": "https://api.github.com/repos/FRRouting/frr"
} | {
"id": 8383368,
"login": "vjardin6WIND",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8383368?",
"url": "https://api.github.com/users/vjardin6WIND"
} | {
"id": 24592672,
"login": "FRRouting",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24592672?",
"url": "https://api.github.com/orgs/FRRouting"
} | 2018-03-28T08:37:13 | 7446375085 | {"actor":{"display_login":"vjardin6WIND"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gwsystems/composite/pulls/comments/173677033","pull_request_review_id":102903750,"id":173677033,"diff_hunk":"@@ -0,0 +1,118 @@\n+/*\n+ * Copyright 2018, Phani Gadepalli and Gabriel Parmer, GWU, gparmer@gwu.edu.\n+ *\n+ * This uses a two clause BSD License.\n+ */\n+\n+#include <stdio.h>\n+#include <string.h>\n+\n+#include <cos_component.h>\n+#include <cos_defkernel_api.h>\n+#include <capmgr.h>\n+#include <memmgr.h>\n+#include <hypercall.h>\n+\n+#define SPIN() \\\n+\tdo { \\\n+\t\twhile (1) \\\n+\t\t\t; \\\n+\t} while (0)\n+\n+static cycles_t cycs_per_usec;\n+\n+#define TEST_N_THDS 5\n+static thdcap_t test_ts[TEST_N_THDS] = { 0 };\n+static int thd_run_flag = 0;\n+\n+static void\n+__test_thd_fn(void *d)\n+{\n+\tthd_run_flag = (int)d;\n+\tcos_thd_switch(BOOT_CAPTBL_SELF_INITTHD_BASE);\n+}\n+\n+static void\n+test_thds(void)\n+{\n+\tint i = 0;\n+\tthdid_t tid;\n+\n+\tfor (; i < TEST_N_THDS; i++) {","path":"src/components/implementation/tests/unit_capmgr/unit_capmgr.c","position":41,"original_position":41,"commit_id":"772919b2f9c747e31f66ecfefa8da0b2215a2883","original_commit_id":"772919b2f9c747e31f66ecfefa8da0b2215a2883","user":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars1.githubusercontent.com/u/13894584?v=4","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"body":"ty","created_at":"2018-03-12T00:39:54Z","updated_at":"2018-03-12T00:39:54Z","html_url":"https://github.com/gwsystems/composite/pull/315#discussion_r173677033","pull_request_url":"https://api.github.com/repos/gwsystems/composite/pulls/315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/comments/173677033"},"html":{"href":"https://github.com/gwsystems/composite/pull/315#discussion_r173677033"},"pull_request":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/315"}},"in_reply_to_id":173638463},"pull_request":{"url":"https://api.github.com/repos/gwsystems/composite/pulls/315","id":169844516,"html_url":"https://github.com/gwsystems/composite/pull/315","diff_url":"https://github.com/gwsystems/composite/pull/315.diff","patch_url":"https://github.com/gwsystems/composite/pull/315.patch","issue_url":"https://api.github.com/repos/gwsystems/composite/issues/315","number":315,"state":"open","locked":false,"title":"Resmgr (threads, aeps, asnds, heap and shared memory) and schedmgr with fprr component","user":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars1.githubusercontent.com/u/13894584?v=4","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"body":"### Summary of this Pull Request (PR)\r\n\r\n**Resource manager (resmgr):**\r\nThis component manages all the system resources for every component loaded by llbooter in the system.\r\nResources are created at the time of a request from a component for all resources.\r\nI need a `thd_retrieve_next` iterator for PARENT component to walk-through a component's threads and get access. I'll introduce this while working on that big pending item mentioned below.\r\n\r\n* Core system resources: Threads, TCaps, Rcv-ep, Send-ep, Memory\r\n* Resource access to components: Threads, Aeps (Thd, TCap, Rcv), Send-ep, Heap and Shared memory.\r\n* Heap/Shared-memory: Allocates PAGE_SIZE * n pages\r\n* Shared-memory: ~~Almost~~ same as what @RobertGiff has for shmem.h(Referenced from his implementation obviously). ~~Only major difference is, the shared memory regions are per component that creates it and **id**s are per component too unlike the shmem.h where **id** are global IDs across all components.~~ Changed to use global identifiers!\r\n* unit test components but not full-fledged. Tests shared memory and heap well but!\r\n* Access controlled AFAIK. Components allowed to create threads if they're schedulers and/or if they're a parent to other components.\r\n\r\n**Scheduling manager:**\r\n* Interface for basic scheduling operations\r\n* FPRR implementation.\r\n* unit test component mimics `unit_fprr` test but in this case using scheduling interface! \r\n* Access controlled: Components can use this interface only if they're a child component of the component exposing this interface!\r\n\r\n**llbooter changes:**\r\n* components/include/llboot.h - exposes llbooter sinv features with API. Access controlled: Most operations are only allowed to be used by resource manager.\r\n* copying INIT capabilities to required components. (with some hack that requires me to copy SELF_CT to all scheduling components so they can `introspect` on various resources).\r\n* only creating init thread in `resmgr` and `root` scheduler. In general, for all components it is a parent to. This is again based on the component names that are name-mangled with static IDs and a protocol to identify root/resmgr/ and complete hierarchy of components!\r\n* name-mangling: explained in the llbooter.c but I may not have thought it through. It works for what I've done for both my test components and name-mangling in existing components like ping-pong test!\r\n\r\n**sl changes:**\r\n* took out allocation from sl.c : moved core scheduling operations to sl_sched.c, allocation operations to sl_resmgr.c (for components using resource manager for allocation) and to sl_rawmgr.c for components using raw resources, mainly llbooter and resource manager components!\r\n* added api to create threads in child components using `thread index` from the child component\r\n* sl_resmgr library using only id member in cos_defcompinfo (id for spdid)\r\n\r\n**cos_kernel_api:**\r\n* sinv with 3 rets API.\r\n* api exposed to init capfrontier, vasfrontier that's used mainly by resource manager component\r\n* api to create thread using `thread index`\r\n\r\n**cos_defkernel_api:**\r\n* Added api to create threads/aeps in child(ext or external) components.\r\n* Added a member to the struct : spdid so that a component can use sl_resmgr to create threads in child components.\r\n* I've some redundant or unused API there at this point I believe. \r\n* added api to create threads in child components using `thread index` from the child component\r\n\r\n**invocation stubs:** to allow 2 additional return values. This requires me to make all interfaces use this for server stubs through of course client stubs calling `_intern` api. As all the invocations use `cos_sinv_3rets`!\r\n\r\nI believe I've a cleaner implementation for taking out `system scheduler` from llbooter and for providing `llbooter library`. But more importantly some of the changes can be a duplicate work of current pending PRs from @RobertGiff and @maloneya.\r\n\r\n**BIGGEST PENDING ITEMs:** \r\n* ~~Components calling their parent components to initialize their threads in the parent scheduling domains to enable scheduling of SINV from child threads! But I wanted to get this out so I don't block some who need specific parts of my changes~~!.DONE!\r\n* Locks or a retry mechanism for creating resources: For simplicity, if we assume that the resources (other than memory) are created at the boot time and by INITTHD of a component only, then there is really no need for synchronization mechanisms in RESMGR. I've used \"atomic\" instructions for array indexes. This should be sufficient for the shared-memory that can be created on the fly as the indexes == global identifiers. Will talk about this when we meet next time. \r\n* Scheduling hierarchy using \"schedmgr\" interface! TODO\r\n\r\n### Intent for your PR\r\n\r\nChoose one (Mandatory):\r\n\r\n- [ ] This PR is for a code-review and is intended to get feedback, but not to be pulled yet.\r\n- [x] This PR is mature, and ready to be integrated into the repo.\r\n\r\n### Reviewers (Mandatory):\r\n@gparmer @RobertGiff @Others @maloneya @lab176 \r\n\r\n### Code Quality\r\n\r\nAs part of this pull request, I've considered the following:\r\n\r\n[Style](https://github.com/gparmer/composite/raw/ppos/doc/style_guide/composite_coding_style.pdf):\r\n\r\n- [x] Comments adhere to the Style Guide (SG)\r\n- [x] Spacing adhere's to the SG\r\n- [x] Naming adhere's to the SG\r\n- [x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request\r\n- [ ] I have run the auto formatter on my code before submitting this PR (see doc/auto_formatter.md for instructions)\r\n\r\n[Code Craftsmanship](http://www2.seas.gwu.edu/~gparmer/posts/2016-03-07-code-craftsmanship.html):\r\n\r\n- [x] I've made an attempt to remove all redundant code: ~~I may have some unused API in cos_defkernel_api, I need to clean that up~~. \r\n- [x] I've considered ways in which my changes might impact existing code, and cleaned it up\r\n- [x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)\r\n- [x] I've commented appropriately where code is tricky\r\n- [x] I agree that there is no \"throw-away\" code, and that code in this PR is of high quality\r\n\r\n### Testing\r\n\r\nI've tested the code using the following test programs (provide list here):\r\n- micro_booter, vkernel_booter, llbooter_test, llbooter_pong, unit_schedtest, unit_fprr <- existing tests\r\n- unit_resmgr, unit_schedcomp <- new unit tests\r\n- unit_hierschedcomps <- new test for component hierarchy \r\n","created_at":"2018-02-18T19:01:12Z","updated_at":"2018-03-12T00:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30a6c740b3dbfd7ba4e29fd0b32c45c3f533b234","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lab176","id":631197,"avatar_url":"https://avatars3.githubusercontent.com/u/631197?v=4","gravatar_id":"","url":"https://api.github.com/users/lab176","html_url":"https://github.com/lab176","followers_url":"https://api.github.com/users/lab176/followers","following_url":"https://api.github.com/users/lab176/following{/other_user}","gists_url":"https://api.github.com/users/lab176/gists{/gist_id}","starred_url":"https://api.github.com/users/lab176/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lab176/subscriptions","organizations_url":"https://api.github.com/users/lab176/orgs","repos_url":"https://api.github.com/users/lab176/repos","events_url":"https://api.github.com/users/lab176/events{/privacy}","received_events_url":"https://api.github.com/users/lab176/received_events","type":"User","site_admin":false},{"login":"RobertGiff","id":5796818,"avatar_url":"https://avatars3.githubusercontent.com/u/5796818?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertGiff","html_url":"https://github.com/RobertGiff","followers_url":"https://api.github.com/users/RobertGiff/followers","following_url":"https://api.github.com/users/RobertGiff/following{/other_user}","gists_url":"https://api.github.com/users/RobertGiff/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertGiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertGiff/subscriptions","organizations_url":"https://api.github.com/users/RobertGiff/orgs","repos_url":"https://api.github.com/users/RobertGiff/repos","events_url":"https://api.github.com/users/RobertGiff/events{/privacy}","received_events_url":"https://api.github.com/users/RobertGiff/received_events","type":"User","site_admin":false},{"login":"Others","id":6342225,"avatar_url":"https://avatars0.githubusercontent.com/u/6342225?v=4","gravatar_id":"","url":"https://api.github.com/users/Others","html_url":"https://github.com/Others","followers_url":"https://api.github.com/users/Others/followers","following_url":"https://api.github.com/users/Others/following{/other_user}","gists_url":"https://api.github.com/users/Others/gists{/gist_id}","starred_url":"https://api.github.com/users/Others/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Others/subscriptions","organizations_url":"https://api.github.com/users/Others/orgs","repos_url":"https://api.github.com/users/Others/repos","events_url":"https://api.github.com/users/Others/events{/privacy}","received_events_url":"https://api.github.com/users/Others/received_events","type":"User","site_admin":false},{"login":"maloneya","id":9469738,"avatar_url":"https://avatars0.githubusercontent.com/u/9469738?v=4","gravatar_id":"","url":"https://api.github.com/users/maloneya","html_url":"https://github.com/maloneya","followers_url":"https://api.github.com/users/maloneya/followers","following_url":"https://api.github.com/users/maloneya/following{/other_user}","gists_url":"https://api.github.com/users/maloneya/gists{/gist_id}","starred_url":"https://api.github.com/users/maloneya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maloneya/subscriptions","organizations_url":"https://api.github.com/users/maloneya/orgs","repos_url":"https://api.github.com/users/maloneya/repos","events_url":"https://api.github.com/users/maloneya/events{/privacy}","received_events_url":"https://api.github.com/users/maloneya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gwsystems/composite/pulls/315/commits","review_comments_url":"https://api.github.com/repos/gwsystems/composite/pulls/315/comments","review_comment_url":"https://api.github.com/repos/gwsystems/composite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gwsystems/composite/issues/315/comments","statuses_url":"https://api.github.com/repos/gwsystems/composite/statuses/772919b2f9c747e31f66ecfefa8da0b2215a2883","head":{"label":"phanikishoreg:resmgr","ref":"resmgr","sha":"772919b2f9c747e31f66ecfefa8da0b2215a2883","user":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars1.githubusercontent.com/u/13894584?v=4","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"repo":{"id":45254686,"name":"composite","full_name":"phanikishoreg/composite","owner":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars1.githubusercontent.com/u/13894584?v=4","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phanikishoreg/composite","description":"A component-based OS","fork":true,"url":"https://api.github.com/repos/phanikishoreg/composite","forks_url":"https://api.github.com/repos/phanikishoreg/composite/forks","keys_url":"https://api.github.com/repos/phanikishoreg/composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phanikishoreg/composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phanikishoreg/composite/teams","hooks_url":"https://api.github.com/repos/phanikishoreg/composite/hooks","issue_events_url":"https://api.github.com/repos/phanikishoreg/composite/issues/events{/number}","events_url":"https://api.github.com/repos/phanikishoreg/composite/events","assignees_url":"https://api.github.com/repos/phanikishoreg/composite/assignees{/user}","branches_url":"https://api.github.com/repos/phanikishoreg/composite/branches{/branch}","tags_url":"https://api.github.com/repos/phanikishoreg/composite/tags","blobs_url":"https://api.github.com/repos/phanikishoreg/composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phanikishoreg/composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phanikishoreg/composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/phanikishoreg/composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phanikishoreg/composite/statuses/{sha}","languages_url":"https://api.github.com/repos/phanikishoreg/composite/languages","stargazers_url":"https://api.github.com/repos/phanikishoreg/composite/stargazers","contributors_url":"https://api.github.com/repos/phanikishoreg/composite/contributors","subscribers_url":"https://api.github.com/repos/phanikishoreg/composite/subscribers","subscription_url":"https://api.github.com/repos/phanikishoreg/composite/subscription","commits_url":"https://api.github.com/repos/phanikishoreg/composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/phanikishoreg/composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/phanikishoreg/composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/phanikishoreg/composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/phanikishoreg/composite/contents/{+path}","compare_url":"https://api.github.com/repos/phanikishoreg/composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phanikishoreg/composite/merges","archive_url":"https://api.github.com/repos/phanikishoreg/composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phanikishoreg/composite/downloads","issues_url":"https://api.github.com/repos/phanikishoreg/composite/issues{/number}","pulls_url":"https://api.github.com/repos/phanikishoreg/composite/pulls{/number}","milestones_url":"https://api.github.com/repos/phanikishoreg/composite/milestones{/number}","notifications_url":"https://api.github.com/repos/phanikishoreg/composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phanikishoreg/composite/labels{/name}","releases_url":"https://api.github.com/repos/phanikishoreg/composite/releases{/id}","deployments_url":"https://api.github.com/repos/phanikishoreg/composite/deployments","created_at":"2015-10-30T14:08:49Z","updated_at":"2017-08-07T19:07:02Z","pushed_at":"2018-03-09T23:50:39Z","git_url":"git://github.com/phanikishoreg/composite.git","ssh_url":"git@github.com:phanikishoreg/composite.git","clone_url":"https://github.com/phanikishoreg/composite.git","svn_url":"https://github.com/phanikishoreg/composite","homepage":"composite.seas.gwu.edu","size":22670,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ppos"}},"base":{"label":"gwsystems:ppos","ref":"ppos","sha":"be12a18ae2d45391e7afc413dea7a6e0c8ed6bd0","user":{"login":"gwsystems","id":24600102,"avatar_url":"https://avatars2.githubusercontent.com/u/24600102?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsystems","html_url":"https://github.com/gwsystems","followers_url":"https://api.github.com/users/gwsystems/followers","following_url":"https://api.github.com/users/gwsystems/following{/other_user}","gists_url":"https://api.github.com/users/gwsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsystems/subscriptions","organizations_url":"https://api.github.com/users/gwsystems/orgs","repos_url":"https://api.github.com/users/gwsystems/repos","events_url":"https://api.github.com/users/gwsystems/events{/privacy}","received_events_url":"https://api.github.com/users/gwsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":3140667,"name":"composite","full_name":"gwsystems/composite","owner":{"login":"gwsystems","id":24600102,"avatar_url":"https://avatars2.githubusercontent.com/u/24600102?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsystems","html_url":"https://github.com/gwsystems","followers_url":"https://api.github.com/users/gwsystems/followers","following_url":"https://api.github.com/users/gwsystems/following{/other_user}","gists_url":"https://api.github.com/users/gwsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsystems/subscriptions","organizations_url":"https://api.github.com/users/gwsystems/orgs","repos_url":"https://api.github.com/users/gwsystems/repos","events_url":"https://api.github.com/users/gwsystems/events{/privacy}","received_events_url":"https://api.github.com/users/gwsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gwsystems/composite","description":"A component-based OS","fork":false,"url":"https://api.github.com/repos/gwsystems/composite","forks_url":"https://api.github.com/repos/gwsystems/composite/forks","keys_url":"https://api.github.com/repos/gwsystems/composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwsystems/composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwsystems/composite/teams","hooks_url":"https://api.github.com/repos/gwsystems/composite/hooks","issue_events_url":"https://api.github.com/repos/gwsystems/composite/issues/events{/number}","events_url":"https://api.github.com/repos/gwsystems/composite/events","assignees_url":"https://api.github.com/repos/gwsystems/composite/assignees{/user}","branches_url":"https://api.github.com/repos/gwsystems/composite/branches{/branch}","tags_url":"https://api.github.com/repos/gwsystems/composite/tags","blobs_url":"https://api.github.com/repos/gwsystems/composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwsystems/composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwsystems/composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwsystems/composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwsystems/composite/statuses/{sha}","languages_url":"https://api.github.com/repos/gwsystems/composite/languages","stargazers_url":"https://api.github.com/repos/gwsystems/composite/stargazers","contributors_url":"https://api.github.com/repos/gwsystems/composite/contributors","subscribers_url":"https://api.github.com/repos/gwsystems/composite/subscribers","subscription_url":"https://api.github.com/repos/gwsystems/composite/subscription","commits_url":"https://api.github.com/repos/gwsystems/composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwsystems/composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwsystems/composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwsystems/composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwsystems/composite/contents/{+path}","compare_url":"https://api.github.com/repos/gwsystems/composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwsystems/composite/merges","archive_url":"https://api.github.com/repos/gwsystems/composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwsystems/composite/downloads","issues_url":"https://api.github.com/repos/gwsystems/composite/issues{/number}","pulls_url":"https://api.github.com/repos/gwsystems/composite/pulls{/number}","milestones_url":"https://api.github.com/repos/gwsystems/composite/milestones{/number}","notifications_url":"https://api.github.com/repos/gwsystems/composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwsystems/composite/labels{/name}","releases_url":"https://api.github.com/repos/gwsystems/composite/releases{/id}","deployments_url":"https://api.github.com/repos/gwsystems/composite/deployments","created_at":"2012-01-09T22:20:27Z","updated_at":"2018-03-07T21:12:23Z","pushed_at":"2018-03-10T19:48:30Z","git_url":"git://github.com/gwsystems/composite.git","ssh_url":"git@github.com:gwsystems/composite.git","clone_url":"https://github.com/gwsystems/composite.git","svn_url":"https://github.com/gwsystems/composite","homepage":"composite.seas.gwu.edu","size":25596,"stargazers_count":61,"watchers_count":61,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":69,"license":null,"forks":40,"open_issues":69,"watchers":61,"default_branch":"ppos"}},"_links":{"self":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/315"},"html":{"href":"https://github.com/gwsystems/composite/pull/315"},"issue":{"href":"https://api.github.com/repos/gwsystems/composite/issues/315"},"comments":{"href":"https://api.github.com/repos/gwsystems/composite/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gwsystems/composite/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/gwsystems/composite/statuses/772919b2f9c747e31f66ecfefa8da0b2215a2883"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3140667,
"name": "gwsystems/composite",
"url": "https://api.github.com/repos/gwsystems/composite"
} | {
"id": 13894584,
"login": "phanikishoreg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13894584?",
"url": "https://api.github.com/users/phanikishoreg"
} | {
"id": 24600102,
"login": "gwsystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24600102?",
"url": "https://api.github.com/orgs/gwsystems"
} | 2018-03-12T00:39:54 | 7363046953 | {"actor":{"display_login":"phanikishoreg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/comments/222064654","pull_request_review_id":160864132,"id":222064654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA2NDY1NA==","diff_hunk":"@@ -164,11 +165,10 @@\n }\n # Some zone_keys are part of bidding zone domains for price data\n ENTSOE_PRICE_DOMAIN_OVERRIDE = {\n- 'AT': ENTSOE_DOMAIN_MAPPINGS['DE-AT-LU'],","path":"parsers/ENTSOE.py","position":12,"original_position":12,"commit_id":"0df4f59cec8f58caff03042aa7842a0a9ee5afaf","original_commit_id":"0df4f59cec8f58caff03042aa7842a0a9ee5afaf","user":{"login":"alixunderplatz","id":25743609,"node_id":"MDQ6VXNlcjI1NzQzNjA5","avatar_url":"https://avatars0.githubusercontent.com/u/25743609?v=4","gravatar_id":"","url":"https://api.github.com/users/alixunderplatz","html_url":"https://github.com/alixunderplatz","followers_url":"https://api.github.com/users/alixunderplatz/followers","following_url":"https://api.github.com/users/alixunderplatz/following{/other_user}","gists_url":"https://api.github.com/users/alixunderplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/alixunderplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alixunderplatz/subscriptions","organizations_url":"https://api.github.com/users/alixunderplatz/orgs","repos_url":"https://api.github.com/users/alixunderplatz/repos","events_url":"https://api.github.com/users/alixunderplatz/events{/privacy}","received_events_url":"https://api.github.com/users/alixunderplatz/received_events","type":"User","site_admin":false},"body":"'CTY|10YAT-APG------L' should be the correct ENTSO-E code for the bidding zone","created_at":"2018-10-02T18:34:22Z","updated_at":"2018-10-02T18:34:22Z","html_url":"https://github.com/tmrowco/electricitymap-contrib/pull/1619#discussion_r222064654","pull_request_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/comments/222064654"},"html":{"href":"https://github.com/tmrowco/electricitymap-contrib/pull/1619#discussion_r222064654"},"pull_request":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619"}},"in_reply_to_id":222055060},"pull_request":{"url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619","id":219770833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzcwODMz","html_url":"https://github.com/tmrowco/electricitymap-contrib/pull/1619","diff_url":"https://github.com/tmrowco/electricitymap-contrib/pull/1619.diff","patch_url":"https://github.com/tmrowco/electricitymap-contrib/pull/1619.patch","issue_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/1619","number":1619,"state":"open","locked":false,"title":"Update AT, DE, LU price areas","user":{"login":"lorrieq","id":6525086,"node_id":"MDQ6VXNlcjY1MjUwODY=","avatar_url":"https://avatars3.githubusercontent.com/u/6525086?v=4","gravatar_id":"","url":"https://api.github.com/users/lorrieq","html_url":"https://github.com/lorrieq","followers_url":"https://api.github.com/users/lorrieq/followers","following_url":"https://api.github.com/users/lorrieq/following{/other_user}","gists_url":"https://api.github.com/users/lorrieq/gists{/gist_id}","starred_url":"https://api.github.com/users/lorrieq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorrieq/subscriptions","organizations_url":"https://api.github.com/users/lorrieq/orgs","repos_url":"https://api.github.com/users/lorrieq/repos","events_url":"https://api.github.com/users/lorrieq/events{/privacy}","received_events_url":"https://api.github.com/users/lorrieq/received_events","type":"User","site_admin":false},"body":"closes #1605 ","created_at":"2018-10-02T16:40:47Z","updated_at":"2018-10-02T18:34:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfbff263be86c14a3fedee59fd2e6fc06c43e149","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619/commits","review_comments_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619/comments","review_comment_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/1619/comments","statuses_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/statuses/0df4f59cec8f58caff03042aa7842a0a9ee5afaf","head":{"label":"lorrieq:de_at_lu_split","ref":"de_at_lu_split","sha":"0df4f59cec8f58caff03042aa7842a0a9ee5afaf","user":{"login":"lorrieq","id":6525086,"node_id":"MDQ6VXNlcjY1MjUwODY=","avatar_url":"https://avatars3.githubusercontent.com/u/6525086?v=4","gravatar_id":"","url":"https://api.github.com/users/lorrieq","html_url":"https://github.com/lorrieq","followers_url":"https://api.github.com/users/lorrieq/followers","following_url":"https://api.github.com/users/lorrieq/following{/other_user}","gists_url":"https://api.github.com/users/lorrieq/gists{/gist_id}","starred_url":"https://api.github.com/users/lorrieq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorrieq/subscriptions","organizations_url":"https://api.github.com/users/lorrieq/orgs","repos_url":"https://api.github.com/users/lorrieq/repos","events_url":"https://api.github.com/users/lorrieq/events{/privacy}","received_events_url":"https://api.github.com/users/lorrieq/received_events","type":"User","site_admin":false},"repo":{"id":125272723,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNzI3MjM=","name":"electricitymap","full_name":"lorrieq/electricitymap","private":false,"owner":{"login":"lorrieq","id":6525086,"node_id":"MDQ6VXNlcjY1MjUwODY=","avatar_url":"https://avatars3.githubusercontent.com/u/6525086?v=4","gravatar_id":"","url":"https://api.github.com/users/lorrieq","html_url":"https://github.com/lorrieq","followers_url":"https://api.github.com/users/lorrieq/followers","following_url":"https://api.github.com/users/lorrieq/following{/other_user}","gists_url":"https://api.github.com/users/lorrieq/gists{/gist_id}","starred_url":"https://api.github.com/users/lorrieq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorrieq/subscriptions","organizations_url":"https://api.github.com/users/lorrieq/orgs","repos_url":"https://api.github.com/users/lorrieq/repos","events_url":"https://api.github.com/users/lorrieq/events{/privacy}","received_events_url":"https://api.github.com/users/lorrieq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lorrieq/electricitymap","description":"A real-time visualisation of the CO2 emissions of electricity consumption","fork":true,"url":"https://api.github.com/repos/lorrieq/electricitymap","forks_url":"https://api.github.com/repos/lorrieq/electricitymap/forks","keys_url":"https://api.github.com/repos/lorrieq/electricitymap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorrieq/electricitymap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorrieq/electricitymap/teams","hooks_url":"https://api.github.com/repos/lorrieq/electricitymap/hooks","issue_events_url":"https://api.github.com/repos/lorrieq/electricitymap/issues/events{/number}","events_url":"https://api.github.com/repos/lorrieq/electricitymap/events","assignees_url":"https://api.github.com/repos/lorrieq/electricitymap/assignees{/user}","branches_url":"https://api.github.com/repos/lorrieq/electricitymap/branches{/branch}","tags_url":"https://api.github.com/repos/lorrieq/electricitymap/tags","blobs_url":"https://api.github.com/repos/lorrieq/electricitymap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorrieq/electricitymap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorrieq/electricitymap/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorrieq/electricitymap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorrieq/electricitymap/statuses/{sha}","languages_url":"https://api.github.com/repos/lorrieq/electricitymap/languages","stargazers_url":"https://api.github.com/repos/lorrieq/electricitymap/stargazers","contributors_url":"https://api.github.com/repos/lorrieq/electricitymap/contributors","subscribers_url":"https://api.github.com/repos/lorrieq/electricitymap/subscribers","subscription_url":"https://api.github.com/repos/lorrieq/electricitymap/subscription","commits_url":"https://api.github.com/repos/lorrieq/electricitymap/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorrieq/electricitymap/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorrieq/electricitymap/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorrieq/electricitymap/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorrieq/electricitymap/contents/{+path}","compare_url":"https://api.github.com/repos/lorrieq/electricitymap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorrieq/electricitymap/merges","archive_url":"https://api.github.com/repos/lorrieq/electricitymap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorrieq/electricitymap/downloads","issues_url":"https://api.github.com/repos/lorrieq/electricitymap/issues{/number}","pulls_url":"https://api.github.com/repos/lorrieq/electricitymap/pulls{/number}","milestones_url":"https://api.github.com/repos/lorrieq/electricitymap/milestones{/number}","notifications_url":"https://api.github.com/repos/lorrieq/electricitymap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorrieq/electricitymap/labels{/name}","releases_url":"https://api.github.com/repos/lorrieq/electricitymap/releases{/id}","deployments_url":"https://api.github.com/repos/lorrieq/electricitymap/deployments","created_at":"2018-03-14T20:57:57Z","updated_at":"2018-10-02T16:28:20Z","pushed_at":"2018-10-02T16:40:08Z","git_url":"git://github.com/lorrieq/electricitymap.git","ssh_url":"git@github.com:lorrieq/electricitymap.git","clone_url":"https://github.com/lorrieq/electricitymap.git","svn_url":"https://github.com/lorrieq/electricitymap","homepage":"http://www.electricitymap.org","size":39265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmrowco:master","ref":"master","sha":"c04285d36352ac80e2ca155a8337a1216092eae3","user":{"login":"tmrowco","id":24733017,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzMzMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/24733017?v=4","gravatar_id":"","url":"https://api.github.com/users/tmrowco","html_url":"https://github.com/tmrowco","followers_url":"https://api.github.com/users/tmrowco/followers","following_url":"https://api.github.com/users/tmrowco/following{/other_user}","gists_url":"https://api.github.com/users/tmrowco/gists{/gist_id}","starred_url":"https://api.github.com/users/tmrowco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmrowco/subscriptions","organizations_url":"https://api.github.com/users/tmrowco/orgs","repos_url":"https://api.github.com/users/tmrowco/repos","events_url":"https://api.github.com/users/tmrowco/events{/privacy}","received_events_url":"https://api.github.com/users/tmrowco/received_events","type":"Organization","site_admin":false},"repo":{"id":59370571,"node_id":"MDEwOlJlcG9zaXRvcnk1OTM3MDU3MQ==","name":"electricitymap-contrib","full_name":"tmrowco/electricitymap-contrib","private":false,"owner":{"login":"tmrowco","id":24733017,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NzMzMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/24733017?v=4","gravatar_id":"","url":"https://api.github.com/users/tmrowco","html_url":"https://github.com/tmrowco","followers_url":"https://api.github.com/users/tmrowco/followers","following_url":"https://api.github.com/users/tmrowco/following{/other_user}","gists_url":"https://api.github.com/users/tmrowco/gists{/gist_id}","starred_url":"https://api.github.com/users/tmrowco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmrowco/subscriptions","organizations_url":"https://api.github.com/users/tmrowco/orgs","repos_url":"https://api.github.com/users/tmrowco/repos","events_url":"https://api.github.com/users/tmrowco/events{/privacy}","received_events_url":"https://api.github.com/users/tmrowco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tmrowco/electricitymap-contrib","description":"A real-time visualisation of the CO2 emissions of electricity consumption","fork":false,"url":"https://api.github.com/repos/tmrowco/electricitymap-contrib","forks_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/forks","keys_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/teams","hooks_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/hooks","issue_events_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/events","assignees_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/tags","blobs_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/languages","stargazers_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/stargazers","contributors_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/contributors","subscribers_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/subscribers","subscription_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/subscription","commits_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/merges","archive_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/downloads","issues_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/labels{/name}","releases_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/tmrowco/electricitymap-contrib/deployments","created_at":"2016-05-21T16:36:17Z","updated_at":"2018-10-01T13:17:58Z","pushed_at":"2018-10-02T16:40:48Z","git_url":"git://github.com/tmrowco/electricitymap-contrib.git","ssh_url":"git@github.com:tmrowco/electricitymap-contrib.git","clone_url":"https://github.com/tmrowco/electricitymap-contrib.git","svn_url":"https://github.com/tmrowco/electricitymap-contrib","homepage":"https://www.electricitymap.org","size":39099,"stargazers_count":660,"watchers_count":660,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":166,"open_issues":83,"watchers":660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619"},"html":{"href":"https://github.com/tmrowco/electricitymap-contrib/pull/1619"},"issue":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/1619"},"comments":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/issues/1619/comments"},"review_comments":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619/comments"},"review_comment":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/pulls/1619/commits"},"statuses":{"href":"https://api.github.com/repos/tmrowco/electricitymap-contrib/statuses/0df4f59cec8f58caff03042aa7842a0a9ee5afaf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 59370571,
"name": "tmrowco/electricitymap-contrib",
"url": "https://api.github.com/repos/tmrowco/electricitymap-contrib"
} | {
"id": 25743609,
"login": "alixunderplatz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25743609?",
"url": "https://api.github.com/users/alixunderplatz"
} | {
"id": 24733017,
"login": "tmrowco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24733017?",
"url": "https://api.github.com/orgs/tmrowco"
} | 2018-10-02T18:34:22 | 8356467187 | {"actor":{"display_login":"alixunderplatz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/teambit/bit/pulls/comments/165838459","pull_request_review_id":93839709,"id":165838459,"diff_hunk":"@@ -68,7 +75,7 @@ export default class BitMap {\n logger.info(`bit.map: unable to find an existing ${BIT_MAP} file. Will probably create a new one if needed`);\n }\n \n- return new BitMap(dirPath, mapPath, components, version);\n+ return new BitMap(dirPath, mapPath, components, version || BIT_VERSION);","path":"src/consumer/bit-map/bit-map.js","position":28,"original_position":28,"commit_id":"05883f2d2548e092fadb26927e4e2700f965c6e2","original_commit_id":"05883f2d2548e092fadb26927e4e2700f965c6e2","user":{"login":"GiladShoham","id":3840769,"avatar_url":"https://avatars0.githubusercontent.com/u/3840769?v=4","gravatar_id":"","url":"https://api.github.com/users/GiladShoham","html_url":"https://github.com/GiladShoham","followers_url":"https://api.github.com/users/GiladShoham/followers","following_url":"https://api.github.com/users/GiladShoham/following{/other_user}","gists_url":"https://api.github.com/users/GiladShoham/gists{/gist_id}","starred_url":"https://api.github.com/users/GiladShoham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiladShoham/subscriptions","organizations_url":"https://api.github.com/users/GiladShoham/orgs","repos_url":"https://api.github.com/users/GiladShoham/repos","events_url":"https://api.github.com/users/GiladShoham/events{/privacy}","received_events_url":"https://api.github.com/users/GiladShoham/received_events","type":"User","site_admin":false},"body":"remove the else in the condition above.\r\nput the return also inside the fs.existsSync(mapPath), and inside the id use the return without the || BIT_VERSION, in order to make sure migration will run for old bitmaps","created_at":"2018-02-04T09:30:29Z","updated_at":"2018-02-04T09:33:04Z","html_url":"https://github.com/teambit/bit/pull/700#discussion_r165838459","pull_request_url":"https://api.github.com/repos/teambit/bit/pulls/700","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/teambit/bit/pulls/comments/165838459"},"html":{"href":"https://github.com/teambit/bit/pull/700#discussion_r165838459"},"pull_request":{"href":"https://api.github.com/repos/teambit/bit/pulls/700"}}},"pull_request":{"url":"https://api.github.com/repos/teambit/bit/pulls/700","id":166546703,"html_url":"https://github.com/teambit/bit/pull/700","diff_url":"https://github.com/teambit/bit/pull/700.diff","patch_url":"https://github.com/teambit/bit/pull/700.patch","issue_url":"https://api.github.com/repos/teambit/bit/issues/700","number":700,"state":"open","locked":false,"title":"Feature/create bitmap on bit init","user":{"login":"amitgilad3","id":7702311,"avatar_url":"https://avatars0.githubusercontent.com/u/7702311?v=4","gravatar_id":"","url":"https://api.github.com/users/amitgilad3","html_url":"https://github.com/amitgilad3","followers_url":"https://api.github.com/users/amitgilad3/followers","following_url":"https://api.github.com/users/amitgilad3/following{/other_user}","gists_url":"https://api.github.com/users/amitgilad3/gists{/gist_id}","starred_url":"https://api.github.com/users/amitgilad3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitgilad3/subscriptions","organizations_url":"https://api.github.com/users/amitgilad3/orgs","repos_url":"https://api.github.com/users/amitgilad3/repos","events_url":"https://api.github.com/users/amitgilad3/events{/privacy}","received_events_url":"https://api.github.com/users/amitgilad3/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\n\r\n -\r\n -\r\n -\r\n","created_at":"2018-02-01T14:08:41Z","updated_at":"2018-02-04T09:33:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d2e53d522f6609f3136c46eed0d539942b37de1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/teambit/bit/pulls/700/commits","review_comments_url":"https://api.github.com/repos/teambit/bit/pulls/700/comments","review_comment_url":"https://api.github.com/repos/teambit/bit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teambit/bit/issues/700/comments","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/05883f2d2548e092fadb26927e4e2700f965c6e2","head":{"label":"teambit:feature/create-bitmap-on-bit-init","ref":"feature/create-bitmap-on-bit-init","sha":"05883f2d2548e092fadb26927e4e2700f965c6e2","user":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"repo":{"id":79723839,"name":"bit","full_name":"teambit/bit","owner":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teambit/bit","description":"Easily share code components between projects with your team.","fork":false,"url":"https://api.github.com/repos/teambit/bit","forks_url":"https://api.github.com/repos/teambit/bit/forks","keys_url":"https://api.github.com/repos/teambit/bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teambit/bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teambit/bit/teams","hooks_url":"https://api.github.com/repos/teambit/bit/hooks","issue_events_url":"https://api.github.com/repos/teambit/bit/issues/events{/number}","events_url":"https://api.github.com/repos/teambit/bit/events","assignees_url":"https://api.github.com/repos/teambit/bit/assignees{/user}","branches_url":"https://api.github.com/repos/teambit/bit/branches{/branch}","tags_url":"https://api.github.com/repos/teambit/bit/tags","blobs_url":"https://api.github.com/repos/teambit/bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teambit/bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teambit/bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/teambit/bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/{sha}","languages_url":"https://api.github.com/repos/teambit/bit/languages","stargazers_url":"https://api.github.com/repos/teambit/bit/stargazers","contributors_url":"https://api.github.com/repos/teambit/bit/contributors","subscribers_url":"https://api.github.com/repos/teambit/bit/subscribers","subscription_url":"https://api.github.com/repos/teambit/bit/subscription","commits_url":"https://api.github.com/repos/teambit/bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/teambit/bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/teambit/bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/teambit/bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/teambit/bit/contents/{+path}","compare_url":"https://api.github.com/repos/teambit/bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teambit/bit/merges","archive_url":"https://api.github.com/repos/teambit/bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teambit/bit/downloads","issues_url":"https://api.github.com/repos/teambit/bit/issues{/number}","pulls_url":"https://api.github.com/repos/teambit/bit/pulls{/number}","milestones_url":"https://api.github.com/repos/teambit/bit/milestones{/number}","notifications_url":"https://api.github.com/repos/teambit/bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teambit/bit/labels{/name}","releases_url":"https://api.github.com/repos/teambit/bit/releases{/id}","deployments_url":"https://api.github.com/repos/teambit/bit/deployments","created_at":"2017-01-22T14:51:43Z","updated_at":"2018-02-02T21:28:48Z","pushed_at":"2018-02-04T09:14:55Z","git_url":"git://github.com/teambit/bit.git","ssh_url":"git@github.com:teambit/bit.git","clone_url":"https://github.com/teambit/bit.git","svn_url":"https://github.com/teambit/bit","homepage":"https://bitsrc.io","size":35571,"stargazers_count":937,"watchers_count":937,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":57,"watchers":937,"default_branch":"master"}},"base":{"label":"teambit:master","ref":"master","sha":"3516771e3bf834907e4c6f6b0b2602b85a9bf473","user":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"repo":{"id":79723839,"name":"bit","full_name":"teambit/bit","owner":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teambit/bit","description":"Easily share code components between projects with your team.","fork":false,"url":"https://api.github.com/repos/teambit/bit","forks_url":"https://api.github.com/repos/teambit/bit/forks","keys_url":"https://api.github.com/repos/teambit/bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teambit/bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teambit/bit/teams","hooks_url":"https://api.github.com/repos/teambit/bit/hooks","issue_events_url":"https://api.github.com/repos/teambit/bit/issues/events{/number}","events_url":"https://api.github.com/repos/teambit/bit/events","assignees_url":"https://api.github.com/repos/teambit/bit/assignees{/user}","branches_url":"https://api.github.com/repos/teambit/bit/branches{/branch}","tags_url":"https://api.github.com/repos/teambit/bit/tags","blobs_url":"https://api.github.com/repos/teambit/bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teambit/bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teambit/bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/teambit/bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/{sha}","languages_url":"https://api.github.com/repos/teambit/bit/languages","stargazers_url":"https://api.github.com/repos/teambit/bit/stargazers","contributors_url":"https://api.github.com/repos/teambit/bit/contributors","subscribers_url":"https://api.github.com/repos/teambit/bit/subscribers","subscription_url":"https://api.github.com/repos/teambit/bit/subscription","commits_url":"https://api.github.com/repos/teambit/bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/teambit/bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/teambit/bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/teambit/bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/teambit/bit/contents/{+path}","compare_url":"https://api.github.com/repos/teambit/bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teambit/bit/merges","archive_url":"https://api.github.com/repos/teambit/bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teambit/bit/downloads","issues_url":"https://api.github.com/repos/teambit/bit/issues{/number}","pulls_url":"https://api.github.com/repos/teambit/bit/pulls{/number}","milestones_url":"https://api.github.com/repos/teambit/bit/milestones{/number}","notifications_url":"https://api.github.com/repos/teambit/bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teambit/bit/labels{/name}","releases_url":"https://api.github.com/repos/teambit/bit/releases{/id}","deployments_url":"https://api.github.com/repos/teambit/bit/deployments","created_at":"2017-01-22T14:51:43Z","updated_at":"2018-02-02T21:28:48Z","pushed_at":"2018-02-04T09:14:55Z","git_url":"git://github.com/teambit/bit.git","ssh_url":"git@github.com:teambit/bit.git","clone_url":"https://github.com/teambit/bit.git","svn_url":"https://github.com/teambit/bit","homepage":"https://bitsrc.io","size":35571,"stargazers_count":937,"watchers_count":937,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":57,"watchers":937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teambit/bit/pulls/700"},"html":{"href":"https://github.com/teambit/bit/pull/700"},"issue":{"href":"https://api.github.com/repos/teambit/bit/issues/700"},"comments":{"href":"https://api.github.com/repos/teambit/bit/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/teambit/bit/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/teambit/bit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teambit/bit/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/teambit/bit/statuses/05883f2d2548e092fadb26927e4e2700f965c6e2"}},"author_association":"OWNER"}} | {
"id": 79723839,
"name": "teambit/bit",
"url": "https://api.github.com/repos/teambit/bit"
} | {
"id": 3840769,
"login": "GiladShoham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3840769?",
"url": "https://api.github.com/users/GiladShoham"
} | {
"id": 24789812,
"login": "teambit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24789812?",
"url": "https://api.github.com/orgs/teambit"
} | 2018-02-04T09:30:29 | 7194760924 | {"actor":{"display_login":"GiladShoham"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/233748654","pull_request_review_id":175234492,"id":233748654,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzc0ODY1NA==","diff_hunk":"@@ -0,0 +1,80 @@\n+// | / |\n+// ' / __| _` | __| _ \\ __|\n+// . \\ | ( | | ( |\\__ `\n+// _|\\_\\_| \\__,_|\\__|\\___/ ____/\n+// Multi-Physics\n+//\n+// License: BSD License\n+// Kratos default license: kratos/license.txt\n+//\n+// Main author: Jordi Cotela\n+//\n+\n+#ifndef KRATOS_MODEL_PART_COMMUNICATOR_UTILITIES_H_INCLUDED\n+#define\tKRATOS_MODEL_PART_COMMUNICATOR_UTILITIES_H_INCLUDED\n+\n+// System includes\n+\n+// External includes\n+\n+// Project includes\n+#include \"includes/define.h\"\n+#include \"includes/model_part.h\"\n+#include \"mpi/includes/mpi_communicator.h\"\n+\n+namespace Kratos\n+{\n+\n+///@addtogroup MPICore\n+///@{\n+\n+///@name Kratos Classes\n+///@{\n+\n+/// Utilitiy class for ModelPart::Comunicator management in an MPI context.\n+class ModelPartCommunicatorUtilities","path":"kratos/mpi/utilities/model_part_communicator_utilities.h","position":35,"original_position":35,"commit_id":"9bc8925f79c918997164e7ae9e1a5fe45a6a8d83","original_commit_id":"78f41fb4833f7c412968ae744cb89bf8c505c777","user":{"login":"jcotela","id":5071546,"node_id":"MDQ6VXNlcjUwNzE1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},"body":"I agree, but I kept the class structure to export it to python using our standard approach. I am not sure about how we should name the pybind wrapper for a method on a namespace.","created_at":"2018-11-15T08:29:09Z","updated_at":"2018-11-15T08:29:10Z","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/3340#discussion_r233748654","pull_request_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/233748654"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/3340#discussion_r233748654"},"pull_request":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340"}},"in_reply_to_id":233542371},"pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340","id":230197280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTk3Mjgw","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/3340","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/3340.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/3340.patch","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3340","number":3340,"state":"open","locked":false,"title":"First version of new Kratos MPI Core library","user":{"login":"jcotela","id":5071546,"node_id":"MDQ6VXNlcjUwNzE1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},"body":"Following #781, this is the first step to introduce a layer between Kratos and MPI, which should make it easier to develop MPI-compatible code. In this way:\r\n- The MPI interface is centralized in the new library, so 90% of code should not need to link directly to the mpi libraries.\r\n- All calls done using the MPI Core wrappers should have equivalent do-nothing methods for serial runs, making it simpler to write MPI-compatible code.\r\n\r\nThis PR is the first step in this direction, adding the basic KratosMPICore library and a DataCommunicator object, which is a wrapper for `MPI` calls. Specifically:\r\n- The `KratosMPICore` library is added, which can be imported with `from KratosMultiphysics import mpi`.\r\n- A `DataCommunicator` object is added to the `KratosCore`, providing the interface for MPI calls.\r\n- A `MPIDataCommunicator` is implemented in the new MPI core, with the actual MPI calls.\r\n- A `ParallelEnvironment` singleton is created in the kratos core, which essentially contains a register for created `DataCommunicator` objects (this provides the potential to support communicators other than `MPI_COMM_WORLD` in the future, but no interface to create new communicators has been added yet).\r\n- The current `mpi` module for python has been re-routed to be imported together with the new KratosMPICore (essentially, I have hijacked its module name, so I had to keep importing it for backwards compatibility).\r\n- The `MPICommunicator` has been moved from the Trilinos application to the new KratosMPICore.\r\n- The `SetMPICommunicatorProcess` in the Metis application has been deprecated and a new function with equivalent functionality has been added to the MPI core (`ModelPartCommunicatorUtilities::SetMPICommunicator`).\r\n\r\nThis PR uses the recommended pybind11mechanism to call functions in module unload, which will hopefully avoid problems as #77 in the future.\r\n\r\nThis PR is not for immediate merge, suggestions are welcome. I have requested review from people I know are regular MPI users, but feel free to contribute your ideas if you have some.","created_at":"2018-11-12T16:37:50Z","updated_at":"2018-11-15T08:29:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8667f0e31e688b75f6567e4a8bdefe8237bdf35c","assignee":{"login":"jcotela","id":5071546,"node_id":"MDQ6VXNlcjUwNzE1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcotela","id":5071546,"node_id":"MDQ6VXNlcjUwNzE1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"roigcarlo","id":1935791,"node_id":"MDQ6VXNlcjE5MzU3OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1935791?v=4","gravatar_id":"","url":"https://api.github.com/users/roigcarlo","html_url":"https://github.com/roigcarlo","followers_url":"https://api.github.com/users/roigcarlo/followers","following_url":"https://api.github.com/users/roigcarlo/following{/other_user}","gists_url":"https://api.github.com/users/roigcarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/roigcarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roigcarlo/subscriptions","organizations_url":"https://api.github.com/users/roigcarlo/orgs","repos_url":"https://api.github.com/users/roigcarlo/repos","events_url":"https://api.github.com/users/roigcarlo/events{/privacy}","received_events_url":"https://api.github.com/users/roigcarlo/received_events","type":"User","site_admin":false},{"login":"adityaghantasala","id":2531316,"node_id":"MDQ6VXNlcjI1MzEzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2531316?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaghantasala","html_url":"https://github.com/adityaghantasala","followers_url":"https://api.github.com/users/adityaghantasala/followers","following_url":"https://api.github.com/users/adityaghantasala/following{/other_user}","gists_url":"https://api.github.com/users/adityaghantasala/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaghantasala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaghantasala/subscriptions","organizations_url":"https://api.github.com/users/adityaghantasala/orgs","repos_url":"https://api.github.com/users/adityaghantasala/repos","events_url":"https://api.github.com/users/adityaghantasala/events{/privacy}","received_events_url":"https://api.github.com/users/adityaghantasala/received_events","type":"User","site_admin":false},{"login":"RiccardoRossi","id":8059665,"node_id":"MDQ6VXNlcjgwNTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},{"login":"maceligueta","id":8899917,"node_id":"MDQ6VXNlcjg4OTk5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8899917?v=4","gravatar_id":"","url":"https://api.github.com/users/maceligueta","html_url":"https://github.com/maceligueta","followers_url":"https://api.github.com/users/maceligueta/followers","following_url":"https://api.github.com/users/maceligueta/following{/other_user}","gists_url":"https://api.github.com/users/maceligueta/gists{/gist_id}","starred_url":"https://api.github.com/users/maceligueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maceligueta/subscriptions","organizations_url":"https://api.github.com/users/maceligueta/orgs","repos_url":"https://api.github.com/users/maceligueta/repos","events_url":"https://api.github.com/users/maceligueta/events{/privacy}","received_events_url":"https://api.github.com/users/maceligueta/received_events","type":"User","site_admin":false},{"login":"pooyan-dadvand","id":8911479,"node_id":"MDQ6VXNlcjg5MTE0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8911479?v=4","gravatar_id":"","url":"https://api.github.com/users/pooyan-dadvand","html_url":"https://github.com/pooyan-dadvand","followers_url":"https://api.github.com/users/pooyan-dadvand/followers","following_url":"https://api.github.com/users/pooyan-dadvand/following{/other_user}","gists_url":"https://api.github.com/users/pooyan-dadvand/gists{/gist_id}","starred_url":"https://api.github.com/users/pooyan-dadvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pooyan-dadvand/subscriptions","organizations_url":"https://api.github.com/users/pooyan-dadvand/orgs","repos_url":"https://api.github.com/users/pooyan-dadvand/repos","events_url":"https://api.github.com/users/pooyan-dadvand/events{/privacy}","received_events_url":"https://api.github.com/users/pooyan-dadvand/received_events","type":"User","site_admin":false},{"login":"msandre","id":22290001,"node_id":"MDQ6VXNlcjIyMjkwMDAx","avatar_url":"https://avatars0.githubusercontent.com/u/22290001?v=4","gravatar_id":"","url":"https://api.github.com/users/msandre","html_url":"https://github.com/msandre","followers_url":"https://api.github.com/users/msandre/followers","following_url":"https://api.github.com/users/msandre/following{/other_user}","gists_url":"https://api.github.com/users/msandre/gists{/gist_id}","starred_url":"https://api.github.com/users/msandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msandre/subscriptions","organizations_url":"https://api.github.com/users/msandre/orgs","repos_url":"https://api.github.com/users/msandre/repos","events_url":"https://api.github.com/users/msandre/events{/privacy}","received_events_url":"https://api.github.com/users/msandre/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1105857276,"node_id":"MDU6TGFiZWwxMTA1ODU3Mjc2","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Behaviour%20Change","name":"Behaviour Change","color":"fc0223","default":false},{"id":539269431,"node_id":"MDU6TGFiZWw1MzkyNjk0MzE=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/C++","name":"C++","color":"afea2e","default":false},{"id":538609887,"node_id":"MDU6TGFiZWw1Mzg2MDk4ODc=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Discussion","name":"Discussion","color":"cc317c","default":false},{"id":538395921,"node_id":"MDU6TGFiZWw1MzgzOTU5MjE=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Enhancement","name":"Enhancement","color":"77d86e","default":false},{"id":1091391300,"node_id":"MDU6TGFiZWwxMDkxMzkxMzAw","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Feature","name":"Feature","color":"77d86e","default":false},{"id":539268135,"node_id":"MDU6TGFiZWw1MzkyNjgxMzU=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Kratos%20Core","name":"Kratos Core","color":"0052cc","default":false},{"id":985806062,"node_id":"MDU6TGFiZWw5ODU4MDYwNjI=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Parallel-MPI","name":"Parallel-MPI","color":"f28c85","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340/commits","review_comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340/comments","review_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3340/comments","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/9bc8925f79c918997164e7ae9e1a5fe45a6a8d83","head":{"label":"KratosMultiphysics:experimental/mpi-core","ref":"experimental/mpi-core","sha":"9bc8925f79c918997164e7ae9e1a5fe45a6a8d83","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","private":false,"owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-11-15T07:41:08Z","pushed_at":"2018-11-15T08:21:44Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1284111,"stargazers_count":219,"watchers_count":219,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":174,"watchers":219,"default_branch":"master"}},"base":{"label":"KratosMultiphysics:master","ref":"master","sha":"fc47257018abb573a3ce91933f451431a77d363f","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","private":false,"owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-11-15T07:41:08Z","pushed_at":"2018-11-15T08:21:44Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1284111,"stargazers_count":219,"watchers_count":219,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":174,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/3340"},"issue":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3340"},"comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3340/comments"},"review_comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340/comments"},"review_comment":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3340/commits"},"statuses":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/9bc8925f79c918997164e7ae9e1a5fe45a6a8d83"}},"author_association":"MEMBER"}} | {
"id": 81815495,
"name": "KratosMultiphysics/Kratos",
"url": "https://api.github.com/repos/KratosMultiphysics/Kratos"
} | {
"id": 5071546,
"login": "jcotela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5071546?",
"url": "https://api.github.com/users/jcotela"
} | {
"id": 24840449,
"login": "KratosMultiphysics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24840449?",
"url": "https://api.github.com/orgs/KratosMultiphysics"
} | 2018-11-15T08:29:09 | 8593703421 | {"actor":{"display_login":"jcotela"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/206081105","pull_request_review_id":141470668,"id":206081105,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjA4MTEwNQ==","diff_hunk":"@@ -0,0 +1,109 @@\n+from KratosMultiphysics import *","path":"applications/IgaApplication/tests/NodeCurveGeometry3DTests.py","position":1,"original_position":1,"commit_id":"c53aec0181434b4decf793601b4da95f3d24e9f2","original_commit_id":"c53aec0181434b4decf793601b4da95f3d24e9f2","user":{"login":"oberbichler","id":7000594,"node_id":"MDQ6VXNlcjcwMDA1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7000594?v=4","gravatar_id":"","url":"https://api.github.com/users/oberbichler","html_url":"https://github.com/oberbichler","followers_url":"https://api.github.com/users/oberbichler/followers","following_url":"https://api.github.com/users/oberbichler/following{/other_user}","gists_url":"https://api.github.com/users/oberbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/oberbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberbichler/subscriptions","organizations_url":"https://api.github.com/users/oberbichler/orgs","repos_url":"https://api.github.com/users/oberbichler/repos","events_url":"https://api.github.com/users/oberbichler/events{/privacy}","received_events_url":"https://api.github.com/users/oberbichler/received_events","type":"User","site_admin":false},"body":"`node_curve_geometry_3d_tests.py`?","created_at":"2018-07-30T10:16:24Z","updated_at":"2018-07-30T10:16:24Z","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2601#discussion_r206081105","pull_request_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/206081105"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/2601#discussion_r206081105"},"pull_request":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601"}},"in_reply_to_id":206071606},"pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601","id":204742712,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzQyNzEy","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/2601","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/2601.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/2601.patch","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2601","number":2601,"state":"open","locked":false,"title":"Feature/add nurbs brep application","user":{"login":"oberbichler","id":7000594,"node_id":"MDQ6VXNlcjcwMDA1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7000594?v=4","gravatar_id":"","url":"https://api.github.com/users/oberbichler","html_url":"https://github.com/oberbichler","followers_url":"https://api.github.com/users/oberbichler/followers","following_url":"https://api.github.com/users/oberbichler/following{/other_user}","gists_url":"https://api.github.com/users/oberbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/oberbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberbichler/subscriptions","organizations_url":"https://api.github.com/users/oberbichler/orgs","repos_url":"https://api.github.com/users/oberbichler/repos","events_url":"https://api.github.com/users/oberbichler/events{/privacy}","received_events_url":"https://api.github.com/users/oberbichler/received_events","type":"User","site_admin":false},"body":"Same as #2492. Forgot to change target branch to master...\r\nSorry for the effort!","created_at":"2018-07-30T09:21:32Z","updated_at":"2018-07-30T10:16:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c29905b368044b26afadc9c599e164b46a777c39","assignee":null,"assignees":[],"requested_reviewers":[{"login":"philbucher","id":25484702,"node_id":"MDQ6VXNlcjI1NDg0NzAy","avatar_url":"https://avatars3.githubusercontent.com/u/25484702?v=4","gravatar_id":"","url":"https://api.github.com/users/philbucher","html_url":"https://github.com/philbucher","followers_url":"https://api.github.com/users/philbucher/followers","following_url":"https://api.github.com/users/philbucher/following{/other_user}","gists_url":"https://api.github.com/users/philbucher/gists{/gist_id}","starred_url":"https://api.github.com/users/philbucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbucher/subscriptions","organizations_url":"https://api.github.com/users/philbucher/orgs","repos_url":"https://api.github.com/users/philbucher/repos","events_url":"https://api.github.com/users/philbucher/events{/privacy}","received_events_url":"https://api.github.com/users/philbucher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601/commits","review_comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601/comments","review_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2601/comments","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/c53aec0181434b4decf793601b4da95f3d24e9f2","head":{"label":"KratosMultiphysics:feature/add_nurbs_brep_application","ref":"feature/add_nurbs_brep_application","sha":"c53aec0181434b4decf793601b4da95f3d24e9f2","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-07-30T09:17:59Z","pushed_at":"2018-07-30T10:12:43Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1187167,"stargazers_count":167,"watchers_count":167,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":117,"watchers":167,"default_branch":"master"}},"base":{"label":"KratosMultiphysics:master","ref":"master","sha":"84d4ac16b50ed0017cbe44d93bdf81041fc0ed84","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-07-30T09:17:59Z","pushed_at":"2018-07-30T10:12:43Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1187167,"stargazers_count":167,"watchers_count":167,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":117,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/2601"},"issue":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2601"},"comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2601/comments"},"review_comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601/comments"},"review_comment":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/2601/commits"},"statuses":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/c53aec0181434b4decf793601b4da95f3d24e9f2"}},"author_association":"MEMBER"}} | {
"id": 81815495,
"name": "KratosMultiphysics/Kratos",
"url": "https://api.github.com/repos/KratosMultiphysics/Kratos"
} | {
"id": 7000594,
"login": "oberbichler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7000594?",
"url": "https://api.github.com/users/oberbichler"
} | {
"id": 24840449,
"login": "KratosMultiphysics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24840449?",
"url": "https://api.github.com/orgs/KratosMultiphysics"
} | 2018-07-30T10:16:24 | 8036784715 | {"actor":{"display_login":"oberbichler"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/comments/193367246","pull_request_review_id":126321244,"id":193367246,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzM2NzI0Ng==","diff_hunk":"@@ -100,6 +100,21 @@ _Note: SwiftGen needs Xcode 8.3 to build, so installing via Homebrew requires yo\n \n ---\n </details>\n+<details>\n+<summary>Via <strong>Mint</strong></summary>","path":"README.md","position":5,"original_position":5,"commit_id":"39e4d004d2af615919a00f383abeb55cfb72ed04","original_commit_id":"39e4d004d2af615919a00f383abeb55cfb72ed04","user":{"login":"yonaskolb","id":2393781,"node_id":"MDQ6VXNlcjIzOTM3ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"body":"Good question. The repo is called `Mint` and the executable is `mint` (Much like `SwiftGen`).\r\nThe `🌱` is an optional adornment 😛","created_at":"2018-06-06T10:42:16Z","updated_at":"2018-06-06T10:42:16Z","html_url":"https://github.com/SwiftGen/SwiftGen/pull/439#discussion_r193367246","pull_request_url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/comments/193367246"},"html":{"href":"https://github.com/SwiftGen/SwiftGen/pull/439#discussion_r193367246"},"pull_request":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439"}},"in_reply_to_id":193356754},"pull_request":{"url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439","id":192936997,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTM2OTk3","html_url":"https://github.com/SwiftGen/SwiftGen/pull/439","diff_url":"https://github.com/SwiftGen/SwiftGen/pull/439.diff","patch_url":"https://github.com/SwiftGen/SwiftGen/pull/439.patch","issue_url":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/439","number":439,"state":"open","locked":false,"title":"Add mint installation (merge for 6.0 only)","user":{"login":"Lutzifer","id":194417,"node_id":"MDQ6VXNlcjE5NDQxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/194417?v=4","gravatar_id":"","url":"https://api.github.com/users/Lutzifer","html_url":"https://github.com/Lutzifer","followers_url":"https://api.github.com/users/Lutzifer/followers","following_url":"https://api.github.com/users/Lutzifer/following{/other_user}","gists_url":"https://api.github.com/users/Lutzifer/gists{/gist_id}","starred_url":"https://api.github.com/users/Lutzifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lutzifer/subscriptions","organizations_url":"https://api.github.com/users/Lutzifer/orgs","repos_url":"https://api.github.com/users/Lutzifer/repos","events_url":"https://api.github.com/users/Lutzifer/events{/privacy}","received_events_url":"https://api.github.com/users/Lutzifer/received_events","type":"User","site_admin":false},"body":"until the release of 6.0, this can be tested with\r\n\r\n$ mint install SwiftGen/SwiftGen@master --global=false\r\n","created_at":"2018-06-06T08:30:25Z","updated_at":"2018-06-06T10:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b12b072ccbcde4f03685be9af57bca1f8066f536","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439/commits","review_comments_url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439/comments","review_comment_url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/439/comments","statuses_url":"https://api.github.com/repos/SwiftGen/SwiftGen/statuses/39e4d004d2af615919a00f383abeb55cfb72ed04","head":{"label":"Lutzifer:patch-1","ref":"patch-1","sha":"39e4d004d2af615919a00f383abeb55cfb72ed04","user":{"login":"Lutzifer","id":194417,"node_id":"MDQ6VXNlcjE5NDQxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/194417?v=4","gravatar_id":"","url":"https://api.github.com/users/Lutzifer","html_url":"https://github.com/Lutzifer","followers_url":"https://api.github.com/users/Lutzifer/followers","following_url":"https://api.github.com/users/Lutzifer/following{/other_user}","gists_url":"https://api.github.com/users/Lutzifer/gists{/gist_id}","starred_url":"https://api.github.com/users/Lutzifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lutzifer/subscriptions","organizations_url":"https://api.github.com/users/Lutzifer/orgs","repos_url":"https://api.github.com/users/Lutzifer/repos","events_url":"https://api.github.com/users/Lutzifer/events{/privacy}","received_events_url":"https://api.github.com/users/Lutzifer/received_events","type":"User","site_admin":false},"repo":{"id":136296527,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyOTY1Mjc=","name":"SwiftGen","full_name":"Lutzifer/SwiftGen","owner":{"login":"Lutzifer","id":194417,"node_id":"MDQ6VXNlcjE5NDQxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/194417?v=4","gravatar_id":"","url":"https://api.github.com/users/Lutzifer","html_url":"https://github.com/Lutzifer","followers_url":"https://api.github.com/users/Lutzifer/followers","following_url":"https://api.github.com/users/Lutzifer/following{/other_user}","gists_url":"https://api.github.com/users/Lutzifer/gists{/gist_id}","starred_url":"https://api.github.com/users/Lutzifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lutzifer/subscriptions","organizations_url":"https://api.github.com/users/Lutzifer/orgs","repos_url":"https://api.github.com/users/Lutzifer/repos","events_url":"https://api.github.com/users/Lutzifer/events{/privacy}","received_events_url":"https://api.github.com/users/Lutzifer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lutzifer/SwiftGen","description":"The Swift code generator for your assets, storyboards, Localizable.strings, … — Get rid of all String-based APIs!","fork":true,"url":"https://api.github.com/repos/Lutzifer/SwiftGen","forks_url":"https://api.github.com/repos/Lutzifer/SwiftGen/forks","keys_url":"https://api.github.com/repos/Lutzifer/SwiftGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lutzifer/SwiftGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lutzifer/SwiftGen/teams","hooks_url":"https://api.github.com/repos/Lutzifer/SwiftGen/hooks","issue_events_url":"https://api.github.com/repos/Lutzifer/SwiftGen/issues/events{/number}","events_url":"https://api.github.com/repos/Lutzifer/SwiftGen/events","assignees_url":"https://api.github.com/repos/Lutzifer/SwiftGen/assignees{/user}","branches_url":"https://api.github.com/repos/Lutzifer/SwiftGen/branches{/branch}","tags_url":"https://api.github.com/repos/Lutzifer/SwiftGen/tags","blobs_url":"https://api.github.com/repos/Lutzifer/SwiftGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lutzifer/SwiftGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lutzifer/SwiftGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lutzifer/SwiftGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lutzifer/SwiftGen/statuses/{sha}","languages_url":"https://api.github.com/repos/Lutzifer/SwiftGen/languages","stargazers_url":"https://api.github.com/repos/Lutzifer/SwiftGen/stargazers","contributors_url":"https://api.github.com/repos/Lutzifer/SwiftGen/contributors","subscribers_url":"https://api.github.com/repos/Lutzifer/SwiftGen/subscribers","subscription_url":"https://api.github.com/repos/Lutzifer/SwiftGen/subscription","commits_url":"https://api.github.com/repos/Lutzifer/SwiftGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lutzifer/SwiftGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lutzifer/SwiftGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lutzifer/SwiftGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lutzifer/SwiftGen/contents/{+path}","compare_url":"https://api.github.com/repos/Lutzifer/SwiftGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lutzifer/SwiftGen/merges","archive_url":"https://api.github.com/repos/Lutzifer/SwiftGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lutzifer/SwiftGen/downloads","issues_url":"https://api.github.com/repos/Lutzifer/SwiftGen/issues{/number}","pulls_url":"https://api.github.com/repos/Lutzifer/SwiftGen/pulls{/number}","milestones_url":"https://api.github.com/repos/Lutzifer/SwiftGen/milestones{/number}","notifications_url":"https://api.github.com/repos/Lutzifer/SwiftGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lutzifer/SwiftGen/labels{/name}","releases_url":"https://api.github.com/repos/Lutzifer/SwiftGen/releases{/id}","deployments_url":"https://api.github.com/repos/Lutzifer/SwiftGen/deployments","created_at":"2018-06-06T08:20:17Z","updated_at":"2018-06-06T08:20:20Z","pushed_at":"2018-06-06T08:51:33Z","git_url":"git://github.com/Lutzifer/SwiftGen.git","ssh_url":"git@github.com:Lutzifer/SwiftGen.git","clone_url":"https://github.com/Lutzifer/SwiftGen.git","svn_url":"https://github.com/Lutzifer/SwiftGen","homepage":"","size":17757,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SwiftGen:master","ref":"master","sha":"3d6788dfd8f7699676f1c4aa6f9a2894531a75dc","user":{"login":"SwiftGen","id":24867377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODY3Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/24867377?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftGen","html_url":"https://github.com/SwiftGen","followers_url":"https://api.github.com/users/SwiftGen/followers","following_url":"https://api.github.com/users/SwiftGen/following{/other_user}","gists_url":"https://api.github.com/users/SwiftGen/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftGen/subscriptions","organizations_url":"https://api.github.com/users/SwiftGen/orgs","repos_url":"https://api.github.com/users/SwiftGen/repos","events_url":"https://api.github.com/users/SwiftGen/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftGen/received_events","type":"Organization","site_admin":false},"repo":{"id":39166950,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE2Njk1MA==","name":"SwiftGen","full_name":"SwiftGen/SwiftGen","owner":{"login":"SwiftGen","id":24867377,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODY3Mzc3","avatar_url":"https://avatars3.githubusercontent.com/u/24867377?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftGen","html_url":"https://github.com/SwiftGen","followers_url":"https://api.github.com/users/SwiftGen/followers","following_url":"https://api.github.com/users/SwiftGen/following{/other_user}","gists_url":"https://api.github.com/users/SwiftGen/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftGen/subscriptions","organizations_url":"https://api.github.com/users/SwiftGen/orgs","repos_url":"https://api.github.com/users/SwiftGen/repos","events_url":"https://api.github.com/users/SwiftGen/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftGen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SwiftGen/SwiftGen","description":"The Swift code generator for your assets, storyboards, Localizable.strings, … — Get rid of all String-based APIs!","fork":false,"url":"https://api.github.com/repos/SwiftGen/SwiftGen","forks_url":"https://api.github.com/repos/SwiftGen/SwiftGen/forks","keys_url":"https://api.github.com/repos/SwiftGen/SwiftGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwiftGen/SwiftGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwiftGen/SwiftGen/teams","hooks_url":"https://api.github.com/repos/SwiftGen/SwiftGen/hooks","issue_events_url":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/events{/number}","events_url":"https://api.github.com/repos/SwiftGen/SwiftGen/events","assignees_url":"https://api.github.com/repos/SwiftGen/SwiftGen/assignees{/user}","branches_url":"https://api.github.com/repos/SwiftGen/SwiftGen/branches{/branch}","tags_url":"https://api.github.com/repos/SwiftGen/SwiftGen/tags","blobs_url":"https://api.github.com/repos/SwiftGen/SwiftGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwiftGen/SwiftGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwiftGen/SwiftGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwiftGen/SwiftGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwiftGen/SwiftGen/statuses/{sha}","languages_url":"https://api.github.com/repos/SwiftGen/SwiftGen/languages","stargazers_url":"https://api.github.com/repos/SwiftGen/SwiftGen/stargazers","contributors_url":"https://api.github.com/repos/SwiftGen/SwiftGen/contributors","subscribers_url":"https://api.github.com/repos/SwiftGen/SwiftGen/subscribers","subscription_url":"https://api.github.com/repos/SwiftGen/SwiftGen/subscription","commits_url":"https://api.github.com/repos/SwiftGen/SwiftGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwiftGen/SwiftGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwiftGen/SwiftGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwiftGen/SwiftGen/contents/{+path}","compare_url":"https://api.github.com/repos/SwiftGen/SwiftGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwiftGen/SwiftGen/merges","archive_url":"https://api.github.com/repos/SwiftGen/SwiftGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwiftGen/SwiftGen/downloads","issues_url":"https://api.github.com/repos/SwiftGen/SwiftGen/issues{/number}","pulls_url":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls{/number}","milestones_url":"https://api.github.com/repos/SwiftGen/SwiftGen/milestones{/number}","notifications_url":"https://api.github.com/repos/SwiftGen/SwiftGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwiftGen/SwiftGen/labels{/name}","releases_url":"https://api.github.com/repos/SwiftGen/SwiftGen/releases{/id}","deployments_url":"https://api.github.com/repos/SwiftGen/SwiftGen/deployments","created_at":"2015-07-15T23:58:44Z","updated_at":"2018-06-06T10:01:29Z","pushed_at":"2018-06-06T08:51:34Z","git_url":"git://github.com/SwiftGen/SwiftGen.git","ssh_url":"git@github.com:SwiftGen/SwiftGen.git","clone_url":"https://github.com/SwiftGen/SwiftGen.git","svn_url":"https://github.com/SwiftGen/SwiftGen","homepage":"","size":17736,"stargazers_count":4547,"watchers_count":4547,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":287,"open_issues":55,"watchers":4547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439"},"html":{"href":"https://github.com/SwiftGen/SwiftGen/pull/439"},"issue":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/439"},"comments":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/SwiftGen/SwiftGen/statuses/39e4d004d2af615919a00f383abeb55cfb72ed04"}},"author_association":"CONTRIBUTOR"}} | {
"id": 39166950,
"name": "SwiftGen/SwiftGen",
"url": "https://api.github.com/repos/SwiftGen/SwiftGen"
} | {
"id": 2393781,
"login": "yonaskolb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2393781?",
"url": "https://api.github.com/users/yonaskolb"
} | {
"id": 24867377,
"login": "SwiftGen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24867377?",
"url": "https://api.github.com/orgs/SwiftGen"
} | 2018-06-06T10:42:16 | 7783654161 | {"actor":{"display_login":"yonaskolb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/riboseinc/rnp/pulls/comments/220290467","pull_request_review_id":158664925,"id":220290467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI5MDQ2Nw==","diff_hunk":"@@ -472,14 +414,14 @@ rnp_init(rnp_t *rnp, const rnp_params_t *params)\n if (params->pubpath) {\n rnp->pubring = rnp_key_store_new(params->ks_pub_format, params->pubpath);\n if (rnp->pubring == NULL) {\n- fputs(\"rnp: can't create empty pubring keystore\\n\", io->errs);\n+ fprintf(stderr, \"rnp: can't create empty pubring keystore\\n\");","path":"src/lib/rnp.cpp","position":137,"original_position":137,"commit_id":"e17bee1dec1434c2ba0a59c6f8d4b1a679b1dc16","original_commit_id":"e17bee1dec1434c2ba0a59c6f8d4b1a679b1dc16","user":{"login":"randombit","id":469092,"node_id":"MDQ6VXNlcjQ2OTA5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/469092?v=4","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"body":"Is there a reason this isn't `RNP_LOG`?","created_at":"2018-09-25T17:46:41Z","updated_at":"2018-09-25T17:58:07Z","html_url":"https://github.com/riboseinc/rnp/pull/753#discussion_r220290467","pull_request_url":"https://api.github.com/repos/riboseinc/rnp/pulls/753","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/comments/220290467"},"html":{"href":"https://github.com/riboseinc/rnp/pull/753#discussion_r220290467"},"pull_request":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/753"}}},"pull_request":{"url":"https://api.github.com/repos/riboseinc/rnp/pulls/753","id":218034708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDM0NzA4","html_url":"https://github.com/riboseinc/rnp/pull/753","diff_url":"https://github.com/riboseinc/rnp/pull/753.diff","patch_url":"https://github.com/riboseinc/rnp/pull/753.patch","issue_url":"https://api.github.com/repos/riboseinc/rnp/issues/753","number":753,"state":"open","locked":false,"title":"Remove pgp_io_t","user":{"login":"ni4","id":4312096,"node_id":"MDQ6VXNlcjQzMTIwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4312096?v=4","gravatar_id":"","url":"https://api.github.com/users/ni4","html_url":"https://github.com/ni4","followers_url":"https://api.github.com/users/ni4/followers","following_url":"https://api.github.com/users/ni4/following{/other_user}","gists_url":"https://api.github.com/users/ni4/gists{/gist_id}","starred_url":"https://api.github.com/users/ni4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni4/subscriptions","organizations_url":"https://api.github.com/users/ni4/orgs","repos_url":"https://api.github.com/users/ni4/repos","events_url":"https://api.github.com/users/ni4/events{/privacy}","received_events_url":"https://api.github.com/users/ni4/received_events","type":"User","site_admin":false},"body":"Since we moved to RNP_LOG this structure is no longer needed (especially as input parameter to all key/keyring processing functions).\r\nAlso in CLI we used it only for res stream, and in FFI - for err stream, which were replaced with single stream variable.\r\n\r\nFixes #157 ","created_at":"2018-09-25T15:58:45Z","updated_at":"2018-09-25T17:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a42c70cb1fcd2606d9730785a45fabe83ba753d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ronaldtse","id":11865,"node_id":"MDQ6VXNlcjExODY1","avatar_url":"https://avatars1.githubusercontent.com/u/11865?v=4","gravatar_id":"","url":"https://api.github.com/users/ronaldtse","html_url":"https://github.com/ronaldtse","followers_url":"https://api.github.com/users/ronaldtse/followers","following_url":"https://api.github.com/users/ronaldtse/following{/other_user}","gists_url":"https://api.github.com/users/ronaldtse/gists{/gist_id}","starred_url":"https://api.github.com/users/ronaldtse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronaldtse/subscriptions","organizations_url":"https://api.github.com/users/ronaldtse/orgs","repos_url":"https://api.github.com/users/ronaldtse/repos","events_url":"https://api.github.com/users/ronaldtse/events{/privacy}","received_events_url":"https://api.github.com/users/ronaldtse/received_events","type":"User","site_admin":false},{"login":"dewyatt","id":711649,"node_id":"MDQ6VXNlcjcxMTY0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/711649?v=4","gravatar_id":"","url":"https://api.github.com/users/dewyatt","html_url":"https://github.com/dewyatt","followers_url":"https://api.github.com/users/dewyatt/followers","following_url":"https://api.github.com/users/dewyatt/following{/other_user}","gists_url":"https://api.github.com/users/dewyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/dewyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dewyatt/subscriptions","organizations_url":"https://api.github.com/users/dewyatt/orgs","repos_url":"https://api.github.com/users/dewyatt/repos","events_url":"https://api.github.com/users/dewyatt/events{/privacy}","received_events_url":"https://api.github.com/users/dewyatt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/riboseinc/rnp/pulls/753/commits","review_comments_url":"https://api.github.com/repos/riboseinc/rnp/pulls/753/comments","review_comment_url":"https://api.github.com/repos/riboseinc/rnp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riboseinc/rnp/issues/753/comments","statuses_url":"https://api.github.com/repos/riboseinc/rnp/statuses/e17bee1dec1434c2ba0a59c6f8d4b1a679b1dc16","head":{"label":"riboseinc:ni4-157-remove-pgp_io_t","ref":"ni4-157-remove-pgp_io_t","sha":"e17bee1dec1434c2ba0a59c6f8d4b1a679b1dc16","user":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":84580444,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU4MDQ0NA==","name":"rnp","full_name":"riboseinc/rnp","private":false,"owner":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/riboseinc/rnp","description":"RNP: high performance C++ OpenPGP library, fully compliant to RFC 4880","fork":false,"url":"https://api.github.com/repos/riboseinc/rnp","forks_url":"https://api.github.com/repos/riboseinc/rnp/forks","keys_url":"https://api.github.com/repos/riboseinc/rnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/rnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/rnp/teams","hooks_url":"https://api.github.com/repos/riboseinc/rnp/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/rnp/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/rnp/events","assignees_url":"https://api.github.com/repos/riboseinc/rnp/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/rnp/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/rnp/tags","blobs_url":"https://api.github.com/repos/riboseinc/rnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/rnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/rnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/rnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/rnp/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/rnp/languages","stargazers_url":"https://api.github.com/repos/riboseinc/rnp/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/rnp/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/rnp/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/rnp/subscription","commits_url":"https://api.github.com/repos/riboseinc/rnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/rnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/rnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/rnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/rnp/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/rnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/rnp/merges","archive_url":"https://api.github.com/repos/riboseinc/rnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/rnp/downloads","issues_url":"https://api.github.com/repos/riboseinc/rnp/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/rnp/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/rnp/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/rnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/rnp/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/rnp/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/rnp/deployments","created_at":"2017-03-10T16:41:47Z","updated_at":"2018-09-24T17:31:53Z","pushed_at":"2018-09-25T15:58:46Z","git_url":"git://github.com/riboseinc/rnp.git","ssh_url":"git@github.com:riboseinc/rnp.git","clone_url":"https://github.com/riboseinc/rnp.git","svn_url":"https://github.com/riboseinc/rnp","homepage":"https://www.rnpgp.com","size":10548,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":105,"watchers":28,"default_branch":"master"}},"base":{"label":"riboseinc:master","ref":"master","sha":"e6a04fad4ad87c15b7ceb99a2722c3ec4035b64d","user":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":84580444,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU4MDQ0NA==","name":"rnp","full_name":"riboseinc/rnp","private":false,"owner":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/riboseinc/rnp","description":"RNP: high performance C++ OpenPGP library, fully compliant to RFC 4880","fork":false,"url":"https://api.github.com/repos/riboseinc/rnp","forks_url":"https://api.github.com/repos/riboseinc/rnp/forks","keys_url":"https://api.github.com/repos/riboseinc/rnp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/rnp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/rnp/teams","hooks_url":"https://api.github.com/repos/riboseinc/rnp/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/rnp/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/rnp/events","assignees_url":"https://api.github.com/repos/riboseinc/rnp/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/rnp/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/rnp/tags","blobs_url":"https://api.github.com/repos/riboseinc/rnp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/rnp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/rnp/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/rnp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/rnp/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/rnp/languages","stargazers_url":"https://api.github.com/repos/riboseinc/rnp/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/rnp/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/rnp/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/rnp/subscription","commits_url":"https://api.github.com/repos/riboseinc/rnp/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/rnp/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/rnp/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/rnp/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/rnp/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/rnp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/rnp/merges","archive_url":"https://api.github.com/repos/riboseinc/rnp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/rnp/downloads","issues_url":"https://api.github.com/repos/riboseinc/rnp/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/rnp/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/rnp/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/rnp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/rnp/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/rnp/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/rnp/deployments","created_at":"2017-03-10T16:41:47Z","updated_at":"2018-09-24T17:31:53Z","pushed_at":"2018-09-25T15:58:46Z","git_url":"git://github.com/riboseinc/rnp.git","ssh_url":"git@github.com:riboseinc/rnp.git","clone_url":"https://github.com/riboseinc/rnp.git","svn_url":"https://github.com/riboseinc/rnp","homepage":"https://www.rnpgp.com","size":10548,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":105,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/753"},"html":{"href":"https://github.com/riboseinc/rnp/pull/753"},"issue":{"href":"https://api.github.com/repos/riboseinc/rnp/issues/753"},"comments":{"href":"https://api.github.com/repos/riboseinc/rnp/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riboseinc/rnp/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/riboseinc/rnp/statuses/e17bee1dec1434c2ba0a59c6f8d4b1a679b1dc16"}},"author_association":"CONTRIBUTOR"}} | {
"id": 84580444,
"name": "riboseinc/rnp",
"url": "https://api.github.com/repos/riboseinc/rnp"
} | {
"id": 469092,
"login": "randombit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/469092?",
"url": "https://api.github.com/users/randombit"
} | {
"id": 24904375,
"login": "riboseinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24904375?",
"url": "https://api.github.com/orgs/riboseinc"
} | 2018-09-25T17:46:41 | 8319701108 | {"actor":{"display_login":"randombit"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/comments/201276233","pull_request_review_id":135743369,"id":201276233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTI3NjIzMw==","diff_hunk":"@@ -1271,6 +1271,16 @@ def getalignments(bcv):\n cursor.execute(\"SELECT source_wordID, target_wordID, corrected FROM \" + tablename + \" WHERE source_wordID \\\n LIKE '\" + str(lid) + \"\\_%'\")\n rst2 = cursor.fetchall()\n+ englishword = []\n+ for sn in greek_list:\n+ cursor.execute(\"SELECT english FROM lid_lxn_grk_eng WHERE strong = %s\", (sn.lower(),))\n+ rst_sn = cursor.fetchone()\n+ if not rst_sn:\n+ englishword.append(sn)\n+ elif '-' in rst_sn[0]:\n+ englishword.append(sn)","path":"mt2414/main.py","position":11,"original_position":11,"commit_id":"7dba16a500b760b9793ddcde93939493c1cedeb6","original_commit_id":"7dba16a500b760b9793ddcde93939493c1cedeb6","user":{"login":"beniza","id":4908971,"node_id":"MDQ6VXNlcjQ5MDg5NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/4908971?v=4","gravatar_id":"","url":"https://api.github.com/users/beniza","html_url":"https://github.com/beniza","followers_url":"https://api.github.com/users/beniza/followers","following_url":"https://api.github.com/users/beniza/following{/other_user}","gists_url":"https://api.github.com/users/beniza/gists{/gist_id}","starred_url":"https://api.github.com/users/beniza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beniza/subscriptions","organizations_url":"https://api.github.com/users/beniza/orgs","repos_url":"https://api.github.com/users/beniza/repos","events_url":"https://api.github.com/users/beniza/events{/privacy}","received_events_url":"https://api.github.com/users/beniza/received_events","type":"User","site_admin":false},"body":"If the English word is not available for an item, it's better to have the most used form from the definition field included here (may be with an asterisk at the beginning to specify that it's not an exact match). A hyphen on the top line may not be a good idea.","created_at":"2018-07-10T09:31:49Z","updated_at":"2018-07-10T09:31:50Z","html_url":"https://github.com/friendsofagape/mt2414/pull/214#discussion_r201276233","pull_request_url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/comments/201276233"},"html":{"href":"https://github.com/friendsofagape/mt2414/pull/214#discussion_r201276233"},"pull_request":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214","id":200078461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDc4NDYx","html_url":"https://github.com/friendsofagape/mt2414/pull/214","diff_url":"https://github.com/friendsofagape/mt2414/pull/214.diff","patch_url":"https://github.com/friendsofagape/mt2414/pull/214.patch","issue_url":"https://api.github.com/repos/friendsofagape/mt2414/issues/214","number":214,"state":"open","locked":false,"title":"English Words in API response","user":{"login":"bijob89","id":25318423,"node_id":"MDQ6VXNlcjI1MzE4NDIz","avatar_url":"https://avatars0.githubusercontent.com/u/25318423?v=4","gravatar_id":"","url":"https://api.github.com/users/bijob89","html_url":"https://github.com/bijob89","followers_url":"https://api.github.com/users/bijob89/followers","following_url":"https://api.github.com/users/bijob89/following{/other_user}","gists_url":"https://api.github.com/users/bijob89/gists{/gist_id}","starred_url":"https://api.github.com/users/bijob89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijob89/subscriptions","organizations_url":"https://api.github.com/users/bijob89/orgs","repos_url":"https://api.github.com/users/bijob89/repos","events_url":"https://api.github.com/users/bijob89/events{/privacy}","received_events_url":"https://api.github.com/users/bijob89/received_events","type":"User","site_admin":false},"body":"- Returns an array of english words to the corresponding array of strongs Numbers.\r\n- Returns strongs number if the english word is not available.","created_at":"2018-07-09T12:05:40Z","updated_at":"2018-07-10T09:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"330724c561d0f719ea4a293fadf7ea404a93d2d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214/commits","review_comments_url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214/comments","review_comment_url":"https://api.github.com/repos/friendsofagape/mt2414/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendsofagape/mt2414/issues/214/comments","statuses_url":"https://api.github.com/repos/friendsofagape/mt2414/statuses/7dba16a500b760b9793ddcde93939493c1cedeb6","head":{"label":"bijob89:master","ref":"master","sha":"7dba16a500b760b9793ddcde93939493c1cedeb6","user":{"login":"bijob89","id":25318423,"node_id":"MDQ6VXNlcjI1MzE4NDIz","avatar_url":"https://avatars0.githubusercontent.com/u/25318423?v=4","gravatar_id":"","url":"https://api.github.com/users/bijob89","html_url":"https://github.com/bijob89","followers_url":"https://api.github.com/users/bijob89/followers","following_url":"https://api.github.com/users/bijob89/following{/other_user}","gists_url":"https://api.github.com/users/bijob89/gists{/gist_id}","starred_url":"https://api.github.com/users/bijob89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijob89/subscriptions","organizations_url":"https://api.github.com/users/bijob89/orgs","repos_url":"https://api.github.com/users/bijob89/repos","events_url":"https://api.github.com/users/bijob89/events{/privacy}","received_events_url":"https://api.github.com/users/bijob89/received_events","type":"User","site_admin":false},"repo":{"id":82138249,"node_id":"MDEwOlJlcG9zaXRvcnk4MjEzODI0OQ==","name":"mt2414","full_name":"bijob89/mt2414","owner":{"login":"bijob89","id":25318423,"node_id":"MDQ6VXNlcjI1MzE4NDIz","avatar_url":"https://avatars0.githubusercontent.com/u/25318423?v=4","gravatar_id":"","url":"https://api.github.com/users/bijob89","html_url":"https://github.com/bijob89","followers_url":"https://api.github.com/users/bijob89/followers","following_url":"https://api.github.com/users/bijob89/following{/other_user}","gists_url":"https://api.github.com/users/bijob89/gists{/gist_id}","starred_url":"https://api.github.com/users/bijob89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bijob89/subscriptions","organizations_url":"https://api.github.com/users/bijob89/orgs","repos_url":"https://api.github.com/users/bijob89/repos","events_url":"https://api.github.com/users/bijob89/events{/privacy}","received_events_url":"https://api.github.com/users/bijob89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bijob89/mt2414","description":null,"fork":true,"url":"https://api.github.com/repos/bijob89/mt2414","forks_url":"https://api.github.com/repos/bijob89/mt2414/forks","keys_url":"https://api.github.com/repos/bijob89/mt2414/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bijob89/mt2414/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bijob89/mt2414/teams","hooks_url":"https://api.github.com/repos/bijob89/mt2414/hooks","issue_events_url":"https://api.github.com/repos/bijob89/mt2414/issues/events{/number}","events_url":"https://api.github.com/repos/bijob89/mt2414/events","assignees_url":"https://api.github.com/repos/bijob89/mt2414/assignees{/user}","branches_url":"https://api.github.com/repos/bijob89/mt2414/branches{/branch}","tags_url":"https://api.github.com/repos/bijob89/mt2414/tags","blobs_url":"https://api.github.com/repos/bijob89/mt2414/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bijob89/mt2414/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bijob89/mt2414/git/refs{/sha}","trees_url":"https://api.github.com/repos/bijob89/mt2414/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bijob89/mt2414/statuses/{sha}","languages_url":"https://api.github.com/repos/bijob89/mt2414/languages","stargazers_url":"https://api.github.com/repos/bijob89/mt2414/stargazers","contributors_url":"https://api.github.com/repos/bijob89/mt2414/contributors","subscribers_url":"https://api.github.com/repos/bijob89/mt2414/subscribers","subscription_url":"https://api.github.com/repos/bijob89/mt2414/subscription","commits_url":"https://api.github.com/repos/bijob89/mt2414/commits{/sha}","git_commits_url":"https://api.github.com/repos/bijob89/mt2414/git/commits{/sha}","comments_url":"https://api.github.com/repos/bijob89/mt2414/comments{/number}","issue_comment_url":"https://api.github.com/repos/bijob89/mt2414/issues/comments{/number}","contents_url":"https://api.github.com/repos/bijob89/mt2414/contents/{+path}","compare_url":"https://api.github.com/repos/bijob89/mt2414/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bijob89/mt2414/merges","archive_url":"https://api.github.com/repos/bijob89/mt2414/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bijob89/mt2414/downloads","issues_url":"https://api.github.com/repos/bijob89/mt2414/issues{/number}","pulls_url":"https://api.github.com/repos/bijob89/mt2414/pulls{/number}","milestones_url":"https://api.github.com/repos/bijob89/mt2414/milestones{/number}","notifications_url":"https://api.github.com/repos/bijob89/mt2414/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bijob89/mt2414/labels{/name}","releases_url":"https://api.github.com/repos/bijob89/mt2414/releases{/id}","deployments_url":"https://api.github.com/repos/bijob89/mt2414/deployments","created_at":"2017-02-16T04:14:33Z","updated_at":"2018-07-10T09:14:53Z","pushed_at":"2018-07-10T09:14:51Z","git_url":"git://github.com/bijob89/mt2414.git","ssh_url":"git@github.com:bijob89/mt2414.git","clone_url":"https://github.com/bijob89/mt2414.git","svn_url":"https://github.com/bijob89/mt2414","homepage":null,"size":4088,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"friendsofagape:feedbackaligner","ref":"feedbackaligner","sha":"4c8b621d6d1adc7b34ecdbbfbcf6ccc688b7e15e","user":{"login":"friendsofagape","id":24909473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA5NDcz","avatar_url":"https://avatars3.githubusercontent.com/u/24909473?v=4","gravatar_id":"","url":"https://api.github.com/users/friendsofagape","html_url":"https://github.com/friendsofagape","followers_url":"https://api.github.com/users/friendsofagape/followers","following_url":"https://api.github.com/users/friendsofagape/following{/other_user}","gists_url":"https://api.github.com/users/friendsofagape/gists{/gist_id}","starred_url":"https://api.github.com/users/friendsofagape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendsofagape/subscriptions","organizations_url":"https://api.github.com/users/friendsofagape/orgs","repos_url":"https://api.github.com/users/friendsofagape/repos","events_url":"https://api.github.com/users/friendsofagape/events{/privacy}","received_events_url":"https://api.github.com/users/friendsofagape/received_events","type":"Organization","site_admin":false},"repo":{"id":77686049,"node_id":"MDEwOlJlcG9zaXRvcnk3NzY4NjA0OQ==","name":"mt2414","full_name":"friendsofagape/mt2414","owner":{"login":"friendsofagape","id":24909473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA5NDcz","avatar_url":"https://avatars3.githubusercontent.com/u/24909473?v=4","gravatar_id":"","url":"https://api.github.com/users/friendsofagape","html_url":"https://github.com/friendsofagape","followers_url":"https://api.github.com/users/friendsofagape/followers","following_url":"https://api.github.com/users/friendsofagape/following{/other_user}","gists_url":"https://api.github.com/users/friendsofagape/gists{/gist_id}","starred_url":"https://api.github.com/users/friendsofagape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendsofagape/subscriptions","organizations_url":"https://api.github.com/users/friendsofagape/orgs","repos_url":"https://api.github.com/users/friendsofagape/repos","events_url":"https://api.github.com/users/friendsofagape/events{/privacy}","received_events_url":"https://api.github.com/users/friendsofagape/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/friendsofagape/mt2414","description":null,"fork":false,"url":"https://api.github.com/repos/friendsofagape/mt2414","forks_url":"https://api.github.com/repos/friendsofagape/mt2414/forks","keys_url":"https://api.github.com/repos/friendsofagape/mt2414/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendsofagape/mt2414/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendsofagape/mt2414/teams","hooks_url":"https://api.github.com/repos/friendsofagape/mt2414/hooks","issue_events_url":"https://api.github.com/repos/friendsofagape/mt2414/issues/events{/number}","events_url":"https://api.github.com/repos/friendsofagape/mt2414/events","assignees_url":"https://api.github.com/repos/friendsofagape/mt2414/assignees{/user}","branches_url":"https://api.github.com/repos/friendsofagape/mt2414/branches{/branch}","tags_url":"https://api.github.com/repos/friendsofagape/mt2414/tags","blobs_url":"https://api.github.com/repos/friendsofagape/mt2414/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendsofagape/mt2414/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendsofagape/mt2414/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendsofagape/mt2414/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendsofagape/mt2414/statuses/{sha}","languages_url":"https://api.github.com/repos/friendsofagape/mt2414/languages","stargazers_url":"https://api.github.com/repos/friendsofagape/mt2414/stargazers","contributors_url":"https://api.github.com/repos/friendsofagape/mt2414/contributors","subscribers_url":"https://api.github.com/repos/friendsofagape/mt2414/subscribers","subscription_url":"https://api.github.com/repos/friendsofagape/mt2414/subscription","commits_url":"https://api.github.com/repos/friendsofagape/mt2414/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendsofagape/mt2414/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendsofagape/mt2414/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendsofagape/mt2414/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendsofagape/mt2414/contents/{+path}","compare_url":"https://api.github.com/repos/friendsofagape/mt2414/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendsofagape/mt2414/merges","archive_url":"https://api.github.com/repos/friendsofagape/mt2414/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendsofagape/mt2414/downloads","issues_url":"https://api.github.com/repos/friendsofagape/mt2414/issues{/number}","pulls_url":"https://api.github.com/repos/friendsofagape/mt2414/pulls{/number}","milestones_url":"https://api.github.com/repos/friendsofagape/mt2414/milestones{/number}","notifications_url":"https://api.github.com/repos/friendsofagape/mt2414/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendsofagape/mt2414/labels{/name}","releases_url":"https://api.github.com/repos/friendsofagape/mt2414/releases{/id}","deployments_url":"https://api.github.com/repos/friendsofagape/mt2414/deployments","created_at":"2016-12-30T12:51:42Z","updated_at":"2018-06-21T17:55:34Z","pushed_at":"2018-07-10T09:14:52Z","git_url":"git://github.com/friendsofagape/mt2414.git","ssh_url":"git@github.com:friendsofagape/mt2414.git","clone_url":"https://github.com/friendsofagape/mt2414.git","svn_url":"https://github.com/friendsofagape/mt2414","homepage":null,"size":213,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":50,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214"},"html":{"href":"https://github.com/friendsofagape/mt2414/pull/214"},"issue":{"href":"https://api.github.com/repos/friendsofagape/mt2414/issues/214"},"comments":{"href":"https://api.github.com/repos/friendsofagape/mt2414/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendsofagape/mt2414/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/friendsofagape/mt2414/statuses/7dba16a500b760b9793ddcde93939493c1cedeb6"}},"author_association":"COLLABORATOR"}} | {
"id": 77686049,
"name": "friendsofagape/mt2414",
"url": "https://api.github.com/repos/friendsofagape/mt2414"
} | {
"id": 4908971,
"login": "beniza",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4908971?",
"url": "https://api.github.com/users/beniza"
} | {
"id": 24909473,
"login": "friendsofagape",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24909473?",
"url": "https://api.github.com/orgs/friendsofagape"
} | 2018-07-10T09:31:49 | 7942592339 | {"actor":{"display_login":"beniza"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fastify/fastify/pulls/comments/215056741","pull_request_review_id":152240903,"id":215056741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA1Njc0MQ==","diff_hunk":"@@ -177,8 +177,12 @@ fastify.get('/', function (request, reply) {\n reply.send(httpErrors.Gone())\n })\n ```\n+By default Fastify will log the error depending on the `statusCode`:\n+- for `400 <= statusCode < 500` the error will be logged with level `info`\n+- for `statusCode >= 500` the error will be logged with level `error`\n \n-If you want to completely customize the error response, checkout [`setErrorHandler`](https://github.com/fastify/fastify/blob/master/docs/Server.md#seterrorhandler) API.\n+If you want to completely customize the error handling, checkout [`setErrorHandler`](https://github.com/fastify/fastify/blob/master/docs/Server.md#seterrorhandler) API.<br>\n+*Note: you are responsibile for logging when setting the error handler*","path":"docs/Reply.md","position":19,"original_position":19,"commit_id":"fc6d50a2145b186c467e13be3ea2bcf5f3b9baf3","original_commit_id":"fc6d50a2145b186c467e13be3ea2bcf5f3b9baf3","user":{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"We need to add some docs that show that in the error handler we log the error.","created_at":"2018-09-04T20:31:25Z","updated_at":"2018-09-04T20:33:00Z","html_url":"https://github.com/fastify/fastify/pull/1135#discussion_r215056741","pull_request_url":"https://api.github.com/repos/fastify/fastify/pulls/1135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments/215056741"},"html":{"href":"https://github.com/fastify/fastify/pull/1135#discussion_r215056741"},"pull_request":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1135"}}},"pull_request":{"url":"https://api.github.com/repos/fastify/fastify/pulls/1135","id":212985019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTg1MDE5","html_url":"https://github.com/fastify/fastify/pull/1135","diff_url":"https://github.com/fastify/fastify/pull/1135.diff","patch_url":"https://github.com/fastify/fastify/pull/1135.patch","issue_url":"https://api.github.com/repos/fastify/fastify/issues/1135","number":1135,"state":"open","locked":false,"title":"Default error handler that logs the error","user":{"login":"mixecan","id":7155749,"node_id":"MDQ6VXNlcjcxNTU3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7155749?v=4","gravatar_id":"","url":"https://api.github.com/users/mixecan","html_url":"https://github.com/mixecan","followers_url":"https://api.github.com/users/mixecan/followers","following_url":"https://api.github.com/users/mixecan/following{/other_user}","gists_url":"https://api.github.com/users/mixecan/gists{/gist_id}","starred_url":"https://api.github.com/users/mixecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixecan/subscriptions","organizations_url":"https://api.github.com/users/mixecan/orgs","repos_url":"https://api.github.com/users/mixecan/repos","events_url":"https://api.github.com/users/mixecan/events{/privacy}","received_events_url":"https://api.github.com/users/mixecan/received_events","type":"User","site_admin":false},"body":"As discussed in #1119 this PR:\r\n- changes `reply.handlerError()` so that it logs an error only if no error handler is defined\r\n- renames customErrorHandler to errorHandler\r\n- updates the doc regarding the new behaviour, specifying that logging the error is in charge of the error handler, if specified\r\n\r\nThe log level depends on the `statusCode` as previous behaviour.\r\n\r\nOn my machine benchmarks improve by 10% with respect to `next`.\r\n\r\n#### Checklist\r\n\r\n- [x] run `npm run test` and `npm run benchmark`\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)\r\n","created_at":"2018-09-04T13:54:06Z","updated_at":"2018-09-04T20:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4505347333177f38c2400c89249bfbe927cc2243","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":747897137,"node_id":"MDU6TGFiZWw3NDc4OTcxMzc=","url":"https://api.github.com/repos/fastify/fastify/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":764678145,"node_id":"MDU6TGFiZWw3NjQ2NzgxNDU=","url":"https://api.github.com/repos/fastify/fastify/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/fastify/fastify/milestones/2","html_url":"https://github.com/fastify/fastify/milestone/2","labels_url":"https://api.github.com/repos/fastify/fastify/milestones/2/labels","id":3418492,"node_id":"MDk6TWlsZXN0b25lMzQxODQ5Mg==","number":2,"title":"v2.0.0","description":"The next major release of Fastify.","creator":{"login":"delvedor","id":4865608,"node_id":"MDQ6VXNlcjQ4NjU2MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4865608?v=4","gravatar_id":"","url":"https://api.github.com/users/delvedor","html_url":"https://github.com/delvedor","followers_url":"https://api.github.com/users/delvedor/followers","following_url":"https://api.github.com/users/delvedor/following{/other_user}","gists_url":"https://api.github.com/users/delvedor/gists{/gist_id}","starred_url":"https://api.github.com/users/delvedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delvedor/subscriptions","organizations_url":"https://api.github.com/users/delvedor/orgs","repos_url":"https://api.github.com/users/delvedor/repos","events_url":"https://api.github.com/users/delvedor/events{/privacy}","received_events_url":"https://api.github.com/users/delvedor/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2018-06-12T10:03:52Z","updated_at":"2018-09-04T14:04:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/fastify/fastify/pulls/1135/commits","review_comments_url":"https://api.github.com/repos/fastify/fastify/pulls/1135/comments","review_comment_url":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastify/fastify/issues/1135/comments","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/fc6d50a2145b186c467e13be3ea2bcf5f3b9baf3","head":{"label":"mixecan:default-error-handler","ref":"default-error-handler","sha":"fc6d50a2145b186c467e13be3ea2bcf5f3b9baf3","user":{"login":"mixecan","id":7155749,"node_id":"MDQ6VXNlcjcxNTU3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7155749?v=4","gravatar_id":"","url":"https://api.github.com/users/mixecan","html_url":"https://github.com/mixecan","followers_url":"https://api.github.com/users/mixecan/followers","following_url":"https://api.github.com/users/mixecan/following{/other_user}","gists_url":"https://api.github.com/users/mixecan/gists{/gist_id}","starred_url":"https://api.github.com/users/mixecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixecan/subscriptions","organizations_url":"https://api.github.com/users/mixecan/orgs","repos_url":"https://api.github.com/users/mixecan/repos","events_url":"https://api.github.com/users/mixecan/events{/privacy}","received_events_url":"https://api.github.com/users/mixecan/received_events","type":"User","site_admin":false},"repo":{"id":133487564,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0ODc1NjQ=","name":"fastify","full_name":"mixecan/fastify","owner":{"login":"mixecan","id":7155749,"node_id":"MDQ6VXNlcjcxNTU3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7155749?v=4","gravatar_id":"","url":"https://api.github.com/users/mixecan","html_url":"https://github.com/mixecan","followers_url":"https://api.github.com/users/mixecan/followers","following_url":"https://api.github.com/users/mixecan/following{/other_user}","gists_url":"https://api.github.com/users/mixecan/gists{/gist_id}","starred_url":"https://api.github.com/users/mixecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixecan/subscriptions","organizations_url":"https://api.github.com/users/mixecan/orgs","repos_url":"https://api.github.com/users/mixecan/repos","events_url":"https://api.github.com/users/mixecan/events{/privacy}","received_events_url":"https://api.github.com/users/mixecan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mixecan/fastify","description":"Fast and low overhead web framework, for Node.js","fork":true,"url":"https://api.github.com/repos/mixecan/fastify","forks_url":"https://api.github.com/repos/mixecan/fastify/forks","keys_url":"https://api.github.com/repos/mixecan/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixecan/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixecan/fastify/teams","hooks_url":"https://api.github.com/repos/mixecan/fastify/hooks","issue_events_url":"https://api.github.com/repos/mixecan/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/mixecan/fastify/events","assignees_url":"https://api.github.com/repos/mixecan/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/mixecan/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/mixecan/fastify/tags","blobs_url":"https://api.github.com/repos/mixecan/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixecan/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixecan/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixecan/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixecan/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/mixecan/fastify/languages","stargazers_url":"https://api.github.com/repos/mixecan/fastify/stargazers","contributors_url":"https://api.github.com/repos/mixecan/fastify/contributors","subscribers_url":"https://api.github.com/repos/mixecan/fastify/subscribers","subscription_url":"https://api.github.com/repos/mixecan/fastify/subscription","commits_url":"https://api.github.com/repos/mixecan/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixecan/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixecan/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixecan/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixecan/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/mixecan/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixecan/fastify/merges","archive_url":"https://api.github.com/repos/mixecan/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixecan/fastify/downloads","issues_url":"https://api.github.com/repos/mixecan/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/mixecan/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/mixecan/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/mixecan/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixecan/fastify/labels{/name}","releases_url":"https://api.github.com/repos/mixecan/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/mixecan/fastify/deployments","created_at":"2018-05-15T08:48:16Z","updated_at":"2018-09-01T21:52:16Z","pushed_at":"2018-09-04T14:23:44Z","git_url":"git://github.com/mixecan/fastify.git","ssh_url":"git@github.com:mixecan/fastify.git","clone_url":"https://github.com/mixecan/fastify.git","svn_url":"https://github.com/mixecan/fastify","homepage":"https://www.fastify.io","size":1709,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastify:next","ref":"next","sha":"39225010c4a7681bcbd4d137463449677908ce6b","user":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"repo":{"id":69495170,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQ5NTE3MA==","name":"fastify","full_name":"fastify/fastify","owner":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastify/fastify","description":"Fast and low overhead web framework, for Node.js","fork":false,"url":"https://api.github.com/repos/fastify/fastify","forks_url":"https://api.github.com/repos/fastify/fastify/forks","keys_url":"https://api.github.com/repos/fastify/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastify/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastify/fastify/teams","hooks_url":"https://api.github.com/repos/fastify/fastify/hooks","issue_events_url":"https://api.github.com/repos/fastify/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/fastify/fastify/events","assignees_url":"https://api.github.com/repos/fastify/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/fastify/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/fastify/fastify/tags","blobs_url":"https://api.github.com/repos/fastify/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastify/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastify/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastify/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/fastify/fastify/languages","stargazers_url":"https://api.github.com/repos/fastify/fastify/stargazers","contributors_url":"https://api.github.com/repos/fastify/fastify/contributors","subscribers_url":"https://api.github.com/repos/fastify/fastify/subscribers","subscription_url":"https://api.github.com/repos/fastify/fastify/subscription","commits_url":"https://api.github.com/repos/fastify/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastify/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastify/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastify/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastify/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/fastify/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastify/fastify/merges","archive_url":"https://api.github.com/repos/fastify/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastify/fastify/downloads","issues_url":"https://api.github.com/repos/fastify/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/fastify/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/fastify/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/fastify/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastify/fastify/labels{/name}","releases_url":"https://api.github.com/repos/fastify/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/fastify/fastify/deployments","created_at":"2016-09-28T19:10:14Z","updated_at":"2018-09-04T20:28:33Z","pushed_at":"2018-09-04T20:28:33Z","git_url":"git://github.com/fastify/fastify.git","ssh_url":"git@github.com:fastify/fastify.git","clone_url":"https://github.com/fastify/fastify.git","svn_url":"https://github.com/fastify/fastify","homepage":"https://www.fastify.io","size":1715,"stargazers_count":7930,"watchers_count":7930,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":427,"open_issues":35,"watchers":7930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1135"},"html":{"href":"https://github.com/fastify/fastify/pull/1135"},"issue":{"href":"https://api.github.com/repos/fastify/fastify/issues/1135"},"comments":{"href":"https://api.github.com/repos/fastify/fastify/issues/1135/comments"},"review_comments":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1135/comments"},"review_comment":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1135/commits"},"statuses":{"href":"https://api.github.com/repos/fastify/fastify/statuses/fc6d50a2145b186c467e13be3ea2bcf5f3b9baf3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 69495170,
"name": "fastify/fastify",
"url": "https://api.github.com/repos/fastify/fastify"
} | {
"id": 52195,
"login": "mcollina",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52195?",
"url": "https://api.github.com/users/mcollina"
} | {
"id": 24939410,
"login": "fastify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24939410?",
"url": "https://api.github.com/orgs/fastify"
} | 2018-09-04T20:31:25 | 8213741427 | {"actor":{"display_login":"mcollina"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/comments/208616281","pull_request_review_id":144461910,"id":208616281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYxNjI4MQ==","diff_hunk":"@@ -0,0 +1,34 @@\n+section#project-comments\n+ .inner\n+ h1 Project comments\n+ .comments-wrapper\n+ ul.comments\n+ - @project_comments.each.with_index(1) do |comment, i|\n+ li.comment id=\"project-comment-#{comment.id}\"\n+ .left\n+ = link_to image_tag(comment.user.avatar.thumb.url, class: 'avatar'), projects_path(owner_name: comment.user.slug), title: comment.user.name\n+ .right\n+ .wrapper\n+ .header\n+ span.number.header-content\n+ = format \"No.%03d\", i\n+ span.owner.header-content\n+ = link_to comment.user.slug, projects_path(owner_name: comment.user.slug)\n+\n+ span.created-at.header-content\n+ = \"Posted date: \"\n+ span.date\n+ = comment.created_at.strftime '%Y.%m.%d.%H.%M'","path":"app/views/recipes/_project_comments.html.slim","position":21,"original_position":21,"commit_id":"b946938e48506a5c29b30eb08467c1ada32a040f","original_commit_id":"b946938e48506a5c29b30eb08467c1ada32a040f","user":{"login":"itkrt2y","id":2343568,"node_id":"MDQ6VXNlcjIzNDM1Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/2343568?v=4","gravatar_id":"","url":"https://api.github.com/users/itkrt2y","html_url":"https://github.com/itkrt2y","followers_url":"https://api.github.com/users/itkrt2y/followers","following_url":"https://api.github.com/users/itkrt2y/following{/other_user}","gists_url":"https://api.github.com/users/itkrt2y/gists{/gist_id}","starred_url":"https://api.github.com/users/itkrt2y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkrt2y/subscriptions","organizations_url":"https://api.github.com/users/itkrt2y/orgs","repos_url":"https://api.github.com/users/itkrt2y/repos","events_url":"https://api.github.com/users/itkrt2y/events{/privacy}","received_events_url":"https://api.github.com/users/itkrt2y/received_events","type":"User","site_admin":false},"body":"2点\r\n\r\n1. viewでは `strftime` するよりは、 `l(comment.created_at)` と書いた方がシンプル（ https://guides.rubyonrails.org/i18n.html#adding-date-time-formats ）\r\n1. わかってて依頼がないのでスルーしてるところですが、TimeZone設定がされてないのでこれだとUTCで表示される\r\n\r\n多分年月日表記までで、時刻なくていいです","created_at":"2018-08-08T15:00:32Z","updated_at":"2018-08-08T15:00:32Z","html_url":"https://github.com/takeyuwebinc/gitfab2/pull/37#discussion_r208616281","pull_request_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/comments/208616281"},"html":{"href":"https://github.com/takeyuwebinc/gitfab2/pull/37#discussion_r208616281"},"pull_request":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37","id":205707660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzA3NjYw","html_url":"https://github.com/takeyuwebinc/gitfab2/pull/37","diff_url":"https://github.com/takeyuwebinc/gitfab2/pull/37.diff","patch_url":"https://github.com/takeyuwebinc/gitfab2/pull/37.patch","issue_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/37","number":37,"state":"open","locked":false,"title":"コメント機能の強化（プロジェクトに対するコメント）","user":{"login":"noriyotcp","id":5820754,"node_id":"MDQ6VXNlcjU4MjA3NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5820754?v=4","gravatar_id":"","url":"https://api.github.com/users/noriyotcp","html_url":"https://github.com/noriyotcp","followers_url":"https://api.github.com/users/noriyotcp/followers","following_url":"https://api.github.com/users/noriyotcp/following{/other_user}","gists_url":"https://api.github.com/users/noriyotcp/gists{/gist_id}","starred_url":"https://api.github.com/users/noriyotcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noriyotcp/subscriptions","organizations_url":"https://api.github.com/users/noriyotcp/orgs","repos_url":"https://api.github.com/users/noriyotcp/repos","events_url":"https://api.github.com/users/noriyotcp/events{/privacy}","received_events_url":"https://api.github.com/users/noriyotcp/received_events","type":"User","site_admin":false},"body":"Closes #23 \r\n\r\n既存のコメントを参考に以下のようにしている\r\n\r\n\r\n\r\n- 既存の `comments` -> `card_comments` へのリネームは別issueにしたい\r\n\r\n## 削除権限について\r\n- 従来のコメントがユーザーが自分のコメントを削除できるようにはなっていない？カードの管理者は削除できるようだが\r\n\r\nhttps://github.com/takeyuwebinc/gitfab2/blob/master/app/models/ability.rb#L72\r\n\r\nそれに倣い、`project_comments` も管理者のみが削除できるようにはしているが、要確認\r\n\r\n## その他\r\n- facebookコメント関連のコードは削除\r\n- stl-viewに関する対応漏れがあったのでコードを削除\r\n","created_at":"2018-08-02T11:49:29Z","updated_at":"2018-08-08T15:00:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"649a905c878e72b10dba340e407e79c3b022838d","assignee":{"login":"noriyotcp","id":5820754,"node_id":"MDQ6VXNlcjU4MjA3NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5820754?v=4","gravatar_id":"","url":"https://api.github.com/users/noriyotcp","html_url":"https://github.com/noriyotcp","followers_url":"https://api.github.com/users/noriyotcp/followers","following_url":"https://api.github.com/users/noriyotcp/following{/other_user}","gists_url":"https://api.github.com/users/noriyotcp/gists{/gist_id}","starred_url":"https://api.github.com/users/noriyotcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noriyotcp/subscriptions","organizations_url":"https://api.github.com/users/noriyotcp/orgs","repos_url":"https://api.github.com/users/noriyotcp/repos","events_url":"https://api.github.com/users/noriyotcp/events{/privacy}","received_events_url":"https://api.github.com/users/noriyotcp/received_events","type":"User","site_admin":false},"assignees":[{"login":"noriyotcp","id":5820754,"node_id":"MDQ6VXNlcjU4MjA3NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5820754?v=4","gravatar_id":"","url":"https://api.github.com/users/noriyotcp","html_url":"https://github.com/noriyotcp","followers_url":"https://api.github.com/users/noriyotcp/followers","following_url":"https://api.github.com/users/noriyotcp/following{/other_user}","gists_url":"https://api.github.com/users/noriyotcp/gists{/gist_id}","starred_url":"https://api.github.com/users/noriyotcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noriyotcp/subscriptions","organizations_url":"https://api.github.com/users/noriyotcp/orgs","repos_url":"https://api.github.com/users/noriyotcp/repos","events_url":"https://api.github.com/users/noriyotcp/events{/privacy}","received_events_url":"https://api.github.com/users/noriyotcp/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1008673944,"node_id":"MDU6TGFiZWwxMDA4NjczOTQ0","url":"https://api.github.com/repos/takeyuwebinc/gitfab2/labels/%E3%83%AC%E3%83%93%E3%83%A5%E3%83%BC%E5%BE%85%E3%81%A1","name":"レビュー待ち","color":"2ed331","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37/commits","review_comments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37/comments","review_comment_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/37/comments","statuses_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/statuses/b946938e48506a5c29b30eb08467c1ada32a040f","head":{"label":"takeyuwebinc:add-project-comment","ref":"add-project-comment","sha":"b946938e48506a5c29b30eb08467c1ada32a040f","user":{"login":"takeyuwebinc","id":24970198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTcwMTk4","avatar_url":"https://avatars3.githubusercontent.com/u/24970198?v=4","gravatar_id":"","url":"https://api.github.com/users/takeyuwebinc","html_url":"https://github.com/takeyuwebinc","followers_url":"https://api.github.com/users/takeyuwebinc/followers","following_url":"https://api.github.com/users/takeyuwebinc/following{/other_user}","gists_url":"https://api.github.com/users/takeyuwebinc/gists{/gist_id}","starred_url":"https://api.github.com/users/takeyuwebinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeyuwebinc/subscriptions","organizations_url":"https://api.github.com/users/takeyuwebinc/orgs","repos_url":"https://api.github.com/users/takeyuwebinc/repos","events_url":"https://api.github.com/users/takeyuwebinc/events{/privacy}","received_events_url":"https://api.github.com/users/takeyuwebinc/received_events","type":"Organization","site_admin":false},"repo":{"id":71619232,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYxOTIzMg==","name":"gitfab2","full_name":"takeyuwebinc/gitfab2","owner":{"login":"takeyuwebinc","id":24970198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTcwMTk4","avatar_url":"https://avatars3.githubusercontent.com/u/24970198?v=4","gravatar_id":"","url":"https://api.github.com/users/takeyuwebinc","html_url":"https://github.com/takeyuwebinc","followers_url":"https://api.github.com/users/takeyuwebinc/followers","following_url":"https://api.github.com/users/takeyuwebinc/following{/other_user}","gists_url":"https://api.github.com/users/takeyuwebinc/gists{/gist_id}","starred_url":"https://api.github.com/users/takeyuwebinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeyuwebinc/subscriptions","organizations_url":"https://api.github.com/users/takeyuwebinc/orgs","repos_url":"https://api.github.com/users/takeyuwebinc/repos","events_url":"https://api.github.com/users/takeyuwebinc/events{/privacy}","received_events_url":"https://api.github.com/users/takeyuwebinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/takeyuwebinc/gitfab2","description":"Mozilla Japanより引き継いで改修作業中です。","fork":true,"url":"https://api.github.com/repos/takeyuwebinc/gitfab2","forks_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/forks","keys_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/teams","hooks_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/hooks","issue_events_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/events{/number}","events_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/events","assignees_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/assignees{/user}","branches_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/branches{/branch}","tags_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/tags","blobs_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/refs{/sha}","trees_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/statuses/{sha}","languages_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/languages","stargazers_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/stargazers","contributors_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/contributors","subscribers_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/subscribers","subscription_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/subscription","commits_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/commits{/sha}","git_commits_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/commits{/sha}","comments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/comments{/number}","issue_comment_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/comments{/number}","contents_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/contents/{+path}","compare_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/merges","archive_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/downloads","issues_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues{/number}","pulls_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls{/number}","milestones_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/milestones{/number}","notifications_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/labels{/name}","releases_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/releases{/id}","deployments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/deployments","created_at":"2016-10-22T05:38:14Z","updated_at":"2018-08-08T12:04:23Z","pushed_at":"2018-08-08T12:09:09Z","git_url":"git://github.com/takeyuwebinc/gitfab2.git","ssh_url":"git@github.com:takeyuwebinc/gitfab2.git","clone_url":"https://github.com/takeyuwebinc/gitfab2.git","svn_url":"https://github.com/takeyuwebinc/gitfab2","homepage":"https://fabble.cc","size":5997,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"takeyuwebinc:master","ref":"master","sha":"fe0e5a41c76cad3b8e97d57316eac9dd36558554","user":{"login":"takeyuwebinc","id":24970198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTcwMTk4","avatar_url":"https://avatars3.githubusercontent.com/u/24970198?v=4","gravatar_id":"","url":"https://api.github.com/users/takeyuwebinc","html_url":"https://github.com/takeyuwebinc","followers_url":"https://api.github.com/users/takeyuwebinc/followers","following_url":"https://api.github.com/users/takeyuwebinc/following{/other_user}","gists_url":"https://api.github.com/users/takeyuwebinc/gists{/gist_id}","starred_url":"https://api.github.com/users/takeyuwebinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeyuwebinc/subscriptions","organizations_url":"https://api.github.com/users/takeyuwebinc/orgs","repos_url":"https://api.github.com/users/takeyuwebinc/repos","events_url":"https://api.github.com/users/takeyuwebinc/events{/privacy}","received_events_url":"https://api.github.com/users/takeyuwebinc/received_events","type":"Organization","site_admin":false},"repo":{"id":71619232,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYxOTIzMg==","name":"gitfab2","full_name":"takeyuwebinc/gitfab2","owner":{"login":"takeyuwebinc","id":24970198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTcwMTk4","avatar_url":"https://avatars3.githubusercontent.com/u/24970198?v=4","gravatar_id":"","url":"https://api.github.com/users/takeyuwebinc","html_url":"https://github.com/takeyuwebinc","followers_url":"https://api.github.com/users/takeyuwebinc/followers","following_url":"https://api.github.com/users/takeyuwebinc/following{/other_user}","gists_url":"https://api.github.com/users/takeyuwebinc/gists{/gist_id}","starred_url":"https://api.github.com/users/takeyuwebinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeyuwebinc/subscriptions","organizations_url":"https://api.github.com/users/takeyuwebinc/orgs","repos_url":"https://api.github.com/users/takeyuwebinc/repos","events_url":"https://api.github.com/users/takeyuwebinc/events{/privacy}","received_events_url":"https://api.github.com/users/takeyuwebinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/takeyuwebinc/gitfab2","description":"Mozilla Japanより引き継いで改修作業中です。","fork":true,"url":"https://api.github.com/repos/takeyuwebinc/gitfab2","forks_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/forks","keys_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/teams","hooks_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/hooks","issue_events_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/events{/number}","events_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/events","assignees_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/assignees{/user}","branches_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/branches{/branch}","tags_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/tags","blobs_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/refs{/sha}","trees_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/statuses/{sha}","languages_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/languages","stargazers_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/stargazers","contributors_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/contributors","subscribers_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/subscribers","subscription_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/subscription","commits_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/commits{/sha}","git_commits_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/git/commits{/sha}","comments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/comments{/number}","issue_comment_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/comments{/number}","contents_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/contents/{+path}","compare_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/merges","archive_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/downloads","issues_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues{/number}","pulls_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls{/number}","milestones_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/milestones{/number}","notifications_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/labels{/name}","releases_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/releases{/id}","deployments_url":"https://api.github.com/repos/takeyuwebinc/gitfab2/deployments","created_at":"2016-10-22T05:38:14Z","updated_at":"2018-08-08T12:04:23Z","pushed_at":"2018-08-08T12:09:09Z","git_url":"git://github.com/takeyuwebinc/gitfab2.git","ssh_url":"git@github.com:takeyuwebinc/gitfab2.git","clone_url":"https://github.com/takeyuwebinc/gitfab2.git","svn_url":"https://github.com/takeyuwebinc/gitfab2","homepage":"https://fabble.cc","size":5997,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37"},"html":{"href":"https://github.com/takeyuwebinc/gitfab2/pull/37"},"issue":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/37"},"comments":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/takeyuwebinc/gitfab2/statuses/b946938e48506a5c29b30eb08467c1ada32a040f"}},"author_association":"MEMBER"}} | {
"id": 71619232,
"name": "takeyuwebinc/gitfab2",
"url": "https://api.github.com/repos/takeyuwebinc/gitfab2"
} | {
"id": 2343568,
"login": "itkrt2y",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2343568?",
"url": "https://api.github.com/users/itkrt2y"
} | {
"id": 24970198,
"login": "takeyuwebinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24970198?",
"url": "https://api.github.com/orgs/takeyuwebinc"
} | 2018-08-08T15:00:32 | 8084551810 | {"actor":{"display_login":"itkrt2y"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/comments/182093436","pull_request_review_id":112835841,"id":182093436,"diff_hunk":"@@ -143,11 +143,46 @@ variable \"azurerm_apim_eventhub_rule\" {\n description = \"EventHub rule for API management\"\n }\n \n+# Notification HUB\n+\n variable \"azurerm_notification_hub_sku\" {\n type = \"string\"\n description = \"SKU (tier) of the Notification HUB\"\n }\n \n+variable \"notification_hub_apns_app_id\" {\n+ type = \"string\"\n+ description = \"APNS application Id\"\n+}\n+\n+variable \"notification_hub_apns_name\" {\n+ type = \"string\"\n+ description = \"APNS name\"\n+}\n+\n+variable \"notification_hub_apns_endpoint\" {\n+ type = \"string\"\n+ description = \"APNS endpoint (test or sandbox)\"\n+}\n+\n+# This should be passed by ENV var NOTIFICATION_HUB_APNS_KEY\n+variable \"NOTIFICATION_HUB_APNS_KEY\" {\n+ type = \"string\"\n+ description = \"APNS Key\"\n+}\n+\n+# This should be passed by ENV var TF_VARS_NOTIFICATION_HUB_APNS_KEY_ID","path":"infrastructure/azure.tf","position":32,"original_position":32,"commit_id":"5528b3fd0718d7af6f2558cb2f3ae312862ec3d5","original_commit_id":"5528b3fd0718d7af6f2558cb2f3ae312862ec3d5","user":{"login":"cloudify","id":48206,"avatar_url":"https://avatars2.githubusercontent.com/u/48206?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify","html_url":"https://github.com/cloudify","followers_url":"https://api.github.com/users/cloudify/followers","following_url":"https://api.github.com/users/cloudify/following{/other_user}","gists_url":"https://api.github.com/users/cloudify/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify/subscriptions","organizations_url":"https://api.github.com/users/cloudify/orgs","repos_url":"https://api.github.com/users/cloudify/repos","events_url":"https://api.github.com/users/cloudify/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify/received_events","type":"User","site_admin":false},"body":"`TF_VAR_...`","created_at":"2018-04-17T14:29:41Z","updated_at":"2018-04-17T14:30:38Z","html_url":"https://github.com/teamdigitale/digital-citizenship/pull/81#discussion_r182093436","pull_request_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/comments/182093436"},"html":{"href":"https://github.com/teamdigitale/digital-citizenship/pull/81#discussion_r182093436"},"pull_request":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81","id":182173046,"html_url":"https://github.com/teamdigitale/digital-citizenship/pull/81","diff_url":"https://github.com/teamdigitale/digital-citizenship/pull/81.diff","patch_url":"https://github.com/teamdigitale/digital-citizenship/pull/81.patch","issue_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/81","number":81,"state":"open","locked":false,"title":"[#156845313] add notification hub credentials","user":{"login":"gunzip","id":148224,"avatar_url":"https://avatars2.githubusercontent.com/u/148224?v=4","gravatar_id":"","url":"https://api.github.com/users/gunzip","html_url":"https://github.com/gunzip","followers_url":"https://api.github.com/users/gunzip/followers","following_url":"https://api.github.com/users/gunzip/following{/other_user}","gists_url":"https://api.github.com/users/gunzip/gists{/gist_id}","starred_url":"https://api.github.com/users/gunzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunzip/subscriptions","organizations_url":"https://api.github.com/users/gunzip/orgs","repos_url":"https://api.github.com/users/gunzip/repos","events_url":"https://api.github.com/users/gunzip/events{/privacy}","received_events_url":"https://api.github.com/users/gunzip/received_events","type":"User","site_admin":false},"body":"by now, we have no credentials for production","created_at":"2018-04-17T13:50:44Z","updated_at":"2018-04-17T14:30:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cec701cebc47212e22aa0a9100c72bab0dc442b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81/commits","review_comments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81/comments","review_comment_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/81/comments","statuses_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/statuses/5528b3fd0718d7af6f2558cb2f3ae312862ec3d5","head":{"label":"teamdigitale:156845313-notification-hub-creds","ref":"156845313-notification-hub-creds","sha":"5528b3fd0718d7af6f2558cb2f3ae312862ec3d5","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":92495628,"name":"digital-citizenship","full_name":"teamdigitale/digital-citizenship","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/digital-citizenship","description":"Main repository for the Digital Citizenship initiative of the Italian Government","fork":false,"url":"https://api.github.com/repos/teamdigitale/digital-citizenship","forks_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/forks","keys_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/teams","hooks_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/events","assignees_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/tags","blobs_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/subscription","commits_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/merges","archive_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/downloads","issues_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/deployments","created_at":"2017-05-26T09:36:17Z","updated_at":"2018-04-17T14:07:12Z","pushed_at":"2018-04-17T14:15:27Z","git_url":"git://github.com/teamdigitale/digital-citizenship.git","ssh_url":"git@github.com:teamdigitale/digital-citizenship.git","clone_url":"https://github.com/teamdigitale/digital-citizenship.git","svn_url":"https://github.com/teamdigitale/digital-citizenship","homepage":"https://teamdigitale.governo.it/it/projects/cittadinanza-digitale.htm","size":24301,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"teamdigitale:master","ref":"master","sha":"1d468bed4834baa7672f232ac9246d72ebd6679e","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":92495628,"name":"digital-citizenship","full_name":"teamdigitale/digital-citizenship","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/digital-citizenship","description":"Main repository for the Digital Citizenship initiative of the Italian Government","fork":false,"url":"https://api.github.com/repos/teamdigitale/digital-citizenship","forks_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/forks","keys_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/teams","hooks_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/events","assignees_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/tags","blobs_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/subscription","commits_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/merges","archive_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/downloads","issues_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/digital-citizenship/deployments","created_at":"2017-05-26T09:36:17Z","updated_at":"2018-04-17T14:07:12Z","pushed_at":"2018-04-17T14:15:27Z","git_url":"git://github.com/teamdigitale/digital-citizenship.git","ssh_url":"git@github.com:teamdigitale/digital-citizenship.git","clone_url":"https://github.com/teamdigitale/digital-citizenship.git","svn_url":"https://github.com/teamdigitale/digital-citizenship","homepage":"https://teamdigitale.governo.it/it/projects/cittadinanza-digitale.htm","size":24301,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81"},"html":{"href":"https://github.com/teamdigitale/digital-citizenship/pull/81"},"issue":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/81"},"comments":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/teamdigitale/digital-citizenship/statuses/5528b3fd0718d7af6f2558cb2f3ae312862ec3d5"}},"author_association":"COLLABORATOR"}} | {
"id": 92495628,
"name": "teamdigitale/digital-citizenship",
"url": "https://api.github.com/repos/teamdigitale/digital-citizenship"
} | {
"id": 48206,
"login": "cloudify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48206?",
"url": "https://api.github.com/users/cloudify"
} | {
"id": 25081492,
"login": "teamdigitale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25081492?",
"url": "https://api.github.com/orgs/teamdigitale"
} | 2018-04-17T14:29:41 | 7543023545 | {"actor":{"display_login":"cloudify"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments/183441826","pull_request_review_id":114439949,"id":183441826,"diff_hunk":"@@ -28,6 +28,8 @@ target 'ItaliaApp' do\n \n pod 'RNI18n', :path => '../node_modules/react-native-i18n'\n \n+ pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'","path":"ios/Podfile","position":4,"original_position":4,"commit_id":"452421338dfe8ae6b1ee63188f4be82c8c48ad6f","original_commit_id":"452421338dfe8ae6b1ee63188f4be82c8c48ad6f","user":{"login":"gunzip","id":148224,"avatar_url":"https://avatars2.githubusercontent.com/u/148224?v=4","gravatar_id":"","url":"https://api.github.com/users/gunzip","html_url":"https://github.com/gunzip","followers_url":"https://api.github.com/users/gunzip/followers","following_url":"https://api.github.com/users/gunzip/following{/other_user}","gists_url":"https://api.github.com/users/gunzip/gists{/gist_id}","starred_url":"https://api.github.com/users/gunzip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunzip/subscriptions","organizations_url":"https://api.github.com/users/gunzip/orgs","repos_url":"https://api.github.com/users/gunzip/repos","events_url":"https://api.github.com/users/gunzip/events{/privacy}","received_events_url":"https://api.github.com/users/gunzip/received_events","type":"User","site_admin":false},"body":"@matteodesanti do we have custom svg icons in the ui-kit ?","created_at":"2018-04-23T15:40:50Z","updated_at":"2018-04-23T16:05:01Z","html_url":"https://github.com/teamdigitale/italia-app/pull/97#discussion_r183441826","pull_request_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments/183441826"},"html":{"href":"https://github.com/teamdigitale/italia-app/pull/97#discussion_r183441826"},"pull_request":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97","id":183473447,"html_url":"https://github.com/teamdigitale/italia-app/pull/97","diff_url":"https://github.com/teamdigitale/italia-app/pull/97.diff","patch_url":"https://github.com/teamdigitale/italia-app/pull/97.patch","issue_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/97","number":97,"state":"open","locked":false,"title":"156913168 wallet credit cards","user":{"login":"alessiosaltarin","id":38555210,"avatar_url":"https://avatars2.githubusercontent.com/u/38555210?v=4","gravatar_id":"","url":"https://api.github.com/users/alessiosaltarin","html_url":"https://github.com/alessiosaltarin","followers_url":"https://api.github.com/users/alessiosaltarin/followers","following_url":"https://api.github.com/users/alessiosaltarin/following{/other_user}","gists_url":"https://api.github.com/users/alessiosaltarin/gists{/gist_id}","starred_url":"https://api.github.com/users/alessiosaltarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessiosaltarin/subscriptions","organizations_url":"https://api.github.com/users/alessiosaltarin/orgs","repos_url":"https://api.github.com/users/alessiosaltarin/repos","events_url":"https://api.github.com/users/alessiosaltarin/events{/privacy}","received_events_url":"https://api.github.com/users/alessiosaltarin/received_events","type":"User","site_admin":false},"body":"Prima PR di prova. Abbiamo implementato gli scheletri (la grafica è ancora molto approssimativa, ma c'è la navigazione e i controlli...) di \r\nhttps://projects.invisionapp.com/share/48GKAY7S9AZ#/screens/287731298\r\nNota: Flow dà errori sulla mancanza del modulo react-native. Il problema è segnalato qui: https://github.com/facebook/flow/issues/3875\r\n","created_at":"2018-04-23T15:31:23Z","updated_at":"2018-04-23T16:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc83c138e32b521bd31954749c99c57fad814840","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cloudify","id":48206,"avatar_url":"https://avatars2.githubusercontent.com/u/48206?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify","html_url":"https://github.com/cloudify","followers_url":"https://api.github.com/users/cloudify/followers","following_url":"https://api.github.com/users/cloudify/following{/other_user}","gists_url":"https://api.github.com/users/cloudify/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify/subscriptions","organizations_url":"https://api.github.com/users/cloudify/orgs","repos_url":"https://api.github.com/users/cloudify/repos","events_url":"https://api.github.com/users/cloudify/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify/received_events","type":"User","site_admin":false},{"login":"fpersico","id":30595520,"avatar_url":"https://avatars3.githubusercontent.com/u/30595520?v=4","gravatar_id":"","url":"https://api.github.com/users/fpersico","html_url":"https://github.com/fpersico","followers_url":"https://api.github.com/users/fpersico/followers","following_url":"https://api.github.com/users/fpersico/following{/other_user}","gists_url":"https://api.github.com/users/fpersico/gists{/gist_id}","starred_url":"https://api.github.com/users/fpersico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpersico/subscriptions","organizations_url":"https://api.github.com/users/fpersico/orgs","repos_url":"https://api.github.com/users/fpersico/repos","events_url":"https://api.github.com/users/fpersico/events{/privacy}","received_events_url":"https://api.github.com/users/fpersico/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97/commits","review_comments_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97/comments","review_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/97/comments","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/452421338dfe8ae6b1ee63188f4be82c8c48ad6f","head":{"label":"teamdigitale:156913168-wallet-credit-cards","ref":"156913168-wallet-credit-cards","sha":"452421338dfe8ae6b1ee63188f4be82c8c48ad6f","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":87916228,"name":"italia-app","full_name":"teamdigitale/italia-app","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-app","description":"App della Cittadinanza Digitale (mobile)","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-app","forks_url":"https://api.github.com/repos/teamdigitale/italia-app/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-app/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-app/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-app/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-app/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-app/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-app/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-app/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-app/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-app/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-app/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-app/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-app/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-app/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-app/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-app/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-app/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-app/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-app/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-app/deployments","created_at":"2017-04-11T09:34:46Z","updated_at":"2018-04-23T14:36:52Z","pushed_at":"2018-04-23T15:31:23Z","git_url":"git://github.com/teamdigitale/italia-app.git","ssh_url":"git@github.com:teamdigitale/italia-app.git","clone_url":"https://github.com/teamdigitale/italia-app.git","svn_url":"https://github.com/teamdigitale/italia-app","homepage":"","size":14553,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":10,"watchers":8,"default_branch":"master"}},"base":{"label":"teamdigitale:master","ref":"master","sha":"a1378a007f9c350ffe46500319ca8940917134d6","user":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"repo":{"id":87916228,"name":"italia-app","full_name":"teamdigitale/italia-app","owner":{"login":"teamdigitale","id":25081492,"avatar_url":"https://avatars0.githubusercontent.com/u/25081492?v=4","gravatar_id":"","url":"https://api.github.com/users/teamdigitale","html_url":"https://github.com/teamdigitale","followers_url":"https://api.github.com/users/teamdigitale/followers","following_url":"https://api.github.com/users/teamdigitale/following{/other_user}","gists_url":"https://api.github.com/users/teamdigitale/gists{/gist_id}","starred_url":"https://api.github.com/users/teamdigitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamdigitale/subscriptions","organizations_url":"https://api.github.com/users/teamdigitale/orgs","repos_url":"https://api.github.com/users/teamdigitale/repos","events_url":"https://api.github.com/users/teamdigitale/events{/privacy}","received_events_url":"https://api.github.com/users/teamdigitale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamdigitale/italia-app","description":"App della Cittadinanza Digitale (mobile)","fork":false,"url":"https://api.github.com/repos/teamdigitale/italia-app","forks_url":"https://api.github.com/repos/teamdigitale/italia-app/forks","keys_url":"https://api.github.com/repos/teamdigitale/italia-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamdigitale/italia-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamdigitale/italia-app/teams","hooks_url":"https://api.github.com/repos/teamdigitale/italia-app/hooks","issue_events_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/events{/number}","events_url":"https://api.github.com/repos/teamdigitale/italia-app/events","assignees_url":"https://api.github.com/repos/teamdigitale/italia-app/assignees{/user}","branches_url":"https://api.github.com/repos/teamdigitale/italia-app/branches{/branch}","tags_url":"https://api.github.com/repos/teamdigitale/italia-app/tags","blobs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamdigitale/italia-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamdigitale/italia-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamdigitale/italia-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamdigitale/italia-app/statuses/{sha}","languages_url":"https://api.github.com/repos/teamdigitale/italia-app/languages","stargazers_url":"https://api.github.com/repos/teamdigitale/italia-app/stargazers","contributors_url":"https://api.github.com/repos/teamdigitale/italia-app/contributors","subscribers_url":"https://api.github.com/repos/teamdigitale/italia-app/subscribers","subscription_url":"https://api.github.com/repos/teamdigitale/italia-app/subscription","commits_url":"https://api.github.com/repos/teamdigitale/italia-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamdigitale/italia-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamdigitale/italia-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamdigitale/italia-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamdigitale/italia-app/contents/{+path}","compare_url":"https://api.github.com/repos/teamdigitale/italia-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamdigitale/italia-app/merges","archive_url":"https://api.github.com/repos/teamdigitale/italia-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamdigitale/italia-app/downloads","issues_url":"https://api.github.com/repos/teamdigitale/italia-app/issues{/number}","pulls_url":"https://api.github.com/repos/teamdigitale/italia-app/pulls{/number}","milestones_url":"https://api.github.com/repos/teamdigitale/italia-app/milestones{/number}","notifications_url":"https://api.github.com/repos/teamdigitale/italia-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamdigitale/italia-app/labels{/name}","releases_url":"https://api.github.com/repos/teamdigitale/italia-app/releases{/id}","deployments_url":"https://api.github.com/repos/teamdigitale/italia-app/deployments","created_at":"2017-04-11T09:34:46Z","updated_at":"2018-04-23T14:36:52Z","pushed_at":"2018-04-23T15:31:23Z","git_url":"git://github.com/teamdigitale/italia-app.git","ssh_url":"git@github.com:teamdigitale/italia-app.git","clone_url":"https://github.com/teamdigitale/italia-app.git","svn_url":"https://github.com/teamdigitale/italia-app","homepage":"","size":14553,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97"},"html":{"href":"https://github.com/teamdigitale/italia-app/pull/97"},"issue":{"href":"https://api.github.com/repos/teamdigitale/italia-app/issues/97"},"comments":{"href":"https://api.github.com/repos/teamdigitale/italia-app/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamdigitale/italia-app/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/teamdigitale/italia-app/statuses/452421338dfe8ae6b1ee63188f4be82c8c48ad6f"}},"author_association":"NONE"}} | {
"id": 87916228,
"name": "teamdigitale/italia-app",
"url": "https://api.github.com/repos/teamdigitale/italia-app"
} | {
"id": 148224,
"login": "gunzip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/148224?",
"url": "https://api.github.com/users/gunzip"
} | {
"id": 25081492,
"login": "teamdigitale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25081492?",
"url": "https://api.github.com/orgs/teamdigitale"
} | 2018-04-23T15:40:50 | 7572881777 | {"actor":{"display_login":"gunzip"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/comments/211586664","pull_request_review_id":148035881,"id":211586664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU4NjY2NA==","diff_hunk":"@@ -0,0 +1,66 @@\n+<?php\n+\n+/**\n+ * MIT License\n+ * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.\n+ */\n+\n+namespace SprykerEco\\Zed\\Sevensenders\\Business;\n+\n+use Generated\\Shared\\Transfer\\SevensendersTokenTransfer;\n+use Spryker\\Zed\\Kernel\\Business\\AbstractFacade;\n+\n+/**\n+ * @method \\SprykerEco\\Zed\\Sevensenders\\Business\\SevensendersBusinessFactory getFactory()\n+ * @method \\SprykerEco\\Zed\\Sevensenders\\Persistence\\SevensendersRepositoryInterface getRepository()()","path":"src/SprykerEco/Zed/Sevensenders/Business/SevensendersFacade.php","position":15,"original_position":15,"commit_id":"e988f0ba3f7d969bcf42987df2975042c769553a","original_commit_id":"e988f0ba3f7d969bcf42987df2975042c769553a","user":{"login":"dereuromark","id":39854,"node_id":"MDQ6VXNlcjM5ODU0","avatar_url":"https://avatars0.githubusercontent.com/u/39854?v=4","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"body":"invalid () syntax.","created_at":"2018-08-21T12:32:51Z","updated_at":"2018-08-21T12:32:52Z","html_url":"https://github.com/spryker-eco/sevensenders/pull/1#discussion_r211586664","pull_request_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/comments/211586664"},"html":{"href":"https://github.com/spryker-eco/sevensenders/pull/1#discussion_r211586664"},"pull_request":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1","id":209807326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODA3MzI2","html_url":"https://github.com/spryker-eco/sevensenders/pull/1","diff_url":"https://github.com/spryker-eco/sevensenders/pull/1.diff","patch_url":"https://github.com/spryker-eco/sevensenders/pull/1.patch","issue_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Release 1.0.0","user":{"login":"vhrychenko","id":8993180,"node_id":"MDQ6VXNlcjg5OTMxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/8993180?v=4","gravatar_id":"","url":"https://api.github.com/users/vhrychenko","html_url":"https://github.com/vhrychenko","followers_url":"https://api.github.com/users/vhrychenko/followers","following_url":"https://api.github.com/users/vhrychenko/following{/other_user}","gists_url":"https://api.github.com/users/vhrychenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vhrychenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhrychenko/subscriptions","organizations_url":"https://api.github.com/users/vhrychenko/orgs","repos_url":"https://api.github.com/users/vhrychenko/repos","events_url":"https://api.github.com/users/vhrychenko/events{/privacy}","received_events_url":"https://api.github.com/users/vhrychenko/received_events","type":"User","site_admin":false},"body":"- Developer(s): @vhrychenko\r\n\r\n- Peer Reviewer: \r\n\r\n- Tickets:\r\n https://spryker.atlassian.net/browse/ECO-1924\r\n\r\n- Academy PR: \r\n\r\n\r\n#### Please confirm\r\n\r\n- [x] No new OS components - or they have been approved by the legal department\r\n- [x] All new or heavily changed classes get an \"A\" rating (Scrutinizer), except Facades, Factories, QueryContainers and Tests\r\n\r\n#### Documentation\r\n\r\n- [x] Functional documentation provided or in progress?\r\n- [x] Integration guide for projects provided or not needed?\r\n- [x] Migration guides for all contained majors provided or not needed?\r\n\r\n#### Release Table\r\n\r\n Module | Release Type | Constraints |\r\n :--------------------- | :------------------------ | :--------------------- |\r\n Sevensenders | major | |\r\n\r\n#### Release Notes\r\n - 1.0.0 version for sevensenders module.\r\n\r\n-----------------------------------------\r\n\r\n#### Module AkeneoPim\r\n\r\n_**Patch:** Backwards-compatible bug fix_\r\n\r\nDef of done (by the responsible developer):\r\n- [x] All changes are backwards-compatible. The outdated code is marked as deprecated.\r\n- [x] The change is isolated and not mixed with any cleanups or other changes.\r\n- [x] New code fits the architecture rules.\r\n- [x] All new or changed business logic is covered by functional tests (in Zed business layer).\r\n\r\n##### Change log\r\n - 1.0 version for Sevensenders module.\r\n\r\n\r\n","created_at":"2018-08-21T12:23:40Z","updated_at":"2018-08-21T12:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e8863d1e0bba7956d2cd68373880688b982f826","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1/commits","review_comments_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1/comments","review_comment_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/1/comments","statuses_url":"https://api.github.com/repos/spryker-eco/sevensenders/statuses/e988f0ba3f7d969bcf42987df2975042c769553a","head":{"label":"spryker-eco:feature/eco-1924/dev-sevensenders","ref":"feature/eco-1924/dev-sevensenders","sha":"e988f0ba3f7d969bcf42987df2975042c769553a","user":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":144585177,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1ODUxNzc=","name":"sevensenders","full_name":"spryker-eco/sevensenders","owner":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spryker-eco/sevensenders","description":null,"fork":false,"url":"https://api.github.com/repos/spryker-eco/sevensenders","forks_url":"https://api.github.com/repos/spryker-eco/sevensenders/forks","keys_url":"https://api.github.com/repos/spryker-eco/sevensenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker-eco/sevensenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker-eco/sevensenders/teams","hooks_url":"https://api.github.com/repos/spryker-eco/sevensenders/hooks","issue_events_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/events{/number}","events_url":"https://api.github.com/repos/spryker-eco/sevensenders/events","assignees_url":"https://api.github.com/repos/spryker-eco/sevensenders/assignees{/user}","branches_url":"https://api.github.com/repos/spryker-eco/sevensenders/branches{/branch}","tags_url":"https://api.github.com/repos/spryker-eco/sevensenders/tags","blobs_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker-eco/sevensenders/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker-eco/sevensenders/languages","stargazers_url":"https://api.github.com/repos/spryker-eco/sevensenders/stargazers","contributors_url":"https://api.github.com/repos/spryker-eco/sevensenders/contributors","subscribers_url":"https://api.github.com/repos/spryker-eco/sevensenders/subscribers","subscription_url":"https://api.github.com/repos/spryker-eco/sevensenders/subscription","commits_url":"https://api.github.com/repos/spryker-eco/sevensenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker-eco/sevensenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker-eco/sevensenders/contents/{+path}","compare_url":"https://api.github.com/repos/spryker-eco/sevensenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker-eco/sevensenders/merges","archive_url":"https://api.github.com/repos/spryker-eco/sevensenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker-eco/sevensenders/downloads","issues_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues{/number}","pulls_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker-eco/sevensenders/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker-eco/sevensenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker-eco/sevensenders/labels{/name}","releases_url":"https://api.github.com/repos/spryker-eco/sevensenders/releases{/id}","deployments_url":"https://api.github.com/repos/spryker-eco/sevensenders/deployments","created_at":"2018-08-13T13:41:46Z","updated_at":"2018-08-14T14:54:57Z","pushed_at":"2018-08-21T12:23:41Z","git_url":"git://github.com/spryker-eco/sevensenders.git","ssh_url":"git@github.com:spryker-eco/sevensenders.git","clone_url":"https://github.com/spryker-eco/sevensenders.git","svn_url":"https://github.com/spryker-eco/sevensenders","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"spryker-eco:feature/eco-1924/master-sevensenders","ref":"feature/eco-1924/master-sevensenders","sha":"1170833889440b757960406e9458e277db4f50f4","user":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":144585177,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1ODUxNzc=","name":"sevensenders","full_name":"spryker-eco/sevensenders","owner":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spryker-eco/sevensenders","description":null,"fork":false,"url":"https://api.github.com/repos/spryker-eco/sevensenders","forks_url":"https://api.github.com/repos/spryker-eco/sevensenders/forks","keys_url":"https://api.github.com/repos/spryker-eco/sevensenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker-eco/sevensenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker-eco/sevensenders/teams","hooks_url":"https://api.github.com/repos/spryker-eco/sevensenders/hooks","issue_events_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/events{/number}","events_url":"https://api.github.com/repos/spryker-eco/sevensenders/events","assignees_url":"https://api.github.com/repos/spryker-eco/sevensenders/assignees{/user}","branches_url":"https://api.github.com/repos/spryker-eco/sevensenders/branches{/branch}","tags_url":"https://api.github.com/repos/spryker-eco/sevensenders/tags","blobs_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker-eco/sevensenders/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker-eco/sevensenders/languages","stargazers_url":"https://api.github.com/repos/spryker-eco/sevensenders/stargazers","contributors_url":"https://api.github.com/repos/spryker-eco/sevensenders/contributors","subscribers_url":"https://api.github.com/repos/spryker-eco/sevensenders/subscribers","subscription_url":"https://api.github.com/repos/spryker-eco/sevensenders/subscription","commits_url":"https://api.github.com/repos/spryker-eco/sevensenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker-eco/sevensenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker-eco/sevensenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker-eco/sevensenders/contents/{+path}","compare_url":"https://api.github.com/repos/spryker-eco/sevensenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker-eco/sevensenders/merges","archive_url":"https://api.github.com/repos/spryker-eco/sevensenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker-eco/sevensenders/downloads","issues_url":"https://api.github.com/repos/spryker-eco/sevensenders/issues{/number}","pulls_url":"https://api.github.com/repos/spryker-eco/sevensenders/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker-eco/sevensenders/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker-eco/sevensenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker-eco/sevensenders/labels{/name}","releases_url":"https://api.github.com/repos/spryker-eco/sevensenders/releases{/id}","deployments_url":"https://api.github.com/repos/spryker-eco/sevensenders/deployments","created_at":"2018-08-13T13:41:46Z","updated_at":"2018-08-14T14:54:57Z","pushed_at":"2018-08-21T12:23:41Z","git_url":"git://github.com/spryker-eco/sevensenders.git","ssh_url":"git@github.com:spryker-eco/sevensenders.git","clone_url":"https://github.com/spryker-eco/sevensenders.git","svn_url":"https://github.com/spryker-eco/sevensenders","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1"},"html":{"href":"https://github.com/spryker-eco/sevensenders/pull/1"},"issue":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/issues/1"},"comments":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/spryker-eco/sevensenders/statuses/e988f0ba3f7d969bcf42987df2975042c769553a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 144585177,
"name": "spryker-eco/sevensenders",
"url": "https://api.github.com/repos/spryker-eco/sevensenders"
} | {
"id": 39854,
"login": "dereuromark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39854?",
"url": "https://api.github.com/users/dereuromark"
} | {
"id": 25103059,
"login": "spryker-eco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25103059?",
"url": "https://api.github.com/orgs/spryker-eco"
} | 2018-08-21T12:32:51 | 8143927011 | {"actor":{"display_login":"dereuromark"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/spryker-eco/braintree/pulls/comments/241986496","pull_request_review_id":185394169,"id":241986496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk4NjQ5Ng==","diff_hunk":"@@ -0,0 +1,20 @@\n+@mixin braintree-credit-card($name: '.credit-card') {\n+ #{$name} {\n+ &__field {\n+ @include helper-effect-transition(border-color);\n+ height: 1.95rem;\n+ padding: 0.25rem 0.5rem;\n+ border: 1px solid $setting-color-input-border;\n+ }\n+\n+ .braintree-hosted-fields-focused {","path":"src/SprykerEco/Yves/Braintree/Theme/default/components/molecules/credit-card/credit-card.scss","position":10,"original_position":10,"commit_id":"24b93c07ebc466b41c96e571297665d9416efb22","original_commit_id":"24b93c07ebc466b41c96e571297665d9416efb22","user":{"login":"tolerants","id":4608661,"node_id":"MDQ6VXNlcjQ2MDg2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4608661?v=4","gravatar_id":"","url":"https://api.github.com/users/tolerants","html_url":"https://github.com/tolerants","followers_url":"https://api.github.com/users/tolerants/followers","following_url":"https://api.github.com/users/tolerants/following{/other_user}","gists_url":"https://api.github.com/users/tolerants/gists{/gist_id}","starred_url":"https://api.github.com/users/tolerants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tolerants/subscriptions","organizations_url":"https://api.github.com/users/tolerants/orgs","repos_url":"https://api.github.com/users/tolerants/repos","events_url":"https://api.github.com/users/tolerants/events{/privacy}","received_events_url":"https://api.github.com/users/tolerants/received_events","type":"User","site_admin":false},"body":"Why you cann't use `:focus` here?","created_at":"2018-12-16T16:18:27Z","updated_at":"2018-12-16T16:51:24Z","html_url":"https://github.com/spryker-eco/braintree/pull/6#discussion_r241986496","pull_request_url":"https://api.github.com/repos/spryker-eco/braintree/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/comments/241986496"},"html":{"href":"https://github.com/spryker-eco/braintree/pull/6#discussion_r241986496"},"pull_request":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/spryker-eco/braintree/pulls/6","id":238107426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTA3NDI2","html_url":"https://github.com/spryker-eco/braintree/pull/6","diff_url":"https://github.com/spryker-eco/braintree/pull/6.diff","patch_url":"https://github.com/spryker-eco/braintree/pull/6.patch","issue_url":"https://api.github.com/repos/spryker-eco/braintree/issues/6","number":6,"state":"open","locked":false,"title":"Feature/eco 2212/eco 2237 compatibility with shop suite","user":{"login":"danilmoro3","id":42937797,"node_id":"MDQ6VXNlcjQyOTM3Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/42937797?v=4","gravatar_id":"","url":"https://api.github.com/users/danilmoro3","html_url":"https://github.com/danilmoro3","followers_url":"https://api.github.com/users/danilmoro3/followers","following_url":"https://api.github.com/users/danilmoro3/following{/other_user}","gists_url":"https://api.github.com/users/danilmoro3/gists{/gist_id}","starred_url":"https://api.github.com/users/danilmoro3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilmoro3/subscriptions","organizations_url":"https://api.github.com/users/danilmoro3/orgs","repos_url":"https://api.github.com/users/danilmoro3/repos","events_url":"https://api.github.com/users/danilmoro3/events{/privacy}","received_events_url":"https://api.github.com/users/danilmoro3/received_events","type":"User","site_admin":false},"body":"Ticket: https://spryker.atlassian.net/browse/ECO-2237","created_at":"2018-12-12T16:48:09Z","updated_at":"2018-12-16T16:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d57c8f0872708bcf0c916f3ec53ef36a484bd69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spryker-eco/braintree/pulls/6/commits","review_comments_url":"https://api.github.com/repos/spryker-eco/braintree/pulls/6/comments","review_comment_url":"https://api.github.com/repos/spryker-eco/braintree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spryker-eco/braintree/issues/6/comments","statuses_url":"https://api.github.com/repos/spryker-eco/braintree/statuses/24b93c07ebc466b41c96e571297665d9416efb22","head":{"label":"spryker-eco:feature/eco-2212/eco-2237-compatibility-with-shop-suite","ref":"feature/eco-2212/eco-2237-compatibility-with-shop-suite","sha":"24b93c07ebc466b41c96e571297665d9416efb22","user":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":104864902,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4NjQ5MDI=","name":"braintree","full_name":"spryker-eco/braintree","private":false,"owner":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spryker-eco/braintree","description":"Spryker Eco Braintree module","fork":false,"url":"https://api.github.com/repos/spryker-eco/braintree","forks_url":"https://api.github.com/repos/spryker-eco/braintree/forks","keys_url":"https://api.github.com/repos/spryker-eco/braintree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker-eco/braintree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker-eco/braintree/teams","hooks_url":"https://api.github.com/repos/spryker-eco/braintree/hooks","issue_events_url":"https://api.github.com/repos/spryker-eco/braintree/issues/events{/number}","events_url":"https://api.github.com/repos/spryker-eco/braintree/events","assignees_url":"https://api.github.com/repos/spryker-eco/braintree/assignees{/user}","branches_url":"https://api.github.com/repos/spryker-eco/braintree/branches{/branch}","tags_url":"https://api.github.com/repos/spryker-eco/braintree/tags","blobs_url":"https://api.github.com/repos/spryker-eco/braintree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker-eco/braintree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker-eco/braintree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker-eco/braintree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker-eco/braintree/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker-eco/braintree/languages","stargazers_url":"https://api.github.com/repos/spryker-eco/braintree/stargazers","contributors_url":"https://api.github.com/repos/spryker-eco/braintree/contributors","subscribers_url":"https://api.github.com/repos/spryker-eco/braintree/subscribers","subscription_url":"https://api.github.com/repos/spryker-eco/braintree/subscription","commits_url":"https://api.github.com/repos/spryker-eco/braintree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker-eco/braintree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker-eco/braintree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker-eco/braintree/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker-eco/braintree/contents/{+path}","compare_url":"https://api.github.com/repos/spryker-eco/braintree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker-eco/braintree/merges","archive_url":"https://api.github.com/repos/spryker-eco/braintree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker-eco/braintree/downloads","issues_url":"https://api.github.com/repos/spryker-eco/braintree/issues{/number}","pulls_url":"https://api.github.com/repos/spryker-eco/braintree/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker-eco/braintree/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker-eco/braintree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker-eco/braintree/labels{/name}","releases_url":"https://api.github.com/repos/spryker-eco/braintree/releases{/id}","deployments_url":"https://api.github.com/repos/spryker-eco/braintree/deployments","created_at":"2017-09-26T09:30:05Z","updated_at":"2018-08-16T10:05:25Z","pushed_at":"2018-12-13T15:03:25Z","git_url":"git://github.com/spryker-eco/braintree.git","ssh_url":"git@github.com:spryker-eco/braintree.git","clone_url":"https://github.com/spryker-eco/braintree.git","svn_url":"https://github.com/spryker-eco/braintree","homepage":"https://spryker.com","size":673,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"spryker-eco:feature/eco-2212-upgrade-module-to-suite-compatibility","ref":"feature/eco-2212-upgrade-module-to-suite-compatibility","sha":"faff51bc008974357c15f61098fc950c9d0ea8d7","user":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":104864902,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4NjQ5MDI=","name":"braintree","full_name":"spryker-eco/braintree","private":false,"owner":{"login":"spryker-eco","id":25103059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTAzMDU5","avatar_url":"https://avatars2.githubusercontent.com/u/25103059?v=4","gravatar_id":"","url":"https://api.github.com/users/spryker-eco","html_url":"https://github.com/spryker-eco","followers_url":"https://api.github.com/users/spryker-eco/followers","following_url":"https://api.github.com/users/spryker-eco/following{/other_user}","gists_url":"https://api.github.com/users/spryker-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/spryker-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spryker-eco/subscriptions","organizations_url":"https://api.github.com/users/spryker-eco/orgs","repos_url":"https://api.github.com/users/spryker-eco/repos","events_url":"https://api.github.com/users/spryker-eco/events{/privacy}","received_events_url":"https://api.github.com/users/spryker-eco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spryker-eco/braintree","description":"Spryker Eco Braintree module","fork":false,"url":"https://api.github.com/repos/spryker-eco/braintree","forks_url":"https://api.github.com/repos/spryker-eco/braintree/forks","keys_url":"https://api.github.com/repos/spryker-eco/braintree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spryker-eco/braintree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spryker-eco/braintree/teams","hooks_url":"https://api.github.com/repos/spryker-eco/braintree/hooks","issue_events_url":"https://api.github.com/repos/spryker-eco/braintree/issues/events{/number}","events_url":"https://api.github.com/repos/spryker-eco/braintree/events","assignees_url":"https://api.github.com/repos/spryker-eco/braintree/assignees{/user}","branches_url":"https://api.github.com/repos/spryker-eco/braintree/branches{/branch}","tags_url":"https://api.github.com/repos/spryker-eco/braintree/tags","blobs_url":"https://api.github.com/repos/spryker-eco/braintree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spryker-eco/braintree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spryker-eco/braintree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spryker-eco/braintree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spryker-eco/braintree/statuses/{sha}","languages_url":"https://api.github.com/repos/spryker-eco/braintree/languages","stargazers_url":"https://api.github.com/repos/spryker-eco/braintree/stargazers","contributors_url":"https://api.github.com/repos/spryker-eco/braintree/contributors","subscribers_url":"https://api.github.com/repos/spryker-eco/braintree/subscribers","subscription_url":"https://api.github.com/repos/spryker-eco/braintree/subscription","commits_url":"https://api.github.com/repos/spryker-eco/braintree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spryker-eco/braintree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spryker-eco/braintree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spryker-eco/braintree/issues/comments{/number}","contents_url":"https://api.github.com/repos/spryker-eco/braintree/contents/{+path}","compare_url":"https://api.github.com/repos/spryker-eco/braintree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spryker-eco/braintree/merges","archive_url":"https://api.github.com/repos/spryker-eco/braintree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spryker-eco/braintree/downloads","issues_url":"https://api.github.com/repos/spryker-eco/braintree/issues{/number}","pulls_url":"https://api.github.com/repos/spryker-eco/braintree/pulls{/number}","milestones_url":"https://api.github.com/repos/spryker-eco/braintree/milestones{/number}","notifications_url":"https://api.github.com/repos/spryker-eco/braintree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spryker-eco/braintree/labels{/name}","releases_url":"https://api.github.com/repos/spryker-eco/braintree/releases{/id}","deployments_url":"https://api.github.com/repos/spryker-eco/braintree/deployments","created_at":"2017-09-26T09:30:05Z","updated_at":"2018-08-16T10:05:25Z","pushed_at":"2018-12-13T15:03:25Z","git_url":"git://github.com/spryker-eco/braintree.git","ssh_url":"git@github.com:spryker-eco/braintree.git","clone_url":"https://github.com/spryker-eco/braintree.git","svn_url":"https://github.com/spryker-eco/braintree","homepage":"https://spryker.com","size":673,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/6"},"html":{"href":"https://github.com/spryker-eco/braintree/pull/6"},"issue":{"href":"https://api.github.com/repos/spryker-eco/braintree/issues/6"},"comments":{"href":"https://api.github.com/repos/spryker-eco/braintree/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spryker-eco/braintree/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/spryker-eco/braintree/statuses/24b93c07ebc466b41c96e571297665d9416efb22"}},"author_association":"NONE"}} | {
"id": 104864902,
"name": "spryker-eco/braintree",
"url": "https://api.github.com/repos/spryker-eco/braintree"
} | {
"id": 4608661,
"login": "tolerants",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4608661?",
"url": "https://api.github.com/users/tolerants"
} | {
"id": 25103059,
"login": "spryker-eco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25103059?",
"url": "https://api.github.com/orgs/spryker-eco"
} | 2018-12-16T16:18:27 | 8761385088 | {"actor":{"display_login":"tolerants"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dirigeants/klasa/pulls/comments/183402950","pull_request_review_id":114393243,"id":183402950,"diff_hunk":"@@ -16,17 +16,11 @@ module.exports = class extends Command {\n \n \tasync run(msg, [code]) {\n \t\tconst { success, result, time, type } = await this.eval(msg, code);\n-\t\tconst footer = this.client.methods.util.codeBlock('ts', type);\n+\t\tconst footer = this.client.methods.util.codeBlock('ts', type.toString());","path":"src/commands/Admin/eval.js","position":5,"original_position":5,"commit_id":"1c58aa12c042e5a0cbbbbf283e2c6e758c8c1b08","original_commit_id":"1c58aa12c042e5a0cbbbbf283e2c6e758c8c1b08","user":{"login":"bdistin","id":18535830,"avatar_url":"https://avatars2.githubusercontent.com/u/18535830?v=4","gravatar_id":"","url":"https://api.github.com/users/bdistin","html_url":"https://github.com/bdistin","followers_url":"https://api.github.com/users/bdistin/followers","following_url":"https://api.github.com/users/bdistin/following{/other_user}","gists_url":"https://api.github.com/users/bdistin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdistin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdistin/subscriptions","organizations_url":"https://api.github.com/users/bdistin/orgs","repos_url":"https://api.github.com/users/bdistin/repos","events_url":"https://api.github.com/users/bdistin/events{/privacy}","received_events_url":"https://api.github.com/users/bdistin/received_events","type":"User","site_admin":false},"body":"unnecessary, util.codeBlock concatenates the object in a template literal, which automatically calls toString() on the object.","created_at":"2018-04-23T13:54:49Z","updated_at":"2018-04-23T13:56:33Z","html_url":"https://github.com/dirigeants/klasa/pull/278#discussion_r183402950","pull_request_url":"https://api.github.com/repos/dirigeants/klasa/pulls/278","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/comments/183402950"},"html":{"href":"https://github.com/dirigeants/klasa/pull/278#discussion_r183402950"},"pull_request":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/dirigeants/klasa/pulls/278","id":183089231,"html_url":"https://github.com/dirigeants/klasa/pull/278","diff_url":"https://github.com/dirigeants/klasa/pull/278.diff","patch_url":"https://github.com/dirigeants/klasa/pull/278.patch","issue_url":"https://api.github.com/repos/dirigeants/klasa/issues/278","number":278,"state":"open","locked":false,"title":"Made changes to eval cmd","user":{"login":"tech6hutch","id":25398066,"avatar_url":"https://avatars1.githubusercontent.com/u/25398066?v=4","gravatar_id":"","url":"https://api.github.com/users/tech6hutch","html_url":"https://github.com/tech6hutch","followers_url":"https://api.github.com/users/tech6hutch/followers","following_url":"https://api.github.com/users/tech6hutch/following{/other_user}","gists_url":"https://api.github.com/users/tech6hutch/gists{/gist_id}","starred_url":"https://api.github.com/users/tech6hutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech6hutch/subscriptions","organizations_url":"https://api.github.com/users/tech6hutch/orgs","repos_url":"https://api.github.com/users/tech6hutch/repos","events_url":"https://api.github.com/users/tech6hutch/events{/privacy}","received_events_url":"https://api.github.com/users/tech6hutch/received_events","type":"User","site_admin":false},"body":"### Description of the PR\r\nMade changes to eval command, some discussed in chat.\r\n\r\n### Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)\r\n- in `run`:\r\n - `type` can be either a Type object or undefined\r\n - remove error emitting block\r\n- in `eval`:\r\n - destructure `flags` since it's used a lot\r\n - add error emitting to catch block\r\n\r\n### Semver Classification\r\n\r\n- [ ] This PR only includes documentation or non-code changes.\r\n- [x] This PR fixes a bug and does not change the (intended) framework interface.\r\n- [ ] This PR adds methods or properties to the framework interface.\r\n- [ ] This PR removes or renames methods or properties in the framework interface.\r\n","created_at":"2018-04-20T15:02:13Z","updated_at":"2018-04-23T13:56:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a50f2417031e0727351617cd67fc7a0fb3ccd0d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831701071,"url":"https://api.github.com/repos/dirigeants/klasa/labels/Meta:%20BugFix","name":"Meta: BugFix","color":"4cce4a","default":false},{"id":907051137,"url":"https://api.github.com/repos/dirigeants/klasa/labels/Meta:%20Cleanup","name":"Meta: Cleanup","color":"ffff00","default":false},{"id":841695960,"url":"https://api.github.com/repos/dirigeants/klasa/labels/Meta:%20Error%20Handling","name":"Meta: Error Handling","color":"ffff00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dirigeants/klasa/pulls/278/commits","review_comments_url":"https://api.github.com/repos/dirigeants/klasa/pulls/278/comments","review_comment_url":"https://api.github.com/repos/dirigeants/klasa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dirigeants/klasa/issues/278/comments","statuses_url":"https://api.github.com/repos/dirigeants/klasa/statuses/1c58aa12c042e5a0cbbbbf283e2c6e758c8c1b08","head":{"label":"tech6hutch:eval-changes","ref":"eval-changes","sha":"1c58aa12c042e5a0cbbbbf283e2c6e758c8c1b08","user":{"login":"tech6hutch","id":25398066,"avatar_url":"https://avatars1.githubusercontent.com/u/25398066?v=4","gravatar_id":"","url":"https://api.github.com/users/tech6hutch","html_url":"https://github.com/tech6hutch","followers_url":"https://api.github.com/users/tech6hutch/followers","following_url":"https://api.github.com/users/tech6hutch/following{/other_user}","gists_url":"https://api.github.com/users/tech6hutch/gists{/gist_id}","starred_url":"https://api.github.com/users/tech6hutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech6hutch/subscriptions","organizations_url":"https://api.github.com/users/tech6hutch/orgs","repos_url":"https://api.github.com/users/tech6hutch/repos","events_url":"https://api.github.com/users/tech6hutch/events{/privacy}","received_events_url":"https://api.github.com/users/tech6hutch/received_events","type":"User","site_admin":false},"repo":{"id":105169940,"name":"klasa","full_name":"tech6hutch/klasa","owner":{"login":"tech6hutch","id":25398066,"avatar_url":"https://avatars1.githubusercontent.com/u/25398066?v=4","gravatar_id":"","url":"https://api.github.com/users/tech6hutch","html_url":"https://github.com/tech6hutch","followers_url":"https://api.github.com/users/tech6hutch/followers","following_url":"https://api.github.com/users/tech6hutch/following{/other_user}","gists_url":"https://api.github.com/users/tech6hutch/gists{/gist_id}","starred_url":"https://api.github.com/users/tech6hutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech6hutch/subscriptions","organizations_url":"https://api.github.com/users/tech6hutch/orgs","repos_url":"https://api.github.com/users/tech6hutch/repos","events_url":"https://api.github.com/users/tech6hutch/events{/privacy}","received_events_url":"https://api.github.com/users/tech6hutch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tech6hutch/klasa","description":"A class remix on the Komada Bot Framework","fork":true,"url":"https://api.github.com/repos/tech6hutch/klasa","forks_url":"https://api.github.com/repos/tech6hutch/klasa/forks","keys_url":"https://api.github.com/repos/tech6hutch/klasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tech6hutch/klasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tech6hutch/klasa/teams","hooks_url":"https://api.github.com/repos/tech6hutch/klasa/hooks","issue_events_url":"https://api.github.com/repos/tech6hutch/klasa/issues/events{/number}","events_url":"https://api.github.com/repos/tech6hutch/klasa/events","assignees_url":"https://api.github.com/repos/tech6hutch/klasa/assignees{/user}","branches_url":"https://api.github.com/repos/tech6hutch/klasa/branches{/branch}","tags_url":"https://api.github.com/repos/tech6hutch/klasa/tags","blobs_url":"https://api.github.com/repos/tech6hutch/klasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tech6hutch/klasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tech6hutch/klasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/tech6hutch/klasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tech6hutch/klasa/statuses/{sha}","languages_url":"https://api.github.com/repos/tech6hutch/klasa/languages","stargazers_url":"https://api.github.com/repos/tech6hutch/klasa/stargazers","contributors_url":"https://api.github.com/repos/tech6hutch/klasa/contributors","subscribers_url":"https://api.github.com/repos/tech6hutch/klasa/subscribers","subscription_url":"https://api.github.com/repos/tech6hutch/klasa/subscription","commits_url":"https://api.github.com/repos/tech6hutch/klasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/tech6hutch/klasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/tech6hutch/klasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/tech6hutch/klasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/tech6hutch/klasa/contents/{+path}","compare_url":"https://api.github.com/repos/tech6hutch/klasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tech6hutch/klasa/merges","archive_url":"https://api.github.com/repos/tech6hutch/klasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tech6hutch/klasa/downloads","issues_url":"https://api.github.com/repos/tech6hutch/klasa/issues{/number}","pulls_url":"https://api.github.com/repos/tech6hutch/klasa/pulls{/number}","milestones_url":"https://api.github.com/repos/tech6hutch/klasa/milestones{/number}","notifications_url":"https://api.github.com/repos/tech6hutch/klasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tech6hutch/klasa/labels{/name}","releases_url":"https://api.github.com/repos/tech6hutch/klasa/releases{/id}","deployments_url":"https://api.github.com/repos/tech6hutch/klasa/deployments","created_at":"2017-09-28T16:08:00Z","updated_at":"2018-04-20T14:40:42Z","pushed_at":"2018-04-22T09:17:37Z","git_url":"git://github.com/tech6hutch/klasa.git","ssh_url":"git@github.com:tech6hutch/klasa.git","clone_url":"https://github.com/tech6hutch/klasa.git","svn_url":"https://github.com/tech6hutch/klasa","homepage":null,"size":3791,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dirigeants:master","ref":"master","sha":"c4526c3bba6595b38ef5afc1cc607d4830c74213","user":{"login":"dirigeants","id":25160727,"avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"repo":{"id":97268750,"name":"klasa","full_name":"dirigeants/klasa","owner":{"login":"dirigeants","id":25160727,"avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dirigeants/klasa","description":"A class remix of the Komada Bot Framework","fork":false,"url":"https://api.github.com/repos/dirigeants/klasa","forks_url":"https://api.github.com/repos/dirigeants/klasa/forks","keys_url":"https://api.github.com/repos/dirigeants/klasa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirigeants/klasa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirigeants/klasa/teams","hooks_url":"https://api.github.com/repos/dirigeants/klasa/hooks","issue_events_url":"https://api.github.com/repos/dirigeants/klasa/issues/events{/number}","events_url":"https://api.github.com/repos/dirigeants/klasa/events","assignees_url":"https://api.github.com/repos/dirigeants/klasa/assignees{/user}","branches_url":"https://api.github.com/repos/dirigeants/klasa/branches{/branch}","tags_url":"https://api.github.com/repos/dirigeants/klasa/tags","blobs_url":"https://api.github.com/repos/dirigeants/klasa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirigeants/klasa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirigeants/klasa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirigeants/klasa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirigeants/klasa/statuses/{sha}","languages_url":"https://api.github.com/repos/dirigeants/klasa/languages","stargazers_url":"https://api.github.com/repos/dirigeants/klasa/stargazers","contributors_url":"https://api.github.com/repos/dirigeants/klasa/contributors","subscribers_url":"https://api.github.com/repos/dirigeants/klasa/subscribers","subscription_url":"https://api.github.com/repos/dirigeants/klasa/subscription","commits_url":"https://api.github.com/repos/dirigeants/klasa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirigeants/klasa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirigeants/klasa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirigeants/klasa/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirigeants/klasa/contents/{+path}","compare_url":"https://api.github.com/repos/dirigeants/klasa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirigeants/klasa/merges","archive_url":"https://api.github.com/repos/dirigeants/klasa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirigeants/klasa/downloads","issues_url":"https://api.github.com/repos/dirigeants/klasa/issues{/number}","pulls_url":"https://api.github.com/repos/dirigeants/klasa/pulls{/number}","milestones_url":"https://api.github.com/repos/dirigeants/klasa/milestones{/number}","notifications_url":"https://api.github.com/repos/dirigeants/klasa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirigeants/klasa/labels{/name}","releases_url":"https://api.github.com/repos/dirigeants/klasa/releases{/id}","deployments_url":"https://api.github.com/repos/dirigeants/klasa/deployments","created_at":"2017-07-14T20:01:50Z","updated_at":"2018-04-22T18:31:50Z","pushed_at":"2018-04-22T22:55:56Z","git_url":"git://github.com/dirigeants/klasa.git","ssh_url":"git@github.com:dirigeants/klasa.git","clone_url":"https://github.com/dirigeants/klasa.git","svn_url":"https://github.com/dirigeants/klasa","homepage":"https://klasa.js.org","size":5537,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":6,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/278"},"html":{"href":"https://github.com/dirigeants/klasa/pull/278"},"issue":{"href":"https://api.github.com/repos/dirigeants/klasa/issues/278"},"comments":{"href":"https://api.github.com/repos/dirigeants/klasa/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dirigeants/klasa/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/dirigeants/klasa/statuses/1c58aa12c042e5a0cbbbbf283e2c6e758c8c1b08"}},"author_association":"CONTRIBUTOR"}} | {
"id": 97268750,
"name": "dirigeants/klasa",
"url": "https://api.github.com/repos/dirigeants/klasa"
} | {
"id": 18535830,
"login": "bdistin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18535830?",
"url": "https://api.github.com/users/bdistin"
} | {
"id": 25160727,
"login": "dirigeants",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25160727?",
"url": "https://api.github.com/orgs/dirigeants"
} | 2018-04-23T13:54:49 | 7572025549 | {"actor":{"display_login":"bdistin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/comments/192582447","pull_request_review_id":125388448,"id":192582447,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU4MjQ0Nw==","diff_hunk":"@@ -0,0 +1,72 @@\n+const { Command } = require('klasa');\n+const { MessageAttachment } = require('discord.js');\n+const cloud = require('d3-cloud');\n+const { Canvas } = require('canvas');\n+\n+module.exports = class extends Command {\n+\n+\tconstructor(...args) {\n+\t\tsuper(...args, {\n+\t\t\tdescription: 'Generate a wordcloud from the messages in a chat.',\n+\t\t\trequiredPermissions: ['ATTACH_FILES']\n+\t\t});\n+\t}\n+\n+\tasync run(msg) {\n+\t\tconst FinalImage = new Canvas(2000, 2000);\n+\t\tconst ctx = FinalImage.getContext('2d');\n+\t\tlet messageBank = await msg.channel.messages.fetch({ limit: 100 });\n+\t\tconst wordBank = {};\n+\t\tfor (let i = 0; i < 20; i++) {\n+\t\t\tconst fetchedMessages = await msg.channel.messages.fetch({ limit: 100, before: messageBank.last().id });\n+\t\t\tmessageBank = messageBank.concat(fetchedMessages);\n+\t\t}\n+\n+\t\tfor (const message of messageBank.values()) {\n+\t\t\tif (!message.content) continue;","path":"commands/Fun/wordcloud.js","position":26,"original_position":26,"commit_id":"f96f4472f3c4c39b14cd34db74a82c3327d292af","original_commit_id":"f96f4472f3c4c39b14cd34db74a82c3327d292af","user":{"login":"kyranet","id":24852502,"node_id":"MDQ6VXNlcjI0ODUyNTAy","avatar_url":"https://avatars0.githubusercontent.com/u/24852502?v=4","gravatar_id":"","url":"https://api.github.com/users/kyranet","html_url":"https://github.com/kyranet","followers_url":"https://api.github.com/users/kyranet/followers","following_url":"https://api.github.com/users/kyranet/following{/other_user}","gists_url":"https://api.github.com/users/kyranet/gists{/gist_id}","starred_url":"https://api.github.com/users/kyranet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyranet/subscriptions","organizations_url":"https://api.github.com/users/kyranet/orgs","repos_url":"https://api.github.com/users/kyranet/repos","events_url":"https://api.github.com/users/kyranet/events{/privacy}","received_events_url":"https://api.github.com/users/kyranet/received_events","type":"User","site_admin":false},"body":"This check is useless, the second condition covers this.","created_at":"2018-06-03T09:01:32Z","updated_at":"2018-06-03T09:06:44Z","html_url":"https://github.com/dirigeants/klasa-pieces/pull/62#discussion_r192582447","pull_request_url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/comments/192582447"},"html":{"href":"https://github.com/dirigeants/klasa-pieces/pull/62#discussion_r192582447"},"pull_request":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62","id":191059165,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDU5MTY1","html_url":"https://github.com/dirigeants/klasa-pieces/pull/62","diff_url":"https://github.com/dirigeants/klasa-pieces/pull/62.diff","patch_url":"https://github.com/dirigeants/klasa-pieces/pull/62.patch","issue_url":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/62","number":62,"state":"open","locked":false,"title":"Add some commands","user":{"login":"gc","id":30398469,"node_id":"MDQ6VXNlcjMwMzk4NDY5","avatar_url":"https://avatars2.githubusercontent.com/u/30398469?v=4","gravatar_id":"","url":"https://api.github.com/users/gc","html_url":"https://github.com/gc","followers_url":"https://api.github.com/users/gc/followers","following_url":"https://api.github.com/users/gc/following{/other_user}","gists_url":"https://api.github.com/users/gc/gists{/gist_id}","starred_url":"https://api.github.com/users/gc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc/subscriptions","organizations_url":"https://api.github.com/users/gc/orgs","repos_url":"https://api.github.com/users/gc/repos","events_url":"https://api.github.com/users/gc/events{/privacy}","received_events_url":"https://api.github.com/users/gc/received_events","type":"User","site_admin":false},"body":"Adds some commands.","created_at":"2018-05-29T07:48:34Z","updated_at":"2018-06-03T09:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f670f3201d40d4b056617143535c2af9680b6cec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717242318,"node_id":"MDU6TGFiZWw3MTcyNDIzMTg=","url":"https://api.github.com/repos/dirigeants/klasa-pieces/labels/Meta:%20New%20Pieces","name":"Meta: New Pieces","color":"4bfa72","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62/commits","review_comments_url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62/comments","review_comment_url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/62/comments","statuses_url":"https://api.github.com/repos/dirigeants/klasa-pieces/statuses/f96f4472f3c4c39b14cd34db74a82c3327d292af","head":{"label":"gc:master","ref":"master","sha":"f96f4472f3c4c39b14cd34db74a82c3327d292af","user":{"login":"gc","id":30398469,"node_id":"MDQ6VXNlcjMwMzk4NDY5","avatar_url":"https://avatars2.githubusercontent.com/u/30398469?v=4","gravatar_id":"","url":"https://api.github.com/users/gc","html_url":"https://github.com/gc","followers_url":"https://api.github.com/users/gc/followers","following_url":"https://api.github.com/users/gc/following{/other_user}","gists_url":"https://api.github.com/users/gc/gists{/gist_id}","starred_url":"https://api.github.com/users/gc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc/subscriptions","organizations_url":"https://api.github.com/users/gc/orgs","repos_url":"https://api.github.com/users/gc/repos","events_url":"https://api.github.com/users/gc/events{/privacy}","received_events_url":"https://api.github.com/users/gc/received_events","type":"User","site_admin":false},"repo":{"id":135260018,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNjAwMTg=","name":"klasa-pieces","full_name":"gc/klasa-pieces","owner":{"login":"gc","id":30398469,"node_id":"MDQ6VXNlcjMwMzk4NDY5","avatar_url":"https://avatars2.githubusercontent.com/u/30398469?v=4","gravatar_id":"","url":"https://api.github.com/users/gc","html_url":"https://github.com/gc","followers_url":"https://api.github.com/users/gc/followers","following_url":"https://api.github.com/users/gc/following{/other_user}","gists_url":"https://api.github.com/users/gc/gists{/gist_id}","starred_url":"https://api.github.com/users/gc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gc/subscriptions","organizations_url":"https://api.github.com/users/gc/orgs","repos_url":"https://api.github.com/users/gc/repos","events_url":"https://api.github.com/users/gc/events{/privacy}","received_events_url":"https://api.github.com/users/gc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gc/klasa-pieces","description":null,"fork":true,"url":"https://api.github.com/repos/gc/klasa-pieces","forks_url":"https://api.github.com/repos/gc/klasa-pieces/forks","keys_url":"https://api.github.com/repos/gc/klasa-pieces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gc/klasa-pieces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gc/klasa-pieces/teams","hooks_url":"https://api.github.com/repos/gc/klasa-pieces/hooks","issue_events_url":"https://api.github.com/repos/gc/klasa-pieces/issues/events{/number}","events_url":"https://api.github.com/repos/gc/klasa-pieces/events","assignees_url":"https://api.github.com/repos/gc/klasa-pieces/assignees{/user}","branches_url":"https://api.github.com/repos/gc/klasa-pieces/branches{/branch}","tags_url":"https://api.github.com/repos/gc/klasa-pieces/tags","blobs_url":"https://api.github.com/repos/gc/klasa-pieces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gc/klasa-pieces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gc/klasa-pieces/git/refs{/sha}","trees_url":"https://api.github.com/repos/gc/klasa-pieces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gc/klasa-pieces/statuses/{sha}","languages_url":"https://api.github.com/repos/gc/klasa-pieces/languages","stargazers_url":"https://api.github.com/repos/gc/klasa-pieces/stargazers","contributors_url":"https://api.github.com/repos/gc/klasa-pieces/contributors","subscribers_url":"https://api.github.com/repos/gc/klasa-pieces/subscribers","subscription_url":"https://api.github.com/repos/gc/klasa-pieces/subscription","commits_url":"https://api.github.com/repos/gc/klasa-pieces/commits{/sha}","git_commits_url":"https://api.github.com/repos/gc/klasa-pieces/git/commits{/sha}","comments_url":"https://api.github.com/repos/gc/klasa-pieces/comments{/number}","issue_comment_url":"https://api.github.com/repos/gc/klasa-pieces/issues/comments{/number}","contents_url":"https://api.github.com/repos/gc/klasa-pieces/contents/{+path}","compare_url":"https://api.github.com/repos/gc/klasa-pieces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gc/klasa-pieces/merges","archive_url":"https://api.github.com/repos/gc/klasa-pieces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gc/klasa-pieces/downloads","issues_url":"https://api.github.com/repos/gc/klasa-pieces/issues{/number}","pulls_url":"https://api.github.com/repos/gc/klasa-pieces/pulls{/number}","milestones_url":"https://api.github.com/repos/gc/klasa-pieces/milestones{/number}","notifications_url":"https://api.github.com/repos/gc/klasa-pieces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gc/klasa-pieces/labels{/name}","releases_url":"https://api.github.com/repos/gc/klasa-pieces/releases{/id}","deployments_url":"https://api.github.com/repos/gc/klasa-pieces/deployments","created_at":"2018-05-29T07:45:01Z","updated_at":"2018-06-03T05:40:17Z","pushed_at":"2018-06-03T05:40:16Z","git_url":"git://github.com/gc/klasa-pieces.git","ssh_url":"git@github.com:gc/klasa-pieces.git","clone_url":"https://github.com/gc/klasa-pieces.git","svn_url":"https://github.com/gc/klasa-pieces","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dirigeants:master","ref":"master","sha":"7d9e669821226aa13cb1c9143130fd214755a2bf","user":{"login":"dirigeants","id":25160727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTYwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"repo":{"id":100132945,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAxMzI5NDU=","name":"klasa-pieces","full_name":"dirigeants/klasa-pieces","owner":{"login":"dirigeants","id":25160727,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTYwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/25160727?v=4","gravatar_id":"","url":"https://api.github.com/users/dirigeants","html_url":"https://github.com/dirigeants","followers_url":"https://api.github.com/users/dirigeants/followers","following_url":"https://api.github.com/users/dirigeants/following{/other_user}","gists_url":"https://api.github.com/users/dirigeants/gists{/gist_id}","starred_url":"https://api.github.com/users/dirigeants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirigeants/subscriptions","organizations_url":"https://api.github.com/users/dirigeants/orgs","repos_url":"https://api.github.com/users/dirigeants/repos","events_url":"https://api.github.com/users/dirigeants/events{/privacy}","received_events_url":"https://api.github.com/users/dirigeants/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dirigeants/klasa-pieces","description":null,"fork":false,"url":"https://api.github.com/repos/dirigeants/klasa-pieces","forks_url":"https://api.github.com/repos/dirigeants/klasa-pieces/forks","keys_url":"https://api.github.com/repos/dirigeants/klasa-pieces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirigeants/klasa-pieces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirigeants/klasa-pieces/teams","hooks_url":"https://api.github.com/repos/dirigeants/klasa-pieces/hooks","issue_events_url":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/events{/number}","events_url":"https://api.github.com/repos/dirigeants/klasa-pieces/events","assignees_url":"https://api.github.com/repos/dirigeants/klasa-pieces/assignees{/user}","branches_url":"https://api.github.com/repos/dirigeants/klasa-pieces/branches{/branch}","tags_url":"https://api.github.com/repos/dirigeants/klasa-pieces/tags","blobs_url":"https://api.github.com/repos/dirigeants/klasa-pieces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirigeants/klasa-pieces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirigeants/klasa-pieces/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirigeants/klasa-pieces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirigeants/klasa-pieces/statuses/{sha}","languages_url":"https://api.github.com/repos/dirigeants/klasa-pieces/languages","stargazers_url":"https://api.github.com/repos/dirigeants/klasa-pieces/stargazers","contributors_url":"https://api.github.com/repos/dirigeants/klasa-pieces/contributors","subscribers_url":"https://api.github.com/repos/dirigeants/klasa-pieces/subscribers","subscription_url":"https://api.github.com/repos/dirigeants/klasa-pieces/subscription","commits_url":"https://api.github.com/repos/dirigeants/klasa-pieces/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirigeants/klasa-pieces/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirigeants/klasa-pieces/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirigeants/klasa-pieces/contents/{+path}","compare_url":"https://api.github.com/repos/dirigeants/klasa-pieces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirigeants/klasa-pieces/merges","archive_url":"https://api.github.com/repos/dirigeants/klasa-pieces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirigeants/klasa-pieces/downloads","issues_url":"https://api.github.com/repos/dirigeants/klasa-pieces/issues{/number}","pulls_url":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls{/number}","milestones_url":"https://api.github.com/repos/dirigeants/klasa-pieces/milestones{/number}","notifications_url":"https://api.github.com/repos/dirigeants/klasa-pieces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirigeants/klasa-pieces/labels{/name}","releases_url":"https://api.github.com/repos/dirigeants/klasa-pieces/releases{/id}","deployments_url":"https://api.github.com/repos/dirigeants/klasa-pieces/deployments","created_at":"2017-08-12T19:13:51Z","updated_at":"2018-06-01T13:27:26Z","pushed_at":"2018-06-03T08:55:34Z","git_url":"git://github.com/dirigeants/klasa-pieces.git","ssh_url":"git@github.com:dirigeants/klasa-pieces.git","clone_url":"https://github.com/dirigeants/klasa-pieces.git","svn_url":"https://github.com/dirigeants/klasa-pieces","homepage":null,"size":341,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62"},"html":{"href":"https://github.com/dirigeants/klasa-pieces/pull/62"},"issue":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/62"},"comments":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/dirigeants/klasa-pieces/statuses/f96f4472f3c4c39b14cd34db74a82c3327d292af"}},"author_association":"CONTRIBUTOR"}} | {
"id": 100132945,
"name": "dirigeants/klasa-pieces",
"url": "https://api.github.com/repos/dirigeants/klasa-pieces"
} | {
"id": 24852502,
"login": "kyranet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24852502?",
"url": "https://api.github.com/users/kyranet"
} | {
"id": 25160727,
"login": "dirigeants",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25160727?",
"url": "https://api.github.com/orgs/dirigeants"
} | 2018-06-03T09:01:32 | 7767651023 | {"actor":{"display_login":"kyranet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/214968818","pull_request_review_id":152130671,"id":214968818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDk2ODgxOA==","diff_hunk":"@@ -92,14 +102,26 @@ export class SpacesService implements Spaces {\n });\n }\n \n- private saveRecent(recent: Space[]) {\n+ private saveRecent(recent: Space[]): Subscription {\n let patch = {\n store: {\n recentSpaces: recent.map(val => val.id)\n }\n } as ExtProfile;\n return this.profileService.silentSave(patch)\n- .subscribe(profile => { }, err => console.log('Error saving recent spaces:', err));\n+ .subscribe(() => {}, err => console.log('Error saving recent spaces:', err));\n+ }\n+\n+ /**\n+ * Given the id of a space, returns the index of the space in _recent\n+ */\n+ findRecentIndexById(spaces: Space[], id: string): number {\n+ for (let i: number = 0; i < spaces.length; i++) {\n+ if (spaces[i].id === id) {\n+ return i;\n+ }\n+ }\n+ return -1;","path":"src/app/shared/spaces.service.ts","position":165,"original_position":165,"commit_id":"2432ee66e1250a3cfb41299a7ce0e5c10f6a879d","original_commit_id":"2432ee66e1250a3cfb41299a7ce0e5c10f6a879d","user":{"login":"andrewazores","id":3787464,"node_id":"MDQ6VXNlcjM3ODc0NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3787464?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewazores","html_url":"https://github.com/andrewazores","followers_url":"https://api.github.com/users/andrewazores/followers","following_url":"https://api.github.com/users/andrewazores/following{/other_user}","gists_url":"https://api.github.com/users/andrewazores/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewazores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewazores/subscriptions","organizations_url":"https://api.github.com/users/andrewazores/orgs","repos_url":"https://api.github.com/users/andrewazores/repos","events_url":"https://api.github.com/users/andrewazores/events{/privacy}","received_events_url":"https://api.github.com/users/andrewazores/received_events","type":"User","site_admin":false},"body":"This looks a lot like findIndex: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex\r\n\r\n`return spaces.findIndex(space => space.id === id)`","created_at":"2018-09-04T15:47:46Z","updated_at":"2018-09-04T15:47:54Z","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3211#discussion_r214968818","pull_request_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments/214968818"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3211#discussion_r214968818"},"pull_request":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211","id":205121880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTIxODgw","html_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3211","diff_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3211.diff","patch_url":"https://github.com/fabric8-ui/fabric8-ui/pull/3211.patch","issue_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3211","number":3211,"state":"open","locked":false,"title":"[wip] fix(SpacesService): reduce number of calls to /api/users regarding recent spaces","user":{"login":"aptmac","id":10425301,"node_id":"MDQ6VXNlcjEwNDI1MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10425301?v=4","gravatar_id":"","url":"https://api.github.com/users/aptmac","html_url":"https://github.com/aptmac","followers_url":"https://api.github.com/users/aptmac/followers","following_url":"https://api.github.com/users/aptmac/following{/other_user}","gists_url":"https://api.github.com/users/aptmac/gists{/gist_id}","starred_url":"https://api.github.com/users/aptmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptmac/subscriptions","organizations_url":"https://api.github.com/users/aptmac/orgs","repos_url":"https://api.github.com/users/aptmac/repos","events_url":"https://api.github.com/users/aptmac/events{/privacy}","received_events_url":"https://api.github.com/users/aptmac/received_events","type":"User","site_admin":false},"body":"Note: the last commit (regarding tests) in this PR will need to be refactored when https://github.com/fabric8-ui/fabric8-ui/pull/3201 is merged\r\n\r\nThis PR addresses OSIO defect #157 [0], in which the updating of 'recent space' causes a large number of PATCH calls to /api/users. Note that refactoring the SpacesService isn't enough to remove all the redundant calls, it appears that the ContextService is operating in a similar fashion and is responsible for most of the PATCH calls.\r\n\r\nCurrently, the _recent variable is a merge of the broadcaster 'spaceChanged' and addRecent (which gets updated for each space returned from `loadRecent()`) [1]. The problem lies with the `scan()` [2], which gets triggered for each space; loading 8 spaces via `loadRecent()` results in the subsequent block of code being executed 8 times - including `saveRecent()`. As a result, the user can expect to make `${_recent.length}` PATCH calls every time the service is initialized. In this PR, the 'spaceChanged' logic is separated and handled independently from the initial loading of recent spaces from the profileService, this way `saveRecent()` should be called only if 'spaceChanged' or 'spaceDeleted' is broadcasted.\r\n\r\nAdditionally, there is no code for removing deleted spaces from the list of recent spaces; the ContextService has such functionality by subscribing to the events service, but SpacesService currently does not. This could be seen as problematic and has been reported as a bug a handful of times [3]. In this PR, a message ('spaceDeleted') is broadcasted when a space is deleted, and causes the SpacesService to determine if that space is in the list of recent spaces, and if so, remove it [4].\r\n\r\nI've included tests that cover all lines/functions/statements to try and capture the behaviour of the service.\r\n\r\nLet me know what you think about this implementation, and if there is anything I've missed or should be on the look out for. Thanks!\r\n\r\n**Screenshots**\r\n\r\n**Before:**\r\n/api/users requests from the chrome inspect network tab:\r\n\r\n\r\nconsole warning every time a save occurs:\r\n\r\n\r\n**After:**\r\n/api/users requests from the chrome inspect network tab:\r\n\r\n\r\nconsole warning every time a save occurs:\r\n\r\n\r\n\r\n[0] https://openshift.io/openshiftio/Openshift_io/plan/detail/157\r\n[1] https://github.com/fabric8-ui/fabric8-ui/blob/master/src/app/shared/spaces.service.ts#L35\r\n[2] https://github.com/fabric8-ui/fabric8-ui/blob/master/src/app/shared/spaces.service.ts#L40\r\n[3] https://github.com/openshiftio/openshift.io/issues/2196\r\n[4] https://github.com/aptmac/fabric8-ui/blob/93e89febcb97dcea667ec3a36400294b34dc502c/src/app/shared/spaces.service.ts#L63\r\n","created_at":"2018-07-31T13:57:09Z","updated_at":"2018-09-04T15:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b95376674a5fe1aa9c6d6726e9b24d12ab420dc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":950515265,"node_id":"MDU6TGFiZWw5NTA1MTUyNjU=","url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/labels/work-in-progress","name":"work-in-progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211/commits","review_comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211/comments","review_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3211/comments","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/2432ee66e1250a3cfb41299a7ce0e5c10f6a879d","head":{"label":"aptmac:spaces-service","ref":"spaces-service","sha":"2432ee66e1250a3cfb41299a7ce0e5c10f6a879d","user":{"login":"aptmac","id":10425301,"node_id":"MDQ6VXNlcjEwNDI1MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10425301?v=4","gravatar_id":"","url":"https://api.github.com/users/aptmac","html_url":"https://github.com/aptmac","followers_url":"https://api.github.com/users/aptmac/followers","following_url":"https://api.github.com/users/aptmac/following{/other_user}","gists_url":"https://api.github.com/users/aptmac/gists{/gist_id}","starred_url":"https://api.github.com/users/aptmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptmac/subscriptions","organizations_url":"https://api.github.com/users/aptmac/orgs","repos_url":"https://api.github.com/users/aptmac/repos","events_url":"https://api.github.com/users/aptmac/events{/privacy}","received_events_url":"https://api.github.com/users/aptmac/received_events","type":"User","site_admin":false},"repo":{"id":117593075,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1OTMwNzU=","name":"fabric8-ui","full_name":"aptmac/fabric8-ui","owner":{"login":"aptmac","id":10425301,"node_id":"MDQ6VXNlcjEwNDI1MzAx","avatar_url":"https://avatars2.githubusercontent.com/u/10425301?v=4","gravatar_id":"","url":"https://api.github.com/users/aptmac","html_url":"https://github.com/aptmac","followers_url":"https://api.github.com/users/aptmac/followers","following_url":"https://api.github.com/users/aptmac/following{/other_user}","gists_url":"https://api.github.com/users/aptmac/gists{/gist_id}","starred_url":"https://api.github.com/users/aptmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptmac/subscriptions","organizations_url":"https://api.github.com/users/aptmac/orgs","repos_url":"https://api.github.com/users/aptmac/repos","events_url":"https://api.github.com/users/aptmac/events{/privacy}","received_events_url":"https://api.github.com/users/aptmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aptmac/fabric8-ui","description":"The Angular frontend for fabric8 online (OpenShift.IO)","fork":true,"url":"https://api.github.com/repos/aptmac/fabric8-ui","forks_url":"https://api.github.com/repos/aptmac/fabric8-ui/forks","keys_url":"https://api.github.com/repos/aptmac/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aptmac/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aptmac/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/aptmac/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/aptmac/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/aptmac/fabric8-ui/events","assignees_url":"https://api.github.com/repos/aptmac/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/aptmac/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/aptmac/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/aptmac/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aptmac/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aptmac/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/aptmac/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aptmac/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/aptmac/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/aptmac/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/aptmac/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/aptmac/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/aptmac/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/aptmac/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/aptmac/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/aptmac/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/aptmac/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/aptmac/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/aptmac/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aptmac/fabric8-ui/merges","archive_url":"https://api.github.com/repos/aptmac/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aptmac/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/aptmac/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/aptmac/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/aptmac/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/aptmac/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aptmac/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/aptmac/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/aptmac/fabric8-ui/deployments","created_at":"2018-01-15T20:39:35Z","updated_at":"2018-09-04T15:22:19Z","pushed_at":"2018-09-04T15:36:33Z","git_url":"git://github.com/aptmac/fabric8-ui.git","ssh_url":"git@github.com:aptmac/fabric8-ui.git","clone_url":"https://github.com/aptmac/fabric8-ui.git","svn_url":"https://github.com/aptmac/fabric8-ui","homepage":"https://openshift.io/","size":14991,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-ui:master","ref":"master","sha":"21eaeb7313b02236e28865da8ae023369a099328","user":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":73824736,"node_id":"MDEwOlJlcG9zaXRvcnk3MzgyNDczNg==","name":"fabric8-ui","full_name":"fabric8-ui/fabric8-ui","owner":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-ui/fabric8-ui","description":"The Angular frontend for fabric8 online (OpenShift.IO)","fork":false,"url":"https://api.github.com/repos/fabric8-ui/fabric8-ui","forks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/forks","keys_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/teams","hooks_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/hooks","issue_events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/events","assignees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/tags","blobs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/languages","stargazers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/stargazers","contributors_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contributors","subscribers_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscribers","subscription_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/subscription","commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/merges","archive_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/downloads","issues_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-ui/fabric8-ui/deployments","created_at":"2016-11-15T15:04:11Z","updated_at":"2018-09-04T15:46:56Z","pushed_at":"2018-09-04T15:47:18Z","git_url":"git://github.com/fabric8-ui/fabric8-ui.git","ssh_url":"git@github.com:fabric8-ui/fabric8-ui.git","clone_url":"https://github.com/fabric8-ui/fabric8-ui.git","svn_url":"https://github.com/fabric8-ui/fabric8-ui","homepage":"https://openshift.io/","size":15003,"stargazers_count":23,"watchers_count":23,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":8,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211"},"html":{"href":"https://github.com/fabric8-ui/fabric8-ui/pull/3211"},"issue":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3211"},"comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/issues/3211/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/pulls/3211/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-ui/fabric8-ui/statuses/2432ee66e1250a3cfb41299a7ce0e5c10f6a879d"}},"author_association":"MEMBER"}} | {
"id": 73824736,
"name": "fabric8-ui/fabric8-ui",
"url": "https://api.github.com/repos/fabric8-ui/fabric8-ui"
} | {
"id": 3787464,
"login": "andrewazores",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3787464?",
"url": "https://api.github.com/users/andrewazores"
} | {
"id": 25244298,
"login": "fabric8-ui",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25244298?",
"url": "https://api.github.com/orgs/fabric8-ui"
} | 2018-09-04T15:47:46 | 8212248511 | {"actor":{"display_login":"andrewazores"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/magento-engcom/msi/pulls/comments/170649438","pull_request_review_id":99367226,"id":170649438,"diff_hunk":"@@ -60,19 +69,23 @@ public function __construct(\n public function afterExecute(SourceItemsSaveInterface $subject, $result, array $sourceItems)\n {\n foreach ($sourceItems as $sourceItem) {\n- if ($sourceItem->getSourceCode() !== $this->defaultSourceProvider->getCode()) {\n- continue;\n+ try {","path":"app/code/Magento/InventoryCatalog/Plugin/InventoryApi/SetDataToLegacyCatalogInventoryAtSourceItemsSavePlugin.php","position":43,"original_position":43,"commit_id":"f03137de9d40f76c8cc49a0518780d9b448bb22d","original_commit_id":"f03137de9d40f76c8cc49a0518780d9b448bb22d","user":{"login":"naydav","id":537688,"avatar_url":"https://avatars1.githubusercontent.com/u/537688?v=4","gravatar_id":"","url":"https://api.github.com/users/naydav","html_url":"https://github.com/naydav","followers_url":"https://api.github.com/users/naydav/followers","following_url":"https://api.github.com/users/naydav/following{/other_user}","gists_url":"https://api.github.com/users/naydav/gists{/gist_id}","starred_url":"https://api.github.com/users/naydav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naydav/subscriptions","organizations_url":"https://api.github.com/users/naydav/orgs","repos_url":"https://api.github.com/users/naydav/repos","events_url":"https://api.github.com/users/naydav/events{/privacy}","received_events_url":"https://api.github.com/users/naydav/received_events","type":"User","site_admin":false},"body":"Need to revert try... catch\r\nLooks like hack for integration tests","created_at":"2018-02-26T16:25:02Z","updated_at":"2018-02-26T16:25:02Z","html_url":"https://github.com/magento-engcom/msi/pull/597#discussion_r170649438","pull_request_url":"https://api.github.com/repos/magento-engcom/msi/pulls/597","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/comments/170649438"},"html":{"href":"https://github.com/magento-engcom/msi/pull/597#discussion_r170649438"},"pull_request":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/597"}}},"pull_request":{"url":"https://api.github.com/repos/magento-engcom/msi/pulls/597","id":171041325,"html_url":"https://github.com/magento-engcom/msi/pull/597","diff_url":"https://github.com/magento-engcom/msi/pull/597.diff","patch_url":"https://github.com/magento-engcom/msi/pull/597.patch","issue_url":"https://api.github.com/repos/magento-engcom/msi/issues/597","number":597,"state":"open","locked":false,"title":"MSI: 398: Need to cover InventoryCatalog search with integration tests","user":{"login":"RomaKis","id":17450979,"avatar_url":"https://avatars3.githubusercontent.com/u/17450979?v=4","gravatar_id":"","url":"https://api.github.com/users/RomaKis","html_url":"https://github.com/RomaKis","followers_url":"https://api.github.com/users/RomaKis/followers","following_url":"https://api.github.com/users/RomaKis/following{/other_user}","gists_url":"https://api.github.com/users/RomaKis/gists{/gist_id}","starred_url":"https://api.github.com/users/RomaKis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomaKis/subscriptions","organizations_url":"https://api.github.com/users/RomaKis/orgs","repos_url":"https://api.github.com/users/RomaKis/repos","events_url":"https://api.github.com/users/RomaKis/events{/privacy}","received_events_url":"https://api.github.com/users/RomaKis/received_events","type":"User","site_admin":false},"body":"### Fixed Issues (if relevant)\r\n1. https://github.com/magento-engcom/msi/issues/398\r\n","created_at":"2018-02-23T15:23:14Z","updated_at":"2018-02-26T16:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4960f2119382d220a70fb4d4c0f18b57599ae290","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento-engcom/msi/pulls/597/commits","review_comments_url":"https://api.github.com/repos/magento-engcom/msi/pulls/597/comments","review_comment_url":"https://api.github.com/repos/magento-engcom/msi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento-engcom/msi/issues/597/comments","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/f03137de9d40f76c8cc49a0518780d9b448bb22d","head":{"label":"magento-engcom:398","ref":"398","sha":"f03137de9d40f76c8cc49a0518780d9b448bb22d","user":{"login":"magento-engcom","id":25439648,"avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"repo":{"id":91593797,"name":"msi","full_name":"magento-engcom/msi","owner":{"login":"magento-engcom","id":25439648,"avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-engcom/msi","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/magento-engcom/msi","forks_url":"https://api.github.com/repos/magento-engcom/msi/forks","keys_url":"https://api.github.com/repos/magento-engcom/msi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-engcom/msi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-engcom/msi/teams","hooks_url":"https://api.github.com/repos/magento-engcom/msi/hooks","issue_events_url":"https://api.github.com/repos/magento-engcom/msi/issues/events{/number}","events_url":"https://api.github.com/repos/magento-engcom/msi/events","assignees_url":"https://api.github.com/repos/magento-engcom/msi/assignees{/user}","branches_url":"https://api.github.com/repos/magento-engcom/msi/branches{/branch}","tags_url":"https://api.github.com/repos/magento-engcom/msi/tags","blobs_url":"https://api.github.com/repos/magento-engcom/msi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-engcom/msi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-engcom/msi/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-engcom/msi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-engcom/msi/languages","stargazers_url":"https://api.github.com/repos/magento-engcom/msi/stargazers","contributors_url":"https://api.github.com/repos/magento-engcom/msi/contributors","subscribers_url":"https://api.github.com/repos/magento-engcom/msi/subscribers","subscription_url":"https://api.github.com/repos/magento-engcom/msi/subscription","commits_url":"https://api.github.com/repos/magento-engcom/msi/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-engcom/msi/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-engcom/msi/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-engcom/msi/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-engcom/msi/contents/{+path}","compare_url":"https://api.github.com/repos/magento-engcom/msi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-engcom/msi/merges","archive_url":"https://api.github.com/repos/magento-engcom/msi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-engcom/msi/downloads","issues_url":"https://api.github.com/repos/magento-engcom/msi/issues{/number}","pulls_url":"https://api.github.com/repos/magento-engcom/msi/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-engcom/msi/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-engcom/msi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-engcom/msi/labels{/name}","releases_url":"https://api.github.com/repos/magento-engcom/msi/releases{/id}","deployments_url":"https://api.github.com/repos/magento-engcom/msi/deployments","created_at":"2017-05-17T15:47:14Z","updated_at":"2018-02-26T12:05:06Z","pushed_at":"2018-02-26T16:16:55Z","git_url":"git://github.com/magento-engcom/msi.git","ssh_url":"git@github.com:magento-engcom/msi.git","clone_url":"https://github.com/magento-engcom/msi.git","svn_url":"https://github.com/magento-engcom/msi","homepage":"http://www.magento.com","size":403978,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":128,"license":null,"forks":30,"open_issues":128,"watchers":77,"default_branch":"develop"}},"base":{"label":"magento-engcom:develop","ref":"develop","sha":"056bcebd08f468178114d4a56b554dd897f6d4c5","user":{"login":"magento-engcom","id":25439648,"avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"repo":{"id":91593797,"name":"msi","full_name":"magento-engcom/msi","owner":{"login":"magento-engcom","id":25439648,"avatar_url":"https://avatars0.githubusercontent.com/u/25439648?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom","html_url":"https://github.com/magento-engcom","followers_url":"https://api.github.com/users/magento-engcom/followers","following_url":"https://api.github.com/users/magento-engcom/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom/orgs","repos_url":"https://api.github.com/users/magento-engcom/repos","events_url":"https://api.github.com/users/magento-engcom/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-engcom/msi","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/magento-engcom/msi","forks_url":"https://api.github.com/repos/magento-engcom/msi/forks","keys_url":"https://api.github.com/repos/magento-engcom/msi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-engcom/msi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-engcom/msi/teams","hooks_url":"https://api.github.com/repos/magento-engcom/msi/hooks","issue_events_url":"https://api.github.com/repos/magento-engcom/msi/issues/events{/number}","events_url":"https://api.github.com/repos/magento-engcom/msi/events","assignees_url":"https://api.github.com/repos/magento-engcom/msi/assignees{/user}","branches_url":"https://api.github.com/repos/magento-engcom/msi/branches{/branch}","tags_url":"https://api.github.com/repos/magento-engcom/msi/tags","blobs_url":"https://api.github.com/repos/magento-engcom/msi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-engcom/msi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-engcom/msi/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-engcom/msi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-engcom/msi/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-engcom/msi/languages","stargazers_url":"https://api.github.com/repos/magento-engcom/msi/stargazers","contributors_url":"https://api.github.com/repos/magento-engcom/msi/contributors","subscribers_url":"https://api.github.com/repos/magento-engcom/msi/subscribers","subscription_url":"https://api.github.com/repos/magento-engcom/msi/subscription","commits_url":"https://api.github.com/repos/magento-engcom/msi/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-engcom/msi/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-engcom/msi/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-engcom/msi/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-engcom/msi/contents/{+path}","compare_url":"https://api.github.com/repos/magento-engcom/msi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-engcom/msi/merges","archive_url":"https://api.github.com/repos/magento-engcom/msi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-engcom/msi/downloads","issues_url":"https://api.github.com/repos/magento-engcom/msi/issues{/number}","pulls_url":"https://api.github.com/repos/magento-engcom/msi/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-engcom/msi/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-engcom/msi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-engcom/msi/labels{/name}","releases_url":"https://api.github.com/repos/magento-engcom/msi/releases{/id}","deployments_url":"https://api.github.com/repos/magento-engcom/msi/deployments","created_at":"2017-05-17T15:47:14Z","updated_at":"2018-02-26T12:05:06Z","pushed_at":"2018-02-26T16:16:55Z","git_url":"git://github.com/magento-engcom/msi.git","ssh_url":"git@github.com:magento-engcom/msi.git","clone_url":"https://github.com/magento-engcom/msi.git","svn_url":"https://github.com/magento-engcom/msi","homepage":"http://www.magento.com","size":403978,"stargazers_count":77,"watchers_count":77,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":128,"license":null,"forks":30,"open_issues":128,"watchers":77,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/597"},"html":{"href":"https://github.com/magento-engcom/msi/pull/597"},"issue":{"href":"https://api.github.com/repos/magento-engcom/msi/issues/597"},"comments":{"href":"https://api.github.com/repos/magento-engcom/msi/issues/597/comments"},"review_comments":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/597/comments"},"review_comment":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento-engcom/msi/pulls/597/commits"},"statuses":{"href":"https://api.github.com/repos/magento-engcom/msi/statuses/f03137de9d40f76c8cc49a0518780d9b448bb22d"}},"author_association":"COLLABORATOR"}} | {
"id": 91593797,
"name": "magento-engcom/msi",
"url": "https://api.github.com/repos/magento-engcom/msi"
} | {
"id": 537688,
"login": "naydav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/537688?",
"url": "https://api.github.com/users/naydav"
} | {
"id": 25439648,
"login": "magento-engcom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25439648?",
"url": "https://api.github.com/orgs/magento-engcom"
} | 2018-02-26T16:25:02 | 7298240324 | {"actor":{"display_login":"naydav"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/moia-dev/streamee/pulls/comments/230350053","pull_request_review_id":171070902,"id":230350053,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDM1MDA1Mw==","diff_hunk":"@@ -0,0 +1,173 @@\n+/*\n+ * Copyright 2018 MOIA GmbH\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package io.moia.streamee\n+package demo\n+\n+import akka.actor.{ CoordinatedShutdown, Scheduler, ActorSystem => UntypedSystem }\n+import akka.actor.typed.{ ActorSystem, Behavior }\n+import akka.actor.typed.scaladsl.Behaviors\n+import akka.actor.typed.scaladsl.adapter.TypedActorSystemOps\n+import akka.cluster.sharding.typed.scaladsl.ClusterSharding\n+import akka.cluster.typed.{ Cluster, SelfUp, Subscribe, Unsubscribe }\n+import akka.event.LoggingAdapter\n+import akka.http.scaladsl.Http\n+import akka.stream.{ DelayOverflowStrategy, Materializer, ThrottleMode }\n+import akka.stream.scaladsl.{ Flow, Sink, Source }\n+import akka.stream.typed.scaladsl.ActorMaterializer\n+import akka.util.Timeout\n+import org.apache.logging.log4j.core.async.AsyncLoggerContextSelector\n+import pureconfig.loadConfigOrThrow\n+import scala.concurrent.{ ExecutionContext, Promise }\n+import scala.concurrent.duration.DurationInt\n+\n+object Poc {\n+\n+ final case class Config(api: Api.Config)\n+\n+ def main(args: Array[String]): Unit = {\n+ sys.props += \"log4j2.contextSelector\" -> classOf[AsyncLoggerContextSelector].getName // Always use async logging!\n+ val config = loadConfigOrThrow[Config](\"streamee-demo\") // Must be first!\n+ ActorSystem(Poc(config), \"streamee-demo\")\n+ }\n+\n+ def apply(config: Config): Behavior[SelfUp] =\n+ Behaviors.setup { context =>\n+ context.log.info(\"{} started and ready to join cluster\", context.system.name)\n+\n+ Cluster(context.system).subscriptions ! Subscribe(context.self, classOf[SelfUp])\n+\n+ Behaviors.receive { (context, _) =>\n+ context.log.info(\"{} joined cluster and is up\", context.system.name)\n+\n+ Cluster(context.system).subscriptions ! Unsubscribe(context.self)\n+\n+ implicit val system: ActorSystem[_] = context.system\n+ implicit val untypedSystem: UntypedSystem = system.toUntyped\n+ implicit val mat: Materializer = ActorMaterializer()(context.system)\n+ implicit val ec: ExecutionContext = context.executionContext\n+ implicit val scheduler: Scheduler = context.system.scheduler\n+\n+ implicit val log: LoggingAdapter = akka.event.Logging(system.toUntyped, getClass.getName)\n+ val demoProcess =\n+ Flow[(Int, Promise[Int])]\n+ .throttle(1, 1.second, 1, ThrottleMode.Shaping)\n+ .log(\"1: \")\n+ .delay(1.second, DelayOverflowStrategy.backpressure)\n+ .log(\"2: \")\n+ .delay(1.second, DelayOverflowStrategy.backpressure)\n+ .log(\"3: \")\n+ .delay(1.second, DelayOverflowStrategy.backpressure)\n+ .log(\"4: \")\n+\n+ val (_, demoProcessRunnerFor) =\n+ IntoableRunnerSharding.start(demoProcess,\n+ ClusterSharding(system),\n+ CoordinatedShutdown(system.toUntyped))\n+// def getSinkRef(replyTo: ActorRef[SinkRef[(Int, Promise[Int])]]) =\n+// IntoableRunner.GetSinkRef(replyTo)\n+\n+ val route = {\n+ import akka.http.scaladsl.server.Directives._\n+\n+ implicit val askTimeout: Timeout = 30.seconds\n+\n+ pathSingleSlash {\n+ get {\n+ complete {\n+ val response =\n+ Source\n+ .single(42)\n+ .into(_ => demoProcessRunnerFor(\"id-1\"), 42)\n+ .map(_.toString)\n+ .runWith(Sink.head)\n+ response\n+ }\n+ }\n+ }\n+ }\n+\n+ Http().bindAndHandle(route, \"0.0.0.0\", 8080)\n+\n+ Behaviors.empty\n+ }\n+ }\n+}\n+\n+//object IntoableRunner extends Logging {","path":"streamee-demo/src/main/scala/io/moia/streamee/demo/Poc.scala","position":110,"original_position":110,"commit_id":"14e272937bbf30b512433b1b9575307098dff1e6","original_commit_id":"14e272937bbf30b512433b1b9575307098dff1e6","user":{"login":"hseeberger","id":41911,"node_id":"MDQ6VXNlcjQxOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/41911?v=4","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"body":"Will be removed.","created_at":"2018-11-02T11:58:14Z","updated_at":"2018-11-02T11:58:14Z","html_url":"https://github.com/moia-dev/streamee/pull/21#discussion_r230350053","pull_request_url":"https://api.github.com/repos/moia-dev/streamee/pulls/21","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/comments/230350053"},"html":{"href":"https://github.com/moia-dev/streamee/pull/21#discussion_r230350053"},"pull_request":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/21"}},"in_reply_to_id":230342924},"pull_request":{"url":"https://api.github.com/repos/moia-dev/streamee/pulls/21","id":226045535,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDQ1NTM1","html_url":"https://github.com/moia-dev/streamee/pull/21","diff_url":"https://github.com/moia-dev/streamee/pull/21.diff","patch_url":"https://github.com/moia-dev/streamee/pull/21.patch","issue_url":"https://api.github.com/repos/moia-dev/streamee/issues/21","number":21,"state":"open","locked":false,"title":"Use StreamRefs for intoable streams","user":{"login":"hseeberger","id":41911,"node_id":"MDQ6VXNlcjQxOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/41911?v=4","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"body":"This PR shows a new approach for connecting – possibly short-lived – request handling streams with long-lived \"intoable\" ones. Instead of running these \"intoable\" streams with a source queue this PR makes use of `SinkRef`s which are materialized in a single element sub-stream of the request handling stream. Obtaining the `SinkRef`s happens via the `Runner` (naming not decided yet) actor which runs the intoable flow with a `MergeHub` source – that way a new single-shot `SinkRef` can be created for each element of the request handling stream.\r\n\r\nThe `Runner` is a state machine: on shutdown it will no longer handle requests for `SinkRef`s and also shutdown the \"intoable\" stream gracefully using a kill switch. That way no requests are lost assuming that (a) a new Runner is created in a timely fashion, e.g. via ClusterSharding and (b) the request handling streams retry obtaining `SinkRef`s (the `Runner` won't reply during shutdown).\r\n\r\nIn order to run the demo, simply use `r0` in sbt. Then use a HTTP client to GET the root path, e.g. \r\n```\r\nhttp :8080\r\n```\r\n\r\nEach request takes some 4 seconds to complete. If you execute `reStop` during that, you'll notice that the node is only shutdown after the request has been completed.","created_at":"2018-10-26T10:12:57Z","updated_at":"2018-11-02T11:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad41df9c03d12676aa4bee753cfcf764291247df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1075531842,"node_id":"MDU6TGFiZWwxMDc1NTMxODQy","url":"https://api.github.com/repos/moia-dev/streamee/labels/wip","name":"wip","color":"f9ba54","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moia-dev/streamee/pulls/21/commits","review_comments_url":"https://api.github.com/repos/moia-dev/streamee/pulls/21/comments","review_comment_url":"https://api.github.com/repos/moia-dev/streamee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moia-dev/streamee/issues/21/comments","statuses_url":"https://api.github.com/repos/moia-dev/streamee/statuses/14e272937bbf30b512433b1b9575307098dff1e6","head":{"label":"moia-dev:streamrefs","ref":"streamrefs","sha":"14e272937bbf30b512433b1b9575307098dff1e6","user":{"login":"moia-dev","id":25587067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTg3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/25587067?v=4","gravatar_id":"","url":"https://api.github.com/users/moia-dev","html_url":"https://github.com/moia-dev","followers_url":"https://api.github.com/users/moia-dev/followers","following_url":"https://api.github.com/users/moia-dev/following{/other_user}","gists_url":"https://api.github.com/users/moia-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/moia-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moia-dev/subscriptions","organizations_url":"https://api.github.com/users/moia-dev/orgs","repos_url":"https://api.github.com/users/moia-dev/repos","events_url":"https://api.github.com/users/moia-dev/events{/privacy}","received_events_url":"https://api.github.com/users/moia-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":140421617,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MjE2MTc=","name":"streamee","full_name":"moia-dev/streamee","private":false,"owner":{"login":"moia-dev","id":25587067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTg3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/25587067?v=4","gravatar_id":"","url":"https://api.github.com/users/moia-dev","html_url":"https://github.com/moia-dev","followers_url":"https://api.github.com/users/moia-dev/followers","following_url":"https://api.github.com/users/moia-dev/following{/other_user}","gists_url":"https://api.github.com/users/moia-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/moia-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moia-dev/subscriptions","organizations_url":"https://api.github.com/users/moia-dev/orgs","repos_url":"https://api.github.com/users/moia-dev/repos","events_url":"https://api.github.com/users/moia-dev/events{/privacy}","received_events_url":"https://api.github.com/users/moia-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moia-dev/streamee","description":null,"fork":false,"url":"https://api.github.com/repos/moia-dev/streamee","forks_url":"https://api.github.com/repos/moia-dev/streamee/forks","keys_url":"https://api.github.com/repos/moia-dev/streamee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moia-dev/streamee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moia-dev/streamee/teams","hooks_url":"https://api.github.com/repos/moia-dev/streamee/hooks","issue_events_url":"https://api.github.com/repos/moia-dev/streamee/issues/events{/number}","events_url":"https://api.github.com/repos/moia-dev/streamee/events","assignees_url":"https://api.github.com/repos/moia-dev/streamee/assignees{/user}","branches_url":"https://api.github.com/repos/moia-dev/streamee/branches{/branch}","tags_url":"https://api.github.com/repos/moia-dev/streamee/tags","blobs_url":"https://api.github.com/repos/moia-dev/streamee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moia-dev/streamee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moia-dev/streamee/git/refs{/sha}","trees_url":"https://api.github.com/repos/moia-dev/streamee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moia-dev/streamee/statuses/{sha}","languages_url":"https://api.github.com/repos/moia-dev/streamee/languages","stargazers_url":"https://api.github.com/repos/moia-dev/streamee/stargazers","contributors_url":"https://api.github.com/repos/moia-dev/streamee/contributors","subscribers_url":"https://api.github.com/repos/moia-dev/streamee/subscribers","subscription_url":"https://api.github.com/repos/moia-dev/streamee/subscription","commits_url":"https://api.github.com/repos/moia-dev/streamee/commits{/sha}","git_commits_url":"https://api.github.com/repos/moia-dev/streamee/git/commits{/sha}","comments_url":"https://api.github.com/repos/moia-dev/streamee/comments{/number}","issue_comment_url":"https://api.github.com/repos/moia-dev/streamee/issues/comments{/number}","contents_url":"https://api.github.com/repos/moia-dev/streamee/contents/{+path}","compare_url":"https://api.github.com/repos/moia-dev/streamee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moia-dev/streamee/merges","archive_url":"https://api.github.com/repos/moia-dev/streamee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moia-dev/streamee/downloads","issues_url":"https://api.github.com/repos/moia-dev/streamee/issues{/number}","pulls_url":"https://api.github.com/repos/moia-dev/streamee/pulls{/number}","milestones_url":"https://api.github.com/repos/moia-dev/streamee/milestones{/number}","notifications_url":"https://api.github.com/repos/moia-dev/streamee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moia-dev/streamee/labels{/name}","releases_url":"https://api.github.com/repos/moia-dev/streamee/releases{/id}","deployments_url":"https://api.github.com/repos/moia-dev/streamee/deployments","created_at":"2018-07-10T11:24:49Z","updated_at":"2018-10-26T07:59:39Z","pushed_at":"2018-11-02T10:39:53Z","git_url":"git://github.com/moia-dev/streamee.git","ssh_url":"git@github.com:moia-dev/streamee.git","clone_url":"https://github.com/moia-dev/streamee.git","svn_url":"https://github.com/moia-dev/streamee","homepage":null,"size":125,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"moia-dev:master","ref":"master","sha":"f0eb5afaddfb655935e1ffa9e91c357d95deb535","user":{"login":"moia-dev","id":25587067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTg3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/25587067?v=4","gravatar_id":"","url":"https://api.github.com/users/moia-dev","html_url":"https://github.com/moia-dev","followers_url":"https://api.github.com/users/moia-dev/followers","following_url":"https://api.github.com/users/moia-dev/following{/other_user}","gists_url":"https://api.github.com/users/moia-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/moia-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moia-dev/subscriptions","organizations_url":"https://api.github.com/users/moia-dev/orgs","repos_url":"https://api.github.com/users/moia-dev/repos","events_url":"https://api.github.com/users/moia-dev/events{/privacy}","received_events_url":"https://api.github.com/users/moia-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":140421617,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MjE2MTc=","name":"streamee","full_name":"moia-dev/streamee","private":false,"owner":{"login":"moia-dev","id":25587067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTg3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/25587067?v=4","gravatar_id":"","url":"https://api.github.com/users/moia-dev","html_url":"https://github.com/moia-dev","followers_url":"https://api.github.com/users/moia-dev/followers","following_url":"https://api.github.com/users/moia-dev/following{/other_user}","gists_url":"https://api.github.com/users/moia-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/moia-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moia-dev/subscriptions","organizations_url":"https://api.github.com/users/moia-dev/orgs","repos_url":"https://api.github.com/users/moia-dev/repos","events_url":"https://api.github.com/users/moia-dev/events{/privacy}","received_events_url":"https://api.github.com/users/moia-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moia-dev/streamee","description":null,"fork":false,"url":"https://api.github.com/repos/moia-dev/streamee","forks_url":"https://api.github.com/repos/moia-dev/streamee/forks","keys_url":"https://api.github.com/repos/moia-dev/streamee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moia-dev/streamee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moia-dev/streamee/teams","hooks_url":"https://api.github.com/repos/moia-dev/streamee/hooks","issue_events_url":"https://api.github.com/repos/moia-dev/streamee/issues/events{/number}","events_url":"https://api.github.com/repos/moia-dev/streamee/events","assignees_url":"https://api.github.com/repos/moia-dev/streamee/assignees{/user}","branches_url":"https://api.github.com/repos/moia-dev/streamee/branches{/branch}","tags_url":"https://api.github.com/repos/moia-dev/streamee/tags","blobs_url":"https://api.github.com/repos/moia-dev/streamee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moia-dev/streamee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moia-dev/streamee/git/refs{/sha}","trees_url":"https://api.github.com/repos/moia-dev/streamee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moia-dev/streamee/statuses/{sha}","languages_url":"https://api.github.com/repos/moia-dev/streamee/languages","stargazers_url":"https://api.github.com/repos/moia-dev/streamee/stargazers","contributors_url":"https://api.github.com/repos/moia-dev/streamee/contributors","subscribers_url":"https://api.github.com/repos/moia-dev/streamee/subscribers","subscription_url":"https://api.github.com/repos/moia-dev/streamee/subscription","commits_url":"https://api.github.com/repos/moia-dev/streamee/commits{/sha}","git_commits_url":"https://api.github.com/repos/moia-dev/streamee/git/commits{/sha}","comments_url":"https://api.github.com/repos/moia-dev/streamee/comments{/number}","issue_comment_url":"https://api.github.com/repos/moia-dev/streamee/issues/comments{/number}","contents_url":"https://api.github.com/repos/moia-dev/streamee/contents/{+path}","compare_url":"https://api.github.com/repos/moia-dev/streamee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moia-dev/streamee/merges","archive_url":"https://api.github.com/repos/moia-dev/streamee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moia-dev/streamee/downloads","issues_url":"https://api.github.com/repos/moia-dev/streamee/issues{/number}","pulls_url":"https://api.github.com/repos/moia-dev/streamee/pulls{/number}","milestones_url":"https://api.github.com/repos/moia-dev/streamee/milestones{/number}","notifications_url":"https://api.github.com/repos/moia-dev/streamee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moia-dev/streamee/labels{/name}","releases_url":"https://api.github.com/repos/moia-dev/streamee/releases{/id}","deployments_url":"https://api.github.com/repos/moia-dev/streamee/deployments","created_at":"2018-07-10T11:24:49Z","updated_at":"2018-10-26T07:59:39Z","pushed_at":"2018-11-02T10:39:53Z","git_url":"git://github.com/moia-dev/streamee.git","ssh_url":"git@github.com:moia-dev/streamee.git","clone_url":"https://github.com/moia-dev/streamee.git","svn_url":"https://github.com/moia-dev/streamee","homepage":null,"size":125,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/21"},"html":{"href":"https://github.com/moia-dev/streamee/pull/21"},"issue":{"href":"https://api.github.com/repos/moia-dev/streamee/issues/21"},"comments":{"href":"https://api.github.com/repos/moia-dev/streamee/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moia-dev/streamee/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/moia-dev/streamee/statuses/14e272937bbf30b512433b1b9575307098dff1e6"}},"author_association":"COLLABORATOR"}} | {
"id": 140421617,
"name": "moia-dev/streamee",
"url": "https://api.github.com/repos/moia-dev/streamee"
} | {
"id": 41911,
"login": "hseeberger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41911?",
"url": "https://api.github.com/users/hseeberger"
} | {
"id": 25587067,
"login": "moia-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25587067?",
"url": "https://api.github.com/orgs/moia-dev"
} | 2018-11-02T11:58:14 | 8524976839 | {"actor":{"display_login":"hseeberger"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/prettier/plugin-php/pulls/comments/204791958","pull_request_review_id":139934694,"id":204791958,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDc5MTk1OA==","diff_hunk":"@@ -482,6 +460,559 @@ There are <?php echo $variable; ?> examples\n \n `;\n \n+exports[`mixed-8.php 1`] = `\n+<div>\n+ <?php\n+ echo \"1\";\n+ echo \"2\";\n+ ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\"; echo \"2\"; ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\"; ?>\n+ <?php echo \"2\"; ?>\n+</div>\n+\n+<div>\n+ <?php function func($x){\n+ return $x;\n+ }\n+ function other_func($x){\n+ return $x;\n+ } ?>\n+</div>\n+\n+<div>\n+ <?php function func($x){\n+ return $x;\n+ } ?>\n+ <?php function other_func($x){\n+ return $x;\n+ } ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\"; ?>\n+</div>\n+<div>\n+ <?php\n+ echo \"1\";\n+ ?>\n+</div>\n+<div>\n+ <?php\n+ echo \"1\";\n+ echo \"2\";\n+ ?>\n+</div>\n+<div>\n+ <?php\n+ echo \"1\";\n+ echo \"2\";\n+ echo \"3\";\n+ ?>\n+</div>\n+<div>\n+ <?php\n+ echo \"1\";\n+ echo \"2\";\n+ echo \"3\";\n+ echo \"4\";\n+ echo \"5\";\n+ ?>\n+</div>\n+<div>\n+ <div>\n+ <div>\n+ <div>\n+ <?php echo \"1\"; ?>\n+ </div>\n+ </div>\n+ </div>\n+</div>\n+<div>\n+ <div>\n+ <div>\n+ <div>\n+ <?php\n+ echo \"1\";\n+ echo \"2\";\n+ ?>\n+ </div>\n+ </div>\n+ </div>\n+</div>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<div>\n+ <?php echo \"1\";\n+ echo \"2\"; ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\";\n+ echo \"2\"; ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\"; ?>\n+ <?php echo \"2\"; ?>\n+</div>\n+\n+<div>\n+ <?php function func($x)\n+ {\n+ return $x;\n+ }\n+ function other_func($x)\n+ {\n+ return $x;\n+ } ?>\n+</div>\n+\n+<div>\n+ <?php function func($x)\n+ {\n+ return $x;\n+ } ?>\n+ <?php function other_func($x)\n+ {\n+ return $x;\n+ } ?>\n+</div>\n+\n+<div>\n+ <?php echo \"1\"; ?>\n+</div>\n+<div>\n+ <?php echo \"1\"; ?>\n+</div>\n+<div>\n+ <?php echo \"1\";\n+ echo \"2\"; ?>\n+</div>\n+<div>\n+ <?php echo \"1\";\n+ echo \"2\";\n+ echo \"3\"; ?>\n+</div>\n+<div>\n+ <?php echo \"1\";\n+ echo \"2\";\n+ echo \"3\";\n+ echo \"4\";\n+ echo \"5\"; ?>\n+</div>\n+<div>\n+ <div>\n+ <div>\n+ <div>\n+ <?php echo \"1\"; ?>\n+ </div>\n+ </div>\n+ </div>\n+</div>\n+<div>\n+ <div>\n+ <div>\n+ <div>\n+ <?php echo \"1\";\n+ echo \"2\"; ?>\n+ </div>\n+ </div>\n+ </div>\n+</div>\n+\n+`;\n+\n+exports[`mixed-9.php 1`] = `\n+<?php echo '1'; ?>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1'; ?>\n+\n+`;\n+\n+exports[`mixed-10.php 1`] = `\n+<?php echo '1';\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1';\n+\n+`;\n+\n+exports[`mixed-11.php 1`] = `\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+\n+`;\n+\n+exports[`mixed-12.php 1`] = `\n+<?php echo '1'; ?>\n+<?php echo '2';\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1'; ?>\n+<?php echo '2';\n+\n+`;\n+\n+exports[`mixed-13.php 1`] = `\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+<?php echo '3'; ?>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+<?php echo '3'; ?>\n+\n+`;\n+\n+exports[`mixed-14.php 1`] = `\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+<?php echo '3';\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php echo '1'; ?>\n+<?php echo '2'; ?>\n+<?php echo '3';\n+\n+`;\n+\n+exports[`mixed-15.php 1`] = `\n+<?php\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php\n+\n+`;\n+\n+exports[`mixed-16.php 1`] = `\n+<section class=\"<?= $sectionClass ?>\">\n+ <header class=\"<?= $headerClass ?>\">\n+ <?php echo $someOtherVar()->element('collection/item-title', [\n+ 'class' => $itemTitleClass,\n+ 'small_title' => $item->small_title,\n+ 'title' => $item->title,\n+ 'url' => $url,\n+ 'color' => $item->title_color ?: 'primary',\n+ ], [\n+ 'foo' => 'bar',\n+ 'bar' => 'foo',\n+ 'barfoo' => 'foobar',\n+ 'foobar' => 'barfoo'\n+ ]); ?>\n+ </header>\n+ <div> <?php echo $someOtherVar()->element('collection/item-title', [\n+ 'class' => $itemTitleClass,\n+ 'small_title' => $item->small_title,\n+ 'title' => $item->title,\n+ 'url' => $url,\n+ 'color' => $item->title_color ?: 'primary',\n+ ], [\n+ 'foo' => 'bar',\n+ 'bar' => 'foo',\n+ 'barfoo' => 'foobar',\n+ 'foobar' => 'barfoo'\n+ ]); ?>\n+ </div>\n+</section>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<section class=\"<?= $sectionClass; ?>\">\n+ <header class=\"<?= $headerClass; ?>\">\n+ <?php echo $someOtherVar()->element(\n+ 'collection/item-title',\n+ [\n+ 'class' => $itemTitleClass,\n+ 'small_title' => $item->small_title,\n+ 'title' => $item->title,\n+ 'url' => $url,\n+ 'color' => $item->title_color ?: 'primary'\n+ ],\n+ [\n+ 'foo' => 'bar',\n+ 'bar' => 'foo',\n+ 'barfoo' => 'foobar',\n+ 'foobar' => 'barfoo'\n+ ]\n+ ); ?>\n+ </header>\n+ <div> <?php echo $someOtherVar()->element(\n+ 'collection/item-title',\n+ [\n+ 'class' => $itemTitleClass,\n+ 'small_title' => $item->small_title,\n+ 'title' => $item->title,\n+ 'url' => $url,\n+ 'color' => $item->title_color ?: 'primary'\n+ ],\n+ [\n+ 'foo' => 'bar',\n+ 'bar' => 'foo',\n+ 'barfoo' => 'foobar',\n+ 'foobar' => 'barfoo'\n+ ]\n+ ); ?>\n+ </div>\n+</section>\n+\n+`;\n+\n+exports[`mixed-17.php 1`] = `\n+<div>\n+ <?php switch($variable) {\n+ case 1: ?>\n+ <div>Newspage</div>\n+ <?php break; ?>\n+ <?php case 2: ?>\n+ <div>Forum</div>\n+ <?php break; ?>\n+ <?php } ?>\n+</div>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<div>\n+ <?php switch ($variable) { case 1: ?>\n+ <div>Newspage</div>\n+ <?php break; ?>\n+ <?php case 2: ?>\n+ <div>Forum</div>\n+ <?php break; ?>\n+ <?php } ?>\n+</div>\n+\n+`;\n+\n+exports[`mixed-18.php 1`] = `\n+<div>\n+ <?php\n+\n+ echo '1';\n+ echo '2';\n+\n+ ?>\n+</div>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<div>\n+ <?php echo '1';\n+ echo '2';\n+ ?>\n+</div>\n+\n+`;\n+\n+exports[`mixed-19.php 1`] = `\n+<?php\n+$greet = function($name) {\n+ ?>\n+ FooBar\n+ <?php\n+};\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php\n+$greet = function ($name) {\n+ ?>\n+ FooBar\n+ <?php\n+};\n+\n+`;\n+\n+exports[`mixed-20.php 1`] = `\n+<?php\n+try {\n+ ?>\n+ Foo bar\n+ <?php\n+} catch (Exception $e) {\n+ ?>\n+ Foo bar\n+ <?php\n+} finally {\n+ ?>\n+ Foo bar\n+ <?php\n+}\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php\n+try {\n+ ?>\n+ Foo bar\n+ <?php\n+} catch (Exception $e) {\n+ ?>\n+ Foo bar\n+ <?php\n+} finally {\n+ ?>\n+ Foo bar\n+ <?php\n+}\n+\n+`;\n+\n+exports[`mixed-21.php 1`] = `\n+<?php\n+\n+class Foo\n+{\n+ public function html() {\n+ ?>\n+ Foo Bar\n+ <?php\n+ }\n+}\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php\n+class Foo\n+{\n+ public function html()\n+ {\n+ ?>\n+ Foo Bar\n+ <?php\n+ }\n+}\n+\n+`;\n+\n+exports[`mixed-22.php 1`] = `\n+<?php if ($expression == true): ?>\n+ <p>Test.</p>\n+<?php else: ?>\n+ <p>Test.</p>\n+<?php endif; ?>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<?php if ($expression == true): ?>\n+ <p>Test.</p>\n+<?php else: ?>\n+ <p>Test.</p>\n+<?php endif; ?>\n+\n+`;\n+\n+exports[`mixed-23.php 1`] = `\n+<div>Foo</div>\n+<?php for ($really_really_long_variable_name = 0; $really_really_long_variable_name <= 5; $really_really_long_variable_name++) { ?>\n+ <div>\n+ <?php echo $really_really_long_variable_name; ?>\n+ </div>\n+<?php } ?>\n+<div>Bar</div>\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+<div>Foo</div>\n+<?php for (\n+ $really_really_long_variable_name = 0;\n+ $really_really_long_variable_name <= 5;\n+ $really_really_long_variable_name++\n+) { ?>","path":"tests/inline/__snapshots__/jsfmt.spec.js.snap","position":651,"original_position":651,"commit_id":"535b7fd3007f8e497c79f883e2b1ceb0ef787203","original_commit_id":"535b7fd3007f8e497c79f883e2b1ceb0ef787203","user":{"login":"evilebottnawi","id":4567934,"node_id":"MDQ6VXNlcjQ1Njc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"body":"Groups break great","created_at":"2018-07-24T15:01:06Z","updated_at":"2018-07-24T15:01:06Z","html_url":"https://github.com/prettier/plugin-php/pull/492#discussion_r204791958","pull_request_url":"https://api.github.com/repos/prettier/plugin-php/pulls/492","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/comments/204791958"},"html":{"href":"https://github.com/prettier/plugin-php/pull/492#discussion_r204791958"},"pull_request":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/prettier/plugin-php/pulls/492","id":203555434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTU1NDM0","html_url":"https://github.com/prettier/plugin-php/pull/492","diff_url":"https://github.com/prettier/plugin-php/pull/492.diff","patch_url":"https://github.com/prettier/plugin-php/pull/492.patch","issue_url":"https://api.github.com/repos/prettier/plugin-php/issues/492","number":492,"state":"open","locked":false,"title":"[WIP] Feat better print inline","user":{"login":"evilebottnawi","id":4567934,"node_id":"MDQ6VXNlcjQ1Njc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4567934?v=4","gravatar_id":"","url":"https://api.github.com/users/evilebottnawi","html_url":"https://github.com/evilebottnawi","followers_url":"https://api.github.com/users/evilebottnawi/followers","following_url":"https://api.github.com/users/evilebottnawi/following{/other_user}","gists_url":"https://api.github.com/users/evilebottnawi/gists{/gist_id}","starred_url":"https://api.github.com/users/evilebottnawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilebottnawi/subscriptions","organizations_url":"https://api.github.com/users/evilebottnawi/orgs","repos_url":"https://api.github.com/users/evilebottnawi/repos","events_url":"https://api.github.com/users/evilebottnawi/events{/privacy}","received_events_url":"https://api.github.com/users/evilebottnawi/received_events","type":"User","site_admin":false},"body":"Feel free to feedback, it was very hard, but looks i found how we can solve this problems\r\n\r\nShortly:\r\n1. Remove old logic and implement new (also remove utils around inline).\r\n2. A lot of new tests (you can see what all prints better).\r\n3. A lot of fixed with inline nodes (with old logic you can move all test and looks what it is break code in many places and very very ugly)","created_at":"2018-07-24T14:53:21Z","updated_at":"2018-07-24T15:01:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9321627d2d1072d857f36d7e6b66f58342192937","assignee":null,"assignees":[],"requested_reviewers":[{"login":"czosel","id":7962156,"node_id":"MDQ6VXNlcjc5NjIxNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/7962156?v=4","gravatar_id":"","url":"https://api.github.com/users/czosel","html_url":"https://github.com/czosel","followers_url":"https://api.github.com/users/czosel/followers","following_url":"https://api.github.com/users/czosel/following{/other_user}","gists_url":"https://api.github.com/users/czosel/gists{/gist_id}","starred_url":"https://api.github.com/users/czosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czosel/subscriptions","organizations_url":"https://api.github.com/users/czosel/orgs","repos_url":"https://api.github.com/users/czosel/repos","events_url":"https://api.github.com/users/czosel/events{/privacy}","received_events_url":"https://api.github.com/users/czosel/received_events","type":"User","site_admin":false},{"login":"mgrip","id":13454680,"node_id":"MDQ6VXNlcjEzNDU0Njgw","avatar_url":"https://avatars2.githubusercontent.com/u/13454680?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrip","html_url":"https://github.com/mgrip","followers_url":"https://api.github.com/users/mgrip/followers","following_url":"https://api.github.com/users/mgrip/following{/other_user}","gists_url":"https://api.github.com/users/mgrip/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrip/subscriptions","organizations_url":"https://api.github.com/users/mgrip/orgs","repos_url":"https://api.github.com/users/mgrip/repos","events_url":"https://api.github.com/users/mgrip/events{/privacy}","received_events_url":"https://api.github.com/users/mgrip/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prettier/plugin-php/pulls/492/commits","review_comments_url":"https://api.github.com/repos/prettier/plugin-php/pulls/492/comments","review_comment_url":"https://api.github.com/repos/prettier/plugin-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prettier/plugin-php/issues/492/comments","statuses_url":"https://api.github.com/repos/prettier/plugin-php/statuses/535b7fd3007f8e497c79f883e2b1ceb0ef787203","head":{"label":"prettier:feat-better-print-inline","ref":"feat-better-print-inline","sha":"535b7fd3007f8e497c79f883e2b1ceb0ef787203","user":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"repo":{"id":115235915,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyMzU5MTU=","name":"plugin-php","full_name":"prettier/plugin-php","owner":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prettier/plugin-php","description":"Prettier PHP Plugin","fork":false,"url":"https://api.github.com/repos/prettier/plugin-php","forks_url":"https://api.github.com/repos/prettier/plugin-php/forks","keys_url":"https://api.github.com/repos/prettier/plugin-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prettier/plugin-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prettier/plugin-php/teams","hooks_url":"https://api.github.com/repos/prettier/plugin-php/hooks","issue_events_url":"https://api.github.com/repos/prettier/plugin-php/issues/events{/number}","events_url":"https://api.github.com/repos/prettier/plugin-php/events","assignees_url":"https://api.github.com/repos/prettier/plugin-php/assignees{/user}","branches_url":"https://api.github.com/repos/prettier/plugin-php/branches{/branch}","tags_url":"https://api.github.com/repos/prettier/plugin-php/tags","blobs_url":"https://api.github.com/repos/prettier/plugin-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prettier/plugin-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prettier/plugin-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/prettier/plugin-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prettier/plugin-php/statuses/{sha}","languages_url":"https://api.github.com/repos/prettier/plugin-php/languages","stargazers_url":"https://api.github.com/repos/prettier/plugin-php/stargazers","contributors_url":"https://api.github.com/repos/prettier/plugin-php/contributors","subscribers_url":"https://api.github.com/repos/prettier/plugin-php/subscribers","subscription_url":"https://api.github.com/repos/prettier/plugin-php/subscription","commits_url":"https://api.github.com/repos/prettier/plugin-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/prettier/plugin-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/prettier/plugin-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/prettier/plugin-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/prettier/plugin-php/contents/{+path}","compare_url":"https://api.github.com/repos/prettier/plugin-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prettier/plugin-php/merges","archive_url":"https://api.github.com/repos/prettier/plugin-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prettier/plugin-php/downloads","issues_url":"https://api.github.com/repos/prettier/plugin-php/issues{/number}","pulls_url":"https://api.github.com/repos/prettier/plugin-php/pulls{/number}","milestones_url":"https://api.github.com/repos/prettier/plugin-php/milestones{/number}","notifications_url":"https://api.github.com/repos/prettier/plugin-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prettier/plugin-php/labels{/name}","releases_url":"https://api.github.com/repos/prettier/plugin-php/releases{/id}","deployments_url":"https://api.github.com/repos/prettier/plugin-php/deployments","created_at":"2017-12-24T02:56:22Z","updated_at":"2018-07-24T09:24:24Z","pushed_at":"2018-07-24T14:53:22Z","git_url":"git://github.com/prettier/plugin-php.git","ssh_url":"git@github.com:prettier/plugin-php.git","clone_url":"https://github.com/prettier/plugin-php.git","svn_url":"https://github.com/prettier/plugin-php","homepage":null,"size":818,"stargazers_count":388,"watchers_count":388,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":388,"default_branch":"master"}},"base":{"label":"prettier:master","ref":"master","sha":"d3a7aa1ca1ed6ca551f80813eb3df7deb31be909","user":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"repo":{"id":115235915,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyMzU5MTU=","name":"plugin-php","full_name":"prettier/plugin-php","owner":{"login":"prettier","id":25822731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODIyNzMx","avatar_url":"https://avatars2.githubusercontent.com/u/25822731?v=4","gravatar_id":"","url":"https://api.github.com/users/prettier","html_url":"https://github.com/prettier","followers_url":"https://api.github.com/users/prettier/followers","following_url":"https://api.github.com/users/prettier/following{/other_user}","gists_url":"https://api.github.com/users/prettier/gists{/gist_id}","starred_url":"https://api.github.com/users/prettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prettier/subscriptions","organizations_url":"https://api.github.com/users/prettier/orgs","repos_url":"https://api.github.com/users/prettier/repos","events_url":"https://api.github.com/users/prettier/events{/privacy}","received_events_url":"https://api.github.com/users/prettier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prettier/plugin-php","description":"Prettier PHP Plugin","fork":false,"url":"https://api.github.com/repos/prettier/plugin-php","forks_url":"https://api.github.com/repos/prettier/plugin-php/forks","keys_url":"https://api.github.com/repos/prettier/plugin-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prettier/plugin-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prettier/plugin-php/teams","hooks_url":"https://api.github.com/repos/prettier/plugin-php/hooks","issue_events_url":"https://api.github.com/repos/prettier/plugin-php/issues/events{/number}","events_url":"https://api.github.com/repos/prettier/plugin-php/events","assignees_url":"https://api.github.com/repos/prettier/plugin-php/assignees{/user}","branches_url":"https://api.github.com/repos/prettier/plugin-php/branches{/branch}","tags_url":"https://api.github.com/repos/prettier/plugin-php/tags","blobs_url":"https://api.github.com/repos/prettier/plugin-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prettier/plugin-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prettier/plugin-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/prettier/plugin-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prettier/plugin-php/statuses/{sha}","languages_url":"https://api.github.com/repos/prettier/plugin-php/languages","stargazers_url":"https://api.github.com/repos/prettier/plugin-php/stargazers","contributors_url":"https://api.github.com/repos/prettier/plugin-php/contributors","subscribers_url":"https://api.github.com/repos/prettier/plugin-php/subscribers","subscription_url":"https://api.github.com/repos/prettier/plugin-php/subscription","commits_url":"https://api.github.com/repos/prettier/plugin-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/prettier/plugin-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/prettier/plugin-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/prettier/plugin-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/prettier/plugin-php/contents/{+path}","compare_url":"https://api.github.com/repos/prettier/plugin-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prettier/plugin-php/merges","archive_url":"https://api.github.com/repos/prettier/plugin-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prettier/plugin-php/downloads","issues_url":"https://api.github.com/repos/prettier/plugin-php/issues{/number}","pulls_url":"https://api.github.com/repos/prettier/plugin-php/pulls{/number}","milestones_url":"https://api.github.com/repos/prettier/plugin-php/milestones{/number}","notifications_url":"https://api.github.com/repos/prettier/plugin-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prettier/plugin-php/labels{/name}","releases_url":"https://api.github.com/repos/prettier/plugin-php/releases{/id}","deployments_url":"https://api.github.com/repos/prettier/plugin-php/deployments","created_at":"2017-12-24T02:56:22Z","updated_at":"2018-07-24T09:24:24Z","pushed_at":"2018-07-24T14:53:22Z","git_url":"git://github.com/prettier/plugin-php.git","ssh_url":"git@github.com:prettier/plugin-php.git","clone_url":"https://github.com/prettier/plugin-php.git","svn_url":"https://github.com/prettier/plugin-php","homepage":null,"size":818,"stargazers_count":388,"watchers_count":388,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/492"},"html":{"href":"https://github.com/prettier/plugin-php/pull/492"},"issue":{"href":"https://api.github.com/repos/prettier/plugin-php/issues/492"},"comments":{"href":"https://api.github.com/repos/prettier/plugin-php/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prettier/plugin-php/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/prettier/plugin-php/statuses/535b7fd3007f8e497c79f883e2b1ceb0ef787203"}},"author_association":"COLLABORATOR"}} | {
"id": 115235915,
"name": "prettier/plugin-php",
"url": "https://api.github.com/repos/prettier/plugin-php"
} | {
"id": 4567934,
"login": "evilebottnawi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4567934?",
"url": "https://api.github.com/users/evilebottnawi"
} | {
"id": 25822731,
"login": "prettier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25822731?",
"url": "https://api.github.com/orgs/prettier"
} | 2018-07-24T15:01:06 | 8010789559 | {"actor":{"display_login":"evilebottnawi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/comments/210104489","pull_request_review_id":146242046,"id":210104489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDEwNDQ4OQ==","diff_hunk":"@@ -0,0 +1,88 @@\n+<!doctype html>\n+<html lang=\"en\">\n+ <head>\n+ <meta charset=\"utf-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, minimum-scale=1, initial-scale=1, user-scalable=yes\">\n+\n+ <title>ll-form-element-text test</title>\n+ <script src=\"../node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js\"></script>\n+ <script src=\"../node_modules/wct-browser-legacy/browser.js\"></script>\n+\n+ <script type=\"module\" src=\"../ll-form-element-text.js\"></script>\n+ </head>\n+ <body>\n+\n+ <script type=\"module\">\n+ import '../node_modules/@polymer/iron-test-helpers/mock-interactions.js';\n+ import '../node_modules/axe-core/axe.min.js';\n+ import {axeReport} from '../node_modules/pwa-helpers/axe-report.js';\n+ import {html} from '@polymer/lit-element/lit-element.js';\n+ \n+ import {FormElementText} from '../ll-form-element-text.js'\n+ \n+ class PartialImplementElement extends FormElementText {\n+ _element() {\n+ return html`\n+ <textarea\n+ class=\"generated-textarea\"\n+ id=\"${this.for}\"\n+ minlenghth$=\"${this.minlength}\"\n+ maxlenghth$=\"${this.maxlength}\"","path":"test/test_errors.html","position":30,"original_position":30,"commit_id":"8e9767330c0d02103d4b1ba3c74ab6c00cb29b7e","original_commit_id":"8e9767330c0d02103d4b1ba3c74ab6c00cb29b7e","user":{"login":"cintosyntax","id":11335191,"node_id":"MDQ6VXNlcjExMzM1MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/11335191?v=4","gravatar_id":"","url":"https://api.github.com/users/cintosyntax","html_url":"https://github.com/cintosyntax","followers_url":"https://api.github.com/users/cintosyntax/followers","following_url":"https://api.github.com/users/cintosyntax/following{/other_user}","gists_url":"https://api.github.com/users/cintosyntax/gists{/gist_id}","starred_url":"https://api.github.com/users/cintosyntax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cintosyntax/subscriptions","organizations_url":"https://api.github.com/users/cintosyntax/orgs","repos_url":"https://api.github.com/users/cintosyntax/repos","events_url":"https://api.github.com/users/cintosyntax/events{/privacy}","received_events_url":"https://api.github.com/users/cintosyntax/received_events","type":"User","site_admin":false},"body":"I think this is a typo? `minlength` and `maxlength` should be here?","created_at":"2018-08-14T21:09:16Z","updated_at":"2018-08-14T21:13:09Z","html_url":"https://github.com/lingolive/ll-form-element-text/pull/1#discussion_r210104489","pull_request_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/comments/210104489"},"html":{"href":"https://github.com/lingolive/ll-form-element-text/pull/1#discussion_r210104489"},"pull_request":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1","id":206808849,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODA4ODQ5","html_url":"https://github.com/lingolive/ll-form-element-text/pull/1","diff_url":"https://github.com/lingolive/ll-form-element-text/pull/1.diff","patch_url":"https://github.com/lingolive/ll-form-element-text/pull/1.patch","issue_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/1","number":1,"state":"open","locked":false,"title":"ll-form-element-text","user":{"login":"SijiaDavis","id":16018373,"node_id":"MDQ6VXNlcjE2MDE4Mzcz","avatar_url":"https://avatars3.githubusercontent.com/u/16018373?v=4","gravatar_id":"","url":"https://api.github.com/users/SijiaDavis","html_url":"https://github.com/SijiaDavis","followers_url":"https://api.github.com/users/SijiaDavis/followers","following_url":"https://api.github.com/users/SijiaDavis/following{/other_user}","gists_url":"https://api.github.com/users/SijiaDavis/gists{/gist_id}","starred_url":"https://api.github.com/users/SijiaDavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SijiaDavis/subscriptions","organizations_url":"https://api.github.com/users/SijiaDavis/orgs","repos_url":"https://api.github.com/users/SijiaDavis/repos","events_url":"https://api.github.com/users/SijiaDavis/events{/privacy}","received_events_url":"https://api.github.com/users/SijiaDavis/received_events","type":"User","site_admin":false},"body":"Base class for both `ll-input` and `ll-textarea` (and perhaps other form element in the future?)","created_at":"2018-08-07T19:54:55Z","updated_at":"2018-08-14T21:13:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"595fced9bb4415a39c937a3b67974969d0fd500f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lingolive-tech","id":34313760,"node_id":"MDQ6VXNlcjM0MzEzNzYw","avatar_url":"https://avatars2.githubusercontent.com/u/34313760?v=4","gravatar_id":"","url":"https://api.github.com/users/lingolive-tech","html_url":"https://github.com/lingolive-tech","followers_url":"https://api.github.com/users/lingolive-tech/followers","following_url":"https://api.github.com/users/lingolive-tech/following{/other_user}","gists_url":"https://api.github.com/users/lingolive-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/lingolive-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingolive-tech/subscriptions","organizations_url":"https://api.github.com/users/lingolive-tech/orgs","repos_url":"https://api.github.com/users/lingolive-tech/repos","events_url":"https://api.github.com/users/lingolive-tech/events{/privacy}","received_events_url":"https://api.github.com/users/lingolive-tech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/1/comments","statuses_url":"https://api.github.com/repos/lingolive/ll-form-element-text/statuses/8e9767330c0d02103d4b1ba3c74ab6c00cb29b7e","head":{"label":"lingolive:ll-form-element-text","ref":"ll-form-element-text","sha":"8e9767330c0d02103d4b1ba3c74ab6c00cb29b7e","user":{"login":"lingolive","id":25991987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTkxOTg3","avatar_url":"https://avatars0.githubusercontent.com/u/25991987?v=4","gravatar_id":"","url":"https://api.github.com/users/lingolive","html_url":"https://github.com/lingolive","followers_url":"https://api.github.com/users/lingolive/followers","following_url":"https://api.github.com/users/lingolive/following{/other_user}","gists_url":"https://api.github.com/users/lingolive/gists{/gist_id}","starred_url":"https://api.github.com/users/lingolive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingolive/subscriptions","organizations_url":"https://api.github.com/users/lingolive/orgs","repos_url":"https://api.github.com/users/lingolive/repos","events_url":"https://api.github.com/users/lingolive/events{/privacy}","received_events_url":"https://api.github.com/users/lingolive/received_events","type":"Organization","site_admin":false},"repo":{"id":143915642,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MTU2NDI=","name":"ll-form-element-text","full_name":"lingolive/ll-form-element-text","owner":{"login":"lingolive","id":25991987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTkxOTg3","avatar_url":"https://avatars0.githubusercontent.com/u/25991987?v=4","gravatar_id":"","url":"https://api.github.com/users/lingolive","html_url":"https://github.com/lingolive","followers_url":"https://api.github.com/users/lingolive/followers","following_url":"https://api.github.com/users/lingolive/following{/other_user}","gists_url":"https://api.github.com/users/lingolive/gists{/gist_id}","starred_url":"https://api.github.com/users/lingolive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingolive/subscriptions","organizations_url":"https://api.github.com/users/lingolive/orgs","repos_url":"https://api.github.com/users/lingolive/repos","events_url":"https://api.github.com/users/lingolive/events{/privacy}","received_events_url":"https://api.github.com/users/lingolive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lingolive/ll-form-element-text","description":null,"fork":false,"url":"https://api.github.com/repos/lingolive/ll-form-element-text","forks_url":"https://api.github.com/repos/lingolive/ll-form-element-text/forks","keys_url":"https://api.github.com/repos/lingolive/ll-form-element-text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lingolive/ll-form-element-text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lingolive/ll-form-element-text/teams","hooks_url":"https://api.github.com/repos/lingolive/ll-form-element-text/hooks","issue_events_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/events{/number}","events_url":"https://api.github.com/repos/lingolive/ll-form-element-text/events","assignees_url":"https://api.github.com/repos/lingolive/ll-form-element-text/assignees{/user}","branches_url":"https://api.github.com/repos/lingolive/ll-form-element-text/branches{/branch}","tags_url":"https://api.github.com/repos/lingolive/ll-form-element-text/tags","blobs_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/refs{/sha}","trees_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lingolive/ll-form-element-text/statuses/{sha}","languages_url":"https://api.github.com/repos/lingolive/ll-form-element-text/languages","stargazers_url":"https://api.github.com/repos/lingolive/ll-form-element-text/stargazers","contributors_url":"https://api.github.com/repos/lingolive/ll-form-element-text/contributors","subscribers_url":"https://api.github.com/repos/lingolive/ll-form-element-text/subscribers","subscription_url":"https://api.github.com/repos/lingolive/ll-form-element-text/subscription","commits_url":"https://api.github.com/repos/lingolive/ll-form-element-text/commits{/sha}","git_commits_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/commits{/sha}","comments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/comments{/number}","issue_comment_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/comments{/number}","contents_url":"https://api.github.com/repos/lingolive/ll-form-element-text/contents/{+path}","compare_url":"https://api.github.com/repos/lingolive/ll-form-element-text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lingolive/ll-form-element-text/merges","archive_url":"https://api.github.com/repos/lingolive/ll-form-element-text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lingolive/ll-form-element-text/downloads","issues_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues{/number}","pulls_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls{/number}","milestones_url":"https://api.github.com/repos/lingolive/ll-form-element-text/milestones{/number}","notifications_url":"https://api.github.com/repos/lingolive/ll-form-element-text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lingolive/ll-form-element-text/labels{/name}","releases_url":"https://api.github.com/repos/lingolive/ll-form-element-text/releases{/id}","deployments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/deployments","created_at":"2018-08-07T19:02:52Z","updated_at":"2018-08-07T19:03:18Z","pushed_at":"2018-08-14T19:54:38Z","git_url":"git://github.com/lingolive/ll-form-element-text.git","ssh_url":"git@github.com:lingolive/ll-form-element-text.git","clone_url":"https://github.com/lingolive/ll-form-element-text.git","svn_url":"https://github.com/lingolive/ll-form-element-text","homepage":null,"size":270,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lingolive:master","ref":"master","sha":"2b5e2b780af8509dcf1741e4a0414aaaf79e3438","user":{"login":"lingolive","id":25991987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTkxOTg3","avatar_url":"https://avatars0.githubusercontent.com/u/25991987?v=4","gravatar_id":"","url":"https://api.github.com/users/lingolive","html_url":"https://github.com/lingolive","followers_url":"https://api.github.com/users/lingolive/followers","following_url":"https://api.github.com/users/lingolive/following{/other_user}","gists_url":"https://api.github.com/users/lingolive/gists{/gist_id}","starred_url":"https://api.github.com/users/lingolive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingolive/subscriptions","organizations_url":"https://api.github.com/users/lingolive/orgs","repos_url":"https://api.github.com/users/lingolive/repos","events_url":"https://api.github.com/users/lingolive/events{/privacy}","received_events_url":"https://api.github.com/users/lingolive/received_events","type":"Organization","site_admin":false},"repo":{"id":143915642,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MTU2NDI=","name":"ll-form-element-text","full_name":"lingolive/ll-form-element-text","owner":{"login":"lingolive","id":25991987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTkxOTg3","avatar_url":"https://avatars0.githubusercontent.com/u/25991987?v=4","gravatar_id":"","url":"https://api.github.com/users/lingolive","html_url":"https://github.com/lingolive","followers_url":"https://api.github.com/users/lingolive/followers","following_url":"https://api.github.com/users/lingolive/following{/other_user}","gists_url":"https://api.github.com/users/lingolive/gists{/gist_id}","starred_url":"https://api.github.com/users/lingolive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingolive/subscriptions","organizations_url":"https://api.github.com/users/lingolive/orgs","repos_url":"https://api.github.com/users/lingolive/repos","events_url":"https://api.github.com/users/lingolive/events{/privacy}","received_events_url":"https://api.github.com/users/lingolive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lingolive/ll-form-element-text","description":null,"fork":false,"url":"https://api.github.com/repos/lingolive/ll-form-element-text","forks_url":"https://api.github.com/repos/lingolive/ll-form-element-text/forks","keys_url":"https://api.github.com/repos/lingolive/ll-form-element-text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lingolive/ll-form-element-text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lingolive/ll-form-element-text/teams","hooks_url":"https://api.github.com/repos/lingolive/ll-form-element-text/hooks","issue_events_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/events{/number}","events_url":"https://api.github.com/repos/lingolive/ll-form-element-text/events","assignees_url":"https://api.github.com/repos/lingolive/ll-form-element-text/assignees{/user}","branches_url":"https://api.github.com/repos/lingolive/ll-form-element-text/branches{/branch}","tags_url":"https://api.github.com/repos/lingolive/ll-form-element-text/tags","blobs_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/refs{/sha}","trees_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lingolive/ll-form-element-text/statuses/{sha}","languages_url":"https://api.github.com/repos/lingolive/ll-form-element-text/languages","stargazers_url":"https://api.github.com/repos/lingolive/ll-form-element-text/stargazers","contributors_url":"https://api.github.com/repos/lingolive/ll-form-element-text/contributors","subscribers_url":"https://api.github.com/repos/lingolive/ll-form-element-text/subscribers","subscription_url":"https://api.github.com/repos/lingolive/ll-form-element-text/subscription","commits_url":"https://api.github.com/repos/lingolive/ll-form-element-text/commits{/sha}","git_commits_url":"https://api.github.com/repos/lingolive/ll-form-element-text/git/commits{/sha}","comments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/comments{/number}","issue_comment_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/comments{/number}","contents_url":"https://api.github.com/repos/lingolive/ll-form-element-text/contents/{+path}","compare_url":"https://api.github.com/repos/lingolive/ll-form-element-text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lingolive/ll-form-element-text/merges","archive_url":"https://api.github.com/repos/lingolive/ll-form-element-text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lingolive/ll-form-element-text/downloads","issues_url":"https://api.github.com/repos/lingolive/ll-form-element-text/issues{/number}","pulls_url":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls{/number}","milestones_url":"https://api.github.com/repos/lingolive/ll-form-element-text/milestones{/number}","notifications_url":"https://api.github.com/repos/lingolive/ll-form-element-text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lingolive/ll-form-element-text/labels{/name}","releases_url":"https://api.github.com/repos/lingolive/ll-form-element-text/releases{/id}","deployments_url":"https://api.github.com/repos/lingolive/ll-form-element-text/deployments","created_at":"2018-08-07T19:02:52Z","updated_at":"2018-08-07T19:03:18Z","pushed_at":"2018-08-14T19:54:38Z","git_url":"git://github.com/lingolive/ll-form-element-text.git","ssh_url":"git@github.com:lingolive/ll-form-element-text.git","clone_url":"https://github.com/lingolive/ll-form-element-text.git","svn_url":"https://github.com/lingolive/ll-form-element-text","homepage":null,"size":270,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1"},"html":{"href":"https://github.com/lingolive/ll-form-element-text/pull/1"},"issue":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/1"},"comments":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lingolive/ll-form-element-text/statuses/8e9767330c0d02103d4b1ba3c74ab6c00cb29b7e"}},"author_association":"COLLABORATOR"}} | {
"id": 143915642,
"name": "lingolive/ll-form-element-text",
"url": "https://api.github.com/repos/lingolive/ll-form-element-text"
} | {
"id": 11335191,
"login": "cintosyntax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11335191?",
"url": "https://api.github.com/users/cintosyntax"
} | {
"id": 25991987,
"login": "lingolive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25991987?",
"url": "https://api.github.com/orgs/lingolive"
} | 2018-08-14T21:09:16 | 8113790882 | {"actor":{"display_login":"cintosyntax"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/particl/dapp-shell/pulls/comments/169640533","pull_request_review_id":98197770,"id":169640533,"diff_hunk":"@@ -66,6 +66,11 @@ DB_SEEDS_DIR=\"./src/database/seeds\"\n AUTH0_HOST=\"http://localhost:3333\"\n \n #\n+# RPC api authentication\n+#\n+USER_NAME=\"particl\"\n+USER_PASSWORD=\"particl_123\"\n+","path":".env.example","position":8,"original_position":8,"commit_id":"701ff19e277d42de55adb910c36b60bec03cdc49","original_commit_id":"701ff19e277d42de55adb910c36b60bec03cdc49","user":{"login":"xludx","id":213489,"avatar_url":"https://avatars1.githubusercontent.com/u/213489?v=4","gravatar_id":"","url":"https://api.github.com/users/xludx","html_url":"https://github.com/xludx","followers_url":"https://api.github.com/users/xludx/followers","following_url":"https://api.github.com/users/xludx/following{/other_user}","gists_url":"https://api.github.com/users/xludx/gists{/gist_id}","starred_url":"https://api.github.com/users/xludx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xludx/subscriptions","organizations_url":"https://api.github.com/users/xludx/orgs","repos_url":"https://api.github.com/users/xludx/repos","events_url":"https://api.github.com/users/xludx/events{/privacy}","received_events_url":"https://api.github.com/users/xludx/received_events","type":"User","site_admin":false},"body":"remove USER_NAME and USER_PASSWORD.\r\nuse RPCUSER and RPCPASSWORD as the login and password required for the rpc api, that way the marketplace api will use the same ones that are defined for the particld rpc api.","created_at":"2018-02-21T13:48:40Z","updated_at":"2018-02-21T13:56:56Z","html_url":"https://github.com/particl/dapp-shell/pull/156#discussion_r169640533","pull_request_url":"https://api.github.com/repos/particl/dapp-shell/pulls/156","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/comments/169640533"},"html":{"href":"https://github.com/particl/dapp-shell/pull/156#discussion_r169640533"},"pull_request":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/particl/dapp-shell/pulls/156","id":169121457,"html_url":"https://github.com/particl/dapp-shell/pull/156","diff_url":"https://github.com/particl/dapp-shell/pull/156.diff","patch_url":"https://github.com/particl/dapp-shell/pull/156.patch","issue_url":"https://api.github.com/repos/particl/dapp-shell/issues/156","number":156,"state":"open","locked":false,"title":"basic auth check on rpc api call","user":{"login":"cis-navjot-g","id":33522186,"avatar_url":"https://avatars3.githubusercontent.com/u/33522186?v=4","gravatar_id":"","url":"https://api.github.com/users/cis-navjot-g","html_url":"https://github.com/cis-navjot-g","followers_url":"https://api.github.com/users/cis-navjot-g/followers","following_url":"https://api.github.com/users/cis-navjot-g/following{/other_user}","gists_url":"https://api.github.com/users/cis-navjot-g/gists{/gist_id}","starred_url":"https://api.github.com/users/cis-navjot-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cis-navjot-g/subscriptions","organizations_url":"https://api.github.com/users/cis-navjot-g/orgs","repos_url":"https://api.github.com/users/cis-navjot-g/repos","events_url":"https://api.github.com/users/cis-navjot-g/events{/privacy}","received_events_url":"https://api.github.com/users/cis-navjot-g/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-14T14:18:24Z","updated_at":"2018-02-21T13:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa5bf8d7057aa61f48963879d68e0fbe21e047fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/particl/dapp-shell/pulls/156/commits","review_comments_url":"https://api.github.com/repos/particl/dapp-shell/pulls/156/comments","review_comment_url":"https://api.github.com/repos/particl/dapp-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/particl/dapp-shell/issues/156/comments","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/701ff19e277d42de55adb910c36b60bec03cdc49","head":{"label":"particl:authentication","ref":"authentication","sha":"701ff19e277d42de55adb910c36b60bec03cdc49","user":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"repo":{"id":109120213,"name":"dapp-shell","full_name":"particl/dapp-shell","owner":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/particl/dapp-shell","description":"DApp Shell","fork":false,"url":"https://api.github.com/repos/particl/dapp-shell","forks_url":"https://api.github.com/repos/particl/dapp-shell/forks","keys_url":"https://api.github.com/repos/particl/dapp-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particl/dapp-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particl/dapp-shell/teams","hooks_url":"https://api.github.com/repos/particl/dapp-shell/hooks","issue_events_url":"https://api.github.com/repos/particl/dapp-shell/issues/events{/number}","events_url":"https://api.github.com/repos/particl/dapp-shell/events","assignees_url":"https://api.github.com/repos/particl/dapp-shell/assignees{/user}","branches_url":"https://api.github.com/repos/particl/dapp-shell/branches{/branch}","tags_url":"https://api.github.com/repos/particl/dapp-shell/tags","blobs_url":"https://api.github.com/repos/particl/dapp-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particl/dapp-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particl/dapp-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/particl/dapp-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/particl/dapp-shell/languages","stargazers_url":"https://api.github.com/repos/particl/dapp-shell/stargazers","contributors_url":"https://api.github.com/repos/particl/dapp-shell/contributors","subscribers_url":"https://api.github.com/repos/particl/dapp-shell/subscribers","subscription_url":"https://api.github.com/repos/particl/dapp-shell/subscription","commits_url":"https://api.github.com/repos/particl/dapp-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/particl/dapp-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/particl/dapp-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/particl/dapp-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/particl/dapp-shell/contents/{+path}","compare_url":"https://api.github.com/repos/particl/dapp-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particl/dapp-shell/merges","archive_url":"https://api.github.com/repos/particl/dapp-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particl/dapp-shell/downloads","issues_url":"https://api.github.com/repos/particl/dapp-shell/issues{/number}","pulls_url":"https://api.github.com/repos/particl/dapp-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/particl/dapp-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/particl/dapp-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particl/dapp-shell/labels{/name}","releases_url":"https://api.github.com/repos/particl/dapp-shell/releases{/id}","deployments_url":"https://api.github.com/repos/particl/dapp-shell/deployments","created_at":"2017-11-01T10:54:18Z","updated_at":"2018-02-20T03:44:24Z","pushed_at":"2018-02-21T13:54:47Z","git_url":"git://github.com/particl/dapp-shell.git","ssh_url":"git@github.com:particl/dapp-shell.git","clone_url":"https://github.com/particl/dapp-shell.git","svn_url":"https://github.com/particl/dapp-shell","homepage":null,"size":3618,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":8,"watchers":5,"default_branch":"develop"}},"base":{"label":"particl:develop","ref":"develop","sha":"84d10f495c22b7d860d23cb32a22714de7591f2f","user":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"repo":{"id":109120213,"name":"dapp-shell","full_name":"particl/dapp-shell","owner":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/particl/dapp-shell","description":"DApp Shell","fork":false,"url":"https://api.github.com/repos/particl/dapp-shell","forks_url":"https://api.github.com/repos/particl/dapp-shell/forks","keys_url":"https://api.github.com/repos/particl/dapp-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particl/dapp-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particl/dapp-shell/teams","hooks_url":"https://api.github.com/repos/particl/dapp-shell/hooks","issue_events_url":"https://api.github.com/repos/particl/dapp-shell/issues/events{/number}","events_url":"https://api.github.com/repos/particl/dapp-shell/events","assignees_url":"https://api.github.com/repos/particl/dapp-shell/assignees{/user}","branches_url":"https://api.github.com/repos/particl/dapp-shell/branches{/branch}","tags_url":"https://api.github.com/repos/particl/dapp-shell/tags","blobs_url":"https://api.github.com/repos/particl/dapp-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particl/dapp-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particl/dapp-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/particl/dapp-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particl/dapp-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/particl/dapp-shell/languages","stargazers_url":"https://api.github.com/repos/particl/dapp-shell/stargazers","contributors_url":"https://api.github.com/repos/particl/dapp-shell/contributors","subscribers_url":"https://api.github.com/repos/particl/dapp-shell/subscribers","subscription_url":"https://api.github.com/repos/particl/dapp-shell/subscription","commits_url":"https://api.github.com/repos/particl/dapp-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/particl/dapp-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/particl/dapp-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/particl/dapp-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/particl/dapp-shell/contents/{+path}","compare_url":"https://api.github.com/repos/particl/dapp-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particl/dapp-shell/merges","archive_url":"https://api.github.com/repos/particl/dapp-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particl/dapp-shell/downloads","issues_url":"https://api.github.com/repos/particl/dapp-shell/issues{/number}","pulls_url":"https://api.github.com/repos/particl/dapp-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/particl/dapp-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/particl/dapp-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particl/dapp-shell/labels{/name}","releases_url":"https://api.github.com/repos/particl/dapp-shell/releases{/id}","deployments_url":"https://api.github.com/repos/particl/dapp-shell/deployments","created_at":"2017-11-01T10:54:18Z","updated_at":"2018-02-20T03:44:24Z","pushed_at":"2018-02-21T13:54:47Z","git_url":"git://github.com/particl/dapp-shell.git","ssh_url":"git@github.com:particl/dapp-shell.git","clone_url":"https://github.com/particl/dapp-shell.git","svn_url":"https://github.com/particl/dapp-shell","homepage":null,"size":3618,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":8,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/156"},"html":{"href":"https://github.com/particl/dapp-shell/pull/156"},"issue":{"href":"https://api.github.com/repos/particl/dapp-shell/issues/156"},"comments":{"href":"https://api.github.com/repos/particl/dapp-shell/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/particl/dapp-shell/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/particl/dapp-shell/statuses/701ff19e277d42de55adb910c36b60bec03cdc49"}},"author_association":"COLLABORATOR"}} | {
"id": 109120213,
"name": "particl/dapp-shell",
"url": "https://api.github.com/repos/particl/dapp-shell"
} | {
"id": 213489,
"login": "xludx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/213489?",
"url": "https://api.github.com/users/xludx"
} | {
"id": 26021686,
"login": "particl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26021686?",
"url": "https://api.github.com/orgs/particl"
} | 2018-02-21T13:48:40 | 7275548736 | {"actor":{"display_login":"xludx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nert-gu/Xposition/pulls/comments/204198476","pull_request_review_id":139244861,"id":204198476,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5ODQ3Ng==","diff_hunk":"@@ -23,7 +23,7 @@ class PTokenAnnotationTable(tables.Table):\n sentid = tables.Column(accessor='sentence', verbose_name='Sent ID')\n \n def render_exid(self, record):\n- return record.html()\n+ return record.html","path":"wiki/plugins/metadata/tables.py","position":5,"original_position":5,"commit_id":"91002b06742c9166a5d791a8257f3fbb99662a53","original_commit_id":"91002b06742c9166a5d791a8257f3fbb99662a53","user":{"login":"nschneid","id":985263,"node_id":"MDQ6VXNlcjk4NTI2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/985263?v=4","gravatar_id":"","url":"https://api.github.com/users/nschneid","html_url":"https://github.com/nschneid","followers_url":"https://api.github.com/users/nschneid/followers","following_url":"https://api.github.com/users/nschneid/following{/other_user}","gists_url":"https://api.github.com/users/nschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/nschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschneid/subscriptions","organizations_url":"https://api.github.com/users/nschneid/orgs","repos_url":"https://api.github.com/users/nschneid/repos","events_url":"https://api.github.com/users/nschneid/events{/privacy}","received_events_url":"https://api.github.com/users/nschneid/received_events","type":"User","site_admin":false},"body":"In models.py, `CorpusSentence.html` has been made a property (via the `@cached_property` decorator).","created_at":"2018-07-21T01:50:54Z","updated_at":"2018-07-21T01:50:55Z","html_url":"https://github.com/nert-gu/Xposition/pull/103#discussion_r204198476","pull_request_url":"https://api.github.com/repos/nert-gu/Xposition/pulls/103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/comments/204198476"},"html":{"href":"https://github.com/nert-gu/Xposition/pull/103#discussion_r204198476"},"pull_request":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/103"}},"in_reply_to_id":204195405},"pull_request":{"url":"https://api.github.com/repos/nert-gu/Xposition/pulls/103","id":202740523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzQwNTIz","html_url":"https://github.com/nert-gu/Xposition/pull/103","diff_url":"https://github.com/nert-gu/Xposition/pull/103.diff","patch_url":"https://github.com/nert-gu/Xposition/pull/103.patch","issue_url":"https://api.github.com/repos/nert-gu/Xposition/issues/103","number":103,"state":"open","locked":false,"title":"rewrite html() methods and template tags for efficiency","user":{"login":"nschneid","id":985263,"node_id":"MDQ6VXNlcjk4NTI2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/985263?v=4","gravatar_id":"","url":"https://api.github.com/users/nschneid","html_url":"https://github.com/nschneid","followers_url":"https://api.github.com/users/nschneid/followers","following_url":"https://api.github.com/users/nschneid/following{/other_user}","gists_url":"https://api.github.com/users/nschneid/gists{/gist_id}","starred_url":"https://api.github.com/users/nschneid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschneid/subscriptions","organizations_url":"https://api.github.com/users/nschneid/orgs","repos_url":"https://api.github.com/users/nschneid/repos","events_url":"https://api.github.com/users/nschneid/events{/privacy}","received_events_url":"https://api.github.com/users/nschneid/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-20T03:57:55Z","updated_at":"2018-07-21T01:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"142b3518083fac577cf2a841ed017fc51e168fa2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nert-gu/Xposition/pulls/103/commits","review_comments_url":"https://api.github.com/repos/nert-gu/Xposition/pulls/103/comments","review_comment_url":"https://api.github.com/repos/nert-gu/Xposition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nert-gu/Xposition/issues/103/comments","statuses_url":"https://api.github.com/repos/nert-gu/Xposition/statuses/91002b06742c9166a5d791a8257f3fbb99662a53","head":{"label":"nert-gu:html-methods","ref":"html-methods","sha":"91002b06742c9166a5d791a8257f3fbb99662a53","user":{"login":"nert-gu","id":26146203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTQ2MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/26146203?v=4","gravatar_id":"","url":"https://api.github.com/users/nert-gu","html_url":"https://github.com/nert-gu","followers_url":"https://api.github.com/users/nert-gu/followers","following_url":"https://api.github.com/users/nert-gu/following{/other_user}","gists_url":"https://api.github.com/users/nert-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/nert-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nert-gu/subscriptions","organizations_url":"https://api.github.com/users/nert-gu/orgs","repos_url":"https://api.github.com/users/nert-gu/repos","events_url":"https://api.github.com/users/nert-gu/events{/privacy}","received_events_url":"https://api.github.com/users/nert-gu/received_events","type":"Organization","site_admin":false},"repo":{"id":84277254,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI3NzI1NA==","name":"Xposition","full_name":"nert-gu/Xposition","owner":{"login":"nert-gu","id":26146203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTQ2MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/26146203?v=4","gravatar_id":"","url":"https://api.github.com/users/nert-gu","html_url":"https://github.com/nert-gu","followers_url":"https://api.github.com/users/nert-gu/followers","following_url":"https://api.github.com/users/nert-gu/following{/other_user}","gists_url":"https://api.github.com/users/nert-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/nert-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nert-gu/subscriptions","organizations_url":"https://api.github.com/users/nert-gu/orgs","repos_url":"https://api.github.com/users/nert-gu/repos","events_url":"https://api.github.com/users/nert-gu/events{/privacy}","received_events_url":"https://api.github.com/users/nert-gu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nert-gu/Xposition","description":"Cataloging the semantics of adpositions (prepositions, postpositions) and case markers in multiple languages.","fork":false,"url":"https://api.github.com/repos/nert-gu/Xposition","forks_url":"https://api.github.com/repos/nert-gu/Xposition/forks","keys_url":"https://api.github.com/repos/nert-gu/Xposition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nert-gu/Xposition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nert-gu/Xposition/teams","hooks_url":"https://api.github.com/repos/nert-gu/Xposition/hooks","issue_events_url":"https://api.github.com/repos/nert-gu/Xposition/issues/events{/number}","events_url":"https://api.github.com/repos/nert-gu/Xposition/events","assignees_url":"https://api.github.com/repos/nert-gu/Xposition/assignees{/user}","branches_url":"https://api.github.com/repos/nert-gu/Xposition/branches{/branch}","tags_url":"https://api.github.com/repos/nert-gu/Xposition/tags","blobs_url":"https://api.github.com/repos/nert-gu/Xposition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nert-gu/Xposition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nert-gu/Xposition/git/refs{/sha}","trees_url":"https://api.github.com/repos/nert-gu/Xposition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nert-gu/Xposition/statuses/{sha}","languages_url":"https://api.github.com/repos/nert-gu/Xposition/languages","stargazers_url":"https://api.github.com/repos/nert-gu/Xposition/stargazers","contributors_url":"https://api.github.com/repos/nert-gu/Xposition/contributors","subscribers_url":"https://api.github.com/repos/nert-gu/Xposition/subscribers","subscription_url":"https://api.github.com/repos/nert-gu/Xposition/subscription","commits_url":"https://api.github.com/repos/nert-gu/Xposition/commits{/sha}","git_commits_url":"https://api.github.com/repos/nert-gu/Xposition/git/commits{/sha}","comments_url":"https://api.github.com/repos/nert-gu/Xposition/comments{/number}","issue_comment_url":"https://api.github.com/repos/nert-gu/Xposition/issues/comments{/number}","contents_url":"https://api.github.com/repos/nert-gu/Xposition/contents/{+path}","compare_url":"https://api.github.com/repos/nert-gu/Xposition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nert-gu/Xposition/merges","archive_url":"https://api.github.com/repos/nert-gu/Xposition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nert-gu/Xposition/downloads","issues_url":"https://api.github.com/repos/nert-gu/Xposition/issues{/number}","pulls_url":"https://api.github.com/repos/nert-gu/Xposition/pulls{/number}","milestones_url":"https://api.github.com/repos/nert-gu/Xposition/milestones{/number}","notifications_url":"https://api.github.com/repos/nert-gu/Xposition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nert-gu/Xposition/labels{/name}","releases_url":"https://api.github.com/repos/nert-gu/Xposition/releases{/id}","deployments_url":"https://api.github.com/repos/nert-gu/Xposition/deployments","created_at":"2017-03-08T04:12:13Z","updated_at":"2018-07-10T13:30:42Z","pushed_at":"2018-07-21T00:28:02Z","git_url":"git://github.com/nert-gu/Xposition.git","ssh_url":"git@github.com:nert-gu/Xposition.git","clone_url":"https://github.com/nert-gu/Xposition.git","svn_url":"https://github.com/nert-gu/Xposition","homepage":null,"size":11187,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":24,"watchers":1,"default_branch":"master"}},"base":{"label":"nert-gu:wiki-data","ref":"wiki-data","sha":"42e7ec29606c9b01cc8f9544ae2b572e75c7a6f3","user":{"login":"nert-gu","id":26146203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTQ2MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/26146203?v=4","gravatar_id":"","url":"https://api.github.com/users/nert-gu","html_url":"https://github.com/nert-gu","followers_url":"https://api.github.com/users/nert-gu/followers","following_url":"https://api.github.com/users/nert-gu/following{/other_user}","gists_url":"https://api.github.com/users/nert-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/nert-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nert-gu/subscriptions","organizations_url":"https://api.github.com/users/nert-gu/orgs","repos_url":"https://api.github.com/users/nert-gu/repos","events_url":"https://api.github.com/users/nert-gu/events{/privacy}","received_events_url":"https://api.github.com/users/nert-gu/received_events","type":"Organization","site_admin":false},"repo":{"id":84277254,"node_id":"MDEwOlJlcG9zaXRvcnk4NDI3NzI1NA==","name":"Xposition","full_name":"nert-gu/Xposition","owner":{"login":"nert-gu","id":26146203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTQ2MjAz","avatar_url":"https://avatars0.githubusercontent.com/u/26146203?v=4","gravatar_id":"","url":"https://api.github.com/users/nert-gu","html_url":"https://github.com/nert-gu","followers_url":"https://api.github.com/users/nert-gu/followers","following_url":"https://api.github.com/users/nert-gu/following{/other_user}","gists_url":"https://api.github.com/users/nert-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/nert-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nert-gu/subscriptions","organizations_url":"https://api.github.com/users/nert-gu/orgs","repos_url":"https://api.github.com/users/nert-gu/repos","events_url":"https://api.github.com/users/nert-gu/events{/privacy}","received_events_url":"https://api.github.com/users/nert-gu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nert-gu/Xposition","description":"Cataloging the semantics of adpositions (prepositions, postpositions) and case markers in multiple languages.","fork":false,"url":"https://api.github.com/repos/nert-gu/Xposition","forks_url":"https://api.github.com/repos/nert-gu/Xposition/forks","keys_url":"https://api.github.com/repos/nert-gu/Xposition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nert-gu/Xposition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nert-gu/Xposition/teams","hooks_url":"https://api.github.com/repos/nert-gu/Xposition/hooks","issue_events_url":"https://api.github.com/repos/nert-gu/Xposition/issues/events{/number}","events_url":"https://api.github.com/repos/nert-gu/Xposition/events","assignees_url":"https://api.github.com/repos/nert-gu/Xposition/assignees{/user}","branches_url":"https://api.github.com/repos/nert-gu/Xposition/branches{/branch}","tags_url":"https://api.github.com/repos/nert-gu/Xposition/tags","blobs_url":"https://api.github.com/repos/nert-gu/Xposition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nert-gu/Xposition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nert-gu/Xposition/git/refs{/sha}","trees_url":"https://api.github.com/repos/nert-gu/Xposition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nert-gu/Xposition/statuses/{sha}","languages_url":"https://api.github.com/repos/nert-gu/Xposition/languages","stargazers_url":"https://api.github.com/repos/nert-gu/Xposition/stargazers","contributors_url":"https://api.github.com/repos/nert-gu/Xposition/contributors","subscribers_url":"https://api.github.com/repos/nert-gu/Xposition/subscribers","subscription_url":"https://api.github.com/repos/nert-gu/Xposition/subscription","commits_url":"https://api.github.com/repos/nert-gu/Xposition/commits{/sha}","git_commits_url":"https://api.github.com/repos/nert-gu/Xposition/git/commits{/sha}","comments_url":"https://api.github.com/repos/nert-gu/Xposition/comments{/number}","issue_comment_url":"https://api.github.com/repos/nert-gu/Xposition/issues/comments{/number}","contents_url":"https://api.github.com/repos/nert-gu/Xposition/contents/{+path}","compare_url":"https://api.github.com/repos/nert-gu/Xposition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nert-gu/Xposition/merges","archive_url":"https://api.github.com/repos/nert-gu/Xposition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nert-gu/Xposition/downloads","issues_url":"https://api.github.com/repos/nert-gu/Xposition/issues{/number}","pulls_url":"https://api.github.com/repos/nert-gu/Xposition/pulls{/number}","milestones_url":"https://api.github.com/repos/nert-gu/Xposition/milestones{/number}","notifications_url":"https://api.github.com/repos/nert-gu/Xposition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nert-gu/Xposition/labels{/name}","releases_url":"https://api.github.com/repos/nert-gu/Xposition/releases{/id}","deployments_url":"https://api.github.com/repos/nert-gu/Xposition/deployments","created_at":"2017-03-08T04:12:13Z","updated_at":"2018-07-10T13:30:42Z","pushed_at":"2018-07-21T00:28:02Z","git_url":"git://github.com/nert-gu/Xposition.git","ssh_url":"git@github.com:nert-gu/Xposition.git","clone_url":"https://github.com/nert-gu/Xposition.git","svn_url":"https://github.com/nert-gu/Xposition","homepage":null,"size":11187,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":24,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/103"},"html":{"href":"https://github.com/nert-gu/Xposition/pull/103"},"issue":{"href":"https://api.github.com/repos/nert-gu/Xposition/issues/103"},"comments":{"href":"https://api.github.com/repos/nert-gu/Xposition/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nert-gu/Xposition/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/nert-gu/Xposition/statuses/91002b06742c9166a5d791a8257f3fbb99662a53"}},"author_association":"CONTRIBUTOR"}} | {
"id": 84277254,
"name": "nert-gu/Xposition",
"url": "https://api.github.com/repos/nert-gu/Xposition"
} | {
"id": 985263,
"login": "nschneid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/985263?",
"url": "https://api.github.com/users/nschneid"
} | {
"id": 26146203,
"login": "nert-gu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26146203?",
"url": "https://api.github.com/orgs/nert-gu"
} | 2018-07-21T01:50:54 | 7997838590 | {"actor":{"display_login":"nschneid"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/comments/178467842","pull_request_review_id":108527880,"id":178467842,"diff_hunk":"@@ -25,15 +44,66 @@ use core::sync::atomic::Ordering;\n use alloc::boxed::Box;\n \n use crossbeam_utils::cache_padded::CachePadded;\n+use arrayvec::ArrayVec;\n \n use atomic::Owned;\n use collector::{Handle, Collector};\n use epoch::{AtomicEpoch, Epoch};\n use guard::{unprotected, Guard};\n-use garbage::{Bag, Garbage};\n+use deferred::Deferred;\n use sync::list::{List, Entry, IterError, IsElement};\n use sync::queue::Queue;\n \n+/// Maximum number of objects a bag can contain.\n+#[cfg(not(feature = \"strict_gc\"))]\n+const MAX_OBJECTS: usize = 64;\n+#[cfg(feature = \"strict_gc\")]\n+const MAX_OBJECTS: usize = 4;\n+\n+/// Bag of garbages.\n+#[derive(Default, Debug)]\n+pub struct Bag {\n+ /// Stashed objects.\n+ deferreds: ArrayVec<[Deferred; MAX_OBJECTS]>,\n+}\n+\n+// It is safe to implement `Send` for `Bag`, since the user of `Bag::try_push()` guarantees that\n+// another thread may execute any `Deferred` functions inside a `Bag`.\n+unsafe impl Send for Bag {}\n+\n+impl Bag {\n+ /// Returns a new, empty bag.\n+ pub fn new() -> Self {\n+ Self::default()\n+ }\n+\n+ /// Returns `true` if the bag is empty.\n+ pub fn is_empty(&self) -> bool {\n+ self.deferreds.is_empty()\n+ }\n+\n+ /// Attempts to insert a garbage object into the bag.\n+ ///\n+ /// Returns `Ok(())` if successful, and `Err(deferred)` for the given `deferred` if\n+ /// unsuccessful.\n+ ///\n+ /// # Safety\n+ ///\n+ /// Another thread may execute the `deferred` function.\n+ pub unsafe fn try_push(&mut self, deferred: Deferred) -> Result<(), Deferred> {\n+ self.deferreds.try_push(deferred).map_err(|e| e.element())\n+ }\n+}\n+\n+impl Drop for Bag {\n+ fn drop(&mut self) {\n+ // Call all deferred functions.\n+ for deferred in self.deferreds.iter_mut() {","path":"src/internal.rs","position":85,"original_position":85,"commit_id":"40c921087137aa6d7b1c8d4caea89f626aab0617","original_commit_id":"40c921087137aa6d7b1c8d4caea89f626aab0617","user":{"login":"Vtec234","id":13901751,"avatar_url":"https://avatars3.githubusercontent.com/u/13901751?v=4","gravatar_id":"","url":"https://api.github.com/users/Vtec234","html_url":"https://github.com/Vtec234","followers_url":"https://api.github.com/users/Vtec234/followers","following_url":"https://api.github.com/users/Vtec234/following{/other_user}","gists_url":"https://api.github.com/users/Vtec234/gists{/gist_id}","starred_url":"https://api.github.com/users/Vtec234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vtec234/subscriptions","organizations_url":"https://api.github.com/users/Vtec234/orgs","repos_url":"https://api.github.com/users/Vtec234/repos","events_url":"https://api.github.com/users/Vtec234/events{/privacy}","received_events_url":"https://api.github.com/users/Vtec234/received_events","type":"User","site_admin":false},"body":"I can't see anywhere where that could happen, but are we absolutely sure a `Deferred` is never dropped as a standalone object rather than when it's inside a `Bag`? This change would then make it never run, as opposed to having the individual `Garbage` destructor take care of it before the change.","created_at":"2018-04-01T20:11:19Z","updated_at":"2018-04-01T20:11:42Z","html_url":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77#discussion_r178467842","pull_request_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/comments/178467842"},"html":{"href":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77#discussion_r178467842"},"pull_request":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77","id":178733282,"html_url":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77","diff_url":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77.diff","patch_url":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77.patch","issue_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/77","number":77,"state":"open","locked":false,"title":"Remove the Garbage struct (closes #12)","user":{"login":"jeehoonkang","id":1201316,"avatar_url":"https://avatars0.githubusercontent.com/u/1201316?v=4","gravatar_id":"","url":"https://api.github.com/users/jeehoonkang","html_url":"https://github.com/jeehoonkang","followers_url":"https://api.github.com/users/jeehoonkang/followers","following_url":"https://api.github.com/users/jeehoonkang/following{/other_user}","gists_url":"https://api.github.com/users/jeehoonkang/gists{/gist_id}","starred_url":"https://api.github.com/users/jeehoonkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeehoonkang/subscriptions","organizations_url":"https://api.github.com/users/jeehoonkang/orgs","repos_url":"https://api.github.com/users/jeehoonkang/repos","events_url":"https://api.github.com/users/jeehoonkang/events{/privacy}","received_events_url":"https://api.github.com/users/jeehoonkang/received_events","type":"User","site_admin":false},"body":"There was a discussion on the naming of `Garbage` (#12). This PR simply removes it..","created_at":"2018-04-01T15:11:06Z","updated_at":"2018-04-01T20:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bfe1c3875556098269b39a425a05abc7486a06a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77/commits","review_comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77/comments","review_comment_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/77/comments","statuses_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/statuses/40c921087137aa6d7b1c8d4caea89f626aab0617","head":{"label":"jeehoonkang:remove-garbage","ref":"remove-garbage","sha":"40c921087137aa6d7b1c8d4caea89f626aab0617","user":{"login":"jeehoonkang","id":1201316,"avatar_url":"https://avatars0.githubusercontent.com/u/1201316?v=4","gravatar_id":"","url":"https://api.github.com/users/jeehoonkang","html_url":"https://github.com/jeehoonkang","followers_url":"https://api.github.com/users/jeehoonkang/followers","following_url":"https://api.github.com/users/jeehoonkang/following{/other_user}","gists_url":"https://api.github.com/users/jeehoonkang/gists{/gist_id}","starred_url":"https://api.github.com/users/jeehoonkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeehoonkang/subscriptions","organizations_url":"https://api.github.com/users/jeehoonkang/orgs","repos_url":"https://api.github.com/users/jeehoonkang/repos","events_url":"https://api.github.com/users/jeehoonkang/events{/privacy}","received_events_url":"https://api.github.com/users/jeehoonkang/received_events","type":"User","site_admin":false},"repo":{"id":97680713,"name":"crossbeam-epoch","full_name":"jeehoonkang/crossbeam-epoch","owner":{"login":"jeehoonkang","id":1201316,"avatar_url":"https://avatars0.githubusercontent.com/u/1201316?v=4","gravatar_id":"","url":"https://api.github.com/users/jeehoonkang","html_url":"https://github.com/jeehoonkang","followers_url":"https://api.github.com/users/jeehoonkang/followers","following_url":"https://api.github.com/users/jeehoonkang/following{/other_user}","gists_url":"https://api.github.com/users/jeehoonkang/gists{/gist_id}","starred_url":"https://api.github.com/users/jeehoonkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeehoonkang/subscriptions","organizations_url":"https://api.github.com/users/jeehoonkang/orgs","repos_url":"https://api.github.com/users/jeehoonkang/repos","events_url":"https://api.github.com/users/jeehoonkang/events{/privacy}","received_events_url":"https://api.github.com/users/jeehoonkang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeehoonkang/crossbeam-epoch","description":"Epoch-based garbage collection","fork":true,"url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch","forks_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/forks","keys_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/teams","hooks_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/hooks","issue_events_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/issues/events{/number}","events_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/events","assignees_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/assignees{/user}","branches_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/branches{/branch}","tags_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/tags","blobs_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/languages","stargazers_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/stargazers","contributors_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/contributors","subscribers_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/subscribers","subscription_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/subscription","commits_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/contents/{+path}","compare_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/merges","archive_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/downloads","issues_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/issues{/number}","pulls_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/labels{/name}","releases_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/releases{/id}","deployments_url":"https://api.github.com/repos/jeehoonkang/crossbeam-epoch/deployments","created_at":"2017-07-19T06:27:18Z","updated_at":"2018-03-27T12:37:05Z","pushed_at":"2018-04-01T15:45:10Z","git_url":"git://github.com/jeehoonkang/crossbeam-epoch.git","ssh_url":"git@github.com:jeehoonkang/crossbeam-epoch.git","clone_url":"https://github.com/jeehoonkang/crossbeam-epoch.git","svn_url":"https://github.com/jeehoonkang/crossbeam-epoch","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crossbeam-rs:master","ref":"master","sha":"3179e799f384816a0a9f2a3da82a147850e14d38","user":{"login":"crossbeam-rs","id":26314159,"avatar_url":"https://avatars0.githubusercontent.com/u/26314159?v=4","gravatar_id":"","url":"https://api.github.com/users/crossbeam-rs","html_url":"https://github.com/crossbeam-rs","followers_url":"https://api.github.com/users/crossbeam-rs/followers","following_url":"https://api.github.com/users/crossbeam-rs/following{/other_user}","gists_url":"https://api.github.com/users/crossbeam-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbeam-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbeam-rs/subscriptions","organizations_url":"https://api.github.com/users/crossbeam-rs/orgs","repos_url":"https://api.github.com/users/crossbeam-rs/repos","events_url":"https://api.github.com/users/crossbeam-rs/events{/privacy}","received_events_url":"https://api.github.com/users/crossbeam-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":92106962,"name":"crossbeam-epoch","full_name":"crossbeam-rs/crossbeam-epoch","owner":{"login":"crossbeam-rs","id":26314159,"avatar_url":"https://avatars0.githubusercontent.com/u/26314159?v=4","gravatar_id":"","url":"https://api.github.com/users/crossbeam-rs","html_url":"https://github.com/crossbeam-rs","followers_url":"https://api.github.com/users/crossbeam-rs/followers","following_url":"https://api.github.com/users/crossbeam-rs/following{/other_user}","gists_url":"https://api.github.com/users/crossbeam-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbeam-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbeam-rs/subscriptions","organizations_url":"https://api.github.com/users/crossbeam-rs/orgs","repos_url":"https://api.github.com/users/crossbeam-rs/repos","events_url":"https://api.github.com/users/crossbeam-rs/events{/privacy}","received_events_url":"https://api.github.com/users/crossbeam-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crossbeam-rs/crossbeam-epoch","description":"Epoch-based garbage collection","fork":false,"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch","forks_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/forks","keys_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/teams","hooks_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/hooks","issue_events_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/events{/number}","events_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/events","assignees_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/assignees{/user}","branches_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/branches{/branch}","tags_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/tags","blobs_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/languages","stargazers_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/stargazers","contributors_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/contributors","subscribers_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/subscribers","subscription_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/subscription","commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/contents/{+path}","compare_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/merges","archive_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/downloads","issues_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues{/number}","pulls_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/labels{/name}","releases_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/releases{/id}","deployments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/deployments","created_at":"2017-05-22T23:05:37Z","updated_at":"2018-04-01T18:40:50Z","pushed_at":"2018-04-01T15:45:12Z","git_url":"git://github.com/crossbeam-rs/crossbeam-epoch.git","ssh_url":"git@github.com:crossbeam-rs/crossbeam-epoch.git","clone_url":"https://github.com/crossbeam-rs/crossbeam-epoch.git","svn_url":"https://github.com/crossbeam-rs/crossbeam-epoch","homepage":null,"size":161,"stargazers_count":47,"watchers_count":47,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":7,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77"},"html":{"href":"https://github.com/crossbeam-rs/crossbeam-epoch/pull/77"},"issue":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/77"},"comments":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-epoch/statuses/40c921087137aa6d7b1c8d4caea89f626aab0617"}},"author_association":"CONTRIBUTOR"}} | {
"id": 92106962,
"name": "crossbeam-rs/crossbeam-epoch",
"url": "https://api.github.com/repos/crossbeam-rs/crossbeam-epoch"
} | {
"id": 13901751,
"login": "Vtec234",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13901751?",
"url": "https://api.github.com/users/Vtec234"
} | {
"id": 26314159,
"login": "crossbeam-rs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26314159?",
"url": "https://api.github.com/orgs/crossbeam-rs"
} | 2018-04-01T20:11:19 | 7464626787 | {"actor":{"display_login":"Vtec234"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/windmilleng/pets/pulls/comments/206598271","pull_request_review_id":142041019,"id":206598271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjU5ODI3MQ==","diff_hunk":"@@ -168,6 +169,52 @@ func (p *Petsitter) execPetsFileAt(t *skylark.Thread, module string, isMissingOk\n \treturn skylark.StringDict(result), nil\n }\n \n+// Service(server, “localhost”, 8081)","path":"internal/mill/exec.go","position":12,"original_position":12,"commit_id":"96f22fe2318b0a61896dc63af21383ad8bb11d52","original_commit_id":"96f22fe2318b0a61896dc63af21383ad8bb11d52","user":{"login":"nicks","id":278641,"node_id":"MDQ6VXNlcjI3ODY0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/278641?v=4","gravatar_id":"","url":"https://api.github.com/users/nicks","html_url":"https://github.com/nicks","followers_url":"https://api.github.com/users/nicks/followers","following_url":"https://api.github.com/users/nicks/following{/other_user}","gists_url":"https://api.github.com/users/nicks/gists{/gist_id}","starred_url":"https://api.github.com/users/nicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicks/subscriptions","organizations_url":"https://api.github.com/users/nicks/orgs","repos_url":"https://api.github.com/users/nicks/repos","events_url":"https://api.github.com/users/nicks/events{/privacy}","received_events_url":"https://api.github.com/users/nicks/received_events","type":"User","site_admin":false},"body":"i think you need to add this to Petsitter's builtins?","created_at":"2018-07-31T16:34:05Z","updated_at":"2018-07-31T16:34:34Z","html_url":"https://github.com/windmilleng/pets/pull/26#discussion_r206598271","pull_request_url":"https://api.github.com/repos/windmilleng/pets/pulls/26","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/comments/206598271"},"html":{"href":"https://github.com/windmilleng/pets/pull/26#discussion_r206598271"},"pull_request":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/windmilleng/pets/pulls/26","id":204260261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjYwMjYx","html_url":"https://github.com/windmilleng/pets/pull/26","diff_url":"https://github.com/windmilleng/pets/pull/26.diff","patch_url":"https://github.com/windmilleng/pets/pull/26.patch","issue_url":"https://api.github.com/repos/windmilleng/pets/issues/26","number":26,"state":"open","locked":false,"title":"[VERY WIP]: pets: Skeleton for Service","user":{"login":"pmt","id":4122993,"node_id":"MDQ6VXNlcjQxMjI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4122993?v=4","gravatar_id":"","url":"https://api.github.com/users/pmt","html_url":"https://github.com/pmt","followers_url":"https://api.github.com/users/pmt/followers","following_url":"https://api.github.com/users/pmt/following{/other_user}","gists_url":"https://api.github.com/users/pmt/gists{/gist_id}","starred_url":"https://api.github.com/users/pmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmt/subscriptions","organizations_url":"https://api.github.com/users/pmt/orgs","repos_url":"https://api.github.com/users/pmt/repos","events_url":"https://api.github.com/users/pmt/events{/privacy}","received_events_url":"https://api.github.com/users/pmt/received_events","type":"User","site_admin":false},"body":"I have some questions.\r\nI get really confused on argument calls on stuff like ProcsFromFS and WithExposedHost. A good example is\r\n```\r\nnot enough arguments in call to method expression proc.ProcFS.ProcsFromFS\r\n have ()\r\n want (proc.ProcFS)\r\n```\r\n\r\non L192. \r\n\r\nI have a similar problem with how to define things like `pr` on L196. I need to declare it outside the function (right?) as a PetsProc but I'm not sure how.","created_at":"2018-07-26T20:38:39Z","updated_at":"2018-07-31T16:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"909c5104f0ae1b3e9ee10bb2ce02e0b63acb582e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/windmilleng/pets/pulls/26/commits","review_comments_url":"https://api.github.com/repos/windmilleng/pets/pulls/26/comments","review_comment_url":"https://api.github.com/repos/windmilleng/pets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windmilleng/pets/issues/26/comments","statuses_url":"https://api.github.com/repos/windmilleng/pets/statuses/96f22fe2318b0a61896dc63af21383ad8bb11d52","head":{"label":"windmilleng:pmt/service","ref":"pmt/service","sha":"96f22fe2318b0a61896dc63af21383ad8bb11d52","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":141313396,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMTMzOTY=","name":"pets","full_name":"windmilleng/pets","owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windmilleng/pets","description":"Process for Editing Tons of Services 🐈🐈🐈","fork":false,"url":"https://api.github.com/repos/windmilleng/pets","forks_url":"https://api.github.com/repos/windmilleng/pets/forks","keys_url":"https://api.github.com/repos/windmilleng/pets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/pets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/pets/teams","hooks_url":"https://api.github.com/repos/windmilleng/pets/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/pets/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/pets/events","assignees_url":"https://api.github.com/repos/windmilleng/pets/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/pets/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/pets/tags","blobs_url":"https://api.github.com/repos/windmilleng/pets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/pets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/pets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/pets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/pets/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/pets/languages","stargazers_url":"https://api.github.com/repos/windmilleng/pets/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/pets/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/pets/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/pets/subscription","commits_url":"https://api.github.com/repos/windmilleng/pets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/pets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/pets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/pets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/pets/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/pets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/pets/merges","archive_url":"https://api.github.com/repos/windmilleng/pets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/pets/downloads","issues_url":"https://api.github.com/repos/windmilleng/pets/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/pets/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/pets/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/pets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/pets/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/pets/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/pets/deployments","created_at":"2018-07-17T16:05:43Z","updated_at":"2018-07-31T16:23:41Z","pushed_at":"2018-07-31T16:23:42Z","git_url":"git://github.com/windmilleng/pets.git","ssh_url":"git@github.com:windmilleng/pets.git","clone_url":"https://github.com/windmilleng/pets.git","svn_url":"https://github.com/windmilleng/pets","homepage":null,"size":227,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"windmilleng:master","ref":"master","sha":"fd11dfe72e9023a82d0c572aff786768ad02cb5d","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":141313396,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMTMzOTY=","name":"pets","full_name":"windmilleng/pets","owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windmilleng/pets","description":"Process for Editing Tons of Services 🐈🐈🐈","fork":false,"url":"https://api.github.com/repos/windmilleng/pets","forks_url":"https://api.github.com/repos/windmilleng/pets/forks","keys_url":"https://api.github.com/repos/windmilleng/pets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/pets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/pets/teams","hooks_url":"https://api.github.com/repos/windmilleng/pets/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/pets/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/pets/events","assignees_url":"https://api.github.com/repos/windmilleng/pets/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/pets/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/pets/tags","blobs_url":"https://api.github.com/repos/windmilleng/pets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/pets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/pets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/pets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/pets/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/pets/languages","stargazers_url":"https://api.github.com/repos/windmilleng/pets/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/pets/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/pets/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/pets/subscription","commits_url":"https://api.github.com/repos/windmilleng/pets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/pets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/pets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/pets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/pets/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/pets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/pets/merges","archive_url":"https://api.github.com/repos/windmilleng/pets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/pets/downloads","issues_url":"https://api.github.com/repos/windmilleng/pets/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/pets/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/pets/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/pets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/pets/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/pets/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/pets/deployments","created_at":"2018-07-17T16:05:43Z","updated_at":"2018-07-31T16:23:41Z","pushed_at":"2018-07-31T16:23:42Z","git_url":"git://github.com/windmilleng/pets.git","ssh_url":"git@github.com:windmilleng/pets.git","clone_url":"https://github.com/windmilleng/pets.git","svn_url":"https://github.com/windmilleng/pets","homepage":null,"size":227,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/26"},"html":{"href":"https://github.com/windmilleng/pets/pull/26"},"issue":{"href":"https://api.github.com/repos/windmilleng/pets/issues/26"},"comments":{"href":"https://api.github.com/repos/windmilleng/pets/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windmilleng/pets/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/windmilleng/pets/statuses/96f22fe2318b0a61896dc63af21383ad8bb11d52"}},"author_association":"CONTRIBUTOR"}} | {
"id": 141313396,
"name": "windmilleng/pets",
"url": "https://api.github.com/repos/windmilleng/pets"
} | {
"id": 278641,
"login": "nicks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/278641?",
"url": "https://api.github.com/users/nicks"
} | {
"id": 26349925,
"login": "windmilleng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26349925?",
"url": "https://api.github.com/orgs/windmilleng"
} | 2018-07-31T16:34:05 | 8045266439 | {"actor":{"display_login":"nicks"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/169465049","pull_request_review_id":97994932,"id":169465049,"diff_hunk":"@@ -69,6 +69,45 @@\n \t\treturn 0\n \treturn 1\n \n+/datum/stack_recipe/dorf\n+\tvar/inherit_material\n+\tvar/gen_quality\n+\n+/datum/stack_recipe/dorf/New(title, result_type, req_amount = 1, res_amount = 1, max_res_amount = 1, time = 0, one_per_turf = 0, on_floor = 0, start_unanchored = 0, other_reqs = list(), inherit_material = FALSE, gen_quality = FALSE)\n+\t..()\n+\tsrc.inherit_material = inherit_material\n+\tsrc.gen_quality = gen_quality\n+\n+\n+/datum/stack_recipe/dorf/finish_building(mob/usr, var/obj/item/stack/S, var/obj/R)\n+\tvar/datum/material/mat\n+\tvar/datum/materials/materials_list = new\n+\tif(istype(S, /obj/item/stack/sheet/mineral)) //With mineral, it's straight forward\n+\t\tvar/obj/item/stack/sheet/mineral/M = S\n+\n+\t\tmat = materials_list.getMaterial(M.recyck_mat)\n+\telse //Not so straight forward\n+\t\tswitch(S.type)\n+\t\t\tif(/obj/item/stack/sheet/metal)\n+\t\t\t\tmat = materials_list.getMaterial(MAT_IRON)\n+\t\t\tif(/obj/item/stack/sheet/wood)\n+\t\t\t\tmat = materials_list.getMaterial(MAT_WOOD)\n+\t\tif(istype(S, /obj/item/stack/sheet/glass))\n+\t\t\tmat = materials_list.getMaterial(MAT_GLASS)\n+\tto_chat(usr, \"mat = [mat], inherit_material = [inherit_material], gen_quality = [gen_quality]\")\n+\tif(mat)\n+\t\tif(inherit_material)\n+\t\t\tto_chat(world, \"inherit_material called by [mat]\")","path":"code/game/objects/items/stacks/stack_recipes.dm","position":32,"original_position":32,"commit_id":"3cfc0b0eb2bb598ce5c85a78adaefb4f2259f9e9","original_commit_id":"3cfc0b0eb2bb598ce5c85a78adaefb4f2259f9e9","user":{"login":"DrCelt","id":7193289,"avatar_url":"https://avatars3.githubusercontent.com/u/7193289?v=4","gravatar_id":"","url":"https://api.github.com/users/DrCelt","html_url":"https://github.com/DrCelt","followers_url":"https://api.github.com/users/DrCelt/followers","following_url":"https://api.github.com/users/DrCelt/following{/other_user}","gists_url":"https://api.github.com/users/DrCelt/gists{/gist_id}","starred_url":"https://api.github.com/users/DrCelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrCelt/subscriptions","organizations_url":"https://api.github.com/users/DrCelt/orgs","repos_url":"https://api.github.com/users/DrCelt/repos","events_url":"https://api.github.com/users/DrCelt/events{/privacy}","received_events_url":"https://api.github.com/users/DrCelt/received_events","type":"User","site_admin":false},"body":"uh oh","created_at":"2018-02-20T21:27:53Z","updated_at":"2018-02-20T21:30:34Z","html_url":"https://github.com/vgstation-coders/vgstation13/pull/17540#discussion_r169465049","pull_request_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments/169465049"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/17540#discussion_r169465049"},"pull_request":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540"}}},"pull_request":{"url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540","id":170312221,"html_url":"https://github.com/vgstation-coders/vgstation13/pull/17540","diff_url":"https://github.com/vgstation-coders/vgstation13/pull/17540.diff","patch_url":"https://github.com/vgstation-coders/vgstation13/pull/17540.patch","issue_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/17540","number":17540,"state":"open","locked":false,"title":"Interesting Crafting","user":{"login":"MadmanMartian","id":30557196,"avatar_url":"https://avatars2.githubusercontent.com/u/30557196?v=4","gravatar_id":"","url":"https://api.github.com/users/MadmanMartian","html_url":"https://github.com/MadmanMartian","followers_url":"https://api.github.com/users/MadmanMartian/followers","following_url":"https://api.github.com/users/MadmanMartian/following{/other_user}","gists_url":"https://api.github.com/users/MadmanMartian/gists{/gist_id}","starred_url":"https://api.github.com/users/MadmanMartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadmanMartian/subscriptions","organizations_url":"https://api.github.com/users/MadmanMartian/orgs","repos_url":"https://api.github.com/users/MadmanMartian/repos","events_url":"https://api.github.com/users/MadmanMartian/events{/privacy}","received_events_url":"https://api.github.com/users/MadmanMartian/received_events","type":"User","site_admin":false},"body":"closes #13380\r\n\r\n- [x] Inherit color from base material type\r\n- [ ] Make use of some form of functionality for base material type\r\n- [ ] Add quality handling","created_at":"2018-02-20T21:23:32Z","updated_at":"2018-02-20T21:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54a3fecd14e8dc6aaae5a54999473f27573abf10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":174717955,"url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/Content","name":"Content","color":"eb6420","default":false},{"id":735774687,"url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/WiP","name":"WiP","color":"e11d21","default":false},{"id":185450088,"url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels/%E2%9C%8B%20Do%20Not%20Merge%20%E2%9C%8B","name":"✋ Do Not Merge ✋","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540/commits","review_comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540/comments","review_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/17540/comments","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/3cfc0b0eb2bb598ce5c85a78adaefb4f2259f9e9","head":{"label":"MadmanMartian:material_datums_expansion","ref":"material_datums_expansion","sha":"3cfc0b0eb2bb598ce5c85a78adaefb4f2259f9e9","user":{"login":"MadmanMartian","id":30557196,"avatar_url":"https://avatars2.githubusercontent.com/u/30557196?v=4","gravatar_id":"","url":"https://api.github.com/users/MadmanMartian","html_url":"https://github.com/MadmanMartian","followers_url":"https://api.github.com/users/MadmanMartian/followers","following_url":"https://api.github.com/users/MadmanMartian/following{/other_user}","gists_url":"https://api.github.com/users/MadmanMartian/gists{/gist_id}","starred_url":"https://api.github.com/users/MadmanMartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadmanMartian/subscriptions","organizations_url":"https://api.github.com/users/MadmanMartian/orgs","repos_url":"https://api.github.com/users/MadmanMartian/repos","events_url":"https://api.github.com/users/MadmanMartian/events{/privacy}","received_events_url":"https://api.github.com/users/MadmanMartian/received_events","type":"User","site_admin":false},"repo":{"id":98753310,"name":"vgstation13","full_name":"MadmanMartian/vgstation13","owner":{"login":"MadmanMartian","id":30557196,"avatar_url":"https://avatars2.githubusercontent.com/u/30557196?v=4","gravatar_id":"","url":"https://api.github.com/users/MadmanMartian","html_url":"https://github.com/MadmanMartian","followers_url":"https://api.github.com/users/MadmanMartian/followers","following_url":"https://api.github.com/users/MadmanMartian/following{/other_user}","gists_url":"https://api.github.com/users/MadmanMartian/gists{/gist_id}","starred_url":"https://api.github.com/users/MadmanMartian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadmanMartian/subscriptions","organizations_url":"https://api.github.com/users/MadmanMartian/orgs","repos_url":"https://api.github.com/users/MadmanMartian/repos","events_url":"https://api.github.com/users/MadmanMartian/events{/privacy}","received_events_url":"https://api.github.com/users/MadmanMartian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MadmanMartian/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/MadmanMartian/vgstation13","forks_url":"https://api.github.com/repos/MadmanMartian/vgstation13/forks","keys_url":"https://api.github.com/repos/MadmanMartian/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MadmanMartian/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MadmanMartian/vgstation13/teams","hooks_url":"https://api.github.com/repos/MadmanMartian/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/MadmanMartian/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/MadmanMartian/vgstation13/events","assignees_url":"https://api.github.com/repos/MadmanMartian/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/MadmanMartian/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/MadmanMartian/vgstation13/tags","blobs_url":"https://api.github.com/repos/MadmanMartian/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MadmanMartian/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MadmanMartian/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/MadmanMartian/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MadmanMartian/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/MadmanMartian/vgstation13/languages","stargazers_url":"https://api.github.com/repos/MadmanMartian/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/MadmanMartian/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/MadmanMartian/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/MadmanMartian/vgstation13/subscription","commits_url":"https://api.github.com/repos/MadmanMartian/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/MadmanMartian/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/MadmanMartian/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/MadmanMartian/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/MadmanMartian/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/MadmanMartian/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MadmanMartian/vgstation13/merges","archive_url":"https://api.github.com/repos/MadmanMartian/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MadmanMartian/vgstation13/downloads","issues_url":"https://api.github.com/repos/MadmanMartian/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/MadmanMartian/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/MadmanMartian/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/MadmanMartian/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MadmanMartian/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/MadmanMartian/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/MadmanMartian/vgstation13/deployments","created_at":"2017-07-29T19:02:36Z","updated_at":"2017-07-29T19:02:49Z","pushed_at":"2018-02-20T21:19:31Z","git_url":"git://github.com/MadmanMartian/vgstation13.git","ssh_url":"git@github.com:MadmanMartian/vgstation13.git","clone_url":"https://github.com/MadmanMartian/vgstation13.git","svn_url":"https://github.com/MadmanMartian/vgstation13","homepage":"","size":1205105,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"vgstation-coders:Bleeding-Edge","ref":"Bleeding-Edge","sha":"6ed25e03b1d7688cfa7bf8b65e653037f212296f","user":{"login":"vgstation-coders","id":26489760,"avatar_url":"https://avatars2.githubusercontent.com/u/26489760?v=4","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"vgstation-coders/vgstation13","owner":{"login":"vgstation-coders","id":26489760,"avatar_url":"https://avatars2.githubusercontent.com/u/26489760?v=4","gravatar_id":"","url":"https://api.github.com/users/vgstation-coders","html_url":"https://github.com/vgstation-coders","followers_url":"https://api.github.com/users/vgstation-coders/followers","following_url":"https://api.github.com/users/vgstation-coders/following{/other_user}","gists_url":"https://api.github.com/users/vgstation-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/vgstation-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgstation-coders/subscriptions","organizations_url":"https://api.github.com/users/vgstation-coders/orgs","repos_url":"https://api.github.com/users/vgstation-coders/repos","events_url":"https://api.github.com/users/vgstation-coders/events{/privacy}","received_events_url":"https://api.github.com/users/vgstation-coders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vgstation-coders/vgstation13","description":"Butts","fork":false,"url":"https://api.github.com/repos/vgstation-coders/vgstation13","forks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/forks","keys_url":"https://api.github.com/repos/vgstation-coders/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgstation-coders/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgstation-coders/vgstation13/teams","hooks_url":"https://api.github.com/repos/vgstation-coders/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/vgstation-coders/vgstation13/events","assignees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/vgstation-coders/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/tags","blobs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/vgstation-coders/vgstation13/languages","stargazers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/vgstation-coders/vgstation13/subscription","commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgstation-coders/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgstation-coders/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/vgstation-coders/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgstation-coders/vgstation13/merges","archive_url":"https://api.github.com/repos/vgstation-coders/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgstation-coders/vgstation13/downloads","issues_url":"https://api.github.com/repos/vgstation-coders/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/vgstation-coders/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/vgstation-coders/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgstation-coders/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/vgstation-coders/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/vgstation-coders/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2018-02-20T21:00:49Z","pushed_at":"2018-02-20T21:23:33Z","git_url":"git://github.com/vgstation-coders/vgstation13.git","ssh_url":"git@github.com:vgstation-coders/vgstation13.git","clone_url":"https://github.com/vgstation-coders/vgstation13.git","svn_url":"https://github.com/vgstation-coders/vgstation13","homepage":"","size":1201698,"stargazers_count":136,"watchers_count":136,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":1989,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":250,"open_issues":1989,"watchers":136,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540"},"html":{"href":"https://github.com/vgstation-coders/vgstation13/pull/17540"},"issue":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/17540"},"comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/issues/17540/comments"},"review_comments":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540/comments"},"review_comment":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/pulls/17540/commits"},"statuses":{"href":"https://api.github.com/repos/vgstation-coders/vgstation13/statuses/3cfc0b0eb2bb598ce5c85a78adaefb4f2259f9e9"}},"author_association":"COLLABORATOR"}} | {
"id": 10441188,
"name": "vgstation-coders/vgstation13",
"url": "https://api.github.com/repos/vgstation-coders/vgstation13"
} | {
"id": 7193289,
"login": "DrCelt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7193289?",
"url": "https://api.github.com/users/DrCelt"
} | {
"id": 26489760,
"login": "vgstation-coders",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26489760?",
"url": "https://api.github.com/orgs/vgstation-coders"
} | 2018-02-20T21:27:53 | 7271989328 | {"actor":{"display_login":"DrCelt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments/171128843","pull_request_review_id":99923270,"id":171128843,"diff_hunk":"@@ -1,15 +1,319 @@\n \"\"\"Parser responsible for reading the ``*res.m`` files\"\"\"\n+import re\n \n-from serpentTools.objects.readers import BaseReader\n \n+from numpy import array, empty\n \n-class ResultsReader(BaseReader):\n+\n+from serpentTools.settings import rc\n+from serpentTools.objects import splitItems, convertVariableName\n+from serpentTools.objects.containers import HomogUniv\n+from serpentTools.objects.readers import XSReader\n+from serpentTools.messages import info, SerpentToolsException, warning\n+\n+\n+class ResultsReader(XSReader):\n \"\"\"\n Parser responsible for reading and working with result files.\n \n+ .. note::\n+\n+ Branching points for unique burnup steps and universes,\n+ will be overwritten\n+ \n Parameters\n ----------\n filePath: str\n- path to the depletion file\n+ path to the results file\n+ \n+ Raises\n+ ------\n+ SerpentToolsException\n+ If the file is corrupted (empty, not complete), \n+ or the Serpent version cannot be supported\n \"\"\"\n- pass\n+\n+ def __init__(self, filePath):\n+ XSReader.__init__(self, filePath, 'xs')\n+ self.__fileObj = None\n+ self._idxSect = [False, False, False]\n+ self._counter = {'univ': 0, 'step': 0}\n+ self.metadata = {} # metadata - data that does not change (e.g. execution path)\n+ self.resdata = {} # results (e.g. k-eff)\n+ self.univdata = {} # universe data (e.g. cross-sections)\n+ self._univID = {}\n+ self._days = 0\n+ self._bu = 0\n+ self._buIdx = 0\n+\n+ def read(self):\n+ \"\"\"Read through the results file and store requested data.\"\"\"\n+ self._preProcessData() # pre-process the data\n+ info('Preparing to read {}'.format(self.filePath))\n+ with open(self.filePath, 'r') as fObject:\n+ for tline in fObject:\n+ self._processResultsChunk(tline)\n+ info('Done reading results file')\n+\n+ def _processResultsChunk(self, tline):\n+ \"\"\"Performs the main processing of the results.\"\"\"\n+ flagStore = self._positionInFile(tline)\n+ condStore = self._checkStoreData(flagStore)\n+ # If not an empty line or a comment\n+ if condStore and tline.strip() != '' and not re.search(r'\\%', tline):\n+ currKey = re.search(r'^\\w+', tline)\n+ if currKey is not None:\n+ keyName = convertVariableName(currKey.group())\n+ if keyName in self._resKeys:\n+ values = self._getDictVal(tline)\n+ if self._idxSect[0] and self._checkAddVariable(currKey.group()):\n+ self.metadata[keyName] = values\n+ elif self._idxSect[1] and self._checkAddVariable(currKey.group()):\n+ self.resdata[keyName][self._counter['step']-1, :] = values\n+ else:\n+ self._processUnivData(flagStore, currKey.group(), values)\n+\n+\n+ def _processUnivData(self, flagStore, varName, values):\n+ \"\"\"Creates a univ container and stores the data\"\"\"\n+ if flagStore:\n+ self._currUniv = values\n+ if self._daysStr in self.resdata.keys() and self._buStr in self.resdata.keys():\n+ idxStep = self._counter['step']-1\n+ self._days = self.resdata[self._daysStr][idxStep, 0]\n+ self._bu = self.resdata[self._buStr][idxStep, 0]\n+ self._buIdx = self.resdata[self._buIdxStr][idxStep, 0]\n+ self._brachID = (self._currUniv, self._bu, self._buIdx, self._days)\n+ self.univdata[self._brachID] = HomogUniv(self._currUniv, self._bu, self._buIdx, self._days)\n+ else:\n+ if self._checkAddVariable(varName):\n+ if self.strSearch['inf'] in varName[0:4] or self.strSearch['b1'] in varName[0:4]:\n+ vals, uncs = splitItems(values)\n+ self.univdata[self._brachID].addData(varName, array(uncs), True)\n+ self.univdata[self._brachID].addData(varName, array(vals), False)\n+ else:\n+ self.univdata[self._brachID].addData(varName, array(values), False)\n+\n+ def _preProcessData(self):\n+ \"\"\"Pre-process data before collecting it\"\"\"\n+ self._versionSerpent() # Get the utilized Serpent version\n+ self._numUnivSteps() # Count the number of universes repetitions for memory allocation\n+ vals = [self._univID[item] for item in self._univID]\n+ if vals == {}:\n+ raise SerpentToolsException(\"No universes are present in the file.\\n\"\n+ \"Parser: {}\\nFile: {}\".format(self, self.filePath))\n+ if len(vals) > 1 and not vals[1:] == vals[:-1]:\n+ raise SerpentToolsException(\"The repetitions of universes in the file is not equal.\\n\"\n+ \"Parser: {}\\nFile: {}\".format(self, self.filePath))\n+ self._ChunkPosition() # identify the 1st block for defining the dictionary\n+ if self._ChunkPos == 0:\n+ raise SerpentToolsException(\"The results file is corrupted.\\n\"\n+ \"Parser: {}\\nFile: {}\".format(self, self.filePath))\n+ self._defineResultDict() # Obtain the names of the variables to be stored\n+ if self._resKeys == []:\n+ raise SerpentToolsException(\"No variables appear in the results file.\\n\"\n+ \"Parser: {}\\nFile: {}\".format(self, self.filePath))\n+\n+ def _defineResultDict(self):\n+ \"\"\" Initializes the dictionary for ALL results included in .res.m\"\"\"\n+ self._idxSect = [False, False, False]\n+ self._resKeys = [] # Includes a complete set of .res variables\n+ fObj = open(self.filePath, 'r')\n+ numChar = 0 # count the number of characters\n+ nUniv = len(self._univID) # number of steps\n+ nSteps = [self._univID[item] for item in self._univID][0]\n+ for tline in fObj:\n+ self._positionInFile(tline)\n+ if numChar < self._ChunkPos[0]:\n+ numChar += len(tline)\n+ continue\n+ # Not an empty line and not a comment\n+ if tline.strip() != '' and not re.search(r'\\%', tline):\n+ currKey = re.search(r'^\\w+', tline)\n+ if currKey:\n+ keyName = convertVariableName(currKey.group())\n+ self._initResData(keyName, nSteps, tline)\n+ numChar += len(tline)\n+ if numChar >= self._ChunkPos[1]:\n+ break\n+ fObj.close()\n+ self._idxSect = [False, False, False]\n+\n+ def _initResData(self, key, nSteps, tline):\n+ \"\"\"Initializes the dimensions of the variable\"\"\"\n+ if key not in self._resKeys:\n+ # Type of data (general meta, universes)\n+ self._resKeys.append(key)\n+ nvals = len(self._getDictVal(tline))\n+ if self._idxSect[0]:\n+ self.metadata[key] = ''\n+ elif self._idxSect[1]:\n+ self.resdata[key] = \\\n+ empty((nSteps, nvals))\n+\n+ def _versionSerpent(self):\n+ \"\"\"Identifies the utilized version\"\"\"\n+ with open(self.filePath, 'r') as fObject:\n+ if fObject is None:\n+ raise IOError(\"Attempting to read on file that does not exist.\\n\"\n+ \"Parser: {}\\nFile: {}\".format(self, self.filePath))\n+ for tline in fObject:\n+ # If not an empty line or a comment\n+ if re.search('VERSION', tline):\n+ version = self._getDictVal(tline)\n+ self._mapStrVersions(version)\n+ break\n+\n+ def _numUnivSteps(self):\n+ \"\"\"Identifies how many universes and burnup steps are included\"\"\"\n+ # Default number of universes and burnup steps\n+ with open(self.filePath, 'r') as fObject:\n+ for tline in fObject:\n+ # If not an empty line or a comment\n+ if re.search(self.strSearch['universe'], tline):\n+ currUniv = self._getDictVal(tline)\n+ self._addUniv(currUniv)\n+\n+ def _addUniv(self, currUniv):\n+ \"\"\"Add the current universe or add its counter\"\"\"\n+ if currUniv in self._univID:\n+ self._univID[currUniv] += 1\n+ else:\n+ self._univID[currUniv] = 1\n+\n+ def _getDictVal(self, tline):\n+ \"\"\"Gets the values to the dictionary\"\"\"\n+ SepOptions = {\n+ 'list': r'\\=.\\[.+\\]',\n+ 'singleVal': r'\\=.+',\n+ 'string': r'\\=.+\\'.+\\' '}\n+ if re.search(SepOptions['string'], tline) is not None:\n+ strMatch = re.search(SepOptions['string'], tline)\n+ idxpos = [pos for pos, char in enumerate(strMatch.group()) if char == '\\'']\n+ return strMatch.group()[idxpos[0] + 1:idxpos[1]]\n+ elif re.search(SepOptions['list'], tline) is not None:\n+ strMatch = re.search(SepOptions['list'], tline)\n+ strMatch = self._ReplaceNaN(strMatch.group()) # remove NaN & Inf\n+ strMatch = self._stripRedundantChar(strMatch, ['[', ']', '=', ';'])\n+ return self._str2num(strMatch)\n+ elif re.search(SepOptions['singleVal'], tline) is not None:\n+ strMatch = re.search(SepOptions['singleVal'], tline)\n+ strMatch = self._stripRedundantChar(strMatch.group(), ['=', ';'])\n+ return self._str2num(strMatch)\n+ else:\n+ raise IOError(\"Corrupted line.\\n\"\n+ \"Parser: {}\\nFile: {}\\nLine: {}\".format(self, self.filePath, tline))\n+\n+ def _ChunkPosition(self):\n+ \"\"\"Identifies the first block for the definition of the dictionary\"\"\"\n+ self._ChunkPos = [0, 0] # [start, end] position of the first block\n+ cond = [False, False]\n+ fObj = open(self.filePath, 'r')\n+ numChar = 0 # counts the number of characters\n+ for tline in fObj:\n+ if re.search(self.strSearch['start'], tline) is not None:\n+ cond[0] = True\n+ self._ChunkPos[0] = numChar # equivalent to tell()\n+ if re.search(self.strSearch['end'], tline) is not None and self._ChunkPos[0]:\n+ cond[1] = True\n+ self._ChunkPos[1] = numChar\n+ break\n+ numChar += len(tline)\n+ self._ChunkPos[1] = numChar\n+ fObj.close()\n+\n+ def _positionInFile(self, tline):\n+ \"\"\"The function identifies the position in the file and returns\n+ The sections are: general, meta, cross-sections\"\"\"\n+ if re.search(self.strSearch['start'], tline):\n+ self._idxSect = [True, False, False]\n+ return True\n+ elif re.search(self.strSearch['meta'], tline):\n+ self._idxSect = [False, True, False]\n+ return True\n+ elif re.search(self.strSearch['universe'], tline):\n+ self._idxSect = [False, False, True]\n+ return True\n+ return False\n+\n+ def _checkStoreData(self, flagIn):\n+ \"\"\"Checks whether the data should be stored in the dictionary\"\"\"\n+ flag = False\n+ idx = [i for i, item in enumerate(self._idxSect) if item]\n+ if idx != []:\n+ if idx[0] == 0 and self._counter['univ'] == 0 and self._counter['step'] == 0:\n+ flag = True # General data\n+ elif idx[0] == 1 and self._counter['univ'] == 0:\n+ flag = True\n+ if flagIn:\n+ self._counter['step'] += 1 # Step data\n+ elif idx[0] == 2:\n+ flag = True\n+ if flagIn:\n+ self._counter['univ'] += 1 # Universe data\n+ if self._counter['univ'] >= len(self._univID):\n+ self._counter['univ'] = 0\n+ else:\n+ flag = False # Redundant data\n+ return flag\n+\n+ def _mapStrVersions(self, version):\n+ \"\"\"Assigns search strings for different Serpent versions\"\"\"\n+ MapStrVersions = {'Serpent 2.1.29':\n+ {'start': 'VERSION ',\n+ 'end': 'counter',\n+ 'meta': 'Collision and reaction sampling',\n+ 'universe': 'GC_UNIVERSE_NAME',\n+ 'days':'BURN_DAYS',\n+ 'bu':'BURNUP',\n+ 'buIdx':'BURN_STEP',\n+ 'inf':'_INF',\n+ 'b1':'_B1'}}\n+ if version in MapStrVersions.keys():\n+ self.strSearch = MapStrVersions[version]\n+ self._daysStr = convertVariableName(self.strSearch['days'])\n+ self._buStr = convertVariableName(self.strSearch['bu'])\n+ self._buIdxStr = convertVariableName(self.strSearch['buIdx'])\n+ if rc['serpentVersion'] not in version:\n+ warning('The user version {} is not matching the results'\n+ ' file version {}'.format(rc['serpentVersion'], version))\n+ else:\n+ raise SerpentToolsException(\n+ 'This version {} is not supported'.format(version)\n+ )\n+\n+ def _stripRedundantChar(self, tlineOld, stripChars):\n+ \"\"\"Removes redundant characters (e.g. []=) from the string\"\"\"\n+ tline = tlineOld\n+ for item in stripChars:\n+ tline = tline.replace(item, '')\n+ return tline\n+\n+ def _str2num(self, string):\n+ \"\"\"Converts a string of numbers to an array of numbers \"\"\"\n+ numbers = [float(item) for item in string.split() if self._is_float(item)]\n+ return numbers\n+\n+ def _is_float(self, string):\n+ \"\"\"Checks whether the string can be converted to float\"\"\"\n+ try:\n+ num = float(string)\n+ except ValueError:\n+ return False\n+ return True\n+\n+ def _ReplaceNaN(self, tlineOld):\n+ \"\"\"Checks if there are NaNs or Inf and replace with zeros\"\"\"","path":"serpentTools/parsers/results.py","position":310,"original_position":310,"commit_id":"6d57d7a0e98f92e4373e992c7073560a840bd676","original_commit_id":"6d57d7a0e98f92e4373e992c7073560a840bd676","user":{"login":"drewejohnson","id":19477741,"avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"body":"This should be a static method","created_at":"2018-02-28T02:30:38Z","updated_at":"2018-02-28T02:45:58Z","html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91#discussion_r171128843","pull_request_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments/171128843"},"html":{"href":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91#discussion_r171128843"},"pull_request":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91","id":171259770,"html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91","diff_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91.diff","patch_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91.patch","issue_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/91","number":91,"state":"open","locked":false,"title":"Read results","user":{"login":"CORE-GATECH","id":26622847,"avatar_url":"https://avatars1.githubusercontent.com/u/26622847?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH","html_url":"https://github.com/CORE-GATECH","followers_url":"https://api.github.com/users/CORE-GATECH/followers","following_url":"https://api.github.com/users/CORE-GATECH/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH/orgs","repos_url":"https://api.github.com/users/CORE-GATECH/repos","events_url":"https://api.github.com/users/CORE-GATECH/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH/received_events","type":"User","site_admin":false},"body":"Title: ResultsReader parser\r\n\r\nBody: Results reader is capable to read and store the data. In addition, basic 1-D plotting capability was added. Example is also available in the 'ResultsReader.ipynb'. The test_result is not yet finalized. \r\nresolves or addresses::\r\n\r\n\r\nRead, process and plot capability is available. \r\nTesting must be included. \r\n","created_at":"2018-02-25T23:57:57Z","updated_at":"2018-02-28T02:45:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e4c78dc72cb958cfe32b0c0d3f1fb081f67a976","assignee":{"login":"drewejohnson","id":19477741,"avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"assignees":[{"login":"drewejohnson","id":19477741,"avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":704366608,"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels/reader","name":"reader","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/milestones/4","html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools/milestone/4","labels_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/milestones/4/labels","id":3067183,"number":4,"title":"1.0","description":"","creator":{"login":"drewejohnson","id":19477741,"avatar_url":"https://avatars0.githubusercontent.com/u/19477741?v=4","gravatar_id":"","url":"https://api.github.com/users/drewejohnson","html_url":"https://github.com/drewejohnson","followers_url":"https://api.github.com/users/drewejohnson/followers","following_url":"https://api.github.com/users/drewejohnson/following{/other_user}","gists_url":"https://api.github.com/users/drewejohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/drewejohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewejohnson/subscriptions","organizations_url":"https://api.github.com/users/drewejohnson/orgs","repos_url":"https://api.github.com/users/drewejohnson/repos","events_url":"https://api.github.com/users/drewejohnson/events{/privacy}","received_events_url":"https://api.github.com/users/drewejohnson/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":13,"state":"open","created_at":"2018-01-26T19:18:22Z","updated_at":"2018-02-27T19:48:54Z","due_on":"2018-04-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91/commits","review_comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91/comments","review_comment_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/91/comments","statuses_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/6d57d7a0e98f92e4373e992c7073560a840bd676","head":{"label":"CORE-GATECH-GROUP:Read-Results","ref":"Read-Results","sha":"6d57d7a0e98f92e4373e992c7073560a840bd676","user":{"login":"CORE-GATECH-GROUP","id":26622918,"avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":102786755,"name":"serpent-tools","full_name":"CORE-GATECH-GROUP/serpent-tools","owner":{"login":"CORE-GATECH-GROUP","id":26622918,"avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","description":"A suite of parsers designed to make interacting with SERPENT output files simple and flawless","fork":false,"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools","forks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/forks","keys_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/teams","hooks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/hooks","issue_events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/events{/number}","events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/events","assignees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/assignees{/user}","branches_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/branches{/branch}","tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/tags","blobs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/languages","stargazers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/stargazers","contributors_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contributors","subscribers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscribers","subscription_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscription","commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contents/{+path}","compare_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/merges","archive_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/downloads","issues_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues{/number}","pulls_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels{/name}","releases_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/releases{/id}","deployments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/deployments","created_at":"2017-09-07T21:19:39Z","updated_at":"2018-02-02T21:08:01Z","pushed_at":"2018-02-27T19:48:54Z","git_url":"git://github.com/CORE-GATECH-GROUP/serpent-tools.git","ssh_url":"git@github.com:CORE-GATECH-GROUP/serpent-tools.git","clone_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools.git","svn_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","homepage":null,"size":2860,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":12,"watchers":3,"default_branch":"develop"}},"base":{"label":"CORE-GATECH-GROUP:develop","ref":"develop","sha":"22d726e32551da86813cb1f76ba52455531bf7b8","user":{"login":"CORE-GATECH-GROUP","id":26622918,"avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":102786755,"name":"serpent-tools","full_name":"CORE-GATECH-GROUP/serpent-tools","owner":{"login":"CORE-GATECH-GROUP","id":26622918,"avatar_url":"https://avatars3.githubusercontent.com/u/26622918?v=4","gravatar_id":"","url":"https://api.github.com/users/CORE-GATECH-GROUP","html_url":"https://github.com/CORE-GATECH-GROUP","followers_url":"https://api.github.com/users/CORE-GATECH-GROUP/followers","following_url":"https://api.github.com/users/CORE-GATECH-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/CORE-GATECH-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/CORE-GATECH-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CORE-GATECH-GROUP/subscriptions","organizations_url":"https://api.github.com/users/CORE-GATECH-GROUP/orgs","repos_url":"https://api.github.com/users/CORE-GATECH-GROUP/repos","events_url":"https://api.github.com/users/CORE-GATECH-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/CORE-GATECH-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","description":"A suite of parsers designed to make interacting with SERPENT output files simple and flawless","fork":false,"url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools","forks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/forks","keys_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/teams","hooks_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/hooks","issue_events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/events{/number}","events_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/events","assignees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/assignees{/user}","branches_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/branches{/branch}","tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/tags","blobs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/languages","stargazers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/stargazers","contributors_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contributors","subscribers_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscribers","subscription_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/subscription","commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/contents/{+path}","compare_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/merges","archive_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/downloads","issues_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues{/number}","pulls_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/labels{/name}","releases_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/releases{/id}","deployments_url":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/deployments","created_at":"2017-09-07T21:19:39Z","updated_at":"2018-02-02T21:08:01Z","pushed_at":"2018-02-27T19:48:54Z","git_url":"git://github.com/CORE-GATECH-GROUP/serpent-tools.git","ssh_url":"git@github.com:CORE-GATECH-GROUP/serpent-tools.git","clone_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools.git","svn_url":"https://github.com/CORE-GATECH-GROUP/serpent-tools","homepage":null,"size":2860,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":12,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91"},"html":{"href":"https://github.com/CORE-GATECH-GROUP/serpent-tools/pull/91"},"issue":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/91"},"comments":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools/statuses/6d57d7a0e98f92e4373e992c7073560a840bd676"}},"author_association":"CONTRIBUTOR"}} | {
"id": 102786755,
"name": "CORE-GATECH-GROUP/serpent-tools",
"url": "https://api.github.com/repos/CORE-GATECH-GROUP/serpent-tools"
} | {
"id": 19477741,
"login": "drewejohnson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19477741?",
"url": "https://api.github.com/users/drewejohnson"
} | {
"id": 26622918,
"login": "CORE-GATECH-GROUP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26622918?",
"url": "https://api.github.com/orgs/CORE-GATECH-GROUP"
} | 2018-02-28T02:30:38 | 7307436674 | {"actor":{"display_login":"drewejohnson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/castorini/Anserini/pulls/comments/217704837","pull_request_review_id":155484701,"id":217704837,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcwNDgzNw==","diff_hunk":"@@ -0,0 +1,258 @@\n+\"\"\"\n+Anserini: An information retrieval toolkit built on Lucene\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+\"\"\"\n+\n+class _ParaSegmenter(object):","path":"src/main/python/paragraph_indexing/paraseg.py","position":17,"original_position":17,"commit_id":"2353ba05ba8920c15148aa124ec5d39127f1218e","original_commit_id":"2353ba05ba8920c15148aa124ec5d39127f1218e","user":{"login":"Kytabyte","id":12863988,"node_id":"MDQ6VXNlcjEyODYzOTg4","avatar_url":"https://avatars0.githubusercontent.com/u/12863988?v=4","gravatar_id":"","url":"https://api.github.com/users/Kytabyte","html_url":"https://github.com/Kytabyte","followers_url":"https://api.github.com/users/Kytabyte/followers","following_url":"https://api.github.com/users/Kytabyte/following{/other_user}","gists_url":"https://api.github.com/users/Kytabyte/gists{/gist_id}","starred_url":"https://api.github.com/users/Kytabyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kytabyte/subscriptions","organizations_url":"https://api.github.com/users/Kytabyte/orgs","repos_url":"https://api.github.com/users/Kytabyte/repos","events_url":"https://api.github.com/users/Kytabyte/events{/privacy}","received_events_url":"https://api.github.com/users/Kytabyte/received_events","type":"User","site_admin":false},"body":"Sure. Will refactor it.","created_at":"2018-09-14T13:03:31Z","updated_at":"2018-09-14T13:03:32Z","html_url":"https://github.com/castorini/Anserini/pull/430#discussion_r217704837","pull_request_url":"https://api.github.com/repos/castorini/Anserini/pulls/430","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/comments/217704837"},"html":{"href":"https://github.com/castorini/Anserini/pull/430#discussion_r217704837"},"pull_request":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/430"}},"in_reply_to_id":217543811},"pull_request":{"url":"https://api.github.com/repos/castorini/Anserini/pulls/430","id":215041732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDQxNzMy","html_url":"https://github.com/castorini/Anserini/pull/430","diff_url":"https://github.com/castorini/Anserini/pull/430.diff","patch_url":"https://github.com/castorini/Anserini/pull/430.patch","issue_url":"https://api.github.com/repos/castorini/Anserini/issues/430","number":430,"state":"open","locked":false,"title":"#358 paragraph segmentation scripts for Robust04 and Core17 collection in Python","user":{"login":"Kytabyte","id":12863988,"node_id":"MDQ6VXNlcjEyODYzOTg4","avatar_url":"https://avatars0.githubusercontent.com/u/12863988?v=4","gravatar_id":"","url":"https://api.github.com/users/Kytabyte","html_url":"https://github.com/Kytabyte","followers_url":"https://api.github.com/users/Kytabyte/followers","following_url":"https://api.github.com/users/Kytabyte/following{/other_user}","gists_url":"https://api.github.com/users/Kytabyte/gists{/gist_id}","starred_url":"https://api.github.com/users/Kytabyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kytabyte/subscriptions","organizations_url":"https://api.github.com/users/Kytabyte/orgs","repos_url":"https://api.github.com/users/Kytabyte/repos","events_url":"https://api.github.com/users/Kytabyte/events{/privacy}","received_events_url":"https://api.github.com/users/Kytabyte/received_events","type":"User","site_admin":false},"body":"These codes provides paragraph segmentation on Robust04 and Core17 collections, by reading the raw documents stored in the document-level indexing files. Each document will be segmented into paragraphs and dumped in `json` format which meets the input format of [`JsonCollection`](https://github.com/Kytabyte/Anserini/blob/master/src/main/java/io/anserini/collection/JsonCollection.java). As such, one is able to build paragraph-level indexing afterwards. \r\n\r\nI designed a base class for all paragraph segmenter called `_ParaSegmenter` in `paraseg.py` and all concrete segmenters extends this base class.\r\n\r\nThe base class defines four basic functionalities that a segmenter should have:\r\n1. how to identify the start of the main body (`_setup`)\r\n2. how to identify the start of *a* paragraph (`hasnextpara`)\r\n3. how to identify the end of a paragraph (`_isend`)\r\n4. return the next paragraph (`nextpara`)\r\n\r\nFor different collections, the strategies may vary. \r\n\r\nFor some collections, they are very easy to detect. for instance, NYT just split paragraphs by `\\n`, with no else indicators; for LA collections in Robust04, every paragraph is wrapped around by `<P></P>`, a and each paragraph is a single line.\r\n\r\nHowever, some collections are not that easy to do paragraph separation. For FT collections in Robust04, a document starts by a `<TEXT>` line. However, due to the technical issues in formatting and printing at that time, instead of one-line-one-paragraph, each paragraph is manually cut by several newlines, and the separator between paragraphs is `\\n` as well. This makes the paragraphs cannot generally be segmented by a deterministic rule. For instance, the content of a raw document may look like this:\r\n\r\n```\r\n<TEXT>\r\nb'He said those points will have a bearing on the future of\\n'\r\nb'Mexico and noted the EZLN is not prepared to lay down its\\n'\r\nb'weapons, since it is certain that the pacification process in\\n'\r\nb'Chiapas is not simple. The signing of a peace accord, he added,\\n'\r\nb'will not be fast or easy to attain, and many days will pass in\\n'\r\nb'order to obtain satisfactory responses to the proposals by the\\n'\r\nb'EZLN General Command.\\n'\r\nb'During a private meeting with foreign correspondents, the\\n'\r\nb'subcommander felt all the demands on the list submitted to\\n'\r\nb'Manuel Camacho Solis, commissioner for peace and reconciliation\\n'\r\nb'in Chiapas, can be resolved by the federal authorities with a\\n'\r\nb'total commitment and interest in improving the conditions in\\n'\r\nb\"which Mexico's Indians live.\\n\"\r\n</TEXT>\r\n```\r\n\r\nWithout reading the content, we can \"guess\" that the line `EZLN General Command` and `which Mexico's Indians live` may be the end of paragraphs because they are shorter than other lines. This is not always reliable but this is the only way to separate them. So for this collection, we have to 1) determine where the main body started and where a new paragraph started separately and 2) use an empirical length of a line to determine if this is the end of a paragraph.\r\n\r\nGenerally, this is quick-and-dirty idea to build the document-level indexing, dump the raw docs, apply the paragraph segmentation, and build the paragraph-level indexing again. However, I think this process may be moved to inside the file segment part during index collection smoothly, except the fact that the document cleaning process will apparently be more delicately treated than what we currently do, as we have to detect paragraphs on the original document instead of the dumped `raw doc` which has already been processed.\r\n\r\n","created_at":"2018-09-12T17:38:13Z","updated_at":"2018-09-14T13:03:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c4b1dd86125a2cdffe379352eef7d71c3508500","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/castorini/Anserini/pulls/430/commits","review_comments_url":"https://api.github.com/repos/castorini/Anserini/pulls/430/comments","review_comment_url":"https://api.github.com/repos/castorini/Anserini/pulls/comments{/number}","comments_url":"https://api.github.com/repos/castorini/Anserini/issues/430/comments","statuses_url":"https://api.github.com/repos/castorini/Anserini/statuses/2353ba05ba8920c15148aa124ec5d39127f1218e","head":{"label":"Kytabyte:master","ref":"master","sha":"2353ba05ba8920c15148aa124ec5d39127f1218e","user":{"login":"Kytabyte","id":12863988,"node_id":"MDQ6VXNlcjEyODYzOTg4","avatar_url":"https://avatars0.githubusercontent.com/u/12863988?v=4","gravatar_id":"","url":"https://api.github.com/users/Kytabyte","html_url":"https://github.com/Kytabyte","followers_url":"https://api.github.com/users/Kytabyte/followers","following_url":"https://api.github.com/users/Kytabyte/following{/other_user}","gists_url":"https://api.github.com/users/Kytabyte/gists{/gist_id}","starred_url":"https://api.github.com/users/Kytabyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kytabyte/subscriptions","organizations_url":"https://api.github.com/users/Kytabyte/orgs","repos_url":"https://api.github.com/users/Kytabyte/repos","events_url":"https://api.github.com/users/Kytabyte/events{/privacy}","received_events_url":"https://api.github.com/users/Kytabyte/received_events","type":"User","site_admin":false},"repo":{"id":135200989,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyMDA5ODk=","name":"Anserini","full_name":"Kytabyte/Anserini","owner":{"login":"Kytabyte","id":12863988,"node_id":"MDQ6VXNlcjEyODYzOTg4","avatar_url":"https://avatars0.githubusercontent.com/u/12863988?v=4","gravatar_id":"","url":"https://api.github.com/users/Kytabyte","html_url":"https://github.com/Kytabyte","followers_url":"https://api.github.com/users/Kytabyte/followers","following_url":"https://api.github.com/users/Kytabyte/following{/other_user}","gists_url":"https://api.github.com/users/Kytabyte/gists{/gist_id}","starred_url":"https://api.github.com/users/Kytabyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kytabyte/subscriptions","organizations_url":"https://api.github.com/users/Kytabyte/orgs","repos_url":"https://api.github.com/users/Kytabyte/repos","events_url":"https://api.github.com/users/Kytabyte/events{/privacy}","received_events_url":"https://api.github.com/users/Kytabyte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kytabyte/Anserini","description":"An information retrieval toolkit built on Lucene","fork":true,"url":"https://api.github.com/repos/Kytabyte/Anserini","forks_url":"https://api.github.com/repos/Kytabyte/Anserini/forks","keys_url":"https://api.github.com/repos/Kytabyte/Anserini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kytabyte/Anserini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kytabyte/Anserini/teams","hooks_url":"https://api.github.com/repos/Kytabyte/Anserini/hooks","issue_events_url":"https://api.github.com/repos/Kytabyte/Anserini/issues/events{/number}","events_url":"https://api.github.com/repos/Kytabyte/Anserini/events","assignees_url":"https://api.github.com/repos/Kytabyte/Anserini/assignees{/user}","branches_url":"https://api.github.com/repos/Kytabyte/Anserini/branches{/branch}","tags_url":"https://api.github.com/repos/Kytabyte/Anserini/tags","blobs_url":"https://api.github.com/repos/Kytabyte/Anserini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kytabyte/Anserini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kytabyte/Anserini/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kytabyte/Anserini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kytabyte/Anserini/statuses/{sha}","languages_url":"https://api.github.com/repos/Kytabyte/Anserini/languages","stargazers_url":"https://api.github.com/repos/Kytabyte/Anserini/stargazers","contributors_url":"https://api.github.com/repos/Kytabyte/Anserini/contributors","subscribers_url":"https://api.github.com/repos/Kytabyte/Anserini/subscribers","subscription_url":"https://api.github.com/repos/Kytabyte/Anserini/subscription","commits_url":"https://api.github.com/repos/Kytabyte/Anserini/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kytabyte/Anserini/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kytabyte/Anserini/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kytabyte/Anserini/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kytabyte/Anserini/contents/{+path}","compare_url":"https://api.github.com/repos/Kytabyte/Anserini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kytabyte/Anserini/merges","archive_url":"https://api.github.com/repos/Kytabyte/Anserini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kytabyte/Anserini/downloads","issues_url":"https://api.github.com/repos/Kytabyte/Anserini/issues{/number}","pulls_url":"https://api.github.com/repos/Kytabyte/Anserini/pulls{/number}","milestones_url":"https://api.github.com/repos/Kytabyte/Anserini/milestones{/number}","notifications_url":"https://api.github.com/repos/Kytabyte/Anserini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kytabyte/Anserini/labels{/name}","releases_url":"https://api.github.com/repos/Kytabyte/Anserini/releases{/id}","deployments_url":"https://api.github.com/repos/Kytabyte/Anserini/deployments","created_at":"2018-05-28T19:25:23Z","updated_at":"2018-09-12T17:27:10Z","pushed_at":"2018-09-12T17:27:09Z","git_url":"git://github.com/Kytabyte/Anserini.git","ssh_url":"git@github.com:Kytabyte/Anserini.git","clone_url":"https://github.com/Kytabyte/Anserini.git","svn_url":"https://github.com/Kytabyte/Anserini","homepage":"http://anserini.io/","size":9991,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"castorini:master","ref":"master","sha":"e26bcbfcfe35913663d039078f736631b54decf6","user":{"login":"castorini","id":26842848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/26842848?v=4","gravatar_id":"","url":"https://api.github.com/users/castorini","html_url":"https://github.com/castorini","followers_url":"https://api.github.com/users/castorini/followers","following_url":"https://api.github.com/users/castorini/following{/other_user}","gists_url":"https://api.github.com/users/castorini/gists{/gist_id}","starred_url":"https://api.github.com/users/castorini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castorini/subscriptions","organizations_url":"https://api.github.com/users/castorini/orgs","repos_url":"https://api.github.com/users/castorini/repos","events_url":"https://api.github.com/users/castorini/events{/privacy}","received_events_url":"https://api.github.com/users/castorini/received_events","type":"Organization","site_admin":false},"repo":{"id":43719677,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcxOTY3Nw==","name":"Anserini","full_name":"castorini/Anserini","owner":{"login":"castorini","id":26842848,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/26842848?v=4","gravatar_id":"","url":"https://api.github.com/users/castorini","html_url":"https://github.com/castorini","followers_url":"https://api.github.com/users/castorini/followers","following_url":"https://api.github.com/users/castorini/following{/other_user}","gists_url":"https://api.github.com/users/castorini/gists{/gist_id}","starred_url":"https://api.github.com/users/castorini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castorini/subscriptions","organizations_url":"https://api.github.com/users/castorini/orgs","repos_url":"https://api.github.com/users/castorini/repos","events_url":"https://api.github.com/users/castorini/events{/privacy}","received_events_url":"https://api.github.com/users/castorini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/castorini/Anserini","description":"An information retrieval toolkit built on Lucene","fork":false,"url":"https://api.github.com/repos/castorini/Anserini","forks_url":"https://api.github.com/repos/castorini/Anserini/forks","keys_url":"https://api.github.com/repos/castorini/Anserini/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castorini/Anserini/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castorini/Anserini/teams","hooks_url":"https://api.github.com/repos/castorini/Anserini/hooks","issue_events_url":"https://api.github.com/repos/castorini/Anserini/issues/events{/number}","events_url":"https://api.github.com/repos/castorini/Anserini/events","assignees_url":"https://api.github.com/repos/castorini/Anserini/assignees{/user}","branches_url":"https://api.github.com/repos/castorini/Anserini/branches{/branch}","tags_url":"https://api.github.com/repos/castorini/Anserini/tags","blobs_url":"https://api.github.com/repos/castorini/Anserini/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castorini/Anserini/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castorini/Anserini/git/refs{/sha}","trees_url":"https://api.github.com/repos/castorini/Anserini/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castorini/Anserini/statuses/{sha}","languages_url":"https://api.github.com/repos/castorini/Anserini/languages","stargazers_url":"https://api.github.com/repos/castorini/Anserini/stargazers","contributors_url":"https://api.github.com/repos/castorini/Anserini/contributors","subscribers_url":"https://api.github.com/repos/castorini/Anserini/subscribers","subscription_url":"https://api.github.com/repos/castorini/Anserini/subscription","commits_url":"https://api.github.com/repos/castorini/Anserini/commits{/sha}","git_commits_url":"https://api.github.com/repos/castorini/Anserini/git/commits{/sha}","comments_url":"https://api.github.com/repos/castorini/Anserini/comments{/number}","issue_comment_url":"https://api.github.com/repos/castorini/Anserini/issues/comments{/number}","contents_url":"https://api.github.com/repos/castorini/Anserini/contents/{+path}","compare_url":"https://api.github.com/repos/castorini/Anserini/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castorini/Anserini/merges","archive_url":"https://api.github.com/repos/castorini/Anserini/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castorini/Anserini/downloads","issues_url":"https://api.github.com/repos/castorini/Anserini/issues{/number}","pulls_url":"https://api.github.com/repos/castorini/Anserini/pulls{/number}","milestones_url":"https://api.github.com/repos/castorini/Anserini/milestones{/number}","notifications_url":"https://api.github.com/repos/castorini/Anserini/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castorini/Anserini/labels{/name}","releases_url":"https://api.github.com/repos/castorini/Anserini/releases{/id}","deployments_url":"https://api.github.com/repos/castorini/Anserini/deployments","created_at":"2015-10-05T23:27:54Z","updated_at":"2018-09-10T22:47:04Z","pushed_at":"2018-09-12T17:38:14Z","git_url":"git://github.com/castorini/Anserini.git","ssh_url":"git@github.com:castorini/Anserini.git","clone_url":"https://github.com/castorini/Anserini.git","svn_url":"https://github.com/castorini/Anserini","homepage":"http://anserini.io/","size":10036,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":45,"open_issues":35,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/430"},"html":{"href":"https://github.com/castorini/Anserini/pull/430"},"issue":{"href":"https://api.github.com/repos/castorini/Anserini/issues/430"},"comments":{"href":"https://api.github.com/repos/castorini/Anserini/issues/430/comments"},"review_comments":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/430/comments"},"review_comment":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/castorini/Anserini/pulls/430/commits"},"statuses":{"href":"https://api.github.com/repos/castorini/Anserini/statuses/2353ba05ba8920c15148aa124ec5d39127f1218e"}},"author_association":"MEMBER"}} | {
"id": 43719677,
"name": "castorini/Anserini",
"url": "https://api.github.com/repos/castorini/Anserini"
} | {
"id": 12863988,
"login": "Kytabyte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12863988?",
"url": "https://api.github.com/users/Kytabyte"
} | {
"id": 26842848,
"login": "castorini",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26842848?",
"url": "https://api.github.com/orgs/castorini"
} | 2018-09-14T13:03:31 | 8265971781 | {"actor":{"display_login":"Kytabyte"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/comments/181761284","pull_request_review_id":112450854,"id":181761284,"diff_hunk":"@@ -2,7 +2,26 @@ import React, { Component } from 'react';\n import PropTypes from 'prop-types';\n import { Tabs, Tab } from 'material-ui/Tabs';\n \n-const divStyle = { padding: '0 1em 1em 1em' };\n+\n+/**\n+ *\n+ styles: {\n+ tabs: {\n+ Style for container for the tabs\n+ },\n+ inkBar: {\n+ Style for showing when a tab is active\n+ },\n+ activeButton: {\n+ Style for Tab active","path":"src/mui/detail/TabbedShowLayout.js","position":16,"original_position":16,"commit_id":"7e2288a7b1807fac6613f8f98987ccc7806db999","original_commit_id":"7e2288a7b1807fac6613f8f98987ccc7806db999","user":{"login":"thomas-cleany","id":29975433,"avatar_url":"https://avatars0.githubusercontent.com/u/29975433?v=4","gravatar_id":"","url":"https://api.github.com/users/thomas-cleany","html_url":"https://github.com/thomas-cleany","followers_url":"https://api.github.com/users/thomas-cleany/followers","following_url":"https://api.github.com/users/thomas-cleany/following{/other_user}","gists_url":"https://api.github.com/users/thomas-cleany/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-cleany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-cleany/subscriptions","organizations_url":"https://api.github.com/users/thomas-cleany/orgs","repos_url":"https://api.github.com/users/thomas-cleany/repos","events_url":"https://api.github.com/users/thomas-cleany/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-cleany/received_events","type":"User","site_admin":false},"body":"style for active Tab","created_at":"2018-04-16T14:49:58Z","updated_at":"2018-04-16T14:50:51Z","html_url":"https://github.com/cleany/admin-on-rest/pull/51#discussion_r181761284","pull_request_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/comments/181761284"},"html":{"href":"https://github.com/cleany/admin-on-rest/pull/51#discussion_r181761284"},"pull_request":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51","id":180923813,"html_url":"https://github.com/cleany/admin-on-rest/pull/51","diff_url":"https://github.com/cleany/admin-on-rest/pull/51.diff","patch_url":"https://github.com/cleany/admin-on-rest/pull/51.patch","issue_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/51","number":51,"state":"open","locked":false,"title":"mui: update layout for tabs, simple list, simple show","user":{"login":"killui","id":2854770,"avatar_url":"https://avatars1.githubusercontent.com/u/2854770?v=4","gravatar_id":"","url":"https://api.github.com/users/killui","html_url":"https://github.com/killui","followers_url":"https://api.github.com/users/killui/followers","following_url":"https://api.github.com/users/killui/following{/other_user}","gists_url":"https://api.github.com/users/killui/gists{/gist_id}","starred_url":"https://api.github.com/users/killui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killui/subscriptions","organizations_url":"https://api.github.com/users/killui/orgs","repos_url":"https://api.github.com/users/killui/repos","events_url":"https://api.github.com/users/killui/events{/privacy}","received_events_url":"https://api.github.com/users/killui/received_events","type":"User","site_admin":false},"body":"Review a partir de second commit","created_at":"2018-04-11T14:31:09Z","updated_at":"2018-04-16T14:50:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a22439da570b2287b068efd83ddab15f19361356","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51/commits","review_comments_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51/comments","review_comment_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/51/comments","statuses_url":"https://api.github.com/repos/cleany/admin-on-rest/statuses/7e2288a7b1807fac6613f8f98987ccc7806db999","head":{"label":"cleany:integrationDesign-2","ref":"integrationDesign-2","sha":"7e2288a7b1807fac6613f8f98987ccc7806db999","user":{"login":"cleany","id":26871548,"avatar_url":"https://avatars3.githubusercontent.com/u/26871548?v=4","gravatar_id":"","url":"https://api.github.com/users/cleany","html_url":"https://github.com/cleany","followers_url":"https://api.github.com/users/cleany/followers","following_url":"https://api.github.com/users/cleany/following{/other_user}","gists_url":"https://api.github.com/users/cleany/gists{/gist_id}","starred_url":"https://api.github.com/users/cleany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleany/subscriptions","organizations_url":"https://api.github.com/users/cleany/orgs","repos_url":"https://api.github.com/users/cleany/repos","events_url":"https://api.github.com/users/cleany/events{/privacy}","received_events_url":"https://api.github.com/users/cleany/received_events","type":"Organization","site_admin":false},"repo":{"id":94206221,"name":"admin-on-rest","full_name":"cleany/admin-on-rest","owner":{"login":"cleany","id":26871548,"avatar_url":"https://avatars3.githubusercontent.com/u/26871548?v=4","gravatar_id":"","url":"https://api.github.com/users/cleany","html_url":"https://github.com/cleany","followers_url":"https://api.github.com/users/cleany/followers","following_url":"https://api.github.com/users/cleany/following{/other_user}","gists_url":"https://api.github.com/users/cleany/gists{/gist_id}","starred_url":"https://api.github.com/users/cleany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleany/subscriptions","organizations_url":"https://api.github.com/users/cleany/orgs","repos_url":"https://api.github.com/users/cleany/repos","events_url":"https://api.github.com/users/cleany/events{/privacy}","received_events_url":"https://api.github.com/users/cleany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cleany/admin-on-rest","description":"A frontend framework for building admin SPAs on top of REST services, using React and Material Design","fork":true,"url":"https://api.github.com/repos/cleany/admin-on-rest","forks_url":"https://api.github.com/repos/cleany/admin-on-rest/forks","keys_url":"https://api.github.com/repos/cleany/admin-on-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleany/admin-on-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleany/admin-on-rest/teams","hooks_url":"https://api.github.com/repos/cleany/admin-on-rest/hooks","issue_events_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/events{/number}","events_url":"https://api.github.com/repos/cleany/admin-on-rest/events","assignees_url":"https://api.github.com/repos/cleany/admin-on-rest/assignees{/user}","branches_url":"https://api.github.com/repos/cleany/admin-on-rest/branches{/branch}","tags_url":"https://api.github.com/repos/cleany/admin-on-rest/tags","blobs_url":"https://api.github.com/repos/cleany/admin-on-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleany/admin-on-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleany/admin-on-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleany/admin-on-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleany/admin-on-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/cleany/admin-on-rest/languages","stargazers_url":"https://api.github.com/repos/cleany/admin-on-rest/stargazers","contributors_url":"https://api.github.com/repos/cleany/admin-on-rest/contributors","subscribers_url":"https://api.github.com/repos/cleany/admin-on-rest/subscribers","subscription_url":"https://api.github.com/repos/cleany/admin-on-rest/subscription","commits_url":"https://api.github.com/repos/cleany/admin-on-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleany/admin-on-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleany/admin-on-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleany/admin-on-rest/contents/{+path}","compare_url":"https://api.github.com/repos/cleany/admin-on-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleany/admin-on-rest/merges","archive_url":"https://api.github.com/repos/cleany/admin-on-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleany/admin-on-rest/downloads","issues_url":"https://api.github.com/repos/cleany/admin-on-rest/issues{/number}","pulls_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/cleany/admin-on-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/cleany/admin-on-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleany/admin-on-rest/labels{/name}","releases_url":"https://api.github.com/repos/cleany/admin-on-rest/releases{/id}","deployments_url":"https://api.github.com/repos/cleany/admin-on-rest/deployments","created_at":"2017-06-13T11:35:53Z","updated_at":"2017-11-22T21:22:46Z","pushed_at":"2018-04-13T09:40:49Z","git_url":"git://github.com/cleany/admin-on-rest.git","ssh_url":"git@github.com:cleany/admin-on-rest.git","clone_url":"https://github.com/cleany/admin-on-rest.git","svn_url":"https://github.com/cleany/admin-on-rest","homepage":"http://marmelab.com/admin-on-rest","size":10858,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"cleany:local","ref":"local","sha":"69adace22746d40263e28d56a4bdc3cc41aca3c0","user":{"login":"cleany","id":26871548,"avatar_url":"https://avatars3.githubusercontent.com/u/26871548?v=4","gravatar_id":"","url":"https://api.github.com/users/cleany","html_url":"https://github.com/cleany","followers_url":"https://api.github.com/users/cleany/followers","following_url":"https://api.github.com/users/cleany/following{/other_user}","gists_url":"https://api.github.com/users/cleany/gists{/gist_id}","starred_url":"https://api.github.com/users/cleany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleany/subscriptions","organizations_url":"https://api.github.com/users/cleany/orgs","repos_url":"https://api.github.com/users/cleany/repos","events_url":"https://api.github.com/users/cleany/events{/privacy}","received_events_url":"https://api.github.com/users/cleany/received_events","type":"Organization","site_admin":false},"repo":{"id":94206221,"name":"admin-on-rest","full_name":"cleany/admin-on-rest","owner":{"login":"cleany","id":26871548,"avatar_url":"https://avatars3.githubusercontent.com/u/26871548?v=4","gravatar_id":"","url":"https://api.github.com/users/cleany","html_url":"https://github.com/cleany","followers_url":"https://api.github.com/users/cleany/followers","following_url":"https://api.github.com/users/cleany/following{/other_user}","gists_url":"https://api.github.com/users/cleany/gists{/gist_id}","starred_url":"https://api.github.com/users/cleany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleany/subscriptions","organizations_url":"https://api.github.com/users/cleany/orgs","repos_url":"https://api.github.com/users/cleany/repos","events_url":"https://api.github.com/users/cleany/events{/privacy}","received_events_url":"https://api.github.com/users/cleany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cleany/admin-on-rest","description":"A frontend framework for building admin SPAs on top of REST services, using React and Material Design","fork":true,"url":"https://api.github.com/repos/cleany/admin-on-rest","forks_url":"https://api.github.com/repos/cleany/admin-on-rest/forks","keys_url":"https://api.github.com/repos/cleany/admin-on-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleany/admin-on-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleany/admin-on-rest/teams","hooks_url":"https://api.github.com/repos/cleany/admin-on-rest/hooks","issue_events_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/events{/number}","events_url":"https://api.github.com/repos/cleany/admin-on-rest/events","assignees_url":"https://api.github.com/repos/cleany/admin-on-rest/assignees{/user}","branches_url":"https://api.github.com/repos/cleany/admin-on-rest/branches{/branch}","tags_url":"https://api.github.com/repos/cleany/admin-on-rest/tags","blobs_url":"https://api.github.com/repos/cleany/admin-on-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleany/admin-on-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleany/admin-on-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleany/admin-on-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleany/admin-on-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/cleany/admin-on-rest/languages","stargazers_url":"https://api.github.com/repos/cleany/admin-on-rest/stargazers","contributors_url":"https://api.github.com/repos/cleany/admin-on-rest/contributors","subscribers_url":"https://api.github.com/repos/cleany/admin-on-rest/subscribers","subscription_url":"https://api.github.com/repos/cleany/admin-on-rest/subscription","commits_url":"https://api.github.com/repos/cleany/admin-on-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleany/admin-on-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleany/admin-on-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleany/admin-on-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleany/admin-on-rest/contents/{+path}","compare_url":"https://api.github.com/repos/cleany/admin-on-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleany/admin-on-rest/merges","archive_url":"https://api.github.com/repos/cleany/admin-on-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleany/admin-on-rest/downloads","issues_url":"https://api.github.com/repos/cleany/admin-on-rest/issues{/number}","pulls_url":"https://api.github.com/repos/cleany/admin-on-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/cleany/admin-on-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/cleany/admin-on-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleany/admin-on-rest/labels{/name}","releases_url":"https://api.github.com/repos/cleany/admin-on-rest/releases{/id}","deployments_url":"https://api.github.com/repos/cleany/admin-on-rest/deployments","created_at":"2017-06-13T11:35:53Z","updated_at":"2017-11-22T21:22:46Z","pushed_at":"2018-04-13T09:40:49Z","git_url":"git://github.com/cleany/admin-on-rest.git","ssh_url":"git@github.com:cleany/admin-on-rest.git","clone_url":"https://github.com/cleany/admin-on-rest.git","svn_url":"https://github.com/cleany/admin-on-rest","homepage":"http://marmelab.com/admin-on-rest","size":10858,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51"},"html":{"href":"https://github.com/cleany/admin-on-rest/pull/51"},"issue":{"href":"https://api.github.com/repos/cleany/admin-on-rest/issues/51"},"comments":{"href":"https://api.github.com/repos/cleany/admin-on-rest/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cleany/admin-on-rest/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/cleany/admin-on-rest/statuses/7e2288a7b1807fac6613f8f98987ccc7806db999"}},"author_association":"NONE"}} | {
"id": 94206221,
"name": "cleany/admin-on-rest",
"url": "https://api.github.com/repos/cleany/admin-on-rest"
} | {
"id": 29975433,
"login": "thomas-cleany",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29975433?",
"url": "https://api.github.com/users/thomas-cleany"
} | {
"id": 26871548,
"login": "cleany",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26871548?",
"url": "https://api.github.com/orgs/cleany"
} | 2018-04-16T14:49:58 | 7536645924 | {"actor":{"display_login":"thomas-cleany"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/comments/207168387","pull_request_review_id":142722650,"id":207168387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE2ODM4Nw==","diff_hunk":"@@ -28,7 +28,7 @@ export class BaseView implements View {\n readonly measure: Measure;\n /**\n * A map of stringified tags representing columns labels or tag keys, concept\n- * similar to dimensions on multidimensional modeling, to AggregationData.\n+ * similar to dimensions on multidimensional modeling, to AggregationMetadata.","path":"packages/opencensus-core/src/stats/view.ts","position":null,"original_position":5,"commit_id":"f04554a7764b5e0b9616acb47a04a8118fbccef9","original_commit_id":"10a50ef7cf94d0fe1ce9036aca3b049cec4f2f9f","user":{"login":"eduardoemery","id":37382770,"node_id":"MDQ6VXNlcjM3MzgyNzcw","avatar_url":"https://avatars3.githubusercontent.com/u/37382770?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoemery","html_url":"https://github.com/eduardoemery","followers_url":"https://api.github.com/users/eduardoemery/followers","following_url":"https://api.github.com/users/eduardoemery/following{/other_user}","gists_url":"https://api.github.com/users/eduardoemery/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoemery/subscriptions","organizations_url":"https://api.github.com/users/eduardoemery/orgs","repos_url":"https://api.github.com/users/eduardoemery/repos","events_url":"https://api.github.com/users/eduardoemery/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoemery/received_events","type":"User","site_admin":false},"body":"Thanks, there were a few other occurrences of this mistake, fixed. ","created_at":"2018-08-02T09:55:41Z","updated_at":"2018-08-02T09:55:41Z","html_url":"https://github.com/census-instrumentation/opencensus-node/pull/85#discussion_r207168387","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/comments/207168387"},"html":{"href":"https://github.com/census-instrumentation/opencensus-node/pull/85#discussion_r207168387"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85"}},"in_reply_to_id":207064158},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85","id":204758168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzU4MTY4","html_url":"https://github.com/census-instrumentation/opencensus-node/pull/85","diff_url":"https://github.com/census-instrumentation/opencensus-node/pull/85.diff","patch_url":"https://github.com/census-instrumentation/opencensus-node/pull/85.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/85","number":85,"state":"open","locked":false,"title":"feat: add stats recorder implementation","user":{"login":"eduardoemery","id":37382770,"node_id":"MDQ6VXNlcjM3MzgyNzcw","avatar_url":"https://avatars3.githubusercontent.com/u/37382770?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardoemery","html_url":"https://github.com/eduardoemery","followers_url":"https://api.github.com/users/eduardoemery/followers","following_url":"https://api.github.com/users/eduardoemery/following{/other_user}","gists_url":"https://api.github.com/users/eduardoemery/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoemery/subscriptions","organizations_url":"https://api.github.com/users/eduardoemery/orgs","repos_url":"https://api.github.com/users/eduardoemery/repos","events_url":"https://api.github.com/users/eduardoemery/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoemery/received_events","type":"User","site_admin":false},"body":"- Add the `recorder` implementation\r\n- Adds `recorder` tests\r\n- Refactors code\r\n - removes `bucketsBoundaries`\r\n - changes `bucket.max` to `bucket.highBoundary`\r\n - changes `bucket.min` to `bucket.lowBoundary`","created_at":"2018-07-30T10:20:23Z","updated_at":"2018-08-02T09:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be51f62d2bad7d6e48faebb0a6f501c0eb581afe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":925574611,"node_id":"MDU6TGFiZWw5MjU1NzQ2MTE=","url":"https://api.github.com/repos/census-instrumentation/opencensus-node/labels/cla:%20yes","name":"cla: yes","color":"14a839","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/85/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/statuses/f04554a7764b5e0b9616acb47a04a8118fbccef9","head":{"label":"CESARBR:stats_recorder","ref":"stats_recorder","sha":"f04554a7764b5e0b9616acb47a04a8118fbccef9","user":{"login":"CESARBR","id":7859691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTk2OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7859691?v=4","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"repo":{"id":134257961,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyNTc5NjE=","name":"opencensus-node","full_name":"CESARBR/opencensus-node","owner":{"login":"CESARBR","id":7859691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTk2OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7859691?v=4","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESARBR/opencensus-node","description":null,"fork":true,"url":"https://api.github.com/repos/CESARBR/opencensus-node","forks_url":"https://api.github.com/repos/CESARBR/opencensus-node/forks","keys_url":"https://api.github.com/repos/CESARBR/opencensus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESARBR/opencensus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESARBR/opencensus-node/teams","hooks_url":"https://api.github.com/repos/CESARBR/opencensus-node/hooks","issue_events_url":"https://api.github.com/repos/CESARBR/opencensus-node/issues/events{/number}","events_url":"https://api.github.com/repos/CESARBR/opencensus-node/events","assignees_url":"https://api.github.com/repos/CESARBR/opencensus-node/assignees{/user}","branches_url":"https://api.github.com/repos/CESARBR/opencensus-node/branches{/branch}","tags_url":"https://api.github.com/repos/CESARBR/opencensus-node/tags","blobs_url":"https://api.github.com/repos/CESARBR/opencensus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESARBR/opencensus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESARBR/opencensus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESARBR/opencensus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESARBR/opencensus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/CESARBR/opencensus-node/languages","stargazers_url":"https://api.github.com/repos/CESARBR/opencensus-node/stargazers","contributors_url":"https://api.github.com/repos/CESARBR/opencensus-node/contributors","subscribers_url":"https://api.github.com/repos/CESARBR/opencensus-node/subscribers","subscription_url":"https://api.github.com/repos/CESARBR/opencensus-node/subscription","commits_url":"https://api.github.com/repos/CESARBR/opencensus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESARBR/opencensus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESARBR/opencensus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESARBR/opencensus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESARBR/opencensus-node/contents/{+path}","compare_url":"https://api.github.com/repos/CESARBR/opencensus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESARBR/opencensus-node/merges","archive_url":"https://api.github.com/repos/CESARBR/opencensus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESARBR/opencensus-node/downloads","issues_url":"https://api.github.com/repos/CESARBR/opencensus-node/issues{/number}","pulls_url":"https://api.github.com/repos/CESARBR/opencensus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/CESARBR/opencensus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/CESARBR/opencensus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESARBR/opencensus-node/labels{/name}","releases_url":"https://api.github.com/repos/CESARBR/opencensus-node/releases{/id}","deployments_url":"https://api.github.com/repos/CESARBR/opencensus-node/deployments","created_at":"2018-05-21T11:07:13Z","updated_at":"2018-07-20T18:30:24Z","pushed_at":"2018-08-02T09:54:22Z","git_url":"git://github.com/CESARBR/opencensus-node.git","ssh_url":"git@github.com:CESARBR/opencensus-node.git","clone_url":"https://github.com/CESARBR/opencensus-node.git","svn_url":"https://github.com/CESARBR/opencensus-node","homepage":null,"size":1461,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"64b104b32d79f7f970105905a5c981a93c47c7ea","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":109782875,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3ODI4NzU=","name":"opencensus-node","full_name":"census-instrumentation/opencensus-node","owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-node","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-node","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-node/deployments","created_at":"2017-11-07T03:35:31Z","updated_at":"2018-07-31T20:47:19Z","pushed_at":"2018-08-02T09:54:23Z","git_url":"git://github.com/census-instrumentation/opencensus-node.git","ssh_url":"git@github.com:census-instrumentation/opencensus-node.git","clone_url":"https://github.com/census-instrumentation/opencensus-node.git","svn_url":"https://github.com/census-instrumentation/opencensus-node","homepage":"https://opencensus.io","size":1248,"stargazers_count":54,"watchers_count":54,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":16,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85"},"html":{"href":"https://github.com/census-instrumentation/opencensus-node/pull/85"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/85"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-node/statuses/f04554a7764b5e0b9616acb47a04a8118fbccef9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 109782875,
"name": "census-instrumentation/opencensus-node",
"url": "https://api.github.com/repos/census-instrumentation/opencensus-node"
} | {
"id": 37382770,
"login": "eduardoemery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37382770?",
"url": "https://api.github.com/users/eduardoemery"
} | {
"id": 26944525,
"login": "census-instrumentation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26944525?",
"url": "https://api.github.com/orgs/census-instrumentation"
} | 2018-08-02T09:55:41 | 8055640430 | {"actor":{"display_login":"eduardoemery"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/comments/229825491","pull_request_review_id":170418292,"id":229825491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgyNTQ5MQ==","diff_hunk":"@@ -0,0 +1,167 @@\n+---\n+title: \"Stackdriver (Stats)\"\n+date: 2018-10-26T14:27:35-07:00\n+draft: false\n+class: \"shadowed-image lightbox\"\n+aliases: [/supported-exporters/java/stackdriver]\n+logo: /images/logo_gcp_vertical_rgb.png\n+---\n+\n+- [Introduction](#introduction)\n+- [Creating the exporters](#creating-the-exporters)\n+ - [Import Packages](#creating-the-exporters)\n+ - [Basic Example](#creating-the-exporters)\n+- [Viewing your metrics](#viewing-your-metrics)\n+- [References](#references)\n+\n+## Introduction\n+{{% notice note %}}\n+This guide makes use of Stackdriver for visualizing your data. For assistance setting up Stackdriver, [Click here](/codelabs/stackdriver) for a guided codelab.\n+{{% /notice %}}\n+\n+Stackdriver Monitoring provides visibility into the performance, uptime, and overall health of cloud-powered applications.\n+Stackdriver collects metrics, events, and metadata from Google Cloud Platform, Amazon Web Services, hosted uptime probes, application instrumentation, and a variety of common application components including Cassandra, Nginx, Apache Web Server, Elasticsearch, and many others.\n+\n+Stackdriver ingests that data and generates insights via dashboards, charts, and alerts. Stackdriver alerting helps you collaborate by integrating with Slack, PagerDuty, HipChat, Campfire, and more.\n+\n+OpenCensus Java has support for this exporter available through packages:\n+* Stats [io.opencensus.exporter.stats.stackdriver](https://www.javadoc.io/doc/io.opencensus/opencensus-exporter-stats-stackdriver)\n+\n+## Creating the exporters\n+To create the exporters, you'll need to:\n+\n+* Have a GCP Project ID\n+* Have already enabled [Stackdriver Monitoring](https://cloud.google.com/monitoring/docs/quickstart), if not, please visit the [Code lab](/codelabs/stackdriver)\n+* Use Maven setup your pom.xml file\n+* Create the exporters in code\n+\n+{{% notice warning %}}\n+Stackdriver's minimum stats reporting period must be >= 60 seconds. Find out why at this [official Stackdriver advisory](https://cloud.google.com/monitoring/custom-metrics/creating-metrics#writing-ts)\n+{{% /notice %}}\n+\n+Using OpenCensus for metrics involves three general steps:\n+\n+* Importing the OpenCensus stats and OpenCensus Stackdriver exporter packages.\n+* Initializing the Stackdriver exporter.\n+* Using the OpenCensus API to instrument your code.\n+\n+#### A basic example\n+\n+Following is a minimal program that illustrates these steps. It runs a loop and collects latency measures, and when the loop finishes, it exports the stats to Stackdriver Monitoring and exits:\n+\n+{{<tabs Example Import>}}\n+{{<highlight java>}}\n+package io.opencensus.tutorial.stackdriver;\n+\n+import io.opencensus.exporter.stats.stackdriver.StackdriverStatsExporter;\n+import io.opencensus.stats.Aggregation;\n+import io.opencensus.stats.Aggregation.Distribution;\n+import io.opencensus.stats.BucketBoundaries;\n+import io.opencensus.stats.Measure.MeasureDouble;\n+import io.opencensus.stats.Stats;\n+import io.opencensus.stats.StatsRecorder;\n+import io.opencensus.stats.View;\n+import io.opencensus.stats.View.Name;\n+import io.opencensus.stats.ViewManager;\n+import io.opencensus.tags.TagKey;\n+import java.io.IOException;\n+import java.util.Arrays;\n+import java.util.Collections;\n+\n+/** StackdriverExample is an example of exporting a custom metric from OpenCensus to Stackdriver. */\n+public final class StackdriverExample {\n+\n+ // The task latency in milliseconds.\n+ private static final MeasureDouble LATENCY_MS =\n+ MeasureDouble.create(\"task_latency\", \"The task latency in milliseconds\", \"ms\");\n+\n+ private static final StatsRecorder statsRecorder = Stats.getStatsRecorder();\n+\n+ /** Main launcher for the Stackdriver example. */\n+ public static void main(String... args) throws IOException, InterruptedException {\n+ \n+ // Defining the distribution aggregations\n+ Aggregation latencyDistribution =\n+ Distribution.create(\n+ BucketBoundaries.create(\n+ Arrays.asList(\n+ // Latency in buckets: [>=0ms, >=100ms, >=200ms, >=400ms, >=1s, >=2s, >=4s]\n+ 0.0, 100.0, 200.0, 400.0, 1000.0, 2000.0, 4000.0)));\n+ View view =\n+ View.create(\n+ Name.create(\"task_latency_distribution\"),\n+ \"The distribution of the task latencies\",\n+ LATENCY_MS,\n+ latencyDistribution,\n+ Collections.<TagKey>emptyList());\n+\n+ // Create the view manager\n+ ViewManager vmgr = Stats.getViewManager();\n+\n+ // Then finally register the views\n+ vmgr.registerView(view);\n+\n+ // Enable OpenCensus exporters to export metrics to Stackdriver Monitoring.\n+ // Exporters use Application Default Credentials to authenticate.\n+ // See https://developers.google.com/identity/protocols/application-default-credentials\n+ // for more details.\n+ // The minimum reporting period for Stackdriver is 1 minute.\n+ StackdriverStatsExporter.createAndRegister();\n+\n+ // Record 100 fake latency values between 0 and 5 seconds.\n+ for (int i = 0; i < 100; i++) {\n+ double ms = Math.random() * 5 * 1000;\n+ System.out.println(String.format(\"Latency %d: %f\", i, ms));\n+ statsRecorder.newMeasureMap().put(LATENCY_MS, ms).record();\n+ Thread.sleep(1000);\n+ }\n+ \n+ System.out.println(\"Done recording metrics\");","path":"content/guides/exporters/supported-exporters/Java/stackdriver-stats.md","position":119,"original_position":119,"commit_id":"818e895c35d9398b2f66ca4451a55f6568ea537c","original_commit_id":"818e895c35d9398b2f66ca4451a55f6568ea537c","user":{"login":"songy23","id":10536136,"node_id":"MDQ6VXNlcjEwNTM2MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"body":"You may need to wait for one minute before exiting the main thread. Otherwise there will be values that are not uploaded to Stackdriver. Currently we don't have a `flush` for stats exporters.","created_at":"2018-10-31T18:52:23Z","updated_at":"2018-10-31T18:56:29Z","html_url":"https://github.com/census-instrumentation/opencensus-website/pull/412#discussion_r229825491","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/comments/229825491"},"html":{"href":"https://github.com/census-instrumentation/opencensus-website/pull/412#discussion_r229825491"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412","id":227394589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mzk0NTg5","html_url":"https://github.com/census-instrumentation/opencensus-website/pull/412","diff_url":"https://github.com/census-instrumentation/opencensus-website/pull/412.diff","patch_url":"https://github.com/census-instrumentation/opencensus-website/pull/412.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/412","number":412,"state":"open","locked":false,"title":"Guides/Exporters/Java: Stackdriver Stats and Trace","user":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"body":"Few changes:\r\n1. Separate out SD stats and trace.\r\n2. Added a new basic example for stats (https://github.com/census-instrumentation/opencensus-java/pull/1522).\r\n3. Added screenshots for results.","created_at":"2018-10-31T18:21:26Z","updated_at":"2018-10-31T18:56:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21981f650d188cd98b5fda31777bbcd574382224","assignee":null,"assignees":[],"requested_reviewers":[{"login":"odeke-em","id":4898263,"node_id":"MDQ6VXNlcjQ4OTgyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4898263?v=4","gravatar_id":"","url":"https://api.github.com/users/odeke-em","html_url":"https://github.com/odeke-em","followers_url":"https://api.github.com/users/odeke-em/followers","following_url":"https://api.github.com/users/odeke-em/following{/other_user}","gists_url":"https://api.github.com/users/odeke-em/gists{/gist_id}","starred_url":"https://api.github.com/users/odeke-em/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeke-em/subscriptions","organizations_url":"https://api.github.com/users/odeke-em/orgs","repos_url":"https://api.github.com/users/odeke-em/repos","events_url":"https://api.github.com/users/odeke-em/events{/privacy}","received_events_url":"https://api.github.com/users/odeke-em/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":867838896,"node_id":"MDU6TGFiZWw4Njc4Mzg4OTY=","url":"https://api.github.com/repos/census-instrumentation/opencensus-website/labels/cla:%20yes","name":"cla: yes","color":"ccfcae","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/412/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/statuses/818e895c35d9398b2f66ca4451a55f6568ea537c","head":{"label":"mayurkale22:stackdriver_stats","ref":"stackdriver_stats","sha":"818e895c35d9398b2f66ca4451a55f6568ea537c","user":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"repo":{"id":145482773,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0ODI3NzM=","name":"opencensus-website","full_name":"mayurkale22/opencensus-website","private":false,"owner":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mayurkale22/opencensus-website","description":"opencensus.io website content","fork":true,"url":"https://api.github.com/repos/mayurkale22/opencensus-website","forks_url":"https://api.github.com/repos/mayurkale22/opencensus-website/forks","keys_url":"https://api.github.com/repos/mayurkale22/opencensus-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayurkale22/opencensus-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayurkale22/opencensus-website/teams","hooks_url":"https://api.github.com/repos/mayurkale22/opencensus-website/hooks","issue_events_url":"https://api.github.com/repos/mayurkale22/opencensus-website/issues/events{/number}","events_url":"https://api.github.com/repos/mayurkale22/opencensus-website/events","assignees_url":"https://api.github.com/repos/mayurkale22/opencensus-website/assignees{/user}","branches_url":"https://api.github.com/repos/mayurkale22/opencensus-website/branches{/branch}","tags_url":"https://api.github.com/repos/mayurkale22/opencensus-website/tags","blobs_url":"https://api.github.com/repos/mayurkale22/opencensus-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayurkale22/opencensus-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayurkale22/opencensus-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayurkale22/opencensus-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayurkale22/opencensus-website/statuses/{sha}","languages_url":"https://api.github.com/repos/mayurkale22/opencensus-website/languages","stargazers_url":"https://api.github.com/repos/mayurkale22/opencensus-website/stargazers","contributors_url":"https://api.github.com/repos/mayurkale22/opencensus-website/contributors","subscribers_url":"https://api.github.com/repos/mayurkale22/opencensus-website/subscribers","subscription_url":"https://api.github.com/repos/mayurkale22/opencensus-website/subscription","commits_url":"https://api.github.com/repos/mayurkale22/opencensus-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayurkale22/opencensus-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayurkale22/opencensus-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayurkale22/opencensus-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/mayurkale22/opencensus-website/contents/{+path}","compare_url":"https://api.github.com/repos/mayurkale22/opencensus-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayurkale22/opencensus-website/merges","archive_url":"https://api.github.com/repos/mayurkale22/opencensus-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayurkale22/opencensus-website/downloads","issues_url":"https://api.github.com/repos/mayurkale22/opencensus-website/issues{/number}","pulls_url":"https://api.github.com/repos/mayurkale22/opencensus-website/pulls{/number}","milestones_url":"https://api.github.com/repos/mayurkale22/opencensus-website/milestones{/number}","notifications_url":"https://api.github.com/repos/mayurkale22/opencensus-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayurkale22/opencensus-website/labels{/name}","releases_url":"https://api.github.com/repos/mayurkale22/opencensus-website/releases{/id}","deployments_url":"https://api.github.com/repos/mayurkale22/opencensus-website/deployments","created_at":"2018-08-21T00:00:36Z","updated_at":"2018-10-31T18:10:46Z","pushed_at":"2018-10-31T18:20:58Z","git_url":"git://github.com/mayurkale22/opencensus-website.git","ssh_url":"git@github.com:mayurkale22/opencensus-website.git","clone_url":"https://github.com/mayurkale22/opencensus-website.git","svn_url":"https://github.com/mayurkale22/opencensus-website","homepage":"https://opencensus.io","size":59968,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"f51496451ff6fb9043ba3108524f798d450f4030","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":107703454,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MDM0NTQ=","name":"opencensus-website","full_name":"census-instrumentation/opencensus-website","private":false,"owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/census-instrumentation/opencensus-website","description":"opencensus.io website content","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-website","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-website/deployments","created_at":"2017-10-20T16:51:09Z","updated_at":"2018-10-31T17:52:34Z","pushed_at":"2018-10-31T18:21:27Z","git_url":"git://github.com/census-instrumentation/opencensus-website.git","ssh_url":"git@github.com:census-instrumentation/opencensus-website.git","clone_url":"https://github.com/census-instrumentation/opencensus-website.git","svn_url":"https://github.com/census-instrumentation/opencensus-website","homepage":"https://opencensus.io","size":61060,"stargazers_count":25,"watchers_count":25,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":60,"open_issues":48,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412"},"html":{"href":"https://github.com/census-instrumentation/opencensus-website/pull/412"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/412"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-website/statuses/818e895c35d9398b2f66ca4451a55f6568ea537c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 107703454,
"name": "census-instrumentation/opencensus-website",
"url": "https://api.github.com/repos/census-instrumentation/opencensus-website"
} | {
"id": 10536136,
"login": "songy23",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10536136?",
"url": "https://api.github.com/users/songy23"
} | {
"id": 26944525,
"login": "census-instrumentation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26944525?",
"url": "https://api.github.com/orgs/census-instrumentation"
} | 2018-10-31T18:52:23 | 8514569260 | {"actor":{"display_login":"songy23"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/moby/buildkit/pulls/comments/165253159","pull_request_review_id":93159665,"id":165253159,"diff_hunk":"@@ -0,0 +1,198 @@\n+package pipe\n+\n+import (\n+\t\"context\"\n+\t\"sync\"\n+\t\"sync/atomic\"\n+\n+\t\"github.com/pkg/errors\"\n+)\n+\n+type channel struct {\n+\tOnSendCompletion func()\n+\tmu sync.Mutex\n+\tvalue atomic.Value\n+\tlastValue interface{}\n+}\n+\n+func (c *channel) Send(v interface{}) {\n+\tc.value.Store(v)\n+\tif c.OnSendCompletion != nil {\n+\t\tc.OnSendCompletion()\n+\t}\n+}\n+\n+func (c *channel) Receive() (interface{}, bool) {\n+\tv := c.value.Load()\n+\tif c.lastValue == v {\n+\t\treturn nil, false\n+\t}\n+\tc.lastValue = v\n+\treturn v, true\n+}\n+\n+type Pipe struct {\n+\tSender Sender\n+\tReceiver Receiver\n+\tOnReceiveCompletion func()\n+\tOnSendCompletion func()\n+}\n+\n+type Request struct {\n+\tPayload interface{}\n+\tCanceled bool\n+}\n+\n+type Sender interface {\n+\tRequest() Request\n+\tUpdate(v interface{})\n+\tFinalize(v interface{}, err error)\n+\tStatus() Status\n+}\n+\n+type Receiver interface {\n+\tReceive() bool\n+\tCancel()\n+\tStatus() Status\n+\tRequest() interface{}\n+}\n+\n+type Status struct {\n+\tCanceled bool\n+\tCompleted bool\n+\tErr error\n+\tValue interface{}\n+}\n+\n+func NewWithFunction(f func(context.Context) (interface{}, error)) (*Pipe, func()) {\n+\tp := New(Request{})\n+\n+\tctx, cancel := context.WithCancel(context.TODO())\n+\n+\tp.OnReceiveCompletion = func() {\n+\t\tif req := p.Sender.Request(); req.Canceled {\n+\t\t\tcancel()\n+\t\t}\n+\t}\n+\n+\treturn p, func() {\n+\t\tres, err := f(ctx)\n+\t\tif err != nil {\n+\t\t\tp.Sender.Finalize(nil, err)\n+\t\t\treturn\n+\t\t}\n+\t\tp.Sender.Finalize(res, nil)\n+\t}\n+}\n+\n+func New(req Request) *Pipe {\n+\tcancelCh := &channel{}\n+\troundTripCh := &channel{}\n+\tpw := &sender{\n+\t\treq: req,\n+\t\trecvChannel: cancelCh,\n+\t\tsendChannel: roundTripCh,\n+\t}\n+\tpr := &receiver{\n+\t\treq: req,\n+\t\trecvChannel: roundTripCh,\n+\t\tsendChannel: cancelCh,\n+\t}\n+\n+\tp := &Pipe{\n+\t\tSender: pw,\n+\t\tReceiver: pr,\n+\t}\n+\n+\tcancelCh.OnSendCompletion = func() {\n+\t\tv, ok := cancelCh.Receive()\n+\t\tif ok {\n+\t\t\tpw.setRequest(v.(Request))\n+\t\t}\n+\t\tif p.OnReceiveCompletion != nil {\n+\t\t\tp.OnReceiveCompletion()\n+\t\t}\n+\t}\n+\n+\troundTripCh.OnSendCompletion = func() {\n+\t\tif p.OnSendCompletion != nil {\n+\t\t\tp.OnSendCompletion()\n+\t\t}\n+\t}\n+\n+\treturn p\n+}\n+\n+type sender struct {\n+\tstatus Status\n+\treq Request\n+\trecvChannel *channel\n+\tsendChannel *channel\n+\tmu sync.Mutex\n+}\n+\n+func (pw *sender) Status() Status {\n+\treturn pw.status\n+}\n+\n+func (pw *sender) Request() Request {\n+\tpw.mu.Lock()\n+\tdefer pw.mu.Unlock()\n+\treturn pw.req","path":"solver-next/internal/pipe/pipe.go","position":141,"original_position":141,"commit_id":"bcbb3d6234f13a59d11d4ffaa0323aa0a1186474","original_commit_id":"bcbb3d6234f13a59d11d4ffaa0323aa0a1186474","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"body":"To clarify, the reader/writer methods as a group are single threaded. A reader can be used concurrently with the writer.","created_at":"2018-02-01T03:39:38Z","updated_at":"2018-02-01T03:39:38Z","html_url":"https://github.com/moby/buildkit/pull/268#discussion_r165253159","pull_request_url":"https://api.github.com/repos/moby/buildkit/pulls/268","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/buildkit/pulls/comments/165253159"},"html":{"href":"https://github.com/moby/buildkit/pull/268#discussion_r165253159"},"pull_request":{"href":"https://api.github.com/repos/moby/buildkit/pulls/268"}},"in_reply_to_id":165252668},"pull_request":{"url":"https://api.github.com/repos/moby/buildkit/pulls/268","id":166426516,"html_url":"https://github.com/moby/buildkit/pull/268","diff_url":"https://github.com/moby/buildkit/pull/268.diff","patch_url":"https://github.com/moby/buildkit/pull/268.patch","issue_url":"https://api.github.com/repos/moby/buildkit/issues/268","number":268,"state":"open","locked":false,"title":"solver: new implementation, follow-up #267","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"body":"The previous PR #267 was merged bit soon before I could address all the comments.\r\n\r\nThis has the readability fixes, better names and function/package separation.\r\n\r\nI also added a stateful cond package in here that avoids creating a goroutine for signaling an event. This reduced the overhead of using race detector in tests from 50x to 18x. No significant performance impact without using race detector.\r\n\r\n@AkihiroSuda ","created_at":"2018-02-01T02:10:08Z","updated_at":"2018-02-01T03:39:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc89fd5e62d89cc043fe6741b18ae7d68cb0e9fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/moby/buildkit/pulls/268/commits","review_comments_url":"https://api.github.com/repos/moby/buildkit/pulls/268/comments","review_comment_url":"https://api.github.com/repos/moby/buildkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/buildkit/issues/268/comments","statuses_url":"https://api.github.com/repos/moby/buildkit/statuses/bcbb3d6234f13a59d11d4ffaa0323aa0a1186474","head":{"label":"tonistiigi:solver2-updates","ref":"solver2-updates","sha":"bcbb3d6234f13a59d11d4ffaa0323aa0a1186474","user":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"repo":{"id":95247198,"name":"buildkit","full_name":"tonistiigi/buildkit","owner":{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonistiigi/buildkit","description":null,"fork":true,"url":"https://api.github.com/repos/tonistiigi/buildkit","forks_url":"https://api.github.com/repos/tonistiigi/buildkit/forks","keys_url":"https://api.github.com/repos/tonistiigi/buildkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonistiigi/buildkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonistiigi/buildkit/teams","hooks_url":"https://api.github.com/repos/tonistiigi/buildkit/hooks","issue_events_url":"https://api.github.com/repos/tonistiigi/buildkit/issues/events{/number}","events_url":"https://api.github.com/repos/tonistiigi/buildkit/events","assignees_url":"https://api.github.com/repos/tonistiigi/buildkit/assignees{/user}","branches_url":"https://api.github.com/repos/tonistiigi/buildkit/branches{/branch}","tags_url":"https://api.github.com/repos/tonistiigi/buildkit/tags","blobs_url":"https://api.github.com/repos/tonistiigi/buildkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonistiigi/buildkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonistiigi/buildkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonistiigi/buildkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonistiigi/buildkit/statuses/{sha}","languages_url":"https://api.github.com/repos/tonistiigi/buildkit/languages","stargazers_url":"https://api.github.com/repos/tonistiigi/buildkit/stargazers","contributors_url":"https://api.github.com/repos/tonistiigi/buildkit/contributors","subscribers_url":"https://api.github.com/repos/tonistiigi/buildkit/subscribers","subscription_url":"https://api.github.com/repos/tonistiigi/buildkit/subscription","commits_url":"https://api.github.com/repos/tonistiigi/buildkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonistiigi/buildkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonistiigi/buildkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonistiigi/buildkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonistiigi/buildkit/contents/{+path}","compare_url":"https://api.github.com/repos/tonistiigi/buildkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonistiigi/buildkit/merges","archive_url":"https://api.github.com/repos/tonistiigi/buildkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonistiigi/buildkit/downloads","issues_url":"https://api.github.com/repos/tonistiigi/buildkit/issues{/number}","pulls_url":"https://api.github.com/repos/tonistiigi/buildkit/pulls{/number}","milestones_url":"https://api.github.com/repos/tonistiigi/buildkit/milestones{/number}","notifications_url":"https://api.github.com/repos/tonistiigi/buildkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonistiigi/buildkit/labels{/name}","releases_url":"https://api.github.com/repos/tonistiigi/buildkit/releases{/id}","deployments_url":"https://api.github.com/repos/tonistiigi/buildkit/deployments","created_at":"2017-06-23T18:44:36Z","updated_at":"2017-06-23T18:44:38Z","pushed_at":"2018-02-01T02:44:27Z","git_url":"git://github.com/tonistiigi/buildkit.git","ssh_url":"git@github.com:tonistiigi/buildkit.git","clone_url":"https://github.com/tonistiigi/buildkit.git","svn_url":"https://github.com/tonistiigi/buildkit","homepage":"","size":4854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"9c8fc18511b8796b0d997523d4c5cdbfa5294de3","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":92969352,"name":"buildkit","full_name":"moby/buildkit","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/buildkit","description":"concurrent, cache-efficient, and Dockerfile-agnostic builder toolkit","fork":false,"url":"https://api.github.com/repos/moby/buildkit","forks_url":"https://api.github.com/repos/moby/buildkit/forks","keys_url":"https://api.github.com/repos/moby/buildkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/buildkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/buildkit/teams","hooks_url":"https://api.github.com/repos/moby/buildkit/hooks","issue_events_url":"https://api.github.com/repos/moby/buildkit/issues/events{/number}","events_url":"https://api.github.com/repos/moby/buildkit/events","assignees_url":"https://api.github.com/repos/moby/buildkit/assignees{/user}","branches_url":"https://api.github.com/repos/moby/buildkit/branches{/branch}","tags_url":"https://api.github.com/repos/moby/buildkit/tags","blobs_url":"https://api.github.com/repos/moby/buildkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/buildkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/buildkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/buildkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/buildkit/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/buildkit/languages","stargazers_url":"https://api.github.com/repos/moby/buildkit/stargazers","contributors_url":"https://api.github.com/repos/moby/buildkit/contributors","subscribers_url":"https://api.github.com/repos/moby/buildkit/subscribers","subscription_url":"https://api.github.com/repos/moby/buildkit/subscription","commits_url":"https://api.github.com/repos/moby/buildkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/buildkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/buildkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/buildkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/buildkit/contents/{+path}","compare_url":"https://api.github.com/repos/moby/buildkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/buildkit/merges","archive_url":"https://api.github.com/repos/moby/buildkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/buildkit/downloads","issues_url":"https://api.github.com/repos/moby/buildkit/issues{/number}","pulls_url":"https://api.github.com/repos/moby/buildkit/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/buildkit/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/buildkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/buildkit/labels{/name}","releases_url":"https://api.github.com/repos/moby/buildkit/releases{/id}","deployments_url":"https://api.github.com/repos/moby/buildkit/deployments","created_at":"2017-05-31T17:04:10Z","updated_at":"2018-01-25T23:10:49Z","pushed_at":"2018-02-01T02:44:29Z","git_url":"git://github.com/moby/buildkit.git","ssh_url":"git@github.com:moby/buildkit.git","clone_url":"https://github.com/moby/buildkit.git","svn_url":"https://github.com/moby/buildkit","homepage":"https://github.com/moby/moby/issues/34227","size":4717,"stargazers_count":273,"watchers_count":273,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":33,"open_issues":31,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/buildkit/pulls/268"},"html":{"href":"https://github.com/moby/buildkit/pull/268"},"issue":{"href":"https://api.github.com/repos/moby/buildkit/issues/268"},"comments":{"href":"https://api.github.com/repos/moby/buildkit/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/buildkit/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/buildkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/buildkit/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/moby/buildkit/statuses/bcbb3d6234f13a59d11d4ffaa0323aa0a1186474"}},"author_association":"MEMBER"}} | {
"id": 92969352,
"name": "moby/buildkit",
"url": "https://api.github.com/repos/moby/buildkit"
} | {
"id": 585223,
"login": "tonistiigi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/585223?",
"url": "https://api.github.com/users/tonistiigi"
} | {
"id": 27259197,
"login": "moby",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27259197?",
"url": "https://api.github.com/orgs/moby"
} | 2018-02-01T03:39:38 | 7181237894 | {"actor":{"display_login":"tonistiigi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/flathub/flathub/pulls/comments/176143975","pull_request_review_id":105795894,"id":176143975,"diff_hunk":"@@ -0,0 +1,94 @@\n+{\n+ \"app-id\": \"com.wps.WPS\",\n+ \"branch\": \"stable\",\n+ \"runtime\": \"org.freedesktop.Platform\",\n+ \"runtime-version\": \"1.6\",\n+ \"sdk\": \"org.freedesktop.Sdk\",\n+ \"tags\": [\"proprietary\"], \n+ \"separate-locales\": false,\n+ \"finish-args\": [\n+ \"--share=ipc\", \"--socket=x11\",\n+ \"--socket=pulseaudio\",\n+ \"--share=network\",\n+ \"--device=dri\",\n+ \"--filesystem=host\",\n+ \"--env=WPS_NO_GLOBAL_MENUBAR=1\"\n+ ],\n+ \"command\": \"wps\",\n+ \"modules\": [\n+ {\n+ \"name\": \"libpng12\",","path":"com.wps.WPS.json","position":20,"original_position":20,"commit_id":"35ca552dc02d5353c1f6437f830f461313c38d59","original_commit_id":"35ca552dc02d5353c1f6437f830f461313c38d59","user":{"login":"TingPing","id":798838,"avatar_url":"https://avatars0.githubusercontent.com/u/798838?v=4","gravatar_id":"","url":"https://api.github.com/users/TingPing","html_url":"https://github.com/TingPing","followers_url":"https://api.github.com/users/TingPing/followers","following_url":"https://api.github.com/users/TingPing/following{/other_user}","gists_url":"https://api.github.com/users/TingPing/gists{/gist_id}","starred_url":"https://api.github.com/users/TingPing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TingPing/subscriptions","organizations_url":"https://api.github.com/users/TingPing/orgs","repos_url":"https://api.github.com/users/TingPing/repos","events_url":"https://api.github.com/users/TingPing/events{/privacy}","received_events_url":"https://api.github.com/users/TingPing/received_events","type":"User","site_admin":false},"body":"libpng breaks ABI often, might require an old version.","created_at":"2018-03-21T16:15:59Z","updated_at":"2018-03-21T16:15:59Z","html_url":"https://github.com/flathub/flathub/pull/309#discussion_r176143975","pull_request_url":"https://api.github.com/repos/flathub/flathub/pulls/309","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments/176143975"},"html":{"href":"https://github.com/flathub/flathub/pull/309#discussion_r176143975"},"pull_request":{"href":"https://api.github.com/repos/flathub/flathub/pulls/309"}},"in_reply_to_id":176140574},"pull_request":{"url":"https://api.github.com/repos/flathub/flathub/pulls/309","id":176120981,"html_url":"https://github.com/flathub/flathub/pull/309","diff_url":"https://github.com/flathub/flathub/pull/309.diff","patch_url":"https://github.com/flathub/flathub/pull/309.patch","issue_url":"https://api.github.com/repos/flathub/flathub/issues/309","number":309,"state":"open","locked":false,"title":"Initial WPS flatpak","user":{"login":"cheese","id":303331,"avatar_url":"https://avatars0.githubusercontent.com/u/303331?v=4","gravatar_id":"","url":"https://api.github.com/users/cheese","html_url":"https://github.com/cheese","followers_url":"https://api.github.com/users/cheese/followers","following_url":"https://api.github.com/users/cheese/following{/other_user}","gists_url":"https://api.github.com/users/cheese/gists{/gist_id}","starred_url":"https://api.github.com/users/cheese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheese/subscriptions","organizations_url":"https://api.github.com/users/cheese/orgs","repos_url":"https://api.github.com/users/cheese/repos","events_url":"https://api.github.com/users/cheese/events{/privacy}","received_events_url":"https://api.github.com/users/cheese/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-20T08:45:10Z","updated_at":"2018-03-21T16:15:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74a78320a30fa94f3b7cfa3e867aef5e567ec6bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flathub/flathub/pulls/309/commits","review_comments_url":"https://api.github.com/repos/flathub/flathub/pulls/309/comments","review_comment_url":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flathub/flathub/issues/309/comments","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/35ca552dc02d5353c1f6437f830f461313c38d59","head":{"label":"cheese:wps","ref":"wps","sha":"35ca552dc02d5353c1f6437f830f461313c38d59","user":{"login":"cheese","id":303331,"avatar_url":"https://avatars0.githubusercontent.com/u/303331?v=4","gravatar_id":"","url":"https://api.github.com/users/cheese","html_url":"https://github.com/cheese","followers_url":"https://api.github.com/users/cheese/followers","following_url":"https://api.github.com/users/cheese/following{/other_user}","gists_url":"https://api.github.com/users/cheese/gists{/gist_id}","starred_url":"https://api.github.com/users/cheese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheese/subscriptions","organizations_url":"https://api.github.com/users/cheese/orgs","repos_url":"https://api.github.com/users/cheese/repos","events_url":"https://api.github.com/users/cheese/events{/privacy}","received_events_url":"https://api.github.com/users/cheese/received_events","type":"User","site_admin":false},"repo":{"id":119648398,"name":"flathub","full_name":"cheese/flathub","owner":{"login":"cheese","id":303331,"avatar_url":"https://avatars0.githubusercontent.com/u/303331?v=4","gravatar_id":"","url":"https://api.github.com/users/cheese","html_url":"https://github.com/cheese","followers_url":"https://api.github.com/users/cheese/followers","following_url":"https://api.github.com/users/cheese/following{/other_user}","gists_url":"https://api.github.com/users/cheese/gists{/gist_id}","starred_url":"https://api.github.com/users/cheese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheese/subscriptions","organizations_url":"https://api.github.com/users/cheese/orgs","repos_url":"https://api.github.com/users/cheese/repos","events_url":"https://api.github.com/users/cheese/events{/privacy}","received_events_url":"https://api.github.com/users/cheese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cheese/flathub","description":"Pull requests for new applications to be added","fork":true,"url":"https://api.github.com/repos/cheese/flathub","forks_url":"https://api.github.com/repos/cheese/flathub/forks","keys_url":"https://api.github.com/repos/cheese/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cheese/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cheese/flathub/teams","hooks_url":"https://api.github.com/repos/cheese/flathub/hooks","issue_events_url":"https://api.github.com/repos/cheese/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/cheese/flathub/events","assignees_url":"https://api.github.com/repos/cheese/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/cheese/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/cheese/flathub/tags","blobs_url":"https://api.github.com/repos/cheese/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cheese/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cheese/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/cheese/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cheese/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/cheese/flathub/languages","stargazers_url":"https://api.github.com/repos/cheese/flathub/stargazers","contributors_url":"https://api.github.com/repos/cheese/flathub/contributors","subscribers_url":"https://api.github.com/repos/cheese/flathub/subscribers","subscription_url":"https://api.github.com/repos/cheese/flathub/subscription","commits_url":"https://api.github.com/repos/cheese/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/cheese/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/cheese/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/cheese/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/cheese/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/cheese/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cheese/flathub/merges","archive_url":"https://api.github.com/repos/cheese/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cheese/flathub/downloads","issues_url":"https://api.github.com/repos/cheese/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/cheese/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/cheese/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/cheese/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cheese/flathub/labels{/name}","releases_url":"https://api.github.com/repos/cheese/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/cheese/flathub/deployments","created_at":"2018-01-31T07:03:28Z","updated_at":"2018-01-29T00:21:35Z","pushed_at":"2018-03-21T13:18:40Z","git_url":"git://github.com/cheese/flathub.git","ssh_url":"git@github.com:cheese/flathub.git","clone_url":"https://github.com/cheese/flathub.git","svn_url":"https://github.com/cheese/flathub","homepage":"https://flathub.org","size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flathub:new-pr","ref":"new-pr","sha":"746ea89cc4ff85ad2dbc05fb47efde23de4062f8","user":{"login":"flathub","id":27268838,"avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"repo":{"id":88860262,"name":"flathub","full_name":"flathub/flathub","owner":{"login":"flathub","id":27268838,"avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flathub/flathub","description":"Pull requests for new applications to be added","fork":false,"url":"https://api.github.com/repos/flathub/flathub","forks_url":"https://api.github.com/repos/flathub/flathub/forks","keys_url":"https://api.github.com/repos/flathub/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flathub/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flathub/flathub/teams","hooks_url":"https://api.github.com/repos/flathub/flathub/hooks","issue_events_url":"https://api.github.com/repos/flathub/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/flathub/flathub/events","assignees_url":"https://api.github.com/repos/flathub/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/flathub/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/flathub/flathub/tags","blobs_url":"https://api.github.com/repos/flathub/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flathub/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flathub/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/flathub/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/flathub/flathub/languages","stargazers_url":"https://api.github.com/repos/flathub/flathub/stargazers","contributors_url":"https://api.github.com/repos/flathub/flathub/contributors","subscribers_url":"https://api.github.com/repos/flathub/flathub/subscribers","subscription_url":"https://api.github.com/repos/flathub/flathub/subscription","commits_url":"https://api.github.com/repos/flathub/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/flathub/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/flathub/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/flathub/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/flathub/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/flathub/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flathub/flathub/merges","archive_url":"https://api.github.com/repos/flathub/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flathub/flathub/downloads","issues_url":"https://api.github.com/repos/flathub/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/flathub/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/flathub/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/flathub/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flathub/flathub/labels{/name}","releases_url":"https://api.github.com/repos/flathub/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/flathub/flathub/deployments","created_at":"2017-04-20T11:55:49Z","updated_at":"2018-03-21T06:05:03Z","pushed_at":"2018-03-21T13:18:42Z","git_url":"git://github.com/flathub/flathub.git","ssh_url":"git@github.com:flathub/flathub.git","clone_url":"https://github.com/flathub/flathub.git","svn_url":"https://github.com/flathub/flathub","homepage":"https://flathub.org","size":66,"stargazers_count":98,"watchers_count":98,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":97,"open_issues":45,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/309"},"html":{"href":"https://github.com/flathub/flathub/pull/309"},"issue":{"href":"https://api.github.com/repos/flathub/flathub/issues/309"},"comments":{"href":"https://api.github.com/repos/flathub/flathub/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/flathub/flathub/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flathub/flathub/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/flathub/flathub/statuses/35ca552dc02d5353c1f6437f830f461313c38d59"}},"author_association":"NONE"}} | {
"id": 88860262,
"name": "flathub/flathub",
"url": "https://api.github.com/repos/flathub/flathub"
} | {
"id": 798838,
"login": "TingPing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/798838?",
"url": "https://api.github.com/users/TingPing"
} | {
"id": 27268838,
"login": "flathub",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27268838?",
"url": "https://api.github.com/orgs/flathub"
} | 2018-03-21T16:15:59 | 7413940186 | {"actor":{"display_login":"TingPing"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/comments/199994704","pull_request_review_id":134221512,"id":199994704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk5NDcwNA==","diff_hunk":"@@ -0,0 +1,281 @@\n+/*\n+ File: UIImage+ImageEffects.m\n+ Abstract: This is a category of UIImage that adds methods to apply blur and tint effects to an image. This is the code you’ll want to look out to find out how to use vImage to efficiently calculate a blur.\n+ Version: 1.0\n+ Disclaimer: IMPORTANT: This Apple software is supplied to you by Apple\n+ Inc. (\"Apple\") in consideration of your agreement to the following\n+ terms, and your use, installation, modification or redistribution of\n+ this Apple software constitutes acceptance of these terms. If you do\n+ not agree with these terms, please do not use, install, modify or\n+ redistribute this Apple software.\n+ In consideration of your agreement to abide by the following terms, and\n+ subject to these terms, Apple grants you a personal, non-exclusive\n+ license, under Apple's copyrights in this original Apple software (the\n+ \"Apple Software\"), to use, reproduce, modify and redistribute the Apple\n+ Software, with or without modifications, in source and/or binary forms;\n+ provided that if you redistribute the Apple Software in its entirety and\n+ without modifications, you must retain this notice and the following\n+ text and disclaimers in all such redistributions of the Apple Software.\n+ Neither the name, trademarks, service marks or logos of Apple Inc. may\n+ be used to endorse or promote products derived from the Apple Software\n+ without specific prior written permission from Apple. Except as\n+ expressly stated in this notice, no other rights or licenses, express or\n+ implied, are granted by Apple herein, including but not limited to any\n+ patent rights that may be infringed by your derivative works or by other\n+ works in which the Apple Software may be incorporated.\n+ The Apple Software is provided by Apple on an \"AS IS\" basis. APPLE\n+ MAKES NO WARRANTIES, EXPRESS OR IMPLIED, INCLUDING WITHOUT LIMITATION\n+ THE IMPLIED WARRANTIES OF NON-INFRINGEMENT, MERCHANTABILITY AND FITNESS\n+ FOR A PARTICULAR PURPOSE, REGARDING THE APPLE SOFTWARE OR ITS USE AND\n+ OPERATION ALONE OR IN COMBINATION WITH YOUR PRODUCTS.\n+ IN NO EVENT SHALL APPLE BE LIABLE FOR ANY SPECIAL, INDIRECT, INCIDENTAL\n+ OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ INTERRUPTION) ARISING IN ANY WAY OUT OF THE USE, REPRODUCTION,\n+ MODIFICATION AND/OR DISTRIBUTION OF THE APPLE SOFTWARE, HOWEVER CAUSED\n+ AND WHETHER UNDER THEORY OF CONTRACT, TORT (INCLUDING NEGLIGENCE),\n+ STRICT LIABILITY OR OTHERWISE, EVEN IF APPLE HAS BEEN ADVISED OF THE\n+ POSSIBILITY OF SUCH DAMAGE.\n+ Copyright (C) 2013 Apple Inc. All Rights Reserved.\n+ Copyright © 2013 Apple Inc. All rights reserved.\n+ WWDC 2013 License\n+ NOTE: This Apple Software was supplied by Apple as part of a WWDC 2013\n+ Session. Please refer to the applicable WWDC 2013 Session for further\n+ information.\n+ IMPORTANT: This Apple software is supplied to you by Apple Inc.\n+ (\"Apple\") in consideration of your agreement to the following terms, and\n+ your use, installation, modification or redistribution of this Apple\n+ software constitutes acceptance of these terms. If you do not agree with\n+ these terms, please do not use, install, modify or redistribute this\n+ Apple software.\n+ In consideration of your agreement to abide by the following terms, and\n+ subject to these terms, Apple grants you a non-exclusive license, under\n+ Apple's copyrights in this original Apple software (the \"Apple\n+ Software\"), to use, reproduce, modify and redistribute the Apple\n+ Software, with or without modifications, in source and/or binary forms;\n+ provided that if you redistribute the Apple Software in its entirety and\n+ without modifications, you must retain this notice and the following\n+ text and disclaimers in all such redistributions of the Apple Software.\n+ Neither the name, trademarks, service marks or logos of Apple Inc. may\n+ be used to endorse or promote products derived from the Apple Software\n+ without specific prior written permission from Apple. Except as\n+ expressly stated in this notice, no other rights or licenses, express or\n+ implied, are granted by Apple herein, including but not limited to any\n+ patent rights that may be infringed by your derivative works or by other\n+ works in which the Apple Software may be incorporated.\n+ The Apple Software is provided by Apple on an \"AS IS\" basis. APPLE MAKES\n+ NO WARRANTIES, EXPRESS OR IMPLIED, INCLUDING WITHOUT LIMITATION THE\n+ IMPLIED WARRANTIES OF NON-INFRINGEMENT, MERCHANTABILITY AND FITNESS FOR\n+ A PARTICULAR PURPOSE, REGARDING THE APPLE SOFTWARE OR ITS USE AND\n+ OPERATION ALONE OR IN COMBINATION WITH YOUR PRODUCTS.\n+ IN NO EVENT SHALL APPLE BE LIABLE FOR ANY SPECIAL, INDIRECT, INCIDENTAL\n+ OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ INTERRUPTION) ARISING IN ANY WAY OUT OF THE USE, REPRODUCTION,\n+ MODIFICATION AND/OR DISTRIBUTION OF THE APPLE SOFTWARE, HOWEVER CAUSED\n+ AND WHETHER UNDER THEORY OF CONTRACT, TORT (INCLUDING NEGLIGENCE),\n+ STRICT LIABILITY OR OTHERWISE, EVEN IF APPLE HAS BEEN ADVISED OF THE\n+ POSSIBILITY OF SUCH DAMAGE.\n+ EA1002\n+ 5/3/2013\n+ */\n+\n+//\n+// UIImage.swift\n+// Today\n+//\n+// Created by Alexey Globchastyy on 15/09/14.\n+// Copyright (c) 2014 Alexey Globchastyy. All rights reserved.\n+//\n+import UIKit\n+import Accelerate\n+\n+public extension UIImage {\n+ public func applyLightEffect() -> UIImage? {\n+ return applyBlurWithRadius(30, tintColor: UIColor(white: 1.0, alpha: 0.3), saturationDeltaFactor: 1.8)\n+ }\n+ \n+ public func applyExtraLightEffect() -> UIImage? {\n+ return applyBlurWithRadius(20, tintColor: UIColor(white: 0.97, alpha: 0.82), saturationDeltaFactor: 1.8)\n+ }\n+ \n+ public func applyDarkEffect() -> UIImage? {\n+ return applyBlurWithRadius(20, tintColor: UIColor(white: 0.11, alpha: 0.73), saturationDeltaFactor: 1.8)\n+ }\n+ \n+ public func applyTintEffectWithColor(_ tintColor: UIColor) -> UIImage? {\n+ let effectColorAlpha: CGFloat = 0.6\n+ var effectColor = tintColor\n+ \n+ let componentCount = tintColor.cgColor.numberOfComponents\n+ \n+ if componentCount == 2 {\n+ var b: CGFloat = 0\n+ if tintColor.getWhite(&b, alpha: nil) {\n+ effectColor = UIColor(white: b, alpha: effectColorAlpha)\n+ }\n+ } else {\n+ var red: CGFloat = 0\n+ var green: CGFloat = 0\n+ var blue: CGFloat = 0\n+ \n+ if tintColor.getRed(&red, green: &green, blue: &blue, alpha: nil) {\n+ effectColor = UIColor(red: red, green: green, blue: blue, alpha: effectColorAlpha)\n+ }\n+ }\n+ \n+ return applyBlurWithRadius(10, tintColor: effectColor, saturationDeltaFactor: -1.0, maskImage: nil)\n+ }\n+ \n+ public func applyBlurWithRadius(_ blurRadius: CGFloat, tintColor: UIColor?, saturationDeltaFactor: CGFloat, maskImage: UIImage? = nil) -> UIImage? {","path":"Headlines/src/Categories/UIImageEffects.swift","position":130,"original_position":130,"commit_id":"b49c86a9b05bec3bbe17833b5a716a8293c42cf1","original_commit_id":"b49c86a9b05bec3bbe17833b5a716a8293c42cf1","user":{"login":"botzerra","id":28550240,"node_id":"MDQ6VXNlcjI4NTUwMjQw","avatar_url":"https://avatars2.githubusercontent.com/u/28550240?v=4","gravatar_id":"","url":"https://api.github.com/users/botzerra","html_url":"https://github.com/botzerra","followers_url":"https://api.github.com/users/botzerra/followers","following_url":"https://api.github.com/users/botzerra/following{/other_user}","gists_url":"https://api.github.com/users/botzerra/gists{/gist_id}","starred_url":"https://api.github.com/users/botzerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botzerra/subscriptions","organizations_url":"https://api.github.com/users/botzerra/orgs","repos_url":"https://api.github.com/users/botzerra/repos","events_url":"https://api.github.com/users/botzerra/events{/privacy}","received_events_url":"https://api.github.com/users/botzerra/received_events","type":"User","site_admin":false},"body":"<table data-meta=\"generated_by_danger\">\n <tbody>\n <tr>\n <td>:warning:</td>\n <td width=\"100%\" data-sticky=\"false\"><span data-href=\"https://github.com/Canillitapp/headlines-iOS/blob/b49c86a9b05bec3bbe17833b5a716a8293c42cf1/Headlines/src/Categories/UIImageEffects.swift#L130\"></span>Line should be 120 characters or less: currently 152 characters</td>\n </tr>\n </tbody>\n</table>\n\n\n\n","created_at":"2018-07-04T02:29:12Z","updated_at":"2018-07-04T02:29:12Z","html_url":"https://github.com/Canillitapp/headlines-iOS/pull/93#discussion_r199994704","pull_request_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/comments/199994704"},"html":{"href":"https://github.com/Canillitapp/headlines-iOS/pull/93#discussion_r199994704"},"pull_request":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93","id":199123222,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTIzMjIy","html_url":"https://github.com/Canillitapp/headlines-iOS/pull/93","diff_url":"https://github.com/Canillitapp/headlines-iOS/pull/93.diff","patch_url":"https://github.com/Canillitapp/headlines-iOS/pull/93.patch","issue_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/93","number":93,"state":"open","locked":false,"title":"[WIP] Feat categories","user":{"login":"betzerra","id":681600,"node_id":"MDQ6VXNlcjY4MTYwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/681600?v=4","gravatar_id":"","url":"https://api.github.com/users/betzerra","html_url":"https://github.com/betzerra","followers_url":"https://api.github.com/users/betzerra/followers","following_url":"https://api.github.com/users/betzerra/following{/other_user}","gists_url":"https://api.github.com/users/betzerra/gists{/gist_id}","starred_url":"https://api.github.com/users/betzerra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betzerra/subscriptions","organizations_url":"https://api.github.com/users/betzerra/orgs","repos_url":"https://api.github.com/users/betzerra/repos","events_url":"https://api.github.com/users/betzerra/events{/privacy}","received_events_url":"https://api.github.com/users/betzerra/received_events","type":"User","site_admin":false},"body":"- [x] feat: categories on TrendingCardsViewController! 🎉 \r\n- [x] feat: prefetch categories on Loading screen.\r\n- [ ] feat: prefetch trending news on Loading screen.\r\n- [ ] chore: unit tests\r\n- [ ] chore: check automated screenshots.","created_at":"2018-07-04T02:14:55Z","updated_at":"2018-07-04T02:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71ad981f9abb5d171328fc77a5fe136ab976fab1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93/commits","review_comments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93/comments","review_comment_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/93/comments","statuses_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/statuses/b49c86a9b05bec3bbe17833b5a716a8293c42cf1","head":{"label":"Canillitapp:feat-categories","ref":"feat-categories","sha":"b49c86a9b05bec3bbe17833b5a716a8293c42cf1","user":{"login":"Canillitapp","id":27981584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTgxNTg0","avatar_url":"https://avatars2.githubusercontent.com/u/27981584?v=4","gravatar_id":"","url":"https://api.github.com/users/Canillitapp","html_url":"https://github.com/Canillitapp","followers_url":"https://api.github.com/users/Canillitapp/followers","following_url":"https://api.github.com/users/Canillitapp/following{/other_user}","gists_url":"https://api.github.com/users/Canillitapp/gists{/gist_id}","starred_url":"https://api.github.com/users/Canillitapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Canillitapp/subscriptions","organizations_url":"https://api.github.com/users/Canillitapp/orgs","repos_url":"https://api.github.com/users/Canillitapp/repos","events_url":"https://api.github.com/users/Canillitapp/events{/privacy}","received_events_url":"https://api.github.com/users/Canillitapp/received_events","type":"Organization","site_admin":false},"repo":{"id":66330583,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMzMDU4Mw==","name":"headlines-iOS","full_name":"Canillitapp/headlines-iOS","owner":{"login":"Canillitapp","id":27981584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTgxNTg0","avatar_url":"https://avatars2.githubusercontent.com/u/27981584?v=4","gravatar_id":"","url":"https://api.github.com/users/Canillitapp","html_url":"https://github.com/Canillitapp","followers_url":"https://api.github.com/users/Canillitapp/followers","following_url":"https://api.github.com/users/Canillitapp/following{/other_user}","gists_url":"https://api.github.com/users/Canillitapp/gists{/gist_id}","starred_url":"https://api.github.com/users/Canillitapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Canillitapp/subscriptions","organizations_url":"https://api.github.com/users/Canillitapp/orgs","repos_url":"https://api.github.com/users/Canillitapp/repos","events_url":"https://api.github.com/users/Canillitapp/events{/privacy}","received_events_url":"https://api.github.com/users/Canillitapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Canillitapp/headlines-iOS","description":null,"fork":false,"url":"https://api.github.com/repos/Canillitapp/headlines-iOS","forks_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/forks","keys_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/teams","hooks_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/hooks","issue_events_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/events","assignees_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/tags","blobs_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/languages","stargazers_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/stargazers","contributors_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/contributors","subscribers_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/subscribers","subscription_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/subscription","commits_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/merges","archive_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/downloads","issues_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/labels{/name}","releases_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/deployments","created_at":"2016-08-23T03:38:49Z","updated_at":"2018-05-16T16:03:42Z","pushed_at":"2018-07-04T02:21:27Z","git_url":"git://github.com/Canillitapp/headlines-iOS.git","ssh_url":"git@github.com:Canillitapp/headlines-iOS.git","clone_url":"https://github.com/Canillitapp/headlines-iOS.git","svn_url":"https://github.com/Canillitapp/headlines-iOS","homepage":null,"size":8357,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"Canillitapp:master","ref":"master","sha":"6ee2ffa40e665ba5c28171979eb39f08c6768af1","user":{"login":"Canillitapp","id":27981584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTgxNTg0","avatar_url":"https://avatars2.githubusercontent.com/u/27981584?v=4","gravatar_id":"","url":"https://api.github.com/users/Canillitapp","html_url":"https://github.com/Canillitapp","followers_url":"https://api.github.com/users/Canillitapp/followers","following_url":"https://api.github.com/users/Canillitapp/following{/other_user}","gists_url":"https://api.github.com/users/Canillitapp/gists{/gist_id}","starred_url":"https://api.github.com/users/Canillitapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Canillitapp/subscriptions","organizations_url":"https://api.github.com/users/Canillitapp/orgs","repos_url":"https://api.github.com/users/Canillitapp/repos","events_url":"https://api.github.com/users/Canillitapp/events{/privacy}","received_events_url":"https://api.github.com/users/Canillitapp/received_events","type":"Organization","site_admin":false},"repo":{"id":66330583,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMzMDU4Mw==","name":"headlines-iOS","full_name":"Canillitapp/headlines-iOS","owner":{"login":"Canillitapp","id":27981584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3OTgxNTg0","avatar_url":"https://avatars2.githubusercontent.com/u/27981584?v=4","gravatar_id":"","url":"https://api.github.com/users/Canillitapp","html_url":"https://github.com/Canillitapp","followers_url":"https://api.github.com/users/Canillitapp/followers","following_url":"https://api.github.com/users/Canillitapp/following{/other_user}","gists_url":"https://api.github.com/users/Canillitapp/gists{/gist_id}","starred_url":"https://api.github.com/users/Canillitapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Canillitapp/subscriptions","organizations_url":"https://api.github.com/users/Canillitapp/orgs","repos_url":"https://api.github.com/users/Canillitapp/repos","events_url":"https://api.github.com/users/Canillitapp/events{/privacy}","received_events_url":"https://api.github.com/users/Canillitapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Canillitapp/headlines-iOS","description":null,"fork":false,"url":"https://api.github.com/repos/Canillitapp/headlines-iOS","forks_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/forks","keys_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/teams","hooks_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/hooks","issue_events_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/events","assignees_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/tags","blobs_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/languages","stargazers_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/stargazers","contributors_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/contributors","subscribers_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/subscribers","subscription_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/subscription","commits_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/merges","archive_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/downloads","issues_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/labels{/name}","releases_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/Canillitapp/headlines-iOS/deployments","created_at":"2016-08-23T03:38:49Z","updated_at":"2018-05-16T16:03:42Z","pushed_at":"2018-07-04T02:21:27Z","git_url":"git://github.com/Canillitapp/headlines-iOS.git","ssh_url":"git@github.com:Canillitapp/headlines-iOS.git","clone_url":"https://github.com/Canillitapp/headlines-iOS.git","svn_url":"https://github.com/Canillitapp/headlines-iOS","homepage":null,"size":8357,"stargazers_count":4,"watchers_count":4,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93"},"html":{"href":"https://github.com/Canillitapp/headlines-iOS/pull/93"},"issue":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/93"},"comments":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/Canillitapp/headlines-iOS/statuses/b49c86a9b05bec3bbe17833b5a716a8293c42cf1"}},"author_association":"MEMBER"}} | {
"id": 66330583,
"name": "Canillitapp/headlines-iOS",
"url": "https://api.github.com/repos/Canillitapp/headlines-iOS"
} | {
"id": 28550240,
"login": "botzerra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28550240?",
"url": "https://api.github.com/users/botzerra"
} | {
"id": 27981584,
"login": "Canillitapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27981584?",
"url": "https://api.github.com/orgs/Canillitapp"
} | 2018-07-04T02:29:12 | 7915898595 | {"actor":{"display_login":"botzerra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/comments/191319362","pull_request_review_id":123865971,"id":191319362,"diff_hunk":"@@ -0,0 +1,168 @@\n+\"\"\"The HPF Model scoring class.\"\"\"\n+\n+import numpy as np\n+import os\n+from edward.models import Poisson\n+from edward.models import Gamma\n+import tensorflow as tf\n+from collections import defaultdict\n+from src.config import (SCORING_THRESHOLD,\n+ HPF_SCORING_REGION,\n+ HPF_output_package_id_dict,\n+ HPF_output_manifest_id_dict,\n+ HPF_output_rating_matrix,\n+ HPF_output_item_matrix,\n+ a, a_c, c, c_c,\n+ b_c, d_c, K)\n+\n+\n+class HPFScoring:\n+ \"\"\"The HPF Model scoring class.\"\"\"\n+\n+ def __init__(self, datastore=None, scoring_threshold=SCORING_THRESHOLD,\n+ scoring_region=HPF_SCORING_REGION):\n+ \"\"\"Set the variables and load model data.\"\"\"\n+ self.datastore = datastore\n+ self.scoring_threshold = scoring_threshold\n+ self.scoring_region = scoring_region\n+ self.package_id_dict = None\n+ self.id_package_dict = None\n+ self.rating_matrix = None\n+ self.beta = None\n+ self.manifest_id_dict = None\n+ self.manifests = 0\n+ self.packages = 0\n+ self.rating_mean = 0.0\n+ self.a = tf.constant(a)\n+ self.a_c = tf.constant(a_c)\n+ self.c = tf.constant(c)\n+ self.c_c = tf.constant(c_c)\n+ self.b_c = tf.constant(b_c)\n+ self.d_c = tf.constant(d_c)\n+ self.K = K\n+ self.loadS3()\n+\n+ def loadS3(self):\n+ \"\"\"Load the model data from AWS S3.\"\"\"\n+ package_id_dict_filename = os.path.join(\n+ self.scoring_region, HPF_output_package_id_dict)\n+ self.package_id_dict = self.datastore.read_json_file(\n+ package_id_dict_filename)\n+ self.id_package_dict = {x: n for n, x in self.package_id_dict.items()}\n+ manifest_id_dict_filename = os.path.join(\n+ self.scoring_region, HPF_output_manifest_id_dict)\n+ self.manifest_id_dict = self.datastore.read_json_file(\n+ manifest_id_dict_filename)\n+ self.manifest_id_dict = {n: set(x)\n+ for n, x in self.manifest_id_dict.items()}\n+ rating_matrix_filename = os.path.join(\n+ self.scoring_region, HPF_output_rating_matrix)\n+ self.datastore.download_file(\n+ rating_matrix_filename, \"/tmp/rating_matrix.npy\")\n+ self.rating_matrix = np.load(\"/tmp/rating_matrix.npy\")\n+ beta_matrix_filename = os.path.join(\n+ self.scoring_region, HPF_output_item_matrix)\n+ self.datastore.download_file(\n+ beta_matrix_filename, \"/tmp/beta_matrix.npy\")\n+ self.beta = np.load(\"/tmp/beta_matrix.npy\")\n+ self.manifests, self.packages = self.rating_matrix.shape\n+ self.rating_mean = self.rating_matrix.mean()\n+\n+ def predict(self, input_stack):\n+ \"\"\"Prediction function.\n+\n+ :param input_stack: The user's package list\n+ for which companion recommendation are to be generated.\n+ :return companion_recommendation: The list of recommended companion packages\n+ along with condifence score.\n+ :return package_topic_dict: The topics associated with the packages\n+ in the input_stack+recommendation.\n+ :return missing_packages: The list of packages unknown to the HPF model.\n+ \"\"\"\n+ input_id_set = set()\n+ missing_packages = []\n+ for package_name in input_stack:\n+ package_id = self.package_id_dict.get(package_name)\n+ if package_id is None:\n+ missing_packages.append(package_name)\n+ else:\n+ input_id_set.add(package_id)\n+ # TODO: Check for known-unknown ratio before recommending\n+ companion_recommendation, package_topic_dict = self.folding_in(\n+ input_id_set)\n+ return companion_recommendation, package_topic_dict, missing_packages\n+\n+ def match_manifest(self, input_id_set):\n+ \"\"\"Find a manifest list that matches user's input package list and return its index.\n+\n+ :param input_id_set: A set containing package ids of user's input package list.\n+ :return manifest_id: The index of the matched manifest.\n+ \"\"\"\n+ for manifest_id, dependency_set in self.manifest_id_dict.items():\n+ if dependency_set == input_id_set:\n+ break\n+ else:\n+ manifest_id = -1\n+ return manifest_id\n+\n+ def folding_in(self, input_id_set):\n+ \"\"\"Folding in logic for prediction.\n+\n+ :param input_id_set: A set containing package ids of user's input package list.\n+ :return: Filter companion recommendations and their topics.\n+ \"\"\"\n+ manifest_id = int(self.match_manifest(input_id_set))\n+ if manifest_id == -1:\n+ theta = []\n+ with tf.Session() as sess:","path":"src/scoring/hpf_scoring.py","position":117,"original_position":117,"commit_id":"8df186d37025db72f10a17c2b45c9afc61d08545","original_commit_id":"8df186d37025db72f10a17c2b45c9afc61d08545","user":{"login":"sara-02","id":7047079,"avatar_url":"https://avatars0.githubusercontent.com/u/7047079?v=4","gravatar_id":"","url":"https://api.github.com/users/sara-02","html_url":"https://github.com/sara-02","followers_url":"https://api.github.com/users/sara-02/followers","following_url":"https://api.github.com/users/sara-02/following{/other_user}","gists_url":"https://api.github.com/users/sara-02/gists{/gist_id}","starred_url":"https://api.github.com/users/sara-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sara-02/subscriptions","organizations_url":"https://api.github.com/users/sara-02/orgs","repos_url":"https://api.github.com/users/sara-02/repos","events_url":"https://api.github.com/users/sara-02/events{/privacy}","received_events_url":"https://api.github.com/users/sara-02/received_events","type":"User","site_admin":false},"body":"@rootAvish I had a doubt, should the `tf.session()` be created at each request, or at the class level.","created_at":"2018-05-29T06:56:05Z","updated_at":"2018-05-29T06:58:02Z","html_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1#discussion_r191319362","pull_request_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/comments/191319362"},"html":{"href":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1#discussion_r191319362"},"pull_request":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1","id":190194116,"html_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1","diff_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1.diff","patch_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1.patch","issue_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/1","number":1,"state":"open","locked":false,"title":"Devcluster setup","user":{"login":"sara-02","id":7047079,"avatar_url":"https://avatars0.githubusercontent.com/u/7047079?v=4","gravatar_id":"","url":"https://api.github.com/users/sara-02","html_url":"https://github.com/sara-02","followers_url":"https://api.github.com/users/sara-02/followers","following_url":"https://api.github.com/users/sara-02/following{/other_user}","gists_url":"https://api.github.com/users/sara-02/gists{/gist_id}","starred_url":"https://api.github.com/users/sara-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sara-02/subscriptions","organizations_url":"https://api.github.com/users/sara-02/orgs","repos_url":"https://api.github.com/users/sara-02/repos","events_url":"https://api.github.com/users/sara-02/events{/privacy}","received_events_url":"https://api.github.com/users/sara-02/received_events","type":"User","site_admin":false},"body":"Initial scoring endpoint setup at Dev cluster.\r\n","created_at":"2018-05-24T07:32:38Z","updated_at":"2018-05-29T06:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a8b9ac7f1185da43263287d8c62b6a3f65df50","assignee":null,"assignees":[],"requested_reviewers":[{"login":"msrb","id":3759039,"avatar_url":"https://avatars0.githubusercontent.com/u/3759039?v=4","gravatar_id":"","url":"https://api.github.com/users/msrb","html_url":"https://github.com/msrb","followers_url":"https://api.github.com/users/msrb/followers","following_url":"https://api.github.com/users/msrb/following{/other_user}","gists_url":"https://api.github.com/users/msrb/gists{/gist_id}","starred_url":"https://api.github.com/users/msrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msrb/subscriptions","organizations_url":"https://api.github.com/users/msrb/orgs","repos_url":"https://api.github.com/users/msrb/repos","events_url":"https://api.github.com/users/msrb/events{/privacy}","received_events_url":"https://api.github.com/users/msrb/received_events","type":"User","site_admin":false},{"login":"tisnik","id":4579967,"avatar_url":"https://avatars1.githubusercontent.com/u/4579967?v=4","gravatar_id":"","url":"https://api.github.com/users/tisnik","html_url":"https://github.com/tisnik","followers_url":"https://api.github.com/users/tisnik/followers","following_url":"https://api.github.com/users/tisnik/following{/other_user}","gists_url":"https://api.github.com/users/tisnik/gists{/gist_id}","starred_url":"https://api.github.com/users/tisnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tisnik/subscriptions","organizations_url":"https://api.github.com/users/tisnik/orgs","repos_url":"https://api.github.com/users/tisnik/repos","events_url":"https://api.github.com/users/tisnik/events{/privacy}","received_events_url":"https://api.github.com/users/tisnik/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1/commits","review_comments_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1/comments","review_comment_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/1/comments","statuses_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/statuses/8df186d37025db72f10a17c2b45c9afc61d08545","head":{"label":"sara-02:devcluster_setup","ref":"devcluster_setup","sha":"8df186d37025db72f10a17c2b45c9afc61d08545","user":{"login":"sara-02","id":7047079,"avatar_url":"https://avatars0.githubusercontent.com/u/7047079?v=4","gravatar_id":"","url":"https://api.github.com/users/sara-02","html_url":"https://github.com/sara-02","followers_url":"https://api.github.com/users/sara-02/followers","following_url":"https://api.github.com/users/sara-02/following{/other_user}","gists_url":"https://api.github.com/users/sara-02/gists{/gist_id}","starred_url":"https://api.github.com/users/sara-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sara-02/subscriptions","organizations_url":"https://api.github.com/users/sara-02/orgs","repos_url":"https://api.github.com/users/sara-02/repos","events_url":"https://api.github.com/users/sara-02/events{/privacy}","received_events_url":"https://api.github.com/users/sara-02/received_events","type":"User","site_admin":false},"repo":{"id":134397000,"name":"poc-maven-stack-analysis","full_name":"sara-02/poc-maven-stack-analysis","owner":{"login":"sara-02","id":7047079,"avatar_url":"https://avatars0.githubusercontent.com/u/7047079?v=4","gravatar_id":"","url":"https://api.github.com/users/sara-02","html_url":"https://github.com/sara-02","followers_url":"https://api.github.com/users/sara-02/followers","following_url":"https://api.github.com/users/sara-02/following{/other_user}","gists_url":"https://api.github.com/users/sara-02/gists{/gist_id}","starred_url":"https://api.github.com/users/sara-02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sara-02/subscriptions","organizations_url":"https://api.github.com/users/sara-02/orgs","repos_url":"https://api.github.com/users/sara-02/repos","events_url":"https://api.github.com/users/sara-02/events{/privacy}","received_events_url":"https://api.github.com/users/sara-02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sara-02/poc-maven-stack-analysis","description":"Poc for Matrix Factorizations for Maven companion recommendation","fork":true,"url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis","forks_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/forks","keys_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/teams","hooks_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/hooks","issue_events_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/events","assignees_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/tags","blobs_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/languages","stargazers_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/stargazers","contributors_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/contributors","subscribers_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/subscribers","subscription_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/subscription","commits_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/merges","archive_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/downloads","issues_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/labels{/name}","releases_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/sara-02/poc-maven-stack-analysis/deployments","created_at":"2018-05-22T10:08:14Z","updated_at":"2018-05-25T10:29:35Z","pushed_at":"2018-05-28T21:06:31Z","git_url":"git://github.com/sara-02/poc-maven-stack-analysis.git","ssh_url":"git@github.com:sara-02/poc-maven-stack-analysis.git","clone_url":"https://github.com/sara-02/poc-maven-stack-analysis.git","svn_url":"https://github.com/sara-02/poc-maven-stack-analysis","homepage":null,"size":405,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-analytics:master","ref":"master","sha":"1fc0707dacbeac249f26f615db0adf6fb9936576","user":{"login":"fabric8-analytics","id":28134954,"avatar_url":"https://avatars3.githubusercontent.com/u/28134954?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-analytics","html_url":"https://github.com/fabric8-analytics","followers_url":"https://api.github.com/users/fabric8-analytics/followers","following_url":"https://api.github.com/users/fabric8-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-analytics/subscriptions","organizations_url":"https://api.github.com/users/fabric8-analytics/orgs","repos_url":"https://api.github.com/users/fabric8-analytics/repos","events_url":"https://api.github.com/users/fabric8-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":132793642,"name":"poc-maven-stack-analysis","full_name":"fabric8-analytics/poc-maven-stack-analysis","owner":{"login":"fabric8-analytics","id":28134954,"avatar_url":"https://avatars3.githubusercontent.com/u/28134954?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-analytics","html_url":"https://github.com/fabric8-analytics","followers_url":"https://api.github.com/users/fabric8-analytics/followers","following_url":"https://api.github.com/users/fabric8-analytics/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-analytics/subscriptions","organizations_url":"https://api.github.com/users/fabric8-analytics/orgs","repos_url":"https://api.github.com/users/fabric8-analytics/repos","events_url":"https://api.github.com/users/fabric8-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis","description":"Poc for Matrix Factorizations for Maven companion recommendation","fork":false,"url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis","forks_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/forks","keys_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/teams","hooks_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/hooks","issue_events_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/events","assignees_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/tags","blobs_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/languages","stargazers_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/stargazers","contributors_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/contributors","subscribers_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/subscribers","subscription_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/subscription","commits_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/merges","archive_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/downloads","issues_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/deployments","created_at":"2018-05-09T17:51:22Z","updated_at":"2018-05-25T10:15:18Z","pushed_at":"2018-05-28T21:06:32Z","git_url":"git://github.com/fabric8-analytics/poc-maven-stack-analysis.git","ssh_url":"git@github.com:fabric8-analytics/poc-maven-stack-analysis.git","clone_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis.git","svn_url":"https://github.com/fabric8-analytics/poc-maven-stack-analysis","homepage":null,"size":391,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1"},"html":{"href":"https://github.com/fabric8-analytics/poc-maven-stack-analysis/pull/1"},"issue":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/1"},"comments":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis/statuses/8df186d37025db72f10a17c2b45c9afc61d08545"}},"author_association":"MEMBER"}} | {
"id": 132793642,
"name": "fabric8-analytics/poc-maven-stack-analysis",
"url": "https://api.github.com/repos/fabric8-analytics/poc-maven-stack-analysis"
} | {
"id": 7047079,
"login": "sara-02",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7047079?",
"url": "https://api.github.com/users/sara-02"
} | {
"id": 28134954,
"login": "fabric8-analytics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28134954?",
"url": "https://api.github.com/orgs/fabric8-analytics"
} | 2018-05-29T06:56:05 | 7741677787 | {"actor":{"display_login":"sara-02"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/comments/239427522","pull_request_review_id":182206136,"id":239427522,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTQyNzUyMg==","diff_hunk":"@@ -0,0 +1,61 @@\n+import os\n+import shlex\n+\n+from coalib.bearlib.abstractions.Linter import linter\n+from dependency_management.requirements.PipRequirement import PipRequirement\n+from coalib.results.RESULT_SEVERITY import RESULT_SEVERITY\n+from coalib.settings.Setting import typed_list\n+\n+\n+@linter(executable='python2',\n+ output_format='regex',\n+ output_regex=r'L(?P<line>\\d+)C(?P<column>\\d+): (?P<message>'\n+ r'(?P<origin>(?P<severity>[WFECRI])\\d+) - .*)',\n+ severity_map={'F': RESULT_SEVERITY.MAJOR,\n+ 'E': RESULT_SEVERITY.MAJOR,\n+ 'W': RESULT_SEVERITY.NORMAL,\n+ 'C': RESULT_SEVERITY.INFO,\n+ 'R': RESULT_SEVERITY.INFO,\n+ 'I': RESULT_SEVERITY.INFO})\n+class PyLintBear:\n+ \"\"\"\n+ Checks the code with pylint. This will run pylint over each file\n+ separately.\n+ \"\"\"\n+ LANGUAGES = {'Python', 'Python 2', 'Python 3'}","path":"bears/python/PyLintBear2.py","position":25,"original_position":25,"commit_id":"034d49686738d7f73a57513bc7b86b82ef53d93d","original_commit_id":"034d49686738d7f73a57513bc7b86b82ef53d93d","user":{"login":"amrondonp","id":6508705,"node_id":"MDQ6VXNlcjY1MDg3MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6508705?v=4","gravatar_id":"","url":"https://api.github.com/users/amrondonp","html_url":"https://github.com/amrondonp","followers_url":"https://api.github.com/users/amrondonp/followers","following_url":"https://api.github.com/users/amrondonp/following{/other_user}","gists_url":"https://api.github.com/users/amrondonp/gists{/gist_id}","starred_url":"https://api.github.com/users/amrondonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrondonp/subscriptions","organizations_url":"https://api.github.com/users/amrondonp/orgs","repos_url":"https://api.github.com/users/amrondonp/repos","events_url":"https://api.github.com/users/amrondonp/events{/privacy}","received_events_url":"https://api.github.com/users/amrondonp/received_events","type":"User","site_admin":false},"body":"Update supported languages","created_at":"2018-12-06T12:01:22Z","updated_at":"2018-12-06T12:01:43Z","html_url":"https://github.com/JuezUN/coala-bears/pull/4#discussion_r239427522","pull_request_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/comments/239427522"},"html":{"href":"https://github.com/JuezUN/coala-bears/pull/4#discussion_r239427522"},"pull_request":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4","id":236505343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTA1MzQz","html_url":"https://github.com/JuezUN/coala-bears/pull/4","diff_url":"https://github.com/JuezUN/coala-bears/pull/4.diff","patch_url":"https://github.com/JuezUN/coala-bears/pull/4.patch","issue_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/4","number":4,"state":"open","locked":false,"title":"Add pylint python2 bear","user":{"login":"amrondonp","id":6508705,"node_id":"MDQ6VXNlcjY1MDg3MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6508705?v=4","gravatar_id":"","url":"https://api.github.com/users/amrondonp","html_url":"https://github.com/amrondonp","followers_url":"https://api.github.com/users/amrondonp/followers","following_url":"https://api.github.com/users/amrondonp/following{/other_user}","gists_url":"https://api.github.com/users/amrondonp/gists{/gist_id}","starred_url":"https://api.github.com/users/amrondonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrondonp/subscriptions","organizations_url":"https://api.github.com/users/amrondonp/orgs","repos_url":"https://api.github.com/users/amrondonp/repos","events_url":"https://api.github.com/users/amrondonp/events{/privacy}","received_events_url":"https://api.github.com/users/amrondonp/received_events","type":"User","site_admin":false},"body":"This PR adds pylint bear for python2\r\n\r\nThe python version that pylint uses is the one that it runs on because it uses the python interpreter to parse the code among other things.\r\n\r\nSo this Bear calls pylint but with the interpreter of python2","created_at":"2018-12-06T12:00:54Z","updated_at":"2018-12-06T12:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"236cb7e8059c2f5a26aa9a8e92ad201fb6298153","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4/commits","review_comments_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4/comments","review_comment_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/4/comments","statuses_url":"https://api.github.com/repos/JuezUN/coala-bears/statuses/034d49686738d7f73a57513bc7b86b82ef53d93d","head":{"label":"JuezUN:python2","ref":"python2","sha":"034d49686738d7f73a57513bc7b86b82ef53d93d","user":{"login":"JuezUN","id":28381056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzgxMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28381056?v=4","gravatar_id":"","url":"https://api.github.com/users/JuezUN","html_url":"https://github.com/JuezUN","followers_url":"https://api.github.com/users/JuezUN/followers","following_url":"https://api.github.com/users/JuezUN/following{/other_user}","gists_url":"https://api.github.com/users/JuezUN/gists{/gist_id}","starred_url":"https://api.github.com/users/JuezUN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuezUN/subscriptions","organizations_url":"https://api.github.com/users/JuezUN/orgs","repos_url":"https://api.github.com/users/JuezUN/repos","events_url":"https://api.github.com/users/JuezUN/events{/privacy}","received_events_url":"https://api.github.com/users/JuezUN/received_events","type":"Organization","site_admin":false},"repo":{"id":92797297,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc5NzI5Nw==","name":"coala-bears","full_name":"JuezUN/coala-bears","private":false,"owner":{"login":"JuezUN","id":28381056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzgxMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28381056?v=4","gravatar_id":"","url":"https://api.github.com/users/JuezUN","html_url":"https://github.com/JuezUN","followers_url":"https://api.github.com/users/JuezUN/followers","following_url":"https://api.github.com/users/JuezUN/following{/other_user}","gists_url":"https://api.github.com/users/JuezUN/gists{/gist_id}","starred_url":"https://api.github.com/users/JuezUN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuezUN/subscriptions","organizations_url":"https://api.github.com/users/JuezUN/orgs","repos_url":"https://api.github.com/users/JuezUN/repos","events_url":"https://api.github.com/users/JuezUN/events{/privacy}","received_events_url":"https://api.github.com/users/JuezUN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuezUN/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/JuezUN/coala-bears","forks_url":"https://api.github.com/repos/JuezUN/coala-bears/forks","keys_url":"https://api.github.com/repos/JuezUN/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuezUN/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuezUN/coala-bears/teams","hooks_url":"https://api.github.com/repos/JuezUN/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/JuezUN/coala-bears/events","assignees_url":"https://api.github.com/repos/JuezUN/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/JuezUN/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/JuezUN/coala-bears/tags","blobs_url":"https://api.github.com/repos/JuezUN/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuezUN/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuezUN/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuezUN/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuezUN/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/JuezUN/coala-bears/languages","stargazers_url":"https://api.github.com/repos/JuezUN/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/JuezUN/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/JuezUN/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/JuezUN/coala-bears/subscription","commits_url":"https://api.github.com/repos/JuezUN/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuezUN/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuezUN/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuezUN/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/JuezUN/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuezUN/coala-bears/merges","archive_url":"https://api.github.com/repos/JuezUN/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuezUN/coala-bears/downloads","issues_url":"https://api.github.com/repos/JuezUN/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/JuezUN/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/JuezUN/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuezUN/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/JuezUN/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/JuezUN/coala-bears/deployments","created_at":"2017-05-30T04:15:28Z","updated_at":"2017-05-30T04:15:30Z","pushed_at":"2018-12-06T12:00:54Z","git_url":"git://github.com/JuezUN/coala-bears.git","ssh_url":"git@github.com:JuezUN/coala-bears.git","clone_url":"https://github.com/JuezUN/coala-bears.git","svn_url":"https://github.com/JuezUN/coala-bears","homepage":"https://coala.io/","size":1662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"JuezUN:master","ref":"master","sha":"60599b719c98cfd723eb284faa143e547d6ca19d","user":{"login":"JuezUN","id":28381056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzgxMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28381056?v=4","gravatar_id":"","url":"https://api.github.com/users/JuezUN","html_url":"https://github.com/JuezUN","followers_url":"https://api.github.com/users/JuezUN/followers","following_url":"https://api.github.com/users/JuezUN/following{/other_user}","gists_url":"https://api.github.com/users/JuezUN/gists{/gist_id}","starred_url":"https://api.github.com/users/JuezUN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuezUN/subscriptions","organizations_url":"https://api.github.com/users/JuezUN/orgs","repos_url":"https://api.github.com/users/JuezUN/repos","events_url":"https://api.github.com/users/JuezUN/events{/privacy}","received_events_url":"https://api.github.com/users/JuezUN/received_events","type":"Organization","site_admin":false},"repo":{"id":92797297,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc5NzI5Nw==","name":"coala-bears","full_name":"JuezUN/coala-bears","private":false,"owner":{"login":"JuezUN","id":28381056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzgxMDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28381056?v=4","gravatar_id":"","url":"https://api.github.com/users/JuezUN","html_url":"https://github.com/JuezUN","followers_url":"https://api.github.com/users/JuezUN/followers","following_url":"https://api.github.com/users/JuezUN/following{/other_user}","gists_url":"https://api.github.com/users/JuezUN/gists{/gist_id}","starred_url":"https://api.github.com/users/JuezUN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuezUN/subscriptions","organizations_url":"https://api.github.com/users/JuezUN/orgs","repos_url":"https://api.github.com/users/JuezUN/repos","events_url":"https://api.github.com/users/JuezUN/events{/privacy}","received_events_url":"https://api.github.com/users/JuezUN/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuezUN/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/JuezUN/coala-bears","forks_url":"https://api.github.com/repos/JuezUN/coala-bears/forks","keys_url":"https://api.github.com/repos/JuezUN/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuezUN/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuezUN/coala-bears/teams","hooks_url":"https://api.github.com/repos/JuezUN/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/JuezUN/coala-bears/events","assignees_url":"https://api.github.com/repos/JuezUN/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/JuezUN/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/JuezUN/coala-bears/tags","blobs_url":"https://api.github.com/repos/JuezUN/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuezUN/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuezUN/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuezUN/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuezUN/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/JuezUN/coala-bears/languages","stargazers_url":"https://api.github.com/repos/JuezUN/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/JuezUN/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/JuezUN/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/JuezUN/coala-bears/subscription","commits_url":"https://api.github.com/repos/JuezUN/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuezUN/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuezUN/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuezUN/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuezUN/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/JuezUN/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuezUN/coala-bears/merges","archive_url":"https://api.github.com/repos/JuezUN/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuezUN/coala-bears/downloads","issues_url":"https://api.github.com/repos/JuezUN/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/JuezUN/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/JuezUN/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/JuezUN/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuezUN/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/JuezUN/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/JuezUN/coala-bears/deployments","created_at":"2017-05-30T04:15:28Z","updated_at":"2017-05-30T04:15:30Z","pushed_at":"2018-12-06T12:00:54Z","git_url":"git://github.com/JuezUN/coala-bears.git","ssh_url":"git@github.com:JuezUN/coala-bears.git","clone_url":"https://github.com/JuezUN/coala-bears.git","svn_url":"https://github.com/JuezUN/coala-bears","homepage":"https://coala.io/","size":1662,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4"},"html":{"href":"https://github.com/JuezUN/coala-bears/pull/4"},"issue":{"href":"https://api.github.com/repos/JuezUN/coala-bears/issues/4"},"comments":{"href":"https://api.github.com/repos/JuezUN/coala-bears/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuezUN/coala-bears/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/JuezUN/coala-bears/statuses/034d49686738d7f73a57513bc7b86b82ef53d93d"}},"author_association":"MEMBER"}} | {
"id": 92797297,
"name": "JuezUN/coala-bears",
"url": "https://api.github.com/repos/JuezUN/coala-bears"
} | {
"id": 6508705,
"login": "amrondonp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6508705?",
"url": "https://api.github.com/users/amrondonp"
} | {
"id": 28381056,
"login": "JuezUN",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28381056?",
"url": "https://api.github.com/orgs/JuezUN"
} | 2018-12-06T12:01:22 | 8708794071 | {"actor":{"display_login":"amrondonp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rsksmart/rskj/pulls/comments/241489194","pull_request_review_id":184775187,"id":241489194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ4OTE5NA==","diff_hunk":"@@ -1089,6 +1089,9 @@ private static boolean isEmptyTrie(byte[] value, TrieImpl[] nodes, Keccak256[] h\n public Trie getSnapshotTo(Keccak256 hash) {\n // This call shouldn't be needed since internally try can know it should store data\n //this.save();\n+ if (getHash().equals(hash)) {","path":"rskj-core/src/main/java/co/rsk/trie/TrieImpl.java","position":19,"original_position":4,"commit_id":"4ab235a265b5627979f945f2d412987a7e46ea07","original_commit_id":"5a450e20b419d819fe2d1b31c22be253bd928798","user":{"login":"SergioDemianLerner","id":1752347,"node_id":"MDQ6VXNlcjE3NTIzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1752347?v=4","gravatar_id":"","url":"https://api.github.com/users/SergioDemianLerner","html_url":"https://github.com/SergioDemianLerner","followers_url":"https://api.github.com/users/SergioDemianLerner/followers","following_url":"https://api.github.com/users/SergioDemianLerner/following{/other_user}","gists_url":"https://api.github.com/users/SergioDemianLerner/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioDemianLerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioDemianLerner/subscriptions","organizations_url":"https://api.github.com/users/SergioDemianLerner/orgs","repos_url":"https://api.github.com/users/SergioDemianLerner/repos","events_url":"https://api.github.com/users/SergioDemianLerner/events{/privacy}","received_events_url":"https://api.github.com/users/SergioDemianLerner/received_events","type":"User","site_admin":false},"body":"FYI: This line provides an enormous speed boost for unitrie, if merged. ","created_at":"2018-12-13T17:17:34Z","updated_at":"2018-12-13T17:17:34Z","html_url":"https://github.com/rsksmart/rskj/pull/719#discussion_r241489194","pull_request_url":"https://api.github.com/repos/rsksmart/rskj/pulls/719","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/comments/241489194"},"html":{"href":"https://github.com/rsksmart/rskj/pull/719#discussion_r241489194"},"pull_request":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/719"}},"in_reply_to_id":240316084},"pull_request":{"url":"https://api.github.com/repos/rsksmart/rskj/pulls/719","id":236915356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTE1MzU2","html_url":"https://github.com/rsksmart/rskj/pull/719","diff_url":"https://github.com/rsksmart/rskj/pull/719.diff","patch_url":"https://github.com/rsksmart/rskj/pull/719.patch","issue_url":"https://api.github.com/repos/rsksmart/rskj/issues/719","number":719,"state":"open","locked":false,"title":"Performance improvements on Trie handling","user":{"login":"diega","id":79943,"node_id":"MDQ6VXNlcjc5OTQz","avatar_url":"https://avatars1.githubusercontent.com/u/79943?v=4","gravatar_id":"","url":"https://api.github.com/users/diega","html_url":"https://github.com/diega","followers_url":"https://api.github.com/users/diega/followers","following_url":"https://api.github.com/users/diega/following{/other_user}","gists_url":"https://api.github.com/users/diega/gists{/gist_id}","starred_url":"https://api.github.com/users/diega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diega/subscriptions","organizations_url":"https://api.github.com/users/diega/orgs","repos_url":"https://api.github.com/users/diega/repos","events_url":"https://api.github.com/users/diega/events{/privacy}","received_events_url":"https://api.github.com/users/diega/received_events","type":"User","site_admin":false},"body":"A refactor for splitting the Trie and its underlying store is planned but not tackled by this PR. Having that in mind, I don't think integrating this changes should make that task harder","created_at":"2018-12-07T16:03:42Z","updated_at":"2018-12-13T17:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6df7695abd4fcc93fbf5b6c5429282e2cd7a020","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lsebrie","id":6642445,"node_id":"MDQ6VXNlcjY2NDI0NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6642445?v=4","gravatar_id":"","url":"https://api.github.com/users/lsebrie","html_url":"https://github.com/lsebrie","followers_url":"https://api.github.com/users/lsebrie/followers","following_url":"https://api.github.com/users/lsebrie/following{/other_user}","gists_url":"https://api.github.com/users/lsebrie/gists{/gist_id}","starred_url":"https://api.github.com/users/lsebrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsebrie/subscriptions","organizations_url":"https://api.github.com/users/lsebrie/orgs","repos_url":"https://api.github.com/users/lsebrie/repos","events_url":"https://api.github.com/users/lsebrie/events{/privacy}","received_events_url":"https://api.github.com/users/lsebrie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsksmart/rskj/pulls/719/commits","review_comments_url":"https://api.github.com/repos/rsksmart/rskj/pulls/719/comments","review_comment_url":"https://api.github.com/repos/rsksmart/rskj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsksmart/rskj/issues/719/comments","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/4ab235a265b5627979f945f2d412987a7e46ea07","head":{"label":"rsksmart:perf_fixes","ref":"perf_fixes","sha":"4ab235a265b5627979f945f2d412987a7e46ea07","user":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"repo":{"id":91470090,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ3MDA5MA==","name":"rskj","full_name":"rsksmart/rskj","private":false,"owner":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rsksmart/rskj","description":"RSKj is a Java implementation of the RSK protocol.","fork":false,"url":"https://api.github.com/repos/rsksmart/rskj","forks_url":"https://api.github.com/repos/rsksmart/rskj/forks","keys_url":"https://api.github.com/repos/rsksmart/rskj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsksmart/rskj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsksmart/rskj/teams","hooks_url":"https://api.github.com/repos/rsksmart/rskj/hooks","issue_events_url":"https://api.github.com/repos/rsksmart/rskj/issues/events{/number}","events_url":"https://api.github.com/repos/rsksmart/rskj/events","assignees_url":"https://api.github.com/repos/rsksmart/rskj/assignees{/user}","branches_url":"https://api.github.com/repos/rsksmart/rskj/branches{/branch}","tags_url":"https://api.github.com/repos/rsksmart/rskj/tags","blobs_url":"https://api.github.com/repos/rsksmart/rskj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsksmart/rskj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsksmart/rskj/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsksmart/rskj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/{sha}","languages_url":"https://api.github.com/repos/rsksmart/rskj/languages","stargazers_url":"https://api.github.com/repos/rsksmart/rskj/stargazers","contributors_url":"https://api.github.com/repos/rsksmart/rskj/contributors","subscribers_url":"https://api.github.com/repos/rsksmart/rskj/subscribers","subscription_url":"https://api.github.com/repos/rsksmart/rskj/subscription","commits_url":"https://api.github.com/repos/rsksmart/rskj/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsksmart/rskj/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsksmart/rskj/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsksmart/rskj/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsksmart/rskj/contents/{+path}","compare_url":"https://api.github.com/repos/rsksmart/rskj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsksmart/rskj/merges","archive_url":"https://api.github.com/repos/rsksmart/rskj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsksmart/rskj/downloads","issues_url":"https://api.github.com/repos/rsksmart/rskj/issues{/number}","pulls_url":"https://api.github.com/repos/rsksmart/rskj/pulls{/number}","milestones_url":"https://api.github.com/repos/rsksmart/rskj/milestones{/number}","notifications_url":"https://api.github.com/repos/rsksmart/rskj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsksmart/rskj/labels{/name}","releases_url":"https://api.github.com/repos/rsksmart/rskj/releases{/id}","deployments_url":"https://api.github.com/repos/rsksmart/rskj/deployments","created_at":"2017-05-16T14:47:56Z","updated_at":"2018-12-13T14:23:35Z","pushed_at":"2018-12-13T15:05:01Z","git_url":"git://github.com/rsksmart/rskj.git","ssh_url":"git@github.com:rsksmart/rskj.git","clone_url":"https://github.com/rsksmart/rskj.git","svn_url":"https://github.com/rsksmart/rskj","homepage":null,"size":59819,"stargazers_count":532,"watchers_count":532,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":125,"open_issues":116,"watchers":532,"default_branch":"master"}},"base":{"label":"rsksmart:master","ref":"master","sha":"f48ebe73ecbe5e90df1dbf16a7faf62ff0084b9a","user":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"repo":{"id":91470090,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ3MDA5MA==","name":"rskj","full_name":"rsksmart/rskj","private":false,"owner":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rsksmart/rskj","description":"RSKj is a Java implementation of the RSK protocol.","fork":false,"url":"https://api.github.com/repos/rsksmart/rskj","forks_url":"https://api.github.com/repos/rsksmart/rskj/forks","keys_url":"https://api.github.com/repos/rsksmart/rskj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsksmart/rskj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsksmart/rskj/teams","hooks_url":"https://api.github.com/repos/rsksmart/rskj/hooks","issue_events_url":"https://api.github.com/repos/rsksmart/rskj/issues/events{/number}","events_url":"https://api.github.com/repos/rsksmart/rskj/events","assignees_url":"https://api.github.com/repos/rsksmart/rskj/assignees{/user}","branches_url":"https://api.github.com/repos/rsksmart/rskj/branches{/branch}","tags_url":"https://api.github.com/repos/rsksmart/rskj/tags","blobs_url":"https://api.github.com/repos/rsksmart/rskj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsksmart/rskj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsksmart/rskj/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsksmart/rskj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/{sha}","languages_url":"https://api.github.com/repos/rsksmart/rskj/languages","stargazers_url":"https://api.github.com/repos/rsksmart/rskj/stargazers","contributors_url":"https://api.github.com/repos/rsksmart/rskj/contributors","subscribers_url":"https://api.github.com/repos/rsksmart/rskj/subscribers","subscription_url":"https://api.github.com/repos/rsksmart/rskj/subscription","commits_url":"https://api.github.com/repos/rsksmart/rskj/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsksmart/rskj/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsksmart/rskj/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsksmart/rskj/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsksmart/rskj/contents/{+path}","compare_url":"https://api.github.com/repos/rsksmart/rskj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsksmart/rskj/merges","archive_url":"https://api.github.com/repos/rsksmart/rskj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsksmart/rskj/downloads","issues_url":"https://api.github.com/repos/rsksmart/rskj/issues{/number}","pulls_url":"https://api.github.com/repos/rsksmart/rskj/pulls{/number}","milestones_url":"https://api.github.com/repos/rsksmart/rskj/milestones{/number}","notifications_url":"https://api.github.com/repos/rsksmart/rskj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsksmart/rskj/labels{/name}","releases_url":"https://api.github.com/repos/rsksmart/rskj/releases{/id}","deployments_url":"https://api.github.com/repos/rsksmart/rskj/deployments","created_at":"2017-05-16T14:47:56Z","updated_at":"2018-12-13T14:23:35Z","pushed_at":"2018-12-13T15:05:01Z","git_url":"git://github.com/rsksmart/rskj.git","ssh_url":"git@github.com:rsksmart/rskj.git","clone_url":"https://github.com/rsksmart/rskj.git","svn_url":"https://github.com/rsksmart/rskj","homepage":null,"size":59819,"stargazers_count":532,"watchers_count":532,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":125,"open_issues":116,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/719"},"html":{"href":"https://github.com/rsksmart/rskj/pull/719"},"issue":{"href":"https://api.github.com/repos/rsksmart/rskj/issues/719"},"comments":{"href":"https://api.github.com/repos/rsksmart/rskj/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/rsksmart/rskj/statuses/4ab235a265b5627979f945f2d412987a7e46ea07"}},"author_association":"CONTRIBUTOR"}} | {
"id": 91470090,
"name": "rsksmart/rskj",
"url": "https://api.github.com/repos/rsksmart/rskj"
} | {
"id": 1752347,
"login": "SergioDemianLerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1752347?",
"url": "https://api.github.com/users/SergioDemianLerner"
} | {
"id": 28455056,
"login": "rsksmart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28455056?",
"url": "https://api.github.com/orgs/rsksmart"
} | 2018-12-13T17:17:34 | 8749792512 | {"actor":{"display_login":"SergioDemianLerner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rsksmart/rskj/pulls/comments/203812335","pull_request_review_id":138778545,"id":203812335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzgxMjMzNQ==","diff_hunk":"@@ -70,5 +70,4 @@ public RegTestGenesisConfig() {\n public boolean areBridgeTxsFree() {\n return true;\n }\n-","path":"rskj-core/src/main/java/org/ethereum/config/blockchain/regtest/RegTestGenesisConfig.java","position":4,"original_position":4,"commit_id":"4c398aa70b0e22079447ffc4f84db2371c4e8476","original_commit_id":"4c398aa70b0e22079447ffc4f84db2371c4e8476","user":{"login":"pmprete","id":3655076,"node_id":"MDQ6VXNlcjM2NTUwNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3655076?v=4","gravatar_id":"","url":"https://api.github.com/users/pmprete","html_url":"https://github.com/pmprete","followers_url":"https://api.github.com/users/pmprete/followers","following_url":"https://api.github.com/users/pmprete/following{/other_user}","gists_url":"https://api.github.com/users/pmprete/gists{/gist_id}","starred_url":"https://api.github.com/users/pmprete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmprete/subscriptions","organizations_url":"https://api.github.com/users/pmprete/orgs","repos_url":"https://api.github.com/users/pmprete/repos","events_url":"https://api.github.com/users/pmprete/events{/privacy}","received_events_url":"https://api.github.com/users/pmprete/received_events","type":"User","site_admin":false},"body":"Regtest doesn't need this?\r\n```\r\n@Override\r\n+ public boolean isRskip85() {\r\n+ return true;\r\n+ }\r\n```","created_at":"2018-07-19T17:37:48Z","updated_at":"2018-07-19T17:38:00Z","html_url":"https://github.com/rsksmart/rskj/pull/611#discussion_r203812335","pull_request_url":"https://api.github.com/repos/rsksmart/rskj/pulls/611","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/comments/203812335"},"html":{"href":"https://github.com/rsksmart/rskj/pull/611#discussion_r203812335"},"pull_request":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/611"}}},"pull_request":{"url":"https://api.github.com/repos/rsksmart/rskj/pulls/611","id":201025574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDI1NTc0","html_url":"https://github.com/rsksmart/rskj/pull/611","diff_url":"https://github.com/rsksmart/rskj/pull/611.diff","patch_url":"https://github.com/rsksmart/rskj/pull/611.patch","issue_url":"https://api.github.com/repos/rsksmart/rskj/issues/611","number":611,"state":"open","locked":false,"title":"Remasc improvements","user":{"login":"lsebrie","id":6642445,"node_id":"MDQ6VXNlcjY2NDI0NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/6642445?v=4","gravatar_id":"","url":"https://api.github.com/users/lsebrie","html_url":"https://github.com/lsebrie","followers_url":"https://api.github.com/users/lsebrie/followers","following_url":"https://api.github.com/users/lsebrie/following{/other_user}","gists_url":"https://api.github.com/users/lsebrie/gists{/gist_id}","starred_url":"https://api.github.com/users/lsebrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsebrie/subscriptions","organizations_url":"https://api.github.com/users/lsebrie/orgs","repos_url":"https://api.github.com/users/lsebrie/repos","events_url":"https://api.github.com/users/lsebrie/events{/privacy}","received_events_url":"https://api.github.com/users/lsebrie/received_events","type":"User","site_admin":false},"body":"Changes are introduced to Remasc to enhance performance and reduce disk usage\r\n\r\n- now there is a minimum limit for payments, below the value the fees are not distributed\r\n- block information to process remasc is now obtained from blockStore instead of remasc storage\r\n- new tests added to check this behaviors","created_at":"2018-07-12T14:43:49Z","updated_at":"2018-07-19T17:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e383a7b995dbfce15f45177488ff68887bb85dae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717254728,"node_id":"MDU6TGFiZWw3MTcyNTQ3Mjg=","url":"https://api.github.com/repos/rsksmart/rskj/labels/network-upgrade%20%F0%9F%8C%B1","name":"network-upgrade 🌱","color":"ff0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rsksmart/rskj/pulls/611/commits","review_comments_url":"https://api.github.com/repos/rsksmart/rskj/pulls/611/comments","review_comment_url":"https://api.github.com/repos/rsksmart/rskj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsksmart/rskj/issues/611/comments","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/4c398aa70b0e22079447ffc4f84db2371c4e8476","head":{"label":"rsksmart:remasc_improvements","ref":"remasc_improvements","sha":"4c398aa70b0e22079447ffc4f84db2371c4e8476","user":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"repo":{"id":91470090,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ3MDA5MA==","name":"rskj","full_name":"rsksmart/rskj","owner":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rsksmart/rskj","description":"RSKj is a Java implementation of the RSK protocol.","fork":false,"url":"https://api.github.com/repos/rsksmart/rskj","forks_url":"https://api.github.com/repos/rsksmart/rskj/forks","keys_url":"https://api.github.com/repos/rsksmart/rskj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsksmart/rskj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsksmart/rskj/teams","hooks_url":"https://api.github.com/repos/rsksmart/rskj/hooks","issue_events_url":"https://api.github.com/repos/rsksmart/rskj/issues/events{/number}","events_url":"https://api.github.com/repos/rsksmart/rskj/events","assignees_url":"https://api.github.com/repos/rsksmart/rskj/assignees{/user}","branches_url":"https://api.github.com/repos/rsksmart/rskj/branches{/branch}","tags_url":"https://api.github.com/repos/rsksmart/rskj/tags","blobs_url":"https://api.github.com/repos/rsksmart/rskj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsksmart/rskj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsksmart/rskj/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsksmart/rskj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/{sha}","languages_url":"https://api.github.com/repos/rsksmart/rskj/languages","stargazers_url":"https://api.github.com/repos/rsksmart/rskj/stargazers","contributors_url":"https://api.github.com/repos/rsksmart/rskj/contributors","subscribers_url":"https://api.github.com/repos/rsksmart/rskj/subscribers","subscription_url":"https://api.github.com/repos/rsksmart/rskj/subscription","commits_url":"https://api.github.com/repos/rsksmart/rskj/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsksmart/rskj/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsksmart/rskj/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsksmart/rskj/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsksmart/rskj/contents/{+path}","compare_url":"https://api.github.com/repos/rsksmart/rskj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsksmart/rskj/merges","archive_url":"https://api.github.com/repos/rsksmart/rskj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsksmart/rskj/downloads","issues_url":"https://api.github.com/repos/rsksmart/rskj/issues{/number}","pulls_url":"https://api.github.com/repos/rsksmart/rskj/pulls{/number}","milestones_url":"https://api.github.com/repos/rsksmart/rskj/milestones{/number}","notifications_url":"https://api.github.com/repos/rsksmart/rskj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsksmart/rskj/labels{/name}","releases_url":"https://api.github.com/repos/rsksmart/rskj/releases{/id}","deployments_url":"https://api.github.com/repos/rsksmart/rskj/deployments","created_at":"2017-05-16T14:47:56Z","updated_at":"2018-07-19T13:41:37Z","pushed_at":"2018-07-19T16:11:54Z","git_url":"git://github.com/rsksmart/rskj.git","ssh_url":"git@github.com:rsksmart/rskj.git","clone_url":"https://github.com/rsksmart/rskj.git","svn_url":"https://github.com/rsksmart/rskj","homepage":null,"size":26485,"stargazers_count":464,"watchers_count":464,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":105,"open_issues":119,"watchers":464,"default_branch":"master"}},"base":{"label":"rsksmart:0.5.0","ref":"0.5.0","sha":"d1d99623ac3e789ebb6bbdb7dacc1f2aea6ccd36","user":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"repo":{"id":91470090,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQ3MDA5MA==","name":"rskj","full_name":"rsksmart/rskj","owner":{"login":"rsksmart","id":28455056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDU1MDU2","avatar_url":"https://avatars0.githubusercontent.com/u/28455056?v=4","gravatar_id":"","url":"https://api.github.com/users/rsksmart","html_url":"https://github.com/rsksmart","followers_url":"https://api.github.com/users/rsksmart/followers","following_url":"https://api.github.com/users/rsksmart/following{/other_user}","gists_url":"https://api.github.com/users/rsksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/rsksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsksmart/subscriptions","organizations_url":"https://api.github.com/users/rsksmart/orgs","repos_url":"https://api.github.com/users/rsksmart/repos","events_url":"https://api.github.com/users/rsksmart/events{/privacy}","received_events_url":"https://api.github.com/users/rsksmart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rsksmart/rskj","description":"RSKj is a Java implementation of the RSK protocol.","fork":false,"url":"https://api.github.com/repos/rsksmart/rskj","forks_url":"https://api.github.com/repos/rsksmart/rskj/forks","keys_url":"https://api.github.com/repos/rsksmart/rskj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsksmart/rskj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsksmart/rskj/teams","hooks_url":"https://api.github.com/repos/rsksmart/rskj/hooks","issue_events_url":"https://api.github.com/repos/rsksmart/rskj/issues/events{/number}","events_url":"https://api.github.com/repos/rsksmart/rskj/events","assignees_url":"https://api.github.com/repos/rsksmart/rskj/assignees{/user}","branches_url":"https://api.github.com/repos/rsksmart/rskj/branches{/branch}","tags_url":"https://api.github.com/repos/rsksmart/rskj/tags","blobs_url":"https://api.github.com/repos/rsksmart/rskj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsksmart/rskj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsksmart/rskj/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsksmart/rskj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsksmart/rskj/statuses/{sha}","languages_url":"https://api.github.com/repos/rsksmart/rskj/languages","stargazers_url":"https://api.github.com/repos/rsksmart/rskj/stargazers","contributors_url":"https://api.github.com/repos/rsksmart/rskj/contributors","subscribers_url":"https://api.github.com/repos/rsksmart/rskj/subscribers","subscription_url":"https://api.github.com/repos/rsksmart/rskj/subscription","commits_url":"https://api.github.com/repos/rsksmart/rskj/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsksmart/rskj/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsksmart/rskj/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsksmart/rskj/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsksmart/rskj/contents/{+path}","compare_url":"https://api.github.com/repos/rsksmart/rskj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsksmart/rskj/merges","archive_url":"https://api.github.com/repos/rsksmart/rskj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsksmart/rskj/downloads","issues_url":"https://api.github.com/repos/rsksmart/rskj/issues{/number}","pulls_url":"https://api.github.com/repos/rsksmart/rskj/pulls{/number}","milestones_url":"https://api.github.com/repos/rsksmart/rskj/milestones{/number}","notifications_url":"https://api.github.com/repos/rsksmart/rskj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsksmart/rskj/labels{/name}","releases_url":"https://api.github.com/repos/rsksmart/rskj/releases{/id}","deployments_url":"https://api.github.com/repos/rsksmart/rskj/deployments","created_at":"2017-05-16T14:47:56Z","updated_at":"2018-07-19T13:41:37Z","pushed_at":"2018-07-19T16:11:54Z","git_url":"git://github.com/rsksmart/rskj.git","ssh_url":"git@github.com:rsksmart/rskj.git","clone_url":"https://github.com/rsksmart/rskj.git","svn_url":"https://github.com/rsksmart/rskj","homepage":null,"size":26485,"stargazers_count":464,"watchers_count":464,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":119,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":105,"open_issues":119,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/611"},"html":{"href":"https://github.com/rsksmart/rskj/pull/611"},"issue":{"href":"https://api.github.com/repos/rsksmart/rskj/issues/611"},"comments":{"href":"https://api.github.com/repos/rsksmart/rskj/issues/611/comments"},"review_comments":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/611/comments"},"review_comment":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsksmart/rskj/pulls/611/commits"},"statuses":{"href":"https://api.github.com/repos/rsksmart/rskj/statuses/4c398aa70b0e22079447ffc4f84db2371c4e8476"}},"author_association":"CONTRIBUTOR"}} | {
"id": 91470090,
"name": "rsksmart/rskj",
"url": "https://api.github.com/repos/rsksmart/rskj"
} | {
"id": 3655076,
"login": "pmprete",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3655076?",
"url": "https://api.github.com/users/pmprete"
} | {
"id": 28455056,
"login": "rsksmart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28455056?",
"url": "https://api.github.com/orgs/rsksmart"
} | 2018-07-19T17:37:48 | 7990623889 | {"actor":{"display_login":"pmprete"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/comments/168970744","pull_request_review_id":97421549,"id":168970744,"diff_hunk":"@@ -67,7 +68,11 @@ static char kbsyspath[DEV_MAX][FILENAME_MAX];\n ///\n int os_usbsend(usbdevice* kb, const uchar* out_msg, int is_recv, const char* file, int line) {\n int res;\n- if ((kb->fwversion >= 0x120 || IS_V2_OVERRIDE(kb)) && !is_recv){\n+ // If we need to read a response, lock the mutex so that os_usbrecv() waits for the main thread.\n+ if(is_recv)\n+ pthread_mutex_lock(&kb->interruptmutex);","path":"src/ckb-daemon/usb_linux.c","position":15,"original_position":15,"commit_id":"dcdf58a216163f1ef4dc553f6112c33af60b4076","original_commit_id":"dcdf58a216163f1ef4dc553f6112c33af60b4076","user":{"login":"light2yellow","id":10786469,"avatar_url":"https://avatars2.githubusercontent.com/u/10786469?v=4","gravatar_id":"","url":"https://api.github.com/users/light2yellow","html_url":"https://github.com/light2yellow","followers_url":"https://api.github.com/users/light2yellow/followers","following_url":"https://api.github.com/users/light2yellow/following{/other_user}","gists_url":"https://api.github.com/users/light2yellow/gists{/gist_id}","starred_url":"https://api.github.com/users/light2yellow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/light2yellow/subscriptions","organizations_url":"https://api.github.com/users/light2yellow/orgs","repos_url":"https://api.github.com/users/light2yellow/repos","events_url":"https://api.github.com/users/light2yellow/events{/privacy}","received_events_url":"https://api.github.com/users/light2yellow/received_events","type":"User","site_admin":false},"body":"... here, and in other pthread_* functions, no point in commenting under every call.","created_at":"2018-02-18T23:36:21Z","updated_at":"2018-02-18T23:36:21Z","html_url":"https://github.com/ckb-next/ckb-next/pull/98#discussion_r168970744","pull_request_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/comments/168970744"},"html":{"href":"https://github.com/ckb-next/ckb-next/pull/98#discussion_r168970744"},"pull_request":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98"}},"in_reply_to_id":168970562},"pull_request":{"url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98","id":169733083,"html_url":"https://github.com/ckb-next/ckb-next/pull/98","diff_url":"https://github.com/ckb-next/ckb-next/pull/98.diff","patch_url":"https://github.com/ckb-next/ckb-next/pull/98.patch","issue_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/98","number":98,"state":"open","locked":false,"title":"Use URB Interrupts for all non-HID transfers","user":{"login":"tatokis","id":6003656,"avatar_url":"https://avatars2.githubusercontent.com/u/6003656?v=4","gravatar_id":"","url":"https://api.github.com/users/tatokis","html_url":"https://github.com/tatokis","followers_url":"https://api.github.com/users/tatokis/followers","following_url":"https://api.github.com/users/tatokis/following{/other_user}","gists_url":"https://api.github.com/users/tatokis/gists{/gist_id}","starred_url":"https://api.github.com/users/tatokis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatokis/subscriptions","organizations_url":"https://api.github.com/users/tatokis/orgs","repos_url":"https://api.github.com/users/tatokis/repos","events_url":"https://api.github.com/users/tatokis/events{/privacy}","received_events_url":"https://api.github.com/users/tatokis/received_events","type":"User","site_admin":false},"body":"Closes #51, which contains a really nice summary of the whole problem.\r\n\r\nA mutex and a buffer are added to the usbdevice struct.\r\n\r\nWhen usbsend is called with the is_recv flag, the mutex is locked.\r\nThe main thread listens for packets starting with 0x0e, copies them to the buffer and unlocks the mutex.\r\nusbrecv waits for the mutex to be unlocked and then copies the buffer from usbdevice.\r\n\r\nThe above is all ignored, falling back to the old behaviour, when fwversion is lower than 1.3 which works only with URB Controls.\r\n\r\nIdeally, the comments for the functions should be rewritten before merging this.","created_at":"2018-02-16T21:45:37Z","updated_at":"2018-02-18T23:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26fc20ca3b13ad447e1e53746dee1fabd3910090","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98/commits","review_comments_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98/comments","review_comment_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/98/comments","statuses_url":"https://api.github.com/repos/ckb-next/ckb-next/statuses/dcdf58a216163f1ef4dc553f6112c33af60b4076","head":{"label":"ckb-next:interrupt-read-fix","ref":"interrupt-read-fix","sha":"dcdf58a216163f1ef4dc553f6112c33af60b4076","user":{"login":"ckb-next","id":28515582,"avatar_url":"https://avatars3.githubusercontent.com/u/28515582?v=4","gravatar_id":"","url":"https://api.github.com/users/ckb-next","html_url":"https://github.com/ckb-next","followers_url":"https://api.github.com/users/ckb-next/followers","following_url":"https://api.github.com/users/ckb-next/following{/other_user}","gists_url":"https://api.github.com/users/ckb-next/gists{/gist_id}","starred_url":"https://api.github.com/users/ckb-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckb-next/subscriptions","organizations_url":"https://api.github.com/users/ckb-next/orgs","repos_url":"https://api.github.com/users/ckb-next/repos","events_url":"https://api.github.com/users/ckb-next/events{/privacy}","received_events_url":"https://api.github.com/users/ckb-next/received_events","type":"Organization","site_admin":false},"repo":{"id":118226152,"name":"ckb-next","full_name":"ckb-next/ckb-next","owner":{"login":"ckb-next","id":28515582,"avatar_url":"https://avatars3.githubusercontent.com/u/28515582?v=4","gravatar_id":"","url":"https://api.github.com/users/ckb-next","html_url":"https://github.com/ckb-next","followers_url":"https://api.github.com/users/ckb-next/followers","following_url":"https://api.github.com/users/ckb-next/following{/other_user}","gists_url":"https://api.github.com/users/ckb-next/gists{/gist_id}","starred_url":"https://api.github.com/users/ckb-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckb-next/subscriptions","organizations_url":"https://api.github.com/users/ckb-next/orgs","repos_url":"https://api.github.com/users/ckb-next/repos","events_url":"https://api.github.com/users/ckb-next/events{/privacy}","received_events_url":"https://api.github.com/users/ckb-next/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckb-next/ckb-next","description":"RGB Driver for Linux and OS X","fork":false,"url":"https://api.github.com/repos/ckb-next/ckb-next","forks_url":"https://api.github.com/repos/ckb-next/ckb-next/forks","keys_url":"https://api.github.com/repos/ckb-next/ckb-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckb-next/ckb-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckb-next/ckb-next/teams","hooks_url":"https://api.github.com/repos/ckb-next/ckb-next/hooks","issue_events_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/events{/number}","events_url":"https://api.github.com/repos/ckb-next/ckb-next/events","assignees_url":"https://api.github.com/repos/ckb-next/ckb-next/assignees{/user}","branches_url":"https://api.github.com/repos/ckb-next/ckb-next/branches{/branch}","tags_url":"https://api.github.com/repos/ckb-next/ckb-next/tags","blobs_url":"https://api.github.com/repos/ckb-next/ckb-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckb-next/ckb-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckb-next/ckb-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckb-next/ckb-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckb-next/ckb-next/statuses/{sha}","languages_url":"https://api.github.com/repos/ckb-next/ckb-next/languages","stargazers_url":"https://api.github.com/repos/ckb-next/ckb-next/stargazers","contributors_url":"https://api.github.com/repos/ckb-next/ckb-next/contributors","subscribers_url":"https://api.github.com/repos/ckb-next/ckb-next/subscribers","subscription_url":"https://api.github.com/repos/ckb-next/ckb-next/subscription","commits_url":"https://api.github.com/repos/ckb-next/ckb-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckb-next/ckb-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckb-next/ckb-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckb-next/ckb-next/contents/{+path}","compare_url":"https://api.github.com/repos/ckb-next/ckb-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckb-next/ckb-next/merges","archive_url":"https://api.github.com/repos/ckb-next/ckb-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckb-next/ckb-next/downloads","issues_url":"https://api.github.com/repos/ckb-next/ckb-next/issues{/number}","pulls_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls{/number}","milestones_url":"https://api.github.com/repos/ckb-next/ckb-next/milestones{/number}","notifications_url":"https://api.github.com/repos/ckb-next/ckb-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckb-next/ckb-next/labels{/name}","releases_url":"https://api.github.com/repos/ckb-next/ckb-next/releases{/id}","deployments_url":"https://api.github.com/repos/ckb-next/ckb-next/deployments","created_at":"2018-01-20T08:53:57Z","updated_at":"2018-02-16T23:37:32Z","pushed_at":"2018-02-18T11:48:33Z","git_url":"git://github.com/ckb-next/ckb-next.git","ssh_url":"git@github.com:ckb-next/ckb-next.git","clone_url":"https://github.com/ckb-next/ckb-next.git","svn_url":"https://github.com/ckb-next/ckb-next","homepage":null,"size":3966,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":15,"open_issues":64,"watchers":124,"default_branch":"master"}},"base":{"label":"ckb-next:master","ref":"master","sha":"d79bf1880a5b4f6af60395a33d69e9435374b682","user":{"login":"ckb-next","id":28515582,"avatar_url":"https://avatars3.githubusercontent.com/u/28515582?v=4","gravatar_id":"","url":"https://api.github.com/users/ckb-next","html_url":"https://github.com/ckb-next","followers_url":"https://api.github.com/users/ckb-next/followers","following_url":"https://api.github.com/users/ckb-next/following{/other_user}","gists_url":"https://api.github.com/users/ckb-next/gists{/gist_id}","starred_url":"https://api.github.com/users/ckb-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckb-next/subscriptions","organizations_url":"https://api.github.com/users/ckb-next/orgs","repos_url":"https://api.github.com/users/ckb-next/repos","events_url":"https://api.github.com/users/ckb-next/events{/privacy}","received_events_url":"https://api.github.com/users/ckb-next/received_events","type":"Organization","site_admin":false},"repo":{"id":118226152,"name":"ckb-next","full_name":"ckb-next/ckb-next","owner":{"login":"ckb-next","id":28515582,"avatar_url":"https://avatars3.githubusercontent.com/u/28515582?v=4","gravatar_id":"","url":"https://api.github.com/users/ckb-next","html_url":"https://github.com/ckb-next","followers_url":"https://api.github.com/users/ckb-next/followers","following_url":"https://api.github.com/users/ckb-next/following{/other_user}","gists_url":"https://api.github.com/users/ckb-next/gists{/gist_id}","starred_url":"https://api.github.com/users/ckb-next/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckb-next/subscriptions","organizations_url":"https://api.github.com/users/ckb-next/orgs","repos_url":"https://api.github.com/users/ckb-next/repos","events_url":"https://api.github.com/users/ckb-next/events{/privacy}","received_events_url":"https://api.github.com/users/ckb-next/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckb-next/ckb-next","description":"RGB Driver for Linux and OS X","fork":false,"url":"https://api.github.com/repos/ckb-next/ckb-next","forks_url":"https://api.github.com/repos/ckb-next/ckb-next/forks","keys_url":"https://api.github.com/repos/ckb-next/ckb-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckb-next/ckb-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckb-next/ckb-next/teams","hooks_url":"https://api.github.com/repos/ckb-next/ckb-next/hooks","issue_events_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/events{/number}","events_url":"https://api.github.com/repos/ckb-next/ckb-next/events","assignees_url":"https://api.github.com/repos/ckb-next/ckb-next/assignees{/user}","branches_url":"https://api.github.com/repos/ckb-next/ckb-next/branches{/branch}","tags_url":"https://api.github.com/repos/ckb-next/ckb-next/tags","blobs_url":"https://api.github.com/repos/ckb-next/ckb-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckb-next/ckb-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckb-next/ckb-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckb-next/ckb-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckb-next/ckb-next/statuses/{sha}","languages_url":"https://api.github.com/repos/ckb-next/ckb-next/languages","stargazers_url":"https://api.github.com/repos/ckb-next/ckb-next/stargazers","contributors_url":"https://api.github.com/repos/ckb-next/ckb-next/contributors","subscribers_url":"https://api.github.com/repos/ckb-next/ckb-next/subscribers","subscription_url":"https://api.github.com/repos/ckb-next/ckb-next/subscription","commits_url":"https://api.github.com/repos/ckb-next/ckb-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckb-next/ckb-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckb-next/ckb-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckb-next/ckb-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckb-next/ckb-next/contents/{+path}","compare_url":"https://api.github.com/repos/ckb-next/ckb-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckb-next/ckb-next/merges","archive_url":"https://api.github.com/repos/ckb-next/ckb-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckb-next/ckb-next/downloads","issues_url":"https://api.github.com/repos/ckb-next/ckb-next/issues{/number}","pulls_url":"https://api.github.com/repos/ckb-next/ckb-next/pulls{/number}","milestones_url":"https://api.github.com/repos/ckb-next/ckb-next/milestones{/number}","notifications_url":"https://api.github.com/repos/ckb-next/ckb-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckb-next/ckb-next/labels{/name}","releases_url":"https://api.github.com/repos/ckb-next/ckb-next/releases{/id}","deployments_url":"https://api.github.com/repos/ckb-next/ckb-next/deployments","created_at":"2018-01-20T08:53:57Z","updated_at":"2018-02-16T23:37:32Z","pushed_at":"2018-02-18T11:48:33Z","git_url":"git://github.com/ckb-next/ckb-next.git","ssh_url":"git@github.com:ckb-next/ckb-next.git","clone_url":"https://github.com/ckb-next/ckb-next.git","svn_url":"https://github.com/ckb-next/ckb-next","homepage":null,"size":3966,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":15,"open_issues":64,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98"},"html":{"href":"https://github.com/ckb-next/ckb-next/pull/98"},"issue":{"href":"https://api.github.com/repos/ckb-next/ckb-next/issues/98"},"comments":{"href":"https://api.github.com/repos/ckb-next/ckb-next/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckb-next/ckb-next/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/ckb-next/ckb-next/statuses/dcdf58a216163f1ef4dc553f6112c33af60b4076"}},"author_association":"OWNER"}} | {
"id": 118226152,
"name": "ckb-next/ckb-next",
"url": "https://api.github.com/repos/ckb-next/ckb-next"
} | {
"id": 10786469,
"login": "light2yellow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10786469?",
"url": "https://api.github.com/users/light2yellow"
} | {
"id": 28515582,
"login": "ckb-next",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28515582?",
"url": "https://api.github.com/orgs/ckb-next"
} | 2018-02-18T23:36:21 | 7261726744 | {"actor":{"display_login":"light2yellow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/comments/201694063","pull_request_review_id":136244448,"id":201694063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY5NDA2Mw==","diff_hunk":"@@ -46,4 +46,4 @@ deploy:\n notifications:\n on_success: change\n on_failure: always\n- on_start: never\n+ on_start: never","path":".travis.yml","position":5,"original_position":5,"commit_id":"3fa5a1eaadd5bd00dd56261dbf7ad6793daace89","original_commit_id":"b3e1b062fbc6ee4020380bce11d0fb8b4f98596a","user":{"login":"marcdumais-work","id":25749063,"node_id":"MDQ6VXNlcjI1NzQ5MDYz","avatar_url":"https://avatars2.githubusercontent.com/u/25749063?v=4","gravatar_id":"","url":"https://api.github.com/users/marcdumais-work","html_url":"https://github.com/marcdumais-work","followers_url":"https://api.github.com/users/marcdumais-work/followers","following_url":"https://api.github.com/users/marcdumais-work/following{/other_user}","gists_url":"https://api.github.com/users/marcdumais-work/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdumais-work/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdumais-work/subscriptions","organizations_url":"https://api.github.com/users/marcdumais-work/orgs","repos_url":"https://api.github.com/users/marcdumais-work/repos","events_url":"https://api.github.com/users/marcdumais-work/events{/privacy}","received_events_url":"https://api.github.com/users/marcdumais-work/received_events","type":"User","site_admin":false},"body":"ok. ATM in your PR the trailing newline that used to be there is removed. I think we should have a newline at the end of text files. My comment was to add it back. See here:\r\n\r\nhttps://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline#729795","created_at":"2018-07-11T13:43:44Z","updated_at":"2018-07-11T13:43:44Z","html_url":"https://github.com/theia-ide/theia-apps/pull/56#discussion_r201694063","pull_request_url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/comments/201694063"},"html":{"href":"https://github.com/theia-ide/theia-apps/pull/56#discussion_r201694063"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56"}},"in_reply_to_id":201265407},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56","id":199925922,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTI1OTIy","html_url":"https://github.com/theia-ide/theia-apps/pull/56","diff_url":"https://github.com/theia-ide/theia-apps/pull/56.diff","patch_url":"https://github.com/theia-ide/theia-apps/pull/56.patch","issue_url":"https://api.github.com/repos/theia-ide/theia-apps/issues/56","number":56,"state":"open","locked":false,"title":"Theia IDE on user mode","user":{"login":"sr229","id":14976516,"node_id":"MDQ6VXNlcjE0OTc2NTE2","avatar_url":"https://avatars3.githubusercontent.com/u/14976516?v=4","gravatar_id":"","url":"https://api.github.com/users/sr229","html_url":"https://github.com/sr229","followers_url":"https://api.github.com/users/sr229/followers","following_url":"https://api.github.com/users/sr229/following{/other_user}","gists_url":"https://api.github.com/users/sr229/gists{/gist_id}","starred_url":"https://api.github.com/users/sr229/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr229/subscriptions","organizations_url":"https://api.github.com/users/sr229/orgs","repos_url":"https://api.github.com/users/sr229/repos","events_url":"https://api.github.com/users/sr229/events{/privacy}","received_events_url":"https://api.github.com/users/sr229/received_events","type":"User","site_admin":false},"body":"A quick branch fix of #35 due to squashing problems.\r\n\r\nSupersedes(Closes #10) and resolves #34 \r\n\r\nNote: I can't seem to get squashing by rebase right, Maintainer edit is enabled so you guys can assist me with this","created_at":"2018-07-08T05:20:56Z","updated_at":"2018-07-11T13:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4795529d2a3603caef6d365e371ed99487faaf75","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia-apps/issues/56/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia-apps/statuses/3fa5a1eaadd5bd00dd56261dbf7ad6793daace89","head":{"label":"sr229:gen-fixes","ref":"gen-fixes","sha":"3fa5a1eaadd5bd00dd56261dbf7ad6793daace89","user":{"login":"sr229","id":14976516,"node_id":"MDQ6VXNlcjE0OTc2NTE2","avatar_url":"https://avatars3.githubusercontent.com/u/14976516?v=4","gravatar_id":"","url":"https://api.github.com/users/sr229","html_url":"https://github.com/sr229","followers_url":"https://api.github.com/users/sr229/followers","following_url":"https://api.github.com/users/sr229/following{/other_user}","gists_url":"https://api.github.com/users/sr229/gists{/gist_id}","starred_url":"https://api.github.com/users/sr229/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr229/subscriptions","organizations_url":"https://api.github.com/users/sr229/orgs","repos_url":"https://api.github.com/users/sr229/repos","events_url":"https://api.github.com/users/sr229/events{/privacy}","received_events_url":"https://api.github.com/users/sr229/received_events","type":"User","site_admin":false},"repo":{"id":127595723,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc1OTU3MjM=","name":"theia-apps","full_name":"sr229/theia-apps","owner":{"login":"sr229","id":14976516,"node_id":"MDQ6VXNlcjE0OTc2NTE2","avatar_url":"https://avatars3.githubusercontent.com/u/14976516?v=4","gravatar_id":"","url":"https://api.github.com/users/sr229","html_url":"https://github.com/sr229","followers_url":"https://api.github.com/users/sr229/followers","following_url":"https://api.github.com/users/sr229/following{/other_user}","gists_url":"https://api.github.com/users/sr229/gists{/gist_id}","starred_url":"https://api.github.com/users/sr229/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sr229/subscriptions","organizations_url":"https://api.github.com/users/sr229/orgs","repos_url":"https://api.github.com/users/sr229/repos","events_url":"https://api.github.com/users/sr229/events{/privacy}","received_events_url":"https://api.github.com/users/sr229/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sr229/theia-apps","description":"Theia applications - docker images and desktop distributions","fork":true,"url":"https://api.github.com/repos/sr229/theia-apps","forks_url":"https://api.github.com/repos/sr229/theia-apps/forks","keys_url":"https://api.github.com/repos/sr229/theia-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sr229/theia-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sr229/theia-apps/teams","hooks_url":"https://api.github.com/repos/sr229/theia-apps/hooks","issue_events_url":"https://api.github.com/repos/sr229/theia-apps/issues/events{/number}","events_url":"https://api.github.com/repos/sr229/theia-apps/events","assignees_url":"https://api.github.com/repos/sr229/theia-apps/assignees{/user}","branches_url":"https://api.github.com/repos/sr229/theia-apps/branches{/branch}","tags_url":"https://api.github.com/repos/sr229/theia-apps/tags","blobs_url":"https://api.github.com/repos/sr229/theia-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sr229/theia-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sr229/theia-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/sr229/theia-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sr229/theia-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/sr229/theia-apps/languages","stargazers_url":"https://api.github.com/repos/sr229/theia-apps/stargazers","contributors_url":"https://api.github.com/repos/sr229/theia-apps/contributors","subscribers_url":"https://api.github.com/repos/sr229/theia-apps/subscribers","subscription_url":"https://api.github.com/repos/sr229/theia-apps/subscription","commits_url":"https://api.github.com/repos/sr229/theia-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/sr229/theia-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/sr229/theia-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/sr229/theia-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/sr229/theia-apps/contents/{+path}","compare_url":"https://api.github.com/repos/sr229/theia-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sr229/theia-apps/merges","archive_url":"https://api.github.com/repos/sr229/theia-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sr229/theia-apps/downloads","issues_url":"https://api.github.com/repos/sr229/theia-apps/issues{/number}","pulls_url":"https://api.github.com/repos/sr229/theia-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/sr229/theia-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/sr229/theia-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sr229/theia-apps/labels{/name}","releases_url":"https://api.github.com/repos/sr229/theia-apps/releases{/id}","deployments_url":"https://api.github.com/repos/sr229/theia-apps/deployments","created_at":"2018-04-01T04:07:42Z","updated_at":"2018-07-09T01:36:41Z","pushed_at":"2018-07-11T06:26:08Z","git_url":"git://github.com/sr229/theia-apps.git","ssh_url":"git@github.com:sr229/theia-apps.git","clone_url":"https://github.com/sr229/theia-apps.git","svn_url":"https://github.com/sr229/theia-apps","homepage":"","size":99,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"66362790c7ba62ff73a74fe0474321243ee4c400","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":110673749,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2NzM3NDk=","name":"theia-apps","full_name":"theia-ide/theia-apps","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia-apps","description":"Theia applications - docker images and desktop distributions","fork":false,"url":"https://api.github.com/repos/theia-ide/theia-apps","forks_url":"https://api.github.com/repos/theia-ide/theia-apps/forks","keys_url":"https://api.github.com/repos/theia-ide/theia-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia-apps/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia-apps/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia-apps/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia-apps/events","assignees_url":"https://api.github.com/repos/theia-ide/theia-apps/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia-apps/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia-apps/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia-apps/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia-apps/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia-apps/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia-apps/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia-apps/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia-apps/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia-apps/merges","archive_url":"https://api.github.com/repos/theia-ide/theia-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia-apps/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia-apps/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia-apps/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia-apps/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia-apps/deployments","created_at":"2017-11-14T10:08:18Z","updated_at":"2018-07-09T23:34:15Z","pushed_at":"2018-07-11T06:26:10Z","git_url":"git://github.com/theia-ide/theia-apps.git","ssh_url":"git@github.com:theia-ide/theia-apps.git","clone_url":"https://github.com/theia-ide/theia-apps.git","svn_url":"https://github.com/theia-ide/theia-apps","homepage":"","size":80,"stargazers_count":36,"watchers_count":36,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":26,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56"},"html":{"href":"https://github.com/theia-ide/theia-apps/pull/56"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia-apps/issues/56"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia-apps/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia-apps/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia-apps/statuses/3fa5a1eaadd5bd00dd56261dbf7ad6793daace89"}},"author_association":"NONE"}} | {
"id": 110673749,
"name": "theia-ide/theia-apps",
"url": "https://api.github.com/repos/theia-ide/theia-apps"
} | {
"id": 25749063,
"login": "marcdumais-work",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25749063?",
"url": "https://api.github.com/users/marcdumais-work"
} | {
"id": 28530323,
"login": "theia-ide",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28530323?",
"url": "https://api.github.com/orgs/theia-ide"
} | 2018-07-11T13:43:44 | 7950173083 | {"actor":{"display_login":"marcdumais-work"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/decentfund/kyodo/pulls/comments/235827754","pull_request_review_id":177785506,"id":235827754,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTgyNzc1NA==","diff_hunk":"@@ -2,8 +2,82 @@\n \n # Kyodo\n \n-**Kyodo**\n-Ethereum blockchain based web app, the cross-platform incentive tool for building the crypto economy for DAO based on Impression revenue model. We build Kyodo to run Decent.Fund.\n+## Installation\n+\n+This is a monorepo for Kyodo project consisting of 3 modules:\n+\n+- Kyodo web app to setup colony, sign final tips, get your balance and view tasks progress\n+- Kyodo backend to run mongodb server and tipping watch within a period\n+- Kyodo bot to run riot bot for task creation and instant tipping\n+\n+## Get started\n+\n+### Prerequisites\n+\n+- Yarn\n+- Docker\n+- Node 9.10\n+\n+### To setup monorepo packages and its dependencies\n+\n+```\n+git clone https://github.com/decentfund/kyodo.git\n+cd kyodo\n+yarn\n+```\n+\n+### Add initial distribution (optional)\n+\n+```\n+# Create initial distribution of tokens\n+# Change `deploy_parameters.json` to reflect the initial distribution you want or leave the accounts section empty.\n+cp migrations/deploy_parameters.example.json migrations/deploy_parameters.json\n+```\n+\n+\n+### Setup contracts\n+\n+```bash\n+cd packages/kyodo-contracts","path":"docs/README.md","position":42,"original_position":42,"commit_id":"a83475d93d0b7438e32d5f4d6a93dd28eebc3e4e","original_commit_id":"a83475d93d0b7438e32d5f4d6a93dd28eebc3e4e","user":{"login":"jsidorenko","id":5252494,"node_id":"MDQ6VXNlcjUyNTI0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5252494?v=4","gravatar_id":"","url":"https://api.github.com/users/jsidorenko","html_url":"https://github.com/jsidorenko","followers_url":"https://api.github.com/users/jsidorenko/followers","following_url":"https://api.github.com/users/jsidorenko/following{/other_user}","gists_url":"https://api.github.com/users/jsidorenko/gists{/gist_id}","starred_url":"https://api.github.com/users/jsidorenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsidorenko/subscriptions","organizations_url":"https://api.github.com/users/jsidorenko/orgs","repos_url":"https://api.github.com/users/jsidorenko/repos","events_url":"https://api.github.com/users/jsidorenko/events{/privacy}","received_events_url":"https://api.github.com/users/jsidorenko/received_events","type":"User","site_admin":false},"body":"What do you think about this starting [approach](https://github.com/JoinColony/colonyStarter/blob/master/package.json)? \r\nIt eliminates the need to navigate to the `packages/kyodo-contracts` folder and allows the developer to launch all the scripts from the project root","created_at":"2018-11-22T23:07:49Z","updated_at":"2018-11-22T23:07:49Z","html_url":"https://github.com/decentfund/kyodo/pull/206#discussion_r235827754","pull_request_url":"https://api.github.com/repos/decentfund/kyodo/pulls/206","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/comments/235827754"},"html":{"href":"https://github.com/decentfund/kyodo/pull/206#discussion_r235827754"},"pull_request":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/decentfund/kyodo/pulls/206","id":230827443,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODI3NDQz","html_url":"https://github.com/decentfund/kyodo/pull/206","diff_url":"https://github.com/decentfund/kyodo/pull/206.diff","patch_url":"https://github.com/decentfund/kyodo/pull/206.patch","issue_url":"https://api.github.com/repos/decentfund/kyodo/issues/206","number":206,"state":"open","locked":false,"title":"[WIP] Fixed clean install and instructions","user":{"login":"igorline","id":1465430,"node_id":"MDQ6VXNlcjE0NjU0MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1465430?v=4","gravatar_id":"","url":"https://api.github.com/users/igorline","html_url":"https://github.com/igorline","followers_url":"https://api.github.com/users/igorline/followers","following_url":"https://api.github.com/users/igorline/following{/other_user}","gists_url":"https://api.github.com/users/igorline/gists{/gist_id}","starred_url":"https://api.github.com/users/igorline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorline/subscriptions","organizations_url":"https://api.github.com/users/igorline/orgs","repos_url":"https://api.github.com/users/igorline/repos","events_url":"https://api.github.com/users/igorline/events{/privacy}","received_events_url":"https://api.github.com/users/igorline/received_events","type":"User","site_admin":false},"body":"Hey, @palevoo ! Can you verify that with current changes you are able to do a fresh setup?","created_at":"2018-11-14T13:03:30Z","updated_at":"2018-11-22T23:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88ccd5875af39d7c7c06f06f52116d562b75d4a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"palevoo","id":21197100,"node_id":"MDQ6VXNlcjIxMTk3MTAw","avatar_url":"https://avatars3.githubusercontent.com/u/21197100?v=4","gravatar_id":"","url":"https://api.github.com/users/palevoo","html_url":"https://github.com/palevoo","followers_url":"https://api.github.com/users/palevoo/followers","following_url":"https://api.github.com/users/palevoo/following{/other_user}","gists_url":"https://api.github.com/users/palevoo/gists{/gist_id}","starred_url":"https://api.github.com/users/palevoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palevoo/subscriptions","organizations_url":"https://api.github.com/users/palevoo/orgs","repos_url":"https://api.github.com/users/palevoo/repos","events_url":"https://api.github.com/users/palevoo/events{/privacy}","received_events_url":"https://api.github.com/users/palevoo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decentfund/kyodo/pulls/206/commits","review_comments_url":"https://api.github.com/repos/decentfund/kyodo/pulls/206/comments","review_comment_url":"https://api.github.com/repos/decentfund/kyodo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decentfund/kyodo/issues/206/comments","statuses_url":"https://api.github.com/repos/decentfund/kyodo/statuses/a83475d93d0b7438e32d5f4d6a93dd28eebc3e4e","head":{"label":"decentfund:fix-install-instructions","ref":"fix-install-instructions","sha":"a83475d93d0b7438e32d5f4d6a93dd28eebc3e4e","user":{"login":"decentfund","id":28684566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Njg0NTY2","avatar_url":"https://avatars1.githubusercontent.com/u/28684566?v=4","gravatar_id":"","url":"https://api.github.com/users/decentfund","html_url":"https://github.com/decentfund","followers_url":"https://api.github.com/users/decentfund/followers","following_url":"https://api.github.com/users/decentfund/following{/other_user}","gists_url":"https://api.github.com/users/decentfund/gists{/gist_id}","starred_url":"https://api.github.com/users/decentfund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentfund/subscriptions","organizations_url":"https://api.github.com/users/decentfund/orgs","repos_url":"https://api.github.com/users/decentfund/repos","events_url":"https://api.github.com/users/decentfund/events{/privacy}","received_events_url":"https://api.github.com/users/decentfund/received_events","type":"Organization","site_admin":false},"repo":{"id":137364398,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNjQzOTg=","name":"kyodo","full_name":"decentfund/kyodo","private":false,"owner":{"login":"decentfund","id":28684566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Njg0NTY2","avatar_url":"https://avatars1.githubusercontent.com/u/28684566?v=4","gravatar_id":"","url":"https://api.github.com/users/decentfund","html_url":"https://github.com/decentfund","followers_url":"https://api.github.com/users/decentfund/followers","following_url":"https://api.github.com/users/decentfund/following{/other_user}","gists_url":"https://api.github.com/users/decentfund/gists{/gist_id}","starred_url":"https://api.github.com/users/decentfund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentfund/subscriptions","organizations_url":"https://api.github.com/users/decentfund/orgs","repos_url":"https://api.github.com/users/decentfund/repos","events_url":"https://api.github.com/users/decentfund/events{/privacy}","received_events_url":"https://api.github.com/users/decentfund/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentfund/kyodo","description":null,"fork":false,"url":"https://api.github.com/repos/decentfund/kyodo","forks_url":"https://api.github.com/repos/decentfund/kyodo/forks","keys_url":"https://api.github.com/repos/decentfund/kyodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentfund/kyodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentfund/kyodo/teams","hooks_url":"https://api.github.com/repos/decentfund/kyodo/hooks","issue_events_url":"https://api.github.com/repos/decentfund/kyodo/issues/events{/number}","events_url":"https://api.github.com/repos/decentfund/kyodo/events","assignees_url":"https://api.github.com/repos/decentfund/kyodo/assignees{/user}","branches_url":"https://api.github.com/repos/decentfund/kyodo/branches{/branch}","tags_url":"https://api.github.com/repos/decentfund/kyodo/tags","blobs_url":"https://api.github.com/repos/decentfund/kyodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentfund/kyodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentfund/kyodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentfund/kyodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentfund/kyodo/statuses/{sha}","languages_url":"https://api.github.com/repos/decentfund/kyodo/languages","stargazers_url":"https://api.github.com/repos/decentfund/kyodo/stargazers","contributors_url":"https://api.github.com/repos/decentfund/kyodo/contributors","subscribers_url":"https://api.github.com/repos/decentfund/kyodo/subscribers","subscription_url":"https://api.github.com/repos/decentfund/kyodo/subscription","commits_url":"https://api.github.com/repos/decentfund/kyodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentfund/kyodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentfund/kyodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentfund/kyodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentfund/kyodo/contents/{+path}","compare_url":"https://api.github.com/repos/decentfund/kyodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentfund/kyodo/merges","archive_url":"https://api.github.com/repos/decentfund/kyodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentfund/kyodo/downloads","issues_url":"https://api.github.com/repos/decentfund/kyodo/issues{/number}","pulls_url":"https://api.github.com/repos/decentfund/kyodo/pulls{/number}","milestones_url":"https://api.github.com/repos/decentfund/kyodo/milestones{/number}","notifications_url":"https://api.github.com/repos/decentfund/kyodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentfund/kyodo/labels{/name}","releases_url":"https://api.github.com/repos/decentfund/kyodo/releases{/id}","deployments_url":"https://api.github.com/repos/decentfund/kyodo/deployments","created_at":"2018-06-14T13:50:15Z","updated_at":"2018-11-14T13:02:35Z","pushed_at":"2018-11-22T22:21:53Z","git_url":"git://github.com/decentfund/kyodo.git","ssh_url":"git@github.com:decentfund/kyodo.git","clone_url":"https://github.com/decentfund/kyodo.git","svn_url":"https://github.com/decentfund/kyodo","homepage":null,"size":958,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":46,"watchers":2,"default_branch":"master"}},"base":{"label":"decentfund:master","ref":"master","sha":"be4c02c56d83a5c727b2e4dfd70a25a27820309a","user":{"login":"decentfund","id":28684566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Njg0NTY2","avatar_url":"https://avatars1.githubusercontent.com/u/28684566?v=4","gravatar_id":"","url":"https://api.github.com/users/decentfund","html_url":"https://github.com/decentfund","followers_url":"https://api.github.com/users/decentfund/followers","following_url":"https://api.github.com/users/decentfund/following{/other_user}","gists_url":"https://api.github.com/users/decentfund/gists{/gist_id}","starred_url":"https://api.github.com/users/decentfund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentfund/subscriptions","organizations_url":"https://api.github.com/users/decentfund/orgs","repos_url":"https://api.github.com/users/decentfund/repos","events_url":"https://api.github.com/users/decentfund/events{/privacy}","received_events_url":"https://api.github.com/users/decentfund/received_events","type":"Organization","site_admin":false},"repo":{"id":137364398,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNjQzOTg=","name":"kyodo","full_name":"decentfund/kyodo","private":false,"owner":{"login":"decentfund","id":28684566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4Njg0NTY2","avatar_url":"https://avatars1.githubusercontent.com/u/28684566?v=4","gravatar_id":"","url":"https://api.github.com/users/decentfund","html_url":"https://github.com/decentfund","followers_url":"https://api.github.com/users/decentfund/followers","following_url":"https://api.github.com/users/decentfund/following{/other_user}","gists_url":"https://api.github.com/users/decentfund/gists{/gist_id}","starred_url":"https://api.github.com/users/decentfund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentfund/subscriptions","organizations_url":"https://api.github.com/users/decentfund/orgs","repos_url":"https://api.github.com/users/decentfund/repos","events_url":"https://api.github.com/users/decentfund/events{/privacy}","received_events_url":"https://api.github.com/users/decentfund/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentfund/kyodo","description":null,"fork":false,"url":"https://api.github.com/repos/decentfund/kyodo","forks_url":"https://api.github.com/repos/decentfund/kyodo/forks","keys_url":"https://api.github.com/repos/decentfund/kyodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentfund/kyodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentfund/kyodo/teams","hooks_url":"https://api.github.com/repos/decentfund/kyodo/hooks","issue_events_url":"https://api.github.com/repos/decentfund/kyodo/issues/events{/number}","events_url":"https://api.github.com/repos/decentfund/kyodo/events","assignees_url":"https://api.github.com/repos/decentfund/kyodo/assignees{/user}","branches_url":"https://api.github.com/repos/decentfund/kyodo/branches{/branch}","tags_url":"https://api.github.com/repos/decentfund/kyodo/tags","blobs_url":"https://api.github.com/repos/decentfund/kyodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentfund/kyodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentfund/kyodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentfund/kyodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentfund/kyodo/statuses/{sha}","languages_url":"https://api.github.com/repos/decentfund/kyodo/languages","stargazers_url":"https://api.github.com/repos/decentfund/kyodo/stargazers","contributors_url":"https://api.github.com/repos/decentfund/kyodo/contributors","subscribers_url":"https://api.github.com/repos/decentfund/kyodo/subscribers","subscription_url":"https://api.github.com/repos/decentfund/kyodo/subscription","commits_url":"https://api.github.com/repos/decentfund/kyodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentfund/kyodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentfund/kyodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentfund/kyodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentfund/kyodo/contents/{+path}","compare_url":"https://api.github.com/repos/decentfund/kyodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentfund/kyodo/merges","archive_url":"https://api.github.com/repos/decentfund/kyodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentfund/kyodo/downloads","issues_url":"https://api.github.com/repos/decentfund/kyodo/issues{/number}","pulls_url":"https://api.github.com/repos/decentfund/kyodo/pulls{/number}","milestones_url":"https://api.github.com/repos/decentfund/kyodo/milestones{/number}","notifications_url":"https://api.github.com/repos/decentfund/kyodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentfund/kyodo/labels{/name}","releases_url":"https://api.github.com/repos/decentfund/kyodo/releases{/id}","deployments_url":"https://api.github.com/repos/decentfund/kyodo/deployments","created_at":"2018-06-14T13:50:15Z","updated_at":"2018-11-14T13:02:35Z","pushed_at":"2018-11-22T22:21:53Z","git_url":"git://github.com/decentfund/kyodo.git","ssh_url":"git@github.com:decentfund/kyodo.git","clone_url":"https://github.com/decentfund/kyodo.git","svn_url":"https://github.com/decentfund/kyodo","homepage":null,"size":958,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":46,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/206"},"html":{"href":"https://github.com/decentfund/kyodo/pull/206"},"issue":{"href":"https://api.github.com/repos/decentfund/kyodo/issues/206"},"comments":{"href":"https://api.github.com/repos/decentfund/kyodo/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decentfund/kyodo/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/decentfund/kyodo/statuses/a83475d93d0b7438e32d5f4d6a93dd28eebc3e4e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 137364398,
"name": "decentfund/kyodo",
"url": "https://api.github.com/repos/decentfund/kyodo"
} | {
"id": 5252494,
"login": "jsidorenko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5252494?",
"url": "https://api.github.com/users/jsidorenko"
} | {
"id": 28684566,
"login": "decentfund",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28684566?",
"url": "https://api.github.com/orgs/decentfund"
} | 2018-11-22T23:07:49 | 8635475386 | {"actor":{"display_login":"jsidorenko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eciis/web/pulls/comments/230118841","pull_request_review_id":170684120,"id":230118841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDExODg0MQ==","diff_hunk":"@@ -124,33 +167,47 @@\n };\n \n rootScope.$emit(\"DELETED_POST\", post_not_timeline);\n- expect(timelineCtrl.posts.length).toEqual(2);\n- expect(timelineCtrl.posts).toEqual(posts);\n+ expect(timelineCtrl.posts.size()).toEqual(2);\n+ expect(timelineCtrl.posts.data).toEqual(posts);\n });\n \n it('should not delete post because it has activity.', function() {","path":"frontend/test/specs/post/timelineDirectiveSpec.js","position":118,"original_position":118,"commit_id":"c653c6750db754dff866fa20c3e6d9f95e0ef738","original_commit_id":"c653c6750db754dff866fa20c3e6d9f95e0ef738","user":{"login":"JuliePessoa","id":7011394,"node_id":"MDQ6VXNlcjcwMTEzOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7011394?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliePessoa","html_url":"https://github.com/JuliePessoa","followers_url":"https://api.github.com/users/JuliePessoa/followers","following_url":"https://api.github.com/users/JuliePessoa/following{/other_user}","gists_url":"https://api.github.com/users/JuliePessoa/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliePessoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliePessoa/subscriptions","organizations_url":"https://api.github.com/users/JuliePessoa/orgs","repos_url":"https://api.github.com/users/JuliePessoa/repos","events_url":"https://api.github.com/users/JuliePessoa/events{/privacy}","received_events_url":"https://api.github.com/users/JuliePessoa/received_events","type":"User","site_admin":false},"body":"this should be a test of Posts Factory","created_at":"2018-11-01T17:05:12Z","updated_at":"2018-11-01T17:12:17Z","html_url":"https://github.com/eciis/web/pull/1294#discussion_r230118841","pull_request_url":"https://api.github.com/repos/eciis/web/pulls/1294","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/comments/230118841"},"html":{"href":"https://github.com/eciis/web/pull/1294#discussion_r230118841"},"pull_request":{"href":"https://api.github.com/repos/eciis/web/pulls/1294"}}},"pull_request":{"url":"https://api.github.com/repos/eciis/web/pulls/1294","id":227391860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzkxODYw","html_url":"https://github.com/eciis/web/pull/1294","diff_url":"https://github.com/eciis/web/pull/1294.diff","patch_url":"https://github.com/eciis/web/pull/1294.patch","issue_url":"https://api.github.com/repos/eciis/web/issues/1294","number":1294,"state":"open","locked":false,"title":"Improve posts array update","user":{"login":"raonismaneoto","id":23387866,"node_id":"MDQ6VXNlcjIzMzg3ODY2","avatar_url":"https://avatars2.githubusercontent.com/u/23387866?v=4","gravatar_id":"","url":"https://api.github.com/users/raonismaneoto","html_url":"https://github.com/raonismaneoto","followers_url":"https://api.github.com/users/raonismaneoto/followers","following_url":"https://api.github.com/users/raonismaneoto/following{/other_user}","gists_url":"https://api.github.com/users/raonismaneoto/gists{/gist_id}","starred_url":"https://api.github.com/users/raonismaneoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raonismaneoto/subscriptions","organizations_url":"https://api.github.com/users/raonismaneoto/orgs","repos_url":"https://api.github.com/users/raonismaneoto/repos","events_url":"https://api.github.com/users/raonismaneoto/events{/privacy}","received_events_url":"https://api.github.com/users/raonismaneoto/received_events","type":"User","site_admin":false},"body":"**Feature/Bug description:**\r\nThe posts' array was going through the entire application, what is not a good practice once it could be large enough to slow down the processing.\r\n**Solution:**\r\nThe array is no longer going through the application, it stays in timelineDirective and its update happens with events and eventsListeners.\r\nI also had to create a factory to wrap the logic, mainly pagination logic, to avoid duplicates.\r\n**TODO/FIXME:** n/a","created_at":"2018-10-31T18:12:38Z","updated_at":"2018-11-01T17:12:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afe051845c9c983f22b99ecf14491502296c31c","assignee":{"login":"raonismaneoto","id":23387866,"node_id":"MDQ6VXNlcjIzMzg3ODY2","avatar_url":"https://avatars2.githubusercontent.com/u/23387866?v=4","gravatar_id":"","url":"https://api.github.com/users/raonismaneoto","html_url":"https://github.com/raonismaneoto","followers_url":"https://api.github.com/users/raonismaneoto/followers","following_url":"https://api.github.com/users/raonismaneoto/following{/other_user}","gists_url":"https://api.github.com/users/raonismaneoto/gists{/gist_id}","starred_url":"https://api.github.com/users/raonismaneoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raonismaneoto/subscriptions","organizations_url":"https://api.github.com/users/raonismaneoto/orgs","repos_url":"https://api.github.com/users/raonismaneoto/repos","events_url":"https://api.github.com/users/raonismaneoto/events{/privacy}","received_events_url":"https://api.github.com/users/raonismaneoto/received_events","type":"User","site_admin":false},"assignees":[{"login":"raonismaneoto","id":23387866,"node_id":"MDQ6VXNlcjIzMzg3ODY2","avatar_url":"https://avatars2.githubusercontent.com/u/23387866?v=4","gravatar_id":"","url":"https://api.github.com/users/raonismaneoto","html_url":"https://github.com/raonismaneoto","followers_url":"https://api.github.com/users/raonismaneoto/followers","following_url":"https://api.github.com/users/raonismaneoto/following{/other_user}","gists_url":"https://api.github.com/users/raonismaneoto/gists{/gist_id}","starred_url":"https://api.github.com/users/raonismaneoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raonismaneoto/subscriptions","organizations_url":"https://api.github.com/users/raonismaneoto/orgs","repos_url":"https://api.github.com/users/raonismaneoto/repos","events_url":"https://api.github.com/users/raonismaneoto/events{/privacy}","received_events_url":"https://api.github.com/users/raonismaneoto/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858264818,"node_id":"MDU6TGFiZWw4NTgyNjQ4MTg=","url":"https://api.github.com/repos/eciis/web/labels/enhancement","name":"enhancement","color":"e2c88e","default":true},{"id":606546317,"node_id":"MDU6TGFiZWw2MDY1NDYzMTc=","url":"https://api.github.com/repos/eciis/web/labels/frontend","name":"frontend","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/eciis/web/milestones/7","html_url":"https://github.com/eciis/web/milestone/7","labels_url":"https://api.github.com/repos/eciis/web/milestones/7/labels","id":3649556,"node_id":"MDk6TWlsZXN0b25lMzY0OTU1Ng==","number":7,"title":"MT 7","description":"","creator":{"login":"Luiz-FS","id":18005317,"node_id":"MDQ6VXNlcjE4MDA1MzE3","avatar_url":"https://avatars2.githubusercontent.com/u/18005317?v=4","gravatar_id":"","url":"https://api.github.com/users/Luiz-FS","html_url":"https://github.com/Luiz-FS","followers_url":"https://api.github.com/users/Luiz-FS/followers","following_url":"https://api.github.com/users/Luiz-FS/following{/other_user}","gists_url":"https://api.github.com/users/Luiz-FS/gists{/gist_id}","starred_url":"https://api.github.com/users/Luiz-FS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luiz-FS/subscriptions","organizations_url":"https://api.github.com/users/Luiz-FS/orgs","repos_url":"https://api.github.com/users/Luiz-FS/repos","events_url":"https://api.github.com/users/Luiz-FS/events{/privacy}","received_events_url":"https://api.github.com/users/Luiz-FS/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":45,"state":"open","created_at":"2018-09-12T18:18:04Z","updated_at":"2018-10-31T20:38:33Z","due_on":"2018-11-13T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eciis/web/pulls/1294/commits","review_comments_url":"https://api.github.com/repos/eciis/web/pulls/1294/comments","review_comment_url":"https://api.github.com/repos/eciis/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eciis/web/issues/1294/comments","statuses_url":"https://api.github.com/repos/eciis/web/statuses/c653c6750db754dff866fa20c3e6d9f95e0ef738","head":{"label":"eciis:improve-posts-array-update","ref":"improve-posts-array-update","sha":"c653c6750db754dff866fa20c3e6d9f95e0ef738","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-10-30T11:42:04Z","pushed_at":"2018-11-01T14:27:52Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":10499,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":5,"watchers":9,"default_branch":"dev"}},"base":{"label":"eciis:dev","ref":"dev","sha":"c14235804febf3adc8ee3529e2453fac4c3ec2a8","user":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"repo":{"id":91336041,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMzNjA0MQ==","name":"web","full_name":"eciis/web","private":false,"owner":{"login":"eciis","id":28706805,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzA2ODA1","avatar_url":"https://avatars3.githubusercontent.com/u/28706805?v=4","gravatar_id":"","url":"https://api.github.com/users/eciis","html_url":"https://github.com/eciis","followers_url":"https://api.github.com/users/eciis/followers","following_url":"https://api.github.com/users/eciis/following{/other_user}","gists_url":"https://api.github.com/users/eciis/gists{/gist_id}","starred_url":"https://api.github.com/users/eciis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eciis/subscriptions","organizations_url":"https://api.github.com/users/eciis/orgs","repos_url":"https://api.github.com/users/eciis/repos","events_url":"https://api.github.com/users/eciis/events{/privacy}","received_events_url":"https://api.github.com/users/eciis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eciis/web","description":"AngularJS Frontend with Appengine Python Backend","fork":false,"url":"https://api.github.com/repos/eciis/web","forks_url":"https://api.github.com/repos/eciis/web/forks","keys_url":"https://api.github.com/repos/eciis/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eciis/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eciis/web/teams","hooks_url":"https://api.github.com/repos/eciis/web/hooks","issue_events_url":"https://api.github.com/repos/eciis/web/issues/events{/number}","events_url":"https://api.github.com/repos/eciis/web/events","assignees_url":"https://api.github.com/repos/eciis/web/assignees{/user}","branches_url":"https://api.github.com/repos/eciis/web/branches{/branch}","tags_url":"https://api.github.com/repos/eciis/web/tags","blobs_url":"https://api.github.com/repos/eciis/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eciis/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eciis/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/eciis/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eciis/web/statuses/{sha}","languages_url":"https://api.github.com/repos/eciis/web/languages","stargazers_url":"https://api.github.com/repos/eciis/web/stargazers","contributors_url":"https://api.github.com/repos/eciis/web/contributors","subscribers_url":"https://api.github.com/repos/eciis/web/subscribers","subscription_url":"https://api.github.com/repos/eciis/web/subscription","commits_url":"https://api.github.com/repos/eciis/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/eciis/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/eciis/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/eciis/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/eciis/web/contents/{+path}","compare_url":"https://api.github.com/repos/eciis/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eciis/web/merges","archive_url":"https://api.github.com/repos/eciis/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eciis/web/downloads","issues_url":"https://api.github.com/repos/eciis/web/issues{/number}","pulls_url":"https://api.github.com/repos/eciis/web/pulls{/number}","milestones_url":"https://api.github.com/repos/eciis/web/milestones{/number}","notifications_url":"https://api.github.com/repos/eciis/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eciis/web/labels{/name}","releases_url":"https://api.github.com/repos/eciis/web/releases{/id}","deployments_url":"https://api.github.com/repos/eciis/web/deployments","created_at":"2017-05-15T12:37:06Z","updated_at":"2018-10-30T11:42:04Z","pushed_at":"2018-11-01T14:27:52Z","git_url":"git://github.com/eciis/web.git","ssh_url":"git@github.com:eciis/web.git","clone_url":"https://github.com/eciis/web.git","svn_url":"https://github.com/eciis/web","homepage":"","size":10499,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":5,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/eciis/web/pulls/1294"},"html":{"href":"https://github.com/eciis/web/pull/1294"},"issue":{"href":"https://api.github.com/repos/eciis/web/issues/1294"},"comments":{"href":"https://api.github.com/repos/eciis/web/issues/1294/comments"},"review_comments":{"href":"https://api.github.com/repos/eciis/web/pulls/1294/comments"},"review_comment":{"href":"https://api.github.com/repos/eciis/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eciis/web/pulls/1294/commits"},"statuses":{"href":"https://api.github.com/repos/eciis/web/statuses/c653c6750db754dff866fa20c3e6d9f95e0ef738"}},"author_association":"CONTRIBUTOR"}} | {
"id": 91336041,
"name": "eciis/web",
"url": "https://api.github.com/repos/eciis/web"
} | {
"id": 7011394,
"login": "JuliePessoa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7011394?",
"url": "https://api.github.com/users/JuliePessoa"
} | {
"id": 28706805,
"login": "eciis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28706805?",
"url": "https://api.github.com/orgs/eciis"
} | 2018-11-01T17:05:12 | 8520409806 | {"actor":{"display_login":"JuliePessoa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/comments/194350926","pull_request_review_id":127501034,"id":194350926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDM1MDkyNg==","diff_hunk":"@@ -196,6 +214,108 @@ Run the following `curl` command:\n \n Replace _<IAM-token>_, _<cluster-url>_, _<instanceId>_ and _<certificateId>_ with the appropriate values.\n \n+## Listing all of your notification channels\n+{: #list-notification-channels}\n+\n+Retrieve a list of all of your notification channels.\n+{: shortdesc}\n+\n+Run the following `curl` command:\n+\n+ ```\n+ curl -H \"Authorization: Bearer <IAM-token>\" https://<cluster-url>/api/v1/instances/<instanceId>/notifications/channels\n+ ```\n+\n+ {: pre}\n+\n+Replace _<IAM-token>_, _<cluster-url>_, and _<instanceId>_ with the appropriate values.\n+\n+## Adding a notification channel\n+{: #import-certificate}\n+\n+Add a notification channel where you will get notifications about expiring certificates.\n+{: shortdesc}\n+\n+\n+Run the following `curl` command:\n+\n+ ```\n+ curl -X PUT \\\n+ https://<cluster-url>/api/v1/instances/<instanceId>/notifications/channels \\\n+ -H 'authorization: Bearer <IAM-token>' \\\n+ -H 'content-type: application/json' \\\n+ -d '{\n+\t\"type\":\"<type>\",\n+\t\"endpoint\":\"<endpoint>\",\n+\t\"is_active\":<is_active>\n+ }'\n+ ```\n+ {: pre}\n+\n+Replace _<cluster-url>_, _<instanceId>_, _<IAM-token>_, _<type>_, _<endpoint>_,\n+ _<is_active>_ with the appropriate values.\n+\n+## Updating notification channel endpoint\n+{: #update-notification-channel}\n+\n+Update a notification channel endpoint property.\n+{: shortdesc}\n+\n+Run the following `curl` command:\n+\n+ ```\n+ curl -X POST \\\n+ https://<cluster-url>/api/v1/instances/<instanceID>/notifications/<channelId> \\\n+ -H 'authorization: Bearer <IAM-token>' \\\n+ -H 'content-type: application/json' \\\n+ -d '{\n+ \t\"endpoint\":\"<endpoint>\"\n+ }'\n+ ```\n+\n+{: pre}\n+\n+Replace _<cluster-url>_, _<instanceId>_, _<channelId>_, _<IAM-token>_, and _<endpoint>_ with the appropriate values.\n+\n+## Enable / disable notification channels\n+{: #enable-disable-notification-channels}\n+\n+Enable or disable a notification channel - if a channel is disabled no notifications will be sent to the channel.\n+{: shortdesc}\n+\n+Run the following `curl` command:\n+\n+ ```\n+ curl -X PUT \\\n+ https://<cluster-url>/api/v1/instances/<instanceID>/notifications/<channelId>/state \\\n+ -H 'authorization: Bearer <IAM-token>' \\\n+ -H 'content-type: application/json' \\\n+ -d '{\n+ \t\"enabled\":true/false\n+ }'","path":"rest-api.md","position":153,"original_position":153,"commit_id":"242a39660a397de1cc6b66602d73092267633c94","original_commit_id":"242a39660a397de1cc6b66602d73092267633c94","user":{"login":"jeffpk62","id":10051651,"node_id":"MDQ6VXNlcjEwMDUxNjUx","avatar_url":"https://avatars3.githubusercontent.com/u/10051651?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffpk62","html_url":"https://github.com/jeffpk62","followers_url":"https://api.github.com/users/jeffpk62/followers","following_url":"https://api.github.com/users/jeffpk62/following{/other_user}","gists_url":"https://api.github.com/users/jeffpk62/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffpk62/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffpk62/subscriptions","organizations_url":"https://api.github.com/users/jeffpk62/orgs","repos_url":"https://api.github.com/users/jeffpk62/repos","events_url":"https://api.github.com/users/jeffpk62/events{/privacy}","received_events_url":"https://api.github.com/users/jeffpk62/received_events","type":"User","site_admin":false},"body":"Align closing brace.","created_at":"2018-06-11T09:59:26Z","updated_at":"2018-06-11T10:04:40Z","html_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65#discussion_r194350926","pull_request_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/comments/194350926"},"html":{"href":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65#discussion_r194350926"},"pull_request":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65","id":190829509,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwODI5NTA5","html_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65","diff_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65.diff","patch_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65.patch","issue_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/65","number":65,"state":"closed","locked":false,"title":"Includes Merge pull request #9 from security-services/notifications and more...","user":{"login":"alchemyDocs","id":20405225,"node_id":"MDQ6VXNlcjIwNDA1MjI1","avatar_url":"https://avatars3.githubusercontent.com/u/20405225?v=4","gravatar_id":"","url":"https://api.github.com/users/alchemyDocs","html_url":"https://github.com/alchemyDocs","followers_url":"https://api.github.com/users/alchemyDocs/followers","following_url":"https://api.github.com/users/alchemyDocs/following{/other_user}","gists_url":"https://api.github.com/users/alchemyDocs/gists{/gist_id}","starred_url":"https://api.github.com/users/alchemyDocs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alchemyDocs/subscriptions","organizations_url":"https://api.github.com/users/alchemyDocs/orgs","repos_url":"https://api.github.com/users/alchemyDocs/repos","events_url":"https://api.github.com/users/alchemyDocs/events{/privacy}","received_events_url":"https://api.github.com/users/alchemyDocs/received_events","type":"User","site_admin":false},"body":"See the Commits and Files changed tabs for more information about what is included in this pull request.","created_at":"2018-05-28T03:54:42Z","updated_at":"2018-06-11T10:04:41Z","closed_at":"2018-06-11T10:00:43Z","merged_at":"2018-06-11T10:00:43Z","merge_commit_sha":"55073811151c1967fb5c593fb4a46e34c21a0f97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65/commits","review_comments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65/comments","review_comment_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/65/comments","statuses_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/statuses/242a39660a397de1cc6b66602d73092267633c94","head":{"label":"IBM-Bluemix-Docs:next-prod-push","ref":"next-prod-push","sha":"242a39660a397de1cc6b66602d73092267633c94","user":{"login":"IBM-Bluemix-Docs","id":28810603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEwNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/28810603?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Bluemix-Docs","html_url":"https://github.com/IBM-Bluemix-Docs","followers_url":"https://api.github.com/users/IBM-Bluemix-Docs/followers","following_url":"https://api.github.com/users/IBM-Bluemix-Docs/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Bluemix-Docs/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Bluemix-Docs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Bluemix-Docs/subscriptions","organizations_url":"https://api.github.com/users/IBM-Bluemix-Docs/orgs","repos_url":"https://api.github.com/users/IBM-Bluemix-Docs/repos","events_url":"https://api.github.com/users/IBM-Bluemix-Docs/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Bluemix-Docs/received_events","type":"Organization","site_admin":false},"repo":{"id":112749527,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NDk1Mjc=","name":"certificate-manager","full_name":"IBM-Bluemix-Docs/certificate-manager","owner":{"login":"IBM-Bluemix-Docs","id":28810603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEwNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/28810603?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Bluemix-Docs","html_url":"https://github.com/IBM-Bluemix-Docs","followers_url":"https://api.github.com/users/IBM-Bluemix-Docs/followers","following_url":"https://api.github.com/users/IBM-Bluemix-Docs/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Bluemix-Docs/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Bluemix-Docs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Bluemix-Docs/subscriptions","organizations_url":"https://api.github.com/users/IBM-Bluemix-Docs/orgs","repos_url":"https://api.github.com/users/IBM-Bluemix-Docs/repos","events_url":"https://api.github.com/users/IBM-Bluemix-Docs/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Bluemix-Docs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager","description":"certificate-manager","fork":false,"url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager","forks_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/forks","keys_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/teams","hooks_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/hooks","issue_events_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/events{/number}","events_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/events","assignees_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/assignees{/user}","branches_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/branches{/branch}","tags_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/tags","blobs_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/languages","stargazers_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/stargazers","contributors_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/contributors","subscribers_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/subscribers","subscription_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/subscription","commits_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/contents/{+path}","compare_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/merges","archive_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/downloads","issues_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues{/number}","pulls_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/labels{/name}","releases_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/releases{/id}","deployments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/deployments","created_at":"2017-12-01T14:33:14Z","updated_at":"2018-06-11T10:00:46Z","pushed_at":"2018-06-11T10:00:43Z","git_url":"git://github.com/IBM-Bluemix-Docs/certificate-manager.git","ssh_url":"git@github.com:IBM-Bluemix-Docs/certificate-manager.git","clone_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager.git","svn_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager","homepage":null,"size":132,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"IBM-Bluemix-Docs:master","ref":"master","sha":"83efeb3be02e42e969d6f6035ef8b185b8193a87","user":{"login":"IBM-Bluemix-Docs","id":28810603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEwNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/28810603?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Bluemix-Docs","html_url":"https://github.com/IBM-Bluemix-Docs","followers_url":"https://api.github.com/users/IBM-Bluemix-Docs/followers","following_url":"https://api.github.com/users/IBM-Bluemix-Docs/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Bluemix-Docs/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Bluemix-Docs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Bluemix-Docs/subscriptions","organizations_url":"https://api.github.com/users/IBM-Bluemix-Docs/orgs","repos_url":"https://api.github.com/users/IBM-Bluemix-Docs/repos","events_url":"https://api.github.com/users/IBM-Bluemix-Docs/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Bluemix-Docs/received_events","type":"Organization","site_admin":false},"repo":{"id":112749527,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NDk1Mjc=","name":"certificate-manager","full_name":"IBM-Bluemix-Docs/certificate-manager","owner":{"login":"IBM-Bluemix-Docs","id":28810603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODEwNjAz","avatar_url":"https://avatars3.githubusercontent.com/u/28810603?v=4","gravatar_id":"","url":"https://api.github.com/users/IBM-Bluemix-Docs","html_url":"https://github.com/IBM-Bluemix-Docs","followers_url":"https://api.github.com/users/IBM-Bluemix-Docs/followers","following_url":"https://api.github.com/users/IBM-Bluemix-Docs/following{/other_user}","gists_url":"https://api.github.com/users/IBM-Bluemix-Docs/gists{/gist_id}","starred_url":"https://api.github.com/users/IBM-Bluemix-Docs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IBM-Bluemix-Docs/subscriptions","organizations_url":"https://api.github.com/users/IBM-Bluemix-Docs/orgs","repos_url":"https://api.github.com/users/IBM-Bluemix-Docs/repos","events_url":"https://api.github.com/users/IBM-Bluemix-Docs/events{/privacy}","received_events_url":"https://api.github.com/users/IBM-Bluemix-Docs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager","description":"certificate-manager","fork":false,"url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager","forks_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/forks","keys_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/teams","hooks_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/hooks","issue_events_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/events{/number}","events_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/events","assignees_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/assignees{/user}","branches_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/branches{/branch}","tags_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/tags","blobs_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/languages","stargazers_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/stargazers","contributors_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/contributors","subscribers_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/subscribers","subscription_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/subscription","commits_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/contents/{+path}","compare_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/merges","archive_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/downloads","issues_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues{/number}","pulls_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/labels{/name}","releases_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/releases{/id}","deployments_url":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/deployments","created_at":"2017-12-01T14:33:14Z","updated_at":"2018-06-11T10:00:46Z","pushed_at":"2018-06-11T10:00:43Z","git_url":"git://github.com/IBM-Bluemix-Docs/certificate-manager.git","ssh_url":"git@github.com:IBM-Bluemix-Docs/certificate-manager.git","clone_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager.git","svn_url":"https://github.com/IBM-Bluemix-Docs/certificate-manager","homepage":null,"size":132,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65"},"html":{"href":"https://github.com/IBM-Bluemix-Docs/certificate-manager/pull/65"},"issue":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/65"},"comments":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager/statuses/242a39660a397de1cc6b66602d73092267633c94"}},"author_association":"COLLABORATOR"}} | {
"id": 112749527,
"name": "IBM-Bluemix-Docs/certificate-manager",
"url": "https://api.github.com/repos/IBM-Bluemix-Docs/certificate-manager"
} | {
"id": 10051651,
"login": "jeffpk62",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10051651?",
"url": "https://api.github.com/users/jeffpk62"
} | {
"id": 28810603,
"login": "IBM-Bluemix-Docs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28810603?",
"url": "https://api.github.com/orgs/IBM-Bluemix-Docs"
} | 2018-06-11T09:59:26 | 7805219663 | {"actor":{"display_login":"jeffpk62"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/comments/209451480","pull_request_review_id":145470927,"id":209451480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ1MTQ4MA==","diff_hunk":"@@ -0,0 +1,7 @@\n+threshold_crypto is copyright 2018, POA Network Developers.\n+\n+Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or\n+http://www.apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or\n+http://opensource.org/licenses/MIT>, at your option. All files in the project\n+carrying such notice may not be copied, modified, or distributed except\n+according to those terms.","path":"COPYRIGHT","position":7,"original_position":7,"commit_id":"9633af7cadf3cc75246af06b149f736f0e0d76dc","original_commit_id":"9633af7cadf3cc75246af06b149f736f0e0d76dc","user":{"login":"vkomenda","id":5529505,"node_id":"MDQ6VXNlcjU1Mjk1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5529505?v=4","gravatar_id":"","url":"https://api.github.com/users/vkomenda","html_url":"https://github.com/vkomenda","followers_url":"https://api.github.com/users/vkomenda/followers","following_url":"https://api.github.com/users/vkomenda/following{/other_user}","gists_url":"https://api.github.com/users/vkomenda/gists{/gist_id}","starred_url":"https://api.github.com/users/vkomenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkomenda/subscriptions","organizations_url":"https://api.github.com/users/vkomenda/orgs","repos_url":"https://api.github.com/users/vkomenda/repos","events_url":"https://api.github.com/users/vkomenda/events{/privacy}","received_events_url":"https://api.github.com/users/vkomenda/received_events","type":"User","site_admin":false},"body":"Can you add a newline here?","created_at":"2018-08-12T11:14:20Z","updated_at":"2018-08-12T11:30:28Z","html_url":"https://github.com/poanetwork/threshold_crypto/pull/8#discussion_r209451480","pull_request_url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/comments/209451480"},"html":{"href":"https://github.com/poanetwork/threshold_crypto/pull/8#discussion_r209451480"},"pull_request":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8","id":207783457,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzgzNDU3","html_url":"https://github.com/poanetwork/threshold_crypto/pull/8","diff_url":"https://github.com/poanetwork/threshold_crypto/pull/8.diff","patch_url":"https://github.com/poanetwork/threshold_crypto/pull/8.patch","issue_url":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/8","number":8,"state":"open","locked":false,"title":"Change license, flesh out README a bit.","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"body":"* Expand readme\r\n* Change license\r\n\r\nCloses https://github.com/poanetwork/threshold_crypto/issues/7 and https://github.com/poanetwork/threshold_crypto/issues/2\r\n\r\n@andogro, I'll hand this off to you to refine the language in a separate PR as you see fit.\r\n\r\nMany of the tests use private types or types with private constructors. I'll leave it to @vkomenda, @afck, and @DrPeterVanNostrand to build on the example and decide what you may want to make public for those purposes.\r\n\r\nFor now this is probably ready to merge.","created_at":"2018-08-11T17:01:04Z","updated_at":"2018-08-12T11:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1133fb6ae77a51245c8c77a7fc80ec6e740ce9f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"afck","id":7894725,"node_id":"MDQ6VXNlcjc4OTQ3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7894725?v=4","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},{"login":"DrPeterVanNostrand","id":9577225,"node_id":"MDQ6VXNlcjk1NzcyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/9577225?v=4","gravatar_id":"","url":"https://api.github.com/users/DrPeterVanNostrand","html_url":"https://github.com/DrPeterVanNostrand","followers_url":"https://api.github.com/users/DrPeterVanNostrand/followers","following_url":"https://api.github.com/users/DrPeterVanNostrand/following{/other_user}","gists_url":"https://api.github.com/users/DrPeterVanNostrand/gists{/gist_id}","starred_url":"https://api.github.com/users/DrPeterVanNostrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrPeterVanNostrand/subscriptions","organizations_url":"https://api.github.com/users/DrPeterVanNostrand/orgs","repos_url":"https://api.github.com/users/DrPeterVanNostrand/repos","events_url":"https://api.github.com/users/DrPeterVanNostrand/events{/privacy}","received_events_url":"https://api.github.com/users/DrPeterVanNostrand/received_events","type":"User","site_admin":false},{"login":"andogro","id":14284654,"node_id":"MDQ6VXNlcjE0Mjg0NjU0","avatar_url":"https://avatars3.githubusercontent.com/u/14284654?v=4","gravatar_id":"","url":"https://api.github.com/users/andogro","html_url":"https://github.com/andogro","followers_url":"https://api.github.com/users/andogro/followers","following_url":"https://api.github.com/users/andogro/following{/other_user}","gists_url":"https://api.github.com/users/andogro/gists{/gist_id}","starred_url":"https://api.github.com/users/andogro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andogro/subscriptions","organizations_url":"https://api.github.com/users/andogro/orgs","repos_url":"https://api.github.com/users/andogro/repos","events_url":"https://api.github.com/users/andogro/events{/privacy}","received_events_url":"https://api.github.com/users/andogro/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8/commits","review_comments_url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8/comments","review_comment_url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/8/comments","statuses_url":"https://api.github.com/repos/poanetwork/threshold_crypto/statuses/9633af7cadf3cc75246af06b149f736f0e0d76dc","head":{"label":"c0gent:c0gent-readme","ref":"c0gent-readme","sha":"9633af7cadf3cc75246af06b149f736f0e0d76dc","user":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"repo":{"id":143755989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NTU5ODk=","name":"threshold_crypto","full_name":"c0gent/threshold_crypto","owner":{"login":"c0gent","id":2916797,"node_id":"MDQ6VXNlcjI5MTY3OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2916797?v=4","gravatar_id":"","url":"https://api.github.com/users/c0gent","html_url":"https://github.com/c0gent","followers_url":"https://api.github.com/users/c0gent/followers","following_url":"https://api.github.com/users/c0gent/following{/other_user}","gists_url":"https://api.github.com/users/c0gent/gists{/gist_id}","starred_url":"https://api.github.com/users/c0gent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0gent/subscriptions","organizations_url":"https://api.github.com/users/c0gent/orgs","repos_url":"https://api.github.com/users/c0gent/repos","events_url":"https://api.github.com/users/c0gent/events{/privacy}","received_events_url":"https://api.github.com/users/c0gent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c0gent/threshold_crypto","description":"Pairing cryptography and threshold signatures","fork":true,"url":"https://api.github.com/repos/c0gent/threshold_crypto","forks_url":"https://api.github.com/repos/c0gent/threshold_crypto/forks","keys_url":"https://api.github.com/repos/c0gent/threshold_crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c0gent/threshold_crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c0gent/threshold_crypto/teams","hooks_url":"https://api.github.com/repos/c0gent/threshold_crypto/hooks","issue_events_url":"https://api.github.com/repos/c0gent/threshold_crypto/issues/events{/number}","events_url":"https://api.github.com/repos/c0gent/threshold_crypto/events","assignees_url":"https://api.github.com/repos/c0gent/threshold_crypto/assignees{/user}","branches_url":"https://api.github.com/repos/c0gent/threshold_crypto/branches{/branch}","tags_url":"https://api.github.com/repos/c0gent/threshold_crypto/tags","blobs_url":"https://api.github.com/repos/c0gent/threshold_crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c0gent/threshold_crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c0gent/threshold_crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/c0gent/threshold_crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c0gent/threshold_crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/c0gent/threshold_crypto/languages","stargazers_url":"https://api.github.com/repos/c0gent/threshold_crypto/stargazers","contributors_url":"https://api.github.com/repos/c0gent/threshold_crypto/contributors","subscribers_url":"https://api.github.com/repos/c0gent/threshold_crypto/subscribers","subscription_url":"https://api.github.com/repos/c0gent/threshold_crypto/subscription","commits_url":"https://api.github.com/repos/c0gent/threshold_crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/c0gent/threshold_crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/c0gent/threshold_crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/c0gent/threshold_crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/c0gent/threshold_crypto/contents/{+path}","compare_url":"https://api.github.com/repos/c0gent/threshold_crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c0gent/threshold_crypto/merges","archive_url":"https://api.github.com/repos/c0gent/threshold_crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c0gent/threshold_crypto/downloads","issues_url":"https://api.github.com/repos/c0gent/threshold_crypto/issues{/number}","pulls_url":"https://api.github.com/repos/c0gent/threshold_crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/c0gent/threshold_crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/c0gent/threshold_crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c0gent/threshold_crypto/labels{/name}","releases_url":"https://api.github.com/repos/c0gent/threshold_crypto/releases{/id}","deployments_url":"https://api.github.com/repos/c0gent/threshold_crypto/deployments","created_at":"2018-08-06T16:38:21Z","updated_at":"2018-08-11T16:54:05Z","pushed_at":"2018-08-11T19:11:16Z","git_url":"git://github.com/c0gent/threshold_crypto.git","ssh_url":"git@github.com:c0gent/threshold_crypto.git","clone_url":"https://github.com/c0gent/threshold_crypto.git","svn_url":"https://github.com/c0gent/threshold_crypto","homepage":null,"size":111,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poanetwork:master","ref":"master","sha":"d81953b55d181311c2a4eed2b6c34059fcf3fdae","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":142872468,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4NzI0Njg=","name":"threshold_crypto","full_name":"poanetwork/threshold_crypto","owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poanetwork/threshold_crypto","description":"Pairing cryptography and threshold signatures","fork":false,"url":"https://api.github.com/repos/poanetwork/threshold_crypto","forks_url":"https://api.github.com/repos/poanetwork/threshold_crypto/forks","keys_url":"https://api.github.com/repos/poanetwork/threshold_crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/threshold_crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/threshold_crypto/teams","hooks_url":"https://api.github.com/repos/poanetwork/threshold_crypto/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/threshold_crypto/events","assignees_url":"https://api.github.com/repos/poanetwork/threshold_crypto/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/threshold_crypto/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/threshold_crypto/tags","blobs_url":"https://api.github.com/repos/poanetwork/threshold_crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/threshold_crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/threshold_crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/threshold_crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/threshold_crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/threshold_crypto/languages","stargazers_url":"https://api.github.com/repos/poanetwork/threshold_crypto/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/threshold_crypto/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/threshold_crypto/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/threshold_crypto/subscription","commits_url":"https://api.github.com/repos/poanetwork/threshold_crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/threshold_crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/threshold_crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/threshold_crypto/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/threshold_crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/threshold_crypto/merges","archive_url":"https://api.github.com/repos/poanetwork/threshold_crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/threshold_crypto/downloads","issues_url":"https://api.github.com/repos/poanetwork/threshold_crypto/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/threshold_crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/threshold_crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/threshold_crypto/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/threshold_crypto/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/threshold_crypto/deployments","created_at":"2018-07-30T12:29:53Z","updated_at":"2018-08-10T13:29:50Z","pushed_at":"2018-08-11T19:11:17Z","git_url":"git://github.com/poanetwork/threshold_crypto.git","ssh_url":"git@github.com:poanetwork/threshold_crypto.git","clone_url":"https://github.com/poanetwork/threshold_crypto.git","svn_url":"https://github.com/poanetwork/threshold_crypto","homepage":null,"size":89,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8"},"html":{"href":"https://github.com/poanetwork/threshold_crypto/pull/8"},"issue":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/8"},"comments":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/threshold_crypto/statuses/9633af7cadf3cc75246af06b149f736f0e0d76dc"}},"author_association":"MEMBER"}} | {
"id": 142872468,
"name": "poanetwork/threshold_crypto",
"url": "https://api.github.com/repos/poanetwork/threshold_crypto"
} | {
"id": 5529505,
"login": "vkomenda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5529505?",
"url": "https://api.github.com/users/vkomenda"
} | {
"id": 28943015,
"login": "poanetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28943015?",
"url": "https://api.github.com/orgs/poanetwork"
} | 2018-08-12T11:14:20 | 8101254458 | {"actor":{"display_login":"vkomenda"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments/240204046","pull_request_review_id":183144699,"id":240204046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDIwNDA0Ng==","diff_hunk":"@@ -248,10 +293,64 @@ where\n }\n }\n \n+ /// Removes a given old participant if it has been scheduled for removal as a result of being\n+ /// superseded by a new set of participants of which it is not a member. Returns `true` if the\n+ /// participant has been removed and `false` otherwise.\n+ fn remove_participant_if_old(&mut self, id: &D::NodeId) -> bool {\n+ self.last_epochs\n+ .get(id)\n+ .cloned()\n+ .map_or(false, |last_epoch| self.remove_participant(id, &last_epoch))\n+ }\n+\n+ /// Removes a given old participant after a specified epoch if that participant has become\n+ /// superseded by a new set of participants of which it is not a member. Returns `true` if the\n+ /// participant has been removed and `false` otherwise.\n+ fn remove_participant_after(&mut self, id: &D::NodeId, last_epoch: &D::Epoch) -> bool {\n+ self.last_epochs.insert(id.clone(), last_epoch.clone());\n+ self.remove_participant(id, last_epoch)\n+ }\n+\n+ /// Removes a participant after a specified last epoch. The participant is removed if\n+ ///\n+ /// 1. its epoch is newer than its last epoch, or\n+ ///\n+ /// 2. the epoch of the managed algorithm instance is newer than the last epoch and the sender\n+ /// queue has sent all messages for all epochs up to the last epoch to the participant.\n+ ///\n+ /// Returns `true` if the participant has been removed and `false` otherwise.\n+ fn remove_participant(&mut self, id: &D::NodeId, last_epoch: &D::Epoch) -> bool {\n+ let remove = if let Some(peer_epoch) = self.peer_epochs.get(id) {\n+ last_epoch < peer_epoch\n+ || (*last_epoch < self.algo.epoch() && self.outgoing_queue.get(id).map_or(\n+ false,\n+ |q| {\n+ q.keys()\n+ .take_while(|epoch| *epoch <= last_epoch)\n+ .next()\n+ .is_none()\n+ },\n+ ))\n+ } else {\n+ true\n+ };","path":"src/sender_queue/mod.rs","position":167,"original_position":167,"commit_id":"6b31be7225be8fb94cf5df4accf2dc41e1f2a9eb","original_commit_id":"6b31be7225be8fb94cf5df4accf2dc41e1f2a9eb","user":{"login":"afck","id":7894725,"node_id":"MDQ6VXNlcjc4OTQ3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7894725?v=4","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"That's reeeally hard to read, but I also can't come up with anything much better right now.\r\nIt _might_ help (_or_ make it worse) to `return false` in all the places where we'd assign `false` to `remove`, and get rid of that variable. The last line of the method would then just be `true`. Not sure.\r\nBut I'm also fine with merging it like that for now. Maybe we can reformulate it later.","created_at":"2018-12-10T13:15:55Z","updated_at":"2018-12-10T13:44:44Z","html_url":"https://github.com/poanetwork/hbbft/pull/352#discussion_r240204046","pull_request_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments/240204046"},"html":{"href":"https://github.com/poanetwork/hbbft/pull/352#discussion_r240204046"},"pull_request":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/poanetwork/hbbft/pulls/352","id":233612178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjEyMTc4","html_url":"https://github.com/poanetwork/hbbft/pull/352","diff_url":"https://github.com/poanetwork/hbbft/pull/352.diff","patch_url":"https://github.com/poanetwork/hbbft/pull/352.patch","issue_url":"https://api.github.com/repos/poanetwork/hbbft/issues/352","number":352,"state":"open","locked":false,"title":"Remove peers from sender queue","user":{"login":"vkomenda","id":5529505,"node_id":"MDQ6VXNlcjU1Mjk1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5529505?v=4","gravatar_id":"","url":"https://api.github.com/users/vkomenda","html_url":"https://github.com/vkomenda","followers_url":"https://api.github.com/users/vkomenda/followers","following_url":"https://api.github.com/users/vkomenda/following{/other_user}","gists_url":"https://api.github.com/users/vkomenda/gists{/gist_id}","starred_url":"https://api.github.com/users/vkomenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkomenda/subscriptions","organizations_url":"https://api.github.com/users/vkomenda/orgs","repos_url":"https://api.github.com/users/vkomenda/repos","events_url":"https://api.github.com/users/vkomenda/events{/privacy}","received_events_url":"https://api.github.com/users/vkomenda/received_events","type":"User","site_admin":false},"body":"Closes #341 \r\n\r\nPrior to this PR we had only addition of new peers in the sender queue. This PR allows removal of those peers which are validators that become superseded by other validators in the next epoch.","created_at":"2018-11-26T16:09:08Z","updated_at":"2018-12-10T13:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f2f1a23238d526eb2a211db42b3e1d023c9f926","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbr","id":110577,"node_id":"MDQ6VXNlcjExMDU3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/110577?v=4","gravatar_id":"","url":"https://api.github.com/users/mbr","html_url":"https://github.com/mbr","followers_url":"https://api.github.com/users/mbr/followers","following_url":"https://api.github.com/users/mbr/following{/other_user}","gists_url":"https://api.github.com/users/mbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbr/subscriptions","organizations_url":"https://api.github.com/users/mbr/orgs","repos_url":"https://api.github.com/users/mbr/repos","events_url":"https://api.github.com/users/mbr/events{/privacy}","received_events_url":"https://api.github.com/users/mbr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/352/commits","review_comments_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/352/comments","review_comment_url":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/issues/352/comments","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/6b31be7225be8fb94cf5df4accf2dc41e1f2a9eb","head":{"label":"poanetwork:remove-peers-from-sender-queue","ref":"remove-peers-from-sender-queue","sha":"6b31be7225be8fb94cf5df4accf2dc41e1f2a9eb","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":125307734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzMDc3MzQ=","name":"hbbft","full_name":"poanetwork/hbbft","private":false,"owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poanetwork/hbbft","description":" An implementation of the paper \"Honey Badger of BFT Protocols\" in Rust. This is a modular library of consensus.","fork":false,"url":"https://api.github.com/repos/poanetwork/hbbft","forks_url":"https://api.github.com/repos/poanetwork/hbbft/forks","keys_url":"https://api.github.com/repos/poanetwork/hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/hbbft/teams","hooks_url":"https://api.github.com/repos/poanetwork/hbbft/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/hbbft/events","assignees_url":"https://api.github.com/repos/poanetwork/hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/hbbft/tags","blobs_url":"https://api.github.com/repos/poanetwork/hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/hbbft/languages","stargazers_url":"https://api.github.com/repos/poanetwork/hbbft/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/hbbft/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/hbbft/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/hbbft/subscription","commits_url":"https://api.github.com/repos/poanetwork/hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/hbbft/merges","archive_url":"https://api.github.com/repos/poanetwork/hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/hbbft/downloads","issues_url":"https://api.github.com/repos/poanetwork/hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/hbbft/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/hbbft/deployments","created_at":"2018-03-15T03:32:34Z","updated_at":"2018-12-05T12:42:20Z","pushed_at":"2018-12-10T11:51:49Z","git_url":"git://github.com/poanetwork/hbbft.git","ssh_url":"git@github.com:poanetwork/hbbft.git","clone_url":"https://github.com/poanetwork/hbbft.git","svn_url":"https://github.com/poanetwork/hbbft","homepage":"","size":2095,"stargazers_count":122,"watchers_count":122,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":36,"watchers":122,"default_branch":"master"}},"base":{"label":"poanetwork:master","ref":"master","sha":"ceb416a6e145a46898637377e05ded4422a1494e","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":125307734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzMDc3MzQ=","name":"hbbft","full_name":"poanetwork/hbbft","private":false,"owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poanetwork/hbbft","description":" An implementation of the paper \"Honey Badger of BFT Protocols\" in Rust. This is a modular library of consensus.","fork":false,"url":"https://api.github.com/repos/poanetwork/hbbft","forks_url":"https://api.github.com/repos/poanetwork/hbbft/forks","keys_url":"https://api.github.com/repos/poanetwork/hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/hbbft/teams","hooks_url":"https://api.github.com/repos/poanetwork/hbbft/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/hbbft/events","assignees_url":"https://api.github.com/repos/poanetwork/hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/hbbft/tags","blobs_url":"https://api.github.com/repos/poanetwork/hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/hbbft/languages","stargazers_url":"https://api.github.com/repos/poanetwork/hbbft/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/hbbft/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/hbbft/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/hbbft/subscription","commits_url":"https://api.github.com/repos/poanetwork/hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/hbbft/merges","archive_url":"https://api.github.com/repos/poanetwork/hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/hbbft/downloads","issues_url":"https://api.github.com/repos/poanetwork/hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/hbbft/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/hbbft/deployments","created_at":"2018-03-15T03:32:34Z","updated_at":"2018-12-05T12:42:20Z","pushed_at":"2018-12-10T11:51:49Z","git_url":"git://github.com/poanetwork/hbbft.git","ssh_url":"git@github.com:poanetwork/hbbft.git","clone_url":"https://github.com/poanetwork/hbbft.git","svn_url":"https://github.com/poanetwork/hbbft","homepage":"","size":2095,"stargazers_count":122,"watchers_count":122,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":31,"open_issues":36,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/352"},"html":{"href":"https://github.com/poanetwork/hbbft/pull/352"},"issue":{"href":"https://api.github.com/repos/poanetwork/hbbft/issues/352"},"comments":{"href":"https://api.github.com/repos/poanetwork/hbbft/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/hbbft/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/hbbft/statuses/6b31be7225be8fb94cf5df4accf2dc41e1f2a9eb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 125307734,
"name": "poanetwork/hbbft",
"url": "https://api.github.com/repos/poanetwork/hbbft"
} | {
"id": 7894725,
"login": "afck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7894725?",
"url": "https://api.github.com/users/afck"
} | {
"id": 28943015,
"login": "poanetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28943015?",
"url": "https://api.github.com/orgs/poanetwork"
} | 2018-12-10T13:15:55 | 8726918189 | {"actor":{"display_login":"afck"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments/189407364","pull_request_review_id":121589691,"id":189407364,"diff_hunk":"@@ -24,9 +24,15 @@\n def format_and_mount_boot(args):\n mountpoint = \"/mnt/install/boot\"\n device = \"/dev/installp1\"\n- logging.info(\"(native) format \" + device + \" (boot, ext2), mount to \" +\n+ filesystem = args.deviceinfo[\"boot_filesystem\"] or \"ext2\"","path":"pmb/install/format.py","position":5,"original_position":5,"commit_id":"4bea86d6551f3d29a9e54ea78fafda6dbbf87148","original_commit_id":"83e1aea54d332be3cfbcb167a57e0bebca2ff88c","user":{"login":"drebrez","id":1611547,"avatar_url":"https://avatars0.githubusercontent.com/u/1611547?v=4","gravatar_id":"","url":"https://api.github.com/users/drebrez","html_url":"https://github.com/drebrez","followers_url":"https://api.github.com/users/drebrez/followers","following_url":"https://api.github.com/users/drebrez/following{/other_user}","gists_url":"https://api.github.com/users/drebrez/gists{/gist_id}","starred_url":"https://api.github.com/users/drebrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebrez/subscriptions","organizations_url":"https://api.github.com/users/drebrez/orgs","repos_url":"https://api.github.com/users/drebrez/repos","events_url":"https://api.github.com/users/drebrez/events{/privacy}","received_events_url":"https://api.github.com/users/drebrez/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-18T22:35:05Z","updated_at":"2018-05-18T22:35:05Z","html_url":"https://github.com/postmarketOS/pmbootstrap/pull/1501#discussion_r189407364","pull_request_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments/189407364"},"html":{"href":"https://github.com/postmarketOS/pmbootstrap/pull/1501#discussion_r189407364"},"pull_request":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501"}},"in_reply_to_id":189121267},"pull_request":{"url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501","id":188589494,"html_url":"https://github.com/postmarketOS/pmbootstrap/pull/1501","diff_url":"https://github.com/postmarketOS/pmbootstrap/pull/1501.diff","patch_url":"https://github.com/postmarketOS/pmbootstrap/pull/1501.patch","issue_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1501","number":1501,"state":"open","locked":false,"title":"Add Raspberry Pi device","user":{"login":"drebrez","id":1611547,"avatar_url":"https://avatars0.githubusercontent.com/u/1611547?v=4","gravatar_id":"","url":"https://api.github.com/users/drebrez","html_url":"https://github.com/drebrez","followers_url":"https://api.github.com/users/drebrez/followers","following_url":"https://api.github.com/users/drebrez/following{/other_user}","gists_url":"https://api.github.com/users/drebrez/gists{/gist_id}","starred_url":"https://api.github.com/users/drebrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drebrez/subscriptions","organizations_url":"https://api.github.com/users/drebrez/orgs","repos_url":"https://api.github.com/users/drebrez/repos","events_url":"https://api.github.com/users/drebrez/events{/privacy}","received_events_url":"https://api.github.com/users/drebrez/received_events","type":"User","site_admin":false},"body":"Added a new deviceinfo variable `deviceinfo_boot_filesystem` to specify the desired filesystem for the boot partition.\r\nIn `pmb/install/format.py` it checks if it's a supported value otherwise it raises an exception. Supported for now: fat16 and ext2 (default).\r\nIn order to format in fat16, there is the additional package `dosfstools` (132 kB) installed in the native chroot.\r\n\r\nAbout the Raspberry Pi device files, when you select it in `pmbootstrap init` it will prompt you which kernel to use, this depends on the device version there is a different kernel for it.\r\n```\r\n[10:47:03] Which kernel do you want to use with your device?\r\n[10:47:03] Available kernels (2):\r\n[10:47:03] * rpi: Kernel for the Raspberry Pi Zero & 1\r\n[10:47:03] * rpi2: Kernel for the Raspberry Pi 2 & 3\r\n```\r\nThe `config.txt` and `cmdline.txt` files are taken from the official alpine raspberry pi download (http://dl-cdn.alpinelinux.org/alpine/v3.7/releases/armhf/alpine-rpi-3.7.0-armhf.tar.gz), with the path adapter to our kernel/initramfs location.\r\n\r\nIn the post-install scripts there is the necessity to copy the `.dtb` and `.dtbo` files installed by the kernel package to the `/boot` and `/boot/overlays` folders. Those are required in order to boot the device.\r\n\r\nTested:\r\n- [ ] Raspberry Pi Zero W (steamport)\r\n- [ ] Raspberry Pi 1 Model B (duncan^)\r\n- [x] Raspberry Pi 2 Model B (drebrez)\r\n- [x] Raspberry Pi 3 (MartijnBraam)\r\n\r\nTodo:\r\n- [ ] Update wiki (https://wiki.postmarketos.org/wiki/Raspberry_Pi)\r\n\r\nCloses: #699\r\n\r\n---\r\n[x] Merge on GitHub (see <https://postmarketos.org/merge>)\r\n","created_at":"2018-05-16T23:43:08Z","updated_at":"2018-05-18T22:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4595b563f0559e11ddce801ed5316f9fcc91864","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501/commits","review_comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501/comments","review_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1501/comments","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/4bea86d6551f3d29a9e54ea78fafda6dbbf87148","head":{"label":"postmarketOS:device/raspberry-pi","ref":"device/raspberry-pi","sha":"4bea86d6551f3d29a9e54ea78fafda6dbbf87148","user":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"repo":{"id":92542047,"name":"pmbootstrap","full_name":"postmarketOS/pmbootstrap","owner":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmarketOS/pmbootstrap","description":"Sophisticated chroot/build/flash tool to develop and install postmarketOS","fork":false,"url":"https://api.github.com/repos/postmarketOS/pmbootstrap","forks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/forks","keys_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/teams","hooks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/hooks","issue_events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/events","assignees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/tags","blobs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/languages","stargazers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/stargazers","contributors_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contributors","subscribers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscribers","subscription_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscription","commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/merges","archive_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/downloads","issues_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/labels{/name}","releases_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/deployments","created_at":"2017-05-26T19:25:47Z","updated_at":"2018-05-16T21:59:23Z","pushed_at":"2018-05-18T20:16:45Z","git_url":"git://github.com/postmarketOS/pmbootstrap.git","ssh_url":"git@github.com:postmarketOS/pmbootstrap.git","clone_url":"https://github.com/postmarketOS/pmbootstrap.git","svn_url":"https://github.com/postmarketOS/pmbootstrap","homepage":"","size":13407,"stargazers_count":982,"watchers_count":982,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":165,"open_issues":166,"watchers":982,"default_branch":"master"}},"base":{"label":"postmarketOS:master","ref":"master","sha":"b06aba74b4e34f1ffee05c00ad7f66daa9d22b3a","user":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"repo":{"id":92542047,"name":"pmbootstrap","full_name":"postmarketOS/pmbootstrap","owner":{"login":"postmarketOS","id":28978999,"avatar_url":"https://avatars2.githubusercontent.com/u/28978999?v=4","gravatar_id":"","url":"https://api.github.com/users/postmarketOS","html_url":"https://github.com/postmarketOS","followers_url":"https://api.github.com/users/postmarketOS/followers","following_url":"https://api.github.com/users/postmarketOS/following{/other_user}","gists_url":"https://api.github.com/users/postmarketOS/gists{/gist_id}","starred_url":"https://api.github.com/users/postmarketOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmarketOS/subscriptions","organizations_url":"https://api.github.com/users/postmarketOS/orgs","repos_url":"https://api.github.com/users/postmarketOS/repos","events_url":"https://api.github.com/users/postmarketOS/events{/privacy}","received_events_url":"https://api.github.com/users/postmarketOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmarketOS/pmbootstrap","description":"Sophisticated chroot/build/flash tool to develop and install postmarketOS","fork":false,"url":"https://api.github.com/repos/postmarketOS/pmbootstrap","forks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/forks","keys_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/teams","hooks_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/hooks","issue_events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/events","assignees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/tags","blobs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/languages","stargazers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/stargazers","contributors_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contributors","subscribers_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscribers","subscription_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/subscription","commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/merges","archive_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/downloads","issues_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/labels{/name}","releases_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/postmarketOS/pmbootstrap/deployments","created_at":"2017-05-26T19:25:47Z","updated_at":"2018-05-16T21:59:23Z","pushed_at":"2018-05-18T20:16:45Z","git_url":"git://github.com/postmarketOS/pmbootstrap.git","ssh_url":"git@github.com:postmarketOS/pmbootstrap.git","clone_url":"https://github.com/postmarketOS/pmbootstrap.git","svn_url":"https://github.com/postmarketOS/pmbootstrap","homepage":"","size":13407,"stargazers_count":982,"watchers_count":982,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":165,"open_issues":166,"watchers":982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501"},"html":{"href":"https://github.com/postmarketOS/pmbootstrap/pull/1501"},"issue":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1501"},"comments":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/issues/1501/comments"},"review_comments":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501/comments"},"review_comment":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/pulls/1501/commits"},"statuses":{"href":"https://api.github.com/repos/postmarketOS/pmbootstrap/statuses/4bea86d6551f3d29a9e54ea78fafda6dbbf87148"}},"author_association":"MEMBER"}} | {
"id": 92542047,
"name": "postmarketOS/pmbootstrap",
"url": "https://api.github.com/repos/postmarketOS/pmbootstrap"
} | {
"id": 1611547,
"login": "drebrez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1611547?",
"url": "https://api.github.com/users/drebrez"
} | {
"id": 28978999,
"login": "postmarketOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28978999?",
"url": "https://api.github.com/orgs/postmarketOS"
} | 2018-05-18T22:35:05 | 7698323271 | {"actor":{"display_login":"drebrez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/226880026","pull_request_review_id":166802668,"id":226880026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg4MDAyNg==","diff_hunk":"@@ -984,227 +984,231 @@\n \t\t\t\"path\": \"github.com/hashicorp/terraform/config\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"WzQP2WfiCYlaALKZVqEFsxZsG1o=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/config/configschema\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"3V7300kyZF+AGy/cOKV0+P6M3LY=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/config/hcl2shim\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"7+cYlhS0+Z/xYUzYQft8Wibs1GA=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/config/module\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"mPbjVPD2enEey45bP4M83W2AxlY=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/dag\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"P8gNPDuOzmiK4Lz9xG7OBy4Rlm8=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/flatmap\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"zx5DLo5aV0xDqxGTzSibXg7HHAA=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/acctest\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"uT6Q9RdSRAkDjyUgQlJ2XKJRab4=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/config\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"KNvbU1r5jv0CBeQLnEtDoL3dRtc=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/hashcode\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"B267stWNQd0/pBTXHfI/tJsxzfc=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/hilmapstructure\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"BAXV9ruAyno3aFgwYI2/wWzB2Gc=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/logging\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"twkFd4x71kBnDfrdqO5nhs8dMOY=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/mutexkv\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"9d4zouxtH24HFa6RuUdq7lG3tgQ=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/resource\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"Hnaw+m7E6HQ+me3G/p6pMLU7SXk=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/schema\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"Fzbv+N7hFXOtrR6E7ZcHT3jEE9s=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/structure\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"6O4zxgqAD+QZm6plsIfl4MH310Q=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/helper/validation\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"kD1ayilNruf2cES1LDfNZjYRscQ=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/httpclient\",\n-\t\t\t\"revision\": \"c96155cc68b1da43e49893ddc19a609f0085af19\",\n-\t\t\t\"revisionTime\": \"2018-10-04T21:23:31Z\"\n+\t\t\t\"revision\": \"4e44b41c8bc1b533d14f9939690adf09e3d2a2be\",\n+\t\t\t\"revisionTime\": \"2018-10-19T18:08:03Z\",\n+\t\t\t\"version\": \"v0.11.9\",\n+\t\t\t\"versionExact\": \"v0.11.9\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"yFWmdS6yEJZpRJzUqd/mULqCYGk=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/moduledeps\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"DqaoG++NXRCfvH/OloneLWrM+3k=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/plugin\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"zSwwe4v/eJEBO1m1fLIeroxRbxE=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/plugin/discovery\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n-\t\t\t\"checksumSHA1\": \"R6kmKI5Yetjs3Jwp1NjsetpUzJQ=\",\n+\t\t\t\"checksumSHA1\": \"JO9S/lHcLONtP+lUbr+8M6w4pzk=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/registry\",\n-\t\t\t\"revision\": \"dc8036636ae76c7a7d1a7bd4e0ee09686a216a3b\",\n-\t\t\t\"revisionTime\": \"2018-02-27T16:38:55Z\"\n+\t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n+\t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n+\t\t\t\"version\": \"v0.11.3\",\n+\t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"cR87P4V5aiEfvF+1qoBi2JQyQS4=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/registry/regsrc\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"y9IXgIJQq9XNy1zIYUV2Kc0KsnA=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/registry/response\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"VXlzRRDVOqeMvnnrbUcR9H64OA4=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/svchost\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"GzcKNlFL0N77JVjU8qbltXE4R3k=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/svchost/auth\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"Y4t8+iBORq8ll8t6tmwUozq3FGk=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/svchost/disco\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"4iyhUJFJqtCont3sddyqSD3DFWg=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/terraform\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"+K+oz9mMTmQMxIA3KVkGRfjvm9I=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/tfdiags\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",\n \t\t\t\"versionExact\": \"v0.11.3\"\n \t\t},\n \t\t{\n \t\t\t\"checksumSHA1\": \"R43En+SNnXiSxTUecrW58Ohprmc=\",\n \t\t\t\"path\": \"github.com/hashicorp/terraform/version\",\n \t\t\t\"revision\": \"3802b14260603f90c7a1faf55994dcc8933e2069\",\n \t\t\t\"revisionTime\": \"2018-01-31T20:48:39Z\",\n-\t\t\t\"version\": \"=v0.11.3\",\n+\t\t\t\"version\": \"v0.11.3\",","path":"vendor/vendor.json","position":278,"original_position":278,"commit_id":"dab9a05f555cf581a9201391434ebde1cd6933b2","original_commit_id":"dab9a05f555cf581a9201391434ebde1cd6933b2","user":{"login":"tombuildsstuff","id":666005,"node_id":"MDQ6VXNlcjY2NjAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/666005?v=4","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"body":"we should pin these to the same version of TFCore (0.11.9)","created_at":"2018-10-21T22:00:04Z","updated_at":"2018-10-21T22:00:04Z","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121#discussion_r226880026","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/226880026"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121#discussion_r226880026"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121","id":224439435,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDM5NDM1","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121","diff_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/2121","number":2121,"state":"open","locked":false,"title":"vendor house keeping","user":{"login":"katbyte","id":1638467,"node_id":"MDQ6VXNlcjE2Mzg0Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1638467?v=4","gravatar_id":"","url":"https://api.github.com/users/katbyte","html_url":"https://github.com/katbyte","followers_url":"https://api.github.com/users/katbyte/followers","following_url":"https://api.github.com/users/katbyte/following{/other_user}","gists_url":"https://api.github.com/users/katbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/katbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katbyte/subscriptions","organizations_url":"https://api.github.com/users/katbyte/orgs","repos_url":"https://api.github.com/users/katbyte/repos","events_url":"https://api.github.com/users/katbyte/events{/privacy}","received_events_url":"https://api.github.com/users/katbyte/received_events","type":"User","site_admin":false},"body":"- remove unused azure DNS package\r\n- remove =s from all package versions\r\n- set httpclient version to 0.11.9 (first version it is available\"","created_at":"2018-10-20T00:26:07Z","updated_at":"2018-10-21T22:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af4883d4d62c9ad99b4ec18a5dd0faba1129a3f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737912011,"node_id":"MDU6TGFiZWw3Mzc5MTIwMTE=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/size/XXL","name":"size/XXL","color":"ffffff","default":false},{"id":810203018,"node_id":"MDU6TGFiZWw4MTAyMDMwMTg=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/technical-debt","name":"technical-debt","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones/29","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/milestone/29","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones/29/labels","id":3753197,"node_id":"MDk6TWlsZXN0b25lMzc1MzE5Nw==","number":29,"title":"1.17.1","description":null,"creator":{"login":"katbyte","id":1638467,"node_id":"MDQ6VXNlcjE2Mzg0Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1638467?v=4","gravatar_id":"","url":"https://api.github.com/users/katbyte","html_url":"https://github.com/katbyte","followers_url":"https://api.github.com/users/katbyte/followers","following_url":"https://api.github.com/users/katbyte/following{/other_user}","gists_url":"https://api.github.com/users/katbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/katbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katbyte/subscriptions","organizations_url":"https://api.github.com/users/katbyte/orgs","repos_url":"https://api.github.com/users/katbyte/repos","events_url":"https://api.github.com/users/katbyte/events{/privacy}","received_events_url":"https://api.github.com/users/katbyte/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":6,"state":"open","created_at":"2018-10-19T21:31:31Z","updated_at":"2018-10-21T21:53:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/2121/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/dab9a05f555cf581a9201391434ebde1cd6933b2","head":{"label":"terraform-providers:tidy-vendor","ref":"tidy-vendor","sha":"dab9a05f555cf581a9201391434ebde1cd6933b2","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-10-21T21:53:48Z","pushed_at":"2018-10-21T21:56:42Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":23474,"stargazers_count":496,"watchers_count":496,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":473,"open_issues":348,"watchers":496,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"2b3b8b13c8b9c123e3019e5ae24e53a29d70adbd","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-10-21T21:53:48Z","pushed_at":"2018-10-21T21:56:42Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":23474,"stargazers_count":496,"watchers_count":496,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":473,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":473,"open_issues":348,"watchers":496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/2121"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/2121"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/2121/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/2121/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/dab9a05f555cf581a9201391434ebde1cd6933b2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 93446042,
"name": "terraform-providers/terraform-provider-azurerm",
"url": "https://api.github.com/repos/terraform-providers/terraform-provider-azurerm"
} | {
"id": 666005,
"login": "tombuildsstuff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/666005?",
"url": "https://api.github.com/users/tombuildsstuff"
} | {
"id": 29154831,
"login": "terraform-providers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29154831?",
"url": "https://api.github.com/orgs/terraform-providers"
} | 2018-10-21T22:00:04 | 8456189509 | {"actor":{"display_login":"tombuildsstuff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/213264259","pull_request_review_id":150062893,"id":213264259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI2NDI1OQ==","diff_hunk":"@@ -214,4 +219,52 @@ std::unique_ptr<IDiversifier> MatchToolsFactory::createDiversifier() const\n _diversityParams.cutoff_strategy == DiversityParams::CutoffStrategy::STRICT);\n }\n \n+std::unique_ptr<AttributeOperationTask>\n+MatchToolsFactory::createTask(vespalib::stringref attribute, vespalib::stringref operation) const {\n+ return (!attribute.empty() && ! operation.empty())\n+ ? std::make_unique<AttributeOperationTask>(_requestContext, attribute, operation)\n+ : std::unique_ptr<AttributeOperationTask>();\n+}\n+std::unique_ptr<AttributeOperationTask>\n+MatchToolsFactory::createOnMatchTask() const {\n+ return createTask(execute::onmatch::Attribute::lookup(_queryEnv.getProperties()),","path":"searchcore/src/vespa/searchcore/proton/matching/match_tools.cpp","position":44,"original_position":44,"commit_id":"60d9e3beca7ebeca83ac5fd96f1950ba4578bfc9","original_commit_id":"8ee3a24c5a39f5940537968516050702ac45b3eb","user":{"login":"baldersheim","id":19857788,"node_id":"MDQ6VXNlcjE5ODU3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/19857788?v=4","gravatar_id":"","url":"https://api.github.com/users/baldersheim","html_url":"https://github.com/baldersheim","followers_url":"https://api.github.com/users/baldersheim/followers","following_url":"https://api.github.com/users/baldersheim/following{/other_user}","gists_url":"https://api.github.com/users/baldersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/baldersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldersheim/subscriptions","organizations_url":"https://api.github.com/users/baldersheim/orgs","repos_url":"https://api.github.com/users/baldersheim/repos","events_url":"https://api.github.com/users/baldersheim/events{/privacy}","received_events_url":"https://api.github.com/users/baldersheim/received_events","type":"User","site_admin":false},"body":"No, nothing definitive here. But as you need to specify 'mutable' you will not accidentally run into it. WE will wait until we see use cases more clearly.","created_at":"2018-08-28T10:41:39Z","updated_at":"2018-08-28T10:41:40Z","html_url":"https://github.com/vespa-engine/vespa/pull/6680#discussion_r213264259","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/213264259"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6680#discussion_r213264259"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680"}},"in_reply_to_id":212999244},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680","id":211067722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDY3NzIy","html_url":"https://github.com/vespa-engine/vespa/pull/6680","diff_url":"https://github.com/vespa-engine/vespa/pull/6680.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/6680.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6680","number":6680,"state":"open","locked":false,"title":"Balder/update attributes","user":{"login":"baldersheim","id":19857788,"node_id":"MDQ6VXNlcjE5ODU3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/19857788?v=4","gravatar_id":"","url":"https://api.github.com/users/baldersheim","html_url":"https://github.com/baldersheim","followers_url":"https://api.github.com/users/baldersheim/followers","following_url":"https://api.github.com/users/baldersheim/following{/other_user}","gists_url":"https://api.github.com/users/baldersheim/gists{/gist_id}","starred_url":"https://api.github.com/users/baldersheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldersheim/subscriptions","organizations_url":"https://api.github.com/users/baldersheim/orgs","repos_url":"https://api.github.com/users/baldersheim/repos","events_url":"https://api.github.com/users/baldersheim/events{/privacy}","received_events_url":"https://api.github.com/users/baldersheim/received_events","type":"User","site_admin":false},"body":"@havardpe PR","created_at":"2018-08-27T10:24:45Z","updated_at":"2018-08-28T10:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95e7d8f8af977c94d910b97182279ea414b8f505","assignee":null,"assignees":[],"requested_reviewers":[{"login":"toregge","id":19347706,"node_id":"MDQ6VXNlcjE5MzQ3NzA2","avatar_url":"https://avatars2.githubusercontent.com/u/19347706?v=4","gravatar_id":"","url":"https://api.github.com/users/toregge","html_url":"https://github.com/toregge","followers_url":"https://api.github.com/users/toregge/followers","following_url":"https://api.github.com/users/toregge/following{/other_user}","gists_url":"https://api.github.com/users/toregge/gists{/gist_id}","starred_url":"https://api.github.com/users/toregge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toregge/subscriptions","organizations_url":"https://api.github.com/users/toregge/orgs","repos_url":"https://api.github.com/users/toregge/repos","events_url":"https://api.github.com/users/toregge/events{/privacy}","received_events_url":"https://api.github.com/users/toregge/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6680/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/60d9e3beca7ebeca83ac5fd96f1950ba4578bfc9","head":{"label":"vespa-engine:balder/update-attributes","ref":"balder/update-attributes","sha":"60d9e3beca7ebeca83ac5fd96f1950ba4578bfc9","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-08-28T10:28:41Z","pushed_at":"2018-08-28T10:41:33Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":74258,"stargazers_count":2566,"watchers_count":2566,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":303,"open_issues":56,"watchers":2566,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"2ef5934a74134ea424b68d35f422af01ee3af3dd","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-08-28T10:28:41Z","pushed_at":"2018-08-28T10:41:33Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":74258,"stargazers_count":2566,"watchers_count":2566,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":303,"open_issues":56,"watchers":2566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6680"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6680"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6680/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6680/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/60d9e3beca7ebeca83ac5fd96f1950ba4578bfc9"}},"author_association":"MEMBER"}} | {
"id": 60377070,
"name": "vespa-engine/vespa",
"url": "https://api.github.com/repos/vespa-engine/vespa"
} | {
"id": 19857788,
"login": "baldersheim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19857788?",
"url": "https://api.github.com/users/baldersheim"
} | {
"id": 29299694,
"login": "vespa-engine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29299694?",
"url": "https://api.github.com/orgs/vespa-engine"
} | 2018-08-28T10:41:39 | 8177431521 | {"actor":{"display_login":"baldersheim"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/214716419","pull_request_review_id":151828640,"id":214716419,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDcxNjQxOQ==","diff_hunk":"@@ -0,0 +1,232 @@\n+// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.\n+package com.yahoo.jrt;\n+\n+import javax.net.ssl.SSLEngine;\n+import javax.net.ssl.SSLEngineResult;\n+import javax.net.ssl.SSLException;\n+import javax.net.ssl.SSLSession;\n+import java.io.IOException;\n+import java.nio.ByteBuffer;\n+import java.nio.channels.ClosedChannelException;\n+import java.nio.channels.SocketChannel;\n+import java.util.logging.Logger;\n+\n+import static javax.net.ssl.SSLEngineResult.*;\n+\n+/**\n+ * A {@link CryptoSocket} using TLS ({@link SSLEngine})\n+ *\n+ * @author bjorncs\n+ */\n+public class SslSocket implements CryptoSocket {\n+\n+ private static final Logger log = Logger.getLogger(SslSocket.class.getName());\n+\n+ private enum HandshakeState { NOT_STARTED, NEED_READ, NEED_WRITE, COMPLETED }\n+\n+ private final SocketChannel channel;\n+ private final SSLEngine sslEngine;\n+ private final ByteBuffer wrapBuffer;\n+ private final ByteBuffer unwrapBuffer;\n+ private final ByteBuffer handshakeDummyBuffer;\n+ private HandshakeState handshakeState;\n+\n+ public SslSocket(SocketChannel channel, SSLEngine sslEngine) {\n+ this.channel = channel;\n+ this.sslEngine = sslEngine;\n+ SSLSession nullSession = sslEngine.getSession();\n+ this.wrapBuffer = ByteBuffer.allocate(nullSession.getPacketBufferSize() * 2);\n+ this.unwrapBuffer = ByteBuffer.allocate(nullSession.getPacketBufferSize() * 2);\n+ // Note: Dummy buffer as unwrap requires a full size application buffer even though no application data is unwrapped\n+ this.handshakeDummyBuffer = ByteBuffer.allocate(nullSession.getApplicationBufferSize());\n+ this.handshakeState = HandshakeState.NOT_STARTED;\n+ }\n+\n+ @Override\n+ public SocketChannel channel() {\n+ return channel;\n+ }\n+\n+ @Override\n+ public HandshakeResult handshake() throws IOException {\n+ HandshakeState newHandshakeState = processHandshakeState(this.handshakeState);\n+ log.fine(() -> String.format(\"Handshake state '%s -> %s'\", this.handshakeState, newHandshakeState));\n+ this.handshakeState = newHandshakeState;\n+ return toHandshakeResult(newHandshakeState);\n+ }\n+\n+ private HandshakeState processHandshakeState(HandshakeState state) throws IOException {\n+ switch (state) {\n+ case NOT_STARTED:\n+ sslEngine.beginHandshake();\n+ break;\n+ case NEED_WRITE:\n+ channelWrite();\n+ break;\n+ case NEED_READ:\n+ channelRead();\n+ break;\n+ case COMPLETED:\n+ return HandshakeState.COMPLETED;\n+ default:\n+ throw new IllegalStateException(\"Unhandled state: \" + state);\n+ }\n+\n+ while (true) {\n+ switch (sslEngine.getHandshakeStatus()) {\n+ case NOT_HANDSHAKING:\n+ if (hasWrapBufferMoreData()) return HandshakeState.NEED_WRITE;\n+ sslEngine.setEnableSessionCreation(false); // disable renegotiation\n+ return HandshakeState.COMPLETED;\n+ case NEED_TASK:\n+ sslEngine.getDelegatedTask().run();\n+ break;\n+ case NEED_UNWRAP:\n+ if (hasWrapBufferMoreData()) return HandshakeState.NEED_WRITE;\n+ int bytesUnwrapped = sslEngineUnwrap(handshakeDummyBuffer);\n+ if (handshakeDummyBuffer.position() > 0) throw new SSLException(\"Got application data in handshake unwrap: \" + handshakeDummyBuffer);","path":"jrt/src/com/yahoo/jrt/SslSocket.java","position":null,"original_position":87,"commit_id":"f7ab4bc80b354d5db31119772a801034d72e0ec6","original_commit_id":"418c52b59b1ac2f3a188f5de174b1f3497dc78c5","user":{"login":"vekterli","id":16582643,"node_id":"MDQ6VXNlcjE2NTgyNjQz","avatar_url":"https://avatars1.githubusercontent.com/u/16582643?v=4","gravatar_id":"","url":"https://api.github.com/users/vekterli","html_url":"https://github.com/vekterli","followers_url":"https://api.github.com/users/vekterli/followers","following_url":"https://api.github.com/users/vekterli/following{/other_user}","gists_url":"https://api.github.com/users/vekterli/gists{/gist_id}","starred_url":"https://api.github.com/users/vekterli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vekterli/subscriptions","organizations_url":"https://api.github.com/users/vekterli/orgs","repos_url":"https://api.github.com/users/vekterli/repos","events_url":"https://api.github.com/users/vekterli/events{/privacy}","received_events_url":"https://api.github.com/users/vekterli/received_events","type":"User","site_admin":false},"body":"Was pondering if this could trigger if a server peer pipelines its `Finished` packet with the first application data, but assuming unwrap() only processes 1 handshake frame per invocation during handshaking it _shouldn't_. Are my assumptions correct?","created_at":"2018-09-03T15:05:27Z","updated_at":"2018-09-03T15:40:13Z","html_url":"https://github.com/vespa-engine/vespa/pull/6770#discussion_r214716419","pull_request_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments/214716419"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6770#discussion_r214716419"},"pull_request":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770"}}},"pull_request":{"url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770","id":212751427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzUxNDI3","html_url":"https://github.com/vespa-engine/vespa/pull/6770","diff_url":"https://github.com/vespa-engine/vespa/pull/6770.diff","patch_url":"https://github.com/vespa-engine/vespa/pull/6770.patch","issue_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6770","number":6770,"state":"open","locked":false,"title":"Bjorncs/jrt ssl socket","user":{"login":"bjorncs","id":798335,"node_id":"MDQ6VXNlcjc5ODMzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/798335?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorncs","html_url":"https://github.com/bjorncs","followers_url":"https://api.github.com/users/bjorncs/followers","following_url":"https://api.github.com/users/bjorncs/following{/other_user}","gists_url":"https://api.github.com/users/bjorncs/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorncs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorncs/subscriptions","organizations_url":"https://api.github.com/users/bjorncs/orgs","repos_url":"https://api.github.com/users/bjorncs/repos","events_url":"https://api.github.com/users/bjorncs/events{/privacy}","received_events_url":"https://api.github.com/users/bjorncs/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-03T13:36:01Z","updated_at":"2018-09-03T15:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"863b537dd541fcc1693d77eeee33a9f523901740","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770/commits","review_comments_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770/comments","review_comment_url":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/issues/6770/comments","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/f7ab4bc80b354d5db31119772a801034d72e0ec6","head":{"label":"vespa-engine:bjorncs/jrt-ssl-socket","ref":"bjorncs/jrt-ssl-socket","sha":"f7ab4bc80b354d5db31119772a801034d72e0ec6","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-09-03T13:18:32Z","pushed_at":"2018-09-03T15:22:45Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":74660,"stargazers_count":2567,"watchers_count":2567,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":303,"open_issues":55,"watchers":2567,"default_branch":"master"}},"base":{"label":"vespa-engine:master","ref":"master","sha":"ae594f2b7453ff1c5109fd8a9cec9339ec0a6366","user":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":60377070,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NzA3MA==","name":"vespa","full_name":"vespa-engine/vespa","owner":{"login":"vespa-engine","id":29299694,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mjk5Njk0","avatar_url":"https://avatars1.githubusercontent.com/u/29299694?v=4","gravatar_id":"","url":"https://api.github.com/users/vespa-engine","html_url":"https://github.com/vespa-engine","followers_url":"https://api.github.com/users/vespa-engine/followers","following_url":"https://api.github.com/users/vespa-engine/following{/other_user}","gists_url":"https://api.github.com/users/vespa-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/vespa-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vespa-engine/subscriptions","organizations_url":"https://api.github.com/users/vespa-engine/orgs","repos_url":"https://api.github.com/users/vespa-engine/repos","events_url":"https://api.github.com/users/vespa-engine/events{/privacy}","received_events_url":"https://api.github.com/users/vespa-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vespa-engine/vespa","description":"Vespa - the open big data serving engine","fork":false,"url":"https://api.github.com/repos/vespa-engine/vespa","forks_url":"https://api.github.com/repos/vespa-engine/vespa/forks","keys_url":"https://api.github.com/repos/vespa-engine/vespa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vespa-engine/vespa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vespa-engine/vespa/teams","hooks_url":"https://api.github.com/repos/vespa-engine/vespa/hooks","issue_events_url":"https://api.github.com/repos/vespa-engine/vespa/issues/events{/number}","events_url":"https://api.github.com/repos/vespa-engine/vespa/events","assignees_url":"https://api.github.com/repos/vespa-engine/vespa/assignees{/user}","branches_url":"https://api.github.com/repos/vespa-engine/vespa/branches{/branch}","tags_url":"https://api.github.com/repos/vespa-engine/vespa/tags","blobs_url":"https://api.github.com/repos/vespa-engine/vespa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vespa-engine/vespa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vespa-engine/vespa/git/refs{/sha}","trees_url":"https://api.github.com/repos/vespa-engine/vespa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vespa-engine/vespa/statuses/{sha}","languages_url":"https://api.github.com/repos/vespa-engine/vespa/languages","stargazers_url":"https://api.github.com/repos/vespa-engine/vespa/stargazers","contributors_url":"https://api.github.com/repos/vespa-engine/vespa/contributors","subscribers_url":"https://api.github.com/repos/vespa-engine/vespa/subscribers","subscription_url":"https://api.github.com/repos/vespa-engine/vespa/subscription","commits_url":"https://api.github.com/repos/vespa-engine/vespa/commits{/sha}","git_commits_url":"https://api.github.com/repos/vespa-engine/vespa/git/commits{/sha}","comments_url":"https://api.github.com/repos/vespa-engine/vespa/comments{/number}","issue_comment_url":"https://api.github.com/repos/vespa-engine/vespa/issues/comments{/number}","contents_url":"https://api.github.com/repos/vespa-engine/vespa/contents/{+path}","compare_url":"https://api.github.com/repos/vespa-engine/vespa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vespa-engine/vespa/merges","archive_url":"https://api.github.com/repos/vespa-engine/vespa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vespa-engine/vespa/downloads","issues_url":"https://api.github.com/repos/vespa-engine/vespa/issues{/number}","pulls_url":"https://api.github.com/repos/vespa-engine/vespa/pulls{/number}","milestones_url":"https://api.github.com/repos/vespa-engine/vespa/milestones{/number}","notifications_url":"https://api.github.com/repos/vespa-engine/vespa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vespa-engine/vespa/labels{/name}","releases_url":"https://api.github.com/repos/vespa-engine/vespa/releases{/id}","deployments_url":"https://api.github.com/repos/vespa-engine/vespa/deployments","created_at":"2016-06-03T20:54:20Z","updated_at":"2018-09-03T13:18:32Z","pushed_at":"2018-09-03T15:22:45Z","git_url":"git://github.com/vespa-engine/vespa.git","ssh_url":"git@github.com:vespa-engine/vespa.git","clone_url":"https://github.com/vespa-engine/vespa.git","svn_url":"https://github.com/vespa-engine/vespa","homepage":"http://vespa.ai/","size":74660,"stargazers_count":2567,"watchers_count":2567,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":303,"open_issues":55,"watchers":2567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770"},"html":{"href":"https://github.com/vespa-engine/vespa/pull/6770"},"issue":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6770"},"comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/issues/6770/comments"},"review_comments":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770/comments"},"review_comment":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vespa-engine/vespa/pulls/6770/commits"},"statuses":{"href":"https://api.github.com/repos/vespa-engine/vespa/statuses/f7ab4bc80b354d5db31119772a801034d72e0ec6"}},"author_association":"MEMBER"}} | {
"id": 60377070,
"name": "vespa-engine/vespa",
"url": "https://api.github.com/repos/vespa-engine/vespa"
} | {
"id": 16582643,
"login": "vekterli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16582643?",
"url": "https://api.github.com/users/vekterli"
} | {
"id": 29299694,
"login": "vespa-engine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29299694?",
"url": "https://api.github.com/orgs/vespa-engine"
} | 2018-09-03T15:05:27 | 8207073239 | {"actor":{"display_login":"vekterli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/funfix/monix.js/pulls/comments/171576563","pull_request_review_id":100452299,"id":171576563,"diff_hunk":"@@ -61,6 +61,6 @@\n \"reactive streams\"\n ],\n \"dependencies\": {\n- \"monix-types\": \"0.0.0-development\"\n+ \"funfix\": \"^6.2.2\"","path":"packages/monix-reactive/package.json","position":5,"original_position":5,"commit_id":"76e1d2ba24235dd8b7bdbbbe089ba2370f44fc8d","original_commit_id":"76e1d2ba24235dd8b7bdbbbe089ba2370f44fc8d","user":{"login":"alexandru","id":11753,"avatar_url":"https://avatars2.githubusercontent.com/u/11753?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandru","html_url":"https://github.com/alexandru","followers_url":"https://api.github.com/users/alexandru/followers","following_url":"https://api.github.com/users/alexandru/following{/other_user}","gists_url":"https://api.github.com/users/alexandru/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru/subscriptions","organizations_url":"https://api.github.com/users/alexandru/orgs","repos_url":"https://api.github.com/users/alexandru/repos","events_url":"https://api.github.com/users/alexandru/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru/received_events","type":"User","site_admin":false},"body":"I should really publish version 7 already, it's at release candidate. Will let you know.\r\n","created_at":"2018-03-01T14:35:03Z","updated_at":"2018-03-01T14:35:18Z","html_url":"https://github.com/funfix/monix.js/pull/8#discussion_r171576563","pull_request_url":"https://api.github.com/repos/funfix/monix.js/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/comments/171576563"},"html":{"href":"https://github.com/funfix/monix.js/pull/8#discussion_r171576563"},"pull_request":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/funfix/monix.js/pulls/8","id":172199400,"html_url":"https://github.com/funfix/monix.js/pull/8","diff_url":"https://github.com/funfix/monix.js/pull/8.diff","patch_url":"https://github.com/funfix/monix.js/pull/8.patch","issue_url":"https://api.github.com/repos/funfix/monix.js/issues/8","number":8,"state":"open","locked":false,"title":"Cleanup/drop monix types pkg","user":{"login":"lostintime","id":722841,"avatar_url":"https://avatars0.githubusercontent.com/u/722841?v=4","gravatar_id":"","url":"https://api.github.com/users/lostintime","html_url":"https://github.com/lostintime","followers_url":"https://api.github.com/users/lostintime/followers","following_url":"https://api.github.com/users/lostintime/following{/other_user}","gists_url":"https://api.github.com/users/lostintime/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintime/subscriptions","organizations_url":"https://api.github.com/users/lostintime/orgs","repos_url":"https://api.github.com/users/lostintime/repos","events_url":"https://api.github.com/users/lostintime/events{/privacy}","received_events_url":"https://api.github.com/users/lostintime/received_events","type":"User","site_admin":false},"body":"Drops `monix-types` package (resolves #5)\r\nDrops `WithScheduler` interface (resolves #6)\r\nDrops `IObservable` interface\r\n\r\n`Observable` now extends `ObservableInstance` to hide later for clients, ex: \r\n```typescript\r\nimport { Observable } from \"monix\"\r\n\r\nfunction doSomethingOn<A>(a: Observable<A>): Observable<A> {\r\n return a\r\n}\r\n```\r\n\r\nIs it worth it to create flow definitions for internals, while those not exposed to clients?\r\n\r\nWhat is the right way to run `test:watch` using `lerna`, `lerna run --scope=monix-reactive test:watch` doesn't seem to work?\r\n\r\nHow to get rid of `flow-typed` folders? not it fails with:\r\n\r\n```\r\nCannot resolve module `funfix`.\r\n\r\n 20| import type { Future } from \"funfix\"\r\n ^^^^^^^^\r\n```\r\n\r\n`node_modules` removed from ignored in [.flowconfig](https://github.com/funfix/monix.js/blob/cleanup/drop_monix_types_pkg/common/.flowconfig)\r\n","created_at":"2018-03-01T10:37:26Z","updated_at":"2018-03-01T14:35:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc4199047e8c47914258feea3662373c7bdf0adc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/funfix/monix.js/pulls/8/commits","review_comments_url":"https://api.github.com/repos/funfix/monix.js/pulls/8/comments","review_comment_url":"https://api.github.com/repos/funfix/monix.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/funfix/monix.js/issues/8/comments","statuses_url":"https://api.github.com/repos/funfix/monix.js/statuses/76e1d2ba24235dd8b7bdbbbe089ba2370f44fc8d","head":{"label":"funfix:cleanup/drop_monix_types_pkg","ref":"cleanup/drop_monix_types_pkg","sha":"76e1d2ba24235dd8b7bdbbbe089ba2370f44fc8d","user":{"login":"funfix","id":29314073,"avatar_url":"https://avatars0.githubusercontent.com/u/29314073?v=4","gravatar_id":"","url":"https://api.github.com/users/funfix","html_url":"https://github.com/funfix","followers_url":"https://api.github.com/users/funfix/followers","following_url":"https://api.github.com/users/funfix/following{/other_user}","gists_url":"https://api.github.com/users/funfix/gists{/gist_id}","starred_url":"https://api.github.com/users/funfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funfix/subscriptions","organizations_url":"https://api.github.com/users/funfix/orgs","repos_url":"https://api.github.com/users/funfix/repos","events_url":"https://api.github.com/users/funfix/events{/privacy}","received_events_url":"https://api.github.com/users/funfix/received_events","type":"Organization","site_admin":false},"repo":{"id":112912103,"name":"monix.js","full_name":"funfix/monix.js","owner":{"login":"funfix","id":29314073,"avatar_url":"https://avatars0.githubusercontent.com/u/29314073?v=4","gravatar_id":"","url":"https://api.github.com/users/funfix","html_url":"https://github.com/funfix","followers_url":"https://api.github.com/users/funfix/followers","following_url":"https://api.github.com/users/funfix/following{/other_user}","gists_url":"https://api.github.com/users/funfix/gists{/gist_id}","starred_url":"https://api.github.com/users/funfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funfix/subscriptions","organizations_url":"https://api.github.com/users/funfix/orgs","repos_url":"https://api.github.com/users/funfix/repos","events_url":"https://api.github.com/users/funfix/events{/privacy}","received_events_url":"https://api.github.com/users/funfix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/funfix/monix.js","description":"JS/TypeScript/Flow library for composing asynchronous and event-based programs","fork":false,"url":"https://api.github.com/repos/funfix/monix.js","forks_url":"https://api.github.com/repos/funfix/monix.js/forks","keys_url":"https://api.github.com/repos/funfix/monix.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funfix/monix.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funfix/monix.js/teams","hooks_url":"https://api.github.com/repos/funfix/monix.js/hooks","issue_events_url":"https://api.github.com/repos/funfix/monix.js/issues/events{/number}","events_url":"https://api.github.com/repos/funfix/monix.js/events","assignees_url":"https://api.github.com/repos/funfix/monix.js/assignees{/user}","branches_url":"https://api.github.com/repos/funfix/monix.js/branches{/branch}","tags_url":"https://api.github.com/repos/funfix/monix.js/tags","blobs_url":"https://api.github.com/repos/funfix/monix.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funfix/monix.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funfix/monix.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/funfix/monix.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funfix/monix.js/statuses/{sha}","languages_url":"https://api.github.com/repos/funfix/monix.js/languages","stargazers_url":"https://api.github.com/repos/funfix/monix.js/stargazers","contributors_url":"https://api.github.com/repos/funfix/monix.js/contributors","subscribers_url":"https://api.github.com/repos/funfix/monix.js/subscribers","subscription_url":"https://api.github.com/repos/funfix/monix.js/subscription","commits_url":"https://api.github.com/repos/funfix/monix.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/funfix/monix.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/funfix/monix.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/funfix/monix.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/funfix/monix.js/contents/{+path}","compare_url":"https://api.github.com/repos/funfix/monix.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funfix/monix.js/merges","archive_url":"https://api.github.com/repos/funfix/monix.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funfix/monix.js/downloads","issues_url":"https://api.github.com/repos/funfix/monix.js/issues{/number}","pulls_url":"https://api.github.com/repos/funfix/monix.js/pulls{/number}","milestones_url":"https://api.github.com/repos/funfix/monix.js/milestones{/number}","notifications_url":"https://api.github.com/repos/funfix/monix.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funfix/monix.js/labels{/name}","releases_url":"https://api.github.com/repos/funfix/monix.js/releases{/id}","deployments_url":"https://api.github.com/repos/funfix/monix.js/deployments","created_at":"2017-12-03T08:29:19Z","updated_at":"2018-03-01T07:27:06Z","pushed_at":"2018-03-01T13:53:23Z","git_url":"git://github.com/funfix/monix.js.git","ssh_url":"git@github.com:funfix/monix.js.git","clone_url":"https://github.com/funfix/monix.js.git","svn_url":"https://github.com/funfix/monix.js","homepage":null,"size":215,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"funfix:master","ref":"master","sha":"49c5b5908bff0c0c4c59a801308a2b69f68ff53b","user":{"login":"funfix","id":29314073,"avatar_url":"https://avatars0.githubusercontent.com/u/29314073?v=4","gravatar_id":"","url":"https://api.github.com/users/funfix","html_url":"https://github.com/funfix","followers_url":"https://api.github.com/users/funfix/followers","following_url":"https://api.github.com/users/funfix/following{/other_user}","gists_url":"https://api.github.com/users/funfix/gists{/gist_id}","starred_url":"https://api.github.com/users/funfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funfix/subscriptions","organizations_url":"https://api.github.com/users/funfix/orgs","repos_url":"https://api.github.com/users/funfix/repos","events_url":"https://api.github.com/users/funfix/events{/privacy}","received_events_url":"https://api.github.com/users/funfix/received_events","type":"Organization","site_admin":false},"repo":{"id":112912103,"name":"monix.js","full_name":"funfix/monix.js","owner":{"login":"funfix","id":29314073,"avatar_url":"https://avatars0.githubusercontent.com/u/29314073?v=4","gravatar_id":"","url":"https://api.github.com/users/funfix","html_url":"https://github.com/funfix","followers_url":"https://api.github.com/users/funfix/followers","following_url":"https://api.github.com/users/funfix/following{/other_user}","gists_url":"https://api.github.com/users/funfix/gists{/gist_id}","starred_url":"https://api.github.com/users/funfix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funfix/subscriptions","organizations_url":"https://api.github.com/users/funfix/orgs","repos_url":"https://api.github.com/users/funfix/repos","events_url":"https://api.github.com/users/funfix/events{/privacy}","received_events_url":"https://api.github.com/users/funfix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/funfix/monix.js","description":"JS/TypeScript/Flow library for composing asynchronous and event-based programs","fork":false,"url":"https://api.github.com/repos/funfix/monix.js","forks_url":"https://api.github.com/repos/funfix/monix.js/forks","keys_url":"https://api.github.com/repos/funfix/monix.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funfix/monix.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funfix/monix.js/teams","hooks_url":"https://api.github.com/repos/funfix/monix.js/hooks","issue_events_url":"https://api.github.com/repos/funfix/monix.js/issues/events{/number}","events_url":"https://api.github.com/repos/funfix/monix.js/events","assignees_url":"https://api.github.com/repos/funfix/monix.js/assignees{/user}","branches_url":"https://api.github.com/repos/funfix/monix.js/branches{/branch}","tags_url":"https://api.github.com/repos/funfix/monix.js/tags","blobs_url":"https://api.github.com/repos/funfix/monix.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funfix/monix.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funfix/monix.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/funfix/monix.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funfix/monix.js/statuses/{sha}","languages_url":"https://api.github.com/repos/funfix/monix.js/languages","stargazers_url":"https://api.github.com/repos/funfix/monix.js/stargazers","contributors_url":"https://api.github.com/repos/funfix/monix.js/contributors","subscribers_url":"https://api.github.com/repos/funfix/monix.js/subscribers","subscription_url":"https://api.github.com/repos/funfix/monix.js/subscription","commits_url":"https://api.github.com/repos/funfix/monix.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/funfix/monix.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/funfix/monix.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/funfix/monix.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/funfix/monix.js/contents/{+path}","compare_url":"https://api.github.com/repos/funfix/monix.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funfix/monix.js/merges","archive_url":"https://api.github.com/repos/funfix/monix.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funfix/monix.js/downloads","issues_url":"https://api.github.com/repos/funfix/monix.js/issues{/number}","pulls_url":"https://api.github.com/repos/funfix/monix.js/pulls{/number}","milestones_url":"https://api.github.com/repos/funfix/monix.js/milestones{/number}","notifications_url":"https://api.github.com/repos/funfix/monix.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funfix/monix.js/labels{/name}","releases_url":"https://api.github.com/repos/funfix/monix.js/releases{/id}","deployments_url":"https://api.github.com/repos/funfix/monix.js/deployments","created_at":"2017-12-03T08:29:19Z","updated_at":"2018-03-01T07:27:06Z","pushed_at":"2018-03-01T13:53:23Z","git_url":"git://github.com/funfix/monix.js.git","ssh_url":"git@github.com:funfix/monix.js.git","clone_url":"https://github.com/funfix/monix.js.git","svn_url":"https://github.com/funfix/monix.js","homepage":null,"size":215,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/8"},"html":{"href":"https://github.com/funfix/monix.js/pull/8"},"issue":{"href":"https://api.github.com/repos/funfix/monix.js/issues/8"},"comments":{"href":"https://api.github.com/repos/funfix/monix.js/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/funfix/monix.js/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/funfix/monix.js/statuses/76e1d2ba24235dd8b7bdbbbe089ba2370f44fc8d"}},"author_association":"COLLABORATOR"}} | {
"id": 112912103,
"name": "funfix/monix.js",
"url": "https://api.github.com/repos/funfix/monix.js"
} | {
"id": 11753,
"login": "alexandru",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11753?",
"url": "https://api.github.com/users/alexandru"
} | {
"id": 29314073,
"login": "funfix",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29314073?",
"url": "https://api.github.com/orgs/funfix"
} | 2018-03-01T14:35:03 | 7316440012 | {"actor":{"display_login":"alexandru"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/comments/243618454","pull_request_review_id":187443017,"id":243618454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzYxODQ1NA==","diff_hunk":"@@ -46,8 +46,44 @@ public struct Snapshotting<Value, Format> {\n }\n }\n \n+ /// Transforms a strategy on `Value`s into a strategy on `NewValue`s through a function\n+ /// `(NewValue) -> Value`.\n+ ///\n+ /// This is the most important operation for transforming existing strategies into new strategies. It\n+ /// allows you to transform a `Snapshotting<Value, Format>` into a `Snapshotting<NewValue, Format>`\n+ /// by pulling it back along a function `(NewValue) -> Value`. Notice that the function must go in\n+ /// in the direction `(NewValue) -> Value` even though we are transforming in the other direction\n+ /// `(Snapshotting<Value, Format>) -> Snapshotting<NewValue, Format>`.\n+ ///\n+ /// A simple example of this is to `pullback` the snapshot strategy on `UIView`'s to work on\n+ /// `UIViewController`'s:\n+ ///\n+ /// ```\n+ /// let strategy = Snapshotting<UIView, UIImage>.image.pullback { (vc: UIViewController) in\n+ /// return vc.view\n+ /// }\n+ /// ```\n+ ///\n+ /// Here we took the strategy that snapshots `UIView`'s as `UIImage`'s and pulled it back to work on\n+ /// `UIViewController`'s by using the function `(UIViewController) -> UIView` that simply plucks the\n+ /// view out of the controller.\n+ ///\n+ /// Nearly every snapshot strategy provided in this library is a `pullback` of some base strategy, which\n+ /// shows just how important this operation is.\n+ ///\n+ /// - Parameters:\n+ /// - transform: A transform function from `NewValue` into `Value`.\n+ /// - otherValue: A value to be transformed.\n+ public func pullback<NewValue>(_ transform: @escaping (_ otherValue: NewValue) -> Value) -> Snapshotting<NewValue, Format> {\n+ return self.asyncPullback { newValue in Async(value: transform(newValue)) }\n+ }\n+\n /// Transforms a strategy on `Value`s into a strategy on `NewValue`s through a function `(NewValue) -> Async<Value>`.\n ///\n+ /// See the documention of `pullback` for a full description of how pullbacks works. This operation differs","path":"Sources/SnapshotTesting/Snapshotting.swift","position":38,"original_position":38,"commit_id":"fe9113647db00d3965a2865d630d4f36679693b3","original_commit_id":"fe9113647db00d3965a2865d630d4f36679693b3","user":{"login":"mbrandonw","id":135203,"node_id":"MDQ6VXNlcjEzNTIwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/135203?v=4","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"ah yes, lemme try it out","created_at":"2018-12-21T15:49:45Z","updated_at":"2018-12-21T15:49:45Z","html_url":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155#discussion_r243618454","pull_request_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/comments/243618454"},"html":{"href":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155#discussion_r243618454"},"pull_request":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155"}},"in_reply_to_id":243618247},"pull_request":{"url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155","id":240508953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTA4OTUz","html_url":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155","diff_url":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155.diff","patch_url":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155.patch","issue_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/155","number":155,"state":"open","locked":false,"title":"Updated docs for pullback.","user":{"login":"mbrandonw","id":135203,"node_id":"MDQ6VXNlcjEzNTIwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/135203?v=4","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"Beefing up the docs for pullback.","created_at":"2018-12-21T15:46:27Z","updated_at":"2018-12-21T15:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"259e1046b2a6a0ee788ed98fca297f6ca02ed975","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155/commits","review_comments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155/comments","review_comment_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/155/comments","statuses_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/statuses/fe9113647db00d3965a2865d630d4f36679693b3","head":{"label":"pointfreeco:pullback-docs","ref":"pullback-docs","sha":"fe9113647db00d3965a2865d630d4f36679693b3","user":{"login":"pointfreeco","id":29466629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDY2NjI5","avatar_url":"https://avatars1.githubusercontent.com/u/29466629?v=4","gravatar_id":"","url":"https://api.github.com/users/pointfreeco","html_url":"https://github.com/pointfreeco","followers_url":"https://api.github.com/users/pointfreeco/followers","following_url":"https://api.github.com/users/pointfreeco/following{/other_user}","gists_url":"https://api.github.com/users/pointfreeco/gists{/gist_id}","starred_url":"https://api.github.com/users/pointfreeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pointfreeco/subscriptions","organizations_url":"https://api.github.com/users/pointfreeco/orgs","repos_url":"https://api.github.com/users/pointfreeco/repos","events_url":"https://api.github.com/users/pointfreeco/events{/privacy}","received_events_url":"https://api.github.com/users/pointfreeco/received_events","type":"Organization","site_admin":false},"repo":{"id":96496250,"node_id":"MDEwOlJlcG9zaXRvcnk5NjQ5NjI1MA==","name":"swift-snapshot-testing","full_name":"pointfreeco/swift-snapshot-testing","private":false,"owner":{"login":"pointfreeco","id":29466629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDY2NjI5","avatar_url":"https://avatars1.githubusercontent.com/u/29466629?v=4","gravatar_id":"","url":"https://api.github.com/users/pointfreeco","html_url":"https://github.com/pointfreeco","followers_url":"https://api.github.com/users/pointfreeco/followers","following_url":"https://api.github.com/users/pointfreeco/following{/other_user}","gists_url":"https://api.github.com/users/pointfreeco/gists{/gist_id}","starred_url":"https://api.github.com/users/pointfreeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pointfreeco/subscriptions","organizations_url":"https://api.github.com/users/pointfreeco/orgs","repos_url":"https://api.github.com/users/pointfreeco/repos","events_url":"https://api.github.com/users/pointfreeco/events{/privacy}","received_events_url":"https://api.github.com/users/pointfreeco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pointfreeco/swift-snapshot-testing","description":"📸 Delightful Swift snapshot testing.","fork":false,"url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing","forks_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/forks","keys_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/teams","hooks_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/hooks","issue_events_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/events{/number}","events_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/events","assignees_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/assignees{/user}","branches_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/branches{/branch}","tags_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/tags","blobs_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/languages","stargazers_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/stargazers","contributors_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/contributors","subscribers_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/subscribers","subscription_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/subscription","commits_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/contents/{+path}","compare_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/merges","archive_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/downloads","issues_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues{/number}","pulls_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/labels{/name}","releases_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/releases{/id}","deployments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/deployments","created_at":"2017-07-07T03:38:51Z","updated_at":"2018-12-21T15:44:23Z","pushed_at":"2018-12-21T15:46:57Z","git_url":"git://github.com/pointfreeco/swift-snapshot-testing.git","ssh_url":"git@github.com:pointfreeco/swift-snapshot-testing.git","clone_url":"https://github.com/pointfreeco/swift-snapshot-testing.git","svn_url":"https://github.com/pointfreeco/swift-snapshot-testing","homepage":"https://www.pointfree.co/episodes/ep41-a-tour-of-snapshot-testing","size":23237,"stargazers_count":659,"watchers_count":659,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":12,"watchers":659,"default_branch":"master"}},"base":{"label":"pointfreeco:master","ref":"master","sha":"f73aa80ece217045407ee5275de3db0fa579a0f1","user":{"login":"pointfreeco","id":29466629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDY2NjI5","avatar_url":"https://avatars1.githubusercontent.com/u/29466629?v=4","gravatar_id":"","url":"https://api.github.com/users/pointfreeco","html_url":"https://github.com/pointfreeco","followers_url":"https://api.github.com/users/pointfreeco/followers","following_url":"https://api.github.com/users/pointfreeco/following{/other_user}","gists_url":"https://api.github.com/users/pointfreeco/gists{/gist_id}","starred_url":"https://api.github.com/users/pointfreeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pointfreeco/subscriptions","organizations_url":"https://api.github.com/users/pointfreeco/orgs","repos_url":"https://api.github.com/users/pointfreeco/repos","events_url":"https://api.github.com/users/pointfreeco/events{/privacy}","received_events_url":"https://api.github.com/users/pointfreeco/received_events","type":"Organization","site_admin":false},"repo":{"id":96496250,"node_id":"MDEwOlJlcG9zaXRvcnk5NjQ5NjI1MA==","name":"swift-snapshot-testing","full_name":"pointfreeco/swift-snapshot-testing","private":false,"owner":{"login":"pointfreeco","id":29466629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDY2NjI5","avatar_url":"https://avatars1.githubusercontent.com/u/29466629?v=4","gravatar_id":"","url":"https://api.github.com/users/pointfreeco","html_url":"https://github.com/pointfreeco","followers_url":"https://api.github.com/users/pointfreeco/followers","following_url":"https://api.github.com/users/pointfreeco/following{/other_user}","gists_url":"https://api.github.com/users/pointfreeco/gists{/gist_id}","starred_url":"https://api.github.com/users/pointfreeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pointfreeco/subscriptions","organizations_url":"https://api.github.com/users/pointfreeco/orgs","repos_url":"https://api.github.com/users/pointfreeco/repos","events_url":"https://api.github.com/users/pointfreeco/events{/privacy}","received_events_url":"https://api.github.com/users/pointfreeco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pointfreeco/swift-snapshot-testing","description":"📸 Delightful Swift snapshot testing.","fork":false,"url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing","forks_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/forks","keys_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/teams","hooks_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/hooks","issue_events_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/events{/number}","events_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/events","assignees_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/assignees{/user}","branches_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/branches{/branch}","tags_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/tags","blobs_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/languages","stargazers_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/stargazers","contributors_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/contributors","subscribers_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/subscribers","subscription_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/subscription","commits_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/contents/{+path}","compare_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/merges","archive_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/downloads","issues_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues{/number}","pulls_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/labels{/name}","releases_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/releases{/id}","deployments_url":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/deployments","created_at":"2017-07-07T03:38:51Z","updated_at":"2018-12-21T15:44:23Z","pushed_at":"2018-12-21T15:46:57Z","git_url":"git://github.com/pointfreeco/swift-snapshot-testing.git","ssh_url":"git@github.com:pointfreeco/swift-snapshot-testing.git","clone_url":"https://github.com/pointfreeco/swift-snapshot-testing.git","svn_url":"https://github.com/pointfreeco/swift-snapshot-testing","homepage":"https://www.pointfree.co/episodes/ep41-a-tour-of-snapshot-testing","size":23237,"stargazers_count":659,"watchers_count":659,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":12,"watchers":659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155"},"html":{"href":"https://github.com/pointfreeco/swift-snapshot-testing/pull/155"},"issue":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/155"},"comments":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/pointfreeco/swift-snapshot-testing/statuses/fe9113647db00d3965a2865d630d4f36679693b3"}},"author_association":"MEMBER"}} | {
"id": 96496250,
"name": "pointfreeco/swift-snapshot-testing",
"url": "https://api.github.com/repos/pointfreeco/swift-snapshot-testing"
} | {
"id": 135203,
"login": "mbrandonw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/135203?",
"url": "https://api.github.com/users/mbrandonw"
} | {
"id": 29466629,
"login": "pointfreeco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29466629?",
"url": "https://api.github.com/orgs/pointfreeco"
} | 2018-12-21T15:49:45 | 8792348100 | {"actor":{"display_login":"mbrandonw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/molr/molr-remote/pulls/comments/207236546","pull_request_review_id":142806281,"id":207236546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzIzNjU0Ng==","diff_hunk":"@@ -0,0 +1,50 @@\n+package cern.molr.sample.states;\n+\n+import cern.molr.commons.api.request.MissionCommand;\n+import cern.molr.commons.api.response.MissionState;\n+import cern.molr.sample.mole.SequenceMole;\n+import com.fasterxml.jackson.annotation.JsonProperty;\n+\n+import java.util.List;\n+\n+/**\n+ * A state generated by {@link SequenceMole}\n+ *\n+ * @author yassine-kr\n+ */\n+public class SequenceMissionState extends MissionState {\n+\n+ /**\n+ * The number of the task that the mole is running or waiting for.\n+ */\n+ private final int taskNumber;\n+ private final State state;\n+\n+ public SequenceMissionState(@JsonProperty(\"level\") Level level, @JsonProperty(\"status\") String status,\n+ @JsonProperty(\"possibleCommands\") List<MissionCommand> possibleCommands, @JsonProperty(\"taskNumber\") int\n+ taskNumber, @JsonProperty(\"state\") State state) {\n+ super(level, status, possibleCommands);\n+ this.taskNumber = taskNumber;\n+ this.state = state;\n+ }\n+\n+ public SequenceMissionState(String status, List<MissionCommand> possibleCommands, int taskNumber, State state) {\n+ super(Level.MOLE, status, possibleCommands);\n+ this.taskNumber = taskNumber;\n+ this.state = state;\n+ }\n+\n+ public int getTaskNumber() {\n+ return taskNumber;\n+ }\n+\n+ public State getState() {\n+ return state;\n+ }\n+\n+ public enum State {\n+ WAITING,\n+ RUNNING,","path":"sample/src/main/java/cern/molr/sample/states/SequenceMissionState.java","position":null,"original_position":47,"commit_id":"d832f1ef35ddfec76782ed1cd0637e7aedd3b6b3","original_commit_id":"1e81e7e35cff75e88c86269695b7eefc00b2c9e9","user":{"login":"yassine-kr","id":18330607,"node_id":"MDQ6VXNlcjE4MzMwNjA3","avatar_url":"https://avatars2.githubusercontent.com/u/18330607?v=4","gravatar_id":"","url":"https://api.github.com/users/yassine-kr","html_url":"https://github.com/yassine-kr","followers_url":"https://api.github.com/users/yassine-kr/followers","following_url":"https://api.github.com/users/yassine-kr/following{/other_user}","gists_url":"https://api.github.com/users/yassine-kr/gists{/gist_id}","starred_url":"https://api.github.com/users/yassine-kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassine-kr/subscriptions","organizations_url":"https://api.github.com/users/yassine-kr/orgs","repos_url":"https://api.github.com/users/yassine-kr/repos","events_url":"https://api.github.com/users/yassine-kr/events{/privacy}","received_events_url":"https://api.github.com/users/yassine-kr/received_events","type":"User","site_admin":false},"body":"I renamed the states as you suggested. But I am not sure that TASK_FINISHED is an appropriate name, because the state is generated when all the tasks are finished. So I think the name TASKS_FINISHED (with S) or MISSION_FINISHED would be more appropriate.","created_at":"2018-08-02T14:00:23Z","updated_at":"2018-08-02T14:00:23Z","html_url":"https://github.com/molr/molr-remote/pull/51#discussion_r207236546","pull_request_url":"https://api.github.com/repos/molr/molr-remote/pulls/51","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/comments/207236546"},"html":{"href":"https://github.com/molr/molr-remote/pull/51#discussion_r207236546"},"pull_request":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/51"}},"in_reply_to_id":207224101},"pull_request":{"url":"https://api.github.com/repos/molr/molr-remote/pulls/51","id":205682724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjgyNzI0","html_url":"https://github.com/molr/molr-remote/pull/51","diff_url":"https://github.com/molr/molr-remote/pull/51.diff","patch_url":"https://github.com/molr/molr-remote/pull/51.patch","issue_url":"https://api.github.com/repos/molr/molr-remote/issues/51","number":51,"state":"open","locked":false,"title":"Sequence mole specific states","user":{"login":"yassine-kr","id":18330607,"node_id":"MDQ6VXNlcjE4MzMwNjA3","avatar_url":"https://avatars2.githubusercontent.com/u/18330607?v=4","gravatar_id":"","url":"https://api.github.com/users/yassine-kr","html_url":"https://github.com/yassine-kr","followers_url":"https://api.github.com/users/yassine-kr/followers","following_url":"https://api.github.com/users/yassine-kr/following{/other_user}","gists_url":"https://api.github.com/users/yassine-kr/gists{/gist_id}","starred_url":"https://api.github.com/users/yassine-kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yassine-kr/subscriptions","organizations_url":"https://api.github.com/users/yassine-kr/orgs","repos_url":"https://api.github.com/users/yassine-kr/repos","events_url":"https://api.github.com/users/yassine-kr/events{/privacy}","received_events_url":"https://api.github.com/users/yassine-kr/received_events","type":"User","site_admin":false},"body":"I created a class SequenceMissionState which contains an enum field representing the current state of the sequence mole, because it is more convenient to handle an enum value compared to a string value.\r\nThe class contains also the index of the current task.\r\n\r\nI modified also the name of the MissionControlEvent to MissionRunnerEvent which is more meaningful as this kind of event is triggered by the MoleRunner.","created_at":"2018-08-02T10:07:08Z","updated_at":"2018-08-02T14:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50b717321b7da2d56b8a1e81aeeb0498ad52593","assignee":null,"assignees":[],"requested_reviewers":[{"login":"timart1n","id":7980551,"node_id":"MDQ6VXNlcjc5ODA1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7980551?v=4","gravatar_id":"","url":"https://api.github.com/users/timart1n","html_url":"https://github.com/timart1n","followers_url":"https://api.github.com/users/timart1n/followers","following_url":"https://api.github.com/users/timart1n/following{/other_user}","gists_url":"https://api.github.com/users/timart1n/gists{/gist_id}","starred_url":"https://api.github.com/users/timart1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timart1n/subscriptions","organizations_url":"https://api.github.com/users/timart1n/orgs","repos_url":"https://api.github.com/users/timart1n/repos","events_url":"https://api.github.com/users/timart1n/events{/privacy}","received_events_url":"https://api.github.com/users/timart1n/received_events","type":"User","site_admin":false},{"login":"andyswec","id":11132999,"node_id":"MDQ6VXNlcjExMTMyOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/11132999?v=4","gravatar_id":"","url":"https://api.github.com/users/andyswec","html_url":"https://github.com/andyswec","followers_url":"https://api.github.com/users/andyswec/followers","following_url":"https://api.github.com/users/andyswec/following{/other_user}","gists_url":"https://api.github.com/users/andyswec/gists{/gist_id}","starred_url":"https://api.github.com/users/andyswec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyswec/subscriptions","organizations_url":"https://api.github.com/users/andyswec/orgs","repos_url":"https://api.github.com/users/andyswec/repos","events_url":"https://api.github.com/users/andyswec/events{/privacy}","received_events_url":"https://api.github.com/users/andyswec/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/molr/molr-remote/pulls/51/commits","review_comments_url":"https://api.github.com/repos/molr/molr-remote/pulls/51/comments","review_comment_url":"https://api.github.com/repos/molr/molr-remote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/molr/molr-remote/issues/51/comments","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/d832f1ef35ddfec76782ed1cd0637e7aedd3b6b3","head":{"label":"molr:sequence-mole-specific-states","ref":"sequence-mole-specific-states","sha":"d832f1ef35ddfec76782ed1cd0637e7aedd3b6b3","user":{"login":"molr","id":29492821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyODIx","avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"repo":{"id":99821218,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgyMTIxOA==","name":"molr-remote","full_name":"molr/molr-remote","owner":{"login":"molr","id":29492821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyODIx","avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molr/molr-remote","description":"A delegation framework for remote execution","fork":false,"url":"https://api.github.com/repos/molr/molr-remote","forks_url":"https://api.github.com/repos/molr/molr-remote/forks","keys_url":"https://api.github.com/repos/molr/molr-remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molr/molr-remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molr/molr-remote/teams","hooks_url":"https://api.github.com/repos/molr/molr-remote/hooks","issue_events_url":"https://api.github.com/repos/molr/molr-remote/issues/events{/number}","events_url":"https://api.github.com/repos/molr/molr-remote/events","assignees_url":"https://api.github.com/repos/molr/molr-remote/assignees{/user}","branches_url":"https://api.github.com/repos/molr/molr-remote/branches{/branch}","tags_url":"https://api.github.com/repos/molr/molr-remote/tags","blobs_url":"https://api.github.com/repos/molr/molr-remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molr/molr-remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molr/molr-remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/molr/molr-remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/{sha}","languages_url":"https://api.github.com/repos/molr/molr-remote/languages","stargazers_url":"https://api.github.com/repos/molr/molr-remote/stargazers","contributors_url":"https://api.github.com/repos/molr/molr-remote/contributors","subscribers_url":"https://api.github.com/repos/molr/molr-remote/subscribers","subscription_url":"https://api.github.com/repos/molr/molr-remote/subscription","commits_url":"https://api.github.com/repos/molr/molr-remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/molr/molr-remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/molr/molr-remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/molr/molr-remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/molr/molr-remote/contents/{+path}","compare_url":"https://api.github.com/repos/molr/molr-remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molr/molr-remote/merges","archive_url":"https://api.github.com/repos/molr/molr-remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molr/molr-remote/downloads","issues_url":"https://api.github.com/repos/molr/molr-remote/issues{/number}","pulls_url":"https://api.github.com/repos/molr/molr-remote/pulls{/number}","milestones_url":"https://api.github.com/repos/molr/molr-remote/milestones{/number}","notifications_url":"https://api.github.com/repos/molr/molr-remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molr/molr-remote/labels{/name}","releases_url":"https://api.github.com/repos/molr/molr-remote/releases{/id}","deployments_url":"https://api.github.com/repos/molr/molr-remote/deployments","created_at":"2017-08-09T15:02:43Z","updated_at":"2018-08-02T09:23:19Z","pushed_at":"2018-08-02T13:54:39Z","git_url":"git://github.com/molr/molr-remote.git","ssh_url":"git@github.com:molr/molr-remote.git","clone_url":"https://github.com/molr/molr-remote.git","svn_url":"https://github.com/molr/molr-remote","homepage":"","size":917,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":1,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"molr:master","ref":"master","sha":"9c99b85829e34121bb935df1e5f382a1bafc414b","user":{"login":"molr","id":29492821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyODIx","avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"repo":{"id":99821218,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgyMTIxOA==","name":"molr-remote","full_name":"molr/molr-remote","owner":{"login":"molr","id":29492821,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyODIx","avatar_url":"https://avatars2.githubusercontent.com/u/29492821?v=4","gravatar_id":"","url":"https://api.github.com/users/molr","html_url":"https://github.com/molr","followers_url":"https://api.github.com/users/molr/followers","following_url":"https://api.github.com/users/molr/following{/other_user}","gists_url":"https://api.github.com/users/molr/gists{/gist_id}","starred_url":"https://api.github.com/users/molr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molr/subscriptions","organizations_url":"https://api.github.com/users/molr/orgs","repos_url":"https://api.github.com/users/molr/repos","events_url":"https://api.github.com/users/molr/events{/privacy}","received_events_url":"https://api.github.com/users/molr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molr/molr-remote","description":"A delegation framework for remote execution","fork":false,"url":"https://api.github.com/repos/molr/molr-remote","forks_url":"https://api.github.com/repos/molr/molr-remote/forks","keys_url":"https://api.github.com/repos/molr/molr-remote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molr/molr-remote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molr/molr-remote/teams","hooks_url":"https://api.github.com/repos/molr/molr-remote/hooks","issue_events_url":"https://api.github.com/repos/molr/molr-remote/issues/events{/number}","events_url":"https://api.github.com/repos/molr/molr-remote/events","assignees_url":"https://api.github.com/repos/molr/molr-remote/assignees{/user}","branches_url":"https://api.github.com/repos/molr/molr-remote/branches{/branch}","tags_url":"https://api.github.com/repos/molr/molr-remote/tags","blobs_url":"https://api.github.com/repos/molr/molr-remote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molr/molr-remote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molr/molr-remote/git/refs{/sha}","trees_url":"https://api.github.com/repos/molr/molr-remote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molr/molr-remote/statuses/{sha}","languages_url":"https://api.github.com/repos/molr/molr-remote/languages","stargazers_url":"https://api.github.com/repos/molr/molr-remote/stargazers","contributors_url":"https://api.github.com/repos/molr/molr-remote/contributors","subscribers_url":"https://api.github.com/repos/molr/molr-remote/subscribers","subscription_url":"https://api.github.com/repos/molr/molr-remote/subscription","commits_url":"https://api.github.com/repos/molr/molr-remote/commits{/sha}","git_commits_url":"https://api.github.com/repos/molr/molr-remote/git/commits{/sha}","comments_url":"https://api.github.com/repos/molr/molr-remote/comments{/number}","issue_comment_url":"https://api.github.com/repos/molr/molr-remote/issues/comments{/number}","contents_url":"https://api.github.com/repos/molr/molr-remote/contents/{+path}","compare_url":"https://api.github.com/repos/molr/molr-remote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molr/molr-remote/merges","archive_url":"https://api.github.com/repos/molr/molr-remote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molr/molr-remote/downloads","issues_url":"https://api.github.com/repos/molr/molr-remote/issues{/number}","pulls_url":"https://api.github.com/repos/molr/molr-remote/pulls{/number}","milestones_url":"https://api.github.com/repos/molr/molr-remote/milestones{/number}","notifications_url":"https://api.github.com/repos/molr/molr-remote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molr/molr-remote/labels{/name}","releases_url":"https://api.github.com/repos/molr/molr-remote/releases{/id}","deployments_url":"https://api.github.com/repos/molr/molr-remote/deployments","created_at":"2017-08-09T15:02:43Z","updated_at":"2018-08-02T09:23:19Z","pushed_at":"2018-08-02T13:54:39Z","git_url":"git://github.com/molr/molr-remote.git","ssh_url":"git@github.com:molr/molr-remote.git","clone_url":"https://github.com/molr/molr-remote.git","svn_url":"https://github.com/molr/molr-remote","homepage":"","size":917,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":1,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/51"},"html":{"href":"https://github.com/molr/molr-remote/pull/51"},"issue":{"href":"https://api.github.com/repos/molr/molr-remote/issues/51"},"comments":{"href":"https://api.github.com/repos/molr/molr-remote/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/molr/molr-remote/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/molr/molr-remote/statuses/d832f1ef35ddfec76782ed1cd0637e7aedd3b6b3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 99821218,
"name": "molr/molr-remote",
"url": "https://api.github.com/repos/molr/molr-remote"
} | {
"id": 18330607,
"login": "yassine-kr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18330607?",
"url": "https://api.github.com/users/yassine-kr"
} | {
"id": 29492821,
"login": "molr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29492821?",
"url": "https://api.github.com/orgs/molr"
} | 2018-08-02T14:00:23 | 8056889683 | {"actor":{"display_login":"yassine-kr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/comments/211508015","pull_request_review_id":147938165,"id":211508015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTUwODAxNQ==","diff_hunk":"@@ -93,6 +95,20 @@ defmodule Core.Mongo.AuditLog do\n defp fetch_event_data(@delete, [_, filter | _]), do: {nil, filter}\n defp fetch_event_data(@update, [_, filter, params | _]), do: {params, filter}\n \n+ # fetch from data set. Usualy for insert operations\n+ defp fetch_actor_id(%{updated_by: actor_id}, _opts), do: actor_id\n+\n+ # fetch from $set attribute. Usualy for update operations","path":"apps/core/lib/core/mongo/audit_log.ex","position":34,"original_position":34,"commit_id":"056ca0bfaf2421d554a63235a4648e5d5fa018eb","original_commit_id":"056ca0bfaf2421d554a63235a4648e5d5fa018eb","user":{"login":"AlexKovalevych","id":577231,"node_id":"MDQ6VXNlcjU3NzIzMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/577231?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKovalevych","html_url":"https://github.com/AlexKovalevych","followers_url":"https://api.github.com/users/AlexKovalevych/followers","following_url":"https://api.github.com/users/AlexKovalevych/following{/other_user}","gists_url":"https://api.github.com/users/AlexKovalevych/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKovalevych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKovalevych/subscriptions","organizations_url":"https://api.github.com/users/AlexKovalevych/orgs","repos_url":"https://api.github.com/users/AlexKovalevych/repos","events_url":"https://api.github.com/users/AlexKovalevych/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKovalevych/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2018-08-21T07:46:32Z","updated_at":"2018-08-21T07:49:09Z","html_url":"https://github.com/edenlabllc/medical_events/pull/6#discussion_r211508015","pull_request_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/comments/211508015"},"html":{"href":"https://github.com/edenlabllc/medical_events/pull/6#discussion_r211508015"},"pull_request":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6","id":209479952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDc5OTUy","html_url":"https://github.com/edenlabllc/medical_events/pull/6","diff_url":"https://github.com/edenlabllc/medical_events/pull/6.diff","patch_url":"https://github.com/edenlabllc/medical_events/pull/6.patch","issue_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/6","number":6,"state":"open","locked":false,"title":"Audit Log: added fields actor_id and inserted_at","user":{"login":"PavelVesnin","id":7769545,"node_id":"MDQ6VXNlcjc3Njk1NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/7769545?v=4","gravatar_id":"","url":"https://api.github.com/users/PavelVesnin","html_url":"https://github.com/PavelVesnin","followers_url":"https://api.github.com/users/PavelVesnin/followers","following_url":"https://api.github.com/users/PavelVesnin/following{/other_user}","gists_url":"https://api.github.com/users/PavelVesnin/gists{/gist_id}","starred_url":"https://api.github.com/users/PavelVesnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavelVesnin/subscriptions","organizations_url":"https://api.github.com/users/PavelVesnin/orgs","repos_url":"https://api.github.com/users/PavelVesnin/repos","events_url":"https://api.github.com/users/PavelVesnin/events{/privacy}","received_events_url":"https://api.github.com/users/PavelVesnin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-20T10:41:12Z","updated_at":"2018-08-21T07:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1edf23196e1b958d26fa71fe127992086886f8b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6/commits","review_comments_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6/comments","review_comment_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/6/comments","statuses_url":"https://api.github.com/repos/edenlabllc/medical_events/statuses/056ca0bfaf2421d554a63235a4648e5d5fa018eb","head":{"label":"edenlabllc:audit-log-created-by","ref":"audit-log-created-by","sha":"056ca0bfaf2421d554a63235a4648e5d5fa018eb","user":{"login":"edenlabllc","id":29564877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/29564877?v=4","gravatar_id":"","url":"https://api.github.com/users/edenlabllc","html_url":"https://github.com/edenlabllc","followers_url":"https://api.github.com/users/edenlabllc/followers","following_url":"https://api.github.com/users/edenlabllc/following{/other_user}","gists_url":"https://api.github.com/users/edenlabllc/gists{/gist_id}","starred_url":"https://api.github.com/users/edenlabllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenlabllc/subscriptions","organizations_url":"https://api.github.com/users/edenlabllc/orgs","repos_url":"https://api.github.com/users/edenlabllc/repos","events_url":"https://api.github.com/users/edenlabllc/events{/privacy}","received_events_url":"https://api.github.com/users/edenlabllc/received_events","type":"Organization","site_admin":false},"repo":{"id":142130300,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxMzAzMDA=","name":"medical_events","full_name":"edenlabllc/medical_events","owner":{"login":"edenlabllc","id":29564877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/29564877?v=4","gravatar_id":"","url":"https://api.github.com/users/edenlabllc","html_url":"https://github.com/edenlabllc","followers_url":"https://api.github.com/users/edenlabllc/followers","following_url":"https://api.github.com/users/edenlabllc/following{/other_user}","gists_url":"https://api.github.com/users/edenlabllc/gists{/gist_id}","starred_url":"https://api.github.com/users/edenlabllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenlabllc/subscriptions","organizations_url":"https://api.github.com/users/edenlabllc/orgs","repos_url":"https://api.github.com/users/edenlabllc/repos","events_url":"https://api.github.com/users/edenlabllc/events{/privacy}","received_events_url":"https://api.github.com/users/edenlabllc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edenlabllc/medical_events","description":"EHealth medical events repository","fork":false,"url":"https://api.github.com/repos/edenlabllc/medical_events","forks_url":"https://api.github.com/repos/edenlabllc/medical_events/forks","keys_url":"https://api.github.com/repos/edenlabllc/medical_events/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edenlabllc/medical_events/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edenlabllc/medical_events/teams","hooks_url":"https://api.github.com/repos/edenlabllc/medical_events/hooks","issue_events_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/events{/number}","events_url":"https://api.github.com/repos/edenlabllc/medical_events/events","assignees_url":"https://api.github.com/repos/edenlabllc/medical_events/assignees{/user}","branches_url":"https://api.github.com/repos/edenlabllc/medical_events/branches{/branch}","tags_url":"https://api.github.com/repos/edenlabllc/medical_events/tags","blobs_url":"https://api.github.com/repos/edenlabllc/medical_events/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edenlabllc/medical_events/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edenlabllc/medical_events/git/refs{/sha}","trees_url":"https://api.github.com/repos/edenlabllc/medical_events/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edenlabllc/medical_events/statuses/{sha}","languages_url":"https://api.github.com/repos/edenlabllc/medical_events/languages","stargazers_url":"https://api.github.com/repos/edenlabllc/medical_events/stargazers","contributors_url":"https://api.github.com/repos/edenlabllc/medical_events/contributors","subscribers_url":"https://api.github.com/repos/edenlabllc/medical_events/subscribers","subscription_url":"https://api.github.com/repos/edenlabllc/medical_events/subscription","commits_url":"https://api.github.com/repos/edenlabllc/medical_events/commits{/sha}","git_commits_url":"https://api.github.com/repos/edenlabllc/medical_events/git/commits{/sha}","comments_url":"https://api.github.com/repos/edenlabllc/medical_events/comments{/number}","issue_comment_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/comments{/number}","contents_url":"https://api.github.com/repos/edenlabllc/medical_events/contents/{+path}","compare_url":"https://api.github.com/repos/edenlabllc/medical_events/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edenlabllc/medical_events/merges","archive_url":"https://api.github.com/repos/edenlabllc/medical_events/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edenlabllc/medical_events/downloads","issues_url":"https://api.github.com/repos/edenlabllc/medical_events/issues{/number}","pulls_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls{/number}","milestones_url":"https://api.github.com/repos/edenlabllc/medical_events/milestones{/number}","notifications_url":"https://api.github.com/repos/edenlabllc/medical_events/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edenlabllc/medical_events/labels{/name}","releases_url":"https://api.github.com/repos/edenlabllc/medical_events/releases{/id}","deployments_url":"https://api.github.com/repos/edenlabllc/medical_events/deployments","created_at":"2018-07-24T08:41:15Z","updated_at":"2018-08-20T08:02:19Z","pushed_at":"2018-08-20T15:50:33Z","git_url":"git://github.com/edenlabllc/medical_events.git","ssh_url":"git@github.com:edenlabllc/medical_events.git","clone_url":"https://github.com/edenlabllc/medical_events.git","svn_url":"https://github.com/edenlabllc/medical_events","homepage":null,"size":138,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"edenlabllc:develop","ref":"develop","sha":"6b77e3597260468a21575e6cc3ee8fc50f71a436","user":{"login":"edenlabllc","id":29564877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/29564877?v=4","gravatar_id":"","url":"https://api.github.com/users/edenlabllc","html_url":"https://github.com/edenlabllc","followers_url":"https://api.github.com/users/edenlabllc/followers","following_url":"https://api.github.com/users/edenlabllc/following{/other_user}","gists_url":"https://api.github.com/users/edenlabllc/gists{/gist_id}","starred_url":"https://api.github.com/users/edenlabllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenlabllc/subscriptions","organizations_url":"https://api.github.com/users/edenlabllc/orgs","repos_url":"https://api.github.com/users/edenlabllc/repos","events_url":"https://api.github.com/users/edenlabllc/events{/privacy}","received_events_url":"https://api.github.com/users/edenlabllc/received_events","type":"Organization","site_admin":false},"repo":{"id":142130300,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxMzAzMDA=","name":"medical_events","full_name":"edenlabllc/medical_events","owner":{"login":"edenlabllc","id":29564877,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/29564877?v=4","gravatar_id":"","url":"https://api.github.com/users/edenlabllc","html_url":"https://github.com/edenlabllc","followers_url":"https://api.github.com/users/edenlabllc/followers","following_url":"https://api.github.com/users/edenlabllc/following{/other_user}","gists_url":"https://api.github.com/users/edenlabllc/gists{/gist_id}","starred_url":"https://api.github.com/users/edenlabllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenlabllc/subscriptions","organizations_url":"https://api.github.com/users/edenlabllc/orgs","repos_url":"https://api.github.com/users/edenlabllc/repos","events_url":"https://api.github.com/users/edenlabllc/events{/privacy}","received_events_url":"https://api.github.com/users/edenlabllc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edenlabllc/medical_events","description":"EHealth medical events repository","fork":false,"url":"https://api.github.com/repos/edenlabllc/medical_events","forks_url":"https://api.github.com/repos/edenlabllc/medical_events/forks","keys_url":"https://api.github.com/repos/edenlabllc/medical_events/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edenlabllc/medical_events/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edenlabllc/medical_events/teams","hooks_url":"https://api.github.com/repos/edenlabllc/medical_events/hooks","issue_events_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/events{/number}","events_url":"https://api.github.com/repos/edenlabllc/medical_events/events","assignees_url":"https://api.github.com/repos/edenlabllc/medical_events/assignees{/user}","branches_url":"https://api.github.com/repos/edenlabllc/medical_events/branches{/branch}","tags_url":"https://api.github.com/repos/edenlabllc/medical_events/tags","blobs_url":"https://api.github.com/repos/edenlabllc/medical_events/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edenlabllc/medical_events/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edenlabllc/medical_events/git/refs{/sha}","trees_url":"https://api.github.com/repos/edenlabllc/medical_events/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edenlabllc/medical_events/statuses/{sha}","languages_url":"https://api.github.com/repos/edenlabllc/medical_events/languages","stargazers_url":"https://api.github.com/repos/edenlabllc/medical_events/stargazers","contributors_url":"https://api.github.com/repos/edenlabllc/medical_events/contributors","subscribers_url":"https://api.github.com/repos/edenlabllc/medical_events/subscribers","subscription_url":"https://api.github.com/repos/edenlabllc/medical_events/subscription","commits_url":"https://api.github.com/repos/edenlabllc/medical_events/commits{/sha}","git_commits_url":"https://api.github.com/repos/edenlabllc/medical_events/git/commits{/sha}","comments_url":"https://api.github.com/repos/edenlabllc/medical_events/comments{/number}","issue_comment_url":"https://api.github.com/repos/edenlabllc/medical_events/issues/comments{/number}","contents_url":"https://api.github.com/repos/edenlabllc/medical_events/contents/{+path}","compare_url":"https://api.github.com/repos/edenlabllc/medical_events/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edenlabllc/medical_events/merges","archive_url":"https://api.github.com/repos/edenlabllc/medical_events/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edenlabllc/medical_events/downloads","issues_url":"https://api.github.com/repos/edenlabllc/medical_events/issues{/number}","pulls_url":"https://api.github.com/repos/edenlabllc/medical_events/pulls{/number}","milestones_url":"https://api.github.com/repos/edenlabllc/medical_events/milestones{/number}","notifications_url":"https://api.github.com/repos/edenlabllc/medical_events/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edenlabllc/medical_events/labels{/name}","releases_url":"https://api.github.com/repos/edenlabllc/medical_events/releases{/id}","deployments_url":"https://api.github.com/repos/edenlabllc/medical_events/deployments","created_at":"2018-07-24T08:41:15Z","updated_at":"2018-08-20T08:02:19Z","pushed_at":"2018-08-20T15:50:33Z","git_url":"git://github.com/edenlabllc/medical_events.git","ssh_url":"git@github.com:edenlabllc/medical_events.git","clone_url":"https://github.com/edenlabllc/medical_events.git","svn_url":"https://github.com/edenlabllc/medical_events","homepage":null,"size":138,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6"},"html":{"href":"https://github.com/edenlabllc/medical_events/pull/6"},"issue":{"href":"https://api.github.com/repos/edenlabllc/medical_events/issues/6"},"comments":{"href":"https://api.github.com/repos/edenlabllc/medical_events/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edenlabllc/medical_events/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/edenlabllc/medical_events/statuses/056ca0bfaf2421d554a63235a4648e5d5fa018eb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 142130300,
"name": "edenlabllc/medical_events",
"url": "https://api.github.com/repos/edenlabllc/medical_events"
} | {
"id": 577231,
"login": "AlexKovalevych",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/577231?",
"url": "https://api.github.com/users/AlexKovalevych"
} | {
"id": 29564877,
"login": "edenlabllc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29564877?",
"url": "https://api.github.com/orgs/edenlabllc"
} | 2018-08-21T07:46:32 | 8142494604 | {"actor":{"display_login":"AlexKovalevych"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/comments/237868528","pull_request_review_id":180275469,"id":237868528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzg2ODUyOA==","diff_hunk":"@@ -193,3 +278,64 @@ cdef class GeneratedModel_Proto_tmpHzG5bQ(CvodeSolver):\n outputs[5][()] = var_environment__time\n return outputs\n \n+ cpdef ResetState(self, name=None):\n+ \"\"\"\n+ Reset the model to the given named saved state, or to initial\n+ conditions if no name given.\n+\n+ See :meth:`fc.simulations.AbstractOdeModel.ResetState()`.\n+ \"\"\"\n+ if name is None:\n+ CvodeSolver.ResetSolver(self, self.initialState)\n+ else:\n+ CvodeSolver.ResetSolver(self, self.savedStates[name])\n+\n+ def SaveState(self, name):\n+ \"\"\"\n+ Save a copy of the current model state associated with the given name,\n+ to be restored using :meth:`ResetState()`.\n+\n+ See :meth:`fc.simulations.AbstractOdeModel.SaveState()`.\n+ \"\"\"\n+ self.savedStates[name] = self.state.copy()\n+\n+ cpdef SetFreeVariable(self, double t):\n+ \"\"\"\n+ Set the value of the free variable (typically time), but retain the\n+ model's current state.\n+\n+ See :meth:`fc.simulations.AbstractOdeModel.SetFreeVariable()`.\n+ \"\"\"\n+ self.freeVariable = t\n+ CvodeSolver.SetFreeVariable(self, t)\n+\n+ def SetIndentLevel(self, indentLevel):\n+ \"\"\"\n+ Set the level of indentation to use for progress output.\n+\n+ See :meth:`fc.simulations.AbstractModel.setIndentLevel()`.\n+ \"\"\"\n+ self.indentLevel = indentLevel\n+\n+ def SetOutputFolder(self, path):\n+ # TODO This is undocumented in fc\n+ if os.path.isdir(path) and path.startswith('/tmp'):\n+ shutil.rmtree(path)\n+ os.mkdir(path)\n+ self.outputPath = path\n+\n+ def SetRhsWrapper(self):\n+ flag = Sundials.CVodeInit(\n+ self.cvode_mem, _EvaluateRhs, 0.0, self._state)\n+ self.CheckFlag(flag, \"CVodeInit\")\n+\n+ def SetSolver(self, solver):\n+ \"\"\"\n+ Specify the ODE solver to use for this model.\n+\n+ See :meth:`fc.simulations.AbstractOdeModel.SetSolver()`.\n+ \"\"\"\n+ # TODO Should this be python 3 syntax? Or is this special Cython\n+ # syntax?\n+ # TODO Can we use logging here instead? Or an exception?","path":"fccodegen/data/tests/weblab_model.pyx","position":340,"original_position":332,"commit_id":"70b09bf8b3eb6808552a007f66c4e6b3f84ed9ee","original_commit_id":"70b09bf8b3eb6808552a007f66c4e6b3f84ed9ee","user":{"login":"jonc125","id":2032871,"node_id":"MDQ6VXNlcjIwMzI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/2032871?v=4","gravatar_id":"","url":"https://api.github.com/users/jonc125","html_url":"https://github.com/jonc125","followers_url":"https://api.github.com/users/jonc125/followers","following_url":"https://api.github.com/users/jonc125/following{/other_user}","gists_url":"https://api.github.com/users/jonc125/gists{/gist_id}","starred_url":"https://api.github.com/users/jonc125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonc125/subscriptions","organizations_url":"https://api.github.com/users/jonc125/orgs","repos_url":"https://api.github.com/users/jonc125/repos","events_url":"https://api.github.com/users/jonc125/events{/privacy}","received_events_url":"https://api.github.com/users/jonc125/received_events","type":"User","site_admin":false},"body":"Those would be better options, yes. I can't remember why this doesn't raise; probably there's some test cases that trigger this path.","created_at":"2018-11-30T13:58:23Z","updated_at":"2018-11-30T13:58:23Z","html_url":"https://github.com/ModellingWebLab/fccodegen/pull/2#discussion_r237868528","pull_request_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/comments/237868528"},"html":{"href":"https://github.com/ModellingWebLab/fccodegen/pull/2#discussion_r237868528"},"pull_request":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2","id":233218252,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjE4MjUy","html_url":"https://github.com/ModellingWebLab/fccodegen/pull/2","diff_url":"https://github.com/ModellingWebLab/fccodegen/pull/2.diff","patch_url":"https://github.com/ModellingWebLab/fccodegen/pull/2.patch","issue_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/2","number":2,"state":"open","locked":false,"title":"CellML loading and expression printing","user":{"login":"MichaelClerx","id":517644,"node_id":"MDQ6VXNlcjUxNzY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/517644?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelClerx","html_url":"https://github.com/MichaelClerx","followers_url":"https://api.github.com/users/MichaelClerx/followers","following_url":"https://api.github.com/users/MichaelClerx/following{/other_user}","gists_url":"https://api.github.com/users/MichaelClerx/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelClerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelClerx/subscriptions","organizations_url":"https://api.github.com/users/MichaelClerx/orgs","repos_url":"https://api.github.com/users/MichaelClerx/repos","events_url":"https://api.github.com/users/MichaelClerx/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelClerx/received_events","type":"User","site_admin":false},"body":"Still a work in progress","created_at":"2018-11-23T14:38:54Z","updated_at":"2018-11-30T13:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f27f13f9591812b4209c11b8b892b7ae5f0e9a6","assignee":{"login":"MichaelClerx","id":517644,"node_id":"MDQ6VXNlcjUxNzY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/517644?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelClerx","html_url":"https://github.com/MichaelClerx","followers_url":"https://api.github.com/users/MichaelClerx/followers","following_url":"https://api.github.com/users/MichaelClerx/following{/other_user}","gists_url":"https://api.github.com/users/MichaelClerx/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelClerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelClerx/subscriptions","organizations_url":"https://api.github.com/users/MichaelClerx/orgs","repos_url":"https://api.github.com/users/MichaelClerx/repos","events_url":"https://api.github.com/users/MichaelClerx/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelClerx/received_events","type":"User","site_admin":false},"assignees":[{"login":"MichaelClerx","id":517644,"node_id":"MDQ6VXNlcjUxNzY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/517644?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelClerx","html_url":"https://github.com/MichaelClerx","followers_url":"https://api.github.com/users/MichaelClerx/followers","following_url":"https://api.github.com/users/MichaelClerx/following{/other_user}","gists_url":"https://api.github.com/users/MichaelClerx/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelClerx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelClerx/subscriptions","organizations_url":"https://api.github.com/users/MichaelClerx/orgs","repos_url":"https://api.github.com/users/MichaelClerx/repos","events_url":"https://api.github.com/users/MichaelClerx/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelClerx/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tamuri","id":360002,"node_id":"MDQ6VXNlcjM2MDAwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/360002?v=4","gravatar_id":"","url":"https://api.github.com/users/tamuri","html_url":"https://github.com/tamuri","followers_url":"https://api.github.com/users/tamuri/followers","following_url":"https://api.github.com/users/tamuri/following{/other_user}","gists_url":"https://api.github.com/users/tamuri/gists{/gist_id}","starred_url":"https://api.github.com/users/tamuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamuri/subscriptions","organizations_url":"https://api.github.com/users/tamuri/orgs","repos_url":"https://api.github.com/users/tamuri/repos","events_url":"https://api.github.com/users/tamuri/events{/privacy}","received_events_url":"https://api.github.com/users/tamuri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1113920985,"node_id":"MDU6TGFiZWwxMTEzOTIwOTg1","url":"https://api.github.com/repos/ModellingWebLab/fccodegen/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/2/comments","statuses_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/statuses/70b09bf8b3eb6808552a007f66c4e6b3f84ed9ee","head":{"label":"ModellingWebLab:cellmlmanip_usage","ref":"cellmlmanip_usage","sha":"70b09bf8b3eb6808552a007f66c4e6b3f84ed9ee","user":{"login":"ModellingWebLab","id":29707434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA3NDM0","avatar_url":"https://avatars3.githubusercontent.com/u/29707434?v=4","gravatar_id":"","url":"https://api.github.com/users/ModellingWebLab","html_url":"https://github.com/ModellingWebLab","followers_url":"https://api.github.com/users/ModellingWebLab/followers","following_url":"https://api.github.com/users/ModellingWebLab/following{/other_user}","gists_url":"https://api.github.com/users/ModellingWebLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ModellingWebLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModellingWebLab/subscriptions","organizations_url":"https://api.github.com/users/ModellingWebLab/orgs","repos_url":"https://api.github.com/users/ModellingWebLab/repos","events_url":"https://api.github.com/users/ModellingWebLab/events{/privacy}","received_events_url":"https://api.github.com/users/ModellingWebLab/received_events","type":"Organization","site_admin":false},"repo":{"id":155874563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4NzQ1NjM=","name":"fccodegen","full_name":"ModellingWebLab/fccodegen","private":false,"owner":{"login":"ModellingWebLab","id":29707434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA3NDM0","avatar_url":"https://avatars3.githubusercontent.com/u/29707434?v=4","gravatar_id":"","url":"https://api.github.com/users/ModellingWebLab","html_url":"https://github.com/ModellingWebLab","followers_url":"https://api.github.com/users/ModellingWebLab/followers","following_url":"https://api.github.com/users/ModellingWebLab/following{/other_user}","gists_url":"https://api.github.com/users/ModellingWebLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ModellingWebLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModellingWebLab/subscriptions","organizations_url":"https://api.github.com/users/ModellingWebLab/orgs","repos_url":"https://api.github.com/users/ModellingWebLab/repos","events_url":"https://api.github.com/users/ModellingWebLab/events{/privacy}","received_events_url":"https://api.github.com/users/ModellingWebLab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ModellingWebLab/fccodegen","description":"Code generation for the web lab","fork":false,"url":"https://api.github.com/repos/ModellingWebLab/fccodegen","forks_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/forks","keys_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/teams","hooks_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/hooks","issue_events_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/events{/number}","events_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/events","assignees_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/assignees{/user}","branches_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/branches{/branch}","tags_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/tags","blobs_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/statuses/{sha}","languages_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/languages","stargazers_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/stargazers","contributors_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/contributors","subscribers_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/subscribers","subscription_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/subscription","commits_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/contents/{+path}","compare_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/merges","archive_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/downloads","issues_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues{/number}","pulls_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls{/number}","milestones_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/milestones{/number}","notifications_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/labels{/name}","releases_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/releases{/id}","deployments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/deployments","created_at":"2018-11-02T14:07:51Z","updated_at":"2018-11-19T12:22:05Z","pushed_at":"2018-11-30T13:42:31Z","git_url":"git://github.com/ModellingWebLab/fccodegen.git","ssh_url":"git@github.com:ModellingWebLab/fccodegen.git","clone_url":"https://github.com/ModellingWebLab/fccodegen.git","svn_url":"https://github.com/ModellingWebLab/fccodegen","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ModellingWebLab:master","ref":"master","sha":"1b0f840a283a580626d91a317e72d0ebb7b4a721","user":{"login":"ModellingWebLab","id":29707434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA3NDM0","avatar_url":"https://avatars3.githubusercontent.com/u/29707434?v=4","gravatar_id":"","url":"https://api.github.com/users/ModellingWebLab","html_url":"https://github.com/ModellingWebLab","followers_url":"https://api.github.com/users/ModellingWebLab/followers","following_url":"https://api.github.com/users/ModellingWebLab/following{/other_user}","gists_url":"https://api.github.com/users/ModellingWebLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ModellingWebLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModellingWebLab/subscriptions","organizations_url":"https://api.github.com/users/ModellingWebLab/orgs","repos_url":"https://api.github.com/users/ModellingWebLab/repos","events_url":"https://api.github.com/users/ModellingWebLab/events{/privacy}","received_events_url":"https://api.github.com/users/ModellingWebLab/received_events","type":"Organization","site_admin":false},"repo":{"id":155874563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4NzQ1NjM=","name":"fccodegen","full_name":"ModellingWebLab/fccodegen","private":false,"owner":{"login":"ModellingWebLab","id":29707434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzA3NDM0","avatar_url":"https://avatars3.githubusercontent.com/u/29707434?v=4","gravatar_id":"","url":"https://api.github.com/users/ModellingWebLab","html_url":"https://github.com/ModellingWebLab","followers_url":"https://api.github.com/users/ModellingWebLab/followers","following_url":"https://api.github.com/users/ModellingWebLab/following{/other_user}","gists_url":"https://api.github.com/users/ModellingWebLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ModellingWebLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModellingWebLab/subscriptions","organizations_url":"https://api.github.com/users/ModellingWebLab/orgs","repos_url":"https://api.github.com/users/ModellingWebLab/repos","events_url":"https://api.github.com/users/ModellingWebLab/events{/privacy}","received_events_url":"https://api.github.com/users/ModellingWebLab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ModellingWebLab/fccodegen","description":"Code generation for the web lab","fork":false,"url":"https://api.github.com/repos/ModellingWebLab/fccodegen","forks_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/forks","keys_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/teams","hooks_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/hooks","issue_events_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/events{/number}","events_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/events","assignees_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/assignees{/user}","branches_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/branches{/branch}","tags_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/tags","blobs_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/statuses/{sha}","languages_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/languages","stargazers_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/stargazers","contributors_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/contributors","subscribers_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/subscribers","subscription_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/subscription","commits_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/contents/{+path}","compare_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/merges","archive_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/downloads","issues_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues{/number}","pulls_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls{/number}","milestones_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/milestones{/number}","notifications_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/labels{/name}","releases_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/releases{/id}","deployments_url":"https://api.github.com/repos/ModellingWebLab/fccodegen/deployments","created_at":"2018-11-02T14:07:51Z","updated_at":"2018-11-19T12:22:05Z","pushed_at":"2018-11-30T13:42:31Z","git_url":"git://github.com/ModellingWebLab/fccodegen.git","ssh_url":"git@github.com:ModellingWebLab/fccodegen.git","clone_url":"https://github.com/ModellingWebLab/fccodegen.git","svn_url":"https://github.com/ModellingWebLab/fccodegen","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2"},"html":{"href":"https://github.com/ModellingWebLab/fccodegen/pull/2"},"issue":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/2"},"comments":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ModellingWebLab/fccodegen/statuses/70b09bf8b3eb6808552a007f66c4e6b3f84ed9ee"}},"author_association":"CONTRIBUTOR"}} | {
"id": 155874563,
"name": "ModellingWebLab/fccodegen",
"url": "https://api.github.com/repos/ModellingWebLab/fccodegen"
} | {
"id": 2032871,
"login": "jonc125",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2032871?",
"url": "https://api.github.com/users/jonc125"
} | {
"id": 29707434,
"login": "ModellingWebLab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29707434?",
"url": "https://api.github.com/orgs/ModellingWebLab"
} | 2018-11-30T13:58:23 | 8676382988 | {"actor":{"display_login":"jonc125"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/trias-project/trias/pulls/comments/185817091","pull_request_review_id":117283205,"id":185817091,"diff_hunk":"@@ -0,0 +1,76 @@\n+#' Spread a key-value pair across multiple columns in presence of duplicates\n+#' \n+#' @param .data A dataframe.\n+#' @param key,value Column names or positions.\n+#' @param fill If set, missing values will be replaced with this value.\n+#' @param aggfunc Aggregation function. \n+#' Default: NA (keep dulicates)\n+#' @return A data.frame\n+#' @examples \n+#' test1 <- data.frame(col1 = c(1, 1, 1, 1),\t\n+#' col2 = c(\"H\", \"H\", \"H\", \"H\"),\n+#' key = c(\"A\", \"B\", \"C\", \"C\"),\n+#' value = c(\"R\", \"S\", \"T\", \"X\"),\n+#' stringsAsFactors = FALSE)\n+#' spread_with_duplicates(test1, key, value)\n+#' spread_with_duplicates(test1, 3, 4)\n+#' spread_with_duplicates(test1, -2, -1)","path":"R/spread_with_duplicates.R","position":null,"original_position":17,"commit_id":"78f36641a777e2a8572a50daf6d0903dbdc5c04d","original_commit_id":"217d8853c212be422f92e0044722ce6e5b962a8e","user":{"login":"damianooldoni","id":33662631,"avatar_url":"https://avatars1.githubusercontent.com/u/33662631?v=4","gravatar_id":"","url":"https://api.github.com/users/damianooldoni","html_url":"https://github.com/damianooldoni","followers_url":"https://api.github.com/users/damianooldoni/followers","following_url":"https://api.github.com/users/damianooldoni/following{/other_user}","gists_url":"https://api.github.com/users/damianooldoni/gists{/gist_id}","starred_url":"https://api.github.com/users/damianooldoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianooldoni/subscriptions","organizations_url":"https://api.github.com/users/damianooldoni/orgs","repos_url":"https://api.github.com/users/damianooldoni/repos","events_url":"https://api.github.com/users/damianooldoni/events{/privacy}","received_events_url":"https://api.github.com/users/damianooldoni/received_events","type":"User","site_admin":false},"body":"Now `spread_with_duplicates()`doesn't crash if not strings values are in key column. So, they are automatically converted to strings while applying `rename()`\r\nsee 78f3664 \r\nFor example, datetime keys are converted nicely and put as column names now:\r\n\r\n```r\r\n#from example in tidyr::spread()\r\nlibrary(dplyr)\r\nstocks <- data.frame(\r\n time = as.Date('2009-01-01') + 0:9,\r\n X = rnorm(10, 0, 1),\r\n Y = rnorm(10, 0, 2),\r\n Z = rnorm(10, 0, 4)\r\n)\r\nstocksm <- stocks %>% gather(stock, price, -time)\r\n# use time column as key\r\nstocksm %>% spread_with_ducpliates(time, price)\r\n```\r\n\r\nSame result as for `stocksm %>% spread(time, price)`","created_at":"2018-05-03T14:27:41Z","updated_at":"2018-05-03T14:27:41Z","html_url":"https://github.com/trias-project/trias/pull/17#discussion_r185817091","pull_request_url":"https://api.github.com/repos/trias-project/trias/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/trias-project/trias/pulls/comments/185817091"},"html":{"href":"https://github.com/trias-project/trias/pull/17#discussion_r185817091"},"pull_request":{"href":"https://api.github.com/repos/trias-project/trias/pulls/17"}},"in_reply_to_id":185600510},"pull_request":{"url":"https://api.github.com/repos/trias-project/trias/pulls/17","id":183420712,"html_url":"https://github.com/trias-project/trias/pull/17","diff_url":"https://github.com/trias-project/trias/pull/17.diff","patch_url":"https://github.com/trias-project/trias/pull/17.patch","issue_url":"https://api.github.com/repos/trias-project/trias/issues/17","number":17,"state":"open","locked":false,"title":"Spread with duplicates","user":{"login":"damianooldoni","id":33662631,"avatar_url":"https://avatars1.githubusercontent.com/u/33662631?v=4","gravatar_id":"","url":"https://api.github.com/users/damianooldoni","html_url":"https://github.com/damianooldoni","followers_url":"https://api.github.com/users/damianooldoni/followers","following_url":"https://api.github.com/users/damianooldoni/following{/other_user}","gists_url":"https://api.github.com/users/damianooldoni/gists{/gist_id}","starred_url":"https://api.github.com/users/damianooldoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianooldoni/subscriptions","organizations_url":"https://api.github.com/users/damianooldoni/orgs","repos_url":"https://api.github.com/users/damianooldoni/repos","events_url":"https://api.github.com/users/damianooldoni/events{/privacy}","received_events_url":"https://api.github.com/users/damianooldoni/received_events","type":"User","site_admin":false},"body":"Function `spread_with_duplicates()` added to this package. I used a 100% tidyverse approach.\r\nThis function answers to the need of spreading key value pairs in presence of duplicates as discussed in #16 .\r\nExamples in function documentation.\r\nPlease, have a look.","created_at":"2018-04-23T12:39:05Z","updated_at":"2018-05-03T14:27:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1c688fc1a3f3d02fd6dc4f2d96d0d4850ff4710","assignee":null,"assignees":[],"requested_reviewers":[{"login":"peterdesmet","id":600993,"avatar_url":"https://avatars3.githubusercontent.com/u/600993?v=4","gravatar_id":"","url":"https://api.github.com/users/peterdesmet","html_url":"https://github.com/peterdesmet","followers_url":"https://api.github.com/users/peterdesmet/followers","following_url":"https://api.github.com/users/peterdesmet/following{/other_user}","gists_url":"https://api.github.com/users/peterdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/peterdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterdesmet/subscriptions","organizations_url":"https://api.github.com/users/peterdesmet/orgs","repos_url":"https://api.github.com/users/peterdesmet/repos","events_url":"https://api.github.com/users/peterdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/peterdesmet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trias-project/trias/pulls/17/commits","review_comments_url":"https://api.github.com/repos/trias-project/trias/pulls/17/comments","review_comment_url":"https://api.github.com/repos/trias-project/trias/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trias-project/trias/issues/17/comments","statuses_url":"https://api.github.com/repos/trias-project/trias/statuses/78f36641a777e2a8572a50daf6d0903dbdc5c04d","head":{"label":"trias-project:spread_with_duplicates","ref":"spread_with_duplicates","sha":"78f36641a777e2a8572a50daf6d0903dbdc5c04d","user":{"login":"trias-project","id":29750687,"avatar_url":"https://avatars3.githubusercontent.com/u/29750687?v=4","gravatar_id":"","url":"https://api.github.com/users/trias-project","html_url":"https://github.com/trias-project","followers_url":"https://api.github.com/users/trias-project/followers","following_url":"https://api.github.com/users/trias-project/following{/other_user}","gists_url":"https://api.github.com/users/trias-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trias-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trias-project/subscriptions","organizations_url":"https://api.github.com/users/trias-project/orgs","repos_url":"https://api.github.com/users/trias-project/repos","events_url":"https://api.github.com/users/trias-project/events{/privacy}","received_events_url":"https://api.github.com/users/trias-project/received_events","type":"Organization","site_admin":false},"repo":{"id":111584976,"name":"trias","full_name":"trias-project/trias","owner":{"login":"trias-project","id":29750687,"avatar_url":"https://avatars3.githubusercontent.com/u/29750687?v=4","gravatar_id":"","url":"https://api.github.com/users/trias-project","html_url":"https://github.com/trias-project","followers_url":"https://api.github.com/users/trias-project/followers","following_url":"https://api.github.com/users/trias-project/following{/other_user}","gists_url":"https://api.github.com/users/trias-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trias-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trias-project/subscriptions","organizations_url":"https://api.github.com/users/trias-project/orgs","repos_url":"https://api.github.com/users/trias-project/repos","events_url":"https://api.github.com/users/trias-project/events{/privacy}","received_events_url":"https://api.github.com/users/trias-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trias-project/trias","description":"📦 R package with functions for TrIAS","fork":false,"url":"https://api.github.com/repos/trias-project/trias","forks_url":"https://api.github.com/repos/trias-project/trias/forks","keys_url":"https://api.github.com/repos/trias-project/trias/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trias-project/trias/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trias-project/trias/teams","hooks_url":"https://api.github.com/repos/trias-project/trias/hooks","issue_events_url":"https://api.github.com/repos/trias-project/trias/issues/events{/number}","events_url":"https://api.github.com/repos/trias-project/trias/events","assignees_url":"https://api.github.com/repos/trias-project/trias/assignees{/user}","branches_url":"https://api.github.com/repos/trias-project/trias/branches{/branch}","tags_url":"https://api.github.com/repos/trias-project/trias/tags","blobs_url":"https://api.github.com/repos/trias-project/trias/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trias-project/trias/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trias-project/trias/git/refs{/sha}","trees_url":"https://api.github.com/repos/trias-project/trias/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trias-project/trias/statuses/{sha}","languages_url":"https://api.github.com/repos/trias-project/trias/languages","stargazers_url":"https://api.github.com/repos/trias-project/trias/stargazers","contributors_url":"https://api.github.com/repos/trias-project/trias/contributors","subscribers_url":"https://api.github.com/repos/trias-project/trias/subscribers","subscription_url":"https://api.github.com/repos/trias-project/trias/subscription","commits_url":"https://api.github.com/repos/trias-project/trias/commits{/sha}","git_commits_url":"https://api.github.com/repos/trias-project/trias/git/commits{/sha}","comments_url":"https://api.github.com/repos/trias-project/trias/comments{/number}","issue_comment_url":"https://api.github.com/repos/trias-project/trias/issues/comments{/number}","contents_url":"https://api.github.com/repos/trias-project/trias/contents/{+path}","compare_url":"https://api.github.com/repos/trias-project/trias/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trias-project/trias/merges","archive_url":"https://api.github.com/repos/trias-project/trias/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trias-project/trias/downloads","issues_url":"https://api.github.com/repos/trias-project/trias/issues{/number}","pulls_url":"https://api.github.com/repos/trias-project/trias/pulls{/number}","milestones_url":"https://api.github.com/repos/trias-project/trias/milestones{/number}","notifications_url":"https://api.github.com/repos/trias-project/trias/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trias-project/trias/labels{/name}","releases_url":"https://api.github.com/repos/trias-project/trias/releases{/id}","deployments_url":"https://api.github.com/repos/trias-project/trias/deployments","created_at":"2017-11-21T18:14:48Z","updated_at":"2018-04-10T10:28:41Z","pushed_at":"2018-05-03T14:14:51Z","git_url":"git://github.com/trias-project/trias.git","ssh_url":"git@github.com:trias-project/trias.git","clone_url":"https://github.com/trias-project/trias.git","svn_url":"https://github.com/trias-project/trias","homepage":"","size":462,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"trias-project:master","ref":"master","sha":"9f8ee182452d1e0cc74a6109c7c4a84f3a9b9ab2","user":{"login":"trias-project","id":29750687,"avatar_url":"https://avatars3.githubusercontent.com/u/29750687?v=4","gravatar_id":"","url":"https://api.github.com/users/trias-project","html_url":"https://github.com/trias-project","followers_url":"https://api.github.com/users/trias-project/followers","following_url":"https://api.github.com/users/trias-project/following{/other_user}","gists_url":"https://api.github.com/users/trias-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trias-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trias-project/subscriptions","organizations_url":"https://api.github.com/users/trias-project/orgs","repos_url":"https://api.github.com/users/trias-project/repos","events_url":"https://api.github.com/users/trias-project/events{/privacy}","received_events_url":"https://api.github.com/users/trias-project/received_events","type":"Organization","site_admin":false},"repo":{"id":111584976,"name":"trias","full_name":"trias-project/trias","owner":{"login":"trias-project","id":29750687,"avatar_url":"https://avatars3.githubusercontent.com/u/29750687?v=4","gravatar_id":"","url":"https://api.github.com/users/trias-project","html_url":"https://github.com/trias-project","followers_url":"https://api.github.com/users/trias-project/followers","following_url":"https://api.github.com/users/trias-project/following{/other_user}","gists_url":"https://api.github.com/users/trias-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trias-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trias-project/subscriptions","organizations_url":"https://api.github.com/users/trias-project/orgs","repos_url":"https://api.github.com/users/trias-project/repos","events_url":"https://api.github.com/users/trias-project/events{/privacy}","received_events_url":"https://api.github.com/users/trias-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trias-project/trias","description":"📦 R package with functions for TrIAS","fork":false,"url":"https://api.github.com/repos/trias-project/trias","forks_url":"https://api.github.com/repos/trias-project/trias/forks","keys_url":"https://api.github.com/repos/trias-project/trias/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trias-project/trias/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trias-project/trias/teams","hooks_url":"https://api.github.com/repos/trias-project/trias/hooks","issue_events_url":"https://api.github.com/repos/trias-project/trias/issues/events{/number}","events_url":"https://api.github.com/repos/trias-project/trias/events","assignees_url":"https://api.github.com/repos/trias-project/trias/assignees{/user}","branches_url":"https://api.github.com/repos/trias-project/trias/branches{/branch}","tags_url":"https://api.github.com/repos/trias-project/trias/tags","blobs_url":"https://api.github.com/repos/trias-project/trias/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trias-project/trias/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trias-project/trias/git/refs{/sha}","trees_url":"https://api.github.com/repos/trias-project/trias/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trias-project/trias/statuses/{sha}","languages_url":"https://api.github.com/repos/trias-project/trias/languages","stargazers_url":"https://api.github.com/repos/trias-project/trias/stargazers","contributors_url":"https://api.github.com/repos/trias-project/trias/contributors","subscribers_url":"https://api.github.com/repos/trias-project/trias/subscribers","subscription_url":"https://api.github.com/repos/trias-project/trias/subscription","commits_url":"https://api.github.com/repos/trias-project/trias/commits{/sha}","git_commits_url":"https://api.github.com/repos/trias-project/trias/git/commits{/sha}","comments_url":"https://api.github.com/repos/trias-project/trias/comments{/number}","issue_comment_url":"https://api.github.com/repos/trias-project/trias/issues/comments{/number}","contents_url":"https://api.github.com/repos/trias-project/trias/contents/{+path}","compare_url":"https://api.github.com/repos/trias-project/trias/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trias-project/trias/merges","archive_url":"https://api.github.com/repos/trias-project/trias/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trias-project/trias/downloads","issues_url":"https://api.github.com/repos/trias-project/trias/issues{/number}","pulls_url":"https://api.github.com/repos/trias-project/trias/pulls{/number}","milestones_url":"https://api.github.com/repos/trias-project/trias/milestones{/number}","notifications_url":"https://api.github.com/repos/trias-project/trias/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trias-project/trias/labels{/name}","releases_url":"https://api.github.com/repos/trias-project/trias/releases{/id}","deployments_url":"https://api.github.com/repos/trias-project/trias/deployments","created_at":"2017-11-21T18:14:48Z","updated_at":"2018-04-10T10:28:41Z","pushed_at":"2018-05-03T14:14:51Z","git_url":"git://github.com/trias-project/trias.git","ssh_url":"git@github.com:trias-project/trias.git","clone_url":"https://github.com/trias-project/trias.git","svn_url":"https://github.com/trias-project/trias","homepage":"","size":462,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trias-project/trias/pulls/17"},"html":{"href":"https://github.com/trias-project/trias/pull/17"},"issue":{"href":"https://api.github.com/repos/trias-project/trias/issues/17"},"comments":{"href":"https://api.github.com/repos/trias-project/trias/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/trias-project/trias/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/trias-project/trias/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trias-project/trias/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/trias-project/trias/statuses/78f36641a777e2a8572a50daf6d0903dbdc5c04d"}},"author_association":"COLLABORATOR"}} | {
"id": 111584976,
"name": "trias-project/trias",
"url": "https://api.github.com/repos/trias-project/trias"
} | {
"id": 33662631,
"login": "damianooldoni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33662631?",
"url": "https://api.github.com/users/damianooldoni"
} | {
"id": 29750687,
"login": "trias-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29750687?",
"url": "https://api.github.com/orgs/trias-project"
} | 2018-05-03T14:27:41 | 7623212493 | {"actor":{"display_login":"damianooldoni"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/210203922","pull_request_review_id":146368370,"id":210203922,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDIwMzkyMg==","diff_hunk":"@@ -0,0 +1,416 @@\n+package rules\n+\n+import (\n+\t\"context\"\n+\t\"encoding/json\"\n+\t\"errors\"\n+\n+\tuuid \"github.com/satori/go.uuid\"\n+\n+\t\"github.com/fabric8-services/fabric8-wit/application\"\n+\t\"github.com/fabric8-services/fabric8-wit/convert\"\n+\t\"github.com/fabric8-services/fabric8-wit/workitem\"\n+)\n+\n+type ActionStateToMetaState struct {\n+\tDb application.DB\n+\tCtx context.Context\n+\tUserID *uuid.UUID\n+}\n+\n+// make sure the rule is implementing the interface.\n+var _ Action = ActionStateToMetaState{}\n+\n+func (act ActionStateToMetaState) contains(s []uuid.UUID, e uuid.UUID) bool {\n+\tfor _, a := range s {\n+\t\tif a == e {\n+\t\t\treturn true\n+\t\t}\n+\t}\n+\treturn false\n+}\n+\n+func (act ActionStateToMetaState) removeElement(s []uuid.UUID, e uuid.UUID) []uuid.UUID {\n+\tfor idx, a := range s {\n+\t\tif a == e {\n+\t\t\ts = append(s[:idx], s[idx+1:]...)\n+\t\t\t// we don't return here as there may be multiple copies of e in s.\n+\t\t}\n+\t}\n+\treturn s\n+}\n+\n+func (act ActionStateToMetaState) difference(old []uuid.UUID, new []uuid.UUID) ([]uuid.UUID, []uuid.UUID) {\n+\tvar added []uuid.UUID\n+\tvar removed []uuid.UUID\n+\t// added in slice2\n+\tfor _, elem := range new {\n+\t\tif !act.contains(old, elem) {\n+\t\t\tadded = append(added, elem)\n+\t\t}\n+\t}\n+\t// removed in slice2\n+\tfor _, elem := range old {\n+\t\tif !act.contains(new, elem) {\n+\t\t\tremoved = append(removed, elem)\n+\t\t}\n+\t}\n+\treturn added, removed\n+}\n+\n+func (act ActionStateToMetaState) loadWorkItemBoardsBySpaceID(spaceID uuid.UUID) ([]*workitem.Board, error) {\n+\tif act.Ctx == nil {\n+\t\treturn nil, errors.New(\"Context is nil\")\n+\t}\n+\tif act.Db == nil {\n+\t\treturn nil, errors.New(\"Database is nil\")\n+\t}\n+\tspace, err := act.Db.Spaces().Load(act.Ctx, spaceID)\n+\tif err != nil {\n+\t\treturn nil, errors.New(\"Error loading space: \" + err.Error())\n+\t}\n+\tboards, err := act.Db.Boards().List(act.Ctx, space.SpaceTemplateID)\n+\tif err != nil {\n+\t\treturn nil, errors.New(\"Error loading work item type: \" + err.Error())\n+\t}\n+\treturn boards, nil\n+}\n+\n+func (act ActionStateToMetaState) loadWorkItemTypeGroupsBySpaceID(spaceID uuid.UUID) ([]*workitem.WorkItemTypeGroup, error) {\n+\tif act.Ctx == nil {\n+\t\treturn nil, errors.New(\"Context is nil\")\n+\t}\n+\tif act.Db == nil {\n+\t\treturn nil, errors.New(\"Database is nil\")\n+\t}\n+\tspace, err := act.Db.Spaces().Load(act.Ctx, spaceID)\n+\tif err != nil {\n+\t\treturn nil, errors.New(\"Error loading space: \" + err.Error())\n+\t}\n+\tgroups, err := act.Db.WorkItemTypeGroups().List(act.Ctx, space.SpaceTemplateID)\n+\tif err != nil {\n+\t\treturn nil, errors.New(\"Error loading work item type: \" + err.Error())\n+\t}\n+\treturn groups, nil\n+}\n+\n+func (act ActionStateToMetaState) loadWorkItemTypeByID(id uuid.UUID) (*workitem.WorkItemType, error) {\n+\tif act.Ctx == nil {\n+\t\treturn nil, errors.New(\"Context is nil\")\n+\t}\n+\tif act.Db == nil {\n+\t\treturn nil, errors.New(\"Database is nil\")\n+\t}\n+\twit, err := act.Db.WorkItemTypes().Load(act.Ctx, id)\n+\tif err != nil {\n+\t\treturn nil, errors.New(\"Error loading work item type: \" + err.Error())\n+\t}\n+\treturn wit, nil\n+}\n+\n+func (act ActionStateToMetaState) loadWorkItemByID(id uuid.UUID) (*workitem.WorkItem, error) {\n+\tif act.Ctx == nil {\n+\t\treturn nil, errors.New(\"Context is nil\")\n+\t}\n+\tif act.Db == nil {\n+\t\treturn nil, errors.New(\"Database is nil\")\n+\t}\n+\twi, err := act.Db.WorkItems().LoadByID(act.Ctx, id)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\treturn wi, nil\n+}\n+\n+func (act ActionStateToMetaState) storeWorkItem(workitem *workitem.WorkItem) (*workitem.WorkItem, error) {\n+\tif act.Ctx == nil {\n+\t\treturn nil, errors.New(\"Context is nil\")\n+\t}\n+\tif act.Db == nil {\n+\t\treturn nil, errors.New(\"Database is nil\")\n+\t}\n+\tif act.UserID == nil {\n+\t\treturn nil, errors.New(\"UserID is nil\")\n+\t}\n+\terr := application.Transactional(act.Db, func(appl application.Application) error {\n+\t\tvar err error\n+\t\tworkitem, err = appl.WorkItems().Save(act.Ctx, workitem.SpaceID, *workitem, *act.UserID)\n+\t\tif err != nil {\n+\t\t\treturn errors.New(\"Error updating work item\")\n+\t\t}\n+\t\treturn nil\n+\t})\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\treturn workitem, nil\n+}\n+\n+func (act ActionStateToMetaState) getValueListFromFieldType(wit *workitem.WorkItemType, fieldName string) ([]interface{}, error) {\n+\tfieldType := wit.Fields[fieldName].Type\n+\tswitch t := fieldType.(type) {\n+\tcase workitem.EnumType:\n+\t\treturn t.Values, nil\n+\t}\n+\treturn nil, errors.New(\"Given field on workitemtype \" + wit.ID.String() + \" is not an enum field: \" + fieldName)\n+}\n+\n+func (act ActionStateToMetaState) getStateToMetastateMap(workitemTypeID uuid.UUID) (map[string]string, error) {\n+\twit, err := act.loadWorkItemTypeByID(workitemTypeID)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tstateList, err := act.getValueListFromFieldType(wit, workitem.SystemState)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tmetastateList, err := act.getValueListFromFieldType(wit, workitem.SystemMetaState)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tstateToMetastateMap := make(map[string]string)\n+\tfor idx := range stateList {\n+\t\tthisState, ok := stateList[idx].(string)\n+\t\tif !ok {\n+\t\t\treturn nil, errors.New(\"State value in value list is not of type string\")\n+\t\t}\n+\t\tthisMetastate, ok := metastateList[idx].(string)\n+\t\tif !ok {\n+\t\t\treturn nil, errors.New(\"Metastate value in value list is not of type string\")\n+\t\t}\n+\t\tstateToMetastateMap[thisState] = thisMetastate\n+\t}\n+\treturn stateToMetastateMap, nil\n+}\n+\n+func (act ActionStateToMetaState) getMetastateToStateMap(workitemTypeID uuid.UUID) (map[string]string, error) {\n+\tstateToMetastate, err := act.getStateToMetastateMap(workitemTypeID)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tmetastateToStateMap := make(map[string]string)\n+\tfor state, metastate := range stateToMetastate {\n+\t\tmetastateToStateMap[metastate] = state\n+\t}\n+\treturn metastateToStateMap, nil\n+}\n+\n+func (act ActionStateToMetaState) addOrUpdateChange(changes *[]convert.Change, attributeName string, oldValue interface{}, newValue interface{}) []convert.Change {","path":"actions/rules/action_state_to_metastate.go","position":null,"original_position":198,"commit_id":"bcee40a4608033cfe4d3e41cb1ee0e0744a16bb3","original_commit_id":"f0b4df9dbe5e2e9a9229c49b277453f76e282ec0","user":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"body":"Next PR.","created_at":"2018-08-15T08:36:46Z","updated_at":"2018-08-15T08:36:46Z","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/2154#discussion_r210203922","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/210203922"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/2154#discussion_r210203922"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154"}},"in_reply_to_id":204379222},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154","id":199942715,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTQyNzE1","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/2154","diff_url":"https://github.com/fabric8-services/fabric8-wit/pull/2154.diff","patch_url":"https://github.com/fabric8-services/fabric8-wit/pull/2154.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2154","number":2154,"state":"open","locked":false,"title":"feat(actions): Actions for WIT.","user":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"body":"The actions system is a key component for process automation in WIT. It provides a way of executing user-configurable, dynamic process steps depending on user settings, schema settings and events in the WIT.\r\n\r\nThe idea here is to provide a simple, yet powerful \"signal-slot\" system that can connect any \"event\" in the system to any \"action\" with a clear decoupling of events and actions with the goal of making the associations later dynamic and configurable by the user (\"user connects this event to this action\"). Think of a \"IFTTT for WIT\". \r\n\r\nActions are generic and atomic execution steps that do exactly one task and are configurable. The actions system around the actions provide a key-based execution of the actions. \r\n\t \r\nSome examples for an application of this system would be:\r\n\r\n- closing all childs of a parent that is being closed (the user connects the \"close\" attribute change event of a WI to an action that closes all WIs of a matching query).\r\n- sending out notifications for mentions on markdown (the system executes an action \"send notification\" for every mention found in markdown values).\r\n- moving all WIs from one iteration to the next in the time sequence when the original iteration is closed.\r\n\r\nFor all these automations, the actions system provides a re-usable, flexible and later user configurable way of doing that without creating lots of custom code and/or custom process implementations that are hardcoded in the WIT.\r\n\r\nThe current PR provides the basic actions infrastructure and an implementation of action rules for the board view WI placement/moving on state change.\r\n","created_at":"2018-07-08T13:41:44Z","updated_at":"2018-08-15T08:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd31d62c6bc09afed44cee36fe8f400644249fcb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"baijum","id":121129,"node_id":"MDQ6VXNlcjEyMTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/121129?v=4","gravatar_id":"","url":"https://api.github.com/users/baijum","html_url":"https://github.com/baijum","followers_url":"https://api.github.com/users/baijum/followers","following_url":"https://api.github.com/users/baijum/following{/other_user}","gists_url":"https://api.github.com/users/baijum/gists{/gist_id}","starred_url":"https://api.github.com/users/baijum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baijum/subscriptions","organizations_url":"https://api.github.com/users/baijum/orgs","repos_url":"https://api.github.com/users/baijum/repos","events_url":"https://api.github.com/users/baijum/events{/privacy}","received_events_url":"https://api.github.com/users/baijum/received_events","type":"User","site_admin":false},{"login":"DhritiShikhar","id":6303309,"node_id":"MDQ6VXNlcjYzMDMzMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6303309?v=4","gravatar_id":"","url":"https://api.github.com/users/DhritiShikhar","html_url":"https://github.com/DhritiShikhar","followers_url":"https://api.github.com/users/DhritiShikhar/followers","following_url":"https://api.github.com/users/DhritiShikhar/following{/other_user}","gists_url":"https://api.github.com/users/DhritiShikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/DhritiShikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DhritiShikhar/subscriptions","organizations_url":"https://api.github.com/users/DhritiShikhar/orgs","repos_url":"https://api.github.com/users/DhritiShikhar/repos","events_url":"https://api.github.com/users/DhritiShikhar/events{/privacy}","received_events_url":"https://api.github.com/users/DhritiShikhar/received_events","type":"User","site_admin":false},{"login":"tinakurian","id":40298444,"node_id":"MDQ6VXNlcjQwMjk4NDQ0","avatar_url":"https://avatars1.githubusercontent.com/u/40298444?v=4","gravatar_id":"","url":"https://api.github.com/users/tinakurian","html_url":"https://github.com/tinakurian","followers_url":"https://api.github.com/users/tinakurian/followers","following_url":"https://api.github.com/users/tinakurian/following{/other_user}","gists_url":"https://api.github.com/users/tinakurian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinakurian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinakurian/subscriptions","organizations_url":"https://api.github.com/users/tinakurian/orgs","repos_url":"https://api.github.com/users/tinakurian/repos","events_url":"https://api.github.com/users/tinakurian/events{/privacy}","received_events_url":"https://api.github.com/users/tinakurian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2154/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/bcee40a4608033cfe4d3e41cb1ee0e0744a16bb3","head":{"label":"michaelkleinhenz:boardview_actions","ref":"boardview_actions","sha":"bcee40a4608033cfe4d3e41cb1ee0e0744a16bb3","user":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"repo":{"id":131597385,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1OTczODU=","name":"fabric8-wit","full_name":"michaelkleinhenz/fabric8-wit","owner":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelkleinhenz/fabric8-wit","description":null,"fork":true,"url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit","forks_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/forks","keys_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/events","assignees_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/merges","archive_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/deployments","created_at":"2018-04-30T13:11:46Z","updated_at":"2018-08-03T07:09:24Z","pushed_at":"2018-08-15T08:05:20Z","git_url":"git://github.com/michaelkleinhenz/fabric8-wit.git","ssh_url":"git@github.com:michaelkleinhenz/fabric8-wit.git","clone_url":"https://github.com/michaelkleinhenz/fabric8-wit.git","svn_url":"https://github.com/michaelkleinhenz/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":8985,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"19c0e19355ac3b0aa8bdd67e8a9e0854a3843ed2","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MDcwNg==","name":"fabric8-wit","full_name":"fabric8-services/fabric8-wit","owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-wit","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-wit","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2018-08-14T13:35:27Z","pushed_at":"2018-08-15T08:05:22Z","git_url":"git://github.com/fabric8-services/fabric8-wit.git","ssh_url":"git@github.com:fabric8-services/fabric8-wit.git","clone_url":"https://github.com/fabric8-services/fabric8-wit.git","svn_url":"https://github.com/fabric8-services/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":13190,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":80,"open_issues":202,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/2154"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2154"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2154/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2154/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/bcee40a4608033cfe4d3e41cb1ee0e0744a16bb3"}},"author_association":"COLLABORATOR"}} | {
"id": 54260706,
"name": "fabric8-services/fabric8-wit",
"url": "https://api.github.com/repos/fabric8-services/fabric8-wit"
} | {
"id": 7101098,
"login": "michaelkleinhenz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7101098?",
"url": "https://api.github.com/users/michaelkleinhenz"
} | {
"id": 29751612,
"login": "fabric8-services",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29751612?",
"url": "https://api.github.com/orgs/fabric8-services"
} | 2018-08-15T08:36:46 | 8115793064 | {"actor":{"display_login":"michaelkleinhenz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/200605325","pull_request_review_id":134953897,"id":200605325,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDYwNTMyNQ==","diff_hunk":"@@ -0,0 +1,109 @@\n+package design\n+\n+import (\n+\td \"github.com/goadesign/goa/design\"\n+\ta \"github.com/goadesign/goa/design/apidsl\"\n+)\n+\n+var workItemBoardSingle = JSONSingle(\n+\t\"workItemBoard\",\n+\t`A board for work item types`,\n+\tworkItemBoardData,\n+\tworkItemBoardLinks,\n+)\n+\n+var workItemBoardList = JSONList(\n+\t\"workItemBoard\",\n+\t`List of work item boards`,\n+\tworkItemBoardData,\n+\tworkItemBoardLinks,\n+\tnil,\n+)\n+\n+var workItemBoardLinks = a.Type(\"WorkItemBoardLinks\", func() {\n+\ta.Attribute(\"self\", d.String, func() {\n+\t\ta.Example(\"http://api.openshift.io/api/spacetemplates/2d98c73d-6969-4ea6-958a-812c832b6c18/workitemboards\")\n+\t})\n+\ta.Required(\"self\")\n+})\n+\n+var workItemBoardColumnData = a.Type(\"WorkItemBoardColumnData\", func() {\n+\ta.Description(`a column represents a vertical lane in a board`)\n+\ta.Attribute(\"type\", d.String, \"The type string of the work item board column\", func() {\n+\t\ta.Enum(\"boardcolumns\")\n+\t})\n+\ta.Attribute(\"id\", d.UUID, \"ID of the work item board column\", func() {\n+\t\ta.Example(\"712f20e4-2202-4469-9a02-b892b7051b2b\")\n+\t})\n+\ta.Attribute(\"attributes\", workItemBoardColumnAttributes)\n+\ta.Required(\"id\", \"type\", \"attributes\")","path":"design/work_item_board.go","position":39,"original_position":39,"commit_id":"b1dd453e00249348c14675602a8c6e8dde5669b9","original_commit_id":"b1dd453e00249348c14675602a8c6e8dde5669b9","user":{"login":"DhritiShikhar","id":6303309,"node_id":"MDQ6VXNlcjYzMDMzMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6303309?v=4","gravatar_id":"","url":"https://api.github.com/users/DhritiShikhar","html_url":"https://github.com/DhritiShikhar","followers_url":"https://api.github.com/users/DhritiShikhar/followers","following_url":"https://api.github.com/users/DhritiShikhar/following{/other_user}","gists_url":"https://api.github.com/users/DhritiShikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/DhritiShikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DhritiShikhar/subscriptions","organizations_url":"https://api.github.com/users/DhritiShikhar/orgs","repos_url":"https://api.github.com/users/DhritiShikhar/repos","events_url":"https://api.github.com/users/DhritiShikhar/events{/privacy}","received_events_url":"https://api.github.com/users/DhritiShikhar/received_events","type":"User","site_admin":false},"body":"`version` should also be a required attribute","created_at":"2018-07-06T09:51:27Z","updated_at":"2018-07-06T09:51:27Z","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/2111#discussion_r200605325","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/200605325"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/2111#discussion_r200605325"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111","id":193559160,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNTU5MTYw","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/2111","diff_url":"https://github.com/fabric8-services/fabric8-wit/pull/2111.diff","patch_url":"https://github.com/fabric8-services/fabric8-wit/pull/2111.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2111","number":2111,"state":"open","locked":false,"title":"WIP: feat(boardview): Board View for WIT.","user":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"body":"# Board View for WIT Backend Services\r\n\r\n## Description\r\nThis implements the backend support for board views. It contains changes to the JSONAPI services as well as to the space template system. It provides backend support for a flexible, extensible board view implementation.\r\n\r\n# Board View for WIT Backend Services\r\n\r\nImplements User Stories:\r\n - Board Configuration on Process Template: https://openshift.io/openshiftio/openshiftio/plan/detail/1725\r\n - Basic Board View for Planner: https://openshift.io/openshiftio/openshiftio/plan/detail/2073\r\n\r\n## Description\r\nThis implements the backend support for board views. It contains changes to the JSONAPI services as well as to the space template system. It provides backend support for a flexible, extensible board view implementation.\r\n\r\n## Changes to the JSONAPI\r\n\r\nThis section describes the API of the new service changes. It defines new entities available through JSONAPI as well as the changes to existing endpoints.\r\n\r\n### Board/Column Definition in the Space Template Response\r\n\r\nThe response for `/spacetemplates` and `/spacetemplates/:id` gets a new relationship for the board definition:\r\n\r\n```yaml\r\n# [...]\r\n\"workitemboards\": {\r\n \"links\": {\r\n \"related\": \"http://api/spacetemplates/000-000-001/workitemboards\"\r\n }\r\n},\r\n# [...]\r\n```\r\n\r\nNote that this relationship will *not* be present on the response for `/space/:id` as having normalized template information on the `space` relationships is deprecated. The client should always use the provided `space-template` relationship on the `space` entitiy to pull template information.\r\n\r\nThe new external relationship `workitemboards` is available at the endpoint `/spacetemplates/:id/workitemboards` and has the following structure: \r\n\r\n```yaml\r\n{\r\n \"id\": \"000-000-002\",\r\n \"attributes\": {\r\n \"name\": \"Scenarios Board\",\r\n \"description\": \"This is the default board config for the legacy template (Experiences).\",\r\n \"contextType\": \"TypeLevelContext\", // this designates the type of the context\r\n \"context\": \"000-000-003\", // this designates the ID of the context, in this case the typegroup ID\r\n \"created-at\": \"0001-01-01T00:00:00Z\",\r\n \"updated-at\": \"0001-01-01T00:00:00Z\"\r\n },\r\n \"relationships\": {\r\n \"spaceTemplate\": {\r\n \"data\": {\r\n \"id\": \"000-000-004\",\r\n \"type\": \"spacetemplates\"\r\n }\r\n },\r\n \"columns\": {\r\n \"data\": [\r\n {\r\n \"id\": \"000-000-005\",\r\n \"type\": \"boardcolumns\"\r\n }\r\n ]\r\n }\r\n },\r\n \"included\": [\r\n {\r\n \"id\": \"000-000-005\",\r\n \"title\": \"workitemboardcolumn\",\r\n \"columnOrder\": 0, // the left-to-right order of the column in the view\r\n \"type\": \"boardcolumns\"\r\n }\r\n ],\r\n \"type\": \"workitemboards\"\r\n}\r\n```\r\n\r\nNote that clients should always use the `related` link from the `/spacetemplate` response to pull the column definitions. The column definitions are attached as an included relationship to match the JSONAPI standard.\r\n\r\nThere might be zero or more `onUpdateActions` defined on a `boardcolumns` definition. The definition, including the `transRuleKey` and `transRuleArguments` values are only used on the WIT side and should not be used by the UI. They are provided for a future use case where the user might be allowed to update those values to change the board behaviour. `transRuleKey` describes the rule/action that is executed when a Work Item is moved *into* this column while `transRuleArguments` gives additional parameters for this action. In the current state of the implementation, this will execute a rule that updates the state of the Work Item moved into the column based on the meta-state given in `transRuleArguments`. In the future, there might be other rules/actions and different arguments. One example could be to create columns for labels. In this case, the rule/action needs to update the labels on the Work Item and the `transRuleArguments` may contain the label attached to the described column.\r\n\r\nThe columns are described as an embedded JSONAPI relationship. `onUpdateActions` are also described as included relationships.\r\n\r\n### Board Position Data on the Work Item Response\r\n\r\nThe response to `/workitems` and `/workitems/:id` is updated to contain the positions of the Work Item in the boards. Note that a Work Item may have multiple positions as a Work Item can and will appear in multiple boards. A Work Item can appear only once in each board though:\r\n\r\n```yaml\r\n{\r\n \"data\": [\r\n {\r\n \"attributes\": {\r\n \"system.created_at\": \"0001-01-01T00:00:00Z\",\r\n \"system.title\":\"Some Work Item\",\r\n # [...]\r\n },\r\n relationships: {\r\n \"boardcolumns\": {\r\n \"data\": [\r\n {\r\n \"id\":\"000-000-005\",\r\n \"type\":\"boardcolumns\"\r\n }\r\n ]\r\n } \r\n },\r\n # [...]\r\n```\r\n\r\nThe ID reference of the board column is always referring to the UUID of a column. The board is given implicitly as we're dealing with UUIDs. The column positions are described as an embedded JSONAPI relationship.\r\n\r\n### Meta State on the Work Item\r\n\r\nThe meta-state is not directly connected to the board/column definitions, but to the first application of that system, mapping states to board columns. The meta-state is stored with the Work Item and returned as a standard JSONAPI attribute:\r\n\r\n```yaml\r\n{\r\n \"data\": [\r\n {\r\n \"attributes\": {\r\n \"system.created_at\": \"0001-01-01T00:00:00Z\",\r\n \"system.title\": \"Some Work Item\",\r\n \"system.metastate\": \"mInprogress\",\r\n # [...]\r\n },\r\n# [...]\r\n```\r\n\r\n### Rule/Actions on Work Item Data Updates\r\n\r\nThe rules/actions being executed on Work Item data changes are exposed by a new relationship `onUpdateActions` on the ` /workitemtypes` and `/workitemtypes/:id` responses:\r\n\r\n```yaml\r\n# [...]\r\n\"onUpdateActions\": {\r\n \"data\": [\r\n {\r\n \"id\": \"000-000-006\",\r\n \"type\": \"onUpdateActions\",\r\n \"transRuleKey\": \"updateColumnPositionFromStateChange\",\r\n \"transRuleArguments\": { \r\n \"someArgument\": \"someValue\" \r\n }\r\n }\r\n ]\r\n}\r\n# [...]\r\n```\r\n\r\nThere may be zero or more rules defined on a Work Item Type. Note that the rule/action information is not (yet) used on the UI. This might change when we allow the user to update those values to change the board view behaviour. \r\n\r\nThe rule/action system might later be used beyond the board view use case as a generic \"onUpdate\" mechanism.\r\n\r\n## Updates on the Board Position and State Values\r\n\r\nThe above only describes the schema of the board positions and the meta-state values. This section will describe how to update those values.\r\n\r\n### Update the Position of Work Items on a Board\r\n\r\nWhen a Work Item is moved on a board by the user, a rule/action is executed on the WIT side on update of the `boardcolumns` relationship. Clients are expected to send a `PATCH` request with the updated list of `boardcolumns` to `/workitems/:id`. *The response of the `PATCH` request contains an updated Work Item that may contain updated attribute and/or relationship values* (for example, an updated `system.state` attribute). The client is expected to update the local Work Item data from that response.\r\n\r\nThe rule/action being executed on the WIT side is defined by `transRuleID` and `transRuleArguments` values in the board definition (see above). If a card is moved on the board, that rule/action get executed and calculate the updates necessary to the Work Item.\r\n\r\n### Update of Work Item Data\r\n\r\nWhen a Work Item is updated (either attributes or relationships), the WIT will re-calculate the board positions of the particular Work Item. The client is expected to send a `PATCH` request to `/workitems/:id` as usual to update Work Item data. *The response of the `PATCH` request contains an updated Work Item that may contain updated attribute and/or relationship values* (for example, an updated `boardcolumns` relationship). The client is expected to update the local Work Item data from that response.\r\n\r\nThe rule/action being executed on the WIT side is defined by the `onUpdateActions` relationship on the Work Item Type definition (see above). If a Work Item is updated, the rules/actions are executed and the new board positions for the Work Item are calculated.\r\n \r\n## Querying for Work Items related to a Board View\r\n\r\nWhen displaying the board view, the UI needs a way to get all Work Items that are related to that board view. This is done by extending the query language for criterias on boards and columns:\r\n\r\n```\r\n{ $AND: [\r\n { space: { $EQ: mySpaceID } },\r\n { typegroup.name: { $EQ: Execution } },\r\n { iteration: { $EQ: myIterationID } },\r\n { column: { $EQ: myColumnID }}\r\n ]}\r\n```\r\n\r\nOr for getting all Work Items on an entire board:\r\n\r\n```\r\n{ $AND: [\r\n { space: { $EQ: mySpaceID } },\r\n { typegroup.name: { $EQ: Execution } },\r\n { iteration: { $EQ: myIterationID } },\r\n { board: { $EQ: myBoardID }}\r\n ]}\r\n```\r\n\r\nThe new criterias `column` and `board` can be used with other query language features as usual to allow for more fine-granular filtering. The `boardID` and `columnID` values can be retrieved from the board definition contained in the Space Template.\r\n\r\n## Internal Wiring\r\n\r\n### Default Board Definition in the Space Templates\r\n\r\nThe default board definition has to be added to the Space Template definition. This is done through the YAML definition files:\r\n\r\n```yaml\r\nboard_config:\r\n\r\n- id: \"24181b5c-713f-4bef-a19f-45240875da92\"\r\n name: Scenarios Board\r\n description: This is the default board config for the legacy template (Scenarios).\r\n context: \"679a563c-ac9b-4478-9f3e-4187f708dd30\"\r\n contextType: \"TypeLevelContext\"\r\n columns:\r\n - id: \"b4edad70-1d77-4e5a-b973-0f0d599fd20d\"\r\n title: \"New\"\r\n order: 0\r\n transRuleKey: \"updateStateFromColumnMove\"\r\n transRuleArguments: \"{ metaState: 'mNew' }\"\r\n - id: \"b4edad70-1d77-4e5a-b973-0f0d599fd20d\"\r\n title: \"In Progress\"\r\n order: 0\r\n transRuleKey: \"updateStateFromColumnMove\"\r\n transRuleArguments: \"{ metaState: 'mInprogress' }\"\r\n\r\n- id: \"56d62801-798a-4bb0-9c97-89f136f3d539\"\r\n name: Experiences Board\r\n description: This is the default board config for the legacy template (Experiences).\r\n context: \"8e4c995d-8e5f-4ad6-85bd-3cfbe718f908\"\r\n contextType: \"TypeLevelContext\"\r\n columns:\r\n - id: \"b4edad70-1d77-4e5a-b973-0f0d599fd20d\"\r\n title: \"New\"\r\n order: 0\r\n transRuleKey: \"updateStateFromColumnMove\"\r\n transRuleArguments: \"{ metaState: 'mNew' }\"\r\n - id: \"ba79f468-d2b3-4f9b-a0de-3817f40d64b4\"\r\n title: \"In Progress\"\r\n order: 0\r\n transRuleKey: \"updateStateFromColumnMove\"\r\n transRuleArguments: \"{ metaState: 'mInprogress' }\"\r\n```\r\n\r\nThe default board definitions get loaded/updated into the database on launch in the same way the Work Item Type definitions are bootstrapped.\r\n\r\n### New Database Table holding the Column Definitions\r\n\r\nThis is the table that holds the board definition for a specific board of a specific Space. A Work Item placed in a column links back to exactly one `boardcolumn` entry per `boardID`. A Work Item may be in multiple columns but only in one column per board. The `boardcolumns` defintions link back to a Space template (`spaceTemplateID`), not a Space as we don’t allow customization yet and the schema is modelled the same way the Work Item Types are modelled. That means that `columnID` and `boardID` are the same for Spaces using the same Space template. This is not an issue as the Work Item definition links back to the Space, so the context is given.\r\n\r\n(Pseudocode)\r\n```sql\r\nCREATE TABLE boardcolumns ( \r\n id UUID NOT NULL,\r\n spaceTemplateID UUID NOT NULL,\r\n boardID UUID NOT NULL,\r\n columnID UUID NOT NULL,\r\n columnOrder INT,\r\n context UUID NOT NULL, // typeLevelID for now, but is generic\r\n contextType VARCHAR NOT NULL, // \"TypeLevelContext\"\r\n transRuleKey VARCHAR NOT NULL, // \"updateStateFromColumnMove\"\r\n transRuleArguments JSONB, // contains { metaState: \"mSomeState\" }\r\n columnTitle VARCHAR NOT NULL\r\n)\r\n```\r\n\r\n| **ID** | **spaceTemplateID** | **boardID** | **columnID** | **cOrder** | **transRuleID** | **transRuleArguments** | **context** | **contextType** | **columnTitle** |\r\n| ------ | ------------------- | ----------- | ------------ | ---------- | --------------- | ---------------------------- | ----------- | --------------- | --------------- |\r\n| 1 | s0 | s0-b0 | s0-b0-c0 | 0 | upFrCMove | { metaState: \"mNew\" } | ExId | TLContext | Todo |\r\n| 2 | s0 | s0-b0 | s0-b0-c1 | 1 | upFrCMove | { metaState: \"mInprogress\" } | ExId | TLContext | In Progress |\r\n| 3 | s0 | s0-b0 | s0-b0-c2 | 2 | upFrCMove | { metaState: \"mDone } | ExId | TLContext | Done |\r\n| 4 | s0 | s0-b1 | s0-b1-c0 | 0 | upFrCMove | { metaState: \"mNew\" } | ScenId | TLContext | New |\r\n| 5 | s0 | s0-b1 | s0-b1-c1 | 1 | upFrCMove | { metaState: \"mInprogress\" } | ScenId | TLContext | Working |\r\n| 6 | s0 | s0-b1 | s0-b1-c2 | 2 | upFrCMove | { metaState: \"mDone\" } | ScenId | TLContext | Closed |\r\n\r\n### Meta-State in the Space Template Definition [DONE]\r\n\r\nThe meta-state is stored and covered by a new Work Item Type attribute that provides the mapping by using the ordered nature of the enum definitions in the space template. The new attribute is added to the generalized WIT definition so it is inherited by all existing WITs in all templates:\r\n\r\n```yaml\r\n\"system.metastate\":\r\n label: Meta-State\r\n description: The meta-state of the work item\r\n read_only: yes\r\n required: yes\r\n type:\r\n simple_type:\r\n kind: enum\r\n base_type:\r\n kind: string\r\n # This will allow other WITs to overwrite the values of the state.\r\n rewritable_values: yes\r\n # the sequence of the values need to match the sequence of the \r\n # system.state attributes. This encapsulates the mapping.\r\n values: \r\n - mNew\r\n - mOpen\r\n - mInprogress\r\n - mResolved\r\n - mClosed\r\n```\r\n\r\nThe implementation needs to get the set of `system.state` values and the set of the `system.metastate` values to get the mapping from state to meta-state. The meta-state will be added to the Work Item JSONAPI model response like every other attribute (see above).\r\n","created_at":"2018-06-08T09:34:23Z","updated_at":"2018-07-06T09:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7ef222bf536ee6f2cc1b737fdfb5e2882088a4f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"baijum","id":121129,"node_id":"MDQ6VXNlcjEyMTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/121129?v=4","gravatar_id":"","url":"https://api.github.com/users/baijum","html_url":"https://github.com/baijum","followers_url":"https://api.github.com/users/baijum/followers","following_url":"https://api.github.com/users/baijum/following{/other_user}","gists_url":"https://api.github.com/users/baijum/gists{/gist_id}","starred_url":"https://api.github.com/users/baijum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baijum/subscriptions","organizations_url":"https://api.github.com/users/baijum/orgs","repos_url":"https://api.github.com/users/baijum/repos","events_url":"https://api.github.com/users/baijum/events{/privacy}","received_events_url":"https://api.github.com/users/baijum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":950449756,"node_id":"MDU6TGFiZWw5NTA0NDk3NTY=","url":"https://api.github.com/repos/fabric8-services/fabric8-wit/labels/work-in-progress","name":"work-in-progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2111/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/b1dd453e00249348c14675602a8c6e8dde5669b9","head":{"label":"michaelkleinhenz:boardview","ref":"boardview","sha":"b1dd453e00249348c14675602a8c6e8dde5669b9","user":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"repo":{"id":131597385,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1OTczODU=","name":"fabric8-wit","full_name":"michaelkleinhenz/fabric8-wit","owner":{"login":"michaelkleinhenz","id":7101098,"node_id":"MDQ6VXNlcjcxMDEwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7101098?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkleinhenz","html_url":"https://github.com/michaelkleinhenz","followers_url":"https://api.github.com/users/michaelkleinhenz/followers","following_url":"https://api.github.com/users/michaelkleinhenz/following{/other_user}","gists_url":"https://api.github.com/users/michaelkleinhenz/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkleinhenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkleinhenz/subscriptions","organizations_url":"https://api.github.com/users/michaelkleinhenz/orgs","repos_url":"https://api.github.com/users/michaelkleinhenz/repos","events_url":"https://api.github.com/users/michaelkleinhenz/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkleinhenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelkleinhenz/fabric8-wit","description":null,"fork":true,"url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit","forks_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/forks","keys_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/events","assignees_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/merges","archive_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/michaelkleinhenz/fabric8-wit/deployments","created_at":"2018-04-30T13:11:46Z","updated_at":"2018-04-30T13:11:50Z","pushed_at":"2018-07-05T16:29:25Z","git_url":"git://github.com/michaelkleinhenz/fabric8-wit.git","ssh_url":"git@github.com:michaelkleinhenz/fabric8-wit.git","clone_url":"https://github.com/michaelkleinhenz/fabric8-wit.git","svn_url":"https://github.com/michaelkleinhenz/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":9034,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"88b4ed94f58e2455953ee4c452e07e12b4a087c2","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MDcwNg==","name":"fabric8-wit","full_name":"fabric8-services/fabric8-wit","owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-wit","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-wit","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2018-07-04T20:25:15Z","pushed_at":"2018-07-05T16:29:27Z","git_url":"git://github.com/fabric8-services/fabric8-wit.git","ssh_url":"git@github.com:fabric8-services/fabric8-wit.git","clone_url":"https://github.com/fabric8-services/fabric8-wit.git","svn_url":"https://github.com/fabric8-services/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":12824,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":78,"open_issues":181,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/2111"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2111"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/2111/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/2111/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/b1dd453e00249348c14675602a8c6e8dde5669b9"}},"author_association":"COLLABORATOR"}} | {
"id": 54260706,
"name": "fabric8-services/fabric8-wit",
"url": "https://api.github.com/repos/fabric8-services/fabric8-wit"
} | {
"id": 6303309,
"login": "DhritiShikhar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6303309?",
"url": "https://api.github.com/users/DhritiShikhar"
} | {
"id": 29751612,
"login": "fabric8-services",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29751612?",
"url": "https://api.github.com/orgs/fabric8-services"
} | 2018-07-06T09:51:27 | 7927962998 | {"actor":{"display_login":"DhritiShikhar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments/181079755","pull_request_review_id":111618961,"id":181079755,"diff_hunk":"@@ -0,0 +1,78 @@\n+from dataservice.extensions import db\n+from dataservice.api.common.model import Base, KfId\n+from dataservice.api.genomic_file.models import GenomicFile\n+\n+\n+class Biospecimen(db.Model, Base):\n+ \"\"\"\n+ Biospecimen entity.\n+ :param _id: Unique id assigned by RDBMS\n+ :param kf_id: Unique id given by the Kid's First DCC\n+ :param external_sample_id: Name given to sample by contributor\n+ :param external_aliquot_id: Name given to aliquot by contributor\n+ :param composition : The cellular composition of the biospecimen.\n+ :param tissue_type: description of the kind of tissue collected\n+ with respect to disease status or proximity to tumor tissue\n+ :param anatomical_site : The name of the primary disease site of the\n+ submitted tumor biospecimen\n+ :param age_at_event_days: Age at the time biospecimen was\n+ acquired, expressed in number of days since birth\n+ :param tumor_descriptor: The kind of disease present in the tumor\n+ specimen as related to a specific timepoint\n+ :param shipment_origin : The origin of the shipment\n+ :param shipment_destination: The destination of the shipment\n+ :param analyte_type: Text term that represents the kind of molecular\n+ specimen analyte\n+ :param concentration: The concentration of an analyte or aliquot extracted","path":"dataservice/api/biospecimen/models.py","position":25,"original_position":26,"commit_id":"a8bc2958d54ad183fc62abad0c6d650bd0c3b3f0","original_commit_id":"0a0bd4002a57def4f4497d693dd4cd5dcde88fcc","user":{"login":"dankolbman","id":2495894,"avatar_url":"https://avatars0.githubusercontent.com/u/2495894?v=4","gravatar_id":"","url":"https://api.github.com/users/dankolbman","html_url":"https://github.com/dankolbman","followers_url":"https://api.github.com/users/dankolbman/followers","following_url":"https://api.github.com/users/dankolbman/following{/other_user}","gists_url":"https://api.github.com/users/dankolbman/gists{/gist_id}","starred_url":"https://api.github.com/users/dankolbman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankolbman/subscriptions","organizations_url":"https://api.github.com/users/dankolbman/orgs","repos_url":"https://api.github.com/users/dankolbman/repos","events_url":"https://api.github.com/users/dankolbman/events{/privacy}","received_events_url":"https://api.github.com/users/dankolbman/received_events","type":"User","site_admin":false},"body":"Where else do we have units? Maybe we should fk units to another unit table to ensure we have a strict vocab?","created_at":"2018-04-12T13:26:38Z","updated_at":"2018-04-12T13:26:38Z","html_url":"https://github.com/kids-first/kf-api-dataservice/pull/228#discussion_r181079755","pull_request_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments/181079755"},"html":{"href":"https://github.com/kids-first/kf-api-dataservice/pull/228#discussion_r181079755"},"pull_request":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228"}},"in_reply_to_id":180871800},"pull_request":{"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228","id":180585122,"html_url":"https://github.com/kids-first/kf-api-dataservice/pull/228","diff_url":"https://github.com/kids-first/kf-api-dataservice/pull/228.diff","patch_url":"https://github.com/kids-first/kf-api-dataservice/pull/228.patch","issue_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/228","number":228,"state":"open","locked":false,"title":"✨Biospecimen model","user":{"login":"parimalak","id":20447220,"avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false},"body":"- [x] Update `concentration` field to float for aliquot(biospecimen) model\r\n- [x] Add `uberon_id`, `external_sample_id`, `external_aliquot_id` fields to sample(biospecimen)\r\n- [x] Merge sample and aliquot as biospecimen\r\n- [x] Link biospecimen to genomic_file\r\n- [x] Remove connection between aliquot(biospecimen) and sequencing_experiment and link sequencing_experiment to genomic_file \r\n- [ ] update genomic-file link in sequencing_experiment schema\r\n- [x] update erd and migrations\r\n- [x] update data generation script\r\n\r\nAddresses #202 ","created_at":"2018-04-10T12:27:18Z","updated_at":"2018-04-12T13:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94d2d32d873a42fa9dba09dcce842f8ab2492dbe","assignee":{"login":"parimalak","id":20447220,"avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false},"assignees":[{"login":"parimalak","id":20447220,"avatar_url":"https://avatars2.githubusercontent.com/u/20447220?v=4","gravatar_id":"","url":"https://api.github.com/users/parimalak","html_url":"https://github.com/parimalak","followers_url":"https://api.github.com/users/parimalak/followers","following_url":"https://api.github.com/users/parimalak/following{/other_user}","gists_url":"https://api.github.com/users/parimalak/gists{/gist_id}","starred_url":"https://api.github.com/users/parimalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parimalak/subscriptions","organizations_url":"https://api.github.com/users/parimalak/orgs","repos_url":"https://api.github.com/users/parimalak/repos","events_url":"https://api.github.com/users/parimalak/events{/privacy}","received_events_url":"https://api.github.com/users/parimalak/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":890251781,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels/Ready%20for%20review","name":"Ready for review","color":"0bd6ed","default":false},{"id":806490829,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels/data%20model","name":"data model","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228/commits","review_comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228/comments","review_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/228/comments","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/a8bc2958d54ad183fc62abad0c6d650bd0c3b3f0","head":{"label":"kids-first:biospecimen-model","ref":"biospecimen-model","sha":"a8bc2958d54ad183fc62abad0c6d650bd0c3b3f0","user":{"login":"kids-first","id":29782953,"avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"repo":{"id":116870795,"name":"kf-api-dataservice","full_name":"kids-first/kf-api-dataservice","owner":{"login":"kids-first","id":29782953,"avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kids-first/kf-api-dataservice","description":":file_cabinet: Primary API for interacting with the Kids First data","fork":false,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice","forks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/forks","keys_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/teams","hooks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/hooks","issue_events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/events{/number}","events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/events","assignees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/assignees{/user}","branches_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/branches{/branch}","tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/tags","blobs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/{sha}","languages_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/languages","stargazers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/stargazers","contributors_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contributors","subscribers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscribers","subscription_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscription","commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contents/{+path}","compare_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/merges","archive_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/downloads","issues_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues{/number}","pulls_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls{/number}","milestones_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/milestones{/number}","notifications_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels{/name}","releases_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/releases{/id}","deployments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/deployments","created_at":"2018-01-09T21:06:39Z","updated_at":"2018-04-06T19:55:25Z","pushed_at":"2018-04-12T12:59:18Z","git_url":"git://github.com/kids-first/kf-api-dataservice.git","ssh_url":"git@github.com:kids-first/kf-api-dataservice.git","clone_url":"https://github.com/kids-first/kf-api-dataservice.git","svn_url":"https://github.com/kids-first/kf-api-dataservice","homepage":"http://kf-api-dataservice-qa.kids-first.io","size":7417,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":44,"watchers":1,"default_branch":"master"}},"base":{"label":"kids-first:master","ref":"master","sha":"66dff01cce139e7057778f580f2cdd9bb0fc3b7d","user":{"login":"kids-first","id":29782953,"avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"repo":{"id":116870795,"name":"kf-api-dataservice","full_name":"kids-first/kf-api-dataservice","owner":{"login":"kids-first","id":29782953,"avatar_url":"https://avatars2.githubusercontent.com/u/29782953?v=4","gravatar_id":"","url":"https://api.github.com/users/kids-first","html_url":"https://github.com/kids-first","followers_url":"https://api.github.com/users/kids-first/followers","following_url":"https://api.github.com/users/kids-first/following{/other_user}","gists_url":"https://api.github.com/users/kids-first/gists{/gist_id}","starred_url":"https://api.github.com/users/kids-first/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kids-first/subscriptions","organizations_url":"https://api.github.com/users/kids-first/orgs","repos_url":"https://api.github.com/users/kids-first/repos","events_url":"https://api.github.com/users/kids-first/events{/privacy}","received_events_url":"https://api.github.com/users/kids-first/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kids-first/kf-api-dataservice","description":":file_cabinet: Primary API for interacting with the Kids First data","fork":false,"url":"https://api.github.com/repos/kids-first/kf-api-dataservice","forks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/forks","keys_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/teams","hooks_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/hooks","issue_events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/events{/number}","events_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/events","assignees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/assignees{/user}","branches_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/branches{/branch}","tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/tags","blobs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/{sha}","languages_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/languages","stargazers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/stargazers","contributors_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contributors","subscribers_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscribers","subscription_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/subscription","commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/contents/{+path}","compare_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/merges","archive_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/downloads","issues_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues{/number}","pulls_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls{/number}","milestones_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/milestones{/number}","notifications_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/labels{/name}","releases_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/releases{/id}","deployments_url":"https://api.github.com/repos/kids-first/kf-api-dataservice/deployments","created_at":"2018-01-09T21:06:39Z","updated_at":"2018-04-06T19:55:25Z","pushed_at":"2018-04-12T12:59:18Z","git_url":"git://github.com/kids-first/kf-api-dataservice.git","ssh_url":"git@github.com:kids-first/kf-api-dataservice.git","clone_url":"https://github.com/kids-first/kf-api-dataservice.git","svn_url":"https://github.com/kids-first/kf-api-dataservice","homepage":"http://kf-api-dataservice-qa.kids-first.io","size":7417,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":44,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228"},"html":{"href":"https://github.com/kids-first/kf-api-dataservice/pull/228"},"issue":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/228"},"comments":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/kids-first/kf-api-dataservice/statuses/a8bc2958d54ad183fc62abad0c6d650bd0c3b3f0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 116870795,
"name": "kids-first/kf-api-dataservice",
"url": "https://api.github.com/repos/kids-first/kf-api-dataservice"
} | {
"id": 2495894,
"login": "dankolbman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2495894?",
"url": "https://api.github.com/users/dankolbman"
} | {
"id": 29782953,
"login": "kids-first",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29782953?",
"url": "https://api.github.com/orgs/kids-first"
} | 2018-04-12T13:26:38 | 7520026345 | {"actor":{"display_login":"dankolbman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gitcoinco/web/pulls/comments/165434624","pull_request_review_id":93374070,"id":165434624,"diff_hunk":"@@ -336,6 +323,27 @@ def process_bounty_details(bountydetails, url, contract_address, network):\n for interested in last_bounty.interested.all():\n new_bounty.interested.add(interested)\n \n+ if fments:","path":"app/dashboard/helpers.py","position":90,"original_position":90,"commit_id":"3122fc7b5574b84a789eca1ebba011631b79582c","original_commit_id":"3122fc7b5574b84a789eca1ebba011631b79582c","user":{"login":"jasonrhaas","id":7018237,"avatar_url":"https://avatars1.githubusercontent.com/u/7018237?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhaas","html_url":"https://github.com/jasonrhaas","followers_url":"https://api.github.com/users/jasonrhaas/followers","following_url":"https://api.github.com/users/jasonrhaas/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhaas/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhaas/subscriptions","organizations_url":"https://api.github.com/users/jasonrhaas/orgs","repos_url":"https://api.github.com/users/jasonrhaas/repos","events_url":"https://api.github.com/users/jasonrhaas/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhaas/received_events","type":"User","site_admin":false},"body":"Agree that we could break it out more. The only thing is that I wanted to make sure that the fulfillments get created at the same time as the bounty because of the way that we do the `current_bounty`. Maybe there is a cleaner way to do it...","created_at":"2018-02-01T17:46:35Z","updated_at":"2018-02-01T17:46:35Z","html_url":"https://github.com/gitcoinco/web/pull/330#discussion_r165434624","pull_request_url":"https://api.github.com/repos/gitcoinco/web/pulls/330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/comments/165434624"},"html":{"href":"https://github.com/gitcoinco/web/pull/330#discussion_r165434624"},"pull_request":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/330"}},"in_reply_to_id":165431932},"pull_request":{"url":"https://api.github.com/repos/gitcoinco/web/pulls/330","id":166091034,"html_url":"https://github.com/gitcoinco/web/pull/330","diff_url":"https://github.com/gitcoinco/web/pull/330.diff","patch_url":"https://github.com/gitcoinco/web/pull/330.patch","issue_url":"https://api.github.com/repos/gitcoinco/web/issues/330","number":330,"state":"open","locked":false,"title":"Multiple fulfillments","user":{"login":"jasonrhaas","id":7018237,"avatar_url":"https://avatars1.githubusercontent.com/u/7018237?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrhaas","html_url":"https://github.com/jasonrhaas","followers_url":"https://api.github.com/users/jasonrhaas/followers","following_url":"https://api.github.com/users/jasonrhaas/following{/other_user}","gists_url":"https://api.github.com/users/jasonrhaas/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrhaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrhaas/subscriptions","organizations_url":"https://api.github.com/users/jasonrhaas/orgs","repos_url":"https://api.github.com/users/jasonrhaas/repos","events_url":"https://api.github.com/users/jasonrhaas/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrhaas/received_events","type":"User","site_admin":false},"body":"<!--\r\n Thank you for your pull request. Please provide a description above and review\r\n the requirements below.\r\n\r\n Contributors guide: https://github.com/gitcoinco/web/blob/contributing/CONTRIBUTING.md\r\n-->\r\n\r\n##### Description\r\nAdd support for multiple fulfillments on a given bounty.\r\n\r\n##### Checklist\r\n\r\n- [x] Updated back-end model by adding new fulfillments table\r\n- [x] Data also available in the `fulfillments` field as JSON in the bounty table\r\n- [x] Updated API. Fulfillments available as JSON in the `fulfillments`\r\n- [x] Bounty stays open even if work has been submitted.\r\n- [x] Update front end display, allow Bounty Owner to choose a fulfillment to accept.\r\n\r\n\r\n##### Affected core subsystem(s)\r\n- Database tables\r\n- API\r\n- Bounty Details page\r\n\r\n##### Refers/Fixes\r\n#308 \r\n","created_at":"2018-01-30T20:37:47Z","updated_at":"2018-02-01T17:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef4a4f13fa330ef19277e18e6412867e86eab5d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/gitcoinco/web/pulls/330/commits","review_comments_url":"https://api.github.com/repos/gitcoinco/web/pulls/330/comments","review_comment_url":"https://api.github.com/repos/gitcoinco/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitcoinco/web/issues/330/comments","statuses_url":"https://api.github.com/repos/gitcoinco/web/statuses/3122fc7b5574b84a789eca1ebba011631b79582c","head":{"label":"gitcoinco:multiple-fulfillments","ref":"multiple-fulfillments","sha":"3122fc7b5574b84a789eca1ebba011631b79582c","user":{"login":"gitcoinco","id":30044474,"avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"repo":{"id":96767206,"name":"web","full_name":"gitcoinco/web","owner":{"login":"gitcoinco","id":30044474,"avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitcoinco/web","description":"Push Open Source Forward.","fork":false,"url":"https://api.github.com/repos/gitcoinco/web","forks_url":"https://api.github.com/repos/gitcoinco/web/forks","keys_url":"https://api.github.com/repos/gitcoinco/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitcoinco/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitcoinco/web/teams","hooks_url":"https://api.github.com/repos/gitcoinco/web/hooks","issue_events_url":"https://api.github.com/repos/gitcoinco/web/issues/events{/number}","events_url":"https://api.github.com/repos/gitcoinco/web/events","assignees_url":"https://api.github.com/repos/gitcoinco/web/assignees{/user}","branches_url":"https://api.github.com/repos/gitcoinco/web/branches{/branch}","tags_url":"https://api.github.com/repos/gitcoinco/web/tags","blobs_url":"https://api.github.com/repos/gitcoinco/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitcoinco/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitcoinco/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitcoinco/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitcoinco/web/statuses/{sha}","languages_url":"https://api.github.com/repos/gitcoinco/web/languages","stargazers_url":"https://api.github.com/repos/gitcoinco/web/stargazers","contributors_url":"https://api.github.com/repos/gitcoinco/web/contributors","subscribers_url":"https://api.github.com/repos/gitcoinco/web/subscribers","subscription_url":"https://api.github.com/repos/gitcoinco/web/subscription","commits_url":"https://api.github.com/repos/gitcoinco/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitcoinco/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitcoinco/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitcoinco/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitcoinco/web/contents/{+path}","compare_url":"https://api.github.com/repos/gitcoinco/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitcoinco/web/merges","archive_url":"https://api.github.com/repos/gitcoinco/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitcoinco/web/downloads","issues_url":"https://api.github.com/repos/gitcoinco/web/issues{/number}","pulls_url":"https://api.github.com/repos/gitcoinco/web/pulls{/number}","milestones_url":"https://api.github.com/repos/gitcoinco/web/milestones{/number}","notifications_url":"https://api.github.com/repos/gitcoinco/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitcoinco/web/labels{/name}","releases_url":"https://api.github.com/repos/gitcoinco/web/releases{/id}","deployments_url":"https://api.github.com/repos/gitcoinco/web/deployments","created_at":"2017-07-10T10:53:45Z","updated_at":"2018-02-01T11:30:05Z","pushed_at":"2018-02-01T17:46:26Z","git_url":"git://github.com/gitcoinco/web.git","ssh_url":"git@github.com:gitcoinco/web.git","clone_url":"https://github.com/gitcoinco/web.git","svn_url":"https://github.com/gitcoinco/web","homepage":"https://gitcoin.co","size":142750,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":83,"open_issues":133,"watchers":134,"default_branch":"master"}},"base":{"label":"gitcoinco:master","ref":"master","sha":"82a1a1fc210322c8540e983a62e2d2a612864823","user":{"login":"gitcoinco","id":30044474,"avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"repo":{"id":96767206,"name":"web","full_name":"gitcoinco/web","owner":{"login":"gitcoinco","id":30044474,"avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitcoinco/web","description":"Push Open Source Forward.","fork":false,"url":"https://api.github.com/repos/gitcoinco/web","forks_url":"https://api.github.com/repos/gitcoinco/web/forks","keys_url":"https://api.github.com/repos/gitcoinco/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitcoinco/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitcoinco/web/teams","hooks_url":"https://api.github.com/repos/gitcoinco/web/hooks","issue_events_url":"https://api.github.com/repos/gitcoinco/web/issues/events{/number}","events_url":"https://api.github.com/repos/gitcoinco/web/events","assignees_url":"https://api.github.com/repos/gitcoinco/web/assignees{/user}","branches_url":"https://api.github.com/repos/gitcoinco/web/branches{/branch}","tags_url":"https://api.github.com/repos/gitcoinco/web/tags","blobs_url":"https://api.github.com/repos/gitcoinco/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitcoinco/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitcoinco/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitcoinco/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitcoinco/web/statuses/{sha}","languages_url":"https://api.github.com/repos/gitcoinco/web/languages","stargazers_url":"https://api.github.com/repos/gitcoinco/web/stargazers","contributors_url":"https://api.github.com/repos/gitcoinco/web/contributors","subscribers_url":"https://api.github.com/repos/gitcoinco/web/subscribers","subscription_url":"https://api.github.com/repos/gitcoinco/web/subscription","commits_url":"https://api.github.com/repos/gitcoinco/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitcoinco/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitcoinco/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitcoinco/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitcoinco/web/contents/{+path}","compare_url":"https://api.github.com/repos/gitcoinco/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitcoinco/web/merges","archive_url":"https://api.github.com/repos/gitcoinco/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitcoinco/web/downloads","issues_url":"https://api.github.com/repos/gitcoinco/web/issues{/number}","pulls_url":"https://api.github.com/repos/gitcoinco/web/pulls{/number}","milestones_url":"https://api.github.com/repos/gitcoinco/web/milestones{/number}","notifications_url":"https://api.github.com/repos/gitcoinco/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitcoinco/web/labels{/name}","releases_url":"https://api.github.com/repos/gitcoinco/web/releases{/id}","deployments_url":"https://api.github.com/repos/gitcoinco/web/deployments","created_at":"2017-07-10T10:53:45Z","updated_at":"2018-02-01T11:30:05Z","pushed_at":"2018-02-01T17:46:26Z","git_url":"git://github.com/gitcoinco/web.git","ssh_url":"git@github.com:gitcoinco/web.git","clone_url":"https://github.com/gitcoinco/web.git","svn_url":"https://github.com/gitcoinco/web","homepage":"https://gitcoin.co","size":142750,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":83,"open_issues":133,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/330"},"html":{"href":"https://github.com/gitcoinco/web/pull/330"},"issue":{"href":"https://api.github.com/repos/gitcoinco/web/issues/330"},"comments":{"href":"https://api.github.com/repos/gitcoinco/web/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/gitcoinco/web/statuses/3122fc7b5574b84a789eca1ebba011631b79582c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 96767206,
"name": "gitcoinco/web",
"url": "https://api.github.com/repos/gitcoinco/web"
} | {
"id": 7018237,
"login": "jasonrhaas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7018237?",
"url": "https://api.github.com/users/jasonrhaas"
} | {
"id": 30044474,
"login": "gitcoinco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30044474?",
"url": "https://api.github.com/orgs/gitcoinco"
} | 2018-02-01T17:46:35 | 7184922270 | {"actor":{"display_login":"jasonrhaas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gitcoinco/web/pulls/comments/204593405","pull_request_review_id":139699926,"id":204593405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU5MzQwNQ==","diff_hunk":"@@ -924,6 +927,282 @@ def save_search(request):\n return TemplateResponse(request, 'save_search.html', context)\n \n \n+def funder_dashboard(request):\n+ \"\"\" Render the funder dashboard\"\"\"\n+ funder_bounties = request.user.profile.get_funded_bounties()\n+\n+ # TODO: Remove, it's just for testing now\n+ funder_bounties = Bounty.objects.all()\n+\n+ active_done_expired_bounties = funder_bounties.filter_by_status(['active', 'done', 'expired'])\n+ active_bounties = active_done_expired_bounties.filter_by_status(['active'])\n+ done_bounties = active_done_expired_bounties.filter_by_status(['done'])\n+ expired_bounties = active_done_expired_bounties.filter_by_status(['expired'])\n+\n+ contributor1 = {\n+ \"githubLink\": \"https://github.com\",\n+ \"profilePictureSrc\": \"/static/avatar/NedelescuVlad\",\n+ }\n+\n+ # TODO: use done bounties to get the contributors\n+ top_contributors = [contributor1]\n+\n+ # TODO: Fill in payout history data for the line chart\n+ # Each one of these dictionaries is composed of 2 arrays that should have the same length.\n+ # Each data[i] labels[i] represents a X Y coordinate (plot point)\n+ payout_history_weekly = {\n+ \"data\": [50, 105, 405, 150, 200, 300, 80, 305],\n+ \"labels\": [1, 2, 3, 4, 5, 6, 7, 8]\n+ }\n+\n+ payout_history_monthly = {\n+ \"data\": [80, 305, 50, 105, 405, 150, 200, 300],\n+ \"labels\": [\"January\", \"February\", \"March\", \"April\", \"May\", \"June\", \"July\", \"August\"]\n+ }\n+\n+ payout_history_yearly = {\n+ \"data\": [50000, 70000, 90000, 30000],\n+ \"labels\": [2016, 2017, 2018, 30000]\n+ }\n+\n+ utc_now = datetime.datetime.now(timezone.utc)\n+ expiring_bounties = active_bounties.filter(expires_date__gte=utc_now, expires_date__lte=utc_now + timezone.timedelta(days=7))\n+\n+ # expiring at 7 days\n+ expiring_bounties_count = expiring_bounties.count()\n+ last_expiring_days_from_now = None\n+ for bounty in funder_bounties:\n+ delta_days = (bounty.expires_date - utc_now).days\n+ if last_expiring_days_from_now is None or delta_days > last_expiring_days_from_now:\n+ last_expiring_days_from_now = delta_days\n+\n+ expiring_days_count = last_expiring_days_from_now\n+\n+ # TODO: Count the new comments\n+ new_contributor_comments = 3\n+\n+ # EVER submitted / created\n+ submitted_bounties_count = funder_bounties.count()\n+\n+ # TODO: number of people who ever contributed\n+ total_contributors_count = 142","path":"app/dashboard/views.py","position":79,"original_position":79,"commit_id":"92ad6d7ef2c63632e4aac10d545c78390281f6c3","original_commit_id":"92ad6d7ef2c63632e4aac10d545c78390281f6c3","user":{"login":"owocki","id":513929,"node_id":"MDQ6VXNlcjUxMzkyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/513929?v=4","gravatar_id":"","url":"https://api.github.com/users/owocki","html_url":"https://github.com/owocki","followers_url":"https://api.github.com/users/owocki/followers","following_url":"https://api.github.com/users/owocki/following{/other_user}","gists_url":"https://api.github.com/users/owocki/gists{/gist_id}","starred_url":"https://api.github.com/users/owocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owocki/subscriptions","organizations_url":"https://api.github.com/users/owocki/orgs","repos_url":"https://api.github.com/users/owocki/repos","events_url":"https://api.github.com/users/owocki/events{/privacy}","received_events_url":"https://api.github.com/users/owocki/received_events","type":"User","site_admin":false},"body":"you can do this by summing up all the `current_bounty=True`s that belong to this user and counting all of the fulfillments that are accepted","created_at":"2018-07-24T00:33:03Z","updated_at":"2018-07-24T00:37:51Z","html_url":"https://github.com/gitcoinco/web/pull/1351#discussion_r204593405","pull_request_url":"https://api.github.com/repos/gitcoinco/web/pulls/1351","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/comments/204593405"},"html":{"href":"https://github.com/gitcoinco/web/pull/1351#discussion_r204593405"},"pull_request":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/1351"}}},"pull_request":{"url":"https://api.github.com/repos/gitcoinco/web/pulls/1351","id":192265097,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjY1MDk3","html_url":"https://github.com/gitcoinco/web/pull/1351","diff_url":"https://github.com/gitcoinco/web/pull/1351.diff","patch_url":"https://github.com/gitcoinco/web/pull/1351.patch","issue_url":"https://api.github.com/repos/gitcoinco/web/issues/1351","number":1351,"state":"open","locked":false,"title":"WIP: Feature/vlad/funder dashboard","user":{"login":"NedelescuVlad","id":14984176,"node_id":"MDQ6VXNlcjE0OTg0MTc2","avatar_url":"https://avatars1.githubusercontent.com/u/14984176?v=4","gravatar_id":"","url":"https://api.github.com/users/NedelescuVlad","html_url":"https://github.com/NedelescuVlad","followers_url":"https://api.github.com/users/NedelescuVlad/followers","following_url":"https://api.github.com/users/NedelescuVlad/following{/other_user}","gists_url":"https://api.github.com/users/NedelescuVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/NedelescuVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NedelescuVlad/subscriptions","organizations_url":"https://api.github.com/users/NedelescuVlad/orgs","repos_url":"https://api.github.com/users/NedelescuVlad/repos","events_url":"https://api.github.com/users/NedelescuVlad/events{/privacy}","received_events_url":"https://api.github.com/users/NedelescuVlad/received_events","type":"User","site_admin":false},"body":"<!--\r\n Thank you for your pull request. Please provide a description above and review\r\n the requirements below.\r\n\r\n Contributors guide: https://github.com/gitcoinco/web/blob/contributing/CONTRIBUTING.md\r\n-->\r\n\r\n##### Description\r\n<!-- A description on what this PR aims to solve -->\r\n\r\nWIP - Funder dashboard: https://github.com/gitcoinco/web/issues/1177. Currently have done the front-end with all dummy data. Current state of things is this: https://imgur.com/a/YWirKIn\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] linter status: 100% pass\r\n- [ ] changes don't break existing behavior\r\n- [ ] commit message follows [commit guidelines](https://github.com/gitcoinco/web/blob/master/docs/CONTRIBUTING.md#step-4-commit)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, ui, crypto, etc). -->\r\n\r\n##### Testing\r\n<!-- Why should the PR reviewer trust that this change doesn't break anything? How have you tested this change? -->\r\n\r\n##### Refers/Fixes\r\n<!--\r\n Link to an issue if applicable. For example:\r\n If your PR fixes an issue -> Fixes: #102\r\n If your PR refers an issue -> Refs: #101\r\n-->\r\n","created_at":"2018-06-03T20:12:34Z","updated_at":"2018-07-24T00:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49df6d99deaf595a4aa2499de9bf589cab7011ea","assignee":{"login":"owocki","id":513929,"node_id":"MDQ6VXNlcjUxMzkyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/513929?v=4","gravatar_id":"","url":"https://api.github.com/users/owocki","html_url":"https://github.com/owocki","followers_url":"https://api.github.com/users/owocki/followers","following_url":"https://api.github.com/users/owocki/following{/other_user}","gists_url":"https://api.github.com/users/owocki/gists{/gist_id}","starred_url":"https://api.github.com/users/owocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owocki/subscriptions","organizations_url":"https://api.github.com/users/owocki/orgs","repos_url":"https://api.github.com/users/owocki/repos","events_url":"https://api.github.com/users/owocki/events{/privacy}","received_events_url":"https://api.github.com/users/owocki/received_events","type":"User","site_admin":false},"assignees":[{"login":"owocki","id":513929,"node_id":"MDQ6VXNlcjUxMzkyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/513929?v=4","gravatar_id":"","url":"https://api.github.com/users/owocki","html_url":"https://github.com/owocki","followers_url":"https://api.github.com/users/owocki/followers","following_url":"https://api.github.com/users/owocki/following{/other_user}","gists_url":"https://api.github.com/users/owocki/gists{/gist_id}","starred_url":"https://api.github.com/users/owocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owocki/subscriptions","organizations_url":"https://api.github.com/users/owocki/orgs","repos_url":"https://api.github.com/users/owocki/repos","events_url":"https://api.github.com/users/owocki/events{/privacy}","received_events_url":"https://api.github.com/users/owocki/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820451824,"node_id":"MDU6TGFiZWw4MjA0NTE4MjQ=","url":"https://api.github.com/repos/gitcoinco/web/labels/in%20progress","name":"in progress","color":"4abc40","default":false},{"id":857985414,"node_id":"MDU6TGFiZWw4NTc5ODU0MTQ=","url":"https://api.github.com/repos/gitcoinco/web/labels/waiting%20on%20contributor","name":"waiting on contributor","color":"abb7ff","default":false},{"id":854182139,"node_id":"MDU6TGFiZWw4NTQxODIxMzk=","url":"https://api.github.com/repos/gitcoinco/web/labels/wip","name":"wip","color":"e2ba85","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gitcoinco/web/pulls/1351/commits","review_comments_url":"https://api.github.com/repos/gitcoinco/web/pulls/1351/comments","review_comment_url":"https://api.github.com/repos/gitcoinco/web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitcoinco/web/issues/1351/comments","statuses_url":"https://api.github.com/repos/gitcoinco/web/statuses/92ad6d7ef2c63632e4aac10d545c78390281f6c3","head":{"label":"NedelescuVlad:feature/vlad/funder-dashboard","ref":"feature/vlad/funder-dashboard","sha":"92ad6d7ef2c63632e4aac10d545c78390281f6c3","user":{"login":"NedelescuVlad","id":14984176,"node_id":"MDQ6VXNlcjE0OTg0MTc2","avatar_url":"https://avatars1.githubusercontent.com/u/14984176?v=4","gravatar_id":"","url":"https://api.github.com/users/NedelescuVlad","html_url":"https://github.com/NedelescuVlad","followers_url":"https://api.github.com/users/NedelescuVlad/followers","following_url":"https://api.github.com/users/NedelescuVlad/following{/other_user}","gists_url":"https://api.github.com/users/NedelescuVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/NedelescuVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NedelescuVlad/subscriptions","organizations_url":"https://api.github.com/users/NedelescuVlad/orgs","repos_url":"https://api.github.com/users/NedelescuVlad/repos","events_url":"https://api.github.com/users/NedelescuVlad/events{/privacy}","received_events_url":"https://api.github.com/users/NedelescuVlad/received_events","type":"User","site_admin":false},"repo":{"id":134938617,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ5Mzg2MTc=","name":"web","full_name":"NedelescuVlad/web","owner":{"login":"NedelescuVlad","id":14984176,"node_id":"MDQ6VXNlcjE0OTg0MTc2","avatar_url":"https://avatars1.githubusercontent.com/u/14984176?v=4","gravatar_id":"","url":"https://api.github.com/users/NedelescuVlad","html_url":"https://github.com/NedelescuVlad","followers_url":"https://api.github.com/users/NedelescuVlad/followers","following_url":"https://api.github.com/users/NedelescuVlad/following{/other_user}","gists_url":"https://api.github.com/users/NedelescuVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/NedelescuVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NedelescuVlad/subscriptions","organizations_url":"https://api.github.com/users/NedelescuVlad/orgs","repos_url":"https://api.github.com/users/NedelescuVlad/repos","events_url":"https://api.github.com/users/NedelescuVlad/events{/privacy}","received_events_url":"https://api.github.com/users/NedelescuVlad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NedelescuVlad/web","description":"Grow Open Source","fork":true,"url":"https://api.github.com/repos/NedelescuVlad/web","forks_url":"https://api.github.com/repos/NedelescuVlad/web/forks","keys_url":"https://api.github.com/repos/NedelescuVlad/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NedelescuVlad/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NedelescuVlad/web/teams","hooks_url":"https://api.github.com/repos/NedelescuVlad/web/hooks","issue_events_url":"https://api.github.com/repos/NedelescuVlad/web/issues/events{/number}","events_url":"https://api.github.com/repos/NedelescuVlad/web/events","assignees_url":"https://api.github.com/repos/NedelescuVlad/web/assignees{/user}","branches_url":"https://api.github.com/repos/NedelescuVlad/web/branches{/branch}","tags_url":"https://api.github.com/repos/NedelescuVlad/web/tags","blobs_url":"https://api.github.com/repos/NedelescuVlad/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NedelescuVlad/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NedelescuVlad/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/NedelescuVlad/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NedelescuVlad/web/statuses/{sha}","languages_url":"https://api.github.com/repos/NedelescuVlad/web/languages","stargazers_url":"https://api.github.com/repos/NedelescuVlad/web/stargazers","contributors_url":"https://api.github.com/repos/NedelescuVlad/web/contributors","subscribers_url":"https://api.github.com/repos/NedelescuVlad/web/subscribers","subscription_url":"https://api.github.com/repos/NedelescuVlad/web/subscription","commits_url":"https://api.github.com/repos/NedelescuVlad/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/NedelescuVlad/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/NedelescuVlad/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/NedelescuVlad/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/NedelescuVlad/web/contents/{+path}","compare_url":"https://api.github.com/repos/NedelescuVlad/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NedelescuVlad/web/merges","archive_url":"https://api.github.com/repos/NedelescuVlad/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NedelescuVlad/web/downloads","issues_url":"https://api.github.com/repos/NedelescuVlad/web/issues{/number}","pulls_url":"https://api.github.com/repos/NedelescuVlad/web/pulls{/number}","milestones_url":"https://api.github.com/repos/NedelescuVlad/web/milestones{/number}","notifications_url":"https://api.github.com/repos/NedelescuVlad/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NedelescuVlad/web/labels{/name}","releases_url":"https://api.github.com/repos/NedelescuVlad/web/releases{/id}","deployments_url":"https://api.github.com/repos/NedelescuVlad/web/deployments","created_at":"2018-05-26T07:16:44Z","updated_at":"2018-05-26T07:16:47Z","pushed_at":"2018-07-23T22:01:00Z","git_url":"git://github.com/NedelescuVlad/web.git","ssh_url":"git@github.com:NedelescuVlad/web.git","clone_url":"https://github.com/NedelescuVlad/web.git","svn_url":"https://github.com/NedelescuVlad/web","homepage":"https://gitcoin.co","size":253587,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitcoinco:master","ref":"master","sha":"a7baae3c99e11c26991f973b0232560d5ba91752","user":{"login":"gitcoinco","id":30044474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDQ0NDc0","avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"repo":{"id":96767206,"node_id":"MDEwOlJlcG9zaXRvcnk5Njc2NzIwNg==","name":"web","full_name":"gitcoinco/web","owner":{"login":"gitcoinco","id":30044474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMDQ0NDc0","avatar_url":"https://avatars1.githubusercontent.com/u/30044474?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinco","html_url":"https://github.com/gitcoinco","followers_url":"https://api.github.com/users/gitcoinco/followers","following_url":"https://api.github.com/users/gitcoinco/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinco/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinco/subscriptions","organizations_url":"https://api.github.com/users/gitcoinco/orgs","repos_url":"https://api.github.com/users/gitcoinco/repos","events_url":"https://api.github.com/users/gitcoinco/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitcoinco/web","description":"Grow Open Source","fork":false,"url":"https://api.github.com/repos/gitcoinco/web","forks_url":"https://api.github.com/repos/gitcoinco/web/forks","keys_url":"https://api.github.com/repos/gitcoinco/web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitcoinco/web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitcoinco/web/teams","hooks_url":"https://api.github.com/repos/gitcoinco/web/hooks","issue_events_url":"https://api.github.com/repos/gitcoinco/web/issues/events{/number}","events_url":"https://api.github.com/repos/gitcoinco/web/events","assignees_url":"https://api.github.com/repos/gitcoinco/web/assignees{/user}","branches_url":"https://api.github.com/repos/gitcoinco/web/branches{/branch}","tags_url":"https://api.github.com/repos/gitcoinco/web/tags","blobs_url":"https://api.github.com/repos/gitcoinco/web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitcoinco/web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitcoinco/web/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitcoinco/web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitcoinco/web/statuses/{sha}","languages_url":"https://api.github.com/repos/gitcoinco/web/languages","stargazers_url":"https://api.github.com/repos/gitcoinco/web/stargazers","contributors_url":"https://api.github.com/repos/gitcoinco/web/contributors","subscribers_url":"https://api.github.com/repos/gitcoinco/web/subscribers","subscription_url":"https://api.github.com/repos/gitcoinco/web/subscription","commits_url":"https://api.github.com/repos/gitcoinco/web/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitcoinco/web/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitcoinco/web/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitcoinco/web/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitcoinco/web/contents/{+path}","compare_url":"https://api.github.com/repos/gitcoinco/web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitcoinco/web/merges","archive_url":"https://api.github.com/repos/gitcoinco/web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitcoinco/web/downloads","issues_url":"https://api.github.com/repos/gitcoinco/web/issues{/number}","pulls_url":"https://api.github.com/repos/gitcoinco/web/pulls{/number}","milestones_url":"https://api.github.com/repos/gitcoinco/web/milestones{/number}","notifications_url":"https://api.github.com/repos/gitcoinco/web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitcoinco/web/labels{/name}","releases_url":"https://api.github.com/repos/gitcoinco/web/releases{/id}","deployments_url":"https://api.github.com/repos/gitcoinco/web/deployments","created_at":"2017-07-10T10:53:45Z","updated_at":"2018-07-24T00:17:38Z","pushed_at":"2018-07-24T00:17:32Z","git_url":"git://github.com/gitcoinco/web.git","ssh_url":"git@github.com:gitcoinco/web.git","clone_url":"https://github.com/gitcoinco/web.git","svn_url":"https://github.com/gitcoinco/web","homepage":"https://gitcoin.co","size":266587,"stargazers_count":360,"watchers_count":360,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":479,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":211,"open_issues":479,"watchers":360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/1351"},"html":{"href":"https://github.com/gitcoinco/web/pull/1351"},"issue":{"href":"https://api.github.com/repos/gitcoinco/web/issues/1351"},"comments":{"href":"https://api.github.com/repos/gitcoinco/web/issues/1351/comments"},"review_comments":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/1351/comments"},"review_comment":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitcoinco/web/pulls/1351/commits"},"statuses":{"href":"https://api.github.com/repos/gitcoinco/web/statuses/92ad6d7ef2c63632e4aac10d545c78390281f6c3"}},"author_association":"NONE"}} | {
"id": 96767206,
"name": "gitcoinco/web",
"url": "https://api.github.com/repos/gitcoinco/web"
} | {
"id": 513929,
"login": "owocki",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/513929?",
"url": "https://api.github.com/users/owocki"
} | {
"id": 30044474,
"login": "gitcoinco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30044474?",
"url": "https://api.github.com/orgs/gitcoinco"
} | 2018-07-24T00:33:03 | 8007151017 | {"actor":{"display_login":"owocki"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/181478581","pull_request_review_id":112119755,"id":181478581,"diff_hunk":"@@ -61,30 +61,103 @@ class LogRecordingSink : public Logger::SinkDelegate {\n std::vector<std::string> messages_;\n };\n \n-// Validates that when stmt is executed, exactly one log message containing substr will be emitted.\n-#define EXPECT_LOG_CONTAINS(loglevel, substr, stmt) \\\n+typedef std::vector<std::pair<std::string, std::string>> ExpectedLogMessages;\n+\n+// Validates that when stmt is executed, log messages containing substr and loglevel will be\n+// emitted. Failure message e.g.,\n+//\n+// Logs:\n+// [2018-04-12 05:51:00.245][7290192][debug][upstream] grpc_mux_impl.cc:160] Received gRPC\n+// [2018-04-12 05:51:00.246][7290192][warning][upstream] grpc_mux_impl.cc:63] Called bar\n+// [2018-04-12 05:51:00.246][7290192][trace][upstream] grpc_mux_impl.cc:80] Sending foo\n+// Does NOT contain:\n+// 'warning', 'Too many sendDiscoveryRequest calls for baz’\n+// 'warning', 'Too man sendDiscoveryRequest calls for foo'\n+#define EXPECT_LOG_CONTAINS_MANY(expected_messages, stmt) \\","path":"test/test_common/logging.h","position":36,"original_position":36,"commit_id":"3a4868e2fc9f7cb59e1614664ed8ec4757489c26","original_commit_id":"3a4868e2fc9f7cb59e1614664ed8ec4757489c26","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"body":"\"MANY\" seems ambiguous. From reading the impl, I suggest calling this EXPECT_LOG_CONTAINS_ALL_OF.\r\n\r\nAnd this is a nice abstraction as a test may not care about order or whether there are some extra logs beyond the expected ones.","created_at":"2018-04-13T18:47:47Z","updated_at":"2018-04-13T18:55:31Z","html_url":"https://github.com/envoyproxy/envoy/pull/2783#discussion_r181478581","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/181478581"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2783#discussion_r181478581"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783","id":174580191,"html_url":"https://github.com/envoyproxy/envoy/pull/2783","diff_url":"https://github.com/envoyproxy/envoy/pull/2783.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2783.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2783","number":2783,"state":"open","locked":false,"title":"xds_rate_limit: implemented xds rate-limit and alerts","user":{"login":"gsagula","id":587468,"avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"body":"*Description*: This PR implements a mechanism to detect when xDS update requests go over a pre-specified limit.\r\n\r\n*Issue*: https://github.com/envoyproxy/envoy/issues/2169\r\n\r\n*What it does*:\r\n- Detects when xDS update requests go over the limit.\r\n- Issues one log warn level when over the limit is detected.\r\n- Limits warnings to one log on every 5 seconds.\r\n\r\n*Risk Level*: Low\r\n\r\n*Testing*: unit test, manual testing.\r\n\r\nSigned-off-by: Gabriel <gsagula@gmail.com>\r\n","created_at":"2018-03-13T07:49:01Z","updated_at":"2018-04-13T18:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a969e87d7bc9389319978e225852ad28d3411f","assignee":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2783/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/3a4868e2fc9f7cb59e1614664ed8ec4757489c26","head":{"label":"gsagula:wip_xds_rate_limit","ref":"wip_xds_rate_limit","sha":"3a4868e2fc9f7cb59e1614664ed8ec4757489c26","user":{"login":"gsagula","id":587468,"avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"repo":{"id":97367677,"name":"envoy","full_name":"gsagula/envoy","owner":{"login":"gsagula","id":587468,"avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsagula/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/gsagula/envoy","forks_url":"https://api.github.com/repos/gsagula/envoy/forks","keys_url":"https://api.github.com/repos/gsagula/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsagula/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsagula/envoy/teams","hooks_url":"https://api.github.com/repos/gsagula/envoy/hooks","issue_events_url":"https://api.github.com/repos/gsagula/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/gsagula/envoy/events","assignees_url":"https://api.github.com/repos/gsagula/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/gsagula/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/gsagula/envoy/tags","blobs_url":"https://api.github.com/repos/gsagula/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsagula/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsagula/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsagula/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsagula/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/gsagula/envoy/languages","stargazers_url":"https://api.github.com/repos/gsagula/envoy/stargazers","contributors_url":"https://api.github.com/repos/gsagula/envoy/contributors","subscribers_url":"https://api.github.com/repos/gsagula/envoy/subscribers","subscription_url":"https://api.github.com/repos/gsagula/envoy/subscription","commits_url":"https://api.github.com/repos/gsagula/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsagula/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsagula/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsagula/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsagula/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/gsagula/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsagula/envoy/merges","archive_url":"https://api.github.com/repos/gsagula/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsagula/envoy/downloads","issues_url":"https://api.github.com/repos/gsagula/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/gsagula/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/gsagula/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/gsagula/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsagula/envoy/labels{/name}","releases_url":"https://api.github.com/repos/gsagula/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/gsagula/envoy/deployments","created_at":"2017-07-16T07:30:34Z","updated_at":"2018-04-11T06:42:32Z","pushed_at":"2018-04-12T06:59:15Z","git_url":"git://github.com/gsagula/envoy.git","ssh_url":"git@github.com:gsagula/envoy.git","clone_url":"https://github.com/gsagula/envoy.git","svn_url":"https://github.com/gsagula/envoy","homepage":"https://lyft.github.io/envoy","size":14256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"b2e54ba70979ce7b1fc9d0c06acc11576013f8f9","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-04-13T18:14:52Z","pushed_at":"2018-04-13T18:54:58Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":13932,"stargazers_count":4519,"watchers_count":4519,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":565,"mirror_url":null,"archived":false,"open_issues_count":299,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":565,"open_issues":299,"watchers":4519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2783"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2783"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2783/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2783/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/3a4868e2fc9f7cb59e1614664ed8ec4757489c26"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65214191,
"name": "envoyproxy/envoy",
"url": "https://api.github.com/repos/envoyproxy/envoy"
} | {
"id": 1942589,
"login": "jmarantz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1942589?",
"url": "https://api.github.com/users/jmarantz"
} | {
"id": 30125649,
"login": "envoyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30125649?",
"url": "https://api.github.com/orgs/envoyproxy"
} | 2018-04-13T18:47:47 | 7527957284 | {"actor":{"display_login":"jmarantz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/198943304","pull_request_review_id":132968159,"id":198943304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODk0MzMwNA==","diff_hunk":"@@ -55,6 +56,7 @@ class SslSocket : public Network::TransportSocket,\n std::vector<std::string> getDnsSansFromCertificate(X509* cert);\n \n Network::TransportSocketCallbacks* callbacks_{};\n+ ContextSharedPtr ctx_owner_;","path":"source/common/ssl/ssl_socket.h","position":21,"original_position":21,"commit_id":"0dbc3ad5374088f75d99bb98a8d03209072e28fb","original_commit_id":"0dbc3ad5374088f75d99bb98a8d03209072e28fb","user":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"As I mentioned above, I try to remove this member variable ctx_. ","created_at":"2018-06-28T18:34:39Z","updated_at":"2018-06-28T18:34:40Z","html_url":"https://github.com/envoyproxy/envoy/pull/3748#discussion_r198943304","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/198943304"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3748#discussion_r198943304"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748"}},"in_reply_to_id":198938036},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748","id":197897571,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODk3NTcx","html_url":"https://github.com/envoyproxy/envoy/pull/3748","diff_url":"https://github.com/envoyproxy/envoy/pull/3748.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3748.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3748","number":3748,"state":"open","locked":false,"title":"High level design PR: Add SDS dynamic secret","user":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Wayne Zhang <qiwzhang@google.com>\r\n\r\nThis PR is not a real PR, it is a high level design proposal to support fetching dynamic secrets.\r\n\r\nMain changes:\r\n1) added SecretCallback interface to notify secret has been changed\r\n2) added DynamicSecretProvider interface to fetch dynamic secret.\r\n3) secretManager to hold static and dynamic secret separately.\r\n4) use shared_ptr for Context objects so an new object can be created while old one is in-use.\r\n\r\nCode Status: \r\nPassed compiling for files under /source/.... \r\n\r\n","created_at":"2018-06-28T01:59:27Z","updated_at":"2018-06-28T18:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"437e9117340ad297b5338630b0db22a7f9fbb74f","assignee":{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},"assignees":[{"login":"PiotrSikora","id":190297,"node_id":"MDQ6VXNlcjE5MDI5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/190297?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrSikora","html_url":"https://github.com/PiotrSikora","followers_url":"https://api.github.com/users/PiotrSikora/followers","following_url":"https://api.github.com/users/PiotrSikora/following{/other_user}","gists_url":"https://api.github.com/users/PiotrSikora/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrSikora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrSikora/subscriptions","organizations_url":"https://api.github.com/users/PiotrSikora/orgs","repos_url":"https://api.github.com/users/PiotrSikora/repos","events_url":"https://api.github.com/users/PiotrSikora/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrSikora/received_events","type":"User","site_admin":false},{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3748/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/0dbc3ad5374088f75d99bb98a8d03209072e28fb","head":{"label":"qiwzhang:sds_b3_1","ref":"sds_b3_1","sha":"0dbc3ad5374088f75d99bb98a8d03209072e28fb","user":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"repo":{"id":80474148,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQ3NDE0OA==","name":"envoy","full_name":"qiwzhang/envoy","owner":{"login":"qiwzhang","id":11790727,"node_id":"MDQ6VXNlcjExNzkwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qiwzhang/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/qiwzhang/envoy","forks_url":"https://api.github.com/repos/qiwzhang/envoy/forks","keys_url":"https://api.github.com/repos/qiwzhang/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiwzhang/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiwzhang/envoy/teams","hooks_url":"https://api.github.com/repos/qiwzhang/envoy/hooks","issue_events_url":"https://api.github.com/repos/qiwzhang/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/qiwzhang/envoy/events","assignees_url":"https://api.github.com/repos/qiwzhang/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/qiwzhang/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/qiwzhang/envoy/tags","blobs_url":"https://api.github.com/repos/qiwzhang/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiwzhang/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiwzhang/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiwzhang/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiwzhang/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/qiwzhang/envoy/languages","stargazers_url":"https://api.github.com/repos/qiwzhang/envoy/stargazers","contributors_url":"https://api.github.com/repos/qiwzhang/envoy/contributors","subscribers_url":"https://api.github.com/repos/qiwzhang/envoy/subscribers","subscription_url":"https://api.github.com/repos/qiwzhang/envoy/subscription","commits_url":"https://api.github.com/repos/qiwzhang/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiwzhang/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiwzhang/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiwzhang/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiwzhang/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/qiwzhang/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiwzhang/envoy/merges","archive_url":"https://api.github.com/repos/qiwzhang/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiwzhang/envoy/downloads","issues_url":"https://api.github.com/repos/qiwzhang/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/qiwzhang/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/qiwzhang/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/qiwzhang/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiwzhang/envoy/labels{/name}","releases_url":"https://api.github.com/repos/qiwzhang/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/qiwzhang/envoy/deployments","created_at":"2017-01-30T23:25:24Z","updated_at":"2017-01-30T23:25:27Z","pushed_at":"2018-06-28T01:52:54Z","git_url":"git://github.com/qiwzhang/envoy.git","ssh_url":"git@github.com:qiwzhang/envoy.git","clone_url":"https://github.com/qiwzhang/envoy.git","svn_url":"https://github.com/qiwzhang/envoy","homepage":"https://lyft.github.io/envoy","size":21688,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"299591bdcf43a51d2b7ef92ce004343a4bfc620f","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-06-28T16:42:12Z","pushed_at":"2018-06-28T17:59:13Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":17086,"stargazers_count":5408,"watchers_count":5408,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":691,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":691,"open_issues":322,"watchers":5408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3748"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3748"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3748/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3748/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/0dbc3ad5374088f75d99bb98a8d03209072e28fb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 65214191,
"name": "envoyproxy/envoy",
"url": "https://api.github.com/repos/envoyproxy/envoy"
} | {
"id": 11790727,
"login": "qiwzhang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11790727?",
"url": "https://api.github.com/users/qiwzhang"
} | {
"id": 30125649,
"login": "envoyproxy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30125649?",
"url": "https://api.github.com/orgs/envoyproxy"
} | 2018-06-28T18:34:39 | 7893593114 | {"actor":{"display_login":"qiwzhang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ironmussa/Optimus/pulls/comments/208815474","pull_request_review_id":144701356,"id":208815474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODgxNTQ3NA==","diff_hunk":"@@ -1,123 +1,151 @@\n-# Importing DataFrameTransformer library\n-from optimus.df_transformer import DataFrameTransformer\n-# Importing DataFrameAnalyzer library\n-from optimus.df_analyzer import DataFrameAnalyzer\n-from pyspark.sql.dataframe import DataFrame\n+import os\n+from shutil import rmtree\n \n+from optimus.create import Create\n+from optimus.functions import concat\n+from optimus.helpers.constants import *\n+from optimus.helpers.raiseit import RaiseIfNot\n+from optimus.io.load import Load\n+from optimus.spark import Spark\n \n-class Optimus:\n- \"\"\"\n- This class can be considered as a wrapper of DataFrameTransformer and DataFrameAnalyzer classes.\n- \"\"\"\n-\n- def __init__(self, df, path_file, pu=1):\n- \"\"\"Constructor.\n- In this method DataFrameTransformer and DataFrameAnalyzer classes are\n- instantiated.\n- \"\"\"\n- # Path file:\n- self._path_file = path_file\n-\n- # Pu file:\n- self._pu = pu\n+from optimus.dataframe import rows, columns, extension","path":"optimus/optimus.py","position":31,"original_position":31,"commit_id":"2d55bf1f10d2b74ff5931e3e22c8002bb3933985","original_commit_id":"2d55bf1f10d2b74ff5931e3e22c8002bb3933985","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Unused rows imported from optimus.dataframe](https://app.codacy.com/app/favio.vazquezp/Optimus/pullRequest?prid=2013067)","created_at":"2018-08-09T06:11:09Z","updated_at":"2018-08-09T06:11:09Z","html_url":"https://github.com/ironmussa/Optimus/pull/290#discussion_r208815474","pull_request_url":"https://api.github.com/repos/ironmussa/Optimus/pulls/290","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/comments/208815474"},"html":{"href":"https://github.com/ironmussa/Optimus/pull/290#discussion_r208815474"},"pull_request":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/ironmussa/Optimus/pulls/290","id":206880005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODgwMDA1","html_url":"https://github.com/ironmussa/Optimus/pull/290","diff_url":"https://github.com/ironmussa/Optimus/pull/290.diff","patch_url":"https://github.com/ironmussa/Optimus/pull/290.patch","issue_url":"https://api.github.com/repos/ironmussa/Optimus/issues/290","number":290,"state":"open","locked":false,"title":"Optimus version 2 official","user":{"login":"FavioVazquez","id":10162068,"node_id":"MDQ6VXNlcjEwMTYyMDY4","avatar_url":"https://avatars2.githubusercontent.com/u/10162068?v=4","gravatar_id":"","url":"https://api.github.com/users/FavioVazquez","html_url":"https://github.com/FavioVazquez","followers_url":"https://api.github.com/users/FavioVazquez/followers","following_url":"https://api.github.com/users/FavioVazquez/following{/other_user}","gists_url":"https://api.github.com/users/FavioVazquez/gists{/gist_id}","starred_url":"https://api.github.com/users/FavioVazquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FavioVazquez/subscriptions","organizations_url":"https://api.github.com/users/FavioVazquez/orgs","repos_url":"https://api.github.com/users/FavioVazquez/repos","events_url":"https://api.github.com/users/FavioVazquez/events{/privacy}","received_events_url":"https://api.github.com/users/FavioVazquez/received_events","type":"User","site_admin":false},"body":"@argenisleon working on this and me :)","created_at":"2018-08-08T03:03:03Z","updated_at":"2018-08-09T06:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"003d6628f3a616ee9d79173b18de4928f4699be0","assignee":{"login":"FavioVazquez","id":10162068,"node_id":"MDQ6VXNlcjEwMTYyMDY4","avatar_url":"https://avatars2.githubusercontent.com/u/10162068?v=4","gravatar_id":"","url":"https://api.github.com/users/FavioVazquez","html_url":"https://github.com/FavioVazquez","followers_url":"https://api.github.com/users/FavioVazquez/followers","following_url":"https://api.github.com/users/FavioVazquez/following{/other_user}","gists_url":"https://api.github.com/users/FavioVazquez/gists{/gist_id}","starred_url":"https://api.github.com/users/FavioVazquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FavioVazquez/subscriptions","organizations_url":"https://api.github.com/users/FavioVazquez/orgs","repos_url":"https://api.github.com/users/FavioVazquez/repos","events_url":"https://api.github.com/users/FavioVazquez/events{/privacy}","received_events_url":"https://api.github.com/users/FavioVazquez/received_events","type":"User","site_admin":false},"assignees":[{"login":"FavioVazquez","id":10162068,"node_id":"MDQ6VXNlcjEwMTYyMDY4","avatar_url":"https://avatars2.githubusercontent.com/u/10162068?v=4","gravatar_id":"","url":"https://api.github.com/users/FavioVazquez","html_url":"https://github.com/FavioVazquez","followers_url":"https://api.github.com/users/FavioVazquez/followers","following_url":"https://api.github.com/users/FavioVazquez/following{/other_user}","gists_url":"https://api.github.com/users/FavioVazquez/gists{/gist_id}","starred_url":"https://api.github.com/users/FavioVazquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FavioVazquez/subscriptions","organizations_url":"https://api.github.com/users/FavioVazquez/orgs","repos_url":"https://api.github.com/users/FavioVazquez/repos","events_url":"https://api.github.com/users/FavioVazquez/events{/privacy}","received_events_url":"https://api.github.com/users/FavioVazquez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":645896927,"node_id":"MDU6TGFiZWw2NDU4OTY5Mjc=","url":"https://api.github.com/repos/ironmussa/Optimus/labels/bug","name":"bug","color":"ee0701","default":true},{"id":647151202,"node_id":"MDU6TGFiZWw2NDcxNTEyMDI=","url":"https://api.github.com/repos/ironmussa/Optimus/labels/documentation","name":"documentation","color":"0052cc","default":false},{"id":645896929,"node_id":"MDU6TGFiZWw2NDU4OTY5Mjk=","url":"https://api.github.com/repos/ironmussa/Optimus/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":721871911,"node_id":"MDU6TGFiZWw3MjE4NzE5MTE=","url":"https://api.github.com/repos/ironmussa/Optimus/labels/testing","name":"testing","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ironmussa/Optimus/pulls/290/commits","review_comments_url":"https://api.github.com/repos/ironmussa/Optimus/pulls/290/comments","review_comment_url":"https://api.github.com/repos/ironmussa/Optimus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironmussa/Optimus/issues/290/comments","statuses_url":"https://api.github.com/repos/ironmussa/Optimus/statuses/2d55bf1f10d2b74ff5931e3e22c8002bb3933985","head":{"label":"ironmussa:new_interface","ref":"new_interface","sha":"2d55bf1f10d2b74ff5931e3e22c8002bb3933985","user":{"login":"ironmussa","id":30134402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTM0NDAy","avatar_url":"https://avatars2.githubusercontent.com/u/30134402?v=4","gravatar_id":"","url":"https://api.github.com/users/ironmussa","html_url":"https://github.com/ironmussa","followers_url":"https://api.github.com/users/ironmussa/followers","following_url":"https://api.github.com/users/ironmussa/following{/other_user}","gists_url":"https://api.github.com/users/ironmussa/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmussa/subscriptions","organizations_url":"https://api.github.com/users/ironmussa/orgs","repos_url":"https://api.github.com/users/ironmussa/repos","events_url":"https://api.github.com/users/ironmussa/events{/privacy}","received_events_url":"https://api.github.com/users/ironmussa/received_events","type":"Organization","site_admin":false},"repo":{"id":97071697,"node_id":"MDEwOlJlcG9zaXRvcnk5NzA3MTY5Nw==","name":"Optimus","full_name":"ironmussa/Optimus","owner":{"login":"ironmussa","id":30134402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTM0NDAy","avatar_url":"https://avatars2.githubusercontent.com/u/30134402?v=4","gravatar_id":"","url":"https://api.github.com/users/ironmussa","html_url":"https://github.com/ironmussa","followers_url":"https://api.github.com/users/ironmussa/followers","following_url":"https://api.github.com/users/ironmussa/following{/other_user}","gists_url":"https://api.github.com/users/ironmussa/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmussa/subscriptions","organizations_url":"https://api.github.com/users/ironmussa/orgs","repos_url":"https://api.github.com/users/ironmussa/repos","events_url":"https://api.github.com/users/ironmussa/events{/privacy}","received_events_url":"https://api.github.com/users/ironmussa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironmussa/Optimus","description":":rocket: Optimus is the missing framework for cleansing (cleaning and much more), pre-processing and exploratory data analysis in a distributed fashion with Apache Spark.","fork":false,"url":"https://api.github.com/repos/ironmussa/Optimus","forks_url":"https://api.github.com/repos/ironmussa/Optimus/forks","keys_url":"https://api.github.com/repos/ironmussa/Optimus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironmussa/Optimus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironmussa/Optimus/teams","hooks_url":"https://api.github.com/repos/ironmussa/Optimus/hooks","issue_events_url":"https://api.github.com/repos/ironmussa/Optimus/issues/events{/number}","events_url":"https://api.github.com/repos/ironmussa/Optimus/events","assignees_url":"https://api.github.com/repos/ironmussa/Optimus/assignees{/user}","branches_url":"https://api.github.com/repos/ironmussa/Optimus/branches{/branch}","tags_url":"https://api.github.com/repos/ironmussa/Optimus/tags","blobs_url":"https://api.github.com/repos/ironmussa/Optimus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironmussa/Optimus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironmussa/Optimus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironmussa/Optimus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironmussa/Optimus/statuses/{sha}","languages_url":"https://api.github.com/repos/ironmussa/Optimus/languages","stargazers_url":"https://api.github.com/repos/ironmussa/Optimus/stargazers","contributors_url":"https://api.github.com/repos/ironmussa/Optimus/contributors","subscribers_url":"https://api.github.com/repos/ironmussa/Optimus/subscribers","subscription_url":"https://api.github.com/repos/ironmussa/Optimus/subscription","commits_url":"https://api.github.com/repos/ironmussa/Optimus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironmussa/Optimus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironmussa/Optimus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironmussa/Optimus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironmussa/Optimus/contents/{+path}","compare_url":"https://api.github.com/repos/ironmussa/Optimus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironmussa/Optimus/merges","archive_url":"https://api.github.com/repos/ironmussa/Optimus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironmussa/Optimus/downloads","issues_url":"https://api.github.com/repos/ironmussa/Optimus/issues{/number}","pulls_url":"https://api.github.com/repos/ironmussa/Optimus/pulls{/number}","milestones_url":"https://api.github.com/repos/ironmussa/Optimus/milestones{/number}","notifications_url":"https://api.github.com/repos/ironmussa/Optimus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironmussa/Optimus/labels{/name}","releases_url":"https://api.github.com/repos/ironmussa/Optimus/releases{/id}","deployments_url":"https://api.github.com/repos/ironmussa/Optimus/deployments","created_at":"2017-07-13T02:31:18Z","updated_at":"2018-08-08T07:11:48Z","pushed_at":"2018-08-09T06:08:13Z","git_url":"git://github.com/ironmussa/Optimus.git","ssh_url":"git@github.com:ironmussa/Optimus.git","clone_url":"https://github.com/ironmussa/Optimus.git","svn_url":"https://github.com/ironmussa/Optimus","homepage":"https://hioptimus.com","size":4275,"stargazers_count":285,"watchers_count":285,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":10,"watchers":285,"default_branch":"master"}},"base":{"label":"ironmussa:master","ref":"master","sha":"25cb1c00193c45fa864820b0aa0fb77cd76a4842","user":{"login":"ironmussa","id":30134402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTM0NDAy","avatar_url":"https://avatars2.githubusercontent.com/u/30134402?v=4","gravatar_id":"","url":"https://api.github.com/users/ironmussa","html_url":"https://github.com/ironmussa","followers_url":"https://api.github.com/users/ironmussa/followers","following_url":"https://api.github.com/users/ironmussa/following{/other_user}","gists_url":"https://api.github.com/users/ironmussa/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmussa/subscriptions","organizations_url":"https://api.github.com/users/ironmussa/orgs","repos_url":"https://api.github.com/users/ironmussa/repos","events_url":"https://api.github.com/users/ironmussa/events{/privacy}","received_events_url":"https://api.github.com/users/ironmussa/received_events","type":"Organization","site_admin":false},"repo":{"id":97071697,"node_id":"MDEwOlJlcG9zaXRvcnk5NzA3MTY5Nw==","name":"Optimus","full_name":"ironmussa/Optimus","owner":{"login":"ironmussa","id":30134402,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTM0NDAy","avatar_url":"https://avatars2.githubusercontent.com/u/30134402?v=4","gravatar_id":"","url":"https://api.github.com/users/ironmussa","html_url":"https://github.com/ironmussa","followers_url":"https://api.github.com/users/ironmussa/followers","following_url":"https://api.github.com/users/ironmussa/following{/other_user}","gists_url":"https://api.github.com/users/ironmussa/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmussa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmussa/subscriptions","organizations_url":"https://api.github.com/users/ironmussa/orgs","repos_url":"https://api.github.com/users/ironmussa/repos","events_url":"https://api.github.com/users/ironmussa/events{/privacy}","received_events_url":"https://api.github.com/users/ironmussa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironmussa/Optimus","description":":rocket: Optimus is the missing framework for cleansing (cleaning and much more), pre-processing and exploratory data analysis in a distributed fashion with Apache Spark.","fork":false,"url":"https://api.github.com/repos/ironmussa/Optimus","forks_url":"https://api.github.com/repos/ironmussa/Optimus/forks","keys_url":"https://api.github.com/repos/ironmussa/Optimus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironmussa/Optimus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironmussa/Optimus/teams","hooks_url":"https://api.github.com/repos/ironmussa/Optimus/hooks","issue_events_url":"https://api.github.com/repos/ironmussa/Optimus/issues/events{/number}","events_url":"https://api.github.com/repos/ironmussa/Optimus/events","assignees_url":"https://api.github.com/repos/ironmussa/Optimus/assignees{/user}","branches_url":"https://api.github.com/repos/ironmussa/Optimus/branches{/branch}","tags_url":"https://api.github.com/repos/ironmussa/Optimus/tags","blobs_url":"https://api.github.com/repos/ironmussa/Optimus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironmussa/Optimus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironmussa/Optimus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironmussa/Optimus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironmussa/Optimus/statuses/{sha}","languages_url":"https://api.github.com/repos/ironmussa/Optimus/languages","stargazers_url":"https://api.github.com/repos/ironmussa/Optimus/stargazers","contributors_url":"https://api.github.com/repos/ironmussa/Optimus/contributors","subscribers_url":"https://api.github.com/repos/ironmussa/Optimus/subscribers","subscription_url":"https://api.github.com/repos/ironmussa/Optimus/subscription","commits_url":"https://api.github.com/repos/ironmussa/Optimus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironmussa/Optimus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironmussa/Optimus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironmussa/Optimus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironmussa/Optimus/contents/{+path}","compare_url":"https://api.github.com/repos/ironmussa/Optimus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironmussa/Optimus/merges","archive_url":"https://api.github.com/repos/ironmussa/Optimus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironmussa/Optimus/downloads","issues_url":"https://api.github.com/repos/ironmussa/Optimus/issues{/number}","pulls_url":"https://api.github.com/repos/ironmussa/Optimus/pulls{/number}","milestones_url":"https://api.github.com/repos/ironmussa/Optimus/milestones{/number}","notifications_url":"https://api.github.com/repos/ironmussa/Optimus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironmussa/Optimus/labels{/name}","releases_url":"https://api.github.com/repos/ironmussa/Optimus/releases{/id}","deployments_url":"https://api.github.com/repos/ironmussa/Optimus/deployments","created_at":"2017-07-13T02:31:18Z","updated_at":"2018-08-08T07:11:48Z","pushed_at":"2018-08-09T06:08:13Z","git_url":"git://github.com/ironmussa/Optimus.git","ssh_url":"git@github.com:ironmussa/Optimus.git","clone_url":"https://github.com/ironmussa/Optimus.git","svn_url":"https://github.com/ironmussa/Optimus","homepage":"https://hioptimus.com","size":4275,"stargazers_count":285,"watchers_count":285,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":10,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/290"},"html":{"href":"https://github.com/ironmussa/Optimus/pull/290"},"issue":{"href":"https://api.github.com/repos/ironmussa/Optimus/issues/290"},"comments":{"href":"https://api.github.com/repos/ironmussa/Optimus/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironmussa/Optimus/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/ironmussa/Optimus/statuses/2d55bf1f10d2b74ff5931e3e22c8002bb3933985"}},"author_association":"MEMBER"}} | {
"id": 97071697,
"name": "ironmussa/Optimus",
"url": "https://api.github.com/repos/ironmussa/Optimus"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 30134402,
"login": "ironmussa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30134402?",
"url": "https://api.github.com/orgs/ironmussa"
} | 2018-08-09T06:11:09 | 8088115860 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/comments/238045812","pull_request_review_id":180504142,"id":238045812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA0NTgxMg==","diff_hunk":"@@ -0,0 +1,99 @@\n+package edu.mit.csail.sdg.ast;\n+\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.List;\n+\n+import edu.mit.csail.sdg.alloy4.ConstList;\n+import edu.mit.csail.sdg.alloy4.Err;\n+import edu.mit.csail.sdg.alloy4.ErrorWarning;\n+import edu.mit.csail.sdg.alloy4.Pos;\n+\n+public class Bounds extends Expr {\n+\n+ /** The label for this sig; this name does not need to be unique. */\n+ public final String label;\n+\n+ public final ArrayList<CommandScope> scope;\n+ \n+ public final ArrayList<ExprVar> funcs;\n+ \n+ public final Expr fact;\n+ \n+ public Bounds(String label){\n+ super(Pos.UNKNOWN, null);\n+ this.label = label;\n+ scope = new ArrayList<CommandScope>();\n+ funcs = new ArrayList<ExprVar>();\n+ fact = null;\n+\n+ \n+ }\n+\n+ public Bounds(Pos pos, String label, List<CommandScope> list){\n+ super( Pos.UNKNOWN,Type.FORMULA);\n+ this.label = label;\n+ this.scope = new ArrayList<CommandScope>(list);\n+ funcs = new ArrayList<ExprVar>();\n+ fact = null;\n+ }\n+\n+ public Bounds(Pos pos, String label, List<CommandScope> list, Expr fact){\n+ super( Pos.UNKNOWN,Type.FORMULA);\n+ this.label = label;\n+ this.scope = new ArrayList<CommandScope>(list);\n+ funcs = new ArrayList<ExprVar>();\n+ this.fact = fact;\n+ }\n+\n+ ","path":"org.alloytools.alloy.core/src/main/java/edu/mit/csail/sdg/ast/Bounds.java","position":null,"original_position":49,"commit_id":"e88fbefd2591ed76f2230338d3d514a26acbef91","original_commit_id":"89541ce6faf9180c5c858b3fc2d270271a5e3186","user":{"login":"vmontagh","id":6729172,"node_id":"MDQ6VXNlcjY3MjkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6729172?v=4","gravatar_id":"","url":"https://api.github.com/users/vmontagh","html_url":"https://github.com/vmontagh","followers_url":"https://api.github.com/users/vmontagh/followers","following_url":"https://api.github.com/users/vmontagh/following{/other_user}","gists_url":"https://api.github.com/users/vmontagh/gists{/gist_id}","starred_url":"https://api.github.com/users/vmontagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmontagh/subscriptions","organizations_url":"https://api.github.com/users/vmontagh/orgs","repos_url":"https://api.github.com/users/vmontagh/repos","events_url":"https://api.github.com/users/vmontagh/events{/privacy}","received_events_url":"https://api.github.com/users/vmontagh/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-12-01T01:30:14Z","updated_at":"2018-12-01T01:30:14Z","html_url":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76#discussion_r238045812","pull_request_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/comments/238045812"},"html":{"href":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76#discussion_r238045812"},"pull_request":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76"}},"in_reply_to_id":237352751},"pull_request":{"url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76","id":231731649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzMxNjQ5","html_url":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76","diff_url":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76.diff","patch_url":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76.patch","issue_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/76","number":76,"state":"open","locked":false,"title":"Adding partial instance","user":{"login":"vmontagh","id":6729172,"node_id":"MDQ6VXNlcjY3MjkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6729172?v=4","gravatar_id":"","url":"https://api.github.com/users/vmontagh","html_url":"https://github.com/vmontagh","followers_url":"https://api.github.com/users/vmontagh/followers","following_url":"https://api.github.com/users/vmontagh/following{/other_user}","gists_url":"https://api.github.com/users/vmontagh/gists{/gist_id}","starred_url":"https://api.github.com/users/vmontagh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmontagh/subscriptions","organizations_url":"https://api.github.com/users/vmontagh/orgs","repos_url":"https://api.github.com/users/vmontagh/repos","events_url":"https://api.github.com/users/vmontagh/events{/privacy}","received_events_url":"https://api.github.com/users/vmontagh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-17T14:45:52Z","updated_at":"2018-12-01T01:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd7ca13f4806b37821b05dd3c5a4b82300adcff4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76/commits","review_comments_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76/comments","review_comment_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/76/comments","statuses_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/statuses/e88fbefd2591ed76f2230338d3d514a26acbef91","head":{"label":"drayside:uw/partial-instance","ref":"uw/partial-instance","sha":"e88fbefd2591ed76f2230338d3d514a26acbef91","user":{"login":"drayside","id":3977769,"node_id":"MDQ6VXNlcjM5Nzc3Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/3977769?v=4","gravatar_id":"","url":"https://api.github.com/users/drayside","html_url":"https://github.com/drayside","followers_url":"https://api.github.com/users/drayside/followers","following_url":"https://api.github.com/users/drayside/following{/other_user}","gists_url":"https://api.github.com/users/drayside/gists{/gist_id}","starred_url":"https://api.github.com/users/drayside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drayside/subscriptions","organizations_url":"https://api.github.com/users/drayside/orgs","repos_url":"https://api.github.com/users/drayside/repos","events_url":"https://api.github.com/users/drayside/events{/privacy}","received_events_url":"https://api.github.com/users/drayside/received_events","type":"User","site_admin":false},"repo":{"id":156710193,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3MTAxOTM=","name":"org.alloytools.alloy","full_name":"drayside/org.alloytools.alloy","private":false,"owner":{"login":"drayside","id":3977769,"node_id":"MDQ6VXNlcjM5Nzc3Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/3977769?v=4","gravatar_id":"","url":"https://api.github.com/users/drayside","html_url":"https://github.com/drayside","followers_url":"https://api.github.com/users/drayside/followers","following_url":"https://api.github.com/users/drayside/following{/other_user}","gists_url":"https://api.github.com/users/drayside/gists{/gist_id}","starred_url":"https://api.github.com/users/drayside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drayside/subscriptions","organizations_url":"https://api.github.com/users/drayside/orgs","repos_url":"https://api.github.com/users/drayside/repos","events_url":"https://api.github.com/users/drayside/events{/privacy}","received_events_url":"https://api.github.com/users/drayside/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drayside/org.alloytools.alloy","description":"Alloy is a language for describing structures and a tool for exploring them. It has been used in a wide range of applications from finding holes in security mechanisms to designing telephone switching networks. This repository contains the code for the tool.","fork":true,"url":"https://api.github.com/repos/drayside/org.alloytools.alloy","forks_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/forks","keys_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/teams","hooks_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/hooks","issue_events_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/issues/events{/number}","events_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/events","assignees_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/assignees{/user}","branches_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/branches{/branch}","tags_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/tags","blobs_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/git/refs{/sha}","trees_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/statuses/{sha}","languages_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/languages","stargazers_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/stargazers","contributors_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/contributors","subscribers_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/subscribers","subscription_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/subscription","commits_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/commits{/sha}","git_commits_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/git/commits{/sha}","comments_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/comments{/number}","issue_comment_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/issues/comments{/number}","contents_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/contents/{+path}","compare_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/merges","archive_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/downloads","issues_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/issues{/number}","pulls_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/pulls{/number}","milestones_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/milestones{/number}","notifications_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/labels{/name}","releases_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/releases{/id}","deployments_url":"https://api.github.com/repos/drayside/org.alloytools.alloy/deployments","created_at":"2018-11-08T13:20:47Z","updated_at":"2018-11-08T13:20:53Z","pushed_at":"2018-12-01T01:17:27Z","git_url":"git://github.com/drayside/org.alloytools.alloy.git","ssh_url":"git@github.com:drayside/org.alloytools.alloy.git","clone_url":"https://github.com/drayside/org.alloytools.alloy.git","svn_url":"https://github.com/drayside/org.alloytools.alloy","homepage":null,"size":19799,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AlloyTools:master","ref":"master","sha":"30b41ae8125f69657f118167f34dc1d675ed31db","user":{"login":"AlloyTools","id":30268214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY4MjE0","avatar_url":"https://avatars2.githubusercontent.com/u/30268214?v=4","gravatar_id":"","url":"https://api.github.com/users/AlloyTools","html_url":"https://github.com/AlloyTools","followers_url":"https://api.github.com/users/AlloyTools/followers","following_url":"https://api.github.com/users/AlloyTools/following{/other_user}","gists_url":"https://api.github.com/users/AlloyTools/gists{/gist_id}","starred_url":"https://api.github.com/users/AlloyTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlloyTools/subscriptions","organizations_url":"https://api.github.com/users/AlloyTools/orgs","repos_url":"https://api.github.com/users/AlloyTools/repos","events_url":"https://api.github.com/users/AlloyTools/events{/privacy}","received_events_url":"https://api.github.com/users/AlloyTools/received_events","type":"Organization","site_admin":false},"repo":{"id":97738923,"node_id":"MDEwOlJlcG9zaXRvcnk5NzczODkyMw==","name":"org.alloytools.alloy","full_name":"AlloyTools/org.alloytools.alloy","private":false,"owner":{"login":"AlloyTools","id":30268214,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY4MjE0","avatar_url":"https://avatars2.githubusercontent.com/u/30268214?v=4","gravatar_id":"","url":"https://api.github.com/users/AlloyTools","html_url":"https://github.com/AlloyTools","followers_url":"https://api.github.com/users/AlloyTools/followers","following_url":"https://api.github.com/users/AlloyTools/following{/other_user}","gists_url":"https://api.github.com/users/AlloyTools/gists{/gist_id}","starred_url":"https://api.github.com/users/AlloyTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlloyTools/subscriptions","organizations_url":"https://api.github.com/users/AlloyTools/orgs","repos_url":"https://api.github.com/users/AlloyTools/repos","events_url":"https://api.github.com/users/AlloyTools/events{/privacy}","received_events_url":"https://api.github.com/users/AlloyTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AlloyTools/org.alloytools.alloy","description":"Alloy is a language for describing structures and a tool for exploring them. It has been used in a wide range of applications from finding holes in security mechanisms to designing telephone switching networks. This repository contains the code for the tool.","fork":false,"url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy","forks_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/forks","keys_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/teams","hooks_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/hooks","issue_events_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/events{/number}","events_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/events","assignees_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/assignees{/user}","branches_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/branches{/branch}","tags_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/tags","blobs_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/statuses/{sha}","languages_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/languages","stargazers_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/stargazers","contributors_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/contributors","subscribers_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/subscribers","subscription_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/subscription","commits_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/contents/{+path}","compare_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/merges","archive_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/downloads","issues_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues{/number}","pulls_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls{/number}","milestones_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/milestones{/number}","notifications_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/labels{/name}","releases_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/releases{/id}","deployments_url":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/deployments","created_at":"2017-07-19T16:33:02Z","updated_at":"2018-11-29T01:52:56Z","pushed_at":"2018-12-01T01:17:29Z","git_url":"git://github.com/AlloyTools/org.alloytools.alloy.git","ssh_url":"git@github.com:AlloyTools/org.alloytools.alloy.git","clone_url":"https://github.com/AlloyTools/org.alloytools.alloy.git","svn_url":"https://github.com/AlloyTools/org.alloytools.alloy","homepage":null,"size":19734,"stargazers_count":82,"watchers_count":82,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":28,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76"},"html":{"href":"https://github.com/AlloyTools/org.alloytools.alloy/pull/76"},"issue":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/76"},"comments":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/AlloyTools/org.alloytools.alloy/statuses/e88fbefd2591ed76f2230338d3d514a26acbef91"}},"author_association":"NONE"}} | {
"id": 97738923,
"name": "AlloyTools/org.alloytools.alloy",
"url": "https://api.github.com/repos/AlloyTools/org.alloytools.alloy"
} | {
"id": 6729172,
"login": "vmontagh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6729172?",
"url": "https://api.github.com/users/vmontagh"
} | {
"id": 30268214,
"login": "AlloyTools",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30268214?",
"url": "https://api.github.com/orgs/AlloyTools"
} | 2018-12-01T01:30:14 | 8679681104 | {"actor":{"display_login":"vmontagh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fnproject/fn/pulls/comments/217722279","pull_request_review_id":155507453,"id":217722279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcyMjI3OQ==","diff_hunk":"@@ -108,202 +87,3 @@ func getErrorResponse(t *testing.T, rec *httptest.ResponseRecorder) *models.Erro\n \t}\n \treturn &err\n }\n-\n-func prepareDB(ctx context.Context, t *testing.T) (models.Datastore, models.LogStore, func()) {\n-\tos.Remove(tmpDatastoreTests)\n-\turi, err := url.Parse(\"sqlite3://\" + tmpDatastoreTests)\n-\tif err != nil {\n-\t\tt.Fatal(err)\n-\t}\n-\tss, err := sql.New(ctx, uri)\n-\tif err != nil {\n-\t\tt.Fatalf(\"Error when creating datastore: %s\", err)\n-\t}\n-\tlogDB := logs.Wrap(ss)\n-\tds := datastore.Wrap(ss)\n-\n-\treturn ds, logDB, func() {\n-\t\tos.Remove(tmpDatastoreTests)\n-\t}\n-}\n-\n-func TestFullStack(t *testing.T) {\n-\tctx := context.Background()\n-\tbuf := setLogBuffer()\n-\tds, logDB, close := prepareDB(ctx, t)\n-\tdefer close()\n-\n-\trnr, rnrcancel := testRunner(t, ds)\n-\tdefer rnrcancel()\n-\n-\tsrv := testServer(ds, &mqs.Mock{}, logDB, rnr, ServerTypeFull, LimitRequestBody(32256))\n-\n-\tvar bigbufa [32257]byte\n-\trand.Read(bigbufa[:])\n-\tbigbuf := base64.StdEncoding.EncodeToString(bigbufa[:]) // this will be > bigbufa, but json compatible\n-\ttoobigerr := errors.New(\"Content-Length too large for this server\")\n-\tgatewayerr := errors.New(\"container exit code\")\n-\n-\tfor _, test := range []struct {\n-\t\tname string\n-\t\tmethod string\n-\t\tpath string\n-\t\tbody string\n-\t\texpectedCode int\n-\t\texpectedCacheSize int // TODO kill me\n-\t\texpectedError error\n-\t}{\n-\t\t{\"create my app\", \"POST\", \"/v1/apps\", `{ \"app\": { \"name\": \"myapp\" } }`, http.StatusOK, 0, nil},\n-\t\t{\"list apps\", \"GET\", \"/v1/apps\", ``, http.StatusOK, 0, nil},\n-\t\t{\"get app\", \"GET\", \"/v1/apps/myapp\", ``, http.StatusOK, 0, nil},\n-\t\t// NOTE: cache is lazy, loads when a request comes in for the route, not when added\n-\t\t{\"add myroute\", \"POST\", \"/v1/apps/myapp/routes\", `{ \"route\": { \"name\": \"myroute\", \"path\": \"/myroute\", \"image\": \"fnproject/fn-test-utils\", \"type\": \"sync\" } }`, http.StatusOK, 0, nil},\n-\t\t{\"add myroute2\", \"POST\", \"/v1/apps/myapp/routes\", `{ \"route\": { \"name\": \"myroute2\", \"path\": \"/myroute2\", \"image\": \"fnproject/fn-test-utils\", \"type\": \"sync\" } }`, http.StatusOK, 0, nil},\n-\t\t{\"get myroute\", \"GET\", \"/v1/apps/myapp/routes/myroute\", ``, http.StatusOK, 0, nil},\n-\t\t{\"get myroute2\", \"GET\", \"/v1/apps/myapp/routes/myroute2\", ``, http.StatusOK, 0, nil},\n-\t\t{\"get all routes\", \"GET\", \"/v1/apps/myapp/routes\", ``, http.StatusOK, 0, nil},\n-\t\t{\"execute myroute\", \"POST\", \"/r/myapp/myroute\", `{ \"echoContent\": \"Teste\" }`, http.StatusOK, 1, nil},\n-\n-\t\t// fails\n-\t\t{\"execute myroute2\", \"POST\", \"/r/myapp/myroute2\", `{\"sleepTime\": 0, \"isDebug\": true, \"isCrash\": true}`, http.StatusBadGateway, 2, gatewayerr},\n-\t\t{\"request body too large\", \"POST\", \"/r/myapp/myroute\", bigbuf, http.StatusRequestEntityTooLarge, 0, toobigerr},\n-\n-\t\t{\"get myroute2\", \"GET\", \"/v1/apps/myapp/routes/myroute2\", ``, http.StatusOK, 2, nil},\n-\t\t{\"delete myroute\", \"DELETE\", \"/v1/apps/myapp/routes/myroute\", ``, http.StatusOK, 1, nil},\n-\t\t{\"delete myroute2\", \"DELETE\", \"/v1/apps/myapp/routes/myroute2\", ``, http.StatusOK, 0, nil},\n-\t\t{\"delete app (success)\", \"DELETE\", \"/v1/apps/myapp\", ``, http.StatusOK, 0, nil},\n-\n-\t\t{\"get deleted app\", \"GET\", \"/v1/apps/myapp\", ``, http.StatusNotFound, 0, models.ErrAppsNotFound},\n-\t\t{\"get deleteds route on deleted app\", \"GET\", \"/v1/apps/myapp/routes/myroute\", ``, http.StatusNotFound, 0, models.ErrAppsNotFound},\n-\t} {\n-\t\tt.Run(test.name, func(t *testing.T) {\n-\t\t\t_, rec := routerRequest(t, srv.Router, test.method, test.path, bytes.NewBuffer([]byte(test.body)))\n-\n-\t\t\tif rec.Code != test.expectedCode {\n-\t\t\t\tt.Log(buf.String())\n-\t\t\t\tt.Log(rec.Body.String())\n-\t\t\t\tt.Errorf(\"Test \\\"%s\\\": Expected status code to be %d but was %d\",\n-\t\t\t\t\ttest.name, test.expectedCode, rec.Code)\n-\t\t\t}\n-\n-\t\t\tif rec.Code > 300 && test.expectedError == nil {\n-\t\t\t\tt.Log(buf.String())\n-\t\t\t\tt.Error(\"got error when not expected error\", rec.Body.String())\n-\t\t\t} else if test.expectedError != nil {\n-\t\t\t\tif !strings.Contains(rec.Body.String(), test.expectedError.Error()) {\n-\t\t\t\t\tt.Log(buf.String())\n-\t\t\t\t\tt.Errorf(\"Test %s: Expected error message to have `%s`, but got `%s`\",\n-\t\t\t\t\t\ttest.name, test.expectedError.Error(), rec.Body.String())\n-\t\t\t\t}\n-\t\t\t}\n-\t\t})\n-\t}\n-}\n-\n-func TestRunnerNode(t *testing.T) {\n-\tctx := context.Background()\n-\tbuf := setLogBuffer()\n-\tds, logDB, close := prepareDB(ctx, t)\n-\tdefer close()\n-\n-\trnr, rnrcancel := testRunner(t, ds)\n-\tdefer rnrcancel()\n-\n-\t// Add route with an API server using the same DB\n-\t{\n-\t\tapiServer := testServer(ds, &mqs.Mock{}, logDB, nil, ServerTypeAPI)\n-\t\t_, rec := routerRequest(t, apiServer.Router, \"POST\", \"/v1/apps/myapp/routes\", bytes.NewBuffer([]byte(`{ \"route\": { \"name\": \"myroute\", \"path\": \"/myroute\", \"image\": \"fnproject/fn-test-utils\", \"type\": \"sync\" } }`)))\n-\t\tif rec.Code != http.StatusOK {\n-\t\t\tt.Errorf(\"Expected status code 200 when creating sync route, but got %d\", rec.Code)\n-\t\t}\n-\t\t_, rec = routerRequest(t, apiServer.Router, \"POST\", \"/v1/apps/myapp/routes\", bytes.NewBuffer([]byte(`{ \"route\": { \"name\": \"myasyncroute\", \"path\": \"/myasyncroute\", \"image\": \"fnproject/fn-test-utils\", \"type\": \"async\" } }`)))\n-\t\tif rec.Code != http.StatusOK {\n-\t\t\tt.Errorf(\"Expected status code 200 when creating async route, but got %d\", rec.Code)\n-\t\t}\n-\t}\n-\n-\tsrv := testServer(ds, &mqs.Mock{}, logDB, rnr, ServerTypeRunner)\n-\n-\tfor _, test := range []struct {\n-\t\tname string\n-\t\tmethod string\n-\t\tpath string\n-\t\tbody string\n-\t\texpectedCode int\n-\t\texpectedCacheSize int // TODO kill me\n-\t}{\n-\t\t// Support sync and async API calls\n-\t\t{\"execute sync route succeeds\", \"POST\", \"/r/myapp/myroute\", `{ \"echoContent\": \"Teste\" }`, http.StatusOK, 1},\n-\t\t{\"execute async route succeeds\", \"POST\", \"/r/myapp/myasyncroute\", `{ \"echoContent\": \"Teste\" }`, http.StatusAccepted, 1},\n-\n-\t\t// All other API functions should not be available on runner nodes\n-\t\t{\"create app not found\", \"POST\", \"/v1/apps\", `{ \"app\": { \"name\": \"myapp\" } }`, http.StatusBadRequest, 0},\n-\t\t{\"list apps not found\", \"GET\", \"/v1/apps\", ``, http.StatusBadRequest, 0},\n-\t\t{\"get app not found\", \"GET\", \"/v1/apps/myapp\", ``, http.StatusBadRequest, 0},\n-\n-\t\t{\"add route not found\", \"POST\", \"/v1/apps/myapp/routes\", `{ \"route\": { \"name\": \"myroute\", \"path\": \"/myroute\", \"image\": \"fnproject/fn-test-utils\", \"type\": \"sync\" } }`, http.StatusBadRequest, 0},\n-\t\t{\"get route not found\", \"GET\", \"/v1/apps/myapp/routes/myroute\", ``, http.StatusBadRequest, 0},\n-\t\t{\"get all routes not found\", \"GET\", \"/v1/apps/myapp/routes\", ``, http.StatusBadRequest, 0},\n-\t\t{\"delete app not found\", \"DELETE\", \"/v1/apps/myapp\", ``, http.StatusBadRequest, 0},\n-\t} {\n-\t\tt.Run(test.name, func(t *testing.T) {\n-\t\t\t_, rec := routerRequest(t, srv.Router, test.method, test.path, bytes.NewBuffer([]byte(test.body)))\n-\n-\t\t\tif rec.Code != test.expectedCode {\n-\t\t\t\tt.Log(buf.String())\n-\t\t\t\tt.Errorf(\"Test \\\"%s\\\": Expected status code to be %d but was %d\",\n-\t\t\t\t\ttest.name, test.expectedCode, rec.Code)\n-\t\t\t}\n-\t\t})\n-\n-\t}\n-}\n-\n-func TestApiNode(t *testing.T) {","path":"api/server/server_test.go","position":204,"original_position":204,"commit_id":"ff9deae94b68e731ce04c668c9097ef595c22555","original_commit_id":"77514d570fa027eb0c475b78f60861878038ae09","user":{"login":"mantree","id":422106,"node_id":"MDQ6VXNlcjQyMjEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/422106?v=4","gravatar_id":"","url":"https://api.github.com/users/mantree","html_url":"https://github.com/mantree","followers_url":"https://api.github.com/users/mantree/followers","following_url":"https://api.github.com/users/mantree/following{/other_user}","gists_url":"https://api.github.com/users/mantree/gists{/gist_id}","starred_url":"https://api.github.com/users/mantree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantree/subscriptions","organizations_url":"https://api.github.com/users/mantree/orgs","repos_url":"https://api.github.com/users/mantree/repos","events_url":"https://api.github.com/users/mantree/events{/privacy}","received_events_url":"https://api.github.com/users/mantree/received_events","type":"User","site_admin":false},"body":"Yes. When you remove the route stuff this test is just a repeat of the app tests","created_at":"2018-09-14T13:58:53Z","updated_at":"2018-09-14T13:58:53Z","html_url":"https://github.com/fnproject/fn/pull/1210#discussion_r217722279","pull_request_url":"https://api.github.com/repos/fnproject/fn/pulls/1210","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fnproject/fn/pulls/comments/217722279"},"html":{"href":"https://github.com/fnproject/fn/pull/1210#discussion_r217722279"},"pull_request":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1210"}},"in_reply_to_id":217680727},"pull_request":{"url":"https://api.github.com/repos/fnproject/fn/pulls/1210","id":215315909,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzE1OTA5","html_url":"https://github.com/fnproject/fn/pull/1210","diff_url":"https://github.com/fnproject/fn/pull/1210.diff","patch_url":"https://github.com/fnproject/fn/pull/1210.patch","issue_url":"https://api.github.com/repos/fnproject/fn/issues/1210","number":1210,"state":"open","locked":false,"title":"Remove V1 endpoints and Routes","user":{"login":"mantree","id":422106,"node_id":"MDQ6VXNlcjQyMjEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/422106?v=4","gravatar_id":"","url":"https://api.github.com/users/mantree","html_url":"https://github.com/mantree","followers_url":"https://api.github.com/users/mantree/followers","following_url":"https://api.github.com/users/mantree/following{/other_user}","gists_url":"https://api.github.com/users/mantree/gists{/gist_id}","starred_url":"https://api.github.com/users/mantree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantree/subscriptions","organizations_url":"https://api.github.com/users/mantree/orgs","repos_url":"https://api.github.com/users/mantree/repos","events_url":"https://api.github.com/users/mantree/events{/privacy}","received_events_url":"https://api.github.com/users/mantree/received_events","type":"User","site_admin":false},"body":"Largely a removal job, however many tests, particularly system level\r\nones relied on Routes. These have been migrated to use Fns.\r\n","created_at":"2018-09-13T15:06:19Z","updated_at":"2018-09-14T13:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"856ed09491166aa6c07202e68738af6fcac38d3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fnproject/fn/pulls/1210/commits","review_comments_url":"https://api.github.com/repos/fnproject/fn/pulls/1210/comments","review_comment_url":"https://api.github.com/repos/fnproject/fn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fnproject/fn/issues/1210/comments","statuses_url":"https://api.github.com/repos/fnproject/fn/statuses/ff9deae94b68e731ce04c668c9097ef595c22555","head":{"label":"fnproject:feature/removev1endpoints","ref":"feature/removev1endpoints","sha":"ff9deae94b68e731ce04c668c9097ef595c22555","user":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"repo":{"id":97652025,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY1MjAyNQ==","name":"fn","full_name":"fnproject/fn","owner":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fnproject/fn","description":"The container native, cloud agnostic serverless platform.","fork":false,"url":"https://api.github.com/repos/fnproject/fn","forks_url":"https://api.github.com/repos/fnproject/fn/forks","keys_url":"https://api.github.com/repos/fnproject/fn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnproject/fn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnproject/fn/teams","hooks_url":"https://api.github.com/repos/fnproject/fn/hooks","issue_events_url":"https://api.github.com/repos/fnproject/fn/issues/events{/number}","events_url":"https://api.github.com/repos/fnproject/fn/events","assignees_url":"https://api.github.com/repos/fnproject/fn/assignees{/user}","branches_url":"https://api.github.com/repos/fnproject/fn/branches{/branch}","tags_url":"https://api.github.com/repos/fnproject/fn/tags","blobs_url":"https://api.github.com/repos/fnproject/fn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnproject/fn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnproject/fn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnproject/fn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnproject/fn/statuses/{sha}","languages_url":"https://api.github.com/repos/fnproject/fn/languages","stargazers_url":"https://api.github.com/repos/fnproject/fn/stargazers","contributors_url":"https://api.github.com/repos/fnproject/fn/contributors","subscribers_url":"https://api.github.com/repos/fnproject/fn/subscribers","subscription_url":"https://api.github.com/repos/fnproject/fn/subscription","commits_url":"https://api.github.com/repos/fnproject/fn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnproject/fn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnproject/fn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnproject/fn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnproject/fn/contents/{+path}","compare_url":"https://api.github.com/repos/fnproject/fn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnproject/fn/merges","archive_url":"https://api.github.com/repos/fnproject/fn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnproject/fn/downloads","issues_url":"https://api.github.com/repos/fnproject/fn/issues{/number}","pulls_url":"https://api.github.com/repos/fnproject/fn/pulls{/number}","milestones_url":"https://api.github.com/repos/fnproject/fn/milestones{/number}","notifications_url":"https://api.github.com/repos/fnproject/fn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnproject/fn/labels{/name}","releases_url":"https://api.github.com/repos/fnproject/fn/releases{/id}","deployments_url":"https://api.github.com/repos/fnproject/fn/deployments","created_at":"2017-07-18T23:22:46Z","updated_at":"2018-09-14T11:08:23Z","pushed_at":"2018-09-14T13:56:16Z","git_url":"git://github.com/fnproject/fn.git","ssh_url":"git@github.com:fnproject/fn.git","clone_url":"https://github.com/fnproject/fn.git","svn_url":"https://github.com/fnproject/fn","homepage":"http://fnproject.io","size":165011,"stargazers_count":3316,"watchers_count":3316,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":235,"open_issues":114,"watchers":3316,"default_branch":"master"}},"base":{"label":"fnproject:master","ref":"master","sha":"250853cb8a5d2db2e0e6de3acb74c7a61e1c2bf4","user":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"repo":{"id":97652025,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY1MjAyNQ==","name":"fn","full_name":"fnproject/fn","owner":{"login":"fnproject","id":30273834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjczODM0","avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fnproject/fn","description":"The container native, cloud agnostic serverless platform.","fork":false,"url":"https://api.github.com/repos/fnproject/fn","forks_url":"https://api.github.com/repos/fnproject/fn/forks","keys_url":"https://api.github.com/repos/fnproject/fn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnproject/fn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnproject/fn/teams","hooks_url":"https://api.github.com/repos/fnproject/fn/hooks","issue_events_url":"https://api.github.com/repos/fnproject/fn/issues/events{/number}","events_url":"https://api.github.com/repos/fnproject/fn/events","assignees_url":"https://api.github.com/repos/fnproject/fn/assignees{/user}","branches_url":"https://api.github.com/repos/fnproject/fn/branches{/branch}","tags_url":"https://api.github.com/repos/fnproject/fn/tags","blobs_url":"https://api.github.com/repos/fnproject/fn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnproject/fn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnproject/fn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnproject/fn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnproject/fn/statuses/{sha}","languages_url":"https://api.github.com/repos/fnproject/fn/languages","stargazers_url":"https://api.github.com/repos/fnproject/fn/stargazers","contributors_url":"https://api.github.com/repos/fnproject/fn/contributors","subscribers_url":"https://api.github.com/repos/fnproject/fn/subscribers","subscription_url":"https://api.github.com/repos/fnproject/fn/subscription","commits_url":"https://api.github.com/repos/fnproject/fn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnproject/fn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnproject/fn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnproject/fn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnproject/fn/contents/{+path}","compare_url":"https://api.github.com/repos/fnproject/fn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnproject/fn/merges","archive_url":"https://api.github.com/repos/fnproject/fn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnproject/fn/downloads","issues_url":"https://api.github.com/repos/fnproject/fn/issues{/number}","pulls_url":"https://api.github.com/repos/fnproject/fn/pulls{/number}","milestones_url":"https://api.github.com/repos/fnproject/fn/milestones{/number}","notifications_url":"https://api.github.com/repos/fnproject/fn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnproject/fn/labels{/name}","releases_url":"https://api.github.com/repos/fnproject/fn/releases{/id}","deployments_url":"https://api.github.com/repos/fnproject/fn/deployments","created_at":"2017-07-18T23:22:46Z","updated_at":"2018-09-14T11:08:23Z","pushed_at":"2018-09-14T13:56:16Z","git_url":"git://github.com/fnproject/fn.git","ssh_url":"git@github.com:fnproject/fn.git","clone_url":"https://github.com/fnproject/fn.git","svn_url":"https://github.com/fnproject/fn","homepage":"http://fnproject.io","size":165011,"stargazers_count":3316,"watchers_count":3316,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":235,"open_issues":114,"watchers":3316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1210"},"html":{"href":"https://github.com/fnproject/fn/pull/1210"},"issue":{"href":"https://api.github.com/repos/fnproject/fn/issues/1210"},"comments":{"href":"https://api.github.com/repos/fnproject/fn/issues/1210/comments"},"review_comments":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1210/comments"},"review_comment":{"href":"https://api.github.com/repos/fnproject/fn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fnproject/fn/pulls/1210/commits"},"statuses":{"href":"https://api.github.com/repos/fnproject/fn/statuses/ff9deae94b68e731ce04c668c9097ef595c22555"}},"author_association":"CONTRIBUTOR"}} | {
"id": 97652025,
"name": "fnproject/fn",
"url": "https://api.github.com/repos/fnproject/fn"
} | {
"id": 422106,
"login": "mantree",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/422106?",
"url": "https://api.github.com/users/mantree"
} | {
"id": 30273834,
"login": "fnproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30273834?",
"url": "https://api.github.com/orgs/fnproject"
} | 2018-09-14T13:58:53 | 8266287571 | {"actor":{"display_login":"mantree"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/221755462","pull_request_review_id":160483882,"id":221755462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc1NTQ2Mg==","diff_hunk":"@@ -149,6 +147,9 @@ contract ModuleRegistry is IModuleRegistry, EternalStorage {\n * @param _moduleFactory is the address of the module factory to be registered\n */\n function registerModule(address _moduleFactory) external whenNotPausedOrOwner {\n+ if (IFeatureRegistry(getAddress(Encoder.getKey('featureRegistry'))).getFeatureStatus(\"customModulesAllowed\")) {\n+ require(msg.sender == getAddress(Encoder.getKey(\"owner\")), \"Only owner allowed to register modules\");","path":"contracts/ModuleRegistry.sol","position":34,"original_position":34,"commit_id":"922f037b503b8b1938c5c1aecfb29c26f5775869","original_commit_id":"922f037b503b8b1938c5c1aecfb29c26f5775869","user":{"login":"pabloruiz55","id":526558,"node_id":"MDQ6VXNlcjUyNjU1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/526558?v=4","gravatar_id":"","url":"https://api.github.com/users/pabloruiz55","html_url":"https://github.com/pabloruiz55","followers_url":"https://api.github.com/users/pabloruiz55/followers","following_url":"https://api.github.com/users/pabloruiz55/following{/other_user}","gists_url":"https://api.github.com/users/pabloruiz55/gists{/gist_id}","starred_url":"https://api.github.com/users/pabloruiz55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabloruiz55/subscriptions","organizations_url":"https://api.github.com/users/pabloruiz55/orgs","repos_url":"https://api.github.com/users/pabloruiz55/repos","events_url":"https://api.github.com/users/pabloruiz55/events{/privacy}","received_events_url":"https://api.github.com/users/pabloruiz55/received_events","type":"User","site_admin":false},"body":"@adamdossa this should also say `|| IOwnable(_moduleFactory).owner() == IOwnable(msg.sender).owner()`\r\nso even when the \"customModulesAllowed\" is set, Polymath can still register someone else's module on their behalf, if for some reason we wanted so.","created_at":"2018-10-01T21:01:25Z","updated_at":"2018-10-01T21:01:26Z","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/297#discussion_r221755462","pull_request_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/221755462"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/297#discussion_r221755462"},"pull_request":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297","id":219503380,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTAzMzgw","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/297","diff_url":"https://github.com/PolymathNetwork/polymath-core/pull/297.diff","patch_url":"https://github.com/PolymathNetwork/polymath-core/pull/297.patch","issue_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/297","number":297,"state":"open","locked":false,"title":"Fix namespace squatting in MR","user":{"login":"adamdossa","id":2633913,"node_id":"MDQ6VXNlcjI2MzM5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2633913?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdossa","html_url":"https://github.com/adamdossa","followers_url":"https://api.github.com/users/adamdossa/followers","following_url":"https://api.github.com/users/adamdossa/following{/other_user}","gists_url":"https://api.github.com/users/adamdossa/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdossa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdossa/subscriptions","organizations_url":"https://api.github.com/users/adamdossa/orgs","repos_url":"https://api.github.com/users/adamdossa/repos","events_url":"https://api.github.com/users/adamdossa/events{/privacy}","received_events_url":"https://api.github.com/users/adamdossa/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-01T20:21:40Z","updated_at":"2018-10-01T21:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f0e5f366376f7850f9d69b270ff4082ddba34dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297/commits","review_comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297/comments","review_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/297/comments","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/922f037b503b8b1938c5c1aecfb29c26f5775869","head":{"label":"PolymathNetwork:fix_namespace_squatting_in_MR","ref":"fix_namespace_squatting_in_MR","sha":"922f037b503b8b1938c5c1aecfb29c26f5775869","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-10-01T14:34:42Z","pushed_at":"2018-10-01T20:23:27Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":4021,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":20,"watchers":134,"default_branch":"master"}},"base":{"label":"PolymathNetwork:development-1.5.0","ref":"development-1.5.0","sha":"befd377a1488c5e441fb8e2876514bfcc8c8336f","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-10-01T14:34:42Z","pushed_at":"2018-10-01T20:23:27Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":4021,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":48,"open_issues":20,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/297"},"issue":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/297"},"comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/922f037b503b8b1938c5c1aecfb29c26f5775869"}},"author_association":"MEMBER"}} | {
"id": 124091457,
"name": "PolymathNetwork/polymath-core",
"url": "https://api.github.com/repos/PolymathNetwork/polymath-core"
} | {
"id": 526558,
"login": "pabloruiz55",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/526558?",
"url": "https://api.github.com/users/pabloruiz55"
} | {
"id": 30353617,
"login": "PolymathNetwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30353617?",
"url": "https://api.github.com/orgs/PolymathNetwork"
} | 2018-10-01T21:01:25 | 8350690229 | {"actor":{"display_login":"pabloruiz55"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MirServer/mir/pulls/comments/213954196","pull_request_review_id":150899354,"id":213954196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk1NDE5Ng==","diff_hunk":"@@ -91,8 +92,18 @@ int main(int argc, char const* argv[])\n \"Only allow applications to connect during startup\",\n KioskAuthorizer::startup_only};\n \n+ DisplayConfiguration display_config;\n+\n+ CommandLineOption display_layout{\n+ [&display_config](std::string const& layout) { display_config.select_layout(layout); },\n+ \"display-layout\",\n+ \"Display configuration layout\",","path":"examples/miral-kiosk/kiosk_main.cpp","position":17,"original_position":17,"commit_id":"2a6d164b6d3f45fe6114e1928ea6f3d2d8847a3d","original_commit_id":"73ebc5d5c9d2f32037edc61aed3d8c7b7ff7e3e9","user":{"login":"AlanGriffiths","id":9048879,"node_id":"MDQ6VXNlcjkwNDg4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9048879?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanGriffiths","html_url":"https://github.com/AlanGriffiths","followers_url":"https://api.github.com/users/AlanGriffiths/followers","following_url":"https://api.github.com/users/AlanGriffiths/following{/other_user}","gists_url":"https://api.github.com/users/AlanGriffiths/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanGriffiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanGriffiths/subscriptions","organizations_url":"https://api.github.com/users/AlanGriffiths/orgs","repos_url":"https://api.github.com/users/AlanGriffiths/repos","events_url":"https://api.github.com/users/AlanGriffiths/events{/privacy}","received_events_url":"https://api.github.com/users/AlanGriffiths/received_events","type":"User","site_admin":false},"body":"On it!","created_at":"2018-08-30T09:00:40Z","updated_at":"2018-08-30T09:00:40Z","html_url":"https://github.com/MirServer/mir/pull/563#discussion_r213954196","pull_request_url":"https://api.github.com/repos/MirServer/mir/pulls/563","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MirServer/mir/pulls/comments/213954196"},"html":{"href":"https://github.com/MirServer/mir/pull/563#discussion_r213954196"},"pull_request":{"href":"https://api.github.com/repos/MirServer/mir/pulls/563"}},"in_reply_to_id":213624578},"pull_request":{"url":"https://api.github.com/repos/MirServer/mir/pulls/563","id":211518212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTE4MjEy","html_url":"https://github.com/MirServer/mir/pull/563","diff_url":"https://github.com/MirServer/mir/pull/563.diff","patch_url":"https://github.com/MirServer/mir/pull/563.patch","issue_url":"https://api.github.com/repos/MirServer/mir/issues/563","number":563,"state":"open","locked":false,"title":" Add miral::DisplayConfiguration","user":{"login":"AlanGriffiths","id":9048879,"node_id":"MDQ6VXNlcjkwNDg4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/9048879?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanGriffiths","html_url":"https://github.com/AlanGriffiths","followers_url":"https://api.github.com/users/AlanGriffiths/followers","following_url":"https://api.github.com/users/AlanGriffiths/following{/other_user}","gists_url":"https://api.github.com/users/AlanGriffiths/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanGriffiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanGriffiths/subscriptions","organizations_url":"https://api.github.com/users/AlanGriffiths/orgs","repos_url":"https://api.github.com/users/AlanGriffiths/repos","events_url":"https://api.github.com/users/AlanGriffiths/events{/privacy}","received_events_url":"https://api.github.com/users/AlanGriffiths/received_events","type":"User","site_admin":false},"body":"Mechanism to select layout from the display configuration file","created_at":"2018-08-28T18:38:17Z","updated_at":"2018-08-30T09:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f7055c10332e63e556b2383983ad16f29385425","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MirServer/mir/pulls/563/commits","review_comments_url":"https://api.github.com/repos/MirServer/mir/pulls/563/comments","review_comment_url":"https://api.github.com/repos/MirServer/mir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MirServer/mir/issues/563/comments","statuses_url":"https://api.github.com/repos/MirServer/mir/statuses/2a6d164b6d3f45fe6114e1928ea6f3d2d8847a3d","head":{"label":"MirServer:display-configuration","ref":"display-configuration","sha":"2a6d164b6d3f45fe6114e1928ea6f3d2d8847a3d","user":{"login":"MirServer","id":30658783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjU4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"repo":{"id":99117626,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExNzYyNg==","name":"mir","full_name":"MirServer/mir","owner":{"login":"MirServer","id":30658783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjU4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MirServer/mir","description":"The Mir compositor","fork":false,"url":"https://api.github.com/repos/MirServer/mir","forks_url":"https://api.github.com/repos/MirServer/mir/forks","keys_url":"https://api.github.com/repos/MirServer/mir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MirServer/mir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MirServer/mir/teams","hooks_url":"https://api.github.com/repos/MirServer/mir/hooks","issue_events_url":"https://api.github.com/repos/MirServer/mir/issues/events{/number}","events_url":"https://api.github.com/repos/MirServer/mir/events","assignees_url":"https://api.github.com/repos/MirServer/mir/assignees{/user}","branches_url":"https://api.github.com/repos/MirServer/mir/branches{/branch}","tags_url":"https://api.github.com/repos/MirServer/mir/tags","blobs_url":"https://api.github.com/repos/MirServer/mir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MirServer/mir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MirServer/mir/git/refs{/sha}","trees_url":"https://api.github.com/repos/MirServer/mir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MirServer/mir/statuses/{sha}","languages_url":"https://api.github.com/repos/MirServer/mir/languages","stargazers_url":"https://api.github.com/repos/MirServer/mir/stargazers","contributors_url":"https://api.github.com/repos/MirServer/mir/contributors","subscribers_url":"https://api.github.com/repos/MirServer/mir/subscribers","subscription_url":"https://api.github.com/repos/MirServer/mir/subscription","commits_url":"https://api.github.com/repos/MirServer/mir/commits{/sha}","git_commits_url":"https://api.github.com/repos/MirServer/mir/git/commits{/sha}","comments_url":"https://api.github.com/repos/MirServer/mir/comments{/number}","issue_comment_url":"https://api.github.com/repos/MirServer/mir/issues/comments{/number}","contents_url":"https://api.github.com/repos/MirServer/mir/contents/{+path}","compare_url":"https://api.github.com/repos/MirServer/mir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MirServer/mir/merges","archive_url":"https://api.github.com/repos/MirServer/mir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MirServer/mir/downloads","issues_url":"https://api.github.com/repos/MirServer/mir/issues{/number}","pulls_url":"https://api.github.com/repos/MirServer/mir/pulls{/number}","milestones_url":"https://api.github.com/repos/MirServer/mir/milestones{/number}","notifications_url":"https://api.github.com/repos/MirServer/mir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MirServer/mir/labels{/name}","releases_url":"https://api.github.com/repos/MirServer/mir/releases{/id}","deployments_url":"https://api.github.com/repos/MirServer/mir/deployments","created_at":"2017-08-02T13:09:25Z","updated_at":"2018-08-30T07:43:05Z","pushed_at":"2018-08-30T07:43:04Z","git_url":"git://github.com/MirServer/mir.git","ssh_url":"git@github.com:MirServer/mir.git","clone_url":"https://github.com/MirServer/mir.git","svn_url":"https://github.com/MirServer/mir","homepage":null,"size":178862,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":37,"watchers":104,"default_branch":"master"}},"base":{"label":"MirServer:master","ref":"master","sha":"f8425b27d9fec610927aee9a3b30b8d790e7ab27","user":{"login":"MirServer","id":30658783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjU4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"repo":{"id":99117626,"node_id":"MDEwOlJlcG9zaXRvcnk5OTExNzYyNg==","name":"mir","full_name":"MirServer/mir","owner":{"login":"MirServer","id":30658783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjU4Nzgz","avatar_url":"https://avatars2.githubusercontent.com/u/30658783?v=4","gravatar_id":"","url":"https://api.github.com/users/MirServer","html_url":"https://github.com/MirServer","followers_url":"https://api.github.com/users/MirServer/followers","following_url":"https://api.github.com/users/MirServer/following{/other_user}","gists_url":"https://api.github.com/users/MirServer/gists{/gist_id}","starred_url":"https://api.github.com/users/MirServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MirServer/subscriptions","organizations_url":"https://api.github.com/users/MirServer/orgs","repos_url":"https://api.github.com/users/MirServer/repos","events_url":"https://api.github.com/users/MirServer/events{/privacy}","received_events_url":"https://api.github.com/users/MirServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MirServer/mir","description":"The Mir compositor","fork":false,"url":"https://api.github.com/repos/MirServer/mir","forks_url":"https://api.github.com/repos/MirServer/mir/forks","keys_url":"https://api.github.com/repos/MirServer/mir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MirServer/mir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MirServer/mir/teams","hooks_url":"https://api.github.com/repos/MirServer/mir/hooks","issue_events_url":"https://api.github.com/repos/MirServer/mir/issues/events{/number}","events_url":"https://api.github.com/repos/MirServer/mir/events","assignees_url":"https://api.github.com/repos/MirServer/mir/assignees{/user}","branches_url":"https://api.github.com/repos/MirServer/mir/branches{/branch}","tags_url":"https://api.github.com/repos/MirServer/mir/tags","blobs_url":"https://api.github.com/repos/MirServer/mir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MirServer/mir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MirServer/mir/git/refs{/sha}","trees_url":"https://api.github.com/repos/MirServer/mir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MirServer/mir/statuses/{sha}","languages_url":"https://api.github.com/repos/MirServer/mir/languages","stargazers_url":"https://api.github.com/repos/MirServer/mir/stargazers","contributors_url":"https://api.github.com/repos/MirServer/mir/contributors","subscribers_url":"https://api.github.com/repos/MirServer/mir/subscribers","subscription_url":"https://api.github.com/repos/MirServer/mir/subscription","commits_url":"https://api.github.com/repos/MirServer/mir/commits{/sha}","git_commits_url":"https://api.github.com/repos/MirServer/mir/git/commits{/sha}","comments_url":"https://api.github.com/repos/MirServer/mir/comments{/number}","issue_comment_url":"https://api.github.com/repos/MirServer/mir/issues/comments{/number}","contents_url":"https://api.github.com/repos/MirServer/mir/contents/{+path}","compare_url":"https://api.github.com/repos/MirServer/mir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MirServer/mir/merges","archive_url":"https://api.github.com/repos/MirServer/mir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MirServer/mir/downloads","issues_url":"https://api.github.com/repos/MirServer/mir/issues{/number}","pulls_url":"https://api.github.com/repos/MirServer/mir/pulls{/number}","milestones_url":"https://api.github.com/repos/MirServer/mir/milestones{/number}","notifications_url":"https://api.github.com/repos/MirServer/mir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MirServer/mir/labels{/name}","releases_url":"https://api.github.com/repos/MirServer/mir/releases{/id}","deployments_url":"https://api.github.com/repos/MirServer/mir/deployments","created_at":"2017-08-02T13:09:25Z","updated_at":"2018-08-30T07:43:05Z","pushed_at":"2018-08-30T07:43:04Z","git_url":"git://github.com/MirServer/mir.git","ssh_url":"git@github.com:MirServer/mir.git","clone_url":"https://github.com/MirServer/mir.git","svn_url":"https://github.com/MirServer/mir","homepage":null,"size":178862,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":37,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MirServer/mir/pulls/563"},"html":{"href":"https://github.com/MirServer/mir/pull/563"},"issue":{"href":"https://api.github.com/repos/MirServer/mir/issues/563"},"comments":{"href":"https://api.github.com/repos/MirServer/mir/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/MirServer/mir/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/MirServer/mir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MirServer/mir/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/MirServer/mir/statuses/2a6d164b6d3f45fe6114e1928ea6f3d2d8847a3d"}},"author_association":"MEMBER"}} | {
"id": 99117626,
"name": "MirServer/mir",
"url": "https://api.github.com/repos/MirServer/mir"
} | {
"id": 9048879,
"login": "AlanGriffiths",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9048879?",
"url": "https://api.github.com/users/AlanGriffiths"
} | {
"id": 30658783,
"login": "MirServer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30658783?",
"url": "https://api.github.com/orgs/MirServer"
} | 2018-08-30T09:00:40 | 8189918095 | {"actor":{"display_login":"AlanGriffiths"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/comments/212537996","pull_request_review_id":149194265,"id":212537996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjUzNzk5Ng==","diff_hunk":"@@ -425,7 +425,11 @@ def _wait_for_submission(self, timeout=60):\n raise JobTimeoutError(\n \"Timeout waiting for the job being submitted: {}\".format(ex)\n )\n-\n+ if (submit_info is None","path":"qiskit/backends/ibmq/ibmqjob.py","position":5,"original_position":5,"commit_id":"fb1f09e3bc420f7666d1f94a0fdd6ab79499443e","original_commit_id":"fb1f09e3bc420f7666d1f94a0fdd6ab79499443e","user":{"login":"delapuente","id":757942,"node_id":"MDQ6VXNlcjc1Nzk0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/757942?v=4","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"body":"I think we could move the check just after checking `self._future` to keep the timeout signaling in the last place and remove the check of `submit_info` (I'm not sure if it's possible at all).","created_at":"2018-08-24T07:04:38Z","updated_at":"2018-08-24T07:04:43Z","html_url":"https://github.com/Qiskit/qiskit-terra/pull/816#discussion_r212537996","pull_request_url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/comments/212537996"},"html":{"href":"https://github.com/Qiskit/qiskit-terra/pull/816#discussion_r212537996"},"pull_request":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816"}}},"pull_request":{"url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816","id":210483681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDgzNjgx","html_url":"https://github.com/Qiskit/qiskit-terra/pull/816","diff_url":"https://github.com/Qiskit/qiskit-terra/pull/816.diff","patch_url":"https://github.com/Qiskit/qiskit-terra/pull/816.patch","issue_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/816","number":816,"state":"open","locked":false,"title":"raise caught exception during job submission","user":{"login":"ewinston","id":25756217,"node_id":"MDQ6VXNlcjI1NzU2MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/25756217?v=4","gravatar_id":"","url":"https://api.github.com/users/ewinston","html_url":"https://github.com/ewinston","followers_url":"https://api.github.com/users/ewinston/followers","following_url":"https://api.github.com/users/ewinston/following{/other_user}","gists_url":"https://api.github.com/users/ewinston/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinston/subscriptions","organizations_url":"https://api.github.com/users/ewinston/orgs","repos_url":"https://api.github.com/users/ewinston/repos","events_url":"https://api.github.com/users/ewinston/events{/privacy}","received_events_url":"https://api.github.com/users/ewinston/received_events","type":"User","site_admin":false},"body":"fixes #815\r\n\r\n<!--\r\n⚠️ If you do not respect this template, your pull request will be closed.\r\n⚠️ Your pull request title should be short detailed and understandable for all.\r\n⚠️ Also, please add it in the CHANGELOG file under Unreleased section.\r\n⚠️ If your pull request fixes an open issue, please link to the issue.\r\n\r\n✅ I have added the tests to cover my changes.\r\n✅ I have updated the documentation accordingly.\r\n✅ I have read the CONTRIBUTING document.\r\n-->\r\n\r\n### Summary\r\n\r\n\r\n\r\n### Details and comments\r\n\r\n\r\n","created_at":"2018-08-23T15:14:39Z","updated_at":"2018-08-24T07:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"333df283975edcb2a474bc4deb8e56e4ba6479fe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"diego-plan9","id":418311,"node_id":"MDQ6VXNlcjQxODMxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/418311?v=4","gravatar_id":"","url":"https://api.github.com/users/diego-plan9","html_url":"https://github.com/diego-plan9","followers_url":"https://api.github.com/users/diego-plan9/followers","following_url":"https://api.github.com/users/diego-plan9/following{/other_user}","gists_url":"https://api.github.com/users/diego-plan9/gists{/gist_id}","starred_url":"https://api.github.com/users/diego-plan9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diego-plan9/subscriptions","organizations_url":"https://api.github.com/users/diego-plan9/orgs","repos_url":"https://api.github.com/users/diego-plan9/repos","events_url":"https://api.github.com/users/diego-plan9/events{/privacy}","received_events_url":"https://api.github.com/users/diego-plan9/received_events","type":"User","site_admin":false},{"login":"nonhermitian","id":1249193,"node_id":"MDQ6VXNlcjEyNDkxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1249193?v=4","gravatar_id":"","url":"https://api.github.com/users/nonhermitian","html_url":"https://github.com/nonhermitian","followers_url":"https://api.github.com/users/nonhermitian/followers","following_url":"https://api.github.com/users/nonhermitian/following{/other_user}","gists_url":"https://api.github.com/users/nonhermitian/gists{/gist_id}","starred_url":"https://api.github.com/users/nonhermitian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nonhermitian/subscriptions","organizations_url":"https://api.github.com/users/nonhermitian/orgs","repos_url":"https://api.github.com/users/nonhermitian/repos","events_url":"https://api.github.com/users/nonhermitian/events{/privacy}","received_events_url":"https://api.github.com/users/nonhermitian/received_events","type":"User","site_admin":false},{"login":"atilag","id":1304071,"node_id":"MDQ6VXNlcjEzMDQwNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1304071?v=4","gravatar_id":"","url":"https://api.github.com/users/atilag","html_url":"https://github.com/atilag","followers_url":"https://api.github.com/users/atilag/followers","following_url":"https://api.github.com/users/atilag/following{/other_user}","gists_url":"https://api.github.com/users/atilag/gists{/gist_id}","starred_url":"https://api.github.com/users/atilag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atilag/subscriptions","organizations_url":"https://api.github.com/users/atilag/orgs","repos_url":"https://api.github.com/users/atilag/repos","events_url":"https://api.github.com/users/atilag/events{/privacy}","received_events_url":"https://api.github.com/users/atilag/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816/commits","review_comments_url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816/comments","review_comment_url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/816/comments","statuses_url":"https://api.github.com/repos/Qiskit/qiskit-terra/statuses/fb1f09e3bc420f7666d1f94a0fdd6ab79499443e","head":{"label":"ewinston:bug/815","ref":"bug/815","sha":"fb1f09e3bc420f7666d1f94a0fdd6ab79499443e","user":{"login":"ewinston","id":25756217,"node_id":"MDQ6VXNlcjI1NzU2MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/25756217?v=4","gravatar_id":"","url":"https://api.github.com/users/ewinston","html_url":"https://github.com/ewinston","followers_url":"https://api.github.com/users/ewinston/followers","following_url":"https://api.github.com/users/ewinston/following{/other_user}","gists_url":"https://api.github.com/users/ewinston/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinston/subscriptions","organizations_url":"https://api.github.com/users/ewinston/orgs","repos_url":"https://api.github.com/users/ewinston/repos","events_url":"https://api.github.com/users/ewinston/events{/privacy}","received_events_url":"https://api.github.com/users/ewinston/received_events","type":"User","site_admin":false},"repo":{"id":99157942,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE1Nzk0Mg==","name":"qiskit-terra","full_name":"ewinston/qiskit-terra","owner":{"login":"ewinston","id":25756217,"node_id":"MDQ6VXNlcjI1NzU2MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/25756217?v=4","gravatar_id":"","url":"https://api.github.com/users/ewinston","html_url":"https://github.com/ewinston","followers_url":"https://api.github.com/users/ewinston/followers","following_url":"https://api.github.com/users/ewinston/following{/other_user}","gists_url":"https://api.github.com/users/ewinston/gists{/gist_id}","starred_url":"https://api.github.com/users/ewinston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewinston/subscriptions","organizations_url":"https://api.github.com/users/ewinston/orgs","repos_url":"https://api.github.com/users/ewinston/repos","events_url":"https://api.github.com/users/ewinston/events{/privacy}","received_events_url":"https://api.github.com/users/ewinston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewinston/qiskit-terra","description":"Python tools for running quantum information experiments","fork":true,"url":"https://api.github.com/repos/ewinston/qiskit-terra","forks_url":"https://api.github.com/repos/ewinston/qiskit-terra/forks","keys_url":"https://api.github.com/repos/ewinston/qiskit-terra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewinston/qiskit-terra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewinston/qiskit-terra/teams","hooks_url":"https://api.github.com/repos/ewinston/qiskit-terra/hooks","issue_events_url":"https://api.github.com/repos/ewinston/qiskit-terra/issues/events{/number}","events_url":"https://api.github.com/repos/ewinston/qiskit-terra/events","assignees_url":"https://api.github.com/repos/ewinston/qiskit-terra/assignees{/user}","branches_url":"https://api.github.com/repos/ewinston/qiskit-terra/branches{/branch}","tags_url":"https://api.github.com/repos/ewinston/qiskit-terra/tags","blobs_url":"https://api.github.com/repos/ewinston/qiskit-terra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewinston/qiskit-terra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewinston/qiskit-terra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewinston/qiskit-terra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewinston/qiskit-terra/statuses/{sha}","languages_url":"https://api.github.com/repos/ewinston/qiskit-terra/languages","stargazers_url":"https://api.github.com/repos/ewinston/qiskit-terra/stargazers","contributors_url":"https://api.github.com/repos/ewinston/qiskit-terra/contributors","subscribers_url":"https://api.github.com/repos/ewinston/qiskit-terra/subscribers","subscription_url":"https://api.github.com/repos/ewinston/qiskit-terra/subscription","commits_url":"https://api.github.com/repos/ewinston/qiskit-terra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewinston/qiskit-terra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewinston/qiskit-terra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewinston/qiskit-terra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewinston/qiskit-terra/contents/{+path}","compare_url":"https://api.github.com/repos/ewinston/qiskit-terra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewinston/qiskit-terra/merges","archive_url":"https://api.github.com/repos/ewinston/qiskit-terra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewinston/qiskit-terra/downloads","issues_url":"https://api.github.com/repos/ewinston/qiskit-terra/issues{/number}","pulls_url":"https://api.github.com/repos/ewinston/qiskit-terra/pulls{/number}","milestones_url":"https://api.github.com/repos/ewinston/qiskit-terra/milestones{/number}","notifications_url":"https://api.github.com/repos/ewinston/qiskit-terra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewinston/qiskit-terra/labels{/name}","releases_url":"https://api.github.com/repos/ewinston/qiskit-terra/releases{/id}","deployments_url":"https://api.github.com/repos/ewinston/qiskit-terra/deployments","created_at":"2017-08-02T20:26:39Z","updated_at":"2018-08-21T15:31:17Z","pushed_at":"2018-08-23T17:10:10Z","git_url":"git://github.com/ewinston/qiskit-terra.git","ssh_url":"git@github.com:ewinston/qiskit-terra.git","clone_url":"https://github.com/ewinston/qiskit-terra.git","svn_url":"https://github.com/ewinston/qiskit-terra","homepage":"https://quantumexperience.ng.bluemix.net/","size":28945,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Qiskit:master","ref":"master","sha":"2582fae6a3cf020f5715d8ed58b492eb91a7604d","user":{"login":"Qiskit","id":30696987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjk2OTg3","avatar_url":"https://avatars1.githubusercontent.com/u/30696987?v=4","gravatar_id":"","url":"https://api.github.com/users/Qiskit","html_url":"https://github.com/Qiskit","followers_url":"https://api.github.com/users/Qiskit/followers","following_url":"https://api.github.com/users/Qiskit/following{/other_user}","gists_url":"https://api.github.com/users/Qiskit/gists{/gist_id}","starred_url":"https://api.github.com/users/Qiskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qiskit/subscriptions","organizations_url":"https://api.github.com/users/Qiskit/orgs","repos_url":"https://api.github.com/users/Qiskit/repos","events_url":"https://api.github.com/users/Qiskit/events{/privacy}","received_events_url":"https://api.github.com/users/Qiskit/received_events","type":"Organization","site_admin":false},"repo":{"id":83821669,"node_id":"MDEwOlJlcG9zaXRvcnk4MzgyMTY2OQ==","name":"qiskit-terra","full_name":"Qiskit/qiskit-terra","owner":{"login":"Qiskit","id":30696987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjk2OTg3","avatar_url":"https://avatars1.githubusercontent.com/u/30696987?v=4","gravatar_id":"","url":"https://api.github.com/users/Qiskit","html_url":"https://github.com/Qiskit","followers_url":"https://api.github.com/users/Qiskit/followers","following_url":"https://api.github.com/users/Qiskit/following{/other_user}","gists_url":"https://api.github.com/users/Qiskit/gists{/gist_id}","starred_url":"https://api.github.com/users/Qiskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qiskit/subscriptions","organizations_url":"https://api.github.com/users/Qiskit/orgs","repos_url":"https://api.github.com/users/Qiskit/repos","events_url":"https://api.github.com/users/Qiskit/events{/privacy}","received_events_url":"https://api.github.com/users/Qiskit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qiskit/qiskit-terra","description":"Terra provides the foundations for Qiskit. It allows the user to write quantum circuits easily, and takes care of the constraints of real hardware.","fork":false,"url":"https://api.github.com/repos/Qiskit/qiskit-terra","forks_url":"https://api.github.com/repos/Qiskit/qiskit-terra/forks","keys_url":"https://api.github.com/repos/Qiskit/qiskit-terra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qiskit/qiskit-terra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qiskit/qiskit-terra/teams","hooks_url":"https://api.github.com/repos/Qiskit/qiskit-terra/hooks","issue_events_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/events{/number}","events_url":"https://api.github.com/repos/Qiskit/qiskit-terra/events","assignees_url":"https://api.github.com/repos/Qiskit/qiskit-terra/assignees{/user}","branches_url":"https://api.github.com/repos/Qiskit/qiskit-terra/branches{/branch}","tags_url":"https://api.github.com/repos/Qiskit/qiskit-terra/tags","blobs_url":"https://api.github.com/repos/Qiskit/qiskit-terra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qiskit/qiskit-terra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qiskit/qiskit-terra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qiskit/qiskit-terra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qiskit/qiskit-terra/statuses/{sha}","languages_url":"https://api.github.com/repos/Qiskit/qiskit-terra/languages","stargazers_url":"https://api.github.com/repos/Qiskit/qiskit-terra/stargazers","contributors_url":"https://api.github.com/repos/Qiskit/qiskit-terra/contributors","subscribers_url":"https://api.github.com/repos/Qiskit/qiskit-terra/subscribers","subscription_url":"https://api.github.com/repos/Qiskit/qiskit-terra/subscription","commits_url":"https://api.github.com/repos/Qiskit/qiskit-terra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qiskit/qiskit-terra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qiskit/qiskit-terra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qiskit/qiskit-terra/contents/{+path}","compare_url":"https://api.github.com/repos/Qiskit/qiskit-terra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qiskit/qiskit-terra/merges","archive_url":"https://api.github.com/repos/Qiskit/qiskit-terra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qiskit/qiskit-terra/downloads","issues_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues{/number}","pulls_url":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls{/number}","milestones_url":"https://api.github.com/repos/Qiskit/qiskit-terra/milestones{/number}","notifications_url":"https://api.github.com/repos/Qiskit/qiskit-terra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qiskit/qiskit-terra/labels{/name}","releases_url":"https://api.github.com/repos/Qiskit/qiskit-terra/releases{/id}","deployments_url":"https://api.github.com/repos/Qiskit/qiskit-terra/deployments","created_at":"2017-03-03T17:02:42Z","updated_at":"2018-08-24T04:45:10Z","pushed_at":"2018-08-24T04:45:05Z","git_url":"git://github.com/Qiskit/qiskit-terra.git","ssh_url":"git@github.com:Qiskit/qiskit-terra.git","clone_url":"https://github.com/Qiskit/qiskit-terra.git","svn_url":"https://github.com/Qiskit/qiskit-terra","homepage":"https://qiskit.org","size":28516,"stargazers_count":1998,"watchers_count":1998,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":588,"open_issues":109,"watchers":1998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816"},"html":{"href":"https://github.com/Qiskit/qiskit-terra/pull/816"},"issue":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/816"},"comments":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/816/comments"},"review_comments":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816/comments"},"review_comment":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/pulls/816/commits"},"statuses":{"href":"https://api.github.com/repos/Qiskit/qiskit-terra/statuses/fb1f09e3bc420f7666d1f94a0fdd6ab79499443e"}},"author_association":"COLLABORATOR"}} | {
"id": 83821669,
"name": "Qiskit/qiskit-terra",
"url": "https://api.github.com/repos/Qiskit/qiskit-terra"
} | {
"id": 757942,
"login": "delapuente",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/757942?",
"url": "https://api.github.com/users/delapuente"
} | {
"id": 30696987,
"login": "Qiskit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30696987?",
"url": "https://api.github.com/orgs/Qiskit"
} | 2018-08-24T07:04:38 | 8161344529 | {"actor":{"display_login":"delapuente"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments/230945507","pull_request_review_id":171800247,"id":230945507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk0NTUwNw==","diff_hunk":"@@ -671,9 +641,7 @@ TEST_P(metics_uitls_dcp_c_p, test_metric_utils_12) {\n \n \n \tEXPECT_EQ(FPGA_OK, fpga_vector_free(&vector));\n-\n-\tdlclose(_handle->bmc_handle);\n-\n+\t//dlclose(_handle->bmc_handle);","path":"testing/xfpga/test_metrics_utils_c.cpp","position":154,"original_position":154,"commit_id":"597151d640bf495f8811fd9094569ca2720ccf23","original_commit_id":"597151d640bf495f8811fd9094569ca2720ccf23","user":{"login":"tswhison","id":33638304,"node_id":"MDQ6VXNlcjMzNjM4MzA0","avatar_url":"https://avatars3.githubusercontent.com/u/33638304?v=4","gravatar_id":"","url":"https://api.github.com/users/tswhison","html_url":"https://github.com/tswhison","followers_url":"https://api.github.com/users/tswhison/followers","following_url":"https://api.github.com/users/tswhison/following{/other_user}","gists_url":"https://api.github.com/users/tswhison/gists{/gist_id}","starred_url":"https://api.github.com/users/tswhison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswhison/subscriptions","organizations_url":"https://api.github.com/users/tswhison/orgs","repos_url":"https://api.github.com/users/tswhison/repos","events_url":"https://api.github.com/users/tswhison/events{/privacy}","received_events_url":"https://api.github.com/users/tswhison/received_events","type":"User","site_admin":false},"body":"Remove if it isn't needed.","created_at":"2018-11-05T22:57:05Z","updated_at":"2018-11-05T22:57:31Z","html_url":"https://github.com/OPAE/opae-sdk/pull/912#discussion_r230945507","pull_request_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments/230945507"},"html":{"href":"https://github.com/OPAE/opae-sdk/pull/912#discussion_r230945507"},"pull_request":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912"}}},"pull_request":{"url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912","id":228518409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTE4NDA5","html_url":"https://github.com/OPAE/opae-sdk/pull/912","diff_url":"https://github.com/OPAE/opae-sdk/pull/912.diff","patch_url":"https://github.com/OPAE/opae-sdk/pull/912.patch","issue_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/912","number":912,"state":"open","locked":false,"title":"Address Metrics tests valgrind issues","user":{"login":"jelonanX","id":42047493,"node_id":"MDQ6VXNlcjQyMDQ3NDkz","avatar_url":"https://avatars0.githubusercontent.com/u/42047493?v=4","gravatar_id":"","url":"https://api.github.com/users/jelonanX","html_url":"https://github.com/jelonanX","followers_url":"https://api.github.com/users/jelonanX/followers","following_url":"https://api.github.com/users/jelonanX/following{/other_user}","gists_url":"https://api.github.com/users/jelonanX/gists{/gist_id}","starred_url":"https://api.github.com/users/jelonanX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelonanX/subscriptions","organizations_url":"https://api.github.com/users/jelonanX/orgs","repos_url":"https://api.github.com/users/jelonanX/repos","events_url":"https://api.github.com/users/jelonanX/events{/privacy}","received_events_url":"https://api.github.com/users/jelonanX/received_events","type":"User","site_admin":false},"body":"Fixed typos in test_metrics_c.cpp\r\nAddress valgrind issues in test_metrics_utils_c.cpp","created_at":"2018-11-05T22:51:26Z","updated_at":"2018-11-05T22:57:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51e44ce5ffd88795e6680a31a1852173fffc256c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nakulkorde","id":10795903,"node_id":"MDQ6VXNlcjEwNzk1OTAz","avatar_url":"https://avatars2.githubusercontent.com/u/10795903?v=4","gravatar_id":"","url":"https://api.github.com/users/nakulkorde","html_url":"https://github.com/nakulkorde","followers_url":"https://api.github.com/users/nakulkorde/followers","following_url":"https://api.github.com/users/nakulkorde/following{/other_user}","gists_url":"https://api.github.com/users/nakulkorde/gists{/gist_id}","starred_url":"https://api.github.com/users/nakulkorde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakulkorde/subscriptions","organizations_url":"https://api.github.com/users/nakulkorde/orgs","repos_url":"https://api.github.com/users/nakulkorde/repos","events_url":"https://api.github.com/users/nakulkorde/events{/privacy}","received_events_url":"https://api.github.com/users/nakulkorde/received_events","type":"User","site_admin":false},{"login":"r-rojo","id":22808196,"node_id":"MDQ6VXNlcjIyODA4MTk2","avatar_url":"https://avatars3.githubusercontent.com/u/22808196?v=4","gravatar_id":"","url":"https://api.github.com/users/r-rojo","html_url":"https://github.com/r-rojo","followers_url":"https://api.github.com/users/r-rojo/followers","following_url":"https://api.github.com/users/r-rojo/following{/other_user}","gists_url":"https://api.github.com/users/r-rojo/gists{/gist_id}","starred_url":"https://api.github.com/users/r-rojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-rojo/subscriptions","organizations_url":"https://api.github.com/users/r-rojo/orgs","repos_url":"https://api.github.com/users/r-rojo/repos","events_url":"https://api.github.com/users/r-rojo/events{/privacy}","received_events_url":"https://api.github.com/users/r-rojo/received_events","type":"User","site_admin":false},{"login":"ibarraza","id":33640356,"node_id":"MDQ6VXNlcjMzNjQwMzU2","avatar_url":"https://avatars0.githubusercontent.com/u/33640356?v=4","gravatar_id":"","url":"https://api.github.com/users/ibarraza","html_url":"https://github.com/ibarraza","followers_url":"https://api.github.com/users/ibarraza/followers","following_url":"https://api.github.com/users/ibarraza/following{/other_user}","gists_url":"https://api.github.com/users/ibarraza/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarraza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarraza/subscriptions","organizations_url":"https://api.github.com/users/ibarraza/orgs","repos_url":"https://api.github.com/users/ibarraza/repos","events_url":"https://api.github.com/users/ibarraza/events{/privacy}","received_events_url":"https://api.github.com/users/ibarraza/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"ci","id":2649373,"node_id":"MDQ6VGVhbTI2NDkzNzM=","slug":"ci","description":"Maintainers for the build and CI infrastructure","privacy":"closed","url":"https://api.github.com/teams/2649373","members_url":"https://api.github.com/teams/2649373/members{/member}","repositories_url":"https://api.github.com/teams/2649373/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912/commits","review_comments_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912/comments","review_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/912/comments","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/597151d640bf495f8811fd9094569ca2720ccf23","head":{"label":"OPAE:jelonanx/xfpga-metrics","ref":"jelonanx/xfpga-metrics","sha":"597151d640bf495f8811fd9094569ca2720ccf23","user":{"login":"OPAE","id":30705801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzA1ODAx","avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"repo":{"id":102083635,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwODM2MzU=","name":"opae-sdk","full_name":"OPAE/opae-sdk","private":false,"owner":{"login":"OPAE","id":30705801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzA1ODAx","avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OPAE/opae-sdk","description":"Open Programmable Acceleration Engine","fork":false,"url":"https://api.github.com/repos/OPAE/opae-sdk","forks_url":"https://api.github.com/repos/OPAE/opae-sdk/forks","keys_url":"https://api.github.com/repos/OPAE/opae-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPAE/opae-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPAE/opae-sdk/teams","hooks_url":"https://api.github.com/repos/OPAE/opae-sdk/hooks","issue_events_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/OPAE/opae-sdk/events","assignees_url":"https://api.github.com/repos/OPAE/opae-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/OPAE/opae-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/OPAE/opae-sdk/tags","blobs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPAE/opae-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPAE/opae-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/OPAE/opae-sdk/languages","stargazers_url":"https://api.github.com/repos/OPAE/opae-sdk/stargazers","contributors_url":"https://api.github.com/repos/OPAE/opae-sdk/contributors","subscribers_url":"https://api.github.com/repos/OPAE/opae-sdk/subscribers","subscription_url":"https://api.github.com/repos/OPAE/opae-sdk/subscription","commits_url":"https://api.github.com/repos/OPAE/opae-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPAE/opae-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPAE/opae-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/OPAE/opae-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPAE/opae-sdk/merges","archive_url":"https://api.github.com/repos/OPAE/opae-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPAE/opae-sdk/downloads","issues_url":"https://api.github.com/repos/OPAE/opae-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/OPAE/opae-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/OPAE/opae-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPAE/opae-sdk/labels{/name}","releases_url":"https://api.github.com/repos/OPAE/opae-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/OPAE/opae-sdk/deployments","created_at":"2017-09-01T07:00:50Z","updated_at":"2018-11-05T22:34:19Z","pushed_at":"2018-11-05T22:52:52Z","git_url":"git://github.com/OPAE/opae-sdk.git","ssh_url":"git@github.com:OPAE/opae-sdk.git","clone_url":"https://github.com/OPAE/opae-sdk.git","svn_url":"https://github.com/OPAE/opae-sdk","homepage":"https://01.org/OPAE","size":9751,"stargazers_count":127,"watchers_count":127,"language":"Verilog","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":16,"watchers":127,"default_branch":"master"}},"base":{"label":"OPAE:master","ref":"master","sha":"b46209f04ad28c7f96fccb30ca19189a1544c721","user":{"login":"OPAE","id":30705801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzA1ODAx","avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"repo":{"id":102083635,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwODM2MzU=","name":"opae-sdk","full_name":"OPAE/opae-sdk","private":false,"owner":{"login":"OPAE","id":30705801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzA1ODAx","avatar_url":"https://avatars2.githubusercontent.com/u/30705801?v=4","gravatar_id":"","url":"https://api.github.com/users/OPAE","html_url":"https://github.com/OPAE","followers_url":"https://api.github.com/users/OPAE/followers","following_url":"https://api.github.com/users/OPAE/following{/other_user}","gists_url":"https://api.github.com/users/OPAE/gists{/gist_id}","starred_url":"https://api.github.com/users/OPAE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPAE/subscriptions","organizations_url":"https://api.github.com/users/OPAE/orgs","repos_url":"https://api.github.com/users/OPAE/repos","events_url":"https://api.github.com/users/OPAE/events{/privacy}","received_events_url":"https://api.github.com/users/OPAE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OPAE/opae-sdk","description":"Open Programmable Acceleration Engine","fork":false,"url":"https://api.github.com/repos/OPAE/opae-sdk","forks_url":"https://api.github.com/repos/OPAE/opae-sdk/forks","keys_url":"https://api.github.com/repos/OPAE/opae-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPAE/opae-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPAE/opae-sdk/teams","hooks_url":"https://api.github.com/repos/OPAE/opae-sdk/hooks","issue_events_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/OPAE/opae-sdk/events","assignees_url":"https://api.github.com/repos/OPAE/opae-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/OPAE/opae-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/OPAE/opae-sdk/tags","blobs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPAE/opae-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPAE/opae-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPAE/opae-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPAE/opae-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/OPAE/opae-sdk/languages","stargazers_url":"https://api.github.com/repos/OPAE/opae-sdk/stargazers","contributors_url":"https://api.github.com/repos/OPAE/opae-sdk/contributors","subscribers_url":"https://api.github.com/repos/OPAE/opae-sdk/subscribers","subscription_url":"https://api.github.com/repos/OPAE/opae-sdk/subscription","commits_url":"https://api.github.com/repos/OPAE/opae-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPAE/opae-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPAE/opae-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPAE/opae-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPAE/opae-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/OPAE/opae-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPAE/opae-sdk/merges","archive_url":"https://api.github.com/repos/OPAE/opae-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPAE/opae-sdk/downloads","issues_url":"https://api.github.com/repos/OPAE/opae-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/OPAE/opae-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/OPAE/opae-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/OPAE/opae-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPAE/opae-sdk/labels{/name}","releases_url":"https://api.github.com/repos/OPAE/opae-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/OPAE/opae-sdk/deployments","created_at":"2017-09-01T07:00:50Z","updated_at":"2018-11-05T22:34:19Z","pushed_at":"2018-11-05T22:52:52Z","git_url":"git://github.com/OPAE/opae-sdk.git","ssh_url":"git@github.com:OPAE/opae-sdk.git","clone_url":"https://github.com/OPAE/opae-sdk.git","svn_url":"https://github.com/OPAE/opae-sdk","homepage":"https://01.org/OPAE","size":9751,"stargazers_count":127,"watchers_count":127,"language":"Verilog","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":16,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912"},"html":{"href":"https://github.com/OPAE/opae-sdk/pull/912"},"issue":{"href":"https://api.github.com/repos/OPAE/opae-sdk/issues/912"},"comments":{"href":"https://api.github.com/repos/OPAE/opae-sdk/issues/912/comments"},"review_comments":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912/comments"},"review_comment":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPAE/opae-sdk/pulls/912/commits"},"statuses":{"href":"https://api.github.com/repos/OPAE/opae-sdk/statuses/597151d640bf495f8811fd9094569ca2720ccf23"}},"author_association":"CONTRIBUTOR"}} | {
"id": 102083635,
"name": "OPAE/opae-sdk",
"url": "https://api.github.com/repos/OPAE/opae-sdk"
} | {
"id": 33638304,
"login": "tswhison",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33638304?",
"url": "https://api.github.com/users/tswhison"
} | {
"id": 30705801,
"login": "OPAE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30705801?",
"url": "https://api.github.com/orgs/OPAE"
} | 2018-11-05T22:57:05 | 8539097455 | {"actor":{"display_login":"tswhison"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nventive/Uno/pulls/comments/239664141","pull_request_review_id":182511244,"id":239664141,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTY2NDE0MQ==","diff_hunk":"@@ -450,7 +450,8 @@ namespace <#= mixin.NamespaceName #>\n \t\t\t\t\tSizeChanged?.Invoke(this, new SizeChangedEventArgs(previousSize, _actualSize));\n \n #if <#= mixin.IsFrameworkElement #>\n-\t\t\t\t\tif (Superview != null && !(Superview is DependencyObject))\n+\t\t\t\t\t// Require measurement from CommandBar elements just cause apps to crash","path":"src/Uno.UI/UI/Xaml/IFrameworkElementImplementation.iOS.tt","position":5,"original_position":5,"commit_id":"82fc4162ff8fe32224032f2c45153a4e112bc599","original_commit_id":"82fc4162ff8fe32224032f2c45153a4e112bc599","user":{"login":"davidjohnoliver","id":8270914,"node_id":"MDQ6VXNlcjgyNzA5MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8270914?v=4","gravatar_id":"","url":"https://api.github.com/users/davidjohnoliver","html_url":"https://github.com/davidjohnoliver","followers_url":"https://api.github.com/users/davidjohnoliver/followers","following_url":"https://api.github.com/users/davidjohnoliver/following{/other_user}","gists_url":"https://api.github.com/users/davidjohnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjohnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjohnoliver/subscriptions","organizations_url":"https://api.github.com/users/davidjohnoliver/orgs","repos_url":"https://api.github.com/users/davidjohnoliver/repos","events_url":"https://api.github.com/users/davidjohnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/davidjohnoliver/received_events","type":"User","site_admin":false},"body":"Apart from being a monstrous hack, this will cause a regression when the CommandBar content is text that's too long to display in portrait.","created_at":"2018-12-07T00:35:26Z","updated_at":"2018-12-07T00:35:26Z","html_url":"https://github.com/nventive/Uno/pull/424#discussion_r239664141","pull_request_url":"https://api.github.com/repos/nventive/Uno/pulls/424","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nventive/Uno/pulls/comments/239664141"},"html":{"href":"https://github.com/nventive/Uno/pull/424#discussion_r239664141"},"pull_request":{"href":"https://api.github.com/repos/nventive/Uno/pulls/424"}},"in_reply_to_id":239635104},"pull_request":{"url":"https://api.github.com/repos/nventive/Uno/pulls/424","id":236687654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Njg3NjU0","html_url":"https://github.com/nventive/Uno/pull/424","diff_url":"https://github.com/nventive/Uno/pull/424.diff","patch_url":"https://github.com/nventive/Uno/pull/424.patch","issue_url":"https://api.github.com/repos/nventive/Uno/issues/424","number":424,"state":"open","locked":false,"title":"[iOS] Fix app freezes if an Image without width is set in the CommandBar","user":{"login":"YGuerin","id":11750340,"node_id":"MDQ6VXNlcjExNzUwMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/11750340?v=4","gravatar_id":"","url":"https://api.github.com/users/YGuerin","html_url":"https://github.com/YGuerin","followers_url":"https://api.github.com/users/YGuerin/followers","following_url":"https://api.github.com/users/YGuerin/following{/other_user}","gists_url":"https://api.github.com/users/YGuerin/gists{/gist_id}","starred_url":"https://api.github.com/users/YGuerin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YGuerin/subscriptions","organizations_url":"https://api.github.com/users/YGuerin/orgs","repos_url":"https://api.github.com/users/YGuerin/repos","events_url":"https://api.github.com/users/YGuerin/events{/privacy}","received_events_url":"https://api.github.com/users/YGuerin/received_events","type":"User","site_admin":false},"body":"GitHub Issue (If applicable): #\r\n<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal) -->\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please uncomment one ore more that apply to this PR -->\r\n\r\n- Bugfix\r\n<!-- - Feature -->\r\n<!-- - Code style update (formatting) -->\r\n<!-- - Refactoring (no functional changes, no api changes) -->\r\n<!-- - Build or CI related changes -->\r\n<!-- - Documentation content changes -->\r\n<!-- - Other... Please describe: -->\r\n\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nThe app freezes if the Content of a CommandBar is an Image without specified width\r\n\r\n## What is the new behavior?\r\n<!-- Please describe the new behavior after your modifications. -->\r\nThe app no longer freezes\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ ] Tested code with current [supported SDKs](../README.md#supported)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/nventive/Uno/blob/master/doc/.feature-template.md). (for bug fixes / features)\r\n- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] Contains **NO** breaking changes\r\n- [ ] Updated the [Release Notes](https://github.com/nventive/Uno/tree/master/doc/ReleaseNotes)\r\n- [ ] Associated with an issue (GitHub or internal)\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. \r\n Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\n<!-- Please provide any additional information if necessary -->\r\n\r\nInternal Issue (If applicable):\r\n<!-- Link to relevant internal issue if applicable. All PRs should be associated with an issue (GitHub issue or internal) -->\r\nhttps://nventive.visualstudio.com/Umbrella/_workitems/edit/138537/","created_at":"2018-12-06T22:02:36Z","updated_at":"2018-12-07T00:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"846837b551beac42fa6b4958eea8ccafcd495883","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeremiethibeault","id":5444226,"node_id":"MDQ6VXNlcjU0NDQyMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/5444226?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiethibeault","html_url":"https://github.com/jeremiethibeault","followers_url":"https://api.github.com/users/jeremiethibeault/followers","following_url":"https://api.github.com/users/jeremiethibeault/following{/other_user}","gists_url":"https://api.github.com/users/jeremiethibeault/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiethibeault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiethibeault/subscriptions","organizations_url":"https://api.github.com/users/jeremiethibeault/orgs","repos_url":"https://api.github.com/users/jeremiethibeault/repos","events_url":"https://api.github.com/users/jeremiethibeault/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiethibeault/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nventive/Uno/pulls/424/commits","review_comments_url":"https://api.github.com/repos/nventive/Uno/pulls/424/comments","review_comment_url":"https://api.github.com/repos/nventive/Uno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nventive/Uno/issues/424/comments","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/82fc4162ff8fe32224032f2c45153a4e112bc599","head":{"label":"nventive:dev/yogu/frozen","ref":"dev/yogu/frozen","sha":"82fc4162ff8fe32224032f2c45153a4e112bc599","user":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"Uno","full_name":"nventive/Uno","private":false,"owner":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nventive/Uno","description":"The Uno Platform, the UWP bridge for iOS, Android, and WebAssembly","fork":false,"url":"https://api.github.com/repos/nventive/Uno","forks_url":"https://api.github.com/repos/nventive/Uno/forks","keys_url":"https://api.github.com/repos/nventive/Uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nventive/Uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nventive/Uno/teams","hooks_url":"https://api.github.com/repos/nventive/Uno/hooks","issue_events_url":"https://api.github.com/repos/nventive/Uno/issues/events{/number}","events_url":"https://api.github.com/repos/nventive/Uno/events","assignees_url":"https://api.github.com/repos/nventive/Uno/assignees{/user}","branches_url":"https://api.github.com/repos/nventive/Uno/branches{/branch}","tags_url":"https://api.github.com/repos/nventive/Uno/tags","blobs_url":"https://api.github.com/repos/nventive/Uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nventive/Uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nventive/Uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/nventive/Uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/{sha}","languages_url":"https://api.github.com/repos/nventive/Uno/languages","stargazers_url":"https://api.github.com/repos/nventive/Uno/stargazers","contributors_url":"https://api.github.com/repos/nventive/Uno/contributors","subscribers_url":"https://api.github.com/repos/nventive/Uno/subscribers","subscription_url":"https://api.github.com/repos/nventive/Uno/subscription","commits_url":"https://api.github.com/repos/nventive/Uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/nventive/Uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/nventive/Uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/nventive/Uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/nventive/Uno/contents/{+path}","compare_url":"https://api.github.com/repos/nventive/Uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nventive/Uno/merges","archive_url":"https://api.github.com/repos/nventive/Uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nventive/Uno/downloads","issues_url":"https://api.github.com/repos/nventive/Uno/issues{/number}","pulls_url":"https://api.github.com/repos/nventive/Uno/pulls{/number}","milestones_url":"https://api.github.com/repos/nventive/Uno/milestones{/number}","notifications_url":"https://api.github.com/repos/nventive/Uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nventive/Uno/labels{/name}","releases_url":"https://api.github.com/repos/nventive/Uno/releases{/id}","deployments_url":"https://api.github.com/repos/nventive/Uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2018-12-06T22:07:57Z","pushed_at":"2018-12-06T22:07:57Z","git_url":"git://github.com/nventive/Uno.git","ssh_url":"git@github.com:nventive/Uno.git","clone_url":"https://github.com/nventive/Uno.git","svn_url":"https://github.com/nventive/Uno","homepage":"http://platform.uno/","size":18269,"stargazers_count":701,"watchers_count":701,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":127,"watchers":701,"default_branch":"master"}},"base":{"label":"nventive:master","ref":"master","sha":"835242faa30611241f3a5fcafe26af86d532477a","user":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"Uno","full_name":"nventive/Uno","private":false,"owner":{"login":"nventive","id":30845833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwODQ1ODMz","avatar_url":"https://avatars1.githubusercontent.com/u/30845833?v=4","gravatar_id":"","url":"https://api.github.com/users/nventive","html_url":"https://github.com/nventive","followers_url":"https://api.github.com/users/nventive/followers","following_url":"https://api.github.com/users/nventive/following{/other_user}","gists_url":"https://api.github.com/users/nventive/gists{/gist_id}","starred_url":"https://api.github.com/users/nventive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nventive/subscriptions","organizations_url":"https://api.github.com/users/nventive/orgs","repos_url":"https://api.github.com/users/nventive/repos","events_url":"https://api.github.com/users/nventive/events{/privacy}","received_events_url":"https://api.github.com/users/nventive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nventive/Uno","description":"The Uno Platform, the UWP bridge for iOS, Android, and WebAssembly","fork":false,"url":"https://api.github.com/repos/nventive/Uno","forks_url":"https://api.github.com/repos/nventive/Uno/forks","keys_url":"https://api.github.com/repos/nventive/Uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nventive/Uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nventive/Uno/teams","hooks_url":"https://api.github.com/repos/nventive/Uno/hooks","issue_events_url":"https://api.github.com/repos/nventive/Uno/issues/events{/number}","events_url":"https://api.github.com/repos/nventive/Uno/events","assignees_url":"https://api.github.com/repos/nventive/Uno/assignees{/user}","branches_url":"https://api.github.com/repos/nventive/Uno/branches{/branch}","tags_url":"https://api.github.com/repos/nventive/Uno/tags","blobs_url":"https://api.github.com/repos/nventive/Uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nventive/Uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nventive/Uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/nventive/Uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nventive/Uno/statuses/{sha}","languages_url":"https://api.github.com/repos/nventive/Uno/languages","stargazers_url":"https://api.github.com/repos/nventive/Uno/stargazers","contributors_url":"https://api.github.com/repos/nventive/Uno/contributors","subscribers_url":"https://api.github.com/repos/nventive/Uno/subscribers","subscription_url":"https://api.github.com/repos/nventive/Uno/subscription","commits_url":"https://api.github.com/repos/nventive/Uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/nventive/Uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/nventive/Uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/nventive/Uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/nventive/Uno/contents/{+path}","compare_url":"https://api.github.com/repos/nventive/Uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nventive/Uno/merges","archive_url":"https://api.github.com/repos/nventive/Uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nventive/Uno/downloads","issues_url":"https://api.github.com/repos/nventive/Uno/issues{/number}","pulls_url":"https://api.github.com/repos/nventive/Uno/pulls{/number}","milestones_url":"https://api.github.com/repos/nventive/Uno/milestones{/number}","notifications_url":"https://api.github.com/repos/nventive/Uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nventive/Uno/labels{/name}","releases_url":"https://api.github.com/repos/nventive/Uno/releases{/id}","deployments_url":"https://api.github.com/repos/nventive/Uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2018-12-06T22:07:57Z","pushed_at":"2018-12-06T22:07:57Z","git_url":"git://github.com/nventive/Uno.git","ssh_url":"git@github.com:nventive/Uno.git","clone_url":"https://github.com/nventive/Uno.git","svn_url":"https://github.com/nventive/Uno","homepage":"http://platform.uno/","size":18269,"stargazers_count":701,"watchers_count":701,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":127,"watchers":701,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nventive/Uno/pulls/424"},"html":{"href":"https://github.com/nventive/Uno/pull/424"},"issue":{"href":"https://api.github.com/repos/nventive/Uno/issues/424"},"comments":{"href":"https://api.github.com/repos/nventive/Uno/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/nventive/Uno/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/nventive/Uno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nventive/Uno/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/nventive/Uno/statuses/82fc4162ff8fe32224032f2c45153a4e112bc599"}},"author_association":"CONTRIBUTOR"}} | {
"id": 132453438,
"name": "nventive/Uno",
"url": "https://api.github.com/repos/nventive/Uno"
} | {
"id": 8270914,
"login": "davidjohnoliver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8270914?",
"url": "https://api.github.com/users/davidjohnoliver"
} | {
"id": 30845833,
"login": "nventive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30845833?",
"url": "https://api.github.com/orgs/nventive"
} | 2018-12-07T00:35:26 | 8713022522 | {"actor":{"display_login":"davidjohnoliver"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/comments/167353847","pull_request_review_id":95572165,"id":167353847,"diff_hunk":"@@ -4,14 +4,27 @@\n \n require 'conjur_client'\n \n+conjur_api = ConjurClient.api\n+\n begin\n- conjur_api = ConjurClient.api\n if ConjurClient.version == 5\n conjur_api.resources limit: 5\n else\n conjur_api.resource(\"#{ConjurClient.account}:user:admin\").exists?\n end\n+ \n puts \"Successfully validated Conjur credentials.\"\n rescue\n- raise \"Error: There is an issue with your Conjur configuration. Please verify that the credentials are correct and try again.\"\n+ raise \"Error: There is an issue with your Conjur configuration. Please verify\" \\\n+ \" that the credentials are correct and try again.\"\n+end\n+\n+if ConjurClient.version == 4\n+ hf_id = ConjurClient.v4_host_factory_id\n+ \n+ if !conjur_api.resource(URI::encode(hf_id, \"/\")).exists?\n+ raise \"Error: There is an issue with your Conjur configuration. Please\" \\\n+ \" verify that your Conjur policy contains a host factory named \" \\\n+ \"'#{hf_id.split(':')[-1]}' under the '#{ConjurClient.policy}' policy.\"","path":"bin/health-check.rb","position":27,"original_position":27,"commit_id":"8ea3ca426fc9fa35754922aa8564c49d2061e699","original_commit_id":"8ea3ca426fc9fa35754922aa8564c49d2061e699","user":{"login":"jtuttle","id":18331203,"avatar_url":"https://avatars3.githubusercontent.com/u/18331203?v=4","gravatar_id":"","url":"https://api.github.com/users/jtuttle","html_url":"https://github.com/jtuttle","followers_url":"https://api.github.com/users/jtuttle/followers","following_url":"https://api.github.com/users/jtuttle/following{/other_user}","gists_url":"https://api.github.com/users/jtuttle/gists{/gist_id}","starred_url":"https://api.github.com/users/jtuttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtuttle/subscriptions","organizations_url":"https://api.github.com/users/jtuttle/orgs","repos_url":"https://api.github.com/users/jtuttle/repos","events_url":"https://api.github.com/users/jtuttle/events{/privacy}","received_events_url":"https://api.github.com/users/jtuttle/received_events","type":"User","site_admin":false},"body":"Fixed\r\n\r\n```\r\nroot@cee6b32939da:/app# ./bin/health-check.rb\r\nSuccessfully validated Conjur credentials.\r\n./bin/health-check.rb:26:in `<main>': Error: There is an issue with your Conjur configuration. Please verify that your Conjur policy contains a host factory named 'pcf-apps' under the 'pcf' policy. (RuntimeError)\r\n```","created_at":"2018-02-09T21:44:44Z","updated_at":"2018-02-09T21:44:44Z","html_url":"https://github.com/cyberark/conjur-service-broker/pull/42#discussion_r167353847","pull_request_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/comments/167353847"},"html":{"href":"https://github.com/cyberark/conjur-service-broker/pull/42#discussion_r167353847"},"pull_request":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42"}},"in_reply_to_id":167335754},"pull_request":{"url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42","id":168323447,"html_url":"https://github.com/cyberark/conjur-service-broker/pull/42","diff_url":"https://github.com/cyberark/conjur-service-broker/pull/42.diff","patch_url":"https://github.com/cyberark/conjur-service-broker/pull/42.patch","issue_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/42","number":42,"state":"open","locked":false,"title":"Conj 4711 service broker has health check that verifies hf existence for v4","user":{"login":"jtuttle","id":18331203,"avatar_url":"https://avatars3.githubusercontent.com/u/18331203?v=4","gravatar_id":"","url":"https://api.github.com/users/jtuttle","html_url":"https://github.com/jtuttle","followers_url":"https://api.github.com/users/jtuttle/followers","following_url":"https://api.github.com/users/jtuttle/following{/other_user}","gists_url":"https://api.github.com/users/jtuttle/gists{/gist_id}","starred_url":"https://api.github.com/users/jtuttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtuttle/subscriptions","organizations_url":"https://api.github.com/users/jtuttle/orgs","repos_url":"https://api.github.com/users/jtuttle/repos","events_url":"https://api.github.com/users/jtuttle/events{/privacy}","received_events_url":"https://api.github.com/users/jtuttle/received_events","type":"User","site_admin":false},"body":"https://ca-il-jira.il.cyber-ark.com:8443/browse/CONJ-4711\r\n\r\nTested via `test.sh` script:\r\n\r\n```\r\nroot@b2f81d44f2f8:/app# ./bin/health-check.rb\r\nSuccessfully validated Conjur credentials.\r\n./bin/health-check.rb:26:in `<main>': Error: There is an issue with your Conjur configuration. Please verify that your Conjur policy contains a host factory named 'apps' under the 'root' policy. (RuntimeError)\r\n```","created_at":"2018-02-09T19:31:00Z","updated_at":"2018-02-09T21:44:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3a8208152f26faf48d3766b0ce93cfd602d9a98","assignee":{"login":"jtuttle","id":18331203,"avatar_url":"https://avatars3.githubusercontent.com/u/18331203?v=4","gravatar_id":"","url":"https://api.github.com/users/jtuttle","html_url":"https://github.com/jtuttle","followers_url":"https://api.github.com/users/jtuttle/followers","following_url":"https://api.github.com/users/jtuttle/following{/other_user}","gists_url":"https://api.github.com/users/jtuttle/gists{/gist_id}","starred_url":"https://api.github.com/users/jtuttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtuttle/subscriptions","organizations_url":"https://api.github.com/users/jtuttle/orgs","repos_url":"https://api.github.com/users/jtuttle/repos","events_url":"https://api.github.com/users/jtuttle/events{/privacy}","received_events_url":"https://api.github.com/users/jtuttle/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtuttle","id":18331203,"avatar_url":"https://avatars3.githubusercontent.com/u/18331203?v=4","gravatar_id":"","url":"https://api.github.com/users/jtuttle","html_url":"https://github.com/jtuttle","followers_url":"https://api.github.com/users/jtuttle/followers","following_url":"https://api.github.com/users/jtuttle/following{/other_user}","gists_url":"https://api.github.com/users/jtuttle/gists{/gist_id}","starred_url":"https://api.github.com/users/jtuttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtuttle/subscriptions","organizations_url":"https://api.github.com/users/jtuttle/orgs","repos_url":"https://api.github.com/users/jtuttle/repos","events_url":"https://api.github.com/users/jtuttle/events{/privacy}","received_events_url":"https://api.github.com/users/jtuttle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828822247,"url":"https://api.github.com/repos/cyberark/conjur-service-broker/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":828928129,"url":"https://api.github.com/repos/cyberark/conjur-service-broker/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42/commits","review_comments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42/comments","review_comment_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/42/comments","statuses_url":"https://api.github.com/repos/cyberark/conjur-service-broker/statuses/8ea3ca426fc9fa35754922aa8564c49d2061e699","head":{"label":"cyberark:CONJ-4711--service-broker-has-health-check-that-verifies-hf-existence-for-v4","ref":"CONJ-4711--service-broker-has-health-check-that-verifies-hf-existence-for-v4","sha":"8ea3ca426fc9fa35754922aa8564c49d2061e699","user":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":110738790,"name":"conjur-service-broker","full_name":"cyberark/conjur-service-broker","owner":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur-service-broker","description":"Implementation of the Open Service Broker API for Conjur","fork":false,"url":"https://api.github.com/repos/cyberark/conjur-service-broker","forks_url":"https://api.github.com/repos/cyberark/conjur-service-broker/forks","keys_url":"https://api.github.com/repos/cyberark/conjur-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur-service-broker/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur-service-broker/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur-service-broker/events","assignees_url":"https://api.github.com/repos/cyberark/conjur-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur-service-broker/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur-service-broker/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur-service-broker/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur-service-broker/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur-service-broker/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur-service-broker/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur-service-broker/merges","archive_url":"https://api.github.com/repos/cyberark/conjur-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur-service-broker/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/deployments","created_at":"2017-11-14T20:04:41Z","updated_at":"2018-01-29T16:58:20Z","pushed_at":"2018-02-09T19:31:00Z","git_url":"git://github.com/cyberark/conjur-service-broker.git","ssh_url":"git@github.com:cyberark/conjur-service-broker.git","clone_url":"https://github.com/cyberark/conjur-service-broker.git","svn_url":"https://github.com/cyberark/conjur-service-broker","homepage":null,"size":176,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"cyberark:master","ref":"master","sha":"779554e68cc2341194ff736566f08e3d02bfa27c","user":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"repo":{"id":110738790,"name":"conjur-service-broker","full_name":"cyberark/conjur-service-broker","owner":{"login":"cyberark","id":30869256,"avatar_url":"https://avatars3.githubusercontent.com/u/30869256?v=4","gravatar_id":"","url":"https://api.github.com/users/cyberark","html_url":"https://github.com/cyberark","followers_url":"https://api.github.com/users/cyberark/followers","following_url":"https://api.github.com/users/cyberark/following{/other_user}","gists_url":"https://api.github.com/users/cyberark/gists{/gist_id}","starred_url":"https://api.github.com/users/cyberark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyberark/subscriptions","organizations_url":"https://api.github.com/users/cyberark/orgs","repos_url":"https://api.github.com/users/cyberark/repos","events_url":"https://api.github.com/users/cyberark/events{/privacy}","received_events_url":"https://api.github.com/users/cyberark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyberark/conjur-service-broker","description":"Implementation of the Open Service Broker API for Conjur","fork":false,"url":"https://api.github.com/repos/cyberark/conjur-service-broker","forks_url":"https://api.github.com/repos/cyberark/conjur-service-broker/forks","keys_url":"https://api.github.com/repos/cyberark/conjur-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyberark/conjur-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyberark/conjur-service-broker/teams","hooks_url":"https://api.github.com/repos/cyberark/conjur-service-broker/hooks","issue_events_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/cyberark/conjur-service-broker/events","assignees_url":"https://api.github.com/repos/cyberark/conjur-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/cyberark/conjur-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/cyberark/conjur-service-broker/tags","blobs_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyberark/conjur-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/cyberark/conjur-service-broker/languages","stargazers_url":"https://api.github.com/repos/cyberark/conjur-service-broker/stargazers","contributors_url":"https://api.github.com/repos/cyberark/conjur-service-broker/contributors","subscribers_url":"https://api.github.com/repos/cyberark/conjur-service-broker/subscribers","subscription_url":"https://api.github.com/repos/cyberark/conjur-service-broker/subscription","commits_url":"https://api.github.com/repos/cyberark/conjur-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyberark/conjur-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyberark/conjur-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/cyberark/conjur-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyberark/conjur-service-broker/merges","archive_url":"https://api.github.com/repos/cyberark/conjur-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyberark/conjur-service-broker/downloads","issues_url":"https://api.github.com/repos/cyberark/conjur-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/cyberark/conjur-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/cyberark/conjur-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyberark/conjur-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/cyberark/conjur-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/cyberark/conjur-service-broker/deployments","created_at":"2017-11-14T20:04:41Z","updated_at":"2018-01-29T16:58:20Z","pushed_at":"2018-02-09T19:31:00Z","git_url":"git://github.com/cyberark/conjur-service-broker.git","ssh_url":"git@github.com:cyberark/conjur-service-broker.git","clone_url":"https://github.com/cyberark/conjur-service-broker.git","svn_url":"https://github.com/cyberark/conjur-service-broker","homepage":null,"size":176,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42"},"html":{"href":"https://github.com/cyberark/conjur-service-broker/pull/42"},"issue":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/42"},"comments":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/cyberark/conjur-service-broker/statuses/8ea3ca426fc9fa35754922aa8564c49d2061e699"}},"author_association":"MEMBER"}} | {
"id": 110738790,
"name": "cyberark/conjur-service-broker",
"url": "https://api.github.com/repos/cyberark/conjur-service-broker"
} | {
"id": 18331203,
"login": "jtuttle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18331203?",
"url": "https://api.github.com/users/jtuttle"
} | {
"id": 30869256,
"login": "cyberark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30869256?",
"url": "https://api.github.com/orgs/cyberark"
} | 2018-02-09T21:44:44 | 7225182219 | {"actor":{"display_login":"jtuttle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/comments/212818759","pull_request_review_id":149530965,"id":212818759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgxODc1OQ==","diff_hunk":"@@ -0,0 +1,148 @@\n+/*\n+ \n+ This Source Code Form is subject to the terms of the Mozilla Public\n+ License, v. 2.0. If a copy of the MPL was not distributed with this\n+ file, You can obtain one at http://mozilla.org/MPL/2.0/.\n+ \n+ Copyright (C) 2012 Michael Möller <mmoeller@openhardwaremonitor.org>\n+\t\n+*/\n+\n+using System;\n+using System.Diagnostics;\n+using System.Globalization;\n+using System.Net.NetworkInformation;\n+\n+namespace OpenHardwareMonitor.Hardware.Nic\n+{\n+ internal class Nic : Hardware\n+ {\n+ private ISettings settings;\n+ private Sensor connectionSpeed;\n+ private Sensor dataUploaded;\n+ private Sensor dataDownloaded;\n+ private Sensor uploadSpeed;\n+ private Sensor downloadSpeed;\n+ private Sensor networkUtilization;\n+ private Sensor totalDataDownloaded;\n+ private Sensor totalDataUploaded;\n+ private Sensor totalDataFlowed;\n+ private NetworkInterface nic;\n+ private int nicIndex;\n+ private DateTime latesTime;\n+ private DateTime presentBootTime;\n+\n+ private long bytesUploaded;\n+ private long bytesDownloaded;\n+ private long totalBytesDownloaded;\n+ private long totalBytesUploaded;\n+ private bool shouldTotalFlowUpdate = true;\n+\n+ public Nic(string name, ISettings Settings, int index, NicGroup nicGroup)\n+ : base(name, new Identifier(\"NIC\",index.ToString(CultureInfo.InvariantCulture)), Settings)\n+ {\n+ settings = Settings;\n+ nicIndex = index;\n+ nic = nicGroup.NicArr[index];\n+ totalBytesDownloaded = Convert.ToInt64(settings.GetValue(\"TotalDownloadedBeforeLastBoot\"+nic.Name, \"-1\"));","path":"Hardware/Nic/Nic.cs","position":47,"original_position":47,"commit_id":"01a54e6a06dc5d52827b82fb97371e42ac0de438","original_commit_id":"38023e7b348a89b82cdc444537efd6434f6622f1","user":{"login":"Phyxion","id":7643972,"node_id":"MDQ6VXNlcjc2NDM5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/7643972?v=4","gravatar_id":"","url":"https://api.github.com/users/Phyxion","html_url":"https://github.com/Phyxion","followers_url":"https://api.github.com/users/Phyxion/followers","following_url":"https://api.github.com/users/Phyxion/following{/other_user}","gists_url":"https://api.github.com/users/Phyxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Phyxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phyxion/subscriptions","organizations_url":"https://api.github.com/users/Phyxion/orgs","repos_url":"https://api.github.com/users/Phyxion/repos","events_url":"https://api.github.com/users/Phyxion/events{/privacy}","received_events_url":"https://api.github.com/users/Phyxion/received_events","type":"User","site_admin":false},"body":"No, settings is OK, but it's only used for custom names, not for storing the bytes like this here (which is rather pointless as it only monitors while OHM is running). I'll remove it 👍 ","created_at":"2018-08-26T08:28:28Z","updated_at":"2018-08-26T08:28:28Z","html_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52#discussion_r212818759","pull_request_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/comments/212818759"},"html":{"href":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52#discussion_r212818759"},"pull_request":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52"}},"in_reply_to_id":212793723},"pull_request":{"url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52","id":210875384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODc1Mzg0","html_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52","diff_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52.diff","patch_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52.patch","issue_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/52","number":52,"state":"open","locked":false,"title":"Add Network (NIC) support (updated)","user":{"login":"LORDofDOOM","id":562702,"node_id":"MDQ6VXNlcjU2MjcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/562702?v=4","gravatar_id":"","url":"https://api.github.com/users/LORDofDOOM","html_url":"https://github.com/LORDofDOOM","followers_url":"https://api.github.com/users/LORDofDOOM/followers","following_url":"https://api.github.com/users/LORDofDOOM/following{/other_user}","gists_url":"https://api.github.com/users/LORDofDOOM/gists{/gist_id}","starred_url":"https://api.github.com/users/LORDofDOOM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LORDofDOOM/subscriptions","organizations_url":"https://api.github.com/users/LORDofDOOM/orgs","repos_url":"https://api.github.com/users/LORDofDOOM/repos","events_url":"https://api.github.com/users/LORDofDOOM/events{/privacy}","received_events_url":"https://api.github.com/users/LORDofDOOM/received_events","type":"User","site_admin":false},"body":"Updated PR for https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/18","created_at":"2018-08-25T00:30:58Z","updated_at":"2018-08-26T08:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e7eaebe7006f174753b14db531205cd06dac912","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52/commits","review_comments_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52/comments","review_comment_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/52/comments","statuses_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/statuses/01a54e6a06dc5d52827b82fb97371e42ac0de438","head":{"label":"MachinaCore:nic_support","ref":"nic_support","sha":"01a54e6a06dc5d52827b82fb97371e42ac0de438","user":{"login":"MachinaCore","id":42019471,"node_id":"MDQ6VXNlcjQyMDE5NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/42019471?v=4","gravatar_id":"","url":"https://api.github.com/users/MachinaCore","html_url":"https://github.com/MachinaCore","followers_url":"https://api.github.com/users/MachinaCore/followers","following_url":"https://api.github.com/users/MachinaCore/following{/other_user}","gists_url":"https://api.github.com/users/MachinaCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MachinaCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachinaCore/subscriptions","organizations_url":"https://api.github.com/users/MachinaCore/orgs","repos_url":"https://api.github.com/users/MachinaCore/repos","events_url":"https://api.github.com/users/MachinaCore/events{/privacy}","received_events_url":"https://api.github.com/users/MachinaCore/received_events","type":"User","site_admin":false},"repo":{"id":146050966,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwNTA5NjY=","name":"LibreHardwareMonitor","full_name":"MachinaCore/LibreHardwareMonitor","owner":{"login":"MachinaCore","id":42019471,"node_id":"MDQ6VXNlcjQyMDE5NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/42019471?v=4","gravatar_id":"","url":"https://api.github.com/users/MachinaCore","html_url":"https://github.com/MachinaCore","followers_url":"https://api.github.com/users/MachinaCore/followers","following_url":"https://api.github.com/users/MachinaCore/following{/other_user}","gists_url":"https://api.github.com/users/MachinaCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MachinaCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MachinaCore/subscriptions","organizations_url":"https://api.github.com/users/MachinaCore/orgs","repos_url":"https://api.github.com/users/MachinaCore/repos","events_url":"https://api.github.com/users/MachinaCore/events{/privacy}","received_events_url":"https://api.github.com/users/MachinaCore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MachinaCore/LibreHardwareMonitor","description":"Libre Hardware Monitor, home of the fork of Open Hardware Monitor","fork":true,"url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor","forks_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/forks","keys_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/teams","hooks_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/hooks","issue_events_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/issues/events{/number}","events_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/events","assignees_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/assignees{/user}","branches_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/branches{/branch}","tags_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/tags","blobs_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/statuses/{sha}","languages_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/languages","stargazers_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/stargazers","contributors_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/contributors","subscribers_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/subscribers","subscription_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/subscription","commits_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/contents/{+path}","compare_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/merges","archive_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/downloads","issues_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/issues{/number}","pulls_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/pulls{/number}","milestones_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/milestones{/number}","notifications_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/labels{/name}","releases_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/releases{/id}","deployments_url":"https://api.github.com/repos/MachinaCore/LibreHardwareMonitor/deployments","created_at":"2018-08-25T00:14:52Z","updated_at":"2018-08-25T22:43:24Z","pushed_at":"2018-08-25T22:43:23Z","git_url":"git://github.com/MachinaCore/LibreHardwareMonitor.git","ssh_url":"git@github.com:MachinaCore/LibreHardwareMonitor.git","clone_url":"https://github.com/MachinaCore/LibreHardwareMonitor.git","svn_url":"https://github.com/MachinaCore/LibreHardwareMonitor","homepage":"","size":2154,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"nuget"}},"base":{"label":"LibreHardwareMonitor:master","ref":"master","sha":"f6d3338cda14de8477c735daa2fb7d1b3d526dc5","user":{"login":"LibreHardwareMonitor","id":30905571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTA1NTcx","avatar_url":"https://avatars1.githubusercontent.com/u/30905571?v=4","gravatar_id":"","url":"https://api.github.com/users/LibreHardwareMonitor","html_url":"https://github.com/LibreHardwareMonitor","followers_url":"https://api.github.com/users/LibreHardwareMonitor/followers","following_url":"https://api.github.com/users/LibreHardwareMonitor/following{/other_user}","gists_url":"https://api.github.com/users/LibreHardwareMonitor/gists{/gist_id}","starred_url":"https://api.github.com/users/LibreHardwareMonitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibreHardwareMonitor/subscriptions","organizations_url":"https://api.github.com/users/LibreHardwareMonitor/orgs","repos_url":"https://api.github.com/users/LibreHardwareMonitor/repos","events_url":"https://api.github.com/users/LibreHardwareMonitor/events{/privacy}","received_events_url":"https://api.github.com/users/LibreHardwareMonitor/received_events","type":"Organization","site_admin":false},"repo":{"id":99942769,"node_id":"MDEwOlJlcG9zaXRvcnk5OTk0Mjc2OQ==","name":"LibreHardwareMonitor","full_name":"LibreHardwareMonitor/LibreHardwareMonitor","owner":{"login":"LibreHardwareMonitor","id":30905571,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTA1NTcx","avatar_url":"https://avatars1.githubusercontent.com/u/30905571?v=4","gravatar_id":"","url":"https://api.github.com/users/LibreHardwareMonitor","html_url":"https://github.com/LibreHardwareMonitor","followers_url":"https://api.github.com/users/LibreHardwareMonitor/followers","following_url":"https://api.github.com/users/LibreHardwareMonitor/following{/other_user}","gists_url":"https://api.github.com/users/LibreHardwareMonitor/gists{/gist_id}","starred_url":"https://api.github.com/users/LibreHardwareMonitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibreHardwareMonitor/subscriptions","organizations_url":"https://api.github.com/users/LibreHardwareMonitor/orgs","repos_url":"https://api.github.com/users/LibreHardwareMonitor/repos","events_url":"https://api.github.com/users/LibreHardwareMonitor/events{/privacy}","received_events_url":"https://api.github.com/users/LibreHardwareMonitor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor","description":"Libre Hardware Monitor, home of the fork of Open Hardware Monitor","fork":true,"url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor","forks_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/forks","keys_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/teams","hooks_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/hooks","issue_events_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/events{/number}","events_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/events","assignees_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/assignees{/user}","branches_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/branches{/branch}","tags_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/tags","blobs_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/statuses/{sha}","languages_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/languages","stargazers_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/stargazers","contributors_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/contributors","subscribers_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/subscribers","subscription_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/subscription","commits_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/contents/{+path}","compare_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/merges","archive_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/downloads","issues_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues{/number}","pulls_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls{/number}","milestones_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/milestones{/number}","notifications_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/labels{/name}","releases_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/releases{/id}","deployments_url":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/deployments","created_at":"2017-08-10T16:19:30Z","updated_at":"2018-08-20T11:46:23Z","pushed_at":"2018-08-25T22:23:27Z","git_url":"git://github.com/LibreHardwareMonitor/LibreHardwareMonitor.git","ssh_url":"git@github.com:LibreHardwareMonitor/LibreHardwareMonitor.git","clone_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor.git","svn_url":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor","homepage":"","size":2129,"stargazers_count":53,"watchers_count":53,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":22,"open_issues":9,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52"},"html":{"href":"https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/52"},"issue":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/52"},"comments":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor/statuses/01a54e6a06dc5d52827b82fb97371e42ac0de438"}},"author_association":"NONE"}} | {
"id": 99942769,
"name": "LibreHardwareMonitor/LibreHardwareMonitor",
"url": "https://api.github.com/repos/LibreHardwareMonitor/LibreHardwareMonitor"
} | {
"id": 7643972,
"login": "Phyxion",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7643972?",
"url": "https://api.github.com/users/Phyxion"
} | {
"id": 30905571,
"login": "LibreHardwareMonitor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30905571?",
"url": "https://api.github.com/orgs/LibreHardwareMonitor"
} | 2018-08-26T08:28:28 | 8168026192 | {"actor":{"display_login":"Phyxion"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/comments/231320307","pull_request_review_id":172267316,"id":231320307,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTMyMDMwNw==","diff_hunk":"@@ -357,12 +341,12 @@ def get_bounties_guid_assertions(guid):\n @bounties.route('/<uuid:guid>/assertions/<int:id_>', methods=['GET'])\n @chain\n def get_bounties_guid_assertions_id(guid, id_):\n- bounty = bounty_to_dict(g.bounty_registry.functions.bountiesByGuid(guid.int).call())\n+ bounty = bounty_to_dict(g.chain.bounty_registry.contract.functions.bountiesByGuid(guid.int).call())\n if bounty['author'] == zero_address:\n return failure('Bounty not found', 404)\n \n try:\n- assertion = assertion_to_dict(g.bounty_registry.functions.assertionsByGuid(guid.int, id_).call(),\n+ assertion = assertion_to_dict(g.chain.bounty_registry.contract.functions.assertionsByGuid(guid.int, id_).call(),","path":"src/polyswarmd/bounties.py","position":225,"original_position":225,"commit_id":"8e5a09329d9dc26945a542d610ecca52cfb5ef96","original_commit_id":"8e5a09329d9dc26945a542d610ecca52cfb5ef96","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Similar blocks of code found in 2 locations. Consider refactoring.","created_at":"2018-11-06T22:37:23Z","updated_at":"2018-11-06T22:37:23Z","html_url":"https://github.com/polyswarm/polyswarmd/pull/121#discussion_r231320307","pull_request_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/comments/231320307"},"html":{"href":"https://github.com/polyswarm/polyswarmd/pull/121#discussion_r231320307"},"pull_request":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121","id":228855761,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODU1NzYx","html_url":"https://github.com/polyswarm/polyswarmd/pull/121","diff_url":"https://github.com/polyswarm/polyswarmd/pull/121.diff","patch_url":"https://github.com/polyswarm/polyswarmd/pull/121.patch","issue_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/121","number":121,"state":"open","locked":false,"title":"Feature/status route","user":{"login":"mjkoo","id":30420,"node_id":"MDQ6VXNlcjMwNDIw","avatar_url":"https://avatars3.githubusercontent.com/u/30420?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkoo","html_url":"https://github.com/mjkoo","followers_url":"https://api.github.com/users/mjkoo/followers","following_url":"https://api.github.com/users/mjkoo/following{/other_user}","gists_url":"https://api.github.com/users/mjkoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkoo/subscriptions","organizations_url":"https://api.github.com/users/mjkoo/orgs","repos_url":"https://api.github.com/users/mjkoo/repos","events_url":"https://api.github.com/users/mjkoo/events{/privacy}","received_events_url":"https://api.github.com/users/mjkoo/received_events","type":"User","site_admin":false},"body":"Depends on #118 being merged first, addresses #104 ","created_at":"2018-11-06T22:25:47Z","updated_at":"2018-11-06T22:37:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ed6788c3aa9b372a94356ea78ad83cdcb6cdf5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121/commits","review_comments_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121/comments","review_comment_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/121/comments","statuses_url":"https://api.github.com/repos/polyswarm/polyswarmd/statuses/8e5a09329d9dc26945a542d610ecca52cfb5ef96","head":{"label":"polyswarm:feature/status-route","ref":"feature/status-route","sha":"8e5a09329d9dc26945a542d610ecca52cfb5ef96","user":{"login":"polyswarm","id":31043802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDQzODAy","avatar_url":"https://avatars0.githubusercontent.com/u/31043802?v=4","gravatar_id":"","url":"https://api.github.com/users/polyswarm","html_url":"https://github.com/polyswarm","followers_url":"https://api.github.com/users/polyswarm/followers","following_url":"https://api.github.com/users/polyswarm/following{/other_user}","gists_url":"https://api.github.com/users/polyswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/polyswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polyswarm/subscriptions","organizations_url":"https://api.github.com/users/polyswarm/orgs","repos_url":"https://api.github.com/users/polyswarm/repos","events_url":"https://api.github.com/users/polyswarm/events{/privacy}","received_events_url":"https://api.github.com/users/polyswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":126096752,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwOTY3NTI=","name":"polyswarmd","full_name":"polyswarm/polyswarmd","private":false,"owner":{"login":"polyswarm","id":31043802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDQzODAy","avatar_url":"https://avatars0.githubusercontent.com/u/31043802?v=4","gravatar_id":"","url":"https://api.github.com/users/polyswarm","html_url":"https://github.com/polyswarm","followers_url":"https://api.github.com/users/polyswarm/followers","following_url":"https://api.github.com/users/polyswarm/following{/other_user}","gists_url":"https://api.github.com/users/polyswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/polyswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polyswarm/subscriptions","organizations_url":"https://api.github.com/users/polyswarm/orgs","repos_url":"https://api.github.com/users/polyswarm/repos","events_url":"https://api.github.com/users/polyswarm/events{/privacy}","received_events_url":"https://api.github.com/users/polyswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/polyswarm/polyswarmd","description":"daemon for PolySwarm, the first decentralized threat intelligence market.","fork":false,"url":"https://api.github.com/repos/polyswarm/polyswarmd","forks_url":"https://api.github.com/repos/polyswarm/polyswarmd/forks","keys_url":"https://api.github.com/repos/polyswarm/polyswarmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polyswarm/polyswarmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polyswarm/polyswarmd/teams","hooks_url":"https://api.github.com/repos/polyswarm/polyswarmd/hooks","issue_events_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/events{/number}","events_url":"https://api.github.com/repos/polyswarm/polyswarmd/events","assignees_url":"https://api.github.com/repos/polyswarm/polyswarmd/assignees{/user}","branches_url":"https://api.github.com/repos/polyswarm/polyswarmd/branches{/branch}","tags_url":"https://api.github.com/repos/polyswarm/polyswarmd/tags","blobs_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polyswarm/polyswarmd/statuses/{sha}","languages_url":"https://api.github.com/repos/polyswarm/polyswarmd/languages","stargazers_url":"https://api.github.com/repos/polyswarm/polyswarmd/stargazers","contributors_url":"https://api.github.com/repos/polyswarm/polyswarmd/contributors","subscribers_url":"https://api.github.com/repos/polyswarm/polyswarmd/subscribers","subscription_url":"https://api.github.com/repos/polyswarm/polyswarmd/subscription","commits_url":"https://api.github.com/repos/polyswarm/polyswarmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/polyswarm/polyswarmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/polyswarm/polyswarmd/contents/{+path}","compare_url":"https://api.github.com/repos/polyswarm/polyswarmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polyswarm/polyswarmd/merges","archive_url":"https://api.github.com/repos/polyswarm/polyswarmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polyswarm/polyswarmd/downloads","issues_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues{/number}","pulls_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls{/number}","milestones_url":"https://api.github.com/repos/polyswarm/polyswarmd/milestones{/number}","notifications_url":"https://api.github.com/repos/polyswarm/polyswarmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polyswarm/polyswarmd/labels{/name}","releases_url":"https://api.github.com/repos/polyswarm/polyswarmd/releases{/id}","deployments_url":"https://api.github.com/repos/polyswarm/polyswarmd/deployments","created_at":"2018-03-20T23:40:21Z","updated_at":"2018-11-06T18:04:32Z","pushed_at":"2018-11-06T22:36:58Z","git_url":"git://github.com/polyswarm/polyswarmd.git","ssh_url":"git@github.com:polyswarm/polyswarmd.git","clone_url":"https://github.com/polyswarm/polyswarmd.git","svn_url":"https://github.com/polyswarm/polyswarmd","homepage":"https://polyswarm.io","size":683,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":34,"watchers":10,"default_branch":"master"}},"base":{"label":"polyswarm:master","ref":"master","sha":"3dedfff604a56dce7a4f2bfcab9f3fab46858e19","user":{"login":"polyswarm","id":31043802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDQzODAy","avatar_url":"https://avatars0.githubusercontent.com/u/31043802?v=4","gravatar_id":"","url":"https://api.github.com/users/polyswarm","html_url":"https://github.com/polyswarm","followers_url":"https://api.github.com/users/polyswarm/followers","following_url":"https://api.github.com/users/polyswarm/following{/other_user}","gists_url":"https://api.github.com/users/polyswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/polyswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polyswarm/subscriptions","organizations_url":"https://api.github.com/users/polyswarm/orgs","repos_url":"https://api.github.com/users/polyswarm/repos","events_url":"https://api.github.com/users/polyswarm/events{/privacy}","received_events_url":"https://api.github.com/users/polyswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":126096752,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwOTY3NTI=","name":"polyswarmd","full_name":"polyswarm/polyswarmd","private":false,"owner":{"login":"polyswarm","id":31043802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDQzODAy","avatar_url":"https://avatars0.githubusercontent.com/u/31043802?v=4","gravatar_id":"","url":"https://api.github.com/users/polyswarm","html_url":"https://github.com/polyswarm","followers_url":"https://api.github.com/users/polyswarm/followers","following_url":"https://api.github.com/users/polyswarm/following{/other_user}","gists_url":"https://api.github.com/users/polyswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/polyswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polyswarm/subscriptions","organizations_url":"https://api.github.com/users/polyswarm/orgs","repos_url":"https://api.github.com/users/polyswarm/repos","events_url":"https://api.github.com/users/polyswarm/events{/privacy}","received_events_url":"https://api.github.com/users/polyswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/polyswarm/polyswarmd","description":"daemon for PolySwarm, the first decentralized threat intelligence market.","fork":false,"url":"https://api.github.com/repos/polyswarm/polyswarmd","forks_url":"https://api.github.com/repos/polyswarm/polyswarmd/forks","keys_url":"https://api.github.com/repos/polyswarm/polyswarmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polyswarm/polyswarmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polyswarm/polyswarmd/teams","hooks_url":"https://api.github.com/repos/polyswarm/polyswarmd/hooks","issue_events_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/events{/number}","events_url":"https://api.github.com/repos/polyswarm/polyswarmd/events","assignees_url":"https://api.github.com/repos/polyswarm/polyswarmd/assignees{/user}","branches_url":"https://api.github.com/repos/polyswarm/polyswarmd/branches{/branch}","tags_url":"https://api.github.com/repos/polyswarm/polyswarmd/tags","blobs_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polyswarm/polyswarmd/statuses/{sha}","languages_url":"https://api.github.com/repos/polyswarm/polyswarmd/languages","stargazers_url":"https://api.github.com/repos/polyswarm/polyswarmd/stargazers","contributors_url":"https://api.github.com/repos/polyswarm/polyswarmd/contributors","subscribers_url":"https://api.github.com/repos/polyswarm/polyswarmd/subscribers","subscription_url":"https://api.github.com/repos/polyswarm/polyswarmd/subscription","commits_url":"https://api.github.com/repos/polyswarm/polyswarmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/polyswarm/polyswarmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/polyswarm/polyswarmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/polyswarm/polyswarmd/contents/{+path}","compare_url":"https://api.github.com/repos/polyswarm/polyswarmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polyswarm/polyswarmd/merges","archive_url":"https://api.github.com/repos/polyswarm/polyswarmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polyswarm/polyswarmd/downloads","issues_url":"https://api.github.com/repos/polyswarm/polyswarmd/issues{/number}","pulls_url":"https://api.github.com/repos/polyswarm/polyswarmd/pulls{/number}","milestones_url":"https://api.github.com/repos/polyswarm/polyswarmd/milestones{/number}","notifications_url":"https://api.github.com/repos/polyswarm/polyswarmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polyswarm/polyswarmd/labels{/name}","releases_url":"https://api.github.com/repos/polyswarm/polyswarmd/releases{/id}","deployments_url":"https://api.github.com/repos/polyswarm/polyswarmd/deployments","created_at":"2018-03-20T23:40:21Z","updated_at":"2018-11-06T18:04:32Z","pushed_at":"2018-11-06T22:36:58Z","git_url":"git://github.com/polyswarm/polyswarmd.git","ssh_url":"git@github.com:polyswarm/polyswarmd.git","clone_url":"https://github.com/polyswarm/polyswarmd.git","svn_url":"https://github.com/polyswarm/polyswarmd","homepage":"https://polyswarm.io","size":683,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":34,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121"},"html":{"href":"https://github.com/polyswarm/polyswarmd/pull/121"},"issue":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/issues/121"},"comments":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/polyswarm/polyswarmd/statuses/8e5a09329d9dc26945a542d610ecca52cfb5ef96"}},"author_association":"MEMBER"}} | {
"id": 126096752,
"name": "polyswarm/polyswarmd",
"url": "https://api.github.com/repos/polyswarm/polyswarmd"
} | {
"id": 36754821,
"login": "codeclimate[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36754821?",
"url": "https://api.github.com/users/codeclimate[bot]"
} | {
"id": 31043802,
"login": "polyswarm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31043802?",
"url": "https://api.github.com/orgs/polyswarm"
} | 2018-11-06T22:37:23 | 8546043953 | {"actor":{"display_login":"codeclimate"}} |
Subsets and Splits